commit 1fc77f2b3e648d6b9b36f7976828a7359a929f24
author Ralph Nathan <ralphnathan@chromium.org> Tue Apr 21 15:05:48 2015 -0700
committer ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Fri May 08 19:33:14 2015 +0000
tree f155dc8f51473785f199da5e44c91b79f3e660a6
parent d99f622f0ec1ebc6026353f2a4989aa82cbfb4e2

scripts/cros: Change the default log level for brillo commands.

Change the default log level of brillo commands to notice instead of
info. Cros commands still operate at logging level info.

BUG=brillo:888
TEST=unittest + manual test
CQ-DEPEND=CL:269510, CL:269832

Change-Id: I9a9b1e8bd99f0a2681b826dc95734ae07e47333f
Reviewed-on: https://chromium-review.googlesource.com/266740
Reviewed-by: David Pursell <dpursell@chromium.org>
Commit-Queue: Ralph Nathan <ralphnathan@chromium.org>
Trybot-Ready: Ralph Nathan <ralphnathan@chromium.org>
Tested-by: Ralph Nathan <ralphnathan@chromium.org>

scripts/cros_unittest.py

diff --git a/scripts/cros_unittest.py b/scripts/cros_unittest.py
index c881539..421db9c 100644
--- a/scripts/cros_unittest.py
+++ b/scripts/cros_unittest.py
@@ -7,6 +7,7 @@
 from __future__ import print_function
 
 from chromite.cli import command
+from chromite.lib import commandline
 from chromite.lib import cros_test_lib
 from chromite.lib import stats
 from chromite.lib import stats_unittest
@@ -21,7 +22,9 @@
     self.StartPatcher(self.stats_module_mock)
     self.PatchObject(cros, '_RunSubCommand', autospec=True)
     # Use the `cros` toolset for these tests.
-    self.PatchObject(command, '_GetToolset', autospec=True, return_value='cros')
+    self.get_toolset_mock = self.PatchObject(command, 'GetToolset',
+                                             autospec=True)
+    self.get_toolset_mock.return_value = 'cros'
 
   def testStatsUpload(self, upload_count=1, return_value=0):
     """Test stats uploading."""
@@ -36,3 +39,18 @@
     self.stats_module_mock.stats_mock.init_exception = True
     with cros_test_lib.LoggingCapturer():
       self.testStatsUpload(upload_count=0)
+
+  def testDefaultLogLevelBrillo(self):
+    """Test that the default log level is notice for brillo tools."""
+    self.get_toolset_mock.return_value = 'brillo'
+    arg_parser = self.PatchObject(commandline, 'ArgumentParser',
+                                  return_value=commandline.ArgumentParser())
+    cros.GetOptions({})
+    arg_parser.assert_called_with(caching=True, default_log_level='notice')
+
+  def testDefaultLogLevelCros(self):
+    """Test that the default log level is not set to notice for cros tools."""
+    arg_parser = self.PatchObject(commandline, 'ArgumentParser',
+                                  return_value=commandline.ArgumentParser())
+    cros.GetOptions({})
+    arg_parser.assert_called_with(caching=True)