Formatting: Format all python code with black.
This CL is probably not what you're looking for, it's only
automated formatting. Ignore it with
`git blame --ignore-rev <revision>` for this commit.
BUG=b:233893248
TEST=CQ
Change-Id: I66591d7a738d241aed3290138c0f68065ab10a6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/3879174
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Tested-by: Alex Klein <saklein@chromium.org>
diff --git a/api/metrics_unittest.py b/api/metrics_unittest.py
index 9530213..c3378a9 100644
--- a/api/metrics_unittest.py
+++ b/api/metrics_unittest.py
@@ -13,78 +13,95 @@
class MetricsTest(cros_test_lib.TestCase):
- """Test Metrics deserialization functionality at the API layer."""
+ """Test Metrics deserialization functionality at the API layer."""
- def testDeserializeTimer(self):
- """Test timer math and deserialization into proto objects."""
- response = build_api_test_pb2.TestResultMessage()
- mock_events = [
- metrics_lib.MetricEvent(
- 600, 'a.b', metrics_lib.OP_START_TIMER, arg='100'),
- metrics_lib.MetricEvent(
- 1000, 'a.b', metrics_lib.OP_STOP_TIMER, arg='100'),
- ]
- with mock.patch(
- 'chromite.api.metrics.metrics_lib.read_metrics_events',
- return_value=mock_events):
- api_metrics.deserialize_metrics_log(response.events)
- self.assertEqual(len(response.events), 1)
- self.assertEqual(response.events[0].name, 'a.b')
- self.assertEqual(response.events[0].timestamp_milliseconds, 1000)
- self.assertEqual(response.events[0].duration_milliseconds, 1000 - 600)
+ def testDeserializeTimer(self):
+ """Test timer math and deserialization into proto objects."""
+ response = build_api_test_pb2.TestResultMessage()
+ mock_events = [
+ metrics_lib.MetricEvent(
+ 600, "a.b", metrics_lib.OP_START_TIMER, arg="100"
+ ),
+ metrics_lib.MetricEvent(
+ 1000, "a.b", metrics_lib.OP_STOP_TIMER, arg="100"
+ ),
+ ]
+ with mock.patch(
+ "chromite.api.metrics.metrics_lib.read_metrics_events",
+ return_value=mock_events,
+ ):
+ api_metrics.deserialize_metrics_log(response.events)
+ self.assertEqual(len(response.events), 1)
+ self.assertEqual(response.events[0].name, "a.b")
+ self.assertEqual(response.events[0].timestamp_milliseconds, 1000)
+ self.assertEqual(
+ response.events[0].duration_milliseconds, 1000 - 600
+ )
- def testDeserializeNamedEvent(self):
- """Test deserialization of a named event.
+ def testDeserializeNamedEvent(self):
+ """Test deserialization of a named event.
- This test also includes a prefix to test for proper prepending.
- """
- response = build_api_test_pb2.TestResultMessage()
- mock_events = [
- metrics_lib.MetricEvent(
- 1000, 'a.named_event', metrics_lib.OP_NAMED_EVENT, arg=None),
- ]
- with mock.patch(
- 'chromite.api.metrics.metrics_lib.read_metrics_events',
- return_value=mock_events):
- api_metrics.deserialize_metrics_log(response.events, prefix='prefix')
- self.assertEqual(len(response.events), 1)
- self.assertEqual(response.events[0].name, 'prefix.a.named_event')
- self.assertEqual(response.events[0].timestamp_milliseconds, 1000)
- self.assertFalse(response.events[0].duration_milliseconds)
+ This test also includes a prefix to test for proper prepending.
+ """
+ response = build_api_test_pb2.TestResultMessage()
+ mock_events = [
+ metrics_lib.MetricEvent(
+ 1000, "a.named_event", metrics_lib.OP_NAMED_EVENT, arg=None
+ ),
+ ]
+ with mock.patch(
+ "chromite.api.metrics.metrics_lib.read_metrics_events",
+ return_value=mock_events,
+ ):
+ api_metrics.deserialize_metrics_log(
+ response.events, prefix="prefix"
+ )
+ self.assertEqual(len(response.events), 1)
+ self.assertEqual(response.events[0].name, "prefix.a.named_event")
+ self.assertEqual(response.events[0].timestamp_milliseconds, 1000)
+ self.assertFalse(response.events[0].duration_milliseconds)
- def testDeserializeGauge(self):
- """Test deserialization of a gauge."""
- response = build_api_test_pb2.TestResultMessage()
- mock_events = [
- metrics_lib.MetricEvent(1000, 'a.gauge', metrics_lib.OP_GAUGE, arg=17),
- ]
- with mock.patch(
- 'chromite.api.metrics.metrics_lib.read_metrics_events',
- return_value=mock_events):
- api_metrics.deserialize_metrics_log(response.events)
- self.assertEqual(len(response.events), 1)
- self.assertEqual(response.events[0].name, 'a.gauge')
- self.assertEqual(response.events[0].timestamp_milliseconds, 1000)
- self.assertEqual(response.events[0].gauge, 17)
+ def testDeserializeGauge(self):
+ """Test deserialization of a gauge."""
+ response = build_api_test_pb2.TestResultMessage()
+ mock_events = [
+ metrics_lib.MetricEvent(
+ 1000, "a.gauge", metrics_lib.OP_GAUGE, arg=17
+ ),
+ ]
+ with mock.patch(
+ "chromite.api.metrics.metrics_lib.read_metrics_events",
+ return_value=mock_events,
+ ):
+ api_metrics.deserialize_metrics_log(response.events)
+ self.assertEqual(len(response.events), 1)
+ self.assertEqual(response.events[0].name, "a.gauge")
+ self.assertEqual(response.events[0].timestamp_milliseconds, 1000)
+ self.assertEqual(response.events[0].gauge, 17)
- def testDeserializeCounter(self):
- """Test deserialization of a counter."""
- response = build_api_test_pb2.TestResultMessage()
- mock_events = [
- metrics_lib.MetricEvent(
- 1000, 'a.counter', metrics_lib.OP_INCREMENT_COUNTER, arg=1),
- metrics_lib.MetricEvent(
- 1001, 'a.counter', metrics_lib.OP_INCREMENT_COUNTER, arg=2),
- metrics_lib.MetricEvent(
- 1002, 'a.counter', metrics_lib.OP_INCREMENT_COUNTER, arg=3),
- metrics_lib.MetricEvent(
- 1003, 'a.counter', metrics_lib.OP_DECREMENT_COUNTER, arg=4),
- ]
- with mock.patch(
- 'chromite.api.metrics.metrics_lib.read_metrics_events',
- return_value=mock_events):
- api_metrics.deserialize_metrics_log(response.events)
- self.assertEqual(len(response.events), 1)
- self.assertEqual(response.events[0].name, 'a.counter')
- self.assertEqual(response.events[0].timestamp_milliseconds, 1003)
- self.assertEqual(response.events[0].gauge, 2)
+ def testDeserializeCounter(self):
+ """Test deserialization of a counter."""
+ response = build_api_test_pb2.TestResultMessage()
+ mock_events = [
+ metrics_lib.MetricEvent(
+ 1000, "a.counter", metrics_lib.OP_INCREMENT_COUNTER, arg=1
+ ),
+ metrics_lib.MetricEvent(
+ 1001, "a.counter", metrics_lib.OP_INCREMENT_COUNTER, arg=2
+ ),
+ metrics_lib.MetricEvent(
+ 1002, "a.counter", metrics_lib.OP_INCREMENT_COUNTER, arg=3
+ ),
+ metrics_lib.MetricEvent(
+ 1003, "a.counter", metrics_lib.OP_DECREMENT_COUNTER, arg=4
+ ),
+ ]
+ with mock.patch(
+ "chromite.api.metrics.metrics_lib.read_metrics_events",
+ return_value=mock_events,
+ ):
+ api_metrics.deserialize_metrics_log(response.events)
+ self.assertEqual(len(response.events), 1)
+ self.assertEqual(response.events[0].name, "a.counter")
+ self.assertEqual(response.events[0].timestamp_milliseconds, 1003)
+ self.assertEqual(response.events[0].gauge, 2)