commit 112b67c146c1baca171f706cb53df642d64cc36e
author Mike Frysinger <vapier@chromium.org> Mon Aug 08 00:52:10 2022 -0400
committer Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Aug 10 11:45:48 2022 +0000
tree 337550bc526e778b76e68f2c9ea3bad594015189
parent 8240befaa5bcd58b123d1a4648c719f743fd92d7

cros_build_lib: convert CommandResult to CompletedProcess

Since CommandResult is just CompletedProcess at this point, switch
away from that to better match subprocess APIs.

BUG=b:187789262
TEST=CQ passes

Change-Id: I888ef8c27d8a57b6461deade4ff57846c6e8b04e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/3818209
Tested-by: Mike Frysinger <vapier@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Alex Klein <saklein@chromium.org>

api/controller/test_unittest.py

diff --git a/api/controller/test_unittest.py b/api/controller/test_unittest.py
index d8e0e0c..17cbf2b 100644
--- a/api/controller/test_unittest.py
+++ b/api/controller/test_unittest.py
@@ -391,7 +391,7 @@
     patch = self.PatchObject(
         cros_build_lib,
         'run',
-        return_value=cros_build_lib.CommandResult(returncode=1))
+        return_value=cros_build_lib.CompletedProcess(returncode=1))
 
     response = test_pb2.BuildTestServiceContainersResponse()
     test_controller.BuildTestServiceContainers(self.request, response,
@@ -454,7 +454,7 @@
     patch = self.PatchObject(
         cros_build_lib,
         'run',
-        return_value=cros_build_lib.CommandResult(returncode=0))
+        return_value=cros_build_lib.CompletedProcess(returncode=0))
 
     test_controller.ChromiteUnitTest(request, self._GetOutput(),
                                      self.api_config)
@@ -494,7 +494,7 @@
     patch = self.PatchObject(
         cros_build_lib,
         'run',
-        return_value=cros_build_lib.CommandResult(returncode=0))
+        return_value=cros_build_lib.CompletedProcess(returncode=0))
 
     test_controller.CrosSigningTest(request, self._GetOutput(), self.api_config)
     patch.assert_called_once()
@@ -704,7 +704,7 @@
     patch = self.PatchObject(
         cros_build_lib,
         'run',
-        return_value=cros_build_lib.CommandResult(returncode=0))
+        return_value=cros_build_lib.CompletedProcess(returncode=0))
 
     test_controller.VmTest(request, response, self.api_config)
     patch.assert_called()