commit 112b67c146c1baca171f706cb53df642d64cc36e
author Mike Frysinger <vapier@chromium.org> Mon Aug 08 00:52:10 2022 -0400
committer Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Aug 10 11:45:48 2022 +0000
tree 337550bc526e778b76e68f2c9ea3bad594015189
parent 8240befaa5bcd58b123d1a4648c719f743fd92d7

cros_build_lib: convert CommandResult to CompletedProcess

Since CommandResult is just CompletedProcess at this point, switch
away from that to better match subprocess APIs.

BUG=b:187789262
TEST=CQ passes

Change-Id: I888ef8c27d8a57b6461deade4ff57846c6e8b04e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/3818209
Tested-by: Mike Frysinger <vapier@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Alex Klein <saklein@chromium.org>

api/controller/sysroot_unittest.py

diff --git a/api/controller/sysroot_unittest.py b/api/controller/sysroot_unittest.py
index 37c1253..d41372b 100644
--- a/api/controller/sysroot_unittest.py
+++ b/api/controller/sysroot_unittest.py
@@ -411,7 +411,7 @@
           datetime.datetime(2021, 6, 9, 16, 20, 0))
 
     err = sysroot_lib.ToolchainInstallError(
-        'Error', cros_build_lib.CommandResult(), tc_info=err_cpvs)
+        'Error', cros_build_lib.CompletedProcess(), tc_info=err_cpvs)
     self.PatchObject(sysroot_service, 'InstallToolchain', side_effect=err)
 
     rc = sysroot_controller.InstallToolchain(in_proto, out_proto,
@@ -810,7 +810,7 @@
           datetime.datetime(2021, 6, 9, 16, 20, 0))
     # Force error to be raised with the packages.
     error = sysroot_lib.PackageInstallError(
-        'Error', cros_build_lib.CommandResult(), packages=err_cpvs)
+        'Error', cros_build_lib.CompletedProcess(), packages=err_cpvs)
     self.PatchObject(sysroot_service, 'BuildPackages', side_effect=error)
 
     rc = sysroot_controller.InstallPackages(in_proto, out_proto,
@@ -835,7 +835,7 @@
 
     # Force error to be raised with no packages.
     error = sysroot_lib.PackageInstallError(
-        'Error', cros_build_lib.CommandResult(), packages=[])
+        'Error', cros_build_lib.CompletedProcess(), packages=[])
     self.PatchObject(sysroot_service, 'BuildPackages', side_effect=error)
 
     rc = sysroot_controller.InstallPackages(in_proto, out_proto,