upload_prebuilts: change datestamp format
I find the US date format to be ugly and ambiguous. It also makes sorting
a huge pita. So let's fix it.
Using this date as an example:
Thu Dec 13 07:16:07 UTC 2012
The old code would produce:
13.12.12.071607
The new code produces:
2012.12.13.071607
The reason for using %Y over %y is to avoid possible collisions.
In the old format: 13 Dec 2012 00:00:00 -> 13.12.12.000000
In the new format: 12 Dec 2013 00:00:00 -> 13.12.12.000000
Using a 4 digit date avoids that issue.
This shouldn't cause a problem in practice as anytime this version string
has appeared, it's been dumped into a variable as an opaque blob. That
means no code is parsing it to figure out the date or to infer path info
from it. Replacing one arbitrary string with another makes no difference
to that code.
As an example, this is being used in binhost URLs:
$ cd src/third_party/chromiumos-overlay/chromeos/binhost/host/
$ grep . *.conf
amd64-LATEST_RELEASE_CHROME_BINHOST.conf:LATEST_RELEASE_CHROME_BINHOST=http://commondatastorage.googleapis.com/chromeos-prebuilt/host/amd64/chrome-27.05.11.033811/packages/
amd64-TOT_CHROME_BINHOST.conf:TOT_CHROME_BINHOST="http://commondatastorage.googleapis.com/chromeos-prebuilt/host/amd64/chrome-26.05.11.214444/packages/"
sdk_version.conf:SDK_LATEST_VERSION="12.12.12.180828"
sdk_version.conf:BOOTSTRAP_LATEST_VERSION="2010.03.09"
Other code simply takes those values as-is and plugs them in to other
places. Changing it should be safe.
BUG=None
TEST=buildbot/run_tests passes
Change-Id: I7dc4269a89ac7a0d5e984ef7a5be5d12b7430e1c
Reviewed-on: https://gerrit.chromium.org/gerrit/39642
Reviewed-by: Peter Mayo <petermayo@chromium.org>
Reviewed-by: Brian Harring <ferringb@chromium.org>
Reviewed-by: David James <davidjames@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
diff --git a/scripts/upload_prebuilts.py b/scripts/upload_prebuilts.py
index d3e82d5..3cf711a 100644
--- a/scripts/upload_prebuilts.py
+++ b/scripts/upload_prebuilts.py
@@ -156,7 +156,7 @@
def GetVersion():
"""Get the version to put in LATEST and update the git version with."""
- return datetime.datetime.now().strftime('%d.%m.%y.%H%M%S')
+ return datetime.datetime.now().strftime('%Y.%m.%d.%H%M%S')
def _GsUpload(local_file, remote_file, acl):