commit 0aecf47200582d8fde4ba928b9ea010b03642d18
author Alex Klein <saklein@chromium.org> Mon May 23 10:48:45 2022 -0600
committer Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu May 26 02:10:41 2022 +0000
tree d16251575f10d52481b6a822b904c5528d405efb
parent 57b7b2fd21551978988a711130bd7b1de07f35a5

api: test: Finish dropping BuildTargetUnitTest unit_tests.tar support

Drop remnants of support for generating unit_tests.tar in the
TestService/BuildTargetUnitTest endpoint.

BUG=b:217211026
TEST=run_tests

Change-Id: I33975a1df8050b983d9c935d7feb679c1f1b422d
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/3661369
Tested-by: Alex Klein <saklein@chromium.org>
Commit-Queue: Alex Klein <saklein@chromium.org>
Reviewed-by: Lizzy Presland <zland@google.com>

api/controller/test_unittest.py

diff --git a/api/controller/test_unittest.py b/api/controller/test_unittest.py
index 0fcb715..8d5feb7 100644
--- a/api/controller/test_unittest.py
+++ b/api/controller/test_unittest.py
@@ -7,7 +7,6 @@
 import contextlib
 import datetime
 import os
-from pathlib import Path
 from typing import Union
 from unittest import mock
 
@@ -116,7 +115,6 @@
 
   def _GetInput(self,
                 board=None,
-                result_path=None,
                 chroot_path=None,
                 cache_dir=None,
                 empty_sysroot=None,
@@ -136,13 +134,8 @@
           'package_name': pkg.package
       })
 
-    # Protobufs can't handle Path objects.
-    if isinstance(result_path, Path):
-      result_path = str(result_path)
-
     return test_pb2.BuildTargetUnitTestRequest(
         build_target={'name': board},
-        result_path=result_path,
         chroot={
             'path': chroot_path,
             'cache_dir': cache_dir
@@ -178,7 +171,7 @@
     """Sanity check that a validate only call does not execute any logic."""
     patch = self.PatchObject(test_service, 'BuildTargetUnitTest')
 
-    input_msg = self._GetInput(board='board', result_path=self.tempdir)
+    input_msg = self._GetInput(board='board')
     test_controller.BuildTargetUnitTest(input_msg, self._GetOutput(),
                                         self.validate_only_config)
     patch.assert_not_called()
@@ -187,19 +180,17 @@
     """Test that a mock call does not execute logic, returns mocked value."""
     patch = self.PatchObject(test_service, 'BuildTargetUnitTest')
 
-    input_msg = self._GetInput(board='board', result_path=self.tempdir)
+    input_msg = self._GetInput(board='board')
     response = self._GetOutput()
     test_controller.BuildTargetUnitTest(input_msg, response,
                                         self.mock_call_config)
     patch.assert_not_called()
-    self.assertEqual(response.tarball_path,
-                     os.path.join(input_msg.result_path, 'unit_tests.tar'))
 
   def testMockError(self):
     """Test that a mock error does not execute logic, returns error."""
     patch = self.PatchObject(test_service, 'BuildTargetUnitTest')
 
-    input_msg = self._GetInput(board='board', result_path=self.tempdir)
+    input_msg = self._GetInput(board='board')
     response = self._GetOutput()
     rc = test_controller.BuildTargetUnitTest(input_msg, response,
                                              self.mock_error_config)
@@ -215,8 +206,7 @@
     """Test missing result path fails."""
     # Missing result_path.
     pkg = package_info.PackageInfo(package='bar')
-    input_msg = self._GetInput(
-        board='board', result_path=self.tempdir, packages=[pkg])
+    input_msg = self._GetInput(board='board', packages=[pkg])
     output_msg = self._GetOutput()
     with self.assertRaises(cros_build_lib.DieSystemExit):
       test_controller.BuildTargetUnitTest(input_msg, output_msg,
@@ -241,7 +231,7 @@
     result.failed_pkgs = [package_info.parse(p) for p in pkgs]
     self.PatchObject(test_service, 'BuildTargetUnitTest', return_value=result)
 
-    input_msg = self._GetInput(board='board', result_path=self.tempdir)
+    input_msg = self._GetInput(board='board')
     output_msg = self._GetOutput()
 
     rc = test_controller.BuildTargetUnitTest(input_msg, output_msg,