commit 0352f7713fe663b4fec1b6d3590ca509acf65104
author Derek Beckett <dbeckett@chromium.org> Tue Apr 26 11:34:40 2022 -0700
committer Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Apr 27 01:46:52 2022 +0000
tree cf45723594a13be0694d692fa96fe43278bcb25a
parent aef41948c534691e12ea4bc9770a4ee1e2cc344b

cft: make cros-test critical again

I demoted it during transition to cloudbuild, but it appears to be
stable (spot checked > 50 builds), move it back to critical

BUG=b:228645277
TEST=unittest, cq

Change-Id: Ibd4d7e6406d9d1d14929f8a5700e137f0b428d60
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/3608461
Tested-by: Derek Beckett <dbeckett@chromium.org>
Auto-Submit: Derek Beckett <dbeckett@chromium.org>
Reviewed-by: Azizur Rahman <azrahman@google.com>
Commit-Queue: Azizur Rahman <azrahman@google.com>

api/controller/test.py

diff --git a/api/controller/test.py b/api/controller/test.py
index 0618e79..1c7a932 100644
--- a/api/controller/test.py
+++ b/api/controller/test.py
@@ -292,21 +292,13 @@
             )
         )
       else:
-        # Do not fail on cros-test-cloud as it is experimental.
-        if human_name == 'cros-test':
-
-          logging.debug('%s build failed.\nStdout:\n%s\nStderr:\n%s',
-                        human_name, cmd_result.stdout, cmd_result.stderr)
-          result.success.CopyFrom(
-              test_pb2.TestServiceContainerBuildResult.Success()
-          )
-        else:
-          result.failure.CopyFrom(
-              test_pb2.TestServiceContainerBuildResult.Failure(
-                  error_message=cmd_result.stdout
-              )
-          )
-
+        logging.debug('%s build failed.\nStdout:\n%s\nStderr:\n%s',
+                      human_name, cmd_result.stdout, cmd_result.stderr)
+        result.failure.CopyFrom(
+            test_pb2.TestServiceContainerBuildResult.Failure(
+                error_message=cmd_result.stdout
+            )
+        )
       output_proto.results.append(result)