deploy_chrome: Support strip option for deploying Lacros
To use the strip binary in SDK, developers need to specify the
board.
Currently developers is using:
deploy_chrome.py --device=<> --build-dir=<> --lacros --nostrip
With board args, developers will use either:
deploy_chrome.py --device=<> --build-dir=<> --lacros --board=<>
or
deploy_chrome.py --device=<> --build-dir=<> --lacros --nostrip
TEST: Tested locally that the stripped binary can be deployed
to altas and can run the binary successfully.
BUG: 1342286
Change-Id: Ic4128df281be91fb2069946230402a4da14cd665
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/3764811
Commit-Queue: Sven Zheng <svenzheng@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Tested-by: Sven Zheng <svenzheng@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
diff --git a/scripts/deploy_chrome.py b/scripts/deploy_chrome.py
index b434108..3903dbb 100644
--- a/scripts/deploy_chrome.py
+++ b/scripts/deploy_chrome.py
@@ -714,13 +714,8 @@
parser.error('Cannot specify both --build_dir and '
'--gs-path/--local-pkg-patch')
if options.lacros:
- if options.board:
- parser.error('--board is not supported with --lacros')
- # The stripping implemented in this file rely on the cros-chrome-sdk, which
- # is inappropriate for Lacros. Lacros stripping is currently not
- # implemented.
- if options.dostrip:
- parser.error('--lacros requires --nostrip')
+ if options.dostrip and not options.board:
+ parser.error('Please specify --board.')
if options.mount_dir or options.mount:
parser.error('--lacros does not support --mount or --mount-dir')
if options.deploy_test_binaries: