commit 0186d25a10e954e5f282930f1eb33be64bec9c40
author Jeremy Bettis <jbettis@google.com> Thu Jan 19 14:47:46 2023 -0700
committer Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Jan 20 02:58:51 2023 +0000
tree 7526430e8b5b8cd4e09d0e5d321b0471bc678490
parent 78006d988c9a1d130933885ab7d808b3f984547b

service: Split up ec-utils packages

It appears that the service will be called for only one package at a
time, and if it modifies files outside of that package, then no commit
will be created. See http://go/bbid/8791514939375519537

BUG=b:261258378
TEST=Modified unit test

Change-Id: I3d798f1439727b7decd17c6793d95122c20e2fd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/4182527
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Greg Edelston <gredelston@google.com>
Commit-Queue: Greg Edelston <gredelston@google.com>
Tested-by: Jeremy Bettis <jbettis@chromium.org>

service/packages_unittest.py

diff --git a/service/packages_unittest.py b/service/packages_unittest.py
index 9d2249a..99fb375 100644
--- a/service/packages_unittest.py
+++ b/service/packages_unittest.py
@@ -260,34 +260,38 @@
             "UprevOverlayManager",
             return_value=mock_overlay_mgr,
         )
-        cpv = package_info.SplitCPV("chromeos-base/ec-utils", strict=False)
-        assert cpv is not None
-        build_targets = [build_target_lib.BuildTarget("foo")]
-        refs = [
-            GitRef(
-                path="/platform/ec",
-                ref="main",
-                revision="123",
+
+        for package in [
+            "chromeos-base/ec-devutils",
+            "chromeos-base/ec-utils",
+            "chromeos-base/ec-utils-test",
+        ]:
+            cpv = package_info.SplitCPV(package, strict=False)
+            assert cpv is not None
+            build_targets = [build_target_lib.BuildTarget("foo")]
+            refs = [
+                GitRef(
+                    path="/platform/ec",
+                    ref="main",
+                    revision="123",
+                )
+            ]
+            chroot = Chroot()
+
+            result = packages.uprev_versioned_package(
+                cpv, build_targets, refs, chroot
             )
-        ]
-        chroot = Chroot()
 
-        result = packages.uprev_versioned_package(
-            cpv, build_targets, refs, chroot
-        )
+            self.assertEqual(1, len(result.modified))
+            self.assertEqual("123", result.modified[0].new_version)
+            self.assertListEqual(result.modified[0].files, ["file1", "file2"])
 
-        self.assertEqual(1, len(result.modified))
-        self.assertEqual("123", result.modified[0].new_version)
-        self.assertListEqual(result.modified[0].files, ["file1", "file2"])
-
-        mock_overlay_mgr.uprev.assert_called_once_with(
-            package_list=[
-                "chromeos-base/ec-devutils",
-                "chromeos-base/ec-utils",
-                "chromeos-base/ec-utils-test",
-            ],
-            force=True,
-        )
+            mock_overlay_mgr.uprev.assert_called_with(
+                package_list=[
+                    package,
+                ],
+                force=True,
+            )
 
 
 class UprevBuildTargetsTest(cros_test_lib.RunCommandTestCase):