blob: 5bf17f8175db3837ae38e01522126eb49d0d5a3f [file] [log] [blame]
Edward Lemur0db01f02019-11-12 22:01:51 +00001#!/usr/bin/env vpython3
2# coding=utf-8
maruel@chromium.orgeb5edbc2012-01-16 17:03:28 +00003# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@chromium.orgddd59412011-11-30 14:20:38 +00004# Use of this source code is governed by a BSD-style license that can be
5# found in the LICENSE file.
6
7"""Unit tests for git_cl.py."""
8
Edward Lemur85153282020-02-14 22:06:29 +00009from __future__ import print_function
Edward Lemur0db01f02019-11-12 22:01:51 +000010from __future__ import unicode_literals
11
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +010012import datetime
tandriide281ae2016-10-12 06:02:30 -070013import json
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +010014import logging
Edward Lemur61bf4172020-02-24 23:22:37 +000015import multiprocessing
maruel@chromium.orgddd59412011-11-30 14:20:38 +000016import os
Edward Lemur85153282020-02-14 22:06:29 +000017import pprint
Brian Sheedy59b06a82019-10-14 17:03:29 +000018import shutil
maruel@chromium.orgddd59412011-11-30 14:20:38 +000019import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070020import tempfile
maruel@chromium.orgddd59412011-11-30 14:20:38 +000021import unittest
22
Edward Lemura8145022020-01-06 18:47:54 +000023if sys.version_info.major == 2:
24 from StringIO import StringIO
25 import mock
26else:
27 from io import StringIO
28 from unittest import mock
29
maruel@chromium.orgddd59412011-11-30 14:20:38 +000030sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
31
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000032import metrics
33# We have to disable monitoring before importing git_cl.
34metrics.DISABLE_METRICS_COLLECTION = True
35
Jamie Madill5e96ad12020-01-13 16:08:35 +000036import clang_format
Edward Lemur227d5102020-02-25 23:45:35 +000037import contextlib
Edward Lemur1773f372020-02-22 00:27:14 +000038import gclient_utils
Eric Boren2fb63102018-10-05 13:05:03 +000039import gerrit_util
maruel@chromium.orgddd59412011-11-30 14:20:38 +000040import git_cl
iannucci@chromium.org9e849272014-04-04 00:31:55 +000041import git_common
tandrii@chromium.org57d86542016-03-04 16:11:32 +000042import git_footers
Edward Lemur85153282020-02-14 22:06:29 +000043import git_new_branch
44import scm
maruel@chromium.orgddd59412011-11-30 14:20:38 +000045import subprocess2
maruel@chromium.orgddd59412011-11-30 14:20:38 +000046
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000047
Edward Lemur0db01f02019-11-12 22:01:51 +000048def callError(code=1, cmd='', cwd='', stdout=b'', stderr=b''):
tandrii5d48c322016-08-18 16:19:37 -070049 return subprocess2.CalledProcessError(code, cmd, cwd, stdout, stderr)
50
51
Edward Lemur4c707a22019-09-24 21:13:43 +000052def _constantFn(return_value):
53 def f(*args, **kwargs):
54 return return_value
55 return f
56
57
tandrii5d48c322016-08-18 16:19:37 -070058CERR1 = callError(1)
59
60
Edward Lemur1773f372020-02-22 00:27:14 +000061class TemporaryFileMock(object):
62 def __init__(self):
63 self.suffix = 0
Aaron Gable9a03ae02017-11-03 11:31:07 -070064
Edward Lemur1773f372020-02-22 00:27:14 +000065 @contextlib.contextmanager
66 def __call__(self):
67 self.suffix += 1
68 yield '/tmp/fake-temp' + str(self.suffix)
Aaron Gable9a03ae02017-11-03 11:31:07 -070069
70
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000071class ChangelistMock(object):
72 # A class variable so we can access it when we don't have access to the
73 # instance that's being set.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000074 desc = ''
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000075 def __init__(self, **kwargs):
76 pass
77 def GetIssue(self):
78 return 1
Edward Lemur6c6827c2020-02-06 21:15:18 +000079 def FetchDescription(self):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000080 return ChangelistMock.desc
dsansomee2d6fd92016-09-08 00:10:47 -070081 def UpdateDescription(self, desc, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000082 ChangelistMock.desc = desc
83
tandrii5d48c322016-08-18 16:19:37 -070084
Edward Lemur85153282020-02-14 22:06:29 +000085class GitMocks(object):
86 def __init__(self, config=None, branchref=None):
87 self.branchref = branchref or 'refs/heads/master'
88 self.config = config or {}
89
90 def GetBranchRef(self, _root):
91 return self.branchref
92
93 def NewBranch(self, branchref):
94 self.branchref = branchref
95
Edward Lemur26964072020-02-19 19:18:51 +000096 def GetConfig(self, root, key, default=None):
97 if root != '':
98 key = '%s:%s' % (root, key)
Edward Lemur85153282020-02-14 22:06:29 +000099 return self.config.get(key, default)
100
Edward Lemur26964072020-02-19 19:18:51 +0000101 def SetConfig(self, root, key, value=None):
102 if root != '':
103 key = '%s:%s' % (root, key)
Edward Lemur85153282020-02-14 22:06:29 +0000104 if value:
105 self.config[key] = value
106 return
107 if key not in self.config:
108 raise CERR1
109 del self.config[key]
110
111
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000112class WatchlistsMock(object):
113 def __init__(self, _):
114 pass
115 @staticmethod
116 def GetWatchersForPaths(_):
117 return ['joe@example.com']
118
119
Edward Lemur4c707a22019-09-24 21:13:43 +0000120class CodereviewSettingsFileMock(object):
121 def __init__(self):
122 pass
123 # pylint: disable=no-self-use
124 def read(self):
125 return ('CODE_REVIEW_SERVER: gerrit.chromium.org\n' +
126 'GERRIT_HOST: True\n')
127
128
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000129class AuthenticatorMock(object):
130 def __init__(self, *_args):
131 pass
132 def has_cached_credentials(self):
133 return True
tandrii221ab252016-10-06 08:12:04 -0700134 def authorize(self, http):
135 return http
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000136
137
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100138def CookiesAuthenticatorMockFactory(hosts_with_creds=None, same_auth=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000139 """Use to mock Gerrit/Git credentials from ~/.netrc or ~/.gitcookies.
140
141 Usage:
142 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100143 CookiesAuthenticatorMockFactory({'host': ('user', _, 'pass')})
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000144
145 OR
146 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100147 CookiesAuthenticatorMockFactory(
148 same_auth=('user', '', 'pass'))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000149 """
150 class CookiesAuthenticatorMock(git_cl.gerrit_util.CookiesAuthenticator):
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800151 def __init__(self): # pylint: disable=super-init-not-called
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000152 # Intentionally not calling super() because it reads actual cookie files.
153 pass
154 @classmethod
155 def get_gitcookies_path(cls):
156 return '~/.gitcookies'
157 @classmethod
158 def get_netrc_path(cls):
159 return '~/.netrc'
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100160 def _get_auth_for_host(self, host):
161 if same_auth:
162 return same_auth
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000163 return (hosts_with_creds or {}).get(host)
164 return CookiesAuthenticatorMock
165
Aaron Gable9a03ae02017-11-03 11:31:07 -0700166
kmarshall9249e012016-08-23 12:02:16 -0700167class MockChangelistWithBranchAndIssue():
168 def __init__(self, branch, issue):
169 self.branch = branch
170 self.issue = issue
171 def GetBranch(self):
172 return self.branch
173 def GetIssue(self):
174 return self.issue
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000175
tandriic2405f52016-10-10 08:13:15 -0700176
177class SystemExitMock(Exception):
178 pass
179
180
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000181class TestGitClBasic(unittest.TestCase):
Edward Lemur6c6827c2020-02-06 21:15:18 +0000182 def test_fetch_description(self):
Edward Lemurf38bc172019-09-03 21:02:13 +0000183 cl = git_cl.Changelist(issue=1, codereview_host='host')
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100184 cl.description = 'x'
Edward Lemur6c6827c2020-02-06 21:15:18 +0000185 self.assertEqual(cl.FetchDescription(), 'x')
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700186
Edward Lemur61bf4172020-02-24 23:22:37 +0000187 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
188 @mock.patch('git_cl.Changelist.GetStatus', lambda cl: cl.status)
189 def test_get_cl_statuses(self, *_mocks):
190 statuses = [
191 'closed', 'commit', 'dry-run', 'lgtm', 'reply', 'unsent', 'waiting']
192 changes = []
193 for status in statuses:
194 cl = git_cl.Changelist()
195 cl.status = status
196 changes.append(cl)
197
198 actual = set(git_cl.get_cl_statuses(changes, True))
199 self.assertEqual(set(zip(changes, statuses)), actual)
200
201 def test_get_cl_statuses_no_changes(self):
202 self.assertEqual([], list(git_cl.get_cl_statuses([], True)))
203
204 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
205 @mock.patch('multiprocessing.pool.ThreadPool')
206 def test_get_cl_statuses_timeout(self, *_mocks):
207 changes = [git_cl.Changelist() for _ in range(2)]
208 pool = multiprocessing.pool.ThreadPool()
209 it = pool.imap_unordered.return_value.__iter__ = mock.Mock()
210 it.return_value.next.side_effect = [
211 (changes[0], 'lgtm'),
212 multiprocessing.TimeoutError,
213 ]
214
215 actual = list(git_cl.get_cl_statuses(changes, True))
216 self.assertEqual([(changes[0], 'lgtm'), (changes[1], 'error')], actual)
217
218 @mock.patch('git_cl.Changelist.GetIssueURL')
219 def test_get_cl_statuses_not_finegrained(self, _mock):
220 changes = [git_cl.Changelist() for _ in range(2)]
221 urls = ['some-url', None]
222 git_cl.Changelist.GetIssueURL.side_effect = urls
223
224 actual = set(git_cl.get_cl_statuses(changes, False))
225 self.assertEqual(
226 set([(changes[0], 'waiting'), (changes[1], 'error')]), actual)
227
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +0000228 def test_set_preserve_tryjobs(self):
229 d = git_cl.ChangeDescription('Simple.')
230 d.set_preserve_tryjobs()
231 self.assertEqual(d.description.splitlines(), [
232 'Simple.',
233 '',
234 'Cq-Do-Not-Cancel-Tryjobs: true',
235 ])
236 before = d.description
237 d.set_preserve_tryjobs()
238 self.assertEqual(before, d.description)
239
240 d = git_cl.ChangeDescription('\n'.join([
241 'One is enough',
242 '',
243 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
244 'Change-Id: Ideadbeef',
245 ]))
246 d.set_preserve_tryjobs()
247 self.assertEqual(d.description.splitlines(), [
248 'One is enough',
249 '',
250 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
251 'Change-Id: Ideadbeef',
252 'Cq-Do-Not-Cancel-Tryjobs: true',
253 ])
254
tandriif9aefb72016-07-01 09:06:51 -0700255 def test_get_bug_line_values(self):
256 f = lambda p, bugs: list(git_cl._get_bug_line_values(p, bugs))
257 self.assertEqual(f('', ''), [])
258 self.assertEqual(f('', '123,v8:456'), ['123', 'v8:456'])
259 self.assertEqual(f('v8', '456'), ['v8:456'])
260 self.assertEqual(f('v8', 'chromium:123,456'), ['v8:456', 'chromium:123'])
261 # Not nice, but not worth carying.
262 self.assertEqual(f('v8', 'chromium:123,456,v8:123'),
263 ['v8:456', 'chromium:123', 'v8:123'])
264
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100265 def _test_git_number(self, parent_msg, dest_ref, child_msg,
266 parent_hash='parenthash'):
267 desc = git_cl.ChangeDescription(child_msg)
268 desc.update_with_git_number_footers(parent_hash, parent_msg, dest_ref)
269 return desc.description
270
271 def assertEqualByLine(self, actual, expected):
272 self.assertEqual(actual.splitlines(), expected.splitlines())
273
274 def test_git_number_bad_parent(self):
275 with self.assertRaises(ValueError):
276 self._test_git_number('Parent', 'refs/heads/master', 'Child')
277
278 def test_git_number_bad_parent_footer(self):
279 with self.assertRaises(AssertionError):
280 self._test_git_number(
281 'Parent\n'
282 '\n'
283 'Cr-Commit-Position: wrong',
284 'refs/heads/master', 'Child')
285
286 def test_git_number_bad_lineage_ignored(self):
287 actual = self._test_git_number(
288 'Parent\n'
289 '\n'
290 'Cr-Commit-Position: refs/heads/master@{#1}\n'
291 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}',
292 'refs/heads/master', 'Child')
293 self.assertEqualByLine(
294 actual,
295 'Child\n'
296 '\n'
297 'Cr-Commit-Position: refs/heads/master@{#2}\n'
298 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}')
299
300 def test_git_number_same_branch(self):
301 actual = self._test_git_number(
302 'Parent\n'
303 '\n'
304 'Cr-Commit-Position: refs/heads/master@{#12}',
305 dest_ref='refs/heads/master',
306 child_msg='Child')
307 self.assertEqualByLine(
308 actual,
309 'Child\n'
310 '\n'
311 'Cr-Commit-Position: refs/heads/master@{#13}')
312
Andrii Shyshkalovde37c012017-07-06 21:06:50 +0200313 def test_git_number_same_branch_mixed_footers(self):
314 actual = self._test_git_number(
315 'Parent\n'
316 '\n'
317 'Cr-Commit-Position: refs/heads/master@{#12}',
318 dest_ref='refs/heads/master',
319 child_msg='Child\n'
320 '\n'
321 'Broken-by: design\n'
322 'BUG=123')
323 self.assertEqualByLine(
324 actual,
325 'Child\n'
326 '\n'
327 'Broken-by: design\n'
328 'BUG=123\n'
329 'Cr-Commit-Position: refs/heads/master@{#13}')
330
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100331 def test_git_number_same_branch_with_originals(self):
332 actual = self._test_git_number(
333 'Parent\n'
334 '\n'
335 'Cr-Commit-Position: refs/heads/master@{#12}',
336 dest_ref='refs/heads/master',
337 child_msg='Child\n'
338 '\n'
339 'Some users are smart and insert their own footers\n'
340 '\n'
341 'Cr-Whatever: value\n'
342 'Cr-Commit-Position: refs/copy/paste@{#22}')
343 self.assertEqualByLine(
344 actual,
345 'Child\n'
346 '\n'
347 'Some users are smart and insert their own footers\n'
348 '\n'
349 'Cr-Original-Whatever: value\n'
350 'Cr-Original-Commit-Position: refs/copy/paste@{#22}\n'
351 'Cr-Commit-Position: refs/heads/master@{#13}')
352
353 def test_git_number_new_branch(self):
354 actual = self._test_git_number(
355 'Parent\n'
356 '\n'
357 'Cr-Commit-Position: refs/heads/master@{#12}',
358 dest_ref='refs/heads/branch',
359 child_msg='Child')
360 self.assertEqualByLine(
361 actual,
362 'Child\n'
363 '\n'
364 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
365 'Cr-Branched-From: parenthash-refs/heads/master@{#12}')
366
367 def test_git_number_lineage(self):
368 actual = self._test_git_number(
369 'Parent\n'
370 '\n'
371 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
372 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
373 dest_ref='refs/heads/branch',
374 child_msg='Child')
375 self.assertEqualByLine(
376 actual,
377 'Child\n'
378 '\n'
379 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
380 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
381
382 def test_git_number_moooooooore_lineage(self):
383 actual = self._test_git_number(
384 'Parent\n'
385 '\n'
386 'Cr-Commit-Position: refs/heads/branch@{#5}\n'
387 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
388 dest_ref='refs/heads/mooore',
389 child_msg='Child')
390 self.assertEqualByLine(
391 actual,
392 'Child\n'
393 '\n'
394 'Cr-Commit-Position: refs/heads/mooore@{#1}\n'
395 'Cr-Branched-From: parenthash-refs/heads/branch@{#5}\n'
396 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
397
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100398 def test_git_number_ever_moooooooore_lineage(self):
Robert Iannucci456b0d62018-03-13 19:15:50 -0700399 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100400 actual = self._test_git_number(
401 'CQ commit on fresh new branch + numbering.\n'
402 '\n'
403 'NOTRY=True\n'
404 'NOPRESUBMIT=True\n'
405 'BUG=\n'
406 '\n'
407 'Review-Url: https://codereview.chromium.org/2577703003\n'
408 'Cr-Commit-Position: refs/heads/gnumb-test/br@{#1}\n'
409 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
410 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}',
411 dest_ref='refs/heads/gnumb-test/cl',
412 child_msg='git cl on fresh new branch + numbering.\n'
413 '\n'
414 'Review-Url: https://codereview.chromium.org/2575043003 .\n')
415 self.assertEqualByLine(
416 actual,
417 'git cl on fresh new branch + numbering.\n'
418 '\n'
419 'Review-Url: https://codereview.chromium.org/2575043003 .\n'
420 'Cr-Commit-Position: refs/heads/gnumb-test/cl@{#1}\n'
421 'Cr-Branched-From: parenthash-refs/heads/gnumb-test/br@{#1}\n'
422 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
423 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}')
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100424
425 def test_git_number_cherry_pick(self):
426 actual = self._test_git_number(
427 'Parent\n'
428 '\n'
429 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
430 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
431 dest_ref='refs/heads/branch',
432 child_msg='Child, which is cherry-pick from master\n'
433 '\n'
434 'Cr-Commit-Position: refs/heads/master@{#100}\n'
435 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)')
436 self.assertEqualByLine(
437 actual,
438 'Child, which is cherry-pick from master\n'
439 '\n'
440 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)\n'
441 '\n'
442 'Cr-Original-Commit-Position: refs/heads/master@{#100}\n'
443 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
444 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
445
Edward Lemurda4b6c62020-02-13 00:28:40 +0000446 @mock.patch('gerrit_util.GetAccountDetails')
447 def test_valid_accounts(self, mockGetAccountDetails):
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000448 mock_per_account = {
449 'u1': None, # 404, doesn't exist.
450 'u2': {
451 '_account_id': 123124,
452 'avatars': [],
453 'email': 'u2@example.com',
454 'name': 'User Number 2',
455 'status': 'OOO',
456 },
457 'u3': git_cl.gerrit_util.GerritError(500, 'retries didn\'t help :('),
458 }
459 def GetAccountDetailsMock(_, account):
460 # Poor-man's mock library's side_effect.
461 v = mock_per_account.pop(account)
462 if isinstance(v, Exception):
463 raise v
464 return v
465
Edward Lemurda4b6c62020-02-13 00:28:40 +0000466 mockGetAccountDetails.side_effect = GetAccountDetailsMock
467 actual = git_cl.gerrit_util.ValidAccounts(
468 'host', ['u1', 'u2', 'u3'], max_threads=1)
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000469 self.assertEqual(actual, {
470 'u2': {
471 '_account_id': 123124,
472 'avatars': [],
473 'email': 'u2@example.com',
474 'name': 'User Number 2',
475 'status': 'OOO',
476 },
477 })
478
479
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200480class TestParseIssueURL(unittest.TestCase):
481 def _validate(self, parsed, issue=None, patchset=None, hostname=None,
Edward Lemurf38bc172019-09-03 21:02:13 +0000482 fail=False):
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200483 self.assertIsNotNone(parsed)
484 if fail:
485 self.assertFalse(parsed.valid)
486 return
487 self.assertTrue(parsed.valid)
488 self.assertEqual(parsed.issue, issue)
489 self.assertEqual(parsed.patchset, patchset)
490 self.assertEqual(parsed.hostname, hostname)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200491
Edward Lemur678a6842019-10-03 22:25:05 +0000492 def test_ParseIssueNumberArgument(self):
493 def test(arg, *args, **kwargs):
494 self._validate(git_cl.ParseIssueNumberArgument(arg), *args, **kwargs)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200495
Edward Lemur678a6842019-10-03 22:25:05 +0000496 test('123', 123)
497 test('', fail=True)
498 test('abc', fail=True)
499 test('123/1', fail=True)
500 test('123a', fail=True)
501 test('ssh://chrome-review.source.com/#/c/123/4/', fail=True)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200502
Edward Lemur678a6842019-10-03 22:25:05 +0000503 test('https://codereview.source.com/123',
504 123, None, 'codereview.source.com')
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200505 test('http://chrome-review.source.com/c/123',
506 123, None, 'chrome-review.source.com')
507 test('https://chrome-review.source.com/c/123/',
508 123, None, 'chrome-review.source.com')
509 test('https://chrome-review.source.com/c/123/4',
510 123, 4, 'chrome-review.source.com')
511 test('https://chrome-review.source.com/#/c/123/4',
512 123, 4, 'chrome-review.source.com')
513 test('https://chrome-review.source.com/c/123/4',
514 123, 4, 'chrome-review.source.com')
515 test('https://chrome-review.source.com/123',
516 123, None, 'chrome-review.source.com')
517 test('https://chrome-review.source.com/123/4',
518 123, 4, 'chrome-review.source.com')
519
Edward Lemur678a6842019-10-03 22:25:05 +0000520 test('https://chrome-review.source.com/bad/123/4', fail=True)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200521 test('https://chrome-review.source.com/c/123/1/whatisthis', fail=True)
522 test('https://chrome-review.source.com/c/abc/', fail=True)
523 test('ssh://chrome-review.source.com/c/123/1/', fail=True)
524
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200525
526
Edward Lemurda4b6c62020-02-13 00:28:40 +0000527class GitCookiesCheckerTest(unittest.TestCase):
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100528 def setUp(self):
529 super(GitCookiesCheckerTest, self).setUp()
530 self.c = git_cl._GitCookiesChecker()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100531 self.c._all_hosts = []
Edward Lemurda4b6c62020-02-13 00:28:40 +0000532 mock.patch('sys.stdout', StringIO()).start()
533 self.addCleanup(mock.patch.stopall)
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100534
535 def mock_hosts_creds(self, subhost_identity_pairs):
536 def ensure_googlesource(h):
537 if not h.endswith(self.c._GOOGLESOURCE):
538 assert not h.endswith('.')
539 return h + '.' + self.c._GOOGLESOURCE
540 return h
541 self.c._all_hosts = [(ensure_googlesource(h), i, '.gitcookies')
542 for h, i in subhost_identity_pairs]
543
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200544 def test_identity_parsing(self):
545 self.assertEqual(self.c._parse_identity('ldap.google.com'),
546 ('ldap', 'google.com'))
547 self.assertEqual(self.c._parse_identity('git-ldap.example.com'),
548 ('ldap', 'example.com'))
549 # Specical case because we know there are no subdomains in chromium.org.
550 self.assertEqual(self.c._parse_identity('git-note.period.chromium.org'),
551 ('note.period', 'chromium.org'))
Lei Zhangd3f769a2017-12-15 15:16:14 -0800552 # Pathological: ".period." can be either username OR domain, more likely
553 # domain.
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200554 self.assertEqual(self.c._parse_identity('git-note.period.example.com'),
555 ('note', 'period.example.com'))
556
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100557 def test_analysis_nothing(self):
558 self.c._all_hosts = []
559 self.assertFalse(self.c.has_generic_host())
560 self.assertEqual(set(), self.c.get_conflicting_hosts())
561 self.assertEqual(set(), self.c.get_duplicated_hosts())
562 self.assertEqual(set(), self.c.get_partially_configured_hosts())
563 self.assertEqual(set(), self.c.get_hosts_with_wrong_identities())
564
565 def test_analysis(self):
566 self.mock_hosts_creds([
567 ('.googlesource.com', 'git-example.chromium.org'),
568
569 ('chromium', 'git-example.google.com'),
570 ('chromium-review', 'git-example.google.com'),
571 ('chrome-internal', 'git-example.chromium.org'),
572 ('chrome-internal-review', 'git-example.chromium.org'),
573 ('conflict', 'git-example.google.com'),
574 ('conflict-review', 'git-example.chromium.org'),
575 ('dup', 'git-example.google.com'),
576 ('dup', 'git-example.google.com'),
577 ('dup-review', 'git-example.google.com'),
578 ('partial', 'git-example.google.com'),
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200579 ('gpartial-review', 'git-example.google.com'),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100580 ])
581 self.assertTrue(self.c.has_generic_host())
582 self.assertEqual(set(['conflict.googlesource.com']),
583 self.c.get_conflicting_hosts())
584 self.assertEqual(set(['dup.googlesource.com']),
585 self.c.get_duplicated_hosts())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200586 self.assertEqual(set(['partial.googlesource.com',
587 'gpartial-review.googlesource.com']),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100588 self.c.get_partially_configured_hosts())
589 self.assertEqual(set(['chromium.googlesource.com',
590 'chrome-internal.googlesource.com']),
591 self.c.get_hosts_with_wrong_identities())
592
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100593 def test_report_no_problems(self):
594 self.test_analysis_nothing()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100595 self.assertFalse(self.c.find_and_report_problems())
596 self.assertEqual(sys.stdout.getvalue(), '')
597
Edward Lemurda4b6c62020-02-13 00:28:40 +0000598 @mock.patch(
599 'git_cl.gerrit_util.CookiesAuthenticator.get_gitcookies_path',
600 return_value='~/.gitcookies')
601 def test_report(self, *_mocks):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100602 self.test_analysis()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100603 self.assertTrue(self.c.find_and_report_problems())
604 with open(os.path.join(os.path.dirname(__file__),
605 'git_cl_creds_check_report.txt')) as f:
606 expected = f.read()
607 def by_line(text):
608 return [l.rstrip() for l in text.rstrip().splitlines()]
Robert Iannucci456b0d62018-03-13 19:15:50 -0700609 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalov4812e612017-03-27 17:22:57 +0200610 self.assertEqual(by_line(sys.stdout.getvalue().strip()), by_line(expected))
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100611
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -0800612
Edward Lemurda4b6c62020-02-13 00:28:40 +0000613class TestGitCl(unittest.TestCase):
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000614 def setUp(self):
615 super(TestGitCl, self).setUp()
616 self.calls = []
tandrii9d206752016-06-20 11:32:47 -0700617 self._calls_done = []
Edward Lemurda4b6c62020-02-13 00:28:40 +0000618 mock.patch('sys.stdout', StringIO()).start()
619 mock.patch(
620 'git_cl.time_time',
621 lambda: self._mocked_call('time.time')).start()
622 mock.patch(
623 'git_cl.metrics.collector.add_repeated',
624 lambda *a: self._mocked_call('add_repeated', *a)).start()
625 mock.patch('subprocess2.call', self._mocked_call).start()
626 mock.patch('subprocess2.check_call', self._mocked_call).start()
627 mock.patch('subprocess2.check_output', self._mocked_call).start()
628 mock.patch(
629 'subprocess2.communicate',
630 lambda *a, **_k: ([self._mocked_call(*a), ''], 0)).start()
631 mock.patch(
632 'git_cl.gclient_utils.CheckCallAndFilter',
633 self._mocked_call).start()
634 mock.patch('git_common.is_dirty_git_tree', lambda x: False).start()
635 mock.patch(
636 'git_common.get_or_create_merge_base',
637 lambda *a: self._mocked_call('get_or_create_merge_base', *a)).start()
638 mock.patch('git_cl.BranchExists', return_value=True).start()
639 mock.patch('git_cl.FindCodereviewSettingsFile', return_value='').start()
640 mock.patch(
641 'git_cl.SaveDescriptionBackup',
642 lambda _: self._mocked_call('SaveDescriptionBackup')).start()
643 mock.patch(
644 'git_cl.ask_for_data',
645 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
646 mock.patch(
647 'git_cl.write_json',
648 lambda *a: self._mocked_call('write_json', *a)).start()
649 mock.patch(
Edward Lemur227d5102020-02-25 23:45:35 +0000650 'git_cl.Changelist.RunHook',
651 return_value={'more_cc': ['test-more-cc@chromium.org']}).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +0000652 mock.patch('git_cl.watchlists.Watchlists', WatchlistsMock).start()
653 mock.patch('git_cl.auth.Authenticator', AuthenticatorMock).start()
Edward Lesmes7677e5c2020-02-19 20:39:03 +0000654 mock.patch('gerrit_util.GetChangeDetail').start()
Edward Lemurda4b6c62020-02-13 00:28:40 +0000655 mock.patch(
656 'git_cl.gerrit_util.GetChangeComments',
657 lambda *a: self._mocked_call('GetChangeComments', *a)).start()
658 mock.patch(
659 'git_cl.gerrit_util.GetChangeRobotComments',
660 lambda *a: self._mocked_call('GetChangeRobotComments', *a)).start()
661 mock.patch(
662 'git_cl.gerrit_util.AddReviewers',
663 lambda *a: self._mocked_call('AddReviewers', *a)).start()
664 mock.patch(
665 'git_cl.gerrit_util.SetReview',
666 lambda h, i, msg=None, labels=None, notify=None, ready=None: (
667 self._mocked_call(
668 'SetReview', h, i, msg, labels, notify, ready))).start()
669 mock.patch(
670 'git_cl.gerrit_util.LuciContextAuthenticator.is_luci',
671 return_value=False).start()
672 mock.patch(
673 'git_cl.gerrit_util.GceAuthenticator.is_gce',
674 return_value=False).start()
675 mock.patch(
676 'git_cl.gerrit_util.ValidAccounts',
677 lambda *a: self._mocked_call('ValidAccounts', *a)).start()
Edward Lemurd55c5072020-02-20 01:09:07 +0000678 mock.patch('sys.exit', side_effect=SystemExitMock).start()
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000679 mock.patch('git_cl.Settings.GetRoot', return_value='').start()
Edward Lemur85153282020-02-14 22:06:29 +0000680 self.mockGit = GitMocks()
681 mock.patch('scm.GIT.GetBranchRef', self.mockGit.GetBranchRef).start()
682 mock.patch('scm.GIT.GetConfig', self.mockGit.GetConfig).start()
683 mock.patch('scm.GIT.SetConfig', self.mockGit.SetConfig).start()
Edward Lemur84101642020-02-21 21:40:34 +0000684 mock.patch(
685 'git_new_branch.create_new_branch', self.mockGit.NewBranch).start()
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000686 mock.patch(
Edward Lemur85153282020-02-14 22:06:29 +0000687 'scm.GIT.FetchUpstreamTuple',
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000688 return_value=('origin', 'refs/heads/master')).start()
Edward Lemur85153282020-02-14 22:06:29 +0000689 mock.patch(
690 'scm.GIT.CaptureStatus', return_value=[('M', 'foo.txt')]).start()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000691 # It's important to reset settings to not have inter-tests interference.
692 git_cl.settings = None
Edward Lemurda4b6c62020-02-13 00:28:40 +0000693 self.addCleanup(mock.patch.stopall)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000694
695 def tearDown(self):
wychen@chromium.org445c8962015-04-28 23:30:05 +0000696 try:
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +0000697 self.assertEqual([], self.calls)
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100698 except AssertionError:
Edward Lemur85153282020-02-14 22:06:29 +0000699 calls = ''.join(' %s\n' % str(call) for call in self.calls[:5])
700 if len(self.calls) > 5:
701 calls += ' ...\n'
702 self.fail(
703 '\n'
704 'There are un-consumed calls after this test has finished:\n' +
705 calls)
wychen@chromium.org445c8962015-04-28 23:30:05 +0000706 finally:
707 super(TestGitCl, self).tearDown()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000708
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000709 def _mocked_call(self, *args, **_kwargs):
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000710 self.assertTrue(
711 self.calls,
tandrii9d206752016-06-20 11:32:47 -0700712 '@%d Expected: <Missing> Actual: %r' % (len(self._calls_done), args))
wychen@chromium.orga872e752015-04-28 23:42:18 +0000713 top = self.calls.pop(0)
wychen@chromium.orga872e752015-04-28 23:42:18 +0000714 expected_args, result = top
715
maruel@chromium.orge52678e2013-04-26 18:34:44 +0000716 # Also logs otherwise it could get caught in a try/finally and be hard to
717 # diagnose.
718 if expected_args != args:
tandrii9d206752016-06-20 11:32:47 -0700719 N = 5
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000720 prior_calls = '\n '.join(
tandrii9d206752016-06-20 11:32:47 -0700721 '@%d: %r' % (len(self._calls_done) - N + i, c[0])
722 for i, c in enumerate(self._calls_done[-N:]))
723 following_calls = '\n '.join(
724 '@%d: %r' % (len(self._calls_done) + i + 1, c[0])
725 for i, c in enumerate(self.calls[:N]))
726 extended_msg = (
727 'A few prior calls:\n %s\n\n'
728 'This (expected):\n @%d: %r\n'
729 'This (actual):\n @%d: %r\n\n'
730 'A few following expected calls:\n %s' %
731 (prior_calls, len(self._calls_done), expected_args,
732 len(self._calls_done), args, following_calls))
tandrii9d206752016-06-20 11:32:47 -0700733
tandrii99a72f22016-08-17 14:33:24 -0700734 self.fail('@%d\n'
735 ' Expected: %r\n'
Edward Lemur26964072020-02-19 19:18:51 +0000736 ' Actual: %r\n'
737 '\n'
738 '%s' % (
739 len(self._calls_done), expected_args, args, extended_msg))
tandrii9d206752016-06-20 11:32:47 -0700740
741 self._calls_done.append(top)
tandrii5d48c322016-08-18 16:19:37 -0700742 if isinstance(result, Exception):
743 raise result
Edward Lemur0db01f02019-11-12 22:01:51 +0000744 # stdout from git commands is supposed to be a bytestream. Convert it here
745 # instead of converting all test output in this file to bytes.
746 if args[0][0] == 'git' and not isinstance(result, bytes):
747 result = result.encode('utf-8')
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000748 return result
749
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100750 def test_ask_for_explicit_yes_true(self):
751 self.calls = [
752 (('ask_for_data', 'prompt [Yes/No]: '), 'blah'),
753 (('ask_for_data', 'Please, type yes or no: '), 'ye'),
754 ]
755 self.assertTrue(git_cl.ask_for_explicit_yes('prompt'))
756
tandrii48df5812016-10-17 03:55:37 -0700757 def test_LoadCodereviewSettingsFromFile_gerrit(self):
Edward Lemur79d4f992019-11-11 23:49:02 +0000758 codereview_file = StringIO('GERRIT_HOST: true')
tandrii48df5812016-10-17 03:55:37 -0700759 self.calls = [
760 ((['git', 'config', '--unset-all', 'rietveld.cc'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700761 ((['git', 'config', '--unset-all', 'rietveld.tree-status-url'],), CERR1),
762 ((['git', 'config', '--unset-all', 'rietveld.viewvc-url'],), CERR1),
763 ((['git', 'config', '--unset-all', 'rietveld.bug-prefix'],), CERR1),
764 ((['git', 'config', '--unset-all', 'rietveld.cpplint-regex'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700765 ((['git', 'config', '--unset-all', 'rietveld.cpplint-ignore-regex'],),
766 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700767 ((['git', 'config', '--unset-all', 'rietveld.run-post-upload-hook'],),
768 CERR1),
Jamie Madilldc4d19e2019-10-24 21:50:02 +0000769 ((['git', 'config', '--unset-all', 'rietveld.format-full-by-default'],),
770 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700771 ((['git', 'config', 'gerrit.host', 'true'],), ''),
772 ]
773 self.assertIsNone(git_cl.LoadCodereviewSettingsFromFile(codereview_file))
774
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000775 @classmethod
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100776 def _gerrit_base_calls(cls, issue=None, fetched_description=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200777 fetched_status=None, other_cl_owner=None,
Anthony Polito8b955342019-09-24 19:01:36 +0000778 custom_cl_base=None, short_hostname='chromium',
779 change_id=None):
Edward Lemur26964072020-02-19 19:18:51 +0000780 calls = []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200781 if custom_cl_base:
782 ancestor_revision = custom_cl_base
783 else:
784 # Determine ancestor_revision to be merge base.
785 ancestor_revision = 'fake_ancestor_sha'
786 calls += [
Edward Lemurda4b6c62020-02-13 00:28:40 +0000787 (('get_or_create_merge_base', 'master', 'refs/remotes/origin/master'),
788 ancestor_revision),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200789 ]
790
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100791 if issue:
Edward Lesmes7677e5c2020-02-19 20:39:03 +0000792 gerrit_util.GetChangeDetail.return_value = {
793 'owner': {'email': (other_cl_owner or 'owner@example.com')},
794 'change_id': (change_id or '123456789'),
795 'current_revision': 'sha1_of_current_revision',
796 'revisions': {'sha1_of_current_revision': {
797 'commit': {'message': fetched_description},
798 }},
799 'status': fetched_status or 'NEW',
800 }
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100801 if fetched_status == 'ABANDONED':
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100802 return calls
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100803 if other_cl_owner:
804 calls += [
805 (('ask_for_data', 'Press Enter to upload, or Ctrl+C to abort'), ''),
806 ]
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100807
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100808 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200809 ((['git', 'rev-parse', 'HEAD'],), '12345'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100810 ]
811
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100812 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200813 ((['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] +
814 ([custom_cl_base] if custom_cl_base else
815 [ancestor_revision, 'HEAD']),),
816 '+dat'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100817 ]
818 return calls
ukai@chromium.orge8077812012-02-03 03:41:46 +0000819
Edward Lemur26964072020-02-19 19:18:51 +0000820 def _gerrit_upload_calls(self, description, reviewers, squash,
tandriia60502f2016-06-20 02:01:53 -0700821 squash_mode='default',
tandrii@chromium.org10625002016-03-04 20:03:47 +0000822 expected_upstream_ref='origin/refs/heads/master',
Aaron Gablefd238082017-06-07 13:42:34 -0700823 title=None, notify=False,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +0100824 post_amend_description=None, issue=None, cc=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000825 custom_cl_base=None, tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +0000826 short_hostname='chromium',
Edward Lemur1b52d872019-05-09 21:12:12 +0000827 labels=None, change_id=None, original_title=None,
Anthony Polito8b955342019-09-24 19:01:36 +0000828 final_description=None, gitcookies_exists=True,
Josipe827b0f2020-01-30 00:07:20 +0000829 force=False, edit_description=None):
tandrii@chromium.org10625002016-03-04 20:03:47 +0000830 if post_amend_description is None:
831 post_amend_description = description
bradnelsond975b302016-10-23 12:20:23 -0700832 cc = cc or []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200833 # Determined in `_gerrit_base_calls`.
834 determined_ancestor_revision = custom_cl_base or 'fake_ancestor_sha'
835
836 calls = []
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000837
Edward Lemur26964072020-02-19 19:18:51 +0000838 if squash_mode in ('override_squash', 'override_nosquash'):
839 self.mockGit.config['gerrit.override-squash-uploads'] = (
840 'true' if squash_mode == 'override_squash' else 'false')
tandriia60502f2016-06-20 02:01:53 -0700841
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000842 # If issue is given, then description is fetched from Gerrit instead.
843 if issue is None:
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000844 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200845 ((['git', 'log', '--pretty=format:%s\n\n%b',
846 ((custom_cl_base + '..') if custom_cl_base else
847 'fake_ancestor_sha..HEAD')],),
848 description),
849 ]
Aaron Gableb56ad332017-01-06 15:24:31 -0800850 if squash:
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000851 title = 'Initial_upload'
Aaron Gableb56ad332017-01-06 15:24:31 -0800852 else:
853 if not title:
854 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200855 ((['git', 'show', '-s', '--format=%s', 'HEAD'],), ''),
856 (('ask_for_data', 'Title for patchset []: '), 'User input'),
Aaron Gableb56ad332017-01-06 15:24:31 -0800857 ]
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000858 title = 'User_input'
tandrii@chromium.org57d86542016-03-04 16:11:32 +0000859 if not git_footers.get_footer_change_id(description) and not squash:
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000860 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200861 (('DownloadGerritHook', False), ''),
862 # Amending of commit message to get the Change-Id.
863 ((['git', 'log', '--pretty=format:%s\n\n%b',
864 determined_ancestor_revision + '..HEAD'],),
865 description),
866 ((['git', 'commit', '--amend', '-m', description],), ''),
867 ((['git', 'log', '--pretty=format:%s\n\n%b',
868 determined_ancestor_revision + '..HEAD'],),
869 post_amend_description)
870 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000871 if squash:
Anthony Polito8b955342019-09-24 19:01:36 +0000872 if force or not issue:
Anthony Polito8b955342019-09-24 19:01:36 +0000873 if not force:
874 calls += [
Anthony Polito8b955342019-09-24 19:01:36 +0000875 ((['RunEditor'],), description),
876 ]
Josipe827b0f2020-01-30 00:07:20 +0000877 # user wants to edit description
878 if edit_description:
879 calls += [
Josipe827b0f2020-01-30 00:07:20 +0000880 ((['RunEditor'],), edit_description),
881 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000882 ref_to_push = 'abcdef0123456789'
883 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200884 ]
885
886 if custom_cl_base is None:
887 calls += [
Edward Lemurda4b6c62020-02-13 00:28:40 +0000888 (('get_or_create_merge_base', 'master', 'refs/remotes/origin/master'),
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000889 'origin/master'),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200890 ]
891 parent = 'origin/master'
892 else:
893 calls += [
894 ((['git', 'merge-base', '--is-ancestor', custom_cl_base,
895 'refs/remotes/origin/master'],),
896 callError(1)), # Means not ancenstor.
897 (('ask_for_data',
898 'Do you take responsibility for cleaning up potential mess '
899 'resulting from proceeding with upload? Press Enter to upload, '
900 'or Ctrl+C to abort'), ''),
901 ]
902 parent = custom_cl_base
903
904 calls += [
905 ((['git', 'rev-parse', 'HEAD:'],), # `HEAD:` means HEAD's tree hash.
906 '0123456789abcdef'),
Edward Lemur1773f372020-02-22 00:27:14 +0000907 ((['FileWrite', '/tmp/fake-temp1', description],), None),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200908 ((['git', 'commit-tree', '0123456789abcdef', '-p', parent,
Edward Lemur1773f372020-02-22 00:27:14 +0000909 '-F', '/tmp/fake-temp1'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200910 ref_to_push),
911 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000912 else:
913 ref_to_push = 'HEAD'
914
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000915 calls += [
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000916 (('SaveDescriptionBackup',), None),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200917 ((['git', 'rev-list',
918 (custom_cl_base if custom_cl_base else expected_upstream_ref) + '..' +
919 ref_to_push],),
920 '1hashPerLine\n'),
921 ]
tandrii@chromium.org8da45402016-05-24 23:11:03 +0000922
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000923 metrics_arguments = []
924
Aaron Gableafd52772017-06-27 16:40:10 -0700925 if notify:
Aaron Gable844cf292017-06-28 11:32:59 -0700926 ref_suffix = '%ready,notify=ALL'
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000927 metrics_arguments += ['ready', 'notify=ALL']
Aaron Gable844cf292017-06-28 11:32:59 -0700928 else:
Jamie Madill276da0b2018-04-27 14:41:20 -0400929 if not issue and squash:
Aaron Gable844cf292017-06-28 11:32:59 -0700930 ref_suffix = '%wip'
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000931 metrics_arguments.append('wip')
Aaron Gable844cf292017-06-28 11:32:59 -0700932 else:
933 ref_suffix = '%notify=NONE'
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000934 metrics_arguments.append('notify=NONE')
Aaron Gable9b713dd2016-12-14 16:04:21 -0800935
Aaron Gable70f4e242017-06-26 10:45:59 -0700936 if title:
Aaron Gableafd52772017-06-27 16:40:10 -0700937 ref_suffix += ',m=' + title
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000938 metrics_arguments.append('m')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000939
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000940 if short_hostname == 'chromium':
941 # All reviwers and ccs get into ref_suffix.
942 for r in sorted(reviewers):
943 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000944 metrics_arguments.append('r')
Edward Lemur4508b422019-10-03 21:56:35 +0000945 if issue is None:
Edward Lemur227d5102020-02-25 23:45:35 +0000946 cc += ['test-more-cc@chromium.org', 'joe@example.com']
Edward Lemur4508b422019-10-03 21:56:35 +0000947 for c in sorted(cc):
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000948 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000949 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000950 reviewers, cc = [], []
951 else:
952 # TODO(crbug/877717): remove this case.
953 calls += [
954 (('ValidAccounts', '%s-review.googlesource.com' % short_hostname,
955 sorted(reviewers) + ['joe@example.com',
Edward Lemur227d5102020-02-25 23:45:35 +0000956 'test-more-cc@chromium.org'] + cc),
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000957 {
958 e: {'email': e}
959 for e in (reviewers + ['joe@example.com'] + cc)
960 })
961 ]
962 for r in sorted(reviewers):
963 if r != 'bad-account-or-email':
964 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000965 metrics_arguments.append('r')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000966 reviewers.remove(r)
Edward Lemur4508b422019-10-03 21:56:35 +0000967 if issue is None:
968 cc += ['joe@example.com']
969 for c in sorted(cc):
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000970 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000971 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000972 if c in cc:
973 cc.remove(c)
Andrii Shyshkalov76988a82018-10-15 03:12:25 +0000974
Edward Lemur687ca902018-12-05 02:30:30 +0000975 for k, v in sorted((labels or {}).items()):
976 ref_suffix += ',l=%s+%d' % (k, v)
977 metrics_arguments.append('l=%s+%d' % (k, v))
978
979 if tbr:
980 calls += [
981 (('GetCodeReviewTbrScore',
982 '%s-review.googlesource.com' % short_hostname,
983 'my/repo'),
984 2,),
985 ]
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +0000986
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000987 calls += [
988 (('time.time',), 1000,),
989 ((['git', 'push',
990 'https://%s.googlesource.com/my/repo' % short_hostname,
991 ref_to_push + ':refs/for/refs/heads/master' + ref_suffix],),
992 (('remote:\n'
993 'remote: Processing changes: (\)\n'
994 'remote: Processing changes: (|)\n'
995 'remote: Processing changes: (/)\n'
996 'remote: Processing changes: (-)\n'
997 'remote: Processing changes: new: 1 (/)\n'
998 'remote: Processing changes: new: 1, done\n'
999 'remote:\n'
1000 'remote: New Changes:\n'
1001 'remote: https://%s-review.googlesource.com/#/c/my/repo/+/123456'
1002 ' XXX\n'
1003 'remote:\n'
1004 'To https://%s.googlesource.com/my/repo\n'
1005 ' * [new branch] hhhh -> refs/for/refs/heads/master\n'
1006 ) % (short_hostname, short_hostname)),),
1007 (('time.time',), 2000,),
1008 (('add_repeated',
1009 'sub_commands',
1010 {
1011 'execution_time': 1000,
1012 'command': 'git push',
1013 'exit_code': 0,
1014 'arguments': sorted(metrics_arguments),
1015 }),
1016 None,),
1017 ]
1018
Edward Lemur1b52d872019-05-09 21:12:12 +00001019 final_description = final_description or post_amend_description.strip()
1020 original_title = original_title or title or '<untitled>'
1021 # Trace-related calls
1022 calls += [
1023 # Write a description with context for the current trace.
1024 ((['FileWrite', 'TRACES_DIR/20170316T200041.000000-README',
Edward Lemur75391d42019-05-14 23:35:56 +00001025 'Thu Mar 16 20:00:41 2017\n'
1026 '%(short_hostname)s-review.googlesource.com\n'
1027 '%(change_id)s\n'
1028 '%(title)s\n'
1029 '%(description)s\n'
1030 '1000\n'
1031 '0\n'
1032 '%(trace_name)s' % {
Edward Lemur1b52d872019-05-09 21:12:12 +00001033 'short_hostname': short_hostname,
1034 'change_id': change_id,
1035 'description': final_description,
1036 'title': original_title,
Edward Lemur75391d42019-05-14 23:35:56 +00001037 'trace_name': 'TRACES_DIR/20170316T200041.000000',
Edward Lemur1b52d872019-05-09 21:12:12 +00001038 }],),
1039 None,
1040 ),
1041 # Read traces and shorten git hashes.
1042 ((['os.path.isfile', 'TEMP_DIR/trace-packet'],),
1043 True,
1044 ),
1045 ((['FileRead', 'TEMP_DIR/trace-packet'],),
1046 ('git-hash: 0123456789012345678901234567890123456789\n'
1047 'git-hash: abcdeabcdeabcdeabcdeabcdeabcdeabcdeabcde\n'),
1048 ),
1049 ((['FileWrite', 'TEMP_DIR/trace-packet',
1050 'git-hash: 012345\n'
1051 'git-hash: abcdea\n'],),
1052 None,
1053 ),
1054 # Make zip file for the git traces.
1055 ((['make_archive', 'TRACES_DIR/20170316T200041.000000-traces', 'zip',
1056 'TEMP_DIR'],),
1057 None,
1058 ),
1059 # Collect git config and gitcookies.
1060 ((['git', 'config', '-l'],),
1061 'git-config-output',
1062 ),
1063 ((['FileWrite', 'TEMP_DIR/git-config', 'git-config-output'],),
1064 None,
1065 ),
1066 ((['os.path.isfile', '~/.gitcookies'],),
1067 gitcookies_exists,
1068 ),
1069 ]
1070 if gitcookies_exists:
1071 calls += [
1072 ((['FileRead', '~/.gitcookies'],),
1073 'gitcookies 1/SECRET',
1074 ),
1075 ((['FileWrite', 'TEMP_DIR/gitcookies', 'gitcookies REDACTED'],),
1076 None,
1077 ),
1078 ]
1079 calls += [
1080 # Make zip file for the git config and gitcookies.
1081 ((['make_archive', 'TRACES_DIR/20170316T200041.000000-git-info', 'zip',
1082 'TEMP_DIR'],),
1083 None,
1084 ),
1085 ]
1086
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001087 # TODO(crbug/877717): this should never be used.
1088 if squash and short_hostname != 'chromium':
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001089 calls += [
1090 (('AddReviewers',
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001091 'chromium-review.googlesource.com', 'my%2Frepo~123456',
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001092 sorted(reviewers),
Edward Lemur227d5102020-02-25 23:45:35 +00001093 cc + ['test-more-cc@chromium.org'],
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00001094 notify),
1095 ''),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001096 ]
Edward Lemur26964072020-02-19 19:18:51 +00001097 calls += [
1098 ((['git', 'rev-parse', 'HEAD'],), 'hash'),
1099 ]
ukai@chromium.orge8077812012-02-03 03:41:46 +00001100 return calls
1101
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001102 def _run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001103 self,
1104 upload_args,
1105 description,
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001106 reviewers=None,
tandriia60502f2016-06-20 02:01:53 -07001107 squash=True,
1108 squash_mode=None,
tandrii@chromium.org10625002016-03-04 20:03:47 +00001109 expected_upstream_ref='origin/refs/heads/master',
Aaron Gable9b713dd2016-12-14 16:04:21 -08001110 title=None,
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001111 notify=False,
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001112 post_amend_description=None,
bradnelsond975b302016-10-23 12:20:23 -07001113 issue=None,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +01001114 cc=None,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001115 fetched_status=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001116 other_cl_owner=None,
Aaron Gablefd238082017-06-07 13:42:34 -07001117 custom_cl_base=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001118 tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001119 short_hostname='chromium',
Edward Lemur1b52d872019-05-09 21:12:12 +00001120 labels=None,
1121 change_id=None,
1122 original_title=None,
1123 final_description=None,
Anthony Polito8b955342019-09-24 19:01:36 +00001124 gitcookies_exists=True,
1125 force=False,
Josipe827b0f2020-01-30 00:07:20 +00001126 edit_description=None,
Anthony Polito8b955342019-09-24 19:01:36 +00001127 fetched_description=None):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001128 """Generic gerrit upload test framework."""
tandriia60502f2016-06-20 02:01:53 -07001129 if squash_mode is None:
1130 if '--no-squash' in upload_args:
1131 squash_mode = 'nosquash'
1132 elif '--squash' in upload_args:
1133 squash_mode = 'squash'
1134 else:
1135 squash_mode = 'default'
1136
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001137 reviewers = reviewers or []
bradnelsond975b302016-10-23 12:20:23 -07001138 cc = cc or []
Edward Lemurda4b6c62020-02-13 00:28:40 +00001139 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001140 CookiesAuthenticatorMockFactory(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001141 same_auth=('git-owner.example.com', '', 'pass'))).start()
1142 mock.patch('git_cl.Changelist._GerritCommitMsgHookCheck',
1143 lambda _, offer_removal: None).start()
1144 mock.patch('git_cl.gclient_utils.RunEditor',
1145 lambda *_, **__: self._mocked_call(['RunEditor'])).start()
1146 mock.patch('git_cl.DownloadGerritHook', lambda force: self._mocked_call(
1147 'DownloadGerritHook', force)).start()
1148 mock.patch('git_cl.gclient_utils.FileRead',
1149 lambda path: self._mocked_call(['FileRead', path])).start()
1150 mock.patch('git_cl.gclient_utils.FileWrite',
Edward Lemur1b52d872019-05-09 21:12:12 +00001151 lambda path, contents: self._mocked_call(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001152 ['FileWrite', path, contents])).start()
1153 mock.patch('git_cl.datetime_now',
1154 lambda: datetime.datetime(2017, 3, 16, 20, 0, 41, 0)).start()
1155 mock.patch('git_cl.tempfile.mkdtemp', lambda: 'TEMP_DIR').start()
1156 mock.patch('git_cl.TRACES_DIR', 'TRACES_DIR').start()
1157 mock.patch('git_cl.TRACES_README_FORMAT',
Edward Lemur75391d42019-05-14 23:35:56 +00001158 '%(now)s\n'
1159 '%(gerrit_host)s\n'
1160 '%(change_id)s\n'
1161 '%(title)s\n'
1162 '%(description)s\n'
1163 '%(execution_time)s\n'
1164 '%(exit_code)s\n'
Edward Lemurda4b6c62020-02-13 00:28:40 +00001165 '%(trace_name)s').start()
1166 mock.patch('git_cl.shutil.make_archive',
1167 lambda *args: self._mocked_call(['make_archive'] +
1168 list(args))).start()
1169 mock.patch('os.path.isfile',
1170 lambda path: self._mocked_call(['os.path.isfile', path])).start()
Edward Lemurd55c5072020-02-20 01:09:07 +00001171 mock.patch('git_cl.Changelist.GitSanityChecks', return_value=True).start()
Edward Lemur9aa1a962020-02-25 00:58:38 +00001172 mock.patch(
1173 'git_cl.Changelist.GetLocalDescription', return_value='foo').start()
tandriia60502f2016-06-20 02:01:53 -07001174
Edward Lemur26964072020-02-19 19:18:51 +00001175 self.mockGit.config['gerrit.host'] = 'true'
Edward Lemur85153282020-02-14 22:06:29 +00001176 self.mockGit.config['branch.master.gerritissue'] = (
1177 str(issue) if issue else None)
1178 self.mockGit.config['remote.origin.url'] = (
1179 'https://%s.googlesource.com/my/repo' % short_hostname)
Edward Lemur9aa1a962020-02-25 00:58:38 +00001180 self.mockGit.config['user.email'] = 'me@example.com'
Edward Lemur85153282020-02-14 22:06:29 +00001181
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001182 self.calls = self._gerrit_base_calls(
1183 issue=issue,
Anthony Polito8b955342019-09-24 19:01:36 +00001184 fetched_description=fetched_description or description,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001185 fetched_status=fetched_status,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001186 other_cl_owner=other_cl_owner,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001187 custom_cl_base=custom_cl_base,
Anthony Polito8b955342019-09-24 19:01:36 +00001188 short_hostname=short_hostname,
1189 change_id=change_id)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001190 if fetched_status != 'ABANDONED':
Edward Lemurda4b6c62020-02-13 00:28:40 +00001191 mock.patch(
Edward Lemur1773f372020-02-22 00:27:14 +00001192 'gclient_utils.temporary_file', TemporaryFileMock()).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00001193 mock.patch('os.remove', return_value=True).start()
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001194 self.calls += self._gerrit_upload_calls(
1195 description, reviewers, squash,
1196 squash_mode=squash_mode,
1197 expected_upstream_ref=expected_upstream_ref,
Aaron Gablefd238082017-06-07 13:42:34 -07001198 title=title, notify=notify,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001199 post_amend_description=post_amend_description,
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001200 issue=issue, cc=cc,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001201 custom_cl_base=custom_cl_base, tbr=tbr,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001202 short_hostname=short_hostname,
Edward Lemur1b52d872019-05-09 21:12:12 +00001203 labels=labels,
1204 change_id=change_id,
1205 original_title=original_title,
1206 final_description=final_description,
Anthony Polito8b955342019-09-24 19:01:36 +00001207 gitcookies_exists=gitcookies_exists,
Josipe827b0f2020-01-30 00:07:20 +00001208 force=force,
1209 edit_description=edit_description)
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001210 # Uncomment when debugging.
Raul Tambre80ee78e2019-05-06 22:41:05 +00001211 # print('\n'.join(map(lambda x: '%2i: %s' % x, enumerate(self.calls))))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001212 git_cl.main(['upload'] + upload_args)
Edward Lemur85153282020-02-14 22:06:29 +00001213 if squash:
Edward Lemur26964072020-02-19 19:18:51 +00001214 self.assertIssueAndPatchset(patchset=None)
Edward Lemur85153282020-02-14 22:06:29 +00001215 self.assertEqual(
1216 'abcdef0123456789',
Edward Lemur26964072020-02-19 19:18:51 +00001217 scm.GIT.GetBranchConfig('', 'master', 'gerritsquashhash'))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001218
Edward Lemur1b52d872019-05-09 21:12:12 +00001219 def test_gerrit_upload_traces_no_gitcookies(self):
1220 self._run_gerrit_upload_test(
1221 ['--no-squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001222 'desc ✔\n\nBUG=\n',
Edward Lemur1b52d872019-05-09 21:12:12 +00001223 [],
1224 squash=False,
Edward Lemur0db01f02019-11-12 22:01:51 +00001225 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001226 change_id='Ixxx',
1227 gitcookies_exists=False)
1228
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001229 def test_gerrit_upload_without_change_id(self):
tandriia60502f2016-06-20 02:01:53 -07001230 self._run_gerrit_upload_test(
1231 ['--no-squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001232 'desc ✔\n\nBUG=\n',
tandriia60502f2016-06-20 02:01:53 -07001233 [],
1234 squash=False,
Edward Lemur0db01f02019-11-12 22:01:51 +00001235 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001236 change_id='Ixxx')
tandriia60502f2016-06-20 02:01:53 -07001237
1238 def test_gerrit_upload_without_change_id_override_nosquash(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001239 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001240 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001241 'desc ✔\n\nBUG=\n',
tandrii@chromium.org10625002016-03-04 20:03:47 +00001242 [],
tandriia60502f2016-06-20 02:01:53 -07001243 squash=False,
1244 squash_mode='override_nosquash',
Edward Lemur0db01f02019-11-12 22:01:51 +00001245 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001246 change_id='Ixxx')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001247
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001248 def test_gerrit_no_reviewer(self):
1249 self._run_gerrit_upload_test(
1250 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001251 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
tandriia60502f2016-06-20 02:01:53 -07001252 [],
1253 squash=False,
Edward Lemur1b52d872019-05-09 21:12:12 +00001254 squash_mode='override_nosquash',
1255 change_id='I123456789')
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001256
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001257 def test_gerrit_no_reviewer_non_chromium_host(self):
1258 # TODO(crbug/877717): remove this test case.
1259 self._run_gerrit_upload_test(
1260 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001261 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001262 [],
1263 squash=False,
1264 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001265 short_hostname='other',
1266 change_id='I123456789')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001267
Nick Carter8692b182017-11-06 16:30:38 -08001268 def test_gerrit_patchset_title_special_chars(self):
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001269 self._run_gerrit_upload_test(
Nick Carter8692b182017-11-06 16:30:38 -08001270 ['-f', '-t', 'We\'ll escape ^_ ^ special chars...@{u}'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001271 'desc ✔\n\nBUG=\n\nChange-Id: I123456789',
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001272 squash=False,
1273 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001274 title='We%27ll_escape_%5E%5F_%5E_special_chars%2E%2E%2E%40%7Bu%7D',
1275 change_id='I123456789',
1276 original_title='We\'ll escape ^_ ^ special chars...@{u}')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001277
ukai@chromium.orge8077812012-02-03 03:41:46 +00001278 def test_gerrit_reviewers_cmd_line(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001279 self._run_gerrit_upload_test(
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001280 ['-r', 'foo@example.com', '--send-mail'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001281 'desc ✔\n\nBUG=\n\nChange-Id: I123456789',
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001282 ['foo@example.com'],
tandriia60502f2016-06-20 02:01:53 -07001283 squash=False,
1284 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001285 notify=True,
1286 change_id='I123456789',
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001287 final_description=(
Edward Lemur0db01f02019-11-12 22:01:51 +00001288 'desc ✔\n\nBUG=\nR=foo@example.com\n\nChange-Id: I123456789'))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001289
Anthony Polito8b955342019-09-24 19:01:36 +00001290 def test_gerrit_upload_force_sets_bug(self):
1291 self._run_gerrit_upload_test(
1292 ['-b', '10000', '-f'],
1293 u'desc=\n\nBug: 10000\nChange-Id: Ixxx',
1294 [],
1295 force=True,
1296 expected_upstream_ref='origin/master',
1297 fetched_description='desc=\n\nChange-Id: Ixxx',
1298 original_title='Initial upload',
1299 change_id='Ixxx')
1300
1301 def test_gerrit_upload_force_sets_bug_if_wrong_changeid(self):
1302 self._run_gerrit_upload_test(
1303 ['-b', '10000', '-f', '-m', 'Title'],
1304 u'desc=\n\nChange-Id: Ixxxx\n\nChange-Id: Izzzz\nBug: 10000',
1305 [],
1306 force=True,
1307 issue='123456',
1308 expected_upstream_ref='origin/master',
1309 fetched_description='desc=\n\nChange-Id: Ixxxx',
1310 original_title='Title',
1311 title='Title',
1312 change_id='Izzzz')
1313
Dan Beamd8b04ca2019-10-10 21:23:26 +00001314 def test_gerrit_upload_force_sets_fixed(self):
1315 self._run_gerrit_upload_test(
1316 ['-x', '10000', '-f'],
1317 u'desc=\n\nFixed: 10000\nChange-Id: Ixxx',
1318 [],
1319 force=True,
1320 expected_upstream_ref='origin/master',
1321 fetched_description='desc=\n\nChange-Id: Ixxx',
1322 original_title='Initial upload',
1323 change_id='Ixxx')
1324
ukai@chromium.orge8077812012-02-03 03:41:46 +00001325 def test_gerrit_reviewer_multiple(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00001326 mock.patch('git_cl.gerrit_util.GetCodeReviewTbrScore',
1327 lambda *a: self._mocked_call('GetCodeReviewTbrScore', *a)).start()
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001328 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001329 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001330 'desc ✔\nTBR=reviewer@example.com\nBUG=\nR=another@example.com\n'
bradnelsond975b302016-10-23 12:20:23 -07001331 'CC=more@example.com,people@example.com\n\n'
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001332 'Change-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001333 ['reviewer@example.com', 'another@example.com'],
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001334 expected_upstream_ref='origin/master',
Aaron Gablefd238082017-06-07 13:42:34 -07001335 cc=['more@example.com', 'people@example.com'],
Edward Lemur687ca902018-12-05 02:30:30 +00001336 tbr='reviewer@example.com',
Edward Lemur1b52d872019-05-09 21:12:12 +00001337 labels={'Code-Review': 2},
1338 change_id='123456789',
1339 original_title='Initial upload')
tandriia60502f2016-06-20 02:01:53 -07001340
1341 def test_gerrit_upload_squash_first_is_default(self):
tandriia60502f2016-06-20 02:01:53 -07001342 self._run_gerrit_upload_test(
1343 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001344 'desc ✔\nBUG=\n\nChange-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001345 [],
Edward Lemur1b52d872019-05-09 21:12:12 +00001346 expected_upstream_ref='origin/master',
1347 change_id='123456789',
1348 original_title='Initial upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001349
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001350 def test_gerrit_upload_squash_first(self):
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001351 self._run_gerrit_upload_test(
1352 ['--squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001353 'desc ✔\nBUG=\n\nChange-Id: 123456789',
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001354 [],
luqui@chromium.org609f3952015-05-04 22:47:04 +00001355 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001356 expected_upstream_ref='origin/master',
1357 change_id='123456789',
1358 original_title='Initial upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001359
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001360 def test_gerrit_upload_squash_first_with_labels(self):
1361 self._run_gerrit_upload_test(
1362 ['--squash', '--cq-dry-run', '--enable-auto-submit'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001363 'desc ✔\nBUG=\n\nChange-Id: 123456789',
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001364 [],
1365 squash=True,
1366 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001367 labels={'Commit-Queue': 1, 'Auto-Submit': 1},
1368 change_id='123456789',
1369 original_title='Initial upload')
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001370
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001371 def test_gerrit_upload_squash_first_against_rev(self):
1372 custom_cl_base = 'custom_cl_base_rev_or_branch'
1373 self._run_gerrit_upload_test(
1374 ['--squash', custom_cl_base],
Edward Lemur0db01f02019-11-12 22:01:51 +00001375 'desc ✔\nBUG=\n\nChange-Id: 123456789',
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001376 [],
1377 squash=True,
1378 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001379 custom_cl_base=custom_cl_base,
1380 change_id='123456789',
1381 original_title='Initial upload')
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001382 self.assertIn(
1383 'If you proceed with upload, more than 1 CL may be created by Gerrit',
1384 sys.stdout.getvalue())
1385
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001386 def test_gerrit_upload_squash_reupload(self):
Edward Lemur0db01f02019-11-12 22:01:51 +00001387 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001388 self._run_gerrit_upload_test(
1389 ['--squash'],
1390 description,
1391 [],
1392 squash=True,
1393 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001394 issue=123456,
1395 change_id='123456789',
1396 original_title='User input')
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001397
Edward Lemurd55c5072020-02-20 01:09:07 +00001398 @mock.patch('sys.stderr', StringIO())
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001399 def test_gerrit_upload_squash_reupload_to_abandoned(self):
Edward Lemur0db01f02019-11-12 22:01:51 +00001400 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001401 with self.assertRaises(SystemExitMock):
1402 self._run_gerrit_upload_test(
1403 ['--squash'],
1404 description,
1405 [],
1406 squash=True,
1407 expected_upstream_ref='origin/master',
1408 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001409 fetched_status='ABANDONED',
1410 change_id='123456789')
Edward Lemurd55c5072020-02-20 01:09:07 +00001411 self.assertEqual(
1412 'Change https://chromium-review.googlesource.com/123456 has been '
1413 'abandoned, new uploads are not allowed\n',
1414 sys.stderr.getvalue())
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001415
Edward Lemurda4b6c62020-02-13 00:28:40 +00001416 @mock.patch(
1417 'gerrit_util.GetAccountDetails',
1418 return_value={'email': 'yet-another@example.com'})
1419 def test_gerrit_upload_squash_reupload_to_not_owned(self, _mock):
Edward Lemur0db01f02019-11-12 22:01:51 +00001420 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001421 self._run_gerrit_upload_test(
1422 ['--squash'],
1423 description,
1424 [],
1425 squash=True,
1426 expected_upstream_ref='origin/master',
1427 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001428 other_cl_owner='other@example.com',
1429 change_id='123456789',
1430 original_title='User input')
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001431 self.assertIn(
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001432 'WARNING: Change 123456 is owned by other@example.com, but you '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001433 'authenticate to Gerrit as yet-another@example.com.\n'
1434 'Uploading may fail due to lack of permissions',
Edward Lemurda4b6c62020-02-13 00:28:40 +00001435 sys.stdout.getvalue())
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001436
Josipe827b0f2020-01-30 00:07:20 +00001437 def test_upload_change_description_editor(self):
1438 fetched_description = 'foo\n\nChange-Id: 123456789'
1439 description = 'bar\n\nChange-Id: 123456789'
1440 self._run_gerrit_upload_test(
1441 ['--squash', '--edit-description'],
1442 description,
1443 [],
1444 fetched_description=fetched_description,
1445 squash=True,
1446 expected_upstream_ref='origin/master',
1447 issue=123456,
1448 change_id='123456789',
1449 original_title='User input',
1450 edit_description=description)
1451
Edward Lemurda4b6c62020-02-13 00:28:40 +00001452 @mock.patch('git_cl.RunGit')
1453 @mock.patch('git_cl.CMDupload')
1454 @mock.patch('git_cl.ask_for_data')
1455 def test_upload_branch_deps(self, *_mocks):
rmistry@google.com2dd99862015-06-22 12:22:18 +00001456 def mock_run_git(*args, **_kwargs):
1457 if args[0] == ['for-each-ref',
1458 '--format=%(refname:short) %(upstream:short)',
1459 'refs/heads']:
1460 # Create a local branch dependency tree that looks like this:
1461 # test1 -> test2 -> test3 -> test4 -> test5
1462 # -> test3.1
1463 # test6 -> test0
1464 branch_deps = [
1465 'test2 test1', # test1 -> test2
1466 'test3 test2', # test2 -> test3
1467 'test3.1 test2', # test2 -> test3.1
1468 'test4 test3', # test3 -> test4
1469 'test5 test4', # test4 -> test5
1470 'test6 test0', # test0 -> test6
1471 'test7', # test7
1472 ]
1473 return '\n'.join(branch_deps)
Edward Lemurda4b6c62020-02-13 00:28:40 +00001474 git_cl.RunGit.side_effect = mock_run_git
1475 git_cl.CMDupload.return_value = 0
rmistry@google.com2dd99862015-06-22 12:22:18 +00001476
1477 class MockChangelist():
1478 def __init__(self):
1479 pass
1480 def GetBranch(self):
1481 return 'test1'
1482 def GetIssue(self):
1483 return '123'
1484 def GetPatchset(self):
1485 return '1001'
tandrii@chromium.org4c72b082016-03-31 22:26:35 +00001486 def IsGerrit(self):
1487 return False
rmistry@google.com2dd99862015-06-22 12:22:18 +00001488
1489 ret = git_cl.upload_branch_deps(MockChangelist(), [])
1490 # CMDupload should have been called 5 times because of 5 dependent branches.
Edward Lemurda4b6c62020-02-13 00:28:40 +00001491 self.assertEqual(5, len(git_cl.CMDupload.mock_calls))
1492 git_cl.ask_for_data.assert_called_once_with(
1493 'This command will checkout all dependent branches '
1494 'and run "git cl upload". Press Enter to continue, '
1495 'or Ctrl+C to abort')
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00001496 self.assertEqual(0, ret)
rmistry@google.com2dd99862015-06-22 12:22:18 +00001497
tandrii@chromium.org65874e12016-03-04 12:03:02 +00001498 def test_gerrit_change_id(self):
1499 self.calls = [
1500 ((['git', 'write-tree'], ),
1501 'hashtree'),
1502 ((['git', 'rev-parse', 'HEAD~0'], ),
1503 'branch-parent'),
1504 ((['git', 'var', 'GIT_AUTHOR_IDENT'], ),
1505 'A B <a@b.org> 1456848326 +0100'),
1506 ((['git', 'var', 'GIT_COMMITTER_IDENT'], ),
1507 'C D <c@d.org> 1456858326 +0100'),
1508 ((['git', 'hash-object', '-t', 'commit', '--stdin'], ),
1509 'hashchange'),
1510 ]
1511 change_id = git_cl.GenerateGerritChangeId('line1\nline2\n')
1512 self.assertEqual(change_id, 'Ihashchange')
1513
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001514 def test_desecription_append_footer(self):
1515 for init_desc, footer_line, expected_desc in [
1516 # Use unique desc first lines for easy test failure identification.
1517 ('foo', 'R=one', 'foo\n\nR=one'),
1518 ('foo\n\nR=one', 'BUG=', 'foo\n\nR=one\nBUG='),
1519 ('foo\n\nR=one', 'Change-Id: Ixx', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1520 ('foo\n\nChange-Id: Ixx', 'R=one', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1521 ('foo\n\nR=one\n\nChange-Id: Ixx', 'TBR=two',
1522 'foo\n\nR=one\nTBR=two\n\nChange-Id: Ixx'),
1523 ('foo\n\nR=one\n\nChange-Id: Ixx', 'Foo-Bar: baz',
1524 'foo\n\nR=one\n\nChange-Id: Ixx\nFoo-Bar: baz'),
1525 ('foo\n\nChange-Id: Ixx', 'Foo-Bak: baz',
1526 'foo\n\nChange-Id: Ixx\nFoo-Bak: baz'),
1527 ('foo', 'Change-Id: Ixx', 'foo\n\nChange-Id: Ixx'),
1528 ]:
1529 desc = git_cl.ChangeDescription(init_desc)
1530 desc.append_footer(footer_line)
1531 self.assertEqual(desc.description, expected_desc)
1532
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001533 def test_update_reviewers(self):
1534 data = [
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001535 ('foo', [], [],
1536 'foo'),
1537 ('foo\nR=xx', [], [],
1538 'foo\nR=xx'),
1539 ('foo\nTBR=xx', [], [],
1540 'foo\nTBR=xx'),
1541 ('foo', ['a@c'], [],
1542 'foo\n\nR=a@c'),
1543 ('foo\nR=xx', ['a@c'], [],
1544 'foo\n\nR=a@c, xx'),
1545 ('foo\nTBR=xx', ['a@c'], [],
1546 'foo\n\nR=a@c\nTBR=xx'),
1547 ('foo\nTBR=xx\nR=yy', ['a@c'], [],
1548 'foo\n\nR=a@c, yy\nTBR=xx'),
1549 ('foo\nBUG=', ['a@c'], [],
1550 'foo\nBUG=\nR=a@c'),
1551 ('foo\nR=xx\nTBR=yy\nR=bar', ['a@c'], [],
1552 'foo\n\nR=a@c, bar, xx\nTBR=yy'),
1553 ('foo', ['a@c', 'b@c'], [],
1554 'foo\n\nR=a@c, b@c'),
1555 ('foo\nBar\n\nR=\nBUG=', ['c@c'], [],
1556 'foo\nBar\n\nR=c@c\nBUG='),
1557 ('foo\nBar\n\nR=\nBUG=\nR=', ['c@c'], [],
1558 'foo\nBar\n\nR=c@c\nBUG='),
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001559 # Same as the line before, but full of whitespaces.
1560 (
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001561 'foo\nBar\n\n R = \n BUG = \n R = ', ['c@c'], [],
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001562 'foo\nBar\n\nR=c@c\n BUG =',
1563 ),
1564 # Whitespaces aren't interpreted as new lines.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001565 ('foo BUG=allo R=joe ', ['c@c'], [],
1566 'foo BUG=allo R=joe\n\nR=c@c'),
1567 # Redundant TBRs get promoted to Rs
1568 ('foo\n\nR=a@c\nTBR=t@c', ['b@c', 'a@c'], ['a@c', 't@c'],
1569 'foo\n\nR=a@c, b@c\nTBR=t@c'),
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001570 ]
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001571 expected = [i[-1] for i in data]
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001572 actual = []
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001573 for orig, reviewers, tbrs, _expected in data:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001574 obj = git_cl.ChangeDescription(orig)
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001575 obj.update_reviewers(reviewers, tbrs)
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001576 actual.append(obj.description)
1577 self.assertEqual(expected, actual)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001578
Nodir Turakulov23b82142017-11-16 11:04:25 -08001579 def test_get_hash_tags(self):
1580 cases = [
1581 ('', []),
1582 ('a', []),
1583 ('[a]', ['a']),
1584 ('[aa]', ['aa']),
1585 ('[a ]', ['a']),
1586 ('[a- ]', ['a']),
1587 ('[a- b]', ['a-b']),
1588 ('[a--b]', ['a-b']),
1589 ('[a', []),
1590 ('[a]x', ['a']),
1591 ('[aa]x', ['aa']),
1592 ('[a b]', ['a-b']),
1593 ('[a b]', ['a-b']),
1594 ('[a__b]', ['a-b']),
1595 ('[a] x', ['a']),
1596 ('[a][b]', ['a', 'b']),
1597 ('[a] [b]', ['a', 'b']),
1598 ('[a][b]x', ['a', 'b']),
1599 ('[a][b] x', ['a', 'b']),
1600 ('[a]\n[b]', ['a']),
1601 ('[a\nb]', []),
1602 ('[a][', ['a']),
1603 ('Revert "[a] feature"', ['a']),
1604 ('Reland "[a] feature"', ['a']),
1605 ('Revert: [a] feature', ['a']),
1606 ('Reland: [a] feature', ['a']),
1607 ('Revert "Reland: [a] feature"', ['a']),
1608 ('Foo: feature', ['foo']),
1609 ('Foo Bar: feature', ['foo-bar']),
Anthony Polito02b5af32019-12-02 19:49:47 +00001610 ('Change Foo::Bar', []),
1611 ('Foo: Change Foo::Bar', ['foo']),
Nodir Turakulov23b82142017-11-16 11:04:25 -08001612 ('Revert "Foo bar: feature"', ['foo-bar']),
1613 ('Reland "Foo bar: feature"', ['foo-bar']),
1614 ]
1615 for desc, expected in cases:
1616 change_desc = git_cl.ChangeDescription(desc)
1617 actual = change_desc.get_hash_tags()
1618 self.assertEqual(
1619 actual,
1620 expected,
1621 'GetHashTags(%r) == %r, expected %r' % (desc, actual, expected))
1622
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001623 self.assertEqual(None, git_cl.GetTargetRef('origin', None, 'master'))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001624 self.assertEqual(None, git_cl.GetTargetRef(None,
1625 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001626 'master'))
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001627
wittman@chromium.org455dc922015-01-26 20:15:50 +00001628 # Check default target refs for branches.
1629 self.assertEqual('refs/heads/master',
1630 git_cl.GetTargetRef('origin', 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001631 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001632 self.assertEqual('refs/heads/master',
1633 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkgr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001634 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001635 self.assertEqual('refs/heads/master',
1636 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkcr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001637 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001638 self.assertEqual('refs/branch-heads/123',
1639 git_cl.GetTargetRef('origin',
1640 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001641 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001642 self.assertEqual('refs/diff/test',
1643 git_cl.GetTargetRef('origin',
1644 'refs/remotes/origin/refs/diff/test',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001645 None))
rmistry@google.comc68112d2015-03-03 12:48:06 +00001646 self.assertEqual('refs/heads/chrome/m42',
1647 git_cl.GetTargetRef('origin',
1648 'refs/remotes/origin/chrome/m42',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001649 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001650
1651 # Check target refs for user-specified target branch.
1652 for branch in ('branch-heads/123', 'remotes/branch-heads/123',
1653 'refs/remotes/branch-heads/123'):
1654 self.assertEqual('refs/branch-heads/123',
1655 git_cl.GetTargetRef('origin',
1656 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001657 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001658 for branch in ('origin/master', 'remotes/origin/master',
1659 'refs/remotes/origin/master'):
1660 self.assertEqual('refs/heads/master',
1661 git_cl.GetTargetRef('origin',
1662 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001663 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001664 for branch in ('master', 'heads/master', 'refs/heads/master'):
1665 self.assertEqual('refs/heads/master',
1666 git_cl.GetTargetRef('origin',
1667 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001668 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001669
Edward Lemurda4b6c62020-02-13 00:28:40 +00001670 @mock.patch('git_common.is_dirty_git_tree', return_value=True)
1671 def test_patch_when_dirty(self, *_mocks):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001672 # Patch when local tree is dirty.
wychen@chromium.orga872e752015-04-28 23:42:18 +00001673 self.assertNotEqual(git_cl.main(['patch', '123456']), 0)
1674
Edward Lemur85153282020-02-14 22:06:29 +00001675 def assertIssueAndPatchset(
1676 self, branch='master', issue='123456', patchset='7',
1677 git_short_host='chromium'):
1678 self.assertEqual(
Edward Lemur26964072020-02-19 19:18:51 +00001679 issue, scm.GIT.GetBranchConfig('', branch, 'gerritissue'))
Edward Lemur85153282020-02-14 22:06:29 +00001680 self.assertEqual(
Edward Lemur26964072020-02-19 19:18:51 +00001681 patchset, scm.GIT.GetBranchConfig('', branch, 'gerritpatchset'))
Edward Lemur85153282020-02-14 22:06:29 +00001682 self.assertEqual(
1683 'https://%s-review.googlesource.com' % git_short_host,
Edward Lemur26964072020-02-19 19:18:51 +00001684 scm.GIT.GetBranchConfig('', branch, 'gerritserver'))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001685
Edward Lemur85153282020-02-14 22:06:29 +00001686 def _patch_common(self, git_short_host='chromium'):
Edward Lemurda4b6c62020-02-13 00:28:40 +00001687 mock.patch('git_cl.IsGitVersionAtLeast', return_value=True).start()
Edward Lemur26964072020-02-19 19:18:51 +00001688 self.mockGit.config['remote.origin.url'] = (
1689 'https://%s.googlesource.com/my/repo' % git_short_host)
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001690 gerrit_util.GetChangeDetail.return_value = {
1691 'current_revision': '7777777777',
1692 'revisions': {
1693 '1111111111': {
1694 '_number': 1,
1695 'fetch': {'http': {
1696 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1697 'ref': 'refs/changes/56/123456/1',
1698 }},
1699 },
1700 '7777777777': {
1701 '_number': 7,
1702 'fetch': {'http': {
1703 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1704 'ref': 'refs/changes/56/123456/7',
1705 }},
1706 },
1707 },
1708 }
wychen@chromium.orga872e752015-04-28 23:42:18 +00001709
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001710 def test_patch_gerrit_default(self):
Edward Lemur85153282020-02-14 22:06:29 +00001711 self._patch_common()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001712 self.calls += [
1713 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1714 'refs/changes/56/123456/7'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001715 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001716 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001717 ]
1718 self.assertEqual(git_cl.main(['patch', '123456']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001719 self.assertIssueAndPatchset()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001720
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001721 def test_patch_gerrit_new_branch(self):
Edward Lemur85153282020-02-14 22:06:29 +00001722 self._patch_common()
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001723 self.calls += [
1724 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1725 'refs/changes/56/123456/7'],), ''),
1726 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001727 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001728 ]
Edward Lemur85153282020-02-14 22:06:29 +00001729 self.assertEqual(git_cl.main(['patch', '-b', 'feature', '123456']), 0)
1730 self.assertIssueAndPatchset(branch='feature')
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001731
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001732 def test_patch_gerrit_force(self):
Edward Lemur85153282020-02-14 22:06:29 +00001733 self._patch_common('host')
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001734 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001735 ((['git', 'fetch', 'https://host.googlesource.com/my/repo',
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001736 'refs/changes/56/123456/7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001737 ((['git', 'reset', '--hard', 'FETCH_HEAD'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001738 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001739 ]
Edward Lemur52969c92020-02-06 18:15:28 +00001740 self.assertEqual(git_cl.main(['patch', '123456', '--force']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001741 self.assertIssueAndPatchset(git_short_host='host')
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001742
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001743 def test_patch_gerrit_guess_by_url(self):
Edward Lemur85153282020-02-14 22:06:29 +00001744 self._patch_common('else')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001745 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001746 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001747 'refs/changes/56/123456/1'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001748 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001749 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001750 ]
1751 self.assertEqual(git_cl.main(
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001752 ['patch', 'https://else-review.googlesource.com/#/c/123456/1']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001753 self.assertIssueAndPatchset(patchset='1', git_short_host='else')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001754
Aaron Gable697a91b2018-01-19 15:20:15 -08001755 def test_patch_gerrit_guess_by_url_with_repo(self):
Edward Lemur85153282020-02-14 22:06:29 +00001756 self._patch_common('else')
Aaron Gable697a91b2018-01-19 15:20:15 -08001757 self.calls += [
1758 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
1759 'refs/changes/56/123456/1'],), ''),
1760 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
Aaron Gable697a91b2018-01-19 15:20:15 -08001761 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
Aaron Gable697a91b2018-01-19 15:20:15 -08001762 ]
1763 self.assertEqual(git_cl.main(
1764 ['patch', 'https://else-review.googlesource.com/c/my/repo/+/123456/1']),
1765 0)
Edward Lemur85153282020-02-14 22:06:29 +00001766 self.assertIssueAndPatchset(patchset='1', git_short_host='else')
Aaron Gable697a91b2018-01-19 15:20:15 -08001767
Edward Lemurd55c5072020-02-20 01:09:07 +00001768 @mock.patch('sys.stderr', StringIO())
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001769 def test_patch_gerrit_conflict(self):
Edward Lemur85153282020-02-14 22:06:29 +00001770 self._patch_common()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001771 self.calls += [
1772 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001773 'refs/changes/56/123456/7'],), ''),
tandrii5d48c322016-08-18 16:19:37 -07001774 ((['git', 'cherry-pick', 'FETCH_HEAD'],), CERR1),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001775 ]
1776 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001777 git_cl.main(['patch', '123456'])
Edward Lemurd55c5072020-02-20 01:09:07 +00001778 self.assertEqual(
1779 'Command "git cherry-pick FETCH_HEAD" failed.\n\n',
1780 sys.stderr.getvalue())
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001781
Edward Lemurda4b6c62020-02-13 00:28:40 +00001782 @mock.patch(
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001783 'gerrit_util.GetChangeDetail',
Edward Lemurda4b6c62020-02-13 00:28:40 +00001784 side_effect=gerrit_util.GerritError(404, ''))
Edward Lemurd55c5072020-02-20 01:09:07 +00001785 @mock.patch('sys.stderr', StringIO())
Edward Lemurda4b6c62020-02-13 00:28:40 +00001786 def test_patch_gerrit_not_exists(self, *_mocks):
Edward Lemur26964072020-02-19 19:18:51 +00001787 self.mockGit.config['remote.origin.url'] = (
1788 'https://chromium.googlesource.com/my/repo')
tandriic2405f52016-10-10 08:13:15 -07001789 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001790 self.assertEqual(1, git_cl.main(['patch', '123456']))
Edward Lemurd55c5072020-02-20 01:09:07 +00001791 self.assertEqual(
1792 'change 123456 at https://chromium-review.googlesource.com does not '
1793 'exist or you have no access to it\n',
1794 sys.stderr.getvalue())
tandriic2405f52016-10-10 08:13:15 -07001795
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001796 def _checkout_calls(self):
1797 return [
1798 ((['git', 'config', '--local', '--get-regexp',
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001799 'branch\\..*\\.gerritissue'], ),
1800 ('branch.ger-branch.gerritissue 123456\n'
1801 'branch.gbranch654.gerritissue 654321\n')),
1802 ]
1803
1804 def test_checkout_gerrit(self):
1805 """Tests git cl checkout <issue>."""
1806 self.calls = self._checkout_calls()
1807 self.calls += [((['git', 'checkout', 'ger-branch'], ), '')]
1808 self.assertEqual(0, git_cl.main(['checkout', '123456']))
1809
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001810 def test_checkout_not_found(self):
1811 """Tests git cl checkout <issue>."""
1812 self.calls = self._checkout_calls()
1813 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1814
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001815 def test_checkout_no_branch_issues(self):
1816 """Tests git cl checkout <issue>."""
1817 self.calls = [
1818 ((['git', 'config', '--local', '--get-regexp',
tandrii5d48c322016-08-18 16:19:37 -07001819 'branch\\..*\\.gerritissue'], ), CERR1),
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001820 ]
1821 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1822
Edward Lemur26964072020-02-19 19:18:51 +00001823 def _test_gerrit_ensure_authenticated_common(self, auth):
Edward Lemurda4b6c62020-02-13 00:28:40 +00001824 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
1825 CookiesAuthenticatorMockFactory(hosts_with_creds=auth)).start()
Edward Lemur26964072020-02-19 19:18:51 +00001826 self.mockGit.config['remote.origin.url'] = (
1827 'https://chromium.googlesource.com/my/repo')
Edward Lemurf38bc172019-09-03 21:02:13 +00001828 cl = git_cl.Changelist()
tandrii@chromium.org28253532016-04-14 13:46:56 +00001829 cl.branch = 'master'
1830 cl.branchref = 'refs/heads/master'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001831 return cl
1832
Edward Lemurd55c5072020-02-20 01:09:07 +00001833 @mock.patch('sys.stderr', StringIO())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001834 def test_gerrit_ensure_authenticated_missing(self):
1835 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001836 'chromium.googlesource.com': ('git-is.ok', '', 'but gerrit is missing'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001837 })
Edward Lemurd55c5072020-02-20 01:09:07 +00001838 with self.assertRaises(SystemExitMock):
1839 cl.EnsureAuthenticated(force=False)
1840 self.assertEqual(
1841 'Credentials for the following hosts are required:\n'
1842 ' chromium-review.googlesource.com\n'
1843 'These are read from ~/.gitcookies (or legacy ~/.netrc)\n'
1844 'You can (re)generate your credentials by visiting '
1845 'https://chromium-review.googlesource.com/new-password\n',
1846 sys.stderr.getvalue())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001847
1848 def test_gerrit_ensure_authenticated_conflict(self):
1849 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001850 'chromium.googlesource.com':
1851 ('git-one.example.com', None, 'secret1'),
1852 'chromium-review.googlesource.com':
1853 ('git-other.example.com', None, 'secret2'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001854 })
1855 self.calls.append(
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001856 (('ask_for_data', 'If you know what you are doing '
1857 'press Enter to continue, or Ctrl+C to abort'), ''))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001858 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1859
1860 def test_gerrit_ensure_authenticated_ok(self):
1861 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001862 'chromium.googlesource.com':
1863 ('git-same.example.com', None, 'secret'),
1864 'chromium-review.googlesource.com':
1865 ('git-same.example.com', None, 'secret'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001866 })
1867 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1868
tandrii@chromium.org28253532016-04-14 13:46:56 +00001869 def test_gerrit_ensure_authenticated_skipped(self):
Edward Lemur26964072020-02-19 19:18:51 +00001870 self.mockGit.config['gerrit.skip-ensure-authenticated'] = 'true'
1871 cl = self._test_gerrit_ensure_authenticated_common(auth={})
tandrii@chromium.org28253532016-04-14 13:46:56 +00001872 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1873
Eric Boren2fb63102018-10-05 13:05:03 +00001874 def test_gerrit_ensure_authenticated_bearer_token(self):
1875 cl = self._test_gerrit_ensure_authenticated_common(auth={
1876 'chromium.googlesource.com':
1877 ('', None, 'secret'),
1878 'chromium-review.googlesource.com':
1879 ('', None, 'secret'),
1880 })
1881 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1882 header = gerrit_util.CookiesAuthenticator().get_auth_header(
1883 'chromium.googlesource.com')
1884 self.assertTrue('Bearer' in header)
1885
Daniel Chengcf6269b2019-05-18 01:02:12 +00001886 def test_gerrit_ensure_authenticated_non_https(self):
Edward Lemur26964072020-02-19 19:18:51 +00001887 self.mockGit.config['remote.origin.url'] = 'custom-scheme://repo'
Daniel Chengcf6269b2019-05-18 01:02:12 +00001888 self.calls = [
Josip906bfde2020-01-31 22:38:49 +00001889 (('logging.warning',
1890 'Ignoring branch %(branch)s with non-https remote '
1891 '%(remote)s', {
1892 'branch': 'master',
1893 'remote': 'custom-scheme://repo'}
1894 ), None),
Daniel Chengcf6269b2019-05-18 01:02:12 +00001895 ]
Edward Lemurda4b6c62020-02-13 00:28:40 +00001896 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
1897 CookiesAuthenticatorMockFactory(hosts_with_creds={})).start()
1898 mock.patch('logging.warning',
1899 lambda *a: self._mocked_call('logging.warning', *a)).start()
Edward Lemurf38bc172019-09-03 21:02:13 +00001900 cl = git_cl.Changelist()
Daniel Chengcf6269b2019-05-18 01:02:12 +00001901 cl.branch = 'master'
1902 cl.branchref = 'refs/heads/master'
1903 cl.lookedup_issue = True
1904 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1905
Florian Mayerae510e82020-01-30 21:04:48 +00001906 def test_gerrit_ensure_authenticated_non_url(self):
Edward Lemur26964072020-02-19 19:18:51 +00001907 self.mockGit.config['remote.origin.url'] = (
1908 'git@somehost.example:foo/bar.git')
Florian Mayerae510e82020-01-30 21:04:48 +00001909 self.calls = [
Josip906bfde2020-01-31 22:38:49 +00001910 (('logging.error',
1911 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
1912 'but it doesn\'t exist.', {
1913 'remote': 'origin',
1914 'branch': 'master',
1915 'url': 'git@somehost.example:foo/bar.git'}
1916 ), None),
Florian Mayerae510e82020-01-30 21:04:48 +00001917 ]
Edward Lemurda4b6c62020-02-13 00:28:40 +00001918 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
1919 CookiesAuthenticatorMockFactory(hosts_with_creds={})).start()
1920 mock.patch('logging.error',
1921 lambda *a: self._mocked_call('logging.error', *a)).start()
Florian Mayerae510e82020-01-30 21:04:48 +00001922 cl = git_cl.Changelist()
1923 cl.branch = 'master'
1924 cl.branchref = 'refs/heads/master'
1925 cl.lookedup_issue = True
1926 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1927
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01001928 def _cmd_set_commit_gerrit_common(self, vote, notify=None):
Edward Lemur85153282020-02-14 22:06:29 +00001929 self.mockGit.config['branch.master.gerritissue'] = '123'
1930 self.mockGit.config['branch.master.gerritserver'] = (
1931 'https://chromium-review.googlesource.com')
Edward Lemur26964072020-02-19 19:18:51 +00001932 self.mockGit.config['remote.origin.url'] = (
1933 'https://chromium.googlesource.com/infra/infra')
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001934 self.calls = [
Edward Lemurda4b6c62020-02-13 00:28:40 +00001935 (('SetReview', 'chromium-review.googlesource.com',
1936 'infra%2Finfra~123', None,
1937 {'Commit-Queue': vote}, notify, None), ''),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001938 ]
tandriid9e5ce52016-07-13 02:32:59 -07001939
1940 def test_cmd_set_commit_gerrit_clear(self):
1941 self._cmd_set_commit_gerrit_common(0)
1942 self.assertEqual(0, git_cl.main(['set-commit', '-c']))
1943
1944 def test_cmd_set_commit_gerrit_dry(self):
Aaron Gable75e78722017-06-09 10:40:16 -07001945 self._cmd_set_commit_gerrit_common(1, notify=False)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001946 self.assertEqual(0, git_cl.main(['set-commit', '-d']))
1947
tandriid9e5ce52016-07-13 02:32:59 -07001948 def test_cmd_set_commit_gerrit(self):
1949 self._cmd_set_commit_gerrit_common(2)
1950 self.assertEqual(0, git_cl.main(['set-commit']))
1951
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001952 def test_description_display(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00001953 mock.patch('git_cl.Changelist', ChangelistMock).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00001954 ChangelistMock.desc = 'foo\n'
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001955
1956 self.assertEqual(0, git_cl.main(['description', '-d']))
Edward Lemurda4b6c62020-02-13 00:28:40 +00001957 self.assertEqual('foo\n', sys.stdout.getvalue())
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001958
Edward Lemurda4b6c62020-02-13 00:28:40 +00001959 @mock.patch('sys.stderr', StringIO())
iannucci3c972b92016-08-17 13:24:10 -07001960 def test_StatusFieldOverrideIssueMissingArgs(self):
iannucci3c972b92016-08-17 13:24:10 -07001961 try:
1962 self.assertEqual(git_cl.main(['status', '--issue', '1']), 0)
Edward Lemurd55c5072020-02-20 01:09:07 +00001963 except SystemExitMock:
Edward Lemur6c6827c2020-02-06 21:15:18 +00001964 self.assertIn(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001965 '--field must be given when --issue is set.', sys.stderr.getvalue())
iannucci3c972b92016-08-17 13:24:10 -07001966
1967 def test_StatusFieldOverrideIssue(self):
iannucci3c972b92016-08-17 13:24:10 -07001968 def assertIssue(cl_self, *_args):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00001969 self.assertEqual(cl_self.issue, 1)
iannucci3c972b92016-08-17 13:24:10 -07001970 return 'foobar'
1971
Edward Lemurda4b6c62020-02-13 00:28:40 +00001972 mock.patch('git_cl.Changelist.FetchDescription', assertIssue).start()
iannuccie53c9352016-08-17 14:40:40 -07001973 self.assertEqual(
Edward Lemur52969c92020-02-06 18:15:28 +00001974 git_cl.main(['status', '--issue', '1', '--field', 'desc']),
iannuccie53c9352016-08-17 14:40:40 -07001975 0)
Edward Lemurda4b6c62020-02-13 00:28:40 +00001976 self.assertEqual(sys.stdout.getvalue(), 'foobar\n')
iannucci3c972b92016-08-17 13:24:10 -07001977
iannuccie53c9352016-08-17 14:40:40 -07001978 def test_SetCloseOverrideIssue(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001979
iannuccie53c9352016-08-17 14:40:40 -07001980 def assertIssue(cl_self, *_args):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00001981 self.assertEqual(cl_self.issue, 1)
iannuccie53c9352016-08-17 14:40:40 -07001982 return 'foobar'
1983
Edward Lemurda4b6c62020-02-13 00:28:40 +00001984 mock.patch('git_cl.Changelist.FetchDescription', assertIssue).start()
1985 mock.patch('git_cl.Changelist.CloseIssue', lambda *_: None).start()
iannuccie53c9352016-08-17 14:40:40 -07001986 self.assertEqual(
Edward Lemur52969c92020-02-06 18:15:28 +00001987 git_cl.main(['set-close', '--issue', '1']), 0)
iannuccie53c9352016-08-17 14:40:40 -07001988
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00001989 def test_description(self):
Edward Lemur26964072020-02-19 19:18:51 +00001990 self.mockGit.config['remote.origin.url'] = (
1991 'https://chromium.googlesource.com/my/repo')
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001992 gerrit_util.GetChangeDetail.return_value = {
1993 'current_revision': 'sha1',
1994 'revisions': {'sha1': {
1995 'commit': {'message': 'foobar'},
1996 }},
1997 }
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001998 self.assertEqual(0, git_cl.main([
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00001999 'description',
2000 'https://chromium-review.googlesource.com/c/my/repo/+/123123',
2001 '-d']))
Edward Lemurda4b6c62020-02-13 00:28:40 +00002002 self.assertEqual('foobar\n', sys.stdout.getvalue())
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002003
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002004 def test_description_set_raw(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002005 mock.patch('git_cl.Changelist', ChangelistMock).start()
2006 mock.patch('git_cl.sys.stdin', StringIO('hihi')).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002007
2008 self.assertEqual(0, git_cl.main(['description', '-n', 'hihi']))
2009 self.assertEqual('hihi', ChangelistMock.desc)
2010
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002011 def test_description_appends_bug_line(self):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002012 current_desc = 'Some.\n\nChange-Id: xxx'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002013
2014 def RunEditor(desc, _, **kwargs):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002015 self.assertEqual(
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002016 '# Enter a description of the change.\n'
2017 '# This will be displayed on the codereview site.\n'
2018 '# The first line will also be used as the subject of the review.\n'
2019 '#--------------------This line is 72 characters long'
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002020 '--------------------\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -07002021 'Some.\n\nChange-Id: xxx\nBug: ',
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002022 desc)
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002023 # Simulate user changing something.
Aaron Gable3a16ed12017-03-23 10:51:55 -07002024 return 'Some.\n\nChange-Id: xxx\nBug: 123'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002025
Edward Lemur6c6827c2020-02-06 21:15:18 +00002026 def UpdateDescription(_, desc, force=False):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002027 self.assertEqual(desc, 'Some.\n\nChange-Id: xxx\nBug: 123')
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002028
Edward Lemurda4b6c62020-02-13 00:28:40 +00002029 mock.patch('git_cl.Changelist.FetchDescription',
2030 lambda *args: current_desc).start()
2031 mock.patch('git_cl.Changelist.UpdateDescription',
2032 UpdateDescription).start()
2033 mock.patch('git_cl.gclient_utils.RunEditor', RunEditor).start()
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002034
Edward Lemur85153282020-02-14 22:06:29 +00002035 self.mockGit.config['branch.master.gerritissue'] = '123'
Edward Lemur52969c92020-02-06 18:15:28 +00002036 self.assertEqual(0, git_cl.main(['description']))
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002037
Dan Beamd8b04ca2019-10-10 21:23:26 +00002038 def test_description_does_not_append_bug_line_if_fixed_is_present(self):
2039 current_desc = 'Some.\n\nFixed: 123\nChange-Id: xxx'
2040
2041 def RunEditor(desc, _, **kwargs):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002042 self.assertEqual(
Dan Beamd8b04ca2019-10-10 21:23:26 +00002043 '# Enter a description of the change.\n'
2044 '# This will be displayed on the codereview site.\n'
2045 '# The first line will also be used as the subject of the review.\n'
2046 '#--------------------This line is 72 characters long'
2047 '--------------------\n'
2048 'Some.\n\nFixed: 123\nChange-Id: xxx',
2049 desc)
2050 return desc
2051
Edward Lemurda4b6c62020-02-13 00:28:40 +00002052 mock.patch('git_cl.Changelist.FetchDescription',
2053 lambda *args: current_desc).start()
2054 mock.patch('git_cl.gclient_utils.RunEditor', RunEditor).start()
Dan Beamd8b04ca2019-10-10 21:23:26 +00002055
Edward Lemur85153282020-02-14 22:06:29 +00002056 self.mockGit.config['branch.master.gerritissue'] = '123'
Edward Lemur52969c92020-02-06 18:15:28 +00002057 self.assertEqual(0, git_cl.main(['description']))
Dan Beamd8b04ca2019-10-10 21:23:26 +00002058
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002059 def test_description_set_stdin(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002060 mock.patch('git_cl.Changelist', ChangelistMock).start()
2061 mock.patch('git_cl.sys.stdin', StringIO('hi \r\n\t there\n\nman')).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002062
2063 self.assertEqual(0, git_cl.main(['description', '-n', '-']))
2064 self.assertEqual('hi\n\t there\n\nman', ChangelistMock.desc)
2065
kmarshall3bff56b2016-06-06 18:31:47 -07002066 def test_archive(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002067 self.calls = [
2068 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
Edward Lemurf38bc172019-09-03 21:02:13 +00002069 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002070 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002071 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],), ''),
Edward Lemurf38bc172019-09-03 21:02:13 +00002072 ((['git', 'branch', '-D', 'foo'],), '')
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002073 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002074
Edward Lemurda4b6c62020-02-13 00:28:40 +00002075 mock.patch('git_cl.get_cl_statuses',
kmarshall3bff56b2016-06-06 18:31:47 -07002076 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002077 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2078 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002079 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall3bff56b2016-06-06 18:31:47 -07002080
2081 self.assertEqual(0, git_cl.main(['archive', '-f']))
2082
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002083 def test_archive_tag_collision(self):
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002084 self.calls = [
2085 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2086 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2087 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],),
2088 'refs/tags/git-cl-archived-456-foo'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002089 ((['git', 'tag', 'git-cl-archived-456-foo-2', 'foo'],), ''),
2090 ((['git', 'branch', '-D', 'foo'],), '')
2091 ]
2092
Edward Lemurda4b6c62020-02-13 00:28:40 +00002093 mock.patch('git_cl.get_cl_statuses',
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002094 lambda branches, fine_grained, max_processes:
2095 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2096 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002097 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002098
2099 self.assertEqual(0, git_cl.main(['archive', '-f']))
2100
kmarshall3bff56b2016-06-06 18:31:47 -07002101 def test_archive_current_branch_fails(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002102 self.calls = [
2103 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2104 'refs/heads/master'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002105 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002106 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002107
Edward Lemurda4b6c62020-02-13 00:28:40 +00002108 mock.patch('git_cl.get_cl_statuses',
kmarshall9249e012016-08-23 12:02:16 -07002109 lambda branches, fine_grained, max_processes:
Edward Lemurda4b6c62020-02-13 00:28:40 +00002110 [(MockChangelistWithBranchAndIssue('master', 1),
2111 'closed')]).start()
kmarshall9249e012016-08-23 12:02:16 -07002112
2113 self.assertEqual(1, git_cl.main(['archive', '-f']))
2114
2115 def test_archive_dry_run(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002116 self.calls = [
2117 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2118 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002119 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002120 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002121
Edward Lemurda4b6c62020-02-13 00:28:40 +00002122 mock.patch('git_cl.get_cl_statuses',
kmarshall3bff56b2016-06-06 18:31:47 -07002123 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002124 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2125 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002126 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall3bff56b2016-06-06 18:31:47 -07002127
kmarshall9249e012016-08-23 12:02:16 -07002128 self.assertEqual(0, git_cl.main(['archive', '-f', '--dry-run']))
2129
2130 def test_archive_no_tags(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002131 self.calls = [
2132 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2133 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002134 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002135 ((['git', 'branch', '-D', 'foo'],), '')
2136 ]
kmarshall9249e012016-08-23 12:02:16 -07002137
Edward Lemurda4b6c62020-02-13 00:28:40 +00002138 mock.patch('git_cl.get_cl_statuses',
kmarshall9249e012016-08-23 12:02:16 -07002139 lambda branches, fine_grained, max_processes:
2140 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2141 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002142 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall9249e012016-08-23 12:02:16 -07002143
2144 self.assertEqual(0, git_cl.main(['archive', '-f', '--notags']))
kmarshall3bff56b2016-06-06 18:31:47 -07002145
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002146 def test_archive_tag_cleanup_on_branch_deletion_error(self):
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002147 self.calls = [
2148 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2149 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2150 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002151 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],),
2152 'refs/tags/git-cl-archived-456-foo'),
2153 ((['git', 'branch', '-D', 'foo'],), CERR1),
2154 ((['git', 'tag', '-d', 'git-cl-archived-456-foo'],),
2155 'refs/tags/git-cl-archived-456-foo'),
2156 ]
2157
Edward Lemurda4b6c62020-02-13 00:28:40 +00002158 mock.patch('git_cl.get_cl_statuses',
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002159 lambda branches, fine_grained, max_processes:
2160 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2161 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002162 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002163
2164 self.assertEqual(0, git_cl.main(['archive', '-f']))
2165
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002166 def test_cmd_issue_erase_existing(self):
Edward Lemur85153282020-02-14 22:06:29 +00002167 self.mockGit.config['branch.master.gerritissue'] = '123'
2168 self.mockGit.config['branch.master.gerritserver'] = (
2169 'https://chromium-review.googlesource.com')
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002170 self.calls = [
Aaron Gableca01e2c2017-07-19 11:16:02 -07002171 ((['git', 'log', '-1', '--format=%B'],), 'This is a description'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002172 ]
2173 self.assertEqual(0, git_cl.main(['issue', '0']))
Edward Lemur85153282020-02-14 22:06:29 +00002174 self.assertNotIn('branch.master.gerritissue', self.mockGit.config)
2175 self.assertNotIn('branch.master.gerritserver', self.mockGit.config)
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002176
Aaron Gable400e9892017-07-12 15:31:21 -07002177 def test_cmd_issue_erase_existing_with_change_id(self):
Edward Lemur85153282020-02-14 22:06:29 +00002178 self.mockGit.config['branch.master.gerritissue'] = '123'
2179 self.mockGit.config['branch.master.gerritserver'] = (
2180 'https://chromium-review.googlesource.com')
Edward Lemurda4b6c62020-02-13 00:28:40 +00002181 mock.patch('git_cl.Changelist.FetchDescription',
2182 lambda _: 'This is a description\n\nChange-Id: Ideadbeef').start()
Aaron Gable400e9892017-07-12 15:31:21 -07002183 self.calls = [
Aaron Gableca01e2c2017-07-19 11:16:02 -07002184 ((['git', 'log', '-1', '--format=%B'],),
2185 'This is a description\n\nChange-Id: Ideadbeef'),
2186 ((['git', 'commit', '--amend', '-m', 'This is a description\n'],), ''),
Aaron Gable400e9892017-07-12 15:31:21 -07002187 ]
2188 self.assertEqual(0, git_cl.main(['issue', '0']))
Edward Lemur85153282020-02-14 22:06:29 +00002189 self.assertNotIn('branch.master.gerritissue', self.mockGit.config)
2190 self.assertNotIn('branch.master.gerritserver', self.mockGit.config)
Aaron Gable400e9892017-07-12 15:31:21 -07002191
phajdan.jre328cf92016-08-22 04:12:17 -07002192 def test_cmd_issue_json(self):
Edward Lemur85153282020-02-14 22:06:29 +00002193 self.mockGit.config['branch.master.gerritissue'] = '123'
2194 self.mockGit.config['branch.master.gerritserver'] = (
2195 'https://chromium-review.googlesource.com')
phajdan.jre328cf92016-08-22 04:12:17 -07002196 self.calls = [
phajdan.jre328cf92016-08-22 04:12:17 -07002197 (('write_json', 'output.json',
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002198 {'issue': 123,
2199 'issue_url': 'https://chromium-review.googlesource.com/123'}),
phajdan.jre328cf92016-08-22 04:12:17 -07002200 ''),
2201 ]
2202 self.assertEqual(0, git_cl.main(['issue', '--json', 'output.json']))
2203
tandrii16e0b4e2016-06-07 10:34:28 -07002204 def _common_GerritCommitMsgHookCheck(self):
Edward Lemur15a9b8c2020-02-13 00:52:30 +00002205 mock.patch(
2206 'git_cl.os.path.abspath',
2207 lambda path: self._mocked_call(['abspath', path])).start()
2208 mock.patch(
2209 'git_cl.os.path.exists',
2210 lambda path: self._mocked_call(['exists', path])).start()
2211 mock.patch(
2212 'git_cl.gclient_utils.FileRead',
2213 lambda path: self._mocked_call(['FileRead', path])).start()
2214 mock.patch(
2215 'git_cl.gclient_utils.rm_file_or_tree',
2216 lambda path: self._mocked_call(['rm_file_or_tree', path])).start()
Edward Lemurf38bc172019-09-03 21:02:13 +00002217 return git_cl.Changelist(issue=123)
tandrii16e0b4e2016-06-07 10:34:28 -07002218
2219 def test_GerritCommitMsgHookCheck_custom_hook(self):
2220 cl = self._common_GerritCommitMsgHookCheck()
2221 self.calls += [
Edward Lemur15a9b8c2020-02-13 00:52:30 +00002222 ((['exists', '.git/hooks/commit-msg'],), True),
2223 ((['FileRead', '.git/hooks/commit-msg'],),
tandrii16e0b4e2016-06-07 10:34:28 -07002224 '#!/bin/sh\necho "custom hook"')
2225 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002226 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002227
2228 def test_GerritCommitMsgHookCheck_not_exists(self):
2229 cl = self._common_GerritCommitMsgHookCheck()
2230 self.calls += [
Edward Lemur15a9b8c2020-02-13 00:52:30 +00002231 ((['exists', '.git/hooks/commit-msg'],), False),
tandrii16e0b4e2016-06-07 10:34:28 -07002232 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002233 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002234
2235 def test_GerritCommitMsgHookCheck(self):
2236 cl = self._common_GerritCommitMsgHookCheck()
2237 self.calls += [
Edward Lemur15a9b8c2020-02-13 00:52:30 +00002238 ((['exists', '.git/hooks/commit-msg'],), True),
2239 ((['FileRead', '.git/hooks/commit-msg'],),
tandrii16e0b4e2016-06-07 10:34:28 -07002240 '...\n# From Gerrit Code Review\n...\nadd_ChangeId()\n'),
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002241 (('ask_for_data', 'Do you want to remove it now? [Yes/No]: '), 'Yes'),
Edward Lemur15a9b8c2020-02-13 00:52:30 +00002242 ((['rm_file_or_tree', '.git/hooks/commit-msg'],),
tandrii16e0b4e2016-06-07 10:34:28 -07002243 ''),
2244 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002245 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002246
tandriic4344b52016-08-29 06:04:54 -07002247 def test_GerritCmdLand(self):
Edward Lemur85153282020-02-14 22:06:29 +00002248 self.mockGit.config['branch.master.gerritsquashhash'] = 'deadbeaf'
2249 self.mockGit.config['branch.master.gerritserver'] = (
2250 'chromium-review.googlesource.com')
tandriic4344b52016-08-29 06:04:54 -07002251 self.calls += [
tandriic4344b52016-08-29 06:04:54 -07002252 ((['git', 'diff', 'deadbeaf'],), ''), # No diff.
tandriic4344b52016-08-29 06:04:54 -07002253 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002254 cl = git_cl.Changelist(issue=123)
Edward Lemur125d60a2019-09-13 18:25:41 +00002255 cl._GetChangeDetail = lambda *args, **kwargs: {
tandriic4344b52016-08-29 06:04:54 -07002256 'labels': {},
2257 'current_revision': 'deadbeaf',
2258 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002259 cl._GetChangeCommit = lambda: {
agable32978d92016-11-01 12:55:02 -07002260 'commit': 'deadbeef',
Aaron Gable02cdbb42016-12-13 16:24:25 -08002261 'web_links': [{'name': 'gitiles',
agable32978d92016-11-01 12:55:02 -07002262 'url': 'https://git.googlesource.com/test/+/deadbeef'}],
2263 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002264 cl.SubmitIssue = lambda wait_for_merge: None
Olivier Robin75ee7252018-04-13 10:02:56 +02002265 self.assertEqual(0, cl.CMDLand(force=True,
2266 bypass_hooks=True,
2267 verbose=True,
2268 parallel=False))
Edward Lemur73c76702020-02-06 23:57:18 +00002269 self.assertIn(
2270 'Issue chromium-review.googlesource.com/123 has been submitted',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002271 sys.stdout.getvalue())
Edward Lemur73c76702020-02-06 23:57:18 +00002272 self.assertIn(
2273 'Landed as: https://git.googlesource.com/test/+/deadbeef',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002274 sys.stdout.getvalue())
tandriic4344b52016-08-29 06:04:54 -07002275
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002276 def _mock_gerrit_changes_for_detail_cache(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002277 mock.patch('git_cl.Changelist._GetGerritHost', lambda _: 'host').start()
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002278
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002279 def test_gerrit_change_detail_cache_simple(self):
2280 self._mock_gerrit_changes_for_detail_cache()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002281 gerrit_util.GetChangeDetail.side_effect = ['a', 'b']
Edward Lemurf38bc172019-09-03 21:02:13 +00002282 cl1 = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002283 cl1._cached_remote_url = (
2284 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemurf38bc172019-09-03 21:02:13 +00002285 cl2 = git_cl.Changelist(issue=2)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002286 cl2._cached_remote_url = (
2287 True, 'https://chromium.googlesource.com/ab/repo')
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002288 self.assertEqual(cl1._GetChangeDetail(), 'a') # Miss.
2289 self.assertEqual(cl1._GetChangeDetail(), 'a')
2290 self.assertEqual(cl2._GetChangeDetail(), 'b') # Miss.
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002291
2292 def test_gerrit_change_detail_cache_options(self):
2293 self._mock_gerrit_changes_for_detail_cache()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002294 gerrit_util.GetChangeDetail.side_effect = ['cab', 'ad']
Edward Lemurf38bc172019-09-03 21:02:13 +00002295 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002296 cl._cached_remote_url = (True, 'https://chromium.googlesource.com/repo/')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002297 self.assertEqual(cl._GetChangeDetail(options=['C', 'A', 'B']), 'cab')
2298 self.assertEqual(cl._GetChangeDetail(options=['A', 'B', 'C']), 'cab')
2299 self.assertEqual(cl._GetChangeDetail(options=['B', 'A']), 'cab')
2300 self.assertEqual(cl._GetChangeDetail(options=['C']), 'cab')
2301 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2302 self.assertEqual(cl._GetChangeDetail(), 'cab')
2303
2304 self.assertEqual(cl._GetChangeDetail(options=['A', 'D']), 'ad')
2305 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2306 self.assertEqual(cl._GetChangeDetail(options=['D']), 'ad')
2307 self.assertEqual(cl._GetChangeDetail(), 'cab')
2308
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002309 def test_gerrit_description_caching(self):
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002310 gerrit_util.GetChangeDetail.return_value = {
2311 'current_revision': 'rev1',
2312 'revisions': {
2313 'rev1': {'commit': {'message': 'desc1'}},
2314 },
2315 }
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002316
2317 self._mock_gerrit_changes_for_detail_cache()
Edward Lemurf38bc172019-09-03 21:02:13 +00002318 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002319 cl._cached_remote_url = (
2320 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemur6c6827c2020-02-06 21:15:18 +00002321 self.assertEqual(cl.FetchDescription(), 'desc1')
2322 self.assertEqual(cl.FetchDescription(), 'desc1') # cache hit.
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002323
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002324 def test_print_current_creds(self):
2325 class CookiesAuthenticatorMock(object):
2326 def __init__(self):
2327 self.gitcookies = {
2328 'host.googlesource.com': ('user', 'pass'),
2329 'host-review.googlesource.com': ('user', 'pass'),
2330 }
2331 self.netrc = self
2332 self.netrc.hosts = {
2333 'github.com': ('user2', None, 'pass2'),
2334 'host2.googlesource.com': ('user3', None, 'pass'),
2335 }
Edward Lemurda4b6c62020-02-13 00:28:40 +00002336 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
2337 CookiesAuthenticatorMock).start()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002338 git_cl._GitCookiesChecker().print_current_creds(include_netrc=True)
2339 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2340 ' Host\t User\t Which file',
2341 '============================\t=====\t===========',
2342 'host-review.googlesource.com\t user\t.gitcookies',
2343 ' host.googlesource.com\t user\t.gitcookies',
2344 ' host2.googlesource.com\tuser3\t .netrc',
2345 ])
Edward Lemur79d4f992019-11-11 23:49:02 +00002346 sys.stdout.seek(0)
2347 sys.stdout.truncate(0)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002348 git_cl._GitCookiesChecker().print_current_creds(include_netrc=False)
2349 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2350 ' Host\tUser\t Which file',
2351 '============================\t====\t===========',
2352 'host-review.googlesource.com\tuser\t.gitcookies',
2353 ' host.googlesource.com\tuser\t.gitcookies',
2354 ])
2355
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002356 def _common_creds_check_mocks(self):
2357 def exists_mock(path):
2358 dirname = os.path.dirname(path)
2359 if dirname == os.path.expanduser('~'):
2360 dirname = '~'
2361 base = os.path.basename(path)
2362 if base in ('.netrc', '.gitcookies'):
2363 return self._mocked_call('os.path.exists', '%s/%s' % (dirname, base))
2364 # git cl also checks for existence other files not relevant to this test.
2365 return None
Edward Lemurda4b6c62020-02-13 00:28:40 +00002366 mock.patch('os.path.exists', exists_mock).start()
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002367
2368 def test_creds_check_gitcookies_not_configured(self):
2369 self._common_creds_check_mocks()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002370 mock.patch('git_cl._GitCookiesChecker.get_hosts_with_creds',
2371 lambda _, include_netrc=False: []).start()
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002372 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08002373 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002374 ((['git', 'config', '--global', 'http.cookiefile'],), CERR1),
2375 (('os.path.exists', '~/.netrc'), True),
2376 (('ask_for_data', 'Press Enter to setup .gitcookies, '
2377 'or Ctrl+C to abort'), ''),
2378 ((['git', 'config', '--global', 'http.cookiefile',
2379 os.path.expanduser('~/.gitcookies')], ), ''),
2380 ]
2381 self.assertEqual(0, git_cl.main(['creds-check']))
Edward Lemur73c76702020-02-06 23:57:18 +00002382 self.assertTrue(
2383 sys.stdout.getvalue().startswith(
2384 'You seem to be using outdated .netrc for git credentials:'))
2385 self.assertIn(
2386 '\nConfigured git to use .gitcookies from',
2387 sys.stdout.getvalue())
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002388
2389 def test_creds_check_gitcookies_configured_custom_broken(self):
2390 self._common_creds_check_mocks()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002391 mock.patch('git_cl._GitCookiesChecker.get_hosts_with_creds',
2392 lambda _, include_netrc=False: []).start()
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002393 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08002394 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002395 ((['git', 'config', '--global', 'http.cookiefile'],),
2396 '/custom/.gitcookies'),
2397 (('os.path.exists', '/custom/.gitcookies'), False),
2398 (('ask_for_data', 'Reconfigure git to use default .gitcookies? '
2399 'Press Enter to reconfigure, or Ctrl+C to abort'), ''),
2400 ((['git', 'config', '--global', 'http.cookiefile',
2401 os.path.expanduser('~/.gitcookies')], ), ''),
2402 ]
2403 self.assertEqual(0, git_cl.main(['creds-check']))
Edward Lemur73c76702020-02-06 23:57:18 +00002404 self.assertIn(
2405 'WARNING: You have configured custom path to .gitcookies: ',
2406 sys.stdout.getvalue())
2407 self.assertIn(
2408 'However, your configured .gitcookies file is missing.',
2409 sys.stdout.getvalue())
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002410
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002411 def test_git_cl_comment_add_gerrit(self):
Edward Lemur85153282020-02-14 22:06:29 +00002412 self.mockGit.branchref = None
Edward Lemur26964072020-02-19 19:18:51 +00002413 self.mockGit.config['remote.origin.url'] = (
2414 'https://chromium.googlesource.com/infra/infra')
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002415 self.calls = [
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002416 (('SetReview', 'chromium-review.googlesource.com', 'infra%2Finfra~10',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002417 'msg', None, None, None),
Aaron Gable636b13f2017-07-14 10:42:48 -07002418 None),
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002419 ]
Edward Lemur52969c92020-02-06 18:15:28 +00002420 self.assertEqual(0, git_cl.main(['comment', '-i', '10', '-a', 'msg']))
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002421
Edward Lemurda4b6c62020-02-13 00:28:40 +00002422 @mock.patch('git_cl.Changelist.GetBranch', return_value='foo')
2423 def test_git_cl_comments_fetch_gerrit(self, *_mocks):
Edward Lemur26964072020-02-19 19:18:51 +00002424 self.mockGit.config['remote.origin.url'] = (
2425 'https://chromium.googlesource.com/infra/infra')
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002426 gerrit_util.GetChangeDetail.return_value = {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002427 'owner': {'email': 'owner@example.com'},
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002428 'current_revision': 'ba5eba11',
2429 'revisions': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002430 'deadbeaf': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002431 '_number': 1,
2432 },
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002433 'ba5eba11': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002434 '_number': 2,
2435 },
2436 },
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002437 'messages': [
2438 {
2439 u'_revision_number': 1,
2440 u'author': {
2441 u'_account_id': 1111084,
2442 u'email': u'commit-bot@chromium.org',
2443 u'name': u'Commit Bot'
2444 },
2445 u'date': u'2017-03-15 20:08:45.000000000',
2446 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
Dirk Prankef6a58802017-10-17 12:49:42 -07002447 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002448 u'tag': u'autogenerated:cq:dry-run'
2449 },
2450 {
2451 u'_revision_number': 2,
2452 u'author': {
2453 u'_account_id': 11151243,
2454 u'email': u'owner@example.com',
2455 u'name': u'owner'
2456 },
2457 u'date': u'2017-03-16 20:00:41.000000000',
2458 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2459 u'message': u'PTAL',
2460 },
2461 {
2462 u'_revision_number': 2,
2463 u'author': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002464 u'_account_id': 148512,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002465 u'email': u'reviewer@example.com',
2466 u'name': u'reviewer'
2467 },
2468 u'date': u'2017-03-17 05:19:37.500000000',
2469 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2470 u'message': u'Patch Set 2: Code-Review+1',
2471 },
2472 ]
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002473 }
2474 self.calls = [
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002475 (('GetChangeComments', 'chromium-review.googlesource.com',
2476 'infra%2Finfra~1'), {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002477 '/COMMIT_MSG': [
2478 {
2479 'author': {'email': u'reviewer@example.com'},
2480 'updated': u'2017-03-17 05:19:37.500000000',
2481 'patch_set': 2,
2482 'side': 'REVISION',
2483 'message': 'Please include a bug link',
2484 },
2485 ],
2486 'codereview.settings': [
2487 {
2488 'author': {'email': u'owner@example.com'},
2489 'updated': u'2017-03-16 20:00:41.000000000',
2490 'patch_set': 2,
2491 'side': 'PARENT',
2492 'line': 42,
2493 'message': 'I removed this because it is bad',
2494 },
2495 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002496 }),
2497 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
2498 'infra%2Finfra~1'), {}),
Leszek Swirski45b20c42018-09-17 17:05:26 +00002499 ] * 2 + [
2500 (('write_json', 'output.json', [
2501 {
2502 u'date': u'2017-03-16 20:00:41.000000',
2503 u'message': (
2504 u'PTAL\n' +
2505 u'\n' +
2506 u'codereview.settings\n' +
2507 u' Base, Line 42: https://chromium-review.googlesource.com/' +
2508 u'c/1/2/codereview.settings#b42\n' +
2509 u' I removed this because it is bad\n'),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002510 u'autogenerated': False,
Leszek Swirski45b20c42018-09-17 17:05:26 +00002511 u'approval': False,
2512 u'disapproval': False,
2513 u'sender': u'owner@example.com'
2514 }, {
2515 u'date': u'2017-03-17 05:19:37.500000',
2516 u'message': (
2517 u'Patch Set 2: Code-Review+1\n' +
2518 u'\n' +
2519 u'/COMMIT_MSG\n' +
2520 u' PS2, File comment: https://chromium-review.googlesource' +
2521 u'.com/c/1/2//COMMIT_MSG#\n' +
2522 u' Please include a bug link\n'),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002523 u'autogenerated': False,
Leszek Swirski45b20c42018-09-17 17:05:26 +00002524 u'approval': False,
2525 u'disapproval': False,
2526 u'sender': u'reviewer@example.com'
2527 }
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002528 ]), '')
Leszek Swirski45b20c42018-09-17 17:05:26 +00002529 ]
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002530 expected_comments_summary = [
2531 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002532 message=(
2533 u'PTAL\n' +
2534 u'\n' +
2535 u'codereview.settings\n' +
2536 u' Base, Line 42: https://chromium-review.googlesource.com/' +
2537 u'c/1/2/codereview.settings#b42\n' +
2538 u' I removed this because it is bad\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002539 date=datetime.datetime(2017, 3, 16, 20, 0, 41, 0),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002540 autogenerated=False,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002541 disapproval=False, approval=False, sender=u'owner@example.com'),
2542 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002543 message=(
2544 u'Patch Set 2: Code-Review+1\n' +
2545 u'\n' +
2546 u'/COMMIT_MSG\n' +
2547 u' PS2, File comment: https://chromium-review.googlesource.com/' +
2548 u'c/1/2//COMMIT_MSG#\n' +
2549 u' Please include a bug link\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002550 date=datetime.datetime(2017, 3, 17, 5, 19, 37, 500000),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002551 autogenerated=False,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002552 disapproval=False, approval=False, sender=u'reviewer@example.com'),
2553 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002554 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00002555 issue=1, branchref='refs/heads/foo')
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002556 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002557 self.assertEqual(
2558 0, git_cl.main(['comments', '-i', '1', '-j', 'output.json']))
2559
2560 def test_git_cl_comments_robot_comments(self):
2561 # git cl comments also fetches robot comments (which are considered a type
2562 # of autogenerated comment), and unlike other types of comments, only robot
2563 # comments from the latest patchset are shown.
Edward Lemur26964072020-02-19 19:18:51 +00002564 self.mockGit.config['remote.origin.url'] = (
2565 'https://chromium.googlesource.com/infra/infra')
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002566 gerrit_util.GetChangeDetail.return_value = {
2567 'owner': {'email': 'owner@example.com'},
2568 'current_revision': 'ba5eba11',
2569 'revisions': {
2570 'deadbeaf': {
2571 '_number': 1,
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002572 },
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002573 'ba5eba11': {
2574 '_number': 2,
2575 },
2576 },
2577 'messages': [
2578 {
2579 u'_revision_number': 1,
2580 u'author': {
2581 u'_account_id': 1111084,
2582 u'email': u'commit-bot@chromium.org',
2583 u'name': u'Commit Bot'
2584 },
2585 u'date': u'2017-03-15 20:08:45.000000000',
2586 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
2587 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
2588 u'tag': u'autogenerated:cq:dry-run'
2589 },
2590 {
2591 u'_revision_number': 1,
2592 u'author': {
2593 u'_account_id': 123,
2594 u'email': u'tricium@serviceaccount.com',
2595 u'name': u'Tricium'
2596 },
2597 u'date': u'2017-03-16 20:00:41.000000000',
2598 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2599 u'message': u'(1 comment)',
2600 u'tag': u'autogenerated:tricium',
2601 },
2602 {
2603 u'_revision_number': 1,
2604 u'author': {
2605 u'_account_id': 123,
2606 u'email': u'tricium@serviceaccount.com',
2607 u'name': u'Tricium'
2608 },
2609 u'date': u'2017-03-16 20:00:41.000000000',
2610 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2611 u'message': u'(1 comment)',
2612 u'tag': u'autogenerated:tricium',
2613 },
2614 {
2615 u'_revision_number': 2,
2616 u'author': {
2617 u'_account_id': 123,
2618 u'email': u'tricium@serviceaccount.com',
2619 u'name': u'reviewer'
2620 },
2621 u'date': u'2017-03-17 05:30:37.000000000',
2622 u'tag': u'autogenerated:tricium',
2623 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2624 u'message': u'(1 comment)',
2625 },
2626 ]
2627 }
2628 self.calls = [
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002629 (('GetChangeComments', 'chromium-review.googlesource.com',
2630 'infra%2Finfra~1'), {}),
2631 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
2632 'infra%2Finfra~1'), {
2633 'codereview.settings': [
2634 {
2635 u'author': {u'email': u'tricium@serviceaccount.com'},
2636 u'updated': u'2017-03-17 05:30:37.000000000',
2637 u'robot_run_id': u'5565031076855808',
2638 u'robot_id': u'Linter/Category',
2639 u'tag': u'autogenerated:tricium',
2640 u'patch_set': 2,
2641 u'side': u'REVISION',
2642 u'message': u'Linter warning message text',
2643 u'line': 32,
2644 },
2645 ],
2646 }),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002647 ]
2648 expected_comments_summary = [
2649 git_cl._CommentSummary(date=datetime.datetime(2017, 3, 17, 5, 30, 37),
2650 message=(
2651 u'(1 comment)\n\ncodereview.settings\n'
2652 u' PS2, Line 32: https://chromium-review.googlesource.com/'
2653 u'c/1/2/codereview.settings#32\n'
2654 u' Linter warning message text\n'),
2655 sender=u'tricium@serviceaccount.com',
2656 autogenerated=True, approval=False, disapproval=False)
2657 ]
2658 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00002659 issue=1, branchref='refs/heads/foo')
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002660 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002661
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002662 def test_get_remote_url_with_mirror(self):
2663 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002664
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002665 def selective_os_path_isdir_mock(path):
2666 if path == '/cache/this-dir-exists':
2667 return self._mocked_call('os.path.isdir', path)
2668 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002669
Edward Lemurda4b6c62020-02-13 00:28:40 +00002670 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002671
2672 url = 'https://chromium.googlesource.com/my/repo'
Edward Lemur26964072020-02-19 19:18:51 +00002673 self.mockGit.config['remote.origin.url'] = (
2674 '/cache/this-dir-exists')
2675 self.mockGit.config['/cache/this-dir-exists:remote.origin.url'] = (
2676 url)
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002677 self.calls = [
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002678 (('os.path.isdir', '/cache/this-dir-exists'),
2679 True),
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002680 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002681 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002682 self.assertEqual(cl.GetRemoteUrl(), url)
2683 self.assertEqual(cl.GetRemoteUrl(), url) # Must be cached.
2684
Edward Lemur298f2cf2019-02-22 21:40:39 +00002685 def test_get_remote_url_non_existing_mirror(self):
2686 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002687
Edward Lemur298f2cf2019-02-22 21:40:39 +00002688 def selective_os_path_isdir_mock(path):
2689 if path == '/cache/this-dir-doesnt-exist':
2690 return self._mocked_call('os.path.isdir', path)
2691 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002692
Edward Lemurda4b6c62020-02-13 00:28:40 +00002693 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
2694 mock.patch('logging.error',
2695 lambda *a: self._mocked_call('logging.error', *a)).start()
Edward Lemur298f2cf2019-02-22 21:40:39 +00002696
Edward Lemur26964072020-02-19 19:18:51 +00002697 self.mockGit.config['remote.origin.url'] = (
2698 '/cache/this-dir-doesnt-exist')
Edward Lemur298f2cf2019-02-22 21:40:39 +00002699 self.calls = [
Edward Lemur298f2cf2019-02-22 21:40:39 +00002700 (('os.path.isdir', '/cache/this-dir-doesnt-exist'),
2701 False),
2702 (('logging.error',
Josip906bfde2020-01-31 22:38:49 +00002703 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
2704 'but it doesn\'t exist.', {
2705 'remote': 'origin',
2706 'branch': 'master',
2707 'url': '/cache/this-dir-doesnt-exist'}
2708 ), None),
Edward Lemur298f2cf2019-02-22 21:40:39 +00002709 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002710 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00002711 self.assertIsNone(cl.GetRemoteUrl())
2712
2713 def test_get_remote_url_misconfigured_mirror(self):
2714 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002715
Edward Lemur298f2cf2019-02-22 21:40:39 +00002716 def selective_os_path_isdir_mock(path):
2717 if path == '/cache/this-dir-exists':
2718 return self._mocked_call('os.path.isdir', path)
2719 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002720
Edward Lemurda4b6c62020-02-13 00:28:40 +00002721 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
2722 mock.patch('logging.error',
2723 lambda *a: self._mocked_call('logging.error', *a)).start()
Edward Lemur298f2cf2019-02-22 21:40:39 +00002724
Edward Lemur26964072020-02-19 19:18:51 +00002725 self.mockGit.config['remote.origin.url'] = (
2726 '/cache/this-dir-exists')
Edward Lemur298f2cf2019-02-22 21:40:39 +00002727 self.calls = [
Edward Lemur298f2cf2019-02-22 21:40:39 +00002728 (('os.path.isdir', '/cache/this-dir-exists'), True),
Edward Lemur298f2cf2019-02-22 21:40:39 +00002729 (('logging.error',
2730 'Remote "%(remote)s" for branch "%(branch)s" points to '
2731 '"%(cache_path)s", but it is misconfigured.\n'
2732 '"%(cache_path)s" must be a git repo and must have a remote named '
2733 '"%(remote)s" pointing to the git host.', {
2734 'remote': 'origin',
2735 'cache_path': '/cache/this-dir-exists',
2736 'branch': 'master'}
2737 ), None),
2738 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002739 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00002740 self.assertIsNone(cl.GetRemoteUrl())
2741
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002742 def test_gerrit_change_identifier_with_project(self):
Edward Lemur26964072020-02-19 19:18:51 +00002743 self.mockGit.config['remote.origin.url'] = (
2744 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemurf38bc172019-09-03 21:02:13 +00002745 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002746 self.assertEqual(cl._GerritChangeIdentifier(), 'my%2Frepo~123456')
2747
2748 def test_gerrit_change_identifier_without_project(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002749 mock.patch('logging.error',
2750 lambda *a: self._mocked_call('logging.error', *a)).start()
Josip906bfde2020-01-31 22:38:49 +00002751
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002752 self.calls = [
Josip906bfde2020-01-31 22:38:49 +00002753 (('logging.error',
2754 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
2755 'but it doesn\'t exist.', {
2756 'remote': 'origin',
2757 'branch': 'master',
2758 'url': ''}
2759 ), None),
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002760 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002761 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002762 self.assertEqual(cl._GerritChangeIdentifier(), '123456')
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00002763
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002764
Edward Lemur9aa1a962020-02-25 00:58:38 +00002765class ChangelistTest(unittest.TestCase):
Edward Lemur227d5102020-02-25 23:45:35 +00002766 def setUp(self):
2767 super(ChangelistTest, self).setUp()
2768 mock.patch('gclient_utils.FileRead').start()
2769 mock.patch('gclient_utils.FileWrite').start()
2770 mock.patch('gclient_utils.temporary_file', TemporaryFileMock()).start()
2771 mock.patch(
2772 'git_cl.Changelist.GetCodereviewServer',
2773 return_value='https://chromium-review.googlesource.com').start()
2774 mock.patch('git_cl.Changelist.GetAuthor', return_value='author').start()
2775 mock.patch('git_cl.Changelist.GetIssue', return_value=123456).start()
2776 mock.patch('git_cl.Changelist.GetPatchset', return_value=7).start()
2777 mock.patch('git_cl.PRESUBMIT_SUPPORT', 'PRESUBMIT_SUPPORT').start()
2778 mock.patch('git_cl.Settings.GetRoot', return_value='root').start()
2779 mock.patch('git_cl.time_time').start()
2780 mock.patch('metrics.collector').start()
2781 mock.patch('subprocess2.Popen').start()
2782 self.addCleanup(mock.patch.stopall)
2783 self.temp_count = 0
2784
Edward Lemur9aa1a962020-02-25 00:58:38 +00002785 @mock.patch('git_cl.RunGitWithCode')
2786 def testGetLocalDescription(self, _mock):
2787 git_cl.RunGitWithCode.return_value = (0, 'description')
2788 cl = git_cl.Changelist()
2789 self.assertEqual('description', cl.GetLocalDescription('branch'))
2790 self.assertEqual('description', cl.GetLocalDescription('branch'))
2791 git_cl.RunGitWithCode.assert_called_once_with(
2792 ['log', '--pretty=format:%s%n%n%b', 'branch...'])
2793
Edward Lemur227d5102020-02-25 23:45:35 +00002794 def testRunHook(self):
2795 expected_results = {
2796 'more_cc': ['more@example.com', 'cc@example.com'],
2797 'should_continue': True,
2798 }
2799 gclient_utils.FileRead.return_value = json.dumps(expected_results)
2800 git_cl.time_time.side_effect = [100, 200]
2801 mockProcess = mock.Mock()
2802 mockProcess.wait.return_value = 0
2803 subprocess2.Popen.return_value = mockProcess
2804
2805 cl = git_cl.Changelist()
2806 results = cl.RunHook(
2807 committing=True,
2808 may_prompt=True,
2809 verbose=2,
2810 parallel=True,
2811 upstream='upstream',
2812 description='description',
2813 all_files=True)
2814
2815 self.assertEqual(expected_results, results)
2816 subprocess2.Popen.assert_called_once_with([
2817 'vpython', 'PRESUBMIT_SUPPORT',
Edward Lemur227d5102020-02-25 23:45:35 +00002818 '--author', 'author',
2819 '--root', 'root',
2820 '--upstream', 'upstream',
2821 '--verbose', '--verbose',
2822 '--issue', '123456',
2823 '--patchset', '7',
2824 '--gerrit_url', 'https://chromium-review.googlesource.com',
Edward Lemur75526302020-02-27 22:31:05 +00002825 '--commit',
Edward Lemur227d5102020-02-25 23:45:35 +00002826 '--may_prompt',
2827 '--parallel',
2828 '--all_files',
2829 '--json_output', '/tmp/fake-temp2',
2830 '--description_file', '/tmp/fake-temp1',
2831 ])
2832 gclient_utils.FileWrite.assert_called_once_with(
2833 '/tmp/fake-temp1', b'description', mode='wb')
2834 metrics.collector.add_repeated('sub_commands', {
2835 'command': 'presubmit',
2836 'execution_time': 100,
2837 'exit_code': 0,
2838 })
2839
2840 @mock.patch('sys.exit', side_effect=SystemExitMock)
2841 def testRunHook_Failure(self, _mock):
2842 git_cl.time_time.side_effect = [100, 200]
2843 mockProcess = mock.Mock()
2844 mockProcess.wait.return_value = 2
2845 subprocess2.Popen.return_value = mockProcess
2846
2847 cl = git_cl.Changelist()
2848 with self.assertRaises(SystemExitMock):
2849 cl.RunHook(
2850 committing=True,
2851 may_prompt=True,
2852 verbose=2,
2853 parallel=True,
2854 upstream='upstream',
2855 description='description',
2856 all_files=True)
2857
2858 sys.exit.assert_called_once_with(2)
2859
Edward Lemur75526302020-02-27 22:31:05 +00002860 def testRunPostUploadHook(self):
2861 cl = git_cl.Changelist()
2862 cl.RunPostUploadHook(2, 'upstream', 'description')
2863
2864 subprocess2.Popen.assert_called_once_with([
2865 'vpython', 'PRESUBMIT_SUPPORT',
2866 '--author', 'author',
2867 '--root', 'root',
2868 '--upstream', 'upstream',
2869 '--verbose', '--verbose',
2870 '--issue', '123456',
2871 '--patchset', '7',
2872 '--gerrit_url', 'https://chromium-review.googlesource.com',
2873 '--post_upload',
2874 '--description_file', '/tmp/fake-temp1',
2875 ])
2876 gclient_utils.FileWrite.assert_called_once_with(
2877 '/tmp/fake-temp1', b'description', mode='wb')
2878
Edward Lemur9aa1a962020-02-25 00:58:38 +00002879
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002880class CMDTestCaseBase(unittest.TestCase):
2881 _STATUSES = [
2882 'STATUS_UNSPECIFIED', 'SCHEDULED', 'STARTED', 'SUCCESS', 'FAILURE',
2883 'INFRA_FAILURE', 'CANCELED',
2884 ]
2885 _CHANGE_DETAIL = {
2886 'project': 'depot_tools',
2887 'status': 'OPEN',
2888 'owner': {'email': 'owner@e.mail'},
2889 'current_revision': 'beeeeeef',
2890 'revisions': {
2891 'deadbeaf': {'_number': 6},
2892 'beeeeeef': {
2893 '_number': 7,
2894 'fetch': {'http': {
2895 'url': 'https://chromium.googlesource.com/depot_tools',
2896 'ref': 'refs/changes/56/123456/7'
2897 }},
2898 },
2899 },
2900 }
2901 _DEFAULT_RESPONSE = {
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00002902 'builds': [{
2903 'id': str(100 + idx),
2904 'builder': {
2905 'project': 'chromium',
2906 'bucket': 'try',
2907 'builder': 'bot_' + status.lower(),
2908 },
2909 'createTime': '2019-10-09T08:00:0%d.854286Z' % (idx % 10),
2910 'tags': [],
2911 'status': status,
2912 } for idx, status in enumerate(_STATUSES)]
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002913 }
2914
Edward Lemur4c707a22019-09-24 21:13:43 +00002915 def setUp(self):
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002916 super(CMDTestCaseBase, self).setUp()
Edward Lemur79d4f992019-11-11 23:49:02 +00002917 mock.patch('git_cl.sys.stdout', StringIO()).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002918 mock.patch('git_cl.uuid.uuid4', return_value='uuid4').start()
2919 mock.patch('git_cl.Changelist.GetIssue', return_value=123456).start()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002920 mock.patch(
2921 'git_cl.Changelist.GetCodereviewServer',
2922 return_value='https://chromium-review.googlesource.com').start()
2923 mock.patch(
2924 'git_cl.Changelist._GetGerritHost',
2925 return_value='chromium-review.googlesource.com').start()
2926 mock.patch(
2927 'git_cl.Changelist.GetMostRecentPatchset',
2928 return_value=7).start()
2929 mock.patch(
2930 'git_cl.Changelist.GetRemoteUrl',
2931 return_value='https://chromium.googlesource.com/depot_tools').start()
2932 mock.patch(
2933 'auth.Authenticator',
2934 return_value=AuthenticatorMock()).start()
2935 mock.patch(
2936 'gerrit_util.GetChangeDetail',
2937 return_value=self._CHANGE_DETAIL).start()
2938 mock.patch(
2939 'git_cl._call_buildbucket',
2940 return_value = self._DEFAULT_RESPONSE).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002941 mock.patch('git_common.is_dirty_git_tree', return_value=False).start()
Edward Lemur4c707a22019-09-24 21:13:43 +00002942 self.addCleanup(mock.patch.stopall)
2943
Edward Lemur4c707a22019-09-24 21:13:43 +00002944
Edward Lemur9468eba2020-02-27 19:07:22 +00002945class CMDPresubmitTestCase(CMDTestCaseBase):
2946 def setUp(self):
2947 super(CMDPresubmitTestCase, self).setUp()
2948 mock.patch(
2949 'git_cl.Changelist.GetCommonAncestorWithUpstream',
2950 return_value='upstream').start()
2951 mock.patch(
2952 'git_cl.Changelist.FetchDescription',
2953 return_value='fetch description').start()
2954 mock.patch(
2955 'git_cl.Changelist.GetLocalDescription',
2956 return_value='get description').start()
2957 mock.patch('git_cl.Changelist.RunHook').start()
2958
2959 def testDefaultCase(self):
2960 self.assertEqual(0, git_cl.main(['presubmit']))
2961 git_cl.Changelist.RunHook.assert_called_once_with(
2962 committing=True,
2963 may_prompt=False,
2964 verbose=0,
2965 parallel=None,
2966 upstream='upstream',
2967 description='fetch description',
2968 all_files=None)
2969
2970 def testNoIssue(self):
2971 git_cl.Changelist.GetIssue.return_value = None
2972 self.assertEqual(0, git_cl.main(['presubmit']))
2973 git_cl.Changelist.RunHook.assert_called_once_with(
2974 committing=True,
2975 may_prompt=False,
2976 verbose=0,
2977 parallel=None,
2978 upstream='upstream',
2979 description='get description',
2980 all_files=None)
2981
2982 def testCustomBranch(self):
2983 self.assertEqual(0, git_cl.main(['presubmit', 'custom_branch']))
2984 git_cl.Changelist.RunHook.assert_called_once_with(
2985 committing=True,
2986 may_prompt=False,
2987 verbose=0,
2988 parallel=None,
2989 upstream='custom_branch',
2990 description='fetch description',
2991 all_files=None)
2992
2993 def testOptions(self):
2994 self.assertEqual(
2995 0, git_cl.main(['presubmit', '-v', '-v', '--all', '--parallel', '-u']))
2996 git_cl.Changelist.RunHook.assert_called_once_with(
2997 committing=False,
2998 may_prompt=False,
2999 verbose=2,
3000 parallel=True,
3001 upstream='upstream',
3002 description='fetch description',
3003 all_files=True)
3004
3005
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003006class CMDTryResultsTestCase(CMDTestCaseBase):
3007 _DEFAULT_REQUEST = {
3008 'predicate': {
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003009 "gerritChanges": [{
3010 "project": "depot_tools",
3011 "host": "chromium-review.googlesource.com",
3012 "patchset": 7,
3013 "change": 123456,
3014 }],
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003015 },
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003016 'fields': ('builds.*.id,builds.*.builder,builds.*.status' +
3017 ',builds.*.createTime,builds.*.tags'),
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003018 }
3019
3020 def testNoJobs(self):
3021 git_cl._call_buildbucket.return_value = {}
3022
3023 self.assertEqual(0, git_cl.main(['try-results']))
3024 self.assertEqual('No tryjobs scheduled.\n', sys.stdout.getvalue())
3025 git_cl._call_buildbucket.assert_called_once_with(
3026 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3027 self._DEFAULT_REQUEST)
3028
3029 def testPrintToStdout(self):
3030 self.assertEqual(0, git_cl.main(['try-results']))
3031 self.assertEqual([
3032 'Successes:',
3033 ' bot_success https://ci.chromium.org/b/103',
3034 'Infra Failures:',
3035 ' bot_infra_failure https://ci.chromium.org/b/105',
3036 'Failures:',
3037 ' bot_failure https://ci.chromium.org/b/104',
3038 'Canceled:',
3039 ' bot_canceled ',
3040 'Started:',
3041 ' bot_started https://ci.chromium.org/b/102',
3042 'Scheduled:',
3043 ' bot_scheduled id=101',
3044 'Other:',
3045 ' bot_status_unspecified id=100',
3046 'Total: 7 tryjobs',
3047 ], sys.stdout.getvalue().splitlines())
3048 git_cl._call_buildbucket.assert_called_once_with(
3049 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3050 self._DEFAULT_REQUEST)
3051
3052 def testPrintToStdoutWithMasters(self):
3053 self.assertEqual(0, git_cl.main(['try-results', '--print-master']))
3054 self.assertEqual([
3055 'Successes:',
3056 ' try bot_success https://ci.chromium.org/b/103',
3057 'Infra Failures:',
3058 ' try bot_infra_failure https://ci.chromium.org/b/105',
3059 'Failures:',
3060 ' try bot_failure https://ci.chromium.org/b/104',
3061 'Canceled:',
3062 ' try bot_canceled ',
3063 'Started:',
3064 ' try bot_started https://ci.chromium.org/b/102',
3065 'Scheduled:',
3066 ' try bot_scheduled id=101',
3067 'Other:',
3068 ' try bot_status_unspecified id=100',
3069 'Total: 7 tryjobs',
3070 ], sys.stdout.getvalue().splitlines())
3071 git_cl._call_buildbucket.assert_called_once_with(
3072 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3073 self._DEFAULT_REQUEST)
3074
3075 @mock.patch('git_cl.write_json')
3076 def testWriteToJson(self, mockJsonDump):
3077 self.assertEqual(0, git_cl.main(['try-results', '--json', 'file.json']))
3078 git_cl._call_buildbucket.assert_called_once_with(
3079 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3080 self._DEFAULT_REQUEST)
3081 mockJsonDump.assert_called_once_with(
3082 'file.json', self._DEFAULT_RESPONSE['builds'])
3083
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003084 def test_filter_failed_for_one_simple(self):
3085 self.assertEqual({}, git_cl._filter_failed_for_retry([]))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003086 self.assertEqual({
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003087 'chromium/try': {
3088 'bot_failure': [],
3089 'bot_infra_failure': []
3090 },
3091 }, git_cl._filter_failed_for_retry(self._DEFAULT_RESPONSE['builds']))
3092
3093 def test_filter_failed_for_retry_many_builds(self):
3094
3095 def _build(name, created_sec, status, experimental=False):
3096 assert 0 <= created_sec < 100, created_sec
3097 b = {
3098 'id': 112112,
3099 'builder': {
3100 'project': 'chromium',
3101 'bucket': 'try',
3102 'builder': name,
3103 },
3104 'createTime': '2019-10-09T08:00:%02d.854286Z' % created_sec,
3105 'status': status,
3106 'tags': [],
3107 }
3108 if experimental:
3109 b['tags'].append({'key': 'cq_experimental', 'value': 'true'})
3110 return b
3111
3112 builds = [
3113 _build('flaky-last-green', 1, 'FAILURE'),
3114 _build('flaky-last-green', 2, 'SUCCESS'),
3115 _build('flaky', 1, 'SUCCESS'),
3116 _build('flaky', 2, 'FAILURE'),
3117 _build('running', 1, 'FAILED'),
3118 _build('running', 2, 'SCHEDULED'),
3119 _build('yep-still-running', 1, 'STARTED'),
3120 _build('yep-still-running', 2, 'FAILURE'),
3121 _build('cq-experimental', 1, 'SUCCESS', experimental=True),
3122 _build('cq-experimental', 2, 'FAILURE', experimental=True),
3123
3124 # Simulate experimental in CQ builder, which developer decided
3125 # to retry manually which resulted in 2nd build non-experimental.
3126 _build('sometimes-experimental', 1, 'FAILURE', experimental=True),
3127 _build('sometimes-experimental', 2, 'FAILURE', experimental=False),
3128 ]
3129 builds.sort(key=lambda b: b['status']) # ~deterministic shuffle.
3130 self.assertEqual({
3131 'chromium/try': {
3132 'flaky': [],
3133 'sometimes-experimental': []
3134 },
3135 }, git_cl._filter_failed_for_retry(builds))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003136
3137
3138class CMDTryTestCase(CMDTestCaseBase):
3139
3140 @mock.patch('git_cl.Changelist.SetCQState')
3141 @mock.patch('git_cl._get_bucket_map', return_value={})
3142 def testSetCQDryRunByDefault(self, _mockGetBucketMap, mockSetCQState):
3143 mockSetCQState.return_value = 0
Edward Lemur4c707a22019-09-24 21:13:43 +00003144 self.assertEqual(0, git_cl.main(['try']))
3145 git_cl.Changelist.SetCQState.assert_called_with(git_cl._CQState.DRY_RUN)
3146 self.assertEqual(
3147 sys.stdout.getvalue(),
3148 'Scheduling CQ dry run on: '
3149 'https://chromium-review.googlesource.com/123456\n')
3150
Edward Lemur4c707a22019-09-24 21:13:43 +00003151 @mock.patch('git_cl._call_buildbucket')
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003152 def testScheduleOnBuildbucket(self, mockCallBuildbucket):
Edward Lemur4c707a22019-09-24 21:13:43 +00003153 mockCallBuildbucket.return_value = {}
Edward Lemur4c707a22019-09-24 21:13:43 +00003154
3155 self.assertEqual(0, git_cl.main([
3156 'try', '-B', 'luci.chromium.try', '-b', 'win',
3157 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
3158 self.assertIn(
3159 'Scheduling jobs on:\nBucket: luci.chromium.try',
3160 git_cl.sys.stdout.getvalue())
3161
3162 expected_request = {
3163 "requests": [{
3164 "scheduleBuild": {
3165 "requestId": "uuid4",
3166 "builder": {
3167 "project": "chromium",
3168 "builder": "win",
3169 "bucket": "try",
3170 },
3171 "gerritChanges": [{
3172 "project": "depot_tools",
3173 "host": "chromium-review.googlesource.com",
3174 "patchset": 7,
3175 "change": 123456,
3176 }],
3177 "properties": {
3178 "category": "git_cl_try",
3179 "json": [{"a": 1}, None],
3180 "key": "val",
3181 },
3182 "tags": [
3183 {"value": "win", "key": "builder"},
3184 {"value": "git_cl_try", "key": "user_agent"},
3185 ],
3186 },
3187 }],
3188 }
3189 mockCallBuildbucket.assert_called_with(
3190 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3191
Anthony Polito1a5fe232020-01-24 23:17:52 +00003192 @mock.patch('git_cl._call_buildbucket')
3193 def testScheduleOnBuildbucketWithRevision(self, mockCallBuildbucket):
3194 mockCallBuildbucket.return_value = {}
3195
3196 self.assertEqual(0, git_cl.main([
3197 'try', '-B', 'luci.chromium.try', '-b', 'win', '-b', 'linux',
3198 '-p', 'key=val', '-p', 'json=[{"a":1}, null]',
3199 '-r', 'beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef']))
3200 self.assertIn(
3201 'Scheduling jobs on:\nBucket: luci.chromium.try',
3202 git_cl.sys.stdout.getvalue())
3203
3204 expected_request = {
3205 "requests": [{
3206 "scheduleBuild": {
3207 "requestId": "uuid4",
3208 "builder": {
3209 "project": "chromium",
3210 "builder": "linux",
3211 "bucket": "try",
3212 },
3213 "gerritChanges": [{
3214 "project": "depot_tools",
3215 "host": "chromium-review.googlesource.com",
3216 "patchset": 7,
3217 "change": 123456,
3218 }],
3219 "properties": {
3220 "category": "git_cl_try",
3221 "json": [{"a": 1}, None],
3222 "key": "val",
3223 },
3224 "tags": [
3225 {"value": "linux", "key": "builder"},
3226 {"value": "git_cl_try", "key": "user_agent"},
3227 ],
3228 "gitilesCommit": {
3229 "host": "chromium-review.googlesource.com",
3230 "project": "depot_tools",
3231 "id": "beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef",
3232 }
3233 },
3234 },
3235 {
3236 "scheduleBuild": {
3237 "requestId": "uuid4",
3238 "builder": {
3239 "project": "chromium",
3240 "builder": "win",
3241 "bucket": "try",
3242 },
3243 "gerritChanges": [{
3244 "project": "depot_tools",
3245 "host": "chromium-review.googlesource.com",
3246 "patchset": 7,
3247 "change": 123456,
3248 }],
3249 "properties": {
3250 "category": "git_cl_try",
3251 "json": [{"a": 1}, None],
3252 "key": "val",
3253 },
3254 "tags": [
3255 {"value": "win", "key": "builder"},
3256 {"value": "git_cl_try", "key": "user_agent"},
3257 ],
3258 "gitilesCommit": {
3259 "host": "chromium-review.googlesource.com",
3260 "project": "depot_tools",
3261 "id": "beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef",
3262 }
3263 },
3264 }],
3265 }
3266 mockCallBuildbucket.assert_called_with(
3267 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3268
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003269 def testScheduleOnBuildbucket_WrongBucket(self):
Edward Lemur4c707a22019-09-24 21:13:43 +00003270 self.assertEqual(0, git_cl.main([
3271 'try', '-B', 'not-a-bucket', '-b', 'win',
3272 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
3273 self.assertIn(
3274 'WARNING Could not parse bucket "not-a-bucket". Skipping.',
3275 git_cl.sys.stdout.getvalue())
3276
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003277 @mock.patch('git_cl._call_buildbucket')
3278 @mock.patch('git_cl.fetch_try_jobs')
3279 def testScheduleOnBuildbucketRetryFailed(
3280 self, mockFetchTryJobs, mockCallBuildbucket):
3281
3282 git_cl.fetch_try_jobs.side_effect = lambda *_, **kw: {
3283 7: [],
3284 6: [{
3285 'id': 112112,
3286 'builder': {
3287 'project': 'chromium',
3288 'bucket': 'try',
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003289 'builder': 'linux',},
3290 'createTime': '2019-10-09T08:00:01.854286Z',
3291 'tags': [],
3292 'status': 'FAILURE',}],}[kw['patchset']]
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003293 mockCallBuildbucket.return_value = {}
3294
3295 self.assertEqual(0, git_cl.main(['try', '--retry-failed']))
3296 self.assertIn(
3297 'Scheduling jobs on:\nBucket: chromium/try',
3298 git_cl.sys.stdout.getvalue())
3299
3300 expected_request = {
3301 "requests": [{
3302 "scheduleBuild": {
3303 "requestId": "uuid4",
3304 "builder": {
3305 "project": "chromium",
3306 "bucket": "try",
3307 "builder": "linux",
3308 },
3309 "gerritChanges": [{
3310 "project": "depot_tools",
3311 "host": "chromium-review.googlesource.com",
3312 "patchset": 7,
3313 "change": 123456,
3314 }],
3315 "properties": {
3316 "category": "git_cl_try",
3317 },
3318 "tags": [
3319 {"value": "linux", "key": "builder"},
3320 {"value": "git_cl_try", "key": "user_agent"},
3321 {"value": "1", "key": "retry_failed"},
3322 ],
3323 },
3324 }],
3325 }
3326 mockCallBuildbucket.assert_called_with(
3327 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3328
Edward Lemur4c707a22019-09-24 21:13:43 +00003329 def test_parse_bucket(self):
3330 test_cases = [
3331 {
3332 'bucket': 'chromium/try',
3333 'result': ('chromium', 'try'),
3334 },
3335 {
3336 'bucket': 'luci.chromium.try',
3337 'result': ('chromium', 'try'),
3338 'has_warning': True,
3339 },
3340 {
3341 'bucket': 'skia.primary',
3342 'result': ('skia', 'skia.primary'),
3343 'has_warning': True,
3344 },
3345 {
3346 'bucket': 'not-a-bucket',
3347 'result': (None, None),
3348 },
3349 ]
3350
3351 for test_case in test_cases:
3352 git_cl.sys.stdout.truncate(0)
3353 self.assertEqual(
3354 test_case['result'], git_cl._parse_bucket(test_case['bucket']))
3355 if test_case.get('has_warning'):
Edward Lemur6215c792019-10-03 21:59:05 +00003356 expected_warning = 'WARNING Please use %s/%s to specify the bucket' % (
3357 test_case['result'])
3358 self.assertIn(expected_warning, git_cl.sys.stdout.getvalue())
Edward Lemur4c707a22019-09-24 21:13:43 +00003359
3360
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003361class CMDUploadTestCase(CMDTestCaseBase):
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003362 def setUp(self):
3363 super(CMDUploadTestCase, self).setUp()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003364 mock.patch('git_cl.fetch_try_jobs').start()
3365 mock.patch('git_cl._trigger_try_jobs', return_value={}).start()
3366 mock.patch('git_cl.Changelist.CMDUpload', return_value=0).start()
Anthony Polito46689b02019-11-15 20:56:41 +00003367 mock.patch('git_cl.Settings.GetIsGerrit', return_value=True).start()
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003368 self.addCleanup(mock.patch.stopall)
3369
Edward Lesmes7677e5c2020-02-19 20:39:03 +00003370 def testWarmUpChangeDetailCache(self):
3371 self.assertEqual(0, git_cl.main(['upload']))
3372 gerrit_util.GetChangeDetail.assert_called_once_with(
3373 'chromium-review.googlesource.com', 'depot_tools~123456',
3374 frozenset([
3375 'LABELS', 'CURRENT_REVISION', 'DETAILED_ACCOUNTS',
3376 'CURRENT_COMMIT']))
3377
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003378 def testUploadRetryFailed(self):
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003379 # This test mocks out the actual upload part, and just asserts that after
3380 # upload, if --retry-failed is added, then the tool will fetch try jobs
3381 # from the previous patchset and trigger the right builders on the latest
3382 # patchset.
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003383 git_cl.fetch_try_jobs.side_effect = [
3384 # Latest patchset: No builds.
3385 [],
3386 # Patchset before latest: Some builds.
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003387 [{
3388 'id': str(100 + idx),
3389 'builder': {
3390 'project': 'chromium',
3391 'bucket': 'try',
3392 'builder': 'bot_' + status.lower(),
3393 },
3394 'createTime': '2019-10-09T08:00:0%d.854286Z' % (idx % 10),
3395 'tags': [],
3396 'status': status,
3397 } for idx, status in enumerate(self._STATUSES)],
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +00003398 ]
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003399
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003400 self.assertEqual(0, git_cl.main(['upload', '--retry-failed']))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003401 self.assertEqual([
Edward Lemur5b929a42019-10-21 17:57:39 +00003402 mock.call(mock.ANY, 'cr-buildbucket.appspot.com', patchset=7),
3403 mock.call(mock.ANY, 'cr-buildbucket.appspot.com', patchset=6),
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003404 ], git_cl.fetch_try_jobs.mock_calls)
3405 expected_buckets = {
3406 'chromium/try': {'bot_failure': [], 'bot_infra_failure': []},
3407 }
3408 git_cl._trigger_try_jobs.assert_called_once_with(
Edward Lemur5b929a42019-10-21 17:57:39 +00003409 mock.ANY, expected_buckets, mock.ANY, 8)
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003410
Brian Sheedy59b06a82019-10-14 17:03:29 +00003411
Edward Lemurda4b6c62020-02-13 00:28:40 +00003412class CMDFormatTestCase(unittest.TestCase):
Brian Sheedy59b06a82019-10-14 17:03:29 +00003413
3414 def setUp(self):
3415 super(CMDFormatTestCase, self).setUp()
Jamie Madill5e96ad12020-01-13 16:08:35 +00003416 mock.patch('git_cl.RunCommand').start()
3417 mock.patch('clang_format.FindClangFormatToolInChromiumTree').start()
3418 mock.patch('clang_format.FindClangFormatScriptInChromiumTree').start()
3419 mock.patch('git_cl.settings').start()
Brian Sheedy59b06a82019-10-14 17:03:29 +00003420 self._top_dir = tempfile.mkdtemp()
Jamie Madill5e96ad12020-01-13 16:08:35 +00003421 self.addCleanup(mock.patch.stopall)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003422
3423 def tearDown(self):
3424 shutil.rmtree(self._top_dir)
3425 super(CMDFormatTestCase, self).tearDown()
3426
Jamie Madill5e96ad12020-01-13 16:08:35 +00003427 def _make_temp_file(self, fname, contents):
3428 with open(os.path.join(self._top_dir, fname), 'w') as tf:
3429 tf.write('\n'.join(contents))
3430
Brian Sheedy59b06a82019-10-14 17:03:29 +00003431 def _make_yapfignore(self, contents):
Jamie Madill5e96ad12020-01-13 16:08:35 +00003432 self._make_temp_file('.yapfignore', contents)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003433
Brian Sheedyb4307d52019-12-02 19:18:17 +00003434 def _check_yapf_filtering(self, files, expected):
3435 self.assertEqual(expected, git_cl._FilterYapfIgnoredFiles(
3436 files, git_cl._GetYapfIgnorePatterns(self._top_dir)))
Brian Sheedy59b06a82019-10-14 17:03:29 +00003437
Jamie Madill5e96ad12020-01-13 16:08:35 +00003438 def testClangFormatDiffFull(self):
3439 self._make_temp_file('test.cc', ['// test'])
3440 git_cl.settings.GetFormatFullByDefault.return_value = False
3441 diff_file = [os.path.join(self._top_dir, 'test.cc')]
3442 mock_opts = mock.Mock(full=True, dry_run=True, diff=False)
3443
3444 # Diff
3445 git_cl.RunCommand.return_value = ' // test'
3446 return_value = git_cl._RunClangFormatDiff(mock_opts, diff_file,
3447 self._top_dir, 'HEAD')
3448 self.assertEqual(2, return_value)
3449
3450 # No diff
3451 git_cl.RunCommand.return_value = '// test'
3452 return_value = git_cl._RunClangFormatDiff(mock_opts, diff_file,
3453 self._top_dir, 'HEAD')
3454 self.assertEqual(0, return_value)
3455
3456 def testClangFormatDiff(self):
3457 git_cl.settings.GetFormatFullByDefault.return_value = False
3458 mock_opts = mock.Mock(full=False, dry_run=True, diff=False)
3459
3460 # Diff
3461 git_cl.RunCommand.return_value = 'error'
3462 return_value = git_cl._RunClangFormatDiff(mock_opts, ['.'], self._top_dir,
3463 'HEAD')
3464 self.assertEqual(2, return_value)
3465
3466 # No diff
3467 git_cl.RunCommand.return_value = ''
3468 return_value = git_cl._RunClangFormatDiff(mock_opts, ['.'], self._top_dir,
3469 'HEAD')
3470 self.assertEqual(0, return_value)
3471
Brian Sheedyb4307d52019-12-02 19:18:17 +00003472 def testYapfignoreExplicit(self):
3473 self._make_yapfignore(['foo/bar.py', 'foo/bar/baz.py'])
3474 files = [
3475 'bar.py',
3476 'foo/bar.py',
3477 'foo/baz.py',
3478 'foo/bar/baz.py',
3479 'foo/bar/foobar.py',
3480 ]
3481 expected = [
3482 'bar.py',
3483 'foo/baz.py',
3484 'foo/bar/foobar.py',
3485 ]
3486 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003487
Brian Sheedyb4307d52019-12-02 19:18:17 +00003488 def testYapfignoreSingleWildcards(self):
3489 self._make_yapfignore(['*bar.py', 'foo*', 'baz*.py'])
3490 files = [
3491 'bar.py', # Matched by *bar.py.
3492 'bar.txt',
3493 'foobar.py', # Matched by *bar.py, foo*.
3494 'foobar.txt', # Matched by foo*.
3495 'bazbar.py', # Matched by *bar.py, baz*.py.
3496 'bazbar.txt',
3497 'foo/baz.txt', # Matched by foo*.
3498 'bar/bar.py', # Matched by *bar.py.
3499 'baz/foo.py', # Matched by baz*.py, foo*.
3500 'baz/foo.txt',
3501 ]
3502 expected = [
3503 'bar.txt',
3504 'bazbar.txt',
3505 'baz/foo.txt',
3506 ]
3507 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003508
Brian Sheedyb4307d52019-12-02 19:18:17 +00003509 def testYapfignoreMultiplewildcards(self):
3510 self._make_yapfignore(['*bar*', '*foo*baz.txt'])
3511 files = [
3512 'bar.py', # Matched by *bar*.
3513 'bar.txt', # Matched by *bar*.
3514 'abar.py', # Matched by *bar*.
3515 'foobaz.txt', # Matched by *foo*baz.txt.
3516 'foobaz.py',
3517 'afoobaz.txt', # Matched by *foo*baz.txt.
3518 ]
3519 expected = [
3520 'foobaz.py',
3521 ]
3522 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003523
3524 def testYapfignoreComments(self):
3525 self._make_yapfignore(['test.py', '#test2.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003526 files = [
3527 'test.py',
3528 'test2.py',
3529 ]
3530 expected = [
3531 'test2.py',
3532 ]
3533 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003534
3535 def testYapfignoreBlankLines(self):
3536 self._make_yapfignore(['test.py', '', '', 'test2.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003537 files = [
3538 'test.py',
3539 'test2.py',
3540 'test3.py',
3541 ]
3542 expected = [
3543 'test3.py',
3544 ]
3545 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003546
3547 def testYapfignoreWhitespace(self):
3548 self._make_yapfignore([' test.py '])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003549 files = [
3550 'test.py',
3551 'test2.py',
3552 ]
3553 expected = [
3554 'test2.py',
3555 ]
3556 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003557
Brian Sheedyb4307d52019-12-02 19:18:17 +00003558 def testYapfignoreNoFiles(self):
Brian Sheedy59b06a82019-10-14 17:03:29 +00003559 self._make_yapfignore(['test.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003560 self._check_yapf_filtering([], [])
3561
3562 def testYapfignoreMissingYapfignore(self):
3563 files = [
3564 'test.py',
3565 ]
3566 expected = [
3567 'test.py',
3568 ]
3569 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003570
3571
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003572if __name__ == '__main__':
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +01003573 logging.basicConfig(
3574 level=logging.DEBUG if '-v' in sys.argv else logging.ERROR)
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003575 unittest.main()