blob: 43d815163eaffd155fdbe21b8e88f333bbdfc088 [file] [log] [blame]
Josip Sokcevic4de5dea2022-03-23 21:15:14 +00001#!/usr/bin/env python3
maruel@chromium.org3bbf2942012-01-10 16:52:06 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Enables directory-specific presubmit checks to run at upload and/or commit.
7"""
8
Raul Tambre80ee78e2019-05-06 22:41:05 +00009from __future__ import print_function
10
Saagar Sanghavi99816902020-08-11 22:41:25 +000011__version__ = '2.0.0'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000012
13# TODO(joi) Add caching where appropriate/needed. The API is designed to allow
14# caching (between all different invocations of presubmit scripts for a given
15# change). We should add it as our presubmit scripts start feeling slow.
16
Edward Lemura5799e32020-01-17 19:26:51 +000017import argparse
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +090018import ast # Exposed through the API.
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +000019import contextlib
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +000020import cpplint
dcheng091b7db2016-06-16 01:27:51 -070021import fnmatch # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000022import glob
asvitkine@chromium.org15169952011-09-27 14:30:53 +000023import inspect
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +000024import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000025import json # Exposed through the API.
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +000026import logging
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000027import multiprocessing
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000028import os # Somewhat exposed through the API.
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000029import random
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000030import re # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040031import signal
Allen Webbfe7d7092021-05-18 02:05:49 +000032import six
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000033import sys # Parts exposed through API.
34import tempfile # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040035import threading
jam@chromium.org2a891dc2009-08-20 20:33:37 +000036import time
Edward Lemurde9e3ca2019-10-24 21:13:31 +000037import traceback
maruel@chromium.org1487d532009-06-06 00:22:57 +000038import unittest # Exposed through the API.
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000039from warnings import warn
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000040
41# Local imports.
maruel@chromium.org35625c72011-03-23 17:34:02 +000042import fix_encoding
Yoshisato Yanagisawa04600b42019-03-15 03:03:41 +000043import gclient_paths # Exposed through the API
44import gclient_utils
Josip Sokcevic7958e302023-03-01 23:02:21 +000045import git_footers
tandrii@chromium.org015ebae2016-04-25 19:37:22 +000046import gerrit_util
Edward Lesmes9ce03f82021-01-12 20:13:31 +000047import owners_client
Jochen Eisinger76f5fc62017-04-07 16:27:46 +020048import owners_finder
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000049import presubmit_canned_checks
Saagar Sanghavi9949ab72020-07-20 20:56:40 +000050import rdb_wrapper
Josip Sokcevic7958e302023-03-01 23:02:21 +000051import scm
maruel@chromium.org84f4fe32011-04-06 13:26:45 +000052import subprocess2 as subprocess # Exposed through the API.
Josip Sokcevic512fd3b2023-03-01 21:06:41 +000053from lib import utils
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000054
Edward Lemur16af3562019-10-17 22:11:33 +000055if sys.version_info.major == 2:
56 # TODO(1009814): Expose urllib2 only through urllib_request and urllib_error
57 import urllib2 # Exposed through the API.
58 import urlparse
59 import urllib2 as urllib_request
60 import urllib2 as urllib_error
61else:
62 import urllib.parse as urlparse
63 import urllib.request as urllib_request
64 import urllib.error as urllib_error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000065
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000066# Ask for feedback only once in program lifetime.
67_ASKED_FOR_FEEDBACK = False
68
Bruce Dawsondca14bc2022-09-15 20:59:38 +000069# Set if super-verbose mode is requested, for tracking where presubmit messages
70# are coming from.
71_SHOW_CALLSTACKS = False
72
Josip Sokcevic512fd3b2023-03-01 21:06:41 +000073_PRESUBMIT_FILE_REGEX = r'PRESUBMIT.*\.py$'
74_PRESUBMIT_FILE_EXCLUDE = r'PRESUBMIT_test'
75
Bruce Dawsondca14bc2022-09-15 20:59:38 +000076
Edward Lemurecc27072020-01-06 16:42:34 +000077def time_time():
78 # Use this so that it can be mocked in tests without interfering with python
79 # system machinery.
80 return time.time()
81
82
maruel@chromium.org899e1c12011-04-07 17:03:18 +000083class PresubmitFailure(Exception):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000084 pass
85
86
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000087class CommandData(object):
Edward Lemur940c2822019-08-23 00:34:25 +000088 def __init__(self, name, cmd, kwargs, message, python3=False):
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000089 self.name = name
90 self.cmd = cmd
Edward Lesmes8e282792018-04-03 18:50:29 -040091 self.stdin = kwargs.get('stdin', None)
Edward Lemur2d6b67c2019-08-23 22:25:41 +000092 self.kwargs = kwargs.copy()
Edward Lesmes8e282792018-04-03 18:50:29 -040093 self.kwargs['stdout'] = subprocess.PIPE
94 self.kwargs['stderr'] = subprocess.STDOUT
95 self.kwargs['stdin'] = subprocess.PIPE
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000096 self.message = message
97 self.info = None
Edward Lemur940c2822019-08-23 00:34:25 +000098 self.python3 = python3
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000099
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000100
Edward Lesmes8e282792018-04-03 18:50:29 -0400101# Adapted from
102# https://github.com/google/gtest-parallel/blob/master/gtest_parallel.py#L37
103#
104# An object that catches SIGINT sent to the Python process and notices
105# if processes passed to wait() die by SIGINT (we need to look for
106# both of those cases, because pressing Ctrl+C can result in either
107# the main process or one of the subprocesses getting the signal).
108#
109# Before a SIGINT is seen, wait(p) will simply call p.wait() and
110# return the result. Once a SIGINT has been seen (in the main process
111# or a subprocess, including the one the current call is waiting for),
Edward Lemur9a5bb612019-09-26 02:01:52 +0000112# wait(p) will call p.terminate().
Edward Lesmes8e282792018-04-03 18:50:29 -0400113class SigintHandler(object):
Edward Lesmes8e282792018-04-03 18:50:29 -0400114 sigint_returncodes = {-signal.SIGINT, # Unix
115 -1073741510, # Windows
116 }
117 def __init__(self):
118 self.__lock = threading.Lock()
119 self.__processes = set()
120 self.__got_sigint = False
Edward Lemur9a5bb612019-09-26 02:01:52 +0000121 self.__previous_signal = signal.signal(signal.SIGINT, self.interrupt)
Edward Lesmes8e282792018-04-03 18:50:29 -0400122
123 def __on_sigint(self):
124 self.__got_sigint = True
125 while self.__processes:
126 try:
127 self.__processes.pop().terminate()
128 except OSError:
129 pass
130
Edward Lemur9a5bb612019-09-26 02:01:52 +0000131 def interrupt(self, signal_num, frame):
Edward Lesmes8e282792018-04-03 18:50:29 -0400132 with self.__lock:
133 self.__on_sigint()
Edward Lemur9a5bb612019-09-26 02:01:52 +0000134 self.__previous_signal(signal_num, frame)
Edward Lesmes8e282792018-04-03 18:50:29 -0400135
136 def got_sigint(self):
137 with self.__lock:
138 return self.__got_sigint
139
140 def wait(self, p, stdin):
141 with self.__lock:
142 if self.__got_sigint:
143 p.terminate()
144 self.__processes.add(p)
145 stdout, stderr = p.communicate(stdin)
146 code = p.returncode
147 with self.__lock:
148 self.__processes.discard(p)
149 if code in self.sigint_returncodes:
150 self.__on_sigint()
Edward Lesmes8e282792018-04-03 18:50:29 -0400151 return stdout, stderr
152
153sigint_handler = SigintHandler()
154
155
Edward Lemurecc27072020-01-06 16:42:34 +0000156class Timer(object):
157 def __init__(self, timeout, fn):
158 self.completed = False
159 self._fn = fn
160 self._timer = threading.Timer(timeout, self._onTimer) if timeout else None
161
162 def __enter__(self):
163 if self._timer:
164 self._timer.start()
165 return self
166
167 def __exit__(self, _type, _value, _traceback):
168 if self._timer:
169 self._timer.cancel()
170
171 def _onTimer(self):
172 self._fn()
173 self.completed = True
174
175
Edward Lesmes8e282792018-04-03 18:50:29 -0400176class ThreadPool(object):
Edward Lemurecc27072020-01-06 16:42:34 +0000177 def __init__(self, pool_size=None, timeout=None):
178 self.timeout = timeout
Edward Lesmes8e282792018-04-03 18:50:29 -0400179 self._pool_size = pool_size or multiprocessing.cpu_count()
Bruce Dawson8254f062022-06-17 17:33:08 +0000180 if sys.platform == 'win32':
181 # TODO(crbug.com/1190269) - we can't use more than 56 child processes on
182 # Windows or Python3 may hang.
183 self._pool_size = min(self._pool_size, 56)
Edward Lesmes8e282792018-04-03 18:50:29 -0400184 self._messages = []
185 self._messages_lock = threading.Lock()
186 self._tests = []
187 self._tests_lock = threading.Lock()
188 self._nonparallel_tests = []
189
Edward Lemurecc27072020-01-06 16:42:34 +0000190 def _GetCommand(self, test):
Edward Lemur940c2822019-08-23 00:34:25 +0000191 vpython = 'vpython'
192 if test.python3:
193 vpython += '3'
194 if sys.platform == 'win32':
195 vpython += '.bat'
Edward Lesmes8e282792018-04-03 18:50:29 -0400196
197 cmd = test.cmd
198 if cmd[0] == 'python':
199 cmd = list(cmd)
200 cmd[0] = vpython
201 elif cmd[0].endswith('.py'):
202 cmd = [vpython] + cmd
203
Edward Lemur336e51f2019-11-14 21:42:04 +0000204 # On Windows, scripts on the current directory take precedence over PATH, so
205 # that when testing depot_tools on Windows, calling `vpython.bat` will
206 # execute the copy of vpython of the depot_tools under test instead of the
207 # one in the bot.
208 # As a workaround, we run the tests from the parent directory instead.
209 if (cmd[0] == vpython and
210 'cwd' in test.kwargs and
211 os.path.basename(test.kwargs['cwd']) == 'depot_tools'):
212 test.kwargs['cwd'] = os.path.dirname(test.kwargs['cwd'])
213 cmd[1] = os.path.join('depot_tools', cmd[1])
214
Edward Lemurecc27072020-01-06 16:42:34 +0000215 return cmd
216
217 def _RunWithTimeout(self, cmd, stdin, kwargs):
218 p = subprocess.Popen(cmd, **kwargs)
219 with Timer(self.timeout, p.terminate) as timer:
220 stdout, _ = sigint_handler.wait(p, stdin)
Josip Sokcevic6635baf2021-11-19 02:04:39 +0000221 stdout = stdout.decode('utf-8', 'ignore')
Edward Lemurecc27072020-01-06 16:42:34 +0000222 if timer.completed:
223 stdout = 'Process timed out after %ss\n%s' % (self.timeout, stdout)
Josip Sokcevic6635baf2021-11-19 02:04:39 +0000224 return p.returncode, stdout
Edward Lemurecc27072020-01-06 16:42:34 +0000225
226 def CallCommand(self, test):
227 """Runs an external program.
228
Edward Lemura5799e32020-01-17 19:26:51 +0000229 This function converts invocation of .py files and invocations of 'python'
Edward Lemurecc27072020-01-06 16:42:34 +0000230 to vpython invocations.
231 """
232 cmd = self._GetCommand(test)
Edward Lesmes8e282792018-04-03 18:50:29 -0400233 try:
Edward Lemurecc27072020-01-06 16:42:34 +0000234 start = time_time()
235 returncode, stdout = self._RunWithTimeout(cmd, test.stdin, test.kwargs)
236 duration = time_time() - start
Edward Lemur7cf94382019-11-15 22:36:41 +0000237 except Exception:
Edward Lemurecc27072020-01-06 16:42:34 +0000238 duration = time_time() - start
Edward Lesmes8e282792018-04-03 18:50:29 -0400239 return test.message(
Edward Lemur7cf94382019-11-15 22:36:41 +0000240 '%s\n%s exec failure (%4.2fs)\n%s' % (
241 test.name, ' '.join(cmd), duration, traceback.format_exc()))
Edward Lemurde9e3ca2019-10-24 21:13:31 +0000242
Edward Lemurecc27072020-01-06 16:42:34 +0000243 if returncode != 0:
Edward Lesmes8e282792018-04-03 18:50:29 -0400244 return test.message(
Edward Lemur7cf94382019-11-15 22:36:41 +0000245 '%s\n%s (%4.2fs) failed\n%s' % (
246 test.name, ' '.join(cmd), duration, stdout))
Edward Lemurecc27072020-01-06 16:42:34 +0000247
Edward Lesmes8e282792018-04-03 18:50:29 -0400248 if test.info:
Edward Lemur7cf94382019-11-15 22:36:41 +0000249 return test.info('%s\n%s (%4.2fs)' % (test.name, ' '.join(cmd), duration))
Edward Lesmes8e282792018-04-03 18:50:29 -0400250
251 def AddTests(self, tests, parallel=True):
252 if parallel:
253 self._tests.extend(tests)
254 else:
255 self._nonparallel_tests.extend(tests)
256
257 def RunAsync(self):
258 self._messages = []
259
260 def _WorkerFn():
261 while True:
262 test = None
263 with self._tests_lock:
264 if not self._tests:
265 break
266 test = self._tests.pop()
267 result = self.CallCommand(test)
268 if result:
269 with self._messages_lock:
270 self._messages.append(result)
271
272 def _StartDaemon():
273 t = threading.Thread(target=_WorkerFn)
274 t.daemon = True
275 t.start()
276 return t
277
278 while self._nonparallel_tests:
279 test = self._nonparallel_tests.pop()
280 result = self.CallCommand(test)
281 if result:
282 self._messages.append(result)
283
284 if self._tests:
285 threads = [_StartDaemon() for _ in range(self._pool_size)]
286 for worker in threads:
287 worker.join()
288
289 return self._messages
290
291
Josip Sokcevic7958e302023-03-01 23:02:21 +0000292def _RightHandSideLinesImpl(affected_files):
293 """Implements RightHandSideLines for InputApi and GclChange."""
294 for af in affected_files:
295 lines = af.ChangedContents()
296 for line in lines:
297 yield (af, line[0], line[1])
298
299
Edward Lemur6eb1d322020-02-27 22:20:15 +0000300def prompt_should_continue(prompt_string):
301 sys.stdout.write(prompt_string)
Dirk Pranke7288f882021-06-03 18:01:30 +0000302 sys.stdout.flush()
Edward Lemur6eb1d322020-02-27 22:20:15 +0000303 response = sys.stdin.readline().strip().lower()
304 return response in ('y', 'yes')
dpranke@chromium.org5ac21012011-03-16 02:58:25 +0000305
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000306# Top level object so multiprocessing can pickle
307# Public access through OutputApi object.
308class _PresubmitResult(object):
309 """Base class for result objects."""
310 fatal = False
311 should_prompt = False
312
313 def __init__(self, message, items=None, long_text=''):
314 """
315 message: A short one-line message to indicate errors.
316 items: A list of short strings to indicate where errors occurred.
317 long_text: multi-line text output, e.g. from another tool
318 """
Bruce Dawsondb8622b2022-04-03 15:38:12 +0000319 self._message = _PresubmitResult._ensure_str(message)
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000320 self._items = items or []
Tom McKee61c72652021-07-20 11:56:32 +0000321 self._long_text = _PresubmitResult._ensure_str(long_text.rstrip())
Bruce Dawsondca14bc2022-09-15 20:59:38 +0000322 if _SHOW_CALLSTACKS:
323 self._long_text += 'Presubmit result call stack is:\n'
324 self._long_text += ''.join(traceback.format_stack(None, 8))
Tom McKee61c72652021-07-20 11:56:32 +0000325
326 @staticmethod
327 def _ensure_str(val):
328 """
329 val: A "stringish" value. Can be any of str, unicode or bytes.
330 returns: A str after applying encoding/decoding as needed.
331 Assumes/uses UTF-8 for relevant inputs/outputs.
332
333 We'd prefer to use six.ensure_str but our copy of six is old :(
334 """
335 if isinstance(val, str):
336 return val
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +0000337
Tom McKee61c72652021-07-20 11:56:32 +0000338 if six.PY2 and isinstance(val, unicode):
339 return val.encode()
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +0000340
341 if six.PY3 and isinstance(val, bytes):
Tom McKee61c72652021-07-20 11:56:32 +0000342 return val.decode()
343 raise ValueError("Unknown string type %s" % type(val))
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000344
Edward Lemur6eb1d322020-02-27 22:20:15 +0000345 def handle(self):
346 sys.stdout.write(self._message)
347 sys.stdout.write('\n')
Takuto Ikutabaa7be02022-08-23 00:19:34 +0000348 for item in self._items:
Edward Lemur6eb1d322020-02-27 22:20:15 +0000349 sys.stdout.write(' ')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000350 # Write separately in case it's unicode.
Edward Lemur6eb1d322020-02-27 22:20:15 +0000351 sys.stdout.write(str(item))
Edward Lemur6eb1d322020-02-27 22:20:15 +0000352 sys.stdout.write('\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000353 if self._long_text:
Edward Lemur6eb1d322020-02-27 22:20:15 +0000354 sys.stdout.write('\n***************\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000355 # Write separately in case it's unicode.
Tom McKee61c72652021-07-20 11:56:32 +0000356 sys.stdout.write(self._long_text)
Edward Lemur6eb1d322020-02-27 22:20:15 +0000357 sys.stdout.write('\n***************\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000358
Debrian Figueroadd2737e2019-06-21 23:50:13 +0000359 def json_format(self):
360 return {
361 'message': self._message,
Debrian Figueroa6095d402019-06-28 18:47:18 +0000362 'items': [str(item) for item in self._items],
Debrian Figueroadd2737e2019-06-21 23:50:13 +0000363 'long_text': self._long_text,
364 'fatal': self.fatal
365 }
366
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000367
368# Top level object so multiprocessing can pickle
369# Public access through OutputApi object.
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000370class _PresubmitError(_PresubmitResult):
371 """A hard presubmit error."""
372 fatal = True
373
374
375# Top level object so multiprocessing can pickle
376# Public access through OutputApi object.
377class _PresubmitPromptWarning(_PresubmitResult):
378 """An warning that prompts the user if they want to continue."""
379 should_prompt = True
380
381
382# Top level object so multiprocessing can pickle
383# Public access through OutputApi object.
384class _PresubmitNotifyResult(_PresubmitResult):
385 """Just print something to the screen -- but it's not even a warning."""
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000386
387
388# Top level object so multiprocessing can pickle
389# Public access through OutputApi object.
390class _MailTextResult(_PresubmitResult):
391 """A warning that should be included in the review request email."""
392 def __init__(self, *args, **kwargs):
393 super(_MailTextResult, self).__init__()
394 raise NotImplementedError()
395
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000396class GerritAccessor(object):
397 """Limited Gerrit functionality for canned presubmit checks to work.
398
399 To avoid excessive Gerrit calls, caches the results.
400 """
401
Edward Lesmeseb1bd622021-03-01 19:54:07 +0000402 def __init__(self, url=None, project=None, branch=None):
403 self.host = urlparse.urlparse(url).netloc if url else None
404 self.project = project
405 self.branch = branch
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000406 self.cache = {}
Edward Lesmes8170c292021-03-19 20:04:43 +0000407 self.code_owners_enabled = None
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000408
409 def _FetchChangeDetail(self, issue):
410 # Separate function to be easily mocked in tests.
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100411 try:
412 return gerrit_util.GetChangeDetail(
413 self.host, str(issue),
Aaron Gable6f5a8d92017-04-18 14:49:05 -0700414 ['ALL_REVISIONS', 'DETAILED_LABELS', 'ALL_COMMITS'])
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100415 except gerrit_util.GerritError as e:
416 if e.http_status == 404:
417 raise Exception('Either Gerrit issue %s doesn\'t exist, or '
418 'no credentials to fetch issue details' % issue)
419 raise
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000420
421 def GetChangeInfo(self, issue):
422 """Returns labels and all revisions (patchsets) for this issue.
423
424 The result is a dictionary according to Gerrit REST Api.
425 https://gerrit-review.googlesource.com/Documentation/rest-api.html
426
427 However, API isn't very clear what's inside, so see tests for example.
428 """
429 assert issue
430 cache_key = int(issue)
431 if cache_key not in self.cache:
432 self.cache[cache_key] = self._FetchChangeDetail(issue)
433 return self.cache[cache_key]
434
435 def GetChangeDescription(self, issue, patchset=None):
436 """If patchset is none, fetches current patchset."""
437 info = self.GetChangeInfo(issue)
438 # info is a reference to cache. We'll modify it here adding description to
439 # it to the right patchset, if it is not yet there.
440
441 # Find revision info for the patchset we want.
442 if patchset is not None:
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +0000443 for rev, rev_info in info['revisions'].items():
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000444 if str(rev_info['_number']) == str(patchset):
445 break
446 else:
447 raise Exception('patchset %s doesn\'t exist in issue %s' % (
448 patchset, issue))
449 else:
450 rev = info['current_revision']
451 rev_info = info['revisions'][rev]
452
Andrii Shyshkalov9c3a4642017-01-24 17:41:22 +0100453 return rev_info['commit']['message']
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000454
Mun Yong Jang603d01e2017-12-19 16:38:30 -0800455 def GetDestRef(self, issue):
456 ref = self.GetChangeInfo(issue)['branch']
457 if not ref.startswith('refs/'):
458 # NOTE: it is possible to create 'refs/x' branch,
459 # aka 'refs/heads/refs/x'. However, this is ill-advised.
460 ref = 'refs/heads/%s' % ref
461 return ref
462
Edward Lesmes02d4b822020-11-11 00:37:35 +0000463 def _GetApproversForLabel(self, issue, label):
464 change_info = self.GetChangeInfo(issue)
465 label_info = change_info.get('labels', {}).get(label, {})
466 values = label_info.get('values', {}).keys()
467 if not values:
468 return []
469 max_value = max(int(v) for v in values)
470 return [v for v in label_info.get('all', [])
471 if v.get('value', 0) == max_value]
472
Edward Lesmesc4566172021-03-19 16:55:13 +0000473 def IsBotCommitApproved(self, issue):
474 return bool(self._GetApproversForLabel(issue, 'Bot-Commit'))
475
Edward Lesmescf49cb82020-11-11 01:08:36 +0000476 def IsOwnersOverrideApproved(self, issue):
477 return bool(self._GetApproversForLabel(issue, 'Owners-Override'))
478
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000479 def GetChangeOwner(self, issue):
480 return self.GetChangeInfo(issue)['owner']['email']
481
482 def GetChangeReviewers(self, issue, approving_only=True):
Aaron Gable8b478f02017-07-31 15:33:19 -0700483 changeinfo = self.GetChangeInfo(issue)
484 if approving_only:
Edward Lesmes02d4b822020-11-11 00:37:35 +0000485 reviewers = self._GetApproversForLabel(issue, 'Code-Review')
Aaron Gable8b478f02017-07-31 15:33:19 -0700486 else:
487 reviewers = changeinfo.get('reviewers', {}).get('REVIEWER', [])
488 return [r.get('email') for r in reviewers]
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000489
Edward Lemure4d329c2020-02-03 20:41:18 +0000490 def UpdateDescription(self, description, issue):
491 gerrit_util.SetCommitMessage(self.host, issue, description, notify='NONE')
492
Edward Lesmes8170c292021-03-19 20:04:43 +0000493 def IsCodeOwnersEnabledOnRepo(self):
494 if self.code_owners_enabled is None:
495 self.code_owners_enabled = gerrit_util.IsCodeOwnersEnabledOnRepo(
Edward Lesmes392c4072021-03-19 21:58:45 +0000496 self.host, self.project)
Edward Lesmes8170c292021-03-19 20:04:43 +0000497 return self.code_owners_enabled
498
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000499
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000500class OutputApi(object):
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000501 """An instance of OutputApi gets passed to presubmit scripts so that they
502 can output various types of results.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000503 """
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000504 PresubmitResult = _PresubmitResult
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000505 PresubmitError = _PresubmitError
506 PresubmitPromptWarning = _PresubmitPromptWarning
507 PresubmitNotifyResult = _PresubmitNotifyResult
508 MailTextResult = _MailTextResult
509
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000510 def __init__(self, is_committing):
511 self.is_committing = is_committing
Daniel Cheng7227d212017-11-17 08:12:37 -0800512 self.more_cc = []
513
514 def AppendCC(self, cc):
515 """Appends a user to cc for this change."""
Daniel Cheng0e9f6682022-10-19 17:42:57 +0000516 if cc not in self.more_cc:
517 self.more_cc.append(cc)
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000518
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000519 def PresubmitPromptOrNotify(self, *args, **kwargs):
520 """Warn the user when uploading, but only notify if committing."""
521 if self.is_committing:
522 return self.PresubmitNotifyResult(*args, **kwargs)
523 return self.PresubmitPromptWarning(*args, **kwargs)
524
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000525
526class InputApi(object):
527 """An instance of this object is passed to presubmit scripts so they can
528 know stuff about the change they're looking at.
529 """
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000530 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800531 # pylint: disable=no-self-use
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000532
maruel@chromium.org3410d912009-06-09 20:56:16 +0000533 # File extensions that are considered source files from a style guide
534 # perspective. Don't modify this list from a presubmit script!
maruel@chromium.orgc33455a2011-06-24 19:14:18 +0000535 #
536 # Files without an extension aren't included in the list. If you want to
local_bot30f774e2020-06-25 18:23:34 +0000537 # filter them as source files, add r'(^|.*?[\\\/])[^.]+$' to the allow list.
local_bot64021412020-07-08 21:05:39 +0000538 # Note that ALL CAPS files are skipped in DEFAULT_FILES_TO_SKIP below.
539 DEFAULT_FILES_TO_CHECK = (
maruel@chromium.org3410d912009-06-09 20:56:16 +0000540 # C++ and friends
Edward Lemura5799e32020-01-17 19:26:51 +0000541 r'.+\.c$', r'.+\.cc$', r'.+\.cpp$', r'.+\.h$', r'.+\.m$', r'.+\.mm$',
542 r'.+\.inl$', r'.+\.asm$', r'.+\.hxx$', r'.+\.hpp$', r'.+\.s$', r'.+\.S$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000543 # Scripts
dpapad443d9132022-05-05 00:17:30 +0000544 r'.+\.js$', r'.+\.ts$', r'.+\.py$', r'.+\.sh$', r'.+\.rb$', r'.+\.pl$',
545 r'.+\.pm$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000546 # Other
Edward Lemura5799e32020-01-17 19:26:51 +0000547 r'.+\.java$', r'.+\.mk$', r'.+\.am$', r'.+\.css$', r'.+\.mojom$',
Bruce Dawson7a81ebf2023-01-03 18:36:18 +0000548 r'.+\.fidl$', r'.+\.rs$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000549 )
550
551 # Path regexp that should be excluded from being considered containing source
552 # files. Don't modify this list from a presubmit script!
local_bot64021412020-07-08 21:05:39 +0000553 DEFAULT_FILES_TO_SKIP = (
Edward Lemura5799e32020-01-17 19:26:51 +0000554 r'testing_support[\\\/]google_appengine[\\\/].*',
555 r'.*\bexperimental[\\\/].*',
Kent Tamura179dd1e2018-04-26 15:07:41 +0900556 # Exclude third_party/.* but NOT third_party/{WebKit,blink}
557 # (crbug.com/539768 and crbug.com/836555).
Edward Lemura5799e32020-01-17 19:26:51 +0000558 r'.*\bthird_party[\\\/](?!(WebKit|blink)[\\\/]).*',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000559 # Output directories (just in case)
Edward Lemura5799e32020-01-17 19:26:51 +0000560 r'.*\bDebug[\\\/].*',
561 r'.*\bRelease[\\\/].*',
562 r'.*\bxcodebuild[\\\/].*',
563 r'.*\bout[\\\/].*',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000564 # All caps files like README and LICENCE.
Edward Lemura5799e32020-01-17 19:26:51 +0000565 r'.*\b[A-Z0-9_]{2,}$',
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000566 # SCM (can happen in dual SCM configuration). (Slightly over aggressive)
Edward Lemura5799e32020-01-17 19:26:51 +0000567 r'(|.*[\\\/])\.git[\\\/].*',
568 r'(|.*[\\\/])\.svn[\\\/].*',
maruel@chromium.org7ccb4bb2011-11-07 20:26:20 +0000569 # There is no point in processing a patch file.
Edward Lemura5799e32020-01-17 19:26:51 +0000570 r'.+\.diff$',
571 r'.+\.patch$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000572 )
573
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000574 def __init__(self, change, presubmit_path, is_committing,
Bruce Dawson09c0c072022-05-26 20:28:58 +0000575 verbose, gerrit_obj, dry_run=None, thread_pool=None, parallel=False,
576 no_diffs=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000577 """Builds an InputApi object.
578
579 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000580 change: A presubmit.Change object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000581 presubmit_path: The path to the presubmit script being processed.
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000582 is_committing: True if the change is about to be committed.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000583 gerrit_obj: provides basic Gerrit codereview functionality.
584 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -0400585 parallel: if true, all tests reported via input_api.RunTests for all
586 PRESUBMIT files will be run in parallel.
Bruce Dawson09c0c072022-05-26 20:28:58 +0000587 no_diffs: if true, implies that --files or --all was specified so some
588 checks can be skipped, and some errors will be messages.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000589 """
maruel@chromium.org9711bba2009-05-22 23:51:39 +0000590 # Version number of the presubmit_support script.
591 self.version = [int(x) for x in __version__.split('.')]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000592 self.change = change
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000593 self.is_committing = is_committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000594 self.gerrit = gerrit_obj
tandrii@chromium.org57bafac2016-04-28 05:09:03 +0000595 self.dry_run = dry_run
Bruce Dawson09c0c072022-05-26 20:28:58 +0000596 self.no_diffs = no_diffs
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000597
Edward Lesmes8e282792018-04-03 18:50:29 -0400598 self.parallel = parallel
599 self.thread_pool = thread_pool or ThreadPool()
600
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000601 # We expose various modules and functions as attributes of the input_api
602 # so that presubmit scripts don't have to import them.
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +0900603 self.ast = ast
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000604 self.basename = os.path.basename
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000605 self.cpplint = cpplint
dcheng091b7db2016-06-16 01:27:51 -0700606 self.fnmatch = fnmatch
Yoshisato Yanagisawa04600b42019-03-15 03:03:41 +0000607 self.gclient_paths = gclient_paths
Yoshisato Yanagisawa57dd17b2019-03-22 09:10:29 +0000608 # TODO(yyanagisawa): stop exposing this when python3 become default.
609 # Since python3's tempfile has TemporaryDirectory, we do not need this.
610 self.temporary_directory = gclient_utils.temporary_directory
dpranke@chromium.org17cc2442012-10-17 21:12:09 +0000611 self.glob = glob.glob
maruel@chromium.orgfb11c7b2010-03-18 18:22:14 +0000612 self.json = json
maruel@chromium.org6fba34d2011-06-02 13:45:12 +0000613 self.logging = logging.getLogger('PRESUBMIT')
maruel@chromium.org2b5ce562011-03-31 16:15:44 +0000614 self.os_listdir = os.listdir
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000615 self.os_path = os.path
pgervais@chromium.orgbd0cace2014-10-02 23:23:46 +0000616 self.os_stat = os.stat
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +0000617 self.os_walk = os.walk
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000618 self.re = re
619 self.subprocess = subprocess
Edward Lemurb9830242019-10-30 22:19:20 +0000620 self.sys = sys
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000621 self.tempfile = tempfile
dpranke@chromium.org0d1bdea2011-03-24 22:54:38 +0000622 self.time = time
maruel@chromium.org1487d532009-06-06 00:22:57 +0000623 self.unittest = unittest
Edward Lemurb9830242019-10-30 22:19:20 +0000624 if sys.version_info.major == 2:
625 self.urllib2 = urllib2
Edward Lemur16af3562019-10-17 22:11:33 +0000626 self.urllib_request = urllib_request
627 self.urllib_error = urllib_error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000628
Robert Iannucci50258932018-03-19 10:30:59 -0700629 self.is_windows = sys.platform == 'win32'
630
Edward Lemurb9646622019-10-25 20:57:35 +0000631 # Set python_executable to 'vpython' in order to allow scripts in other
632 # repos (e.g. src.git) to automatically pick up that repo's .vpython file,
633 # instead of inheriting the one in depot_tools.
634 self.python_executable = 'vpython'
Erik Staab69135d12021-05-14 22:31:57 +0000635 # Offer a python 3 executable for use during the migration off of python 2.
636 self.python3_executable = 'vpython3'
maruel@chromium.orgc0b22972009-06-25 16:19:14 +0000637 self.environ = os.environ
638
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000639 # InputApi.platform is the platform you're currently running on.
640 self.platform = sys.platform
641
iannucci@chromium.org0af3bb32015-06-12 20:44:35 +0000642 self.cpu_count = multiprocessing.cpu_count()
Bruce Dawson8254f062022-06-17 17:33:08 +0000643 if self.is_windows:
644 # TODO(crbug.com/1190269) - we can't use more than 56 child processes on
645 # Windows or Python3 may hang.
646 self.cpu_count = min(self.cpu_count, 56)
iannucci@chromium.org0af3bb32015-06-12 20:44:35 +0000647
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000648 # The local path of the currently-being-processed presubmit script.
maruel@chromium.org3d235242009-05-15 12:40:48 +0000649 self._current_presubmit_path = os.path.dirname(presubmit_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000650
651 # We carry the canned checks so presubmit scripts can easily use them.
652 self.canned_checks = presubmit_canned_checks
653
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100654 # Temporary files we must manually remove at the end of a run.
655 self._named_temporary_files = []
Jochen Eisinger72606f82017-04-04 10:44:18 +0200656
Edward Lesmesdc11c6b2021-03-19 19:22:05 +0000657 self.owners_client = None
Bruce Dawsoneb8426e2022-08-05 23:58:15 +0000658 if self.gerrit and not 'PRESUBMIT_SKIP_NETWORK' in self.environ:
Bruce Dawson9b9f4512022-04-27 00:56:52 +0000659 try:
660 self.owners_client = owners_client.GetCodeOwnersClient(
Bruce Dawson9b9f4512022-04-27 00:56:52 +0000661 host=self.gerrit.host,
662 project=self.gerrit.project,
663 branch=self.gerrit.branch)
664 except Exception as e:
665 print('Failed to set owners_client - %s' % str(e))
Jochen Eisinger76f5fc62017-04-07 16:27:46 +0200666 self.owners_finder = owners_finder.OwnersFinder
maruel@chromium.org899e1c12011-04-07 17:03:18 +0000667 self.verbose = verbose
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000668 self.Command = CommandData
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000669
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000670 # Replace <hash_map> and <hash_set> as headers that need to be included
Edward Lemura5799e32020-01-17 19:26:51 +0000671 # with 'base/containers/hash_tables.h' instead.
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000672 # Access to a protected member _XX of a client class
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800673 # pylint: disable=protected-access
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000674 self.cpplint._re_pattern_templates = [
danakj@chromium.org18278522013-06-11 22:42:32 +0000675 (a, b, 'base/containers/hash_tables.h')
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000676 if header in ('<hash_map>', '<hash_set>') else (a, b, header)
677 for (a, b, header) in cpplint._re_pattern_templates
678 ]
679
Edward Lemurecc27072020-01-06 16:42:34 +0000680 def SetTimeout(self, timeout):
681 self.thread_pool.timeout = timeout
682
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000683 def PresubmitLocalPath(self):
684 """Returns the local path of the presubmit script currently being run.
685
686 This is useful if you don't want to hard-code absolute paths in the
687 presubmit script. For example, It can be used to find another file
688 relative to the PRESUBMIT.py script, so the whole tree can be branched and
689 the presubmit script still works, without editing its content.
690 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000691 return self._current_presubmit_path
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000692
agable0b65e732016-11-22 09:25:46 -0800693 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000694 """Same as input_api.change.AffectedFiles() except only lists files
695 (and optionally directories) in the same directory as the current presubmit
Bruce Dawson7a0b07a2020-04-23 17:14:40 +0000696 script, or subdirectories thereof. Note that files are listed using the OS
697 path separator, so backslashes are used as separators on Windows.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000698 """
Josip Sokcevic512fd3b2023-03-01 21:06:41 +0000699 dir_with_slash = utils.normpath(self.PresubmitLocalPath())
Bruce Dawson31bfd512022-05-10 23:19:39 +0000700 # normpath strips trailing path separators, so the trailing separator has to
701 # be added after the normpath call.
702 if len(dir_with_slash) > 0:
703 dir_with_slash += os.path.sep
sail@chromium.org5538e022011-05-12 17:53:16 +0000704
Josip Sokcevic512fd3b2023-03-01 21:06:41 +0000705 return list(
706 filter(
707 lambda x: utils.normpath(x.AbsoluteLocalPath()).startswith(
708 dir_with_slash),
709 self.change.AffectedFiles(include_deletes, file_filter)))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000710
agable0b65e732016-11-22 09:25:46 -0800711 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000712 """Returns local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800713 paths = [af.LocalPath() for af in self.AffectedFiles()]
Edward Lemura5799e32020-01-17 19:26:51 +0000714 logging.debug('LocalPaths: %s', paths)
pgervais@chromium.org2f64f782014-04-25 00:12:33 +0000715 return paths
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000716
agable0b65e732016-11-22 09:25:46 -0800717 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000718 """Returns absolute local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800719 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000720
John Budorick16162372018-04-18 10:39:53 -0700721 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
agable0b65e732016-11-22 09:25:46 -0800722 """Same as input_api.change.AffectedTestableFiles() except only lists files
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000723 in the same directory as the current presubmit script, or subdirectories
724 thereof.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000725 """
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000726 if include_deletes is not None:
Edward Lemura5799e32020-01-17 19:26:51 +0000727 warn('AffectedTestableFiles(include_deletes=%s)'
728 ' is deprecated and ignored' % str(include_deletes),
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000729 category=DeprecationWarning,
730 stacklevel=2)
Josip Sokcevic4de5dea2022-03-23 21:15:14 +0000731 # pylint: disable=consider-using-generator
732 return [
733 x for x in self.AffectedFiles(include_deletes=False, **kwargs)
734 if x.IsTestableFile()
735 ]
agable0b65e732016-11-22 09:25:46 -0800736
737 def AffectedTextFiles(self, include_deletes=None):
738 """An alias to AffectedTestableFiles for backwards compatibility."""
739 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000740
Josip Sokcevic8c955952021-02-01 21:32:57 +0000741 def FilterSourceFile(self,
742 affected_file,
743 files_to_check=None,
744 files_to_skip=None,
745 allow_list=None,
746 block_list=None):
Edward Lemura5799e32020-01-17 19:26:51 +0000747 """Filters out files that aren't considered 'source file'.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000748
local_bot64021412020-07-08 21:05:39 +0000749 If files_to_check or files_to_skip is None, InputApi.DEFAULT_FILES_TO_CHECK
750 and InputApi.DEFAULT_FILES_TO_SKIP is used respectively.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000751
Bruce Dawson635383f2022-09-13 16:23:18 +0000752 affected_file.LocalPath() needs to re.match an entry in the files_to_check
753 list and not re.match any entries in the files_to_skip list.
754 '/' path separators should be used in the regular expressions and will work
755 on Windows as well as other platforms.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000756
757 Note: Copy-paste this function to suit your needs or use a lambda function.
758 """
local_bot64021412020-07-08 21:05:39 +0000759 if files_to_check is None:
760 files_to_check = self.DEFAULT_FILES_TO_CHECK
761 if files_to_skip is None:
762 files_to_skip = self.DEFAULT_FILES_TO_SKIP
local_bot30f774e2020-06-25 18:23:34 +0000763
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000764 def Find(affected_file, items):
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000765 local_path = affected_file.LocalPath()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000766 for item in items:
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000767 if self.re.match(item, local_path):
maruel@chromium.org3410d912009-06-09 20:56:16 +0000768 return True
Bruce Dawsona3a014e2022-04-27 23:28:17 +0000769 # Handle the cases where the files regex only handles /, but the local
770 # path uses \.
771 if self.is_windows and self.re.match(item, local_path.replace(
772 '\\', '/')):
773 return True
maruel@chromium.org3410d912009-06-09 20:56:16 +0000774 return False
local_bot64021412020-07-08 21:05:39 +0000775 return (Find(affected_file, files_to_check) and
776 not Find(affected_file, files_to_skip))
maruel@chromium.org3410d912009-06-09 20:56:16 +0000777
778 def AffectedSourceFiles(self, source_file):
agable0b65e732016-11-22 09:25:46 -0800779 """Filter the list of AffectedTestableFiles by the function source_file.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000780
781 If source_file is None, InputApi.FilterSourceFile() is used.
782 """
783 if not source_file:
784 source_file = self.FilterSourceFile
Edward Lemurb9830242019-10-30 22:19:20 +0000785 return list(filter(source_file, self.AffectedTestableFiles()))
maruel@chromium.org3410d912009-06-09 20:56:16 +0000786
787 def RightHandSideLines(self, source_file_filter=None):
Edward Lemura5799e32020-01-17 19:26:51 +0000788 """An iterator over all text lines in 'new' version of changed files.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000789
790 Only lists lines from new or modified text files in the change that are
791 contained by the directory of the currently executing presubmit script.
792
793 This is useful for doing line-by-line regex checks, like checking for
794 trailing whitespace.
795
796 Yields:
797 a 3 tuple:
Josip Sokcevic7958e302023-03-01 23:02:21 +0000798 the AffectedFile instance of the current file;
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000799 integer line number (1-based); and
800 the contents of the line as a string.
maruel@chromium.org1487d532009-06-06 00:22:57 +0000801
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000802 Note: The carriage return (LF or CR) is stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000803 """
maruel@chromium.org3410d912009-06-09 20:56:16 +0000804 files = self.AffectedSourceFiles(source_file_filter)
Josip Sokcevic7958e302023-03-01 23:02:21 +0000805 return _RightHandSideLinesImpl(files)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000806
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000807 def ReadFile(self, file_item, mode='r'):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000808 """Reads an arbitrary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000809
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000810 Deny reading anything outside the repository.
811 """
Josip Sokcevic7958e302023-03-01 23:02:21 +0000812 if isinstance(file_item, AffectedFile):
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000813 file_item = file_item.AbsoluteLocalPath()
814 if not file_item.startswith(self.change.RepositoryRoot()):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000815 raise IOError('Access outside the repository root is denied.')
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +0000816 return gclient_utils.FileRead(file_item, mode)
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000817
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100818 def CreateTemporaryFile(self, **kwargs):
819 """Returns a named temporary file that must be removed with a call to
820 RemoveTemporaryFiles().
821
822 All keyword arguments are forwarded to tempfile.NamedTemporaryFile(),
823 except for |delete|, which is always set to False.
824
825 Presubmit checks that need to create a temporary file and pass it for
826 reading should use this function instead of NamedTemporaryFile(), as
827 Windows fails to open a file that is already open for writing.
828
829 with input_api.CreateTemporaryFile() as f:
830 f.write('xyz')
831 f.close()
832 input_api.subprocess.check_output(['script-that', '--reads-from',
833 f.name])
834
835
836 Note that callers of CreateTemporaryFile() should not worry about removing
837 any temporary file; this is done transparently by the presubmit handling
838 code.
839 """
840 if 'delete' in kwargs:
841 # Prevent users from passing |delete|; we take care of file deletion
842 # ourselves and this prevents unintuitive error messages when we pass
843 # delete=False and 'delete' is also in kwargs.
844 raise TypeError('CreateTemporaryFile() does not take a "delete" '
845 'argument, file deletion is handled automatically by '
846 'the same presubmit_support code that creates InputApi '
847 'objects.')
848 temp_file = self.tempfile.NamedTemporaryFile(delete=False, **kwargs)
849 self._named_temporary_files.append(temp_file.name)
850 return temp_file
851
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000852 @property
853 def tbr(self):
854 """Returns if a change is TBR'ed."""
Jeremy Romandce22502017-06-20 15:37:29 -0400855 return 'TBR' in self.change.tags or self.change.TBRsFromDescription()
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000856
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000857 def RunTests(self, tests_mix, parallel=True):
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000858 tests = []
859 msgs = []
860 for t in tests_mix:
Edward Lesmes8e282792018-04-03 18:50:29 -0400861 if isinstance(t, OutputApi.PresubmitResult) and t:
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000862 msgs.append(t)
863 else:
864 assert issubclass(t.message, _PresubmitResult)
865 tests.append(t)
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000866 if self.verbose:
867 t.info = _PresubmitNotifyResult
Edward Lemur1037c742018-05-01 18:56:04 -0400868 if not t.kwargs.get('cwd'):
869 t.kwargs['cwd'] = self.PresubmitLocalPath()
Edward Lesmes8e282792018-04-03 18:50:29 -0400870 self.thread_pool.AddTests(tests, parallel)
Edward Lemur21000eb2019-05-24 23:25:58 +0000871 # When self.parallel is True (i.e. --parallel is passed as an option)
872 # RunTests doesn't actually run tests. It adds them to a ThreadPool that
873 # will run all tests once all PRESUBMIT files are processed.
874 # Otherwise, it will run them and return the results.
875 if not self.parallel:
Edward Lesmes8e282792018-04-03 18:50:29 -0400876 msgs.extend(self.thread_pool.RunAsync())
877 return msgs
scottmg86099d72016-09-01 09:16:51 -0700878
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000879
Josip Sokcevic7958e302023-03-01 23:02:21 +0000880class _DiffCache(object):
881 """Caches diffs retrieved from a particular SCM."""
882 def __init__(self, upstream=None):
883 """Stores the upstream revision against which all diffs will be computed."""
884 self._upstream = upstream
885
886 def GetDiff(self, path, local_root):
887 """Get the diff for a particular path."""
888 raise NotImplementedError()
889
890 def GetOldContents(self, path, local_root):
891 """Get the old version for a particular path."""
892 raise NotImplementedError()
893
894
895class _GitDiffCache(_DiffCache):
896 """DiffCache implementation for git; gets all file diffs at once."""
897 def __init__(self, upstream):
898 super(_GitDiffCache, self).__init__(upstream=upstream)
899 self._diffs_by_file = None
900
901 def GetDiff(self, path, local_root):
902 # Compare against None to distinguish between None and an initialized but
903 # empty dictionary.
904 if self._diffs_by_file == None:
905 # Compute a single diff for all files and parse the output; should
906 # with git this is much faster than computing one diff for each file.
907 diffs = {}
908
909 # Don't specify any filenames below, because there are command line length
910 # limits on some platforms and GenerateDiff would fail.
911 unified_diff = scm.GIT.GenerateDiff(local_root, files=[], full_move=True,
912 branch=self._upstream)
913
914 # This regex matches the path twice, separated by a space. Note that
915 # filename itself may contain spaces.
916 file_marker = re.compile('^diff --git (?P<filename>.*) (?P=filename)$')
917 current_diff = []
918 keep_line_endings = True
919 for x in unified_diff.splitlines(keep_line_endings):
920 match = file_marker.match(x)
921 if match:
922 # Marks the start of a new per-file section.
923 diffs[match.group('filename')] = current_diff = [x]
924 elif x.startswith('diff --git'):
925 raise PresubmitFailure('Unexpected diff line: %s' % x)
926 else:
927 current_diff.append(x)
928
929 self._diffs_by_file = dict(
930 (utils.normpath(path), ''.join(diff)) for path, diff in diffs.items())
931
932 if path not in self._diffs_by_file:
933 # SCM didn't have any diff on this file. It could be that the file was not
934 # modified at all (e.g. user used --all flag in git cl presubmit).
935 # Intead of failing, return empty string.
936 # See: https://crbug.com/808346.
937 return ''
938
939 return self._diffs_by_file[path]
940
941 def GetOldContents(self, path, local_root):
942 return scm.GIT.GetOldContents(local_root, path, branch=self._upstream)
943
944
945class AffectedFile(object):
946 """Representation of a file in a change."""
947
948 DIFF_CACHE = _DiffCache
949
950 # Method could be a function
951 # pylint: disable=no-self-use
952 def __init__(self, path, action, repository_root, diff_cache):
953 self._path = path
954 self._action = action
955 self._local_root = repository_root
956 self._is_directory = None
957 self._cached_changed_contents = None
958 self._cached_new_contents = None
959 self._diff_cache = diff_cache
960 logging.debug('%s(%s)', self.__class__.__name__, self._path)
961
962 def LocalPath(self):
963 """Returns the path of this file on the local disk relative to client root.
964
965 This should be used for error messages but not for accessing files,
966 because presubmit checks are run with CWD=PresubmitLocalPath() (which is
967 often != client root).
968 """
969 return utils.normpath(self._path)
970
971 def AbsoluteLocalPath(self):
972 """Returns the absolute path of this file on the local disk.
973 """
974 return os.path.abspath(os.path.join(self._local_root, self.LocalPath()))
975
976 def Action(self):
977 """Returns the action on this opened file, e.g. A, M, D, etc."""
978 return self._action
979
980 def IsTestableFile(self):
981 """Returns True if the file is a text file and not a binary file.
982
983 Deleted files are not text file."""
984 raise NotImplementedError() # Implement when needed
985
986 def IsTextFile(self):
987 """An alias to IsTestableFile for backwards compatibility."""
988 return self.IsTestableFile()
989
990 def OldContents(self):
991 """Returns an iterator over the lines in the old version of file.
992
993 The old version is the file before any modifications in the user's
994 workspace, i.e. the 'left hand side'.
995
996 Contents will be empty if the file is a directory or does not exist.
997 Note: The carriage returns (LF or CR) are stripped off.
998 """
999 return self._diff_cache.GetOldContents(self.LocalPath(),
1000 self._local_root).splitlines()
1001
1002 def NewContents(self):
1003 """Returns an iterator over the lines in the new version of file.
1004
1005 The new version is the file in the user's workspace, i.e. the 'right hand
1006 side'.
1007
1008 Contents will be empty if the file is a directory or does not exist.
1009 Note: The carriage returns (LF or CR) are stripped off.
1010 """
1011 if self._cached_new_contents is None:
1012 self._cached_new_contents = []
1013 try:
1014 self._cached_new_contents = gclient_utils.FileRead(
1015 self.AbsoluteLocalPath(), 'rU').splitlines()
1016 except IOError:
1017 pass # File not found? That's fine; maybe it was deleted.
1018 except UnicodeDecodeError as e:
1019 # log the filename since we're probably trying to read a binary
1020 # file, and shouldn't be.
1021 print('Error reading %s: %s' % (self.AbsoluteLocalPath(), e))
1022 raise
1023
1024 return self._cached_new_contents[:]
1025
1026 def ChangedContents(self, keeplinebreaks=False):
1027 """Returns a list of tuples (line number, line text) of all new lines.
1028
1029 This relies on the scm diff output describing each changed code section
1030 with a line of the form
1031
1032 ^@@ <old line num>,<old size> <new line num>,<new size> @@$
1033 """
1034 # Don't return cached results when line breaks are requested.
1035 if not keeplinebreaks and self._cached_changed_contents is not None:
1036 return self._cached_changed_contents[:]
1037 result = []
1038 line_num = 0
1039
1040 # The keeplinebreaks parameter to splitlines must be True or else the
1041 # CheckForWindowsLineEndings presubmit will be a NOP.
1042 for line in self.GenerateScmDiff().splitlines(keeplinebreaks):
1043 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
1044 if m:
1045 line_num = int(m.groups(1)[0])
1046 continue
1047 if line.startswith('+') and not line.startswith('++'):
1048 result.append((line_num, line[1:]))
1049 if not line.startswith('-'):
1050 line_num += 1
1051 # Don't cache results with line breaks.
1052 if keeplinebreaks:
1053 return result;
1054 self._cached_changed_contents = result
1055 return self._cached_changed_contents[:]
1056
1057 def __str__(self):
1058 return self.LocalPath()
1059
1060 def GenerateScmDiff(self):
1061 return self._diff_cache.GetDiff(self.LocalPath(), self._local_root)
1062
1063
1064class GitAffectedFile(AffectedFile):
1065 """Representation of a file in a change out of a git checkout."""
1066 # Method 'NNN' is abstract in class 'NNN' but is not overridden
1067 # pylint: disable=abstract-method
1068
1069 DIFF_CACHE = _GitDiffCache
1070
1071 def __init__(self, *args, **kwargs):
1072 AffectedFile.__init__(self, *args, **kwargs)
1073 self._server_path = None
1074 self._is_testable_file = None
1075
1076 def IsTestableFile(self):
1077 if self._is_testable_file is None:
1078 if self.Action() == 'D':
1079 # A deleted file is not testable.
1080 self._is_testable_file = False
1081 else:
1082 self._is_testable_file = os.path.isfile(self.AbsoluteLocalPath())
1083 return self._is_testable_file
1084
1085
1086class Change(object):
1087 """Describe a change.
1088
1089 Used directly by the presubmit scripts to query the current change being
1090 tested.
1091
1092 Instance members:
1093 tags: Dictionary of KEY=VALUE pairs found in the change description.
1094 self.KEY: equivalent to tags['KEY']
1095 """
1096
1097 _AFFECTED_FILES = AffectedFile
1098
1099 # Matches key/value (or 'tag') lines in changelist descriptions.
1100 TAG_LINE_RE = re.compile(
1101 '^[ \t]*(?P<key>[A-Z][A-Z_0-9]*)[ \t]*=[ \t]*(?P<value>.*?)[ \t]*$')
1102 scm = ''
1103
1104 def __init__(
1105 self, name, description, local_root, files, issue, patchset, author,
1106 upstream=None):
1107 if files is None:
1108 files = []
1109 self._name = name
1110 # Convert root into an absolute path.
1111 self._local_root = os.path.abspath(local_root)
1112 self._upstream = upstream
1113 self.issue = issue
1114 self.patchset = patchset
1115 self.author_email = author
1116
1117 self._full_description = ''
1118 self.tags = {}
1119 self._description_without_tags = ''
1120 self.SetDescriptionText(description)
1121
1122 assert all(
1123 (isinstance(f, (list, tuple)) and len(f) == 2) for f in files), files
1124
1125 diff_cache = self._AFFECTED_FILES.DIFF_CACHE(self._upstream)
1126 self._affected_files = [
1127 self._AFFECTED_FILES(path, action.strip(), self._local_root, diff_cache)
1128 for action, path in files
1129 ]
1130
1131 def UpstreamBranch(self):
1132 """Returns the upstream branch for the change."""
1133 return self._upstream
1134
1135 def Name(self):
1136 """Returns the change name."""
1137 return self._name
1138
1139 def DescriptionText(self):
1140 """Returns the user-entered changelist description, minus tags.
1141
1142 Any line in the user-provided description starting with e.g. 'FOO='
1143 (whitespace permitted before and around) is considered a tag line. Such
1144 lines are stripped out of the description this function returns.
1145 """
1146 return self._description_without_tags
1147
1148 def FullDescriptionText(self):
1149 """Returns the complete changelist description including tags."""
1150 return self._full_description
1151
1152 def SetDescriptionText(self, description):
1153 """Sets the full description text (including tags) to |description|.
1154
1155 Also updates the list of tags."""
1156 self._full_description = description
1157
1158 # From the description text, build up a dictionary of key/value pairs
1159 # plus the description minus all key/value or 'tag' lines.
1160 description_without_tags = []
1161 self.tags = {}
1162 for line in self._full_description.splitlines():
1163 m = self.TAG_LINE_RE.match(line)
1164 if m:
1165 self.tags[m.group('key')] = m.group('value')
1166 else:
1167 description_without_tags.append(line)
1168
1169 # Change back to text and remove whitespace at end.
1170 self._description_without_tags = (
1171 '\n'.join(description_without_tags).rstrip())
1172
1173 def AddDescriptionFooter(self, key, value):
1174 """Adds the given footer to the change description.
1175
1176 Args:
1177 key: A string with the key for the git footer. It must conform to
1178 the git footers format (i.e. 'List-Of-Tokens') and will be case
1179 normalized so that each token is title-cased.
1180 value: A string with the value for the git footer.
1181 """
1182 description = git_footers.add_footer(
1183 self.FullDescriptionText(), git_footers.normalize_name(key), value)
1184 self.SetDescriptionText(description)
1185
1186 def RepositoryRoot(self):
1187 """Returns the repository (checkout) root directory for this change,
1188 as an absolute path.
1189 """
1190 return self._local_root
1191
1192 def __getattr__(self, attr):
1193 """Return tags directly as attributes on the object."""
1194 if not re.match(r'^[A-Z_]*$', attr):
1195 raise AttributeError(self, attr)
1196 return self.tags.get(attr)
1197
1198 def GitFootersFromDescription(self):
1199 """Return the git footers present in the description.
1200
1201 Returns:
1202 footers: A dict of {footer: [values]} containing a multimap of the footers
1203 in the change description.
1204 """
1205 return git_footers.parse_footers(self.FullDescriptionText())
1206
1207 def BugsFromDescription(self):
1208 """Returns all bugs referenced in the commit description."""
1209 bug_tags = ['BUG', 'FIXED']
1210
1211 tags = []
1212 for tag in bug_tags:
1213 values = self.tags.get(tag)
1214 if values:
1215 tags += [value.strip() for value in values.split(',')]
1216
1217 footers = []
1218 parsed = self.GitFootersFromDescription()
1219 unsplit_footers = parsed.get('Bug', []) + parsed.get('Fixed', [])
1220 for unsplit_footer in unsplit_footers:
1221 footers += [b.strip() for b in unsplit_footer.split(',')]
1222 return sorted(set(tags + footers))
1223
1224 def ReviewersFromDescription(self):
1225 """Returns all reviewers listed in the commit description."""
1226 # We don't support a 'R:' git-footer for reviewers; that is in metadata.
1227 tags = [r.strip() for r in self.tags.get('R', '').split(',') if r.strip()]
1228 return sorted(set(tags))
1229
1230 def TBRsFromDescription(self):
1231 """Returns all TBR reviewers listed in the commit description."""
1232 tags = [r.strip() for r in self.tags.get('TBR', '').split(',') if r.strip()]
1233 # TODO(crbug.com/839208): Remove support for 'Tbr:' when TBRs are
1234 # programmatically determined by self-CR+1s.
1235 footers = self.GitFootersFromDescription().get('Tbr', [])
1236 return sorted(set(tags + footers))
1237
1238 # TODO(crbug.com/753425): Delete these once we're sure they're unused.
1239 @property
1240 def BUG(self):
1241 return ','.join(self.BugsFromDescription())
1242 @property
1243 def R(self):
1244 return ','.join(self.ReviewersFromDescription())
1245 @property
1246 def TBR(self):
1247 return ','.join(self.TBRsFromDescription())
1248
1249 def AllFiles(self, root=None):
1250 """List all files under source control in the repo."""
1251 raise NotImplementedError()
1252
1253 def AffectedFiles(self, include_deletes=True, file_filter=None):
1254 """Returns a list of AffectedFile instances for all files in the change.
1255
1256 Args:
1257 include_deletes: If false, deleted files will be filtered out.
1258 file_filter: An additional filter to apply.
1259
1260 Returns:
1261 [AffectedFile(path, action), AffectedFile(path, action)]
1262 """
1263 affected = list(filter(file_filter, self._affected_files))
1264
1265 if include_deletes:
1266 return affected
1267 return list(filter(lambda x: x.Action() != 'D', affected))
1268
1269 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
1270 """Return a list of the existing text files in a change."""
1271 if include_deletes is not None:
1272 warn('AffectedTeestableFiles(include_deletes=%s)'
1273 ' is deprecated and ignored' % str(include_deletes),
1274 category=DeprecationWarning,
1275 stacklevel=2)
1276 return list(filter(
1277 lambda x: x.IsTestableFile(),
1278 self.AffectedFiles(include_deletes=False, **kwargs)))
1279
1280 def AffectedTextFiles(self, include_deletes=None):
1281 """An alias to AffectedTestableFiles for backwards compatibility."""
1282 return self.AffectedTestableFiles(include_deletes=include_deletes)
1283
1284 def LocalPaths(self):
1285 """Convenience function."""
1286 return [af.LocalPath() for af in self.AffectedFiles()]
1287
1288 def AbsoluteLocalPaths(self):
1289 """Convenience function."""
1290 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
1291
1292 def RightHandSideLines(self):
1293 """An iterator over all text lines in 'new' version of changed files.
1294
1295 Lists lines from new or modified text files in the change.
1296
1297 This is useful for doing line-by-line regex checks, like checking for
1298 trailing whitespace.
1299
1300 Yields:
1301 a 3 tuple:
1302 the AffectedFile instance of the current file;
1303 integer line number (1-based); and
1304 the contents of the line as a string.
1305 """
1306 return _RightHandSideLinesImpl(
1307 x for x in self.AffectedFiles(include_deletes=False)
1308 if x.IsTestableFile())
1309
1310 def OriginalOwnersFiles(self):
1311 """A map from path names of affected OWNERS files to their old content."""
1312 def owners_file_filter(f):
1313 return 'OWNERS' in os.path.split(f.LocalPath())[1]
1314 files = self.AffectedFiles(file_filter=owners_file_filter)
1315 return {f.LocalPath(): f.OldContents() for f in files}
1316
1317
1318class GitChange(Change):
1319 _AFFECTED_FILES = GitAffectedFile
1320 scm = 'git'
1321
1322 def AllFiles(self, root=None):
1323 """List all files under source control in the repo."""
1324 root = root or self.RepositoryRoot()
1325 return subprocess.check_output(
1326 ['git', '-c', 'core.quotePath=false', 'ls-files', '--', '.'],
1327 cwd=root).decode('utf-8', 'ignore').splitlines()
1328
1329
rmistry@google.com5626a922015-02-26 14:03:30 +00001330class GetPostUploadExecuter(object):
Pavol Marko624e7ee2023-01-09 09:56:29 +00001331 def __init__(self, change, gerrit_obj, use_python3):
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001332 """
1333 Args:
Pavol Marko624e7ee2023-01-09 09:56:29 +00001334 change: The Change object.
1335 gerrit_obj: provides basic Gerrit codereview functionality.
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001336 use_python3: if true, will use python3 instead of python2 by default
1337 if USE_PYTHON3 is not specified.
1338 """
Pavol Marko624e7ee2023-01-09 09:56:29 +00001339 self.change = change
1340 self.gerrit = gerrit_obj
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001341 self.use_python3 = use_python3
1342
Pavol Marko624e7ee2023-01-09 09:56:29 +00001343 def ExecPresubmitScript(self, script_text, presubmit_path):
rmistry@google.com5626a922015-02-26 14:03:30 +00001344 """Executes PostUploadHook() from a single presubmit script.
Josip Sokcevic632bbc02022-05-19 05:32:50 +00001345 Caller is responsible for validating whether the hook should be executed
1346 and should only call this function if it should be.
rmistry@google.com5626a922015-02-26 14:03:30 +00001347
1348 Args:
1349 script_text: The text of the presubmit script.
1350 presubmit_path: Project script to run.
rmistry@google.com5626a922015-02-26 14:03:30 +00001351
1352 Return:
1353 A list of results objects.
1354 """
Pavol Marko624e7ee2023-01-09 09:56:29 +00001355 # Change to the presubmit file's directory to support local imports.
1356 presubmit_dir = os.path.dirname(presubmit_path)
1357 main_path = os.getcwd()
1358 try:
1359 os.chdir(presubmit_dir)
1360 return self._execute_with_local_working_directory(script_text,
1361 presubmit_dir,
1362 presubmit_path)
1363 finally:
1364 # Return the process to the original working directory.
1365 os.chdir(main_path)
1366
1367 def _execute_with_local_working_directory(self, script_text, presubmit_dir,
1368 presubmit_path):
rmistry@google.com5626a922015-02-26 14:03:30 +00001369 context = {}
1370 try:
Pavol Marko624e7ee2023-01-09 09:56:29 +00001371 exec(compile(script_text, presubmit_path, 'exec', dont_inherit=True),
Raul Tambre09e64b42019-05-14 01:57:22 +00001372 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001373 except Exception as e:
rmistry@google.com5626a922015-02-26 14:03:30 +00001374 raise PresubmitFailure('"%s" had an exception.\n%s'
1375 % (presubmit_path, e))
1376
1377 function_name = 'PostUploadHook'
1378 if function_name not in context:
1379 return {}
1380 post_upload_hook = context[function_name]
1381 if not len(inspect.getargspec(post_upload_hook)[0]) == 3:
1382 raise PresubmitFailure(
1383 'Expected function "PostUploadHook" to take three arguments.')
Pavol Marko624e7ee2023-01-09 09:56:29 +00001384 return post_upload_hook(self.gerrit, self.change, OutputApi(False))
rmistry@google.com5626a922015-02-26 14:03:30 +00001385
1386
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001387def _MergeMasters(masters1, masters2):
1388 """Merges two master maps. Merges also the tests of each builder."""
1389 result = {}
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001390 for (master, builders) in itertools.chain(masters1.items(),
1391 masters2.items()):
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001392 new_builders = result.setdefault(master, {})
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001393 for (builder, tests) in builders.items():
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001394 new_builders.setdefault(builder, set([])).update(tests)
1395 return result
1396
1397
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001398def DoPostUploadExecuter(change, gerrit_obj, verbose, use_python3=False):
rmistry@google.com5626a922015-02-26 14:03:30 +00001399 """Execute the post upload hook.
1400
1401 Args:
1402 change: The Change object.
Edward Lemur016a0872020-02-04 22:13:28 +00001403 gerrit_obj: The GerritAccessor object.
rmistry@google.com5626a922015-02-26 14:03:30 +00001404 verbose: Prints debug info.
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001405 use_python3: if true, default to using Python3 for presubmit checks
1406 rather than Python2.
rmistry@google.com5626a922015-02-26 14:03:30 +00001407 """
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001408 python_version = 'Python %s' % sys.version_info.major
1409 sys.stdout.write('Running %s post upload checks ...\n' % python_version)
Josip Sokcevic512fd3b2023-03-01 21:06:41 +00001410 presubmit_files = utils.ListRelevantFilesInSourceCheckout(
1411 change.LocalPaths(), change.RepositoryRoot(), _PRESUBMIT_FILE_REGEX,
1412 _PRESUBMIT_FILE_EXCLUDE)
rmistry@google.com5626a922015-02-26 14:03:30 +00001413 if not presubmit_files and verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001414 sys.stdout.write('Warning, no PRESUBMIT.py found.\n')
rmistry@google.com5626a922015-02-26 14:03:30 +00001415 results = []
Pavol Marko624e7ee2023-01-09 09:56:29 +00001416 executer = GetPostUploadExecuter(change, gerrit_obj, use_python3)
rmistry@google.com5626a922015-02-26 14:03:30 +00001417 # The root presubmit file should be executed after the ones in subdirectories.
1418 # i.e. the specific post upload hooks should run before the general ones.
Josip Sokcevic512fd3b2023-03-01 21:06:41 +00001419 # Thus, reverse the order.
rmistry@google.com5626a922015-02-26 14:03:30 +00001420 presubmit_files.reverse()
1421
1422 for filename in presubmit_files:
1423 filename = os.path.abspath(filename)
rmistry@google.com5626a922015-02-26 14:03:30 +00001424 # Accept CRLF presubmit script.
Bruce Dawson6e70e862022-07-01 19:37:01 +00001425 presubmit_script = gclient_utils.FileRead(filename).replace('\r\n', '\n')
Bruce Dawson8454fc22023-03-07 22:15:25 +00001426 if verbose:
1427 sys.stdout.write('Running %s\n' % filename)
1428 results.extend(executer.ExecPresubmitScript(presubmit_script, filename))
rmistry@google.com5626a922015-02-26 14:03:30 +00001429
Edward Lemur6eb1d322020-02-27 22:20:15 +00001430 if not results:
1431 return 0
1432
1433 sys.stdout.write('\n')
1434 sys.stdout.write('** Post Upload Hook Messages **\n')
1435
1436 exit_code = 0
1437 for result in results:
1438 if result.fatal:
1439 exit_code = 1
1440 result.handle()
1441 sys.stdout.write('\n')
1442
1443 return exit_code
rmistry@google.com5626a922015-02-26 14:03:30 +00001444
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001445class PresubmitExecuter(object):
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001446 def __init__(self, change, committing, verbose, gerrit_obj, dry_run=None,
Bruce Dawson09c0c072022-05-26 20:28:58 +00001447 thread_pool=None, parallel=False, use_python3=False,
1448 no_diffs=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001449 """
1450 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001451 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001452 committing: True if 'git cl land' is running, False if 'git cl upload' is.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001453 gerrit_obj: provides basic Gerrit codereview functionality.
1454 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001455 parallel: if true, all tests reported via input_api.RunTests for all
1456 PRESUBMIT files will be run in parallel.
Dirk Pranke6f0df682021-06-25 00:42:33 +00001457 use_python3: if true, will use python3 instead of python2 by default
1458 if USE_PYTHON3 is not specified.
Bruce Dawson09c0c072022-05-26 20:28:58 +00001459 no_diffs: if true, implies that --files or --all was specified so some
1460 checks can be skipped, and some errors will be messages.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001461 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001462 self.change = change
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001463 self.committing = committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001464 self.gerrit = gerrit_obj
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001465 self.verbose = verbose
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001466 self.dry_run = dry_run
Daniel Cheng7227d212017-11-17 08:12:37 -08001467 self.more_cc = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001468 self.thread_pool = thread_pool
1469 self.parallel = parallel
Dirk Pranke6f0df682021-06-25 00:42:33 +00001470 self.use_python3 = use_python3
Bruce Dawson09c0c072022-05-26 20:28:58 +00001471 self.no_diffs = no_diffs
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001472
1473 def ExecPresubmitScript(self, script_text, presubmit_path):
1474 """Executes a single presubmit script.
Josip Sokcevic632bbc02022-05-19 05:32:50 +00001475 Caller is responsible for validating whether the hook should be executed
1476 and should only call this function if it should be.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001477
1478 Args:
1479 script_text: The text of the presubmit script.
1480 presubmit_path: The path to the presubmit file (this will be reported via
1481 input_api.PresubmitLocalPath()).
1482
1483 Return:
1484 A list of result objects, empty if no problems.
1485 """
chase@chromium.org8e416c82009-10-06 04:30:44 +00001486 # Change to the presubmit file's directory to support local imports.
Saagar Sanghavi98b332f2020-07-31 17:19:15 +00001487 presubmit_dir = os.path.dirname(presubmit_path)
Pavol Marko624e7ee2023-01-09 09:56:29 +00001488 main_path = os.getcwd()
1489 try:
1490 os.chdir(presubmit_dir)
1491 return self._execute_with_local_working_directory(script_text,
1492 presubmit_dir,
1493 presubmit_path)
1494 finally:
1495 # Return the process to the original working directory.
1496 os.chdir(main_path)
chase@chromium.org8e416c82009-10-06 04:30:44 +00001497
Pavol Marko624e7ee2023-01-09 09:56:29 +00001498 def _execute_with_local_working_directory(self, script_text, presubmit_dir,
1499 presubmit_path):
chase@chromium.org8e416c82009-10-06 04:30:44 +00001500 # Load the presubmit script into context.
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001501 input_api = InputApi(self.change, presubmit_path, self.committing,
Aaron Gable668c1d82018-04-03 10:19:16 -07001502 self.verbose, gerrit_obj=self.gerrit,
Edward Lesmes8e282792018-04-03 18:50:29 -04001503 dry_run=self.dry_run, thread_pool=self.thread_pool,
Bruce Dawson09c0c072022-05-26 20:28:58 +00001504 parallel=self.parallel, no_diffs=self.no_diffs)
Daniel Cheng7227d212017-11-17 08:12:37 -08001505 output_api = OutputApi(self.committing)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001506 context = {}
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001507
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001508 try:
Bruce Dawson0ba2fd42022-07-21 13:47:21 +00001509 exec(compile(script_text, presubmit_path, 'exec', dont_inherit=True),
Raul Tambre09e64b42019-05-14 01:57:22 +00001510 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001511 except Exception as e:
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001512 raise PresubmitFailure('"%s" had an exception.\n%s' % (presubmit_path, e))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001513
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001514 context['__args'] = (input_api, output_api)
Ben Pastene8351dc12020-08-06 05:01:35 +00001515
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001516 # Get path of presubmit directory relative to repository root.
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001517 # Always use forward slashes, so that path is same in *nix and Windows
1518 root = input_api.change.RepositoryRoot()
1519 rel_path = os.path.relpath(presubmit_dir, root)
1520 rel_path = rel_path.replace(os.path.sep, '/')
Ben Pastene8351dc12020-08-06 05:01:35 +00001521
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001522 # Get the URL of git remote origin and use it to identify host and project
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001523 host = project = ''
1524 if self.gerrit:
1525 host = self.gerrit.host or ''
1526 project = self.gerrit.project or ''
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001527
1528 # Prefix for test names
1529 prefix = 'presubmit:%s/%s:%s/' % (host, project, rel_path)
1530
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001531 # Perform all the desired presubmit checks.
1532 results = []
Ben Pastene8351dc12020-08-06 05:01:35 +00001533
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001534 try:
Scott Leecc2fe9b2020-11-19 19:38:06 +00001535 version = [
1536 int(x) for x in context.get('PRESUBMIT_VERSION', '0.0.0').split('.')
1537 ]
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001538
Scott Leecc2fe9b2020-11-19 19:38:06 +00001539 with rdb_wrapper.client(prefix) as sink:
1540 if version >= [2, 0, 0]:
Andrew Grievebdfb8f22022-02-02 21:56:47 +00001541 # Copy the keys to prevent "dictionary changed size during iteration"
1542 # exception if checks add globals to context. E.g. sometimes the
1543 # Python runtime will add __warningregistry__.
1544 for function_name in list(context.keys()):
Scott Leecc2fe9b2020-11-19 19:38:06 +00001545 if not function_name.startswith('Check'):
1546 continue
1547 if function_name.endswith('Commit') and not self.committing:
1548 continue
1549 if function_name.endswith('Upload') and self.committing:
1550 continue
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001551 logging.debug('Running %s in %s', function_name, presubmit_path)
1552 results.extend(
Bruce Dawson8fa42e22022-03-29 17:05:38 +00001553 self._run_check_function(function_name, context, sink,
1554 presubmit_path))
Scott Leecc2fe9b2020-11-19 19:38:06 +00001555 logging.debug('Running %s done.', function_name)
1556 self.more_cc.extend(output_api.more_cc)
1557
1558 else: # Old format
1559 if self.committing:
1560 function_name = 'CheckChangeOnCommit'
1561 else:
1562 function_name = 'CheckChangeOnUpload'
Andrew Grievebdfb8f22022-02-02 21:56:47 +00001563 if function_name in list(context.keys()):
Scott Leecc2fe9b2020-11-19 19:38:06 +00001564 logging.debug('Running %s in %s', function_name, presubmit_path)
1565 results.extend(
Bruce Dawson8fa42e22022-03-29 17:05:38 +00001566 self._run_check_function(function_name, context, sink,
1567 presubmit_path))
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001568 logging.debug('Running %s done.', function_name)
1569 self.more_cc.extend(output_api.more_cc)
1570
1571 finally:
1572 for f in input_api._named_temporary_files:
1573 os.remove(f)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001574
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001575 return results
1576
Bruce Dawson8fa42e22022-03-29 17:05:38 +00001577 def _run_check_function(self, function_name, context, sink, presubmit_path):
Scott Leecc2fe9b2020-11-19 19:38:06 +00001578 """Evaluates and returns the result of a given presubmit function.
1579
1580 If sink is given, the result of the presubmit function will be reported
1581 to the ResultSink.
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001582
1583 Args:
Scott Leecc2fe9b2020-11-19 19:38:06 +00001584 function_name: the name of the presubmit function to evaluate
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001585 context: a context dictionary in which the function will be evaluated
Scott Leecc2fe9b2020-11-19 19:38:06 +00001586 sink: an instance of ResultSink. None, by default.
1587 Returns:
1588 the result of the presubmit function call.
1589 """
1590 start_time = time_time()
1591 try:
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001592 result = eval(function_name + '(*__args)', context)
1593 self._check_result_type(result)
Allen Webbfe7d7092021-05-18 02:05:49 +00001594 except Exception:
Bruce Dawson10a82862022-05-27 19:25:56 +00001595 _, e_value, _ = sys.exc_info()
1596 result = [
1597 OutputApi.PresubmitError(
1598 'Evaluation of %s failed: %s, %s' %
1599 (function_name, e_value, traceback.format_exc()))
1600 ]
Scott Leecc2fe9b2020-11-19 19:38:06 +00001601
Bruce Dawson2bdc49f2021-05-21 19:13:03 +00001602 elapsed_time = time_time() - start_time
1603 if elapsed_time > 10.0:
Bruce Dawson6757d462022-07-13 04:04:40 +00001604 sys.stdout.write('%6.1fs to run %s from %s.\n' %
1605 (elapsed_time, function_name, presubmit_path))
Scott Leecc2fe9b2020-11-19 19:38:06 +00001606 if sink:
Erik Staab9f38b632022-10-31 14:05:24 +00001607 failure_reason = None
Scott Leecc2fe9b2020-11-19 19:38:06 +00001608 status = rdb_wrapper.STATUS_PASS
1609 if any(r.fatal for r in result):
1610 status = rdb_wrapper.STATUS_FAIL
Erik Staab9f38b632022-10-31 14:05:24 +00001611 failure_reasons = []
1612 for r in result:
1613 fields = r.json_format()
1614 message = fields['message']
1615 items = '\n'.join(' %s' % item for item in fields['items'])
1616 failure_reasons.append('\n'.join([message, items]))
1617 if failure_reasons:
1618 failure_reason = '\n'.join(failure_reasons)
1619 sink.report(function_name, status, elapsed_time, failure_reason)
Scott Leecc2fe9b2020-11-19 19:38:06 +00001620
1621 return result
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001622
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001623 def _check_result_type(self, result):
1624 """Helper function which ensures result is a list, and all elements are
1625 instances of OutputApi.PresubmitResult"""
1626 if not isinstance(result, (tuple, list)):
1627 raise PresubmitFailure('Presubmit functions must return a tuple or list')
1628 if not all(isinstance(res, OutputApi.PresubmitResult) for res in result):
1629 raise PresubmitFailure(
1630 'All presubmit results must be of types derived from '
1631 'output_api.PresubmitResult')
1632
1633
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001634def DoPresubmitChecks(change,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001635 committing,
1636 verbose,
maruel@chromium.orgb0dfd352009-06-10 14:12:54 +00001637 default_presubmit,
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001638 may_prompt,
Aaron Gable668c1d82018-04-03 10:19:16 -07001639 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04001640 dry_run=None,
Debrian Figueroadd2737e2019-06-21 23:50:13 +00001641 parallel=False,
Dirk Pranke6f0df682021-06-25 00:42:33 +00001642 json_output=None,
Bruce Dawson09c0c072022-05-26 20:28:58 +00001643 use_python3=False,
1644 no_diffs=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001645 """Runs all presubmit checks that apply to the files in the change.
1646
1647 This finds all PRESUBMIT.py files in directories enclosing the files in the
1648 change (up to the repository root) and calls the relevant entrypoint function
1649 depending on whether the change is being committed or uploaded.
1650
1651 Prints errors, warnings and notifications. Prompts the user for warnings
1652 when needed.
1653
1654 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001655 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001656 committing: True if 'git cl land' is running, False if 'git cl upload' is.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001657 verbose: Prints debug info.
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001658 default_presubmit: A default presubmit script to execute in any case.
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001659 may_prompt: Enable (y/n) questions on warning or error. If False,
1660 any questions are answered with yes by default.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001661 gerrit_obj: provides basic Gerrit codereview functionality.
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001662 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001663 parallel: if true, all tests specified by input_api.RunTests in all
1664 PRESUBMIT files will be run in parallel.
Dirk Pranke6f0df682021-06-25 00:42:33 +00001665 use_python3: if true, default to using Python3 for presubmit checks
1666 rather than Python2.
Bruce Dawson09c0c072022-05-26 20:28:58 +00001667 no_diffs: if true, implies that --files or --all was specified so some
1668 checks can be skipped, and some errors will be messages.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001669 Return:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001670 1 if presubmit checks failed or 0 otherwise.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001671 """
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001672 old_environ = os.environ
1673 try:
1674 # Make sure python subprocesses won't generate .pyc files.
1675 os.environ = os.environ.copy()
Edward Lemurb9830242019-10-30 22:19:20 +00001676 os.environ['PYTHONDONTWRITEBYTECODE'] = '1'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001677
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001678 python_version = 'Python %s' % sys.version_info.major
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001679 if committing:
Dirk Pranke6fc394f2021-05-26 23:25:14 +00001680 sys.stdout.write('Running %s presubmit commit checks ...\n' %
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001681 python_version)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001682 else:
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001683 sys.stdout.write('Running %s presubmit upload checks ...\n' %
1684 python_version)
Edward Lemurecc27072020-01-06 16:42:34 +00001685 start_time = time_time()
Josip Sokcevic512fd3b2023-03-01 21:06:41 +00001686 presubmit_files = utils.ListRelevantFilesInSourceCheckout(
1687 change.AbsoluteLocalPaths(), change.RepositoryRoot(),
1688 _PRESUBMIT_FILE_REGEX, _PRESUBMIT_FILE_EXCLUDE)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001689 if not presubmit_files and verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001690 sys.stdout.write('Warning, no PRESUBMIT.py found.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001691 results = []
Bruce Dawsonc9f904f2022-10-14 20:59:49 +00001692 if sys.platform == 'win32':
1693 temp = os.environ['TEMP']
1694 else:
1695 temp = '/tmp'
1696 python2_usage_log_file = os.path.join(temp, 'python2_usage.txt')
Bruce Dawsonf2b04212022-06-10 16:42:54 +00001697 if os.path.exists(python2_usage_log_file):
1698 os.remove(python2_usage_log_file)
Edward Lesmes8e282792018-04-03 18:50:29 -04001699 thread_pool = ThreadPool()
Edward Lemur7e3c67f2018-07-20 20:52:49 +00001700 executer = PresubmitExecuter(change, committing, verbose, gerrit_obj,
Bruce Dawson09c0c072022-05-26 20:28:58 +00001701 dry_run, thread_pool, parallel, use_python3,
1702 no_diffs)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001703 if default_presubmit:
1704 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001705 sys.stdout.write('Running default presubmit script.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001706 fake_path = os.path.join(change.RepositoryRoot(), 'PRESUBMIT.py')
Bruce Dawson8454fc22023-03-07 22:15:25 +00001707 results += executer.ExecPresubmitScript(default_presubmit, fake_path)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001708 for filename in presubmit_files:
1709 filename = os.path.abspath(filename)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001710 # Accept CRLF presubmit script.
Bruce Dawson6e70e862022-07-01 19:37:01 +00001711 presubmit_script = gclient_utils.FileRead(filename).replace('\r\n', '\n')
Bruce Dawson8454fc22023-03-07 22:15:25 +00001712 if verbose:
1713 sys.stdout.write('Running %s\n' % filename)
1714 results += executer.ExecPresubmitScript(presubmit_script, filename)
Bruce Dawson76fe1a72022-05-25 20:52:21 +00001715
Edward Lesmes8e282792018-04-03 18:50:29 -04001716 results += thread_pool.RunAsync()
1717
Bruce Dawsonf2b04212022-06-10 16:42:54 +00001718 if os.path.exists(python2_usage_log_file):
1719 with open(python2_usage_log_file) as f:
1720 python2_usage = [x.strip() for x in f.readlines()]
1721 results.append(
1722 OutputApi(committing).PresubmitPromptWarning(
1723 'Python 2 scripts were run during %s presubmits. Please see '
1724 'https://bugs.chromium.org/p/chromium/issues/detail?id=1313804'
1725 '#c61 for tips on resolving this.'
1726 % python_version,
1727 items=python2_usage))
1728
Edward Lemur6eb1d322020-02-27 22:20:15 +00001729 messages = {}
1730 should_prompt = False
1731 presubmits_failed = False
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001732 for result in results:
1733 if result.fatal:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001734 presubmits_failed = True
1735 messages.setdefault('ERRORS', []).append(result)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001736 elif result.should_prompt:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001737 should_prompt = True
1738 messages.setdefault('Warnings', []).append(result)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001739 else:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001740 messages.setdefault('Messages', []).append(result)
pam@chromium.orged9a0832009-09-09 22:48:55 +00001741
Bruce Dawson76fe1a72022-05-25 20:52:21 +00001742 # Print the different message types in a consistent order. ERRORS go last
1743 # so that they will be most visible in the local-presubmit output.
1744 for name in ['Messages', 'Warnings', 'ERRORS']:
1745 if name in messages:
1746 items = messages[name]
Gavin Makd22bf602022-07-11 21:10:41 +00001747 sys.stdout.write('** Presubmit %s: %d **\n' % (name, len(items)))
Bruce Dawson76fe1a72022-05-25 20:52:21 +00001748 for item in items:
1749 item.handle()
1750 sys.stdout.write('\n')
pam@chromium.orged9a0832009-09-09 22:48:55 +00001751
Edward Lemurecc27072020-01-06 16:42:34 +00001752 total_time = time_time() - start_time
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001753 if total_time > 1.0:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001754 sys.stdout.write(
Louis Romero4ca9e1c2022-03-10 10:29:11 +00001755 'Presubmit checks took %.1fs to calculate.\n' % total_time)
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001756
Edward Lemur6eb1d322020-02-27 22:20:15 +00001757 if not should_prompt and not presubmits_failed:
Louis Romero4ca9e1c2022-03-10 10:29:11 +00001758 sys.stdout.write('%s presubmit checks passed.\n\n' % python_version)
Josip Sokcevic7592e0a2022-01-12 00:57:54 +00001759 elif should_prompt and not presubmits_failed:
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001760 sys.stdout.write('There were %s presubmit warnings. ' % python_version)
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001761 if may_prompt:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001762 presubmits_failed = not prompt_should_continue(
1763 'Are you sure you wish to continue? (y/N): ')
Garrett Beatyacb807e2020-08-28 18:17:24 +00001764 else:
1765 sys.stdout.write('\n')
Bruce Dawson76fe1a72022-05-25 20:52:21 +00001766 else:
1767 sys.stdout.write('There were %s presubmit errors.\n' % python_version)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001768
Edward Lemur1dc66e12020-02-21 21:36:34 +00001769 if json_output:
1770 # Write the presubmit results to json output
1771 presubmit_results = {
1772 'errors': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001773 error.json_format()
1774 for error in messages.get('ERRORS', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001775 ],
1776 'notifications': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001777 notification.json_format()
1778 for notification in messages.get('Messages', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001779 ],
1780 'warnings': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001781 warning.json_format()
1782 for warning in messages.get('Warnings', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001783 ],
Edward Lemur6eb1d322020-02-27 22:20:15 +00001784 'more_cc': executer.more_cc,
Edward Lemur1dc66e12020-02-21 21:36:34 +00001785 }
1786
1787 gclient_utils.FileWrite(
1788 json_output, json.dumps(presubmit_results, sort_keys=True))
1789
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001790 global _ASKED_FOR_FEEDBACK
1791 # Ask for feedback one time out of 5.
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00001792 if (results and random.randint(0, 4) == 0 and not _ASKED_FOR_FEEDBACK):
Edward Lemur6eb1d322020-02-27 22:20:15 +00001793 sys.stdout.write(
maruel@chromium.org1ce8e662014-01-14 15:23:00 +00001794 'Was the presubmit check useful? If not, run "git cl presubmit -v"\n'
1795 'to figure out which PRESUBMIT.py was run, then run git blame\n'
1796 'on the file to figure out who to ask for help.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001797 _ASKED_FOR_FEEDBACK = True
Edward Lemur6eb1d322020-02-27 22:20:15 +00001798
1799 return 1 if presubmits_failed else 0
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001800 finally:
1801 os.environ = old_environ
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001802
1803
Edward Lemur50984a62020-02-06 18:10:18 +00001804def _scan_sub_dirs(mask, recursive):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001805 if not recursive:
pgervais@chromium.orge57b09d2014-05-07 00:58:13 +00001806 return [x for x in glob.glob(mask) if x not in ('.svn', '.git')]
Lei Zhang9611c4c2017-04-04 01:41:56 -07001807
1808 results = []
1809 for root, dirs, files in os.walk('.'):
1810 if '.svn' in dirs:
1811 dirs.remove('.svn')
1812 if '.git' in dirs:
1813 dirs.remove('.git')
1814 for name in files:
1815 if fnmatch.fnmatch(name, mask):
1816 results.append(os.path.join(root, name))
1817 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001818
1819
Edward Lemur50984a62020-02-06 18:10:18 +00001820def _parse_files(args, recursive):
tobiasjs2836bcf2016-08-16 04:08:16 -07001821 logging.debug('Searching for %s', args)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001822 files = []
1823 for arg in args:
Edward Lemur50984a62020-02-06 18:10:18 +00001824 files.extend([('M', f) for f in _scan_sub_dirs(arg, recursive)])
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001825 return files
1826
1827
Edward Lemur50984a62020-02-06 18:10:18 +00001828def _parse_change(parser, options):
1829 """Process change options.
1830
1831 Args:
1832 parser: The parser used to parse the arguments from command line.
1833 options: The arguments parsed from command line.
1834 Returns:
Josip Sokcevic7958e302023-03-01 23:02:21 +00001835 A GitChange if the change root is a git repository, or a Change otherwise.
Edward Lemur50984a62020-02-06 18:10:18 +00001836 """
1837 if options.files and options.all_files:
1838 parser.error('<files> cannot be specified when --all-files is set.')
1839
Edward Lesmes44ea3ff2020-02-05 00:14:30 +00001840 change_scm = scm.determine_scm(options.root)
Edward Lemur50984a62020-02-06 18:10:18 +00001841 if change_scm != 'git' and not options.files:
1842 parser.error('<files> is not optional for unversioned directories.')
1843
1844 if options.files:
Josip Sokcevic017544d2022-03-31 23:47:53 +00001845 if options.source_controlled_only:
1846 # Get the filtered set of files from SCM.
1847 change_files = []
1848 for name in scm.GIT.GetAllFiles(options.root):
1849 for mask in options.files:
1850 if fnmatch.fnmatch(name, mask):
1851 change_files.append(('M', name))
1852 break
1853 else:
1854 # Get the filtered set of files from a directory scan.
1855 change_files = _parse_files(options.files, options.recursive)
Edward Lemur50984a62020-02-06 18:10:18 +00001856 elif options.all_files:
1857 change_files = [('M', f) for f in scm.GIT.GetAllFiles(options.root)]
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001858 else:
Edward Lemur50984a62020-02-06 18:10:18 +00001859 change_files = scm.GIT.CaptureStatus(
Edward Lemur7f6dec02020-02-06 20:23:58 +00001860 options.root, options.upstream or None)
Edward Lemur50984a62020-02-06 18:10:18 +00001861
1862 logging.info('Found %d file(s).', len(change_files))
1863
Josip Sokcevic7958e302023-03-01 23:02:21 +00001864 change_class = GitChange if change_scm == 'git' else Change
Edward Lemur50984a62020-02-06 18:10:18 +00001865 return change_class(
1866 options.name,
1867 options.description,
1868 options.root,
1869 change_files,
1870 options.issue,
1871 options.patchset,
1872 options.author,
1873 upstream=options.upstream)
1874
1875
1876def _parse_gerrit_options(parser, options):
1877 """Process gerrit options.
1878
1879 SIDE EFFECTS: Modifies options.author and options.description from Gerrit if
1880 options.gerrit_fetch is set.
1881
1882 Args:
1883 parser: The parser used to parse the arguments from command line.
1884 options: The arguments parsed from command line.
1885 Returns:
Stephen Martinisfb09de22021-02-25 03:41:13 +00001886 A GerritAccessor object if options.gerrit_url is set, or None otherwise.
Edward Lemur50984a62020-02-06 18:10:18 +00001887 """
1888 gerrit_obj = None
Stephen Martinisfb09de22021-02-25 03:41:13 +00001889 if options.gerrit_url:
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001890 gerrit_obj = GerritAccessor(
1891 url=options.gerrit_url,
1892 project=options.gerrit_project,
1893 branch=options.gerrit_branch)
Edward Lemur50984a62020-02-06 18:10:18 +00001894
1895 if not options.gerrit_fetch:
1896 return gerrit_obj
1897
1898 if not options.gerrit_url or not options.issue or not options.patchset:
1899 parser.error(
1900 '--gerrit_fetch requires --gerrit_url, --issue and --patchset.')
1901
1902 options.author = gerrit_obj.GetChangeOwner(options.issue)
1903 options.description = gerrit_obj.GetChangeDescription(
1904 options.issue, options.patchset)
1905
1906 logging.info('Got author: "%s"', options.author)
1907 logging.info('Got description: """\n%s\n"""', options.description)
1908
1909 return gerrit_obj
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001910
1911
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001912@contextlib.contextmanager
1913def canned_check_filter(method_names):
1914 filtered = {}
1915 try:
1916 for method_name in method_names:
1917 if not hasattr(presubmit_canned_checks, method_name):
Gavin Make6a62332020-12-04 21:57:10 +00001918 logging.warning('Skipping unknown "canned" check %s' % method_name)
Aaron Gableecee74c2018-04-02 15:13:08 -07001919 continue
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001920 filtered[method_name] = getattr(presubmit_canned_checks, method_name)
1921 setattr(presubmit_canned_checks, method_name, lambda *_a, **_kw: [])
1922 yield
1923 finally:
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001924 for name, method in filtered.items():
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001925 setattr(presubmit_canned_checks, name, method)
1926
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001927
sbc@chromium.org013731e2015-02-26 18:28:43 +00001928def main(argv=None):
Edward Lemura5799e32020-01-17 19:26:51 +00001929 parser = argparse.ArgumentParser(usage='%(prog)s [options] <files...>')
1930 hooks = parser.add_mutually_exclusive_group()
1931 hooks.add_argument('-c', '--commit', action='store_true',
1932 help='Use commit instead of upload checks.')
1933 hooks.add_argument('-u', '--upload', action='store_false', dest='commit',
1934 help='Use upload instead of commit checks.')
Edward Lemur75526302020-02-27 22:31:05 +00001935 hooks.add_argument('--post_upload', action='store_true',
1936 help='Run post-upload commit hooks.')
Edward Lemura5799e32020-01-17 19:26:51 +00001937 parser.add_argument('-r', '--recursive', action='store_true',
1938 help='Act recursively.')
1939 parser.add_argument('-v', '--verbose', action='count', default=0,
1940 help='Use 2 times for more debug info.')
1941 parser.add_argument('--name', default='no name')
1942 parser.add_argument('--author')
Edward Lemur227d5102020-02-25 23:45:35 +00001943 desc = parser.add_mutually_exclusive_group()
1944 desc.add_argument('--description', default='', help='The change description.')
1945 desc.add_argument('--description_file',
1946 help='File to read change description from.')
Edward Lemura5799e32020-01-17 19:26:51 +00001947 parser.add_argument('--issue', type=int, default=0)
1948 parser.add_argument('--patchset', type=int, default=0)
1949 parser.add_argument('--root', default=os.getcwd(),
1950 help='Search for PRESUBMIT.py up to this directory. '
1951 'If inherit-review-settings-ok is present in this '
1952 'directory, parent directories up to the root file '
1953 'system directories will also be searched.')
1954 parser.add_argument('--upstream',
1955 help='Git only: the base ref or upstream branch against '
1956 'which the diff should be computed.')
1957 parser.add_argument('--default_presubmit')
1958 parser.add_argument('--may_prompt', action='store_true', default=False)
1959 parser.add_argument('--skip_canned', action='append', default=[],
1960 help='A list of checks to skip which appear in '
1961 'presubmit_canned_checks. Can be provided multiple times '
1962 'to skip multiple canned checks.')
1963 parser.add_argument('--dry_run', action='store_true', help=argparse.SUPPRESS)
1964 parser.add_argument('--gerrit_url', help=argparse.SUPPRESS)
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001965 parser.add_argument('--gerrit_project', help=argparse.SUPPRESS)
1966 parser.add_argument('--gerrit_branch', help=argparse.SUPPRESS)
Edward Lemura5799e32020-01-17 19:26:51 +00001967 parser.add_argument('--gerrit_fetch', action='store_true',
1968 help=argparse.SUPPRESS)
1969 parser.add_argument('--parallel', action='store_true',
1970 help='Run all tests specified by input_api.RunTests in '
1971 'all PRESUBMIT files in parallel.')
1972 parser.add_argument('--json_output',
1973 help='Write presubmit errors to json output.')
Edward Lemur1dc66e12020-02-21 21:36:34 +00001974 parser.add_argument('--all_files', action='store_true',
Edward Lemur50984a62020-02-06 18:10:18 +00001975 help='Mark all files under source control as modified.')
Bruce Dawson09c0c072022-05-26 20:28:58 +00001976
Edward Lemura5799e32020-01-17 19:26:51 +00001977 parser.add_argument('files', nargs='*',
1978 help='List of files to be marked as modified when '
1979 'executing presubmit or post-upload hooks. fnmatch '
1980 'wildcards can also be used.')
Josip Sokcevic017544d2022-03-31 23:47:53 +00001981 parser.add_argument('--source_controlled_only', action='store_true',
1982 help='Constrain \'files\' to those in source control.')
Dirk Pranke6f0df682021-06-25 00:42:33 +00001983 parser.add_argument('--use-python3', action='store_true',
1984 help='Use python3 for presubmit checks by default')
Bruce Dawson09c0c072022-05-26 20:28:58 +00001985 parser.add_argument('--no_diffs', action='store_true',
1986 help='Assume that all "modified" files have no diffs.')
Edward Lemura5799e32020-01-17 19:26:51 +00001987 options = parser.parse_args(argv)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001988
Erik Staabcca5c492020-04-16 17:40:07 +00001989 log_level = logging.ERROR
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001990 if options.verbose >= 2:
Erik Staabcca5c492020-04-16 17:40:07 +00001991 log_level = logging.DEBUG
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001992 elif options.verbose:
Erik Staabcca5c492020-04-16 17:40:07 +00001993 log_level = logging.INFO
1994 log_format = ('[%(levelname).1s%(asctime)s %(process)d %(thread)d '
1995 '%(filename)s] %(message)s')
1996 logging.basicConfig(format=log_format, level=log_level)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001997
Bruce Dawsondca14bc2022-09-15 20:59:38 +00001998 # Print call stacks when _PresubmitResult objects are created with -v -v is
1999 # specified. This helps track down where presubmit messages are coming from.
2000 if options.verbose >= 2:
2001 global _SHOW_CALLSTACKS
2002 _SHOW_CALLSTACKS = True
2003
Edward Lemur227d5102020-02-25 23:45:35 +00002004 if options.description_file:
2005 options.description = gclient_utils.FileRead(options.description_file)
Edward Lemur50984a62020-02-06 18:10:18 +00002006 gerrit_obj = _parse_gerrit_options(parser, options)
2007 change = _parse_change(parser, options)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00002008
maruel@chromium.org899e1c12011-04-07 17:03:18 +00002009 try:
Edward Lemur75526302020-02-27 22:31:05 +00002010 if options.post_upload:
Josip Sokcevice293d3d2022-02-16 22:52:15 +00002011 return DoPostUploadExecuter(change, gerrit_obj, options.verbose,
2012 options.use_python3)
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00002013 with canned_check_filter(options.skip_canned):
Edward Lemur6eb1d322020-02-27 22:20:15 +00002014 return DoPresubmitChecks(
Edward Lemur50984a62020-02-06 18:10:18 +00002015 change,
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00002016 options.commit,
2017 options.verbose,
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00002018 options.default_presubmit,
2019 options.may_prompt,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00002020 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04002021 options.dry_run,
Debrian Figueroadd2737e2019-06-21 23:50:13 +00002022 options.parallel,
Dirk Pranke6f0df682021-06-25 00:42:33 +00002023 options.json_output,
Bruce Dawson09c0c072022-05-26 20:28:58 +00002024 options.use_python3,
2025 options.no_diffs)
Raul Tambre7c938462019-05-24 16:35:35 +00002026 except PresubmitFailure as e:
Raul Tambre80ee78e2019-05-06 22:41:05 +00002027 print(e, file=sys.stderr)
2028 print('Maybe your depot_tools is out of date?', file=sys.stderr)
Josip Sokcevic0399e172022-03-21 23:11:51 +00002029 print('depot_tools version: %s' % utils.depot_tools_version(),
2030 file=sys.stderr)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00002031 return 2
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00002032
2033
2034if __name__ == '__main__':
maruel@chromium.org35625c72011-03-23 17:34:02 +00002035 fix_encoding.fix_encoding()
sbc@chromium.org013731e2015-02-26 18:28:43 +00002036 try:
2037 sys.exit(main())
2038 except KeyboardInterrupt:
2039 sys.stderr.write('interrupted\n')
sergiybf8a3b382016-07-05 11:21:30 -07002040 sys.exit(2)