maruel@chromium.org | 725f1c3 | 2011-04-01 20:24:54 +0000 | [diff] [blame] | 1 | #!/usr/bin/env python |
maruel@chromium.org | 3bbf294 | 2012-01-10 16:52:06 +0000 | [diff] [blame] | 2 | # Copyright (c) 2012 The Chromium Authors. All rights reserved. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 3 | # Use of this source code is governed by a BSD-style license that can be |
| 4 | # found in the LICENSE file. |
| 5 | |
| 6 | """Enables directory-specific presubmit checks to run at upload and/or commit. |
| 7 | """ |
| 8 | |
enne@chromium.org | e72c5f5 | 2013-04-16 00:36:40 +0000 | [diff] [blame] | 9 | __version__ = '1.6.2' |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 10 | |
| 11 | # TODO(joi) Add caching where appropriate/needed. The API is designed to allow |
| 12 | # caching (between all different invocations of presubmit scripts for a given |
| 13 | # change). We should add it as our presubmit scripts start feeling slow. |
| 14 | |
enne@chromium.org | e72c5f5 | 2013-04-16 00:36:40 +0000 | [diff] [blame] | 15 | import cpplint |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 16 | import cPickle # Exposed through the API. |
| 17 | import cStringIO # Exposed through the API. |
iannucci@chromium.org | 8a4a2bc | 2013-03-08 08:13:20 +0000 | [diff] [blame] | 18 | import contextlib |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 19 | import fnmatch |
| 20 | import glob |
asvitkine@chromium.org | 1516995 | 2011-09-27 14:30:53 +0000 | [diff] [blame] | 21 | import inspect |
maruel@chromium.org | 4f6852c | 2012-04-20 20:39:20 +0000 | [diff] [blame] | 22 | import json # Exposed through the API. |
maruel@chromium.org | df1595a | 2009-06-11 02:00:13 +0000 | [diff] [blame] | 23 | import logging |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 24 | import marshal # Exposed through the API. |
| 25 | import optparse |
| 26 | import os # Somewhat exposed through the API. |
| 27 | import pickle # Exposed through the API. |
maruel@chromium.org | ce8e46b | 2009-06-26 22:31:51 +0000 | [diff] [blame] | 28 | import random |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 29 | import re # Exposed through the API. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 30 | import sys # Parts exposed through API. |
| 31 | import tempfile # Exposed through the API. |
jam@chromium.org | 2a891dc | 2009-08-20 20:33:37 +0000 | [diff] [blame] | 32 | import time |
maruel@chromium.org | d7dccf5 | 2009-06-06 18:51:58 +0000 | [diff] [blame] | 33 | import traceback # Exposed through the API. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 34 | import types |
maruel@chromium.org | 1487d53 | 2009-06-06 00:22:57 +0000 | [diff] [blame] | 35 | import unittest # Exposed through the API. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 36 | import urllib2 # Exposed through the API. |
maruel@chromium.org | cb2985f | 2010-11-03 14:08:31 +0000 | [diff] [blame] | 37 | from warnings import warn |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 38 | |
| 39 | # Local imports. |
maruel@chromium.org | 35625c7 | 2011-03-23 17:34:02 +0000 | [diff] [blame] | 40 | import fix_encoding |
maruel@chromium.org | 5aeb7dd | 2009-11-17 18:09:01 +0000 | [diff] [blame] | 41 | import gclient_utils |
dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 42 | import owners |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 43 | import presubmit_canned_checks |
maruel@chromium.org | 239f411 | 2011-06-03 20:08:23 +0000 | [diff] [blame] | 44 | import rietveld |
maruel@chromium.org | 5aeb7dd | 2009-11-17 18:09:01 +0000 | [diff] [blame] | 45 | import scm |
maruel@chromium.org | 84f4fe3 | 2011-04-06 13:26:45 +0000 | [diff] [blame] | 46 | import subprocess2 as subprocess # Exposed through the API. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 47 | |
| 48 | |
maruel@chromium.org | ce8e46b | 2009-06-26 22:31:51 +0000 | [diff] [blame] | 49 | # Ask for feedback only once in program lifetime. |
| 50 | _ASKED_FOR_FEEDBACK = False |
| 51 | |
| 52 | |
maruel@chromium.org | 899e1c1 | 2011-04-07 17:03:18 +0000 | [diff] [blame] | 53 | class PresubmitFailure(Exception): |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 54 | pass |
| 55 | |
| 56 | |
| 57 | def normpath(path): |
| 58 | '''Version of os.path.normpath that also changes backward slashes to |
| 59 | forward slashes when not running on Windows. |
| 60 | ''' |
| 61 | # This is safe to always do because the Windows version of os.path.normpath |
| 62 | # will replace forward slashes with backward slashes. |
| 63 | path = path.replace(os.sep, '/') |
| 64 | return os.path.normpath(path) |
| 65 | |
maruel@chromium.org | cb2985f | 2010-11-03 14:08:31 +0000 | [diff] [blame] | 66 | |
maruel@chromium.org | cb2985f | 2010-11-03 14:08:31 +0000 | [diff] [blame] | 67 | def _RightHandSideLinesImpl(affected_files): |
| 68 | """Implements RightHandSideLines for InputApi and GclChange.""" |
| 69 | for af in affected_files: |
maruel@chromium.org | ab05d58 | 2011-02-09 23:41:22 +0000 | [diff] [blame] | 70 | lines = af.ChangedContents() |
maruel@chromium.org | cb2985f | 2010-11-03 14:08:31 +0000 | [diff] [blame] | 71 | for line in lines: |
maruel@chromium.org | ab05d58 | 2011-02-09 23:41:22 +0000 | [diff] [blame] | 72 | yield (af, line[0], line[1]) |
maruel@chromium.org | cb2985f | 2010-11-03 14:08:31 +0000 | [diff] [blame] | 73 | |
| 74 | |
dpranke@chromium.org | 5ac2101 | 2011-03-16 02:58:25 +0000 | [diff] [blame] | 75 | class PresubmitOutput(object): |
| 76 | def __init__(self, input_stream=None, output_stream=None): |
| 77 | self.input_stream = input_stream |
| 78 | self.output_stream = output_stream |
| 79 | self.reviewers = [] |
| 80 | self.written_output = [] |
| 81 | self.error_count = 0 |
| 82 | |
| 83 | def prompt_yes_no(self, prompt_string): |
| 84 | self.write(prompt_string) |
| 85 | if self.input_stream: |
| 86 | response = self.input_stream.readline().strip().lower() |
| 87 | if response not in ('y', 'yes'): |
| 88 | self.fail() |
| 89 | else: |
| 90 | self.fail() |
| 91 | |
| 92 | def fail(self): |
| 93 | self.error_count += 1 |
| 94 | |
| 95 | def should_continue(self): |
| 96 | return not self.error_count |
| 97 | |
| 98 | def write(self, s): |
| 99 | self.written_output.append(s) |
| 100 | if self.output_stream: |
| 101 | self.output_stream.write(s) |
| 102 | |
| 103 | def getvalue(self): |
| 104 | return ''.join(self.written_output) |
| 105 | |
| 106 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 107 | class OutputApi(object): |
wez@chromium.org | a6d011e | 2013-03-26 17:31:49 +0000 | [diff] [blame] | 108 | """An instance of OutputApi gets passed to presubmit scripts so that they |
| 109 | can output various types of results. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 110 | """ |
wez@chromium.org | a6d011e | 2013-03-26 17:31:49 +0000 | [diff] [blame] | 111 | def __init__(self, is_committing): |
| 112 | self.is_committing = is_committing |
| 113 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 114 | class PresubmitResult(object): |
| 115 | """Base class for result objects.""" |
dpranke@chromium.org | 5ac2101 | 2011-03-16 02:58:25 +0000 | [diff] [blame] | 116 | fatal = False |
| 117 | should_prompt = False |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 118 | |
| 119 | def __init__(self, message, items=None, long_text=''): |
| 120 | """ |
| 121 | message: A short one-line message to indicate errors. |
| 122 | items: A list of short strings to indicate where errors occurred. |
| 123 | long_text: multi-line text output, e.g. from another tool |
| 124 | """ |
| 125 | self._message = message |
| 126 | self._items = [] |
| 127 | if items: |
| 128 | self._items = items |
| 129 | self._long_text = long_text.rstrip() |
| 130 | |
dpranke@chromium.org | 5ac2101 | 2011-03-16 02:58:25 +0000 | [diff] [blame] | 131 | def handle(self, output): |
| 132 | output.write(self._message) |
| 133 | output.write('\n') |
maruel@chromium.org | 35625c7 | 2011-03-23 17:34:02 +0000 | [diff] [blame] | 134 | for index, item in enumerate(self._items): |
| 135 | output.write(' ') |
| 136 | # Write separately in case it's unicode. |
maruel@chromium.org | 604a589 | 2011-03-23 23:55:48 +0000 | [diff] [blame] | 137 | output.write(str(item)) |
maruel@chromium.org | 35625c7 | 2011-03-23 17:34:02 +0000 | [diff] [blame] | 138 | if index < len(self._items) - 1: |
| 139 | output.write(' \\') |
| 140 | output.write('\n') |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 141 | if self._long_text: |
maruel@chromium.org | 35625c7 | 2011-03-23 17:34:02 +0000 | [diff] [blame] | 142 | output.write('\n***************\n') |
| 143 | # Write separately in case it's unicode. |
| 144 | output.write(self._long_text) |
| 145 | output.write('\n***************\n') |
dpranke@chromium.org | 5ac2101 | 2011-03-16 02:58:25 +0000 | [diff] [blame] | 146 | if self.fatal: |
| 147 | output.fail() |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 148 | |
dpranke@chromium.org | 5ac2101 | 2011-03-16 02:58:25 +0000 | [diff] [blame] | 149 | class PresubmitAddReviewers(PresubmitResult): |
| 150 | """Add some suggested reviewers to the change.""" |
| 151 | def __init__(self, reviewers): |
| 152 | super(OutputApi.PresubmitAddReviewers, self).__init__('') |
| 153 | self.reviewers = reviewers |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 154 | |
dpranke@chromium.org | 5ac2101 | 2011-03-16 02:58:25 +0000 | [diff] [blame] | 155 | def handle(self, output): |
| 156 | output.reviewers.extend(self.reviewers) |
dpranke@chromium.org | 3ae183f | 2011-03-09 21:40:32 +0000 | [diff] [blame] | 157 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 158 | class PresubmitError(PresubmitResult): |
| 159 | """A hard presubmit error.""" |
dpranke@chromium.org | 5ac2101 | 2011-03-16 02:58:25 +0000 | [diff] [blame] | 160 | fatal = True |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 161 | |
| 162 | class PresubmitPromptWarning(PresubmitResult): |
| 163 | """An warning that prompts the user if they want to continue.""" |
dpranke@chromium.org | 5ac2101 | 2011-03-16 02:58:25 +0000 | [diff] [blame] | 164 | should_prompt = True |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 165 | |
| 166 | class PresubmitNotifyResult(PresubmitResult): |
| 167 | """Just print something to the screen -- but it's not even a warning.""" |
| 168 | pass |
| 169 | |
wez@chromium.org | a6d011e | 2013-03-26 17:31:49 +0000 | [diff] [blame] | 170 | def PresubmitPromptOrNotify(self, *args, **kwargs): |
| 171 | """Warn the user when uploading, but only notify if committing.""" |
| 172 | if self.is_committing: |
| 173 | return self.PresubmitNotifyResult(*args, **kwargs) |
| 174 | return self.PresubmitPromptWarning(*args, **kwargs) |
| 175 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 176 | class MailTextResult(PresubmitResult): |
| 177 | """A warning that should be included in the review request email.""" |
| 178 | def __init__(self, *args, **kwargs): |
maruel@chromium.org | cb2985f | 2010-11-03 14:08:31 +0000 | [diff] [blame] | 179 | super(OutputApi.MailTextResult, self).__init__() |
maruel@chromium.org | 899e1c1 | 2011-04-07 17:03:18 +0000 | [diff] [blame] | 180 | raise NotImplementedError() |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 181 | |
| 182 | |
| 183 | class InputApi(object): |
| 184 | """An instance of this object is passed to presubmit scripts so they can |
| 185 | know stuff about the change they're looking at. |
| 186 | """ |
maruel@chromium.org | b17b55b | 2010-11-03 14:42:37 +0000 | [diff] [blame] | 187 | # Method could be a function |
| 188 | # pylint: disable=R0201 |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 189 | |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 190 | # File extensions that are considered source files from a style guide |
| 191 | # perspective. Don't modify this list from a presubmit script! |
maruel@chromium.org | c33455a | 2011-06-24 19:14:18 +0000 | [diff] [blame] | 192 | # |
| 193 | # Files without an extension aren't included in the list. If you want to |
| 194 | # filter them as source files, add r"(^|.*?[\\\/])[^.]+$" to the white list. |
| 195 | # Note that ALL CAPS files are black listed in DEFAULT_BLACK_LIST below. |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 196 | DEFAULT_WHITE_LIST = ( |
| 197 | # C++ and friends |
maruel@chromium.org | fe1211a | 2011-05-28 18:54:17 +0000 | [diff] [blame] | 198 | r".+\.c$", r".+\.cc$", r".+\.cpp$", r".+\.h$", r".+\.m$", r".+\.mm$", |
| 199 | r".+\.inl$", r".+\.asm$", r".+\.hxx$", r".+\.hpp$", r".+\.s$", r".+\.S$", |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 200 | # Scripts |
maruel@chromium.org | fe1211a | 2011-05-28 18:54:17 +0000 | [diff] [blame] | 201 | r".+\.js$", r".+\.py$", r".+\.sh$", r".+\.rb$", r".+\.pl$", r".+\.pm$", |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 202 | # Other |
estade@chromium.org | ae7af92 | 2012-01-27 14:51:13 +0000 | [diff] [blame] | 203 | r".+\.java$", r".+\.mk$", r".+\.am$", r".+\.css$" |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 204 | ) |
| 205 | |
| 206 | # Path regexp that should be excluded from being considered containing source |
| 207 | # files. Don't modify this list from a presubmit script! |
| 208 | DEFAULT_BLACK_LIST = ( |
gavinp@chromium.org | 656326d | 2012-08-13 00:43:57 +0000 | [diff] [blame] | 209 | r"testing_support[\\\/]google_appengine[\\\/].*", |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 210 | r".*\bexperimental[\\\/].*", |
| 211 | r".*\bthird_party[\\\/].*", |
| 212 | # Output directories (just in case) |
| 213 | r".*\bDebug[\\\/].*", |
| 214 | r".*\bRelease[\\\/].*", |
| 215 | r".*\bxcodebuild[\\\/].*", |
| 216 | r".*\bsconsbuild[\\\/].*", |
| 217 | # All caps files like README and LICENCE. |
maruel@chromium.org | ab05d58 | 2011-02-09 23:41:22 +0000 | [diff] [blame] | 218 | r".*\b[A-Z0-9_]{2,}$", |
maruel@chromium.org | df1595a | 2009-06-11 02:00:13 +0000 | [diff] [blame] | 219 | # SCM (can happen in dual SCM configuration). (Slightly over aggressive) |
maruel@chromium.org | 5d0dc43 | 2011-01-03 02:40:37 +0000 | [diff] [blame] | 220 | r"(|.*[\\\/])\.git[\\\/].*", |
| 221 | r"(|.*[\\\/])\.svn[\\\/].*", |
maruel@chromium.org | 7ccb4bb | 2011-11-07 20:26:20 +0000 | [diff] [blame] | 222 | # There is no point in processing a patch file. |
| 223 | r".+\.diff$", |
| 224 | r".+\.patch$", |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 225 | ) |
| 226 | |
maruel@chromium.org | cc73ad6 | 2011-07-06 17:39:26 +0000 | [diff] [blame] | 227 | def __init__(self, change, presubmit_path, is_committing, |
maruel@chromium.org | 239f411 | 2011-06-03 20:08:23 +0000 | [diff] [blame] | 228 | rietveld_obj, verbose): |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 229 | """Builds an InputApi object. |
| 230 | |
| 231 | Args: |
maruel@chromium.org | 4ff922a | 2009-06-12 20:20:19 +0000 | [diff] [blame] | 232 | change: A presubmit.Change object. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 233 | presubmit_path: The path to the presubmit script being processed. |
maruel@chromium.org | d7dccf5 | 2009-06-06 18:51:58 +0000 | [diff] [blame] | 234 | is_committing: True if the change is about to be committed. |
maruel@chromium.org | 239f411 | 2011-06-03 20:08:23 +0000 | [diff] [blame] | 235 | rietveld_obj: rietveld.Rietveld client object |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 236 | """ |
maruel@chromium.org | 9711bba | 2009-05-22 23:51:39 +0000 | [diff] [blame] | 237 | # Version number of the presubmit_support script. |
| 238 | self.version = [int(x) for x in __version__.split('.')] |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 239 | self.change = change |
maruel@chromium.org | d7dccf5 | 2009-06-06 18:51:58 +0000 | [diff] [blame] | 240 | self.is_committing = is_committing |
maruel@chromium.org | 239f411 | 2011-06-03 20:08:23 +0000 | [diff] [blame] | 241 | self.rietveld = rietveld_obj |
maruel@chromium.org | cab38e9 | 2011-04-09 00:30:51 +0000 | [diff] [blame] | 242 | # TBD |
| 243 | self.host_url = 'http://codereview.chromium.org' |
| 244 | if self.rietveld: |
maruel@chromium.org | 239f411 | 2011-06-03 20:08:23 +0000 | [diff] [blame] | 245 | self.host_url = self.rietveld.url |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 246 | |
| 247 | # We expose various modules and functions as attributes of the input_api |
| 248 | # so that presubmit scripts don't have to import them. |
| 249 | self.basename = os.path.basename |
| 250 | self.cPickle = cPickle |
enne@chromium.org | e72c5f5 | 2013-04-16 00:36:40 +0000 | [diff] [blame] | 251 | self.cpplint = cpplint |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 252 | self.cStringIO = cStringIO |
dpranke@chromium.org | 17cc244 | 2012-10-17 21:12:09 +0000 | [diff] [blame] | 253 | self.glob = glob.glob |
maruel@chromium.org | fb11c7b | 2010-03-18 18:22:14 +0000 | [diff] [blame] | 254 | self.json = json |
maruel@chromium.org | 6fba34d | 2011-06-02 13:45:12 +0000 | [diff] [blame] | 255 | self.logging = logging.getLogger('PRESUBMIT') |
maruel@chromium.org | 2b5ce56 | 2011-03-31 16:15:44 +0000 | [diff] [blame] | 256 | self.os_listdir = os.listdir |
| 257 | self.os_walk = os.walk |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 258 | self.os_path = os.path |
| 259 | self.pickle = pickle |
| 260 | self.marshal = marshal |
| 261 | self.re = re |
| 262 | self.subprocess = subprocess |
| 263 | self.tempfile = tempfile |
dpranke@chromium.org | 0d1bdea | 2011-03-24 22:54:38 +0000 | [diff] [blame] | 264 | self.time = time |
maruel@chromium.org | d7dccf5 | 2009-06-06 18:51:58 +0000 | [diff] [blame] | 265 | self.traceback = traceback |
maruel@chromium.org | 1487d53 | 2009-06-06 00:22:57 +0000 | [diff] [blame] | 266 | self.unittest = unittest |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 267 | self.urllib2 = urllib2 |
| 268 | |
maruel@chromium.org | c0b2297 | 2009-06-25 16:19:14 +0000 | [diff] [blame] | 269 | # To easily fork python. |
| 270 | self.python_executable = sys.executable |
| 271 | self.environ = os.environ |
| 272 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 273 | # InputApi.platform is the platform you're currently running on. |
| 274 | self.platform = sys.platform |
| 275 | |
| 276 | # The local path of the currently-being-processed presubmit script. |
maruel@chromium.org | 3d23524 | 2009-05-15 12:40:48 +0000 | [diff] [blame] | 277 | self._current_presubmit_path = os.path.dirname(presubmit_path) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 278 | |
| 279 | # We carry the canned checks so presubmit scripts can easily use them. |
| 280 | self.canned_checks = presubmit_canned_checks |
| 281 | |
dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 282 | # TODO(dpranke): figure out a list of all approved owners for a repo |
| 283 | # in order to be able to handle wildcard OWNERS files? |
| 284 | self.owners_db = owners.Database(change.RepositoryRoot(), |
dpranke@chromium.org | 17cc244 | 2012-10-17 21:12:09 +0000 | [diff] [blame] | 285 | fopen=file, os_path=self.os_path, glob=self.glob) |
maruel@chromium.org | 899e1c1 | 2011-04-07 17:03:18 +0000 | [diff] [blame] | 286 | self.verbose = verbose |
dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 287 | |
enne@chromium.org | e72c5f5 | 2013-04-16 00:36:40 +0000 | [diff] [blame] | 288 | # Replace <hash_map> and <hash_set> as headers that need to be included |
| 289 | # with "base/hash_tables.h" instead. |
| 290 | # Access to a protected member _XX of a client class |
| 291 | # pylint: disable=W0212 |
| 292 | self.cpplint._re_pattern_templates = [ |
| 293 | (a, b, 'base/hash_tables.h') |
| 294 | if header in ('<hash_map>', '<hash_set>') else (a, b, header) |
| 295 | for (a, b, header) in cpplint._re_pattern_templates |
| 296 | ] |
| 297 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 298 | def PresubmitLocalPath(self): |
| 299 | """Returns the local path of the presubmit script currently being run. |
| 300 | |
| 301 | This is useful if you don't want to hard-code absolute paths in the |
| 302 | presubmit script. For example, It can be used to find another file |
| 303 | relative to the PRESUBMIT.py script, so the whole tree can be branched and |
| 304 | the presubmit script still works, without editing its content. |
| 305 | """ |
maruel@chromium.org | 3d23524 | 2009-05-15 12:40:48 +0000 | [diff] [blame] | 306 | return self._current_presubmit_path |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 307 | |
maruel@chromium.org | 1e08c00 | 2009-05-28 19:09:33 +0000 | [diff] [blame] | 308 | def DepotToLocalPath(self, depot_path): |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 309 | """Translate a depot path to a local path (relative to client root). |
| 310 | |
| 311 | Args: |
| 312 | Depot path as a string. |
| 313 | |
| 314 | Returns: |
| 315 | The local path of the depot path under the user's current client, or None |
| 316 | if the file is not mapped. |
| 317 | |
| 318 | Remember to check for the None case and show an appropriate error! |
| 319 | """ |
maruel@chromium.org | d579fcf | 2011-12-13 20:36:03 +0000 | [diff] [blame] | 320 | return scm.SVN.CaptureLocalInfo([depot_path], self.change.RepositoryRoot() |
| 321 | ).get('Path') |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 322 | |
maruel@chromium.org | 1e08c00 | 2009-05-28 19:09:33 +0000 | [diff] [blame] | 323 | def LocalToDepotPath(self, local_path): |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 324 | """Translate a local path to a depot path. |
| 325 | |
| 326 | Args: |
| 327 | Local path (relative to current directory, or absolute) as a string. |
| 328 | |
| 329 | Returns: |
| 330 | The depot path (SVN URL) of the file if mapped, otherwise None. |
| 331 | """ |
maruel@chromium.org | d579fcf | 2011-12-13 20:36:03 +0000 | [diff] [blame] | 332 | return scm.SVN.CaptureLocalInfo([local_path], self.change.RepositoryRoot() |
| 333 | ).get('URL') |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 334 | |
sail@chromium.org | 5538e02 | 2011-05-12 17:53:16 +0000 | [diff] [blame] | 335 | def AffectedFiles(self, include_dirs=False, include_deletes=True, |
| 336 | file_filter=None): |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 337 | """Same as input_api.change.AffectedFiles() except only lists files |
| 338 | (and optionally directories) in the same directory as the current presubmit |
| 339 | script, or subdirectories thereof. |
| 340 | """ |
maruel@chromium.org | 3d23524 | 2009-05-15 12:40:48 +0000 | [diff] [blame] | 341 | dir_with_slash = normpath("%s/" % self.PresubmitLocalPath()) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 342 | if len(dir_with_slash) == 1: |
| 343 | dir_with_slash = '' |
sail@chromium.org | 5538e02 | 2011-05-12 17:53:16 +0000 | [diff] [blame] | 344 | |
maruel@chromium.org | 4661e0c | 2009-06-04 00:45:26 +0000 | [diff] [blame] | 345 | return filter( |
| 346 | lambda x: normpath(x.AbsoluteLocalPath()).startswith(dir_with_slash), |
sail@chromium.org | 5538e02 | 2011-05-12 17:53:16 +0000 | [diff] [blame] | 347 | self.change.AffectedFiles(include_dirs, include_deletes, file_filter)) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 348 | |
| 349 | def LocalPaths(self, include_dirs=False): |
| 350 | """Returns local paths of input_api.AffectedFiles().""" |
| 351 | return [af.LocalPath() for af in self.AffectedFiles(include_dirs)] |
| 352 | |
| 353 | def AbsoluteLocalPaths(self, include_dirs=False): |
| 354 | """Returns absolute local paths of input_api.AffectedFiles().""" |
| 355 | return [af.AbsoluteLocalPath() for af in self.AffectedFiles(include_dirs)] |
| 356 | |
| 357 | def ServerPaths(self, include_dirs=False): |
| 358 | """Returns server paths of input_api.AffectedFiles().""" |
| 359 | return [af.ServerPath() for af in self.AffectedFiles(include_dirs)] |
| 360 | |
maruel@chromium.org | 77c4f0f | 2009-05-29 18:53:04 +0000 | [diff] [blame] | 361 | def AffectedTextFiles(self, include_deletes=None): |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 362 | """Same as input_api.change.AffectedTextFiles() except only lists files |
| 363 | in the same directory as the current presubmit script, or subdirectories |
| 364 | thereof. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 365 | """ |
maruel@chromium.org | 77c4f0f | 2009-05-29 18:53:04 +0000 | [diff] [blame] | 366 | if include_deletes is not None: |
maruel@chromium.org | cb2985f | 2010-11-03 14:08:31 +0000 | [diff] [blame] | 367 | warn("AffectedTextFiles(include_deletes=%s)" |
| 368 | " is deprecated and ignored" % str(include_deletes), |
| 369 | category=DeprecationWarning, |
| 370 | stacklevel=2) |
maruel@chromium.org | 77c4f0f | 2009-05-29 18:53:04 +0000 | [diff] [blame] | 371 | return filter(lambda x: x.IsTextFile(), |
| 372 | self.AffectedFiles(include_dirs=False, include_deletes=False)) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 373 | |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 374 | def FilterSourceFile(self, affected_file, white_list=None, black_list=None): |
| 375 | """Filters out files that aren't considered "source file". |
| 376 | |
| 377 | If white_list or black_list is None, InputApi.DEFAULT_WHITE_LIST |
| 378 | and InputApi.DEFAULT_BLACK_LIST is used respectively. |
| 379 | |
| 380 | The lists will be compiled as regular expression and |
| 381 | AffectedFile.LocalPath() needs to pass both list. |
| 382 | |
| 383 | Note: Copy-paste this function to suit your needs or use a lambda function. |
| 384 | """ |
maruel@chromium.org | cb2985f | 2010-11-03 14:08:31 +0000 | [diff] [blame] | 385 | def Find(affected_file, items): |
maruel@chromium.org | ab05d58 | 2011-02-09 23:41:22 +0000 | [diff] [blame] | 386 | local_path = affected_file.LocalPath() |
maruel@chromium.org | cb2985f | 2010-11-03 14:08:31 +0000 | [diff] [blame] | 387 | for item in items: |
maruel@chromium.org | df1595a | 2009-06-11 02:00:13 +0000 | [diff] [blame] | 388 | if self.re.match(item, local_path): |
| 389 | logging.debug("%s matched %s" % (item, local_path)) |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 390 | return True |
| 391 | return False |
| 392 | return (Find(affected_file, white_list or self.DEFAULT_WHITE_LIST) and |
| 393 | not Find(affected_file, black_list or self.DEFAULT_BLACK_LIST)) |
| 394 | |
| 395 | def AffectedSourceFiles(self, source_file): |
| 396 | """Filter the list of AffectedTextFiles by the function source_file. |
| 397 | |
| 398 | If source_file is None, InputApi.FilterSourceFile() is used. |
| 399 | """ |
| 400 | if not source_file: |
| 401 | source_file = self.FilterSourceFile |
| 402 | return filter(source_file, self.AffectedTextFiles()) |
| 403 | |
| 404 | def RightHandSideLines(self, source_file_filter=None): |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 405 | """An iterator over all text lines in "new" version of changed files. |
| 406 | |
| 407 | Only lists lines from new or modified text files in the change that are |
| 408 | contained by the directory of the currently executing presubmit script. |
| 409 | |
| 410 | This is useful for doing line-by-line regex checks, like checking for |
| 411 | trailing whitespace. |
| 412 | |
| 413 | Yields: |
| 414 | a 3 tuple: |
| 415 | the AffectedFile instance of the current file; |
| 416 | integer line number (1-based); and |
| 417 | the contents of the line as a string. |
maruel@chromium.org | 1487d53 | 2009-06-06 00:22:57 +0000 | [diff] [blame] | 418 | |
nick@chromium.org | 2a3ab7e | 2011-04-27 22:06:27 +0000 | [diff] [blame] | 419 | Note: The carriage return (LF or CR) is stripped off. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 420 | """ |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 421 | files = self.AffectedSourceFiles(source_file_filter) |
maruel@chromium.org | cb2985f | 2010-11-03 14:08:31 +0000 | [diff] [blame] | 422 | return _RightHandSideLinesImpl(files) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 423 | |
maruel@chromium.org | e3608df | 2009-11-10 20:22:57 +0000 | [diff] [blame] | 424 | def ReadFile(self, file_item, mode='r'): |
maruel@chromium.org | 44a17ad | 2009-06-08 14:14:35 +0000 | [diff] [blame] | 425 | """Reads an arbitrary file. |
thestig@chromium.org | da8cddd | 2009-08-13 00:25:55 +0000 | [diff] [blame] | 426 | |
maruel@chromium.org | 44a17ad | 2009-06-08 14:14:35 +0000 | [diff] [blame] | 427 | Deny reading anything outside the repository. |
| 428 | """ |
maruel@chromium.org | e3608df | 2009-11-10 20:22:57 +0000 | [diff] [blame] | 429 | if isinstance(file_item, AffectedFile): |
| 430 | file_item = file_item.AbsoluteLocalPath() |
| 431 | if not file_item.startswith(self.change.RepositoryRoot()): |
maruel@chromium.org | 44a17ad | 2009-06-08 14:14:35 +0000 | [diff] [blame] | 432 | raise IOError('Access outside the repository root is denied.') |
maruel@chromium.org | 5aeb7dd | 2009-11-17 18:09:01 +0000 | [diff] [blame] | 433 | return gclient_utils.FileRead(file_item, mode) |
maruel@chromium.org | 44a17ad | 2009-06-08 14:14:35 +0000 | [diff] [blame] | 434 | |
maruel@chromium.org | cc73ad6 | 2011-07-06 17:39:26 +0000 | [diff] [blame] | 435 | @property |
| 436 | def tbr(self): |
| 437 | """Returns if a change is TBR'ed.""" |
| 438 | return 'TBR' in self.change.tags |
| 439 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 440 | |
| 441 | class AffectedFile(object): |
| 442 | """Representation of a file in a change.""" |
maruel@chromium.org | b17b55b | 2010-11-03 14:42:37 +0000 | [diff] [blame] | 443 | # Method could be a function |
| 444 | # pylint: disable=R0201 |
maruel@chromium.org | d579fcf | 2011-12-13 20:36:03 +0000 | [diff] [blame] | 445 | def __init__(self, path, action, repository_root): |
maruel@chromium.org | 15bdffa | 2009-05-29 11:16:29 +0000 | [diff] [blame] | 446 | self._path = path |
| 447 | self._action = action |
maruel@chromium.org | 4ff922a | 2009-06-12 20:20:19 +0000 | [diff] [blame] | 448 | self._local_root = repository_root |
maruel@chromium.org | 15bdffa | 2009-05-29 11:16:29 +0000 | [diff] [blame] | 449 | self._is_directory = None |
| 450 | self._properties = {} |
nick@chromium.org | 2a3ab7e | 2011-04-27 22:06:27 +0000 | [diff] [blame] | 451 | self._cached_changed_contents = None |
| 452 | self._cached_new_contents = None |
maruel@chromium.org | 5d0dc43 | 2011-01-03 02:40:37 +0000 | [diff] [blame] | 453 | logging.debug('%s(%s)' % (self.__class__.__name__, self._path)) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 454 | |
| 455 | def ServerPath(self): |
| 456 | """Returns a path string that identifies the file in the SCM system. |
| 457 | |
| 458 | Returns the empty string if the file does not exist in SCM. |
| 459 | """ |
maruel@chromium.org | dbbeedc | 2009-05-22 20:26:17 +0000 | [diff] [blame] | 460 | return "" |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 461 | |
| 462 | def LocalPath(self): |
| 463 | """Returns the path of this file on the local disk relative to client root. |
| 464 | """ |
maruel@chromium.org | 15bdffa | 2009-05-29 11:16:29 +0000 | [diff] [blame] | 465 | return normpath(self._path) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 466 | |
| 467 | def AbsoluteLocalPath(self): |
| 468 | """Returns the absolute path of this file on the local disk. |
| 469 | """ |
chase@chromium.org | 8e416c8 | 2009-10-06 04:30:44 +0000 | [diff] [blame] | 470 | return os.path.abspath(os.path.join(self._local_root, self.LocalPath())) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 471 | |
| 472 | def IsDirectory(self): |
| 473 | """Returns true if this object is a directory.""" |
maruel@chromium.org | 15bdffa | 2009-05-29 11:16:29 +0000 | [diff] [blame] | 474 | if self._is_directory is None: |
| 475 | path = self.AbsoluteLocalPath() |
| 476 | self._is_directory = (os.path.exists(path) and |
| 477 | os.path.isdir(path)) |
| 478 | return self._is_directory |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 479 | |
| 480 | def Action(self): |
| 481 | """Returns the action on this opened file, e.g. A, M, D, etc.""" |
maruel@chromium.org | dbbeedc | 2009-05-22 20:26:17 +0000 | [diff] [blame] | 482 | # TODO(maruel): Somewhat crappy, Could be "A" or "A +" for svn but |
| 483 | # different for other SCM. |
maruel@chromium.org | 15bdffa | 2009-05-29 11:16:29 +0000 | [diff] [blame] | 484 | return self._action |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 485 | |
maruel@chromium.org | dbbeedc | 2009-05-22 20:26:17 +0000 | [diff] [blame] | 486 | def Property(self, property_name): |
| 487 | """Returns the specified SCM property of this file, or None if no such |
| 488 | property. |
| 489 | """ |
maruel@chromium.org | 15bdffa | 2009-05-29 11:16:29 +0000 | [diff] [blame] | 490 | return self._properties.get(property_name, None) |
maruel@chromium.org | dbbeedc | 2009-05-22 20:26:17 +0000 | [diff] [blame] | 491 | |
maruel@chromium.org | 1e08c00 | 2009-05-28 19:09:33 +0000 | [diff] [blame] | 492 | def IsTextFile(self): |
maruel@chromium.org | 77c4f0f | 2009-05-29 18:53:04 +0000 | [diff] [blame] | 493 | """Returns True if the file is a text file and not a binary file. |
thestig@chromium.org | da8cddd | 2009-08-13 00:25:55 +0000 | [diff] [blame] | 494 | |
maruel@chromium.org | 77c4f0f | 2009-05-29 18:53:04 +0000 | [diff] [blame] | 495 | Deleted files are not text file.""" |
maruel@chromium.org | 1e08c00 | 2009-05-28 19:09:33 +0000 | [diff] [blame] | 496 | raise NotImplementedError() # Implement when needed |
| 497 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 498 | def NewContents(self): |
| 499 | """Returns an iterator over the lines in the new version of file. |
| 500 | |
| 501 | The new version is the file in the user's workspace, i.e. the "right hand |
| 502 | side". |
| 503 | |
| 504 | Contents will be empty if the file is a directory or does not exist. |
nick@chromium.org | 2a3ab7e | 2011-04-27 22:06:27 +0000 | [diff] [blame] | 505 | Note: The carriage returns (LF or CR) are stripped off. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 506 | """ |
nick@chromium.org | 2a3ab7e | 2011-04-27 22:06:27 +0000 | [diff] [blame] | 507 | if self._cached_new_contents is None: |
| 508 | self._cached_new_contents = [] |
| 509 | if not self.IsDirectory(): |
| 510 | try: |
| 511 | self._cached_new_contents = gclient_utils.FileRead( |
| 512 | self.AbsoluteLocalPath(), 'rU').splitlines() |
| 513 | except IOError: |
| 514 | pass # File not found? That's fine; maybe it was deleted. |
| 515 | return self._cached_new_contents[:] |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 516 | |
| 517 | def OldContents(self): |
| 518 | """Returns an iterator over the lines in the old version of file. |
| 519 | |
| 520 | The old version is the file in depot, i.e. the "left hand side". |
| 521 | """ |
| 522 | raise NotImplementedError() # Implement when needed |
| 523 | |
| 524 | def OldFileTempPath(self): |
| 525 | """Returns the path on local disk where the old contents resides. |
| 526 | |
| 527 | The old version is the file in depot, i.e. the "left hand side". |
| 528 | This is a read-only cached copy of the old contents. *DO NOT* try to |
| 529 | modify this file. |
| 530 | """ |
| 531 | raise NotImplementedError() # Implement if/when needed. |
| 532 | |
maruel@chromium.org | ab05d58 | 2011-02-09 23:41:22 +0000 | [diff] [blame] | 533 | def ChangedContents(self): |
| 534 | """Returns a list of tuples (line number, line text) of all new lines. |
| 535 | |
| 536 | This relies on the scm diff output describing each changed code section |
| 537 | with a line of the form |
| 538 | |
| 539 | ^@@ <old line num>,<old size> <new line num>,<new size> @@$ |
| 540 | """ |
nick@chromium.org | 2a3ab7e | 2011-04-27 22:06:27 +0000 | [diff] [blame] | 541 | if self._cached_changed_contents is not None: |
| 542 | return self._cached_changed_contents[:] |
| 543 | self._cached_changed_contents = [] |
maruel@chromium.org | ab05d58 | 2011-02-09 23:41:22 +0000 | [diff] [blame] | 544 | line_num = 0 |
| 545 | |
| 546 | if self.IsDirectory(): |
| 547 | return [] |
| 548 | |
| 549 | for line in self.GenerateScmDiff().splitlines(): |
| 550 | m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line) |
| 551 | if m: |
| 552 | line_num = int(m.groups(1)[0]) |
| 553 | continue |
| 554 | if line.startswith('+') and not line.startswith('++'): |
nick@chromium.org | 2a3ab7e | 2011-04-27 22:06:27 +0000 | [diff] [blame] | 555 | self._cached_changed_contents.append((line_num, line[1:])) |
maruel@chromium.org | ab05d58 | 2011-02-09 23:41:22 +0000 | [diff] [blame] | 556 | if not line.startswith('-'): |
| 557 | line_num += 1 |
nick@chromium.org | 2a3ab7e | 2011-04-27 22:06:27 +0000 | [diff] [blame] | 558 | return self._cached_changed_contents[:] |
maruel@chromium.org | ab05d58 | 2011-02-09 23:41:22 +0000 | [diff] [blame] | 559 | |
maruel@chromium.org | 5de1397 | 2009-06-10 18:16:06 +0000 | [diff] [blame] | 560 | def __str__(self): |
| 561 | return self.LocalPath() |
| 562 | |
maruel@chromium.org | ab05d58 | 2011-02-09 23:41:22 +0000 | [diff] [blame] | 563 | def GenerateScmDiff(self): |
| 564 | raise NotImplementedError() # Implemented in derived classes. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 565 | |
maruel@chromium.org | 58407af | 2011-04-12 23:15:57 +0000 | [diff] [blame] | 566 | |
maruel@chromium.org | dbbeedc | 2009-05-22 20:26:17 +0000 | [diff] [blame] | 567 | class SvnAffectedFile(AffectedFile): |
| 568 | """Representation of a file in a change out of a Subversion checkout.""" |
maruel@chromium.org | b17b55b | 2010-11-03 14:42:37 +0000 | [diff] [blame] | 569 | # Method 'NNN' is abstract in class 'NNN' but is not overridden |
| 570 | # pylint: disable=W0223 |
maruel@chromium.org | dbbeedc | 2009-05-22 20:26:17 +0000 | [diff] [blame] | 571 | |
maruel@chromium.org | 15bdffa | 2009-05-29 11:16:29 +0000 | [diff] [blame] | 572 | def __init__(self, *args, **kwargs): |
| 573 | AffectedFile.__init__(self, *args, **kwargs) |
| 574 | self._server_path = None |
| 575 | self._is_text_file = None |
maruel@chromium.org | 3bbf294 | 2012-01-10 16:52:06 +0000 | [diff] [blame] | 576 | self._diff = None |
maruel@chromium.org | 15bdffa | 2009-05-29 11:16:29 +0000 | [diff] [blame] | 577 | |
maruel@chromium.org | dbbeedc | 2009-05-22 20:26:17 +0000 | [diff] [blame] | 578 | def ServerPath(self): |
maruel@chromium.org | 15bdffa | 2009-05-29 11:16:29 +0000 | [diff] [blame] | 579 | if self._server_path is None: |
maruel@chromium.org | d579fcf | 2011-12-13 20:36:03 +0000 | [diff] [blame] | 580 | self._server_path = scm.SVN.CaptureLocalInfo( |
| 581 | [self.LocalPath()], self._local_root).get('URL', '') |
maruel@chromium.org | 15bdffa | 2009-05-29 11:16:29 +0000 | [diff] [blame] | 582 | return self._server_path |
maruel@chromium.org | dbbeedc | 2009-05-22 20:26:17 +0000 | [diff] [blame] | 583 | |
| 584 | def IsDirectory(self): |
maruel@chromium.org | 15bdffa | 2009-05-29 11:16:29 +0000 | [diff] [blame] | 585 | if self._is_directory is None: |
| 586 | path = self.AbsoluteLocalPath() |
maruel@chromium.org | dbbeedc | 2009-05-22 20:26:17 +0000 | [diff] [blame] | 587 | if os.path.exists(path): |
| 588 | # Retrieve directly from the file system; it is much faster than |
| 589 | # querying subversion, especially on Windows. |
maruel@chromium.org | 15bdffa | 2009-05-29 11:16:29 +0000 | [diff] [blame] | 590 | self._is_directory = os.path.isdir(path) |
maruel@chromium.org | dbbeedc | 2009-05-22 20:26:17 +0000 | [diff] [blame] | 591 | else: |
maruel@chromium.org | d579fcf | 2011-12-13 20:36:03 +0000 | [diff] [blame] | 592 | self._is_directory = scm.SVN.CaptureLocalInfo( |
| 593 | [self.LocalPath()], self._local_root |
| 594 | ).get('Node Kind') in ('dir', 'directory') |
maruel@chromium.org | 15bdffa | 2009-05-29 11:16:29 +0000 | [diff] [blame] | 595 | return self._is_directory |
maruel@chromium.org | dbbeedc | 2009-05-22 20:26:17 +0000 | [diff] [blame] | 596 | |
| 597 | def Property(self, property_name): |
maruel@chromium.org | 15bdffa | 2009-05-29 11:16:29 +0000 | [diff] [blame] | 598 | if not property_name in self._properties: |
maruel@chromium.org | 5aeb7dd | 2009-11-17 18:09:01 +0000 | [diff] [blame] | 599 | self._properties[property_name] = scm.SVN.GetFileProperty( |
maruel@chromium.org | d579fcf | 2011-12-13 20:36:03 +0000 | [diff] [blame] | 600 | self.LocalPath(), property_name, self._local_root).rstrip() |
maruel@chromium.org | 15bdffa | 2009-05-29 11:16:29 +0000 | [diff] [blame] | 601 | return self._properties[property_name] |
maruel@chromium.org | dbbeedc | 2009-05-22 20:26:17 +0000 | [diff] [blame] | 602 | |
maruel@chromium.org | 1e08c00 | 2009-05-28 19:09:33 +0000 | [diff] [blame] | 603 | def IsTextFile(self): |
maruel@chromium.org | 15bdffa | 2009-05-29 11:16:29 +0000 | [diff] [blame] | 604 | if self._is_text_file is None: |
| 605 | if self.Action() == 'D': |
| 606 | # A deleted file is not a text file. |
| 607 | self._is_text_file = False |
| 608 | elif self.IsDirectory(): |
| 609 | self._is_text_file = False |
| 610 | else: |
maruel@chromium.org | d579fcf | 2011-12-13 20:36:03 +0000 | [diff] [blame] | 611 | mime_type = scm.SVN.GetFileProperty( |
| 612 | self.LocalPath(), 'svn:mime-type', self._local_root) |
maruel@chromium.org | 15bdffa | 2009-05-29 11:16:29 +0000 | [diff] [blame] | 613 | self._is_text_file = (not mime_type or mime_type.startswith('text/')) |
| 614 | return self._is_text_file |
maruel@chromium.org | 1e08c00 | 2009-05-28 19:09:33 +0000 | [diff] [blame] | 615 | |
maruel@chromium.org | ab05d58 | 2011-02-09 23:41:22 +0000 | [diff] [blame] | 616 | def GenerateScmDiff(self): |
maruel@chromium.org | 3bbf294 | 2012-01-10 16:52:06 +0000 | [diff] [blame] | 617 | if self._diff is None: |
| 618 | self._diff = scm.SVN.GenerateDiff( |
| 619 | [self.LocalPath()], self._local_root, False, None) |
| 620 | return self._diff |
maruel@chromium.org | 1f31281 | 2011-02-10 01:33:57 +0000 | [diff] [blame] | 621 | |
maruel@chromium.org | dbbeedc | 2009-05-22 20:26:17 +0000 | [diff] [blame] | 622 | |
maruel@chromium.org | c70a220 | 2009-06-17 12:55:10 +0000 | [diff] [blame] | 623 | class GitAffectedFile(AffectedFile): |
| 624 | """Representation of a file in a change out of a git checkout.""" |
maruel@chromium.org | b17b55b | 2010-11-03 14:42:37 +0000 | [diff] [blame] | 625 | # Method 'NNN' is abstract in class 'NNN' but is not overridden |
| 626 | # pylint: disable=W0223 |
maruel@chromium.org | c70a220 | 2009-06-17 12:55:10 +0000 | [diff] [blame] | 627 | |
| 628 | def __init__(self, *args, **kwargs): |
| 629 | AffectedFile.__init__(self, *args, **kwargs) |
| 630 | self._server_path = None |
| 631 | self._is_text_file = None |
maruel@chromium.org | 3bbf294 | 2012-01-10 16:52:06 +0000 | [diff] [blame] | 632 | self._diff = None |
maruel@chromium.org | c70a220 | 2009-06-17 12:55:10 +0000 | [diff] [blame] | 633 | |
| 634 | def ServerPath(self): |
| 635 | if self._server_path is None: |
maruel@chromium.org | 899e1c1 | 2011-04-07 17:03:18 +0000 | [diff] [blame] | 636 | raise NotImplementedError('TODO(maruel) Implement.') |
maruel@chromium.org | c70a220 | 2009-06-17 12:55:10 +0000 | [diff] [blame] | 637 | return self._server_path |
| 638 | |
| 639 | def IsDirectory(self): |
| 640 | if self._is_directory is None: |
| 641 | path = self.AbsoluteLocalPath() |
| 642 | if os.path.exists(path): |
| 643 | # Retrieve directly from the file system; it is much faster than |
| 644 | # querying subversion, especially on Windows. |
| 645 | self._is_directory = os.path.isdir(path) |
| 646 | else: |
maruel@chromium.org | c70a220 | 2009-06-17 12:55:10 +0000 | [diff] [blame] | 647 | self._is_directory = False |
| 648 | return self._is_directory |
| 649 | |
| 650 | def Property(self, property_name): |
| 651 | if not property_name in self._properties: |
maruel@chromium.org | 899e1c1 | 2011-04-07 17:03:18 +0000 | [diff] [blame] | 652 | raise NotImplementedError('TODO(maruel) Implement.') |
maruel@chromium.org | c70a220 | 2009-06-17 12:55:10 +0000 | [diff] [blame] | 653 | return self._properties[property_name] |
| 654 | |
| 655 | def IsTextFile(self): |
| 656 | if self._is_text_file is None: |
| 657 | if self.Action() == 'D': |
| 658 | # A deleted file is not a text file. |
| 659 | self._is_text_file = False |
| 660 | elif self.IsDirectory(): |
| 661 | self._is_text_file = False |
| 662 | else: |
maruel@chromium.org | c70a220 | 2009-06-17 12:55:10 +0000 | [diff] [blame] | 663 | self._is_text_file = os.path.isfile(self.AbsoluteLocalPath()) |
| 664 | return self._is_text_file |
| 665 | |
maruel@chromium.org | ab05d58 | 2011-02-09 23:41:22 +0000 | [diff] [blame] | 666 | def GenerateScmDiff(self): |
maruel@chromium.org | 3bbf294 | 2012-01-10 16:52:06 +0000 | [diff] [blame] | 667 | if self._diff is None: |
| 668 | self._diff = scm.GIT.GenerateDiff( |
| 669 | self._local_root, files=[self.LocalPath(),]) |
| 670 | return self._diff |
maruel@chromium.org | c70a220 | 2009-06-17 12:55:10 +0000 | [diff] [blame] | 671 | |
maruel@chromium.org | c193875 | 2011-04-12 23:11:13 +0000 | [diff] [blame] | 672 | |
maruel@chromium.org | 4ff922a | 2009-06-12 20:20:19 +0000 | [diff] [blame] | 673 | class Change(object): |
maruel@chromium.org | 6ebe68a | 2009-05-27 23:43:40 +0000 | [diff] [blame] | 674 | """Describe a change. |
| 675 | |
| 676 | Used directly by the presubmit scripts to query the current change being |
| 677 | tested. |
thestig@chromium.org | da8cddd | 2009-08-13 00:25:55 +0000 | [diff] [blame] | 678 | |
maruel@chromium.org | 6ebe68a | 2009-05-27 23:43:40 +0000 | [diff] [blame] | 679 | Instance members: |
| 680 | tags: Dictionnary of KEY=VALUE pairs found in the change description. |
| 681 | self.KEY: equivalent to tags['KEY'] |
| 682 | """ |
| 683 | |
maruel@chromium.org | 4ff922a | 2009-06-12 20:20:19 +0000 | [diff] [blame] | 684 | _AFFECTED_FILES = AffectedFile |
| 685 | |
maruel@chromium.org | 6ebe68a | 2009-05-27 23:43:40 +0000 | [diff] [blame] | 686 | # Matches key/value (or "tag") lines in changelist descriptions. |
maruel@chromium.org | 428342a | 2011-11-10 15:46:33 +0000 | [diff] [blame] | 687 | TAG_LINE_RE = re.compile( |
maruel@chromium.org | 6ebe68a | 2009-05-27 23:43:40 +0000 | [diff] [blame] | 688 | '^\s*(?P<key>[A-Z][A-Z_0-9]*)\s*=\s*(?P<value>.*?)\s*$') |
maruel@chromium.org | c193875 | 2011-04-12 23:11:13 +0000 | [diff] [blame] | 689 | scm = '' |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 690 | |
maruel@chromium.org | 58407af | 2011-04-12 23:15:57 +0000 | [diff] [blame] | 691 | def __init__( |
| 692 | self, name, description, local_root, files, issue, patchset, author): |
maruel@chromium.org | 4ff922a | 2009-06-12 20:20:19 +0000 | [diff] [blame] | 693 | if files is None: |
| 694 | files = [] |
| 695 | self._name = name |
| 696 | self._full_description = description |
chase@chromium.org | 8e416c8 | 2009-10-06 04:30:44 +0000 | [diff] [blame] | 697 | # Convert root into an absolute path. |
| 698 | self._local_root = os.path.abspath(local_root) |
maruel@chromium.org | 4ff922a | 2009-06-12 20:20:19 +0000 | [diff] [blame] | 699 | self.issue = issue |
| 700 | self.patchset = patchset |
maruel@chromium.org | 58407af | 2011-04-12 23:15:57 +0000 | [diff] [blame] | 701 | self.author_email = author |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 702 | |
| 703 | # From the description text, build up a dictionary of key/value pairs |
| 704 | # plus the description minus all key/value or "tag" lines. |
maruel@chromium.org | fa41037 | 2010-09-10 17:01:01 +0000 | [diff] [blame] | 705 | description_without_tags = [] |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 706 | self.tags = {} |
maruel@chromium.org | 8d5c9a5 | 2009-06-12 15:59:08 +0000 | [diff] [blame] | 707 | for line in self._full_description.splitlines(): |
maruel@chromium.org | 428342a | 2011-11-10 15:46:33 +0000 | [diff] [blame] | 708 | m = self.TAG_LINE_RE.match(line) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 709 | if m: |
| 710 | self.tags[m.group('key')] = m.group('value') |
| 711 | else: |
maruel@chromium.org | fa41037 | 2010-09-10 17:01:01 +0000 | [diff] [blame] | 712 | description_without_tags.append(line) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 713 | |
| 714 | # Change back to text and remove whitespace at end. |
maruel@chromium.org | fa41037 | 2010-09-10 17:01:01 +0000 | [diff] [blame] | 715 | self._description_without_tags = ( |
| 716 | '\n'.join(description_without_tags).rstrip()) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 717 | |
maruel@chromium.org | e085d81 | 2011-10-10 19:49:15 +0000 | [diff] [blame] | 718 | assert all( |
| 719 | (isinstance(f, (list, tuple)) and len(f) == 2) for f in files), files |
| 720 | |
maruel@chromium.org | 6ebe68a | 2009-05-27 23:43:40 +0000 | [diff] [blame] | 721 | self._affected_files = [ |
maruel@chromium.org | 4ff922a | 2009-06-12 20:20:19 +0000 | [diff] [blame] | 722 | self._AFFECTED_FILES(info[1], info[0].strip(), self._local_root) |
| 723 | for info in files |
maruel@chromium.org | dbbeedc | 2009-05-22 20:26:17 +0000 | [diff] [blame] | 724 | ] |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 725 | |
maruel@chromium.org | 92022ec | 2009-06-11 01:59:28 +0000 | [diff] [blame] | 726 | def Name(self): |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 727 | """Returns the change name.""" |
maruel@chromium.org | 6ebe68a | 2009-05-27 23:43:40 +0000 | [diff] [blame] | 728 | return self._name |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 729 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 730 | def DescriptionText(self): |
| 731 | """Returns the user-entered changelist description, minus tags. |
| 732 | |
| 733 | Any line in the user-provided description starting with e.g. "FOO=" |
| 734 | (whitespace permitted before and around) is considered a tag line. Such |
| 735 | lines are stripped out of the description this function returns. |
| 736 | """ |
maruel@chromium.org | 6ebe68a | 2009-05-27 23:43:40 +0000 | [diff] [blame] | 737 | return self._description_without_tags |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 738 | |
| 739 | def FullDescriptionText(self): |
| 740 | """Returns the complete changelist description including tags.""" |
maruel@chromium.org | 6ebe68a | 2009-05-27 23:43:40 +0000 | [diff] [blame] | 741 | return self._full_description |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 742 | |
| 743 | def RepositoryRoot(self): |
maruel@chromium.org | 92022ec | 2009-06-11 01:59:28 +0000 | [diff] [blame] | 744 | """Returns the repository (checkout) root directory for this change, |
| 745 | as an absolute path. |
| 746 | """ |
maruel@chromium.org | 4ff922a | 2009-06-12 20:20:19 +0000 | [diff] [blame] | 747 | return self._local_root |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 748 | |
| 749 | def __getattr__(self, attr): |
maruel@chromium.org | 92022ec | 2009-06-11 01:59:28 +0000 | [diff] [blame] | 750 | """Return tags directly as attributes on the object.""" |
| 751 | if not re.match(r"^[A-Z_]*$", attr): |
| 752 | raise AttributeError(self, attr) |
maruel@chromium.org | e1a524f | 2009-05-27 14:43:46 +0000 | [diff] [blame] | 753 | return self.tags.get(attr) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 754 | |
sail@chromium.org | 5538e02 | 2011-05-12 17:53:16 +0000 | [diff] [blame] | 755 | def AffectedFiles(self, include_dirs=False, include_deletes=True, |
| 756 | file_filter=None): |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 757 | """Returns a list of AffectedFile instances for all files in the change. |
| 758 | |
| 759 | Args: |
| 760 | include_deletes: If false, deleted files will be filtered out. |
| 761 | include_dirs: True to include directories in the list |
sail@chromium.org | 5538e02 | 2011-05-12 17:53:16 +0000 | [diff] [blame] | 762 | file_filter: An additional filter to apply. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 763 | |
| 764 | Returns: |
| 765 | [AffectedFile(path, action), AffectedFile(path, action)] |
| 766 | """ |
| 767 | if include_dirs: |
maruel@chromium.org | 6ebe68a | 2009-05-27 23:43:40 +0000 | [diff] [blame] | 768 | affected = self._affected_files |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 769 | else: |
maruel@chromium.org | 6ebe68a | 2009-05-27 23:43:40 +0000 | [diff] [blame] | 770 | affected = filter(lambda x: not x.IsDirectory(), self._affected_files) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 771 | |
sail@chromium.org | 5538e02 | 2011-05-12 17:53:16 +0000 | [diff] [blame] | 772 | affected = filter(file_filter, affected) |
| 773 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 774 | if include_deletes: |
| 775 | return affected |
| 776 | else: |
| 777 | return filter(lambda x: x.Action() != 'D', affected) |
| 778 | |
maruel@chromium.org | 77c4f0f | 2009-05-29 18:53:04 +0000 | [diff] [blame] | 779 | def AffectedTextFiles(self, include_deletes=None): |
| 780 | """Return a list of the existing text files in a change.""" |
| 781 | if include_deletes is not None: |
maruel@chromium.org | cb2985f | 2010-11-03 14:08:31 +0000 | [diff] [blame] | 782 | warn("AffectedTextFiles(include_deletes=%s)" |
| 783 | " is deprecated and ignored" % str(include_deletes), |
| 784 | category=DeprecationWarning, |
| 785 | stacklevel=2) |
maruel@chromium.org | 77c4f0f | 2009-05-29 18:53:04 +0000 | [diff] [blame] | 786 | return filter(lambda x: x.IsTextFile(), |
| 787 | self.AffectedFiles(include_dirs=False, include_deletes=False)) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 788 | |
| 789 | def LocalPaths(self, include_dirs=False): |
| 790 | """Convenience function.""" |
| 791 | return [af.LocalPath() for af in self.AffectedFiles(include_dirs)] |
| 792 | |
| 793 | def AbsoluteLocalPaths(self, include_dirs=False): |
| 794 | """Convenience function.""" |
| 795 | return [af.AbsoluteLocalPath() for af in self.AffectedFiles(include_dirs)] |
| 796 | |
| 797 | def ServerPaths(self, include_dirs=False): |
| 798 | """Convenience function.""" |
| 799 | return [af.ServerPath() for af in self.AffectedFiles(include_dirs)] |
| 800 | |
| 801 | def RightHandSideLines(self): |
| 802 | """An iterator over all text lines in "new" version of changed files. |
| 803 | |
| 804 | Lists lines from new or modified text files in the change. |
| 805 | |
| 806 | This is useful for doing line-by-line regex checks, like checking for |
| 807 | trailing whitespace. |
| 808 | |
| 809 | Yields: |
| 810 | a 3 tuple: |
| 811 | the AffectedFile instance of the current file; |
| 812 | integer line number (1-based); and |
| 813 | the contents of the line as a string. |
| 814 | """ |
maruel@chromium.org | cb2985f | 2010-11-03 14:08:31 +0000 | [diff] [blame] | 815 | return _RightHandSideLinesImpl( |
| 816 | x for x in self.AffectedFiles(include_deletes=False) |
| 817 | if x.IsTextFile()) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 818 | |
| 819 | |
maruel@chromium.org | 4ff922a | 2009-06-12 20:20:19 +0000 | [diff] [blame] | 820 | class SvnChange(Change): |
| 821 | _AFFECTED_FILES = SvnAffectedFile |
maruel@chromium.org | c193875 | 2011-04-12 23:11:13 +0000 | [diff] [blame] | 822 | scm = 'svn' |
| 823 | _changelists = None |
thestig@chromium.org | 6bd3170 | 2009-09-02 23:29:07 +0000 | [diff] [blame] | 824 | |
| 825 | def _GetChangeLists(self): |
| 826 | """Get all change lists.""" |
| 827 | if self._changelists == None: |
| 828 | previous_cwd = os.getcwd() |
| 829 | os.chdir(self.RepositoryRoot()) |
maruel@chromium.org | cb2985f | 2010-11-03 14:08:31 +0000 | [diff] [blame] | 830 | # Need to import here to avoid circular dependency. |
| 831 | import gcl |
thestig@chromium.org | 6bd3170 | 2009-09-02 23:29:07 +0000 | [diff] [blame] | 832 | self._changelists = gcl.GetModifiedFiles() |
| 833 | os.chdir(previous_cwd) |
| 834 | return self._changelists |
thestig@chromium.org | da8cddd | 2009-08-13 00:25:55 +0000 | [diff] [blame] | 835 | |
| 836 | def GetAllModifiedFiles(self): |
| 837 | """Get all modified files.""" |
thestig@chromium.org | 6bd3170 | 2009-09-02 23:29:07 +0000 | [diff] [blame] | 838 | changelists = self._GetChangeLists() |
thestig@chromium.org | da8cddd | 2009-08-13 00:25:55 +0000 | [diff] [blame] | 839 | all_modified_files = [] |
| 840 | for cl in changelists.values(): |
thestig@chromium.org | 6bd3170 | 2009-09-02 23:29:07 +0000 | [diff] [blame] | 841 | all_modified_files.extend( |
| 842 | [os.path.join(self.RepositoryRoot(), f[1]) for f in cl]) |
thestig@chromium.org | da8cddd | 2009-08-13 00:25:55 +0000 | [diff] [blame] | 843 | return all_modified_files |
| 844 | |
| 845 | def GetModifiedFiles(self): |
| 846 | """Get modified files in the current CL.""" |
thestig@chromium.org | 6bd3170 | 2009-09-02 23:29:07 +0000 | [diff] [blame] | 847 | changelists = self._GetChangeLists() |
| 848 | return [os.path.join(self.RepositoryRoot(), f[1]) |
| 849 | for f in changelists[self.Name()]] |
thestig@chromium.org | da8cddd | 2009-08-13 00:25:55 +0000 | [diff] [blame] | 850 | |
maruel@chromium.org | 4ff922a | 2009-06-12 20:20:19 +0000 | [diff] [blame] | 851 | |
maruel@chromium.org | c70a220 | 2009-06-17 12:55:10 +0000 | [diff] [blame] | 852 | class GitChange(Change): |
| 853 | _AFFECTED_FILES = GitAffectedFile |
maruel@chromium.org | c193875 | 2011-04-12 23:11:13 +0000 | [diff] [blame] | 854 | scm = 'git' |
thestig@chromium.org | da8cddd | 2009-08-13 00:25:55 +0000 | [diff] [blame] | 855 | |
maruel@chromium.org | c70a220 | 2009-06-17 12:55:10 +0000 | [diff] [blame] | 856 | |
maruel@chromium.org | 4661e0c | 2009-06-04 00:45:26 +0000 | [diff] [blame] | 857 | def ListRelevantPresubmitFiles(files, root): |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 858 | """Finds all presubmit files that apply to a given set of source files. |
| 859 | |
maruel@chromium.org | b1901a6 | 2010-06-16 00:18:47 +0000 | [diff] [blame] | 860 | If inherit-review-settings-ok is present right under root, looks for |
| 861 | PRESUBMIT.py in directories enclosing root. |
| 862 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 863 | Args: |
| 864 | files: An iterable container containing file paths. |
maruel@chromium.org | 4661e0c | 2009-06-04 00:45:26 +0000 | [diff] [blame] | 865 | root: Path where to stop searching. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 866 | |
| 867 | Return: |
maruel@chromium.org | 4661e0c | 2009-06-04 00:45:26 +0000 | [diff] [blame] | 868 | List of absolute paths of the existing PRESUBMIT.py scripts. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 869 | """ |
maruel@chromium.org | b1901a6 | 2010-06-16 00:18:47 +0000 | [diff] [blame] | 870 | files = [normpath(os.path.join(root, f)) for f in files] |
| 871 | |
| 872 | # List all the individual directories containing files. |
| 873 | directories = set([os.path.dirname(f) for f in files]) |
| 874 | |
| 875 | # Ignore root if inherit-review-settings-ok is present. |
| 876 | if os.path.isfile(os.path.join(root, 'inherit-review-settings-ok')): |
| 877 | root = None |
| 878 | |
| 879 | # Collect all unique directories that may contain PRESUBMIT.py. |
| 880 | candidates = set() |
| 881 | for directory in directories: |
| 882 | while True: |
| 883 | if directory in candidates: |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 884 | break |
maruel@chromium.org | b1901a6 | 2010-06-16 00:18:47 +0000 | [diff] [blame] | 885 | candidates.add(directory) |
| 886 | if directory == root: |
maruel@chromium.org | 4661e0c | 2009-06-04 00:45:26 +0000 | [diff] [blame] | 887 | break |
maruel@chromium.org | b1901a6 | 2010-06-16 00:18:47 +0000 | [diff] [blame] | 888 | parent_dir = os.path.dirname(directory) |
| 889 | if parent_dir == directory: |
| 890 | # We hit the system root directory. |
| 891 | break |
| 892 | directory = parent_dir |
| 893 | |
| 894 | # Look for PRESUBMIT.py in all candidate directories. |
| 895 | results = [] |
| 896 | for directory in sorted(list(candidates)): |
| 897 | p = os.path.join(directory, 'PRESUBMIT.py') |
| 898 | if os.path.isfile(p): |
| 899 | results.append(p) |
| 900 | |
maruel@chromium.org | 5d0dc43 | 2011-01-03 02:40:37 +0000 | [diff] [blame] | 901 | logging.debug('Presubmit files: %s' % ','.join(results)) |
maruel@chromium.org | b1901a6 | 2010-06-16 00:18:47 +0000 | [diff] [blame] | 902 | return results |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 903 | |
| 904 | |
thestig@chromium.org | de24345 | 2009-10-06 21:02:56 +0000 | [diff] [blame] | 905 | class GetTrySlavesExecuter(object): |
maruel@chromium.org | cb2985f | 2010-11-03 14:08:31 +0000 | [diff] [blame] | 906 | @staticmethod |
asvitkine@chromium.org | 1516995 | 2011-09-27 14:30:53 +0000 | [diff] [blame] | 907 | def ExecPresubmitScript(script_text, presubmit_path, project, change): |
thestig@chromium.org | de24345 | 2009-10-06 21:02:56 +0000 | [diff] [blame] | 908 | """Executes GetPreferredTrySlaves() from a single presubmit script. |
| 909 | |
| 910 | Args: |
| 911 | script_text: The text of the presubmit script. |
bradnelson@google.com | 7823002 | 2011-05-24 18:55:19 +0000 | [diff] [blame] | 912 | presubmit_path: Project script to run. |
| 913 | project: Project name to pass to presubmit script for bot selection. |
thestig@chromium.org | de24345 | 2009-10-06 21:02:56 +0000 | [diff] [blame] | 914 | |
| 915 | Return: |
| 916 | A list of try slaves. |
| 917 | """ |
| 918 | context = {} |
maruel@chromium.org | 899e1c1 | 2011-04-07 17:03:18 +0000 | [diff] [blame] | 919 | try: |
| 920 | exec script_text in context |
| 921 | except Exception, e: |
| 922 | raise PresubmitFailure('"%s" had an exception.\n%s' % (presubmit_path, e)) |
thestig@chromium.org | de24345 | 2009-10-06 21:02:56 +0000 | [diff] [blame] | 923 | |
| 924 | function_name = 'GetPreferredTrySlaves' |
| 925 | if function_name in context: |
asvitkine@chromium.org | 1516995 | 2011-09-27 14:30:53 +0000 | [diff] [blame] | 926 | get_preferred_try_slaves = context[function_name] |
| 927 | function_info = inspect.getargspec(get_preferred_try_slaves) |
| 928 | if len(function_info[0]) == 1: |
| 929 | result = get_preferred_try_slaves(project) |
| 930 | elif len(function_info[0]) == 2: |
| 931 | result = get_preferred_try_slaves(project, change) |
| 932 | else: |
| 933 | result = get_preferred_try_slaves() |
thestig@chromium.org | de24345 | 2009-10-06 21:02:56 +0000 | [diff] [blame] | 934 | if not isinstance(result, types.ListType): |
maruel@chromium.org | 899e1c1 | 2011-04-07 17:03:18 +0000 | [diff] [blame] | 935 | raise PresubmitFailure( |
thestig@chromium.org | de24345 | 2009-10-06 21:02:56 +0000 | [diff] [blame] | 936 | 'Presubmit functions must return a list, got a %s instead: %s' % |
| 937 | (type(result), str(result))) |
| 938 | for item in result: |
| 939 | if not isinstance(item, basestring): |
maruel@chromium.org | 899e1c1 | 2011-04-07 17:03:18 +0000 | [diff] [blame] | 940 | raise PresubmitFailure('All try slaves names must be strings.') |
thestig@chromium.org | de24345 | 2009-10-06 21:02:56 +0000 | [diff] [blame] | 941 | if item != item.strip(): |
maruel@chromium.org | 899e1c1 | 2011-04-07 17:03:18 +0000 | [diff] [blame] | 942 | raise PresubmitFailure( |
| 943 | 'Try slave names cannot start/end with whitespace') |
maruel@chromium.org | 3ecc8ea | 2012-03-10 01:47:46 +0000 | [diff] [blame] | 944 | if ',' in item: |
| 945 | raise PresubmitFailure( |
| 946 | 'Do not use \',\' separated builder or test names: %s' % item) |
thestig@chromium.org | de24345 | 2009-10-06 21:02:56 +0000 | [diff] [blame] | 947 | else: |
| 948 | result = [] |
| 949 | return result |
| 950 | |
| 951 | |
asvitkine@chromium.org | 1516995 | 2011-09-27 14:30:53 +0000 | [diff] [blame] | 952 | def DoGetTrySlaves(change, |
| 953 | changed_files, |
thestig@chromium.org | de24345 | 2009-10-06 21:02:56 +0000 | [diff] [blame] | 954 | repository_root, |
| 955 | default_presubmit, |
bradnelson@google.com | 7823002 | 2011-05-24 18:55:19 +0000 | [diff] [blame] | 956 | project, |
thestig@chromium.org | de24345 | 2009-10-06 21:02:56 +0000 | [diff] [blame] | 957 | verbose, |
| 958 | output_stream): |
| 959 | """Get the list of try servers from the presubmit scripts. |
| 960 | |
| 961 | Args: |
| 962 | changed_files: List of modified files. |
| 963 | repository_root: The repository root. |
| 964 | default_presubmit: A default presubmit script to execute in any case. |
bradnelson@google.com | 7823002 | 2011-05-24 18:55:19 +0000 | [diff] [blame] | 965 | project: Optional name of a project used in selecting trybots. |
thestig@chromium.org | de24345 | 2009-10-06 21:02:56 +0000 | [diff] [blame] | 966 | verbose: Prints debug info. |
| 967 | output_stream: A stream to write debug output to. |
| 968 | |
| 969 | Return: |
| 970 | List of try slaves |
| 971 | """ |
| 972 | presubmit_files = ListRelevantPresubmitFiles(changed_files, repository_root) |
| 973 | if not presubmit_files and verbose: |
| 974 | output_stream.write("Warning, no presubmit.py found.\n") |
| 975 | results = [] |
| 976 | executer = GetTrySlavesExecuter() |
| 977 | if default_presubmit: |
| 978 | if verbose: |
| 979 | output_stream.write("Running default presubmit script.\n") |
maruel@chromium.org | 899e1c1 | 2011-04-07 17:03:18 +0000 | [diff] [blame] | 980 | fake_path = os.path.join(repository_root, 'PRESUBMIT.py') |
bradnelson@google.com | 7823002 | 2011-05-24 18:55:19 +0000 | [diff] [blame] | 981 | results += executer.ExecPresubmitScript( |
asvitkine@chromium.org | 1516995 | 2011-09-27 14:30:53 +0000 | [diff] [blame] | 982 | default_presubmit, fake_path, project, change) |
thestig@chromium.org | de24345 | 2009-10-06 21:02:56 +0000 | [diff] [blame] | 983 | for filename in presubmit_files: |
| 984 | filename = os.path.abspath(filename) |
| 985 | if verbose: |
| 986 | output_stream.write("Running %s\n" % filename) |
| 987 | # Accept CRLF presubmit script. |
maruel@chromium.org | 5aeb7dd | 2009-11-17 18:09:01 +0000 | [diff] [blame] | 988 | presubmit_script = gclient_utils.FileRead(filename, 'rU') |
bradnelson@google.com | 7823002 | 2011-05-24 18:55:19 +0000 | [diff] [blame] | 989 | results += executer.ExecPresubmitScript( |
asvitkine@chromium.org | 1516995 | 2011-09-27 14:30:53 +0000 | [diff] [blame] | 990 | presubmit_script, filename, project, change) |
thestig@chromium.org | de24345 | 2009-10-06 21:02:56 +0000 | [diff] [blame] | 991 | |
| 992 | slaves = list(set(results)) |
| 993 | if slaves and verbose: |
| 994 | output_stream.write(', '.join(slaves)) |
| 995 | output_stream.write('\n') |
| 996 | return slaves |
| 997 | |
| 998 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 999 | class PresubmitExecuter(object): |
maruel@chromium.org | cc73ad6 | 2011-07-06 17:39:26 +0000 | [diff] [blame] | 1000 | def __init__(self, change, committing, rietveld_obj, verbose): |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1001 | """ |
| 1002 | Args: |
maruel@chromium.org | 4ff922a | 2009-06-12 20:20:19 +0000 | [diff] [blame] | 1003 | change: The Change object. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1004 | committing: True if 'gcl commit' is running, False if 'gcl upload' is. |
maruel@chromium.org | 239f411 | 2011-06-03 20:08:23 +0000 | [diff] [blame] | 1005 | rietveld_obj: rietveld.Rietveld client object. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1006 | """ |
maruel@chromium.org | 4ff922a | 2009-06-12 20:20:19 +0000 | [diff] [blame] | 1007 | self.change = change |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1008 | self.committing = committing |
maruel@chromium.org | 239f411 | 2011-06-03 20:08:23 +0000 | [diff] [blame] | 1009 | self.rietveld = rietveld_obj |
maruel@chromium.org | 899e1c1 | 2011-04-07 17:03:18 +0000 | [diff] [blame] | 1010 | self.verbose = verbose |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1011 | |
| 1012 | def ExecPresubmitScript(self, script_text, presubmit_path): |
| 1013 | """Executes a single presubmit script. |
| 1014 | |
| 1015 | Args: |
| 1016 | script_text: The text of the presubmit script. |
| 1017 | presubmit_path: The path to the presubmit file (this will be reported via |
| 1018 | input_api.PresubmitLocalPath()). |
| 1019 | |
| 1020 | Return: |
| 1021 | A list of result objects, empty if no problems. |
| 1022 | """ |
chase@chromium.org | 8e416c8 | 2009-10-06 04:30:44 +0000 | [diff] [blame] | 1023 | |
| 1024 | # Change to the presubmit file's directory to support local imports. |
| 1025 | main_path = os.getcwd() |
| 1026 | os.chdir(os.path.dirname(presubmit_path)) |
| 1027 | |
| 1028 | # Load the presubmit script into context. |
dpranke@chromium.org | 970c522 | 2011-03-12 00:32:24 +0000 | [diff] [blame] | 1029 | input_api = InputApi(self.change, presubmit_path, self.committing, |
maruel@chromium.org | cc73ad6 | 2011-07-06 17:39:26 +0000 | [diff] [blame] | 1030 | self.rietveld, self.verbose) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1031 | context = {} |
maruel@chromium.org | 899e1c1 | 2011-04-07 17:03:18 +0000 | [diff] [blame] | 1032 | try: |
| 1033 | exec script_text in context |
| 1034 | except Exception, e: |
| 1035 | raise PresubmitFailure('"%s" had an exception.\n%s' % (presubmit_path, e)) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1036 | |
| 1037 | # These function names must change if we make substantial changes to |
| 1038 | # the presubmit API that are not backwards compatible. |
| 1039 | if self.committing: |
| 1040 | function_name = 'CheckChangeOnCommit' |
| 1041 | else: |
| 1042 | function_name = 'CheckChangeOnUpload' |
| 1043 | if function_name in context: |
wez@chromium.org | a6d011e | 2013-03-26 17:31:49 +0000 | [diff] [blame] | 1044 | context['__args'] = (input_api, OutputApi(self.committing)) |
maruel@chromium.org | 5d0dc43 | 2011-01-03 02:40:37 +0000 | [diff] [blame] | 1045 | logging.debug('Running %s in %s' % (function_name, presubmit_path)) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1046 | result = eval(function_name + '(*__args)', context) |
maruel@chromium.org | 5d0dc43 | 2011-01-03 02:40:37 +0000 | [diff] [blame] | 1047 | logging.debug('Running %s done.' % function_name) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1048 | if not (isinstance(result, types.TupleType) or |
| 1049 | isinstance(result, types.ListType)): |
maruel@chromium.org | 899e1c1 | 2011-04-07 17:03:18 +0000 | [diff] [blame] | 1050 | raise PresubmitFailure( |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1051 | 'Presubmit functions must return a tuple or list') |
| 1052 | for item in result: |
| 1053 | if not isinstance(item, OutputApi.PresubmitResult): |
maruel@chromium.org | 899e1c1 | 2011-04-07 17:03:18 +0000 | [diff] [blame] | 1054 | raise PresubmitFailure( |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1055 | 'All presubmit results must be of types derived from ' |
| 1056 | 'output_api.PresubmitResult') |
| 1057 | else: |
| 1058 | result = () # no error since the script doesn't care about current event. |
| 1059 | |
chase@chromium.org | 8e416c8 | 2009-10-06 04:30:44 +0000 | [diff] [blame] | 1060 | # Return the process to the original working directory. |
| 1061 | os.chdir(main_path) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1062 | return result |
| 1063 | |
dpranke@chromium.org | 5ac2101 | 2011-03-16 02:58:25 +0000 | [diff] [blame] | 1064 | |
maruel@chromium.org | 4ff922a | 2009-06-12 20:20:19 +0000 | [diff] [blame] | 1065 | def DoPresubmitChecks(change, |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1066 | committing, |
| 1067 | verbose, |
| 1068 | output_stream, |
maruel@chromium.org | 0ff1fab | 2009-05-22 13:08:15 +0000 | [diff] [blame] | 1069 | input_stream, |
maruel@chromium.org | b0dfd35 | 2009-06-10 14:12:54 +0000 | [diff] [blame] | 1070 | default_presubmit, |
dpranke@chromium.org | 970c522 | 2011-03-12 00:32:24 +0000 | [diff] [blame] | 1071 | may_prompt, |
maruel@chromium.org | 239f411 | 2011-06-03 20:08:23 +0000 | [diff] [blame] | 1072 | rietveld_obj): |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1073 | """Runs all presubmit checks that apply to the files in the change. |
| 1074 | |
| 1075 | This finds all PRESUBMIT.py files in directories enclosing the files in the |
| 1076 | change (up to the repository root) and calls the relevant entrypoint function |
| 1077 | depending on whether the change is being committed or uploaded. |
| 1078 | |
| 1079 | Prints errors, warnings and notifications. Prompts the user for warnings |
| 1080 | when needed. |
| 1081 | |
| 1082 | Args: |
maruel@chromium.org | 4ff922a | 2009-06-12 20:20:19 +0000 | [diff] [blame] | 1083 | change: The Change object. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1084 | committing: True if 'gcl commit' is running, False if 'gcl upload' is. |
| 1085 | verbose: Prints debug info. |
| 1086 | output_stream: A stream to write output from presubmit tests to. |
| 1087 | input_stream: A stream to read input from the user. |
maruel@chromium.org | 0ff1fab | 2009-05-22 13:08:15 +0000 | [diff] [blame] | 1088 | default_presubmit: A default presubmit script to execute in any case. |
maruel@chromium.org | b0dfd35 | 2009-06-10 14:12:54 +0000 | [diff] [blame] | 1089 | may_prompt: Enable (y/n) questions on warning or error. |
maruel@chromium.org | 239f411 | 2011-06-03 20:08:23 +0000 | [diff] [blame] | 1090 | rietveld_obj: rietveld.Rietveld object. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1091 | |
maruel@chromium.org | ce8e46b | 2009-06-26 22:31:51 +0000 | [diff] [blame] | 1092 | Warning: |
| 1093 | If may_prompt is true, output_stream SHOULD be sys.stdout and input_stream |
| 1094 | SHOULD be sys.stdin. |
| 1095 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1096 | Return: |
dpranke@chromium.org | 5ac2101 | 2011-03-16 02:58:25 +0000 | [diff] [blame] | 1097 | A PresubmitOutput object. Use output.should_continue() to figure out |
| 1098 | if there were errors or warnings and the caller should abort. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1099 | """ |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1100 | old_environ = os.environ |
| 1101 | try: |
| 1102 | # Make sure python subprocesses won't generate .pyc files. |
| 1103 | os.environ = os.environ.copy() |
| 1104 | os.environ['PYTHONDONTWRITEBYTECODE'] = '1' |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1105 | |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1106 | output = PresubmitOutput(input_stream, output_stream) |
| 1107 | if committing: |
| 1108 | output.write("Running presubmit commit checks ...\n") |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1109 | else: |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1110 | output.write("Running presubmit upload checks ...\n") |
| 1111 | start_time = time.time() |
| 1112 | presubmit_files = ListRelevantPresubmitFiles( |
| 1113 | change.AbsoluteLocalPaths(True), change.RepositoryRoot()) |
| 1114 | if not presubmit_files and verbose: |
maruel@chromium.org | fae707b | 2011-09-15 18:57:58 +0000 | [diff] [blame] | 1115 | output.write("Warning, no PRESUBMIT.py found.\n") |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1116 | results = [] |
maruel@chromium.org | cc73ad6 | 2011-07-06 17:39:26 +0000 | [diff] [blame] | 1117 | executer = PresubmitExecuter(change, committing, rietveld_obj, verbose) |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1118 | if default_presubmit: |
| 1119 | if verbose: |
| 1120 | output.write("Running default presubmit script.\n") |
| 1121 | fake_path = os.path.join(change.RepositoryRoot(), 'PRESUBMIT.py') |
| 1122 | results += executer.ExecPresubmitScript(default_presubmit, fake_path) |
| 1123 | for filename in presubmit_files: |
| 1124 | filename = os.path.abspath(filename) |
| 1125 | if verbose: |
| 1126 | output.write("Running %s\n" % filename) |
| 1127 | # Accept CRLF presubmit script. |
| 1128 | presubmit_script = gclient_utils.FileRead(filename, 'rU') |
| 1129 | results += executer.ExecPresubmitScript(presubmit_script, filename) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1130 | |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1131 | errors = [] |
| 1132 | notifications = [] |
| 1133 | warnings = [] |
| 1134 | for result in results: |
| 1135 | if result.fatal: |
| 1136 | errors.append(result) |
| 1137 | elif result.should_prompt: |
| 1138 | warnings.append(result) |
| 1139 | else: |
| 1140 | notifications.append(result) |
pam@chromium.org | ed9a083 | 2009-09-09 22:48:55 +0000 | [diff] [blame] | 1141 | |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1142 | output.write('\n') |
| 1143 | for name, items in (('Messages', notifications), |
| 1144 | ('Warnings', warnings), |
| 1145 | ('ERRORS', errors)): |
| 1146 | if items: |
| 1147 | output.write('** Presubmit %s **\n' % name) |
| 1148 | for item in items: |
| 1149 | item.handle(output) |
| 1150 | output.write('\n') |
pam@chromium.org | ed9a083 | 2009-09-09 22:48:55 +0000 | [diff] [blame] | 1151 | |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1152 | total_time = time.time() - start_time |
| 1153 | if total_time > 1.0: |
| 1154 | output.write("Presubmit checks took %.1fs to calculate.\n\n" % total_time) |
maruel@chromium.org | ce8e46b | 2009-06-26 22:31:51 +0000 | [diff] [blame] | 1155 | |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1156 | if not errors: |
| 1157 | if not warnings: |
| 1158 | output.write('Presubmit checks passed.\n') |
| 1159 | elif may_prompt: |
| 1160 | output.prompt_yes_no('There were presubmit warnings. ' |
| 1161 | 'Are you sure you wish to continue? (y/N): ') |
| 1162 | else: |
| 1163 | output.fail() |
| 1164 | |
| 1165 | global _ASKED_FOR_FEEDBACK |
| 1166 | # Ask for feedback one time out of 5. |
| 1167 | if (len(results) and random.randint(0, 4) == 0 and not _ASKED_FOR_FEEDBACK): |
| 1168 | output.write("Was the presubmit check useful? Please send feedback " |
| 1169 | "& hate mail to maruel@chromium.org!\n") |
| 1170 | _ASKED_FOR_FEEDBACK = True |
| 1171 | return output |
| 1172 | finally: |
| 1173 | os.environ = old_environ |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1174 | |
| 1175 | |
| 1176 | def ScanSubDirs(mask, recursive): |
| 1177 | if not recursive: |
maruel@chromium.org | c70a220 | 2009-06-17 12:55:10 +0000 | [diff] [blame] | 1178 | return [x for x in glob.glob(mask) if '.svn' not in x and '.git' not in x] |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1179 | else: |
| 1180 | results = [] |
| 1181 | for root, dirs, files in os.walk('.'): |
| 1182 | if '.svn' in dirs: |
| 1183 | dirs.remove('.svn') |
maruel@chromium.org | c70a220 | 2009-06-17 12:55:10 +0000 | [diff] [blame] | 1184 | if '.git' in dirs: |
| 1185 | dirs.remove('.git') |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1186 | for name in files: |
| 1187 | if fnmatch.fnmatch(name, mask): |
| 1188 | results.append(os.path.join(root, name)) |
| 1189 | return results |
| 1190 | |
| 1191 | |
| 1192 | def ParseFiles(args, recursive): |
maruel@chromium.org | 7444c50 | 2011-02-09 14:02:11 +0000 | [diff] [blame] | 1193 | logging.debug('Searching for %s' % args) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1194 | files = [] |
| 1195 | for arg in args: |
maruel@chromium.org | e3608df | 2009-11-10 20:22:57 +0000 | [diff] [blame] | 1196 | files.extend([('M', f) for f in ScanSubDirs(arg, recursive)]) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1197 | return files |
| 1198 | |
| 1199 | |
maruel@chromium.org | 5c8c6de | 2011-03-18 16:20:18 +0000 | [diff] [blame] | 1200 | def load_files(options, args): |
| 1201 | """Tries to determine the SCM.""" |
| 1202 | change_scm = scm.determine_scm(options.root) |
| 1203 | files = [] |
maruel@chromium.org | 5c8c6de | 2011-03-18 16:20:18 +0000 | [diff] [blame] | 1204 | if args: |
| 1205 | files = ParseFiles(args, options.recursive) |
maruel@chromium.org | 9b31f16 | 2012-01-26 19:02:31 +0000 | [diff] [blame] | 1206 | if change_scm == 'svn': |
| 1207 | change_class = SvnChange |
| 1208 | if not files: |
| 1209 | files = scm.SVN.CaptureStatus([], options.root) |
| 1210 | elif change_scm == 'git': |
| 1211 | change_class = GitChange |
| 1212 | # TODO(maruel): Get upstream. |
| 1213 | if not files: |
| 1214 | files = scm.GIT.CaptureStatus([], options.root, None) |
maruel@chromium.org | 5c8c6de | 2011-03-18 16:20:18 +0000 | [diff] [blame] | 1215 | else: |
maruel@chromium.org | 9b31f16 | 2012-01-26 19:02:31 +0000 | [diff] [blame] | 1216 | logging.info('Doesn\'t seem under source control. Got %d files' % len(args)) |
| 1217 | if not files: |
| 1218 | return None, None |
| 1219 | change_class = Change |
maruel@chromium.org | 5c8c6de | 2011-03-18 16:20:18 +0000 | [diff] [blame] | 1220 | return change_class, files |
| 1221 | |
| 1222 | |
iannucci@chromium.org | 8a4a2bc | 2013-03-08 08:13:20 +0000 | [diff] [blame] | 1223 | class NonexistantCannedCheckFilter(Exception): |
| 1224 | pass |
| 1225 | |
| 1226 | |
| 1227 | @contextlib.contextmanager |
| 1228 | def canned_check_filter(method_names): |
| 1229 | filtered = {} |
| 1230 | try: |
| 1231 | for method_name in method_names: |
| 1232 | if not hasattr(presubmit_canned_checks, method_name): |
| 1233 | raise NonexistantCannedCheckFilter(method_name) |
| 1234 | filtered[method_name] = getattr(presubmit_canned_checks, method_name) |
| 1235 | setattr(presubmit_canned_checks, method_name, lambda *_a, **_kw: []) |
| 1236 | yield |
| 1237 | finally: |
| 1238 | for name, method in filtered.iteritems(): |
| 1239 | setattr(presubmit_canned_checks, name, method) |
| 1240 | |
| 1241 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1242 | def Main(argv): |
maruel@chromium.org | 5c8c6de | 2011-03-18 16:20:18 +0000 | [diff] [blame] | 1243 | parser = optparse.OptionParser(usage="%prog [options] <files...>", |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1244 | version="%prog " + str(__version__)) |
maruel@chromium.org | c70a220 | 2009-06-17 12:55:10 +0000 | [diff] [blame] | 1245 | parser.add_option("-c", "--commit", action="store_true", default=False, |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1246 | help="Use commit instead of upload checks") |
maruel@chromium.org | c70a220 | 2009-06-17 12:55:10 +0000 | [diff] [blame] | 1247 | parser.add_option("-u", "--upload", action="store_false", dest='commit', |
| 1248 | help="Use upload instead of commit checks") |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1249 | parser.add_option("-r", "--recursive", action="store_true", |
| 1250 | help="Act recursively") |
maruel@chromium.org | 899e1c1 | 2011-04-07 17:03:18 +0000 | [diff] [blame] | 1251 | parser.add_option("-v", "--verbose", action="count", default=0, |
| 1252 | help="Use 2 times for more debug info") |
maruel@chromium.org | 4ff922a | 2009-06-12 20:20:19 +0000 | [diff] [blame] | 1253 | parser.add_option("--name", default='no name') |
maruel@chromium.org | 58407af | 2011-04-12 23:15:57 +0000 | [diff] [blame] | 1254 | parser.add_option("--author") |
maruel@chromium.org | 4ff922a | 2009-06-12 20:20:19 +0000 | [diff] [blame] | 1255 | parser.add_option("--description", default='') |
| 1256 | parser.add_option("--issue", type='int', default=0) |
| 1257 | parser.add_option("--patchset", type='int', default=0) |
maruel@chromium.org | b1901a6 | 2010-06-16 00:18:47 +0000 | [diff] [blame] | 1258 | parser.add_option("--root", default=os.getcwd(), |
| 1259 | help="Search for PRESUBMIT.py up to this directory. " |
| 1260 | "If inherit-review-settings-ok is present in this " |
| 1261 | "directory, parent directories up to the root file " |
| 1262 | "system directories will also be searched.") |
maruel@chromium.org | c70a220 | 2009-06-17 12:55:10 +0000 | [diff] [blame] | 1263 | parser.add_option("--default_presubmit") |
| 1264 | parser.add_option("--may_prompt", action='store_true', default=False) |
iannucci@chromium.org | 8a4a2bc | 2013-03-08 08:13:20 +0000 | [diff] [blame] | 1265 | parser.add_option("--skip_canned", action='append', default=[], |
| 1266 | help="A list of checks to skip which appear in " |
| 1267 | "presubmit_canned_checks. Can be provided multiple times " |
| 1268 | "to skip multiple canned checks.") |
maruel@chromium.org | 239f411 | 2011-06-03 20:08:23 +0000 | [diff] [blame] | 1269 | parser.add_option("--rietveld_url", help=optparse.SUPPRESS_HELP) |
| 1270 | parser.add_option("--rietveld_email", help=optparse.SUPPRESS_HELP) |
| 1271 | parser.add_option("--rietveld_password", help=optparse.SUPPRESS_HELP) |
maruel@chromium.org | 82e5f28 | 2011-03-17 14:08:55 +0000 | [diff] [blame] | 1272 | options, args = parser.parse_args(argv) |
maruel@chromium.org | 899e1c1 | 2011-04-07 17:03:18 +0000 | [diff] [blame] | 1273 | if options.verbose >= 2: |
maruel@chromium.org | 7444c50 | 2011-02-09 14:02:11 +0000 | [diff] [blame] | 1274 | logging.basicConfig(level=logging.DEBUG) |
maruel@chromium.org | 899e1c1 | 2011-04-07 17:03:18 +0000 | [diff] [blame] | 1275 | elif options.verbose: |
| 1276 | logging.basicConfig(level=logging.INFO) |
| 1277 | else: |
| 1278 | logging.basicConfig(level=logging.ERROR) |
maruel@chromium.org | 5c8c6de | 2011-03-18 16:20:18 +0000 | [diff] [blame] | 1279 | change_class, files = load_files(options, args) |
| 1280 | if not change_class: |
| 1281 | parser.error('For unversioned directory, <files> is not optional.') |
maruel@chromium.org | 899e1c1 | 2011-04-07 17:03:18 +0000 | [diff] [blame] | 1282 | logging.info('Found %d file(s).' % len(files)) |
maruel@chromium.org | 239f411 | 2011-06-03 20:08:23 +0000 | [diff] [blame] | 1283 | rietveld_obj = None |
| 1284 | if options.rietveld_url: |
maruel@chromium.org | 4bac4b5 | 2012-11-27 20:33:52 +0000 | [diff] [blame] | 1285 | rietveld_obj = rietveld.CachingRietveld( |
maruel@chromium.org | 239f411 | 2011-06-03 20:08:23 +0000 | [diff] [blame] | 1286 | options.rietveld_url, |
| 1287 | options.rietveld_email, |
| 1288 | options.rietveld_password) |
maruel@chromium.org | 899e1c1 | 2011-04-07 17:03:18 +0000 | [diff] [blame] | 1289 | try: |
iannucci@chromium.org | 8a4a2bc | 2013-03-08 08:13:20 +0000 | [diff] [blame] | 1290 | with canned_check_filter(options.skip_canned): |
| 1291 | results = DoPresubmitChecks( |
| 1292 | change_class(options.name, |
| 1293 | options.description, |
| 1294 | options.root, |
| 1295 | files, |
| 1296 | options.issue, |
| 1297 | options.patchset, |
| 1298 | options.author), |
| 1299 | options.commit, |
| 1300 | options.verbose, |
| 1301 | sys.stdout, |
| 1302 | sys.stdin, |
| 1303 | options.default_presubmit, |
| 1304 | options.may_prompt, |
| 1305 | rietveld_obj) |
maruel@chromium.org | 899e1c1 | 2011-04-07 17:03:18 +0000 | [diff] [blame] | 1306 | return not results.should_continue() |
iannucci@chromium.org | 8a4a2bc | 2013-03-08 08:13:20 +0000 | [diff] [blame] | 1307 | except NonexistantCannedCheckFilter, e: |
| 1308 | print >> sys.stderr, ( |
| 1309 | 'Attempted to skip nonexistent canned presubmit check: %s' % e.message) |
| 1310 | return 2 |
maruel@chromium.org | 899e1c1 | 2011-04-07 17:03:18 +0000 | [diff] [blame] | 1311 | except PresubmitFailure, e: |
| 1312 | print >> sys.stderr, e |
| 1313 | print >> sys.stderr, 'Maybe your depot_tools is out of date?' |
| 1314 | print >> sys.stderr, 'If all fails, contact maruel@' |
| 1315 | return 2 |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1316 | |
| 1317 | |
| 1318 | if __name__ == '__main__': |
maruel@chromium.org | 35625c7 | 2011-03-23 17:34:02 +0000 | [diff] [blame] | 1319 | fix_encoding.fix_encoding() |
maruel@chromium.org | 82e5f28 | 2011-03-17 14:08:55 +0000 | [diff] [blame] | 1320 | sys.exit(Main(None)) |