blob: d29dd388996ef8357210e1cc7e79e034cc8d14d7 [file] [log] [blame]
maruel@chromium.orgddd59412011-11-30 14:20:38 +00001#!/usr/bin/env python
maruel@chromium.orgeb5edbc2012-01-16 17:03:28 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Unit tests for git_cl.py."""
7
8import os
maruel@chromium.orga3353652011-11-30 14:26:57 +00009import StringIO
ukai@chromium.org78c4b982012-02-14 02:20:26 +000010import stat
maruel@chromium.orgddd59412011-11-30 14:20:38 +000011import sys
12import unittest
13
14sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
15
16from testing_support.auto_stub import TestCase
17
18import git_cl
19import subprocess2
20
21
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000022class PresubmitMock(object):
23 def __init__(self, *args, **kwargs):
24 self.reviewers = []
25 @staticmethod
26 def should_continue():
27 return True
28
29
30class RietveldMock(object):
31 def __init__(self, *args, **kwargs):
32 pass
maruel@chromium.org78936cb2013-04-11 00:17:52 +000033
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000034 @staticmethod
35 def get_description(issue):
36 return 'Issue: %d' % issue
37
maruel@chromium.org78936cb2013-04-11 00:17:52 +000038 @staticmethod
39 def get_issue_properties(_issue, _messages):
40 return {
41 'reviewers': ['joe@chromium.org', 'john@chromium.org'],
42 'messages': [
43 {
44 'approval': True,
45 'sender': 'john@chromium.org',
46 },
47 ],
48 }
49
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000050
51class WatchlistsMock(object):
52 def __init__(self, _):
53 pass
54 @staticmethod
55 def GetWatchersForPaths(_):
56 return ['joe@example.com']
57
58
ukai@chromium.org78c4b982012-02-14 02:20:26 +000059class CodereviewSettingsFileMock(object):
60 def __init__(self):
61 pass
62 # pylint: disable=R0201
63 def read(self):
64 return ("CODE_REVIEW_SERVER: gerrit.chromium.org\n" +
65 "GERRIT_HOST: gerrit.chromium.org\n" +
66 "GERRIT_PORT: 29418\n")
67
68
maruel@chromium.orgddd59412011-11-30 14:20:38 +000069class TestGitCl(TestCase):
70 def setUp(self):
71 super(TestGitCl, self).setUp()
72 self.calls = []
73 self._calls_done = 0
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000074 self.mock(subprocess2, 'call', self._mocked_call)
75 self.mock(subprocess2, 'check_call', self._mocked_call)
76 self.mock(subprocess2, 'check_output', self._mocked_call)
77 self.mock(subprocess2, 'communicate', self._mocked_call)
78 self.mock(subprocess2, 'Popen', self._mocked_call)
maruel@chromium.orgddd59412011-11-30 14:20:38 +000079 self.mock(git_cl, 'FindCodereviewSettingsFile', lambda: '')
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000080 self.mock(git_cl, 'ask_for_data', self._mocked_call)
81 self.mock(git_cl.breakpad, 'post', self._mocked_call)
82 self.mock(git_cl.breakpad, 'SendStack', self._mocked_call)
maruel@chromium.orgddd59412011-11-30 14:20:38 +000083 self.mock(git_cl.presubmit_support, 'DoPresubmitChecks', PresubmitMock)
maruel@chromium.orgddd59412011-11-30 14:20:38 +000084 self.mock(git_cl.rietveld, 'Rietveld', RietveldMock)
maruel@chromium.org4bac4b52012-11-27 20:33:52 +000085 self.mock(git_cl.rietveld, 'CachingRietveld', RietveldMock)
maruel@chromium.orgddd59412011-11-30 14:20:38 +000086 self.mock(git_cl.upload, 'RealMain', self.fail)
maruel@chromium.orgddd59412011-11-30 14:20:38 +000087 self.mock(git_cl.watchlists, 'Watchlists', WatchlistsMock)
88 # It's important to reset settings to not have inter-tests interference.
89 git_cl.settings = None
90
91 def tearDown(self):
92 if not self.has_failed():
93 self.assertEquals([], self.calls)
94 super(TestGitCl, self).tearDown()
95
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000096 def _mocked_call(self, *args, **kwargs):
97 self.assertTrue(
98 self.calls,
99 '@%d Expected: <Missing> Actual: %r' % (self._calls_done, args))
100 expected_args, result = self.calls.pop(0)
maruel@chromium.orge52678e2013-04-26 18:34:44 +0000101 # Also logs otherwise it could get caught in a try/finally and be hard to
102 # diagnose.
103 if expected_args != args:
104 msg = '@%d Expected: %r Actual: %r' % (
105 self._calls_done, expected_args, args)
106 git_cl.logging.error(msg)
107 self.fail(msg)
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000108 self._calls_done += 1
109 return result
110
maruel@chromium.orga3353652011-11-30 14:26:57 +0000111 @classmethod
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000112 def _upload_calls(cls, similarity, find_copies, private):
iannucci@chromium.org79540052012-10-19 23:15:26 +0000113 return (cls._git_base_calls(similarity, find_copies) +
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000114 cls._git_upload_calls(private))
maruel@chromium.orga3353652011-11-30 14:26:57 +0000115
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000116 @classmethod
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000117 def _upload_no_rev_calls(cls, similarity, find_copies):
118 return (cls._git_base_calls(similarity, find_copies) +
119 cls._git_upload_no_rev_calls())
120
121 @classmethod
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000122 def _git_base_calls(cls, similarity, find_copies):
iannucci@chromium.org53937ba2012-10-02 18:20:43 +0000123 if similarity is None:
124 similarity = '50'
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000125 similarity_call = ((['git', 'config', '--int', '--get',
iannucci@chromium.org53937ba2012-10-02 18:20:43 +0000126 'branch.master.git-cl-similarity'],), '')
127 else:
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000128 similarity_call = ((['git', 'config', '--int',
iannucci@chromium.org53937ba2012-10-02 18:20:43 +0000129 'branch.master.git-cl-similarity', similarity],), '')
iannucci@chromium.org79540052012-10-19 23:15:26 +0000130
131 if find_copies is None:
132 find_copies = True
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000133 find_copies_call = ((['git', 'config', '--int', '--get',
iannucci@chromium.org79540052012-10-19 23:15:26 +0000134 'branch.master.git-find-copies'],), '')
135 else:
136 val = str(int(find_copies))
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000137 find_copies_call = ((['git', 'config', '--int',
iannucci@chromium.org79540052012-10-19 23:15:26 +0000138 'branch.master.git-find-copies', val],), '')
139
140 if find_copies:
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000141 stat_call = ((['git', 'diff', '--no-ext-diff', '--stat',
iannucci@chromium.org79540052012-10-19 23:15:26 +0000142 '--find-copies-harder', '-l100000', '-C'+similarity,
sbc@chromium.org5e07e062013-02-28 23:55:44 +0000143 'fake_ancestor_sha', 'HEAD'],), '+dat')
iannucci@chromium.org79540052012-10-19 23:15:26 +0000144 else:
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000145 stat_call = ((['git', 'diff', '--no-ext-diff', '--stat',
sbc@chromium.org5e07e062013-02-28 23:55:44 +0000146 '-M'+similarity, 'fake_ancestor_sha', 'HEAD'],), '+dat')
iannucci@chromium.org79540052012-10-19 23:15:26 +0000147
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000148 return [
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000149 ((['git', 'config', 'rietveld.autoupdate'],), ''),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000150 ((['git', 'config', 'rietveld.server'],),
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000151 'codereview.example.com'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000152 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
iannucci@chromium.org53937ba2012-10-02 18:20:43 +0000153 similarity_call,
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000154 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
iannucci@chromium.org79540052012-10-19 23:15:26 +0000155 find_copies_call,
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000156 ((['git', 'update-index', '--refresh', '-q'],), ''),
157 ((['git', 'diff-index', '--name-status', 'HEAD'],), ''),
158 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
159 ((['git', 'config', 'branch.master.merge'],), 'master'),
160 ((['git', 'config', 'branch.master.remote'],), 'origin'),
161 ((['git', 'merge-base', 'master', 'HEAD'],),
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000162 'fake_ancestor_sha'),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000163 ] + cls._git_sanity_checks('fake_ancestor_sha', 'master') + [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000164 ((['git', 'rev-parse', '--show-cdup'],), ''),
165 ((['git', 'rev-parse', 'HEAD'],), '12345'),
166 ((['git', 'diff', '--name-status', '--no-renames', '-r',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000167 'fake_ancestor_sha...', '.'],),
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000168 'M\t.gitignore\n'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000169 ((['git', 'config', 'branch.master.rietveldissue'],), ''),
170 ((['git', 'config', 'branch.master.rietveldpatchset'],),
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000171 ''),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000172 ((['git', 'log', '--pretty=format:%s%n%n%b',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000173 'fake_ancestor_sha...'],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000174 'foo'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000175 ((['git', 'config', 'user.email'],), 'me@example.com'),
iannucci@chromium.org79540052012-10-19 23:15:26 +0000176 stat_call,
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000177 ((['git', 'config', 'gerrit.host'],), ''),
178 ((['git', 'log', '--pretty=format:%s\n\n%b',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000179 'fake_ancestor_sha..HEAD'],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000180 'desc\n'),
maruel@chromium.orga3353652011-11-30 14:26:57 +0000181 ]
182
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000183 @classmethod
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000184 def _git_upload_no_rev_calls(cls):
185 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000186 ((['git', 'config', 'core.editor'],), ''),
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000187 ]
188
189 @classmethod
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000190 def _git_upload_calls(cls, private):
191 if private:
tyoshino@chromium.org99918ab2013-09-30 06:17:28 +0000192 cc_call = []
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000193 private_call = []
194 else:
tyoshino@chromium.org99918ab2013-09-30 06:17:28 +0000195 cc_call = [((['git', 'config', 'rietveld.cc'],), '')]
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000196 private_call = [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000197 ((['git', 'config', 'rietveld.private'],), '')]
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000198
maruel@chromium.orga3353652011-11-30 14:26:57 +0000199 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000200 ((['git', 'config', 'core.editor'],), ''),
tyoshino@chromium.org99918ab2013-09-30 06:17:28 +0000201 ] + cc_call + private_call + [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000202 ((['git', 'config', 'branch.master.base-url'],), ''),
203 ((['git',
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000204 'config', '--local', '--get-regexp', '^svn-remote\\.'],),
205 (('', None), 0)),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000206 ((['git', 'rev-parse', '--show-cdup'],), ''),
207 ((['git', 'svn', 'info'],), ''),
208 ((['git',
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000209 'config', 'branch.master.rietveldissue', '1'],), ''),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000210 ((['git', 'config', 'branch.master.rietveldserver',
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000211 'https://codereview.example.com'],), ''),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000212 ((['git',
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000213 'config', 'branch.master.rietveldpatchset', '2'],), ''),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000214 ((['git', 'rev-parse', 'HEAD'],), 'hash'),
215 ((['git', 'symbolic-ref', 'HEAD'],), 'hash'),
216 ((['git',
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000217 'config', 'branch.hash.last-upload-hash', 'hash'],), ''),
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000218 ]
219
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000220 @staticmethod
221 def _git_sanity_checks(diff_base, working_branch):
222 fake_ancestor = 'fake_ancestor'
223 fake_cl = 'fake_cl_for_patch'
224 return [
225 # Calls to verify branch point is ancestor
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000226 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000227 'rev-parse', '--verify', diff_base],), fake_ancestor),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000228 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000229 'merge-base', fake_ancestor, 'HEAD'],), fake_ancestor),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000230 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000231 'rev-list', '^' + fake_ancestor, 'HEAD'],), fake_cl),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000232 # Mock a config miss (error code 1)
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000233 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000234 'config', 'gitcl.remotebranch'],), (('', None), 1)),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000235 # Call to GetRemoteBranch()
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000236 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000237 'config', 'branch.%s.merge' % working_branch],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000238 'refs/heads/master'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000239 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000240 'config', 'branch.%s.remote' % working_branch],), 'origin'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000241 ((['git', 'rev-list', '^' + fake_ancestor,
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000242 'refs/remotes/origin/master'],), ''),
243 ]
244
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000245 @classmethod
246 def _dcommit_calls_1(cls):
247 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000248 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000249 'config', '--local', '--get-regexp', '^svn-remote\\.'],),
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000250 ((('svn-remote.svn.url svn://svn.chromium.org/chrome\n'
251 'svn-remote.svn.fetch trunk/src:refs/remotes/origin/master'),
252 None),
253 0)),
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000254 ((['git', 'config', 'rietveld.autoupdate'],),
255 ''),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000256 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000257 'config', 'rietveld.server'],), 'codereview.example.com'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000258 ((['git', 'symbolic-ref', 'HEAD'],), 'refs/heads/working'),
259 ((['git', 'config', '--int', '--get',
iannucci@chromium.org53937ba2012-10-02 18:20:43 +0000260 'branch.working.git-cl-similarity'],), ''),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000261 ((['git', 'symbolic-ref', 'HEAD'],), 'refs/heads/working'),
262 ((['git', 'config', '--int', '--get',
iannucci@chromium.org79540052012-10-19 23:15:26 +0000263 'branch.working.git-find-copies'],), ''),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000264 ((['git', 'symbolic-ref', 'HEAD'],), 'refs/heads/working'),
265 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000266 'config', 'branch.working.merge'],), 'refs/heads/master'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000267 ((['git', 'config', 'branch.working.remote'],), 'origin'),
268 ((['git', 'rev-list', '--merges',
szager@chromium.orge84b7542012-06-15 21:26:58 +0000269 '--grep=^SVN changes up to revision [0-9]*$',
szager@chromium.org9bb85e22012-06-13 20:28:23 +0000270 'refs/remotes/origin/master^!'],), ''),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000271 ((['git', 'update-index', '--refresh', '-q'],), ''),
272 ((['git', 'diff-index', '--name-status', 'HEAD'],), ''),
273 ((['git', 'rev-list', '^refs/heads/working',
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000274 'refs/remotes/origin/master'],),
275 ''),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000276 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000277 'log', '--grep=^git-svn-id:', '-1', '--pretty=format:%H'],),
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000278 '3fc18b62c4966193eb435baabe2d18a3810ec82e'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000279 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000280 'rev-list', '^3fc18b62c4966193eb435baabe2d18a3810ec82e',
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000281 'refs/remotes/origin/master'],), ''),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000282 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000283 'merge-base', 'refs/remotes/origin/master', 'HEAD'],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000284 'fake_ancestor_sha'),
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000285 ]
286
287 @classmethod
288 def _dcommit_calls_normal(cls):
289 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000290 ((['git', 'rev-parse', '--show-cdup'],), ''),
291 ((['git', 'rev-parse', 'HEAD'],),
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000292 '00ff397798ea57439712ed7e04ab96e13969ef40'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000293 ((['git',
mcgrathr@chromium.org9249f642013-06-03 21:36:18 +0000294 'diff', '--name-status', '--no-renames', '-r', 'fake_ancestor_sha...',
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000295 '.'],),
296 'M\tPRESUBMIT.py'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000297 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000298 'config', 'branch.working.rietveldissue'],), '12345'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000299 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000300 'config', 'branch.working.rietveldpatchset'],), '31137'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000301 ((['git', 'config', 'branch.working.rietveldserver'],),
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000302 'codereview.example.com'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000303 ((['git', 'config', 'user.email'],), 'author@example.com'),
304 ((['git', 'config', 'rietveld.tree-status-url'],), ''),
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000305 ]
306
307 @classmethod
308 def _dcommit_calls_bypassed(cls):
309 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000310 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000311 'config', 'branch.working.rietveldissue'],), '12345'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000312 ((['git', 'config', 'branch.working.rietveldserver'],),
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000313 'codereview.example.com'),
jochen@chromium.org3ec0d542014-01-14 20:00:03 +0000314 ((['git', 'config', 'rietveld.tree-status-url'],), ''),
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000315 (('GitClHooksBypassedCommit',
316 'Issue https://codereview.example.com/12345 bypassed hook when '
jochen@chromium.org3ec0d542014-01-14 20:00:03 +0000317 'committing (tree status was "unset")'), None),
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000318 ]
319
320 @classmethod
321 def _dcommit_calls_3(cls):
322 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000323 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000324 'diff', '--no-ext-diff', '--stat', '--find-copies-harder',
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000325 '-l100000', '-C50', 'fake_ancestor_sha',
iannucci@chromium.org53937ba2012-10-02 18:20:43 +0000326 'refs/heads/working'],),
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000327 (' PRESUBMIT.py | 2 +-\n'
328 ' 1 files changed, 1 insertions(+), 1 deletions(-)\n')),
329 (('About to commit; enter to confirm.',), None),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000330 ((['git', 'show-ref', '--quiet', '--verify',
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000331 'refs/heads/git-cl-commit'],),
332 (('', None), 0)),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000333 ((['git', 'branch', '-D', 'git-cl-commit'],), ''),
334 ((['git', 'show-ref', '--quiet', '--verify',
szager@chromium.org9bb85e22012-06-13 20:28:23 +0000335 'refs/heads/git-cl-cherry-pick'],), ''),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000336 ((['git', 'rev-parse', '--show-cdup'],), '\n'),
337 ((['git', 'checkout', '-q', '-b', 'git-cl-commit'],), ''),
338 ((['git', 'reset', '--soft', 'fake_ancestor_sha'],), ''),
339 ((['git', 'commit', '-m',
maruel@chromium.orge52678e2013-04-26 18:34:44 +0000340 'Issue: 12345\n\nR=john@chromium.org\n\n'
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000341 'Review URL: https://codereview.example.com/12345'],),
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000342 ''),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000343 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000344 'svn', 'dcommit', '-C50', '--no-rebase', '--rmdir'],),
iannucci@chromium.org53937ba2012-10-02 18:20:43 +0000345 (('', None), 0)),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000346 ((['git', 'checkout', '-q', 'working'],), ''),
347 ((['git', 'branch', '-D', 'git-cl-commit'],), ''),
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000348 ]
349
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000350 @staticmethod
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000351 def _cmd_line(description, args, similarity, find_copies, private):
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000352 """Returns the upload command line passed to upload.RealMain()."""
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000353 return [
354 'upload', '--assume_yes', '--server',
maruel@chromium.orgeb5edbc2012-01-16 17:03:28 +0000355 'https://codereview.example.com',
maruel@chromium.org71e12a92012-02-14 02:34:15 +0000356 '--message', description
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000357 ] + args + [
358 '--cc', 'joe@example.com',
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000359 ] + (['--private'] if private else []) + [
iannucci@chromium.org79540052012-10-19 23:15:26 +0000360 '--git_similarity', similarity or '50'
361 ] + (['--git_no_find_copies'] if find_copies == False else []) + [
sbc@chromium.org5e07e062013-02-28 23:55:44 +0000362 'fake_ancestor_sha', 'HEAD'
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000363 ]
364
365 def _run_reviewer_test(
366 self,
367 upload_args,
368 expected_description,
369 returned_description,
370 final_description,
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000371 reviewers,
372 private=False):
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000373 """Generic reviewer test framework."""
iannucci@chromium.org53937ba2012-10-02 18:20:43 +0000374 try:
375 similarity = upload_args[upload_args.index('--similarity')+1]
376 except ValueError:
377 similarity = None
iannucci@chromium.org79540052012-10-19 23:15:26 +0000378
379 if '--find-copies' in upload_args:
380 find_copies = True
381 elif '--no-find-copies' in upload_args:
382 find_copies = False
383 else:
384 find_copies = None
385
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000386 private = '--private' in upload_args
387
388 self.calls = self._upload_calls(similarity, find_copies, private)
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000389
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000390 def RunEditor(desc, _, **kwargs):
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000391 self.assertEquals(
392 '# Enter a description of the change.\n'
janx@chromium.org104b2db2013-04-18 12:58:40 +0000393 '# This will be displayed on the codereview site.\n'
alancutter@chromium.org63a4d7f2013-05-31 02:22:45 +0000394 '# The first line will also be used as the subject of the review.\n'
alancutter@chromium.orgbd1073e2013-06-01 00:34:38 +0000395 '#--------------------This line is 72 characters long'
396 '--------------------\n' +
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000397 expected_description,
398 desc)
399 return returned_description
400 self.mock(git_cl.gclient_utils, 'RunEditor', RunEditor)
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000401
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000402 def check_upload(args):
iannucci@chromium.org79540052012-10-19 23:15:26 +0000403 cmd_line = self._cmd_line(final_description, reviewers, similarity,
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000404 find_copies, private)
iannucci@chromium.org53937ba2012-10-02 18:20:43 +0000405 self.assertEquals(cmd_line, args)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000406 return 1, 2
407 self.mock(git_cl.upload, 'RealMain', check_upload)
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000408
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000409 git_cl.main(['upload'] + upload_args)
410
411 def test_no_reviewer(self):
412 self._run_reviewer_test(
413 [],
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000414 'desc\n\nBUG=',
415 '# Blah blah comment.\ndesc\n\nBUG=',
416 'desc\n\nBUG=',
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000417 [])
418
iannucci@chromium.org53937ba2012-10-02 18:20:43 +0000419 def test_keep_similarity(self):
420 self._run_reviewer_test(
421 ['--similarity', '70'],
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000422 'desc\n\nBUG=',
423 '# Blah blah comment.\ndesc\n\nBUG=',
424 'desc\n\nBUG=',
iannucci@chromium.org53937ba2012-10-02 18:20:43 +0000425 [])
426
iannucci@chromium.org79540052012-10-19 23:15:26 +0000427 def test_keep_find_copies(self):
428 self._run_reviewer_test(
429 ['--no-find-copies'],
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000430 'desc\n\nBUG=',
iannucci@chromium.org79540052012-10-19 23:15:26 +0000431 '# Blah blah comment.\ndesc\n\nBUG=\n',
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000432 'desc\n\nBUG=',
iannucci@chromium.org79540052012-10-19 23:15:26 +0000433 [])
434
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000435 def test_private(self):
436 self._run_reviewer_test(
437 ['--private'],
438 'desc\n\nBUG=',
439 '# Blah blah comment.\ndesc\n\nBUG=\n',
440 'desc\n\nBUG=',
441 [])
442
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000443 def test_reviewers_cmd_line(self):
444 # Reviewer is passed as-is
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000445 description = 'desc\n\nR=foo@example.com\nBUG='
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000446 self._run_reviewer_test(
447 ['-r' 'foo@example.com'],
448 description,
449 '\n%s\n' % description,
450 description,
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000451 ['--reviewers=foo@example.com'])
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000452
453 def test_reviewer_tbr_overriden(self):
454 # Reviewer is overriden with TBR
455 # Also verifies the regexp work without a trailing LF
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000456 description = 'Foo Bar\n\nTBR=reviewer@example.com'
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000457 self._run_reviewer_test(
458 ['-r' 'foo@example.com'],
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000459 'desc\n\nR=foo@example.com\nBUG=',
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000460 description.strip('\n'),
461 description,
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000462 ['--reviewers=reviewer@example.com'])
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000463
464 def test_reviewer_multiple(self):
465 # Handles multiple R= or TBR= lines.
466 description = (
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000467 'Foo Bar\nTBR=reviewer@example.com\nBUG=\nR=another@example.com')
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000468 self._run_reviewer_test(
469 [],
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000470 'desc\n\nBUG=',
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000471 description,
472 description,
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000473 ['--reviewers=another@example.com,reviewer@example.com'])
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000474
maruel@chromium.orga3353652011-11-30 14:26:57 +0000475 def test_reviewer_send_mail(self):
476 # --send-mail can be used without -r if R= is used
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000477 description = 'Foo Bar\nR=reviewer@example.com'
maruel@chromium.orga3353652011-11-30 14:26:57 +0000478 self._run_reviewer_test(
479 ['--send-mail'],
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000480 'desc\n\nBUG=',
maruel@chromium.orga3353652011-11-30 14:26:57 +0000481 description.strip('\n'),
482 description,
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000483 ['--reviewers=reviewer@example.com', '--send_mail'])
maruel@chromium.orga3353652011-11-30 14:26:57 +0000484
485 def test_reviewer_send_mail_no_rev(self):
486 # Fails without a reviewer.
maruel@chromium.org2e23ce32013-05-07 12:42:28 +0000487 stdout = StringIO.StringIO()
488 stderr = StringIO.StringIO()
maruel@chromium.orga3353652011-11-30 14:26:57 +0000489 try:
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000490 self.calls = self._upload_no_rev_calls(None, None)
491 def RunEditor(desc, _, **kwargs):
maruel@chromium.orga3353652011-11-30 14:26:57 +0000492 return desc
493 self.mock(git_cl.gclient_utils, 'RunEditor', RunEditor)
maruel@chromium.org2e23ce32013-05-07 12:42:28 +0000494 self.mock(sys, 'stdout', stdout)
495 self.mock(sys, 'stderr', stderr)
maruel@chromium.orga3353652011-11-30 14:26:57 +0000496 git_cl.main(['upload', '--send-mail'])
497 self.fail()
498 except SystemExit:
maruel@chromium.org2e23ce32013-05-07 12:42:28 +0000499 self.assertEqual(
500 'Using 50% similarity for rename/copy detection. Override with '
501 '--similarity.\n',
502 stdout.getvalue())
503 self.assertEqual(
504 'Must specify reviewers to send email.\n', stderr.getvalue())
maruel@chromium.orga3353652011-11-30 14:26:57 +0000505
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000506 def test_dcommit(self):
507 self.calls = (
508 self._dcommit_calls_1() +
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000509 self._git_sanity_checks('fake_ancestor_sha', 'working') +
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000510 self._dcommit_calls_normal() +
511 self._dcommit_calls_3())
512 git_cl.main(['dcommit'])
513
514 def test_dcommit_bypass_hooks(self):
515 self.calls = (
516 self._dcommit_calls_1() +
517 self._dcommit_calls_bypassed() +
518 self._dcommit_calls_3())
519 git_cl.main(['dcommit', '--bypass-hooks'])
520
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000521
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000522 @classmethod
523 def _gerrit_base_calls(cls):
ukai@chromium.orge8077812012-02-03 03:41:46 +0000524 return [
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000525 ((['git', 'config', 'rietveld.autoupdate'],),
526 ''),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000527 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000528 'config', 'rietveld.server'],), 'codereview.example.com'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000529 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
530 ((['git', 'config', '--int', '--get',
iannucci@chromium.org53937ba2012-10-02 18:20:43 +0000531 'branch.master.git-cl-similarity'],), ''),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000532 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
533 ((['git', 'config', '--int', '--get',
iannucci@chromium.org79540052012-10-19 23:15:26 +0000534 'branch.master.git-find-copies'],), ''),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000535 ((['git', 'update-index', '--refresh', '-q'],), ''),
536 ((['git', 'diff-index', '--name-status', 'HEAD'],), ''),
537 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
538 ((['git', 'config', 'branch.master.merge'],), 'master'),
539 ((['git', 'config', 'branch.master.remote'],), 'origin'),
540 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000541 'merge-base', 'master', 'HEAD'],), 'fake_ancestor_sha'),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000542 ] + cls._git_sanity_checks('fake_ancestor_sha', 'master') + [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000543 ((['git', 'rev-parse', '--show-cdup'],), ''),
544 ((['git', 'rev-parse', 'HEAD'],), '12345'),
545 ((['git',
mcgrathr@chromium.org9249f642013-06-03 21:36:18 +0000546 'diff', '--name-status', '--no-renames', '-r',
547 'fake_ancestor_sha...', '.'],),
ukai@chromium.orge8077812012-02-03 03:41:46 +0000548 'M\t.gitignore\n'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000549 ((['git', 'config', 'branch.master.rietveldissue'],), ''),
550 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000551 'config', 'branch.master.rietveldpatchset'],), ''),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000552 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000553 'log', '--pretty=format:%s%n%n%b', 'fake_ancestor_sha...'],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000554 'foo'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000555 ((['git', 'config', 'user.email'],), 'me@example.com'),
556 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000557 'diff', '--no-ext-diff', '--stat', '--find-copies-harder',
sbc@chromium.org5e07e062013-02-28 23:55:44 +0000558 '-l100000', '-C50', 'fake_ancestor_sha', 'HEAD'],),
ukai@chromium.orge8077812012-02-03 03:41:46 +0000559 '+dat'),
560 ]
561
562 @staticmethod
563 def _gerrit_upload_calls(description, reviewers):
564 calls = [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000565 ((['git', 'config', 'gerrit.host'],),
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000566 'gerrit.example.com'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000567 ((['git', 'log', '--pretty=format:%s\n\n%b',
sbc@chromium.org5e07e062013-02-28 23:55:44 +0000568 'fake_ancestor_sha..HEAD'],),
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000569 description)
570 ]
571 if git_cl.CHANGE_ID not in description:
572 calls += [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000573 ((['git', 'log', '--pretty=format:%s\n\n%b',
sbc@chromium.org5e07e062013-02-28 23:55:44 +0000574 'fake_ancestor_sha..HEAD'],),
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000575 description),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000576 ((['git', 'commit', '--amend', '-m', description],),
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000577 ''),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000578 ((['git', 'log', '--pretty=format:%s\n\n%b',
sbc@chromium.org5e07e062013-02-28 23:55:44 +0000579 'fake_ancestor_sha..HEAD'],),
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000580 description)
581 ]
582 calls += [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000583 ((['git', 'config', 'rietveld.cc'],), '')
ukai@chromium.orge8077812012-02-03 03:41:46 +0000584 ]
ukai@chromium.org19bbfa22012-02-03 16:18:11 +0000585 receive_pack = '--receive-pack=git receive-pack '
ukai@chromium.orge8077812012-02-03 03:41:46 +0000586 receive_pack += '--cc=joe@example.com' # from watch list
587 if reviewers:
588 receive_pack += ' '
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000589 receive_pack += ' '.join(
590 '--reviewer=' + email for email in sorted(reviewers))
ukai@chromium.org19bbfa22012-02-03 16:18:11 +0000591 receive_pack += ''
ukai@chromium.orge8077812012-02-03 03:41:46 +0000592 calls += [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000593 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000594 'push', receive_pack, 'origin', 'HEAD:refs/for/master'],),
ukai@chromium.orge8077812012-02-03 03:41:46 +0000595 '')
596 ]
597 return calls
598
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000599 def _run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +0000600 self,
601 upload_args,
602 description,
603 reviewers):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000604 """Generic gerrit upload test framework."""
ukai@chromium.orge8077812012-02-03 03:41:46 +0000605 self.calls = self._gerrit_base_calls()
606 self.calls += self._gerrit_upload_calls(description, reviewers)
607 git_cl.main(['upload'] + upload_args)
608
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000609 def test_gerrit_upload_without_change_id(self):
610 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +0000611 [],
jamesr@chromium.org35d1a842012-07-27 00:20:43 +0000612 'desc\n\nBUG=\n',
ukai@chromium.orge8077812012-02-03 03:41:46 +0000613 [])
614
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000615 def test_gerrit_no_reviewer(self):
616 self._run_gerrit_upload_test(
617 [],
618 'desc\n\nBUG=\nChange-Id:123456789\n',
619 [])
620
ukai@chromium.orge8077812012-02-03 03:41:46 +0000621 def test_gerrit_reviewers_cmd_line(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000622 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +0000623 ['-r', 'foo@example.com'],
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000624 'desc\n\nBUG=\nChange-Id:123456789',
ukai@chromium.orge8077812012-02-03 03:41:46 +0000625 ['foo@example.com'])
626
627 def test_gerrit_reviewer_multiple(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000628 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +0000629 [],
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000630 'desc\nTBR=reviewer@example.com\nBUG=\nR=another@example.com\n'
631 'Change-Id:123456789\n',
ukai@chromium.orge8077812012-02-03 03:41:46 +0000632 ['reviewer@example.com', 'another@example.com'])
633
634
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000635 def test_config_gerrit_download_hook(self):
636 self.mock(git_cl, 'FindCodereviewSettingsFile', CodereviewSettingsFileMock)
637 def ParseCodereviewSettingsContent(content):
638 keyvals = {}
639 keyvals['CODE_REVIEW_SERVER'] = 'gerrit.chromium.org'
640 keyvals['GERRIT_HOST'] = 'gerrit.chromium.org'
641 keyvals['GERRIT_PORT'] = '29418'
642 return keyvals
643 self.mock(git_cl.gclient_utils, 'ParseCodereviewSettingsContent',
644 ParseCodereviewSettingsContent)
645 self.mock(git_cl.os, 'access', self._mocked_call)
646 self.mock(git_cl.os, 'chmod', self._mocked_call)
ukai@chromium.org91655502012-05-25 01:46:07 +0000647 src_dir = os.path.join(os.path.sep, 'usr', 'local', 'src')
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000648 def AbsPath(path):
ukai@chromium.org91655502012-05-25 01:46:07 +0000649 if not path.startswith(os.path.sep):
650 return os.path.join(src_dir, path)
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000651 return path
652 self.mock(git_cl.os.path, 'abspath', AbsPath)
ukai@chromium.org91655502012-05-25 01:46:07 +0000653 commit_msg_path = os.path.join(src_dir, '.git', 'hooks', 'commit-msg')
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000654 def Exists(path):
ukai@chromium.org91655502012-05-25 01:46:07 +0000655 if path == commit_msg_path:
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000656 return False
657 # others paths, such as /usr/share/locale/....
658 return True
659 self.mock(git_cl.os.path, 'exists', Exists)
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +0000660 self.mock(git_cl, 'urlretrieve', self._mocked_call)
ukai@chromium.org712d6102013-11-27 00:52:58 +0000661 self.mock(git_cl, 'hasSheBang', self._mocked_call)
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000662 self.calls = [
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000663 ((['git', 'config', 'rietveld.autoupdate'],),
664 ''),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000665 ((['git', 'config', 'rietveld.server',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000666 'gerrit.chromium.org'],), ''),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000667 ((['git', 'config', '--unset-all', 'rietveld.cc'],), ''),
668 ((['git', 'config', '--unset-all',
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000669 'rietveld.private'],), ''),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000670 ((['git', 'config', '--unset-all',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000671 'rietveld.tree-status-url'],), ''),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000672 ((['git', 'config', '--unset-all',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000673 'rietveld.viewvc-url'],), ''),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000674 ((['git', 'config', 'gerrit.host',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000675 'gerrit.chromium.org'],), ''),
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000676 # DownloadHooks(False)
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000677 ((['git', 'config', 'gerrit.host'],),
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000678 'gerrit.chromium.org'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000679 ((['git', 'rev-parse', '--show-cdup'],), ''),
ukai@chromium.org91655502012-05-25 01:46:07 +0000680 ((commit_msg_path, os.X_OK,), False),
ukai@chromium.org712d6102013-11-27 00:52:58 +0000681 (('https://gerrit-review.googlesource.com/tools/hooks/commit-msg',
ukai@chromium.org91655502012-05-25 01:46:07 +0000682 commit_msg_path,), ''),
ukai@chromium.org712d6102013-11-27 00:52:58 +0000683 ((commit_msg_path,), True),
ukai@chromium.org91655502012-05-25 01:46:07 +0000684 ((commit_msg_path, stat.S_IRUSR | stat.S_IWUSR | stat.S_IXUSR,), ''),
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000685 # GetCodereviewSettingsInteractively
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000686 ((['git', 'config', 'rietveld.server'],),
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000687 'gerrit.chromium.org'),
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000688 (('Rietveld server (host[:port]) [https://gerrit.chromium.org]:',),
689 ''),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000690 ((['git', 'config', 'rietveld.cc'],), ''),
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000691 (('CC list:',), ''),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000692 ((['git', 'config', 'rietveld.private'],), ''),
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000693 (('Private flag (rietveld only):',), ''),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000694 ((['git', 'config', 'rietveld.tree-status-url'],), ''),
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000695 (('Tree status URL:',), ''),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000696 ((['git', 'config', 'rietveld.viewvc-url'],), ''),
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000697 (('ViewVC URL:',), ''),
698 # DownloadHooks(True)
ukai@chromium.org91655502012-05-25 01:46:07 +0000699 ((commit_msg_path, os.X_OK,), True),
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000700 ]
701 git_cl.main(['config'])
702
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000703 def test_update_reviewers(self):
704 data = [
705 ('foo', [], 'foo'),
agable@chromium.org42c20792013-09-12 17:34:49 +0000706 ('foo\nR=xx', [], 'foo\nR=xx'),
707 ('foo\nTBR=xx', [], 'foo\nTBR=xx'),
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000708 ('foo', ['a@c'], 'foo\n\nR=a@c'),
agable@chromium.org42c20792013-09-12 17:34:49 +0000709 ('foo\nR=xx', ['a@c'], 'foo\n\nR=a@c, xx'),
710 ('foo\nTBR=xx', ['a@c'], 'foo\n\nR=a@c\nTBR=xx'),
711 ('foo\nTBR=xx\nR=yy', ['a@c'], 'foo\n\nR=a@c, yy\nTBR=xx'),
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000712 ('foo\nBUG=', ['a@c'], 'foo\nBUG=\nR=a@c'),
agable@chromium.org42c20792013-09-12 17:34:49 +0000713 ('foo\nR=xx\nTBR=yy\nR=bar', ['a@c'], 'foo\n\nR=a@c, xx, bar\nTBR=yy'),
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000714 ('foo', ['a@c', 'b@c'], 'foo\n\nR=a@c, b@c'),
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +0000715 ('foo\nBar\n\nR=\nBUG=', ['c@c'], 'foo\nBar\n\nR=c@c\nBUG='),
716 ('foo\nBar\n\nR=\nBUG=\nR=', ['c@c'], 'foo\nBar\n\nR=c@c\nBUG='),
717 # Same as the line before, but full of whitespaces.
718 (
719 'foo\nBar\n\n R = \n BUG = \n R = ', ['c@c'],
720 'foo\nBar\n\nR=c@c\n BUG =',
721 ),
722 # Whitespaces aren't interpreted as new lines.
723 ('foo BUG=allo R=joe ', ['c@c'], 'foo BUG=allo R=joe\n\nR=c@c'),
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000724 ]
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +0000725 expected = [i[2] for i in data]
726 actual = []
727 for orig, reviewers, _expected in data:
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000728 obj = git_cl.ChangeDescription(orig)
729 obj.update_reviewers(reviewers)
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +0000730 actual.append(obj.description)
731 self.assertEqual(expected, actual)
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000732
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000733
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000734if __name__ == '__main__':
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000735 git_cl.logging.basicConfig(
736 level=git_cl.logging.DEBUG if '-v' in sys.argv else git_cl.logging.ERROR)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000737 unittest.main()