blob: 0c72c274ccc42579c79dd9ea20cca313708ba485 [file] [log] [blame]
Edward Lemur0db01f02019-11-12 22:01:51 +00001#!/usr/bin/env vpython3
2# coding=utf-8
maruel@chromium.orgeb5edbc2012-01-16 17:03:28 +00003# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@chromium.orgddd59412011-11-30 14:20:38 +00004# Use of this source code is governed by a BSD-style license that can be
5# found in the LICENSE file.
6
7"""Unit tests for git_cl.py."""
8
Edward Lemur85153282020-02-14 22:06:29 +00009from __future__ import print_function
Edward Lemur0db01f02019-11-12 22:01:51 +000010from __future__ import unicode_literals
11
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +010012import datetime
tandriide281ae2016-10-12 06:02:30 -070013import json
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +010014import logging
Edward Lemur61bf4172020-02-24 23:22:37 +000015import multiprocessing
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000016import optparse
maruel@chromium.orgddd59412011-11-30 14:20:38 +000017import os
Edward Lemur85153282020-02-14 22:06:29 +000018import pprint
Brian Sheedy59b06a82019-10-14 17:03:29 +000019import shutil
maruel@chromium.orgddd59412011-11-30 14:20:38 +000020import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070021import tempfile
maruel@chromium.orgddd59412011-11-30 14:20:38 +000022import unittest
23
Edward Lemura8145022020-01-06 18:47:54 +000024if sys.version_info.major == 2:
25 from StringIO import StringIO
26 import mock
27else:
28 from io import StringIO
29 from unittest import mock
30
maruel@chromium.orgddd59412011-11-30 14:20:38 +000031sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
32
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000033import metrics
Edward Lesmes9c349062021-05-06 20:02:39 +000034import metrics_utils
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000035# We have to disable monitoring before importing git_cl.
Edward Lesmes9c349062021-05-06 20:02:39 +000036metrics_utils.COLLECT_METRICS = False
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000037
Jamie Madill5e96ad12020-01-13 16:08:35 +000038import clang_format
Edward Lemur227d5102020-02-25 23:45:35 +000039import contextlib
Edward Lemur1773f372020-02-22 00:27:14 +000040import gclient_utils
Eric Boren2fb63102018-10-05 13:05:03 +000041import gerrit_util
maruel@chromium.orgddd59412011-11-30 14:20:38 +000042import git_cl
iannucci@chromium.org9e849272014-04-04 00:31:55 +000043import git_common
tandrii@chromium.org57d86542016-03-04 16:11:32 +000044import git_footers
Edward Lemur85153282020-02-14 22:06:29 +000045import git_new_branch
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +000046import owners_client
Edward Lemur85153282020-02-14 22:06:29 +000047import scm
maruel@chromium.orgddd59412011-11-30 14:20:38 +000048import subprocess2
maruel@chromium.orgddd59412011-11-30 14:20:38 +000049
Josip Sokcevic464e9ff2020-03-18 23:48:55 +000050NETRC_FILENAME = '_netrc' if sys.platform == 'win32' else '.netrc'
51
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000052
Edward Lemur0db01f02019-11-12 22:01:51 +000053def callError(code=1, cmd='', cwd='', stdout=b'', stderr=b''):
tandrii5d48c322016-08-18 16:19:37 -070054 return subprocess2.CalledProcessError(code, cmd, cwd, stdout, stderr)
55
tandrii5d48c322016-08-18 16:19:37 -070056CERR1 = callError(1)
57
58
Edward Lemur1773f372020-02-22 00:27:14 +000059class TemporaryFileMock(object):
60 def __init__(self):
61 self.suffix = 0
Aaron Gable9a03ae02017-11-03 11:31:07 -070062
Edward Lemur1773f372020-02-22 00:27:14 +000063 @contextlib.contextmanager
64 def __call__(self):
65 self.suffix += 1
66 yield '/tmp/fake-temp' + str(self.suffix)
Aaron Gable9a03ae02017-11-03 11:31:07 -070067
68
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000069class ChangelistMock(object):
70 # A class variable so we can access it when we don't have access to the
71 # instance that's being set.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000072 desc = ''
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000073
Dirk Pranke6f0df682021-06-25 00:42:33 +000074 def __init__(self, gerrit_change=None, use_python3=False, **kwargs):
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000075 self._gerrit_change = gerrit_change
Dirk Pranke6f0df682021-06-25 00:42:33 +000076 self._use_python3 = use_python3
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000077
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000078 def GetIssue(self):
79 return 1
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000080
Edward Lemur6c6827c2020-02-06 21:15:18 +000081 def FetchDescription(self):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000082 return ChangelistMock.desc
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000083
dsansomee2d6fd92016-09-08 00:10:47 -070084 def UpdateDescription(self, desc, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000085 ChangelistMock.desc = desc
86
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000087 def GetGerritChange(self, patchset=None, **kwargs):
88 del patchset
89 return self._gerrit_change
90
Josip Sokcevic9011a5b2021-02-12 18:59:44 +000091 def GetRemoteBranch(self):
92 return ('origin', 'refs/remotes/origin/main')
93
Dirk Pranke6f0df682021-06-25 00:42:33 +000094 def GetUsePython3(self):
95 return self._use_python3
tandrii5d48c322016-08-18 16:19:37 -070096
Edward Lemur85153282020-02-14 22:06:29 +000097class GitMocks(object):
98 def __init__(self, config=None, branchref=None):
Josip Sokcevic7e133ff2021-07-13 17:44:53 +000099 self.branchref = branchref or 'refs/heads/main'
Edward Lemur85153282020-02-14 22:06:29 +0000100 self.config = config or {}
101
102 def GetBranchRef(self, _root):
103 return self.branchref
104
105 def NewBranch(self, branchref):
106 self.branchref = branchref
107
Edward Lemur26964072020-02-19 19:18:51 +0000108 def GetConfig(self, root, key, default=None):
109 if root != '':
110 key = '%s:%s' % (root, key)
Edward Lemur85153282020-02-14 22:06:29 +0000111 return self.config.get(key, default)
112
Edward Lemur26964072020-02-19 19:18:51 +0000113 def SetConfig(self, root, key, value=None):
114 if root != '':
115 key = '%s:%s' % (root, key)
Edward Lemur85153282020-02-14 22:06:29 +0000116 if value:
117 self.config[key] = value
118 return
119 if key not in self.config:
120 raise CERR1
121 del self.config[key]
122
123
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000124class WatchlistsMock(object):
125 def __init__(self, _):
126 pass
127 @staticmethod
128 def GetWatchersForPaths(_):
129 return ['joe@example.com']
130
131
Edward Lemur4c707a22019-09-24 21:13:43 +0000132class CodereviewSettingsFileMock(object):
133 def __init__(self):
134 pass
135 # pylint: disable=no-self-use
136 def read(self):
137 return ('CODE_REVIEW_SERVER: gerrit.chromium.org\n' +
138 'GERRIT_HOST: True\n')
139
140
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000141class AuthenticatorMock(object):
142 def __init__(self, *_args):
143 pass
144 def has_cached_credentials(self):
145 return True
tandrii221ab252016-10-06 08:12:04 -0700146 def authorize(self, http):
147 return http
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000148
149
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100150def CookiesAuthenticatorMockFactory(hosts_with_creds=None, same_auth=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000151 """Use to mock Gerrit/Git credentials from ~/.netrc or ~/.gitcookies.
152
153 Usage:
154 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100155 CookiesAuthenticatorMockFactory({'host': ('user', _, 'pass')})
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000156
157 OR
158 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100159 CookiesAuthenticatorMockFactory(
160 same_auth=('user', '', 'pass'))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000161 """
162 class CookiesAuthenticatorMock(git_cl.gerrit_util.CookiesAuthenticator):
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800163 def __init__(self): # pylint: disable=super-init-not-called
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000164 # Intentionally not calling super() because it reads actual cookie files.
165 pass
166 @classmethod
167 def get_gitcookies_path(cls):
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000168 return os.path.join('~', '.gitcookies')
169
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000170 @classmethod
171 def get_netrc_path(cls):
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000172 return os.path.join('~', NETRC_FILENAME)
173
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100174 def _get_auth_for_host(self, host):
175 if same_auth:
176 return same_auth
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000177 return (hosts_with_creds or {}).get(host)
178 return CookiesAuthenticatorMock
179
Aaron Gable9a03ae02017-11-03 11:31:07 -0700180
kmarshall9249e012016-08-23 12:02:16 -0700181class MockChangelistWithBranchAndIssue():
182 def __init__(self, branch, issue):
183 self.branch = branch
184 self.issue = issue
185 def GetBranch(self):
186 return self.branch
187 def GetIssue(self):
188 return self.issue
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000189
tandriic2405f52016-10-10 08:13:15 -0700190
191class SystemExitMock(Exception):
192 pass
193
194
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000195class TestGitClBasic(unittest.TestCase):
Josip Sokcevic953278a2020-02-28 19:46:36 +0000196 def setUp(self):
197 mock.patch('sys.exit', side_effect=SystemExitMock).start()
198 mock.patch('sys.stdout', StringIO()).start()
199 mock.patch('sys.stderr', StringIO()).start()
200 self.addCleanup(mock.patch.stopall)
201
202 def test_die_with_error(self):
203 with self.assertRaises(SystemExitMock):
204 git_cl.DieWithError('foo', git_cl.ChangeDescription('lorem ipsum'))
205 self.assertEqual(sys.stderr.getvalue(), 'foo\n')
206 self.assertTrue('saving CL description' in sys.stdout.getvalue())
207 self.assertTrue('Content of CL description' in sys.stdout.getvalue())
208 self.assertTrue('lorem ipsum' in sys.stdout.getvalue())
209 sys.exit.assert_called_once_with(1)
210
211 def test_die_with_error_no_desc(self):
212 with self.assertRaises(SystemExitMock):
213 git_cl.DieWithError('foo')
214 self.assertEqual(sys.stderr.getvalue(), 'foo\n')
215 self.assertEqual(sys.stdout.getvalue(), '')
216 sys.exit.assert_called_once_with(1)
217
Edward Lemur6c6827c2020-02-06 21:15:18 +0000218 def test_fetch_description(self):
Edward Lemurf38bc172019-09-03 21:02:13 +0000219 cl = git_cl.Changelist(issue=1, codereview_host='host')
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100220 cl.description = 'x'
Edward Lemur6c6827c2020-02-06 21:15:18 +0000221 self.assertEqual(cl.FetchDescription(), 'x')
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700222
Edward Lemur61bf4172020-02-24 23:22:37 +0000223 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
224 @mock.patch('git_cl.Changelist.GetStatus', lambda cl: cl.status)
225 def test_get_cl_statuses(self, *_mocks):
226 statuses = [
227 'closed', 'commit', 'dry-run', 'lgtm', 'reply', 'unsent', 'waiting']
228 changes = []
229 for status in statuses:
230 cl = git_cl.Changelist()
231 cl.status = status
232 changes.append(cl)
233
234 actual = set(git_cl.get_cl_statuses(changes, True))
235 self.assertEqual(set(zip(changes, statuses)), actual)
236
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000237 def test_upload_to_non_default_branch_no_retry(self):
238 m = mock.patch('git_cl.Changelist._CMDUploadChange',
239 side_effect=[git_cl.GitPushError(), None]).start()
240 mock.patch('git_cl.Changelist.GetRemoteBranch',
241 return_value=('foo', 'bar')).start()
Edward Lesmeseeca9c62020-11-20 00:00:17 +0000242 mock.patch('git_cl.Changelist.GetGerritProject',
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000243 return_value='foo').start()
244 mock.patch('git_cl.gerrit_util.GetProjectHead',
245 return_value='refs/heads/main').start()
246
247 cl = git_cl.Changelist()
248 options = optparse.Values()
Josip Sokcevicb631a882021-01-06 18:18:10 +0000249 options.target_branch = 'refs/heads/bar'
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000250 with self.assertRaises(SystemExitMock):
251 cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
252
253 # ensure upload is called once
254 self.assertEqual(len(m.mock_calls), 1)
255 sys.exit.assert_called_once_with(1)
256 # option not set as retry didn't happen
257 self.assertFalse(hasattr(options, 'force'))
258 self.assertFalse(hasattr(options, 'edit_description'))
259
260 def test_upload_to_old_default_still_active(self):
261 m = mock.patch('git_cl.Changelist._CMDUploadChange',
262 side_effect=[git_cl.GitPushError(), None]).start()
263 mock.patch('git_cl.Changelist.GetRemoteBranch',
264 return_value=('foo', git_cl.DEFAULT_OLD_BRANCH)).start()
Edward Lesmeseeca9c62020-11-20 00:00:17 +0000265 mock.patch('git_cl.Changelist.GetGerritProject',
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000266 return_value='foo').start()
267 mock.patch('git_cl.gerrit_util.GetProjectHead',
Josip Sokcevic7e133ff2021-07-13 17:44:53 +0000268 return_value='refs/heads/main').start()
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000269
270 cl = git_cl.Changelist()
271 options = optparse.Values()
Josip Sokcevic7e133ff2021-07-13 17:44:53 +0000272 options.target_branch = 'refs/heads/main'
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000273 with self.assertRaises(SystemExitMock):
274 cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
275
276 # ensure upload is called once
277 self.assertEqual(len(m.mock_calls), 1)
278 sys.exit.assert_called_once_with(1)
279 # option not set as retry didn't happen
280 self.assertFalse(hasattr(options, 'force'))
281 self.assertFalse(hasattr(options, 'edit_description'))
282
Gavin Mak68e6cf32021-01-25 18:24:08 +0000283 def test_upload_with_message_file_no_editor(self):
284 m = mock.patch('git_cl.ChangeDescription.prompt',
285 return_value=None).start()
286 mock.patch('git_cl.Changelist.GetRemoteBranch',
287 return_value=('foo', git_cl.DEFAULT_NEW_BRANCH)).start()
288 mock.patch('git_cl.GetTargetRef',
289 return_value='refs/heads/main').start()
290 mock.patch('git_cl.Changelist._GerritCommitMsgHookCheck',
291 lambda _, offer_removal: None).start()
292 mock.patch('git_cl.Changelist.GetIssue', return_value=None).start()
293 mock.patch('git_cl.Changelist.GetBranch',
294 side_effect=SystemExitMock).start()
295 mock.patch('git_cl.GenerateGerritChangeId', return_value=None).start()
296 mock.patch('git_cl.RunGit').start()
297
298 cl = git_cl.Changelist()
299 options = optparse.Values()
Josip Sokcevic7e133ff2021-07-13 17:44:53 +0000300 options.target_branch = 'refs/heads/main'
Gavin Mak68e6cf32021-01-25 18:24:08 +0000301 options.squash = True
302 options.edit_description = False
303 options.force = False
304 options.preserve_tryjobs = False
305 options.message_file = "message.txt"
306
307 with self.assertRaises(SystemExitMock):
308 cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
309 self.assertEqual(len(m.mock_calls), 0)
310
311 options.message_file = None
312 with self.assertRaises(SystemExitMock):
313 cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
314 self.assertEqual(len(m.mock_calls), 1)
315
Edward Lemur61bf4172020-02-24 23:22:37 +0000316 def test_get_cl_statuses_no_changes(self):
317 self.assertEqual([], list(git_cl.get_cl_statuses([], True)))
318
319 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
320 @mock.patch('multiprocessing.pool.ThreadPool')
321 def test_get_cl_statuses_timeout(self, *_mocks):
322 changes = [git_cl.Changelist() for _ in range(2)]
323 pool = multiprocessing.pool.ThreadPool()
324 it = pool.imap_unordered.return_value.__iter__ = mock.Mock()
325 it.return_value.next.side_effect = [
326 (changes[0], 'lgtm'),
327 multiprocessing.TimeoutError,
328 ]
329
330 actual = list(git_cl.get_cl_statuses(changes, True))
331 self.assertEqual([(changes[0], 'lgtm'), (changes[1], 'error')], actual)
332
333 @mock.patch('git_cl.Changelist.GetIssueURL')
334 def test_get_cl_statuses_not_finegrained(self, _mock):
335 changes = [git_cl.Changelist() for _ in range(2)]
336 urls = ['some-url', None]
337 git_cl.Changelist.GetIssueURL.side_effect = urls
338
339 actual = set(git_cl.get_cl_statuses(changes, False))
340 self.assertEqual(
341 set([(changes[0], 'waiting'), (changes[1], 'error')]), actual)
342
Andrii Shyshkalov1ee78cd2020-03-12 01:31:53 +0000343 def test_get_issue_url(self):
344 cl = git_cl.Changelist(issue=123)
345 cl._gerrit_server = 'https://example.com'
346 self.assertEqual(cl.GetIssueURL(), 'https://example.com/123')
347 self.assertEqual(cl.GetIssueURL(short=True), 'https://example.com/123')
348
349 cl = git_cl.Changelist(issue=123)
350 cl._gerrit_server = 'https://chromium-review.googlesource.com'
351 self.assertEqual(cl.GetIssueURL(),
352 'https://chromium-review.googlesource.com/123')
353 self.assertEqual(cl.GetIssueURL(short=True), 'https://crrev.com/c/123')
354
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +0000355 def test_set_preserve_tryjobs(self):
356 d = git_cl.ChangeDescription('Simple.')
357 d.set_preserve_tryjobs()
358 self.assertEqual(d.description.splitlines(), [
359 'Simple.',
360 '',
361 'Cq-Do-Not-Cancel-Tryjobs: true',
362 ])
363 before = d.description
364 d.set_preserve_tryjobs()
365 self.assertEqual(before, d.description)
366
367 d = git_cl.ChangeDescription('\n'.join([
368 'One is enough',
369 '',
370 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
371 'Change-Id: Ideadbeef',
372 ]))
373 d.set_preserve_tryjobs()
374 self.assertEqual(d.description.splitlines(), [
375 'One is enough',
376 '',
377 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
378 'Change-Id: Ideadbeef',
379 'Cq-Do-Not-Cancel-Tryjobs: true',
380 ])
381
tandriif9aefb72016-07-01 09:06:51 -0700382 def test_get_bug_line_values(self):
383 f = lambda p, bugs: list(git_cl._get_bug_line_values(p, bugs))
384 self.assertEqual(f('', ''), [])
385 self.assertEqual(f('', '123,v8:456'), ['123', 'v8:456'])
Lei Zhang8a0efc12020-08-05 19:58:45 +0000386 # Prefix that ends with colon.
387 self.assertEqual(f('v8:', '456'), ['v8:456'])
388 self.assertEqual(f('v8:', 'chromium:123,456'), ['v8:456', 'chromium:123'])
389 # Prefix that ends without colon.
tandriif9aefb72016-07-01 09:06:51 -0700390 self.assertEqual(f('v8', '456'), ['v8:456'])
391 self.assertEqual(f('v8', 'chromium:123,456'), ['v8:456', 'chromium:123'])
392 # Not nice, but not worth carying.
Lei Zhang8a0efc12020-08-05 19:58:45 +0000393 self.assertEqual(f('v8:', 'chromium:123,456,v8:123'),
394 ['v8:456', 'chromium:123', 'v8:123'])
tandriif9aefb72016-07-01 09:06:51 -0700395 self.assertEqual(f('v8', 'chromium:123,456,v8:123'),
396 ['v8:456', 'chromium:123', 'v8:123'])
397
Edward Lemurda4b6c62020-02-13 00:28:40 +0000398 @mock.patch('gerrit_util.GetAccountDetails')
399 def test_valid_accounts(self, mockGetAccountDetails):
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000400 mock_per_account = {
401 'u1': None, # 404, doesn't exist.
402 'u2': {
403 '_account_id': 123124,
404 'avatars': [],
405 'email': 'u2@example.com',
406 'name': 'User Number 2',
407 'status': 'OOO',
408 },
409 'u3': git_cl.gerrit_util.GerritError(500, 'retries didn\'t help :('),
410 }
411 def GetAccountDetailsMock(_, account):
412 # Poor-man's mock library's side_effect.
413 v = mock_per_account.pop(account)
414 if isinstance(v, Exception):
415 raise v
416 return v
417
Edward Lemurda4b6c62020-02-13 00:28:40 +0000418 mockGetAccountDetails.side_effect = GetAccountDetailsMock
419 actual = git_cl.gerrit_util.ValidAccounts(
420 'host', ['u1', 'u2', 'u3'], max_threads=1)
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000421 self.assertEqual(actual, {
422 'u2': {
423 '_account_id': 123124,
424 'avatars': [],
425 'email': 'u2@example.com',
426 'name': 'User Number 2',
427 'status': 'OOO',
428 },
429 })
430
431
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200432class TestParseIssueURL(unittest.TestCase):
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000433 def _test(self, arg, issue=None, patchset=None, hostname=None, fail=False):
434 parsed = git_cl.ParseIssueNumberArgument(arg)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200435 self.assertIsNotNone(parsed)
436 if fail:
437 self.assertFalse(parsed.valid)
438 return
439 self.assertTrue(parsed.valid)
440 self.assertEqual(parsed.issue, issue)
441 self.assertEqual(parsed.patchset, patchset)
442 self.assertEqual(parsed.hostname, hostname)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200443
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000444 def test_basic(self):
445 self._test('123', 123)
446 self._test('', fail=True)
447 self._test('abc', fail=True)
448 self._test('123/1', fail=True)
449 self._test('123a', fail=True)
450 self._test('ssh://chrome-review.source.com/#/c/123/4/', fail=True)
451 self._test('ssh://chrome-review.source.com/c/123/1/', fail=True)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200452
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000453 def test_gerrit_url(self):
454 self._test('https://codereview.source.com/123', 123, None,
455 'codereview.source.com')
456 self._test('http://chrome-review.source.com/c/123', 123, None,
457 'chrome-review.source.com')
458 self._test('https://chrome-review.source.com/c/123/', 123, None,
459 'chrome-review.source.com')
460 self._test('https://chrome-review.source.com/c/123/4', 123, 4,
461 'chrome-review.source.com')
462 self._test('https://chrome-review.source.com/#/c/123/4', 123, 4,
463 'chrome-review.source.com')
464 self._test('https://chrome-review.source.com/c/123/4', 123, 4,
465 'chrome-review.source.com')
466 self._test('https://chrome-review.source.com/123', 123, None,
467 'chrome-review.source.com')
468 self._test('https://chrome-review.source.com/123/4', 123, 4,
469 'chrome-review.source.com')
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200470
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000471 self._test('https://chrome-review.source.com/bad/123/4', fail=True)
472 self._test('https://chrome-review.source.com/c/123/1/whatisthis', fail=True)
473 self._test('https://chrome-review.source.com/c/abc/', fail=True)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200474
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000475 def test_short_urls(self):
476 self._test('https://crrev.com/c/2151934', 2151934, None,
477 'chromium-review.googlesource.com')
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200478
Alex Turner30ae6372022-01-04 02:32:52 +0000479 def test_missing_scheme(self):
480 self._test('codereview.source.com/123', 123, None, 'codereview.source.com')
481 self._test('crrev.com/c/2151934', 2151934, None,
482 'chromium-review.googlesource.com')
483
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200484
Edward Lemurda4b6c62020-02-13 00:28:40 +0000485class GitCookiesCheckerTest(unittest.TestCase):
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100486 def setUp(self):
487 super(GitCookiesCheckerTest, self).setUp()
488 self.c = git_cl._GitCookiesChecker()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100489 self.c._all_hosts = []
Edward Lemurda4b6c62020-02-13 00:28:40 +0000490 mock.patch('sys.stdout', StringIO()).start()
491 self.addCleanup(mock.patch.stopall)
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100492
493 def mock_hosts_creds(self, subhost_identity_pairs):
494 def ensure_googlesource(h):
495 if not h.endswith(self.c._GOOGLESOURCE):
496 assert not h.endswith('.')
497 return h + '.' + self.c._GOOGLESOURCE
498 return h
499 self.c._all_hosts = [(ensure_googlesource(h), i, '.gitcookies')
500 for h, i in subhost_identity_pairs]
501
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200502 def test_identity_parsing(self):
503 self.assertEqual(self.c._parse_identity('ldap.google.com'),
504 ('ldap', 'google.com'))
505 self.assertEqual(self.c._parse_identity('git-ldap.example.com'),
506 ('ldap', 'example.com'))
507 # Specical case because we know there are no subdomains in chromium.org.
508 self.assertEqual(self.c._parse_identity('git-note.period.chromium.org'),
509 ('note.period', 'chromium.org'))
Lei Zhangd3f769a2017-12-15 15:16:14 -0800510 # Pathological: ".period." can be either username OR domain, more likely
511 # domain.
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200512 self.assertEqual(self.c._parse_identity('git-note.period.example.com'),
513 ('note', 'period.example.com'))
514
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100515 def test_analysis_nothing(self):
516 self.c._all_hosts = []
517 self.assertFalse(self.c.has_generic_host())
518 self.assertEqual(set(), self.c.get_conflicting_hosts())
519 self.assertEqual(set(), self.c.get_duplicated_hosts())
520 self.assertEqual(set(), self.c.get_partially_configured_hosts())
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100521
522 def test_analysis(self):
523 self.mock_hosts_creds([
524 ('.googlesource.com', 'git-example.chromium.org'),
525
526 ('chromium', 'git-example.google.com'),
527 ('chromium-review', 'git-example.google.com'),
528 ('chrome-internal', 'git-example.chromium.org'),
529 ('chrome-internal-review', 'git-example.chromium.org'),
530 ('conflict', 'git-example.google.com'),
531 ('conflict-review', 'git-example.chromium.org'),
532 ('dup', 'git-example.google.com'),
533 ('dup', 'git-example.google.com'),
534 ('dup-review', 'git-example.google.com'),
535 ('partial', 'git-example.google.com'),
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200536 ('gpartial-review', 'git-example.google.com'),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100537 ])
538 self.assertTrue(self.c.has_generic_host())
539 self.assertEqual(set(['conflict.googlesource.com']),
540 self.c.get_conflicting_hosts())
541 self.assertEqual(set(['dup.googlesource.com']),
542 self.c.get_duplicated_hosts())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200543 self.assertEqual(set(['partial.googlesource.com',
544 'gpartial-review.googlesource.com']),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100545 self.c.get_partially_configured_hosts())
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100546
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100547 def test_report_no_problems(self):
548 self.test_analysis_nothing()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100549 self.assertFalse(self.c.find_and_report_problems())
550 self.assertEqual(sys.stdout.getvalue(), '')
551
Edward Lemurda4b6c62020-02-13 00:28:40 +0000552 @mock.patch(
553 'git_cl.gerrit_util.CookiesAuthenticator.get_gitcookies_path',
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000554 return_value=os.path.join('~', '.gitcookies'))
Edward Lemurda4b6c62020-02-13 00:28:40 +0000555 def test_report(self, *_mocks):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100556 self.test_analysis()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100557 self.assertTrue(self.c.find_and_report_problems())
558 with open(os.path.join(os.path.dirname(__file__),
559 'git_cl_creds_check_report.txt')) as f:
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000560 expected = f.read() % {
561 'sep': os.sep,
562 }
563
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100564 def by_line(text):
565 return [l.rstrip() for l in text.rstrip().splitlines()]
Robert Iannucci456b0d62018-03-13 19:15:50 -0700566 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalov4812e612017-03-27 17:22:57 +0200567 self.assertEqual(by_line(sys.stdout.getvalue().strip()), by_line(expected))
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100568
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -0800569
Edward Lemurda4b6c62020-02-13 00:28:40 +0000570class TestGitCl(unittest.TestCase):
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000571 def setUp(self):
572 super(TestGitCl, self).setUp()
573 self.calls = []
tandrii9d206752016-06-20 11:32:47 -0700574 self._calls_done = []
Edward Lesmes0dd54822020-03-26 18:24:25 +0000575 self.failed = False
Edward Lemurda4b6c62020-02-13 00:28:40 +0000576 mock.patch('sys.stdout', StringIO()).start()
577 mock.patch(
578 'git_cl.time_time',
579 lambda: self._mocked_call('time.time')).start()
580 mock.patch(
581 'git_cl.metrics.collector.add_repeated',
582 lambda *a: self._mocked_call('add_repeated', *a)).start()
583 mock.patch('subprocess2.call', self._mocked_call).start()
584 mock.patch('subprocess2.check_call', self._mocked_call).start()
585 mock.patch('subprocess2.check_output', self._mocked_call).start()
586 mock.patch(
587 'subprocess2.communicate',
588 lambda *a, **_k: ([self._mocked_call(*a), ''], 0)).start()
589 mock.patch(
590 'git_cl.gclient_utils.CheckCallAndFilter',
591 self._mocked_call).start()
592 mock.patch('git_common.is_dirty_git_tree', lambda x: False).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +0000593 mock.patch('git_cl.FindCodereviewSettingsFile', return_value='').start()
594 mock.patch(
595 'git_cl.SaveDescriptionBackup',
596 lambda _: self._mocked_call('SaveDescriptionBackup')).start()
597 mock.patch(
Edward Lemurda4b6c62020-02-13 00:28:40 +0000598 'git_cl.write_json',
599 lambda *a: self._mocked_call('write_json', *a)).start()
600 mock.patch(
Edward Lemur227d5102020-02-25 23:45:35 +0000601 'git_cl.Changelist.RunHook',
602 return_value={'more_cc': ['test-more-cc@chromium.org']}).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +0000603 mock.patch('git_cl.watchlists.Watchlists', WatchlistsMock).start()
604 mock.patch('git_cl.auth.Authenticator', AuthenticatorMock).start()
Edward Lesmes7677e5c2020-02-19 20:39:03 +0000605 mock.patch('gerrit_util.GetChangeDetail').start()
Edward Lemurda4b6c62020-02-13 00:28:40 +0000606 mock.patch(
607 'git_cl.gerrit_util.GetChangeComments',
608 lambda *a: self._mocked_call('GetChangeComments', *a)).start()
609 mock.patch(
610 'git_cl.gerrit_util.GetChangeRobotComments',
611 lambda *a: self._mocked_call('GetChangeRobotComments', *a)).start()
612 mock.patch(
613 'git_cl.gerrit_util.AddReviewers',
614 lambda *a: self._mocked_call('AddReviewers', *a)).start()
615 mock.patch(
616 'git_cl.gerrit_util.SetReview',
617 lambda h, i, msg=None, labels=None, notify=None, ready=None: (
618 self._mocked_call(
619 'SetReview', h, i, msg, labels, notify, ready))).start()
620 mock.patch(
621 'git_cl.gerrit_util.LuciContextAuthenticator.is_luci',
622 return_value=False).start()
623 mock.patch(
624 'git_cl.gerrit_util.GceAuthenticator.is_gce',
625 return_value=False).start()
626 mock.patch(
627 'git_cl.gerrit_util.ValidAccounts',
628 lambda *a: self._mocked_call('ValidAccounts', *a)).start()
Edward Lemurd55c5072020-02-20 01:09:07 +0000629 mock.patch('sys.exit', side_effect=SystemExitMock).start()
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000630 mock.patch('git_cl.Settings.GetRoot', return_value='').start()
Edward Lemur85153282020-02-14 22:06:29 +0000631 self.mockGit = GitMocks()
632 mock.patch('scm.GIT.GetBranchRef', self.mockGit.GetBranchRef).start()
633 mock.patch('scm.GIT.GetConfig', self.mockGit.GetConfig).start()
Edward Lesmes50da7702020-03-30 19:23:43 +0000634 mock.patch('scm.GIT.ResolveCommit', return_value='hash').start()
635 mock.patch('scm.GIT.IsValidRevision', return_value=True).start()
Edward Lemur85153282020-02-14 22:06:29 +0000636 mock.patch('scm.GIT.SetConfig', self.mockGit.SetConfig).start()
Edward Lemur84101642020-02-21 21:40:34 +0000637 mock.patch(
638 'git_new_branch.create_new_branch', self.mockGit.NewBranch).start()
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000639 mock.patch(
Edward Lemur85153282020-02-14 22:06:29 +0000640 'scm.GIT.FetchUpstreamTuple',
Josip Sokcevic7e133ff2021-07-13 17:44:53 +0000641 return_value=('origin', 'refs/heads/main')).start()
Edward Lemur85153282020-02-14 22:06:29 +0000642 mock.patch(
643 'scm.GIT.CaptureStatus', return_value=[('M', 'foo.txt')]).start()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000644 # It's important to reset settings to not have inter-tests interference.
645 git_cl.settings = None
Edward Lemurda4b6c62020-02-13 00:28:40 +0000646 self.addCleanup(mock.patch.stopall)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000647
648 def tearDown(self):
wychen@chromium.org445c8962015-04-28 23:30:05 +0000649 try:
Edward Lesmes0dd54822020-03-26 18:24:25 +0000650 if not self.failed:
651 self.assertEqual([], self.calls)
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100652 except AssertionError:
Edward Lemur85153282020-02-14 22:06:29 +0000653 calls = ''.join(' %s\n' % str(call) for call in self.calls[:5])
654 if len(self.calls) > 5:
655 calls += ' ...\n'
656 self.fail(
657 '\n'
658 'There are un-consumed calls after this test has finished:\n' +
659 calls)
wychen@chromium.org445c8962015-04-28 23:30:05 +0000660 finally:
661 super(TestGitCl, self).tearDown()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000662
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000663 def _mocked_call(self, *args, **_kwargs):
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000664 self.assertTrue(
665 self.calls,
tandrii9d206752016-06-20 11:32:47 -0700666 '@%d Expected: <Missing> Actual: %r' % (len(self._calls_done), args))
wychen@chromium.orga872e752015-04-28 23:42:18 +0000667 top = self.calls.pop(0)
wychen@chromium.orga872e752015-04-28 23:42:18 +0000668 expected_args, result = top
669
maruel@chromium.orge52678e2013-04-26 18:34:44 +0000670 # Also logs otherwise it could get caught in a try/finally and be hard to
671 # diagnose.
672 if expected_args != args:
tandrii9d206752016-06-20 11:32:47 -0700673 N = 5
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000674 prior_calls = '\n '.join(
tandrii9d206752016-06-20 11:32:47 -0700675 '@%d: %r' % (len(self._calls_done) - N + i, c[0])
676 for i, c in enumerate(self._calls_done[-N:]))
677 following_calls = '\n '.join(
678 '@%d: %r' % (len(self._calls_done) + i + 1, c[0])
679 for i, c in enumerate(self.calls[:N]))
680 extended_msg = (
681 'A few prior calls:\n %s\n\n'
682 'This (expected):\n @%d: %r\n'
683 'This (actual):\n @%d: %r\n\n'
684 'A few following expected calls:\n %s' %
685 (prior_calls, len(self._calls_done), expected_args,
686 len(self._calls_done), args, following_calls))
tandrii9d206752016-06-20 11:32:47 -0700687
Edward Lesmes0dd54822020-03-26 18:24:25 +0000688 self.failed = True
tandrii99a72f22016-08-17 14:33:24 -0700689 self.fail('@%d\n'
690 ' Expected: %r\n'
Edward Lemur26964072020-02-19 19:18:51 +0000691 ' Actual: %r\n'
692 '\n'
693 '%s' % (
694 len(self._calls_done), expected_args, args, extended_msg))
tandrii9d206752016-06-20 11:32:47 -0700695
696 self._calls_done.append(top)
tandrii5d48c322016-08-18 16:19:37 -0700697 if isinstance(result, Exception):
698 raise result
Edward Lemur0db01f02019-11-12 22:01:51 +0000699 # stdout from git commands is supposed to be a bytestream. Convert it here
700 # instead of converting all test output in this file to bytes.
701 if args[0][0] == 'git' and not isinstance(result, bytes):
702 result = result.encode('utf-8')
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000703 return result
704
Edward Lemur1a83da12020-03-04 21:18:36 +0000705 @mock.patch('sys.stdin', StringIO('blah\nye\n'))
706 @mock.patch('sys.stdout', StringIO())
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100707 def test_ask_for_explicit_yes_true(self):
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100708 self.assertTrue(git_cl.ask_for_explicit_yes('prompt'))
Edward Lemur1a83da12020-03-04 21:18:36 +0000709 self.assertEqual(
710 'prompt [Yes/No]: Please, type yes or no: ',
711 sys.stdout.getvalue())
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100712
tandrii48df5812016-10-17 03:55:37 -0700713 def test_LoadCodereviewSettingsFromFile_gerrit(self):
Edward Lemur79d4f992019-11-11 23:49:02 +0000714 codereview_file = StringIO('GERRIT_HOST: true')
tandrii48df5812016-10-17 03:55:37 -0700715 self.calls = [
716 ((['git', 'config', '--unset-all', 'rietveld.cc'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700717 ((['git', 'config', '--unset-all', 'rietveld.tree-status-url'],), CERR1),
718 ((['git', 'config', '--unset-all', 'rietveld.viewvc-url'],), CERR1),
719 ((['git', 'config', '--unset-all', 'rietveld.bug-prefix'],), CERR1),
720 ((['git', 'config', '--unset-all', 'rietveld.cpplint-regex'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700721 ((['git', 'config', '--unset-all', 'rietveld.cpplint-ignore-regex'],),
722 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700723 ((['git', 'config', '--unset-all', 'rietveld.run-post-upload-hook'],),
724 CERR1),
Jamie Madilldc4d19e2019-10-24 21:50:02 +0000725 ((['git', 'config', '--unset-all', 'rietveld.format-full-by-default'],),
726 CERR1),
Dirk Pranke6f0df682021-06-25 00:42:33 +0000727 ((['git', 'config', '--unset-all', 'rietveld.use-python3'],),
728 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700729 ((['git', 'config', 'gerrit.host', 'true'],), ''),
730 ]
731 self.assertIsNone(git_cl.LoadCodereviewSettingsFromFile(codereview_file))
732
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000733 @classmethod
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100734 def _gerrit_base_calls(cls, issue=None, fetched_description=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200735 fetched_status=None, other_cl_owner=None,
Anthony Polito8b955342019-09-24 19:01:36 +0000736 custom_cl_base=None, short_hostname='chromium',
Joanna Wang583ca662022-04-27 21:17:17 +0000737 change_id=None, default_branch='main',
738 reset_issue=False):
Edward Lemur26964072020-02-19 19:18:51 +0000739 calls = []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200740 if custom_cl_base:
741 ancestor_revision = custom_cl_base
742 else:
743 # Determine ancestor_revision to be merge base.
Edward Lesmes8c43c3f2021-01-20 00:20:26 +0000744 ancestor_revision = 'origin/' + default_branch
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200745
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100746 if issue:
Joanna Wang583ca662022-04-27 21:17:17 +0000747 # TODO: if tests don't provide a `change_id` the default used here
748 # will cause the TRACES_README_FORMAT mock (which uses the test provided
749 # `change_id` to fail.
Edward Lesmes7677e5c2020-02-19 20:39:03 +0000750 gerrit_util.GetChangeDetail.return_value = {
751 'owner': {'email': (other_cl_owner or 'owner@example.com')},
752 'change_id': (change_id or '123456789'),
753 'current_revision': 'sha1_of_current_revision',
754 'revisions': {'sha1_of_current_revision': {
755 'commit': {'message': fetched_description},
756 }},
757 'status': fetched_status or 'NEW',
758 }
Joanna Wang583ca662022-04-27 21:17:17 +0000759
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100760 if fetched_status == 'ABANDONED':
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100761 return calls
Joanna Wang583ca662022-04-27 21:17:17 +0000762 if fetched_status == 'MERGED':
763 calls.append(
764 (('ask_for_data',
765 'Change https://chromium-review.googlesource.com/%s has been '
766 'submitted, new uploads are not allowed. Would you like to start '
767 'a new change (Y/n)?' % issue), 'y' if reset_issue else 'n')
768 )
769 if not reset_issue:
770 return calls
771 # Part of SetIssue call.
772 calls.append(
773 ((['git', 'log', '-1', '--format=%B'],), ''))
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100774 if other_cl_owner:
775 calls += [
776 (('ask_for_data', 'Press Enter to upload, or Ctrl+C to abort'), ''),
777 ]
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100778
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100779 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200780 ((['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] +
781 ([custom_cl_base] if custom_cl_base else
782 [ancestor_revision, 'HEAD']),),
783 '+dat'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100784 ]
Edward Lemur2c62b332020-03-12 22:12:33 +0000785
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100786 return calls
ukai@chromium.orge8077812012-02-03 03:41:46 +0000787
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +0000788 def _gerrit_upload_calls(self,
789 description,
790 reviewers,
791 squash,
tandriia60502f2016-06-20 02:01:53 -0700792 squash_mode='default',
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +0000793 title=None,
794 notify=False,
795 post_amend_description=None,
796 issue=None,
797 cc=None,
798 custom_cl_base=None,
799 tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +0000800 short_hostname='chromium',
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +0000801 labels=None,
802 change_id=None,
803 final_description=None,
804 gitcookies_exists=True,
805 force=False,
806 edit_description=None,
Josip Sokcevic7e133ff2021-07-13 17:44:53 +0000807 default_branch='main',
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +0000808 push_opts=None):
tandrii@chromium.org10625002016-03-04 20:03:47 +0000809 if post_amend_description is None:
810 post_amend_description = description
bradnelsond975b302016-10-23 12:20:23 -0700811 cc = cc or []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200812
813 calls = []
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000814
Edward Lesmes4de54132020-05-05 19:41:33 +0000815 if squash_mode in ('override_squash', 'override_nosquash'):
816 self.mockGit.config['gerrit.override-squash-uploads'] = (
817 'true' if squash_mode == 'override_squash' else 'false')
818
tandrii@chromium.org57d86542016-03-04 16:11:32 +0000819 if not git_footers.get_footer_change_id(description) and not squash:
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000820 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200821 (('DownloadGerritHook', False), ''),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200822 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000823 if squash:
Edward Lemur5a644f82020-03-18 16:44:57 +0000824 if not issue and not force:
Edward Lemur5fb22242020-03-12 22:05:13 +0000825 calls += [
826 ((['RunEditor'],), description),
827 ]
Josipe827b0f2020-01-30 00:07:20 +0000828 # user wants to edit description
829 if edit_description:
830 calls += [
Josipe827b0f2020-01-30 00:07:20 +0000831 ((['RunEditor'],), edit_description),
832 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000833 ref_to_push = 'abcdef0123456789'
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200834
835 if custom_cl_base is None:
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000836 parent = 'origin/' + default_branch
Edward Lesmes8c43c3f2021-01-20 00:20:26 +0000837 git_common.get_or_create_merge_base.return_value = parent
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200838 else:
839 calls += [
840 ((['git', 'merge-base', '--is-ancestor', custom_cl_base,
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000841 'refs/remotes/origin/' + default_branch],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200842 callError(1)), # Means not ancenstor.
843 (('ask_for_data',
844 'Do you take responsibility for cleaning up potential mess '
845 'resulting from proceeding with upload? Press Enter to upload, '
846 'or Ctrl+C to abort'), ''),
847 ]
848 parent = custom_cl_base
849
850 calls += [
851 ((['git', 'rev-parse', 'HEAD:'],), # `HEAD:` means HEAD's tree hash.
852 '0123456789abcdef'),
Edward Lemur1773f372020-02-22 00:27:14 +0000853 ((['FileWrite', '/tmp/fake-temp1', description],), None),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200854 ((['git', 'commit-tree', '0123456789abcdef', '-p', parent,
Edward Lemur1773f372020-02-22 00:27:14 +0000855 '-F', '/tmp/fake-temp1'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200856 ref_to_push),
857 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000858 else:
859 ref_to_push = 'HEAD'
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000860 parent = 'origin/refs/heads/' + default_branch
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000861
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000862 calls += [
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000863 (('SaveDescriptionBackup',), None),
Edward Lemur5a644f82020-03-18 16:44:57 +0000864 ((['git', 'rev-list', parent + '..' + ref_to_push],),'1hashPerLine\n'),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200865 ]
tandrii@chromium.org8da45402016-05-24 23:11:03 +0000866
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +0000867 metrics_arguments = []
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000868
Aaron Gableafd52772017-06-27 16:40:10 -0700869 if notify:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +0000870 ref_suffix = '%ready,notify=ALL'
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000871 metrics_arguments += ['ready', 'notify=ALL']
Aaron Gable844cf292017-06-28 11:32:59 -0700872 else:
Jamie Madill276da0b2018-04-27 14:41:20 -0400873 if not issue and squash:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +0000874 ref_suffix = '%wip'
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000875 metrics_arguments.append('wip')
Aaron Gable844cf292017-06-28 11:32:59 -0700876 else:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +0000877 ref_suffix = '%notify=NONE'
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000878 metrics_arguments.append('notify=NONE')
Aaron Gable9b713dd2016-12-14 16:04:21 -0800879
Edward Lemur5a644f82020-03-18 16:44:57 +0000880 # If issue is given, then description is fetched from Gerrit instead.
manukh566e9d02022-06-30 19:49:53 +0000881 if not title:
882 if issue is None:
883 if squash:
884 title = 'Initial upload'
885 else:
Edward Lemur5a644f82020-03-18 16:44:57 +0000886 calls += [
887 ((['git', 'show', '-s', '--format=%s', 'HEAD'],), ''),
888 (('ask_for_data', 'Title for patchset []: '), 'User input'),
889 ]
890 title = 'User input'
Aaron Gable70f4e242017-06-26 10:45:59 -0700891 if title:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +0000892 ref_suffix += ',m=' + gerrit_util.PercentEncodeForGitRef(title)
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000893 metrics_arguments.append('m')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000894
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000895 if short_hostname == 'chromium':
Quinten Yearsley925cedb2020-04-13 17:49:39 +0000896 # All reviewers and ccs get into ref_suffix.
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000897 for r in sorted(reviewers):
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +0000898 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000899 metrics_arguments.append('r')
Edward Lemur4508b422019-10-03 21:56:35 +0000900 if issue is None:
Edward Lemur227d5102020-02-25 23:45:35 +0000901 cc += ['test-more-cc@chromium.org', 'joe@example.com']
Edward Lemur4508b422019-10-03 21:56:35 +0000902 for c in sorted(cc):
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +0000903 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000904 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000905 reviewers, cc = [], []
906 else:
907 # TODO(crbug/877717): remove this case.
908 calls += [
909 (('ValidAccounts', '%s-review.googlesource.com' % short_hostname,
910 sorted(reviewers) + ['joe@example.com',
Edward Lemur227d5102020-02-25 23:45:35 +0000911 'test-more-cc@chromium.org'] + cc),
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000912 {
913 e: {'email': e}
914 for e in (reviewers + ['joe@example.com'] + cc)
915 })
916 ]
917 for r in sorted(reviewers):
918 if r != 'bad-account-or-email':
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +0000919 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000920 metrics_arguments.append('r')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000921 reviewers.remove(r)
Edward Lemur4508b422019-10-03 21:56:35 +0000922 if issue is None:
923 cc += ['joe@example.com']
924 for c in sorted(cc):
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +0000925 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000926 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000927 if c in cc:
928 cc.remove(c)
Andrii Shyshkalov76988a82018-10-15 03:12:25 +0000929
Edward Lemur687ca902018-12-05 02:30:30 +0000930 for k, v in sorted((labels or {}).items()):
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +0000931 ref_suffix += ',l=%s+%d' % (k, v)
Edward Lemur687ca902018-12-05 02:30:30 +0000932 metrics_arguments.append('l=%s+%d' % (k, v))
933
934 if tbr:
935 calls += [
936 (('GetCodeReviewTbrScore',
937 '%s-review.googlesource.com' % short_hostname,
938 'my/repo'),
939 2,),
940 ]
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +0000941
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000942 calls += [
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +0000943 (
944 ('time.time', ),
945 1000,
946 ),
947 (
948 ([
949 'git', 'push',
950 'https://%s.googlesource.com/my/repo' % short_hostname,
951 ref_to_push + ':refs/for/refs/heads/' + default_branch +
952 ref_suffix
953 ] + (push_opts if push_opts else []), ),
954 (('remote:\n'
955 'remote: Processing changes: (\)\n'
956 'remote: Processing changes: (|)\n'
957 'remote: Processing changes: (/)\n'
958 'remote: Processing changes: (-)\n'
959 'remote: Processing changes: new: 1 (/)\n'
960 'remote: Processing changes: new: 1, done\n'
961 'remote:\n'
962 'remote: New Changes:\n'
963 'remote: '
964 'https://%s-review.googlesource.com/#/c/my/repo/+/123456'
965 ' XXX\n'
966 'remote:\n'
967 'To https://%s.googlesource.com/my/repo\n'
968 ' * [new branch] hhhh -> refs/for/refs/heads/%s\n') %
969 (short_hostname, short_hostname, default_branch)),
970 ),
971 (
972 ('time.time', ),
973 2000,
974 ),
975 (
976 ('add_repeated', 'sub_commands', {
977 'execution_time': 1000,
978 'command': 'git push',
979 'exit_code': 0,
980 'arguments': sorted(metrics_arguments),
981 }),
982 None,
983 ),
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000984 ]
985
Edward Lemur1b52d872019-05-09 21:12:12 +0000986 final_description = final_description or post_amend_description.strip()
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000987
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000988 trace_name = os.path.join('TRACES_DIR', '20170316T200041.000000')
989
Edward Lemur1b52d872019-05-09 21:12:12 +0000990 # Trace-related calls
991 calls += [
992 # Write a description with context for the current trace.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000993 (
994 ([
995 'FileWrite', trace_name + '-README',
996 '%(date)s\n'
997 '%(short_hostname)s-review.googlesource.com\n'
998 '%(change_id)s\n'
999 '%(title)s\n'
1000 '%(description)s\n'
1001 '1000\n'
1002 '0\n'
1003 '%(trace_name)s' % {
Josip Sokcevic5e18b602020-04-23 21:47:00 +00001004 'date': '2017-03-16T20:00:41.000000',
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001005 'short_hostname': short_hostname,
1006 'change_id': change_id,
1007 'description': final_description,
1008 'title': title or '<untitled>',
1009 'trace_name': trace_name,
1010 }
1011 ], ),
1012 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001013 ),
1014 # Read traces and shorten git hashes.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001015 (
1016 (['os.path.isfile',
1017 os.path.join('TEMP_DIR', 'trace-packet')], ),
1018 True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001019 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001020 (
1021 (['FileRead', os.path.join('TEMP_DIR', 'trace-packet')], ),
1022 ('git-hash: 0123456789012345678901234567890123456789\n'
1023 'git-hash: abcdeabcdeabcdeabcdeabcdeabcdeabcdeabcde\n'),
Edward Lemur1b52d872019-05-09 21:12:12 +00001024 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001025 (
1026 ([
1027 'FileWrite',
1028 os.path.join('TEMP_DIR', 'trace-packet'), 'git-hash: 012345\n'
1029 'git-hash: abcdea\n'
1030 ], ),
1031 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001032 ),
1033 # Make zip file for the git traces.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001034 (
1035 (['make_archive', trace_name + '-traces', 'zip', 'TEMP_DIR'], ),
1036 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001037 ),
1038 # Collect git config and gitcookies.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001039 (
1040 (['git', 'config', '-l'], ),
1041 'git-config-output',
Edward Lemur1b52d872019-05-09 21:12:12 +00001042 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001043 (
1044 ([
1045 'FileWrite',
1046 os.path.join('TEMP_DIR', 'git-config'), 'git-config-output'
1047 ], ),
1048 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001049 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001050 (
1051 (['os.path.isfile',
1052 os.path.join('~', '.gitcookies')], ),
1053 gitcookies_exists,
Edward Lemur1b52d872019-05-09 21:12:12 +00001054 ),
1055 ]
1056 if gitcookies_exists:
1057 calls += [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001058 (
1059 (['FileRead', os.path.join('~', '.gitcookies')], ),
1060 'gitcookies 1/SECRET',
Edward Lemur1b52d872019-05-09 21:12:12 +00001061 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001062 (
1063 ([
1064 'FileWrite',
1065 os.path.join('TEMP_DIR', 'gitcookies'), 'gitcookies REDACTED'
1066 ], ),
1067 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001068 ),
1069 ]
1070 calls += [
1071 # Make zip file for the git config and gitcookies.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001072 (
1073 (['make_archive', trace_name + '-git-info', 'zip', 'TEMP_DIR'], ),
1074 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001075 ),
1076 ]
1077
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001078 # TODO(crbug/877717): this should never be used.
1079 if squash and short_hostname != 'chromium':
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001080 calls += [
1081 (('AddReviewers',
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001082 'chromium-review.googlesource.com', 'my%2Frepo~123456',
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001083 sorted(reviewers),
Edward Lemur227d5102020-02-25 23:45:35 +00001084 cc + ['test-more-cc@chromium.org'],
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00001085 notify),
1086 ''),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001087 ]
ukai@chromium.orge8077812012-02-03 03:41:46 +00001088 return calls
1089
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00001090 def _run_gerrit_upload_test(self,
1091 upload_args,
1092 description,
1093 reviewers=None,
1094 squash=True,
1095 squash_mode=None,
1096 title=None,
1097 notify=False,
1098 post_amend_description=None,
1099 issue=None,
1100 cc=None,
1101 fetched_status=None,
1102 other_cl_owner=None,
1103 custom_cl_base=None,
1104 tbr=None,
1105 short_hostname='chromium',
1106 labels=None,
1107 change_id=None,
1108 final_description=None,
1109 gitcookies_exists=True,
1110 force=False,
1111 log_description=None,
1112 edit_description=None,
1113 fetched_description=None,
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00001114 default_branch='main',
Joanna Wang583ca662022-04-27 21:17:17 +00001115 push_opts=None,
1116 reset_issue=False):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001117 """Generic gerrit upload test framework."""
tandriia60502f2016-06-20 02:01:53 -07001118 if squash_mode is None:
1119 if '--no-squash' in upload_args:
1120 squash_mode = 'nosquash'
1121 elif '--squash' in upload_args:
1122 squash_mode = 'squash'
1123 else:
1124 squash_mode = 'default'
1125
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001126 reviewers = reviewers or []
bradnelsond975b302016-10-23 12:20:23 -07001127 cc = cc or []
Edward Lemurda4b6c62020-02-13 00:28:40 +00001128 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001129 CookiesAuthenticatorMockFactory(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001130 same_auth=('git-owner.example.com', '', 'pass'))).start()
1131 mock.patch('git_cl.Changelist._GerritCommitMsgHookCheck',
1132 lambda _, offer_removal: None).start()
1133 mock.patch('git_cl.gclient_utils.RunEditor',
1134 lambda *_, **__: self._mocked_call(['RunEditor'])).start()
1135 mock.patch('git_cl.DownloadGerritHook', lambda force: self._mocked_call(
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001136 'DownloadGerritHook', force)).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00001137 mock.patch('git_cl.gclient_utils.FileRead',
1138 lambda path: self._mocked_call(['FileRead', path])).start()
1139 mock.patch('git_cl.gclient_utils.FileWrite',
Edward Lemur1b52d872019-05-09 21:12:12 +00001140 lambda path, contents: self._mocked_call(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001141 ['FileWrite', path, contents])).start()
1142 mock.patch('git_cl.datetime_now',
1143 lambda: datetime.datetime(2017, 3, 16, 20, 0, 41, 0)).start()
1144 mock.patch('git_cl.tempfile.mkdtemp', lambda: 'TEMP_DIR').start()
1145 mock.patch('git_cl.TRACES_DIR', 'TRACES_DIR').start()
1146 mock.patch('git_cl.TRACES_README_FORMAT',
Edward Lemur75391d42019-05-14 23:35:56 +00001147 '%(now)s\n'
1148 '%(gerrit_host)s\n'
1149 '%(change_id)s\n'
1150 '%(title)s\n'
1151 '%(description)s\n'
1152 '%(execution_time)s\n'
1153 '%(exit_code)s\n'
Edward Lemurda4b6c62020-02-13 00:28:40 +00001154 '%(trace_name)s').start()
1155 mock.patch('git_cl.shutil.make_archive',
1156 lambda *args: self._mocked_call(['make_archive'] +
1157 list(args))).start()
1158 mock.patch('os.path.isfile',
1159 lambda path: self._mocked_call(['os.path.isfile', path])).start()
Edward Lemur9aa1a962020-02-25 00:58:38 +00001160 mock.patch(
Edward Lesmes0dd54822020-03-26 18:24:25 +00001161 'git_cl._create_description_from_log',
1162 return_value=log_description or description).start()
Edward Lemura12175c2020-03-09 16:58:26 +00001163 mock.patch(
1164 'git_cl.Changelist._AddChangeIdToCommitMessage',
1165 return_value=post_amend_description or description).start()
Edward Lemur1a83da12020-03-04 21:18:36 +00001166 mock.patch(
Edward Lemur5a644f82020-03-18 16:44:57 +00001167 'git_cl.GenerateGerritChangeId', return_value=change_id).start()
1168 mock.patch(
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001169 'git_common.get_or_create_merge_base',
1170 return_value='origin/' + default_branch).start()
1171 mock.patch(
Edward Lesmesae3586b2020-03-23 21:21:14 +00001172 'gclient_utils.AskForData',
Edward Lemur1a83da12020-03-04 21:18:36 +00001173 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
tandriia60502f2016-06-20 02:01:53 -07001174
Edward Lemur26964072020-02-19 19:18:51 +00001175 self.mockGit.config['gerrit.host'] = 'true'
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00001176 self.mockGit.config['branch.main.gerritissue'] = (
Edward Lemur85153282020-02-14 22:06:29 +00001177 str(issue) if issue else None)
1178 self.mockGit.config['remote.origin.url'] = (
1179 'https://%s.googlesource.com/my/repo' % short_hostname)
Edward Lemur9aa1a962020-02-25 00:58:38 +00001180 self.mockGit.config['user.email'] = 'me@example.com'
Edward Lemur85153282020-02-14 22:06:29 +00001181
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001182 self.calls = self._gerrit_base_calls(
1183 issue=issue,
Anthony Polito8b955342019-09-24 19:01:36 +00001184 fetched_description=fetched_description or description,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001185 fetched_status=fetched_status,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001186 other_cl_owner=other_cl_owner,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001187 custom_cl_base=custom_cl_base,
Anthony Polito8b955342019-09-24 19:01:36 +00001188 short_hostname=short_hostname,
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001189 change_id=change_id,
Joanna Wang583ca662022-04-27 21:17:17 +00001190 default_branch=default_branch,
1191 reset_issue=reset_issue)
1192
1193 if fetched_status == 'ABANDONED' or (
1194 fetched_status == 'MERGED' and not reset_issue):
1195 pass # readability
1196 else:
1197 if fetched_status == 'MERGED' and reset_issue:
1198 fetched_status = 'NEW'
1199 issue = None
Edward Lemurda4b6c62020-02-13 00:28:40 +00001200 mock.patch(
Edward Lemur1773f372020-02-22 00:27:14 +00001201 'gclient_utils.temporary_file', TemporaryFileMock()).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00001202 mock.patch('os.remove', return_value=True).start()
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001203 self.calls += self._gerrit_upload_calls(
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00001204 description,
1205 reviewers,
1206 squash,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001207 squash_mode=squash_mode,
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00001208 title=title,
1209 notify=notify,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001210 post_amend_description=post_amend_description,
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00001211 issue=issue,
1212 cc=cc,
1213 custom_cl_base=custom_cl_base,
1214 tbr=tbr,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001215 short_hostname=short_hostname,
Edward Lemur1b52d872019-05-09 21:12:12 +00001216 labels=labels,
1217 change_id=change_id,
Edward Lemur1b52d872019-05-09 21:12:12 +00001218 final_description=final_description,
Anthony Polito8b955342019-09-24 19:01:36 +00001219 gitcookies_exists=gitcookies_exists,
Josipe827b0f2020-01-30 00:07:20 +00001220 force=force,
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001221 edit_description=edit_description,
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00001222 default_branch=default_branch,
1223 push_opts=push_opts)
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001224 # Uncomment when debugging.
Raul Tambre80ee78e2019-05-06 22:41:05 +00001225 # print('\n'.join(map(lambda x: '%2i: %s' % x, enumerate(self.calls))))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001226 git_cl.main(['upload'] + upload_args)
Edward Lemur85153282020-02-14 22:06:29 +00001227 if squash:
Edward Lemur26964072020-02-19 19:18:51 +00001228 self.assertIssueAndPatchset(patchset=None)
Edward Lemur85153282020-02-14 22:06:29 +00001229 self.assertEqual(
1230 'abcdef0123456789',
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00001231 scm.GIT.GetBranchConfig('', 'main', 'gerritsquashhash'))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001232
Edward Lemur1b52d872019-05-09 21:12:12 +00001233 def test_gerrit_upload_traces_no_gitcookies(self):
1234 self._run_gerrit_upload_test(
1235 ['--no-squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001236 'desc ✔\n\nBUG=\n',
Edward Lemur1b52d872019-05-09 21:12:12 +00001237 [],
1238 squash=False,
Edward Lemur0db01f02019-11-12 22:01:51 +00001239 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001240 change_id='Ixxx',
1241 gitcookies_exists=False)
1242
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001243 def test_gerrit_upload_without_change_id(self):
tandriia60502f2016-06-20 02:01:53 -07001244 self._run_gerrit_upload_test(
Edward Lemur5a644f82020-03-18 16:44:57 +00001245 [],
1246 'desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
1247 [],
1248 change_id='Ixxx')
1249
1250 def test_gerrit_upload_without_change_id_nosquash(self):
1251 self._run_gerrit_upload_test(
tandriia60502f2016-06-20 02:01:53 -07001252 ['--no-squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001253 'desc ✔\n\nBUG=\n',
tandriia60502f2016-06-20 02:01:53 -07001254 [],
1255 squash=False,
Edward Lemur0db01f02019-11-12 22:01:51 +00001256 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001257 change_id='Ixxx')
tandriia60502f2016-06-20 02:01:53 -07001258
Edward Lesmes4de54132020-05-05 19:41:33 +00001259 def test_gerrit_upload_without_change_id_override_nosquash(self):
1260 self._run_gerrit_upload_test(
1261 [],
1262 'desc ✔\n\nBUG=\n',
1263 [],
1264 squash=False,
1265 squash_mode='override_nosquash',
1266 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
1267 change_id='Ixxx')
1268
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001269 def test_gerrit_no_reviewer(self):
1270 self._run_gerrit_upload_test(
Edward Lesmes4de54132020-05-05 19:41:33 +00001271 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001272 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
tandriia60502f2016-06-20 02:01:53 -07001273 [],
1274 squash=False,
Edward Lesmes4de54132020-05-05 19:41:33 +00001275 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001276 change_id='I123456789')
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001277
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00001278 def test_gerrit_push_opts(self):
1279 self._run_gerrit_upload_test(['-o', 'wip'],
1280 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
1281 [],
1282 squash=False,
1283 squash_mode='override_nosquash',
1284 change_id='I123456789',
1285 push_opts=['-o', 'wip'])
1286
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001287 def test_gerrit_no_reviewer_non_chromium_host(self):
1288 # TODO(crbug/877717): remove this test case.
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00001289 self._run_gerrit_upload_test([],
1290 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
1291 [],
1292 squash=False,
1293 squash_mode='override_nosquash',
1294 short_hostname='other',
1295 change_id='I123456789')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001296
Edward Lesmes0dd54822020-03-26 18:24:25 +00001297 def test_gerrit_patchset_title_special_chars_nosquash(self):
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001298 self._run_gerrit_upload_test(
Edward Lesmes4de54132020-05-05 19:41:33 +00001299 ['-f', '-t', 'We\'ll escape ^_ ^ special chars...@{u}'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001300 'desc ✔\n\nBUG=\n\nChange-Id: I123456789',
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001301 squash=False,
Edward Lesmes4de54132020-05-05 19:41:33 +00001302 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001303 change_id='I123456789',
Edward Lemur5a644f82020-03-18 16:44:57 +00001304 title='We\'ll escape ^_ ^ special chars...@{u}')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001305
ukai@chromium.orge8077812012-02-03 03:41:46 +00001306 def test_gerrit_reviewers_cmd_line(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001307 self._run_gerrit_upload_test(
Edward Lesmes4de54132020-05-05 19:41:33 +00001308 ['-r', 'foo@example.com', '--send-mail'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001309 'desc ✔\n\nBUG=\n\nChange-Id: I123456789',
Edward Lemur5a644f82020-03-18 16:44:57 +00001310 reviewers=['foo@example.com'],
tandriia60502f2016-06-20 02:01:53 -07001311 squash=False,
Edward Lesmes4de54132020-05-05 19:41:33 +00001312 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001313 notify=True,
1314 change_id='I123456789',
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001315 final_description=(
Edward Lemur0db01f02019-11-12 22:01:51 +00001316 'desc ✔\n\nBUG=\nR=foo@example.com\n\nChange-Id: I123456789'))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001317
Anthony Polito8b955342019-09-24 19:01:36 +00001318 def test_gerrit_upload_force_sets_bug(self):
1319 self._run_gerrit_upload_test(
1320 ['-b', '10000', '-f'],
1321 u'desc=\n\nBug: 10000\nChange-Id: Ixxx',
1322 [],
1323 force=True,
Anthony Polito8b955342019-09-24 19:01:36 +00001324 fetched_description='desc=\n\nChange-Id: Ixxx',
Anthony Polito8b955342019-09-24 19:01:36 +00001325 change_id='Ixxx')
1326
Edward Lemur5fb22242020-03-12 22:05:13 +00001327 def test_gerrit_upload_corrects_wrong_change_id(self):
Anthony Polito8b955342019-09-24 19:01:36 +00001328 self._run_gerrit_upload_test(
Edward Lemur5fb22242020-03-12 22:05:13 +00001329 ['-b', '10000', '-m', 'Title', '--edit-description'],
1330 u'desc=\n\nBug: 10000\nChange-Id: Ixxxx',
Anthony Polito8b955342019-09-24 19:01:36 +00001331 [],
Anthony Polito8b955342019-09-24 19:01:36 +00001332 issue='123456',
Edward Lemur5fb22242020-03-12 22:05:13 +00001333 edit_description='desc=\n\nBug: 10000\nChange-Id: Izzzz',
Anthony Polito8b955342019-09-24 19:01:36 +00001334 fetched_description='desc=\n\nChange-Id: Ixxxx',
Anthony Polito8b955342019-09-24 19:01:36 +00001335 title='Title',
Edward Lemur5fb22242020-03-12 22:05:13 +00001336 change_id='Ixxxx')
Anthony Polito8b955342019-09-24 19:01:36 +00001337
Dan Beamd8b04ca2019-10-10 21:23:26 +00001338 def test_gerrit_upload_force_sets_fixed(self):
1339 self._run_gerrit_upload_test(
1340 ['-x', '10000', '-f'],
1341 u'desc=\n\nFixed: 10000\nChange-Id: Ixxx',
1342 [],
1343 force=True,
Dan Beamd8b04ca2019-10-10 21:23:26 +00001344 fetched_description='desc=\n\nChange-Id: Ixxx',
Dan Beamd8b04ca2019-10-10 21:23:26 +00001345 change_id='Ixxx')
1346
ukai@chromium.orge8077812012-02-03 03:41:46 +00001347 def test_gerrit_reviewer_multiple(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00001348 mock.patch('git_cl.gerrit_util.GetCodeReviewTbrScore',
1349 lambda *a: self._mocked_call('GetCodeReviewTbrScore', *a)).start()
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001350 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001351 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001352 'desc ✔\nTBR=reviewer@example.com\nBUG=\nR=another@example.com\n'
bradnelsond975b302016-10-23 12:20:23 -07001353 'CC=more@example.com,people@example.com\n\n'
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001354 'Change-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001355 ['reviewer@example.com', 'another@example.com'],
Aaron Gablefd238082017-06-07 13:42:34 -07001356 cc=['more@example.com', 'people@example.com'],
Edward Lemur687ca902018-12-05 02:30:30 +00001357 tbr='reviewer@example.com',
Edward Lemur1b52d872019-05-09 21:12:12 +00001358 labels={'Code-Review': 2},
Edward Lemur5a644f82020-03-18 16:44:57 +00001359 change_id='123456789')
tandriia60502f2016-06-20 02:01:53 -07001360
1361 def test_gerrit_upload_squash_first_is_default(self):
tandriia60502f2016-06-20 02:01:53 -07001362 self._run_gerrit_upload_test(
1363 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001364 'desc ✔\nBUG=\n\nChange-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001365 [],
Edward Lemur5a644f82020-03-18 16:44:57 +00001366 change_id='123456789')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001367
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001368 def test_gerrit_upload_squash_first(self):
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001369 self._run_gerrit_upload_test(
1370 ['--squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001371 'desc ✔\nBUG=\n\nChange-Id: 123456789',
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001372 [],
luqui@chromium.org609f3952015-05-04 22:47:04 +00001373 squash=True,
Edward Lemur5a644f82020-03-18 16:44:57 +00001374 change_id='123456789')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001375
Edward Lesmes0dd54822020-03-26 18:24:25 +00001376 def test_gerrit_upload_squash_first_title(self):
1377 self._run_gerrit_upload_test(
1378 ['-f', '-t', 'title'],
1379 'title\n\ndesc\n\nChange-Id: 123456789',
1380 [],
manukh566e9d02022-06-30 19:49:53 +00001381 title='title',
Edward Lesmes0dd54822020-03-26 18:24:25 +00001382 force=True,
1383 squash=True,
1384 log_description='desc',
1385 change_id='123456789')
1386
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001387 def test_gerrit_upload_squash_first_with_labels(self):
1388 self._run_gerrit_upload_test(
1389 ['--squash', '--cq-dry-run', '--enable-auto-submit'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001390 'desc ✔\nBUG=\n\nChange-Id: 123456789',
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001391 [],
1392 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001393 labels={'Commit-Queue': 1, 'Auto-Submit': 1},
Edward Lemur5a644f82020-03-18 16:44:57 +00001394 change_id='123456789')
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001395
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001396 def test_gerrit_upload_squash_first_against_rev(self):
1397 custom_cl_base = 'custom_cl_base_rev_or_branch'
1398 self._run_gerrit_upload_test(
1399 ['--squash', custom_cl_base],
Edward Lemur0db01f02019-11-12 22:01:51 +00001400 'desc ✔\nBUG=\n\nChange-Id: 123456789',
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001401 [],
1402 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001403 custom_cl_base=custom_cl_base,
Edward Lemur5a644f82020-03-18 16:44:57 +00001404 change_id='123456789')
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001405 self.assertIn(
1406 'If you proceed with upload, more than 1 CL may be created by Gerrit',
1407 sys.stdout.getvalue())
1408
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001409 def test_gerrit_upload_squash_reupload(self):
Edward Lemur0db01f02019-11-12 22:01:51 +00001410 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001411 self._run_gerrit_upload_test(
1412 ['--squash'],
1413 description,
1414 [],
1415 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001416 issue=123456,
Edward Lemur5a644f82020-03-18 16:44:57 +00001417 change_id='123456789')
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001418
Edward Lemurd55c5072020-02-20 01:09:07 +00001419 @mock.patch('sys.stderr', StringIO())
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001420 def test_gerrit_upload_squash_reupload_to_abandoned(self):
Edward Lemur0db01f02019-11-12 22:01:51 +00001421 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001422 with self.assertRaises(SystemExitMock):
1423 self._run_gerrit_upload_test(
1424 ['--squash'],
1425 description,
1426 [],
1427 squash=True,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001428 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001429 fetched_status='ABANDONED',
1430 change_id='123456789')
Edward Lemurd55c5072020-02-20 01:09:07 +00001431 self.assertEqual(
1432 'Change https://chromium-review.googlesource.com/123456 has been '
1433 'abandoned, new uploads are not allowed\n',
1434 sys.stderr.getvalue())
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001435
Edward Lemurda4b6c62020-02-13 00:28:40 +00001436 @mock.patch(
1437 'gerrit_util.GetAccountDetails',
1438 return_value={'email': 'yet-another@example.com'})
1439 def test_gerrit_upload_squash_reupload_to_not_owned(self, _mock):
Edward Lemur0db01f02019-11-12 22:01:51 +00001440 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001441 self._run_gerrit_upload_test(
1442 ['--squash'],
1443 description,
1444 [],
1445 squash=True,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001446 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001447 other_cl_owner='other@example.com',
Edward Lemur5a644f82020-03-18 16:44:57 +00001448 change_id='123456789')
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001449 self.assertIn(
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001450 'WARNING: Change 123456 is owned by other@example.com, but you '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001451 'authenticate to Gerrit as yet-another@example.com.\n'
1452 'Uploading may fail due to lack of permissions',
Edward Lemurda4b6c62020-02-13 00:28:40 +00001453 sys.stdout.getvalue())
Joanna Wang583ca662022-04-27 21:17:17 +00001454 @mock.patch('sys.stderr', StringIO())
1455 def test_gerrit_upload_for_merged(self):
1456 with self.assertRaises(SystemExitMock):
1457 self._run_gerrit_upload_test(
1458 [],
1459 'desc ✔\n\nBUG=\n\nChange-Id: I123456789',
1460 [],
1461 issue=123456,
1462 fetched_status='MERGED',
1463 change_id='I123456789',
1464 reset_issue=False)
1465 self.assertEqual(
1466 'New uploads are not allowed.\n',
1467 sys.stderr.getvalue())
1468
1469 def test_gerrit_upload_new_issue_for_merged(self):
1470 self._run_gerrit_upload_test(
1471 [],
1472 'desc ✔\n\nBUG=\n\nChange-Id: I123456789',
1473 [],
1474 issue=123456,
1475 fetched_status='MERGED',
1476 change_id='I123456789',
1477 reset_issue=True)
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001478
Josipe827b0f2020-01-30 00:07:20 +00001479 def test_upload_change_description_editor(self):
1480 fetched_description = 'foo\n\nChange-Id: 123456789'
1481 description = 'bar\n\nChange-Id: 123456789'
1482 self._run_gerrit_upload_test(
1483 ['--squash', '--edit-description'],
1484 description,
1485 [],
1486 fetched_description=fetched_description,
1487 squash=True,
Josipe827b0f2020-01-30 00:07:20 +00001488 issue=123456,
1489 change_id='123456789',
Josipe827b0f2020-01-30 00:07:20 +00001490 edit_description=description)
1491
Edward Lemurda4b6c62020-02-13 00:28:40 +00001492 @mock.patch('git_cl.RunGit')
1493 @mock.patch('git_cl.CMDupload')
Edward Lemur1a83da12020-03-04 21:18:36 +00001494 @mock.patch('sys.stdin', StringIO('\n'))
1495 @mock.patch('sys.stdout', StringIO())
Edward Lemurda4b6c62020-02-13 00:28:40 +00001496 def test_upload_branch_deps(self, *_mocks):
rmistry@google.com2dd99862015-06-22 12:22:18 +00001497 def mock_run_git(*args, **_kwargs):
1498 if args[0] == ['for-each-ref',
1499 '--format=%(refname:short) %(upstream:short)',
1500 'refs/heads']:
1501 # Create a local branch dependency tree that looks like this:
1502 # test1 -> test2 -> test3 -> test4 -> test5
1503 # -> test3.1
1504 # test6 -> test0
1505 branch_deps = [
1506 'test2 test1', # test1 -> test2
1507 'test3 test2', # test2 -> test3
1508 'test3.1 test2', # test2 -> test3.1
1509 'test4 test3', # test3 -> test4
1510 'test5 test4', # test4 -> test5
1511 'test6 test0', # test0 -> test6
1512 'test7', # test7
1513 ]
1514 return '\n'.join(branch_deps)
Edward Lemurda4b6c62020-02-13 00:28:40 +00001515 git_cl.RunGit.side_effect = mock_run_git
1516 git_cl.CMDupload.return_value = 0
rmistry@google.com2dd99862015-06-22 12:22:18 +00001517
1518 class MockChangelist():
1519 def __init__(self):
1520 pass
1521 def GetBranch(self):
1522 return 'test1'
1523 def GetIssue(self):
1524 return '123'
1525 def GetPatchset(self):
1526 return '1001'
tandrii@chromium.org4c72b082016-03-31 22:26:35 +00001527 def IsGerrit(self):
1528 return False
rmistry@google.com2dd99862015-06-22 12:22:18 +00001529
1530 ret = git_cl.upload_branch_deps(MockChangelist(), [])
1531 # CMDupload should have been called 5 times because of 5 dependent branches.
Edward Lemurda4b6c62020-02-13 00:28:40 +00001532 self.assertEqual(5, len(git_cl.CMDupload.mock_calls))
Edward Lemur1a83da12020-03-04 21:18:36 +00001533 self.assertIn(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001534 'This command will checkout all dependent branches '
1535 'and run "git cl upload". Press Enter to continue, '
Edward Lemur1a83da12020-03-04 21:18:36 +00001536 'or Ctrl+C to abort',
1537 sys.stdout.getvalue())
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00001538 self.assertEqual(0, ret)
rmistry@google.com2dd99862015-06-22 12:22:18 +00001539
tandrii@chromium.org65874e12016-03-04 12:03:02 +00001540 def test_gerrit_change_id(self):
1541 self.calls = [
1542 ((['git', 'write-tree'], ),
1543 'hashtree'),
1544 ((['git', 'rev-parse', 'HEAD~0'], ),
1545 'branch-parent'),
1546 ((['git', 'var', 'GIT_AUTHOR_IDENT'], ),
1547 'A B <a@b.org> 1456848326 +0100'),
1548 ((['git', 'var', 'GIT_COMMITTER_IDENT'], ),
1549 'C D <c@d.org> 1456858326 +0100'),
1550 ((['git', 'hash-object', '-t', 'commit', '--stdin'], ),
1551 'hashchange'),
1552 ]
1553 change_id = git_cl.GenerateGerritChangeId('line1\nline2\n')
1554 self.assertEqual(change_id, 'Ihashchange')
1555
Edward Lesmes8170c292021-03-19 20:04:43 +00001556 @mock.patch('gerrit_util.IsCodeOwnersEnabledOnHost')
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001557 @mock.patch('git_cl.Settings.GetBugPrefix')
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001558 @mock.patch('git_cl.Changelist.FetchDescription')
1559 @mock.patch('git_cl.Changelist.GetBranch')
Edward Lesmes1eaaab52021-03-02 23:52:54 +00001560 @mock.patch('git_cl.Changelist.GetCommonAncestorWithUpstream')
Edward Lesmese1576912021-02-16 21:53:34 +00001561 @mock.patch('git_cl.Changelist.GetGerritHost')
1562 @mock.patch('git_cl.Changelist.GetGerritProject')
1563 @mock.patch('git_cl.Changelist.GetRemoteBranch')
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001564 @mock.patch('owners_client.OwnersClient.BatchListOwners')
1565 def getDescriptionForUploadTest(
Edward Lesmese1576912021-02-16 21:53:34 +00001566 self, mockBatchListOwners=None, mockGetRemoteBranch=None,
Edward Lesmes1eaaab52021-03-02 23:52:54 +00001567 mockGetGerritProject=None, mockGetGerritHost=None,
1568 mockGetCommonAncestorWithUpstream=None, mockGetBranch=None,
Edward Lesmese1576912021-02-16 21:53:34 +00001569 mockFetchDescription=None, mockGetBugPrefix=None,
Edward Lesmes8170c292021-03-19 20:04:43 +00001570 mockIsCodeOwnersEnabledOnHost=None,
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001571 initial_description='desc', bug=None, fixed=None, branch='branch',
1572 reviewers=None, tbrs=None, add_owners_to=None,
1573 expected_description='desc'):
1574 reviewers = reviewers or []
1575 tbrs = tbrs or []
1576 owners_by_path = {
1577 'a': ['a@example.com'],
1578 'b': ['b@example.com'],
1579 'c': ['c@example.com'],
1580 }
Edward Lesmes8170c292021-03-19 20:04:43 +00001581 mockIsCodeOwnersEnabledOnHost.return_value = True
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001582 mockGetBranch.return_value = branch
1583 mockGetBugPrefix.return_value = 'prefix'
Edward Lesmes1eaaab52021-03-02 23:52:54 +00001584 mockGetCommonAncestorWithUpstream.return_value = 'upstream'
Edward Lesmese1576912021-02-16 21:53:34 +00001585 mockGetRemoteBranch.return_value = ('origin', 'refs/remotes/origin/main')
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001586 mockFetchDescription.return_value = 'desc'
1587 mockBatchListOwners.side_effect = lambda ps: {
1588 p: owners_by_path.get(p)
1589 for p in ps
1590 }
1591
1592 cl = git_cl.Changelist(issue=1234)
Josip Sokcevic340edc32021-07-08 17:01:46 +00001593 actual = cl._GetDescriptionForUpload(options=mock.Mock(
1594 bug=bug,
1595 fixed=fixed,
1596 reviewers=reviewers,
1597 tbrs=tbrs,
1598 add_owners_to=add_owners_to,
1599 message=initial_description),
1600 git_diff_args=None,
1601 files=list(owners_by_path))
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001602 self.assertEqual(expected_description, actual.description)
1603
1604 def testGetDescriptionForUpload(self):
1605 self.getDescriptionForUploadTest()
1606
1607 def testGetDescriptionForUpload_Bug(self):
1608 self.getDescriptionForUploadTest(
1609 bug='1234',
1610 expected_description='\n'.join([
1611 'desc',
1612 '',
1613 'Bug: prefix:1234',
1614 ]))
1615
1616 def testGetDescriptionForUpload_Fixed(self):
1617 self.getDescriptionForUploadTest(
1618 fixed='1234',
1619 expected_description='\n'.join([
1620 'desc',
1621 '',
1622 'Fixed: prefix:1234',
1623 ]))
1624
Josip Sokcevic340edc32021-07-08 17:01:46 +00001625 @mock.patch('git_cl.Changelist.GetIssue')
1626 def testGetDescriptionForUpload_BugFromBranch(self, mockGetIssue):
1627 mockGetIssue.return_value = None
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001628 self.getDescriptionForUploadTest(
1629 branch='bug-1234',
1630 expected_description='\n'.join([
1631 'desc',
1632 '',
1633 'Bug: prefix:1234',
1634 ]))
1635
Josip Sokcevic340edc32021-07-08 17:01:46 +00001636 @mock.patch('git_cl.Changelist.GetIssue')
1637 def testGetDescriptionForUpload_FixedFromBranch(self, mockGetIssue):
1638 mockGetIssue.return_value = None
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001639 self.getDescriptionForUploadTest(
1640 branch='fix-1234',
1641 expected_description='\n'.join([
1642 'desc',
1643 '',
1644 'Fixed: prefix:1234',
1645 ]))
1646
Josip Sokcevic340edc32021-07-08 17:01:46 +00001647 def testGetDescriptionForUpload_SkipBugFromBranchIfAlreadyUploaded(self):
1648 self.getDescriptionForUploadTest(
1649 branch='bug-1234',
1650 expected_description='desc',
1651 )
1652
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001653 def testGetDescriptionForUpload_AddOwnersToR(self):
1654 self.getDescriptionForUploadTest(
1655 reviewers=['a@example.com'],
1656 tbrs=['b@example.com'],
1657 add_owners_to='R',
1658 expected_description='\n'.join([
1659 'desc',
1660 '',
1661 'R=a@example.com, c@example.com',
1662 'TBR=b@example.com',
1663 ]))
1664
1665 def testGetDescriptionForUpload_AddOwnersToTBR(self):
1666 self.getDescriptionForUploadTest(
1667 reviewers=['a@example.com'],
1668 tbrs=['b@example.com'],
1669 add_owners_to='TBR',
1670 expected_description='\n'.join([
1671 'desc',
1672 '',
1673 'R=a@example.com',
1674 'TBR=b@example.com, c@example.com',
1675 ]))
1676
1677 def testGetDescriptionForUpload_AddOwnersToNoOwnersNeeded(self):
1678 self.getDescriptionForUploadTest(
1679 reviewers=['a@example.com', 'c@example.com'],
1680 tbrs=['b@example.com'],
1681 add_owners_to='TBR',
1682 expected_description='\n'.join([
1683 'desc',
1684 '',
1685 'R=a@example.com, c@example.com',
1686 'TBR=b@example.com',
1687 ]))
1688
1689 def testGetDescriptionForUpload_Reviewers(self):
1690 self.getDescriptionForUploadTest(
1691 reviewers=['a@example.com', 'b@example.com'],
1692 expected_description='\n'.join([
1693 'desc',
1694 '',
1695 'R=a@example.com, b@example.com',
1696 ]))
1697
1698 def testGetDescriptionForUpload_TBRs(self):
1699 self.getDescriptionForUploadTest(
1700 tbrs=['a@example.com', 'b@example.com'],
1701 expected_description='\n'.join([
1702 'desc',
1703 '',
1704 'TBR=a@example.com, b@example.com',
1705 ]))
1706
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001707 def test_desecription_append_footer(self):
1708 for init_desc, footer_line, expected_desc in [
1709 # Use unique desc first lines for easy test failure identification.
1710 ('foo', 'R=one', 'foo\n\nR=one'),
1711 ('foo\n\nR=one', 'BUG=', 'foo\n\nR=one\nBUG='),
1712 ('foo\n\nR=one', 'Change-Id: Ixx', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1713 ('foo\n\nChange-Id: Ixx', 'R=one', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1714 ('foo\n\nR=one\n\nChange-Id: Ixx', 'TBR=two',
1715 'foo\n\nR=one\nTBR=two\n\nChange-Id: Ixx'),
1716 ('foo\n\nR=one\n\nChange-Id: Ixx', 'Foo-Bar: baz',
1717 'foo\n\nR=one\n\nChange-Id: Ixx\nFoo-Bar: baz'),
1718 ('foo\n\nChange-Id: Ixx', 'Foo-Bak: baz',
1719 'foo\n\nChange-Id: Ixx\nFoo-Bak: baz'),
1720 ('foo', 'Change-Id: Ixx', 'foo\n\nChange-Id: Ixx'),
1721 ]:
1722 desc = git_cl.ChangeDescription(init_desc)
1723 desc.append_footer(footer_line)
1724 self.assertEqual(desc.description, expected_desc)
1725
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001726 def test_update_reviewers(self):
1727 data = [
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001728 ('foo', [], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001729 'foo'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001730 ('foo\nR=xx', [], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001731 'foo\nR=xx'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001732 ('foo\nTBR=xx', [], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001733 'foo\nTBR=xx'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001734 ('foo', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001735 'foo\n\nR=a@c'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001736 ('foo\nR=xx', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001737 'foo\n\nR=a@c, xx'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001738 ('foo\nTBR=xx', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001739 'foo\n\nR=a@c\nTBR=xx'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001740 ('foo\nTBR=xx\nR=yy', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001741 'foo\n\nR=a@c, yy\nTBR=xx'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001742 ('foo\nBUG=', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001743 'foo\nBUG=\nR=a@c'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001744 ('foo\nR=xx\nTBR=yy\nR=bar', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001745 'foo\n\nR=a@c, bar, xx\nTBR=yy'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001746 ('foo', ['a@c', 'b@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001747 'foo\n\nR=a@c, b@c'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001748 ('foo\nBar\n\nR=\nBUG=', ['c@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001749 'foo\nBar\n\nR=c@c\nBUG='),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001750 ('foo\nBar\n\nR=\nBUG=\nR=', ['c@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001751 'foo\nBar\n\nR=c@c\nBUG='),
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001752 # Same as the line before, but full of whitespaces.
1753 (
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001754 'foo\nBar\n\n R = \n BUG = \n R = ', ['c@c'], [],
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001755 'foo\nBar\n\nR=c@c\n BUG =',
1756 ),
1757 # Whitespaces aren't interpreted as new lines.
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001758 ('foo BUG=allo R=joe ', ['c@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001759 'foo BUG=allo R=joe\n\nR=c@c'),
1760 # Redundant TBRs get promoted to Rs
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001761 ('foo\n\nR=a@c\nTBR=t@c', ['b@c', 'a@c'], ['a@c', 't@c'],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001762 'foo\n\nR=a@c, b@c\nTBR=t@c'),
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001763 ]
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001764 expected = [i[-1] for i in data]
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001765 actual = []
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001766 for orig, reviewers, tbrs, _expected in data:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001767 obj = git_cl.ChangeDescription(orig)
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001768 obj.update_reviewers(reviewers, tbrs)
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001769 actual.append(obj.description)
1770 self.assertEqual(expected, actual)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001771
Nodir Turakulov23b82142017-11-16 11:04:25 -08001772 def test_get_hash_tags(self):
1773 cases = [
1774 ('', []),
1775 ('a', []),
1776 ('[a]', ['a']),
1777 ('[aa]', ['aa']),
1778 ('[a ]', ['a']),
1779 ('[a- ]', ['a']),
1780 ('[a- b]', ['a-b']),
1781 ('[a--b]', ['a-b']),
1782 ('[a', []),
1783 ('[a]x', ['a']),
1784 ('[aa]x', ['aa']),
1785 ('[a b]', ['a-b']),
1786 ('[a b]', ['a-b']),
1787 ('[a__b]', ['a-b']),
1788 ('[a] x', ['a']),
1789 ('[a][b]', ['a', 'b']),
1790 ('[a] [b]', ['a', 'b']),
1791 ('[a][b]x', ['a', 'b']),
1792 ('[a][b] x', ['a', 'b']),
1793 ('[a]\n[b]', ['a']),
1794 ('[a\nb]', []),
1795 ('[a][', ['a']),
1796 ('Revert "[a] feature"', ['a']),
1797 ('Reland "[a] feature"', ['a']),
1798 ('Revert: [a] feature', ['a']),
1799 ('Reland: [a] feature', ['a']),
1800 ('Revert "Reland: [a] feature"', ['a']),
1801 ('Foo: feature', ['foo']),
1802 ('Foo Bar: feature', ['foo-bar']),
Anthony Polito02b5af32019-12-02 19:49:47 +00001803 ('Change Foo::Bar', []),
1804 ('Foo: Change Foo::Bar', ['foo']),
Nodir Turakulov23b82142017-11-16 11:04:25 -08001805 ('Revert "Foo bar: feature"', ['foo-bar']),
1806 ('Reland "Foo bar: feature"', ['foo-bar']),
1807 ]
1808 for desc, expected in cases:
1809 change_desc = git_cl.ChangeDescription(desc)
1810 actual = change_desc.get_hash_tags()
1811 self.assertEqual(
1812 actual,
1813 expected,
1814 'GetHashTags(%r) == %r, expected %r' % (desc, actual, expected))
1815
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00001816 self.assertEqual(None, git_cl.GetTargetRef('origin', None, 'main'))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001817 self.assertEqual(None, git_cl.GetTargetRef(None,
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00001818 'refs/remotes/origin/main',
1819 'main'))
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001820
wittman@chromium.org455dc922015-01-26 20:15:50 +00001821 # Check default target refs for branches.
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00001822 self.assertEqual('refs/heads/main',
1823 git_cl.GetTargetRef('origin', 'refs/remotes/origin/main',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001824 None))
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00001825 self.assertEqual('refs/heads/main',
wittman@chromium.org455dc922015-01-26 20:15:50 +00001826 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkgr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001827 None))
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00001828 self.assertEqual('refs/heads/main',
wittman@chromium.org455dc922015-01-26 20:15:50 +00001829 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkcr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001830 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001831 self.assertEqual('refs/branch-heads/123',
1832 git_cl.GetTargetRef('origin',
1833 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001834 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001835 self.assertEqual('refs/diff/test',
1836 git_cl.GetTargetRef('origin',
1837 'refs/remotes/origin/refs/diff/test',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001838 None))
rmistry@google.comc68112d2015-03-03 12:48:06 +00001839 self.assertEqual('refs/heads/chrome/m42',
1840 git_cl.GetTargetRef('origin',
1841 'refs/remotes/origin/chrome/m42',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001842 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001843
1844 # Check target refs for user-specified target branch.
1845 for branch in ('branch-heads/123', 'remotes/branch-heads/123',
1846 'refs/remotes/branch-heads/123'):
1847 self.assertEqual('refs/branch-heads/123',
1848 git_cl.GetTargetRef('origin',
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00001849 'refs/remotes/origin/main',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001850 branch))
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00001851 for branch in ('origin/main', 'remotes/origin/main',
1852 'refs/remotes/origin/main'):
1853 self.assertEqual('refs/heads/main',
wittman@chromium.org455dc922015-01-26 20:15:50 +00001854 git_cl.GetTargetRef('origin',
1855 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001856 branch))
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00001857 for branch in ('main', 'heads/main', 'refs/heads/main'):
1858 self.assertEqual('refs/heads/main',
wittman@chromium.org455dc922015-01-26 20:15:50 +00001859 git_cl.GetTargetRef('origin',
1860 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001861 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001862
Edward Lemurda4b6c62020-02-13 00:28:40 +00001863 @mock.patch('git_common.is_dirty_git_tree', return_value=True)
1864 def test_patch_when_dirty(self, *_mocks):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001865 # Patch when local tree is dirty.
wychen@chromium.orga872e752015-04-28 23:42:18 +00001866 self.assertNotEqual(git_cl.main(['patch', '123456']), 0)
1867
Edward Lemur85153282020-02-14 22:06:29 +00001868 def assertIssueAndPatchset(
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00001869 self, branch='main', issue='123456', patchset='7',
Edward Lemur85153282020-02-14 22:06:29 +00001870 git_short_host='chromium'):
1871 self.assertEqual(
Edward Lemur26964072020-02-19 19:18:51 +00001872 issue, scm.GIT.GetBranchConfig('', branch, 'gerritissue'))
Edward Lemur85153282020-02-14 22:06:29 +00001873 self.assertEqual(
Edward Lemur26964072020-02-19 19:18:51 +00001874 patchset, scm.GIT.GetBranchConfig('', branch, 'gerritpatchset'))
Edward Lemur85153282020-02-14 22:06:29 +00001875 self.assertEqual(
1876 'https://%s-review.googlesource.com' % git_short_host,
Edward Lemur26964072020-02-19 19:18:51 +00001877 scm.GIT.GetBranchConfig('', branch, 'gerritserver'))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001878
Edward Lemur85153282020-02-14 22:06:29 +00001879 def _patch_common(self, git_short_host='chromium'):
Edward Lesmes50da7702020-03-30 19:23:43 +00001880 mock.patch('scm.GIT.ResolveCommit', return_value='deadbeef').start()
Edward Lemur26964072020-02-19 19:18:51 +00001881 self.mockGit.config['remote.origin.url'] = (
1882 'https://%s.googlesource.com/my/repo' % git_short_host)
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001883 gerrit_util.GetChangeDetail.return_value = {
1884 'current_revision': '7777777777',
1885 'revisions': {
1886 '1111111111': {
1887 '_number': 1,
1888 'fetch': {'http': {
1889 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1890 'ref': 'refs/changes/56/123456/1',
1891 }},
1892 },
1893 '7777777777': {
1894 '_number': 7,
1895 'fetch': {'http': {
1896 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1897 'ref': 'refs/changes/56/123456/7',
1898 }},
1899 },
1900 },
1901 }
wychen@chromium.orga872e752015-04-28 23:42:18 +00001902
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001903 def test_patch_gerrit_default(self):
Edward Lemur85153282020-02-14 22:06:29 +00001904 self._patch_common()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001905 self.calls += [
1906 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1907 'refs/changes/56/123456/7'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001908 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001909 ]
1910 self.assertEqual(git_cl.main(['patch', '123456']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001911 self.assertIssueAndPatchset()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001912
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001913 def test_patch_gerrit_new_branch(self):
Edward Lemur85153282020-02-14 22:06:29 +00001914 self._patch_common()
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001915 self.calls += [
1916 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1917 'refs/changes/56/123456/7'],), ''),
1918 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001919 ]
Edward Lemur85153282020-02-14 22:06:29 +00001920 self.assertEqual(git_cl.main(['patch', '-b', 'feature', '123456']), 0)
1921 self.assertIssueAndPatchset(branch='feature')
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001922
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001923 def test_patch_gerrit_force(self):
Edward Lemur85153282020-02-14 22:06:29 +00001924 self._patch_common('host')
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001925 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001926 ((['git', 'fetch', 'https://host.googlesource.com/my/repo',
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001927 'refs/changes/56/123456/7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001928 ((['git', 'reset', '--hard', 'FETCH_HEAD'],), ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001929 ]
Edward Lemur52969c92020-02-06 18:15:28 +00001930 self.assertEqual(git_cl.main(['patch', '123456', '--force']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001931 self.assertIssueAndPatchset(git_short_host='host')
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001932
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001933 def test_patch_gerrit_guess_by_url(self):
Edward Lemur85153282020-02-14 22:06:29 +00001934 self._patch_common('else')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001935 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001936 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001937 'refs/changes/56/123456/1'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001938 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001939 ]
1940 self.assertEqual(git_cl.main(
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001941 ['patch', 'https://else-review.googlesource.com/#/c/123456/1']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001942 self.assertIssueAndPatchset(patchset='1', git_short_host='else')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001943
Aaron Gable697a91b2018-01-19 15:20:15 -08001944 def test_patch_gerrit_guess_by_url_with_repo(self):
Edward Lemur85153282020-02-14 22:06:29 +00001945 self._patch_common('else')
Aaron Gable697a91b2018-01-19 15:20:15 -08001946 self.calls += [
1947 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
1948 'refs/changes/56/123456/1'],), ''),
1949 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
Aaron Gable697a91b2018-01-19 15:20:15 -08001950 ]
1951 self.assertEqual(git_cl.main(
1952 ['patch', 'https://else-review.googlesource.com/c/my/repo/+/123456/1']),
1953 0)
Edward Lemur85153282020-02-14 22:06:29 +00001954 self.assertIssueAndPatchset(patchset='1', git_short_host='else')
Aaron Gable697a91b2018-01-19 15:20:15 -08001955
Edward Lemurd55c5072020-02-20 01:09:07 +00001956 @mock.patch('sys.stderr', StringIO())
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001957 def test_patch_gerrit_conflict(self):
Edward Lemur85153282020-02-14 22:06:29 +00001958 self._patch_common()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001959 self.calls += [
1960 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001961 'refs/changes/56/123456/7'],), ''),
tandrii5d48c322016-08-18 16:19:37 -07001962 ((['git', 'cherry-pick', 'FETCH_HEAD'],), CERR1),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001963 ]
1964 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001965 git_cl.main(['patch', '123456'])
Edward Lemurd55c5072020-02-20 01:09:07 +00001966 self.assertEqual(
1967 'Command "git cherry-pick FETCH_HEAD" failed.\n\n',
1968 sys.stderr.getvalue())
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001969
Edward Lemurda4b6c62020-02-13 00:28:40 +00001970 @mock.patch(
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001971 'gerrit_util.GetChangeDetail',
Edward Lemurda4b6c62020-02-13 00:28:40 +00001972 side_effect=gerrit_util.GerritError(404, ''))
Edward Lemurd55c5072020-02-20 01:09:07 +00001973 @mock.patch('sys.stderr', StringIO())
Edward Lemurda4b6c62020-02-13 00:28:40 +00001974 def test_patch_gerrit_not_exists(self, *_mocks):
Edward Lemur26964072020-02-19 19:18:51 +00001975 self.mockGit.config['remote.origin.url'] = (
1976 'https://chromium.googlesource.com/my/repo')
tandriic2405f52016-10-10 08:13:15 -07001977 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001978 self.assertEqual(1, git_cl.main(['patch', '123456']))
Edward Lemurd55c5072020-02-20 01:09:07 +00001979 self.assertEqual(
1980 'change 123456 at https://chromium-review.googlesource.com does not '
1981 'exist or you have no access to it\n',
1982 sys.stderr.getvalue())
tandriic2405f52016-10-10 08:13:15 -07001983
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001984 def _checkout_calls(self):
1985 return [
1986 ((['git', 'config', '--local', '--get-regexp',
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001987 'branch\\..*\\.gerritissue'], ),
1988 ('branch.ger-branch.gerritissue 123456\n'
1989 'branch.gbranch654.gerritissue 654321\n')),
1990 ]
1991
1992 def test_checkout_gerrit(self):
1993 """Tests git cl checkout <issue>."""
1994 self.calls = self._checkout_calls()
1995 self.calls += [((['git', 'checkout', 'ger-branch'], ), '')]
1996 self.assertEqual(0, git_cl.main(['checkout', '123456']))
1997
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001998 def test_checkout_not_found(self):
1999 """Tests git cl checkout <issue>."""
2000 self.calls = self._checkout_calls()
2001 self.assertEqual(1, git_cl.main(['checkout', '99999']))
2002
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00002003 def test_checkout_no_branch_issues(self):
2004 """Tests git cl checkout <issue>."""
2005 self.calls = [
2006 ((['git', 'config', '--local', '--get-regexp',
tandrii5d48c322016-08-18 16:19:37 -07002007 'branch\\..*\\.gerritissue'], ), CERR1),
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00002008 ]
2009 self.assertEqual(1, git_cl.main(['checkout', '99999']))
2010
Edward Lemur26964072020-02-19 19:18:51 +00002011 def _test_gerrit_ensure_authenticated_common(self, auth):
Edward Lemur1a83da12020-03-04 21:18:36 +00002012 mock.patch(
Edward Lesmesae3586b2020-03-23 21:21:14 +00002013 'gclient_utils.AskForData',
Edward Lemur1a83da12020-03-04 21:18:36 +00002014 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002015 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
2016 CookiesAuthenticatorMockFactory(hosts_with_creds=auth)).start()
Edward Lemur26964072020-02-19 19:18:51 +00002017 self.mockGit.config['remote.origin.url'] = (
2018 'https://chromium.googlesource.com/my/repo')
Edward Lemurf38bc172019-09-03 21:02:13 +00002019 cl = git_cl.Changelist()
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00002020 cl.branch = 'main'
2021 cl.branchref = 'refs/heads/main'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002022 return cl
2023
Edward Lemurd55c5072020-02-20 01:09:07 +00002024 @mock.patch('sys.stderr', StringIO())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002025 def test_gerrit_ensure_authenticated_missing(self):
2026 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002027 'chromium.googlesource.com': ('git-is.ok', '', 'but gerrit is missing'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002028 })
Edward Lemurd55c5072020-02-20 01:09:07 +00002029 with self.assertRaises(SystemExitMock):
2030 cl.EnsureAuthenticated(force=False)
2031 self.assertEqual(
2032 'Credentials for the following hosts are required:\n'
2033 ' chromium-review.googlesource.com\n'
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002034 'These are read from ~%(sep)s.gitcookies '
2035 '(or legacy ~%(sep)s%(netrc)s)\n'
Edward Lemurd55c5072020-02-20 01:09:07 +00002036 'You can (re)generate your credentials by visiting '
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002037 'https://chromium-review.googlesource.com/new-password\n' % {
2038 'sep': os.sep,
2039 'netrc': NETRC_FILENAME,
2040 }, sys.stderr.getvalue())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002041
2042 def test_gerrit_ensure_authenticated_conflict(self):
2043 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002044 'chromium.googlesource.com':
2045 ('git-one.example.com', None, 'secret1'),
2046 'chromium-review.googlesource.com':
2047 ('git-other.example.com', None, 'secret2'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002048 })
2049 self.calls.append(
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002050 (('ask_for_data', 'If you know what you are doing '
2051 'press Enter to continue, or Ctrl+C to abort'), ''))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002052 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2053
2054 def test_gerrit_ensure_authenticated_ok(self):
2055 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002056 'chromium.googlesource.com':
2057 ('git-same.example.com', None, 'secret'),
2058 'chromium-review.googlesource.com':
2059 ('git-same.example.com', None, 'secret'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002060 })
2061 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2062
tandrii@chromium.org28253532016-04-14 13:46:56 +00002063 def test_gerrit_ensure_authenticated_skipped(self):
Edward Lemur26964072020-02-19 19:18:51 +00002064 self.mockGit.config['gerrit.skip-ensure-authenticated'] = 'true'
2065 cl = self._test_gerrit_ensure_authenticated_common(auth={})
tandrii@chromium.org28253532016-04-14 13:46:56 +00002066 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2067
Eric Boren2fb63102018-10-05 13:05:03 +00002068 def test_gerrit_ensure_authenticated_bearer_token(self):
2069 cl = self._test_gerrit_ensure_authenticated_common(auth={
2070 'chromium.googlesource.com':
2071 ('', None, 'secret'),
2072 'chromium-review.googlesource.com':
2073 ('', None, 'secret'),
2074 })
2075 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2076 header = gerrit_util.CookiesAuthenticator().get_auth_header(
2077 'chromium.googlesource.com')
2078 self.assertTrue('Bearer' in header)
2079
Daniel Chengcf6269b2019-05-18 01:02:12 +00002080 def test_gerrit_ensure_authenticated_non_https(self):
Edward Lemur26964072020-02-19 19:18:51 +00002081 self.mockGit.config['remote.origin.url'] = 'custom-scheme://repo'
Daniel Chengcf6269b2019-05-18 01:02:12 +00002082 self.calls = [
Josip906bfde2020-01-31 22:38:49 +00002083 (('logging.warning',
2084 'Ignoring branch %(branch)s with non-https remote '
2085 '%(remote)s', {
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00002086 'branch': 'main',
Josip906bfde2020-01-31 22:38:49 +00002087 'remote': 'custom-scheme://repo'}
2088 ), None),
Daniel Chengcf6269b2019-05-18 01:02:12 +00002089 ]
Edward Lemurda4b6c62020-02-13 00:28:40 +00002090 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
2091 CookiesAuthenticatorMockFactory(hosts_with_creds={})).start()
2092 mock.patch('logging.warning',
2093 lambda *a: self._mocked_call('logging.warning', *a)).start()
Edward Lemurf38bc172019-09-03 21:02:13 +00002094 cl = git_cl.Changelist()
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00002095 cl.branch = 'main'
2096 cl.branchref = 'refs/heads/main'
Daniel Chengcf6269b2019-05-18 01:02:12 +00002097 cl.lookedup_issue = True
2098 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2099
Florian Mayerae510e82020-01-30 21:04:48 +00002100 def test_gerrit_ensure_authenticated_non_url(self):
Edward Lemur26964072020-02-19 19:18:51 +00002101 self.mockGit.config['remote.origin.url'] = (
2102 'git@somehost.example:foo/bar.git')
Florian Mayerae510e82020-01-30 21:04:48 +00002103 self.calls = [
Josip906bfde2020-01-31 22:38:49 +00002104 (('logging.error',
2105 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
2106 'but it doesn\'t exist.', {
2107 'remote': 'origin',
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00002108 'branch': 'main',
Josip906bfde2020-01-31 22:38:49 +00002109 'url': 'git@somehost.example:foo/bar.git'}
2110 ), None),
Florian Mayerae510e82020-01-30 21:04:48 +00002111 ]
Edward Lemurda4b6c62020-02-13 00:28:40 +00002112 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
2113 CookiesAuthenticatorMockFactory(hosts_with_creds={})).start()
2114 mock.patch('logging.error',
2115 lambda *a: self._mocked_call('logging.error', *a)).start()
Florian Mayerae510e82020-01-30 21:04:48 +00002116 cl = git_cl.Changelist()
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00002117 cl.branch = 'main'
2118 cl.branchref = 'refs/heads/main'
Florian Mayerae510e82020-01-30 21:04:48 +00002119 cl.lookedup_issue = True
2120 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2121
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002122 def _cmd_set_commit_gerrit_common(self, vote, notify=None):
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00002123 self.mockGit.config['branch.main.gerritissue'] = '123'
2124 self.mockGit.config['branch.main.gerritserver'] = (
Edward Lemur85153282020-02-14 22:06:29 +00002125 'https://chromium-review.googlesource.com')
Edward Lemur26964072020-02-19 19:18:51 +00002126 self.mockGit.config['remote.origin.url'] = (
2127 'https://chromium.googlesource.com/infra/infra')
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002128 self.calls = [
Edward Lemurda4b6c62020-02-13 00:28:40 +00002129 (('SetReview', 'chromium-review.googlesource.com',
2130 'infra%2Finfra~123', None,
2131 {'Commit-Queue': vote}, notify, None), ''),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002132 ]
tandriid9e5ce52016-07-13 02:32:59 -07002133
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00002134 def _cmd_set_quick_run_gerrit(self):
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00002135 self.mockGit.config['branch.main.gerritissue'] = '123'
2136 self.mockGit.config['branch.main.gerritserver'] = (
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00002137 'https://chromium-review.googlesource.com')
2138 self.mockGit.config['remote.origin.url'] = (
2139 'https://chromium.googlesource.com/infra/infra')
2140 self.calls = [
2141 (('SetReview', 'chromium-review.googlesource.com',
2142 'infra%2Finfra~123', None,
2143 {'Commit-Queue': 1, 'Quick-Run': 1}, None, None), ''),
2144 ]
2145
tandriid9e5ce52016-07-13 02:32:59 -07002146 def test_cmd_set_commit_gerrit_clear(self):
2147 self._cmd_set_commit_gerrit_common(0)
2148 self.assertEqual(0, git_cl.main(['set-commit', '-c']))
2149
2150 def test_cmd_set_commit_gerrit_dry(self):
Aaron Gable75e78722017-06-09 10:40:16 -07002151 self._cmd_set_commit_gerrit_common(1, notify=False)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002152 self.assertEqual(0, git_cl.main(['set-commit', '-d']))
2153
tandriid9e5ce52016-07-13 02:32:59 -07002154 def test_cmd_set_commit_gerrit(self):
2155 self._cmd_set_commit_gerrit_common(2)
2156 self.assertEqual(0, git_cl.main(['set-commit']))
2157
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00002158 def test_cmd_set_quick_run_gerrit(self):
2159 self._cmd_set_quick_run_gerrit()
2160 self.assertEqual(0, git_cl.main(['set-commit', '-q']))
2161
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002162 def test_description_display(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002163 mock.patch('git_cl.Changelist', ChangelistMock).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002164 ChangelistMock.desc = 'foo\n'
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002165
2166 self.assertEqual(0, git_cl.main(['description', '-d']))
Edward Lemurda4b6c62020-02-13 00:28:40 +00002167 self.assertEqual('foo\n', sys.stdout.getvalue())
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002168
Edward Lemurda4b6c62020-02-13 00:28:40 +00002169 @mock.patch('sys.stderr', StringIO())
iannucci3c972b92016-08-17 13:24:10 -07002170 def test_StatusFieldOverrideIssueMissingArgs(self):
iannucci3c972b92016-08-17 13:24:10 -07002171 try:
2172 self.assertEqual(git_cl.main(['status', '--issue', '1']), 0)
Edward Lemurd55c5072020-02-20 01:09:07 +00002173 except SystemExitMock:
Edward Lemur6c6827c2020-02-06 21:15:18 +00002174 self.assertIn(
Edward Lemurda4b6c62020-02-13 00:28:40 +00002175 '--field must be given when --issue is set.', sys.stderr.getvalue())
iannucci3c972b92016-08-17 13:24:10 -07002176
2177 def test_StatusFieldOverrideIssue(self):
iannucci3c972b92016-08-17 13:24:10 -07002178 def assertIssue(cl_self, *_args):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002179 self.assertEqual(cl_self.issue, 1)
iannucci3c972b92016-08-17 13:24:10 -07002180 return 'foobar'
2181
Edward Lemurda4b6c62020-02-13 00:28:40 +00002182 mock.patch('git_cl.Changelist.FetchDescription', assertIssue).start()
iannuccie53c9352016-08-17 14:40:40 -07002183 self.assertEqual(
Edward Lemur52969c92020-02-06 18:15:28 +00002184 git_cl.main(['status', '--issue', '1', '--field', 'desc']),
iannuccie53c9352016-08-17 14:40:40 -07002185 0)
Edward Lemurda4b6c62020-02-13 00:28:40 +00002186 self.assertEqual(sys.stdout.getvalue(), 'foobar\n')
iannucci3c972b92016-08-17 13:24:10 -07002187
iannuccie53c9352016-08-17 14:40:40 -07002188 def test_SetCloseOverrideIssue(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002189
iannuccie53c9352016-08-17 14:40:40 -07002190 def assertIssue(cl_self, *_args):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002191 self.assertEqual(cl_self.issue, 1)
iannuccie53c9352016-08-17 14:40:40 -07002192 return 'foobar'
2193
Edward Lemurda4b6c62020-02-13 00:28:40 +00002194 mock.patch('git_cl.Changelist.FetchDescription', assertIssue).start()
2195 mock.patch('git_cl.Changelist.CloseIssue', lambda *_: None).start()
iannuccie53c9352016-08-17 14:40:40 -07002196 self.assertEqual(
Edward Lemur52969c92020-02-06 18:15:28 +00002197 git_cl.main(['set-close', '--issue', '1']), 0)
iannuccie53c9352016-08-17 14:40:40 -07002198
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002199 def test_description(self):
Edward Lemur26964072020-02-19 19:18:51 +00002200 self.mockGit.config['remote.origin.url'] = (
2201 'https://chromium.googlesource.com/my/repo')
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002202 gerrit_util.GetChangeDetail.return_value = {
2203 'current_revision': 'sha1',
2204 'revisions': {'sha1': {
2205 'commit': {'message': 'foobar'},
2206 }},
2207 }
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002208 self.assertEqual(0, git_cl.main([
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002209 'description',
2210 'https://chromium-review.googlesource.com/c/my/repo/+/123123',
2211 '-d']))
Edward Lemurda4b6c62020-02-13 00:28:40 +00002212 self.assertEqual('foobar\n', sys.stdout.getvalue())
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002213
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002214 def test_description_set_raw(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002215 mock.patch('git_cl.Changelist', ChangelistMock).start()
2216 mock.patch('git_cl.sys.stdin', StringIO('hihi')).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002217
2218 self.assertEqual(0, git_cl.main(['description', '-n', 'hihi']))
2219 self.assertEqual('hihi', ChangelistMock.desc)
2220
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002221 def test_description_appends_bug_line(self):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002222 current_desc = 'Some.\n\nChange-Id: xxx'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002223
2224 def RunEditor(desc, _, **kwargs):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002225 self.assertEqual(
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002226 '# Enter a description of the change.\n'
2227 '# This will be displayed on the codereview site.\n'
2228 '# The first line will also be used as the subject of the review.\n'
2229 '#--------------------This line is 72 characters long'
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002230 '--------------------\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -07002231 'Some.\n\nChange-Id: xxx\nBug: ',
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002232 desc)
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002233 # Simulate user changing something.
Aaron Gable3a16ed12017-03-23 10:51:55 -07002234 return 'Some.\n\nChange-Id: xxx\nBug: 123'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002235
Edward Lemur6c6827c2020-02-06 21:15:18 +00002236 def UpdateDescription(_, desc, force=False):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002237 self.assertEqual(desc, 'Some.\n\nChange-Id: xxx\nBug: 123')
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002238
Edward Lemurda4b6c62020-02-13 00:28:40 +00002239 mock.patch('git_cl.Changelist.FetchDescription',
2240 lambda *args: current_desc).start()
2241 mock.patch('git_cl.Changelist.UpdateDescription',
2242 UpdateDescription).start()
2243 mock.patch('git_cl.gclient_utils.RunEditor', RunEditor).start()
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002244
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00002245 self.mockGit.config['branch.main.gerritissue'] = '123'
Edward Lemur52969c92020-02-06 18:15:28 +00002246 self.assertEqual(0, git_cl.main(['description']))
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002247
Dan Beamd8b04ca2019-10-10 21:23:26 +00002248 def test_description_does_not_append_bug_line_if_fixed_is_present(self):
2249 current_desc = 'Some.\n\nFixed: 123\nChange-Id: xxx'
2250
2251 def RunEditor(desc, _, **kwargs):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002252 self.assertEqual(
Dan Beamd8b04ca2019-10-10 21:23:26 +00002253 '# Enter a description of the change.\n'
2254 '# This will be displayed on the codereview site.\n'
2255 '# The first line will also be used as the subject of the review.\n'
2256 '#--------------------This line is 72 characters long'
2257 '--------------------\n'
2258 'Some.\n\nFixed: 123\nChange-Id: xxx',
2259 desc)
2260 return desc
2261
Edward Lemurda4b6c62020-02-13 00:28:40 +00002262 mock.patch('git_cl.Changelist.FetchDescription',
2263 lambda *args: current_desc).start()
2264 mock.patch('git_cl.gclient_utils.RunEditor', RunEditor).start()
Dan Beamd8b04ca2019-10-10 21:23:26 +00002265
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00002266 self.mockGit.config['branch.main.gerritissue'] = '123'
Edward Lemur52969c92020-02-06 18:15:28 +00002267 self.assertEqual(0, git_cl.main(['description']))
Dan Beamd8b04ca2019-10-10 21:23:26 +00002268
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002269 def test_description_set_stdin(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002270 mock.patch('git_cl.Changelist', ChangelistMock).start()
2271 mock.patch('git_cl.sys.stdin', StringIO('hi \r\n\t there\n\nman')).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002272
2273 self.assertEqual(0, git_cl.main(['description', '-n', '-']))
2274 self.assertEqual('hi\n\t there\n\nman', ChangelistMock.desc)
2275
kmarshall3bff56b2016-06-06 18:31:47 -07002276 def test_archive(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002277 self.calls = [
2278 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00002279 'refs/heads/main\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002280 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002281 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],), ''),
Edward Lemurf38bc172019-09-03 21:02:13 +00002282 ((['git', 'branch', '-D', 'foo'],), '')
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002283 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002284
Edward Lemurda4b6c62020-02-13 00:28:40 +00002285 mock.patch('git_cl.get_cl_statuses',
kmarshall3bff56b2016-06-06 18:31:47 -07002286 lambda branches, fine_grained, max_processes:
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00002287 [(MockChangelistWithBranchAndIssue('main', 1), 'open'),
kmarshall9249e012016-08-23 12:02:16 -07002288 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002289 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall3bff56b2016-06-06 18:31:47 -07002290
2291 self.assertEqual(0, git_cl.main(['archive', '-f']))
2292
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002293 def test_archive_tag_collision(self):
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002294 self.calls = [
2295 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00002296 'refs/heads/main\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002297 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],),
2298 'refs/tags/git-cl-archived-456-foo'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002299 ((['git', 'tag', 'git-cl-archived-456-foo-2', 'foo'],), ''),
2300 ((['git', 'branch', '-D', 'foo'],), '')
2301 ]
2302
Edward Lemurda4b6c62020-02-13 00:28:40 +00002303 mock.patch('git_cl.get_cl_statuses',
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002304 lambda branches, fine_grained, max_processes:
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00002305 [(MockChangelistWithBranchAndIssue('main', 1), 'open'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002306 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002307 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002308
2309 self.assertEqual(0, git_cl.main(['archive', '-f']))
2310
kmarshall3bff56b2016-06-06 18:31:47 -07002311 def test_archive_current_branch_fails(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002312 self.calls = [
2313 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00002314 'refs/heads/main'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002315 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002316 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002317
Edward Lemurda4b6c62020-02-13 00:28:40 +00002318 mock.patch('git_cl.get_cl_statuses',
kmarshall9249e012016-08-23 12:02:16 -07002319 lambda branches, fine_grained, max_processes:
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00002320 [(MockChangelistWithBranchAndIssue('main', 1),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002321 'closed')]).start()
kmarshall9249e012016-08-23 12:02:16 -07002322
2323 self.assertEqual(1, git_cl.main(['archive', '-f']))
2324
2325 def test_archive_dry_run(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002326 self.calls = [
2327 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00002328 'refs/heads/main\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002329 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002330 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002331
Edward Lemurda4b6c62020-02-13 00:28:40 +00002332 mock.patch('git_cl.get_cl_statuses',
kmarshall3bff56b2016-06-06 18:31:47 -07002333 lambda branches, fine_grained, max_processes:
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00002334 [(MockChangelistWithBranchAndIssue('main', 1), 'open'),
kmarshall9249e012016-08-23 12:02:16 -07002335 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002336 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall3bff56b2016-06-06 18:31:47 -07002337
kmarshall9249e012016-08-23 12:02:16 -07002338 self.assertEqual(0, git_cl.main(['archive', '-f', '--dry-run']))
2339
2340 def test_archive_no_tags(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002341 self.calls = [
2342 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00002343 'refs/heads/main\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002344 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002345 ((['git', 'branch', '-D', 'foo'],), '')
2346 ]
kmarshall9249e012016-08-23 12:02:16 -07002347
Edward Lemurda4b6c62020-02-13 00:28:40 +00002348 mock.patch('git_cl.get_cl_statuses',
kmarshall9249e012016-08-23 12:02:16 -07002349 lambda branches, fine_grained, max_processes:
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00002350 [(MockChangelistWithBranchAndIssue('main', 1), 'open'),
kmarshall9249e012016-08-23 12:02:16 -07002351 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002352 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall9249e012016-08-23 12:02:16 -07002353
2354 self.assertEqual(0, git_cl.main(['archive', '-f', '--notags']))
kmarshall3bff56b2016-06-06 18:31:47 -07002355
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002356 def test_archive_tag_cleanup_on_branch_deletion_error(self):
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002357 self.calls = [
2358 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00002359 'refs/heads/main\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002360 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002361 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],),
2362 'refs/tags/git-cl-archived-456-foo'),
2363 ((['git', 'branch', '-D', 'foo'],), CERR1),
2364 ((['git', 'tag', '-d', 'git-cl-archived-456-foo'],),
2365 'refs/tags/git-cl-archived-456-foo'),
2366 ]
2367
Edward Lemurda4b6c62020-02-13 00:28:40 +00002368 mock.patch('git_cl.get_cl_statuses',
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002369 lambda branches, fine_grained, max_processes:
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00002370 [(MockChangelistWithBranchAndIssue('main', 1), 'open'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002371 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002372 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002373
2374 self.assertEqual(0, git_cl.main(['archive', '-f']))
2375
Tibor Goldschwendt7c5efb22020-03-25 01:23:54 +00002376 def test_archive_with_format(self):
2377 self.calls = [
2378 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'], ),
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00002379 'refs/heads/main\nrefs/heads/foo\nrefs/heads/bar'),
Tibor Goldschwendt7c5efb22020-03-25 01:23:54 +00002380 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'], ), ''),
2381 ((['git', 'tag', 'archived/12-foo', 'foo'], ), ''),
2382 ((['git', 'branch', '-D', 'foo'], ), ''),
2383 ]
2384
2385 mock.patch('git_cl.get_cl_statuses',
2386 lambda branches, fine_grained, max_processes:
2387 [(MockChangelistWithBranchAndIssue('foo', 12), 'closed')]).start()
2388
2389 self.assertEqual(
2390 0, git_cl.main(['archive', '-f', '-p', 'archived/{issue}-{branch}']))
2391
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002392 def test_cmd_issue_erase_existing(self):
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00002393 self.mockGit.config['branch.main.gerritissue'] = '123'
2394 self.mockGit.config['branch.main.gerritserver'] = (
Edward Lemur85153282020-02-14 22:06:29 +00002395 'https://chromium-review.googlesource.com')
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002396 self.calls = [
Aaron Gableca01e2c2017-07-19 11:16:02 -07002397 ((['git', 'log', '-1', '--format=%B'],), 'This is a description'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002398 ]
2399 self.assertEqual(0, git_cl.main(['issue', '0']))
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00002400 self.assertNotIn('branch.main.gerritissue', self.mockGit.config)
2401 self.assertNotIn('branch.main.gerritserver', self.mockGit.config)
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002402
Aaron Gable400e9892017-07-12 15:31:21 -07002403 def test_cmd_issue_erase_existing_with_change_id(self):
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00002404 self.mockGit.config['branch.main.gerritissue'] = '123'
2405 self.mockGit.config['branch.main.gerritserver'] = (
Edward Lemur85153282020-02-14 22:06:29 +00002406 'https://chromium-review.googlesource.com')
Edward Lemurda4b6c62020-02-13 00:28:40 +00002407 mock.patch('git_cl.Changelist.FetchDescription',
2408 lambda _: 'This is a description\n\nChange-Id: Ideadbeef').start()
Aaron Gable400e9892017-07-12 15:31:21 -07002409 self.calls = [
Aaron Gableca01e2c2017-07-19 11:16:02 -07002410 ((['git', 'log', '-1', '--format=%B'],),
2411 'This is a description\n\nChange-Id: Ideadbeef'),
2412 ((['git', 'commit', '--amend', '-m', 'This is a description\n'],), ''),
Aaron Gable400e9892017-07-12 15:31:21 -07002413 ]
2414 self.assertEqual(0, git_cl.main(['issue', '0']))
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00002415 self.assertNotIn('branch.main.gerritissue', self.mockGit.config)
2416 self.assertNotIn('branch.main.gerritserver', self.mockGit.config)
Aaron Gable400e9892017-07-12 15:31:21 -07002417
phajdan.jre328cf92016-08-22 04:12:17 -07002418 def test_cmd_issue_json(self):
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00002419 self.mockGit.config['branch.main.gerritissue'] = '123'
2420 self.mockGit.config['branch.main.gerritserver'] = (
Edward Lemur85153282020-02-14 22:06:29 +00002421 'https://chromium-review.googlesource.com')
Nodir Turakulov27379632021-03-17 18:53:29 +00002422 self.mockGit.config['remote.origin.url'] = (
2423 'https://chromium.googlesource.com/chromium/src'
2424 )
2425 self.calls = [(
2426 (
2427 'write_json',
2428 'output.json',
2429 {
2430 'issue': 123,
2431 'issue_url': 'https://chromium-review.googlesource.com/123',
2432 'gerrit_host': 'chromium-review.googlesource.com',
2433 'gerrit_project': 'chromium/src',
2434 },
2435 ),
2436 '',
2437 )]
phajdan.jre328cf92016-08-22 04:12:17 -07002438 self.assertEqual(0, git_cl.main(['issue', '--json', 'output.json']))
2439
tandrii16e0b4e2016-06-07 10:34:28 -07002440 def _common_GerritCommitMsgHookCheck(self):
Edward Lemur15a9b8c2020-02-13 00:52:30 +00002441 mock.patch(
2442 'git_cl.os.path.abspath',
2443 lambda path: self._mocked_call(['abspath', path])).start()
2444 mock.patch(
2445 'git_cl.os.path.exists',
2446 lambda path: self._mocked_call(['exists', path])).start()
2447 mock.patch(
2448 'git_cl.gclient_utils.FileRead',
2449 lambda path: self._mocked_call(['FileRead', path])).start()
2450 mock.patch(
2451 'git_cl.gclient_utils.rm_file_or_tree',
2452 lambda path: self._mocked_call(['rm_file_or_tree', path])).start()
Edward Lemur1a83da12020-03-04 21:18:36 +00002453 mock.patch(
Edward Lesmesae3586b2020-03-23 21:21:14 +00002454 'gclient_utils.AskForData',
Edward Lemur1a83da12020-03-04 21:18:36 +00002455 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
Edward Lemurf38bc172019-09-03 21:02:13 +00002456 return git_cl.Changelist(issue=123)
tandrii16e0b4e2016-06-07 10:34:28 -07002457
2458 def test_GerritCommitMsgHookCheck_custom_hook(self):
2459 cl = self._common_GerritCommitMsgHookCheck()
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002460 self.calls += [((['exists',
2461 os.path.join('.git', 'hooks', 'commit-msg')], ), True),
2462 ((['FileRead',
2463 os.path.join('.git', 'hooks', 'commit-msg')], ),
2464 '#!/bin/sh\necho "custom hook"')]
Edward Lemur125d60a2019-09-13 18:25:41 +00002465 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002466
2467 def test_GerritCommitMsgHookCheck_not_exists(self):
2468 cl = self._common_GerritCommitMsgHookCheck()
2469 self.calls += [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002470 ((['exists', os.path.join('.git', 'hooks', 'commit-msg')], ), False),
tandrii16e0b4e2016-06-07 10:34:28 -07002471 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002472 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002473
2474 def test_GerritCommitMsgHookCheck(self):
2475 cl = self._common_GerritCommitMsgHookCheck()
2476 self.calls += [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002477 ((['exists', os.path.join('.git', 'hooks', 'commit-msg')], ), True),
2478 ((['FileRead', os.path.join('.git', 'hooks', 'commit-msg')], ),
tandrii16e0b4e2016-06-07 10:34:28 -07002479 '...\n# From Gerrit Code Review\n...\nadd_ChangeId()\n'),
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002480 (('ask_for_data', 'Do you want to remove it now? [Yes/No]: '), 'Yes'),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002481 ((['rm_file_or_tree',
2482 os.path.join('.git', 'hooks', 'commit-msg')], ), ''),
tandrii16e0b4e2016-06-07 10:34:28 -07002483 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002484 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002485
tandriic4344b52016-08-29 06:04:54 -07002486 def test_GerritCmdLand(self):
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00002487 self.mockGit.config['branch.main.gerritsquashhash'] = 'deadbeaf'
2488 self.mockGit.config['branch.main.gerritserver'] = (
Edward Lemur85153282020-02-14 22:06:29 +00002489 'chromium-review.googlesource.com')
tandriic4344b52016-08-29 06:04:54 -07002490 self.calls += [
tandriic4344b52016-08-29 06:04:54 -07002491 ((['git', 'diff', 'deadbeaf'],), ''), # No diff.
tandriic4344b52016-08-29 06:04:54 -07002492 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002493 cl = git_cl.Changelist(issue=123)
Edward Lemur125d60a2019-09-13 18:25:41 +00002494 cl._GetChangeDetail = lambda *args, **kwargs: {
tandriic4344b52016-08-29 06:04:54 -07002495 'labels': {},
2496 'current_revision': 'deadbeaf',
2497 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002498 cl._GetChangeCommit = lambda: {
agable32978d92016-11-01 12:55:02 -07002499 'commit': 'deadbeef',
Aaron Gable02cdbb42016-12-13 16:24:25 -08002500 'web_links': [{'name': 'gitiles',
agable32978d92016-11-01 12:55:02 -07002501 'url': 'https://git.googlesource.com/test/+/deadbeef'}],
2502 }
Xinan Lin1bd4ffa2021-07-28 00:54:22 +00002503 cl.SubmitIssue = lambda: None
Olivier Robin75ee7252018-04-13 10:02:56 +02002504 self.assertEqual(0, cl.CMDLand(force=True,
2505 bypass_hooks=True,
2506 verbose=True,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00002507 parallel=False,
2508 resultdb=False,
2509 realm=None))
Edward Lemur73c76702020-02-06 23:57:18 +00002510 self.assertIn(
2511 'Issue chromium-review.googlesource.com/123 has been submitted',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002512 sys.stdout.getvalue())
Edward Lemur73c76702020-02-06 23:57:18 +00002513 self.assertIn(
2514 'Landed as: https://git.googlesource.com/test/+/deadbeef',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002515 sys.stdout.getvalue())
tandriic4344b52016-08-29 06:04:54 -07002516
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002517 def _mock_gerrit_changes_for_detail_cache(self):
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002518 mock.patch('git_cl.Changelist.GetGerritHost', lambda _: 'host').start()
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002519
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002520 def test_gerrit_change_detail_cache_simple(self):
2521 self._mock_gerrit_changes_for_detail_cache()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002522 gerrit_util.GetChangeDetail.side_effect = ['a', 'b']
Edward Lemurf38bc172019-09-03 21:02:13 +00002523 cl1 = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002524 cl1._cached_remote_url = (
2525 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemurf38bc172019-09-03 21:02:13 +00002526 cl2 = git_cl.Changelist(issue=2)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002527 cl2._cached_remote_url = (
2528 True, 'https://chromium.googlesource.com/ab/repo')
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002529 self.assertEqual(cl1._GetChangeDetail(), 'a') # Miss.
2530 self.assertEqual(cl1._GetChangeDetail(), 'a')
2531 self.assertEqual(cl2._GetChangeDetail(), 'b') # Miss.
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002532
2533 def test_gerrit_change_detail_cache_options(self):
2534 self._mock_gerrit_changes_for_detail_cache()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002535 gerrit_util.GetChangeDetail.side_effect = ['cab', 'ad']
Edward Lemurf38bc172019-09-03 21:02:13 +00002536 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002537 cl._cached_remote_url = (True, 'https://chromium.googlesource.com/repo/')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002538 self.assertEqual(cl._GetChangeDetail(options=['C', 'A', 'B']), 'cab')
2539 self.assertEqual(cl._GetChangeDetail(options=['A', 'B', 'C']), 'cab')
2540 self.assertEqual(cl._GetChangeDetail(options=['B', 'A']), 'cab')
2541 self.assertEqual(cl._GetChangeDetail(options=['C']), 'cab')
2542 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2543 self.assertEqual(cl._GetChangeDetail(), 'cab')
2544
2545 self.assertEqual(cl._GetChangeDetail(options=['A', 'D']), 'ad')
2546 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2547 self.assertEqual(cl._GetChangeDetail(options=['D']), 'ad')
2548 self.assertEqual(cl._GetChangeDetail(), 'cab')
2549
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002550 def test_gerrit_description_caching(self):
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002551 gerrit_util.GetChangeDetail.return_value = {
2552 'current_revision': 'rev1',
2553 'revisions': {
2554 'rev1': {'commit': {'message': 'desc1'}},
2555 },
2556 }
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002557
2558 self._mock_gerrit_changes_for_detail_cache()
Edward Lemurf38bc172019-09-03 21:02:13 +00002559 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002560 cl._cached_remote_url = (
2561 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemur6c6827c2020-02-06 21:15:18 +00002562 self.assertEqual(cl.FetchDescription(), 'desc1')
2563 self.assertEqual(cl.FetchDescription(), 'desc1') # cache hit.
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002564
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002565 def test_print_current_creds(self):
2566 class CookiesAuthenticatorMock(object):
2567 def __init__(self):
2568 self.gitcookies = {
2569 'host.googlesource.com': ('user', 'pass'),
2570 'host-review.googlesource.com': ('user', 'pass'),
2571 }
2572 self.netrc = self
2573 self.netrc.hosts = {
2574 'github.com': ('user2', None, 'pass2'),
2575 'host2.googlesource.com': ('user3', None, 'pass'),
2576 }
Edward Lemurda4b6c62020-02-13 00:28:40 +00002577 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
2578 CookiesAuthenticatorMock).start()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002579 git_cl._GitCookiesChecker().print_current_creds(include_netrc=True)
2580 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2581 ' Host\t User\t Which file',
2582 '============================\t=====\t===========',
2583 'host-review.googlesource.com\t user\t.gitcookies',
2584 ' host.googlesource.com\t user\t.gitcookies',
2585 ' host2.googlesource.com\tuser3\t .netrc',
2586 ])
Edward Lemur79d4f992019-11-11 23:49:02 +00002587 sys.stdout.seek(0)
2588 sys.stdout.truncate(0)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002589 git_cl._GitCookiesChecker().print_current_creds(include_netrc=False)
2590 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2591 ' Host\tUser\t Which file',
2592 '============================\t====\t===========',
2593 'host-review.googlesource.com\tuser\t.gitcookies',
2594 ' host.googlesource.com\tuser\t.gitcookies',
2595 ])
2596
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002597 def _common_creds_check_mocks(self):
2598 def exists_mock(path):
2599 dirname = os.path.dirname(path)
2600 if dirname == os.path.expanduser('~'):
2601 dirname = '~'
2602 base = os.path.basename(path)
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002603 if base in (NETRC_FILENAME, '.gitcookies'):
2604 return self._mocked_call('os.path.exists', os.path.join(dirname, base))
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002605 # git cl also checks for existence other files not relevant to this test.
2606 return None
Edward Lemur1a83da12020-03-04 21:18:36 +00002607 mock.patch(
Edward Lesmesae3586b2020-03-23 21:21:14 +00002608 'gclient_utils.AskForData',
Edward Lemur1a83da12020-03-04 21:18:36 +00002609 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002610 mock.patch('os.path.exists', exists_mock).start()
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002611
2612 def test_creds_check_gitcookies_not_configured(self):
2613 self._common_creds_check_mocks()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002614 mock.patch('git_cl._GitCookiesChecker.get_hosts_with_creds',
2615 lambda _, include_netrc=False: []).start()
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002616 self.calls = [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002617 ((['git', 'config', '--path', 'http.cookiefile'], ), CERR1),
2618 ((['git', 'config', '--global', 'http.cookiefile'], ), CERR1),
2619 (('os.path.exists', os.path.join('~', NETRC_FILENAME)), True),
2620 (('ask_for_data', 'Press Enter to setup .gitcookies, '
2621 'or Ctrl+C to abort'), ''),
2622 (([
2623 'git', 'config', '--global', 'http.cookiefile',
2624 os.path.expanduser(os.path.join('~', '.gitcookies'))
2625 ], ), ''),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002626 ]
2627 self.assertEqual(0, git_cl.main(['creds-check']))
Edward Lemur73c76702020-02-06 23:57:18 +00002628 self.assertTrue(
2629 sys.stdout.getvalue().startswith(
2630 'You seem to be using outdated .netrc for git credentials:'))
2631 self.assertIn(
2632 '\nConfigured git to use .gitcookies from',
2633 sys.stdout.getvalue())
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002634
2635 def test_creds_check_gitcookies_configured_custom_broken(self):
2636 self._common_creds_check_mocks()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002637 mock.patch('git_cl._GitCookiesChecker.get_hosts_with_creds',
2638 lambda _, include_netrc=False: []).start()
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002639 custom_cookie_path = ('C:\\.gitcookies'
2640 if sys.platform == 'win32' else '/custom/.gitcookies')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002641 self.calls = [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002642 ((['git', 'config', '--path', 'http.cookiefile'], ), CERR1),
2643 ((['git', 'config', '--global', 'http.cookiefile'], ),
2644 custom_cookie_path),
2645 (('os.path.exists', custom_cookie_path), False),
2646 (('ask_for_data', 'Reconfigure git to use default .gitcookies? '
2647 'Press Enter to reconfigure, or Ctrl+C to abort'), ''),
2648 (([
2649 'git', 'config', '--global', 'http.cookiefile',
2650 os.path.expanduser(os.path.join('~', '.gitcookies'))
2651 ], ), ''),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002652 ]
2653 self.assertEqual(0, git_cl.main(['creds-check']))
Edward Lemur73c76702020-02-06 23:57:18 +00002654 self.assertIn(
2655 'WARNING: You have configured custom path to .gitcookies: ',
2656 sys.stdout.getvalue())
2657 self.assertIn(
2658 'However, your configured .gitcookies file is missing.',
2659 sys.stdout.getvalue())
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002660
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002661 def test_git_cl_comment_add_gerrit(self):
Edward Lemur85153282020-02-14 22:06:29 +00002662 self.mockGit.branchref = None
Edward Lemur26964072020-02-19 19:18:51 +00002663 self.mockGit.config['remote.origin.url'] = (
2664 'https://chromium.googlesource.com/infra/infra')
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002665 self.calls = [
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002666 (('SetReview', 'chromium-review.googlesource.com', 'infra%2Finfra~10',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002667 'msg', None, None, None),
Aaron Gable636b13f2017-07-14 10:42:48 -07002668 None),
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002669 ]
Edward Lemur52969c92020-02-06 18:15:28 +00002670 self.assertEqual(0, git_cl.main(['comment', '-i', '10', '-a', 'msg']))
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002671
Edward Lemurda4b6c62020-02-13 00:28:40 +00002672 @mock.patch('git_cl.Changelist.GetBranch', return_value='foo')
2673 def test_git_cl_comments_fetch_gerrit(self, *_mocks):
Edward Lemur26964072020-02-19 19:18:51 +00002674 self.mockGit.config['remote.origin.url'] = (
2675 'https://chromium.googlesource.com/infra/infra')
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002676 gerrit_util.GetChangeDetail.return_value = {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002677 'owner': {'email': 'owner@example.com'},
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002678 'current_revision': 'ba5eba11',
2679 'revisions': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002680 'deadbeaf': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002681 '_number': 1,
2682 },
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002683 'ba5eba11': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002684 '_number': 2,
2685 },
2686 },
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002687 'messages': [
2688 {
2689 u'_revision_number': 1,
2690 u'author': {
2691 u'_account_id': 1111084,
Andrii Shyshkalov8aa9d622020-03-10 19:15:35 +00002692 u'email': u'could-be-anything@example.com',
2693 u'name': u'LUCI CQ'
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002694 },
2695 u'date': u'2017-03-15 20:08:45.000000000',
2696 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
Dirk Prankef6a58802017-10-17 12:49:42 -07002697 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
Andrii Shyshkalov899785a2021-07-09 12:45:37 +00002698 u'tag': u'autogenerated:cv:dry-run'
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002699 },
2700 {
2701 u'_revision_number': 2,
2702 u'author': {
2703 u'_account_id': 11151243,
2704 u'email': u'owner@example.com',
2705 u'name': u'owner'
2706 },
2707 u'date': u'2017-03-16 20:00:41.000000000',
2708 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2709 u'message': u'PTAL',
2710 },
2711 {
2712 u'_revision_number': 2,
2713 u'author': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002714 u'_account_id': 148512,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002715 u'email': u'reviewer@example.com',
2716 u'name': u'reviewer'
2717 },
2718 u'date': u'2017-03-17 05:19:37.500000000',
2719 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2720 u'message': u'Patch Set 2: Code-Review+1',
2721 },
Josip Sokcevic266129c2021-11-09 00:22:00 +00002722 {
2723 u'_revision_number': 2,
2724 u'author': {
2725 u'_account_id': 42,
2726 u'name': u'reviewer'
2727 },
2728 u'date': u'2017-03-17 05:19:37.900000000',
2729 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d0000',
2730 u'message': u'A bot with no email set',
2731 },
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002732 ]
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002733 }
2734 self.calls = [
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002735 (('GetChangeComments', 'chromium-review.googlesource.com',
2736 'infra%2Finfra~1'), {
2737 '/COMMIT_MSG': [
2738 {
2739 'author': {
2740 'email': u'reviewer@example.com'
2741 },
2742 'updated': u'2017-03-17 05:19:37.500000000',
2743 'patch_set': 2,
2744 'side': 'REVISION',
2745 'message': 'Please include a bug link',
2746 },
2747 ],
2748 'codereview.settings': [
2749 {
2750 'author': {
2751 'email': u'owner@example.com'
2752 },
2753 'updated': u'2017-03-16 20:00:41.000000000',
2754 'patch_set': 2,
2755 'side': 'PARENT',
2756 'line': 42,
2757 'message': 'I removed this because it is bad',
2758 },
2759 ]
2760 }),
2761 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
2762 'infra%2Finfra~1'), {}),
2763 ] * 2 + [(('write_json', 'output.json', [{
2764 u'date':
2765 u'2017-03-16 20:00:41.000000',
2766 u'message': (u'PTAL\n' + u'\n' + u'codereview.settings\n' +
2767 u' Base, Line 42: https://crrev.com/c/1/2/'
2768 u'codereview.settings#b42\n' +
2769 u' I removed this because it is bad\n'),
2770 u'autogenerated':
2771 False,
2772 u'approval':
2773 False,
2774 u'disapproval':
2775 False,
2776 u'sender':
2777 u'owner@example.com'
2778 }, {
2779 u'date':
2780 u'2017-03-17 05:19:37.500000',
2781 u'message':
2782 (u'Patch Set 2: Code-Review+1\n' + u'\n' + u'/COMMIT_MSG\n' +
2783 u' PS2, File comment: https://crrev.com/c/1/2//COMMIT_MSG#\n' +
2784 u' Please include a bug link\n'),
2785 u'autogenerated':
2786 False,
2787 u'approval':
2788 False,
2789 u'disapproval':
2790 False,
2791 u'sender':
2792 u'reviewer@example.com'
2793 }]), '')]
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002794 expected_comments_summary = [
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002795 git_cl._CommentSummary(
2796 message=(u'PTAL\n' + u'\n' + u'codereview.settings\n' +
2797 u' Base, Line 42: https://crrev.com/c/1/2/' +
2798 u'codereview.settings#b42\n' +
2799 u' I removed this because it is bad\n'),
2800 date=datetime.datetime(2017, 3, 16, 20, 0, 41, 0),
2801 autogenerated=False,
2802 disapproval=False,
2803 approval=False,
2804 sender=u'owner@example.com'),
2805 git_cl._CommentSummary(message=(
2806 u'Patch Set 2: Code-Review+1\n' + u'\n' + u'/COMMIT_MSG\n' +
2807 u' PS2, File comment: https://crrev.com/c/1/2//COMMIT_MSG#\n' +
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002808 u' Please include a bug link\n'),
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002809 date=datetime.datetime(2017, 3, 17, 5, 19, 37,
2810 500000),
2811 autogenerated=False,
2812 disapproval=False,
2813 approval=False,
2814 sender=u'reviewer@example.com'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002815 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002816 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00002817 issue=1, branchref='refs/heads/foo')
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002818 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002819 self.assertEqual(
2820 0, git_cl.main(['comments', '-i', '1', '-j', 'output.json']))
2821
2822 def test_git_cl_comments_robot_comments(self):
2823 # git cl comments also fetches robot comments (which are considered a type
2824 # of autogenerated comment), and unlike other types of comments, only robot
2825 # comments from the latest patchset are shown.
Edward Lemur26964072020-02-19 19:18:51 +00002826 self.mockGit.config['remote.origin.url'] = (
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002827 'https://x.googlesource.com/infra/infra')
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002828 gerrit_util.GetChangeDetail.return_value = {
2829 'owner': {'email': 'owner@example.com'},
2830 'current_revision': 'ba5eba11',
2831 'revisions': {
2832 'deadbeaf': {
2833 '_number': 1,
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002834 },
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002835 'ba5eba11': {
2836 '_number': 2,
2837 },
2838 },
2839 'messages': [
2840 {
2841 u'_revision_number': 1,
2842 u'author': {
2843 u'_account_id': 1111084,
2844 u'email': u'commit-bot@chromium.org',
2845 u'name': u'Commit Bot'
2846 },
2847 u'date': u'2017-03-15 20:08:45.000000000',
2848 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
2849 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
2850 u'tag': u'autogenerated:cq:dry-run'
2851 },
2852 {
2853 u'_revision_number': 1,
2854 u'author': {
2855 u'_account_id': 123,
2856 u'email': u'tricium@serviceaccount.com',
2857 u'name': u'Tricium'
2858 },
2859 u'date': u'2017-03-16 20:00:41.000000000',
2860 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2861 u'message': u'(1 comment)',
2862 u'tag': u'autogenerated:tricium',
2863 },
2864 {
2865 u'_revision_number': 1,
2866 u'author': {
2867 u'_account_id': 123,
2868 u'email': u'tricium@serviceaccount.com',
2869 u'name': u'Tricium'
2870 },
2871 u'date': u'2017-03-16 20:00:41.000000000',
2872 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2873 u'message': u'(1 comment)',
2874 u'tag': u'autogenerated:tricium',
2875 },
2876 {
2877 u'_revision_number': 2,
2878 u'author': {
2879 u'_account_id': 123,
2880 u'email': u'tricium@serviceaccount.com',
2881 u'name': u'reviewer'
2882 },
2883 u'date': u'2017-03-17 05:30:37.000000000',
2884 u'tag': u'autogenerated:tricium',
2885 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2886 u'message': u'(1 comment)',
2887 },
2888 ]
2889 }
2890 self.calls = [
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002891 (('GetChangeComments', 'x-review.googlesource.com', 'infra%2Finfra~1'),
2892 {}),
2893 (('GetChangeRobotComments', 'x-review.googlesource.com',
2894 'infra%2Finfra~1'), {
2895 'codereview.settings': [
2896 {
2897 u'author': {
2898 u'email': u'tricium@serviceaccount.com'
2899 },
2900 u'updated': u'2017-03-17 05:30:37.000000000',
2901 u'robot_run_id': u'5565031076855808',
2902 u'robot_id': u'Linter/Category',
2903 u'tag': u'autogenerated:tricium',
2904 u'patch_set': 2,
2905 u'side': u'REVISION',
2906 u'message': u'Linter warning message text',
2907 u'line': 32,
2908 },
2909 ],
2910 }),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002911 ]
2912 expected_comments_summary = [
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002913 git_cl._CommentSummary(
2914 date=datetime.datetime(2017, 3, 17, 5, 30, 37),
2915 message=(u'(1 comment)\n\ncodereview.settings\n'
2916 u' PS2, Line 32: https://x-review.googlesource.com/c/1/2/'
2917 u'codereview.settings#32\n'
2918 u' Linter warning message text\n'),
2919 sender=u'tricium@serviceaccount.com',
2920 autogenerated=True,
2921 approval=False,
2922 disapproval=False)
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002923 ]
2924 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00002925 issue=1, branchref='refs/heads/foo')
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002926 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002927
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002928 def test_get_remote_url_with_mirror(self):
2929 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002930
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002931 def selective_os_path_isdir_mock(path):
2932 if path == '/cache/this-dir-exists':
2933 return self._mocked_call('os.path.isdir', path)
2934 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002935
Edward Lemurda4b6c62020-02-13 00:28:40 +00002936 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002937
2938 url = 'https://chromium.googlesource.com/my/repo'
Edward Lemur26964072020-02-19 19:18:51 +00002939 self.mockGit.config['remote.origin.url'] = (
2940 '/cache/this-dir-exists')
2941 self.mockGit.config['/cache/this-dir-exists:remote.origin.url'] = (
2942 url)
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002943 self.calls = [
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002944 (('os.path.isdir', '/cache/this-dir-exists'),
2945 True),
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002946 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002947 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002948 self.assertEqual(cl.GetRemoteUrl(), url)
2949 self.assertEqual(cl.GetRemoteUrl(), url) # Must be cached.
2950
Edward Lemur298f2cf2019-02-22 21:40:39 +00002951 def test_get_remote_url_non_existing_mirror(self):
2952 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002953
Edward Lemur298f2cf2019-02-22 21:40:39 +00002954 def selective_os_path_isdir_mock(path):
2955 if path == '/cache/this-dir-doesnt-exist':
2956 return self._mocked_call('os.path.isdir', path)
2957 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002958
Edward Lemurda4b6c62020-02-13 00:28:40 +00002959 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
2960 mock.patch('logging.error',
2961 lambda *a: self._mocked_call('logging.error', *a)).start()
Edward Lemur298f2cf2019-02-22 21:40:39 +00002962
Edward Lemur26964072020-02-19 19:18:51 +00002963 self.mockGit.config['remote.origin.url'] = (
2964 '/cache/this-dir-doesnt-exist')
Edward Lemur298f2cf2019-02-22 21:40:39 +00002965 self.calls = [
Edward Lemur298f2cf2019-02-22 21:40:39 +00002966 (('os.path.isdir', '/cache/this-dir-doesnt-exist'),
2967 False),
2968 (('logging.error',
Josip906bfde2020-01-31 22:38:49 +00002969 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
2970 'but it doesn\'t exist.', {
2971 'remote': 'origin',
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00002972 'branch': 'main',
Josip906bfde2020-01-31 22:38:49 +00002973 'url': '/cache/this-dir-doesnt-exist'}
2974 ), None),
Edward Lemur298f2cf2019-02-22 21:40:39 +00002975 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002976 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00002977 self.assertIsNone(cl.GetRemoteUrl())
2978
2979 def test_get_remote_url_misconfigured_mirror(self):
2980 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002981
Edward Lemur298f2cf2019-02-22 21:40:39 +00002982 def selective_os_path_isdir_mock(path):
2983 if path == '/cache/this-dir-exists':
2984 return self._mocked_call('os.path.isdir', path)
2985 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002986
Edward Lemurda4b6c62020-02-13 00:28:40 +00002987 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
2988 mock.patch('logging.error',
2989 lambda *a: self._mocked_call('logging.error', *a)).start()
Edward Lemur298f2cf2019-02-22 21:40:39 +00002990
Edward Lemur26964072020-02-19 19:18:51 +00002991 self.mockGit.config['remote.origin.url'] = (
2992 '/cache/this-dir-exists')
Edward Lemur298f2cf2019-02-22 21:40:39 +00002993 self.calls = [
Edward Lemur298f2cf2019-02-22 21:40:39 +00002994 (('os.path.isdir', '/cache/this-dir-exists'), True),
Edward Lemur298f2cf2019-02-22 21:40:39 +00002995 (('logging.error',
2996 'Remote "%(remote)s" for branch "%(branch)s" points to '
2997 '"%(cache_path)s", but it is misconfigured.\n'
2998 '"%(cache_path)s" must be a git repo and must have a remote named '
2999 '"%(remote)s" pointing to the git host.', {
3000 'remote': 'origin',
3001 'cache_path': '/cache/this-dir-exists',
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00003002 'branch': 'main'}
Edward Lemur298f2cf2019-02-22 21:40:39 +00003003 ), None),
3004 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00003005 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00003006 self.assertIsNone(cl.GetRemoteUrl())
3007
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003008 def test_gerrit_change_identifier_with_project(self):
Edward Lemur26964072020-02-19 19:18:51 +00003009 self.mockGit.config['remote.origin.url'] = (
3010 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemurf38bc172019-09-03 21:02:13 +00003011 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003012 self.assertEqual(cl._GerritChangeIdentifier(), 'my%2Frepo~123456')
3013
3014 def test_gerrit_change_identifier_without_project(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00003015 mock.patch('logging.error',
3016 lambda *a: self._mocked_call('logging.error', *a)).start()
Josip906bfde2020-01-31 22:38:49 +00003017
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003018 self.calls = [
Josip906bfde2020-01-31 22:38:49 +00003019 (('logging.error',
3020 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
3021 'but it doesn\'t exist.', {
3022 'remote': 'origin',
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00003023 'branch': 'main',
Josip906bfde2020-01-31 22:38:49 +00003024 'url': ''}
3025 ), None),
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003026 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00003027 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003028 self.assertEqual(cl._GerritChangeIdentifier(), '123456')
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00003029
Josip Sokcevicc39ab992020-09-24 20:09:15 +00003030 def test_gerrit_new_default(self):
3031 self._run_gerrit_upload_test(
3032 [],
3033 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
3034 [],
3035 squash=False,
3036 squash_mode='override_nosquash',
3037 change_id='I123456789',
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00003038 default_branch='main')
Josip Sokcevicc39ab992020-09-24 20:09:15 +00003039
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003040
Edward Lemur9aa1a962020-02-25 00:58:38 +00003041class ChangelistTest(unittest.TestCase):
mlcui3da91712021-05-05 10:00:30 +00003042 LAST_COMMIT_SUBJECT = 'Fixes goat teleporter destination to be Australia'
3043
3044 def _mock_run_git(commands):
3045 if commands == ['show', '-s', '--format=%s', 'HEAD']:
3046 return ChangelistTest.LAST_COMMIT_SUBJECT
3047
Edward Lemur227d5102020-02-25 23:45:35 +00003048 def setUp(self):
3049 super(ChangelistTest, self).setUp()
3050 mock.patch('gclient_utils.FileRead').start()
3051 mock.patch('gclient_utils.FileWrite').start()
3052 mock.patch('gclient_utils.temporary_file', TemporaryFileMock()).start()
3053 mock.patch(
3054 'git_cl.Changelist.GetCodereviewServer',
3055 return_value='https://chromium-review.googlesource.com').start()
3056 mock.patch('git_cl.Changelist.GetAuthor', return_value='author').start()
3057 mock.patch('git_cl.Changelist.GetIssue', return_value=123456).start()
3058 mock.patch('git_cl.Changelist.GetPatchset', return_value=7).start()
Dirk Pranke6f0df682021-06-25 00:42:33 +00003059 mock.patch('git_cl.Changelist.GetUsePython3', return_value=False).start()
Edward Lesmeseb1bd622021-03-01 19:54:07 +00003060 mock.patch(
3061 'git_cl.Changelist.GetRemoteBranch',
3062 return_value=('origin', 'refs/remotes/origin/main')).start()
Edward Lemur227d5102020-02-25 23:45:35 +00003063 mock.patch('git_cl.PRESUBMIT_SUPPORT', 'PRESUBMIT_SUPPORT').start()
3064 mock.patch('git_cl.Settings.GetRoot', return_value='root').start()
Aleksey Khoroshilov35ef5ad2022-06-03 18:29:25 +00003065 mock.patch('git_cl.Settings.GetIsGerrit', return_value=True).start()
Edward Lemur227d5102020-02-25 23:45:35 +00003066 mock.patch('git_cl.time_time').start()
3067 mock.patch('metrics.collector').start()
3068 mock.patch('subprocess2.Popen').start()
Edward Lesmeseb1bd622021-03-01 19:54:07 +00003069 mock.patch(
3070 'git_cl.Changelist.GetGerritProject', return_value='project').start()
Edward Lemur227d5102020-02-25 23:45:35 +00003071 self.addCleanup(mock.patch.stopall)
3072 self.temp_count = 0
3073
Edward Lemur227d5102020-02-25 23:45:35 +00003074 def testRunHook(self):
3075 expected_results = {
Dirk Pranke61bf6e82021-04-23 00:50:21 +00003076 'more_cc': ['cc@example.com', 'more@example.com'],
3077 'errors': [],
3078 'notifications': [],
3079 'warnings': [],
Edward Lemur227d5102020-02-25 23:45:35 +00003080 }
3081 gclient_utils.FileRead.return_value = json.dumps(expected_results)
Dirk Pranke61bf6e82021-04-23 00:50:21 +00003082 git_cl.time_time.side_effect = [100, 200, 300, 400]
Edward Lemur227d5102020-02-25 23:45:35 +00003083 mockProcess = mock.Mock()
3084 mockProcess.wait.return_value = 0
3085 subprocess2.Popen.return_value = mockProcess
3086
3087 cl = git_cl.Changelist()
3088 results = cl.RunHook(
3089 committing=True,
3090 may_prompt=True,
3091 verbose=2,
3092 parallel=True,
3093 upstream='upstream',
3094 description='description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003095 all_files=True,
3096 resultdb=False)
Edward Lemur227d5102020-02-25 23:45:35 +00003097
3098 self.assertEqual(expected_results, results)
Dirk Pranke61bf6e82021-04-23 00:50:21 +00003099 subprocess2.Popen.assert_any_call([
Josip Sokcevic632bbc02022-05-19 05:32:50 +00003100 'vpython3', 'PRESUBMIT_SUPPORT',
Edward Lemur227d5102020-02-25 23:45:35 +00003101 '--root', 'root',
3102 '--upstream', 'upstream',
3103 '--verbose', '--verbose',
Edward Lemur99df04e2020-03-05 19:39:43 +00003104 '--gerrit_url', 'https://chromium-review.googlesource.com',
Edward Lesmeseb1bd622021-03-01 19:54:07 +00003105 '--gerrit_project', 'project',
3106 '--gerrit_branch', 'refs/heads/main',
3107 '--author', 'author',
Edward Lemur227d5102020-02-25 23:45:35 +00003108 '--issue', '123456',
3109 '--patchset', '7',
Edward Lemur75526302020-02-27 22:31:05 +00003110 '--commit',
Edward Lemur227d5102020-02-25 23:45:35 +00003111 '--may_prompt',
3112 '--parallel',
3113 '--all_files',
Bruce Dawson09c0c072022-05-26 20:28:58 +00003114 '--no_diffs',
Edward Lemur227d5102020-02-25 23:45:35 +00003115 '--json_output', '/tmp/fake-temp2',
3116 '--description_file', '/tmp/fake-temp1',
3117 ])
Dirk Pranke61bf6e82021-04-23 00:50:21 +00003118 subprocess2.Popen.assert_any_call([
Josip Sokcevic632bbc02022-05-19 05:32:50 +00003119 'vpython', 'PRESUBMIT_SUPPORT',
Dirk Pranke61bf6e82021-04-23 00:50:21 +00003120 '--root', 'root',
3121 '--upstream', 'upstream',
3122 '--verbose', '--verbose',
3123 '--gerrit_url', 'https://chromium-review.googlesource.com',
3124 '--gerrit_project', 'project',
3125 '--gerrit_branch', 'refs/heads/main',
3126 '--author', 'author',
3127 '--issue', '123456',
3128 '--patchset', '7',
3129 '--commit',
3130 '--may_prompt',
3131 '--parallel',
3132 '--all_files',
Bruce Dawson09c0c072022-05-26 20:28:58 +00003133 '--no_diffs',
Dirk Pranke61bf6e82021-04-23 00:50:21 +00003134 '--json_output', '/tmp/fake-temp4',
3135 '--description_file', '/tmp/fake-temp3',
3136 ])
3137 gclient_utils.FileWrite.assert_any_call(
Edward Lemur1a83da12020-03-04 21:18:36 +00003138 '/tmp/fake-temp1', 'description')
Edward Lemur227d5102020-02-25 23:45:35 +00003139 metrics.collector.add_repeated('sub_commands', {
3140 'command': 'presubmit',
3141 'execution_time': 100,
3142 'exit_code': 0,
3143 })
3144
Edward Lemur99df04e2020-03-05 19:39:43 +00003145 def testRunHook_FewerOptions(self):
3146 expected_results = {
Dirk Pranke61bf6e82021-04-23 00:50:21 +00003147 'more_cc': ['cc@example.com', 'more@example.com'],
3148 'errors': [],
3149 'notifications': [],
3150 'warnings': [],
Edward Lemur99df04e2020-03-05 19:39:43 +00003151 }
3152 gclient_utils.FileRead.return_value = json.dumps(expected_results)
Dirk Pranke61bf6e82021-04-23 00:50:21 +00003153 git_cl.time_time.side_effect = [100, 200, 300, 400]
Edward Lemur99df04e2020-03-05 19:39:43 +00003154 mockProcess = mock.Mock()
3155 mockProcess.wait.return_value = 0
3156 subprocess2.Popen.return_value = mockProcess
3157
3158 git_cl.Changelist.GetAuthor.return_value = None
3159 git_cl.Changelist.GetIssue.return_value = None
3160 git_cl.Changelist.GetPatchset.return_value = None
Edward Lemur99df04e2020-03-05 19:39:43 +00003161
3162 cl = git_cl.Changelist()
3163 results = cl.RunHook(
3164 committing=False,
3165 may_prompt=False,
3166 verbose=0,
3167 parallel=False,
3168 upstream='upstream',
3169 description='description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003170 all_files=False,
3171 resultdb=False)
Edward Lemur99df04e2020-03-05 19:39:43 +00003172
3173 self.assertEqual(expected_results, results)
Dirk Pranke61bf6e82021-04-23 00:50:21 +00003174 subprocess2.Popen.assert_any_call([
Josip Sokcevic632bbc02022-05-19 05:32:50 +00003175 'vpython3', 'PRESUBMIT_SUPPORT',
Edward Lemur99df04e2020-03-05 19:39:43 +00003176 '--root', 'root',
3177 '--upstream', 'upstream',
Edward Lesmeseb1bd622021-03-01 19:54:07 +00003178 '--gerrit_url', 'https://chromium-review.googlesource.com',
3179 '--gerrit_project', 'project',
3180 '--gerrit_branch', 'refs/heads/main',
Edward Lemur99df04e2020-03-05 19:39:43 +00003181 '--upload',
3182 '--json_output', '/tmp/fake-temp2',
3183 '--description_file', '/tmp/fake-temp1',
3184 ])
Dirk Pranke61bf6e82021-04-23 00:50:21 +00003185 gclient_utils.FileWrite.assert_any_call(
Edward Lemur99df04e2020-03-05 19:39:43 +00003186 '/tmp/fake-temp1', 'description')
3187 metrics.collector.add_repeated('sub_commands', {
3188 'command': 'presubmit',
3189 'execution_time': 100,
3190 'exit_code': 0,
3191 })
3192
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003193 def testRunHook_FewerOptionsResultDB(self):
3194 expected_results = {
Dirk Pranke61bf6e82021-04-23 00:50:21 +00003195 'more_cc': ['cc@example.com', 'more@example.com'],
3196 'errors': [],
3197 'notifications': [],
3198 'warnings': [],
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003199 }
3200 gclient_utils.FileRead.return_value = json.dumps(expected_results)
Dirk Pranke61bf6e82021-04-23 00:50:21 +00003201 git_cl.time_time.side_effect = [100, 200, 300, 400]
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003202 mockProcess = mock.Mock()
3203 mockProcess.wait.return_value = 0
3204 subprocess2.Popen.return_value = mockProcess
3205
3206 git_cl.Changelist.GetAuthor.return_value = None
3207 git_cl.Changelist.GetIssue.return_value = None
3208 git_cl.Changelist.GetPatchset.return_value = None
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003209
3210 cl = git_cl.Changelist()
3211 results = cl.RunHook(
3212 committing=False,
3213 may_prompt=False,
3214 verbose=0,
3215 parallel=False,
3216 upstream='upstream',
3217 description='description',
3218 all_files=False,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003219 resultdb=True,
3220 realm='chromium:public')
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003221
3222 self.assertEqual(expected_results, results)
Dirk Pranke61bf6e82021-04-23 00:50:21 +00003223 subprocess2.Popen.assert_any_call([
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003224 'rdb', 'stream', '-new', '-realm', 'chromium:public', '--',
Josip Sokcevic632bbc02022-05-19 05:32:50 +00003225 'vpython3', 'PRESUBMIT_SUPPORT',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003226 '--root', 'root',
3227 '--upstream', 'upstream',
Edward Lesmeseb1bd622021-03-01 19:54:07 +00003228 '--gerrit_url', 'https://chromium-review.googlesource.com',
3229 '--gerrit_project', 'project',
3230 '--gerrit_branch', 'refs/heads/main',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003231 '--upload',
3232 '--json_output', '/tmp/fake-temp2',
3233 '--description_file', '/tmp/fake-temp1',
3234 ])
3235
Aleksey Khoroshilov35ef5ad2022-06-03 18:29:25 +00003236 def testRunHook_NoGerrit(self):
3237 mock.patch('git_cl.Settings.GetIsGerrit', return_value=False).start()
3238
3239 expected_results = {
3240 'more_cc': ['cc@example.com', 'more@example.com'],
3241 'errors': [],
3242 'notifications': [],
3243 'warnings': [],
3244 }
3245 gclient_utils.FileRead.return_value = json.dumps(expected_results)
3246 git_cl.time_time.side_effect = [100, 200, 300, 400]
3247 mockProcess = mock.Mock()
3248 mockProcess.wait.return_value = 0
3249 subprocess2.Popen.return_value = mockProcess
3250
3251 git_cl.Changelist.GetAuthor.return_value = None
3252 git_cl.Changelist.GetIssue.return_value = None
3253 git_cl.Changelist.GetPatchset.return_value = None
3254
3255 cl = git_cl.Changelist()
3256 results = cl.RunHook(
3257 committing=False,
3258 may_prompt=False,
3259 verbose=0,
3260 parallel=False,
3261 upstream='upstream',
3262 description='description',
3263 all_files=False,
3264 resultdb=False)
3265
3266 self.assertEqual(expected_results, results)
3267 subprocess2.Popen.assert_any_call([
3268 'vpython3', 'PRESUBMIT_SUPPORT',
3269 '--root', 'root',
3270 '--upstream', 'upstream',
3271 '--upload',
3272 '--json_output', '/tmp/fake-temp2',
3273 '--description_file', '/tmp/fake-temp1',
3274 ])
3275 gclient_utils.FileWrite.assert_any_call(
3276 '/tmp/fake-temp1', 'description')
3277 metrics.collector.add_repeated('sub_commands', {
3278 'command': 'presubmit',
3279 'execution_time': 100,
3280 'exit_code': 0,
3281 })
3282
Edward Lemur227d5102020-02-25 23:45:35 +00003283 @mock.patch('sys.exit', side_effect=SystemExitMock)
3284 def testRunHook_Failure(self, _mock):
3285 git_cl.time_time.side_effect = [100, 200]
3286 mockProcess = mock.Mock()
3287 mockProcess.wait.return_value = 2
3288 subprocess2.Popen.return_value = mockProcess
3289
3290 cl = git_cl.Changelist()
3291 with self.assertRaises(SystemExitMock):
3292 cl.RunHook(
3293 committing=True,
3294 may_prompt=True,
3295 verbose=2,
3296 parallel=True,
3297 upstream='upstream',
3298 description='description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003299 all_files=True,
3300 resultdb=False)
Edward Lemur227d5102020-02-25 23:45:35 +00003301
3302 sys.exit.assert_called_once_with(2)
3303
Edward Lemur75526302020-02-27 22:31:05 +00003304 def testRunPostUploadHook(self):
3305 cl = git_cl.Changelist()
3306 cl.RunPostUploadHook(2, 'upstream', 'description')
3307
Josip Sokcevice293d3d2022-02-16 22:52:15 +00003308 subprocess2.Popen.assert_any_call([
3309 'vpython',
3310 'PRESUBMIT_SUPPORT',
3311 '--root',
3312 'root',
3313 '--upstream',
3314 'upstream',
3315 '--verbose',
3316 '--verbose',
3317 '--gerrit_url',
3318 'https://chromium-review.googlesource.com',
3319 '--gerrit_project',
3320 'project',
3321 '--gerrit_branch',
3322 'refs/heads/main',
3323 '--author',
3324 'author',
3325 '--issue',
3326 '123456',
3327 '--patchset',
3328 '7',
Edward Lemur75526302020-02-27 22:31:05 +00003329 '--post_upload',
Josip Sokcevice293d3d2022-02-16 22:52:15 +00003330 '--description_file',
3331 '/tmp/fake-temp1',
Edward Lemur75526302020-02-27 22:31:05 +00003332 ])
Josip Sokcevice293d3d2022-02-16 22:52:15 +00003333 subprocess2.Popen.assert_called_with([
3334 'vpython3',
3335 'PRESUBMIT_SUPPORT',
3336 '--root',
3337 'root',
3338 '--upstream',
3339 'upstream',
3340 '--verbose',
3341 '--verbose',
3342 '--gerrit_url',
3343 'https://chromium-review.googlesource.com',
3344 '--gerrit_project',
3345 'project',
3346 '--gerrit_branch',
3347 'refs/heads/main',
3348 '--author',
3349 'author',
3350 '--issue',
3351 '123456',
3352 '--patchset',
3353 '7',
3354 '--post_upload',
3355 '--description_file',
3356 '/tmp/fake-temp1',
3357 '--use-python3',
3358 ])
3359
Edward Lemur75526302020-02-27 22:31:05 +00003360 gclient_utils.FileWrite.assert_called_once_with(
Edward Lemur1a83da12020-03-04 21:18:36 +00003361 '/tmp/fake-temp1', 'description')
Edward Lemur75526302020-02-27 22:31:05 +00003362
mlcui3da91712021-05-05 10:00:30 +00003363 @mock.patch('git_cl.RunGit', _mock_run_git)
3364 def testDefaultTitleEmptyMessage(self):
3365 cl = git_cl.Changelist()
3366 cl.issue = 100
3367 options = optparse.Values({
3368 'squash': True,
3369 'title': None,
3370 'message': None,
3371 'force': None,
3372 'skip_title': None
3373 })
3374
3375 mock.patch('gclient_utils.AskForData', lambda _: user_title).start()
3376 for user_title in ['', 'y', 'Y']:
3377 self.assertEqual(cl._GetTitleForUpload(options), self.LAST_COMMIT_SUBJECT)
3378
3379 for user_title in ['not empty', 'yes', 'YES']:
3380 self.assertEqual(cl._GetTitleForUpload(options), user_title)
3381
Edward Lemur9aa1a962020-02-25 00:58:38 +00003382
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003383class CMDTestCaseBase(unittest.TestCase):
3384 _STATUSES = [
3385 'STATUS_UNSPECIFIED', 'SCHEDULED', 'STARTED', 'SUCCESS', 'FAILURE',
3386 'INFRA_FAILURE', 'CANCELED',
3387 ]
3388 _CHANGE_DETAIL = {
3389 'project': 'depot_tools',
3390 'status': 'OPEN',
3391 'owner': {'email': 'owner@e.mail'},
3392 'current_revision': 'beeeeeef',
3393 'revisions': {
Gavin Make61ccc52020-11-13 00:12:57 +00003394 'deadbeaf': {
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00003395 '_number': 6,
Gavin Make61ccc52020-11-13 00:12:57 +00003396 'kind': 'REWORK',
3397 },
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003398 'beeeeeef': {
3399 '_number': 7,
Gavin Make61ccc52020-11-13 00:12:57 +00003400 'kind': 'NO_CODE_CHANGE',
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003401 'fetch': {'http': {
3402 'url': 'https://chromium.googlesource.com/depot_tools',
3403 'ref': 'refs/changes/56/123456/7'
3404 }},
3405 },
3406 },
3407 }
3408 _DEFAULT_RESPONSE = {
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003409 'builds': [{
3410 'id': str(100 + idx),
3411 'builder': {
3412 'project': 'chromium',
3413 'bucket': 'try',
3414 'builder': 'bot_' + status.lower(),
3415 },
3416 'createTime': '2019-10-09T08:00:0%d.854286Z' % (idx % 10),
3417 'tags': [],
3418 'status': status,
3419 } for idx, status in enumerate(_STATUSES)]
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003420 }
3421
Edward Lemur4c707a22019-09-24 21:13:43 +00003422 def setUp(self):
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003423 super(CMDTestCaseBase, self).setUp()
Edward Lemur79d4f992019-11-11 23:49:02 +00003424 mock.patch('git_cl.sys.stdout', StringIO()).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003425 mock.patch('git_cl.uuid.uuid4', return_value='uuid4').start()
3426 mock.patch('git_cl.Changelist.GetIssue', return_value=123456).start()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00003427 mock.patch(
3428 'git_cl.Changelist.GetCodereviewServer',
3429 return_value='https://chromium-review.googlesource.com').start()
3430 mock.patch(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00003431 'git_cl.Changelist.GetGerritHost',
Edward Lesmes7677e5c2020-02-19 20:39:03 +00003432 return_value='chromium-review.googlesource.com').start()
3433 mock.patch(
3434 'git_cl.Changelist.GetMostRecentPatchset',
3435 return_value=7).start()
3436 mock.patch(
Gavin Make61ccc52020-11-13 00:12:57 +00003437 'git_cl.Changelist.GetMostRecentDryRunPatchset',
3438 return_value=6).start()
3439 mock.patch(
Edward Lesmes7677e5c2020-02-19 20:39:03 +00003440 'git_cl.Changelist.GetRemoteUrl',
3441 return_value='https://chromium.googlesource.com/depot_tools').start()
3442 mock.patch(
3443 'auth.Authenticator',
3444 return_value=AuthenticatorMock()).start()
3445 mock.patch(
3446 'gerrit_util.GetChangeDetail',
3447 return_value=self._CHANGE_DETAIL).start()
3448 mock.patch(
3449 'git_cl._call_buildbucket',
3450 return_value = self._DEFAULT_RESPONSE).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003451 mock.patch('git_common.is_dirty_git_tree', return_value=False).start()
Edward Lemur4c707a22019-09-24 21:13:43 +00003452 self.addCleanup(mock.patch.stopall)
3453
Edward Lemur4c707a22019-09-24 21:13:43 +00003454
Edward Lemur9468eba2020-02-27 19:07:22 +00003455class CMDPresubmitTestCase(CMDTestCaseBase):
3456 def setUp(self):
3457 super(CMDPresubmitTestCase, self).setUp()
3458 mock.patch(
3459 'git_cl.Changelist.GetCommonAncestorWithUpstream',
3460 return_value='upstream').start()
3461 mock.patch(
3462 'git_cl.Changelist.FetchDescription',
3463 return_value='fetch description').start()
3464 mock.patch(
Edward Lemura12175c2020-03-09 16:58:26 +00003465 'git_cl._create_description_from_log',
Edward Lemur9468eba2020-02-27 19:07:22 +00003466 return_value='get description').start()
3467 mock.patch('git_cl.Changelist.RunHook').start()
3468
3469 def testDefaultCase(self):
3470 self.assertEqual(0, git_cl.main(['presubmit']))
3471 git_cl.Changelist.RunHook.assert_called_once_with(
3472 committing=True,
3473 may_prompt=False,
3474 verbose=0,
3475 parallel=None,
3476 upstream='upstream',
3477 description='fetch description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003478 all_files=None,
Josip Sokcevic017544d2022-03-31 23:47:53 +00003479 files=None,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003480 resultdb=None,
3481 realm=None)
Edward Lemur9468eba2020-02-27 19:07:22 +00003482
3483 def testNoIssue(self):
3484 git_cl.Changelist.GetIssue.return_value = None
3485 self.assertEqual(0, git_cl.main(['presubmit']))
3486 git_cl.Changelist.RunHook.assert_called_once_with(
3487 committing=True,
3488 may_prompt=False,
3489 verbose=0,
3490 parallel=None,
3491 upstream='upstream',
3492 description='get description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003493 all_files=None,
Josip Sokcevic017544d2022-03-31 23:47:53 +00003494 files=None,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003495 resultdb=None,
3496 realm=None)
Edward Lemur9468eba2020-02-27 19:07:22 +00003497
3498 def testCustomBranch(self):
3499 self.assertEqual(0, git_cl.main(['presubmit', 'custom_branch']))
3500 git_cl.Changelist.RunHook.assert_called_once_with(
3501 committing=True,
3502 may_prompt=False,
3503 verbose=0,
3504 parallel=None,
3505 upstream='custom_branch',
3506 description='fetch description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003507 all_files=None,
Josip Sokcevic017544d2022-03-31 23:47:53 +00003508 files=None,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003509 resultdb=None,
3510 realm=None)
Edward Lemur9468eba2020-02-27 19:07:22 +00003511
3512 def testOptions(self):
3513 self.assertEqual(
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003514 0, git_cl.main(['presubmit', '-v', '-v', '--all', '--parallel', '-u',
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003515 '--resultdb', '--realm', 'chromium:public']))
Edward Lemur9468eba2020-02-27 19:07:22 +00003516 git_cl.Changelist.RunHook.assert_called_once_with(
3517 committing=False,
3518 may_prompt=False,
3519 verbose=2,
3520 parallel=True,
3521 upstream='upstream',
3522 description='fetch description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003523 all_files=True,
Josip Sokcevic017544d2022-03-31 23:47:53 +00003524 files=None,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003525 resultdb=True,
3526 realm='chromium:public')
Edward Lemur9468eba2020-02-27 19:07:22 +00003527
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003528class CMDTryResultsTestCase(CMDTestCaseBase):
3529 _DEFAULT_REQUEST = {
3530 'predicate': {
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003531 "gerritChanges": [{
3532 "project": "depot_tools",
3533 "host": "chromium-review.googlesource.com",
Gavin Make61ccc52020-11-13 00:12:57 +00003534 "patchset": 6,
3535 "change": 123456,
3536 }],
3537 },
3538 'fields': ('builds.*.id,builds.*.builder,builds.*.status' +
3539 ',builds.*.createTime,builds.*.tags'),
3540 }
3541
3542 _TRIVIAL_REQUEST = {
3543 'predicate': {
3544 "gerritChanges": [{
3545 "project": "depot_tools",
3546 "host": "chromium-review.googlesource.com",
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003547 "patchset": 7,
3548 "change": 123456,
3549 }],
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003550 },
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003551 'fields': ('builds.*.id,builds.*.builder,builds.*.status' +
3552 ',builds.*.createTime,builds.*.tags'),
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003553 }
3554
3555 def testNoJobs(self):
3556 git_cl._call_buildbucket.return_value = {}
3557
3558 self.assertEqual(0, git_cl.main(['try-results']))
3559 self.assertEqual('No tryjobs scheduled.\n', sys.stdout.getvalue())
3560 git_cl._call_buildbucket.assert_called_once_with(
3561 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3562 self._DEFAULT_REQUEST)
3563
Gavin Make61ccc52020-11-13 00:12:57 +00003564 def testTrivialCommits(self):
3565 self.assertEqual(0, git_cl.main(['try-results']))
3566 git_cl._call_buildbucket.assert_called_with(
3567 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3568 self._DEFAULT_REQUEST)
3569
3570 git_cl._call_buildbucket.return_value = {}
3571 self.assertEqual(0, git_cl.main(['try-results', '--patchset', '7']))
3572 git_cl._call_buildbucket.assert_called_with(
3573 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3574 self._TRIVIAL_REQUEST)
3575 self.assertEqual([
3576 'Successes:',
3577 ' bot_success https://ci.chromium.org/b/103',
3578 'Infra Failures:',
3579 ' bot_infra_failure https://ci.chromium.org/b/105',
3580 'Failures:',
3581 ' bot_failure https://ci.chromium.org/b/104',
3582 'Canceled:',
3583 ' bot_canceled ',
3584 'Started:',
3585 ' bot_started https://ci.chromium.org/b/102',
3586 'Scheduled:',
3587 ' bot_scheduled id=101',
3588 'Other:',
3589 ' bot_status_unspecified id=100',
3590 'Total: 7 tryjobs',
3591 'No tryjobs scheduled.',
3592 ], sys.stdout.getvalue().splitlines())
3593
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003594 def testPrintToStdout(self):
3595 self.assertEqual(0, git_cl.main(['try-results']))
3596 self.assertEqual([
3597 'Successes:',
3598 ' bot_success https://ci.chromium.org/b/103',
3599 'Infra Failures:',
3600 ' bot_infra_failure https://ci.chromium.org/b/105',
3601 'Failures:',
3602 ' bot_failure https://ci.chromium.org/b/104',
3603 'Canceled:',
3604 ' bot_canceled ',
3605 'Started:',
3606 ' bot_started https://ci.chromium.org/b/102',
3607 'Scheduled:',
3608 ' bot_scheduled id=101',
3609 'Other:',
3610 ' bot_status_unspecified id=100',
3611 'Total: 7 tryjobs',
3612 ], sys.stdout.getvalue().splitlines())
3613 git_cl._call_buildbucket.assert_called_once_with(
3614 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3615 self._DEFAULT_REQUEST)
3616
3617 def testPrintToStdoutWithMasters(self):
3618 self.assertEqual(0, git_cl.main(['try-results', '--print-master']))
3619 self.assertEqual([
3620 'Successes:',
3621 ' try bot_success https://ci.chromium.org/b/103',
3622 'Infra Failures:',
3623 ' try bot_infra_failure https://ci.chromium.org/b/105',
3624 'Failures:',
3625 ' try bot_failure https://ci.chromium.org/b/104',
3626 'Canceled:',
3627 ' try bot_canceled ',
3628 'Started:',
3629 ' try bot_started https://ci.chromium.org/b/102',
3630 'Scheduled:',
3631 ' try bot_scheduled id=101',
3632 'Other:',
3633 ' try bot_status_unspecified id=100',
3634 'Total: 7 tryjobs',
3635 ], sys.stdout.getvalue().splitlines())
3636 git_cl._call_buildbucket.assert_called_once_with(
3637 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3638 self._DEFAULT_REQUEST)
3639
3640 @mock.patch('git_cl.write_json')
3641 def testWriteToJson(self, mockJsonDump):
3642 self.assertEqual(0, git_cl.main(['try-results', '--json', 'file.json']))
3643 git_cl._call_buildbucket.assert_called_once_with(
3644 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3645 self._DEFAULT_REQUEST)
3646 mockJsonDump.assert_called_once_with(
3647 'file.json', self._DEFAULT_RESPONSE['builds'])
3648
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003649 def test_filter_failed_for_one_simple(self):
Edward Lemur45768512020-03-02 19:03:14 +00003650 self.assertEqual([], git_cl._filter_failed_for_retry([]))
3651 self.assertEqual(
3652 [
3653 ('chromium', 'try', 'bot_failure'),
3654 ('chromium', 'try', 'bot_infra_failure'),
3655 ],
3656 git_cl._filter_failed_for_retry(self._DEFAULT_RESPONSE['builds']))
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003657
3658 def test_filter_failed_for_retry_many_builds(self):
3659
3660 def _build(name, created_sec, status, experimental=False):
3661 assert 0 <= created_sec < 100, created_sec
3662 b = {
3663 'id': 112112,
3664 'builder': {
3665 'project': 'chromium',
3666 'bucket': 'try',
3667 'builder': name,
3668 },
3669 'createTime': '2019-10-09T08:00:%02d.854286Z' % created_sec,
3670 'status': status,
3671 'tags': [],
3672 }
3673 if experimental:
3674 b['tags'].append({'key': 'cq_experimental', 'value': 'true'})
3675 return b
3676
3677 builds = [
3678 _build('flaky-last-green', 1, 'FAILURE'),
3679 _build('flaky-last-green', 2, 'SUCCESS'),
3680 _build('flaky', 1, 'SUCCESS'),
3681 _build('flaky', 2, 'FAILURE'),
3682 _build('running', 1, 'FAILED'),
3683 _build('running', 2, 'SCHEDULED'),
3684 _build('yep-still-running', 1, 'STARTED'),
3685 _build('yep-still-running', 2, 'FAILURE'),
3686 _build('cq-experimental', 1, 'SUCCESS', experimental=True),
3687 _build('cq-experimental', 2, 'FAILURE', experimental=True),
3688
3689 # Simulate experimental in CQ builder, which developer decided
3690 # to retry manually which resulted in 2nd build non-experimental.
3691 _build('sometimes-experimental', 1, 'FAILURE', experimental=True),
3692 _build('sometimes-experimental', 2, 'FAILURE', experimental=False),
3693 ]
3694 builds.sort(key=lambda b: b['status']) # ~deterministic shuffle.
Edward Lemur45768512020-03-02 19:03:14 +00003695 self.assertEqual(
3696 [
3697 ('chromium', 'try', 'flaky'),
3698 ('chromium', 'try', 'sometimes-experimental'),
3699 ],
3700 git_cl._filter_failed_for_retry(builds))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003701
3702
3703class CMDTryTestCase(CMDTestCaseBase):
3704
3705 @mock.patch('git_cl.Changelist.SetCQState')
Edward Lemur45768512020-03-02 19:03:14 +00003706 def testSetCQDryRunByDefault(self, mockSetCQState):
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003707 mockSetCQState.return_value = 0
Edward Lemur4c707a22019-09-24 21:13:43 +00003708 self.assertEqual(0, git_cl.main(['try']))
3709 git_cl.Changelist.SetCQState.assert_called_with(git_cl._CQState.DRY_RUN)
3710 self.assertEqual(
3711 sys.stdout.getvalue(),
3712 'Scheduling CQ dry run on: '
3713 'https://chromium-review.googlesource.com/123456\n')
3714
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00003715 @mock.patch('git_cl.Changelist.SetCQState')
3716 def testSetCQQuickRunByDefault(self, mockSetCQState):
3717 mockSetCQState.return_value = 0
3718 self.assertEqual(0, git_cl.main(['try', '-q']))
3719 git_cl.Changelist.SetCQState.assert_called_with(git_cl._CQState.QUICK_RUN)
3720 self.assertEqual(
3721 sys.stdout.getvalue(),
3722 'Scheduling CQ quick run on: '
3723 'https://chromium-review.googlesource.com/123456\n')
3724
Edward Lemur4c707a22019-09-24 21:13:43 +00003725 @mock.patch('git_cl._call_buildbucket')
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003726 def testScheduleOnBuildbucket(self, mockCallBuildbucket):
Edward Lemur4c707a22019-09-24 21:13:43 +00003727 mockCallBuildbucket.return_value = {}
Edward Lemur4c707a22019-09-24 21:13:43 +00003728
3729 self.assertEqual(0, git_cl.main([
3730 'try', '-B', 'luci.chromium.try', '-b', 'win',
3731 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
3732 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003733 'Scheduling jobs on:\n'
3734 ' chromium/try: win',
Edward Lemur4c707a22019-09-24 21:13:43 +00003735 git_cl.sys.stdout.getvalue())
3736
3737 expected_request = {
3738 "requests": [{
3739 "scheduleBuild": {
3740 "requestId": "uuid4",
3741 "builder": {
3742 "project": "chromium",
3743 "builder": "win",
3744 "bucket": "try",
3745 },
3746 "gerritChanges": [{
3747 "project": "depot_tools",
3748 "host": "chromium-review.googlesource.com",
3749 "patchset": 7,
3750 "change": 123456,
3751 }],
3752 "properties": {
3753 "category": "git_cl_try",
3754 "json": [{"a": 1}, None],
3755 "key": "val",
3756 },
3757 "tags": [
3758 {"value": "win", "key": "builder"},
3759 {"value": "git_cl_try", "key": "user_agent"},
3760 ],
3761 },
3762 }],
3763 }
3764 mockCallBuildbucket.assert_called_with(
3765 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3766
Anthony Polito1a5fe232020-01-24 23:17:52 +00003767 @mock.patch('git_cl._call_buildbucket')
3768 def testScheduleOnBuildbucketWithRevision(self, mockCallBuildbucket):
3769 mockCallBuildbucket.return_value = {}
Josip Sokcevic9011a5b2021-02-12 18:59:44 +00003770 mock.patch('git_cl.Changelist.GetRemoteBranch',
3771 return_value=('origin', 'refs/remotes/origin/main')).start()
Anthony Polito1a5fe232020-01-24 23:17:52 +00003772
3773 self.assertEqual(0, git_cl.main([
3774 'try', '-B', 'luci.chromium.try', '-b', 'win', '-b', 'linux',
3775 '-p', 'key=val', '-p', 'json=[{"a":1}, null]',
3776 '-r', 'beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef']))
3777 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003778 'Scheduling jobs on:\n'
3779 ' chromium/try: linux\n'
3780 ' chromium/try: win',
Anthony Polito1a5fe232020-01-24 23:17:52 +00003781 git_cl.sys.stdout.getvalue())
3782
3783 expected_request = {
3784 "requests": [{
3785 "scheduleBuild": {
3786 "requestId": "uuid4",
3787 "builder": {
3788 "project": "chromium",
3789 "builder": "linux",
3790 "bucket": "try",
3791 },
3792 "gerritChanges": [{
3793 "project": "depot_tools",
3794 "host": "chromium-review.googlesource.com",
3795 "patchset": 7,
3796 "change": 123456,
3797 }],
3798 "properties": {
3799 "category": "git_cl_try",
3800 "json": [{"a": 1}, None],
3801 "key": "val",
3802 },
3803 "tags": [
3804 {"value": "linux", "key": "builder"},
3805 {"value": "git_cl_try", "key": "user_agent"},
3806 ],
3807 "gitilesCommit": {
3808 "host": "chromium-review.googlesource.com",
3809 "project": "depot_tools",
3810 "id": "beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef",
Josip Sokcevic9011a5b2021-02-12 18:59:44 +00003811 "ref": "refs/heads/main",
Anthony Polito1a5fe232020-01-24 23:17:52 +00003812 }
3813 },
3814 },
3815 {
3816 "scheduleBuild": {
3817 "requestId": "uuid4",
3818 "builder": {
3819 "project": "chromium",
3820 "builder": "win",
3821 "bucket": "try",
3822 },
3823 "gerritChanges": [{
3824 "project": "depot_tools",
3825 "host": "chromium-review.googlesource.com",
3826 "patchset": 7,
3827 "change": 123456,
3828 }],
3829 "properties": {
3830 "category": "git_cl_try",
3831 "json": [{"a": 1}, None],
3832 "key": "val",
3833 },
3834 "tags": [
3835 {"value": "win", "key": "builder"},
3836 {"value": "git_cl_try", "key": "user_agent"},
3837 ],
3838 "gitilesCommit": {
3839 "host": "chromium-review.googlesource.com",
3840 "project": "depot_tools",
3841 "id": "beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef",
Josip Sokcevic9011a5b2021-02-12 18:59:44 +00003842 "ref": "refs/heads/main",
Anthony Polito1a5fe232020-01-24 23:17:52 +00003843 }
3844 },
3845 }],
3846 }
3847 mockCallBuildbucket.assert_called_with(
3848 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3849
Edward Lemur45768512020-03-02 19:03:14 +00003850 @mock.patch('sys.stderr', StringIO())
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003851 def testScheduleOnBuildbucket_WrongBucket(self):
Edward Lemur45768512020-03-02 19:03:14 +00003852 with self.assertRaises(SystemExit):
3853 git_cl.main([
3854 'try', '-B', 'not-a-bucket', '-b', 'win',
3855 '-p', 'key=val', '-p', 'json=[{"a":1}, null]'])
Edward Lemur4c707a22019-09-24 21:13:43 +00003856 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003857 'Invalid bucket: not-a-bucket.',
3858 sys.stderr.getvalue())
Edward Lemur4c707a22019-09-24 21:13:43 +00003859
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003860 @mock.patch('git_cl._call_buildbucket')
Quinten Yearsley777660f2020-03-04 23:37:06 +00003861 @mock.patch('git_cl._fetch_tryjobs')
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003862 def testScheduleOnBuildbucketRetryFailed(
3863 self, mockFetchTryJobs, mockCallBuildbucket):
Quinten Yearsley777660f2020-03-04 23:37:06 +00003864 git_cl._fetch_tryjobs.side_effect = lambda *_, **kw: {
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003865 7: [],
3866 6: [{
3867 'id': 112112,
3868 'builder': {
3869 'project': 'chromium',
3870 'bucket': 'try',
Quinten Yearsley777660f2020-03-04 23:37:06 +00003871 'builder': 'linux', },
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003872 'createTime': '2019-10-09T08:00:01.854286Z',
3873 'tags': [],
Quinten Yearsley777660f2020-03-04 23:37:06 +00003874 'status': 'FAILURE', }], }[kw['patchset']]
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003875 mockCallBuildbucket.return_value = {}
3876
3877 self.assertEqual(0, git_cl.main(['try', '--retry-failed']))
3878 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003879 'Scheduling jobs on:\n'
3880 ' chromium/try: linux',
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003881 git_cl.sys.stdout.getvalue())
3882
3883 expected_request = {
3884 "requests": [{
3885 "scheduleBuild": {
3886 "requestId": "uuid4",
3887 "builder": {
3888 "project": "chromium",
3889 "bucket": "try",
3890 "builder": "linux",
3891 },
3892 "gerritChanges": [{
3893 "project": "depot_tools",
3894 "host": "chromium-review.googlesource.com",
3895 "patchset": 7,
3896 "change": 123456,
3897 }],
3898 "properties": {
3899 "category": "git_cl_try",
3900 },
3901 "tags": [
3902 {"value": "linux", "key": "builder"},
3903 {"value": "git_cl_try", "key": "user_agent"},
3904 {"value": "1", "key": "retry_failed"},
3905 ],
3906 },
3907 }],
3908 }
3909 mockCallBuildbucket.assert_called_with(
3910 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3911
Edward Lemur4c707a22019-09-24 21:13:43 +00003912 def test_parse_bucket(self):
3913 test_cases = [
3914 {
3915 'bucket': 'chromium/try',
3916 'result': ('chromium', 'try'),
3917 },
3918 {
3919 'bucket': 'luci.chromium.try',
3920 'result': ('chromium', 'try'),
3921 'has_warning': True,
3922 },
3923 {
3924 'bucket': 'skia.primary',
3925 'result': ('skia', 'skia.primary'),
3926 'has_warning': True,
3927 },
3928 {
3929 'bucket': 'not-a-bucket',
3930 'result': (None, None),
3931 },
3932 ]
3933
3934 for test_case in test_cases:
3935 git_cl.sys.stdout.truncate(0)
3936 self.assertEqual(
3937 test_case['result'], git_cl._parse_bucket(test_case['bucket']))
3938 if test_case.get('has_warning'):
Edward Lemur6215c792019-10-03 21:59:05 +00003939 expected_warning = 'WARNING Please use %s/%s to specify the bucket' % (
3940 test_case['result'])
3941 self.assertIn(expected_warning, git_cl.sys.stdout.getvalue())
Edward Lemur4c707a22019-09-24 21:13:43 +00003942
3943
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003944class CMDUploadTestCase(CMDTestCaseBase):
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +00003945
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003946 def setUp(self):
3947 super(CMDUploadTestCase, self).setUp()
Quinten Yearsley777660f2020-03-04 23:37:06 +00003948 mock.patch('git_cl._fetch_tryjobs').start()
3949 mock.patch('git_cl._trigger_tryjobs', return_value={}).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003950 mock.patch('git_cl.Changelist.CMDUpload', return_value=0).start()
Edward Lesmes0dd54822020-03-26 18:24:25 +00003951 mock.patch('git_cl.Settings.GetRoot', return_value='').start()
3952 mock.patch(
3953 'git_cl.Settings.GetSquashGerritUploads',
3954 return_value=True).start()
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003955 self.addCleanup(mock.patch.stopall)
3956
Edward Lesmes7677e5c2020-02-19 20:39:03 +00003957 def testWarmUpChangeDetailCache(self):
3958 self.assertEqual(0, git_cl.main(['upload']))
3959 gerrit_util.GetChangeDetail.assert_called_once_with(
3960 'chromium-review.googlesource.com', 'depot_tools~123456',
3961 frozenset([
3962 'LABELS', 'CURRENT_REVISION', 'DETAILED_ACCOUNTS',
3963 'CURRENT_COMMIT']))
3964
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003965 def testUploadRetryFailed(self):
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003966 # This test mocks out the actual upload part, and just asserts that after
3967 # upload, if --retry-failed is added, then the tool will fetch try jobs
3968 # from the previous patchset and trigger the right builders on the latest
3969 # patchset.
Quinten Yearsley777660f2020-03-04 23:37:06 +00003970 git_cl._fetch_tryjobs.side_effect = [
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003971 # Latest patchset: No builds.
3972 [],
3973 # Patchset before latest: Some builds.
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003974 [{
3975 'id': str(100 + idx),
3976 'builder': {
3977 'project': 'chromium',
3978 'bucket': 'try',
3979 'builder': 'bot_' + status.lower(),
3980 },
3981 'createTime': '2019-10-09T08:00:0%d.854286Z' % (idx % 10),
3982 'tags': [],
3983 'status': status,
3984 } for idx, status in enumerate(self._STATUSES)],
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +00003985 ]
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003986
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003987 self.assertEqual(0, git_cl.main(['upload', '--retry-failed']))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003988 self.assertEqual([
Edward Lemur5b929a42019-10-21 17:57:39 +00003989 mock.call(mock.ANY, 'cr-buildbucket.appspot.com', patchset=7),
3990 mock.call(mock.ANY, 'cr-buildbucket.appspot.com', patchset=6),
Quinten Yearsley777660f2020-03-04 23:37:06 +00003991 ], git_cl._fetch_tryjobs.mock_calls)
Edward Lemur45768512020-03-02 19:03:14 +00003992 expected_buckets = [
3993 ('chromium', 'try', 'bot_failure'),
3994 ('chromium', 'try', 'bot_infra_failure'),
3995 ]
Quinten Yearsley777660f2020-03-04 23:37:06 +00003996 git_cl._trigger_tryjobs.assert_called_once_with(mock.ANY, expected_buckets,
3997 mock.ANY, 8)
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003998
Brian Sheedy59b06a82019-10-14 17:03:29 +00003999
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +00004000class MakeRequestsHelperTestCase(unittest.TestCase):
4001
4002 def exampleGerritChange(self):
4003 return {
4004 'host': 'chromium-review.googlesource.com',
4005 'project': 'depot_tools',
4006 'change': 1,
4007 'patchset': 2,
4008 }
4009
4010 def testMakeRequestsHelperNoOptions(self):
4011 # Basic test for the helper function _make_tryjob_schedule_requests;
4012 # it shouldn't throw AttributeError even when options doesn't have any
4013 # of the expected values; it will use default option values.
4014 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
4015 jobs = [('chromium', 'try', 'my-builder')]
4016 options = optparse.Values()
4017 requests = git_cl._make_tryjob_schedule_requests(
4018 changelist, jobs, options, patchset=None)
4019
4020 # requestId is non-deterministic. Just assert that it's there and has
4021 # a particular length.
4022 self.assertEqual(len(requests[0]['scheduleBuild'].pop('requestId')), 36)
4023 self.assertEqual(requests, [{
4024 'scheduleBuild': {
4025 'builder': {
4026 'bucket': 'try',
4027 'builder': 'my-builder',
4028 'project': 'chromium'
4029 },
4030 'gerritChanges': [self.exampleGerritChange()],
4031 'properties': {
4032 'category': 'git_cl_try'
4033 },
4034 'tags': [{
4035 'key': 'builder',
4036 'value': 'my-builder'
4037 }, {
4038 'key': 'user_agent',
4039 'value': 'git_cl_try'
4040 }]
4041 }
4042 }])
4043
4044 def testMakeRequestsHelperPresubmitSetsDryRunProperty(self):
4045 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
4046 jobs = [('chromium', 'try', 'presubmit')]
4047 options = optparse.Values()
4048 requests = git_cl._make_tryjob_schedule_requests(
4049 changelist, jobs, options, patchset=None)
4050 self.assertEqual(requests[0]['scheduleBuild']['properties'], {
4051 'category': 'git_cl_try',
4052 'dry_run': 'true'
4053 })
4054
4055 def testMakeRequestsHelperRevisionSet(self):
4056 # Gitiles commit is specified when revision is in options.
4057 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
4058 jobs = [('chromium', 'try', 'my-builder')]
4059 options = optparse.Values({'revision': 'ba5eba11'})
4060 requests = git_cl._make_tryjob_schedule_requests(
4061 changelist, jobs, options, patchset=None)
4062 self.assertEqual(
4063 requests[0]['scheduleBuild']['gitilesCommit'], {
4064 'host': 'chromium-review.googlesource.com',
4065 'id': 'ba5eba11',
Josip Sokcevic9011a5b2021-02-12 18:59:44 +00004066 'project': 'depot_tools',
4067 'ref': 'refs/heads/main',
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +00004068 })
4069
4070 def testMakeRequestsHelperRetryFailedSet(self):
4071 # An extra tag is added when retry_failed is in options.
4072 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
4073 jobs = [('chromium', 'try', 'my-builder')]
4074 options = optparse.Values({'retry_failed': 'true'})
4075 requests = git_cl._make_tryjob_schedule_requests(
4076 changelist, jobs, options, patchset=None)
4077 self.assertEqual(
4078 requests[0]['scheduleBuild']['tags'], [
4079 {
4080 'key': 'builder',
4081 'value': 'my-builder'
4082 },
4083 {
4084 'key': 'user_agent',
4085 'value': 'git_cl_try'
4086 },
4087 {
4088 'key': 'retry_failed',
4089 'value': '1'
4090 }
4091 ])
4092
4093 def testMakeRequestsHelperCategorySet(self):
Quinten Yearsley925cedb2020-04-13 17:49:39 +00004094 # The category property can be overridden with options.
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +00004095 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
4096 jobs = [('chromium', 'try', 'my-builder')]
4097 options = optparse.Values({'category': 'my-special-category'})
4098 requests = git_cl._make_tryjob_schedule_requests(
4099 changelist, jobs, options, patchset=None)
4100 self.assertEqual(requests[0]['scheduleBuild']['properties'],
4101 {'category': 'my-special-category'})
4102
4103
Edward Lemurda4b6c62020-02-13 00:28:40 +00004104class CMDFormatTestCase(unittest.TestCase):
Brian Sheedy59b06a82019-10-14 17:03:29 +00004105
4106 def setUp(self):
4107 super(CMDFormatTestCase, self).setUp()
Jamie Madill5e96ad12020-01-13 16:08:35 +00004108 mock.patch('git_cl.RunCommand').start()
4109 mock.patch('clang_format.FindClangFormatToolInChromiumTree').start()
4110 mock.patch('clang_format.FindClangFormatScriptInChromiumTree').start()
4111 mock.patch('git_cl.settings').start()
Brian Sheedy59b06a82019-10-14 17:03:29 +00004112 self._top_dir = tempfile.mkdtemp()
Jamie Madill5e96ad12020-01-13 16:08:35 +00004113 self.addCleanup(mock.patch.stopall)
Brian Sheedy59b06a82019-10-14 17:03:29 +00004114
4115 def tearDown(self):
4116 shutil.rmtree(self._top_dir)
4117 super(CMDFormatTestCase, self).tearDown()
4118
Jamie Madill5e96ad12020-01-13 16:08:35 +00004119 def _make_temp_file(self, fname, contents):
Anthony Politoc64e3902021-04-30 21:55:25 +00004120 gclient_utils.FileWrite(os.path.join(self._top_dir, fname),
4121 ('\n'.join(contents)))
Jamie Madill5e96ad12020-01-13 16:08:35 +00004122
Brian Sheedy59b06a82019-10-14 17:03:29 +00004123 def _make_yapfignore(self, contents):
Jamie Madill5e96ad12020-01-13 16:08:35 +00004124 self._make_temp_file('.yapfignore', contents)
Brian Sheedy59b06a82019-10-14 17:03:29 +00004125
Brian Sheedyb4307d52019-12-02 19:18:17 +00004126 def _check_yapf_filtering(self, files, expected):
4127 self.assertEqual(expected, git_cl._FilterYapfIgnoredFiles(
4128 files, git_cl._GetYapfIgnorePatterns(self._top_dir)))
Brian Sheedy59b06a82019-10-14 17:03:29 +00004129
Edward Lemur1a83da12020-03-04 21:18:36 +00004130 def _run_command_mock(self, return_value):
4131 def f(*args, **kwargs):
4132 if 'stdin' in kwargs:
4133 self.assertIsInstance(kwargs['stdin'], bytes)
4134 return return_value
4135 return f
4136
Jamie Madill5e96ad12020-01-13 16:08:35 +00004137 def testClangFormatDiffFull(self):
4138 self._make_temp_file('test.cc', ['// test'])
4139 git_cl.settings.GetFormatFullByDefault.return_value = False
4140 diff_file = [os.path.join(self._top_dir, 'test.cc')]
4141 mock_opts = mock.Mock(full=True, dry_run=True, diff=False)
4142
4143 # Diff
Edward Lemur1a83da12020-03-04 21:18:36 +00004144 git_cl.RunCommand.side_effect = self._run_command_mock(' // test')
Jamie Madill5e96ad12020-01-13 16:08:35 +00004145 return_value = git_cl._RunClangFormatDiff(mock_opts, diff_file,
4146 self._top_dir, 'HEAD')
4147 self.assertEqual(2, return_value)
4148
4149 # No diff
Edward Lemur1a83da12020-03-04 21:18:36 +00004150 git_cl.RunCommand.side_effect = self._run_command_mock('// test')
Jamie Madill5e96ad12020-01-13 16:08:35 +00004151 return_value = git_cl._RunClangFormatDiff(mock_opts, diff_file,
4152 self._top_dir, 'HEAD')
4153 self.assertEqual(0, return_value)
4154
4155 def testClangFormatDiff(self):
4156 git_cl.settings.GetFormatFullByDefault.return_value = False
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00004157 # A valid file is required, so use this test.
4158 clang_format.FindClangFormatToolInChromiumTree.return_value = __file__
Jamie Madill5e96ad12020-01-13 16:08:35 +00004159 mock_opts = mock.Mock(full=False, dry_run=True, diff=False)
4160
4161 # Diff
Edward Lemur1a83da12020-03-04 21:18:36 +00004162 git_cl.RunCommand.side_effect = self._run_command_mock('error')
4163 return_value = git_cl._RunClangFormatDiff(
4164 mock_opts, ['.'], self._top_dir, 'HEAD')
Jamie Madill5e96ad12020-01-13 16:08:35 +00004165 self.assertEqual(2, return_value)
4166
4167 # No diff
Edward Lemur1a83da12020-03-04 21:18:36 +00004168 git_cl.RunCommand.side_effect = self._run_command_mock('')
Jamie Madill5e96ad12020-01-13 16:08:35 +00004169 return_value = git_cl._RunClangFormatDiff(mock_opts, ['.'], self._top_dir,
4170 'HEAD')
4171 self.assertEqual(0, return_value)
4172
Brian Sheedyb4307d52019-12-02 19:18:17 +00004173 def testYapfignoreExplicit(self):
4174 self._make_yapfignore(['foo/bar.py', 'foo/bar/baz.py'])
4175 files = [
4176 'bar.py',
4177 'foo/bar.py',
4178 'foo/baz.py',
4179 'foo/bar/baz.py',
4180 'foo/bar/foobar.py',
4181 ]
4182 expected = [
4183 'bar.py',
4184 'foo/baz.py',
4185 'foo/bar/foobar.py',
4186 ]
4187 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00004188
Brian Sheedyb4307d52019-12-02 19:18:17 +00004189 def testYapfignoreSingleWildcards(self):
4190 self._make_yapfignore(['*bar.py', 'foo*', 'baz*.py'])
4191 files = [
4192 'bar.py', # Matched by *bar.py.
4193 'bar.txt',
4194 'foobar.py', # Matched by *bar.py, foo*.
4195 'foobar.txt', # Matched by foo*.
4196 'bazbar.py', # Matched by *bar.py, baz*.py.
4197 'bazbar.txt',
4198 'foo/baz.txt', # Matched by foo*.
4199 'bar/bar.py', # Matched by *bar.py.
4200 'baz/foo.py', # Matched by baz*.py, foo*.
4201 'baz/foo.txt',
4202 ]
4203 expected = [
4204 'bar.txt',
4205 'bazbar.txt',
4206 'baz/foo.txt',
4207 ]
4208 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00004209
Brian Sheedyb4307d52019-12-02 19:18:17 +00004210 def testYapfignoreMultiplewildcards(self):
4211 self._make_yapfignore(['*bar*', '*foo*baz.txt'])
4212 files = [
4213 'bar.py', # Matched by *bar*.
4214 'bar.txt', # Matched by *bar*.
4215 'abar.py', # Matched by *bar*.
4216 'foobaz.txt', # Matched by *foo*baz.txt.
4217 'foobaz.py',
4218 'afoobaz.txt', # Matched by *foo*baz.txt.
4219 ]
4220 expected = [
4221 'foobaz.py',
4222 ]
4223 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00004224
4225 def testYapfignoreComments(self):
4226 self._make_yapfignore(['test.py', '#test2.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00004227 files = [
4228 'test.py',
4229 'test2.py',
4230 ]
4231 expected = [
4232 'test2.py',
4233 ]
4234 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00004235
Anthony Politoc64e3902021-04-30 21:55:25 +00004236 def testYapfHandleUtf8(self):
4237 self._make_yapfignore(['test.py', 'test_🌐.py'])
4238 files = [
4239 'test.py',
4240 'test_🌐.py',
4241 'test2.py',
4242 ]
4243 expected = [
4244 'test2.py',
4245 ]
4246 self._check_yapf_filtering(files, expected)
4247
Brian Sheedy59b06a82019-10-14 17:03:29 +00004248 def testYapfignoreBlankLines(self):
4249 self._make_yapfignore(['test.py', '', '', 'test2.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00004250 files = [
4251 'test.py',
4252 'test2.py',
4253 'test3.py',
4254 ]
4255 expected = [
4256 'test3.py',
4257 ]
4258 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00004259
4260 def testYapfignoreWhitespace(self):
4261 self._make_yapfignore([' test.py '])
Brian Sheedyb4307d52019-12-02 19:18:17 +00004262 files = [
4263 'test.py',
4264 'test2.py',
4265 ]
4266 expected = [
4267 'test2.py',
4268 ]
4269 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00004270
Brian Sheedyb4307d52019-12-02 19:18:17 +00004271 def testYapfignoreNoFiles(self):
Brian Sheedy59b06a82019-10-14 17:03:29 +00004272 self._make_yapfignore(['test.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00004273 self._check_yapf_filtering([], [])
4274
4275 def testYapfignoreMissingYapfignore(self):
4276 files = [
4277 'test.py',
4278 ]
4279 expected = [
4280 'test.py',
4281 ]
4282 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00004283
4284
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00004285class CMDStatusTestCase(CMDTestCaseBase):
4286 # Return branch names a,..,f with comitterdates in increasing order, i.e.
4287 # 'f' is the most-recently changed branch.
4288 def _mock_run_git(commands):
4289 if commands == [
4290 'for-each-ref', '--format=%(refname) %(committerdate:unix)',
4291 'refs/heads'
4292 ]:
4293 branches_and_committerdates = [
4294 'refs/heads/a 1',
4295 'refs/heads/b 2',
4296 'refs/heads/c 3',
4297 'refs/heads/d 4',
4298 'refs/heads/e 5',
4299 'refs/heads/f 6',
4300 ]
4301 return '\n'.join(branches_and_committerdates)
4302
4303 # Mock the status in such a way that the issue number gives us an
4304 # indication of the commit date (simplifies manual debugging).
4305 def _mock_get_cl_statuses(branches, fine_grained, max_processes):
4306 for c in branches:
4307 c.issue = (100 + int(c.GetCommitDate()))
4308 yield (c, 'open')
4309
4310 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
4311 @mock.patch('git_cl.Changelist.FetchDescription', lambda cl, pretty: 'x')
4312 @mock.patch('git_cl.Changelist.GetIssue', lambda cl: cl.issue)
4313 @mock.patch('git_cl.RunGit', _mock_run_git)
4314 @mock.patch('git_cl.get_cl_statuses', _mock_get_cl_statuses)
4315 @mock.patch('git_cl.Settings.GetRoot', return_value='')
Sigurd Schneider1bfda8e2021-06-30 14:46:25 +00004316 @mock.patch('git_cl.Settings.IsStatusCommitOrderByDate', return_value=False)
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00004317 @mock.patch('scm.GIT.GetBranch', return_value='a')
4318 def testStatus(self, *_mocks):
4319 self.assertEqual(0, git_cl.main(['status', '--no-branch-color']))
4320 self.maxDiff = None
4321 self.assertEqual(
4322 sys.stdout.getvalue(), 'Branches associated with reviews:\n'
4323 ' * a : https://crrev.com/c/101 (open)\n'
4324 ' b : https://crrev.com/c/102 (open)\n'
4325 ' c : https://crrev.com/c/103 (open)\n'
4326 ' d : https://crrev.com/c/104 (open)\n'
4327 ' e : https://crrev.com/c/105 (open)\n'
4328 ' f : https://crrev.com/c/106 (open)\n\n'
4329 'Current branch: a\n'
4330 'Issue number: 101 (https://chromium-review.googlesource.com/101)\n'
4331 'Issue description:\n'
4332 'x\n')
4333
4334 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
4335 @mock.patch('git_cl.Changelist.FetchDescription', lambda cl, pretty: 'x')
4336 @mock.patch('git_cl.Changelist.GetIssue', lambda cl: cl.issue)
4337 @mock.patch('git_cl.RunGit', _mock_run_git)
4338 @mock.patch('git_cl.get_cl_statuses', _mock_get_cl_statuses)
4339 @mock.patch('git_cl.Settings.GetRoot', return_value='')
Sigurd Schneider1bfda8e2021-06-30 14:46:25 +00004340 @mock.patch('git_cl.Settings.IsStatusCommitOrderByDate', return_value=False)
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00004341 @mock.patch('scm.GIT.GetBranch', return_value='a')
4342 def testStatusByDate(self, *_mocks):
4343 self.assertEqual(
4344 0, git_cl.main(['status', '--no-branch-color', '--date-order']))
4345 self.maxDiff = None
4346 self.assertEqual(
4347 sys.stdout.getvalue(), 'Branches associated with reviews:\n'
4348 ' f : https://crrev.com/c/106 (open)\n'
4349 ' e : https://crrev.com/c/105 (open)\n'
4350 ' d : https://crrev.com/c/104 (open)\n'
4351 ' c : https://crrev.com/c/103 (open)\n'
4352 ' b : https://crrev.com/c/102 (open)\n'
4353 ' * a : https://crrev.com/c/101 (open)\n\n'
4354 'Current branch: a\n'
4355 'Issue number: 101 (https://chromium-review.googlesource.com/101)\n'
4356 'Issue description:\n'
4357 'x\n')
4358
Sigurd Schneider1bfda8e2021-06-30 14:46:25 +00004359 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
4360 @mock.patch('git_cl.Changelist.FetchDescription', lambda cl, pretty: 'x')
4361 @mock.patch('git_cl.Changelist.GetIssue', lambda cl: cl.issue)
4362 @mock.patch('git_cl.RunGit', _mock_run_git)
4363 @mock.patch('git_cl.get_cl_statuses', _mock_get_cl_statuses)
4364 @mock.patch('git_cl.Settings.GetRoot', return_value='')
4365 @mock.patch('git_cl.Settings.IsStatusCommitOrderByDate', return_value=True)
4366 @mock.patch('scm.GIT.GetBranch', return_value='a')
4367 def testStatusByDate(self, *_mocks):
4368 self.assertEqual(
4369 0, git_cl.main(['status', '--no-branch-color']))
4370 self.maxDiff = None
4371 self.assertEqual(
4372 sys.stdout.getvalue(), 'Branches associated with reviews:\n'
4373 ' f : https://crrev.com/c/106 (open)\n'
4374 ' e : https://crrev.com/c/105 (open)\n'
4375 ' d : https://crrev.com/c/104 (open)\n'
4376 ' c : https://crrev.com/c/103 (open)\n'
4377 ' b : https://crrev.com/c/102 (open)\n'
4378 ' * a : https://crrev.com/c/101 (open)\n\n'
4379 'Current branch: a\n'
4380 'Issue number: 101 (https://chromium-review.googlesource.com/101)\n'
4381 'Issue description:\n'
4382 'x\n')
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00004383
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004384class CMDOwnersTestCase(CMDTestCaseBase):
4385 def setUp(self):
4386 super(CMDOwnersTestCase, self).setUp()
Edward Lesmes82b992a2021-01-11 23:24:55 +00004387 self.owners_by_path = {
4388 'foo': ['a@example.com'],
4389 'bar': ['b@example.com', 'c@example.com'],
4390 }
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004391 mock.patch('git_cl.Settings.GetRoot', return_value='root').start()
4392 mock.patch('git_cl.Changelist.GetAuthor', return_value='author').start()
4393 mock.patch(
Edward Lesmes82b992a2021-01-11 23:24:55 +00004394 'git_cl.Changelist.GetAffectedFiles',
4395 return_value=list(self.owners_by_path)).start()
4396 mock.patch(
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004397 'git_cl.Changelist.GetCommonAncestorWithUpstream',
4398 return_value='upstream').start()
Edward Lesmes82b992a2021-01-11 23:24:55 +00004399 mock.patch(
Edward Lesmese1576912021-02-16 21:53:34 +00004400 'git_cl.Changelist.GetGerritHost',
4401 return_value='host').start()
4402 mock.patch(
4403 'git_cl.Changelist.GetGerritProject',
4404 return_value='project').start()
4405 mock.patch(
4406 'git_cl.Changelist.GetRemoteBranch',
4407 return_value=('origin', 'refs/remotes/origin/main')).start()
4408 mock.patch(
4409 'owners_client.OwnersClient.BatchListOwners',
Edward Lesmes82b992a2021-01-11 23:24:55 +00004410 return_value=self.owners_by_path).start()
Edward Lesmes8170c292021-03-19 20:04:43 +00004411 mock.patch(
4412 'gerrit_util.IsCodeOwnersEnabledOnHost', return_value=True).start()
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004413 self.addCleanup(mock.patch.stopall)
4414
4415 def testShowAllNoArgs(self):
4416 self.assertEqual(0, git_cl.main(['owners', '--show-all']))
4417 self.assertEqual(
4418 'No files specified for --show-all. Nothing to do.\n',
4419 git_cl.sys.stdout.getvalue())
4420
4421 def testShowAll(self):
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004422 self.assertEqual(
4423 0,
4424 git_cl.main(['owners', '--show-all', 'foo', 'bar', 'baz']))
Edward Lesmese1576912021-02-16 21:53:34 +00004425 owners_client.OwnersClient.BatchListOwners.assert_called_once_with(
Edward Lesmes82b992a2021-01-11 23:24:55 +00004426 ['foo', 'bar', 'baz'])
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004427 self.assertEqual(
4428 '\n'.join([
4429 'Owners for foo:',
4430 ' - a@example.com',
4431 'Owners for bar:',
4432 ' - b@example.com',
4433 ' - c@example.com',
4434 'Owners for baz:',
4435 ' - No owners found',
4436 '',
4437 ]),
4438 sys.stdout.getvalue())
4439
Edward Lesmes82b992a2021-01-11 23:24:55 +00004440 def testBatch(self):
4441 self.assertEqual(0, git_cl.main(['owners', '--batch']))
4442 self.assertIn('a@example.com', sys.stdout.getvalue())
4443 self.assertIn('b@example.com', sys.stdout.getvalue())
4444
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004445
maruel@chromium.orgddd59412011-11-30 14:20:38 +00004446if __name__ == '__main__':
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +01004447 logging.basicConfig(
4448 level=logging.DEBUG if '-v' in sys.argv else logging.ERROR)
maruel@chromium.orgddd59412011-11-30 14:20:38 +00004449 unittest.main()