blob: 35bf918f626746cf7a29f5744327a56d41d0e0a4 [file] [log] [blame]
Edward Lemur0db01f02019-11-12 22:01:51 +00001#!/usr/bin/env vpython3
2# coding=utf-8
maruel@chromium.orgeb5edbc2012-01-16 17:03:28 +00003# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@chromium.orgddd59412011-11-30 14:20:38 +00004# Use of this source code is governed by a BSD-style license that can be
5# found in the LICENSE file.
6
7"""Unit tests for git_cl.py."""
8
Edward Lemur85153282020-02-14 22:06:29 +00009from __future__ import print_function
Edward Lemur0db01f02019-11-12 22:01:51 +000010from __future__ import unicode_literals
11
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +010012import datetime
tandriide281ae2016-10-12 06:02:30 -070013import json
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +010014import logging
Edward Lemur61bf4172020-02-24 23:22:37 +000015import multiprocessing
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000016import optparse
maruel@chromium.orgddd59412011-11-30 14:20:38 +000017import os
Edward Lemur85153282020-02-14 22:06:29 +000018import pprint
Brian Sheedy59b06a82019-10-14 17:03:29 +000019import shutil
maruel@chromium.orgddd59412011-11-30 14:20:38 +000020import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070021import tempfile
maruel@chromium.orgddd59412011-11-30 14:20:38 +000022import unittest
23
Edward Lemura8145022020-01-06 18:47:54 +000024if sys.version_info.major == 2:
25 from StringIO import StringIO
26 import mock
27else:
28 from io import StringIO
29 from unittest import mock
30
maruel@chromium.orgddd59412011-11-30 14:20:38 +000031sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
32
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000033import metrics
Edward Lesmes9c349062021-05-06 20:02:39 +000034import metrics_utils
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000035# We have to disable monitoring before importing git_cl.
Edward Lesmes9c349062021-05-06 20:02:39 +000036metrics_utils.COLLECT_METRICS = False
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000037
Jamie Madill5e96ad12020-01-13 16:08:35 +000038import clang_format
Edward Lemur227d5102020-02-25 23:45:35 +000039import contextlib
Edward Lemur1773f372020-02-22 00:27:14 +000040import gclient_utils
Eric Boren2fb63102018-10-05 13:05:03 +000041import gerrit_util
maruel@chromium.orgddd59412011-11-30 14:20:38 +000042import git_cl
iannucci@chromium.org9e849272014-04-04 00:31:55 +000043import git_common
tandrii@chromium.org57d86542016-03-04 16:11:32 +000044import git_footers
Edward Lemur85153282020-02-14 22:06:29 +000045import git_new_branch
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +000046import owners_client
Edward Lemur85153282020-02-14 22:06:29 +000047import scm
maruel@chromium.orgddd59412011-11-30 14:20:38 +000048import subprocess2
maruel@chromium.orgddd59412011-11-30 14:20:38 +000049
Josip Sokcevic464e9ff2020-03-18 23:48:55 +000050NETRC_FILENAME = '_netrc' if sys.platform == 'win32' else '.netrc'
51
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000052
Edward Lemur0db01f02019-11-12 22:01:51 +000053def callError(code=1, cmd='', cwd='', stdout=b'', stderr=b''):
tandrii5d48c322016-08-18 16:19:37 -070054 return subprocess2.CalledProcessError(code, cmd, cwd, stdout, stderr)
55
tandrii5d48c322016-08-18 16:19:37 -070056CERR1 = callError(1)
57
58
Edward Lemur1773f372020-02-22 00:27:14 +000059class TemporaryFileMock(object):
60 def __init__(self):
61 self.suffix = 0
Aaron Gable9a03ae02017-11-03 11:31:07 -070062
Edward Lemur1773f372020-02-22 00:27:14 +000063 @contextlib.contextmanager
64 def __call__(self):
65 self.suffix += 1
66 yield '/tmp/fake-temp' + str(self.suffix)
Aaron Gable9a03ae02017-11-03 11:31:07 -070067
68
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000069class ChangelistMock(object):
70 # A class variable so we can access it when we don't have access to the
71 # instance that's being set.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000072 desc = ''
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000073
Dirk Pranke6f0df682021-06-25 00:42:33 +000074 def __init__(self, gerrit_change=None, use_python3=False, **kwargs):
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000075 self._gerrit_change = gerrit_change
Dirk Pranke6f0df682021-06-25 00:42:33 +000076 self._use_python3 = use_python3
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000077
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000078 def GetIssue(self):
79 return 1
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000080
Edward Lemur6c6827c2020-02-06 21:15:18 +000081 def FetchDescription(self):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000082 return ChangelistMock.desc
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000083
dsansomee2d6fd92016-09-08 00:10:47 -070084 def UpdateDescription(self, desc, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000085 ChangelistMock.desc = desc
86
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000087 def GetGerritChange(self, patchset=None, **kwargs):
88 del patchset
89 return self._gerrit_change
90
Josip Sokcevic9011a5b2021-02-12 18:59:44 +000091 def GetRemoteBranch(self):
92 return ('origin', 'refs/remotes/origin/main')
93
Dirk Pranke6f0df682021-06-25 00:42:33 +000094 def GetUsePython3(self):
95 return self._use_python3
tandrii5d48c322016-08-18 16:19:37 -070096
Edward Lemur85153282020-02-14 22:06:29 +000097class GitMocks(object):
98 def __init__(self, config=None, branchref=None):
99 self.branchref = branchref or 'refs/heads/master'
100 self.config = config or {}
101
102 def GetBranchRef(self, _root):
103 return self.branchref
104
105 def NewBranch(self, branchref):
106 self.branchref = branchref
107
Edward Lemur26964072020-02-19 19:18:51 +0000108 def GetConfig(self, root, key, default=None):
109 if root != '':
110 key = '%s:%s' % (root, key)
Edward Lemur85153282020-02-14 22:06:29 +0000111 return self.config.get(key, default)
112
Edward Lemur26964072020-02-19 19:18:51 +0000113 def SetConfig(self, root, key, value=None):
114 if root != '':
115 key = '%s:%s' % (root, key)
Edward Lemur85153282020-02-14 22:06:29 +0000116 if value:
117 self.config[key] = value
118 return
119 if key not in self.config:
120 raise CERR1
121 del self.config[key]
122
123
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000124class WatchlistsMock(object):
125 def __init__(self, _):
126 pass
127 @staticmethod
128 def GetWatchersForPaths(_):
129 return ['joe@example.com']
130
131
Edward Lemur4c707a22019-09-24 21:13:43 +0000132class CodereviewSettingsFileMock(object):
133 def __init__(self):
134 pass
135 # pylint: disable=no-self-use
136 def read(self):
137 return ('CODE_REVIEW_SERVER: gerrit.chromium.org\n' +
138 'GERRIT_HOST: True\n')
139
140
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000141class AuthenticatorMock(object):
142 def __init__(self, *_args):
143 pass
144 def has_cached_credentials(self):
145 return True
tandrii221ab252016-10-06 08:12:04 -0700146 def authorize(self, http):
147 return http
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000148
149
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100150def CookiesAuthenticatorMockFactory(hosts_with_creds=None, same_auth=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000151 """Use to mock Gerrit/Git credentials from ~/.netrc or ~/.gitcookies.
152
153 Usage:
154 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100155 CookiesAuthenticatorMockFactory({'host': ('user', _, 'pass')})
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000156
157 OR
158 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100159 CookiesAuthenticatorMockFactory(
160 same_auth=('user', '', 'pass'))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000161 """
162 class CookiesAuthenticatorMock(git_cl.gerrit_util.CookiesAuthenticator):
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800163 def __init__(self): # pylint: disable=super-init-not-called
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000164 # Intentionally not calling super() because it reads actual cookie files.
165 pass
166 @classmethod
167 def get_gitcookies_path(cls):
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000168 return os.path.join('~', '.gitcookies')
169
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000170 @classmethod
171 def get_netrc_path(cls):
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000172 return os.path.join('~', NETRC_FILENAME)
173
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100174 def _get_auth_for_host(self, host):
175 if same_auth:
176 return same_auth
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000177 return (hosts_with_creds or {}).get(host)
178 return CookiesAuthenticatorMock
179
Aaron Gable9a03ae02017-11-03 11:31:07 -0700180
kmarshall9249e012016-08-23 12:02:16 -0700181class MockChangelistWithBranchAndIssue():
182 def __init__(self, branch, issue):
183 self.branch = branch
184 self.issue = issue
185 def GetBranch(self):
186 return self.branch
187 def GetIssue(self):
188 return self.issue
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000189
tandriic2405f52016-10-10 08:13:15 -0700190
191class SystemExitMock(Exception):
192 pass
193
194
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000195class TestGitClBasic(unittest.TestCase):
Josip Sokcevic953278a2020-02-28 19:46:36 +0000196 def setUp(self):
197 mock.patch('sys.exit', side_effect=SystemExitMock).start()
198 mock.patch('sys.stdout', StringIO()).start()
199 mock.patch('sys.stderr', StringIO()).start()
200 self.addCleanup(mock.patch.stopall)
201
202 def test_die_with_error(self):
203 with self.assertRaises(SystemExitMock):
204 git_cl.DieWithError('foo', git_cl.ChangeDescription('lorem ipsum'))
205 self.assertEqual(sys.stderr.getvalue(), 'foo\n')
206 self.assertTrue('saving CL description' in sys.stdout.getvalue())
207 self.assertTrue('Content of CL description' in sys.stdout.getvalue())
208 self.assertTrue('lorem ipsum' in sys.stdout.getvalue())
209 sys.exit.assert_called_once_with(1)
210
211 def test_die_with_error_no_desc(self):
212 with self.assertRaises(SystemExitMock):
213 git_cl.DieWithError('foo')
214 self.assertEqual(sys.stderr.getvalue(), 'foo\n')
215 self.assertEqual(sys.stdout.getvalue(), '')
216 sys.exit.assert_called_once_with(1)
217
Edward Lemur6c6827c2020-02-06 21:15:18 +0000218 def test_fetch_description(self):
Edward Lemurf38bc172019-09-03 21:02:13 +0000219 cl = git_cl.Changelist(issue=1, codereview_host='host')
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100220 cl.description = 'x'
Edward Lemur6c6827c2020-02-06 21:15:18 +0000221 self.assertEqual(cl.FetchDescription(), 'x')
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700222
Edward Lemur61bf4172020-02-24 23:22:37 +0000223 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
224 @mock.patch('git_cl.Changelist.GetStatus', lambda cl: cl.status)
225 def test_get_cl_statuses(self, *_mocks):
226 statuses = [
227 'closed', 'commit', 'dry-run', 'lgtm', 'reply', 'unsent', 'waiting']
228 changes = []
229 for status in statuses:
230 cl = git_cl.Changelist()
231 cl.status = status
232 changes.append(cl)
233
234 actual = set(git_cl.get_cl_statuses(changes, True))
235 self.assertEqual(set(zip(changes, statuses)), actual)
236
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000237 def test_upload_to_non_default_branch_no_retry(self):
238 m = mock.patch('git_cl.Changelist._CMDUploadChange',
239 side_effect=[git_cl.GitPushError(), None]).start()
240 mock.patch('git_cl.Changelist.GetRemoteBranch',
241 return_value=('foo', 'bar')).start()
Edward Lesmeseeca9c62020-11-20 00:00:17 +0000242 mock.patch('git_cl.Changelist.GetGerritProject',
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000243 return_value='foo').start()
244 mock.patch('git_cl.gerrit_util.GetProjectHead',
245 return_value='refs/heads/main').start()
246
247 cl = git_cl.Changelist()
248 options = optparse.Values()
Josip Sokcevicb631a882021-01-06 18:18:10 +0000249 options.target_branch = 'refs/heads/bar'
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000250 with self.assertRaises(SystemExitMock):
251 cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
252
253 # ensure upload is called once
254 self.assertEqual(len(m.mock_calls), 1)
255 sys.exit.assert_called_once_with(1)
256 # option not set as retry didn't happen
257 self.assertFalse(hasattr(options, 'force'))
258 self.assertFalse(hasattr(options, 'edit_description'))
259
260 def test_upload_to_old_default_still_active(self):
261 m = mock.patch('git_cl.Changelist._CMDUploadChange',
262 side_effect=[git_cl.GitPushError(), None]).start()
263 mock.patch('git_cl.Changelist.GetRemoteBranch',
264 return_value=('foo', git_cl.DEFAULT_OLD_BRANCH)).start()
Edward Lesmeseeca9c62020-11-20 00:00:17 +0000265 mock.patch('git_cl.Changelist.GetGerritProject',
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000266 return_value='foo').start()
267 mock.patch('git_cl.gerrit_util.GetProjectHead',
Josip Sokcevicb631a882021-01-06 18:18:10 +0000268 return_value='refs/heads/master').start()
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000269
270 cl = git_cl.Changelist()
271 options = optparse.Values()
Josip Sokcevicb631a882021-01-06 18:18:10 +0000272 options.target_branch = 'refs/heads/master'
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000273 with self.assertRaises(SystemExitMock):
274 cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
275
276 # ensure upload is called once
277 self.assertEqual(len(m.mock_calls), 1)
278 sys.exit.assert_called_once_with(1)
279 # option not set as retry didn't happen
280 self.assertFalse(hasattr(options, 'force'))
281 self.assertFalse(hasattr(options, 'edit_description'))
282
283 def test_upload_to_old_default_retry_on_failure(self):
284 m = mock.patch('git_cl.Changelist._CMDUploadChange',
285 side_effect=[git_cl.GitPushError(), None]).start()
286 mock.patch('git_cl.Changelist.GetRemoteBranch',
287 return_value=('foo', git_cl.DEFAULT_OLD_BRANCH)).start()
Edward Lesmeseeca9c62020-11-20 00:00:17 +0000288 mock.patch('git_cl.Changelist.GetGerritProject',
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000289 return_value='foo').start()
290 mock.patch('git_cl.gerrit_util.GetProjectHead',
291 return_value='refs/heads/main').start()
292 mock.patch('git_cl.RunGit').start()
293
294 cl = git_cl.Changelist()
295 options = optparse.Values()
Josip Sokcevicb631a882021-01-06 18:18:10 +0000296 options.target_branch = 'refs/heads/master'
297 cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
298 # ensure upload is called twice
299 self.assertEqual(len(m.mock_calls), 2)
300 # option overrides on retry
301 self.assertEqual(options.force, True)
302 self.assertEqual(options.edit_description, False)
303
Gavin Mak68e6cf32021-01-25 18:24:08 +0000304 def test_upload_with_message_file_no_editor(self):
305 m = mock.patch('git_cl.ChangeDescription.prompt',
306 return_value=None).start()
307 mock.patch('git_cl.Changelist.GetRemoteBranch',
308 return_value=('foo', git_cl.DEFAULT_NEW_BRANCH)).start()
309 mock.patch('git_cl.GetTargetRef',
310 return_value='refs/heads/main').start()
311 mock.patch('git_cl.Changelist._GerritCommitMsgHookCheck',
312 lambda _, offer_removal: None).start()
313 mock.patch('git_cl.Changelist.GetIssue', return_value=None).start()
314 mock.patch('git_cl.Changelist.GetBranch',
315 side_effect=SystemExitMock).start()
316 mock.patch('git_cl.GenerateGerritChangeId', return_value=None).start()
317 mock.patch('git_cl.RunGit').start()
318
319 cl = git_cl.Changelist()
320 options = optparse.Values()
321 options.target_branch = 'refs/heads/master'
322 options.squash = True
323 options.edit_description = False
324 options.force = False
325 options.preserve_tryjobs = False
326 options.message_file = "message.txt"
327
328 with self.assertRaises(SystemExitMock):
329 cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
330 self.assertEqual(len(m.mock_calls), 0)
331
332 options.message_file = None
333 with self.assertRaises(SystemExitMock):
334 cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
335 self.assertEqual(len(m.mock_calls), 1)
336
Josip Sokcevicb631a882021-01-06 18:18:10 +0000337 def test_upload_to_old_default_retry_on_rollback(self):
338 """Test when default branch migration had to be rolled back to old name"""
339 m = mock.patch('git_cl.Changelist._CMDUploadChange',
340 side_effect=[git_cl.GitPushError(), None]).start()
341 mock.patch('git_cl.Changelist.GetRemoteBranch',
342 return_value=('foo', git_cl.DEFAULT_NEW_BRANCH)).start()
343 mock.patch('git_cl.Changelist.GetGerritProject',
344 return_value='foo').start()
345 mock.patch('git_cl.gerrit_util.GetProjectHead',
346 return_value='refs/heads/master').start()
347 # GetTargetRef returns new default branch since it has stale remote
348 # information.
349 mock.patch('git_cl.GetTargetRef',
350 return_value='refs/heads/main').start()
351 mock.patch('git_cl.RunGit').start()
352
353 cl = git_cl.Changelist()
354 options = optparse.Values()
355 options.target_branch = 'refs/heads/master'
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000356 cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
357 # ensure upload is called twice
358 self.assertEqual(len(m.mock_calls), 2)
359 # option overrides on retry
360 self.assertEqual(options.force, True)
361 self.assertEqual(options.edit_description, False)
362
Edward Lemur61bf4172020-02-24 23:22:37 +0000363 def test_get_cl_statuses_no_changes(self):
364 self.assertEqual([], list(git_cl.get_cl_statuses([], True)))
365
366 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
367 @mock.patch('multiprocessing.pool.ThreadPool')
368 def test_get_cl_statuses_timeout(self, *_mocks):
369 changes = [git_cl.Changelist() for _ in range(2)]
370 pool = multiprocessing.pool.ThreadPool()
371 it = pool.imap_unordered.return_value.__iter__ = mock.Mock()
372 it.return_value.next.side_effect = [
373 (changes[0], 'lgtm'),
374 multiprocessing.TimeoutError,
375 ]
376
377 actual = list(git_cl.get_cl_statuses(changes, True))
378 self.assertEqual([(changes[0], 'lgtm'), (changes[1], 'error')], actual)
379
380 @mock.patch('git_cl.Changelist.GetIssueURL')
381 def test_get_cl_statuses_not_finegrained(self, _mock):
382 changes = [git_cl.Changelist() for _ in range(2)]
383 urls = ['some-url', None]
384 git_cl.Changelist.GetIssueURL.side_effect = urls
385
386 actual = set(git_cl.get_cl_statuses(changes, False))
387 self.assertEqual(
388 set([(changes[0], 'waiting'), (changes[1], 'error')]), actual)
389
Andrii Shyshkalov1ee78cd2020-03-12 01:31:53 +0000390 def test_get_issue_url(self):
391 cl = git_cl.Changelist(issue=123)
392 cl._gerrit_server = 'https://example.com'
393 self.assertEqual(cl.GetIssueURL(), 'https://example.com/123')
394 self.assertEqual(cl.GetIssueURL(short=True), 'https://example.com/123')
395
396 cl = git_cl.Changelist(issue=123)
397 cl._gerrit_server = 'https://chromium-review.googlesource.com'
398 self.assertEqual(cl.GetIssueURL(),
399 'https://chromium-review.googlesource.com/123')
400 self.assertEqual(cl.GetIssueURL(short=True), 'https://crrev.com/c/123')
401
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +0000402 def test_set_preserve_tryjobs(self):
403 d = git_cl.ChangeDescription('Simple.')
404 d.set_preserve_tryjobs()
405 self.assertEqual(d.description.splitlines(), [
406 'Simple.',
407 '',
408 'Cq-Do-Not-Cancel-Tryjobs: true',
409 ])
410 before = d.description
411 d.set_preserve_tryjobs()
412 self.assertEqual(before, d.description)
413
414 d = git_cl.ChangeDescription('\n'.join([
415 'One is enough',
416 '',
417 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
418 'Change-Id: Ideadbeef',
419 ]))
420 d.set_preserve_tryjobs()
421 self.assertEqual(d.description.splitlines(), [
422 'One is enough',
423 '',
424 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
425 'Change-Id: Ideadbeef',
426 'Cq-Do-Not-Cancel-Tryjobs: true',
427 ])
428
tandriif9aefb72016-07-01 09:06:51 -0700429 def test_get_bug_line_values(self):
430 f = lambda p, bugs: list(git_cl._get_bug_line_values(p, bugs))
431 self.assertEqual(f('', ''), [])
432 self.assertEqual(f('', '123,v8:456'), ['123', 'v8:456'])
Lei Zhang8a0efc12020-08-05 19:58:45 +0000433 # Prefix that ends with colon.
434 self.assertEqual(f('v8:', '456'), ['v8:456'])
435 self.assertEqual(f('v8:', 'chromium:123,456'), ['v8:456', 'chromium:123'])
436 # Prefix that ends without colon.
tandriif9aefb72016-07-01 09:06:51 -0700437 self.assertEqual(f('v8', '456'), ['v8:456'])
438 self.assertEqual(f('v8', 'chromium:123,456'), ['v8:456', 'chromium:123'])
439 # Not nice, but not worth carying.
Lei Zhang8a0efc12020-08-05 19:58:45 +0000440 self.assertEqual(f('v8:', 'chromium:123,456,v8:123'),
441 ['v8:456', 'chromium:123', 'v8:123'])
tandriif9aefb72016-07-01 09:06:51 -0700442 self.assertEqual(f('v8', 'chromium:123,456,v8:123'),
443 ['v8:456', 'chromium:123', 'v8:123'])
444
Edward Lemurda4b6c62020-02-13 00:28:40 +0000445 @mock.patch('gerrit_util.GetAccountDetails')
446 def test_valid_accounts(self, mockGetAccountDetails):
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000447 mock_per_account = {
448 'u1': None, # 404, doesn't exist.
449 'u2': {
450 '_account_id': 123124,
451 'avatars': [],
452 'email': 'u2@example.com',
453 'name': 'User Number 2',
454 'status': 'OOO',
455 },
456 'u3': git_cl.gerrit_util.GerritError(500, 'retries didn\'t help :('),
457 }
458 def GetAccountDetailsMock(_, account):
459 # Poor-man's mock library's side_effect.
460 v = mock_per_account.pop(account)
461 if isinstance(v, Exception):
462 raise v
463 return v
464
Edward Lemurda4b6c62020-02-13 00:28:40 +0000465 mockGetAccountDetails.side_effect = GetAccountDetailsMock
466 actual = git_cl.gerrit_util.ValidAccounts(
467 'host', ['u1', 'u2', 'u3'], max_threads=1)
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000468 self.assertEqual(actual, {
469 'u2': {
470 '_account_id': 123124,
471 'avatars': [],
472 'email': 'u2@example.com',
473 'name': 'User Number 2',
474 'status': 'OOO',
475 },
476 })
477
478
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200479class TestParseIssueURL(unittest.TestCase):
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000480 def _test(self, arg, issue=None, patchset=None, hostname=None, fail=False):
481 parsed = git_cl.ParseIssueNumberArgument(arg)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200482 self.assertIsNotNone(parsed)
483 if fail:
484 self.assertFalse(parsed.valid)
485 return
486 self.assertTrue(parsed.valid)
487 self.assertEqual(parsed.issue, issue)
488 self.assertEqual(parsed.patchset, patchset)
489 self.assertEqual(parsed.hostname, hostname)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200490
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000491 def test_basic(self):
492 self._test('123', 123)
493 self._test('', fail=True)
494 self._test('abc', fail=True)
495 self._test('123/1', fail=True)
496 self._test('123a', fail=True)
497 self._test('ssh://chrome-review.source.com/#/c/123/4/', fail=True)
498 self._test('ssh://chrome-review.source.com/c/123/1/', fail=True)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200499
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000500 def test_gerrit_url(self):
501 self._test('https://codereview.source.com/123', 123, None,
502 'codereview.source.com')
503 self._test('http://chrome-review.source.com/c/123', 123, None,
504 'chrome-review.source.com')
505 self._test('https://chrome-review.source.com/c/123/', 123, None,
506 'chrome-review.source.com')
507 self._test('https://chrome-review.source.com/c/123/4', 123, 4,
508 'chrome-review.source.com')
509 self._test('https://chrome-review.source.com/#/c/123/4', 123, 4,
510 'chrome-review.source.com')
511 self._test('https://chrome-review.source.com/c/123/4', 123, 4,
512 'chrome-review.source.com')
513 self._test('https://chrome-review.source.com/123', 123, None,
514 'chrome-review.source.com')
515 self._test('https://chrome-review.source.com/123/4', 123, 4,
516 'chrome-review.source.com')
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200517
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000518 self._test('https://chrome-review.source.com/bad/123/4', fail=True)
519 self._test('https://chrome-review.source.com/c/123/1/whatisthis', fail=True)
520 self._test('https://chrome-review.source.com/c/abc/', fail=True)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200521
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000522 def test_short_urls(self):
523 self._test('https://crrev.com/c/2151934', 2151934, None,
524 'chromium-review.googlesource.com')
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200525
526
Edward Lemurda4b6c62020-02-13 00:28:40 +0000527class GitCookiesCheckerTest(unittest.TestCase):
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100528 def setUp(self):
529 super(GitCookiesCheckerTest, self).setUp()
530 self.c = git_cl._GitCookiesChecker()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100531 self.c._all_hosts = []
Edward Lemurda4b6c62020-02-13 00:28:40 +0000532 mock.patch('sys.stdout', StringIO()).start()
533 self.addCleanup(mock.patch.stopall)
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100534
535 def mock_hosts_creds(self, subhost_identity_pairs):
536 def ensure_googlesource(h):
537 if not h.endswith(self.c._GOOGLESOURCE):
538 assert not h.endswith('.')
539 return h + '.' + self.c._GOOGLESOURCE
540 return h
541 self.c._all_hosts = [(ensure_googlesource(h), i, '.gitcookies')
542 for h, i in subhost_identity_pairs]
543
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200544 def test_identity_parsing(self):
545 self.assertEqual(self.c._parse_identity('ldap.google.com'),
546 ('ldap', 'google.com'))
547 self.assertEqual(self.c._parse_identity('git-ldap.example.com'),
548 ('ldap', 'example.com'))
549 # Specical case because we know there are no subdomains in chromium.org.
550 self.assertEqual(self.c._parse_identity('git-note.period.chromium.org'),
551 ('note.period', 'chromium.org'))
Lei Zhangd3f769a2017-12-15 15:16:14 -0800552 # Pathological: ".period." can be either username OR domain, more likely
553 # domain.
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200554 self.assertEqual(self.c._parse_identity('git-note.period.example.com'),
555 ('note', 'period.example.com'))
556
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100557 def test_analysis_nothing(self):
558 self.c._all_hosts = []
559 self.assertFalse(self.c.has_generic_host())
560 self.assertEqual(set(), self.c.get_conflicting_hosts())
561 self.assertEqual(set(), self.c.get_duplicated_hosts())
562 self.assertEqual(set(), self.c.get_partially_configured_hosts())
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100563
564 def test_analysis(self):
565 self.mock_hosts_creds([
566 ('.googlesource.com', 'git-example.chromium.org'),
567
568 ('chromium', 'git-example.google.com'),
569 ('chromium-review', 'git-example.google.com'),
570 ('chrome-internal', 'git-example.chromium.org'),
571 ('chrome-internal-review', 'git-example.chromium.org'),
572 ('conflict', 'git-example.google.com'),
573 ('conflict-review', 'git-example.chromium.org'),
574 ('dup', 'git-example.google.com'),
575 ('dup', 'git-example.google.com'),
576 ('dup-review', 'git-example.google.com'),
577 ('partial', 'git-example.google.com'),
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200578 ('gpartial-review', 'git-example.google.com'),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100579 ])
580 self.assertTrue(self.c.has_generic_host())
581 self.assertEqual(set(['conflict.googlesource.com']),
582 self.c.get_conflicting_hosts())
583 self.assertEqual(set(['dup.googlesource.com']),
584 self.c.get_duplicated_hosts())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200585 self.assertEqual(set(['partial.googlesource.com',
586 'gpartial-review.googlesource.com']),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100587 self.c.get_partially_configured_hosts())
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100588
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100589 def test_report_no_problems(self):
590 self.test_analysis_nothing()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100591 self.assertFalse(self.c.find_and_report_problems())
592 self.assertEqual(sys.stdout.getvalue(), '')
593
Edward Lemurda4b6c62020-02-13 00:28:40 +0000594 @mock.patch(
595 'git_cl.gerrit_util.CookiesAuthenticator.get_gitcookies_path',
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000596 return_value=os.path.join('~', '.gitcookies'))
Edward Lemurda4b6c62020-02-13 00:28:40 +0000597 def test_report(self, *_mocks):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100598 self.test_analysis()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100599 self.assertTrue(self.c.find_and_report_problems())
600 with open(os.path.join(os.path.dirname(__file__),
601 'git_cl_creds_check_report.txt')) as f:
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000602 expected = f.read() % {
603 'sep': os.sep,
604 }
605
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100606 def by_line(text):
607 return [l.rstrip() for l in text.rstrip().splitlines()]
Robert Iannucci456b0d62018-03-13 19:15:50 -0700608 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalov4812e612017-03-27 17:22:57 +0200609 self.assertEqual(by_line(sys.stdout.getvalue().strip()), by_line(expected))
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100610
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -0800611
Edward Lemurda4b6c62020-02-13 00:28:40 +0000612class TestGitCl(unittest.TestCase):
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000613 def setUp(self):
614 super(TestGitCl, self).setUp()
615 self.calls = []
tandrii9d206752016-06-20 11:32:47 -0700616 self._calls_done = []
Edward Lesmes0dd54822020-03-26 18:24:25 +0000617 self.failed = False
Edward Lemurda4b6c62020-02-13 00:28:40 +0000618 mock.patch('sys.stdout', StringIO()).start()
619 mock.patch(
620 'git_cl.time_time',
621 lambda: self._mocked_call('time.time')).start()
622 mock.patch(
623 'git_cl.metrics.collector.add_repeated',
624 lambda *a: self._mocked_call('add_repeated', *a)).start()
625 mock.patch('subprocess2.call', self._mocked_call).start()
626 mock.patch('subprocess2.check_call', self._mocked_call).start()
627 mock.patch('subprocess2.check_output', self._mocked_call).start()
628 mock.patch(
629 'subprocess2.communicate',
630 lambda *a, **_k: ([self._mocked_call(*a), ''], 0)).start()
631 mock.patch(
632 'git_cl.gclient_utils.CheckCallAndFilter',
633 self._mocked_call).start()
634 mock.patch('git_common.is_dirty_git_tree', lambda x: False).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +0000635 mock.patch('git_cl.FindCodereviewSettingsFile', return_value='').start()
636 mock.patch(
637 'git_cl.SaveDescriptionBackup',
638 lambda _: self._mocked_call('SaveDescriptionBackup')).start()
639 mock.patch(
Edward Lemurda4b6c62020-02-13 00:28:40 +0000640 'git_cl.write_json',
641 lambda *a: self._mocked_call('write_json', *a)).start()
642 mock.patch(
Edward Lemur227d5102020-02-25 23:45:35 +0000643 'git_cl.Changelist.RunHook',
644 return_value={'more_cc': ['test-more-cc@chromium.org']}).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +0000645 mock.patch('git_cl.watchlists.Watchlists', WatchlistsMock).start()
646 mock.patch('git_cl.auth.Authenticator', AuthenticatorMock).start()
Edward Lesmes7677e5c2020-02-19 20:39:03 +0000647 mock.patch('gerrit_util.GetChangeDetail').start()
Edward Lemurda4b6c62020-02-13 00:28:40 +0000648 mock.patch(
649 'git_cl.gerrit_util.GetChangeComments',
650 lambda *a: self._mocked_call('GetChangeComments', *a)).start()
651 mock.patch(
652 'git_cl.gerrit_util.GetChangeRobotComments',
653 lambda *a: self._mocked_call('GetChangeRobotComments', *a)).start()
654 mock.patch(
655 'git_cl.gerrit_util.AddReviewers',
656 lambda *a: self._mocked_call('AddReviewers', *a)).start()
657 mock.patch(
658 'git_cl.gerrit_util.SetReview',
659 lambda h, i, msg=None, labels=None, notify=None, ready=None: (
660 self._mocked_call(
661 'SetReview', h, i, msg, labels, notify, ready))).start()
662 mock.patch(
663 'git_cl.gerrit_util.LuciContextAuthenticator.is_luci',
664 return_value=False).start()
665 mock.patch(
666 'git_cl.gerrit_util.GceAuthenticator.is_gce',
667 return_value=False).start()
668 mock.patch(
669 'git_cl.gerrit_util.ValidAccounts',
670 lambda *a: self._mocked_call('ValidAccounts', *a)).start()
Edward Lemurd55c5072020-02-20 01:09:07 +0000671 mock.patch('sys.exit', side_effect=SystemExitMock).start()
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000672 mock.patch('git_cl.Settings.GetRoot', return_value='').start()
Edward Lemur85153282020-02-14 22:06:29 +0000673 self.mockGit = GitMocks()
674 mock.patch('scm.GIT.GetBranchRef', self.mockGit.GetBranchRef).start()
675 mock.patch('scm.GIT.GetConfig', self.mockGit.GetConfig).start()
Edward Lesmes50da7702020-03-30 19:23:43 +0000676 mock.patch('scm.GIT.ResolveCommit', return_value='hash').start()
677 mock.patch('scm.GIT.IsValidRevision', return_value=True).start()
Edward Lemur85153282020-02-14 22:06:29 +0000678 mock.patch('scm.GIT.SetConfig', self.mockGit.SetConfig).start()
Edward Lemur84101642020-02-21 21:40:34 +0000679 mock.patch(
680 'git_new_branch.create_new_branch', self.mockGit.NewBranch).start()
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000681 mock.patch(
Edward Lemur85153282020-02-14 22:06:29 +0000682 'scm.GIT.FetchUpstreamTuple',
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000683 return_value=('origin', 'refs/heads/master')).start()
Edward Lemur85153282020-02-14 22:06:29 +0000684 mock.patch(
685 'scm.GIT.CaptureStatus', return_value=[('M', 'foo.txt')]).start()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000686 # It's important to reset settings to not have inter-tests interference.
687 git_cl.settings = None
Edward Lemurda4b6c62020-02-13 00:28:40 +0000688 self.addCleanup(mock.patch.stopall)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000689
690 def tearDown(self):
wychen@chromium.org445c8962015-04-28 23:30:05 +0000691 try:
Edward Lesmes0dd54822020-03-26 18:24:25 +0000692 if not self.failed:
693 self.assertEqual([], self.calls)
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100694 except AssertionError:
Edward Lemur85153282020-02-14 22:06:29 +0000695 calls = ''.join(' %s\n' % str(call) for call in self.calls[:5])
696 if len(self.calls) > 5:
697 calls += ' ...\n'
698 self.fail(
699 '\n'
700 'There are un-consumed calls after this test has finished:\n' +
701 calls)
wychen@chromium.org445c8962015-04-28 23:30:05 +0000702 finally:
703 super(TestGitCl, self).tearDown()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000704
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000705 def _mocked_call(self, *args, **_kwargs):
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000706 self.assertTrue(
707 self.calls,
tandrii9d206752016-06-20 11:32:47 -0700708 '@%d Expected: <Missing> Actual: %r' % (len(self._calls_done), args))
wychen@chromium.orga872e752015-04-28 23:42:18 +0000709 top = self.calls.pop(0)
wychen@chromium.orga872e752015-04-28 23:42:18 +0000710 expected_args, result = top
711
maruel@chromium.orge52678e2013-04-26 18:34:44 +0000712 # Also logs otherwise it could get caught in a try/finally and be hard to
713 # diagnose.
714 if expected_args != args:
tandrii9d206752016-06-20 11:32:47 -0700715 N = 5
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000716 prior_calls = '\n '.join(
tandrii9d206752016-06-20 11:32:47 -0700717 '@%d: %r' % (len(self._calls_done) - N + i, c[0])
718 for i, c in enumerate(self._calls_done[-N:]))
719 following_calls = '\n '.join(
720 '@%d: %r' % (len(self._calls_done) + i + 1, c[0])
721 for i, c in enumerate(self.calls[:N]))
722 extended_msg = (
723 'A few prior calls:\n %s\n\n'
724 'This (expected):\n @%d: %r\n'
725 'This (actual):\n @%d: %r\n\n'
726 'A few following expected calls:\n %s' %
727 (prior_calls, len(self._calls_done), expected_args,
728 len(self._calls_done), args, following_calls))
tandrii9d206752016-06-20 11:32:47 -0700729
Edward Lesmes0dd54822020-03-26 18:24:25 +0000730 self.failed = True
tandrii99a72f22016-08-17 14:33:24 -0700731 self.fail('@%d\n'
732 ' Expected: %r\n'
Edward Lemur26964072020-02-19 19:18:51 +0000733 ' Actual: %r\n'
734 '\n'
735 '%s' % (
736 len(self._calls_done), expected_args, args, extended_msg))
tandrii9d206752016-06-20 11:32:47 -0700737
738 self._calls_done.append(top)
tandrii5d48c322016-08-18 16:19:37 -0700739 if isinstance(result, Exception):
740 raise result
Edward Lemur0db01f02019-11-12 22:01:51 +0000741 # stdout from git commands is supposed to be a bytestream. Convert it here
742 # instead of converting all test output in this file to bytes.
743 if args[0][0] == 'git' and not isinstance(result, bytes):
744 result = result.encode('utf-8')
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000745 return result
746
Edward Lemur1a83da12020-03-04 21:18:36 +0000747 @mock.patch('sys.stdin', StringIO('blah\nye\n'))
748 @mock.patch('sys.stdout', StringIO())
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100749 def test_ask_for_explicit_yes_true(self):
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100750 self.assertTrue(git_cl.ask_for_explicit_yes('prompt'))
Edward Lemur1a83da12020-03-04 21:18:36 +0000751 self.assertEqual(
752 'prompt [Yes/No]: Please, type yes or no: ',
753 sys.stdout.getvalue())
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100754
tandrii48df5812016-10-17 03:55:37 -0700755 def test_LoadCodereviewSettingsFromFile_gerrit(self):
Edward Lemur79d4f992019-11-11 23:49:02 +0000756 codereview_file = StringIO('GERRIT_HOST: true')
tandrii48df5812016-10-17 03:55:37 -0700757 self.calls = [
758 ((['git', 'config', '--unset-all', 'rietveld.cc'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700759 ((['git', 'config', '--unset-all', 'rietveld.tree-status-url'],), CERR1),
760 ((['git', 'config', '--unset-all', 'rietveld.viewvc-url'],), CERR1),
761 ((['git', 'config', '--unset-all', 'rietveld.bug-prefix'],), CERR1),
762 ((['git', 'config', '--unset-all', 'rietveld.cpplint-regex'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700763 ((['git', 'config', '--unset-all', 'rietveld.cpplint-ignore-regex'],),
764 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700765 ((['git', 'config', '--unset-all', 'rietveld.run-post-upload-hook'],),
766 CERR1),
Jamie Madilldc4d19e2019-10-24 21:50:02 +0000767 ((['git', 'config', '--unset-all', 'rietveld.format-full-by-default'],),
768 CERR1),
Dirk Pranke6f0df682021-06-25 00:42:33 +0000769 ((['git', 'config', '--unset-all', 'rietveld.use-python3'],),
770 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700771 ((['git', 'config', 'gerrit.host', 'true'],), ''),
772 ]
773 self.assertIsNone(git_cl.LoadCodereviewSettingsFromFile(codereview_file))
774
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000775 @classmethod
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100776 def _gerrit_base_calls(cls, issue=None, fetched_description=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200777 fetched_status=None, other_cl_owner=None,
Anthony Polito8b955342019-09-24 19:01:36 +0000778 custom_cl_base=None, short_hostname='chromium',
Edward Lesmes8c43c3f2021-01-20 00:20:26 +0000779 change_id=None, default_branch='master'):
Edward Lemur26964072020-02-19 19:18:51 +0000780 calls = []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200781 if custom_cl_base:
782 ancestor_revision = custom_cl_base
783 else:
784 # Determine ancestor_revision to be merge base.
Edward Lesmes8c43c3f2021-01-20 00:20:26 +0000785 ancestor_revision = 'origin/' + default_branch
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200786
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100787 if issue:
Edward Lesmes7677e5c2020-02-19 20:39:03 +0000788 gerrit_util.GetChangeDetail.return_value = {
789 'owner': {'email': (other_cl_owner or 'owner@example.com')},
790 'change_id': (change_id or '123456789'),
791 'current_revision': 'sha1_of_current_revision',
792 'revisions': {'sha1_of_current_revision': {
793 'commit': {'message': fetched_description},
794 }},
795 'status': fetched_status or 'NEW',
796 }
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100797 if fetched_status == 'ABANDONED':
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100798 return calls
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100799 if other_cl_owner:
800 calls += [
801 (('ask_for_data', 'Press Enter to upload, or Ctrl+C to abort'), ''),
802 ]
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100803
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100804 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200805 ((['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] +
806 ([custom_cl_base] if custom_cl_base else
807 [ancestor_revision, 'HEAD']),),
808 '+dat'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100809 ]
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000810 calls += [
811 ((['git', 'show-branch', 'refs/remotes/origin/main'], ),
Edward Lesmes8c43c3f2021-01-20 00:20:26 +0000812 '1' if default_branch == 'main' else callError(1)),
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000813 ]
Edward Lemur2c62b332020-03-12 22:12:33 +0000814
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100815 return calls
ukai@chromium.orge8077812012-02-03 03:41:46 +0000816
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +0000817 def _gerrit_upload_calls(self,
818 description,
819 reviewers,
820 squash,
tandriia60502f2016-06-20 02:01:53 -0700821 squash_mode='default',
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +0000822 title=None,
823 notify=False,
824 post_amend_description=None,
825 issue=None,
826 cc=None,
827 custom_cl_base=None,
828 tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +0000829 short_hostname='chromium',
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +0000830 labels=None,
831 change_id=None,
832 final_description=None,
833 gitcookies_exists=True,
834 force=False,
835 edit_description=None,
836 default_branch='master',
837 push_opts=None):
tandrii@chromium.org10625002016-03-04 20:03:47 +0000838 if post_amend_description is None:
839 post_amend_description = description
bradnelsond975b302016-10-23 12:20:23 -0700840 cc = cc or []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200841
842 calls = []
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000843
Edward Lesmes4de54132020-05-05 19:41:33 +0000844 if squash_mode in ('override_squash', 'override_nosquash'):
845 self.mockGit.config['gerrit.override-squash-uploads'] = (
846 'true' if squash_mode == 'override_squash' else 'false')
847
tandrii@chromium.org57d86542016-03-04 16:11:32 +0000848 if not git_footers.get_footer_change_id(description) and not squash:
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000849 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200850 (('DownloadGerritHook', False), ''),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200851 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000852 if squash:
Edward Lemur5a644f82020-03-18 16:44:57 +0000853 if not issue and not force:
Edward Lemur5fb22242020-03-12 22:05:13 +0000854 calls += [
855 ((['RunEditor'],), description),
856 ]
Josipe827b0f2020-01-30 00:07:20 +0000857 # user wants to edit description
858 if edit_description:
859 calls += [
Josipe827b0f2020-01-30 00:07:20 +0000860 ((['RunEditor'],), edit_description),
861 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000862 ref_to_push = 'abcdef0123456789'
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200863
864 if custom_cl_base is None:
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000865 parent = 'origin/' + default_branch
Edward Lesmes8c43c3f2021-01-20 00:20:26 +0000866 git_common.get_or_create_merge_base.return_value = parent
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200867 else:
868 calls += [
869 ((['git', 'merge-base', '--is-ancestor', custom_cl_base,
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000870 'refs/remotes/origin/' + default_branch],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200871 callError(1)), # Means not ancenstor.
872 (('ask_for_data',
873 'Do you take responsibility for cleaning up potential mess '
874 'resulting from proceeding with upload? Press Enter to upload, '
875 'or Ctrl+C to abort'), ''),
876 ]
877 parent = custom_cl_base
878
879 calls += [
880 ((['git', 'rev-parse', 'HEAD:'],), # `HEAD:` means HEAD's tree hash.
881 '0123456789abcdef'),
Edward Lemur1773f372020-02-22 00:27:14 +0000882 ((['FileWrite', '/tmp/fake-temp1', description],), None),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200883 ((['git', 'commit-tree', '0123456789abcdef', '-p', parent,
Edward Lemur1773f372020-02-22 00:27:14 +0000884 '-F', '/tmp/fake-temp1'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200885 ref_to_push),
886 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000887 else:
888 ref_to_push = 'HEAD'
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000889 parent = 'origin/refs/heads/' + default_branch
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000890
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000891 calls += [
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000892 (('SaveDescriptionBackup',), None),
Edward Lemur5a644f82020-03-18 16:44:57 +0000893 ((['git', 'rev-list', parent + '..' + ref_to_push],),'1hashPerLine\n'),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200894 ]
tandrii@chromium.org8da45402016-05-24 23:11:03 +0000895
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +0000896 metrics_arguments = []
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000897
Aaron Gableafd52772017-06-27 16:40:10 -0700898 if notify:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +0000899 ref_suffix = '%ready,notify=ALL'
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000900 metrics_arguments += ['ready', 'notify=ALL']
Aaron Gable844cf292017-06-28 11:32:59 -0700901 else:
Jamie Madill276da0b2018-04-27 14:41:20 -0400902 if not issue and squash:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +0000903 ref_suffix = '%wip'
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000904 metrics_arguments.append('wip')
Aaron Gable844cf292017-06-28 11:32:59 -0700905 else:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +0000906 ref_suffix = '%notify=NONE'
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000907 metrics_arguments.append('notify=NONE')
Aaron Gable9b713dd2016-12-14 16:04:21 -0800908
Edward Lemur5a644f82020-03-18 16:44:57 +0000909 # If issue is given, then description is fetched from Gerrit instead.
910 if issue is None:
911 if squash:
912 title = 'Initial upload'
913 else:
914 if not title:
915 calls += [
916 ((['git', 'show', '-s', '--format=%s', 'HEAD'],), ''),
917 (('ask_for_data', 'Title for patchset []: '), 'User input'),
918 ]
919 title = 'User input'
Aaron Gable70f4e242017-06-26 10:45:59 -0700920 if title:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +0000921 ref_suffix += ',m=' + gerrit_util.PercentEncodeForGitRef(title)
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000922 metrics_arguments.append('m')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000923
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000924 if short_hostname == 'chromium':
Quinten Yearsley925cedb2020-04-13 17:49:39 +0000925 # All reviewers and ccs get into ref_suffix.
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000926 for r in sorted(reviewers):
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +0000927 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000928 metrics_arguments.append('r')
Edward Lemur4508b422019-10-03 21:56:35 +0000929 if issue is None:
Edward Lemur227d5102020-02-25 23:45:35 +0000930 cc += ['test-more-cc@chromium.org', 'joe@example.com']
Edward Lemur4508b422019-10-03 21:56:35 +0000931 for c in sorted(cc):
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +0000932 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000933 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000934 reviewers, cc = [], []
935 else:
936 # TODO(crbug/877717): remove this case.
937 calls += [
938 (('ValidAccounts', '%s-review.googlesource.com' % short_hostname,
939 sorted(reviewers) + ['joe@example.com',
Edward Lemur227d5102020-02-25 23:45:35 +0000940 'test-more-cc@chromium.org'] + cc),
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000941 {
942 e: {'email': e}
943 for e in (reviewers + ['joe@example.com'] + cc)
944 })
945 ]
946 for r in sorted(reviewers):
947 if r != 'bad-account-or-email':
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +0000948 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000949 metrics_arguments.append('r')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000950 reviewers.remove(r)
Edward Lemur4508b422019-10-03 21:56:35 +0000951 if issue is None:
952 cc += ['joe@example.com']
953 for c in sorted(cc):
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +0000954 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000955 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000956 if c in cc:
957 cc.remove(c)
Andrii Shyshkalov76988a82018-10-15 03:12:25 +0000958
Edward Lemur687ca902018-12-05 02:30:30 +0000959 for k, v in sorted((labels or {}).items()):
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +0000960 ref_suffix += ',l=%s+%d' % (k, v)
Edward Lemur687ca902018-12-05 02:30:30 +0000961 metrics_arguments.append('l=%s+%d' % (k, v))
962
963 if tbr:
964 calls += [
965 (('GetCodeReviewTbrScore',
966 '%s-review.googlesource.com' % short_hostname,
967 'my/repo'),
968 2,),
969 ]
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +0000970
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000971 calls += [
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +0000972 (
973 ('time.time', ),
974 1000,
975 ),
976 (
977 ([
978 'git', 'push',
979 'https://%s.googlesource.com/my/repo' % short_hostname,
980 ref_to_push + ':refs/for/refs/heads/' + default_branch +
981 ref_suffix
982 ] + (push_opts if push_opts else []), ),
983 (('remote:\n'
984 'remote: Processing changes: (\)\n'
985 'remote: Processing changes: (|)\n'
986 'remote: Processing changes: (/)\n'
987 'remote: Processing changes: (-)\n'
988 'remote: Processing changes: new: 1 (/)\n'
989 'remote: Processing changes: new: 1, done\n'
990 'remote:\n'
991 'remote: New Changes:\n'
992 'remote: '
993 'https://%s-review.googlesource.com/#/c/my/repo/+/123456'
994 ' XXX\n'
995 'remote:\n'
996 'To https://%s.googlesource.com/my/repo\n'
997 ' * [new branch] hhhh -> refs/for/refs/heads/%s\n') %
998 (short_hostname, short_hostname, default_branch)),
999 ),
1000 (
1001 ('time.time', ),
1002 2000,
1003 ),
1004 (
1005 ('add_repeated', 'sub_commands', {
1006 'execution_time': 1000,
1007 'command': 'git push',
1008 'exit_code': 0,
1009 'arguments': sorted(metrics_arguments),
1010 }),
1011 None,
1012 ),
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001013 ]
1014
Edward Lemur1b52d872019-05-09 21:12:12 +00001015 final_description = final_description or post_amend_description.strip()
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001016
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001017 trace_name = os.path.join('TRACES_DIR', '20170316T200041.000000')
1018
Edward Lemur1b52d872019-05-09 21:12:12 +00001019 # Trace-related calls
1020 calls += [
1021 # Write a description with context for the current trace.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001022 (
1023 ([
1024 'FileWrite', trace_name + '-README',
1025 '%(date)s\n'
1026 '%(short_hostname)s-review.googlesource.com\n'
1027 '%(change_id)s\n'
1028 '%(title)s\n'
1029 '%(description)s\n'
1030 '1000\n'
1031 '0\n'
1032 '%(trace_name)s' % {
Josip Sokcevic5e18b602020-04-23 21:47:00 +00001033 'date': '2017-03-16T20:00:41.000000',
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001034 'short_hostname': short_hostname,
1035 'change_id': change_id,
1036 'description': final_description,
1037 'title': title or '<untitled>',
1038 'trace_name': trace_name,
1039 }
1040 ], ),
1041 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001042 ),
1043 # Read traces and shorten git hashes.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001044 (
1045 (['os.path.isfile',
1046 os.path.join('TEMP_DIR', 'trace-packet')], ),
1047 True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001048 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001049 (
1050 (['FileRead', os.path.join('TEMP_DIR', 'trace-packet')], ),
1051 ('git-hash: 0123456789012345678901234567890123456789\n'
1052 'git-hash: abcdeabcdeabcdeabcdeabcdeabcdeabcdeabcde\n'),
Edward Lemur1b52d872019-05-09 21:12:12 +00001053 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001054 (
1055 ([
1056 'FileWrite',
1057 os.path.join('TEMP_DIR', 'trace-packet'), 'git-hash: 012345\n'
1058 'git-hash: abcdea\n'
1059 ], ),
1060 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001061 ),
1062 # Make zip file for the git traces.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001063 (
1064 (['make_archive', trace_name + '-traces', 'zip', 'TEMP_DIR'], ),
1065 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001066 ),
1067 # Collect git config and gitcookies.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001068 (
1069 (['git', 'config', '-l'], ),
1070 'git-config-output',
Edward Lemur1b52d872019-05-09 21:12:12 +00001071 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001072 (
1073 ([
1074 'FileWrite',
1075 os.path.join('TEMP_DIR', 'git-config'), 'git-config-output'
1076 ], ),
1077 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001078 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001079 (
1080 (['os.path.isfile',
1081 os.path.join('~', '.gitcookies')], ),
1082 gitcookies_exists,
Edward Lemur1b52d872019-05-09 21:12:12 +00001083 ),
1084 ]
1085 if gitcookies_exists:
1086 calls += [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001087 (
1088 (['FileRead', os.path.join('~', '.gitcookies')], ),
1089 'gitcookies 1/SECRET',
Edward Lemur1b52d872019-05-09 21:12:12 +00001090 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001091 (
1092 ([
1093 'FileWrite',
1094 os.path.join('TEMP_DIR', 'gitcookies'), 'gitcookies REDACTED'
1095 ], ),
1096 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001097 ),
1098 ]
1099 calls += [
1100 # Make zip file for the git config and gitcookies.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001101 (
1102 (['make_archive', trace_name + '-git-info', 'zip', 'TEMP_DIR'], ),
1103 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001104 ),
1105 ]
1106
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001107 # TODO(crbug/877717): this should never be used.
1108 if squash and short_hostname != 'chromium':
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001109 calls += [
1110 (('AddReviewers',
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001111 'chromium-review.googlesource.com', 'my%2Frepo~123456',
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001112 sorted(reviewers),
Edward Lemur227d5102020-02-25 23:45:35 +00001113 cc + ['test-more-cc@chromium.org'],
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00001114 notify),
1115 ''),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001116 ]
ukai@chromium.orge8077812012-02-03 03:41:46 +00001117 return calls
1118
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00001119 def _run_gerrit_upload_test(self,
1120 upload_args,
1121 description,
1122 reviewers=None,
1123 squash=True,
1124 squash_mode=None,
1125 title=None,
1126 notify=False,
1127 post_amend_description=None,
1128 issue=None,
1129 cc=None,
1130 fetched_status=None,
1131 other_cl_owner=None,
1132 custom_cl_base=None,
1133 tbr=None,
1134 short_hostname='chromium',
1135 labels=None,
1136 change_id=None,
1137 final_description=None,
1138 gitcookies_exists=True,
1139 force=False,
1140 log_description=None,
1141 edit_description=None,
1142 fetched_description=None,
1143 default_branch='master',
1144 push_opts=None):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001145 """Generic gerrit upload test framework."""
tandriia60502f2016-06-20 02:01:53 -07001146 if squash_mode is None:
1147 if '--no-squash' in upload_args:
1148 squash_mode = 'nosquash'
1149 elif '--squash' in upload_args:
1150 squash_mode = 'squash'
1151 else:
1152 squash_mode = 'default'
1153
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001154 reviewers = reviewers or []
bradnelsond975b302016-10-23 12:20:23 -07001155 cc = cc or []
Edward Lemurda4b6c62020-02-13 00:28:40 +00001156 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001157 CookiesAuthenticatorMockFactory(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001158 same_auth=('git-owner.example.com', '', 'pass'))).start()
1159 mock.patch('git_cl.Changelist._GerritCommitMsgHookCheck',
1160 lambda _, offer_removal: None).start()
1161 mock.patch('git_cl.gclient_utils.RunEditor',
1162 lambda *_, **__: self._mocked_call(['RunEditor'])).start()
1163 mock.patch('git_cl.DownloadGerritHook', lambda force: self._mocked_call(
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001164 'DownloadGerritHook', force)).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00001165 mock.patch('git_cl.gclient_utils.FileRead',
1166 lambda path: self._mocked_call(['FileRead', path])).start()
1167 mock.patch('git_cl.gclient_utils.FileWrite',
Edward Lemur1b52d872019-05-09 21:12:12 +00001168 lambda path, contents: self._mocked_call(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001169 ['FileWrite', path, contents])).start()
1170 mock.patch('git_cl.datetime_now',
1171 lambda: datetime.datetime(2017, 3, 16, 20, 0, 41, 0)).start()
1172 mock.patch('git_cl.tempfile.mkdtemp', lambda: 'TEMP_DIR').start()
1173 mock.patch('git_cl.TRACES_DIR', 'TRACES_DIR').start()
1174 mock.patch('git_cl.TRACES_README_FORMAT',
Edward Lemur75391d42019-05-14 23:35:56 +00001175 '%(now)s\n'
1176 '%(gerrit_host)s\n'
1177 '%(change_id)s\n'
1178 '%(title)s\n'
1179 '%(description)s\n'
1180 '%(execution_time)s\n'
1181 '%(exit_code)s\n'
Edward Lemurda4b6c62020-02-13 00:28:40 +00001182 '%(trace_name)s').start()
1183 mock.patch('git_cl.shutil.make_archive',
1184 lambda *args: self._mocked_call(['make_archive'] +
1185 list(args))).start()
1186 mock.patch('os.path.isfile',
1187 lambda path: self._mocked_call(['os.path.isfile', path])).start()
Edward Lemur9aa1a962020-02-25 00:58:38 +00001188 mock.patch(
Edward Lesmes0dd54822020-03-26 18:24:25 +00001189 'git_cl._create_description_from_log',
1190 return_value=log_description or description).start()
Edward Lemura12175c2020-03-09 16:58:26 +00001191 mock.patch(
1192 'git_cl.Changelist._AddChangeIdToCommitMessage',
1193 return_value=post_amend_description or description).start()
Edward Lemur1a83da12020-03-04 21:18:36 +00001194 mock.patch(
Edward Lemur5a644f82020-03-18 16:44:57 +00001195 'git_cl.GenerateGerritChangeId', return_value=change_id).start()
1196 mock.patch(
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001197 'git_common.get_or_create_merge_base',
1198 return_value='origin/' + default_branch).start()
1199 mock.patch(
Edward Lesmesae3586b2020-03-23 21:21:14 +00001200 'gclient_utils.AskForData',
Edward Lemur1a83da12020-03-04 21:18:36 +00001201 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
tandriia60502f2016-06-20 02:01:53 -07001202
Edward Lemur26964072020-02-19 19:18:51 +00001203 self.mockGit.config['gerrit.host'] = 'true'
Edward Lemur85153282020-02-14 22:06:29 +00001204 self.mockGit.config['branch.master.gerritissue'] = (
1205 str(issue) if issue else None)
1206 self.mockGit.config['remote.origin.url'] = (
1207 'https://%s.googlesource.com/my/repo' % short_hostname)
Edward Lemur9aa1a962020-02-25 00:58:38 +00001208 self.mockGit.config['user.email'] = 'me@example.com'
Edward Lemur85153282020-02-14 22:06:29 +00001209
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001210 self.calls = self._gerrit_base_calls(
1211 issue=issue,
Anthony Polito8b955342019-09-24 19:01:36 +00001212 fetched_description=fetched_description or description,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001213 fetched_status=fetched_status,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001214 other_cl_owner=other_cl_owner,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001215 custom_cl_base=custom_cl_base,
Anthony Polito8b955342019-09-24 19:01:36 +00001216 short_hostname=short_hostname,
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001217 change_id=change_id,
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001218 default_branch=default_branch)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001219 if fetched_status != 'ABANDONED':
Edward Lemurda4b6c62020-02-13 00:28:40 +00001220 mock.patch(
Edward Lemur1773f372020-02-22 00:27:14 +00001221 'gclient_utils.temporary_file', TemporaryFileMock()).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00001222 mock.patch('os.remove', return_value=True).start()
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001223 self.calls += self._gerrit_upload_calls(
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00001224 description,
1225 reviewers,
1226 squash,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001227 squash_mode=squash_mode,
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00001228 title=title,
1229 notify=notify,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001230 post_amend_description=post_amend_description,
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00001231 issue=issue,
1232 cc=cc,
1233 custom_cl_base=custom_cl_base,
1234 tbr=tbr,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001235 short_hostname=short_hostname,
Edward Lemur1b52d872019-05-09 21:12:12 +00001236 labels=labels,
1237 change_id=change_id,
Edward Lemur1b52d872019-05-09 21:12:12 +00001238 final_description=final_description,
Anthony Polito8b955342019-09-24 19:01:36 +00001239 gitcookies_exists=gitcookies_exists,
Josipe827b0f2020-01-30 00:07:20 +00001240 force=force,
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001241 edit_description=edit_description,
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00001242 default_branch=default_branch,
1243 push_opts=push_opts)
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001244 # Uncomment when debugging.
Raul Tambre80ee78e2019-05-06 22:41:05 +00001245 # print('\n'.join(map(lambda x: '%2i: %s' % x, enumerate(self.calls))))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001246 git_cl.main(['upload'] + upload_args)
Edward Lemur85153282020-02-14 22:06:29 +00001247 if squash:
Edward Lemur26964072020-02-19 19:18:51 +00001248 self.assertIssueAndPatchset(patchset=None)
Edward Lemur85153282020-02-14 22:06:29 +00001249 self.assertEqual(
1250 'abcdef0123456789',
Edward Lemur26964072020-02-19 19:18:51 +00001251 scm.GIT.GetBranchConfig('', 'master', 'gerritsquashhash'))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001252
Edward Lemur1b52d872019-05-09 21:12:12 +00001253 def test_gerrit_upload_traces_no_gitcookies(self):
1254 self._run_gerrit_upload_test(
1255 ['--no-squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001256 'desc ✔\n\nBUG=\n',
Edward Lemur1b52d872019-05-09 21:12:12 +00001257 [],
1258 squash=False,
Edward Lemur0db01f02019-11-12 22:01:51 +00001259 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001260 change_id='Ixxx',
1261 gitcookies_exists=False)
1262
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001263 def test_gerrit_upload_without_change_id(self):
tandriia60502f2016-06-20 02:01:53 -07001264 self._run_gerrit_upload_test(
Edward Lemur5a644f82020-03-18 16:44:57 +00001265 [],
1266 'desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
1267 [],
1268 change_id='Ixxx')
1269
1270 def test_gerrit_upload_without_change_id_nosquash(self):
1271 self._run_gerrit_upload_test(
tandriia60502f2016-06-20 02:01:53 -07001272 ['--no-squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001273 'desc ✔\n\nBUG=\n',
tandriia60502f2016-06-20 02:01:53 -07001274 [],
1275 squash=False,
Edward Lemur0db01f02019-11-12 22:01:51 +00001276 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001277 change_id='Ixxx')
tandriia60502f2016-06-20 02:01:53 -07001278
Edward Lesmes4de54132020-05-05 19:41:33 +00001279 def test_gerrit_upload_without_change_id_override_nosquash(self):
1280 self._run_gerrit_upload_test(
1281 [],
1282 'desc ✔\n\nBUG=\n',
1283 [],
1284 squash=False,
1285 squash_mode='override_nosquash',
1286 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
1287 change_id='Ixxx')
1288
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001289 def test_gerrit_no_reviewer(self):
1290 self._run_gerrit_upload_test(
Edward Lesmes4de54132020-05-05 19:41:33 +00001291 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001292 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
tandriia60502f2016-06-20 02:01:53 -07001293 [],
1294 squash=False,
Edward Lesmes4de54132020-05-05 19:41:33 +00001295 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001296 change_id='I123456789')
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001297
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00001298 def test_gerrit_push_opts(self):
1299 self._run_gerrit_upload_test(['-o', 'wip'],
1300 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
1301 [],
1302 squash=False,
1303 squash_mode='override_nosquash',
1304 change_id='I123456789',
1305 push_opts=['-o', 'wip'])
1306
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001307 def test_gerrit_no_reviewer_non_chromium_host(self):
1308 # TODO(crbug/877717): remove this test case.
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00001309 self._run_gerrit_upload_test([],
1310 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
1311 [],
1312 squash=False,
1313 squash_mode='override_nosquash',
1314 short_hostname='other',
1315 change_id='I123456789')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001316
Edward Lesmes0dd54822020-03-26 18:24:25 +00001317 def test_gerrit_patchset_title_special_chars_nosquash(self):
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001318 self._run_gerrit_upload_test(
Edward Lesmes4de54132020-05-05 19:41:33 +00001319 ['-f', '-t', 'We\'ll escape ^_ ^ special chars...@{u}'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001320 'desc ✔\n\nBUG=\n\nChange-Id: I123456789',
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001321 squash=False,
Edward Lesmes4de54132020-05-05 19:41:33 +00001322 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001323 change_id='I123456789',
Edward Lemur5a644f82020-03-18 16:44:57 +00001324 title='We\'ll escape ^_ ^ special chars...@{u}')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001325
ukai@chromium.orge8077812012-02-03 03:41:46 +00001326 def test_gerrit_reviewers_cmd_line(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001327 self._run_gerrit_upload_test(
Edward Lesmes4de54132020-05-05 19:41:33 +00001328 ['-r', 'foo@example.com', '--send-mail'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001329 'desc ✔\n\nBUG=\n\nChange-Id: I123456789',
Edward Lemur5a644f82020-03-18 16:44:57 +00001330 reviewers=['foo@example.com'],
tandriia60502f2016-06-20 02:01:53 -07001331 squash=False,
Edward Lesmes4de54132020-05-05 19:41:33 +00001332 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001333 notify=True,
1334 change_id='I123456789',
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001335 final_description=(
Edward Lemur0db01f02019-11-12 22:01:51 +00001336 'desc ✔\n\nBUG=\nR=foo@example.com\n\nChange-Id: I123456789'))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001337
Anthony Polito8b955342019-09-24 19:01:36 +00001338 def test_gerrit_upload_force_sets_bug(self):
1339 self._run_gerrit_upload_test(
1340 ['-b', '10000', '-f'],
1341 u'desc=\n\nBug: 10000\nChange-Id: Ixxx',
1342 [],
1343 force=True,
Anthony Polito8b955342019-09-24 19:01:36 +00001344 fetched_description='desc=\n\nChange-Id: Ixxx',
Anthony Polito8b955342019-09-24 19:01:36 +00001345 change_id='Ixxx')
1346
Edward Lemur5fb22242020-03-12 22:05:13 +00001347 def test_gerrit_upload_corrects_wrong_change_id(self):
Anthony Polito8b955342019-09-24 19:01:36 +00001348 self._run_gerrit_upload_test(
Edward Lemur5fb22242020-03-12 22:05:13 +00001349 ['-b', '10000', '-m', 'Title', '--edit-description'],
1350 u'desc=\n\nBug: 10000\nChange-Id: Ixxxx',
Anthony Polito8b955342019-09-24 19:01:36 +00001351 [],
Anthony Polito8b955342019-09-24 19:01:36 +00001352 issue='123456',
Edward Lemur5fb22242020-03-12 22:05:13 +00001353 edit_description='desc=\n\nBug: 10000\nChange-Id: Izzzz',
Anthony Polito8b955342019-09-24 19:01:36 +00001354 fetched_description='desc=\n\nChange-Id: Ixxxx',
Anthony Polito8b955342019-09-24 19:01:36 +00001355 title='Title',
Edward Lemur5fb22242020-03-12 22:05:13 +00001356 change_id='Ixxxx')
Anthony Polito8b955342019-09-24 19:01:36 +00001357
Dan Beamd8b04ca2019-10-10 21:23:26 +00001358 def test_gerrit_upload_force_sets_fixed(self):
1359 self._run_gerrit_upload_test(
1360 ['-x', '10000', '-f'],
1361 u'desc=\n\nFixed: 10000\nChange-Id: Ixxx',
1362 [],
1363 force=True,
Dan Beamd8b04ca2019-10-10 21:23:26 +00001364 fetched_description='desc=\n\nChange-Id: Ixxx',
Dan Beamd8b04ca2019-10-10 21:23:26 +00001365 change_id='Ixxx')
1366
ukai@chromium.orge8077812012-02-03 03:41:46 +00001367 def test_gerrit_reviewer_multiple(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00001368 mock.patch('git_cl.gerrit_util.GetCodeReviewTbrScore',
1369 lambda *a: self._mocked_call('GetCodeReviewTbrScore', *a)).start()
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001370 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001371 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001372 'desc ✔\nTBR=reviewer@example.com\nBUG=\nR=another@example.com\n'
bradnelsond975b302016-10-23 12:20:23 -07001373 'CC=more@example.com,people@example.com\n\n'
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001374 'Change-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001375 ['reviewer@example.com', 'another@example.com'],
Aaron Gablefd238082017-06-07 13:42:34 -07001376 cc=['more@example.com', 'people@example.com'],
Edward Lemur687ca902018-12-05 02:30:30 +00001377 tbr='reviewer@example.com',
Edward Lemur1b52d872019-05-09 21:12:12 +00001378 labels={'Code-Review': 2},
Edward Lemur5a644f82020-03-18 16:44:57 +00001379 change_id='123456789')
tandriia60502f2016-06-20 02:01:53 -07001380
1381 def test_gerrit_upload_squash_first_is_default(self):
tandriia60502f2016-06-20 02:01:53 -07001382 self._run_gerrit_upload_test(
1383 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001384 'desc ✔\nBUG=\n\nChange-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001385 [],
Edward Lemur5a644f82020-03-18 16:44:57 +00001386 change_id='123456789')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001387
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001388 def test_gerrit_upload_squash_first(self):
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001389 self._run_gerrit_upload_test(
1390 ['--squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001391 'desc ✔\nBUG=\n\nChange-Id: 123456789',
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001392 [],
luqui@chromium.org609f3952015-05-04 22:47:04 +00001393 squash=True,
Edward Lemur5a644f82020-03-18 16:44:57 +00001394 change_id='123456789')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001395
Edward Lesmes0dd54822020-03-26 18:24:25 +00001396 def test_gerrit_upload_squash_first_title(self):
1397 self._run_gerrit_upload_test(
1398 ['-f', '-t', 'title'],
1399 'title\n\ndesc\n\nChange-Id: 123456789',
1400 [],
1401 force=True,
1402 squash=True,
1403 log_description='desc',
1404 change_id='123456789')
1405
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001406 def test_gerrit_upload_squash_first_with_labels(self):
1407 self._run_gerrit_upload_test(
1408 ['--squash', '--cq-dry-run', '--enable-auto-submit'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001409 'desc ✔\nBUG=\n\nChange-Id: 123456789',
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001410 [],
1411 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001412 labels={'Commit-Queue': 1, 'Auto-Submit': 1},
Edward Lemur5a644f82020-03-18 16:44:57 +00001413 change_id='123456789')
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001414
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001415 def test_gerrit_upload_squash_first_against_rev(self):
1416 custom_cl_base = 'custom_cl_base_rev_or_branch'
1417 self._run_gerrit_upload_test(
1418 ['--squash', custom_cl_base],
Edward Lemur0db01f02019-11-12 22:01:51 +00001419 'desc ✔\nBUG=\n\nChange-Id: 123456789',
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001420 [],
1421 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001422 custom_cl_base=custom_cl_base,
Edward Lemur5a644f82020-03-18 16:44:57 +00001423 change_id='123456789')
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001424 self.assertIn(
1425 'If you proceed with upload, more than 1 CL may be created by Gerrit',
1426 sys.stdout.getvalue())
1427
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001428 def test_gerrit_upload_squash_reupload(self):
Edward Lemur0db01f02019-11-12 22:01:51 +00001429 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001430 self._run_gerrit_upload_test(
1431 ['--squash'],
1432 description,
1433 [],
1434 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001435 issue=123456,
Edward Lemur5a644f82020-03-18 16:44:57 +00001436 change_id='123456789')
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001437
Edward Lemurd55c5072020-02-20 01:09:07 +00001438 @mock.patch('sys.stderr', StringIO())
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001439 def test_gerrit_upload_squash_reupload_to_abandoned(self):
Edward Lemur0db01f02019-11-12 22:01:51 +00001440 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001441 with self.assertRaises(SystemExitMock):
1442 self._run_gerrit_upload_test(
1443 ['--squash'],
1444 description,
1445 [],
1446 squash=True,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001447 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001448 fetched_status='ABANDONED',
1449 change_id='123456789')
Edward Lemurd55c5072020-02-20 01:09:07 +00001450 self.assertEqual(
1451 'Change https://chromium-review.googlesource.com/123456 has been '
1452 'abandoned, new uploads are not allowed\n',
1453 sys.stderr.getvalue())
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001454
Edward Lemurda4b6c62020-02-13 00:28:40 +00001455 @mock.patch(
1456 'gerrit_util.GetAccountDetails',
1457 return_value={'email': 'yet-another@example.com'})
1458 def test_gerrit_upload_squash_reupload_to_not_owned(self, _mock):
Edward Lemur0db01f02019-11-12 22:01:51 +00001459 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001460 self._run_gerrit_upload_test(
1461 ['--squash'],
1462 description,
1463 [],
1464 squash=True,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001465 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001466 other_cl_owner='other@example.com',
Edward Lemur5a644f82020-03-18 16:44:57 +00001467 change_id='123456789')
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001468 self.assertIn(
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001469 'WARNING: Change 123456 is owned by other@example.com, but you '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001470 'authenticate to Gerrit as yet-another@example.com.\n'
1471 'Uploading may fail due to lack of permissions',
Edward Lemurda4b6c62020-02-13 00:28:40 +00001472 sys.stdout.getvalue())
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001473
Josipe827b0f2020-01-30 00:07:20 +00001474 def test_upload_change_description_editor(self):
1475 fetched_description = 'foo\n\nChange-Id: 123456789'
1476 description = 'bar\n\nChange-Id: 123456789'
1477 self._run_gerrit_upload_test(
1478 ['--squash', '--edit-description'],
1479 description,
1480 [],
1481 fetched_description=fetched_description,
1482 squash=True,
Josipe827b0f2020-01-30 00:07:20 +00001483 issue=123456,
1484 change_id='123456789',
Josipe827b0f2020-01-30 00:07:20 +00001485 edit_description=description)
1486
Edward Lemurda4b6c62020-02-13 00:28:40 +00001487 @mock.patch('git_cl.RunGit')
1488 @mock.patch('git_cl.CMDupload')
Edward Lemur1a83da12020-03-04 21:18:36 +00001489 @mock.patch('sys.stdin', StringIO('\n'))
1490 @mock.patch('sys.stdout', StringIO())
Edward Lemurda4b6c62020-02-13 00:28:40 +00001491 def test_upload_branch_deps(self, *_mocks):
rmistry@google.com2dd99862015-06-22 12:22:18 +00001492 def mock_run_git(*args, **_kwargs):
1493 if args[0] == ['for-each-ref',
1494 '--format=%(refname:short) %(upstream:short)',
1495 'refs/heads']:
1496 # Create a local branch dependency tree that looks like this:
1497 # test1 -> test2 -> test3 -> test4 -> test5
1498 # -> test3.1
1499 # test6 -> test0
1500 branch_deps = [
1501 'test2 test1', # test1 -> test2
1502 'test3 test2', # test2 -> test3
1503 'test3.1 test2', # test2 -> test3.1
1504 'test4 test3', # test3 -> test4
1505 'test5 test4', # test4 -> test5
1506 'test6 test0', # test0 -> test6
1507 'test7', # test7
1508 ]
1509 return '\n'.join(branch_deps)
Edward Lemurda4b6c62020-02-13 00:28:40 +00001510 git_cl.RunGit.side_effect = mock_run_git
1511 git_cl.CMDupload.return_value = 0
rmistry@google.com2dd99862015-06-22 12:22:18 +00001512
1513 class MockChangelist():
1514 def __init__(self):
1515 pass
1516 def GetBranch(self):
1517 return 'test1'
1518 def GetIssue(self):
1519 return '123'
1520 def GetPatchset(self):
1521 return '1001'
tandrii@chromium.org4c72b082016-03-31 22:26:35 +00001522 def IsGerrit(self):
1523 return False
rmistry@google.com2dd99862015-06-22 12:22:18 +00001524
1525 ret = git_cl.upload_branch_deps(MockChangelist(), [])
1526 # CMDupload should have been called 5 times because of 5 dependent branches.
Edward Lemurda4b6c62020-02-13 00:28:40 +00001527 self.assertEqual(5, len(git_cl.CMDupload.mock_calls))
Edward Lemur1a83da12020-03-04 21:18:36 +00001528 self.assertIn(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001529 'This command will checkout all dependent branches '
1530 'and run "git cl upload". Press Enter to continue, '
Edward Lemur1a83da12020-03-04 21:18:36 +00001531 'or Ctrl+C to abort',
1532 sys.stdout.getvalue())
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00001533 self.assertEqual(0, ret)
rmistry@google.com2dd99862015-06-22 12:22:18 +00001534
tandrii@chromium.org65874e12016-03-04 12:03:02 +00001535 def test_gerrit_change_id(self):
1536 self.calls = [
1537 ((['git', 'write-tree'], ),
1538 'hashtree'),
1539 ((['git', 'rev-parse', 'HEAD~0'], ),
1540 'branch-parent'),
1541 ((['git', 'var', 'GIT_AUTHOR_IDENT'], ),
1542 'A B <a@b.org> 1456848326 +0100'),
1543 ((['git', 'var', 'GIT_COMMITTER_IDENT'], ),
1544 'C D <c@d.org> 1456858326 +0100'),
1545 ((['git', 'hash-object', '-t', 'commit', '--stdin'], ),
1546 'hashchange'),
1547 ]
1548 change_id = git_cl.GenerateGerritChangeId('line1\nline2\n')
1549 self.assertEqual(change_id, 'Ihashchange')
1550
Edward Lesmes8170c292021-03-19 20:04:43 +00001551 @mock.patch('gerrit_util.IsCodeOwnersEnabledOnHost')
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001552 @mock.patch('git_cl.Settings.GetBugPrefix')
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001553 @mock.patch('git_cl.Changelist.FetchDescription')
1554 @mock.patch('git_cl.Changelist.GetBranch')
Edward Lesmes1eaaab52021-03-02 23:52:54 +00001555 @mock.patch('git_cl.Changelist.GetCommonAncestorWithUpstream')
Edward Lesmese1576912021-02-16 21:53:34 +00001556 @mock.patch('git_cl.Changelist.GetGerritHost')
1557 @mock.patch('git_cl.Changelist.GetGerritProject')
1558 @mock.patch('git_cl.Changelist.GetRemoteBranch')
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001559 @mock.patch('owners_client.OwnersClient.BatchListOwners')
1560 def getDescriptionForUploadTest(
Edward Lesmese1576912021-02-16 21:53:34 +00001561 self, mockBatchListOwners=None, mockGetRemoteBranch=None,
Edward Lesmes1eaaab52021-03-02 23:52:54 +00001562 mockGetGerritProject=None, mockGetGerritHost=None,
1563 mockGetCommonAncestorWithUpstream=None, mockGetBranch=None,
Edward Lesmese1576912021-02-16 21:53:34 +00001564 mockFetchDescription=None, mockGetBugPrefix=None,
Edward Lesmes8170c292021-03-19 20:04:43 +00001565 mockIsCodeOwnersEnabledOnHost=None,
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001566 initial_description='desc', bug=None, fixed=None, branch='branch',
1567 reviewers=None, tbrs=None, add_owners_to=None,
1568 expected_description='desc'):
1569 reviewers = reviewers or []
1570 tbrs = tbrs or []
1571 owners_by_path = {
1572 'a': ['a@example.com'],
1573 'b': ['b@example.com'],
1574 'c': ['c@example.com'],
1575 }
Edward Lesmes8170c292021-03-19 20:04:43 +00001576 mockIsCodeOwnersEnabledOnHost.return_value = True
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001577 mockGetBranch.return_value = branch
1578 mockGetBugPrefix.return_value = 'prefix'
Edward Lesmes1eaaab52021-03-02 23:52:54 +00001579 mockGetCommonAncestorWithUpstream.return_value = 'upstream'
Edward Lesmese1576912021-02-16 21:53:34 +00001580 mockGetRemoteBranch.return_value = ('origin', 'refs/remotes/origin/main')
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001581 mockFetchDescription.return_value = 'desc'
1582 mockBatchListOwners.side_effect = lambda ps: {
1583 p: owners_by_path.get(p)
1584 for p in ps
1585 }
1586
1587 cl = git_cl.Changelist(issue=1234)
Josip Sokcevic340edc32021-07-08 17:01:46 +00001588 actual = cl._GetDescriptionForUpload(options=mock.Mock(
1589 bug=bug,
1590 fixed=fixed,
1591 reviewers=reviewers,
1592 tbrs=tbrs,
1593 add_owners_to=add_owners_to,
1594 message=initial_description),
1595 git_diff_args=None,
1596 files=list(owners_by_path))
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001597 self.assertEqual(expected_description, actual.description)
1598
1599 def testGetDescriptionForUpload(self):
1600 self.getDescriptionForUploadTest()
1601
1602 def testGetDescriptionForUpload_Bug(self):
1603 self.getDescriptionForUploadTest(
1604 bug='1234',
1605 expected_description='\n'.join([
1606 'desc',
1607 '',
1608 'Bug: prefix:1234',
1609 ]))
1610
1611 def testGetDescriptionForUpload_Fixed(self):
1612 self.getDescriptionForUploadTest(
1613 fixed='1234',
1614 expected_description='\n'.join([
1615 'desc',
1616 '',
1617 'Fixed: prefix:1234',
1618 ]))
1619
Josip Sokcevic340edc32021-07-08 17:01:46 +00001620 @mock.patch('git_cl.Changelist.GetIssue')
1621 def testGetDescriptionForUpload_BugFromBranch(self, mockGetIssue):
1622 mockGetIssue.return_value = None
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001623 self.getDescriptionForUploadTest(
1624 branch='bug-1234',
1625 expected_description='\n'.join([
1626 'desc',
1627 '',
1628 'Bug: prefix:1234',
1629 ]))
1630
Josip Sokcevic340edc32021-07-08 17:01:46 +00001631 @mock.patch('git_cl.Changelist.GetIssue')
1632 def testGetDescriptionForUpload_FixedFromBranch(self, mockGetIssue):
1633 mockGetIssue.return_value = None
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001634 self.getDescriptionForUploadTest(
1635 branch='fix-1234',
1636 expected_description='\n'.join([
1637 'desc',
1638 '',
1639 'Fixed: prefix:1234',
1640 ]))
1641
Josip Sokcevic340edc32021-07-08 17:01:46 +00001642 def testGetDescriptionForUpload_SkipBugFromBranchIfAlreadyUploaded(self):
1643 self.getDescriptionForUploadTest(
1644 branch='bug-1234',
1645 expected_description='desc',
1646 )
1647
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001648 def testGetDescriptionForUpload_AddOwnersToR(self):
1649 self.getDescriptionForUploadTest(
1650 reviewers=['a@example.com'],
1651 tbrs=['b@example.com'],
1652 add_owners_to='R',
1653 expected_description='\n'.join([
1654 'desc',
1655 '',
1656 'R=a@example.com, c@example.com',
1657 'TBR=b@example.com',
1658 ]))
1659
1660 def testGetDescriptionForUpload_AddOwnersToTBR(self):
1661 self.getDescriptionForUploadTest(
1662 reviewers=['a@example.com'],
1663 tbrs=['b@example.com'],
1664 add_owners_to='TBR',
1665 expected_description='\n'.join([
1666 'desc',
1667 '',
1668 'R=a@example.com',
1669 'TBR=b@example.com, c@example.com',
1670 ]))
1671
1672 def testGetDescriptionForUpload_AddOwnersToNoOwnersNeeded(self):
1673 self.getDescriptionForUploadTest(
1674 reviewers=['a@example.com', 'c@example.com'],
1675 tbrs=['b@example.com'],
1676 add_owners_to='TBR',
1677 expected_description='\n'.join([
1678 'desc',
1679 '',
1680 'R=a@example.com, c@example.com',
1681 'TBR=b@example.com',
1682 ]))
1683
1684 def testGetDescriptionForUpload_Reviewers(self):
1685 self.getDescriptionForUploadTest(
1686 reviewers=['a@example.com', 'b@example.com'],
1687 expected_description='\n'.join([
1688 'desc',
1689 '',
1690 'R=a@example.com, b@example.com',
1691 ]))
1692
1693 def testGetDescriptionForUpload_TBRs(self):
1694 self.getDescriptionForUploadTest(
1695 tbrs=['a@example.com', 'b@example.com'],
1696 expected_description='\n'.join([
1697 'desc',
1698 '',
1699 'TBR=a@example.com, b@example.com',
1700 ]))
1701
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001702 def test_desecription_append_footer(self):
1703 for init_desc, footer_line, expected_desc in [
1704 # Use unique desc first lines for easy test failure identification.
1705 ('foo', 'R=one', 'foo\n\nR=one'),
1706 ('foo\n\nR=one', 'BUG=', 'foo\n\nR=one\nBUG='),
1707 ('foo\n\nR=one', 'Change-Id: Ixx', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1708 ('foo\n\nChange-Id: Ixx', 'R=one', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1709 ('foo\n\nR=one\n\nChange-Id: Ixx', 'TBR=two',
1710 'foo\n\nR=one\nTBR=two\n\nChange-Id: Ixx'),
1711 ('foo\n\nR=one\n\nChange-Id: Ixx', 'Foo-Bar: baz',
1712 'foo\n\nR=one\n\nChange-Id: Ixx\nFoo-Bar: baz'),
1713 ('foo\n\nChange-Id: Ixx', 'Foo-Bak: baz',
1714 'foo\n\nChange-Id: Ixx\nFoo-Bak: baz'),
1715 ('foo', 'Change-Id: Ixx', 'foo\n\nChange-Id: Ixx'),
1716 ]:
1717 desc = git_cl.ChangeDescription(init_desc)
1718 desc.append_footer(footer_line)
1719 self.assertEqual(desc.description, expected_desc)
1720
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001721 def test_update_reviewers(self):
1722 data = [
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001723 ('foo', [], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001724 'foo'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001725 ('foo\nR=xx', [], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001726 'foo\nR=xx'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001727 ('foo\nTBR=xx', [], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001728 'foo\nTBR=xx'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001729 ('foo', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001730 'foo\n\nR=a@c'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001731 ('foo\nR=xx', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001732 'foo\n\nR=a@c, xx'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001733 ('foo\nTBR=xx', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001734 'foo\n\nR=a@c\nTBR=xx'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001735 ('foo\nTBR=xx\nR=yy', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001736 'foo\n\nR=a@c, yy\nTBR=xx'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001737 ('foo\nBUG=', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001738 'foo\nBUG=\nR=a@c'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001739 ('foo\nR=xx\nTBR=yy\nR=bar', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001740 'foo\n\nR=a@c, bar, xx\nTBR=yy'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001741 ('foo', ['a@c', 'b@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001742 'foo\n\nR=a@c, b@c'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001743 ('foo\nBar\n\nR=\nBUG=', ['c@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001744 'foo\nBar\n\nR=c@c\nBUG='),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001745 ('foo\nBar\n\nR=\nBUG=\nR=', ['c@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001746 'foo\nBar\n\nR=c@c\nBUG='),
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001747 # Same as the line before, but full of whitespaces.
1748 (
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001749 'foo\nBar\n\n R = \n BUG = \n R = ', ['c@c'], [],
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001750 'foo\nBar\n\nR=c@c\n BUG =',
1751 ),
1752 # Whitespaces aren't interpreted as new lines.
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001753 ('foo BUG=allo R=joe ', ['c@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001754 'foo BUG=allo R=joe\n\nR=c@c'),
1755 # Redundant TBRs get promoted to Rs
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001756 ('foo\n\nR=a@c\nTBR=t@c', ['b@c', 'a@c'], ['a@c', 't@c'],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001757 'foo\n\nR=a@c, b@c\nTBR=t@c'),
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001758 ]
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001759 expected = [i[-1] for i in data]
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001760 actual = []
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001761 for orig, reviewers, tbrs, _expected in data:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001762 obj = git_cl.ChangeDescription(orig)
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001763 obj.update_reviewers(reviewers, tbrs)
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001764 actual.append(obj.description)
1765 self.assertEqual(expected, actual)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001766
Nodir Turakulov23b82142017-11-16 11:04:25 -08001767 def test_get_hash_tags(self):
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001768 self.calls = [
1769 ((['git', 'show-branch', 'refs/remotes/origin/main'], ),
1770 callError(1)),
1771 ] * 9
Nodir Turakulov23b82142017-11-16 11:04:25 -08001772 cases = [
1773 ('', []),
1774 ('a', []),
1775 ('[a]', ['a']),
1776 ('[aa]', ['aa']),
1777 ('[a ]', ['a']),
1778 ('[a- ]', ['a']),
1779 ('[a- b]', ['a-b']),
1780 ('[a--b]', ['a-b']),
1781 ('[a', []),
1782 ('[a]x', ['a']),
1783 ('[aa]x', ['aa']),
1784 ('[a b]', ['a-b']),
1785 ('[a b]', ['a-b']),
1786 ('[a__b]', ['a-b']),
1787 ('[a] x', ['a']),
1788 ('[a][b]', ['a', 'b']),
1789 ('[a] [b]', ['a', 'b']),
1790 ('[a][b]x', ['a', 'b']),
1791 ('[a][b] x', ['a', 'b']),
1792 ('[a]\n[b]', ['a']),
1793 ('[a\nb]', []),
1794 ('[a][', ['a']),
1795 ('Revert "[a] feature"', ['a']),
1796 ('Reland "[a] feature"', ['a']),
1797 ('Revert: [a] feature', ['a']),
1798 ('Reland: [a] feature', ['a']),
1799 ('Revert "Reland: [a] feature"', ['a']),
1800 ('Foo: feature', ['foo']),
1801 ('Foo Bar: feature', ['foo-bar']),
Anthony Polito02b5af32019-12-02 19:49:47 +00001802 ('Change Foo::Bar', []),
1803 ('Foo: Change Foo::Bar', ['foo']),
Nodir Turakulov23b82142017-11-16 11:04:25 -08001804 ('Revert "Foo bar: feature"', ['foo-bar']),
1805 ('Reland "Foo bar: feature"', ['foo-bar']),
1806 ]
1807 for desc, expected in cases:
1808 change_desc = git_cl.ChangeDescription(desc)
1809 actual = change_desc.get_hash_tags()
1810 self.assertEqual(
1811 actual,
1812 expected,
1813 'GetHashTags(%r) == %r, expected %r' % (desc, actual, expected))
1814
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001815 self.assertEqual(None, git_cl.GetTargetRef('origin', None, 'master'))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001816 self.assertEqual(None, git_cl.GetTargetRef(None,
1817 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001818 'master'))
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001819
wittman@chromium.org455dc922015-01-26 20:15:50 +00001820 # Check default target refs for branches.
1821 self.assertEqual('refs/heads/master',
1822 git_cl.GetTargetRef('origin', 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001823 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001824 self.assertEqual('refs/heads/master',
1825 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkgr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001826 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001827 self.assertEqual('refs/heads/master',
1828 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkcr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001829 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001830 self.assertEqual('refs/branch-heads/123',
1831 git_cl.GetTargetRef('origin',
1832 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001833 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001834 self.assertEqual('refs/diff/test',
1835 git_cl.GetTargetRef('origin',
1836 'refs/remotes/origin/refs/diff/test',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001837 None))
rmistry@google.comc68112d2015-03-03 12:48:06 +00001838 self.assertEqual('refs/heads/chrome/m42',
1839 git_cl.GetTargetRef('origin',
1840 'refs/remotes/origin/chrome/m42',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001841 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001842
1843 # Check target refs for user-specified target branch.
1844 for branch in ('branch-heads/123', 'remotes/branch-heads/123',
1845 'refs/remotes/branch-heads/123'):
1846 self.assertEqual('refs/branch-heads/123',
1847 git_cl.GetTargetRef('origin',
1848 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001849 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001850 for branch in ('origin/master', 'remotes/origin/master',
1851 'refs/remotes/origin/master'):
1852 self.assertEqual('refs/heads/master',
1853 git_cl.GetTargetRef('origin',
1854 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001855 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001856 for branch in ('master', 'heads/master', 'refs/heads/master'):
1857 self.assertEqual('refs/heads/master',
1858 git_cl.GetTargetRef('origin',
1859 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001860 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001861
Edward Lemurda4b6c62020-02-13 00:28:40 +00001862 @mock.patch('git_common.is_dirty_git_tree', return_value=True)
1863 def test_patch_when_dirty(self, *_mocks):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001864 # Patch when local tree is dirty.
wychen@chromium.orga872e752015-04-28 23:42:18 +00001865 self.assertNotEqual(git_cl.main(['patch', '123456']), 0)
1866
Edward Lemur85153282020-02-14 22:06:29 +00001867 def assertIssueAndPatchset(
1868 self, branch='master', issue='123456', patchset='7',
1869 git_short_host='chromium'):
1870 self.assertEqual(
Edward Lemur26964072020-02-19 19:18:51 +00001871 issue, scm.GIT.GetBranchConfig('', branch, 'gerritissue'))
Edward Lemur85153282020-02-14 22:06:29 +00001872 self.assertEqual(
Edward Lemur26964072020-02-19 19:18:51 +00001873 patchset, scm.GIT.GetBranchConfig('', branch, 'gerritpatchset'))
Edward Lemur85153282020-02-14 22:06:29 +00001874 self.assertEqual(
1875 'https://%s-review.googlesource.com' % git_short_host,
Edward Lemur26964072020-02-19 19:18:51 +00001876 scm.GIT.GetBranchConfig('', branch, 'gerritserver'))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001877
Edward Lemur85153282020-02-14 22:06:29 +00001878 def _patch_common(self, git_short_host='chromium'):
Edward Lesmes50da7702020-03-30 19:23:43 +00001879 mock.patch('scm.GIT.ResolveCommit', return_value='deadbeef').start()
Edward Lemur26964072020-02-19 19:18:51 +00001880 self.mockGit.config['remote.origin.url'] = (
1881 'https://%s.googlesource.com/my/repo' % git_short_host)
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001882 gerrit_util.GetChangeDetail.return_value = {
1883 'current_revision': '7777777777',
1884 'revisions': {
1885 '1111111111': {
1886 '_number': 1,
1887 'fetch': {'http': {
1888 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1889 'ref': 'refs/changes/56/123456/1',
1890 }},
1891 },
1892 '7777777777': {
1893 '_number': 7,
1894 'fetch': {'http': {
1895 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1896 'ref': 'refs/changes/56/123456/7',
1897 }},
1898 },
1899 },
1900 }
wychen@chromium.orga872e752015-04-28 23:42:18 +00001901
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001902 def test_patch_gerrit_default(self):
Edward Lemur85153282020-02-14 22:06:29 +00001903 self._patch_common()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001904 self.calls += [
1905 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1906 'refs/changes/56/123456/7'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001907 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001908 ]
1909 self.assertEqual(git_cl.main(['patch', '123456']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001910 self.assertIssueAndPatchset()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001911
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001912 def test_patch_gerrit_new_branch(self):
Edward Lemur85153282020-02-14 22:06:29 +00001913 self._patch_common()
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001914 self.calls += [
1915 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1916 'refs/changes/56/123456/7'],), ''),
1917 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001918 ]
Edward Lemur85153282020-02-14 22:06:29 +00001919 self.assertEqual(git_cl.main(['patch', '-b', 'feature', '123456']), 0)
1920 self.assertIssueAndPatchset(branch='feature')
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001921
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001922 def test_patch_gerrit_force(self):
Edward Lemur85153282020-02-14 22:06:29 +00001923 self._patch_common('host')
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001924 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001925 ((['git', 'fetch', 'https://host.googlesource.com/my/repo',
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001926 'refs/changes/56/123456/7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001927 ((['git', 'reset', '--hard', 'FETCH_HEAD'],), ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001928 ]
Edward Lemur52969c92020-02-06 18:15:28 +00001929 self.assertEqual(git_cl.main(['patch', '123456', '--force']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001930 self.assertIssueAndPatchset(git_short_host='host')
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001931
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001932 def test_patch_gerrit_guess_by_url(self):
Edward Lemur85153282020-02-14 22:06:29 +00001933 self._patch_common('else')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001934 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001935 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001936 'refs/changes/56/123456/1'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001937 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001938 ]
1939 self.assertEqual(git_cl.main(
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001940 ['patch', 'https://else-review.googlesource.com/#/c/123456/1']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001941 self.assertIssueAndPatchset(patchset='1', git_short_host='else')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001942
Aaron Gable697a91b2018-01-19 15:20:15 -08001943 def test_patch_gerrit_guess_by_url_with_repo(self):
Edward Lemur85153282020-02-14 22:06:29 +00001944 self._patch_common('else')
Aaron Gable697a91b2018-01-19 15:20:15 -08001945 self.calls += [
1946 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
1947 'refs/changes/56/123456/1'],), ''),
1948 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
Aaron Gable697a91b2018-01-19 15:20:15 -08001949 ]
1950 self.assertEqual(git_cl.main(
1951 ['patch', 'https://else-review.googlesource.com/c/my/repo/+/123456/1']),
1952 0)
Edward Lemur85153282020-02-14 22:06:29 +00001953 self.assertIssueAndPatchset(patchset='1', git_short_host='else')
Aaron Gable697a91b2018-01-19 15:20:15 -08001954
Edward Lemurd55c5072020-02-20 01:09:07 +00001955 @mock.patch('sys.stderr', StringIO())
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001956 def test_patch_gerrit_conflict(self):
Edward Lemur85153282020-02-14 22:06:29 +00001957 self._patch_common()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001958 self.calls += [
1959 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001960 'refs/changes/56/123456/7'],), ''),
tandrii5d48c322016-08-18 16:19:37 -07001961 ((['git', 'cherry-pick', 'FETCH_HEAD'],), CERR1),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001962 ]
1963 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001964 git_cl.main(['patch', '123456'])
Edward Lemurd55c5072020-02-20 01:09:07 +00001965 self.assertEqual(
1966 'Command "git cherry-pick FETCH_HEAD" failed.\n\n',
1967 sys.stderr.getvalue())
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001968
Edward Lemurda4b6c62020-02-13 00:28:40 +00001969 @mock.patch(
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001970 'gerrit_util.GetChangeDetail',
Edward Lemurda4b6c62020-02-13 00:28:40 +00001971 side_effect=gerrit_util.GerritError(404, ''))
Edward Lemurd55c5072020-02-20 01:09:07 +00001972 @mock.patch('sys.stderr', StringIO())
Edward Lemurda4b6c62020-02-13 00:28:40 +00001973 def test_patch_gerrit_not_exists(self, *_mocks):
Edward Lemur26964072020-02-19 19:18:51 +00001974 self.mockGit.config['remote.origin.url'] = (
1975 'https://chromium.googlesource.com/my/repo')
tandriic2405f52016-10-10 08:13:15 -07001976 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001977 self.assertEqual(1, git_cl.main(['patch', '123456']))
Edward Lemurd55c5072020-02-20 01:09:07 +00001978 self.assertEqual(
1979 'change 123456 at https://chromium-review.googlesource.com does not '
1980 'exist or you have no access to it\n',
1981 sys.stderr.getvalue())
tandriic2405f52016-10-10 08:13:15 -07001982
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001983 def _checkout_calls(self):
1984 return [
1985 ((['git', 'config', '--local', '--get-regexp',
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001986 'branch\\..*\\.gerritissue'], ),
1987 ('branch.ger-branch.gerritissue 123456\n'
1988 'branch.gbranch654.gerritissue 654321\n')),
1989 ]
1990
1991 def test_checkout_gerrit(self):
1992 """Tests git cl checkout <issue>."""
1993 self.calls = self._checkout_calls()
1994 self.calls += [((['git', 'checkout', 'ger-branch'], ), '')]
1995 self.assertEqual(0, git_cl.main(['checkout', '123456']))
1996
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001997 def test_checkout_not_found(self):
1998 """Tests git cl checkout <issue>."""
1999 self.calls = self._checkout_calls()
2000 self.assertEqual(1, git_cl.main(['checkout', '99999']))
2001
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00002002 def test_checkout_no_branch_issues(self):
2003 """Tests git cl checkout <issue>."""
2004 self.calls = [
2005 ((['git', 'config', '--local', '--get-regexp',
tandrii5d48c322016-08-18 16:19:37 -07002006 'branch\\..*\\.gerritissue'], ), CERR1),
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00002007 ]
2008 self.assertEqual(1, git_cl.main(['checkout', '99999']))
2009
Edward Lemur26964072020-02-19 19:18:51 +00002010 def _test_gerrit_ensure_authenticated_common(self, auth):
Edward Lemur1a83da12020-03-04 21:18:36 +00002011 mock.patch(
Edward Lesmesae3586b2020-03-23 21:21:14 +00002012 'gclient_utils.AskForData',
Edward Lemur1a83da12020-03-04 21:18:36 +00002013 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002014 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
2015 CookiesAuthenticatorMockFactory(hosts_with_creds=auth)).start()
Edward Lemur26964072020-02-19 19:18:51 +00002016 self.mockGit.config['remote.origin.url'] = (
2017 'https://chromium.googlesource.com/my/repo')
Edward Lemurf38bc172019-09-03 21:02:13 +00002018 cl = git_cl.Changelist()
tandrii@chromium.org28253532016-04-14 13:46:56 +00002019 cl.branch = 'master'
2020 cl.branchref = 'refs/heads/master'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002021 return cl
2022
Edward Lemurd55c5072020-02-20 01:09:07 +00002023 @mock.patch('sys.stderr', StringIO())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002024 def test_gerrit_ensure_authenticated_missing(self):
2025 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002026 'chromium.googlesource.com': ('git-is.ok', '', 'but gerrit is missing'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002027 })
Edward Lemurd55c5072020-02-20 01:09:07 +00002028 with self.assertRaises(SystemExitMock):
2029 cl.EnsureAuthenticated(force=False)
2030 self.assertEqual(
2031 'Credentials for the following hosts are required:\n'
2032 ' chromium-review.googlesource.com\n'
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002033 'These are read from ~%(sep)s.gitcookies '
2034 '(or legacy ~%(sep)s%(netrc)s)\n'
Edward Lemurd55c5072020-02-20 01:09:07 +00002035 'You can (re)generate your credentials by visiting '
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002036 'https://chromium-review.googlesource.com/new-password\n' % {
2037 'sep': os.sep,
2038 'netrc': NETRC_FILENAME,
2039 }, sys.stderr.getvalue())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002040
2041 def test_gerrit_ensure_authenticated_conflict(self):
2042 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002043 'chromium.googlesource.com':
2044 ('git-one.example.com', None, 'secret1'),
2045 'chromium-review.googlesource.com':
2046 ('git-other.example.com', None, 'secret2'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002047 })
2048 self.calls.append(
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002049 (('ask_for_data', 'If you know what you are doing '
2050 'press Enter to continue, or Ctrl+C to abort'), ''))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002051 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2052
2053 def test_gerrit_ensure_authenticated_ok(self):
2054 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002055 'chromium.googlesource.com':
2056 ('git-same.example.com', None, 'secret'),
2057 'chromium-review.googlesource.com':
2058 ('git-same.example.com', None, 'secret'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002059 })
2060 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2061
tandrii@chromium.org28253532016-04-14 13:46:56 +00002062 def test_gerrit_ensure_authenticated_skipped(self):
Edward Lemur26964072020-02-19 19:18:51 +00002063 self.mockGit.config['gerrit.skip-ensure-authenticated'] = 'true'
2064 cl = self._test_gerrit_ensure_authenticated_common(auth={})
tandrii@chromium.org28253532016-04-14 13:46:56 +00002065 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2066
Eric Boren2fb63102018-10-05 13:05:03 +00002067 def test_gerrit_ensure_authenticated_bearer_token(self):
2068 cl = self._test_gerrit_ensure_authenticated_common(auth={
2069 'chromium.googlesource.com':
2070 ('', None, 'secret'),
2071 'chromium-review.googlesource.com':
2072 ('', None, 'secret'),
2073 })
2074 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2075 header = gerrit_util.CookiesAuthenticator().get_auth_header(
2076 'chromium.googlesource.com')
2077 self.assertTrue('Bearer' in header)
2078
Daniel Chengcf6269b2019-05-18 01:02:12 +00002079 def test_gerrit_ensure_authenticated_non_https(self):
Edward Lemur26964072020-02-19 19:18:51 +00002080 self.mockGit.config['remote.origin.url'] = 'custom-scheme://repo'
Daniel Chengcf6269b2019-05-18 01:02:12 +00002081 self.calls = [
Josip906bfde2020-01-31 22:38:49 +00002082 (('logging.warning',
2083 'Ignoring branch %(branch)s with non-https remote '
2084 '%(remote)s', {
2085 'branch': 'master',
2086 'remote': 'custom-scheme://repo'}
2087 ), None),
Daniel Chengcf6269b2019-05-18 01:02:12 +00002088 ]
Edward Lemurda4b6c62020-02-13 00:28:40 +00002089 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
2090 CookiesAuthenticatorMockFactory(hosts_with_creds={})).start()
2091 mock.patch('logging.warning',
2092 lambda *a: self._mocked_call('logging.warning', *a)).start()
Edward Lemurf38bc172019-09-03 21:02:13 +00002093 cl = git_cl.Changelist()
Daniel Chengcf6269b2019-05-18 01:02:12 +00002094 cl.branch = 'master'
2095 cl.branchref = 'refs/heads/master'
2096 cl.lookedup_issue = True
2097 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2098
Florian Mayerae510e82020-01-30 21:04:48 +00002099 def test_gerrit_ensure_authenticated_non_url(self):
Edward Lemur26964072020-02-19 19:18:51 +00002100 self.mockGit.config['remote.origin.url'] = (
2101 'git@somehost.example:foo/bar.git')
Florian Mayerae510e82020-01-30 21:04:48 +00002102 self.calls = [
Josip906bfde2020-01-31 22:38:49 +00002103 (('logging.error',
2104 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
2105 'but it doesn\'t exist.', {
2106 'remote': 'origin',
2107 'branch': 'master',
2108 'url': 'git@somehost.example:foo/bar.git'}
2109 ), None),
Florian Mayerae510e82020-01-30 21:04:48 +00002110 ]
Edward Lemurda4b6c62020-02-13 00:28:40 +00002111 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
2112 CookiesAuthenticatorMockFactory(hosts_with_creds={})).start()
2113 mock.patch('logging.error',
2114 lambda *a: self._mocked_call('logging.error', *a)).start()
Florian Mayerae510e82020-01-30 21:04:48 +00002115 cl = git_cl.Changelist()
2116 cl.branch = 'master'
2117 cl.branchref = 'refs/heads/master'
2118 cl.lookedup_issue = True
2119 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2120
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002121 def _cmd_set_commit_gerrit_common(self, vote, notify=None):
Edward Lemur85153282020-02-14 22:06:29 +00002122 self.mockGit.config['branch.master.gerritissue'] = '123'
2123 self.mockGit.config['branch.master.gerritserver'] = (
2124 'https://chromium-review.googlesource.com')
Edward Lemur26964072020-02-19 19:18:51 +00002125 self.mockGit.config['remote.origin.url'] = (
2126 'https://chromium.googlesource.com/infra/infra')
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002127 self.calls = [
Edward Lemurda4b6c62020-02-13 00:28:40 +00002128 (('SetReview', 'chromium-review.googlesource.com',
2129 'infra%2Finfra~123', None,
2130 {'Commit-Queue': vote}, notify, None), ''),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002131 ]
tandriid9e5ce52016-07-13 02:32:59 -07002132
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00002133 def _cmd_set_quick_run_gerrit(self):
2134 self.mockGit.config['branch.master.gerritissue'] = '123'
2135 self.mockGit.config['branch.master.gerritserver'] = (
2136 'https://chromium-review.googlesource.com')
2137 self.mockGit.config['remote.origin.url'] = (
2138 'https://chromium.googlesource.com/infra/infra')
2139 self.calls = [
2140 (('SetReview', 'chromium-review.googlesource.com',
2141 'infra%2Finfra~123', None,
2142 {'Commit-Queue': 1, 'Quick-Run': 1}, None, None), ''),
2143 ]
2144
tandriid9e5ce52016-07-13 02:32:59 -07002145 def test_cmd_set_commit_gerrit_clear(self):
2146 self._cmd_set_commit_gerrit_common(0)
2147 self.assertEqual(0, git_cl.main(['set-commit', '-c']))
2148
2149 def test_cmd_set_commit_gerrit_dry(self):
Aaron Gable75e78722017-06-09 10:40:16 -07002150 self._cmd_set_commit_gerrit_common(1, notify=False)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002151 self.assertEqual(0, git_cl.main(['set-commit', '-d']))
2152
tandriid9e5ce52016-07-13 02:32:59 -07002153 def test_cmd_set_commit_gerrit(self):
2154 self._cmd_set_commit_gerrit_common(2)
2155 self.assertEqual(0, git_cl.main(['set-commit']))
2156
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00002157 def test_cmd_set_quick_run_gerrit(self):
2158 self._cmd_set_quick_run_gerrit()
2159 self.assertEqual(0, git_cl.main(['set-commit', '-q']))
2160
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002161 def test_description_display(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002162 mock.patch('git_cl.Changelist', ChangelistMock).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002163 ChangelistMock.desc = 'foo\n'
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002164
2165 self.assertEqual(0, git_cl.main(['description', '-d']))
Edward Lemurda4b6c62020-02-13 00:28:40 +00002166 self.assertEqual('foo\n', sys.stdout.getvalue())
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002167
Edward Lemurda4b6c62020-02-13 00:28:40 +00002168 @mock.patch('sys.stderr', StringIO())
iannucci3c972b92016-08-17 13:24:10 -07002169 def test_StatusFieldOverrideIssueMissingArgs(self):
iannucci3c972b92016-08-17 13:24:10 -07002170 try:
2171 self.assertEqual(git_cl.main(['status', '--issue', '1']), 0)
Edward Lemurd55c5072020-02-20 01:09:07 +00002172 except SystemExitMock:
Edward Lemur6c6827c2020-02-06 21:15:18 +00002173 self.assertIn(
Edward Lemurda4b6c62020-02-13 00:28:40 +00002174 '--field must be given when --issue is set.', sys.stderr.getvalue())
iannucci3c972b92016-08-17 13:24:10 -07002175
2176 def test_StatusFieldOverrideIssue(self):
iannucci3c972b92016-08-17 13:24:10 -07002177 def assertIssue(cl_self, *_args):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002178 self.assertEqual(cl_self.issue, 1)
iannucci3c972b92016-08-17 13:24:10 -07002179 return 'foobar'
2180
Edward Lemurda4b6c62020-02-13 00:28:40 +00002181 mock.patch('git_cl.Changelist.FetchDescription', assertIssue).start()
iannuccie53c9352016-08-17 14:40:40 -07002182 self.assertEqual(
Edward Lemur52969c92020-02-06 18:15:28 +00002183 git_cl.main(['status', '--issue', '1', '--field', 'desc']),
iannuccie53c9352016-08-17 14:40:40 -07002184 0)
Edward Lemurda4b6c62020-02-13 00:28:40 +00002185 self.assertEqual(sys.stdout.getvalue(), 'foobar\n')
iannucci3c972b92016-08-17 13:24:10 -07002186
iannuccie53c9352016-08-17 14:40:40 -07002187 def test_SetCloseOverrideIssue(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002188
iannuccie53c9352016-08-17 14:40:40 -07002189 def assertIssue(cl_self, *_args):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002190 self.assertEqual(cl_self.issue, 1)
iannuccie53c9352016-08-17 14:40:40 -07002191 return 'foobar'
2192
Edward Lemurda4b6c62020-02-13 00:28:40 +00002193 mock.patch('git_cl.Changelist.FetchDescription', assertIssue).start()
2194 mock.patch('git_cl.Changelist.CloseIssue', lambda *_: None).start()
iannuccie53c9352016-08-17 14:40:40 -07002195 self.assertEqual(
Edward Lemur52969c92020-02-06 18:15:28 +00002196 git_cl.main(['set-close', '--issue', '1']), 0)
iannuccie53c9352016-08-17 14:40:40 -07002197
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002198 def test_description(self):
Edward Lemur26964072020-02-19 19:18:51 +00002199 self.mockGit.config['remote.origin.url'] = (
2200 'https://chromium.googlesource.com/my/repo')
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002201 gerrit_util.GetChangeDetail.return_value = {
2202 'current_revision': 'sha1',
2203 'revisions': {'sha1': {
2204 'commit': {'message': 'foobar'},
2205 }},
2206 }
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002207 self.assertEqual(0, git_cl.main([
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002208 'description',
2209 'https://chromium-review.googlesource.com/c/my/repo/+/123123',
2210 '-d']))
Edward Lemurda4b6c62020-02-13 00:28:40 +00002211 self.assertEqual('foobar\n', sys.stdout.getvalue())
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002212
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002213 def test_description_set_raw(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002214 mock.patch('git_cl.Changelist', ChangelistMock).start()
2215 mock.patch('git_cl.sys.stdin', StringIO('hihi')).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002216
2217 self.assertEqual(0, git_cl.main(['description', '-n', 'hihi']))
2218 self.assertEqual('hihi', ChangelistMock.desc)
2219
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002220 def test_description_appends_bug_line(self):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002221 current_desc = 'Some.\n\nChange-Id: xxx'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002222
2223 def RunEditor(desc, _, **kwargs):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002224 self.assertEqual(
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002225 '# Enter a description of the change.\n'
2226 '# This will be displayed on the codereview site.\n'
2227 '# The first line will also be used as the subject of the review.\n'
2228 '#--------------------This line is 72 characters long'
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002229 '--------------------\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -07002230 'Some.\n\nChange-Id: xxx\nBug: ',
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002231 desc)
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002232 # Simulate user changing something.
Aaron Gable3a16ed12017-03-23 10:51:55 -07002233 return 'Some.\n\nChange-Id: xxx\nBug: 123'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002234
Edward Lemur6c6827c2020-02-06 21:15:18 +00002235 def UpdateDescription(_, desc, force=False):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002236 self.assertEqual(desc, 'Some.\n\nChange-Id: xxx\nBug: 123')
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002237
Edward Lemurda4b6c62020-02-13 00:28:40 +00002238 mock.patch('git_cl.Changelist.FetchDescription',
2239 lambda *args: current_desc).start()
2240 mock.patch('git_cl.Changelist.UpdateDescription',
2241 UpdateDescription).start()
2242 mock.patch('git_cl.gclient_utils.RunEditor', RunEditor).start()
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002243
Edward Lemur85153282020-02-14 22:06:29 +00002244 self.mockGit.config['branch.master.gerritissue'] = '123'
Edward Lemur52969c92020-02-06 18:15:28 +00002245 self.assertEqual(0, git_cl.main(['description']))
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002246
Dan Beamd8b04ca2019-10-10 21:23:26 +00002247 def test_description_does_not_append_bug_line_if_fixed_is_present(self):
2248 current_desc = 'Some.\n\nFixed: 123\nChange-Id: xxx'
2249
2250 def RunEditor(desc, _, **kwargs):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002251 self.assertEqual(
Dan Beamd8b04ca2019-10-10 21:23:26 +00002252 '# Enter a description of the change.\n'
2253 '# This will be displayed on the codereview site.\n'
2254 '# The first line will also be used as the subject of the review.\n'
2255 '#--------------------This line is 72 characters long'
2256 '--------------------\n'
2257 'Some.\n\nFixed: 123\nChange-Id: xxx',
2258 desc)
2259 return desc
2260
Edward Lemurda4b6c62020-02-13 00:28:40 +00002261 mock.patch('git_cl.Changelist.FetchDescription',
2262 lambda *args: current_desc).start()
2263 mock.patch('git_cl.gclient_utils.RunEditor', RunEditor).start()
Dan Beamd8b04ca2019-10-10 21:23:26 +00002264
Edward Lemur85153282020-02-14 22:06:29 +00002265 self.mockGit.config['branch.master.gerritissue'] = '123'
Edward Lemur52969c92020-02-06 18:15:28 +00002266 self.assertEqual(0, git_cl.main(['description']))
Dan Beamd8b04ca2019-10-10 21:23:26 +00002267
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002268 def test_description_set_stdin(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002269 mock.patch('git_cl.Changelist', ChangelistMock).start()
2270 mock.patch('git_cl.sys.stdin', StringIO('hi \r\n\t there\n\nman')).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002271
2272 self.assertEqual(0, git_cl.main(['description', '-n', '-']))
2273 self.assertEqual('hi\n\t there\n\nman', ChangelistMock.desc)
2274
kmarshall3bff56b2016-06-06 18:31:47 -07002275 def test_archive(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002276 self.calls = [
2277 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
Edward Lemurf38bc172019-09-03 21:02:13 +00002278 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002279 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002280 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],), ''),
Edward Lemurf38bc172019-09-03 21:02:13 +00002281 ((['git', 'branch', '-D', 'foo'],), '')
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002282 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002283
Edward Lemurda4b6c62020-02-13 00:28:40 +00002284 mock.patch('git_cl.get_cl_statuses',
kmarshall3bff56b2016-06-06 18:31:47 -07002285 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002286 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2287 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002288 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall3bff56b2016-06-06 18:31:47 -07002289
2290 self.assertEqual(0, git_cl.main(['archive', '-f']))
2291
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002292 def test_archive_tag_collision(self):
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002293 self.calls = [
2294 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2295 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2296 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],),
2297 'refs/tags/git-cl-archived-456-foo'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002298 ((['git', 'tag', 'git-cl-archived-456-foo-2', 'foo'],), ''),
2299 ((['git', 'branch', '-D', 'foo'],), '')
2300 ]
2301
Edward Lemurda4b6c62020-02-13 00:28:40 +00002302 mock.patch('git_cl.get_cl_statuses',
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002303 lambda branches, fine_grained, max_processes:
2304 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2305 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002306 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002307
2308 self.assertEqual(0, git_cl.main(['archive', '-f']))
2309
kmarshall3bff56b2016-06-06 18:31:47 -07002310 def test_archive_current_branch_fails(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002311 self.calls = [
2312 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2313 'refs/heads/master'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002314 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002315 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002316
Edward Lemurda4b6c62020-02-13 00:28:40 +00002317 mock.patch('git_cl.get_cl_statuses',
kmarshall9249e012016-08-23 12:02:16 -07002318 lambda branches, fine_grained, max_processes:
Edward Lemurda4b6c62020-02-13 00:28:40 +00002319 [(MockChangelistWithBranchAndIssue('master', 1),
2320 'closed')]).start()
kmarshall9249e012016-08-23 12:02:16 -07002321
2322 self.assertEqual(1, git_cl.main(['archive', '-f']))
2323
2324 def test_archive_dry_run(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002325 self.calls = [
2326 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2327 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002328 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002329 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002330
Edward Lemurda4b6c62020-02-13 00:28:40 +00002331 mock.patch('git_cl.get_cl_statuses',
kmarshall3bff56b2016-06-06 18:31:47 -07002332 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002333 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2334 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002335 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall3bff56b2016-06-06 18:31:47 -07002336
kmarshall9249e012016-08-23 12:02:16 -07002337 self.assertEqual(0, git_cl.main(['archive', '-f', '--dry-run']))
2338
2339 def test_archive_no_tags(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002340 self.calls = [
2341 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2342 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002343 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002344 ((['git', 'branch', '-D', 'foo'],), '')
2345 ]
kmarshall9249e012016-08-23 12:02:16 -07002346
Edward Lemurda4b6c62020-02-13 00:28:40 +00002347 mock.patch('git_cl.get_cl_statuses',
kmarshall9249e012016-08-23 12:02:16 -07002348 lambda branches, fine_grained, max_processes:
2349 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2350 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002351 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall9249e012016-08-23 12:02:16 -07002352
2353 self.assertEqual(0, git_cl.main(['archive', '-f', '--notags']))
kmarshall3bff56b2016-06-06 18:31:47 -07002354
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002355 def test_archive_tag_cleanup_on_branch_deletion_error(self):
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002356 self.calls = [
2357 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2358 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2359 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002360 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],),
2361 'refs/tags/git-cl-archived-456-foo'),
2362 ((['git', 'branch', '-D', 'foo'],), CERR1),
2363 ((['git', 'tag', '-d', 'git-cl-archived-456-foo'],),
2364 'refs/tags/git-cl-archived-456-foo'),
2365 ]
2366
Edward Lemurda4b6c62020-02-13 00:28:40 +00002367 mock.patch('git_cl.get_cl_statuses',
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002368 lambda branches, fine_grained, max_processes:
2369 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2370 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002371 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002372
2373 self.assertEqual(0, git_cl.main(['archive', '-f']))
2374
Tibor Goldschwendt7c5efb22020-03-25 01:23:54 +00002375 def test_archive_with_format(self):
2376 self.calls = [
2377 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'], ),
2378 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2379 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'], ), ''),
2380 ((['git', 'tag', 'archived/12-foo', 'foo'], ), ''),
2381 ((['git', 'branch', '-D', 'foo'], ), ''),
2382 ]
2383
2384 mock.patch('git_cl.get_cl_statuses',
2385 lambda branches, fine_grained, max_processes:
2386 [(MockChangelistWithBranchAndIssue('foo', 12), 'closed')]).start()
2387
2388 self.assertEqual(
2389 0, git_cl.main(['archive', '-f', '-p', 'archived/{issue}-{branch}']))
2390
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002391 def test_cmd_issue_erase_existing(self):
Edward Lemur85153282020-02-14 22:06:29 +00002392 self.mockGit.config['branch.master.gerritissue'] = '123'
2393 self.mockGit.config['branch.master.gerritserver'] = (
2394 'https://chromium-review.googlesource.com')
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002395 self.calls = [
Aaron Gableca01e2c2017-07-19 11:16:02 -07002396 ((['git', 'log', '-1', '--format=%B'],), 'This is a description'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002397 ]
2398 self.assertEqual(0, git_cl.main(['issue', '0']))
Edward Lemur85153282020-02-14 22:06:29 +00002399 self.assertNotIn('branch.master.gerritissue', self.mockGit.config)
2400 self.assertNotIn('branch.master.gerritserver', self.mockGit.config)
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002401
Aaron Gable400e9892017-07-12 15:31:21 -07002402 def test_cmd_issue_erase_existing_with_change_id(self):
Edward Lemur85153282020-02-14 22:06:29 +00002403 self.mockGit.config['branch.master.gerritissue'] = '123'
2404 self.mockGit.config['branch.master.gerritserver'] = (
2405 'https://chromium-review.googlesource.com')
Edward Lemurda4b6c62020-02-13 00:28:40 +00002406 mock.patch('git_cl.Changelist.FetchDescription',
2407 lambda _: 'This is a description\n\nChange-Id: Ideadbeef').start()
Aaron Gable400e9892017-07-12 15:31:21 -07002408 self.calls = [
Aaron Gableca01e2c2017-07-19 11:16:02 -07002409 ((['git', 'log', '-1', '--format=%B'],),
2410 'This is a description\n\nChange-Id: Ideadbeef'),
2411 ((['git', 'commit', '--amend', '-m', 'This is a description\n'],), ''),
Aaron Gable400e9892017-07-12 15:31:21 -07002412 ]
2413 self.assertEqual(0, git_cl.main(['issue', '0']))
Edward Lemur85153282020-02-14 22:06:29 +00002414 self.assertNotIn('branch.master.gerritissue', self.mockGit.config)
2415 self.assertNotIn('branch.master.gerritserver', self.mockGit.config)
Aaron Gable400e9892017-07-12 15:31:21 -07002416
phajdan.jre328cf92016-08-22 04:12:17 -07002417 def test_cmd_issue_json(self):
Edward Lemur85153282020-02-14 22:06:29 +00002418 self.mockGit.config['branch.master.gerritissue'] = '123'
2419 self.mockGit.config['branch.master.gerritserver'] = (
2420 'https://chromium-review.googlesource.com')
Nodir Turakulov27379632021-03-17 18:53:29 +00002421 self.mockGit.config['remote.origin.url'] = (
2422 'https://chromium.googlesource.com/chromium/src'
2423 )
2424 self.calls = [(
2425 (
2426 'write_json',
2427 'output.json',
2428 {
2429 'issue': 123,
2430 'issue_url': 'https://chromium-review.googlesource.com/123',
2431 'gerrit_host': 'chromium-review.googlesource.com',
2432 'gerrit_project': 'chromium/src',
2433 },
2434 ),
2435 '',
2436 )]
phajdan.jre328cf92016-08-22 04:12:17 -07002437 self.assertEqual(0, git_cl.main(['issue', '--json', 'output.json']))
2438
tandrii16e0b4e2016-06-07 10:34:28 -07002439 def _common_GerritCommitMsgHookCheck(self):
Edward Lemur15a9b8c2020-02-13 00:52:30 +00002440 mock.patch(
2441 'git_cl.os.path.abspath',
2442 lambda path: self._mocked_call(['abspath', path])).start()
2443 mock.patch(
2444 'git_cl.os.path.exists',
2445 lambda path: self._mocked_call(['exists', path])).start()
2446 mock.patch(
2447 'git_cl.gclient_utils.FileRead',
2448 lambda path: self._mocked_call(['FileRead', path])).start()
2449 mock.patch(
2450 'git_cl.gclient_utils.rm_file_or_tree',
2451 lambda path: self._mocked_call(['rm_file_or_tree', path])).start()
Edward Lemur1a83da12020-03-04 21:18:36 +00002452 mock.patch(
Edward Lesmesae3586b2020-03-23 21:21:14 +00002453 'gclient_utils.AskForData',
Edward Lemur1a83da12020-03-04 21:18:36 +00002454 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
Edward Lemurf38bc172019-09-03 21:02:13 +00002455 return git_cl.Changelist(issue=123)
tandrii16e0b4e2016-06-07 10:34:28 -07002456
2457 def test_GerritCommitMsgHookCheck_custom_hook(self):
2458 cl = self._common_GerritCommitMsgHookCheck()
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002459 self.calls += [((['exists',
2460 os.path.join('.git', 'hooks', 'commit-msg')], ), True),
2461 ((['FileRead',
2462 os.path.join('.git', 'hooks', 'commit-msg')], ),
2463 '#!/bin/sh\necho "custom hook"')]
Edward Lemur125d60a2019-09-13 18:25:41 +00002464 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002465
2466 def test_GerritCommitMsgHookCheck_not_exists(self):
2467 cl = self._common_GerritCommitMsgHookCheck()
2468 self.calls += [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002469 ((['exists', os.path.join('.git', 'hooks', 'commit-msg')], ), False),
tandrii16e0b4e2016-06-07 10:34:28 -07002470 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002471 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002472
2473 def test_GerritCommitMsgHookCheck(self):
2474 cl = self._common_GerritCommitMsgHookCheck()
2475 self.calls += [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002476 ((['exists', os.path.join('.git', 'hooks', 'commit-msg')], ), True),
2477 ((['FileRead', os.path.join('.git', 'hooks', 'commit-msg')], ),
tandrii16e0b4e2016-06-07 10:34:28 -07002478 '...\n# From Gerrit Code Review\n...\nadd_ChangeId()\n'),
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002479 (('ask_for_data', 'Do you want to remove it now? [Yes/No]: '), 'Yes'),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002480 ((['rm_file_or_tree',
2481 os.path.join('.git', 'hooks', 'commit-msg')], ), ''),
tandrii16e0b4e2016-06-07 10:34:28 -07002482 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002483 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002484
tandriic4344b52016-08-29 06:04:54 -07002485 def test_GerritCmdLand(self):
Edward Lemur85153282020-02-14 22:06:29 +00002486 self.mockGit.config['branch.master.gerritsquashhash'] = 'deadbeaf'
2487 self.mockGit.config['branch.master.gerritserver'] = (
2488 'chromium-review.googlesource.com')
tandriic4344b52016-08-29 06:04:54 -07002489 self.calls += [
tandriic4344b52016-08-29 06:04:54 -07002490 ((['git', 'diff', 'deadbeaf'],), ''), # No diff.
tandriic4344b52016-08-29 06:04:54 -07002491 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002492 cl = git_cl.Changelist(issue=123)
Edward Lemur125d60a2019-09-13 18:25:41 +00002493 cl._GetChangeDetail = lambda *args, **kwargs: {
tandriic4344b52016-08-29 06:04:54 -07002494 'labels': {},
2495 'current_revision': 'deadbeaf',
2496 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002497 cl._GetChangeCommit = lambda: {
agable32978d92016-11-01 12:55:02 -07002498 'commit': 'deadbeef',
Aaron Gable02cdbb42016-12-13 16:24:25 -08002499 'web_links': [{'name': 'gitiles',
agable32978d92016-11-01 12:55:02 -07002500 'url': 'https://git.googlesource.com/test/+/deadbeef'}],
2501 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002502 cl.SubmitIssue = lambda wait_for_merge: None
Olivier Robin75ee7252018-04-13 10:02:56 +02002503 self.assertEqual(0, cl.CMDLand(force=True,
2504 bypass_hooks=True,
2505 verbose=True,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00002506 parallel=False,
2507 resultdb=False,
2508 realm=None))
Edward Lemur73c76702020-02-06 23:57:18 +00002509 self.assertIn(
2510 'Issue chromium-review.googlesource.com/123 has been submitted',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002511 sys.stdout.getvalue())
Edward Lemur73c76702020-02-06 23:57:18 +00002512 self.assertIn(
2513 'Landed as: https://git.googlesource.com/test/+/deadbeef',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002514 sys.stdout.getvalue())
tandriic4344b52016-08-29 06:04:54 -07002515
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002516 def _mock_gerrit_changes_for_detail_cache(self):
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002517 mock.patch('git_cl.Changelist.GetGerritHost', lambda _: 'host').start()
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002518
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002519 def test_gerrit_change_detail_cache_simple(self):
2520 self._mock_gerrit_changes_for_detail_cache()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002521 gerrit_util.GetChangeDetail.side_effect = ['a', 'b']
Edward Lemurf38bc172019-09-03 21:02:13 +00002522 cl1 = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002523 cl1._cached_remote_url = (
2524 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemurf38bc172019-09-03 21:02:13 +00002525 cl2 = git_cl.Changelist(issue=2)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002526 cl2._cached_remote_url = (
2527 True, 'https://chromium.googlesource.com/ab/repo')
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002528 self.assertEqual(cl1._GetChangeDetail(), 'a') # Miss.
2529 self.assertEqual(cl1._GetChangeDetail(), 'a')
2530 self.assertEqual(cl2._GetChangeDetail(), 'b') # Miss.
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002531
2532 def test_gerrit_change_detail_cache_options(self):
2533 self._mock_gerrit_changes_for_detail_cache()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002534 gerrit_util.GetChangeDetail.side_effect = ['cab', 'ad']
Edward Lemurf38bc172019-09-03 21:02:13 +00002535 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002536 cl._cached_remote_url = (True, 'https://chromium.googlesource.com/repo/')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002537 self.assertEqual(cl._GetChangeDetail(options=['C', 'A', 'B']), 'cab')
2538 self.assertEqual(cl._GetChangeDetail(options=['A', 'B', 'C']), 'cab')
2539 self.assertEqual(cl._GetChangeDetail(options=['B', 'A']), 'cab')
2540 self.assertEqual(cl._GetChangeDetail(options=['C']), 'cab')
2541 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2542 self.assertEqual(cl._GetChangeDetail(), 'cab')
2543
2544 self.assertEqual(cl._GetChangeDetail(options=['A', 'D']), 'ad')
2545 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2546 self.assertEqual(cl._GetChangeDetail(options=['D']), 'ad')
2547 self.assertEqual(cl._GetChangeDetail(), 'cab')
2548
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002549 def test_gerrit_description_caching(self):
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002550 gerrit_util.GetChangeDetail.return_value = {
2551 'current_revision': 'rev1',
2552 'revisions': {
2553 'rev1': {'commit': {'message': 'desc1'}},
2554 },
2555 }
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002556
2557 self._mock_gerrit_changes_for_detail_cache()
Edward Lemurf38bc172019-09-03 21:02:13 +00002558 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002559 cl._cached_remote_url = (
2560 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemur6c6827c2020-02-06 21:15:18 +00002561 self.assertEqual(cl.FetchDescription(), 'desc1')
2562 self.assertEqual(cl.FetchDescription(), 'desc1') # cache hit.
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002563
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002564 def test_print_current_creds(self):
2565 class CookiesAuthenticatorMock(object):
2566 def __init__(self):
2567 self.gitcookies = {
2568 'host.googlesource.com': ('user', 'pass'),
2569 'host-review.googlesource.com': ('user', 'pass'),
2570 }
2571 self.netrc = self
2572 self.netrc.hosts = {
2573 'github.com': ('user2', None, 'pass2'),
2574 'host2.googlesource.com': ('user3', None, 'pass'),
2575 }
Edward Lemurda4b6c62020-02-13 00:28:40 +00002576 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
2577 CookiesAuthenticatorMock).start()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002578 git_cl._GitCookiesChecker().print_current_creds(include_netrc=True)
2579 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2580 ' Host\t User\t Which file',
2581 '============================\t=====\t===========',
2582 'host-review.googlesource.com\t user\t.gitcookies',
2583 ' host.googlesource.com\t user\t.gitcookies',
2584 ' host2.googlesource.com\tuser3\t .netrc',
2585 ])
Edward Lemur79d4f992019-11-11 23:49:02 +00002586 sys.stdout.seek(0)
2587 sys.stdout.truncate(0)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002588 git_cl._GitCookiesChecker().print_current_creds(include_netrc=False)
2589 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2590 ' Host\tUser\t Which file',
2591 '============================\t====\t===========',
2592 'host-review.googlesource.com\tuser\t.gitcookies',
2593 ' host.googlesource.com\tuser\t.gitcookies',
2594 ])
2595
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002596 def _common_creds_check_mocks(self):
2597 def exists_mock(path):
2598 dirname = os.path.dirname(path)
2599 if dirname == os.path.expanduser('~'):
2600 dirname = '~'
2601 base = os.path.basename(path)
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002602 if base in (NETRC_FILENAME, '.gitcookies'):
2603 return self._mocked_call('os.path.exists', os.path.join(dirname, base))
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002604 # git cl also checks for existence other files not relevant to this test.
2605 return None
Edward Lemur1a83da12020-03-04 21:18:36 +00002606 mock.patch(
Edward Lesmesae3586b2020-03-23 21:21:14 +00002607 'gclient_utils.AskForData',
Edward Lemur1a83da12020-03-04 21:18:36 +00002608 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002609 mock.patch('os.path.exists', exists_mock).start()
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002610
2611 def test_creds_check_gitcookies_not_configured(self):
2612 self._common_creds_check_mocks()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002613 mock.patch('git_cl._GitCookiesChecker.get_hosts_with_creds',
2614 lambda _, include_netrc=False: []).start()
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002615 self.calls = [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002616 ((['git', 'config', '--path', 'http.cookiefile'], ), CERR1),
2617 ((['git', 'config', '--global', 'http.cookiefile'], ), CERR1),
2618 (('os.path.exists', os.path.join('~', NETRC_FILENAME)), True),
2619 (('ask_for_data', 'Press Enter to setup .gitcookies, '
2620 'or Ctrl+C to abort'), ''),
2621 (([
2622 'git', 'config', '--global', 'http.cookiefile',
2623 os.path.expanduser(os.path.join('~', '.gitcookies'))
2624 ], ), ''),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002625 ]
2626 self.assertEqual(0, git_cl.main(['creds-check']))
Edward Lemur73c76702020-02-06 23:57:18 +00002627 self.assertTrue(
2628 sys.stdout.getvalue().startswith(
2629 'You seem to be using outdated .netrc for git credentials:'))
2630 self.assertIn(
2631 '\nConfigured git to use .gitcookies from',
2632 sys.stdout.getvalue())
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002633
2634 def test_creds_check_gitcookies_configured_custom_broken(self):
2635 self._common_creds_check_mocks()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002636 mock.patch('git_cl._GitCookiesChecker.get_hosts_with_creds',
2637 lambda _, include_netrc=False: []).start()
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002638 custom_cookie_path = ('C:\\.gitcookies'
2639 if sys.platform == 'win32' else '/custom/.gitcookies')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002640 self.calls = [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002641 ((['git', 'config', '--path', 'http.cookiefile'], ), CERR1),
2642 ((['git', 'config', '--global', 'http.cookiefile'], ),
2643 custom_cookie_path),
2644 (('os.path.exists', custom_cookie_path), False),
2645 (('ask_for_data', 'Reconfigure git to use default .gitcookies? '
2646 'Press Enter to reconfigure, or Ctrl+C to abort'), ''),
2647 (([
2648 'git', 'config', '--global', 'http.cookiefile',
2649 os.path.expanduser(os.path.join('~', '.gitcookies'))
2650 ], ), ''),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002651 ]
2652 self.assertEqual(0, git_cl.main(['creds-check']))
Edward Lemur73c76702020-02-06 23:57:18 +00002653 self.assertIn(
2654 'WARNING: You have configured custom path to .gitcookies: ',
2655 sys.stdout.getvalue())
2656 self.assertIn(
2657 'However, your configured .gitcookies file is missing.',
2658 sys.stdout.getvalue())
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002659
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002660 def test_git_cl_comment_add_gerrit(self):
Edward Lemur85153282020-02-14 22:06:29 +00002661 self.mockGit.branchref = None
Edward Lemur26964072020-02-19 19:18:51 +00002662 self.mockGit.config['remote.origin.url'] = (
2663 'https://chromium.googlesource.com/infra/infra')
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002664 self.calls = [
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002665 (('SetReview', 'chromium-review.googlesource.com', 'infra%2Finfra~10',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002666 'msg', None, None, None),
Aaron Gable636b13f2017-07-14 10:42:48 -07002667 None),
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002668 ]
Edward Lemur52969c92020-02-06 18:15:28 +00002669 self.assertEqual(0, git_cl.main(['comment', '-i', '10', '-a', 'msg']))
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002670
Edward Lemurda4b6c62020-02-13 00:28:40 +00002671 @mock.patch('git_cl.Changelist.GetBranch', return_value='foo')
2672 def test_git_cl_comments_fetch_gerrit(self, *_mocks):
Edward Lemur26964072020-02-19 19:18:51 +00002673 self.mockGit.config['remote.origin.url'] = (
2674 'https://chromium.googlesource.com/infra/infra')
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002675 gerrit_util.GetChangeDetail.return_value = {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002676 'owner': {'email': 'owner@example.com'},
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002677 'current_revision': 'ba5eba11',
2678 'revisions': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002679 'deadbeaf': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002680 '_number': 1,
2681 },
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002682 'ba5eba11': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002683 '_number': 2,
2684 },
2685 },
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002686 'messages': [
2687 {
2688 u'_revision_number': 1,
2689 u'author': {
2690 u'_account_id': 1111084,
Andrii Shyshkalov8aa9d622020-03-10 19:15:35 +00002691 u'email': u'could-be-anything@example.com',
2692 u'name': u'LUCI CQ'
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002693 },
2694 u'date': u'2017-03-15 20:08:45.000000000',
2695 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
Dirk Prankef6a58802017-10-17 12:49:42 -07002696 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
Andrii Shyshkalov899785a2021-07-09 12:45:37 +00002697 u'tag': u'autogenerated:cv:dry-run'
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002698 },
2699 {
2700 u'_revision_number': 2,
2701 u'author': {
2702 u'_account_id': 11151243,
2703 u'email': u'owner@example.com',
2704 u'name': u'owner'
2705 },
2706 u'date': u'2017-03-16 20:00:41.000000000',
2707 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2708 u'message': u'PTAL',
2709 },
2710 {
2711 u'_revision_number': 2,
2712 u'author': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002713 u'_account_id': 148512,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002714 u'email': u'reviewer@example.com',
2715 u'name': u'reviewer'
2716 },
2717 u'date': u'2017-03-17 05:19:37.500000000',
2718 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2719 u'message': u'Patch Set 2: Code-Review+1',
2720 },
2721 ]
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002722 }
2723 self.calls = [
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002724 (('GetChangeComments', 'chromium-review.googlesource.com',
2725 'infra%2Finfra~1'), {
2726 '/COMMIT_MSG': [
2727 {
2728 'author': {
2729 'email': u'reviewer@example.com'
2730 },
2731 'updated': u'2017-03-17 05:19:37.500000000',
2732 'patch_set': 2,
2733 'side': 'REVISION',
2734 'message': 'Please include a bug link',
2735 },
2736 ],
2737 'codereview.settings': [
2738 {
2739 'author': {
2740 'email': u'owner@example.com'
2741 },
2742 'updated': u'2017-03-16 20:00:41.000000000',
2743 'patch_set': 2,
2744 'side': 'PARENT',
2745 'line': 42,
2746 'message': 'I removed this because it is bad',
2747 },
2748 ]
2749 }),
2750 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
2751 'infra%2Finfra~1'), {}),
2752 ] * 2 + [(('write_json', 'output.json', [{
2753 u'date':
2754 u'2017-03-16 20:00:41.000000',
2755 u'message': (u'PTAL\n' + u'\n' + u'codereview.settings\n' +
2756 u' Base, Line 42: https://crrev.com/c/1/2/'
2757 u'codereview.settings#b42\n' +
2758 u' I removed this because it is bad\n'),
2759 u'autogenerated':
2760 False,
2761 u'approval':
2762 False,
2763 u'disapproval':
2764 False,
2765 u'sender':
2766 u'owner@example.com'
2767 }, {
2768 u'date':
2769 u'2017-03-17 05:19:37.500000',
2770 u'message':
2771 (u'Patch Set 2: Code-Review+1\n' + u'\n' + u'/COMMIT_MSG\n' +
2772 u' PS2, File comment: https://crrev.com/c/1/2//COMMIT_MSG#\n' +
2773 u' Please include a bug link\n'),
2774 u'autogenerated':
2775 False,
2776 u'approval':
2777 False,
2778 u'disapproval':
2779 False,
2780 u'sender':
2781 u'reviewer@example.com'
2782 }]), '')]
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002783 expected_comments_summary = [
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002784 git_cl._CommentSummary(
2785 message=(u'PTAL\n' + u'\n' + u'codereview.settings\n' +
2786 u' Base, Line 42: https://crrev.com/c/1/2/' +
2787 u'codereview.settings#b42\n' +
2788 u' I removed this because it is bad\n'),
2789 date=datetime.datetime(2017, 3, 16, 20, 0, 41, 0),
2790 autogenerated=False,
2791 disapproval=False,
2792 approval=False,
2793 sender=u'owner@example.com'),
2794 git_cl._CommentSummary(message=(
2795 u'Patch Set 2: Code-Review+1\n' + u'\n' + u'/COMMIT_MSG\n' +
2796 u' PS2, File comment: https://crrev.com/c/1/2//COMMIT_MSG#\n' +
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002797 u' Please include a bug link\n'),
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002798 date=datetime.datetime(2017, 3, 17, 5, 19, 37,
2799 500000),
2800 autogenerated=False,
2801 disapproval=False,
2802 approval=False,
2803 sender=u'reviewer@example.com'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002804 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002805 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00002806 issue=1, branchref='refs/heads/foo')
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002807 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002808 self.assertEqual(
2809 0, git_cl.main(['comments', '-i', '1', '-j', 'output.json']))
2810
2811 def test_git_cl_comments_robot_comments(self):
2812 # git cl comments also fetches robot comments (which are considered a type
2813 # of autogenerated comment), and unlike other types of comments, only robot
2814 # comments from the latest patchset are shown.
Edward Lemur26964072020-02-19 19:18:51 +00002815 self.mockGit.config['remote.origin.url'] = (
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002816 'https://x.googlesource.com/infra/infra')
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002817 gerrit_util.GetChangeDetail.return_value = {
2818 'owner': {'email': 'owner@example.com'},
2819 'current_revision': 'ba5eba11',
2820 'revisions': {
2821 'deadbeaf': {
2822 '_number': 1,
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002823 },
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002824 'ba5eba11': {
2825 '_number': 2,
2826 },
2827 },
2828 'messages': [
2829 {
2830 u'_revision_number': 1,
2831 u'author': {
2832 u'_account_id': 1111084,
2833 u'email': u'commit-bot@chromium.org',
2834 u'name': u'Commit Bot'
2835 },
2836 u'date': u'2017-03-15 20:08:45.000000000',
2837 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
2838 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
2839 u'tag': u'autogenerated:cq:dry-run'
2840 },
2841 {
2842 u'_revision_number': 1,
2843 u'author': {
2844 u'_account_id': 123,
2845 u'email': u'tricium@serviceaccount.com',
2846 u'name': u'Tricium'
2847 },
2848 u'date': u'2017-03-16 20:00:41.000000000',
2849 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2850 u'message': u'(1 comment)',
2851 u'tag': u'autogenerated:tricium',
2852 },
2853 {
2854 u'_revision_number': 1,
2855 u'author': {
2856 u'_account_id': 123,
2857 u'email': u'tricium@serviceaccount.com',
2858 u'name': u'Tricium'
2859 },
2860 u'date': u'2017-03-16 20:00:41.000000000',
2861 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2862 u'message': u'(1 comment)',
2863 u'tag': u'autogenerated:tricium',
2864 },
2865 {
2866 u'_revision_number': 2,
2867 u'author': {
2868 u'_account_id': 123,
2869 u'email': u'tricium@serviceaccount.com',
2870 u'name': u'reviewer'
2871 },
2872 u'date': u'2017-03-17 05:30:37.000000000',
2873 u'tag': u'autogenerated:tricium',
2874 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2875 u'message': u'(1 comment)',
2876 },
2877 ]
2878 }
2879 self.calls = [
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002880 (('GetChangeComments', 'x-review.googlesource.com', 'infra%2Finfra~1'),
2881 {}),
2882 (('GetChangeRobotComments', 'x-review.googlesource.com',
2883 'infra%2Finfra~1'), {
2884 'codereview.settings': [
2885 {
2886 u'author': {
2887 u'email': u'tricium@serviceaccount.com'
2888 },
2889 u'updated': u'2017-03-17 05:30:37.000000000',
2890 u'robot_run_id': u'5565031076855808',
2891 u'robot_id': u'Linter/Category',
2892 u'tag': u'autogenerated:tricium',
2893 u'patch_set': 2,
2894 u'side': u'REVISION',
2895 u'message': u'Linter warning message text',
2896 u'line': 32,
2897 },
2898 ],
2899 }),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002900 ]
2901 expected_comments_summary = [
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002902 git_cl._CommentSummary(
2903 date=datetime.datetime(2017, 3, 17, 5, 30, 37),
2904 message=(u'(1 comment)\n\ncodereview.settings\n'
2905 u' PS2, Line 32: https://x-review.googlesource.com/c/1/2/'
2906 u'codereview.settings#32\n'
2907 u' Linter warning message text\n'),
2908 sender=u'tricium@serviceaccount.com',
2909 autogenerated=True,
2910 approval=False,
2911 disapproval=False)
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002912 ]
2913 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00002914 issue=1, branchref='refs/heads/foo')
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002915 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002916
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002917 def test_get_remote_url_with_mirror(self):
2918 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002919
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002920 def selective_os_path_isdir_mock(path):
2921 if path == '/cache/this-dir-exists':
2922 return self._mocked_call('os.path.isdir', path)
2923 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002924
Edward Lemurda4b6c62020-02-13 00:28:40 +00002925 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002926
2927 url = 'https://chromium.googlesource.com/my/repo'
Edward Lemur26964072020-02-19 19:18:51 +00002928 self.mockGit.config['remote.origin.url'] = (
2929 '/cache/this-dir-exists')
2930 self.mockGit.config['/cache/this-dir-exists:remote.origin.url'] = (
2931 url)
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002932 self.calls = [
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002933 (('os.path.isdir', '/cache/this-dir-exists'),
2934 True),
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002935 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002936 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002937 self.assertEqual(cl.GetRemoteUrl(), url)
2938 self.assertEqual(cl.GetRemoteUrl(), url) # Must be cached.
2939
Edward Lemur298f2cf2019-02-22 21:40:39 +00002940 def test_get_remote_url_non_existing_mirror(self):
2941 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002942
Edward Lemur298f2cf2019-02-22 21:40:39 +00002943 def selective_os_path_isdir_mock(path):
2944 if path == '/cache/this-dir-doesnt-exist':
2945 return self._mocked_call('os.path.isdir', path)
2946 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002947
Edward Lemurda4b6c62020-02-13 00:28:40 +00002948 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
2949 mock.patch('logging.error',
2950 lambda *a: self._mocked_call('logging.error', *a)).start()
Edward Lemur298f2cf2019-02-22 21:40:39 +00002951
Edward Lemur26964072020-02-19 19:18:51 +00002952 self.mockGit.config['remote.origin.url'] = (
2953 '/cache/this-dir-doesnt-exist')
Edward Lemur298f2cf2019-02-22 21:40:39 +00002954 self.calls = [
Edward Lemur298f2cf2019-02-22 21:40:39 +00002955 (('os.path.isdir', '/cache/this-dir-doesnt-exist'),
2956 False),
2957 (('logging.error',
Josip906bfde2020-01-31 22:38:49 +00002958 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
2959 'but it doesn\'t exist.', {
2960 'remote': 'origin',
2961 'branch': 'master',
2962 'url': '/cache/this-dir-doesnt-exist'}
2963 ), None),
Edward Lemur298f2cf2019-02-22 21:40:39 +00002964 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002965 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00002966 self.assertIsNone(cl.GetRemoteUrl())
2967
2968 def test_get_remote_url_misconfigured_mirror(self):
2969 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002970
Edward Lemur298f2cf2019-02-22 21:40:39 +00002971 def selective_os_path_isdir_mock(path):
2972 if path == '/cache/this-dir-exists':
2973 return self._mocked_call('os.path.isdir', path)
2974 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002975
Edward Lemurda4b6c62020-02-13 00:28:40 +00002976 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
2977 mock.patch('logging.error',
2978 lambda *a: self._mocked_call('logging.error', *a)).start()
Edward Lemur298f2cf2019-02-22 21:40:39 +00002979
Edward Lemur26964072020-02-19 19:18:51 +00002980 self.mockGit.config['remote.origin.url'] = (
2981 '/cache/this-dir-exists')
Edward Lemur298f2cf2019-02-22 21:40:39 +00002982 self.calls = [
Edward Lemur298f2cf2019-02-22 21:40:39 +00002983 (('os.path.isdir', '/cache/this-dir-exists'), True),
Edward Lemur298f2cf2019-02-22 21:40:39 +00002984 (('logging.error',
2985 'Remote "%(remote)s" for branch "%(branch)s" points to '
2986 '"%(cache_path)s", but it is misconfigured.\n'
2987 '"%(cache_path)s" must be a git repo and must have a remote named '
2988 '"%(remote)s" pointing to the git host.', {
2989 'remote': 'origin',
2990 'cache_path': '/cache/this-dir-exists',
2991 'branch': 'master'}
2992 ), None),
2993 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002994 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00002995 self.assertIsNone(cl.GetRemoteUrl())
2996
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002997 def test_gerrit_change_identifier_with_project(self):
Edward Lemur26964072020-02-19 19:18:51 +00002998 self.mockGit.config['remote.origin.url'] = (
2999 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemurf38bc172019-09-03 21:02:13 +00003000 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003001 self.assertEqual(cl._GerritChangeIdentifier(), 'my%2Frepo~123456')
3002
3003 def test_gerrit_change_identifier_without_project(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00003004 mock.patch('logging.error',
3005 lambda *a: self._mocked_call('logging.error', *a)).start()
Josip906bfde2020-01-31 22:38:49 +00003006
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003007 self.calls = [
Josip906bfde2020-01-31 22:38:49 +00003008 (('logging.error',
3009 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
3010 'but it doesn\'t exist.', {
3011 'remote': 'origin',
3012 'branch': 'master',
3013 'url': ''}
3014 ), None),
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003015 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00003016 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003017 self.assertEqual(cl._GerritChangeIdentifier(), '123456')
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00003018
Josip Sokcevicc39ab992020-09-24 20:09:15 +00003019 def test_gerrit_new_default(self):
3020 self._run_gerrit_upload_test(
3021 [],
3022 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
3023 [],
3024 squash=False,
3025 squash_mode='override_nosquash',
3026 change_id='I123456789',
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00003027 default_branch='main')
Josip Sokcevicc39ab992020-09-24 20:09:15 +00003028
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003029
Edward Lemur9aa1a962020-02-25 00:58:38 +00003030class ChangelistTest(unittest.TestCase):
mlcui3da91712021-05-05 10:00:30 +00003031 LAST_COMMIT_SUBJECT = 'Fixes goat teleporter destination to be Australia'
3032
3033 def _mock_run_git(commands):
3034 if commands == ['show', '-s', '--format=%s', 'HEAD']:
3035 return ChangelistTest.LAST_COMMIT_SUBJECT
3036
Edward Lemur227d5102020-02-25 23:45:35 +00003037 def setUp(self):
3038 super(ChangelistTest, self).setUp()
3039 mock.patch('gclient_utils.FileRead').start()
3040 mock.patch('gclient_utils.FileWrite').start()
3041 mock.patch('gclient_utils.temporary_file', TemporaryFileMock()).start()
3042 mock.patch(
3043 'git_cl.Changelist.GetCodereviewServer',
3044 return_value='https://chromium-review.googlesource.com').start()
3045 mock.patch('git_cl.Changelist.GetAuthor', return_value='author').start()
3046 mock.patch('git_cl.Changelist.GetIssue', return_value=123456).start()
3047 mock.patch('git_cl.Changelist.GetPatchset', return_value=7).start()
Dirk Pranke6f0df682021-06-25 00:42:33 +00003048 mock.patch('git_cl.Changelist.GetUsePython3', return_value=False).start()
Edward Lesmeseb1bd622021-03-01 19:54:07 +00003049 mock.patch(
3050 'git_cl.Changelist.GetRemoteBranch',
3051 return_value=('origin', 'refs/remotes/origin/main')).start()
Edward Lemur227d5102020-02-25 23:45:35 +00003052 mock.patch('git_cl.PRESUBMIT_SUPPORT', 'PRESUBMIT_SUPPORT').start()
3053 mock.patch('git_cl.Settings.GetRoot', return_value='root').start()
3054 mock.patch('git_cl.time_time').start()
3055 mock.patch('metrics.collector').start()
3056 mock.patch('subprocess2.Popen').start()
Edward Lesmeseb1bd622021-03-01 19:54:07 +00003057 mock.patch(
3058 'git_cl.Changelist.GetGerritProject', return_value='project').start()
Edward Lemur227d5102020-02-25 23:45:35 +00003059 self.addCleanup(mock.patch.stopall)
3060 self.temp_count = 0
3061
Edward Lemur227d5102020-02-25 23:45:35 +00003062 def testRunHook(self):
3063 expected_results = {
Dirk Pranke61bf6e82021-04-23 00:50:21 +00003064 'more_cc': ['cc@example.com', 'more@example.com'],
3065 'errors': [],
3066 'notifications': [],
3067 'warnings': [],
Edward Lemur227d5102020-02-25 23:45:35 +00003068 }
3069 gclient_utils.FileRead.return_value = json.dumps(expected_results)
Dirk Pranke61bf6e82021-04-23 00:50:21 +00003070 git_cl.time_time.side_effect = [100, 200, 300, 400]
Edward Lemur227d5102020-02-25 23:45:35 +00003071 mockProcess = mock.Mock()
3072 mockProcess.wait.return_value = 0
3073 subprocess2.Popen.return_value = mockProcess
3074
3075 cl = git_cl.Changelist()
3076 results = cl.RunHook(
3077 committing=True,
3078 may_prompt=True,
3079 verbose=2,
3080 parallel=True,
3081 upstream='upstream',
3082 description='description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003083 all_files=True,
3084 resultdb=False)
Edward Lemur227d5102020-02-25 23:45:35 +00003085
3086 self.assertEqual(expected_results, results)
Dirk Pranke61bf6e82021-04-23 00:50:21 +00003087 subprocess2.Popen.assert_any_call([
Edward Lemur227d5102020-02-25 23:45:35 +00003088 'vpython', 'PRESUBMIT_SUPPORT',
Edward Lemur227d5102020-02-25 23:45:35 +00003089 '--root', 'root',
3090 '--upstream', 'upstream',
3091 '--verbose', '--verbose',
Edward Lemur99df04e2020-03-05 19:39:43 +00003092 '--gerrit_url', 'https://chromium-review.googlesource.com',
Edward Lesmeseb1bd622021-03-01 19:54:07 +00003093 '--gerrit_project', 'project',
3094 '--gerrit_branch', 'refs/heads/main',
3095 '--author', 'author',
Edward Lemur227d5102020-02-25 23:45:35 +00003096 '--issue', '123456',
3097 '--patchset', '7',
Edward Lemur75526302020-02-27 22:31:05 +00003098 '--commit',
Edward Lemur227d5102020-02-25 23:45:35 +00003099 '--may_prompt',
3100 '--parallel',
3101 '--all_files',
3102 '--json_output', '/tmp/fake-temp2',
3103 '--description_file', '/tmp/fake-temp1',
3104 ])
Dirk Pranke61bf6e82021-04-23 00:50:21 +00003105 subprocess2.Popen.assert_any_call([
3106 'vpython3', 'PRESUBMIT_SUPPORT',
3107 '--root', 'root',
3108 '--upstream', 'upstream',
3109 '--verbose', '--verbose',
3110 '--gerrit_url', 'https://chromium-review.googlesource.com',
3111 '--gerrit_project', 'project',
3112 '--gerrit_branch', 'refs/heads/main',
3113 '--author', 'author',
3114 '--issue', '123456',
3115 '--patchset', '7',
3116 '--commit',
3117 '--may_prompt',
3118 '--parallel',
3119 '--all_files',
3120 '--json_output', '/tmp/fake-temp4',
3121 '--description_file', '/tmp/fake-temp3',
3122 ])
3123 gclient_utils.FileWrite.assert_any_call(
Edward Lemur1a83da12020-03-04 21:18:36 +00003124 '/tmp/fake-temp1', 'description')
Edward Lemur227d5102020-02-25 23:45:35 +00003125 metrics.collector.add_repeated('sub_commands', {
3126 'command': 'presubmit',
3127 'execution_time': 100,
3128 'exit_code': 0,
3129 })
3130
Edward Lemur99df04e2020-03-05 19:39:43 +00003131 def testRunHook_FewerOptions(self):
3132 expected_results = {
Dirk Pranke61bf6e82021-04-23 00:50:21 +00003133 'more_cc': ['cc@example.com', 'more@example.com'],
3134 'errors': [],
3135 'notifications': [],
3136 'warnings': [],
Edward Lemur99df04e2020-03-05 19:39:43 +00003137 }
3138 gclient_utils.FileRead.return_value = json.dumps(expected_results)
Dirk Pranke61bf6e82021-04-23 00:50:21 +00003139 git_cl.time_time.side_effect = [100, 200, 300, 400]
Edward Lemur99df04e2020-03-05 19:39:43 +00003140 mockProcess = mock.Mock()
3141 mockProcess.wait.return_value = 0
3142 subprocess2.Popen.return_value = mockProcess
3143
3144 git_cl.Changelist.GetAuthor.return_value = None
3145 git_cl.Changelist.GetIssue.return_value = None
3146 git_cl.Changelist.GetPatchset.return_value = None
Edward Lemur99df04e2020-03-05 19:39:43 +00003147
3148 cl = git_cl.Changelist()
3149 results = cl.RunHook(
3150 committing=False,
3151 may_prompt=False,
3152 verbose=0,
3153 parallel=False,
3154 upstream='upstream',
3155 description='description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003156 all_files=False,
3157 resultdb=False)
Edward Lemur99df04e2020-03-05 19:39:43 +00003158
3159 self.assertEqual(expected_results, results)
Dirk Pranke61bf6e82021-04-23 00:50:21 +00003160 subprocess2.Popen.assert_any_call([
Edward Lemur99df04e2020-03-05 19:39:43 +00003161 'vpython', 'PRESUBMIT_SUPPORT',
3162 '--root', 'root',
3163 '--upstream', 'upstream',
Edward Lesmeseb1bd622021-03-01 19:54:07 +00003164 '--gerrit_url', 'https://chromium-review.googlesource.com',
3165 '--gerrit_project', 'project',
3166 '--gerrit_branch', 'refs/heads/main',
Edward Lemur99df04e2020-03-05 19:39:43 +00003167 '--upload',
3168 '--json_output', '/tmp/fake-temp2',
3169 '--description_file', '/tmp/fake-temp1',
3170 ])
Dirk Pranke61bf6e82021-04-23 00:50:21 +00003171 gclient_utils.FileWrite.assert_any_call(
Edward Lemur99df04e2020-03-05 19:39:43 +00003172 '/tmp/fake-temp1', 'description')
3173 metrics.collector.add_repeated('sub_commands', {
3174 'command': 'presubmit',
3175 'execution_time': 100,
3176 'exit_code': 0,
3177 })
3178
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003179 def testRunHook_FewerOptionsResultDB(self):
3180 expected_results = {
Dirk Pranke61bf6e82021-04-23 00:50:21 +00003181 'more_cc': ['cc@example.com', 'more@example.com'],
3182 'errors': [],
3183 'notifications': [],
3184 'warnings': [],
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003185 }
3186 gclient_utils.FileRead.return_value = json.dumps(expected_results)
Dirk Pranke61bf6e82021-04-23 00:50:21 +00003187 git_cl.time_time.side_effect = [100, 200, 300, 400]
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003188 mockProcess = mock.Mock()
3189 mockProcess.wait.return_value = 0
3190 subprocess2.Popen.return_value = mockProcess
3191
3192 git_cl.Changelist.GetAuthor.return_value = None
3193 git_cl.Changelist.GetIssue.return_value = None
3194 git_cl.Changelist.GetPatchset.return_value = None
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003195
3196 cl = git_cl.Changelist()
3197 results = cl.RunHook(
3198 committing=False,
3199 may_prompt=False,
3200 verbose=0,
3201 parallel=False,
3202 upstream='upstream',
3203 description='description',
3204 all_files=False,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003205 resultdb=True,
3206 realm='chromium:public')
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003207
3208 self.assertEqual(expected_results, results)
Dirk Pranke61bf6e82021-04-23 00:50:21 +00003209 subprocess2.Popen.assert_any_call([
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003210 'rdb', 'stream', '-new', '-realm', 'chromium:public', '--',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003211 'vpython', 'PRESUBMIT_SUPPORT',
3212 '--root', 'root',
3213 '--upstream', 'upstream',
Edward Lesmeseb1bd622021-03-01 19:54:07 +00003214 '--gerrit_url', 'https://chromium-review.googlesource.com',
3215 '--gerrit_project', 'project',
3216 '--gerrit_branch', 'refs/heads/main',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003217 '--upload',
3218 '--json_output', '/tmp/fake-temp2',
3219 '--description_file', '/tmp/fake-temp1',
3220 ])
3221
Edward Lemur227d5102020-02-25 23:45:35 +00003222 @mock.patch('sys.exit', side_effect=SystemExitMock)
3223 def testRunHook_Failure(self, _mock):
3224 git_cl.time_time.side_effect = [100, 200]
3225 mockProcess = mock.Mock()
3226 mockProcess.wait.return_value = 2
3227 subprocess2.Popen.return_value = mockProcess
3228
3229 cl = git_cl.Changelist()
3230 with self.assertRaises(SystemExitMock):
3231 cl.RunHook(
3232 committing=True,
3233 may_prompt=True,
3234 verbose=2,
3235 parallel=True,
3236 upstream='upstream',
3237 description='description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003238 all_files=True,
3239 resultdb=False)
Edward Lemur227d5102020-02-25 23:45:35 +00003240
3241 sys.exit.assert_called_once_with(2)
3242
Edward Lemur75526302020-02-27 22:31:05 +00003243 def testRunPostUploadHook(self):
3244 cl = git_cl.Changelist()
3245 cl.RunPostUploadHook(2, 'upstream', 'description')
3246
3247 subprocess2.Popen.assert_called_once_with([
3248 'vpython', 'PRESUBMIT_SUPPORT',
Edward Lemur75526302020-02-27 22:31:05 +00003249 '--root', 'root',
3250 '--upstream', 'upstream',
3251 '--verbose', '--verbose',
Edward Lemur99df04e2020-03-05 19:39:43 +00003252 '--gerrit_url', 'https://chromium-review.googlesource.com',
Edward Lesmeseb1bd622021-03-01 19:54:07 +00003253 '--gerrit_project', 'project',
3254 '--gerrit_branch', 'refs/heads/main',
3255 '--author', 'author',
Edward Lemur75526302020-02-27 22:31:05 +00003256 '--issue', '123456',
3257 '--patchset', '7',
Edward Lemur75526302020-02-27 22:31:05 +00003258 '--post_upload',
3259 '--description_file', '/tmp/fake-temp1',
3260 ])
3261 gclient_utils.FileWrite.assert_called_once_with(
Edward Lemur1a83da12020-03-04 21:18:36 +00003262 '/tmp/fake-temp1', 'description')
Edward Lemur75526302020-02-27 22:31:05 +00003263
mlcui3da91712021-05-05 10:00:30 +00003264 @mock.patch('git_cl.RunGit', _mock_run_git)
3265 def testDefaultTitleEmptyMessage(self):
3266 cl = git_cl.Changelist()
3267 cl.issue = 100
3268 options = optparse.Values({
3269 'squash': True,
3270 'title': None,
3271 'message': None,
3272 'force': None,
3273 'skip_title': None
3274 })
3275
3276 mock.patch('gclient_utils.AskForData', lambda _: user_title).start()
3277 for user_title in ['', 'y', 'Y']:
3278 self.assertEqual(cl._GetTitleForUpload(options), self.LAST_COMMIT_SUBJECT)
3279
3280 for user_title in ['not empty', 'yes', 'YES']:
3281 self.assertEqual(cl._GetTitleForUpload(options), user_title)
3282
Edward Lemur9aa1a962020-02-25 00:58:38 +00003283
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003284class CMDTestCaseBase(unittest.TestCase):
3285 _STATUSES = [
3286 'STATUS_UNSPECIFIED', 'SCHEDULED', 'STARTED', 'SUCCESS', 'FAILURE',
3287 'INFRA_FAILURE', 'CANCELED',
3288 ]
3289 _CHANGE_DETAIL = {
3290 'project': 'depot_tools',
3291 'status': 'OPEN',
3292 'owner': {'email': 'owner@e.mail'},
3293 'current_revision': 'beeeeeef',
3294 'revisions': {
Gavin Make61ccc52020-11-13 00:12:57 +00003295 'deadbeaf': {
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00003296 '_number': 6,
Gavin Make61ccc52020-11-13 00:12:57 +00003297 'kind': 'REWORK',
3298 },
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003299 'beeeeeef': {
3300 '_number': 7,
Gavin Make61ccc52020-11-13 00:12:57 +00003301 'kind': 'NO_CODE_CHANGE',
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003302 'fetch': {'http': {
3303 'url': 'https://chromium.googlesource.com/depot_tools',
3304 'ref': 'refs/changes/56/123456/7'
3305 }},
3306 },
3307 },
3308 }
3309 _DEFAULT_RESPONSE = {
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003310 'builds': [{
3311 'id': str(100 + idx),
3312 'builder': {
3313 'project': 'chromium',
3314 'bucket': 'try',
3315 'builder': 'bot_' + status.lower(),
3316 },
3317 'createTime': '2019-10-09T08:00:0%d.854286Z' % (idx % 10),
3318 'tags': [],
3319 'status': status,
3320 } for idx, status in enumerate(_STATUSES)]
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003321 }
3322
Edward Lemur4c707a22019-09-24 21:13:43 +00003323 def setUp(self):
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003324 super(CMDTestCaseBase, self).setUp()
Edward Lemur79d4f992019-11-11 23:49:02 +00003325 mock.patch('git_cl.sys.stdout', StringIO()).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003326 mock.patch('git_cl.uuid.uuid4', return_value='uuid4').start()
3327 mock.patch('git_cl.Changelist.GetIssue', return_value=123456).start()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00003328 mock.patch(
3329 'git_cl.Changelist.GetCodereviewServer',
3330 return_value='https://chromium-review.googlesource.com').start()
3331 mock.patch(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00003332 'git_cl.Changelist.GetGerritHost',
Edward Lesmes7677e5c2020-02-19 20:39:03 +00003333 return_value='chromium-review.googlesource.com').start()
3334 mock.patch(
3335 'git_cl.Changelist.GetMostRecentPatchset',
3336 return_value=7).start()
3337 mock.patch(
Gavin Make61ccc52020-11-13 00:12:57 +00003338 'git_cl.Changelist.GetMostRecentDryRunPatchset',
3339 return_value=6).start()
3340 mock.patch(
Edward Lesmes7677e5c2020-02-19 20:39:03 +00003341 'git_cl.Changelist.GetRemoteUrl',
3342 return_value='https://chromium.googlesource.com/depot_tools').start()
3343 mock.patch(
3344 'auth.Authenticator',
3345 return_value=AuthenticatorMock()).start()
3346 mock.patch(
3347 'gerrit_util.GetChangeDetail',
3348 return_value=self._CHANGE_DETAIL).start()
3349 mock.patch(
3350 'git_cl._call_buildbucket',
3351 return_value = self._DEFAULT_RESPONSE).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003352 mock.patch('git_common.is_dirty_git_tree', return_value=False).start()
Edward Lemur4c707a22019-09-24 21:13:43 +00003353 self.addCleanup(mock.patch.stopall)
3354
Edward Lemur4c707a22019-09-24 21:13:43 +00003355
Edward Lemur9468eba2020-02-27 19:07:22 +00003356class CMDPresubmitTestCase(CMDTestCaseBase):
3357 def setUp(self):
3358 super(CMDPresubmitTestCase, self).setUp()
3359 mock.patch(
3360 'git_cl.Changelist.GetCommonAncestorWithUpstream',
3361 return_value='upstream').start()
3362 mock.patch(
3363 'git_cl.Changelist.FetchDescription',
3364 return_value='fetch description').start()
3365 mock.patch(
Edward Lemura12175c2020-03-09 16:58:26 +00003366 'git_cl._create_description_from_log',
Edward Lemur9468eba2020-02-27 19:07:22 +00003367 return_value='get description').start()
3368 mock.patch('git_cl.Changelist.RunHook').start()
3369
3370 def testDefaultCase(self):
3371 self.assertEqual(0, git_cl.main(['presubmit']))
3372 git_cl.Changelist.RunHook.assert_called_once_with(
3373 committing=True,
3374 may_prompt=False,
3375 verbose=0,
3376 parallel=None,
3377 upstream='upstream',
3378 description='fetch description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003379 all_files=None,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003380 resultdb=None,
3381 realm=None)
Edward Lemur9468eba2020-02-27 19:07:22 +00003382
3383 def testNoIssue(self):
3384 git_cl.Changelist.GetIssue.return_value = None
3385 self.assertEqual(0, git_cl.main(['presubmit']))
3386 git_cl.Changelist.RunHook.assert_called_once_with(
3387 committing=True,
3388 may_prompt=False,
3389 verbose=0,
3390 parallel=None,
3391 upstream='upstream',
3392 description='get description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003393 all_files=None,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003394 resultdb=None,
3395 realm=None)
Edward Lemur9468eba2020-02-27 19:07:22 +00003396
3397 def testCustomBranch(self):
3398 self.assertEqual(0, git_cl.main(['presubmit', 'custom_branch']))
3399 git_cl.Changelist.RunHook.assert_called_once_with(
3400 committing=True,
3401 may_prompt=False,
3402 verbose=0,
3403 parallel=None,
3404 upstream='custom_branch',
3405 description='fetch description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003406 all_files=None,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003407 resultdb=None,
3408 realm=None)
Edward Lemur9468eba2020-02-27 19:07:22 +00003409
3410 def testOptions(self):
3411 self.assertEqual(
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003412 0, git_cl.main(['presubmit', '-v', '-v', '--all', '--parallel', '-u',
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003413 '--resultdb', '--realm', 'chromium:public']))
Edward Lemur9468eba2020-02-27 19:07:22 +00003414 git_cl.Changelist.RunHook.assert_called_once_with(
3415 committing=False,
3416 may_prompt=False,
3417 verbose=2,
3418 parallel=True,
3419 upstream='upstream',
3420 description='fetch description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003421 all_files=True,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003422 resultdb=True,
3423 realm='chromium:public')
Edward Lemur9468eba2020-02-27 19:07:22 +00003424
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003425class CMDTryResultsTestCase(CMDTestCaseBase):
3426 _DEFAULT_REQUEST = {
3427 'predicate': {
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003428 "gerritChanges": [{
3429 "project": "depot_tools",
3430 "host": "chromium-review.googlesource.com",
Gavin Make61ccc52020-11-13 00:12:57 +00003431 "patchset": 6,
3432 "change": 123456,
3433 }],
3434 },
3435 'fields': ('builds.*.id,builds.*.builder,builds.*.status' +
3436 ',builds.*.createTime,builds.*.tags'),
3437 }
3438
3439 _TRIVIAL_REQUEST = {
3440 'predicate': {
3441 "gerritChanges": [{
3442 "project": "depot_tools",
3443 "host": "chromium-review.googlesource.com",
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003444 "patchset": 7,
3445 "change": 123456,
3446 }],
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003447 },
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003448 'fields': ('builds.*.id,builds.*.builder,builds.*.status' +
3449 ',builds.*.createTime,builds.*.tags'),
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003450 }
3451
3452 def testNoJobs(self):
3453 git_cl._call_buildbucket.return_value = {}
3454
3455 self.assertEqual(0, git_cl.main(['try-results']))
3456 self.assertEqual('No tryjobs scheduled.\n', sys.stdout.getvalue())
3457 git_cl._call_buildbucket.assert_called_once_with(
3458 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3459 self._DEFAULT_REQUEST)
3460
Gavin Make61ccc52020-11-13 00:12:57 +00003461 def testTrivialCommits(self):
3462 self.assertEqual(0, git_cl.main(['try-results']))
3463 git_cl._call_buildbucket.assert_called_with(
3464 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3465 self._DEFAULT_REQUEST)
3466
3467 git_cl._call_buildbucket.return_value = {}
3468 self.assertEqual(0, git_cl.main(['try-results', '--patchset', '7']))
3469 git_cl._call_buildbucket.assert_called_with(
3470 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3471 self._TRIVIAL_REQUEST)
3472 self.assertEqual([
3473 'Successes:',
3474 ' bot_success https://ci.chromium.org/b/103',
3475 'Infra Failures:',
3476 ' bot_infra_failure https://ci.chromium.org/b/105',
3477 'Failures:',
3478 ' bot_failure https://ci.chromium.org/b/104',
3479 'Canceled:',
3480 ' bot_canceled ',
3481 'Started:',
3482 ' bot_started https://ci.chromium.org/b/102',
3483 'Scheduled:',
3484 ' bot_scheduled id=101',
3485 'Other:',
3486 ' bot_status_unspecified id=100',
3487 'Total: 7 tryjobs',
3488 'No tryjobs scheduled.',
3489 ], sys.stdout.getvalue().splitlines())
3490
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003491 def testPrintToStdout(self):
3492 self.assertEqual(0, git_cl.main(['try-results']))
3493 self.assertEqual([
3494 'Successes:',
3495 ' bot_success https://ci.chromium.org/b/103',
3496 'Infra Failures:',
3497 ' bot_infra_failure https://ci.chromium.org/b/105',
3498 'Failures:',
3499 ' bot_failure https://ci.chromium.org/b/104',
3500 'Canceled:',
3501 ' bot_canceled ',
3502 'Started:',
3503 ' bot_started https://ci.chromium.org/b/102',
3504 'Scheduled:',
3505 ' bot_scheduled id=101',
3506 'Other:',
3507 ' bot_status_unspecified id=100',
3508 'Total: 7 tryjobs',
3509 ], sys.stdout.getvalue().splitlines())
3510 git_cl._call_buildbucket.assert_called_once_with(
3511 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3512 self._DEFAULT_REQUEST)
3513
3514 def testPrintToStdoutWithMasters(self):
3515 self.assertEqual(0, git_cl.main(['try-results', '--print-master']))
3516 self.assertEqual([
3517 'Successes:',
3518 ' try bot_success https://ci.chromium.org/b/103',
3519 'Infra Failures:',
3520 ' try bot_infra_failure https://ci.chromium.org/b/105',
3521 'Failures:',
3522 ' try bot_failure https://ci.chromium.org/b/104',
3523 'Canceled:',
3524 ' try bot_canceled ',
3525 'Started:',
3526 ' try bot_started https://ci.chromium.org/b/102',
3527 'Scheduled:',
3528 ' try bot_scheduled id=101',
3529 'Other:',
3530 ' try bot_status_unspecified id=100',
3531 'Total: 7 tryjobs',
3532 ], sys.stdout.getvalue().splitlines())
3533 git_cl._call_buildbucket.assert_called_once_with(
3534 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3535 self._DEFAULT_REQUEST)
3536
3537 @mock.patch('git_cl.write_json')
3538 def testWriteToJson(self, mockJsonDump):
3539 self.assertEqual(0, git_cl.main(['try-results', '--json', 'file.json']))
3540 git_cl._call_buildbucket.assert_called_once_with(
3541 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3542 self._DEFAULT_REQUEST)
3543 mockJsonDump.assert_called_once_with(
3544 'file.json', self._DEFAULT_RESPONSE['builds'])
3545
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003546 def test_filter_failed_for_one_simple(self):
Edward Lemur45768512020-03-02 19:03:14 +00003547 self.assertEqual([], git_cl._filter_failed_for_retry([]))
3548 self.assertEqual(
3549 [
3550 ('chromium', 'try', 'bot_failure'),
3551 ('chromium', 'try', 'bot_infra_failure'),
3552 ],
3553 git_cl._filter_failed_for_retry(self._DEFAULT_RESPONSE['builds']))
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003554
3555 def test_filter_failed_for_retry_many_builds(self):
3556
3557 def _build(name, created_sec, status, experimental=False):
3558 assert 0 <= created_sec < 100, created_sec
3559 b = {
3560 'id': 112112,
3561 'builder': {
3562 'project': 'chromium',
3563 'bucket': 'try',
3564 'builder': name,
3565 },
3566 'createTime': '2019-10-09T08:00:%02d.854286Z' % created_sec,
3567 'status': status,
3568 'tags': [],
3569 }
3570 if experimental:
3571 b['tags'].append({'key': 'cq_experimental', 'value': 'true'})
3572 return b
3573
3574 builds = [
3575 _build('flaky-last-green', 1, 'FAILURE'),
3576 _build('flaky-last-green', 2, 'SUCCESS'),
3577 _build('flaky', 1, 'SUCCESS'),
3578 _build('flaky', 2, 'FAILURE'),
3579 _build('running', 1, 'FAILED'),
3580 _build('running', 2, 'SCHEDULED'),
3581 _build('yep-still-running', 1, 'STARTED'),
3582 _build('yep-still-running', 2, 'FAILURE'),
3583 _build('cq-experimental', 1, 'SUCCESS', experimental=True),
3584 _build('cq-experimental', 2, 'FAILURE', experimental=True),
3585
3586 # Simulate experimental in CQ builder, which developer decided
3587 # to retry manually which resulted in 2nd build non-experimental.
3588 _build('sometimes-experimental', 1, 'FAILURE', experimental=True),
3589 _build('sometimes-experimental', 2, 'FAILURE', experimental=False),
3590 ]
3591 builds.sort(key=lambda b: b['status']) # ~deterministic shuffle.
Edward Lemur45768512020-03-02 19:03:14 +00003592 self.assertEqual(
3593 [
3594 ('chromium', 'try', 'flaky'),
3595 ('chromium', 'try', 'sometimes-experimental'),
3596 ],
3597 git_cl._filter_failed_for_retry(builds))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003598
3599
3600class CMDTryTestCase(CMDTestCaseBase):
3601
3602 @mock.patch('git_cl.Changelist.SetCQState')
Edward Lemur45768512020-03-02 19:03:14 +00003603 def testSetCQDryRunByDefault(self, mockSetCQState):
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003604 mockSetCQState.return_value = 0
Edward Lemur4c707a22019-09-24 21:13:43 +00003605 self.assertEqual(0, git_cl.main(['try']))
3606 git_cl.Changelist.SetCQState.assert_called_with(git_cl._CQState.DRY_RUN)
3607 self.assertEqual(
3608 sys.stdout.getvalue(),
3609 'Scheduling CQ dry run on: '
3610 'https://chromium-review.googlesource.com/123456\n')
3611
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00003612 @mock.patch('git_cl.Changelist.SetCQState')
3613 def testSetCQQuickRunByDefault(self, mockSetCQState):
3614 mockSetCQState.return_value = 0
3615 self.assertEqual(0, git_cl.main(['try', '-q']))
3616 git_cl.Changelist.SetCQState.assert_called_with(git_cl._CQState.QUICK_RUN)
3617 self.assertEqual(
3618 sys.stdout.getvalue(),
3619 'Scheduling CQ quick run on: '
3620 'https://chromium-review.googlesource.com/123456\n')
3621
Edward Lemur4c707a22019-09-24 21:13:43 +00003622 @mock.patch('git_cl._call_buildbucket')
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003623 def testScheduleOnBuildbucket(self, mockCallBuildbucket):
Edward Lemur4c707a22019-09-24 21:13:43 +00003624 mockCallBuildbucket.return_value = {}
Edward Lemur4c707a22019-09-24 21:13:43 +00003625
3626 self.assertEqual(0, git_cl.main([
3627 'try', '-B', 'luci.chromium.try', '-b', 'win',
3628 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
3629 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003630 'Scheduling jobs on:\n'
3631 ' chromium/try: win',
Edward Lemur4c707a22019-09-24 21:13:43 +00003632 git_cl.sys.stdout.getvalue())
3633
3634 expected_request = {
3635 "requests": [{
3636 "scheduleBuild": {
3637 "requestId": "uuid4",
3638 "builder": {
3639 "project": "chromium",
3640 "builder": "win",
3641 "bucket": "try",
3642 },
3643 "gerritChanges": [{
3644 "project": "depot_tools",
3645 "host": "chromium-review.googlesource.com",
3646 "patchset": 7,
3647 "change": 123456,
3648 }],
3649 "properties": {
3650 "category": "git_cl_try",
3651 "json": [{"a": 1}, None],
3652 "key": "val",
3653 },
3654 "tags": [
3655 {"value": "win", "key": "builder"},
3656 {"value": "git_cl_try", "key": "user_agent"},
3657 ],
3658 },
3659 }],
3660 }
3661 mockCallBuildbucket.assert_called_with(
3662 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3663
Anthony Polito1a5fe232020-01-24 23:17:52 +00003664 @mock.patch('git_cl._call_buildbucket')
3665 def testScheduleOnBuildbucketWithRevision(self, mockCallBuildbucket):
3666 mockCallBuildbucket.return_value = {}
Josip Sokcevic9011a5b2021-02-12 18:59:44 +00003667 mock.patch('git_cl.Changelist.GetRemoteBranch',
3668 return_value=('origin', 'refs/remotes/origin/main')).start()
Anthony Polito1a5fe232020-01-24 23:17:52 +00003669
3670 self.assertEqual(0, git_cl.main([
3671 'try', '-B', 'luci.chromium.try', '-b', 'win', '-b', 'linux',
3672 '-p', 'key=val', '-p', 'json=[{"a":1}, null]',
3673 '-r', 'beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef']))
3674 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003675 'Scheduling jobs on:\n'
3676 ' chromium/try: linux\n'
3677 ' chromium/try: win',
Anthony Polito1a5fe232020-01-24 23:17:52 +00003678 git_cl.sys.stdout.getvalue())
3679
3680 expected_request = {
3681 "requests": [{
3682 "scheduleBuild": {
3683 "requestId": "uuid4",
3684 "builder": {
3685 "project": "chromium",
3686 "builder": "linux",
3687 "bucket": "try",
3688 },
3689 "gerritChanges": [{
3690 "project": "depot_tools",
3691 "host": "chromium-review.googlesource.com",
3692 "patchset": 7,
3693 "change": 123456,
3694 }],
3695 "properties": {
3696 "category": "git_cl_try",
3697 "json": [{"a": 1}, None],
3698 "key": "val",
3699 },
3700 "tags": [
3701 {"value": "linux", "key": "builder"},
3702 {"value": "git_cl_try", "key": "user_agent"},
3703 ],
3704 "gitilesCommit": {
3705 "host": "chromium-review.googlesource.com",
3706 "project": "depot_tools",
3707 "id": "beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef",
Josip Sokcevic9011a5b2021-02-12 18:59:44 +00003708 "ref": "refs/heads/main",
Anthony Polito1a5fe232020-01-24 23:17:52 +00003709 }
3710 },
3711 },
3712 {
3713 "scheduleBuild": {
3714 "requestId": "uuid4",
3715 "builder": {
3716 "project": "chromium",
3717 "builder": "win",
3718 "bucket": "try",
3719 },
3720 "gerritChanges": [{
3721 "project": "depot_tools",
3722 "host": "chromium-review.googlesource.com",
3723 "patchset": 7,
3724 "change": 123456,
3725 }],
3726 "properties": {
3727 "category": "git_cl_try",
3728 "json": [{"a": 1}, None],
3729 "key": "val",
3730 },
3731 "tags": [
3732 {"value": "win", "key": "builder"},
3733 {"value": "git_cl_try", "key": "user_agent"},
3734 ],
3735 "gitilesCommit": {
3736 "host": "chromium-review.googlesource.com",
3737 "project": "depot_tools",
3738 "id": "beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef",
Josip Sokcevic9011a5b2021-02-12 18:59:44 +00003739 "ref": "refs/heads/main",
Anthony Polito1a5fe232020-01-24 23:17:52 +00003740 }
3741 },
3742 }],
3743 }
3744 mockCallBuildbucket.assert_called_with(
3745 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3746
Edward Lemur45768512020-03-02 19:03:14 +00003747 @mock.patch('sys.stderr', StringIO())
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003748 def testScheduleOnBuildbucket_WrongBucket(self):
Edward Lemur45768512020-03-02 19:03:14 +00003749 with self.assertRaises(SystemExit):
3750 git_cl.main([
3751 'try', '-B', 'not-a-bucket', '-b', 'win',
3752 '-p', 'key=val', '-p', 'json=[{"a":1}, null]'])
Edward Lemur4c707a22019-09-24 21:13:43 +00003753 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003754 'Invalid bucket: not-a-bucket.',
3755 sys.stderr.getvalue())
Edward Lemur4c707a22019-09-24 21:13:43 +00003756
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003757 @mock.patch('git_cl._call_buildbucket')
Quinten Yearsley777660f2020-03-04 23:37:06 +00003758 @mock.patch('git_cl._fetch_tryjobs')
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003759 def testScheduleOnBuildbucketRetryFailed(
3760 self, mockFetchTryJobs, mockCallBuildbucket):
Quinten Yearsley777660f2020-03-04 23:37:06 +00003761 git_cl._fetch_tryjobs.side_effect = lambda *_, **kw: {
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003762 7: [],
3763 6: [{
3764 'id': 112112,
3765 'builder': {
3766 'project': 'chromium',
3767 'bucket': 'try',
Quinten Yearsley777660f2020-03-04 23:37:06 +00003768 'builder': 'linux', },
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003769 'createTime': '2019-10-09T08:00:01.854286Z',
3770 'tags': [],
Quinten Yearsley777660f2020-03-04 23:37:06 +00003771 'status': 'FAILURE', }], }[kw['patchset']]
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003772 mockCallBuildbucket.return_value = {}
3773
3774 self.assertEqual(0, git_cl.main(['try', '--retry-failed']))
3775 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003776 'Scheduling jobs on:\n'
3777 ' chromium/try: linux',
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003778 git_cl.sys.stdout.getvalue())
3779
3780 expected_request = {
3781 "requests": [{
3782 "scheduleBuild": {
3783 "requestId": "uuid4",
3784 "builder": {
3785 "project": "chromium",
3786 "bucket": "try",
3787 "builder": "linux",
3788 },
3789 "gerritChanges": [{
3790 "project": "depot_tools",
3791 "host": "chromium-review.googlesource.com",
3792 "patchset": 7,
3793 "change": 123456,
3794 }],
3795 "properties": {
3796 "category": "git_cl_try",
3797 },
3798 "tags": [
3799 {"value": "linux", "key": "builder"},
3800 {"value": "git_cl_try", "key": "user_agent"},
3801 {"value": "1", "key": "retry_failed"},
3802 ],
3803 },
3804 }],
3805 }
3806 mockCallBuildbucket.assert_called_with(
3807 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3808
Edward Lemur4c707a22019-09-24 21:13:43 +00003809 def test_parse_bucket(self):
3810 test_cases = [
3811 {
3812 'bucket': 'chromium/try',
3813 'result': ('chromium', 'try'),
3814 },
3815 {
3816 'bucket': 'luci.chromium.try',
3817 'result': ('chromium', 'try'),
3818 'has_warning': True,
3819 },
3820 {
3821 'bucket': 'skia.primary',
3822 'result': ('skia', 'skia.primary'),
3823 'has_warning': True,
3824 },
3825 {
3826 'bucket': 'not-a-bucket',
3827 'result': (None, None),
3828 },
3829 ]
3830
3831 for test_case in test_cases:
3832 git_cl.sys.stdout.truncate(0)
3833 self.assertEqual(
3834 test_case['result'], git_cl._parse_bucket(test_case['bucket']))
3835 if test_case.get('has_warning'):
Edward Lemur6215c792019-10-03 21:59:05 +00003836 expected_warning = 'WARNING Please use %s/%s to specify the bucket' % (
3837 test_case['result'])
3838 self.assertIn(expected_warning, git_cl.sys.stdout.getvalue())
Edward Lemur4c707a22019-09-24 21:13:43 +00003839
3840
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003841class CMDUploadTestCase(CMDTestCaseBase):
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +00003842
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003843 def setUp(self):
3844 super(CMDUploadTestCase, self).setUp()
Quinten Yearsley777660f2020-03-04 23:37:06 +00003845 mock.patch('git_cl._fetch_tryjobs').start()
3846 mock.patch('git_cl._trigger_tryjobs', return_value={}).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003847 mock.patch('git_cl.Changelist.CMDUpload', return_value=0).start()
Edward Lesmes0dd54822020-03-26 18:24:25 +00003848 mock.patch('git_cl.Settings.GetRoot', return_value='').start()
3849 mock.patch(
3850 'git_cl.Settings.GetSquashGerritUploads',
3851 return_value=True).start()
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003852 self.addCleanup(mock.patch.stopall)
3853
Edward Lesmes7677e5c2020-02-19 20:39:03 +00003854 def testWarmUpChangeDetailCache(self):
3855 self.assertEqual(0, git_cl.main(['upload']))
3856 gerrit_util.GetChangeDetail.assert_called_once_with(
3857 'chromium-review.googlesource.com', 'depot_tools~123456',
3858 frozenset([
3859 'LABELS', 'CURRENT_REVISION', 'DETAILED_ACCOUNTS',
3860 'CURRENT_COMMIT']))
3861
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003862 def testUploadRetryFailed(self):
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003863 # This test mocks out the actual upload part, and just asserts that after
3864 # upload, if --retry-failed is added, then the tool will fetch try jobs
3865 # from the previous patchset and trigger the right builders on the latest
3866 # patchset.
Quinten Yearsley777660f2020-03-04 23:37:06 +00003867 git_cl._fetch_tryjobs.side_effect = [
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003868 # Latest patchset: No builds.
3869 [],
3870 # Patchset before latest: Some builds.
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003871 [{
3872 'id': str(100 + idx),
3873 'builder': {
3874 'project': 'chromium',
3875 'bucket': 'try',
3876 'builder': 'bot_' + status.lower(),
3877 },
3878 'createTime': '2019-10-09T08:00:0%d.854286Z' % (idx % 10),
3879 'tags': [],
3880 'status': status,
3881 } for idx, status in enumerate(self._STATUSES)],
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +00003882 ]
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003883
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003884 self.assertEqual(0, git_cl.main(['upload', '--retry-failed']))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003885 self.assertEqual([
Edward Lemur5b929a42019-10-21 17:57:39 +00003886 mock.call(mock.ANY, 'cr-buildbucket.appspot.com', patchset=7),
3887 mock.call(mock.ANY, 'cr-buildbucket.appspot.com', patchset=6),
Quinten Yearsley777660f2020-03-04 23:37:06 +00003888 ], git_cl._fetch_tryjobs.mock_calls)
Edward Lemur45768512020-03-02 19:03:14 +00003889 expected_buckets = [
3890 ('chromium', 'try', 'bot_failure'),
3891 ('chromium', 'try', 'bot_infra_failure'),
3892 ]
Quinten Yearsley777660f2020-03-04 23:37:06 +00003893 git_cl._trigger_tryjobs.assert_called_once_with(mock.ANY, expected_buckets,
3894 mock.ANY, 8)
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003895
Brian Sheedy59b06a82019-10-14 17:03:29 +00003896
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +00003897class MakeRequestsHelperTestCase(unittest.TestCase):
3898
3899 def exampleGerritChange(self):
3900 return {
3901 'host': 'chromium-review.googlesource.com',
3902 'project': 'depot_tools',
3903 'change': 1,
3904 'patchset': 2,
3905 }
3906
3907 def testMakeRequestsHelperNoOptions(self):
3908 # Basic test for the helper function _make_tryjob_schedule_requests;
3909 # it shouldn't throw AttributeError even when options doesn't have any
3910 # of the expected values; it will use default option values.
3911 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3912 jobs = [('chromium', 'try', 'my-builder')]
3913 options = optparse.Values()
3914 requests = git_cl._make_tryjob_schedule_requests(
3915 changelist, jobs, options, patchset=None)
3916
3917 # requestId is non-deterministic. Just assert that it's there and has
3918 # a particular length.
3919 self.assertEqual(len(requests[0]['scheduleBuild'].pop('requestId')), 36)
3920 self.assertEqual(requests, [{
3921 'scheduleBuild': {
3922 'builder': {
3923 'bucket': 'try',
3924 'builder': 'my-builder',
3925 'project': 'chromium'
3926 },
3927 'gerritChanges': [self.exampleGerritChange()],
3928 'properties': {
3929 'category': 'git_cl_try'
3930 },
3931 'tags': [{
3932 'key': 'builder',
3933 'value': 'my-builder'
3934 }, {
3935 'key': 'user_agent',
3936 'value': 'git_cl_try'
3937 }]
3938 }
3939 }])
3940
3941 def testMakeRequestsHelperPresubmitSetsDryRunProperty(self):
3942 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3943 jobs = [('chromium', 'try', 'presubmit')]
3944 options = optparse.Values()
3945 requests = git_cl._make_tryjob_schedule_requests(
3946 changelist, jobs, options, patchset=None)
3947 self.assertEqual(requests[0]['scheduleBuild']['properties'], {
3948 'category': 'git_cl_try',
3949 'dry_run': 'true'
3950 })
3951
3952 def testMakeRequestsHelperRevisionSet(self):
3953 # Gitiles commit is specified when revision is in options.
3954 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3955 jobs = [('chromium', 'try', 'my-builder')]
3956 options = optparse.Values({'revision': 'ba5eba11'})
3957 requests = git_cl._make_tryjob_schedule_requests(
3958 changelist, jobs, options, patchset=None)
3959 self.assertEqual(
3960 requests[0]['scheduleBuild']['gitilesCommit'], {
3961 'host': 'chromium-review.googlesource.com',
3962 'id': 'ba5eba11',
Josip Sokcevic9011a5b2021-02-12 18:59:44 +00003963 'project': 'depot_tools',
3964 'ref': 'refs/heads/main',
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +00003965 })
3966
3967 def testMakeRequestsHelperRetryFailedSet(self):
3968 # An extra tag is added when retry_failed is in options.
3969 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3970 jobs = [('chromium', 'try', 'my-builder')]
3971 options = optparse.Values({'retry_failed': 'true'})
3972 requests = git_cl._make_tryjob_schedule_requests(
3973 changelist, jobs, options, patchset=None)
3974 self.assertEqual(
3975 requests[0]['scheduleBuild']['tags'], [
3976 {
3977 'key': 'builder',
3978 'value': 'my-builder'
3979 },
3980 {
3981 'key': 'user_agent',
3982 'value': 'git_cl_try'
3983 },
3984 {
3985 'key': 'retry_failed',
3986 'value': '1'
3987 }
3988 ])
3989
3990 def testMakeRequestsHelperCategorySet(self):
Quinten Yearsley925cedb2020-04-13 17:49:39 +00003991 # The category property can be overridden with options.
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +00003992 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3993 jobs = [('chromium', 'try', 'my-builder')]
3994 options = optparse.Values({'category': 'my-special-category'})
3995 requests = git_cl._make_tryjob_schedule_requests(
3996 changelist, jobs, options, patchset=None)
3997 self.assertEqual(requests[0]['scheduleBuild']['properties'],
3998 {'category': 'my-special-category'})
3999
4000
Edward Lemurda4b6c62020-02-13 00:28:40 +00004001class CMDFormatTestCase(unittest.TestCase):
Brian Sheedy59b06a82019-10-14 17:03:29 +00004002
4003 def setUp(self):
4004 super(CMDFormatTestCase, self).setUp()
Jamie Madill5e96ad12020-01-13 16:08:35 +00004005 mock.patch('git_cl.RunCommand').start()
4006 mock.patch('clang_format.FindClangFormatToolInChromiumTree').start()
4007 mock.patch('clang_format.FindClangFormatScriptInChromiumTree').start()
4008 mock.patch('git_cl.settings').start()
Brian Sheedy59b06a82019-10-14 17:03:29 +00004009 self._top_dir = tempfile.mkdtemp()
Jamie Madill5e96ad12020-01-13 16:08:35 +00004010 self.addCleanup(mock.patch.stopall)
Brian Sheedy59b06a82019-10-14 17:03:29 +00004011
4012 def tearDown(self):
4013 shutil.rmtree(self._top_dir)
4014 super(CMDFormatTestCase, self).tearDown()
4015
Jamie Madill5e96ad12020-01-13 16:08:35 +00004016 def _make_temp_file(self, fname, contents):
Anthony Politoc64e3902021-04-30 21:55:25 +00004017 gclient_utils.FileWrite(os.path.join(self._top_dir, fname),
4018 ('\n'.join(contents)))
Jamie Madill5e96ad12020-01-13 16:08:35 +00004019
Brian Sheedy59b06a82019-10-14 17:03:29 +00004020 def _make_yapfignore(self, contents):
Jamie Madill5e96ad12020-01-13 16:08:35 +00004021 self._make_temp_file('.yapfignore', contents)
Brian Sheedy59b06a82019-10-14 17:03:29 +00004022
Brian Sheedyb4307d52019-12-02 19:18:17 +00004023 def _check_yapf_filtering(self, files, expected):
4024 self.assertEqual(expected, git_cl._FilterYapfIgnoredFiles(
4025 files, git_cl._GetYapfIgnorePatterns(self._top_dir)))
Brian Sheedy59b06a82019-10-14 17:03:29 +00004026
Edward Lemur1a83da12020-03-04 21:18:36 +00004027 def _run_command_mock(self, return_value):
4028 def f(*args, **kwargs):
4029 if 'stdin' in kwargs:
4030 self.assertIsInstance(kwargs['stdin'], bytes)
4031 return return_value
4032 return f
4033
Jamie Madill5e96ad12020-01-13 16:08:35 +00004034 def testClangFormatDiffFull(self):
4035 self._make_temp_file('test.cc', ['// test'])
4036 git_cl.settings.GetFormatFullByDefault.return_value = False
4037 diff_file = [os.path.join(self._top_dir, 'test.cc')]
4038 mock_opts = mock.Mock(full=True, dry_run=True, diff=False)
4039
4040 # Diff
Edward Lemur1a83da12020-03-04 21:18:36 +00004041 git_cl.RunCommand.side_effect = self._run_command_mock(' // test')
Jamie Madill5e96ad12020-01-13 16:08:35 +00004042 return_value = git_cl._RunClangFormatDiff(mock_opts, diff_file,
4043 self._top_dir, 'HEAD')
4044 self.assertEqual(2, return_value)
4045
4046 # No diff
Edward Lemur1a83da12020-03-04 21:18:36 +00004047 git_cl.RunCommand.side_effect = self._run_command_mock('// test')
Jamie Madill5e96ad12020-01-13 16:08:35 +00004048 return_value = git_cl._RunClangFormatDiff(mock_opts, diff_file,
4049 self._top_dir, 'HEAD')
4050 self.assertEqual(0, return_value)
4051
4052 def testClangFormatDiff(self):
4053 git_cl.settings.GetFormatFullByDefault.return_value = False
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00004054 # A valid file is required, so use this test.
4055 clang_format.FindClangFormatToolInChromiumTree.return_value = __file__
Jamie Madill5e96ad12020-01-13 16:08:35 +00004056 mock_opts = mock.Mock(full=False, dry_run=True, diff=False)
4057
4058 # Diff
Edward Lemur1a83da12020-03-04 21:18:36 +00004059 git_cl.RunCommand.side_effect = self._run_command_mock('error')
4060 return_value = git_cl._RunClangFormatDiff(
4061 mock_opts, ['.'], self._top_dir, 'HEAD')
Jamie Madill5e96ad12020-01-13 16:08:35 +00004062 self.assertEqual(2, return_value)
4063
4064 # No diff
Edward Lemur1a83da12020-03-04 21:18:36 +00004065 git_cl.RunCommand.side_effect = self._run_command_mock('')
Jamie Madill5e96ad12020-01-13 16:08:35 +00004066 return_value = git_cl._RunClangFormatDiff(mock_opts, ['.'], self._top_dir,
4067 'HEAD')
4068 self.assertEqual(0, return_value)
4069
Brian Sheedyb4307d52019-12-02 19:18:17 +00004070 def testYapfignoreExplicit(self):
4071 self._make_yapfignore(['foo/bar.py', 'foo/bar/baz.py'])
4072 files = [
4073 'bar.py',
4074 'foo/bar.py',
4075 'foo/baz.py',
4076 'foo/bar/baz.py',
4077 'foo/bar/foobar.py',
4078 ]
4079 expected = [
4080 'bar.py',
4081 'foo/baz.py',
4082 'foo/bar/foobar.py',
4083 ]
4084 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00004085
Brian Sheedyb4307d52019-12-02 19:18:17 +00004086 def testYapfignoreSingleWildcards(self):
4087 self._make_yapfignore(['*bar.py', 'foo*', 'baz*.py'])
4088 files = [
4089 'bar.py', # Matched by *bar.py.
4090 'bar.txt',
4091 'foobar.py', # Matched by *bar.py, foo*.
4092 'foobar.txt', # Matched by foo*.
4093 'bazbar.py', # Matched by *bar.py, baz*.py.
4094 'bazbar.txt',
4095 'foo/baz.txt', # Matched by foo*.
4096 'bar/bar.py', # Matched by *bar.py.
4097 'baz/foo.py', # Matched by baz*.py, foo*.
4098 'baz/foo.txt',
4099 ]
4100 expected = [
4101 'bar.txt',
4102 'bazbar.txt',
4103 'baz/foo.txt',
4104 ]
4105 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00004106
Brian Sheedyb4307d52019-12-02 19:18:17 +00004107 def testYapfignoreMultiplewildcards(self):
4108 self._make_yapfignore(['*bar*', '*foo*baz.txt'])
4109 files = [
4110 'bar.py', # Matched by *bar*.
4111 'bar.txt', # Matched by *bar*.
4112 'abar.py', # Matched by *bar*.
4113 'foobaz.txt', # Matched by *foo*baz.txt.
4114 'foobaz.py',
4115 'afoobaz.txt', # Matched by *foo*baz.txt.
4116 ]
4117 expected = [
4118 'foobaz.py',
4119 ]
4120 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00004121
4122 def testYapfignoreComments(self):
4123 self._make_yapfignore(['test.py', '#test2.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00004124 files = [
4125 'test.py',
4126 'test2.py',
4127 ]
4128 expected = [
4129 'test2.py',
4130 ]
4131 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00004132
Anthony Politoc64e3902021-04-30 21:55:25 +00004133 def testYapfHandleUtf8(self):
4134 self._make_yapfignore(['test.py', 'test_🌐.py'])
4135 files = [
4136 'test.py',
4137 'test_🌐.py',
4138 'test2.py',
4139 ]
4140 expected = [
4141 'test2.py',
4142 ]
4143 self._check_yapf_filtering(files, expected)
4144
Brian Sheedy59b06a82019-10-14 17:03:29 +00004145 def testYapfignoreBlankLines(self):
4146 self._make_yapfignore(['test.py', '', '', 'test2.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00004147 files = [
4148 'test.py',
4149 'test2.py',
4150 'test3.py',
4151 ]
4152 expected = [
4153 'test3.py',
4154 ]
4155 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00004156
4157 def testYapfignoreWhitespace(self):
4158 self._make_yapfignore([' test.py '])
Brian Sheedyb4307d52019-12-02 19:18:17 +00004159 files = [
4160 'test.py',
4161 'test2.py',
4162 ]
4163 expected = [
4164 'test2.py',
4165 ]
4166 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00004167
Brian Sheedyb4307d52019-12-02 19:18:17 +00004168 def testYapfignoreNoFiles(self):
Brian Sheedy59b06a82019-10-14 17:03:29 +00004169 self._make_yapfignore(['test.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00004170 self._check_yapf_filtering([], [])
4171
4172 def testYapfignoreMissingYapfignore(self):
4173 files = [
4174 'test.py',
4175 ]
4176 expected = [
4177 'test.py',
4178 ]
4179 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00004180
4181
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00004182class CMDStatusTestCase(CMDTestCaseBase):
4183 # Return branch names a,..,f with comitterdates in increasing order, i.e.
4184 # 'f' is the most-recently changed branch.
4185 def _mock_run_git(commands):
4186 if commands == [
4187 'for-each-ref', '--format=%(refname) %(committerdate:unix)',
4188 'refs/heads'
4189 ]:
4190 branches_and_committerdates = [
4191 'refs/heads/a 1',
4192 'refs/heads/b 2',
4193 'refs/heads/c 3',
4194 'refs/heads/d 4',
4195 'refs/heads/e 5',
4196 'refs/heads/f 6',
4197 ]
4198 return '\n'.join(branches_and_committerdates)
4199
4200 # Mock the status in such a way that the issue number gives us an
4201 # indication of the commit date (simplifies manual debugging).
4202 def _mock_get_cl_statuses(branches, fine_grained, max_processes):
4203 for c in branches:
4204 c.issue = (100 + int(c.GetCommitDate()))
4205 yield (c, 'open')
4206
4207 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
4208 @mock.patch('git_cl.Changelist.FetchDescription', lambda cl, pretty: 'x')
4209 @mock.patch('git_cl.Changelist.GetIssue', lambda cl: cl.issue)
4210 @mock.patch('git_cl.RunGit', _mock_run_git)
4211 @mock.patch('git_cl.get_cl_statuses', _mock_get_cl_statuses)
4212 @mock.patch('git_cl.Settings.GetRoot', return_value='')
Sigurd Schneider1bfda8e2021-06-30 14:46:25 +00004213 @mock.patch('git_cl.Settings.IsStatusCommitOrderByDate', return_value=False)
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00004214 @mock.patch('scm.GIT.GetBranch', return_value='a')
4215 def testStatus(self, *_mocks):
4216 self.assertEqual(0, git_cl.main(['status', '--no-branch-color']))
4217 self.maxDiff = None
4218 self.assertEqual(
4219 sys.stdout.getvalue(), 'Branches associated with reviews:\n'
4220 ' * a : https://crrev.com/c/101 (open)\n'
4221 ' b : https://crrev.com/c/102 (open)\n'
4222 ' c : https://crrev.com/c/103 (open)\n'
4223 ' d : https://crrev.com/c/104 (open)\n'
4224 ' e : https://crrev.com/c/105 (open)\n'
4225 ' f : https://crrev.com/c/106 (open)\n\n'
4226 'Current branch: a\n'
4227 'Issue number: 101 (https://chromium-review.googlesource.com/101)\n'
4228 'Issue description:\n'
4229 'x\n')
4230
4231 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
4232 @mock.patch('git_cl.Changelist.FetchDescription', lambda cl, pretty: 'x')
4233 @mock.patch('git_cl.Changelist.GetIssue', lambda cl: cl.issue)
4234 @mock.patch('git_cl.RunGit', _mock_run_git)
4235 @mock.patch('git_cl.get_cl_statuses', _mock_get_cl_statuses)
4236 @mock.patch('git_cl.Settings.GetRoot', return_value='')
Sigurd Schneider1bfda8e2021-06-30 14:46:25 +00004237 @mock.patch('git_cl.Settings.IsStatusCommitOrderByDate', return_value=False)
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00004238 @mock.patch('scm.GIT.GetBranch', return_value='a')
4239 def testStatusByDate(self, *_mocks):
4240 self.assertEqual(
4241 0, git_cl.main(['status', '--no-branch-color', '--date-order']))
4242 self.maxDiff = None
4243 self.assertEqual(
4244 sys.stdout.getvalue(), 'Branches associated with reviews:\n'
4245 ' f : https://crrev.com/c/106 (open)\n'
4246 ' e : https://crrev.com/c/105 (open)\n'
4247 ' d : https://crrev.com/c/104 (open)\n'
4248 ' c : https://crrev.com/c/103 (open)\n'
4249 ' b : https://crrev.com/c/102 (open)\n'
4250 ' * a : https://crrev.com/c/101 (open)\n\n'
4251 'Current branch: a\n'
4252 'Issue number: 101 (https://chromium-review.googlesource.com/101)\n'
4253 'Issue description:\n'
4254 'x\n')
4255
Sigurd Schneider1bfda8e2021-06-30 14:46:25 +00004256 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
4257 @mock.patch('git_cl.Changelist.FetchDescription', lambda cl, pretty: 'x')
4258 @mock.patch('git_cl.Changelist.GetIssue', lambda cl: cl.issue)
4259 @mock.patch('git_cl.RunGit', _mock_run_git)
4260 @mock.patch('git_cl.get_cl_statuses', _mock_get_cl_statuses)
4261 @mock.patch('git_cl.Settings.GetRoot', return_value='')
4262 @mock.patch('git_cl.Settings.IsStatusCommitOrderByDate', return_value=True)
4263 @mock.patch('scm.GIT.GetBranch', return_value='a')
4264 def testStatusByDate(self, *_mocks):
4265 self.assertEqual(
4266 0, git_cl.main(['status', '--no-branch-color']))
4267 self.maxDiff = None
4268 self.assertEqual(
4269 sys.stdout.getvalue(), 'Branches associated with reviews:\n'
4270 ' f : https://crrev.com/c/106 (open)\n'
4271 ' e : https://crrev.com/c/105 (open)\n'
4272 ' d : https://crrev.com/c/104 (open)\n'
4273 ' c : https://crrev.com/c/103 (open)\n'
4274 ' b : https://crrev.com/c/102 (open)\n'
4275 ' * a : https://crrev.com/c/101 (open)\n\n'
4276 'Current branch: a\n'
4277 'Issue number: 101 (https://chromium-review.googlesource.com/101)\n'
4278 'Issue description:\n'
4279 'x\n')
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00004280
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004281class CMDOwnersTestCase(CMDTestCaseBase):
4282 def setUp(self):
4283 super(CMDOwnersTestCase, self).setUp()
Edward Lesmes82b992a2021-01-11 23:24:55 +00004284 self.owners_by_path = {
4285 'foo': ['a@example.com'],
4286 'bar': ['b@example.com', 'c@example.com'],
4287 }
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004288 mock.patch('git_cl.Settings.GetRoot', return_value='root').start()
4289 mock.patch('git_cl.Changelist.GetAuthor', return_value='author').start()
4290 mock.patch(
Edward Lesmes82b992a2021-01-11 23:24:55 +00004291 'git_cl.Changelist.GetAffectedFiles',
4292 return_value=list(self.owners_by_path)).start()
4293 mock.patch(
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004294 'git_cl.Changelist.GetCommonAncestorWithUpstream',
4295 return_value='upstream').start()
Edward Lesmes82b992a2021-01-11 23:24:55 +00004296 mock.patch(
Edward Lesmese1576912021-02-16 21:53:34 +00004297 'git_cl.Changelist.GetGerritHost',
4298 return_value='host').start()
4299 mock.patch(
4300 'git_cl.Changelist.GetGerritProject',
4301 return_value='project').start()
4302 mock.patch(
4303 'git_cl.Changelist.GetRemoteBranch',
4304 return_value=('origin', 'refs/remotes/origin/main')).start()
4305 mock.patch(
4306 'owners_client.OwnersClient.BatchListOwners',
Edward Lesmes82b992a2021-01-11 23:24:55 +00004307 return_value=self.owners_by_path).start()
Edward Lesmes8170c292021-03-19 20:04:43 +00004308 mock.patch(
4309 'gerrit_util.IsCodeOwnersEnabledOnHost', return_value=True).start()
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004310 self.addCleanup(mock.patch.stopall)
4311
4312 def testShowAllNoArgs(self):
4313 self.assertEqual(0, git_cl.main(['owners', '--show-all']))
4314 self.assertEqual(
4315 'No files specified for --show-all. Nothing to do.\n',
4316 git_cl.sys.stdout.getvalue())
4317
4318 def testShowAll(self):
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004319 self.assertEqual(
4320 0,
4321 git_cl.main(['owners', '--show-all', 'foo', 'bar', 'baz']))
Edward Lesmese1576912021-02-16 21:53:34 +00004322 owners_client.OwnersClient.BatchListOwners.assert_called_once_with(
Edward Lesmes82b992a2021-01-11 23:24:55 +00004323 ['foo', 'bar', 'baz'])
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004324 self.assertEqual(
4325 '\n'.join([
4326 'Owners for foo:',
4327 ' - a@example.com',
4328 'Owners for bar:',
4329 ' - b@example.com',
4330 ' - c@example.com',
4331 'Owners for baz:',
4332 ' - No owners found',
4333 '',
4334 ]),
4335 sys.stdout.getvalue())
4336
Edward Lesmes82b992a2021-01-11 23:24:55 +00004337 def testBatch(self):
4338 self.assertEqual(0, git_cl.main(['owners', '--batch']))
4339 self.assertIn('a@example.com', sys.stdout.getvalue())
4340 self.assertIn('b@example.com', sys.stdout.getvalue())
4341
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004342
maruel@chromium.orgddd59412011-11-30 14:20:38 +00004343if __name__ == '__main__':
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +01004344 logging.basicConfig(
4345 level=logging.DEBUG if '-v' in sys.argv else logging.ERROR)
maruel@chromium.orgddd59412011-11-30 14:20:38 +00004346 unittest.main()