blob: aa56a3a7e82004b8f8747a95ddf440905ca6933e [file] [log] [blame]
Edward Lemur0db01f02019-11-12 22:01:51 +00001#!/usr/bin/env vpython3
2# coding=utf-8
maruel@chromium.orgeb5edbc2012-01-16 17:03:28 +00003# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@chromium.orgddd59412011-11-30 14:20:38 +00004# Use of this source code is governed by a BSD-style license that can be
5# found in the LICENSE file.
6
7"""Unit tests for git_cl.py."""
8
Edward Lemur85153282020-02-14 22:06:29 +00009from __future__ import print_function
Edward Lemur0db01f02019-11-12 22:01:51 +000010from __future__ import unicode_literals
11
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +010012import datetime
tandriide281ae2016-10-12 06:02:30 -070013import json
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +010014import logging
Edward Lemur61bf4172020-02-24 23:22:37 +000015import multiprocessing
maruel@chromium.orgddd59412011-11-30 14:20:38 +000016import os
Edward Lemur85153282020-02-14 22:06:29 +000017import pprint
Brian Sheedy59b06a82019-10-14 17:03:29 +000018import shutil
maruel@chromium.orgddd59412011-11-30 14:20:38 +000019import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070020import tempfile
maruel@chromium.orgddd59412011-11-30 14:20:38 +000021import unittest
22
Edward Lemura8145022020-01-06 18:47:54 +000023if sys.version_info.major == 2:
24 from StringIO import StringIO
25 import mock
26else:
27 from io import StringIO
28 from unittest import mock
29
maruel@chromium.orgddd59412011-11-30 14:20:38 +000030sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
31
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000032import metrics
33# We have to disable monitoring before importing git_cl.
34metrics.DISABLE_METRICS_COLLECTION = True
35
Jamie Madill5e96ad12020-01-13 16:08:35 +000036import clang_format
Edward Lemur227d5102020-02-25 23:45:35 +000037import contextlib
Edward Lemur1773f372020-02-22 00:27:14 +000038import gclient_utils
Eric Boren2fb63102018-10-05 13:05:03 +000039import gerrit_util
maruel@chromium.orgddd59412011-11-30 14:20:38 +000040import git_cl
iannucci@chromium.org9e849272014-04-04 00:31:55 +000041import git_common
tandrii@chromium.org57d86542016-03-04 16:11:32 +000042import git_footers
Edward Lemur85153282020-02-14 22:06:29 +000043import git_new_branch
44import scm
maruel@chromium.orgddd59412011-11-30 14:20:38 +000045import subprocess2
maruel@chromium.orgddd59412011-11-30 14:20:38 +000046
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000047
Edward Lemur0db01f02019-11-12 22:01:51 +000048def callError(code=1, cmd='', cwd='', stdout=b'', stderr=b''):
tandrii5d48c322016-08-18 16:19:37 -070049 return subprocess2.CalledProcessError(code, cmd, cwd, stdout, stderr)
50
tandrii5d48c322016-08-18 16:19:37 -070051CERR1 = callError(1)
52
53
Edward Lemur1773f372020-02-22 00:27:14 +000054class TemporaryFileMock(object):
55 def __init__(self):
56 self.suffix = 0
Aaron Gable9a03ae02017-11-03 11:31:07 -070057
Edward Lemur1773f372020-02-22 00:27:14 +000058 @contextlib.contextmanager
59 def __call__(self):
60 self.suffix += 1
61 yield '/tmp/fake-temp' + str(self.suffix)
Aaron Gable9a03ae02017-11-03 11:31:07 -070062
63
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000064class ChangelistMock(object):
65 # A class variable so we can access it when we don't have access to the
66 # instance that's being set.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000067 desc = ''
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000068 def __init__(self, **kwargs):
69 pass
70 def GetIssue(self):
71 return 1
Edward Lemur6c6827c2020-02-06 21:15:18 +000072 def FetchDescription(self):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000073 return ChangelistMock.desc
dsansomee2d6fd92016-09-08 00:10:47 -070074 def UpdateDescription(self, desc, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000075 ChangelistMock.desc = desc
76
tandrii5d48c322016-08-18 16:19:37 -070077
Edward Lemur85153282020-02-14 22:06:29 +000078class GitMocks(object):
79 def __init__(self, config=None, branchref=None):
80 self.branchref = branchref or 'refs/heads/master'
81 self.config = config or {}
82
83 def GetBranchRef(self, _root):
84 return self.branchref
85
86 def NewBranch(self, branchref):
87 self.branchref = branchref
88
Edward Lemur26964072020-02-19 19:18:51 +000089 def GetConfig(self, root, key, default=None):
90 if root != '':
91 key = '%s:%s' % (root, key)
Edward Lemur85153282020-02-14 22:06:29 +000092 return self.config.get(key, default)
93
Edward Lemur26964072020-02-19 19:18:51 +000094 def SetConfig(self, root, key, value=None):
95 if root != '':
96 key = '%s:%s' % (root, key)
Edward Lemur85153282020-02-14 22:06:29 +000097 if value:
98 self.config[key] = value
99 return
100 if key not in self.config:
101 raise CERR1
102 del self.config[key]
103
104
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000105class WatchlistsMock(object):
106 def __init__(self, _):
107 pass
108 @staticmethod
109 def GetWatchersForPaths(_):
110 return ['joe@example.com']
111
112
Edward Lemur4c707a22019-09-24 21:13:43 +0000113class CodereviewSettingsFileMock(object):
114 def __init__(self):
115 pass
116 # pylint: disable=no-self-use
117 def read(self):
118 return ('CODE_REVIEW_SERVER: gerrit.chromium.org\n' +
119 'GERRIT_HOST: True\n')
120
121
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000122class AuthenticatorMock(object):
123 def __init__(self, *_args):
124 pass
125 def has_cached_credentials(self):
126 return True
tandrii221ab252016-10-06 08:12:04 -0700127 def authorize(self, http):
128 return http
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000129
130
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100131def CookiesAuthenticatorMockFactory(hosts_with_creds=None, same_auth=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000132 """Use to mock Gerrit/Git credentials from ~/.netrc or ~/.gitcookies.
133
134 Usage:
135 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100136 CookiesAuthenticatorMockFactory({'host': ('user', _, 'pass')})
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000137
138 OR
139 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100140 CookiesAuthenticatorMockFactory(
141 same_auth=('user', '', 'pass'))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000142 """
143 class CookiesAuthenticatorMock(git_cl.gerrit_util.CookiesAuthenticator):
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800144 def __init__(self): # pylint: disable=super-init-not-called
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000145 # Intentionally not calling super() because it reads actual cookie files.
146 pass
147 @classmethod
148 def get_gitcookies_path(cls):
149 return '~/.gitcookies'
150 @classmethod
151 def get_netrc_path(cls):
152 return '~/.netrc'
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100153 def _get_auth_for_host(self, host):
154 if same_auth:
155 return same_auth
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000156 return (hosts_with_creds or {}).get(host)
157 return CookiesAuthenticatorMock
158
Aaron Gable9a03ae02017-11-03 11:31:07 -0700159
kmarshall9249e012016-08-23 12:02:16 -0700160class MockChangelistWithBranchAndIssue():
161 def __init__(self, branch, issue):
162 self.branch = branch
163 self.issue = issue
164 def GetBranch(self):
165 return self.branch
166 def GetIssue(self):
167 return self.issue
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000168
tandriic2405f52016-10-10 08:13:15 -0700169
170class SystemExitMock(Exception):
171 pass
172
173
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000174class TestGitClBasic(unittest.TestCase):
Josip Sokcevic953278a2020-02-28 19:46:36 +0000175 def setUp(self):
176 mock.patch('sys.exit', side_effect=SystemExitMock).start()
177 mock.patch('sys.stdout', StringIO()).start()
178 mock.patch('sys.stderr', StringIO()).start()
179 self.addCleanup(mock.patch.stopall)
180
181 def test_die_with_error(self):
182 with self.assertRaises(SystemExitMock):
183 git_cl.DieWithError('foo', git_cl.ChangeDescription('lorem ipsum'))
184 self.assertEqual(sys.stderr.getvalue(), 'foo\n')
185 self.assertTrue('saving CL description' in sys.stdout.getvalue())
186 self.assertTrue('Content of CL description' in sys.stdout.getvalue())
187 self.assertTrue('lorem ipsum' in sys.stdout.getvalue())
188 sys.exit.assert_called_once_with(1)
189
190 def test_die_with_error_no_desc(self):
191 with self.assertRaises(SystemExitMock):
192 git_cl.DieWithError('foo')
193 self.assertEqual(sys.stderr.getvalue(), 'foo\n')
194 self.assertEqual(sys.stdout.getvalue(), '')
195 sys.exit.assert_called_once_with(1)
196
Edward Lemur6c6827c2020-02-06 21:15:18 +0000197 def test_fetch_description(self):
Edward Lemurf38bc172019-09-03 21:02:13 +0000198 cl = git_cl.Changelist(issue=1, codereview_host='host')
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100199 cl.description = 'x'
Edward Lemur6c6827c2020-02-06 21:15:18 +0000200 self.assertEqual(cl.FetchDescription(), 'x')
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700201
Edward Lemur61bf4172020-02-24 23:22:37 +0000202 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
203 @mock.patch('git_cl.Changelist.GetStatus', lambda cl: cl.status)
204 def test_get_cl_statuses(self, *_mocks):
205 statuses = [
206 'closed', 'commit', 'dry-run', 'lgtm', 'reply', 'unsent', 'waiting']
207 changes = []
208 for status in statuses:
209 cl = git_cl.Changelist()
210 cl.status = status
211 changes.append(cl)
212
213 actual = set(git_cl.get_cl_statuses(changes, True))
214 self.assertEqual(set(zip(changes, statuses)), actual)
215
216 def test_get_cl_statuses_no_changes(self):
217 self.assertEqual([], list(git_cl.get_cl_statuses([], True)))
218
219 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
220 @mock.patch('multiprocessing.pool.ThreadPool')
221 def test_get_cl_statuses_timeout(self, *_mocks):
222 changes = [git_cl.Changelist() for _ in range(2)]
223 pool = multiprocessing.pool.ThreadPool()
224 it = pool.imap_unordered.return_value.__iter__ = mock.Mock()
225 it.return_value.next.side_effect = [
226 (changes[0], 'lgtm'),
227 multiprocessing.TimeoutError,
228 ]
229
230 actual = list(git_cl.get_cl_statuses(changes, True))
231 self.assertEqual([(changes[0], 'lgtm'), (changes[1], 'error')], actual)
232
233 @mock.patch('git_cl.Changelist.GetIssueURL')
234 def test_get_cl_statuses_not_finegrained(self, _mock):
235 changes = [git_cl.Changelist() for _ in range(2)]
236 urls = ['some-url', None]
237 git_cl.Changelist.GetIssueURL.side_effect = urls
238
239 actual = set(git_cl.get_cl_statuses(changes, False))
240 self.assertEqual(
241 set([(changes[0], 'waiting'), (changes[1], 'error')]), actual)
242
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +0000243 def test_set_preserve_tryjobs(self):
244 d = git_cl.ChangeDescription('Simple.')
245 d.set_preserve_tryjobs()
246 self.assertEqual(d.description.splitlines(), [
247 'Simple.',
248 '',
249 'Cq-Do-Not-Cancel-Tryjobs: true',
250 ])
251 before = d.description
252 d.set_preserve_tryjobs()
253 self.assertEqual(before, d.description)
254
255 d = git_cl.ChangeDescription('\n'.join([
256 'One is enough',
257 '',
258 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
259 'Change-Id: Ideadbeef',
260 ]))
261 d.set_preserve_tryjobs()
262 self.assertEqual(d.description.splitlines(), [
263 'One is enough',
264 '',
265 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
266 'Change-Id: Ideadbeef',
267 'Cq-Do-Not-Cancel-Tryjobs: true',
268 ])
269
tandriif9aefb72016-07-01 09:06:51 -0700270 def test_get_bug_line_values(self):
271 f = lambda p, bugs: list(git_cl._get_bug_line_values(p, bugs))
272 self.assertEqual(f('', ''), [])
273 self.assertEqual(f('', '123,v8:456'), ['123', 'v8:456'])
274 self.assertEqual(f('v8', '456'), ['v8:456'])
275 self.assertEqual(f('v8', 'chromium:123,456'), ['v8:456', 'chromium:123'])
276 # Not nice, but not worth carying.
277 self.assertEqual(f('v8', 'chromium:123,456,v8:123'),
278 ['v8:456', 'chromium:123', 'v8:123'])
279
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100280 def _test_git_number(self, parent_msg, dest_ref, child_msg,
281 parent_hash='parenthash'):
282 desc = git_cl.ChangeDescription(child_msg)
283 desc.update_with_git_number_footers(parent_hash, parent_msg, dest_ref)
284 return desc.description
285
286 def assertEqualByLine(self, actual, expected):
287 self.assertEqual(actual.splitlines(), expected.splitlines())
288
289 def test_git_number_bad_parent(self):
290 with self.assertRaises(ValueError):
291 self._test_git_number('Parent', 'refs/heads/master', 'Child')
292
293 def test_git_number_bad_parent_footer(self):
294 with self.assertRaises(AssertionError):
295 self._test_git_number(
296 'Parent\n'
297 '\n'
298 'Cr-Commit-Position: wrong',
299 'refs/heads/master', 'Child')
300
301 def test_git_number_bad_lineage_ignored(self):
302 actual = self._test_git_number(
303 'Parent\n'
304 '\n'
305 'Cr-Commit-Position: refs/heads/master@{#1}\n'
306 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}',
307 'refs/heads/master', 'Child')
308 self.assertEqualByLine(
309 actual,
310 'Child\n'
311 '\n'
312 'Cr-Commit-Position: refs/heads/master@{#2}\n'
313 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}')
314
315 def test_git_number_same_branch(self):
316 actual = self._test_git_number(
317 'Parent\n'
318 '\n'
319 'Cr-Commit-Position: refs/heads/master@{#12}',
320 dest_ref='refs/heads/master',
321 child_msg='Child')
322 self.assertEqualByLine(
323 actual,
324 'Child\n'
325 '\n'
326 'Cr-Commit-Position: refs/heads/master@{#13}')
327
Andrii Shyshkalovde37c012017-07-06 21:06:50 +0200328 def test_git_number_same_branch_mixed_footers(self):
329 actual = self._test_git_number(
330 'Parent\n'
331 '\n'
332 'Cr-Commit-Position: refs/heads/master@{#12}',
333 dest_ref='refs/heads/master',
334 child_msg='Child\n'
335 '\n'
336 'Broken-by: design\n'
337 'BUG=123')
338 self.assertEqualByLine(
339 actual,
340 'Child\n'
341 '\n'
342 'Broken-by: design\n'
343 'BUG=123\n'
344 'Cr-Commit-Position: refs/heads/master@{#13}')
345
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100346 def test_git_number_same_branch_with_originals(self):
347 actual = self._test_git_number(
348 'Parent\n'
349 '\n'
350 'Cr-Commit-Position: refs/heads/master@{#12}',
351 dest_ref='refs/heads/master',
352 child_msg='Child\n'
353 '\n'
354 'Some users are smart and insert their own footers\n'
355 '\n'
356 'Cr-Whatever: value\n'
357 'Cr-Commit-Position: refs/copy/paste@{#22}')
358 self.assertEqualByLine(
359 actual,
360 'Child\n'
361 '\n'
362 'Some users are smart and insert their own footers\n'
363 '\n'
364 'Cr-Original-Whatever: value\n'
365 'Cr-Original-Commit-Position: refs/copy/paste@{#22}\n'
366 'Cr-Commit-Position: refs/heads/master@{#13}')
367
368 def test_git_number_new_branch(self):
369 actual = self._test_git_number(
370 'Parent\n'
371 '\n'
372 'Cr-Commit-Position: refs/heads/master@{#12}',
373 dest_ref='refs/heads/branch',
374 child_msg='Child')
375 self.assertEqualByLine(
376 actual,
377 'Child\n'
378 '\n'
379 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
380 'Cr-Branched-From: parenthash-refs/heads/master@{#12}')
381
382 def test_git_number_lineage(self):
383 actual = self._test_git_number(
384 'Parent\n'
385 '\n'
386 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
387 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
388 dest_ref='refs/heads/branch',
389 child_msg='Child')
390 self.assertEqualByLine(
391 actual,
392 'Child\n'
393 '\n'
394 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
395 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
396
397 def test_git_number_moooooooore_lineage(self):
398 actual = self._test_git_number(
399 'Parent\n'
400 '\n'
401 'Cr-Commit-Position: refs/heads/branch@{#5}\n'
402 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
403 dest_ref='refs/heads/mooore',
404 child_msg='Child')
405 self.assertEqualByLine(
406 actual,
407 'Child\n'
408 '\n'
409 'Cr-Commit-Position: refs/heads/mooore@{#1}\n'
410 'Cr-Branched-From: parenthash-refs/heads/branch@{#5}\n'
411 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
412
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100413 def test_git_number_ever_moooooooore_lineage(self):
Robert Iannucci456b0d62018-03-13 19:15:50 -0700414 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100415 actual = self._test_git_number(
416 'CQ commit on fresh new branch + numbering.\n'
417 '\n'
418 'NOTRY=True\n'
419 'NOPRESUBMIT=True\n'
420 'BUG=\n'
421 '\n'
422 'Review-Url: https://codereview.chromium.org/2577703003\n'
423 'Cr-Commit-Position: refs/heads/gnumb-test/br@{#1}\n'
424 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
425 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}',
426 dest_ref='refs/heads/gnumb-test/cl',
427 child_msg='git cl on fresh new branch + numbering.\n'
428 '\n'
429 'Review-Url: https://codereview.chromium.org/2575043003 .\n')
430 self.assertEqualByLine(
431 actual,
432 'git cl on fresh new branch + numbering.\n'
433 '\n'
434 'Review-Url: https://codereview.chromium.org/2575043003 .\n'
435 'Cr-Commit-Position: refs/heads/gnumb-test/cl@{#1}\n'
436 'Cr-Branched-From: parenthash-refs/heads/gnumb-test/br@{#1}\n'
437 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
438 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}')
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100439
440 def test_git_number_cherry_pick(self):
441 actual = self._test_git_number(
442 'Parent\n'
443 '\n'
444 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
445 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
446 dest_ref='refs/heads/branch',
447 child_msg='Child, which is cherry-pick from master\n'
448 '\n'
449 'Cr-Commit-Position: refs/heads/master@{#100}\n'
450 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)')
451 self.assertEqualByLine(
452 actual,
453 'Child, which is cherry-pick from master\n'
454 '\n'
455 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)\n'
456 '\n'
457 'Cr-Original-Commit-Position: refs/heads/master@{#100}\n'
458 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
459 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
460
Edward Lemurda4b6c62020-02-13 00:28:40 +0000461 @mock.patch('gerrit_util.GetAccountDetails')
462 def test_valid_accounts(self, mockGetAccountDetails):
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000463 mock_per_account = {
464 'u1': None, # 404, doesn't exist.
465 'u2': {
466 '_account_id': 123124,
467 'avatars': [],
468 'email': 'u2@example.com',
469 'name': 'User Number 2',
470 'status': 'OOO',
471 },
472 'u3': git_cl.gerrit_util.GerritError(500, 'retries didn\'t help :('),
473 }
474 def GetAccountDetailsMock(_, account):
475 # Poor-man's mock library's side_effect.
476 v = mock_per_account.pop(account)
477 if isinstance(v, Exception):
478 raise v
479 return v
480
Edward Lemurda4b6c62020-02-13 00:28:40 +0000481 mockGetAccountDetails.side_effect = GetAccountDetailsMock
482 actual = git_cl.gerrit_util.ValidAccounts(
483 'host', ['u1', 'u2', 'u3'], max_threads=1)
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000484 self.assertEqual(actual, {
485 'u2': {
486 '_account_id': 123124,
487 'avatars': [],
488 'email': 'u2@example.com',
489 'name': 'User Number 2',
490 'status': 'OOO',
491 },
492 })
493
494
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200495class TestParseIssueURL(unittest.TestCase):
496 def _validate(self, parsed, issue=None, patchset=None, hostname=None,
Edward Lemurf38bc172019-09-03 21:02:13 +0000497 fail=False):
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200498 self.assertIsNotNone(parsed)
499 if fail:
500 self.assertFalse(parsed.valid)
501 return
502 self.assertTrue(parsed.valid)
503 self.assertEqual(parsed.issue, issue)
504 self.assertEqual(parsed.patchset, patchset)
505 self.assertEqual(parsed.hostname, hostname)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200506
Edward Lemur678a6842019-10-03 22:25:05 +0000507 def test_ParseIssueNumberArgument(self):
508 def test(arg, *args, **kwargs):
509 self._validate(git_cl.ParseIssueNumberArgument(arg), *args, **kwargs)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200510
Edward Lemur678a6842019-10-03 22:25:05 +0000511 test('123', 123)
512 test('', fail=True)
513 test('abc', fail=True)
514 test('123/1', fail=True)
515 test('123a', fail=True)
516 test('ssh://chrome-review.source.com/#/c/123/4/', fail=True)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200517
Edward Lemur678a6842019-10-03 22:25:05 +0000518 test('https://codereview.source.com/123',
519 123, None, 'codereview.source.com')
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200520 test('http://chrome-review.source.com/c/123',
521 123, None, 'chrome-review.source.com')
522 test('https://chrome-review.source.com/c/123/',
523 123, None, 'chrome-review.source.com')
524 test('https://chrome-review.source.com/c/123/4',
525 123, 4, 'chrome-review.source.com')
526 test('https://chrome-review.source.com/#/c/123/4',
527 123, 4, 'chrome-review.source.com')
528 test('https://chrome-review.source.com/c/123/4',
529 123, 4, 'chrome-review.source.com')
530 test('https://chrome-review.source.com/123',
531 123, None, 'chrome-review.source.com')
532 test('https://chrome-review.source.com/123/4',
533 123, 4, 'chrome-review.source.com')
534
Edward Lemur678a6842019-10-03 22:25:05 +0000535 test('https://chrome-review.source.com/bad/123/4', fail=True)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200536 test('https://chrome-review.source.com/c/123/1/whatisthis', fail=True)
537 test('https://chrome-review.source.com/c/abc/', fail=True)
538 test('ssh://chrome-review.source.com/c/123/1/', fail=True)
539
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200540
541
Edward Lemurda4b6c62020-02-13 00:28:40 +0000542class GitCookiesCheckerTest(unittest.TestCase):
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100543 def setUp(self):
544 super(GitCookiesCheckerTest, self).setUp()
545 self.c = git_cl._GitCookiesChecker()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100546 self.c._all_hosts = []
Edward Lemurda4b6c62020-02-13 00:28:40 +0000547 mock.patch('sys.stdout', StringIO()).start()
548 self.addCleanup(mock.patch.stopall)
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100549
550 def mock_hosts_creds(self, subhost_identity_pairs):
551 def ensure_googlesource(h):
552 if not h.endswith(self.c._GOOGLESOURCE):
553 assert not h.endswith('.')
554 return h + '.' + self.c._GOOGLESOURCE
555 return h
556 self.c._all_hosts = [(ensure_googlesource(h), i, '.gitcookies')
557 for h, i in subhost_identity_pairs]
558
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200559 def test_identity_parsing(self):
560 self.assertEqual(self.c._parse_identity('ldap.google.com'),
561 ('ldap', 'google.com'))
562 self.assertEqual(self.c._parse_identity('git-ldap.example.com'),
563 ('ldap', 'example.com'))
564 # Specical case because we know there are no subdomains in chromium.org.
565 self.assertEqual(self.c._parse_identity('git-note.period.chromium.org'),
566 ('note.period', 'chromium.org'))
Lei Zhangd3f769a2017-12-15 15:16:14 -0800567 # Pathological: ".period." can be either username OR domain, more likely
568 # domain.
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200569 self.assertEqual(self.c._parse_identity('git-note.period.example.com'),
570 ('note', 'period.example.com'))
571
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100572 def test_analysis_nothing(self):
573 self.c._all_hosts = []
574 self.assertFalse(self.c.has_generic_host())
575 self.assertEqual(set(), self.c.get_conflicting_hosts())
576 self.assertEqual(set(), self.c.get_duplicated_hosts())
577 self.assertEqual(set(), self.c.get_partially_configured_hosts())
578 self.assertEqual(set(), self.c.get_hosts_with_wrong_identities())
579
580 def test_analysis(self):
581 self.mock_hosts_creds([
582 ('.googlesource.com', 'git-example.chromium.org'),
583
584 ('chromium', 'git-example.google.com'),
585 ('chromium-review', 'git-example.google.com'),
586 ('chrome-internal', 'git-example.chromium.org'),
587 ('chrome-internal-review', 'git-example.chromium.org'),
588 ('conflict', 'git-example.google.com'),
589 ('conflict-review', 'git-example.chromium.org'),
590 ('dup', 'git-example.google.com'),
591 ('dup', 'git-example.google.com'),
592 ('dup-review', 'git-example.google.com'),
593 ('partial', 'git-example.google.com'),
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200594 ('gpartial-review', 'git-example.google.com'),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100595 ])
596 self.assertTrue(self.c.has_generic_host())
597 self.assertEqual(set(['conflict.googlesource.com']),
598 self.c.get_conflicting_hosts())
599 self.assertEqual(set(['dup.googlesource.com']),
600 self.c.get_duplicated_hosts())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200601 self.assertEqual(set(['partial.googlesource.com',
602 'gpartial-review.googlesource.com']),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100603 self.c.get_partially_configured_hosts())
604 self.assertEqual(set(['chromium.googlesource.com',
605 'chrome-internal.googlesource.com']),
606 self.c.get_hosts_with_wrong_identities())
607
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100608 def test_report_no_problems(self):
609 self.test_analysis_nothing()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100610 self.assertFalse(self.c.find_and_report_problems())
611 self.assertEqual(sys.stdout.getvalue(), '')
612
Edward Lemurda4b6c62020-02-13 00:28:40 +0000613 @mock.patch(
614 'git_cl.gerrit_util.CookiesAuthenticator.get_gitcookies_path',
615 return_value='~/.gitcookies')
616 def test_report(self, *_mocks):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100617 self.test_analysis()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100618 self.assertTrue(self.c.find_and_report_problems())
619 with open(os.path.join(os.path.dirname(__file__),
620 'git_cl_creds_check_report.txt')) as f:
621 expected = f.read()
622 def by_line(text):
623 return [l.rstrip() for l in text.rstrip().splitlines()]
Robert Iannucci456b0d62018-03-13 19:15:50 -0700624 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalov4812e612017-03-27 17:22:57 +0200625 self.assertEqual(by_line(sys.stdout.getvalue().strip()), by_line(expected))
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100626
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -0800627
Edward Lemurda4b6c62020-02-13 00:28:40 +0000628class TestGitCl(unittest.TestCase):
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000629 def setUp(self):
630 super(TestGitCl, self).setUp()
631 self.calls = []
tandrii9d206752016-06-20 11:32:47 -0700632 self._calls_done = []
Edward Lemurda4b6c62020-02-13 00:28:40 +0000633 mock.patch('sys.stdout', StringIO()).start()
634 mock.patch(
635 'git_cl.time_time',
636 lambda: self._mocked_call('time.time')).start()
637 mock.patch(
638 'git_cl.metrics.collector.add_repeated',
639 lambda *a: self._mocked_call('add_repeated', *a)).start()
640 mock.patch('subprocess2.call', self._mocked_call).start()
641 mock.patch('subprocess2.check_call', self._mocked_call).start()
642 mock.patch('subprocess2.check_output', self._mocked_call).start()
643 mock.patch(
644 'subprocess2.communicate',
645 lambda *a, **_k: ([self._mocked_call(*a), ''], 0)).start()
646 mock.patch(
647 'git_cl.gclient_utils.CheckCallAndFilter',
648 self._mocked_call).start()
649 mock.patch('git_common.is_dirty_git_tree', lambda x: False).start()
650 mock.patch(
651 'git_common.get_or_create_merge_base',
652 lambda *a: self._mocked_call('get_or_create_merge_base', *a)).start()
653 mock.patch('git_cl.BranchExists', return_value=True).start()
654 mock.patch('git_cl.FindCodereviewSettingsFile', return_value='').start()
655 mock.patch(
656 'git_cl.SaveDescriptionBackup',
657 lambda _: self._mocked_call('SaveDescriptionBackup')).start()
658 mock.patch(
Edward Lemurda4b6c62020-02-13 00:28:40 +0000659 'git_cl.write_json',
660 lambda *a: self._mocked_call('write_json', *a)).start()
661 mock.patch(
Edward Lemur227d5102020-02-25 23:45:35 +0000662 'git_cl.Changelist.RunHook',
663 return_value={'more_cc': ['test-more-cc@chromium.org']}).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +0000664 mock.patch('git_cl.watchlists.Watchlists', WatchlistsMock).start()
665 mock.patch('git_cl.auth.Authenticator', AuthenticatorMock).start()
Edward Lesmes7677e5c2020-02-19 20:39:03 +0000666 mock.patch('gerrit_util.GetChangeDetail').start()
Edward Lemurda4b6c62020-02-13 00:28:40 +0000667 mock.patch(
668 'git_cl.gerrit_util.GetChangeComments',
669 lambda *a: self._mocked_call('GetChangeComments', *a)).start()
670 mock.patch(
671 'git_cl.gerrit_util.GetChangeRobotComments',
672 lambda *a: self._mocked_call('GetChangeRobotComments', *a)).start()
673 mock.patch(
674 'git_cl.gerrit_util.AddReviewers',
675 lambda *a: self._mocked_call('AddReviewers', *a)).start()
676 mock.patch(
677 'git_cl.gerrit_util.SetReview',
678 lambda h, i, msg=None, labels=None, notify=None, ready=None: (
679 self._mocked_call(
680 'SetReview', h, i, msg, labels, notify, ready))).start()
681 mock.patch(
682 'git_cl.gerrit_util.LuciContextAuthenticator.is_luci',
683 return_value=False).start()
684 mock.patch(
685 'git_cl.gerrit_util.GceAuthenticator.is_gce',
686 return_value=False).start()
687 mock.patch(
688 'git_cl.gerrit_util.ValidAccounts',
689 lambda *a: self._mocked_call('ValidAccounts', *a)).start()
Edward Lemurd55c5072020-02-20 01:09:07 +0000690 mock.patch('sys.exit', side_effect=SystemExitMock).start()
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000691 mock.patch('git_cl.Settings.GetRoot', return_value='').start()
Edward Lemur85153282020-02-14 22:06:29 +0000692 self.mockGit = GitMocks()
693 mock.patch('scm.GIT.GetBranchRef', self.mockGit.GetBranchRef).start()
694 mock.patch('scm.GIT.GetConfig', self.mockGit.GetConfig).start()
695 mock.patch('scm.GIT.SetConfig', self.mockGit.SetConfig).start()
Edward Lemur84101642020-02-21 21:40:34 +0000696 mock.patch(
697 'git_new_branch.create_new_branch', self.mockGit.NewBranch).start()
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000698 mock.patch(
Edward Lemur85153282020-02-14 22:06:29 +0000699 'scm.GIT.FetchUpstreamTuple',
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000700 return_value=('origin', 'refs/heads/master')).start()
Edward Lemur85153282020-02-14 22:06:29 +0000701 mock.patch(
702 'scm.GIT.CaptureStatus', return_value=[('M', 'foo.txt')]).start()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000703 # It's important to reset settings to not have inter-tests interference.
704 git_cl.settings = None
Edward Lemurda4b6c62020-02-13 00:28:40 +0000705 self.addCleanup(mock.patch.stopall)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000706
707 def tearDown(self):
wychen@chromium.org445c8962015-04-28 23:30:05 +0000708 try:
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +0000709 self.assertEqual([], self.calls)
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100710 except AssertionError:
Edward Lemur85153282020-02-14 22:06:29 +0000711 calls = ''.join(' %s\n' % str(call) for call in self.calls[:5])
712 if len(self.calls) > 5:
713 calls += ' ...\n'
714 self.fail(
715 '\n'
716 'There are un-consumed calls after this test has finished:\n' +
717 calls)
wychen@chromium.org445c8962015-04-28 23:30:05 +0000718 finally:
719 super(TestGitCl, self).tearDown()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000720
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000721 def _mocked_call(self, *args, **_kwargs):
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000722 self.assertTrue(
723 self.calls,
tandrii9d206752016-06-20 11:32:47 -0700724 '@%d Expected: <Missing> Actual: %r' % (len(self._calls_done), args))
wychen@chromium.orga872e752015-04-28 23:42:18 +0000725 top = self.calls.pop(0)
wychen@chromium.orga872e752015-04-28 23:42:18 +0000726 expected_args, result = top
727
maruel@chromium.orge52678e2013-04-26 18:34:44 +0000728 # Also logs otherwise it could get caught in a try/finally and be hard to
729 # diagnose.
730 if expected_args != args:
tandrii9d206752016-06-20 11:32:47 -0700731 N = 5
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000732 prior_calls = '\n '.join(
tandrii9d206752016-06-20 11:32:47 -0700733 '@%d: %r' % (len(self._calls_done) - N + i, c[0])
734 for i, c in enumerate(self._calls_done[-N:]))
735 following_calls = '\n '.join(
736 '@%d: %r' % (len(self._calls_done) + i + 1, c[0])
737 for i, c in enumerate(self.calls[:N]))
738 extended_msg = (
739 'A few prior calls:\n %s\n\n'
740 'This (expected):\n @%d: %r\n'
741 'This (actual):\n @%d: %r\n\n'
742 'A few following expected calls:\n %s' %
743 (prior_calls, len(self._calls_done), expected_args,
744 len(self._calls_done), args, following_calls))
tandrii9d206752016-06-20 11:32:47 -0700745
tandrii99a72f22016-08-17 14:33:24 -0700746 self.fail('@%d\n'
747 ' Expected: %r\n'
Edward Lemur26964072020-02-19 19:18:51 +0000748 ' Actual: %r\n'
749 '\n'
750 '%s' % (
751 len(self._calls_done), expected_args, args, extended_msg))
tandrii9d206752016-06-20 11:32:47 -0700752
753 self._calls_done.append(top)
tandrii5d48c322016-08-18 16:19:37 -0700754 if isinstance(result, Exception):
755 raise result
Edward Lemur0db01f02019-11-12 22:01:51 +0000756 # stdout from git commands is supposed to be a bytestream. Convert it here
757 # instead of converting all test output in this file to bytes.
758 if args[0][0] == 'git' and not isinstance(result, bytes):
759 result = result.encode('utf-8')
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000760 return result
761
Edward Lemur1a83da12020-03-04 21:18:36 +0000762 @mock.patch('sys.stdin', StringIO('blah\nye\n'))
763 @mock.patch('sys.stdout', StringIO())
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100764 def test_ask_for_explicit_yes_true(self):
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100765 self.assertTrue(git_cl.ask_for_explicit_yes('prompt'))
Edward Lemur1a83da12020-03-04 21:18:36 +0000766 self.assertEqual(
767 'prompt [Yes/No]: Please, type yes or no: ',
768 sys.stdout.getvalue())
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100769
tandrii48df5812016-10-17 03:55:37 -0700770 def test_LoadCodereviewSettingsFromFile_gerrit(self):
Edward Lemur79d4f992019-11-11 23:49:02 +0000771 codereview_file = StringIO('GERRIT_HOST: true')
tandrii48df5812016-10-17 03:55:37 -0700772 self.calls = [
773 ((['git', 'config', '--unset-all', 'rietveld.cc'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700774 ((['git', 'config', '--unset-all', 'rietveld.tree-status-url'],), CERR1),
775 ((['git', 'config', '--unset-all', 'rietveld.viewvc-url'],), CERR1),
776 ((['git', 'config', '--unset-all', 'rietveld.bug-prefix'],), CERR1),
777 ((['git', 'config', '--unset-all', 'rietveld.cpplint-regex'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700778 ((['git', 'config', '--unset-all', 'rietveld.cpplint-ignore-regex'],),
779 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700780 ((['git', 'config', '--unset-all', 'rietveld.run-post-upload-hook'],),
781 CERR1),
Jamie Madilldc4d19e2019-10-24 21:50:02 +0000782 ((['git', 'config', '--unset-all', 'rietveld.format-full-by-default'],),
783 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700784 ((['git', 'config', 'gerrit.host', 'true'],), ''),
785 ]
786 self.assertIsNone(git_cl.LoadCodereviewSettingsFromFile(codereview_file))
787
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000788 @classmethod
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100789 def _gerrit_base_calls(cls, issue=None, fetched_description=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200790 fetched_status=None, other_cl_owner=None,
Anthony Polito8b955342019-09-24 19:01:36 +0000791 custom_cl_base=None, short_hostname='chromium',
792 change_id=None):
Edward Lemur26964072020-02-19 19:18:51 +0000793 calls = []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200794 if custom_cl_base:
795 ancestor_revision = custom_cl_base
796 else:
797 # Determine ancestor_revision to be merge base.
798 ancestor_revision = 'fake_ancestor_sha'
799 calls += [
Edward Lemurda4b6c62020-02-13 00:28:40 +0000800 (('get_or_create_merge_base', 'master', 'refs/remotes/origin/master'),
801 ancestor_revision),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200802 ]
803
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100804 if issue:
Edward Lesmes7677e5c2020-02-19 20:39:03 +0000805 gerrit_util.GetChangeDetail.return_value = {
806 'owner': {'email': (other_cl_owner or 'owner@example.com')},
807 'change_id': (change_id or '123456789'),
808 'current_revision': 'sha1_of_current_revision',
809 'revisions': {'sha1_of_current_revision': {
810 'commit': {'message': fetched_description},
811 }},
812 'status': fetched_status or 'NEW',
813 }
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100814 if fetched_status == 'ABANDONED':
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100815 return calls
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100816 if other_cl_owner:
817 calls += [
818 (('ask_for_data', 'Press Enter to upload, or Ctrl+C to abort'), ''),
819 ]
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100820
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100821 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200822 ((['git', 'rev-parse', 'HEAD'],), '12345'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100823 ]
824
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100825 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200826 ((['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] +
827 ([custom_cl_base] if custom_cl_base else
828 [ancestor_revision, 'HEAD']),),
829 '+dat'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100830 ]
831 return calls
ukai@chromium.orge8077812012-02-03 03:41:46 +0000832
Edward Lemur26964072020-02-19 19:18:51 +0000833 def _gerrit_upload_calls(self, description, reviewers, squash,
tandriia60502f2016-06-20 02:01:53 -0700834 squash_mode='default',
tandrii@chromium.org10625002016-03-04 20:03:47 +0000835 expected_upstream_ref='origin/refs/heads/master',
Aaron Gablefd238082017-06-07 13:42:34 -0700836 title=None, notify=False,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +0100837 post_amend_description=None, issue=None, cc=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000838 custom_cl_base=None, tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +0000839 short_hostname='chromium',
Edward Lemur1b52d872019-05-09 21:12:12 +0000840 labels=None, change_id=None, original_title=None,
Anthony Polito8b955342019-09-24 19:01:36 +0000841 final_description=None, gitcookies_exists=True,
Josipe827b0f2020-01-30 00:07:20 +0000842 force=False, edit_description=None):
tandrii@chromium.org10625002016-03-04 20:03:47 +0000843 if post_amend_description is None:
844 post_amend_description = description
bradnelsond975b302016-10-23 12:20:23 -0700845 cc = cc or []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200846 # Determined in `_gerrit_base_calls`.
847 determined_ancestor_revision = custom_cl_base or 'fake_ancestor_sha'
848
849 calls = []
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000850
Edward Lemur26964072020-02-19 19:18:51 +0000851 if squash_mode in ('override_squash', 'override_nosquash'):
852 self.mockGit.config['gerrit.override-squash-uploads'] = (
853 'true' if squash_mode == 'override_squash' else 'false')
tandriia60502f2016-06-20 02:01:53 -0700854
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000855 # If issue is given, then description is fetched from Gerrit instead.
856 if issue is None:
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000857 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200858 ((['git', 'log', '--pretty=format:%s\n\n%b',
859 ((custom_cl_base + '..') if custom_cl_base else
860 'fake_ancestor_sha..HEAD')],),
861 description),
862 ]
Aaron Gableb56ad332017-01-06 15:24:31 -0800863 if squash:
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000864 title = 'Initial_upload'
Aaron Gableb56ad332017-01-06 15:24:31 -0800865 else:
866 if not title:
867 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200868 ((['git', 'show', '-s', '--format=%s', 'HEAD'],), ''),
869 (('ask_for_data', 'Title for patchset []: '), 'User input'),
Aaron Gableb56ad332017-01-06 15:24:31 -0800870 ]
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000871 title = 'User_input'
tandrii@chromium.org57d86542016-03-04 16:11:32 +0000872 if not git_footers.get_footer_change_id(description) and not squash:
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000873 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200874 (('DownloadGerritHook', False), ''),
875 # Amending of commit message to get the Change-Id.
876 ((['git', 'log', '--pretty=format:%s\n\n%b',
877 determined_ancestor_revision + '..HEAD'],),
878 description),
879 ((['git', 'commit', '--amend', '-m', description],), ''),
880 ((['git', 'log', '--pretty=format:%s\n\n%b',
881 determined_ancestor_revision + '..HEAD'],),
882 post_amend_description)
883 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000884 if squash:
Anthony Polito8b955342019-09-24 19:01:36 +0000885 if force or not issue:
Anthony Polito8b955342019-09-24 19:01:36 +0000886 if not force:
887 calls += [
Anthony Polito8b955342019-09-24 19:01:36 +0000888 ((['RunEditor'],), description),
889 ]
Josipe827b0f2020-01-30 00:07:20 +0000890 # user wants to edit description
891 if edit_description:
892 calls += [
Josipe827b0f2020-01-30 00:07:20 +0000893 ((['RunEditor'],), edit_description),
894 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000895 ref_to_push = 'abcdef0123456789'
896 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200897 ]
898
899 if custom_cl_base is None:
900 calls += [
Edward Lemurda4b6c62020-02-13 00:28:40 +0000901 (('get_or_create_merge_base', 'master', 'refs/remotes/origin/master'),
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000902 'origin/master'),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200903 ]
904 parent = 'origin/master'
905 else:
906 calls += [
907 ((['git', 'merge-base', '--is-ancestor', custom_cl_base,
908 'refs/remotes/origin/master'],),
909 callError(1)), # Means not ancenstor.
910 (('ask_for_data',
911 'Do you take responsibility for cleaning up potential mess '
912 'resulting from proceeding with upload? Press Enter to upload, '
913 'or Ctrl+C to abort'), ''),
914 ]
915 parent = custom_cl_base
916
917 calls += [
918 ((['git', 'rev-parse', 'HEAD:'],), # `HEAD:` means HEAD's tree hash.
919 '0123456789abcdef'),
Edward Lemur1773f372020-02-22 00:27:14 +0000920 ((['FileWrite', '/tmp/fake-temp1', description],), None),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200921 ((['git', 'commit-tree', '0123456789abcdef', '-p', parent,
Edward Lemur1773f372020-02-22 00:27:14 +0000922 '-F', '/tmp/fake-temp1'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200923 ref_to_push),
924 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000925 else:
926 ref_to_push = 'HEAD'
927
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000928 calls += [
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000929 (('SaveDescriptionBackup',), None),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200930 ((['git', 'rev-list',
931 (custom_cl_base if custom_cl_base else expected_upstream_ref) + '..' +
932 ref_to_push],),
933 '1hashPerLine\n'),
934 ]
tandrii@chromium.org8da45402016-05-24 23:11:03 +0000935
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000936 metrics_arguments = []
937
Aaron Gableafd52772017-06-27 16:40:10 -0700938 if notify:
Aaron Gable844cf292017-06-28 11:32:59 -0700939 ref_suffix = '%ready,notify=ALL'
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000940 metrics_arguments += ['ready', 'notify=ALL']
Aaron Gable844cf292017-06-28 11:32:59 -0700941 else:
Jamie Madill276da0b2018-04-27 14:41:20 -0400942 if not issue and squash:
Aaron Gable844cf292017-06-28 11:32:59 -0700943 ref_suffix = '%wip'
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000944 metrics_arguments.append('wip')
Aaron Gable844cf292017-06-28 11:32:59 -0700945 else:
946 ref_suffix = '%notify=NONE'
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000947 metrics_arguments.append('notify=NONE')
Aaron Gable9b713dd2016-12-14 16:04:21 -0800948
Aaron Gable70f4e242017-06-26 10:45:59 -0700949 if title:
Aaron Gableafd52772017-06-27 16:40:10 -0700950 ref_suffix += ',m=' + title
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000951 metrics_arguments.append('m')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000952
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000953 if short_hostname == 'chromium':
954 # All reviwers and ccs get into ref_suffix.
955 for r in sorted(reviewers):
956 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000957 metrics_arguments.append('r')
Edward Lemur4508b422019-10-03 21:56:35 +0000958 if issue is None:
Edward Lemur227d5102020-02-25 23:45:35 +0000959 cc += ['test-more-cc@chromium.org', 'joe@example.com']
Edward Lemur4508b422019-10-03 21:56:35 +0000960 for c in sorted(cc):
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000961 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000962 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000963 reviewers, cc = [], []
964 else:
965 # TODO(crbug/877717): remove this case.
966 calls += [
967 (('ValidAccounts', '%s-review.googlesource.com' % short_hostname,
968 sorted(reviewers) + ['joe@example.com',
Edward Lemur227d5102020-02-25 23:45:35 +0000969 'test-more-cc@chromium.org'] + cc),
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000970 {
971 e: {'email': e}
972 for e in (reviewers + ['joe@example.com'] + cc)
973 })
974 ]
975 for r in sorted(reviewers):
976 if r != 'bad-account-or-email':
977 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000978 metrics_arguments.append('r')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000979 reviewers.remove(r)
Edward Lemur4508b422019-10-03 21:56:35 +0000980 if issue is None:
981 cc += ['joe@example.com']
982 for c in sorted(cc):
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000983 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000984 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000985 if c in cc:
986 cc.remove(c)
Andrii Shyshkalov76988a82018-10-15 03:12:25 +0000987
Edward Lemur687ca902018-12-05 02:30:30 +0000988 for k, v in sorted((labels or {}).items()):
989 ref_suffix += ',l=%s+%d' % (k, v)
990 metrics_arguments.append('l=%s+%d' % (k, v))
991
992 if tbr:
993 calls += [
994 (('GetCodeReviewTbrScore',
995 '%s-review.googlesource.com' % short_hostname,
996 'my/repo'),
997 2,),
998 ]
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +0000999
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001000 calls += [
1001 (('time.time',), 1000,),
1002 ((['git', 'push',
1003 'https://%s.googlesource.com/my/repo' % short_hostname,
1004 ref_to_push + ':refs/for/refs/heads/master' + ref_suffix],),
1005 (('remote:\n'
1006 'remote: Processing changes: (\)\n'
1007 'remote: Processing changes: (|)\n'
1008 'remote: Processing changes: (/)\n'
1009 'remote: Processing changes: (-)\n'
1010 'remote: Processing changes: new: 1 (/)\n'
1011 'remote: Processing changes: new: 1, done\n'
1012 'remote:\n'
1013 'remote: New Changes:\n'
1014 'remote: https://%s-review.googlesource.com/#/c/my/repo/+/123456'
1015 ' XXX\n'
1016 'remote:\n'
1017 'To https://%s.googlesource.com/my/repo\n'
1018 ' * [new branch] hhhh -> refs/for/refs/heads/master\n'
1019 ) % (short_hostname, short_hostname)),),
1020 (('time.time',), 2000,),
1021 (('add_repeated',
1022 'sub_commands',
1023 {
1024 'execution_time': 1000,
1025 'command': 'git push',
1026 'exit_code': 0,
1027 'arguments': sorted(metrics_arguments),
1028 }),
1029 None,),
1030 ]
1031
Edward Lemur1b52d872019-05-09 21:12:12 +00001032 final_description = final_description or post_amend_description.strip()
1033 original_title = original_title or title or '<untitled>'
1034 # Trace-related calls
1035 calls += [
1036 # Write a description with context for the current trace.
1037 ((['FileWrite', 'TRACES_DIR/20170316T200041.000000-README',
Edward Lemur75391d42019-05-14 23:35:56 +00001038 'Thu Mar 16 20:00:41 2017\n'
1039 '%(short_hostname)s-review.googlesource.com\n'
1040 '%(change_id)s\n'
1041 '%(title)s\n'
1042 '%(description)s\n'
1043 '1000\n'
1044 '0\n'
1045 '%(trace_name)s' % {
Edward Lemur1b52d872019-05-09 21:12:12 +00001046 'short_hostname': short_hostname,
1047 'change_id': change_id,
1048 'description': final_description,
1049 'title': original_title,
Edward Lemur75391d42019-05-14 23:35:56 +00001050 'trace_name': 'TRACES_DIR/20170316T200041.000000',
Edward Lemur1b52d872019-05-09 21:12:12 +00001051 }],),
1052 None,
1053 ),
1054 # Read traces and shorten git hashes.
1055 ((['os.path.isfile', 'TEMP_DIR/trace-packet'],),
1056 True,
1057 ),
1058 ((['FileRead', 'TEMP_DIR/trace-packet'],),
1059 ('git-hash: 0123456789012345678901234567890123456789\n'
1060 'git-hash: abcdeabcdeabcdeabcdeabcdeabcdeabcdeabcde\n'),
1061 ),
1062 ((['FileWrite', 'TEMP_DIR/trace-packet',
1063 'git-hash: 012345\n'
1064 'git-hash: abcdea\n'],),
1065 None,
1066 ),
1067 # Make zip file for the git traces.
1068 ((['make_archive', 'TRACES_DIR/20170316T200041.000000-traces', 'zip',
1069 'TEMP_DIR'],),
1070 None,
1071 ),
1072 # Collect git config and gitcookies.
1073 ((['git', 'config', '-l'],),
1074 'git-config-output',
1075 ),
1076 ((['FileWrite', 'TEMP_DIR/git-config', 'git-config-output'],),
1077 None,
1078 ),
1079 ((['os.path.isfile', '~/.gitcookies'],),
1080 gitcookies_exists,
1081 ),
1082 ]
1083 if gitcookies_exists:
1084 calls += [
1085 ((['FileRead', '~/.gitcookies'],),
1086 'gitcookies 1/SECRET',
1087 ),
1088 ((['FileWrite', 'TEMP_DIR/gitcookies', 'gitcookies REDACTED'],),
1089 None,
1090 ),
1091 ]
1092 calls += [
1093 # Make zip file for the git config and gitcookies.
1094 ((['make_archive', 'TRACES_DIR/20170316T200041.000000-git-info', 'zip',
1095 'TEMP_DIR'],),
1096 None,
1097 ),
1098 ]
1099
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001100 # TODO(crbug/877717): this should never be used.
1101 if squash and short_hostname != 'chromium':
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001102 calls += [
1103 (('AddReviewers',
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001104 'chromium-review.googlesource.com', 'my%2Frepo~123456',
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001105 sorted(reviewers),
Edward Lemur227d5102020-02-25 23:45:35 +00001106 cc + ['test-more-cc@chromium.org'],
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00001107 notify),
1108 ''),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001109 ]
Edward Lemur26964072020-02-19 19:18:51 +00001110 calls += [
1111 ((['git', 'rev-parse', 'HEAD'],), 'hash'),
1112 ]
ukai@chromium.orge8077812012-02-03 03:41:46 +00001113 return calls
1114
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001115 def _run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001116 self,
1117 upload_args,
1118 description,
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001119 reviewers=None,
tandriia60502f2016-06-20 02:01:53 -07001120 squash=True,
1121 squash_mode=None,
tandrii@chromium.org10625002016-03-04 20:03:47 +00001122 expected_upstream_ref='origin/refs/heads/master',
Aaron Gable9b713dd2016-12-14 16:04:21 -08001123 title=None,
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001124 notify=False,
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001125 post_amend_description=None,
bradnelsond975b302016-10-23 12:20:23 -07001126 issue=None,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +01001127 cc=None,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001128 fetched_status=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001129 other_cl_owner=None,
Aaron Gablefd238082017-06-07 13:42:34 -07001130 custom_cl_base=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001131 tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001132 short_hostname='chromium',
Edward Lemur1b52d872019-05-09 21:12:12 +00001133 labels=None,
1134 change_id=None,
1135 original_title=None,
1136 final_description=None,
Anthony Polito8b955342019-09-24 19:01:36 +00001137 gitcookies_exists=True,
1138 force=False,
Josipe827b0f2020-01-30 00:07:20 +00001139 edit_description=None,
Anthony Polito8b955342019-09-24 19:01:36 +00001140 fetched_description=None):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001141 """Generic gerrit upload test framework."""
tandriia60502f2016-06-20 02:01:53 -07001142 if squash_mode is None:
1143 if '--no-squash' in upload_args:
1144 squash_mode = 'nosquash'
1145 elif '--squash' in upload_args:
1146 squash_mode = 'squash'
1147 else:
1148 squash_mode = 'default'
1149
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001150 reviewers = reviewers or []
bradnelsond975b302016-10-23 12:20:23 -07001151 cc = cc or []
Edward Lemurda4b6c62020-02-13 00:28:40 +00001152 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001153 CookiesAuthenticatorMockFactory(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001154 same_auth=('git-owner.example.com', '', 'pass'))).start()
1155 mock.patch('git_cl.Changelist._GerritCommitMsgHookCheck',
1156 lambda _, offer_removal: None).start()
1157 mock.patch('git_cl.gclient_utils.RunEditor',
1158 lambda *_, **__: self._mocked_call(['RunEditor'])).start()
1159 mock.patch('git_cl.DownloadGerritHook', lambda force: self._mocked_call(
1160 'DownloadGerritHook', force)).start()
1161 mock.patch('git_cl.gclient_utils.FileRead',
1162 lambda path: self._mocked_call(['FileRead', path])).start()
1163 mock.patch('git_cl.gclient_utils.FileWrite',
Edward Lemur1b52d872019-05-09 21:12:12 +00001164 lambda path, contents: self._mocked_call(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001165 ['FileWrite', path, contents])).start()
1166 mock.patch('git_cl.datetime_now',
1167 lambda: datetime.datetime(2017, 3, 16, 20, 0, 41, 0)).start()
1168 mock.patch('git_cl.tempfile.mkdtemp', lambda: 'TEMP_DIR').start()
1169 mock.patch('git_cl.TRACES_DIR', 'TRACES_DIR').start()
1170 mock.patch('git_cl.TRACES_README_FORMAT',
Edward Lemur75391d42019-05-14 23:35:56 +00001171 '%(now)s\n'
1172 '%(gerrit_host)s\n'
1173 '%(change_id)s\n'
1174 '%(title)s\n'
1175 '%(description)s\n'
1176 '%(execution_time)s\n'
1177 '%(exit_code)s\n'
Edward Lemurda4b6c62020-02-13 00:28:40 +00001178 '%(trace_name)s').start()
1179 mock.patch('git_cl.shutil.make_archive',
1180 lambda *args: self._mocked_call(['make_archive'] +
1181 list(args))).start()
1182 mock.patch('os.path.isfile',
1183 lambda path: self._mocked_call(['os.path.isfile', path])).start()
Edward Lemurd55c5072020-02-20 01:09:07 +00001184 mock.patch('git_cl.Changelist.GitSanityChecks', return_value=True).start()
Edward Lemur9aa1a962020-02-25 00:58:38 +00001185 mock.patch(
1186 'git_cl.Changelist.GetLocalDescription', return_value='foo').start()
Edward Lemur1a83da12020-03-04 21:18:36 +00001187 mock.patch(
1188 'git_cl.ask_for_data',
1189 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
tandriia60502f2016-06-20 02:01:53 -07001190
Edward Lemur26964072020-02-19 19:18:51 +00001191 self.mockGit.config['gerrit.host'] = 'true'
Edward Lemur85153282020-02-14 22:06:29 +00001192 self.mockGit.config['branch.master.gerritissue'] = (
1193 str(issue) if issue else None)
1194 self.mockGit.config['remote.origin.url'] = (
1195 'https://%s.googlesource.com/my/repo' % short_hostname)
Edward Lemur9aa1a962020-02-25 00:58:38 +00001196 self.mockGit.config['user.email'] = 'me@example.com'
Edward Lemur85153282020-02-14 22:06:29 +00001197
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001198 self.calls = self._gerrit_base_calls(
1199 issue=issue,
Anthony Polito8b955342019-09-24 19:01:36 +00001200 fetched_description=fetched_description or description,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001201 fetched_status=fetched_status,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001202 other_cl_owner=other_cl_owner,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001203 custom_cl_base=custom_cl_base,
Anthony Polito8b955342019-09-24 19:01:36 +00001204 short_hostname=short_hostname,
1205 change_id=change_id)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001206 if fetched_status != 'ABANDONED':
Edward Lemurda4b6c62020-02-13 00:28:40 +00001207 mock.patch(
Edward Lemur1773f372020-02-22 00:27:14 +00001208 'gclient_utils.temporary_file', TemporaryFileMock()).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00001209 mock.patch('os.remove', return_value=True).start()
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001210 self.calls += self._gerrit_upload_calls(
1211 description, reviewers, squash,
1212 squash_mode=squash_mode,
1213 expected_upstream_ref=expected_upstream_ref,
Aaron Gablefd238082017-06-07 13:42:34 -07001214 title=title, notify=notify,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001215 post_amend_description=post_amend_description,
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001216 issue=issue, cc=cc,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001217 custom_cl_base=custom_cl_base, tbr=tbr,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001218 short_hostname=short_hostname,
Edward Lemur1b52d872019-05-09 21:12:12 +00001219 labels=labels,
1220 change_id=change_id,
1221 original_title=original_title,
1222 final_description=final_description,
Anthony Polito8b955342019-09-24 19:01:36 +00001223 gitcookies_exists=gitcookies_exists,
Josipe827b0f2020-01-30 00:07:20 +00001224 force=force,
1225 edit_description=edit_description)
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001226 # Uncomment when debugging.
Raul Tambre80ee78e2019-05-06 22:41:05 +00001227 # print('\n'.join(map(lambda x: '%2i: %s' % x, enumerate(self.calls))))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001228 git_cl.main(['upload'] + upload_args)
Edward Lemur85153282020-02-14 22:06:29 +00001229 if squash:
Edward Lemur26964072020-02-19 19:18:51 +00001230 self.assertIssueAndPatchset(patchset=None)
Edward Lemur85153282020-02-14 22:06:29 +00001231 self.assertEqual(
1232 'abcdef0123456789',
Edward Lemur26964072020-02-19 19:18:51 +00001233 scm.GIT.GetBranchConfig('', 'master', 'gerritsquashhash'))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001234
Edward Lemur1b52d872019-05-09 21:12:12 +00001235 def test_gerrit_upload_traces_no_gitcookies(self):
1236 self._run_gerrit_upload_test(
1237 ['--no-squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001238 'desc ✔\n\nBUG=\n',
Edward Lemur1b52d872019-05-09 21:12:12 +00001239 [],
1240 squash=False,
Edward Lemur0db01f02019-11-12 22:01:51 +00001241 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001242 change_id='Ixxx',
1243 gitcookies_exists=False)
1244
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001245 def test_gerrit_upload_without_change_id(self):
tandriia60502f2016-06-20 02:01:53 -07001246 self._run_gerrit_upload_test(
1247 ['--no-squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001248 'desc ✔\n\nBUG=\n',
tandriia60502f2016-06-20 02:01:53 -07001249 [],
1250 squash=False,
Edward Lemur0db01f02019-11-12 22:01:51 +00001251 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001252 change_id='Ixxx')
tandriia60502f2016-06-20 02:01:53 -07001253
1254 def test_gerrit_upload_without_change_id_override_nosquash(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001255 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001256 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001257 'desc ✔\n\nBUG=\n',
tandrii@chromium.org10625002016-03-04 20:03:47 +00001258 [],
tandriia60502f2016-06-20 02:01:53 -07001259 squash=False,
1260 squash_mode='override_nosquash',
Edward Lemur0db01f02019-11-12 22:01:51 +00001261 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001262 change_id='Ixxx')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001263
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001264 def test_gerrit_no_reviewer(self):
1265 self._run_gerrit_upload_test(
1266 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001267 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
tandriia60502f2016-06-20 02:01:53 -07001268 [],
1269 squash=False,
Edward Lemur1b52d872019-05-09 21:12:12 +00001270 squash_mode='override_nosquash',
1271 change_id='I123456789')
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001272
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001273 def test_gerrit_no_reviewer_non_chromium_host(self):
1274 # TODO(crbug/877717): remove this test case.
1275 self._run_gerrit_upload_test(
1276 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001277 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001278 [],
1279 squash=False,
1280 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001281 short_hostname='other',
1282 change_id='I123456789')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001283
Nick Carter8692b182017-11-06 16:30:38 -08001284 def test_gerrit_patchset_title_special_chars(self):
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001285 self._run_gerrit_upload_test(
Nick Carter8692b182017-11-06 16:30:38 -08001286 ['-f', '-t', 'We\'ll escape ^_ ^ special chars...@{u}'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001287 'desc ✔\n\nBUG=\n\nChange-Id: I123456789',
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001288 squash=False,
1289 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001290 title='We%27ll_escape_%5E%5F_%5E_special_chars%2E%2E%2E%40%7Bu%7D',
1291 change_id='I123456789',
1292 original_title='We\'ll escape ^_ ^ special chars...@{u}')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001293
ukai@chromium.orge8077812012-02-03 03:41:46 +00001294 def test_gerrit_reviewers_cmd_line(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001295 self._run_gerrit_upload_test(
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001296 ['-r', 'foo@example.com', '--send-mail'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001297 'desc ✔\n\nBUG=\n\nChange-Id: I123456789',
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001298 ['foo@example.com'],
tandriia60502f2016-06-20 02:01:53 -07001299 squash=False,
1300 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001301 notify=True,
1302 change_id='I123456789',
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001303 final_description=(
Edward Lemur0db01f02019-11-12 22:01:51 +00001304 'desc ✔\n\nBUG=\nR=foo@example.com\n\nChange-Id: I123456789'))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001305
Anthony Polito8b955342019-09-24 19:01:36 +00001306 def test_gerrit_upload_force_sets_bug(self):
1307 self._run_gerrit_upload_test(
1308 ['-b', '10000', '-f'],
1309 u'desc=\n\nBug: 10000\nChange-Id: Ixxx',
1310 [],
1311 force=True,
1312 expected_upstream_ref='origin/master',
1313 fetched_description='desc=\n\nChange-Id: Ixxx',
1314 original_title='Initial upload',
1315 change_id='Ixxx')
1316
1317 def test_gerrit_upload_force_sets_bug_if_wrong_changeid(self):
1318 self._run_gerrit_upload_test(
1319 ['-b', '10000', '-f', '-m', 'Title'],
1320 u'desc=\n\nChange-Id: Ixxxx\n\nChange-Id: Izzzz\nBug: 10000',
1321 [],
1322 force=True,
1323 issue='123456',
1324 expected_upstream_ref='origin/master',
1325 fetched_description='desc=\n\nChange-Id: Ixxxx',
1326 original_title='Title',
1327 title='Title',
1328 change_id='Izzzz')
1329
Dan Beamd8b04ca2019-10-10 21:23:26 +00001330 def test_gerrit_upload_force_sets_fixed(self):
1331 self._run_gerrit_upload_test(
1332 ['-x', '10000', '-f'],
1333 u'desc=\n\nFixed: 10000\nChange-Id: Ixxx',
1334 [],
1335 force=True,
1336 expected_upstream_ref='origin/master',
1337 fetched_description='desc=\n\nChange-Id: Ixxx',
1338 original_title='Initial upload',
1339 change_id='Ixxx')
1340
ukai@chromium.orge8077812012-02-03 03:41:46 +00001341 def test_gerrit_reviewer_multiple(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00001342 mock.patch('git_cl.gerrit_util.GetCodeReviewTbrScore',
1343 lambda *a: self._mocked_call('GetCodeReviewTbrScore', *a)).start()
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001344 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001345 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001346 'desc ✔\nTBR=reviewer@example.com\nBUG=\nR=another@example.com\n'
bradnelsond975b302016-10-23 12:20:23 -07001347 'CC=more@example.com,people@example.com\n\n'
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001348 'Change-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001349 ['reviewer@example.com', 'another@example.com'],
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001350 expected_upstream_ref='origin/master',
Aaron Gablefd238082017-06-07 13:42:34 -07001351 cc=['more@example.com', 'people@example.com'],
Edward Lemur687ca902018-12-05 02:30:30 +00001352 tbr='reviewer@example.com',
Edward Lemur1b52d872019-05-09 21:12:12 +00001353 labels={'Code-Review': 2},
1354 change_id='123456789',
1355 original_title='Initial upload')
tandriia60502f2016-06-20 02:01:53 -07001356
1357 def test_gerrit_upload_squash_first_is_default(self):
tandriia60502f2016-06-20 02:01:53 -07001358 self._run_gerrit_upload_test(
1359 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001360 'desc ✔\nBUG=\n\nChange-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001361 [],
Edward Lemur1b52d872019-05-09 21:12:12 +00001362 expected_upstream_ref='origin/master',
1363 change_id='123456789',
1364 original_title='Initial upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001365
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001366 def test_gerrit_upload_squash_first(self):
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001367 self._run_gerrit_upload_test(
1368 ['--squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001369 'desc ✔\nBUG=\n\nChange-Id: 123456789',
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001370 [],
luqui@chromium.org609f3952015-05-04 22:47:04 +00001371 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001372 expected_upstream_ref='origin/master',
1373 change_id='123456789',
1374 original_title='Initial upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001375
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001376 def test_gerrit_upload_squash_first_with_labels(self):
1377 self._run_gerrit_upload_test(
1378 ['--squash', '--cq-dry-run', '--enable-auto-submit'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001379 'desc ✔\nBUG=\n\nChange-Id: 123456789',
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001380 [],
1381 squash=True,
1382 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001383 labels={'Commit-Queue': 1, 'Auto-Submit': 1},
1384 change_id='123456789',
1385 original_title='Initial upload')
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001386
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001387 def test_gerrit_upload_squash_first_against_rev(self):
1388 custom_cl_base = 'custom_cl_base_rev_or_branch'
1389 self._run_gerrit_upload_test(
1390 ['--squash', custom_cl_base],
Edward Lemur0db01f02019-11-12 22:01:51 +00001391 'desc ✔\nBUG=\n\nChange-Id: 123456789',
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001392 [],
1393 squash=True,
1394 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001395 custom_cl_base=custom_cl_base,
1396 change_id='123456789',
1397 original_title='Initial upload')
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001398 self.assertIn(
1399 'If you proceed with upload, more than 1 CL may be created by Gerrit',
1400 sys.stdout.getvalue())
1401
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001402 def test_gerrit_upload_squash_reupload(self):
Edward Lemur0db01f02019-11-12 22:01:51 +00001403 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001404 self._run_gerrit_upload_test(
1405 ['--squash'],
1406 description,
1407 [],
1408 squash=True,
1409 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001410 issue=123456,
1411 change_id='123456789',
1412 original_title='User input')
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001413
Edward Lemurd55c5072020-02-20 01:09:07 +00001414 @mock.patch('sys.stderr', StringIO())
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001415 def test_gerrit_upload_squash_reupload_to_abandoned(self):
Edward Lemur0db01f02019-11-12 22:01:51 +00001416 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001417 with self.assertRaises(SystemExitMock):
1418 self._run_gerrit_upload_test(
1419 ['--squash'],
1420 description,
1421 [],
1422 squash=True,
1423 expected_upstream_ref='origin/master',
1424 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001425 fetched_status='ABANDONED',
1426 change_id='123456789')
Edward Lemurd55c5072020-02-20 01:09:07 +00001427 self.assertEqual(
1428 'Change https://chromium-review.googlesource.com/123456 has been '
1429 'abandoned, new uploads are not allowed\n',
1430 sys.stderr.getvalue())
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001431
Edward Lemurda4b6c62020-02-13 00:28:40 +00001432 @mock.patch(
1433 'gerrit_util.GetAccountDetails',
1434 return_value={'email': 'yet-another@example.com'})
1435 def test_gerrit_upload_squash_reupload_to_not_owned(self, _mock):
Edward Lemur0db01f02019-11-12 22:01:51 +00001436 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001437 self._run_gerrit_upload_test(
1438 ['--squash'],
1439 description,
1440 [],
1441 squash=True,
1442 expected_upstream_ref='origin/master',
1443 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001444 other_cl_owner='other@example.com',
1445 change_id='123456789',
1446 original_title='User input')
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001447 self.assertIn(
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001448 'WARNING: Change 123456 is owned by other@example.com, but you '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001449 'authenticate to Gerrit as yet-another@example.com.\n'
1450 'Uploading may fail due to lack of permissions',
Edward Lemurda4b6c62020-02-13 00:28:40 +00001451 sys.stdout.getvalue())
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001452
Josipe827b0f2020-01-30 00:07:20 +00001453 def test_upload_change_description_editor(self):
1454 fetched_description = 'foo\n\nChange-Id: 123456789'
1455 description = 'bar\n\nChange-Id: 123456789'
1456 self._run_gerrit_upload_test(
1457 ['--squash', '--edit-description'],
1458 description,
1459 [],
1460 fetched_description=fetched_description,
1461 squash=True,
1462 expected_upstream_ref='origin/master',
1463 issue=123456,
1464 change_id='123456789',
1465 original_title='User input',
1466 edit_description=description)
1467
Edward Lemurda4b6c62020-02-13 00:28:40 +00001468 @mock.patch('git_cl.RunGit')
1469 @mock.patch('git_cl.CMDupload')
Edward Lemur1a83da12020-03-04 21:18:36 +00001470 @mock.patch('sys.stdin', StringIO('\n'))
1471 @mock.patch('sys.stdout', StringIO())
Edward Lemurda4b6c62020-02-13 00:28:40 +00001472 def test_upload_branch_deps(self, *_mocks):
rmistry@google.com2dd99862015-06-22 12:22:18 +00001473 def mock_run_git(*args, **_kwargs):
1474 if args[0] == ['for-each-ref',
1475 '--format=%(refname:short) %(upstream:short)',
1476 'refs/heads']:
1477 # Create a local branch dependency tree that looks like this:
1478 # test1 -> test2 -> test3 -> test4 -> test5
1479 # -> test3.1
1480 # test6 -> test0
1481 branch_deps = [
1482 'test2 test1', # test1 -> test2
1483 'test3 test2', # test2 -> test3
1484 'test3.1 test2', # test2 -> test3.1
1485 'test4 test3', # test3 -> test4
1486 'test5 test4', # test4 -> test5
1487 'test6 test0', # test0 -> test6
1488 'test7', # test7
1489 ]
1490 return '\n'.join(branch_deps)
Edward Lemurda4b6c62020-02-13 00:28:40 +00001491 git_cl.RunGit.side_effect = mock_run_git
1492 git_cl.CMDupload.return_value = 0
rmistry@google.com2dd99862015-06-22 12:22:18 +00001493
1494 class MockChangelist():
1495 def __init__(self):
1496 pass
1497 def GetBranch(self):
1498 return 'test1'
1499 def GetIssue(self):
1500 return '123'
1501 def GetPatchset(self):
1502 return '1001'
tandrii@chromium.org4c72b082016-03-31 22:26:35 +00001503 def IsGerrit(self):
1504 return False
rmistry@google.com2dd99862015-06-22 12:22:18 +00001505
1506 ret = git_cl.upload_branch_deps(MockChangelist(), [])
1507 # CMDupload should have been called 5 times because of 5 dependent branches.
Edward Lemurda4b6c62020-02-13 00:28:40 +00001508 self.assertEqual(5, len(git_cl.CMDupload.mock_calls))
Edward Lemur1a83da12020-03-04 21:18:36 +00001509 self.assertIn(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001510 'This command will checkout all dependent branches '
1511 'and run "git cl upload". Press Enter to continue, '
Edward Lemur1a83da12020-03-04 21:18:36 +00001512 'or Ctrl+C to abort',
1513 sys.stdout.getvalue())
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00001514 self.assertEqual(0, ret)
rmistry@google.com2dd99862015-06-22 12:22:18 +00001515
tandrii@chromium.org65874e12016-03-04 12:03:02 +00001516 def test_gerrit_change_id(self):
1517 self.calls = [
1518 ((['git', 'write-tree'], ),
1519 'hashtree'),
1520 ((['git', 'rev-parse', 'HEAD~0'], ),
1521 'branch-parent'),
1522 ((['git', 'var', 'GIT_AUTHOR_IDENT'], ),
1523 'A B <a@b.org> 1456848326 +0100'),
1524 ((['git', 'var', 'GIT_COMMITTER_IDENT'], ),
1525 'C D <c@d.org> 1456858326 +0100'),
1526 ((['git', 'hash-object', '-t', 'commit', '--stdin'], ),
1527 'hashchange'),
1528 ]
1529 change_id = git_cl.GenerateGerritChangeId('line1\nline2\n')
1530 self.assertEqual(change_id, 'Ihashchange')
1531
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001532 def test_desecription_append_footer(self):
1533 for init_desc, footer_line, expected_desc in [
1534 # Use unique desc first lines for easy test failure identification.
1535 ('foo', 'R=one', 'foo\n\nR=one'),
1536 ('foo\n\nR=one', 'BUG=', 'foo\n\nR=one\nBUG='),
1537 ('foo\n\nR=one', 'Change-Id: Ixx', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1538 ('foo\n\nChange-Id: Ixx', 'R=one', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1539 ('foo\n\nR=one\n\nChange-Id: Ixx', 'TBR=two',
1540 'foo\n\nR=one\nTBR=two\n\nChange-Id: Ixx'),
1541 ('foo\n\nR=one\n\nChange-Id: Ixx', 'Foo-Bar: baz',
1542 'foo\n\nR=one\n\nChange-Id: Ixx\nFoo-Bar: baz'),
1543 ('foo\n\nChange-Id: Ixx', 'Foo-Bak: baz',
1544 'foo\n\nChange-Id: Ixx\nFoo-Bak: baz'),
1545 ('foo', 'Change-Id: Ixx', 'foo\n\nChange-Id: Ixx'),
1546 ]:
1547 desc = git_cl.ChangeDescription(init_desc)
1548 desc.append_footer(footer_line)
1549 self.assertEqual(desc.description, expected_desc)
1550
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001551 def test_update_reviewers(self):
1552 data = [
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001553 ('foo', [], [],
1554 'foo'),
1555 ('foo\nR=xx', [], [],
1556 'foo\nR=xx'),
1557 ('foo\nTBR=xx', [], [],
1558 'foo\nTBR=xx'),
1559 ('foo', ['a@c'], [],
1560 'foo\n\nR=a@c'),
1561 ('foo\nR=xx', ['a@c'], [],
1562 'foo\n\nR=a@c, xx'),
1563 ('foo\nTBR=xx', ['a@c'], [],
1564 'foo\n\nR=a@c\nTBR=xx'),
1565 ('foo\nTBR=xx\nR=yy', ['a@c'], [],
1566 'foo\n\nR=a@c, yy\nTBR=xx'),
1567 ('foo\nBUG=', ['a@c'], [],
1568 'foo\nBUG=\nR=a@c'),
1569 ('foo\nR=xx\nTBR=yy\nR=bar', ['a@c'], [],
1570 'foo\n\nR=a@c, bar, xx\nTBR=yy'),
1571 ('foo', ['a@c', 'b@c'], [],
1572 'foo\n\nR=a@c, b@c'),
1573 ('foo\nBar\n\nR=\nBUG=', ['c@c'], [],
1574 'foo\nBar\n\nR=c@c\nBUG='),
1575 ('foo\nBar\n\nR=\nBUG=\nR=', ['c@c'], [],
1576 'foo\nBar\n\nR=c@c\nBUG='),
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001577 # Same as the line before, but full of whitespaces.
1578 (
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001579 'foo\nBar\n\n R = \n BUG = \n R = ', ['c@c'], [],
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001580 'foo\nBar\n\nR=c@c\n BUG =',
1581 ),
1582 # Whitespaces aren't interpreted as new lines.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001583 ('foo BUG=allo R=joe ', ['c@c'], [],
1584 'foo BUG=allo R=joe\n\nR=c@c'),
1585 # Redundant TBRs get promoted to Rs
1586 ('foo\n\nR=a@c\nTBR=t@c', ['b@c', 'a@c'], ['a@c', 't@c'],
1587 'foo\n\nR=a@c, b@c\nTBR=t@c'),
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001588 ]
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001589 expected = [i[-1] for i in data]
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001590 actual = []
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001591 for orig, reviewers, tbrs, _expected in data:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001592 obj = git_cl.ChangeDescription(orig)
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001593 obj.update_reviewers(reviewers, tbrs)
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001594 actual.append(obj.description)
1595 self.assertEqual(expected, actual)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001596
Nodir Turakulov23b82142017-11-16 11:04:25 -08001597 def test_get_hash_tags(self):
1598 cases = [
1599 ('', []),
1600 ('a', []),
1601 ('[a]', ['a']),
1602 ('[aa]', ['aa']),
1603 ('[a ]', ['a']),
1604 ('[a- ]', ['a']),
1605 ('[a- b]', ['a-b']),
1606 ('[a--b]', ['a-b']),
1607 ('[a', []),
1608 ('[a]x', ['a']),
1609 ('[aa]x', ['aa']),
1610 ('[a b]', ['a-b']),
1611 ('[a b]', ['a-b']),
1612 ('[a__b]', ['a-b']),
1613 ('[a] x', ['a']),
1614 ('[a][b]', ['a', 'b']),
1615 ('[a] [b]', ['a', 'b']),
1616 ('[a][b]x', ['a', 'b']),
1617 ('[a][b] x', ['a', 'b']),
1618 ('[a]\n[b]', ['a']),
1619 ('[a\nb]', []),
1620 ('[a][', ['a']),
1621 ('Revert "[a] feature"', ['a']),
1622 ('Reland "[a] feature"', ['a']),
1623 ('Revert: [a] feature', ['a']),
1624 ('Reland: [a] feature', ['a']),
1625 ('Revert "Reland: [a] feature"', ['a']),
1626 ('Foo: feature', ['foo']),
1627 ('Foo Bar: feature', ['foo-bar']),
Anthony Polito02b5af32019-12-02 19:49:47 +00001628 ('Change Foo::Bar', []),
1629 ('Foo: Change Foo::Bar', ['foo']),
Nodir Turakulov23b82142017-11-16 11:04:25 -08001630 ('Revert "Foo bar: feature"', ['foo-bar']),
1631 ('Reland "Foo bar: feature"', ['foo-bar']),
1632 ]
1633 for desc, expected in cases:
1634 change_desc = git_cl.ChangeDescription(desc)
1635 actual = change_desc.get_hash_tags()
1636 self.assertEqual(
1637 actual,
1638 expected,
1639 'GetHashTags(%r) == %r, expected %r' % (desc, actual, expected))
1640
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001641 self.assertEqual(None, git_cl.GetTargetRef('origin', None, 'master'))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001642 self.assertEqual(None, git_cl.GetTargetRef(None,
1643 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001644 'master'))
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001645
wittman@chromium.org455dc922015-01-26 20:15:50 +00001646 # Check default target refs for branches.
1647 self.assertEqual('refs/heads/master',
1648 git_cl.GetTargetRef('origin', 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001649 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001650 self.assertEqual('refs/heads/master',
1651 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkgr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001652 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001653 self.assertEqual('refs/heads/master',
1654 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkcr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001655 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001656 self.assertEqual('refs/branch-heads/123',
1657 git_cl.GetTargetRef('origin',
1658 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001659 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001660 self.assertEqual('refs/diff/test',
1661 git_cl.GetTargetRef('origin',
1662 'refs/remotes/origin/refs/diff/test',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001663 None))
rmistry@google.comc68112d2015-03-03 12:48:06 +00001664 self.assertEqual('refs/heads/chrome/m42',
1665 git_cl.GetTargetRef('origin',
1666 'refs/remotes/origin/chrome/m42',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001667 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001668
1669 # Check target refs for user-specified target branch.
1670 for branch in ('branch-heads/123', 'remotes/branch-heads/123',
1671 'refs/remotes/branch-heads/123'):
1672 self.assertEqual('refs/branch-heads/123',
1673 git_cl.GetTargetRef('origin',
1674 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001675 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001676 for branch in ('origin/master', 'remotes/origin/master',
1677 'refs/remotes/origin/master'):
1678 self.assertEqual('refs/heads/master',
1679 git_cl.GetTargetRef('origin',
1680 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001681 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001682 for branch in ('master', 'heads/master', 'refs/heads/master'):
1683 self.assertEqual('refs/heads/master',
1684 git_cl.GetTargetRef('origin',
1685 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001686 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001687
Edward Lemurda4b6c62020-02-13 00:28:40 +00001688 @mock.patch('git_common.is_dirty_git_tree', return_value=True)
1689 def test_patch_when_dirty(self, *_mocks):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001690 # Patch when local tree is dirty.
wychen@chromium.orga872e752015-04-28 23:42:18 +00001691 self.assertNotEqual(git_cl.main(['patch', '123456']), 0)
1692
Edward Lemur85153282020-02-14 22:06:29 +00001693 def assertIssueAndPatchset(
1694 self, branch='master', issue='123456', patchset='7',
1695 git_short_host='chromium'):
1696 self.assertEqual(
Edward Lemur26964072020-02-19 19:18:51 +00001697 issue, scm.GIT.GetBranchConfig('', branch, 'gerritissue'))
Edward Lemur85153282020-02-14 22:06:29 +00001698 self.assertEqual(
Edward Lemur26964072020-02-19 19:18:51 +00001699 patchset, scm.GIT.GetBranchConfig('', branch, 'gerritpatchset'))
Edward Lemur85153282020-02-14 22:06:29 +00001700 self.assertEqual(
1701 'https://%s-review.googlesource.com' % git_short_host,
Edward Lemur26964072020-02-19 19:18:51 +00001702 scm.GIT.GetBranchConfig('', branch, 'gerritserver'))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001703
Edward Lemur85153282020-02-14 22:06:29 +00001704 def _patch_common(self, git_short_host='chromium'):
Edward Lemurda4b6c62020-02-13 00:28:40 +00001705 mock.patch('git_cl.IsGitVersionAtLeast', return_value=True).start()
Edward Lemur26964072020-02-19 19:18:51 +00001706 self.mockGit.config['remote.origin.url'] = (
1707 'https://%s.googlesource.com/my/repo' % git_short_host)
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001708 gerrit_util.GetChangeDetail.return_value = {
1709 'current_revision': '7777777777',
1710 'revisions': {
1711 '1111111111': {
1712 '_number': 1,
1713 'fetch': {'http': {
1714 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1715 'ref': 'refs/changes/56/123456/1',
1716 }},
1717 },
1718 '7777777777': {
1719 '_number': 7,
1720 'fetch': {'http': {
1721 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1722 'ref': 'refs/changes/56/123456/7',
1723 }},
1724 },
1725 },
1726 }
wychen@chromium.orga872e752015-04-28 23:42:18 +00001727
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001728 def test_patch_gerrit_default(self):
Edward Lemur85153282020-02-14 22:06:29 +00001729 self._patch_common()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001730 self.calls += [
1731 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1732 'refs/changes/56/123456/7'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001733 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001734 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001735 ]
1736 self.assertEqual(git_cl.main(['patch', '123456']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001737 self.assertIssueAndPatchset()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001738
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001739 def test_patch_gerrit_new_branch(self):
Edward Lemur85153282020-02-14 22:06:29 +00001740 self._patch_common()
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001741 self.calls += [
1742 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1743 'refs/changes/56/123456/7'],), ''),
1744 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001745 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001746 ]
Edward Lemur85153282020-02-14 22:06:29 +00001747 self.assertEqual(git_cl.main(['patch', '-b', 'feature', '123456']), 0)
1748 self.assertIssueAndPatchset(branch='feature')
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001749
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001750 def test_patch_gerrit_force(self):
Edward Lemur85153282020-02-14 22:06:29 +00001751 self._patch_common('host')
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001752 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001753 ((['git', 'fetch', 'https://host.googlesource.com/my/repo',
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001754 'refs/changes/56/123456/7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001755 ((['git', 'reset', '--hard', 'FETCH_HEAD'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001756 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001757 ]
Edward Lemur52969c92020-02-06 18:15:28 +00001758 self.assertEqual(git_cl.main(['patch', '123456', '--force']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001759 self.assertIssueAndPatchset(git_short_host='host')
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001760
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001761 def test_patch_gerrit_guess_by_url(self):
Edward Lemur85153282020-02-14 22:06:29 +00001762 self._patch_common('else')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001763 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001764 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001765 'refs/changes/56/123456/1'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001766 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001767 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001768 ]
1769 self.assertEqual(git_cl.main(
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001770 ['patch', 'https://else-review.googlesource.com/#/c/123456/1']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001771 self.assertIssueAndPatchset(patchset='1', git_short_host='else')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001772
Aaron Gable697a91b2018-01-19 15:20:15 -08001773 def test_patch_gerrit_guess_by_url_with_repo(self):
Edward Lemur85153282020-02-14 22:06:29 +00001774 self._patch_common('else')
Aaron Gable697a91b2018-01-19 15:20:15 -08001775 self.calls += [
1776 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
1777 'refs/changes/56/123456/1'],), ''),
1778 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
Aaron Gable697a91b2018-01-19 15:20:15 -08001779 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
Aaron Gable697a91b2018-01-19 15:20:15 -08001780 ]
1781 self.assertEqual(git_cl.main(
1782 ['patch', 'https://else-review.googlesource.com/c/my/repo/+/123456/1']),
1783 0)
Edward Lemur85153282020-02-14 22:06:29 +00001784 self.assertIssueAndPatchset(patchset='1', git_short_host='else')
Aaron Gable697a91b2018-01-19 15:20:15 -08001785
Edward Lemurd55c5072020-02-20 01:09:07 +00001786 @mock.patch('sys.stderr', StringIO())
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001787 def test_patch_gerrit_conflict(self):
Edward Lemur85153282020-02-14 22:06:29 +00001788 self._patch_common()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001789 self.calls += [
1790 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001791 'refs/changes/56/123456/7'],), ''),
tandrii5d48c322016-08-18 16:19:37 -07001792 ((['git', 'cherry-pick', 'FETCH_HEAD'],), CERR1),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001793 ]
1794 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001795 git_cl.main(['patch', '123456'])
Edward Lemurd55c5072020-02-20 01:09:07 +00001796 self.assertEqual(
1797 'Command "git cherry-pick FETCH_HEAD" failed.\n\n',
1798 sys.stderr.getvalue())
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001799
Edward Lemurda4b6c62020-02-13 00:28:40 +00001800 @mock.patch(
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001801 'gerrit_util.GetChangeDetail',
Edward Lemurda4b6c62020-02-13 00:28:40 +00001802 side_effect=gerrit_util.GerritError(404, ''))
Edward Lemurd55c5072020-02-20 01:09:07 +00001803 @mock.patch('sys.stderr', StringIO())
Edward Lemurda4b6c62020-02-13 00:28:40 +00001804 def test_patch_gerrit_not_exists(self, *_mocks):
Edward Lemur26964072020-02-19 19:18:51 +00001805 self.mockGit.config['remote.origin.url'] = (
1806 'https://chromium.googlesource.com/my/repo')
tandriic2405f52016-10-10 08:13:15 -07001807 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001808 self.assertEqual(1, git_cl.main(['patch', '123456']))
Edward Lemurd55c5072020-02-20 01:09:07 +00001809 self.assertEqual(
1810 'change 123456 at https://chromium-review.googlesource.com does not '
1811 'exist or you have no access to it\n',
1812 sys.stderr.getvalue())
tandriic2405f52016-10-10 08:13:15 -07001813
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001814 def _checkout_calls(self):
1815 return [
1816 ((['git', 'config', '--local', '--get-regexp',
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001817 'branch\\..*\\.gerritissue'], ),
1818 ('branch.ger-branch.gerritissue 123456\n'
1819 'branch.gbranch654.gerritissue 654321\n')),
1820 ]
1821
1822 def test_checkout_gerrit(self):
1823 """Tests git cl checkout <issue>."""
1824 self.calls = self._checkout_calls()
1825 self.calls += [((['git', 'checkout', 'ger-branch'], ), '')]
1826 self.assertEqual(0, git_cl.main(['checkout', '123456']))
1827
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001828 def test_checkout_not_found(self):
1829 """Tests git cl checkout <issue>."""
1830 self.calls = self._checkout_calls()
1831 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1832
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001833 def test_checkout_no_branch_issues(self):
1834 """Tests git cl checkout <issue>."""
1835 self.calls = [
1836 ((['git', 'config', '--local', '--get-regexp',
tandrii5d48c322016-08-18 16:19:37 -07001837 'branch\\..*\\.gerritissue'], ), CERR1),
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001838 ]
1839 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1840
Edward Lemur26964072020-02-19 19:18:51 +00001841 def _test_gerrit_ensure_authenticated_common(self, auth):
Edward Lemur1a83da12020-03-04 21:18:36 +00001842 mock.patch(
1843 'git_cl.ask_for_data',
1844 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00001845 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
1846 CookiesAuthenticatorMockFactory(hosts_with_creds=auth)).start()
Edward Lemur26964072020-02-19 19:18:51 +00001847 self.mockGit.config['remote.origin.url'] = (
1848 'https://chromium.googlesource.com/my/repo')
Edward Lemurf38bc172019-09-03 21:02:13 +00001849 cl = git_cl.Changelist()
tandrii@chromium.org28253532016-04-14 13:46:56 +00001850 cl.branch = 'master'
1851 cl.branchref = 'refs/heads/master'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001852 return cl
1853
Edward Lemurd55c5072020-02-20 01:09:07 +00001854 @mock.patch('sys.stderr', StringIO())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001855 def test_gerrit_ensure_authenticated_missing(self):
1856 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001857 'chromium.googlesource.com': ('git-is.ok', '', 'but gerrit is missing'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001858 })
Edward Lemurd55c5072020-02-20 01:09:07 +00001859 with self.assertRaises(SystemExitMock):
1860 cl.EnsureAuthenticated(force=False)
1861 self.assertEqual(
1862 'Credentials for the following hosts are required:\n'
1863 ' chromium-review.googlesource.com\n'
1864 'These are read from ~/.gitcookies (or legacy ~/.netrc)\n'
1865 'You can (re)generate your credentials by visiting '
1866 'https://chromium-review.googlesource.com/new-password\n',
1867 sys.stderr.getvalue())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001868
1869 def test_gerrit_ensure_authenticated_conflict(self):
1870 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001871 'chromium.googlesource.com':
1872 ('git-one.example.com', None, 'secret1'),
1873 'chromium-review.googlesource.com':
1874 ('git-other.example.com', None, 'secret2'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001875 })
1876 self.calls.append(
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001877 (('ask_for_data', 'If you know what you are doing '
1878 'press Enter to continue, or Ctrl+C to abort'), ''))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001879 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1880
1881 def test_gerrit_ensure_authenticated_ok(self):
1882 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001883 'chromium.googlesource.com':
1884 ('git-same.example.com', None, 'secret'),
1885 'chromium-review.googlesource.com':
1886 ('git-same.example.com', None, 'secret'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001887 })
1888 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1889
tandrii@chromium.org28253532016-04-14 13:46:56 +00001890 def test_gerrit_ensure_authenticated_skipped(self):
Edward Lemur26964072020-02-19 19:18:51 +00001891 self.mockGit.config['gerrit.skip-ensure-authenticated'] = 'true'
1892 cl = self._test_gerrit_ensure_authenticated_common(auth={})
tandrii@chromium.org28253532016-04-14 13:46:56 +00001893 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1894
Eric Boren2fb63102018-10-05 13:05:03 +00001895 def test_gerrit_ensure_authenticated_bearer_token(self):
1896 cl = self._test_gerrit_ensure_authenticated_common(auth={
1897 'chromium.googlesource.com':
1898 ('', None, 'secret'),
1899 'chromium-review.googlesource.com':
1900 ('', None, 'secret'),
1901 })
1902 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1903 header = gerrit_util.CookiesAuthenticator().get_auth_header(
1904 'chromium.googlesource.com')
1905 self.assertTrue('Bearer' in header)
1906
Daniel Chengcf6269b2019-05-18 01:02:12 +00001907 def test_gerrit_ensure_authenticated_non_https(self):
Edward Lemur26964072020-02-19 19:18:51 +00001908 self.mockGit.config['remote.origin.url'] = 'custom-scheme://repo'
Daniel Chengcf6269b2019-05-18 01:02:12 +00001909 self.calls = [
Josip906bfde2020-01-31 22:38:49 +00001910 (('logging.warning',
1911 'Ignoring branch %(branch)s with non-https remote '
1912 '%(remote)s', {
1913 'branch': 'master',
1914 'remote': 'custom-scheme://repo'}
1915 ), None),
Daniel Chengcf6269b2019-05-18 01:02:12 +00001916 ]
Edward Lemurda4b6c62020-02-13 00:28:40 +00001917 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
1918 CookiesAuthenticatorMockFactory(hosts_with_creds={})).start()
1919 mock.patch('logging.warning',
1920 lambda *a: self._mocked_call('logging.warning', *a)).start()
Edward Lemurf38bc172019-09-03 21:02:13 +00001921 cl = git_cl.Changelist()
Daniel Chengcf6269b2019-05-18 01:02:12 +00001922 cl.branch = 'master'
1923 cl.branchref = 'refs/heads/master'
1924 cl.lookedup_issue = True
1925 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1926
Florian Mayerae510e82020-01-30 21:04:48 +00001927 def test_gerrit_ensure_authenticated_non_url(self):
Edward Lemur26964072020-02-19 19:18:51 +00001928 self.mockGit.config['remote.origin.url'] = (
1929 'git@somehost.example:foo/bar.git')
Florian Mayerae510e82020-01-30 21:04:48 +00001930 self.calls = [
Josip906bfde2020-01-31 22:38:49 +00001931 (('logging.error',
1932 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
1933 'but it doesn\'t exist.', {
1934 'remote': 'origin',
1935 'branch': 'master',
1936 'url': 'git@somehost.example:foo/bar.git'}
1937 ), None),
Florian Mayerae510e82020-01-30 21:04:48 +00001938 ]
Edward Lemurda4b6c62020-02-13 00:28:40 +00001939 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
1940 CookiesAuthenticatorMockFactory(hosts_with_creds={})).start()
1941 mock.patch('logging.error',
1942 lambda *a: self._mocked_call('logging.error', *a)).start()
Florian Mayerae510e82020-01-30 21:04:48 +00001943 cl = git_cl.Changelist()
1944 cl.branch = 'master'
1945 cl.branchref = 'refs/heads/master'
1946 cl.lookedup_issue = True
1947 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1948
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01001949 def _cmd_set_commit_gerrit_common(self, vote, notify=None):
Edward Lemur85153282020-02-14 22:06:29 +00001950 self.mockGit.config['branch.master.gerritissue'] = '123'
1951 self.mockGit.config['branch.master.gerritserver'] = (
1952 'https://chromium-review.googlesource.com')
Edward Lemur26964072020-02-19 19:18:51 +00001953 self.mockGit.config['remote.origin.url'] = (
1954 'https://chromium.googlesource.com/infra/infra')
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001955 self.calls = [
Edward Lemurda4b6c62020-02-13 00:28:40 +00001956 (('SetReview', 'chromium-review.googlesource.com',
1957 'infra%2Finfra~123', None,
1958 {'Commit-Queue': vote}, notify, None), ''),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001959 ]
tandriid9e5ce52016-07-13 02:32:59 -07001960
1961 def test_cmd_set_commit_gerrit_clear(self):
1962 self._cmd_set_commit_gerrit_common(0)
1963 self.assertEqual(0, git_cl.main(['set-commit', '-c']))
1964
1965 def test_cmd_set_commit_gerrit_dry(self):
Aaron Gable75e78722017-06-09 10:40:16 -07001966 self._cmd_set_commit_gerrit_common(1, notify=False)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001967 self.assertEqual(0, git_cl.main(['set-commit', '-d']))
1968
tandriid9e5ce52016-07-13 02:32:59 -07001969 def test_cmd_set_commit_gerrit(self):
1970 self._cmd_set_commit_gerrit_common(2)
1971 self.assertEqual(0, git_cl.main(['set-commit']))
1972
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001973 def test_description_display(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00001974 mock.patch('git_cl.Changelist', ChangelistMock).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00001975 ChangelistMock.desc = 'foo\n'
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001976
1977 self.assertEqual(0, git_cl.main(['description', '-d']))
Edward Lemurda4b6c62020-02-13 00:28:40 +00001978 self.assertEqual('foo\n', sys.stdout.getvalue())
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001979
Edward Lemurda4b6c62020-02-13 00:28:40 +00001980 @mock.patch('sys.stderr', StringIO())
iannucci3c972b92016-08-17 13:24:10 -07001981 def test_StatusFieldOverrideIssueMissingArgs(self):
iannucci3c972b92016-08-17 13:24:10 -07001982 try:
1983 self.assertEqual(git_cl.main(['status', '--issue', '1']), 0)
Edward Lemurd55c5072020-02-20 01:09:07 +00001984 except SystemExitMock:
Edward Lemur6c6827c2020-02-06 21:15:18 +00001985 self.assertIn(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001986 '--field must be given when --issue is set.', sys.stderr.getvalue())
iannucci3c972b92016-08-17 13:24:10 -07001987
1988 def test_StatusFieldOverrideIssue(self):
iannucci3c972b92016-08-17 13:24:10 -07001989 def assertIssue(cl_self, *_args):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00001990 self.assertEqual(cl_self.issue, 1)
iannucci3c972b92016-08-17 13:24:10 -07001991 return 'foobar'
1992
Edward Lemurda4b6c62020-02-13 00:28:40 +00001993 mock.patch('git_cl.Changelist.FetchDescription', assertIssue).start()
iannuccie53c9352016-08-17 14:40:40 -07001994 self.assertEqual(
Edward Lemur52969c92020-02-06 18:15:28 +00001995 git_cl.main(['status', '--issue', '1', '--field', 'desc']),
iannuccie53c9352016-08-17 14:40:40 -07001996 0)
Edward Lemurda4b6c62020-02-13 00:28:40 +00001997 self.assertEqual(sys.stdout.getvalue(), 'foobar\n')
iannucci3c972b92016-08-17 13:24:10 -07001998
iannuccie53c9352016-08-17 14:40:40 -07001999 def test_SetCloseOverrideIssue(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002000
iannuccie53c9352016-08-17 14:40:40 -07002001 def assertIssue(cl_self, *_args):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002002 self.assertEqual(cl_self.issue, 1)
iannuccie53c9352016-08-17 14:40:40 -07002003 return 'foobar'
2004
Edward Lemurda4b6c62020-02-13 00:28:40 +00002005 mock.patch('git_cl.Changelist.FetchDescription', assertIssue).start()
2006 mock.patch('git_cl.Changelist.CloseIssue', lambda *_: None).start()
iannuccie53c9352016-08-17 14:40:40 -07002007 self.assertEqual(
Edward Lemur52969c92020-02-06 18:15:28 +00002008 git_cl.main(['set-close', '--issue', '1']), 0)
iannuccie53c9352016-08-17 14:40:40 -07002009
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002010 def test_description(self):
Edward Lemur26964072020-02-19 19:18:51 +00002011 self.mockGit.config['remote.origin.url'] = (
2012 'https://chromium.googlesource.com/my/repo')
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002013 gerrit_util.GetChangeDetail.return_value = {
2014 'current_revision': 'sha1',
2015 'revisions': {'sha1': {
2016 'commit': {'message': 'foobar'},
2017 }},
2018 }
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002019 self.assertEqual(0, git_cl.main([
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002020 'description',
2021 'https://chromium-review.googlesource.com/c/my/repo/+/123123',
2022 '-d']))
Edward Lemurda4b6c62020-02-13 00:28:40 +00002023 self.assertEqual('foobar\n', sys.stdout.getvalue())
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002024
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002025 def test_description_set_raw(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002026 mock.patch('git_cl.Changelist', ChangelistMock).start()
2027 mock.patch('git_cl.sys.stdin', StringIO('hihi')).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002028
2029 self.assertEqual(0, git_cl.main(['description', '-n', 'hihi']))
2030 self.assertEqual('hihi', ChangelistMock.desc)
2031
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002032 def test_description_appends_bug_line(self):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002033 current_desc = 'Some.\n\nChange-Id: xxx'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002034
2035 def RunEditor(desc, _, **kwargs):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002036 self.assertEqual(
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002037 '# Enter a description of the change.\n'
2038 '# This will be displayed on the codereview site.\n'
2039 '# The first line will also be used as the subject of the review.\n'
2040 '#--------------------This line is 72 characters long'
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002041 '--------------------\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -07002042 'Some.\n\nChange-Id: xxx\nBug: ',
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002043 desc)
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002044 # Simulate user changing something.
Aaron Gable3a16ed12017-03-23 10:51:55 -07002045 return 'Some.\n\nChange-Id: xxx\nBug: 123'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002046
Edward Lemur6c6827c2020-02-06 21:15:18 +00002047 def UpdateDescription(_, desc, force=False):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002048 self.assertEqual(desc, 'Some.\n\nChange-Id: xxx\nBug: 123')
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002049
Edward Lemurda4b6c62020-02-13 00:28:40 +00002050 mock.patch('git_cl.Changelist.FetchDescription',
2051 lambda *args: current_desc).start()
2052 mock.patch('git_cl.Changelist.UpdateDescription',
2053 UpdateDescription).start()
2054 mock.patch('git_cl.gclient_utils.RunEditor', RunEditor).start()
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002055
Edward Lemur85153282020-02-14 22:06:29 +00002056 self.mockGit.config['branch.master.gerritissue'] = '123'
Edward Lemur52969c92020-02-06 18:15:28 +00002057 self.assertEqual(0, git_cl.main(['description']))
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002058
Dan Beamd8b04ca2019-10-10 21:23:26 +00002059 def test_description_does_not_append_bug_line_if_fixed_is_present(self):
2060 current_desc = 'Some.\n\nFixed: 123\nChange-Id: xxx'
2061
2062 def RunEditor(desc, _, **kwargs):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002063 self.assertEqual(
Dan Beamd8b04ca2019-10-10 21:23:26 +00002064 '# Enter a description of the change.\n'
2065 '# This will be displayed on the codereview site.\n'
2066 '# The first line will also be used as the subject of the review.\n'
2067 '#--------------------This line is 72 characters long'
2068 '--------------------\n'
2069 'Some.\n\nFixed: 123\nChange-Id: xxx',
2070 desc)
2071 return desc
2072
Edward Lemurda4b6c62020-02-13 00:28:40 +00002073 mock.patch('git_cl.Changelist.FetchDescription',
2074 lambda *args: current_desc).start()
2075 mock.patch('git_cl.gclient_utils.RunEditor', RunEditor).start()
Dan Beamd8b04ca2019-10-10 21:23:26 +00002076
Edward Lemur85153282020-02-14 22:06:29 +00002077 self.mockGit.config['branch.master.gerritissue'] = '123'
Edward Lemur52969c92020-02-06 18:15:28 +00002078 self.assertEqual(0, git_cl.main(['description']))
Dan Beamd8b04ca2019-10-10 21:23:26 +00002079
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002080 def test_description_set_stdin(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002081 mock.patch('git_cl.Changelist', ChangelistMock).start()
2082 mock.patch('git_cl.sys.stdin', StringIO('hi \r\n\t there\n\nman')).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002083
2084 self.assertEqual(0, git_cl.main(['description', '-n', '-']))
2085 self.assertEqual('hi\n\t there\n\nman', ChangelistMock.desc)
2086
kmarshall3bff56b2016-06-06 18:31:47 -07002087 def test_archive(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002088 self.calls = [
2089 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
Edward Lemurf38bc172019-09-03 21:02:13 +00002090 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002091 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002092 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],), ''),
Edward Lemurf38bc172019-09-03 21:02:13 +00002093 ((['git', 'branch', '-D', 'foo'],), '')
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002094 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002095
Edward Lemurda4b6c62020-02-13 00:28:40 +00002096 mock.patch('git_cl.get_cl_statuses',
kmarshall3bff56b2016-06-06 18:31:47 -07002097 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002098 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2099 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002100 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall3bff56b2016-06-06 18:31:47 -07002101
2102 self.assertEqual(0, git_cl.main(['archive', '-f']))
2103
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002104 def test_archive_tag_collision(self):
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002105 self.calls = [
2106 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2107 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2108 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],),
2109 'refs/tags/git-cl-archived-456-foo'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002110 ((['git', 'tag', 'git-cl-archived-456-foo-2', 'foo'],), ''),
2111 ((['git', 'branch', '-D', 'foo'],), '')
2112 ]
2113
Edward Lemurda4b6c62020-02-13 00:28:40 +00002114 mock.patch('git_cl.get_cl_statuses',
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002115 lambda branches, fine_grained, max_processes:
2116 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2117 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002118 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002119
2120 self.assertEqual(0, git_cl.main(['archive', '-f']))
2121
kmarshall3bff56b2016-06-06 18:31:47 -07002122 def test_archive_current_branch_fails(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002123 self.calls = [
2124 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2125 'refs/heads/master'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002126 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002127 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002128
Edward Lemurda4b6c62020-02-13 00:28:40 +00002129 mock.patch('git_cl.get_cl_statuses',
kmarshall9249e012016-08-23 12:02:16 -07002130 lambda branches, fine_grained, max_processes:
Edward Lemurda4b6c62020-02-13 00:28:40 +00002131 [(MockChangelistWithBranchAndIssue('master', 1),
2132 'closed')]).start()
kmarshall9249e012016-08-23 12:02:16 -07002133
2134 self.assertEqual(1, git_cl.main(['archive', '-f']))
2135
2136 def test_archive_dry_run(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002137 self.calls = [
2138 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2139 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002140 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002141 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002142
Edward Lemurda4b6c62020-02-13 00:28:40 +00002143 mock.patch('git_cl.get_cl_statuses',
kmarshall3bff56b2016-06-06 18:31:47 -07002144 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002145 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2146 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002147 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall3bff56b2016-06-06 18:31:47 -07002148
kmarshall9249e012016-08-23 12:02:16 -07002149 self.assertEqual(0, git_cl.main(['archive', '-f', '--dry-run']))
2150
2151 def test_archive_no_tags(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002152 self.calls = [
2153 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2154 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002155 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002156 ((['git', 'branch', '-D', 'foo'],), '')
2157 ]
kmarshall9249e012016-08-23 12:02:16 -07002158
Edward Lemurda4b6c62020-02-13 00:28:40 +00002159 mock.patch('git_cl.get_cl_statuses',
kmarshall9249e012016-08-23 12:02:16 -07002160 lambda branches, fine_grained, max_processes:
2161 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2162 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002163 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall9249e012016-08-23 12:02:16 -07002164
2165 self.assertEqual(0, git_cl.main(['archive', '-f', '--notags']))
kmarshall3bff56b2016-06-06 18:31:47 -07002166
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002167 def test_archive_tag_cleanup_on_branch_deletion_error(self):
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002168 self.calls = [
2169 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2170 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2171 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002172 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],),
2173 'refs/tags/git-cl-archived-456-foo'),
2174 ((['git', 'branch', '-D', 'foo'],), CERR1),
2175 ((['git', 'tag', '-d', 'git-cl-archived-456-foo'],),
2176 'refs/tags/git-cl-archived-456-foo'),
2177 ]
2178
Edward Lemurda4b6c62020-02-13 00:28:40 +00002179 mock.patch('git_cl.get_cl_statuses',
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002180 lambda branches, fine_grained, max_processes:
2181 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2182 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002183 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002184
2185 self.assertEqual(0, git_cl.main(['archive', '-f']))
2186
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002187 def test_cmd_issue_erase_existing(self):
Edward Lemur85153282020-02-14 22:06:29 +00002188 self.mockGit.config['branch.master.gerritissue'] = '123'
2189 self.mockGit.config['branch.master.gerritserver'] = (
2190 'https://chromium-review.googlesource.com')
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002191 self.calls = [
Aaron Gableca01e2c2017-07-19 11:16:02 -07002192 ((['git', 'log', '-1', '--format=%B'],), 'This is a description'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002193 ]
2194 self.assertEqual(0, git_cl.main(['issue', '0']))
Edward Lemur85153282020-02-14 22:06:29 +00002195 self.assertNotIn('branch.master.gerritissue', self.mockGit.config)
2196 self.assertNotIn('branch.master.gerritserver', self.mockGit.config)
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002197
Aaron Gable400e9892017-07-12 15:31:21 -07002198 def test_cmd_issue_erase_existing_with_change_id(self):
Edward Lemur85153282020-02-14 22:06:29 +00002199 self.mockGit.config['branch.master.gerritissue'] = '123'
2200 self.mockGit.config['branch.master.gerritserver'] = (
2201 'https://chromium-review.googlesource.com')
Edward Lemurda4b6c62020-02-13 00:28:40 +00002202 mock.patch('git_cl.Changelist.FetchDescription',
2203 lambda _: 'This is a description\n\nChange-Id: Ideadbeef').start()
Aaron Gable400e9892017-07-12 15:31:21 -07002204 self.calls = [
Aaron Gableca01e2c2017-07-19 11:16:02 -07002205 ((['git', 'log', '-1', '--format=%B'],),
2206 'This is a description\n\nChange-Id: Ideadbeef'),
2207 ((['git', 'commit', '--amend', '-m', 'This is a description\n'],), ''),
Aaron Gable400e9892017-07-12 15:31:21 -07002208 ]
2209 self.assertEqual(0, git_cl.main(['issue', '0']))
Edward Lemur85153282020-02-14 22:06:29 +00002210 self.assertNotIn('branch.master.gerritissue', self.mockGit.config)
2211 self.assertNotIn('branch.master.gerritserver', self.mockGit.config)
Aaron Gable400e9892017-07-12 15:31:21 -07002212
phajdan.jre328cf92016-08-22 04:12:17 -07002213 def test_cmd_issue_json(self):
Edward Lemur85153282020-02-14 22:06:29 +00002214 self.mockGit.config['branch.master.gerritissue'] = '123'
2215 self.mockGit.config['branch.master.gerritserver'] = (
2216 'https://chromium-review.googlesource.com')
phajdan.jre328cf92016-08-22 04:12:17 -07002217 self.calls = [
phajdan.jre328cf92016-08-22 04:12:17 -07002218 (('write_json', 'output.json',
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002219 {'issue': 123,
2220 'issue_url': 'https://chromium-review.googlesource.com/123'}),
phajdan.jre328cf92016-08-22 04:12:17 -07002221 ''),
2222 ]
2223 self.assertEqual(0, git_cl.main(['issue', '--json', 'output.json']))
2224
tandrii16e0b4e2016-06-07 10:34:28 -07002225 def _common_GerritCommitMsgHookCheck(self):
Edward Lemur15a9b8c2020-02-13 00:52:30 +00002226 mock.patch(
2227 'git_cl.os.path.abspath',
2228 lambda path: self._mocked_call(['abspath', path])).start()
2229 mock.patch(
2230 'git_cl.os.path.exists',
2231 lambda path: self._mocked_call(['exists', path])).start()
2232 mock.patch(
2233 'git_cl.gclient_utils.FileRead',
2234 lambda path: self._mocked_call(['FileRead', path])).start()
2235 mock.patch(
2236 'git_cl.gclient_utils.rm_file_or_tree',
2237 lambda path: self._mocked_call(['rm_file_or_tree', path])).start()
Edward Lemur1a83da12020-03-04 21:18:36 +00002238 mock.patch(
2239 'git_cl.ask_for_data',
2240 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
Edward Lemurf38bc172019-09-03 21:02:13 +00002241 return git_cl.Changelist(issue=123)
tandrii16e0b4e2016-06-07 10:34:28 -07002242
2243 def test_GerritCommitMsgHookCheck_custom_hook(self):
2244 cl = self._common_GerritCommitMsgHookCheck()
2245 self.calls += [
Edward Lemur15a9b8c2020-02-13 00:52:30 +00002246 ((['exists', '.git/hooks/commit-msg'],), True),
2247 ((['FileRead', '.git/hooks/commit-msg'],),
tandrii16e0b4e2016-06-07 10:34:28 -07002248 '#!/bin/sh\necho "custom hook"')
2249 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002250 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002251
2252 def test_GerritCommitMsgHookCheck_not_exists(self):
2253 cl = self._common_GerritCommitMsgHookCheck()
2254 self.calls += [
Edward Lemur15a9b8c2020-02-13 00:52:30 +00002255 ((['exists', '.git/hooks/commit-msg'],), False),
tandrii16e0b4e2016-06-07 10:34:28 -07002256 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002257 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002258
2259 def test_GerritCommitMsgHookCheck(self):
2260 cl = self._common_GerritCommitMsgHookCheck()
2261 self.calls += [
Edward Lemur15a9b8c2020-02-13 00:52:30 +00002262 ((['exists', '.git/hooks/commit-msg'],), True),
2263 ((['FileRead', '.git/hooks/commit-msg'],),
tandrii16e0b4e2016-06-07 10:34:28 -07002264 '...\n# From Gerrit Code Review\n...\nadd_ChangeId()\n'),
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002265 (('ask_for_data', 'Do you want to remove it now? [Yes/No]: '), 'Yes'),
Edward Lemur15a9b8c2020-02-13 00:52:30 +00002266 ((['rm_file_or_tree', '.git/hooks/commit-msg'],),
tandrii16e0b4e2016-06-07 10:34:28 -07002267 ''),
2268 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002269 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002270
tandriic4344b52016-08-29 06:04:54 -07002271 def test_GerritCmdLand(self):
Edward Lemur85153282020-02-14 22:06:29 +00002272 self.mockGit.config['branch.master.gerritsquashhash'] = 'deadbeaf'
2273 self.mockGit.config['branch.master.gerritserver'] = (
2274 'chromium-review.googlesource.com')
tandriic4344b52016-08-29 06:04:54 -07002275 self.calls += [
tandriic4344b52016-08-29 06:04:54 -07002276 ((['git', 'diff', 'deadbeaf'],), ''), # No diff.
tandriic4344b52016-08-29 06:04:54 -07002277 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002278 cl = git_cl.Changelist(issue=123)
Edward Lemur125d60a2019-09-13 18:25:41 +00002279 cl._GetChangeDetail = lambda *args, **kwargs: {
tandriic4344b52016-08-29 06:04:54 -07002280 'labels': {},
2281 'current_revision': 'deadbeaf',
2282 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002283 cl._GetChangeCommit = lambda: {
agable32978d92016-11-01 12:55:02 -07002284 'commit': 'deadbeef',
Aaron Gable02cdbb42016-12-13 16:24:25 -08002285 'web_links': [{'name': 'gitiles',
agable32978d92016-11-01 12:55:02 -07002286 'url': 'https://git.googlesource.com/test/+/deadbeef'}],
2287 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002288 cl.SubmitIssue = lambda wait_for_merge: None
Olivier Robin75ee7252018-04-13 10:02:56 +02002289 self.assertEqual(0, cl.CMDLand(force=True,
2290 bypass_hooks=True,
2291 verbose=True,
2292 parallel=False))
Edward Lemur73c76702020-02-06 23:57:18 +00002293 self.assertIn(
2294 'Issue chromium-review.googlesource.com/123 has been submitted',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002295 sys.stdout.getvalue())
Edward Lemur73c76702020-02-06 23:57:18 +00002296 self.assertIn(
2297 'Landed as: https://git.googlesource.com/test/+/deadbeef',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002298 sys.stdout.getvalue())
tandriic4344b52016-08-29 06:04:54 -07002299
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002300 def _mock_gerrit_changes_for_detail_cache(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002301 mock.patch('git_cl.Changelist._GetGerritHost', lambda _: 'host').start()
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002302
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002303 def test_gerrit_change_detail_cache_simple(self):
2304 self._mock_gerrit_changes_for_detail_cache()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002305 gerrit_util.GetChangeDetail.side_effect = ['a', 'b']
Edward Lemurf38bc172019-09-03 21:02:13 +00002306 cl1 = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002307 cl1._cached_remote_url = (
2308 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemurf38bc172019-09-03 21:02:13 +00002309 cl2 = git_cl.Changelist(issue=2)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002310 cl2._cached_remote_url = (
2311 True, 'https://chromium.googlesource.com/ab/repo')
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002312 self.assertEqual(cl1._GetChangeDetail(), 'a') # Miss.
2313 self.assertEqual(cl1._GetChangeDetail(), 'a')
2314 self.assertEqual(cl2._GetChangeDetail(), 'b') # Miss.
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002315
2316 def test_gerrit_change_detail_cache_options(self):
2317 self._mock_gerrit_changes_for_detail_cache()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002318 gerrit_util.GetChangeDetail.side_effect = ['cab', 'ad']
Edward Lemurf38bc172019-09-03 21:02:13 +00002319 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002320 cl._cached_remote_url = (True, 'https://chromium.googlesource.com/repo/')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002321 self.assertEqual(cl._GetChangeDetail(options=['C', 'A', 'B']), 'cab')
2322 self.assertEqual(cl._GetChangeDetail(options=['A', 'B', 'C']), 'cab')
2323 self.assertEqual(cl._GetChangeDetail(options=['B', 'A']), 'cab')
2324 self.assertEqual(cl._GetChangeDetail(options=['C']), 'cab')
2325 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2326 self.assertEqual(cl._GetChangeDetail(), 'cab')
2327
2328 self.assertEqual(cl._GetChangeDetail(options=['A', 'D']), 'ad')
2329 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2330 self.assertEqual(cl._GetChangeDetail(options=['D']), 'ad')
2331 self.assertEqual(cl._GetChangeDetail(), 'cab')
2332
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002333 def test_gerrit_description_caching(self):
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002334 gerrit_util.GetChangeDetail.return_value = {
2335 'current_revision': 'rev1',
2336 'revisions': {
2337 'rev1': {'commit': {'message': 'desc1'}},
2338 },
2339 }
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002340
2341 self._mock_gerrit_changes_for_detail_cache()
Edward Lemurf38bc172019-09-03 21:02:13 +00002342 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002343 cl._cached_remote_url = (
2344 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemur6c6827c2020-02-06 21:15:18 +00002345 self.assertEqual(cl.FetchDescription(), 'desc1')
2346 self.assertEqual(cl.FetchDescription(), 'desc1') # cache hit.
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002347
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002348 def test_print_current_creds(self):
2349 class CookiesAuthenticatorMock(object):
2350 def __init__(self):
2351 self.gitcookies = {
2352 'host.googlesource.com': ('user', 'pass'),
2353 'host-review.googlesource.com': ('user', 'pass'),
2354 }
2355 self.netrc = self
2356 self.netrc.hosts = {
2357 'github.com': ('user2', None, 'pass2'),
2358 'host2.googlesource.com': ('user3', None, 'pass'),
2359 }
Edward Lemurda4b6c62020-02-13 00:28:40 +00002360 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
2361 CookiesAuthenticatorMock).start()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002362 git_cl._GitCookiesChecker().print_current_creds(include_netrc=True)
2363 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2364 ' Host\t User\t Which file',
2365 '============================\t=====\t===========',
2366 'host-review.googlesource.com\t user\t.gitcookies',
2367 ' host.googlesource.com\t user\t.gitcookies',
2368 ' host2.googlesource.com\tuser3\t .netrc',
2369 ])
Edward Lemur79d4f992019-11-11 23:49:02 +00002370 sys.stdout.seek(0)
2371 sys.stdout.truncate(0)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002372 git_cl._GitCookiesChecker().print_current_creds(include_netrc=False)
2373 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2374 ' Host\tUser\t Which file',
2375 '============================\t====\t===========',
2376 'host-review.googlesource.com\tuser\t.gitcookies',
2377 ' host.googlesource.com\tuser\t.gitcookies',
2378 ])
2379
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002380 def _common_creds_check_mocks(self):
2381 def exists_mock(path):
2382 dirname = os.path.dirname(path)
2383 if dirname == os.path.expanduser('~'):
2384 dirname = '~'
2385 base = os.path.basename(path)
2386 if base in ('.netrc', '.gitcookies'):
2387 return self._mocked_call('os.path.exists', '%s/%s' % (dirname, base))
2388 # git cl also checks for existence other files not relevant to this test.
2389 return None
Edward Lemur1a83da12020-03-04 21:18:36 +00002390 mock.patch(
2391 'git_cl.ask_for_data',
2392 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002393 mock.patch('os.path.exists', exists_mock).start()
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002394
2395 def test_creds_check_gitcookies_not_configured(self):
2396 self._common_creds_check_mocks()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002397 mock.patch('git_cl._GitCookiesChecker.get_hosts_with_creds',
2398 lambda _, include_netrc=False: []).start()
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002399 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08002400 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002401 ((['git', 'config', '--global', 'http.cookiefile'],), CERR1),
2402 (('os.path.exists', '~/.netrc'), True),
2403 (('ask_for_data', 'Press Enter to setup .gitcookies, '
2404 'or Ctrl+C to abort'), ''),
2405 ((['git', 'config', '--global', 'http.cookiefile',
2406 os.path.expanduser('~/.gitcookies')], ), ''),
2407 ]
2408 self.assertEqual(0, git_cl.main(['creds-check']))
Edward Lemur73c76702020-02-06 23:57:18 +00002409 self.assertTrue(
2410 sys.stdout.getvalue().startswith(
2411 'You seem to be using outdated .netrc for git credentials:'))
2412 self.assertIn(
2413 '\nConfigured git to use .gitcookies from',
2414 sys.stdout.getvalue())
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002415
2416 def test_creds_check_gitcookies_configured_custom_broken(self):
2417 self._common_creds_check_mocks()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002418 mock.patch('git_cl._GitCookiesChecker.get_hosts_with_creds',
2419 lambda _, include_netrc=False: []).start()
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002420 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08002421 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002422 ((['git', 'config', '--global', 'http.cookiefile'],),
2423 '/custom/.gitcookies'),
2424 (('os.path.exists', '/custom/.gitcookies'), False),
2425 (('ask_for_data', 'Reconfigure git to use default .gitcookies? '
2426 'Press Enter to reconfigure, or Ctrl+C to abort'), ''),
2427 ((['git', 'config', '--global', 'http.cookiefile',
2428 os.path.expanduser('~/.gitcookies')], ), ''),
2429 ]
2430 self.assertEqual(0, git_cl.main(['creds-check']))
Edward Lemur73c76702020-02-06 23:57:18 +00002431 self.assertIn(
2432 'WARNING: You have configured custom path to .gitcookies: ',
2433 sys.stdout.getvalue())
2434 self.assertIn(
2435 'However, your configured .gitcookies file is missing.',
2436 sys.stdout.getvalue())
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002437
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002438 def test_git_cl_comment_add_gerrit(self):
Edward Lemur85153282020-02-14 22:06:29 +00002439 self.mockGit.branchref = None
Edward Lemur26964072020-02-19 19:18:51 +00002440 self.mockGit.config['remote.origin.url'] = (
2441 'https://chromium.googlesource.com/infra/infra')
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002442 self.calls = [
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002443 (('SetReview', 'chromium-review.googlesource.com', 'infra%2Finfra~10',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002444 'msg', None, None, None),
Aaron Gable636b13f2017-07-14 10:42:48 -07002445 None),
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002446 ]
Edward Lemur52969c92020-02-06 18:15:28 +00002447 self.assertEqual(0, git_cl.main(['comment', '-i', '10', '-a', 'msg']))
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002448
Edward Lemurda4b6c62020-02-13 00:28:40 +00002449 @mock.patch('git_cl.Changelist.GetBranch', return_value='foo')
2450 def test_git_cl_comments_fetch_gerrit(self, *_mocks):
Edward Lemur26964072020-02-19 19:18:51 +00002451 self.mockGit.config['remote.origin.url'] = (
2452 'https://chromium.googlesource.com/infra/infra')
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002453 gerrit_util.GetChangeDetail.return_value = {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002454 'owner': {'email': 'owner@example.com'},
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002455 'current_revision': 'ba5eba11',
2456 'revisions': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002457 'deadbeaf': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002458 '_number': 1,
2459 },
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002460 'ba5eba11': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002461 '_number': 2,
2462 },
2463 },
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002464 'messages': [
2465 {
2466 u'_revision_number': 1,
2467 u'author': {
2468 u'_account_id': 1111084,
2469 u'email': u'commit-bot@chromium.org',
2470 u'name': u'Commit Bot'
2471 },
2472 u'date': u'2017-03-15 20:08:45.000000000',
2473 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
Dirk Prankef6a58802017-10-17 12:49:42 -07002474 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002475 u'tag': u'autogenerated:cq:dry-run'
2476 },
2477 {
2478 u'_revision_number': 2,
2479 u'author': {
2480 u'_account_id': 11151243,
2481 u'email': u'owner@example.com',
2482 u'name': u'owner'
2483 },
2484 u'date': u'2017-03-16 20:00:41.000000000',
2485 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2486 u'message': u'PTAL',
2487 },
2488 {
2489 u'_revision_number': 2,
2490 u'author': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002491 u'_account_id': 148512,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002492 u'email': u'reviewer@example.com',
2493 u'name': u'reviewer'
2494 },
2495 u'date': u'2017-03-17 05:19:37.500000000',
2496 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2497 u'message': u'Patch Set 2: Code-Review+1',
2498 },
2499 ]
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002500 }
2501 self.calls = [
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002502 (('GetChangeComments', 'chromium-review.googlesource.com',
2503 'infra%2Finfra~1'), {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002504 '/COMMIT_MSG': [
2505 {
2506 'author': {'email': u'reviewer@example.com'},
2507 'updated': u'2017-03-17 05:19:37.500000000',
2508 'patch_set': 2,
2509 'side': 'REVISION',
2510 'message': 'Please include a bug link',
2511 },
2512 ],
2513 'codereview.settings': [
2514 {
2515 'author': {'email': u'owner@example.com'},
2516 'updated': u'2017-03-16 20:00:41.000000000',
2517 'patch_set': 2,
2518 'side': 'PARENT',
2519 'line': 42,
2520 'message': 'I removed this because it is bad',
2521 },
2522 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002523 }),
2524 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
2525 'infra%2Finfra~1'), {}),
Leszek Swirski45b20c42018-09-17 17:05:26 +00002526 ] * 2 + [
2527 (('write_json', 'output.json', [
2528 {
2529 u'date': u'2017-03-16 20:00:41.000000',
2530 u'message': (
2531 u'PTAL\n' +
2532 u'\n' +
2533 u'codereview.settings\n' +
2534 u' Base, Line 42: https://chromium-review.googlesource.com/' +
2535 u'c/1/2/codereview.settings#b42\n' +
2536 u' I removed this because it is bad\n'),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002537 u'autogenerated': False,
Leszek Swirski45b20c42018-09-17 17:05:26 +00002538 u'approval': False,
2539 u'disapproval': False,
2540 u'sender': u'owner@example.com'
2541 }, {
2542 u'date': u'2017-03-17 05:19:37.500000',
2543 u'message': (
2544 u'Patch Set 2: Code-Review+1\n' +
2545 u'\n' +
2546 u'/COMMIT_MSG\n' +
2547 u' PS2, File comment: https://chromium-review.googlesource' +
2548 u'.com/c/1/2//COMMIT_MSG#\n' +
2549 u' Please include a bug link\n'),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002550 u'autogenerated': False,
Leszek Swirski45b20c42018-09-17 17:05:26 +00002551 u'approval': False,
2552 u'disapproval': False,
2553 u'sender': u'reviewer@example.com'
2554 }
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002555 ]), '')
Leszek Swirski45b20c42018-09-17 17:05:26 +00002556 ]
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002557 expected_comments_summary = [
2558 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002559 message=(
2560 u'PTAL\n' +
2561 u'\n' +
2562 u'codereview.settings\n' +
2563 u' Base, Line 42: https://chromium-review.googlesource.com/' +
2564 u'c/1/2/codereview.settings#b42\n' +
2565 u' I removed this because it is bad\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002566 date=datetime.datetime(2017, 3, 16, 20, 0, 41, 0),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002567 autogenerated=False,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002568 disapproval=False, approval=False, sender=u'owner@example.com'),
2569 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002570 message=(
2571 u'Patch Set 2: Code-Review+1\n' +
2572 u'\n' +
2573 u'/COMMIT_MSG\n' +
2574 u' PS2, File comment: https://chromium-review.googlesource.com/' +
2575 u'c/1/2//COMMIT_MSG#\n' +
2576 u' Please include a bug link\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002577 date=datetime.datetime(2017, 3, 17, 5, 19, 37, 500000),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002578 autogenerated=False,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002579 disapproval=False, approval=False, sender=u'reviewer@example.com'),
2580 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002581 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00002582 issue=1, branchref='refs/heads/foo')
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002583 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002584 self.assertEqual(
2585 0, git_cl.main(['comments', '-i', '1', '-j', 'output.json']))
2586
2587 def test_git_cl_comments_robot_comments(self):
2588 # git cl comments also fetches robot comments (which are considered a type
2589 # of autogenerated comment), and unlike other types of comments, only robot
2590 # comments from the latest patchset are shown.
Edward Lemur26964072020-02-19 19:18:51 +00002591 self.mockGit.config['remote.origin.url'] = (
2592 'https://chromium.googlesource.com/infra/infra')
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002593 gerrit_util.GetChangeDetail.return_value = {
2594 'owner': {'email': 'owner@example.com'},
2595 'current_revision': 'ba5eba11',
2596 'revisions': {
2597 'deadbeaf': {
2598 '_number': 1,
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002599 },
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002600 'ba5eba11': {
2601 '_number': 2,
2602 },
2603 },
2604 'messages': [
2605 {
2606 u'_revision_number': 1,
2607 u'author': {
2608 u'_account_id': 1111084,
2609 u'email': u'commit-bot@chromium.org',
2610 u'name': u'Commit Bot'
2611 },
2612 u'date': u'2017-03-15 20:08:45.000000000',
2613 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
2614 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
2615 u'tag': u'autogenerated:cq:dry-run'
2616 },
2617 {
2618 u'_revision_number': 1,
2619 u'author': {
2620 u'_account_id': 123,
2621 u'email': u'tricium@serviceaccount.com',
2622 u'name': u'Tricium'
2623 },
2624 u'date': u'2017-03-16 20:00:41.000000000',
2625 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2626 u'message': u'(1 comment)',
2627 u'tag': u'autogenerated:tricium',
2628 },
2629 {
2630 u'_revision_number': 1,
2631 u'author': {
2632 u'_account_id': 123,
2633 u'email': u'tricium@serviceaccount.com',
2634 u'name': u'Tricium'
2635 },
2636 u'date': u'2017-03-16 20:00:41.000000000',
2637 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2638 u'message': u'(1 comment)',
2639 u'tag': u'autogenerated:tricium',
2640 },
2641 {
2642 u'_revision_number': 2,
2643 u'author': {
2644 u'_account_id': 123,
2645 u'email': u'tricium@serviceaccount.com',
2646 u'name': u'reviewer'
2647 },
2648 u'date': u'2017-03-17 05:30:37.000000000',
2649 u'tag': u'autogenerated:tricium',
2650 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2651 u'message': u'(1 comment)',
2652 },
2653 ]
2654 }
2655 self.calls = [
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002656 (('GetChangeComments', 'chromium-review.googlesource.com',
2657 'infra%2Finfra~1'), {}),
2658 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
2659 'infra%2Finfra~1'), {
2660 'codereview.settings': [
2661 {
2662 u'author': {u'email': u'tricium@serviceaccount.com'},
2663 u'updated': u'2017-03-17 05:30:37.000000000',
2664 u'robot_run_id': u'5565031076855808',
2665 u'robot_id': u'Linter/Category',
2666 u'tag': u'autogenerated:tricium',
2667 u'patch_set': 2,
2668 u'side': u'REVISION',
2669 u'message': u'Linter warning message text',
2670 u'line': 32,
2671 },
2672 ],
2673 }),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002674 ]
2675 expected_comments_summary = [
2676 git_cl._CommentSummary(date=datetime.datetime(2017, 3, 17, 5, 30, 37),
2677 message=(
2678 u'(1 comment)\n\ncodereview.settings\n'
2679 u' PS2, Line 32: https://chromium-review.googlesource.com/'
2680 u'c/1/2/codereview.settings#32\n'
2681 u' Linter warning message text\n'),
2682 sender=u'tricium@serviceaccount.com',
2683 autogenerated=True, approval=False, disapproval=False)
2684 ]
2685 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00002686 issue=1, branchref='refs/heads/foo')
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002687 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002688
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002689 def test_get_remote_url_with_mirror(self):
2690 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002691
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002692 def selective_os_path_isdir_mock(path):
2693 if path == '/cache/this-dir-exists':
2694 return self._mocked_call('os.path.isdir', path)
2695 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002696
Edward Lemurda4b6c62020-02-13 00:28:40 +00002697 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002698
2699 url = 'https://chromium.googlesource.com/my/repo'
Edward Lemur26964072020-02-19 19:18:51 +00002700 self.mockGit.config['remote.origin.url'] = (
2701 '/cache/this-dir-exists')
2702 self.mockGit.config['/cache/this-dir-exists:remote.origin.url'] = (
2703 url)
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002704 self.calls = [
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002705 (('os.path.isdir', '/cache/this-dir-exists'),
2706 True),
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002707 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002708 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002709 self.assertEqual(cl.GetRemoteUrl(), url)
2710 self.assertEqual(cl.GetRemoteUrl(), url) # Must be cached.
2711
Edward Lemur298f2cf2019-02-22 21:40:39 +00002712 def test_get_remote_url_non_existing_mirror(self):
2713 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002714
Edward Lemur298f2cf2019-02-22 21:40:39 +00002715 def selective_os_path_isdir_mock(path):
2716 if path == '/cache/this-dir-doesnt-exist':
2717 return self._mocked_call('os.path.isdir', path)
2718 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002719
Edward Lemurda4b6c62020-02-13 00:28:40 +00002720 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
2721 mock.patch('logging.error',
2722 lambda *a: self._mocked_call('logging.error', *a)).start()
Edward Lemur298f2cf2019-02-22 21:40:39 +00002723
Edward Lemur26964072020-02-19 19:18:51 +00002724 self.mockGit.config['remote.origin.url'] = (
2725 '/cache/this-dir-doesnt-exist')
Edward Lemur298f2cf2019-02-22 21:40:39 +00002726 self.calls = [
Edward Lemur298f2cf2019-02-22 21:40:39 +00002727 (('os.path.isdir', '/cache/this-dir-doesnt-exist'),
2728 False),
2729 (('logging.error',
Josip906bfde2020-01-31 22:38:49 +00002730 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
2731 'but it doesn\'t exist.', {
2732 'remote': 'origin',
2733 'branch': 'master',
2734 'url': '/cache/this-dir-doesnt-exist'}
2735 ), None),
Edward Lemur298f2cf2019-02-22 21:40:39 +00002736 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002737 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00002738 self.assertIsNone(cl.GetRemoteUrl())
2739
2740 def test_get_remote_url_misconfigured_mirror(self):
2741 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002742
Edward Lemur298f2cf2019-02-22 21:40:39 +00002743 def selective_os_path_isdir_mock(path):
2744 if path == '/cache/this-dir-exists':
2745 return self._mocked_call('os.path.isdir', path)
2746 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002747
Edward Lemurda4b6c62020-02-13 00:28:40 +00002748 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
2749 mock.patch('logging.error',
2750 lambda *a: self._mocked_call('logging.error', *a)).start()
Edward Lemur298f2cf2019-02-22 21:40:39 +00002751
Edward Lemur26964072020-02-19 19:18:51 +00002752 self.mockGit.config['remote.origin.url'] = (
2753 '/cache/this-dir-exists')
Edward Lemur298f2cf2019-02-22 21:40:39 +00002754 self.calls = [
Edward Lemur298f2cf2019-02-22 21:40:39 +00002755 (('os.path.isdir', '/cache/this-dir-exists'), True),
Edward Lemur298f2cf2019-02-22 21:40:39 +00002756 (('logging.error',
2757 'Remote "%(remote)s" for branch "%(branch)s" points to '
2758 '"%(cache_path)s", but it is misconfigured.\n'
2759 '"%(cache_path)s" must be a git repo and must have a remote named '
2760 '"%(remote)s" pointing to the git host.', {
2761 'remote': 'origin',
2762 'cache_path': '/cache/this-dir-exists',
2763 'branch': 'master'}
2764 ), None),
2765 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002766 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00002767 self.assertIsNone(cl.GetRemoteUrl())
2768
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002769 def test_gerrit_change_identifier_with_project(self):
Edward Lemur26964072020-02-19 19:18:51 +00002770 self.mockGit.config['remote.origin.url'] = (
2771 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemurf38bc172019-09-03 21:02:13 +00002772 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002773 self.assertEqual(cl._GerritChangeIdentifier(), 'my%2Frepo~123456')
2774
2775 def test_gerrit_change_identifier_without_project(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002776 mock.patch('logging.error',
2777 lambda *a: self._mocked_call('logging.error', *a)).start()
Josip906bfde2020-01-31 22:38:49 +00002778
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002779 self.calls = [
Josip906bfde2020-01-31 22:38:49 +00002780 (('logging.error',
2781 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
2782 'but it doesn\'t exist.', {
2783 'remote': 'origin',
2784 'branch': 'master',
2785 'url': ''}
2786 ), None),
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002787 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002788 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002789 self.assertEqual(cl._GerritChangeIdentifier(), '123456')
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00002790
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002791
Edward Lemur9aa1a962020-02-25 00:58:38 +00002792class ChangelistTest(unittest.TestCase):
Edward Lemur227d5102020-02-25 23:45:35 +00002793 def setUp(self):
2794 super(ChangelistTest, self).setUp()
2795 mock.patch('gclient_utils.FileRead').start()
2796 mock.patch('gclient_utils.FileWrite').start()
2797 mock.patch('gclient_utils.temporary_file', TemporaryFileMock()).start()
2798 mock.patch(
2799 'git_cl.Changelist.GetCodereviewServer',
2800 return_value='https://chromium-review.googlesource.com').start()
2801 mock.patch('git_cl.Changelist.GetAuthor', return_value='author').start()
2802 mock.patch('git_cl.Changelist.GetIssue', return_value=123456).start()
2803 mock.patch('git_cl.Changelist.GetPatchset', return_value=7).start()
2804 mock.patch('git_cl.PRESUBMIT_SUPPORT', 'PRESUBMIT_SUPPORT').start()
2805 mock.patch('git_cl.Settings.GetRoot', return_value='root').start()
2806 mock.patch('git_cl.time_time').start()
2807 mock.patch('metrics.collector').start()
2808 mock.patch('subprocess2.Popen').start()
2809 self.addCleanup(mock.patch.stopall)
2810 self.temp_count = 0
2811
Edward Lemur9aa1a962020-02-25 00:58:38 +00002812 @mock.patch('git_cl.RunGitWithCode')
2813 def testGetLocalDescription(self, _mock):
2814 git_cl.RunGitWithCode.return_value = (0, 'description')
2815 cl = git_cl.Changelist()
2816 self.assertEqual('description', cl.GetLocalDescription('branch'))
2817 self.assertEqual('description', cl.GetLocalDescription('branch'))
2818 git_cl.RunGitWithCode.assert_called_once_with(
2819 ['log', '--pretty=format:%s%n%n%b', 'branch...'])
2820
Edward Lemur227d5102020-02-25 23:45:35 +00002821 def testRunHook(self):
2822 expected_results = {
2823 'more_cc': ['more@example.com', 'cc@example.com'],
2824 'should_continue': True,
2825 }
2826 gclient_utils.FileRead.return_value = json.dumps(expected_results)
2827 git_cl.time_time.side_effect = [100, 200]
2828 mockProcess = mock.Mock()
2829 mockProcess.wait.return_value = 0
2830 subprocess2.Popen.return_value = mockProcess
2831
2832 cl = git_cl.Changelist()
2833 results = cl.RunHook(
2834 committing=True,
2835 may_prompt=True,
2836 verbose=2,
2837 parallel=True,
2838 upstream='upstream',
2839 description='description',
2840 all_files=True)
2841
2842 self.assertEqual(expected_results, results)
2843 subprocess2.Popen.assert_called_once_with([
2844 'vpython', 'PRESUBMIT_SUPPORT',
Edward Lemur227d5102020-02-25 23:45:35 +00002845 '--author', 'author',
2846 '--root', 'root',
2847 '--upstream', 'upstream',
2848 '--verbose', '--verbose',
2849 '--issue', '123456',
2850 '--patchset', '7',
2851 '--gerrit_url', 'https://chromium-review.googlesource.com',
Edward Lemur75526302020-02-27 22:31:05 +00002852 '--commit',
Edward Lemur227d5102020-02-25 23:45:35 +00002853 '--may_prompt',
2854 '--parallel',
2855 '--all_files',
2856 '--json_output', '/tmp/fake-temp2',
2857 '--description_file', '/tmp/fake-temp1',
2858 ])
2859 gclient_utils.FileWrite.assert_called_once_with(
Edward Lemur1a83da12020-03-04 21:18:36 +00002860 '/tmp/fake-temp1', 'description')
Edward Lemur227d5102020-02-25 23:45:35 +00002861 metrics.collector.add_repeated('sub_commands', {
2862 'command': 'presubmit',
2863 'execution_time': 100,
2864 'exit_code': 0,
2865 })
2866
2867 @mock.patch('sys.exit', side_effect=SystemExitMock)
2868 def testRunHook_Failure(self, _mock):
2869 git_cl.time_time.side_effect = [100, 200]
2870 mockProcess = mock.Mock()
2871 mockProcess.wait.return_value = 2
2872 subprocess2.Popen.return_value = mockProcess
2873
2874 cl = git_cl.Changelist()
2875 with self.assertRaises(SystemExitMock):
2876 cl.RunHook(
2877 committing=True,
2878 may_prompt=True,
2879 verbose=2,
2880 parallel=True,
2881 upstream='upstream',
2882 description='description',
2883 all_files=True)
2884
2885 sys.exit.assert_called_once_with(2)
2886
Edward Lemur75526302020-02-27 22:31:05 +00002887 def testRunPostUploadHook(self):
2888 cl = git_cl.Changelist()
2889 cl.RunPostUploadHook(2, 'upstream', 'description')
2890
2891 subprocess2.Popen.assert_called_once_with([
2892 'vpython', 'PRESUBMIT_SUPPORT',
2893 '--author', 'author',
2894 '--root', 'root',
2895 '--upstream', 'upstream',
2896 '--verbose', '--verbose',
2897 '--issue', '123456',
2898 '--patchset', '7',
2899 '--gerrit_url', 'https://chromium-review.googlesource.com',
2900 '--post_upload',
2901 '--description_file', '/tmp/fake-temp1',
2902 ])
2903 gclient_utils.FileWrite.assert_called_once_with(
Edward Lemur1a83da12020-03-04 21:18:36 +00002904 '/tmp/fake-temp1', 'description')
Edward Lemur75526302020-02-27 22:31:05 +00002905
Edward Lemur9aa1a962020-02-25 00:58:38 +00002906
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002907class CMDTestCaseBase(unittest.TestCase):
2908 _STATUSES = [
2909 'STATUS_UNSPECIFIED', 'SCHEDULED', 'STARTED', 'SUCCESS', 'FAILURE',
2910 'INFRA_FAILURE', 'CANCELED',
2911 ]
2912 _CHANGE_DETAIL = {
2913 'project': 'depot_tools',
2914 'status': 'OPEN',
2915 'owner': {'email': 'owner@e.mail'},
2916 'current_revision': 'beeeeeef',
2917 'revisions': {
2918 'deadbeaf': {'_number': 6},
2919 'beeeeeef': {
2920 '_number': 7,
2921 'fetch': {'http': {
2922 'url': 'https://chromium.googlesource.com/depot_tools',
2923 'ref': 'refs/changes/56/123456/7'
2924 }},
2925 },
2926 },
2927 }
2928 _DEFAULT_RESPONSE = {
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00002929 'builds': [{
2930 'id': str(100 + idx),
2931 'builder': {
2932 'project': 'chromium',
2933 'bucket': 'try',
2934 'builder': 'bot_' + status.lower(),
2935 },
2936 'createTime': '2019-10-09T08:00:0%d.854286Z' % (idx % 10),
2937 'tags': [],
2938 'status': status,
2939 } for idx, status in enumerate(_STATUSES)]
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002940 }
2941
Edward Lemur4c707a22019-09-24 21:13:43 +00002942 def setUp(self):
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002943 super(CMDTestCaseBase, self).setUp()
Edward Lemur79d4f992019-11-11 23:49:02 +00002944 mock.patch('git_cl.sys.stdout', StringIO()).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002945 mock.patch('git_cl.uuid.uuid4', return_value='uuid4').start()
2946 mock.patch('git_cl.Changelist.GetIssue', return_value=123456).start()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002947 mock.patch(
2948 'git_cl.Changelist.GetCodereviewServer',
2949 return_value='https://chromium-review.googlesource.com').start()
2950 mock.patch(
2951 'git_cl.Changelist._GetGerritHost',
2952 return_value='chromium-review.googlesource.com').start()
2953 mock.patch(
2954 'git_cl.Changelist.GetMostRecentPatchset',
2955 return_value=7).start()
2956 mock.patch(
2957 'git_cl.Changelist.GetRemoteUrl',
2958 return_value='https://chromium.googlesource.com/depot_tools').start()
2959 mock.patch(
2960 'auth.Authenticator',
2961 return_value=AuthenticatorMock()).start()
2962 mock.patch(
2963 'gerrit_util.GetChangeDetail',
2964 return_value=self._CHANGE_DETAIL).start()
2965 mock.patch(
2966 'git_cl._call_buildbucket',
2967 return_value = self._DEFAULT_RESPONSE).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002968 mock.patch('git_common.is_dirty_git_tree', return_value=False).start()
Edward Lemur4c707a22019-09-24 21:13:43 +00002969 self.addCleanup(mock.patch.stopall)
2970
Edward Lemur4c707a22019-09-24 21:13:43 +00002971
Edward Lemur9468eba2020-02-27 19:07:22 +00002972class CMDPresubmitTestCase(CMDTestCaseBase):
2973 def setUp(self):
2974 super(CMDPresubmitTestCase, self).setUp()
2975 mock.patch(
2976 'git_cl.Changelist.GetCommonAncestorWithUpstream',
2977 return_value='upstream').start()
2978 mock.patch(
2979 'git_cl.Changelist.FetchDescription',
2980 return_value='fetch description').start()
2981 mock.patch(
2982 'git_cl.Changelist.GetLocalDescription',
2983 return_value='get description').start()
2984 mock.patch('git_cl.Changelist.RunHook').start()
2985
2986 def testDefaultCase(self):
2987 self.assertEqual(0, git_cl.main(['presubmit']))
2988 git_cl.Changelist.RunHook.assert_called_once_with(
2989 committing=True,
2990 may_prompt=False,
2991 verbose=0,
2992 parallel=None,
2993 upstream='upstream',
2994 description='fetch description',
2995 all_files=None)
2996
2997 def testNoIssue(self):
2998 git_cl.Changelist.GetIssue.return_value = None
2999 self.assertEqual(0, git_cl.main(['presubmit']))
3000 git_cl.Changelist.RunHook.assert_called_once_with(
3001 committing=True,
3002 may_prompt=False,
3003 verbose=0,
3004 parallel=None,
3005 upstream='upstream',
3006 description='get description',
3007 all_files=None)
3008
3009 def testCustomBranch(self):
3010 self.assertEqual(0, git_cl.main(['presubmit', 'custom_branch']))
3011 git_cl.Changelist.RunHook.assert_called_once_with(
3012 committing=True,
3013 may_prompt=False,
3014 verbose=0,
3015 parallel=None,
3016 upstream='custom_branch',
3017 description='fetch description',
3018 all_files=None)
3019
3020 def testOptions(self):
3021 self.assertEqual(
3022 0, git_cl.main(['presubmit', '-v', '-v', '--all', '--parallel', '-u']))
3023 git_cl.Changelist.RunHook.assert_called_once_with(
3024 committing=False,
3025 may_prompt=False,
3026 verbose=2,
3027 parallel=True,
3028 upstream='upstream',
3029 description='fetch description',
3030 all_files=True)
3031
3032
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003033class CMDTryResultsTestCase(CMDTestCaseBase):
3034 _DEFAULT_REQUEST = {
3035 'predicate': {
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003036 "gerritChanges": [{
3037 "project": "depot_tools",
3038 "host": "chromium-review.googlesource.com",
3039 "patchset": 7,
3040 "change": 123456,
3041 }],
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003042 },
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003043 'fields': ('builds.*.id,builds.*.builder,builds.*.status' +
3044 ',builds.*.createTime,builds.*.tags'),
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003045 }
3046
3047 def testNoJobs(self):
3048 git_cl._call_buildbucket.return_value = {}
3049
3050 self.assertEqual(0, git_cl.main(['try-results']))
3051 self.assertEqual('No tryjobs scheduled.\n', sys.stdout.getvalue())
3052 git_cl._call_buildbucket.assert_called_once_with(
3053 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3054 self._DEFAULT_REQUEST)
3055
3056 def testPrintToStdout(self):
3057 self.assertEqual(0, git_cl.main(['try-results']))
3058 self.assertEqual([
3059 'Successes:',
3060 ' bot_success https://ci.chromium.org/b/103',
3061 'Infra Failures:',
3062 ' bot_infra_failure https://ci.chromium.org/b/105',
3063 'Failures:',
3064 ' bot_failure https://ci.chromium.org/b/104',
3065 'Canceled:',
3066 ' bot_canceled ',
3067 'Started:',
3068 ' bot_started https://ci.chromium.org/b/102',
3069 'Scheduled:',
3070 ' bot_scheduled id=101',
3071 'Other:',
3072 ' bot_status_unspecified id=100',
3073 'Total: 7 tryjobs',
3074 ], sys.stdout.getvalue().splitlines())
3075 git_cl._call_buildbucket.assert_called_once_with(
3076 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3077 self._DEFAULT_REQUEST)
3078
3079 def testPrintToStdoutWithMasters(self):
3080 self.assertEqual(0, git_cl.main(['try-results', '--print-master']))
3081 self.assertEqual([
3082 'Successes:',
3083 ' try bot_success https://ci.chromium.org/b/103',
3084 'Infra Failures:',
3085 ' try bot_infra_failure https://ci.chromium.org/b/105',
3086 'Failures:',
3087 ' try bot_failure https://ci.chromium.org/b/104',
3088 'Canceled:',
3089 ' try bot_canceled ',
3090 'Started:',
3091 ' try bot_started https://ci.chromium.org/b/102',
3092 'Scheduled:',
3093 ' try bot_scheduled id=101',
3094 'Other:',
3095 ' try bot_status_unspecified id=100',
3096 'Total: 7 tryjobs',
3097 ], sys.stdout.getvalue().splitlines())
3098 git_cl._call_buildbucket.assert_called_once_with(
3099 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3100 self._DEFAULT_REQUEST)
3101
3102 @mock.patch('git_cl.write_json')
3103 def testWriteToJson(self, mockJsonDump):
3104 self.assertEqual(0, git_cl.main(['try-results', '--json', 'file.json']))
3105 git_cl._call_buildbucket.assert_called_once_with(
3106 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3107 self._DEFAULT_REQUEST)
3108 mockJsonDump.assert_called_once_with(
3109 'file.json', self._DEFAULT_RESPONSE['builds'])
3110
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003111 def test_filter_failed_for_one_simple(self):
Edward Lemur45768512020-03-02 19:03:14 +00003112 self.assertEqual([], git_cl._filter_failed_for_retry([]))
3113 self.assertEqual(
3114 [
3115 ('chromium', 'try', 'bot_failure'),
3116 ('chromium', 'try', 'bot_infra_failure'),
3117 ],
3118 git_cl._filter_failed_for_retry(self._DEFAULT_RESPONSE['builds']))
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003119
3120 def test_filter_failed_for_retry_many_builds(self):
3121
3122 def _build(name, created_sec, status, experimental=False):
3123 assert 0 <= created_sec < 100, created_sec
3124 b = {
3125 'id': 112112,
3126 'builder': {
3127 'project': 'chromium',
3128 'bucket': 'try',
3129 'builder': name,
3130 },
3131 'createTime': '2019-10-09T08:00:%02d.854286Z' % created_sec,
3132 'status': status,
3133 'tags': [],
3134 }
3135 if experimental:
3136 b['tags'].append({'key': 'cq_experimental', 'value': 'true'})
3137 return b
3138
3139 builds = [
3140 _build('flaky-last-green', 1, 'FAILURE'),
3141 _build('flaky-last-green', 2, 'SUCCESS'),
3142 _build('flaky', 1, 'SUCCESS'),
3143 _build('flaky', 2, 'FAILURE'),
3144 _build('running', 1, 'FAILED'),
3145 _build('running', 2, 'SCHEDULED'),
3146 _build('yep-still-running', 1, 'STARTED'),
3147 _build('yep-still-running', 2, 'FAILURE'),
3148 _build('cq-experimental', 1, 'SUCCESS', experimental=True),
3149 _build('cq-experimental', 2, 'FAILURE', experimental=True),
3150
3151 # Simulate experimental in CQ builder, which developer decided
3152 # to retry manually which resulted in 2nd build non-experimental.
3153 _build('sometimes-experimental', 1, 'FAILURE', experimental=True),
3154 _build('sometimes-experimental', 2, 'FAILURE', experimental=False),
3155 ]
3156 builds.sort(key=lambda b: b['status']) # ~deterministic shuffle.
Edward Lemur45768512020-03-02 19:03:14 +00003157 self.assertEqual(
3158 [
3159 ('chromium', 'try', 'flaky'),
3160 ('chromium', 'try', 'sometimes-experimental'),
3161 ],
3162 git_cl._filter_failed_for_retry(builds))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003163
3164
3165class CMDTryTestCase(CMDTestCaseBase):
3166
3167 @mock.patch('git_cl.Changelist.SetCQState')
Edward Lemur45768512020-03-02 19:03:14 +00003168 def testSetCQDryRunByDefault(self, mockSetCQState):
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003169 mockSetCQState.return_value = 0
Edward Lemur4c707a22019-09-24 21:13:43 +00003170 self.assertEqual(0, git_cl.main(['try']))
3171 git_cl.Changelist.SetCQState.assert_called_with(git_cl._CQState.DRY_RUN)
3172 self.assertEqual(
3173 sys.stdout.getvalue(),
3174 'Scheduling CQ dry run on: '
3175 'https://chromium-review.googlesource.com/123456\n')
3176
Edward Lemur4c707a22019-09-24 21:13:43 +00003177 @mock.patch('git_cl._call_buildbucket')
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003178 def testScheduleOnBuildbucket(self, mockCallBuildbucket):
Edward Lemur4c707a22019-09-24 21:13:43 +00003179 mockCallBuildbucket.return_value = {}
Edward Lemur4c707a22019-09-24 21:13:43 +00003180
3181 self.assertEqual(0, git_cl.main([
3182 'try', '-B', 'luci.chromium.try', '-b', 'win',
3183 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
3184 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003185 'Scheduling jobs on:\n'
3186 ' chromium/try: win',
Edward Lemur4c707a22019-09-24 21:13:43 +00003187 git_cl.sys.stdout.getvalue())
3188
3189 expected_request = {
3190 "requests": [{
3191 "scheduleBuild": {
3192 "requestId": "uuid4",
3193 "builder": {
3194 "project": "chromium",
3195 "builder": "win",
3196 "bucket": "try",
3197 },
3198 "gerritChanges": [{
3199 "project": "depot_tools",
3200 "host": "chromium-review.googlesource.com",
3201 "patchset": 7,
3202 "change": 123456,
3203 }],
3204 "properties": {
3205 "category": "git_cl_try",
3206 "json": [{"a": 1}, None],
3207 "key": "val",
3208 },
3209 "tags": [
3210 {"value": "win", "key": "builder"},
3211 {"value": "git_cl_try", "key": "user_agent"},
3212 ],
3213 },
3214 }],
3215 }
3216 mockCallBuildbucket.assert_called_with(
3217 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3218
Anthony Polito1a5fe232020-01-24 23:17:52 +00003219 @mock.patch('git_cl._call_buildbucket')
3220 def testScheduleOnBuildbucketWithRevision(self, mockCallBuildbucket):
3221 mockCallBuildbucket.return_value = {}
3222
3223 self.assertEqual(0, git_cl.main([
3224 'try', '-B', 'luci.chromium.try', '-b', 'win', '-b', 'linux',
3225 '-p', 'key=val', '-p', 'json=[{"a":1}, null]',
3226 '-r', 'beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef']))
3227 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003228 'Scheduling jobs on:\n'
3229 ' chromium/try: linux\n'
3230 ' chromium/try: win',
Anthony Polito1a5fe232020-01-24 23:17:52 +00003231 git_cl.sys.stdout.getvalue())
3232
3233 expected_request = {
3234 "requests": [{
3235 "scheduleBuild": {
3236 "requestId": "uuid4",
3237 "builder": {
3238 "project": "chromium",
3239 "builder": "linux",
3240 "bucket": "try",
3241 },
3242 "gerritChanges": [{
3243 "project": "depot_tools",
3244 "host": "chromium-review.googlesource.com",
3245 "patchset": 7,
3246 "change": 123456,
3247 }],
3248 "properties": {
3249 "category": "git_cl_try",
3250 "json": [{"a": 1}, None],
3251 "key": "val",
3252 },
3253 "tags": [
3254 {"value": "linux", "key": "builder"},
3255 {"value": "git_cl_try", "key": "user_agent"},
3256 ],
3257 "gitilesCommit": {
3258 "host": "chromium-review.googlesource.com",
3259 "project": "depot_tools",
3260 "id": "beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef",
3261 }
3262 },
3263 },
3264 {
3265 "scheduleBuild": {
3266 "requestId": "uuid4",
3267 "builder": {
3268 "project": "chromium",
3269 "builder": "win",
3270 "bucket": "try",
3271 },
3272 "gerritChanges": [{
3273 "project": "depot_tools",
3274 "host": "chromium-review.googlesource.com",
3275 "patchset": 7,
3276 "change": 123456,
3277 }],
3278 "properties": {
3279 "category": "git_cl_try",
3280 "json": [{"a": 1}, None],
3281 "key": "val",
3282 },
3283 "tags": [
3284 {"value": "win", "key": "builder"},
3285 {"value": "git_cl_try", "key": "user_agent"},
3286 ],
3287 "gitilesCommit": {
3288 "host": "chromium-review.googlesource.com",
3289 "project": "depot_tools",
3290 "id": "beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef",
3291 }
3292 },
3293 }],
3294 }
3295 mockCallBuildbucket.assert_called_with(
3296 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3297
Edward Lemur45768512020-03-02 19:03:14 +00003298 @mock.patch('sys.stderr', StringIO())
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003299 def testScheduleOnBuildbucket_WrongBucket(self):
Edward Lemur45768512020-03-02 19:03:14 +00003300 with self.assertRaises(SystemExit):
3301 git_cl.main([
3302 'try', '-B', 'not-a-bucket', '-b', 'win',
3303 '-p', 'key=val', '-p', 'json=[{"a":1}, null]'])
Edward Lemur4c707a22019-09-24 21:13:43 +00003304 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003305 'Invalid bucket: not-a-bucket.',
3306 sys.stderr.getvalue())
Edward Lemur4c707a22019-09-24 21:13:43 +00003307
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003308 @mock.patch('git_cl._call_buildbucket')
3309 @mock.patch('git_cl.fetch_try_jobs')
3310 def testScheduleOnBuildbucketRetryFailed(
3311 self, mockFetchTryJobs, mockCallBuildbucket):
3312
3313 git_cl.fetch_try_jobs.side_effect = lambda *_, **kw: {
3314 7: [],
3315 6: [{
3316 'id': 112112,
3317 'builder': {
3318 'project': 'chromium',
3319 'bucket': 'try',
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003320 'builder': 'linux',},
3321 'createTime': '2019-10-09T08:00:01.854286Z',
3322 'tags': [],
3323 'status': 'FAILURE',}],}[kw['patchset']]
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003324 mockCallBuildbucket.return_value = {}
3325
3326 self.assertEqual(0, git_cl.main(['try', '--retry-failed']))
3327 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003328 'Scheduling jobs on:\n'
3329 ' chromium/try: linux',
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003330 git_cl.sys.stdout.getvalue())
3331
3332 expected_request = {
3333 "requests": [{
3334 "scheduleBuild": {
3335 "requestId": "uuid4",
3336 "builder": {
3337 "project": "chromium",
3338 "bucket": "try",
3339 "builder": "linux",
3340 },
3341 "gerritChanges": [{
3342 "project": "depot_tools",
3343 "host": "chromium-review.googlesource.com",
3344 "patchset": 7,
3345 "change": 123456,
3346 }],
3347 "properties": {
3348 "category": "git_cl_try",
3349 },
3350 "tags": [
3351 {"value": "linux", "key": "builder"},
3352 {"value": "git_cl_try", "key": "user_agent"},
3353 {"value": "1", "key": "retry_failed"},
3354 ],
3355 },
3356 }],
3357 }
3358 mockCallBuildbucket.assert_called_with(
3359 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3360
Edward Lemur4c707a22019-09-24 21:13:43 +00003361 def test_parse_bucket(self):
3362 test_cases = [
3363 {
3364 'bucket': 'chromium/try',
3365 'result': ('chromium', 'try'),
3366 },
3367 {
3368 'bucket': 'luci.chromium.try',
3369 'result': ('chromium', 'try'),
3370 'has_warning': True,
3371 },
3372 {
3373 'bucket': 'skia.primary',
3374 'result': ('skia', 'skia.primary'),
3375 'has_warning': True,
3376 },
3377 {
3378 'bucket': 'not-a-bucket',
3379 'result': (None, None),
3380 },
3381 ]
3382
3383 for test_case in test_cases:
3384 git_cl.sys.stdout.truncate(0)
3385 self.assertEqual(
3386 test_case['result'], git_cl._parse_bucket(test_case['bucket']))
3387 if test_case.get('has_warning'):
Edward Lemur6215c792019-10-03 21:59:05 +00003388 expected_warning = 'WARNING Please use %s/%s to specify the bucket' % (
3389 test_case['result'])
3390 self.assertIn(expected_warning, git_cl.sys.stdout.getvalue())
Edward Lemur4c707a22019-09-24 21:13:43 +00003391
3392
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003393class CMDUploadTestCase(CMDTestCaseBase):
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003394 def setUp(self):
3395 super(CMDUploadTestCase, self).setUp()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003396 mock.patch('git_cl.fetch_try_jobs').start()
3397 mock.patch('git_cl._trigger_try_jobs', return_value={}).start()
3398 mock.patch('git_cl.Changelist.CMDUpload', return_value=0).start()
Anthony Polito46689b02019-11-15 20:56:41 +00003399 mock.patch('git_cl.Settings.GetIsGerrit', return_value=True).start()
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003400 self.addCleanup(mock.patch.stopall)
3401
Edward Lesmes7677e5c2020-02-19 20:39:03 +00003402 def testWarmUpChangeDetailCache(self):
3403 self.assertEqual(0, git_cl.main(['upload']))
3404 gerrit_util.GetChangeDetail.assert_called_once_with(
3405 'chromium-review.googlesource.com', 'depot_tools~123456',
3406 frozenset([
3407 'LABELS', 'CURRENT_REVISION', 'DETAILED_ACCOUNTS',
3408 'CURRENT_COMMIT']))
3409
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003410 def testUploadRetryFailed(self):
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003411 # This test mocks out the actual upload part, and just asserts that after
3412 # upload, if --retry-failed is added, then the tool will fetch try jobs
3413 # from the previous patchset and trigger the right builders on the latest
3414 # patchset.
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003415 git_cl.fetch_try_jobs.side_effect = [
3416 # Latest patchset: No builds.
3417 [],
3418 # Patchset before latest: Some builds.
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003419 [{
3420 'id': str(100 + idx),
3421 'builder': {
3422 'project': 'chromium',
3423 'bucket': 'try',
3424 'builder': 'bot_' + status.lower(),
3425 },
3426 'createTime': '2019-10-09T08:00:0%d.854286Z' % (idx % 10),
3427 'tags': [],
3428 'status': status,
3429 } for idx, status in enumerate(self._STATUSES)],
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +00003430 ]
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003431
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003432 self.assertEqual(0, git_cl.main(['upload', '--retry-failed']))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003433 self.assertEqual([
Edward Lemur5b929a42019-10-21 17:57:39 +00003434 mock.call(mock.ANY, 'cr-buildbucket.appspot.com', patchset=7),
3435 mock.call(mock.ANY, 'cr-buildbucket.appspot.com', patchset=6),
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003436 ], git_cl.fetch_try_jobs.mock_calls)
Edward Lemur45768512020-03-02 19:03:14 +00003437 expected_buckets = [
3438 ('chromium', 'try', 'bot_failure'),
3439 ('chromium', 'try', 'bot_infra_failure'),
3440 ]
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003441 git_cl._trigger_try_jobs.assert_called_once_with(
Edward Lemur5b929a42019-10-21 17:57:39 +00003442 mock.ANY, expected_buckets, mock.ANY, 8)
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003443
Brian Sheedy59b06a82019-10-14 17:03:29 +00003444
Edward Lemurda4b6c62020-02-13 00:28:40 +00003445class CMDFormatTestCase(unittest.TestCase):
Brian Sheedy59b06a82019-10-14 17:03:29 +00003446
3447 def setUp(self):
3448 super(CMDFormatTestCase, self).setUp()
Jamie Madill5e96ad12020-01-13 16:08:35 +00003449 mock.patch('git_cl.RunCommand').start()
3450 mock.patch('clang_format.FindClangFormatToolInChromiumTree').start()
3451 mock.patch('clang_format.FindClangFormatScriptInChromiumTree').start()
3452 mock.patch('git_cl.settings').start()
Brian Sheedy59b06a82019-10-14 17:03:29 +00003453 self._top_dir = tempfile.mkdtemp()
Jamie Madill5e96ad12020-01-13 16:08:35 +00003454 self.addCleanup(mock.patch.stopall)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003455
3456 def tearDown(self):
3457 shutil.rmtree(self._top_dir)
3458 super(CMDFormatTestCase, self).tearDown()
3459
Jamie Madill5e96ad12020-01-13 16:08:35 +00003460 def _make_temp_file(self, fname, contents):
3461 with open(os.path.join(self._top_dir, fname), 'w') as tf:
3462 tf.write('\n'.join(contents))
3463
Brian Sheedy59b06a82019-10-14 17:03:29 +00003464 def _make_yapfignore(self, contents):
Jamie Madill5e96ad12020-01-13 16:08:35 +00003465 self._make_temp_file('.yapfignore', contents)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003466
Brian Sheedyb4307d52019-12-02 19:18:17 +00003467 def _check_yapf_filtering(self, files, expected):
3468 self.assertEqual(expected, git_cl._FilterYapfIgnoredFiles(
3469 files, git_cl._GetYapfIgnorePatterns(self._top_dir)))
Brian Sheedy59b06a82019-10-14 17:03:29 +00003470
Edward Lemur1a83da12020-03-04 21:18:36 +00003471 def _run_command_mock(self, return_value):
3472 def f(*args, **kwargs):
3473 if 'stdin' in kwargs:
3474 self.assertIsInstance(kwargs['stdin'], bytes)
3475 return return_value
3476 return f
3477
Jamie Madill5e96ad12020-01-13 16:08:35 +00003478 def testClangFormatDiffFull(self):
3479 self._make_temp_file('test.cc', ['// test'])
3480 git_cl.settings.GetFormatFullByDefault.return_value = False
3481 diff_file = [os.path.join(self._top_dir, 'test.cc')]
3482 mock_opts = mock.Mock(full=True, dry_run=True, diff=False)
3483
3484 # Diff
Edward Lemur1a83da12020-03-04 21:18:36 +00003485 git_cl.RunCommand.side_effect = self._run_command_mock(' // test')
Jamie Madill5e96ad12020-01-13 16:08:35 +00003486 return_value = git_cl._RunClangFormatDiff(mock_opts, diff_file,
3487 self._top_dir, 'HEAD')
3488 self.assertEqual(2, return_value)
3489
3490 # No diff
Edward Lemur1a83da12020-03-04 21:18:36 +00003491 git_cl.RunCommand.side_effect = self._run_command_mock('// test')
Jamie Madill5e96ad12020-01-13 16:08:35 +00003492 return_value = git_cl._RunClangFormatDiff(mock_opts, diff_file,
3493 self._top_dir, 'HEAD')
3494 self.assertEqual(0, return_value)
3495
3496 def testClangFormatDiff(self):
3497 git_cl.settings.GetFormatFullByDefault.return_value = False
3498 mock_opts = mock.Mock(full=False, dry_run=True, diff=False)
3499
3500 # Diff
Edward Lemur1a83da12020-03-04 21:18:36 +00003501 git_cl.RunCommand.side_effect = self._run_command_mock('error')
3502 return_value = git_cl._RunClangFormatDiff(
3503 mock_opts, ['.'], self._top_dir, 'HEAD')
Jamie Madill5e96ad12020-01-13 16:08:35 +00003504 self.assertEqual(2, return_value)
3505
3506 # No diff
Edward Lemur1a83da12020-03-04 21:18:36 +00003507 git_cl.RunCommand.side_effect = self._run_command_mock('')
Jamie Madill5e96ad12020-01-13 16:08:35 +00003508 return_value = git_cl._RunClangFormatDiff(mock_opts, ['.'], self._top_dir,
3509 'HEAD')
3510 self.assertEqual(0, return_value)
3511
Brian Sheedyb4307d52019-12-02 19:18:17 +00003512 def testYapfignoreExplicit(self):
3513 self._make_yapfignore(['foo/bar.py', 'foo/bar/baz.py'])
3514 files = [
3515 'bar.py',
3516 'foo/bar.py',
3517 'foo/baz.py',
3518 'foo/bar/baz.py',
3519 'foo/bar/foobar.py',
3520 ]
3521 expected = [
3522 'bar.py',
3523 'foo/baz.py',
3524 'foo/bar/foobar.py',
3525 ]
3526 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003527
Brian Sheedyb4307d52019-12-02 19:18:17 +00003528 def testYapfignoreSingleWildcards(self):
3529 self._make_yapfignore(['*bar.py', 'foo*', 'baz*.py'])
3530 files = [
3531 'bar.py', # Matched by *bar.py.
3532 'bar.txt',
3533 'foobar.py', # Matched by *bar.py, foo*.
3534 'foobar.txt', # Matched by foo*.
3535 'bazbar.py', # Matched by *bar.py, baz*.py.
3536 'bazbar.txt',
3537 'foo/baz.txt', # Matched by foo*.
3538 'bar/bar.py', # Matched by *bar.py.
3539 'baz/foo.py', # Matched by baz*.py, foo*.
3540 'baz/foo.txt',
3541 ]
3542 expected = [
3543 'bar.txt',
3544 'bazbar.txt',
3545 'baz/foo.txt',
3546 ]
3547 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003548
Brian Sheedyb4307d52019-12-02 19:18:17 +00003549 def testYapfignoreMultiplewildcards(self):
3550 self._make_yapfignore(['*bar*', '*foo*baz.txt'])
3551 files = [
3552 'bar.py', # Matched by *bar*.
3553 'bar.txt', # Matched by *bar*.
3554 'abar.py', # Matched by *bar*.
3555 'foobaz.txt', # Matched by *foo*baz.txt.
3556 'foobaz.py',
3557 'afoobaz.txt', # Matched by *foo*baz.txt.
3558 ]
3559 expected = [
3560 'foobaz.py',
3561 ]
3562 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003563
3564 def testYapfignoreComments(self):
3565 self._make_yapfignore(['test.py', '#test2.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003566 files = [
3567 'test.py',
3568 'test2.py',
3569 ]
3570 expected = [
3571 'test2.py',
3572 ]
3573 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003574
3575 def testYapfignoreBlankLines(self):
3576 self._make_yapfignore(['test.py', '', '', 'test2.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003577 files = [
3578 'test.py',
3579 'test2.py',
3580 'test3.py',
3581 ]
3582 expected = [
3583 'test3.py',
3584 ]
3585 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003586
3587 def testYapfignoreWhitespace(self):
3588 self._make_yapfignore([' test.py '])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003589 files = [
3590 'test.py',
3591 'test2.py',
3592 ]
3593 expected = [
3594 'test2.py',
3595 ]
3596 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003597
Brian Sheedyb4307d52019-12-02 19:18:17 +00003598 def testYapfignoreNoFiles(self):
Brian Sheedy59b06a82019-10-14 17:03:29 +00003599 self._make_yapfignore(['test.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003600 self._check_yapf_filtering([], [])
3601
3602 def testYapfignoreMissingYapfignore(self):
3603 files = [
3604 'test.py',
3605 ]
3606 expected = [
3607 'test.py',
3608 ]
3609 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003610
3611
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003612if __name__ == '__main__':
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +01003613 logging.basicConfig(
3614 level=logging.DEBUG if '-v' in sys.argv else logging.ERROR)
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003615 unittest.main()