blob: e3f6f57dad37880fd115e15fa74df68f368ddf00 [file] [log] [blame]
Edward Lemur0db01f02019-11-12 22:01:51 +00001#!/usr/bin/env vpython3
2# coding=utf-8
maruel@chromium.orgeb5edbc2012-01-16 17:03:28 +00003# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@chromium.orgddd59412011-11-30 14:20:38 +00004# Use of this source code is governed by a BSD-style license that can be
5# found in the LICENSE file.
6
7"""Unit tests for git_cl.py."""
8
Edward Lemur0db01f02019-11-12 22:01:51 +00009from __future__ import unicode_literals
10
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +010011import datetime
tandriide281ae2016-10-12 06:02:30 -070012import json
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +010013import logging
maruel@chromium.orgddd59412011-11-30 14:20:38 +000014import os
Brian Sheedy59b06a82019-10-14 17:03:29 +000015import shutil
maruel@chromium.orgddd59412011-11-30 14:20:38 +000016import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070017import tempfile
maruel@chromium.orgddd59412011-11-30 14:20:38 +000018import unittest
19
Edward Lemura8145022020-01-06 18:47:54 +000020if sys.version_info.major == 2:
21 from StringIO import StringIO
22 import mock
23else:
24 from io import StringIO
25 from unittest import mock
26
maruel@chromium.orgddd59412011-11-30 14:20:38 +000027sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
28
29from testing_support.auto_stub import TestCase
30
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000031import metrics
32# We have to disable monitoring before importing git_cl.
33metrics.DISABLE_METRICS_COLLECTION = True
34
Eric Boren2fb63102018-10-05 13:05:03 +000035import gerrit_util
maruel@chromium.orgddd59412011-11-30 14:20:38 +000036import git_cl
iannucci@chromium.org9e849272014-04-04 00:31:55 +000037import git_common
tandrii@chromium.org57d86542016-03-04 16:11:32 +000038import git_footers
maruel@chromium.orgddd59412011-11-30 14:20:38 +000039import subprocess2
maruel@chromium.orgddd59412011-11-30 14:20:38 +000040
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000041
Edward Lemur0db01f02019-11-12 22:01:51 +000042def callError(code=1, cmd='', cwd='', stdout=b'', stderr=b''):
tandrii5d48c322016-08-18 16:19:37 -070043 return subprocess2.CalledProcessError(code, cmd, cwd, stdout, stderr)
44
45
Edward Lemur4c707a22019-09-24 21:13:43 +000046def _constantFn(return_value):
47 def f(*args, **kwargs):
48 return return_value
49 return f
50
51
tandrii5d48c322016-08-18 16:19:37 -070052CERR1 = callError(1)
53
54
Edward Lemur0db01f02019-11-12 22:01:51 +000055def MakeNamedTemporaryFileMock(test, expected_content):
Aaron Gable9a03ae02017-11-03 11:31:07 -070056 class NamedTemporaryFileMock(object):
57 def __init__(self, *args, **kwargs):
58 self.name = '/tmp/named'
Edward Lemur0db01f02019-11-12 22:01:51 +000059 self.expected_content = expected_content.encode('utf-8', 'replace')
Aaron Gable9a03ae02017-11-03 11:31:07 -070060
61 def __enter__(self):
62 return self
63
64 def __exit__(self, _type, _value, _tb):
65 pass
66
67 def write(self, content):
68 if self.expected_content:
Edward Lemur0db01f02019-11-12 22:01:51 +000069 test.assertEqual(self.expected_content, content)
Aaron Gable9a03ae02017-11-03 11:31:07 -070070
71 def close(self):
72 pass
73
74 return NamedTemporaryFileMock
75
76
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000077class ChangelistMock(object):
78 # A class variable so we can access it when we don't have access to the
79 # instance that's being set.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000080 desc = ''
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000081 def __init__(self, **kwargs):
82 pass
83 def GetIssue(self):
84 return 1
Kenneth Russell61e2ed42017-02-15 11:47:13 -080085 def GetDescription(self, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000086 return ChangelistMock.desc
dsansomee2d6fd92016-09-08 00:10:47 -070087 def UpdateDescription(self, desc, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000088 ChangelistMock.desc = desc
89
tandrii5d48c322016-08-18 16:19:37 -070090
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000091class PresubmitMock(object):
92 def __init__(self, *args, **kwargs):
93 self.reviewers = []
Daniel Cheng7227d212017-11-17 08:12:37 -080094 self.more_cc = ['chromium-reviews+test-more-cc@chromium.org']
95
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000096 @staticmethod
97 def should_continue():
98 return True
99
100
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000101class WatchlistsMock(object):
102 def __init__(self, _):
103 pass
104 @staticmethod
105 def GetWatchersForPaths(_):
106 return ['joe@example.com']
107
108
Edward Lemur4c707a22019-09-24 21:13:43 +0000109class CodereviewSettingsFileMock(object):
110 def __init__(self):
111 pass
112 # pylint: disable=no-self-use
113 def read(self):
114 return ('CODE_REVIEW_SERVER: gerrit.chromium.org\n' +
115 'GERRIT_HOST: True\n')
116
117
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000118class AuthenticatorMock(object):
119 def __init__(self, *_args):
120 pass
121 def has_cached_credentials(self):
122 return True
tandrii221ab252016-10-06 08:12:04 -0700123 def authorize(self, http):
124 return http
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000125
126
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100127def CookiesAuthenticatorMockFactory(hosts_with_creds=None, same_auth=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000128 """Use to mock Gerrit/Git credentials from ~/.netrc or ~/.gitcookies.
129
130 Usage:
131 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100132 CookiesAuthenticatorMockFactory({'host': ('user', _, 'pass')})
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000133
134 OR
135 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100136 CookiesAuthenticatorMockFactory(
137 same_auth=('user', '', 'pass'))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000138 """
139 class CookiesAuthenticatorMock(git_cl.gerrit_util.CookiesAuthenticator):
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800140 def __init__(self): # pylint: disable=super-init-not-called
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000141 # Intentionally not calling super() because it reads actual cookie files.
142 pass
143 @classmethod
144 def get_gitcookies_path(cls):
145 return '~/.gitcookies'
146 @classmethod
147 def get_netrc_path(cls):
148 return '~/.netrc'
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100149 def _get_auth_for_host(self, host):
150 if same_auth:
151 return same_auth
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000152 return (hosts_with_creds or {}).get(host)
153 return CookiesAuthenticatorMock
154
Aaron Gable9a03ae02017-11-03 11:31:07 -0700155
kmarshall9249e012016-08-23 12:02:16 -0700156class MockChangelistWithBranchAndIssue():
157 def __init__(self, branch, issue):
158 self.branch = branch
159 self.issue = issue
160 def GetBranch(self):
161 return self.branch
162 def GetIssue(self):
163 return self.issue
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000164
tandriic2405f52016-10-10 08:13:15 -0700165
166class SystemExitMock(Exception):
167 pass
168
169
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000170class TestGitClBasic(unittest.TestCase):
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100171 def test_get_description(self):
Edward Lemurf38bc172019-09-03 21:02:13 +0000172 cl = git_cl.Changelist(issue=1, codereview_host='host')
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100173 cl.description = 'x'
174 cl.has_description = True
Edward Lemur125d60a2019-09-13 18:25:41 +0000175 cl.FetchDescription = lambda *a, **kw: 'y'
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +0000176 self.assertEqual(cl.GetDescription(), 'x')
177 self.assertEqual(cl.GetDescription(force=True), 'y')
178 self.assertEqual(cl.GetDescription(), 'y')
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100179
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700180 def test_description_footers(self):
Edward Lemurf38bc172019-09-03 21:02:13 +0000181 cl = git_cl.Changelist(issue=1, codereview_host='host')
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700182 cl.description = '\n'.join([
183 'This is some message',
184 '',
185 'It has some lines',
186 'and, also',
187 '',
188 'Some: Really',
189 'Awesome: Footers',
190 ])
191 cl.has_description = True
Edward Lemur125d60a2019-09-13 18:25:41 +0000192 cl.UpdateDescriptionRemote = lambda *a, **kw: 'y'
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700193 msg, footers = cl.GetDescriptionFooters()
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +0000194 self.assertEqual(
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700195 msg, ['This is some message', '', 'It has some lines', 'and, also'])
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +0000196 self.assertEqual(footers, [('Some', 'Really'), ('Awesome', 'Footers')])
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700197
198 msg.append('wut')
199 footers.append(('gnarly-dude', 'beans'))
200 cl.UpdateDescriptionFooters(msg, footers)
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +0000201 self.assertEqual(cl.GetDescription().splitlines(), [
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700202 'This is some message',
203 '',
204 'It has some lines',
205 'and, also',
206 'wut'
207 '',
208 'Some: Really',
209 'Awesome: Footers',
210 'Gnarly-Dude: beans',
211 ])
212
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +0000213 def test_set_preserve_tryjobs(self):
214 d = git_cl.ChangeDescription('Simple.')
215 d.set_preserve_tryjobs()
216 self.assertEqual(d.description.splitlines(), [
217 'Simple.',
218 '',
219 'Cq-Do-Not-Cancel-Tryjobs: true',
220 ])
221 before = d.description
222 d.set_preserve_tryjobs()
223 self.assertEqual(before, d.description)
224
225 d = git_cl.ChangeDescription('\n'.join([
226 'One is enough',
227 '',
228 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
229 'Change-Id: Ideadbeef',
230 ]))
231 d.set_preserve_tryjobs()
232 self.assertEqual(d.description.splitlines(), [
233 'One is enough',
234 '',
235 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
236 'Change-Id: Ideadbeef',
237 'Cq-Do-Not-Cancel-Tryjobs: true',
238 ])
239
tandriif9aefb72016-07-01 09:06:51 -0700240 def test_get_bug_line_values(self):
241 f = lambda p, bugs: list(git_cl._get_bug_line_values(p, bugs))
242 self.assertEqual(f('', ''), [])
243 self.assertEqual(f('', '123,v8:456'), ['123', 'v8:456'])
244 self.assertEqual(f('v8', '456'), ['v8:456'])
245 self.assertEqual(f('v8', 'chromium:123,456'), ['v8:456', 'chromium:123'])
246 # Not nice, but not worth carying.
247 self.assertEqual(f('v8', 'chromium:123,456,v8:123'),
248 ['v8:456', 'chromium:123', 'v8:123'])
249
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100250 def _test_git_number(self, parent_msg, dest_ref, child_msg,
251 parent_hash='parenthash'):
252 desc = git_cl.ChangeDescription(child_msg)
253 desc.update_with_git_number_footers(parent_hash, parent_msg, dest_ref)
254 return desc.description
255
256 def assertEqualByLine(self, actual, expected):
257 self.assertEqual(actual.splitlines(), expected.splitlines())
258
259 def test_git_number_bad_parent(self):
260 with self.assertRaises(ValueError):
261 self._test_git_number('Parent', 'refs/heads/master', 'Child')
262
263 def test_git_number_bad_parent_footer(self):
264 with self.assertRaises(AssertionError):
265 self._test_git_number(
266 'Parent\n'
267 '\n'
268 'Cr-Commit-Position: wrong',
269 'refs/heads/master', 'Child')
270
271 def test_git_number_bad_lineage_ignored(self):
272 actual = self._test_git_number(
273 'Parent\n'
274 '\n'
275 'Cr-Commit-Position: refs/heads/master@{#1}\n'
276 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}',
277 'refs/heads/master', 'Child')
278 self.assertEqualByLine(
279 actual,
280 'Child\n'
281 '\n'
282 'Cr-Commit-Position: refs/heads/master@{#2}\n'
283 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}')
284
285 def test_git_number_same_branch(self):
286 actual = self._test_git_number(
287 'Parent\n'
288 '\n'
289 'Cr-Commit-Position: refs/heads/master@{#12}',
290 dest_ref='refs/heads/master',
291 child_msg='Child')
292 self.assertEqualByLine(
293 actual,
294 'Child\n'
295 '\n'
296 'Cr-Commit-Position: refs/heads/master@{#13}')
297
Andrii Shyshkalovde37c012017-07-06 21:06:50 +0200298 def test_git_number_same_branch_mixed_footers(self):
299 actual = self._test_git_number(
300 'Parent\n'
301 '\n'
302 'Cr-Commit-Position: refs/heads/master@{#12}',
303 dest_ref='refs/heads/master',
304 child_msg='Child\n'
305 '\n'
306 'Broken-by: design\n'
307 'BUG=123')
308 self.assertEqualByLine(
309 actual,
310 'Child\n'
311 '\n'
312 'Broken-by: design\n'
313 'BUG=123\n'
314 'Cr-Commit-Position: refs/heads/master@{#13}')
315
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100316 def test_git_number_same_branch_with_originals(self):
317 actual = self._test_git_number(
318 'Parent\n'
319 '\n'
320 'Cr-Commit-Position: refs/heads/master@{#12}',
321 dest_ref='refs/heads/master',
322 child_msg='Child\n'
323 '\n'
324 'Some users are smart and insert their own footers\n'
325 '\n'
326 'Cr-Whatever: value\n'
327 'Cr-Commit-Position: refs/copy/paste@{#22}')
328 self.assertEqualByLine(
329 actual,
330 'Child\n'
331 '\n'
332 'Some users are smart and insert their own footers\n'
333 '\n'
334 'Cr-Original-Whatever: value\n'
335 'Cr-Original-Commit-Position: refs/copy/paste@{#22}\n'
336 'Cr-Commit-Position: refs/heads/master@{#13}')
337
338 def test_git_number_new_branch(self):
339 actual = self._test_git_number(
340 'Parent\n'
341 '\n'
342 'Cr-Commit-Position: refs/heads/master@{#12}',
343 dest_ref='refs/heads/branch',
344 child_msg='Child')
345 self.assertEqualByLine(
346 actual,
347 'Child\n'
348 '\n'
349 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
350 'Cr-Branched-From: parenthash-refs/heads/master@{#12}')
351
352 def test_git_number_lineage(self):
353 actual = self._test_git_number(
354 'Parent\n'
355 '\n'
356 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
357 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
358 dest_ref='refs/heads/branch',
359 child_msg='Child')
360 self.assertEqualByLine(
361 actual,
362 'Child\n'
363 '\n'
364 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
365 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
366
367 def test_git_number_moooooooore_lineage(self):
368 actual = self._test_git_number(
369 'Parent\n'
370 '\n'
371 'Cr-Commit-Position: refs/heads/branch@{#5}\n'
372 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
373 dest_ref='refs/heads/mooore',
374 child_msg='Child')
375 self.assertEqualByLine(
376 actual,
377 'Child\n'
378 '\n'
379 'Cr-Commit-Position: refs/heads/mooore@{#1}\n'
380 'Cr-Branched-From: parenthash-refs/heads/branch@{#5}\n'
381 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
382
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100383 def test_git_number_ever_moooooooore_lineage(self):
Robert Iannucci456b0d62018-03-13 19:15:50 -0700384 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100385 actual = self._test_git_number(
386 'CQ commit on fresh new branch + numbering.\n'
387 '\n'
388 'NOTRY=True\n'
389 'NOPRESUBMIT=True\n'
390 'BUG=\n'
391 '\n'
392 'Review-Url: https://codereview.chromium.org/2577703003\n'
393 'Cr-Commit-Position: refs/heads/gnumb-test/br@{#1}\n'
394 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
395 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}',
396 dest_ref='refs/heads/gnumb-test/cl',
397 child_msg='git cl on fresh new branch + numbering.\n'
398 '\n'
399 'Review-Url: https://codereview.chromium.org/2575043003 .\n')
400 self.assertEqualByLine(
401 actual,
402 'git cl on fresh new branch + numbering.\n'
403 '\n'
404 'Review-Url: https://codereview.chromium.org/2575043003 .\n'
405 'Cr-Commit-Position: refs/heads/gnumb-test/cl@{#1}\n'
406 'Cr-Branched-From: parenthash-refs/heads/gnumb-test/br@{#1}\n'
407 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
408 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}')
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100409
410 def test_git_number_cherry_pick(self):
411 actual = self._test_git_number(
412 'Parent\n'
413 '\n'
414 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
415 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
416 dest_ref='refs/heads/branch',
417 child_msg='Child, which is cherry-pick from master\n'
418 '\n'
419 'Cr-Commit-Position: refs/heads/master@{#100}\n'
420 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)')
421 self.assertEqualByLine(
422 actual,
423 'Child, which is cherry-pick from master\n'
424 '\n'
425 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)\n'
426 '\n'
427 'Cr-Original-Commit-Position: refs/heads/master@{#100}\n'
428 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
429 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
430
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000431 def test_valid_accounts(self):
432 mock_per_account = {
433 'u1': None, # 404, doesn't exist.
434 'u2': {
435 '_account_id': 123124,
436 'avatars': [],
437 'email': 'u2@example.com',
438 'name': 'User Number 2',
439 'status': 'OOO',
440 },
441 'u3': git_cl.gerrit_util.GerritError(500, 'retries didn\'t help :('),
442 }
443 def GetAccountDetailsMock(_, account):
444 # Poor-man's mock library's side_effect.
445 v = mock_per_account.pop(account)
446 if isinstance(v, Exception):
447 raise v
448 return v
449
450 original = git_cl.gerrit_util.GetAccountDetails
451 try:
452 git_cl.gerrit_util.GetAccountDetails = GetAccountDetailsMock
453 actual = git_cl.gerrit_util.ValidAccounts(
454 'host', ['u1', 'u2', 'u3'], max_threads=1)
455 finally:
456 git_cl.gerrit_util.GetAccountDetails = original
457 self.assertEqual(actual, {
458 'u2': {
459 '_account_id': 123124,
460 'avatars': [],
461 'email': 'u2@example.com',
462 'name': 'User Number 2',
463 'status': 'OOO',
464 },
465 })
466
467
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200468class TestParseIssueURL(unittest.TestCase):
469 def _validate(self, parsed, issue=None, patchset=None, hostname=None,
Edward Lemurf38bc172019-09-03 21:02:13 +0000470 fail=False):
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200471 self.assertIsNotNone(parsed)
472 if fail:
473 self.assertFalse(parsed.valid)
474 return
475 self.assertTrue(parsed.valid)
476 self.assertEqual(parsed.issue, issue)
477 self.assertEqual(parsed.patchset, patchset)
478 self.assertEqual(parsed.hostname, hostname)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200479
Edward Lemur678a6842019-10-03 22:25:05 +0000480 def test_ParseIssueNumberArgument(self):
481 def test(arg, *args, **kwargs):
482 self._validate(git_cl.ParseIssueNumberArgument(arg), *args, **kwargs)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200483
Edward Lemur678a6842019-10-03 22:25:05 +0000484 test('123', 123)
485 test('', fail=True)
486 test('abc', fail=True)
487 test('123/1', fail=True)
488 test('123a', fail=True)
489 test('ssh://chrome-review.source.com/#/c/123/4/', fail=True)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200490
Edward Lemur678a6842019-10-03 22:25:05 +0000491 test('https://codereview.source.com/123',
492 123, None, 'codereview.source.com')
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200493 test('http://chrome-review.source.com/c/123',
494 123, None, 'chrome-review.source.com')
495 test('https://chrome-review.source.com/c/123/',
496 123, None, 'chrome-review.source.com')
497 test('https://chrome-review.source.com/c/123/4',
498 123, 4, 'chrome-review.source.com')
499 test('https://chrome-review.source.com/#/c/123/4',
500 123, 4, 'chrome-review.source.com')
501 test('https://chrome-review.source.com/c/123/4',
502 123, 4, 'chrome-review.source.com')
503 test('https://chrome-review.source.com/123',
504 123, None, 'chrome-review.source.com')
505 test('https://chrome-review.source.com/123/4',
506 123, 4, 'chrome-review.source.com')
507
Edward Lemur678a6842019-10-03 22:25:05 +0000508 test('https://chrome-review.source.com/bad/123/4', fail=True)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200509 test('https://chrome-review.source.com/c/123/1/whatisthis', fail=True)
510 test('https://chrome-review.source.com/c/abc/', fail=True)
511 test('ssh://chrome-review.source.com/c/123/1/', fail=True)
512
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200513
514
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100515class GitCookiesCheckerTest(TestCase):
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100516 def setUp(self):
517 super(GitCookiesCheckerTest, self).setUp()
518 self.c = git_cl._GitCookiesChecker()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100519 self.c._all_hosts = []
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100520
521 def mock_hosts_creds(self, subhost_identity_pairs):
522 def ensure_googlesource(h):
523 if not h.endswith(self.c._GOOGLESOURCE):
524 assert not h.endswith('.')
525 return h + '.' + self.c._GOOGLESOURCE
526 return h
527 self.c._all_hosts = [(ensure_googlesource(h), i, '.gitcookies')
528 for h, i in subhost_identity_pairs]
529
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200530 def test_identity_parsing(self):
531 self.assertEqual(self.c._parse_identity('ldap.google.com'),
532 ('ldap', 'google.com'))
533 self.assertEqual(self.c._parse_identity('git-ldap.example.com'),
534 ('ldap', 'example.com'))
535 # Specical case because we know there are no subdomains in chromium.org.
536 self.assertEqual(self.c._parse_identity('git-note.period.chromium.org'),
537 ('note.period', 'chromium.org'))
Lei Zhangd3f769a2017-12-15 15:16:14 -0800538 # Pathological: ".period." can be either username OR domain, more likely
539 # domain.
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200540 self.assertEqual(self.c._parse_identity('git-note.period.example.com'),
541 ('note', 'period.example.com'))
542
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100543 def test_analysis_nothing(self):
544 self.c._all_hosts = []
545 self.assertFalse(self.c.has_generic_host())
546 self.assertEqual(set(), self.c.get_conflicting_hosts())
547 self.assertEqual(set(), self.c.get_duplicated_hosts())
548 self.assertEqual(set(), self.c.get_partially_configured_hosts())
549 self.assertEqual(set(), self.c.get_hosts_with_wrong_identities())
550
551 def test_analysis(self):
552 self.mock_hosts_creds([
553 ('.googlesource.com', 'git-example.chromium.org'),
554
555 ('chromium', 'git-example.google.com'),
556 ('chromium-review', 'git-example.google.com'),
557 ('chrome-internal', 'git-example.chromium.org'),
558 ('chrome-internal-review', 'git-example.chromium.org'),
559 ('conflict', 'git-example.google.com'),
560 ('conflict-review', 'git-example.chromium.org'),
561 ('dup', 'git-example.google.com'),
562 ('dup', 'git-example.google.com'),
563 ('dup-review', 'git-example.google.com'),
564 ('partial', 'git-example.google.com'),
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200565 ('gpartial-review', 'git-example.google.com'),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100566 ])
567 self.assertTrue(self.c.has_generic_host())
568 self.assertEqual(set(['conflict.googlesource.com']),
569 self.c.get_conflicting_hosts())
570 self.assertEqual(set(['dup.googlesource.com']),
571 self.c.get_duplicated_hosts())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200572 self.assertEqual(set(['partial.googlesource.com',
573 'gpartial-review.googlesource.com']),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100574 self.c.get_partially_configured_hosts())
575 self.assertEqual(set(['chromium.googlesource.com',
576 'chrome-internal.googlesource.com']),
577 self.c.get_hosts_with_wrong_identities())
578
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100579 def test_report_no_problems(self):
580 self.test_analysis_nothing()
Edward Lemur79d4f992019-11-11 23:49:02 +0000581 self.mock(sys, 'stdout', StringIO())
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100582 self.assertFalse(self.c.find_and_report_problems())
583 self.assertEqual(sys.stdout.getvalue(), '')
584
585 def test_report(self):
586 self.test_analysis()
Edward Lemur79d4f992019-11-11 23:49:02 +0000587 self.mock(sys, 'stdout', StringIO())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200588 self.mock(git_cl.gerrit_util.CookiesAuthenticator, 'get_gitcookies_path',
589 classmethod(lambda _: '~/.gitcookies'))
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100590 self.assertTrue(self.c.find_and_report_problems())
591 with open(os.path.join(os.path.dirname(__file__),
592 'git_cl_creds_check_report.txt')) as f:
593 expected = f.read()
594 def by_line(text):
595 return [l.rstrip() for l in text.rstrip().splitlines()]
Robert Iannucci456b0d62018-03-13 19:15:50 -0700596 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalov4812e612017-03-27 17:22:57 +0200597 self.assertEqual(by_line(sys.stdout.getvalue().strip()), by_line(expected))
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100598
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -0800599
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000600class TestGitCl(TestCase):
601 def setUp(self):
602 super(TestGitCl, self).setUp()
603 self.calls = []
tandrii9d206752016-06-20 11:32:47 -0700604 self._calls_done = []
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000605 self.mock(git_cl, 'time_time',
606 lambda: self._mocked_call('time.time'))
607 self.mock(git_cl.metrics.collector, 'add_repeated',
608 lambda *a: self._mocked_call('add_repeated', *a))
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000609 self.mock(subprocess2, 'call', self._mocked_call)
610 self.mock(subprocess2, 'check_call', self._mocked_call)
611 self.mock(subprocess2, 'check_output', self._mocked_call)
tandrii5d48c322016-08-18 16:19:37 -0700612 self.mock(subprocess2, 'communicate',
613 lambda *a, **kw: ([self._mocked_call(*a, **kw), ''], 0))
tandrii@chromium.orga342c922016-03-16 07:08:25 +0000614 self.mock(git_cl.gclient_utils, 'CheckCallAndFilter', self._mocked_call)
sbc@chromium.org71437c02015-04-09 19:29:40 +0000615 self.mock(git_common, 'is_dirty_git_tree', lambda x: False)
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000616 self.mock(git_common, 'get_or_create_merge_base',
617 lambda *a: (
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000618 self._mocked_call(['get_or_create_merge_base'] + list(a))))
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +0000619 self.mock(git_cl, 'BranchExists', lambda _: True)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000620 self.mock(git_cl, 'FindCodereviewSettingsFile', lambda: '')
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000621 self.mock(git_cl, 'SaveDescriptionBackup', lambda _:
622 self._mocked_call('SaveDescriptionBackup'))
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100623 self.mock(git_cl, 'ask_for_data', lambda *a, **k: self._mocked_call(
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000624 *(['ask_for_data'] + list(a)), **k))
phajdan.jre328cf92016-08-22 04:12:17 -0700625 self.mock(git_cl, 'write_json', lambda path, contents:
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000626 self._mocked_call('write_json', path, contents))
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000627 self.mock(git_cl.presubmit_support, 'DoPresubmitChecks', PresubmitMock)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000628 self.mock(git_cl.watchlists, 'Watchlists', WatchlistsMock)
Edward Lemur5b929a42019-10-21 17:57:39 +0000629 self.mock(git_cl.auth, 'Authenticator', AuthenticatorMock)
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +0100630 self.mock(git_cl.gerrit_util, 'GetChangeDetail',
631 lambda *args, **kwargs: self._mocked_call(
632 'GetChangeDetail', *args, **kwargs))
Aaron Gable0ffdf2d2017-06-05 13:01:17 -0700633 self.mock(git_cl.gerrit_util, 'GetChangeComments',
634 lambda *args, **kwargs: self._mocked_call(
635 'GetChangeComments', *args, **kwargs))
Quinten Yearsley0e617c02019-02-20 00:37:03 +0000636 self.mock(git_cl.gerrit_util, 'GetChangeRobotComments',
637 lambda *args, **kwargs: self._mocked_call(
638 'GetChangeRobotComments', *args, **kwargs))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +0100639 self.mock(git_cl.gerrit_util, 'AddReviewers',
Aaron Gable6dadfbf2017-05-09 14:27:58 -0700640 lambda h, i, reviewers, ccs, notify: self._mocked_call(
641 'AddReviewers', h, i, reviewers, ccs, notify))
Aaron Gablefd238082017-06-07 13:42:34 -0700642 self.mock(git_cl.gerrit_util, 'SetReview',
Aaron Gablefc62f762017-07-17 11:12:07 -0700643 lambda h, i, msg=None, labels=None, notify=None:
644 self._mocked_call('SetReview', h, i, msg, labels, notify))
Andrii Shyshkalov733d4ec2018-04-19 11:48:58 -0700645 self.mock(git_cl.gerrit_util.LuciContextAuthenticator, 'is_luci',
646 staticmethod(lambda: False))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000647 self.mock(git_cl.gerrit_util.GceAuthenticator, 'is_gce',
648 classmethod(lambda _: False))
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000649 self.mock(git_cl.gerrit_util, 'ValidAccounts',
650 lambda host, accounts:
651 self._mocked_call('ValidAccounts', host, accounts))
tandriic2405f52016-10-10 08:13:15 -0700652 self.mock(git_cl, 'DieWithError',
Christopher Lamf732cd52017-01-24 12:40:11 +1100653 lambda msg, change=None: self._mocked_call(['DieWithError', msg]))
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000654 # It's important to reset settings to not have inter-tests interference.
655 git_cl.settings = None
656
657 def tearDown(self):
wychen@chromium.org445c8962015-04-28 23:30:05 +0000658 try:
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +0000659 self.assertEqual([], self.calls)
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100660 except AssertionError:
wychen@chromium.org445c8962015-04-28 23:30:05 +0000661 if not self.has_failed():
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100662 raise
663 # Sadly, has_failed() returns True if this OR any other tests before this
664 # one have failed.
Andrii Shyshkalove05d4882017-04-12 14:34:49 +0200665 git_cl.logging.error(
666 '!!!!!! IF YOU SEE THIS, READ BELOW, IT WILL SAVE YOUR TIME !!!!!\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100667 'There are un-consumed self.calls after this test has finished.\n'
668 'If you don\'t know which test this is, run:\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -0700669 ' tests/git_cl_tests.py -v\n'
Andrii Shyshkalove05d4882017-04-12 14:34:49 +0200670 'If you are already running only this test, then **first** fix the '
671 'problem whose exception is emitted below by unittest runner.\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100672 'Else, to be sure what\'s going on, run this test **alone** with \n'
Aaron Gable3a16ed12017-03-23 10:51:55 -0700673 ' tests/git_cl_tests.py TestGitCl.<name>\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100674 'and follow instructions above.\n' +
675 '=' * 80)
wychen@chromium.org445c8962015-04-28 23:30:05 +0000676 finally:
677 super(TestGitCl, self).tearDown()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000678
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000679 def _mocked_call(self, *args, **_kwargs):
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000680 self.assertTrue(
681 self.calls,
tandrii9d206752016-06-20 11:32:47 -0700682 '@%d Expected: <Missing> Actual: %r' % (len(self._calls_done), args))
wychen@chromium.orga872e752015-04-28 23:42:18 +0000683 top = self.calls.pop(0)
wychen@chromium.orga872e752015-04-28 23:42:18 +0000684 expected_args, result = top
685
maruel@chromium.orge52678e2013-04-26 18:34:44 +0000686 # Also logs otherwise it could get caught in a try/finally and be hard to
687 # diagnose.
688 if expected_args != args:
tandrii9d206752016-06-20 11:32:47 -0700689 N = 5
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000690 prior_calls = '\n '.join(
tandrii9d206752016-06-20 11:32:47 -0700691 '@%d: %r' % (len(self._calls_done) - N + i, c[0])
692 for i, c in enumerate(self._calls_done[-N:]))
693 following_calls = '\n '.join(
694 '@%d: %r' % (len(self._calls_done) + i + 1, c[0])
695 for i, c in enumerate(self.calls[:N]))
696 extended_msg = (
697 'A few prior calls:\n %s\n\n'
698 'This (expected):\n @%d: %r\n'
699 'This (actual):\n @%d: %r\n\n'
700 'A few following expected calls:\n %s' %
701 (prior_calls, len(self._calls_done), expected_args,
702 len(self._calls_done), args, following_calls))
703 git_cl.logging.error(extended_msg)
704
tandrii99a72f22016-08-17 14:33:24 -0700705 self.fail('@%d\n'
706 ' Expected: %r\n'
707 ' Actual: %r' % (
tandrii9d206752016-06-20 11:32:47 -0700708 len(self._calls_done), expected_args, args))
709
710 self._calls_done.append(top)
tandrii5d48c322016-08-18 16:19:37 -0700711 if isinstance(result, Exception):
712 raise result
Edward Lemur0db01f02019-11-12 22:01:51 +0000713 # stdout from git commands is supposed to be a bytestream. Convert it here
714 # instead of converting all test output in this file to bytes.
715 if args[0][0] == 'git' and not isinstance(result, bytes):
716 result = result.encode('utf-8')
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000717 return result
718
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100719 def test_ask_for_explicit_yes_true(self):
720 self.calls = [
721 (('ask_for_data', 'prompt [Yes/No]: '), 'blah'),
722 (('ask_for_data', 'Please, type yes or no: '), 'ye'),
723 ]
724 self.assertTrue(git_cl.ask_for_explicit_yes('prompt'))
725
tandrii48df5812016-10-17 03:55:37 -0700726 def test_LoadCodereviewSettingsFromFile_gerrit(self):
Edward Lemur79d4f992019-11-11 23:49:02 +0000727 codereview_file = StringIO('GERRIT_HOST: true')
tandrii48df5812016-10-17 03:55:37 -0700728 self.calls = [
729 ((['git', 'config', '--unset-all', 'rietveld.cc'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700730 ((['git', 'config', '--unset-all', 'rietveld.tree-status-url'],), CERR1),
731 ((['git', 'config', '--unset-all', 'rietveld.viewvc-url'],), CERR1),
732 ((['git', 'config', '--unset-all', 'rietveld.bug-prefix'],), CERR1),
733 ((['git', 'config', '--unset-all', 'rietveld.cpplint-regex'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700734 ((['git', 'config', '--unset-all', 'rietveld.cpplint-ignore-regex'],),
735 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700736 ((['git', 'config', '--unset-all', 'rietveld.run-post-upload-hook'],),
737 CERR1),
Jamie Madilldc4d19e2019-10-24 21:50:02 +0000738 ((['git', 'config', '--unset-all', 'rietveld.format-full-by-default'],),
739 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700740 ((['git', 'config', 'gerrit.host', 'true'],), ''),
741 ]
742 self.assertIsNone(git_cl.LoadCodereviewSettingsFromFile(codereview_file))
743
maruel@chromium.orga3353652011-11-30 14:26:57 +0000744 @classmethod
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000745 def _is_gerrit_calls(cls, gerrit=False):
746 return [((['git', 'config', 'rietveld.autoupdate'],), ''),
747 ((['git', 'config', 'gerrit.host'],), 'True' if gerrit else '')]
748
749 @classmethod
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +0000750 def _git_post_upload_calls(cls):
751 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000752 ((['git', 'rev-parse', 'HEAD'],), 'hash'),
753 ((['git', 'symbolic-ref', 'HEAD'],), 'hash'),
754 ((['git',
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000755 'config', 'branch.hash.last-upload-hash', 'hash'],), ''),
rmistry@google.com5626a922015-02-26 14:03:30 +0000756 ((['git', 'config', 'rietveld.run-post-upload-hook'],), ''),
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000757 ]
758
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000759 @staticmethod
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000760 def _git_sanity_checks(diff_base, working_branch, get_remote_branch=True):
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000761 fake_ancestor = 'fake_ancestor'
762 fake_cl = 'fake_cl_for_patch'
763 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000764 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000765 'rev-parse', '--verify', diff_base],), fake_ancestor),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000766 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000767 'merge-base', fake_ancestor, 'HEAD'],), fake_ancestor),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000768 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000769 'rev-list', '^' + fake_ancestor, 'HEAD'],), fake_cl),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000770 # Mock a config miss (error code 1)
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000771 ((['git',
tandrii5d48c322016-08-18 16:19:37 -0700772 'config', 'gitcl.remotebranch'],), CERR1),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000773 ] + ([
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000774 # Call to GetRemoteBranch()
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000775 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000776 'config', 'branch.%s.merge' % working_branch],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000777 'refs/heads/master'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000778 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000779 'config', 'branch.%s.remote' % working_branch],), 'origin'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000780 ] if get_remote_branch else []) + [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000781 ((['git', 'rev-list', '^' + fake_ancestor,
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000782 'refs/remotes/origin/master'],), ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000783 ]
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000784
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000785 @classmethod
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000786 def _gerrit_ensure_auth_calls(
Edward Lemurf38bc172019-09-03 21:02:13 +0000787 cls, issue=None, skip_auth_check=False, short_hostname='chromium',
788 custom_cl_base=None):
shinyak@chromium.org00dbccd2016-04-15 07:24:43 +0000789 cmd = ['git', 'config', '--bool', 'gerrit.skip-ensure-authenticated']
tandrii@chromium.org28253532016-04-14 13:46:56 +0000790 if skip_auth_check:
791 return [((cmd, ), 'true')]
792
tandrii5d48c322016-08-18 16:19:37 -0700793 calls = [((cmd, ), CERR1)]
Edward Lemurf38bc172019-09-03 21:02:13 +0000794
795 if custom_cl_base:
796 calls += [
797 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
798 ]
799
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000800 calls.extend([
801 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
802 ((['git', 'config', 'branch.master.remote'],), 'origin'),
803 ((['git', 'config', 'remote.origin.url'],),
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000804 'https://%s.googlesource.com/my/repo' % short_hostname),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000805 ])
Edward Lemurf38bc172019-09-03 21:02:13 +0000806
807 calls += [
808 ((['git', 'config', 'branch.master.gerritissue'],),
809 CERR1 if issue is None else str(issue)),
810 ]
811
Daniel Chengcf6269b2019-05-18 01:02:12 +0000812 if issue:
813 calls.extend([
814 ((['git', 'config', 'branch.master.gerritserver'],), CERR1),
815 ])
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000816 return calls
817
818 @classmethod
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100819 def _gerrit_base_calls(cls, issue=None, fetched_description=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200820 fetched_status=None, other_cl_owner=None,
Anthony Polito8b955342019-09-24 19:01:36 +0000821 custom_cl_base=None, short_hostname='chromium',
822 change_id=None):
Aaron Gable13101a62018-02-09 13:20:41 -0800823 calls = cls._is_gerrit_calls(True)
Edward Lemurf38bc172019-09-03 21:02:13 +0000824 if not custom_cl_base:
825 calls += [
826 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
827 ]
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200828
829 if custom_cl_base:
830 ancestor_revision = custom_cl_base
831 else:
832 # Determine ancestor_revision to be merge base.
833 ancestor_revision = 'fake_ancestor_sha'
834 calls += [
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000835 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000836 ((['git', 'config', 'branch.master.remote'],), 'origin'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000837 ((['get_or_create_merge_base', 'master',
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200838 'refs/remotes/origin/master'],), ancestor_revision),
839 ]
840
841 # Calls to verify branch point is ancestor
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000842 calls += cls._gerrit_ensure_auth_calls(
Edward Lemurf38bc172019-09-03 21:02:13 +0000843 issue=issue, short_hostname=short_hostname,
844 custom_cl_base=custom_cl_base)
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100845
846 if issue:
847 calls += [
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000848 (('GetChangeDetail', '%s-review.googlesource.com' % short_hostname,
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +0000849 'my%2Frepo~123456',
Andrii Shyshkalovc4a73562018-09-25 18:40:17 +0000850 ['DETAILED_ACCOUNTS', 'CURRENT_REVISION', 'CURRENT_COMMIT', 'LABELS']
851 ),
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100852 {
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100853 'owner': {'email': (other_cl_owner or 'owner@example.com')},
Anthony Polito8b955342019-09-24 19:01:36 +0000854 'change_id': (change_id or '123456789'),
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100855 'current_revision': 'sha1_of_current_revision',
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000856 'revisions': {'sha1_of_current_revision': {
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100857 'commit': {'message': fetched_description},
858 }},
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100859 'status': fetched_status or 'NEW',
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100860 }),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100861 ]
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100862 if fetched_status == 'ABANDONED':
863 calls += [
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000864 (('DieWithError', 'Change https://%s-review.googlesource.com/'
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100865 '123456 has been abandoned, new uploads are not '
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000866 'allowed' % short_hostname), SystemExitMock()),
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100867 ]
868 return calls
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100869 if other_cl_owner:
870 calls += [
871 (('ask_for_data', 'Press Enter to upload, or Ctrl+C to abort'), ''),
872 ]
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100873
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200874 calls += cls._git_sanity_checks(ancestor_revision, 'master',
875 get_remote_branch=False)
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100876 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200877 ((['git', 'rev-parse', '--show-cdup'],), ''),
878 ((['git', 'rev-parse', 'HEAD'],), '12345'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000879
Aaron Gable7817f022017-12-12 09:43:17 -0800880 ((['git', '-c', 'core.quotePath=false', 'diff', '--name-status',
881 '--no-renames', '-r', ancestor_revision + '...', '.'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200882 'M\t.gitignore\n'),
883 ((['git', 'config', 'branch.master.gerritpatchset'],), CERR1),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100884 ]
885
886 if not issue:
887 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200888 ((['git', 'log', '--pretty=format:%s%n%n%b',
889 ancestor_revision + '...'],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000890 'foo'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100891 ]
892
893 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200894 ((['git', 'config', 'user.email'],), 'me@example.com'),
Edward Lemur2c48f242019-06-04 16:14:09 +0000895 (('time.time',), 1000,),
896 (('time.time',), 3000,),
897 (('add_repeated', 'sub_commands', {
898 'execution_time': 2000,
899 'command': 'presubmit',
900 'exit_code': 0
901 }), None,),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200902 ((['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] +
903 ([custom_cl_base] if custom_cl_base else
904 [ancestor_revision, 'HEAD']),),
905 '+dat'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100906 ]
907 return calls
ukai@chromium.orge8077812012-02-03 03:41:46 +0000908
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +0000909 @classmethod
910 def _gerrit_upload_calls(cls, description, reviewers, squash,
tandriia60502f2016-06-20 02:01:53 -0700911 squash_mode='default',
tandrii@chromium.org10625002016-03-04 20:03:47 +0000912 expected_upstream_ref='origin/refs/heads/master',
Aaron Gablefd238082017-06-07 13:42:34 -0700913 title=None, notify=False,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +0100914 post_amend_description=None, issue=None, cc=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000915 custom_cl_base=None, tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +0000916 short_hostname='chromium',
Edward Lemur1b52d872019-05-09 21:12:12 +0000917 labels=None, change_id=None, original_title=None,
Anthony Polito8b955342019-09-24 19:01:36 +0000918 final_description=None, gitcookies_exists=True,
919 force=False):
tandrii@chromium.org10625002016-03-04 20:03:47 +0000920 if post_amend_description is None:
921 post_amend_description = description
bradnelsond975b302016-10-23 12:20:23 -0700922 cc = cc or []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200923 # Determined in `_gerrit_base_calls`.
924 determined_ancestor_revision = custom_cl_base or 'fake_ancestor_sha'
925
926 calls = []
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000927
tandriia60502f2016-06-20 02:01:53 -0700928 if squash_mode == 'default':
929 calls.extend([
930 ((['git', 'config', '--bool', 'gerrit.override-squash-uploads'],), ''),
931 ((['git', 'config', '--bool', 'gerrit.squash-uploads'],), ''),
932 ])
933 elif squash_mode in ('override_squash', 'override_nosquash'):
934 calls.extend([
935 ((['git', 'config', '--bool', 'gerrit.override-squash-uploads'],),
936 'true' if squash_mode == 'override_squash' else 'false'),
937 ])
938 else:
939 assert squash_mode in ('squash', 'nosquash')
940
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000941 # If issue is given, then description is fetched from Gerrit instead.
942 if issue is None:
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000943 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200944 ((['git', 'log', '--pretty=format:%s\n\n%b',
945 ((custom_cl_base + '..') if custom_cl_base else
946 'fake_ancestor_sha..HEAD')],),
947 description),
948 ]
Aaron Gableb56ad332017-01-06 15:24:31 -0800949 if squash:
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000950 title = 'Initial_upload'
Aaron Gableb56ad332017-01-06 15:24:31 -0800951 else:
952 if not title:
953 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200954 ((['git', 'show', '-s', '--format=%s', 'HEAD'],), ''),
955 (('ask_for_data', 'Title for patchset []: '), 'User input'),
Aaron Gableb56ad332017-01-06 15:24:31 -0800956 ]
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000957 title = 'User_input'
tandrii@chromium.org57d86542016-03-04 16:11:32 +0000958 if not git_footers.get_footer_change_id(description) and not squash:
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000959 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200960 (('DownloadGerritHook', False), ''),
961 # Amending of commit message to get the Change-Id.
962 ((['git', 'log', '--pretty=format:%s\n\n%b',
963 determined_ancestor_revision + '..HEAD'],),
964 description),
965 ((['git', 'commit', '--amend', '-m', description],), ''),
966 ((['git', 'log', '--pretty=format:%s\n\n%b',
967 determined_ancestor_revision + '..HEAD'],),
968 post_amend_description)
969 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000970 if squash:
Anthony Polito8b955342019-09-24 19:01:36 +0000971 if force or not issue:
972 if issue:
973 calls += [
974 ((['git', 'config', 'rietveld.bug-prefix'],), ''),
975 ]
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000976 # Prompting to edit description on first upload.
977 calls += [
Jonas Termansend0f79112019-03-22 15:28:26 +0000978 ((['git', 'config', 'rietveld.bug-prefix'],), ''),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000979 ]
Anthony Polito8b955342019-09-24 19:01:36 +0000980 if not force:
981 calls += [
982 ((['git', 'config', 'core.editor'],), ''),
983 ((['RunEditor'],), description),
984 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000985 ref_to_push = 'abcdef0123456789'
986 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200987 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
988 ((['git', 'config', 'branch.master.remote'],), 'origin'),
989 ]
990
991 if custom_cl_base is None:
992 calls += [
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000993 ((['get_or_create_merge_base', 'master',
994 'refs/remotes/origin/master'],),
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000995 'origin/master'),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200996 ]
997 parent = 'origin/master'
998 else:
999 calls += [
1000 ((['git', 'merge-base', '--is-ancestor', custom_cl_base,
1001 'refs/remotes/origin/master'],),
1002 callError(1)), # Means not ancenstor.
1003 (('ask_for_data',
1004 'Do you take responsibility for cleaning up potential mess '
1005 'resulting from proceeding with upload? Press Enter to upload, '
1006 'or Ctrl+C to abort'), ''),
1007 ]
1008 parent = custom_cl_base
1009
1010 calls += [
1011 ((['git', 'rev-parse', 'HEAD:'],), # `HEAD:` means HEAD's tree hash.
1012 '0123456789abcdef'),
1013 ((['git', 'commit-tree', '0123456789abcdef', '-p', parent,
Aaron Gable9a03ae02017-11-03 11:31:07 -07001014 '-F', '/tmp/named'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001015 ref_to_push),
1016 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001017 else:
1018 ref_to_push = 'HEAD'
1019
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001020 calls += [
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +00001021 (('SaveDescriptionBackup',), None),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001022 ((['git', 'rev-list',
1023 (custom_cl_base if custom_cl_base else expected_upstream_ref) + '..' +
1024 ref_to_push],),
1025 '1hashPerLine\n'),
1026 ]
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001027
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001028 metrics_arguments = []
1029
Aaron Gableafd52772017-06-27 16:40:10 -07001030 if notify:
Aaron Gable844cf292017-06-28 11:32:59 -07001031 ref_suffix = '%ready,notify=ALL'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001032 metrics_arguments += ['ready', 'notify=ALL']
Aaron Gable844cf292017-06-28 11:32:59 -07001033 else:
Jamie Madill276da0b2018-04-27 14:41:20 -04001034 if not issue and squash:
Aaron Gable844cf292017-06-28 11:32:59 -07001035 ref_suffix = '%wip'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001036 metrics_arguments.append('wip')
Aaron Gable844cf292017-06-28 11:32:59 -07001037 else:
1038 ref_suffix = '%notify=NONE'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001039 metrics_arguments.append('notify=NONE')
Aaron Gable9b713dd2016-12-14 16:04:21 -08001040
Aaron Gable70f4e242017-06-26 10:45:59 -07001041 if title:
Aaron Gableafd52772017-06-27 16:40:10 -07001042 ref_suffix += ',m=' + title
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001043 metrics_arguments.append('m')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001044
Edward Lemur4508b422019-10-03 21:56:35 +00001045 if issue is None:
1046 calls += [
1047 ((['git', 'config', 'rietveld.cc'],), ''),
1048 ]
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001049 if short_hostname == 'chromium':
1050 # All reviwers and ccs get into ref_suffix.
1051 for r in sorted(reviewers):
1052 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001053 metrics_arguments.append('r')
Edward Lemur4508b422019-10-03 21:56:35 +00001054 if issue is None:
1055 cc += ['chromium-reviews+test-more-cc@chromium.org', 'joe@example.com']
1056 for c in sorted(cc):
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001057 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001058 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001059 reviewers, cc = [], []
1060 else:
1061 # TODO(crbug/877717): remove this case.
1062 calls += [
1063 (('ValidAccounts', '%s-review.googlesource.com' % short_hostname,
1064 sorted(reviewers) + ['joe@example.com',
1065 'chromium-reviews+test-more-cc@chromium.org'] + cc),
1066 {
1067 e: {'email': e}
1068 for e in (reviewers + ['joe@example.com'] + cc)
1069 })
1070 ]
1071 for r in sorted(reviewers):
1072 if r != 'bad-account-or-email':
1073 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001074 metrics_arguments.append('r')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001075 reviewers.remove(r)
Edward Lemur4508b422019-10-03 21:56:35 +00001076 if issue is None:
1077 cc += ['joe@example.com']
1078 for c in sorted(cc):
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001079 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001080 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001081 if c in cc:
1082 cc.remove(c)
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00001083
Edward Lemur687ca902018-12-05 02:30:30 +00001084 for k, v in sorted((labels or {}).items()):
1085 ref_suffix += ',l=%s+%d' % (k, v)
1086 metrics_arguments.append('l=%s+%d' % (k, v))
1087
1088 if tbr:
1089 calls += [
1090 (('GetCodeReviewTbrScore',
1091 '%s-review.googlesource.com' % short_hostname,
1092 'my/repo'),
1093 2,),
1094 ]
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001095
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001096 calls += [
1097 (('time.time',), 1000,),
1098 ((['git', 'push',
1099 'https://%s.googlesource.com/my/repo' % short_hostname,
1100 ref_to_push + ':refs/for/refs/heads/master' + ref_suffix],),
1101 (('remote:\n'
1102 'remote: Processing changes: (\)\n'
1103 'remote: Processing changes: (|)\n'
1104 'remote: Processing changes: (/)\n'
1105 'remote: Processing changes: (-)\n'
1106 'remote: Processing changes: new: 1 (/)\n'
1107 'remote: Processing changes: new: 1, done\n'
1108 'remote:\n'
1109 'remote: New Changes:\n'
1110 'remote: https://%s-review.googlesource.com/#/c/my/repo/+/123456'
1111 ' XXX\n'
1112 'remote:\n'
1113 'To https://%s.googlesource.com/my/repo\n'
1114 ' * [new branch] hhhh -> refs/for/refs/heads/master\n'
1115 ) % (short_hostname, short_hostname)),),
1116 (('time.time',), 2000,),
1117 (('add_repeated',
1118 'sub_commands',
1119 {
1120 'execution_time': 1000,
1121 'command': 'git push',
1122 'exit_code': 0,
1123 'arguments': sorted(metrics_arguments),
1124 }),
1125 None,),
1126 ]
1127
Edward Lemur1b52d872019-05-09 21:12:12 +00001128 final_description = final_description or post_amend_description.strip()
1129 original_title = original_title or title or '<untitled>'
1130 # Trace-related calls
1131 calls += [
1132 # Write a description with context for the current trace.
1133 ((['FileWrite', 'TRACES_DIR/20170316T200041.000000-README',
Edward Lemur75391d42019-05-14 23:35:56 +00001134 'Thu Mar 16 20:00:41 2017\n'
1135 '%(short_hostname)s-review.googlesource.com\n'
1136 '%(change_id)s\n'
1137 '%(title)s\n'
1138 '%(description)s\n'
1139 '1000\n'
1140 '0\n'
1141 '%(trace_name)s' % {
Edward Lemur1b52d872019-05-09 21:12:12 +00001142 'short_hostname': short_hostname,
1143 'change_id': change_id,
1144 'description': final_description,
1145 'title': original_title,
Edward Lemur75391d42019-05-14 23:35:56 +00001146 'trace_name': 'TRACES_DIR/20170316T200041.000000',
Edward Lemur1b52d872019-05-09 21:12:12 +00001147 }],),
1148 None,
1149 ),
1150 # Read traces and shorten git hashes.
1151 ((['os.path.isfile', 'TEMP_DIR/trace-packet'],),
1152 True,
1153 ),
1154 ((['FileRead', 'TEMP_DIR/trace-packet'],),
1155 ('git-hash: 0123456789012345678901234567890123456789\n'
1156 'git-hash: abcdeabcdeabcdeabcdeabcdeabcdeabcdeabcde\n'),
1157 ),
1158 ((['FileWrite', 'TEMP_DIR/trace-packet',
1159 'git-hash: 012345\n'
1160 'git-hash: abcdea\n'],),
1161 None,
1162 ),
1163 # Make zip file for the git traces.
1164 ((['make_archive', 'TRACES_DIR/20170316T200041.000000-traces', 'zip',
1165 'TEMP_DIR'],),
1166 None,
1167 ),
1168 # Collect git config and gitcookies.
1169 ((['git', 'config', '-l'],),
1170 'git-config-output',
1171 ),
1172 ((['FileWrite', 'TEMP_DIR/git-config', 'git-config-output'],),
1173 None,
1174 ),
1175 ((['os.path.isfile', '~/.gitcookies'],),
1176 gitcookies_exists,
1177 ),
1178 ]
1179 if gitcookies_exists:
1180 calls += [
1181 ((['FileRead', '~/.gitcookies'],),
1182 'gitcookies 1/SECRET',
1183 ),
1184 ((['FileWrite', 'TEMP_DIR/gitcookies', 'gitcookies REDACTED'],),
1185 None,
1186 ),
1187 ]
1188 calls += [
1189 # Make zip file for the git config and gitcookies.
1190 ((['make_archive', 'TRACES_DIR/20170316T200041.000000-git-info', 'zip',
1191 'TEMP_DIR'],),
1192 None,
1193 ),
1194 ]
1195
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001196 if squash:
1197 calls += [
tandrii33a46ff2016-08-23 05:53:40 -07001198 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001199 ''),
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001200 ((['git', 'config', 'branch.master.gerritserver',
tandrii5d48c322016-08-18 16:19:37 -07001201 'https://chromium-review.googlesource.com'],), ''),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001202 ((['git', 'config', 'branch.master.gerritsquashhash',
1203 'abcdef0123456789'],), ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001204 ]
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001205 # TODO(crbug/877717): this should never be used.
1206 if squash and short_hostname != 'chromium':
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001207 calls += [
1208 (('AddReviewers',
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001209 'chromium-review.googlesource.com', 'my%2Frepo~123456',
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001210 sorted(reviewers),
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00001211 cc + ['chromium-reviews+test-more-cc@chromium.org'],
1212 notify),
1213 ''),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001214 ]
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +00001215 calls += cls._git_post_upload_calls()
ukai@chromium.orge8077812012-02-03 03:41:46 +00001216 return calls
1217
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001218 def _run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001219 self,
1220 upload_args,
1221 description,
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001222 reviewers=None,
tandriia60502f2016-06-20 02:01:53 -07001223 squash=True,
1224 squash_mode=None,
tandrii@chromium.org10625002016-03-04 20:03:47 +00001225 expected_upstream_ref='origin/refs/heads/master',
Aaron Gable9b713dd2016-12-14 16:04:21 -08001226 title=None,
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001227 notify=False,
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001228 post_amend_description=None,
bradnelsond975b302016-10-23 12:20:23 -07001229 issue=None,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +01001230 cc=None,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001231 fetched_status=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001232 other_cl_owner=None,
Aaron Gablefd238082017-06-07 13:42:34 -07001233 custom_cl_base=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001234 tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001235 short_hostname='chromium',
Edward Lemur1b52d872019-05-09 21:12:12 +00001236 labels=None,
1237 change_id=None,
1238 original_title=None,
1239 final_description=None,
Anthony Polito8b955342019-09-24 19:01:36 +00001240 gitcookies_exists=True,
1241 force=False,
1242 fetched_description=None):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001243 """Generic gerrit upload test framework."""
tandriia60502f2016-06-20 02:01:53 -07001244 if squash_mode is None:
1245 if '--no-squash' in upload_args:
1246 squash_mode = 'nosquash'
1247 elif '--squash' in upload_args:
1248 squash_mode = 'squash'
1249 else:
1250 squash_mode = 'default'
1251
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001252 reviewers = reviewers or []
bradnelsond975b302016-10-23 12:20:23 -07001253 cc = cc or []
Edward Lemur79d4f992019-11-11 23:49:02 +00001254 self.mock(git_cl.sys, 'stdout', StringIO())
tandrii16e0b4e2016-06-07 10:34:28 -07001255 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001256 CookiesAuthenticatorMockFactory(
1257 same_auth=('git-owner.example.com', '', 'pass')))
Edward Lemur125d60a2019-09-13 18:25:41 +00001258 self.mock(git_cl.Changelist, '_GerritCommitMsgHookCheck',
tandrii16e0b4e2016-06-07 10:34:28 -07001259 lambda _, offer_removal: None)
tandriia60502f2016-06-20 02:01:53 -07001260 self.mock(git_cl.gclient_utils, 'RunEditor',
1261 lambda *_, **__: self._mocked_call(['RunEditor']))
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001262 self.mock(git_cl, 'DownloadGerritHook', lambda force: self._mocked_call(
1263 'DownloadGerritHook', force))
Edward Lemur1b52d872019-05-09 21:12:12 +00001264 self.mock(git_cl.gclient_utils, 'FileRead',
1265 lambda path: self._mocked_call(['FileRead', path]))
1266 self.mock(git_cl.gclient_utils, 'FileWrite',
1267 lambda path, contents: self._mocked_call(
1268 ['FileWrite', path, contents]))
1269 self.mock(git_cl, 'datetime_now',
1270 lambda: datetime.datetime(2017, 3, 16, 20, 0, 41, 0))
1271 self.mock(git_cl.tempfile, 'mkdtemp', lambda: 'TEMP_DIR')
1272 self.mock(git_cl, 'TRACES_DIR', 'TRACES_DIR')
Edward Lemur75391d42019-05-14 23:35:56 +00001273 self.mock(git_cl, 'TRACES_README_FORMAT',
1274 '%(now)s\n'
1275 '%(gerrit_host)s\n'
1276 '%(change_id)s\n'
1277 '%(title)s\n'
1278 '%(description)s\n'
1279 '%(execution_time)s\n'
1280 '%(exit_code)s\n'
1281 '%(trace_name)s')
Edward Lemur1b52d872019-05-09 21:12:12 +00001282 self.mock(git_cl.shutil, 'make_archive',
1283 lambda *args: self._mocked_call(['make_archive'] + list(args)))
1284 self.mock(os.path, 'isfile',
1285 lambda path: self._mocked_call(['os.path.isfile', path]))
tandriia60502f2016-06-20 02:01:53 -07001286
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001287 self.calls = self._gerrit_base_calls(
1288 issue=issue,
Anthony Polito8b955342019-09-24 19:01:36 +00001289 fetched_description=fetched_description or description,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001290 fetched_status=fetched_status,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001291 other_cl_owner=other_cl_owner,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001292 custom_cl_base=custom_cl_base,
Anthony Polito8b955342019-09-24 19:01:36 +00001293 short_hostname=short_hostname,
1294 change_id=change_id)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001295 if fetched_status != 'ABANDONED':
Aaron Gable9a03ae02017-11-03 11:31:07 -07001296 self.mock(tempfile, 'NamedTemporaryFile', MakeNamedTemporaryFileMock(
Edward Lemur0db01f02019-11-12 22:01:51 +00001297 self, expected_content=description))
Aaron Gable9a03ae02017-11-03 11:31:07 -07001298 self.mock(os, 'remove', lambda _: True)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001299 self.calls += self._gerrit_upload_calls(
1300 description, reviewers, squash,
1301 squash_mode=squash_mode,
1302 expected_upstream_ref=expected_upstream_ref,
Aaron Gablefd238082017-06-07 13:42:34 -07001303 title=title, notify=notify,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001304 post_amend_description=post_amend_description,
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001305 issue=issue, cc=cc,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001306 custom_cl_base=custom_cl_base, tbr=tbr,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001307 short_hostname=short_hostname,
Edward Lemur1b52d872019-05-09 21:12:12 +00001308 labels=labels,
1309 change_id=change_id,
1310 original_title=original_title,
1311 final_description=final_description,
Anthony Polito8b955342019-09-24 19:01:36 +00001312 gitcookies_exists=gitcookies_exists,
1313 force=force)
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001314 # Uncomment when debugging.
Raul Tambre80ee78e2019-05-06 22:41:05 +00001315 # print('\n'.join(map(lambda x: '%2i: %s' % x, enumerate(self.calls))))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001316 git_cl.main(['upload'] + upload_args)
1317
Edward Lemur1b52d872019-05-09 21:12:12 +00001318 def test_gerrit_upload_traces_no_gitcookies(self):
1319 self._run_gerrit_upload_test(
1320 ['--no-squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001321 'desc ✔\n\nBUG=\n',
Edward Lemur1b52d872019-05-09 21:12:12 +00001322 [],
1323 squash=False,
Edward Lemur0db01f02019-11-12 22:01:51 +00001324 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001325 change_id='Ixxx',
1326 gitcookies_exists=False)
1327
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001328 def test_gerrit_upload_without_change_id(self):
tandriia60502f2016-06-20 02:01:53 -07001329 self._run_gerrit_upload_test(
1330 ['--no-squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001331 'desc ✔\n\nBUG=\n',
tandriia60502f2016-06-20 02:01:53 -07001332 [],
1333 squash=False,
Edward Lemur0db01f02019-11-12 22:01:51 +00001334 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001335 change_id='Ixxx')
tandriia60502f2016-06-20 02:01:53 -07001336
1337 def test_gerrit_upload_without_change_id_override_nosquash(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001338 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001339 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001340 'desc ✔\n\nBUG=\n',
tandrii@chromium.org10625002016-03-04 20:03:47 +00001341 [],
tandriia60502f2016-06-20 02:01:53 -07001342 squash=False,
1343 squash_mode='override_nosquash',
Edward Lemur0db01f02019-11-12 22:01:51 +00001344 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001345 change_id='Ixxx')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001346
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001347 def test_gerrit_no_reviewer(self):
1348 self._run_gerrit_upload_test(
1349 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001350 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
tandriia60502f2016-06-20 02:01:53 -07001351 [],
1352 squash=False,
Edward Lemur1b52d872019-05-09 21:12:12 +00001353 squash_mode='override_nosquash',
1354 change_id='I123456789')
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001355
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001356 def test_gerrit_no_reviewer_non_chromium_host(self):
1357 # TODO(crbug/877717): remove this test case.
1358 self._run_gerrit_upload_test(
1359 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001360 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001361 [],
1362 squash=False,
1363 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001364 short_hostname='other',
1365 change_id='I123456789')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001366
Nick Carter8692b182017-11-06 16:30:38 -08001367 def test_gerrit_patchset_title_special_chars(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00001368 self.mock(git_cl.sys, 'stdout', StringIO())
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001369 self._run_gerrit_upload_test(
Nick Carter8692b182017-11-06 16:30:38 -08001370 ['-f', '-t', 'We\'ll escape ^_ ^ special chars...@{u}'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001371 'desc ✔\n\nBUG=\n\nChange-Id: I123456789',
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001372 squash=False,
1373 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001374 title='We%27ll_escape_%5E%5F_%5E_special_chars%2E%2E%2E%40%7Bu%7D',
1375 change_id='I123456789',
1376 original_title='We\'ll escape ^_ ^ special chars...@{u}')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001377
ukai@chromium.orge8077812012-02-03 03:41:46 +00001378 def test_gerrit_reviewers_cmd_line(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001379 self._run_gerrit_upload_test(
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001380 ['-r', 'foo@example.com', '--send-mail'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001381 'desc ✔\n\nBUG=\n\nChange-Id: I123456789',
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001382 ['foo@example.com'],
tandriia60502f2016-06-20 02:01:53 -07001383 squash=False,
1384 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001385 notify=True,
1386 change_id='I123456789',
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001387 final_description=(
Edward Lemur0db01f02019-11-12 22:01:51 +00001388 'desc ✔\n\nBUG=\nR=foo@example.com\n\nChange-Id: I123456789'))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001389
Anthony Polito8b955342019-09-24 19:01:36 +00001390 def test_gerrit_upload_force_sets_bug(self):
1391 self._run_gerrit_upload_test(
1392 ['-b', '10000', '-f'],
1393 u'desc=\n\nBug: 10000\nChange-Id: Ixxx',
1394 [],
1395 force=True,
1396 expected_upstream_ref='origin/master',
1397 fetched_description='desc=\n\nChange-Id: Ixxx',
1398 original_title='Initial upload',
1399 change_id='Ixxx')
1400
1401 def test_gerrit_upload_force_sets_bug_if_wrong_changeid(self):
1402 self._run_gerrit_upload_test(
1403 ['-b', '10000', '-f', '-m', 'Title'],
1404 u'desc=\n\nChange-Id: Ixxxx\n\nChange-Id: Izzzz\nBug: 10000',
1405 [],
1406 force=True,
1407 issue='123456',
1408 expected_upstream_ref='origin/master',
1409 fetched_description='desc=\n\nChange-Id: Ixxxx',
1410 original_title='Title',
1411 title='Title',
1412 change_id='Izzzz')
1413
Dan Beamd8b04ca2019-10-10 21:23:26 +00001414 def test_gerrit_upload_force_sets_fixed(self):
1415 self._run_gerrit_upload_test(
1416 ['-x', '10000', '-f'],
1417 u'desc=\n\nFixed: 10000\nChange-Id: Ixxx',
1418 [],
1419 force=True,
1420 expected_upstream_ref='origin/master',
1421 fetched_description='desc=\n\nChange-Id: Ixxx',
1422 original_title='Initial upload',
1423 change_id='Ixxx')
1424
ukai@chromium.orge8077812012-02-03 03:41:46 +00001425 def test_gerrit_reviewer_multiple(self):
Edward Lemur687ca902018-12-05 02:30:30 +00001426 self.mock(git_cl.gerrit_util, 'GetCodeReviewTbrScore',
1427 lambda *a: self._mocked_call('GetCodeReviewTbrScore', *a))
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001428 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001429 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001430 'desc ✔\nTBR=reviewer@example.com\nBUG=\nR=another@example.com\n'
bradnelsond975b302016-10-23 12:20:23 -07001431 'CC=more@example.com,people@example.com\n\n'
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001432 'Change-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001433 ['reviewer@example.com', 'another@example.com'],
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001434 expected_upstream_ref='origin/master',
Aaron Gablefd238082017-06-07 13:42:34 -07001435 cc=['more@example.com', 'people@example.com'],
Edward Lemur687ca902018-12-05 02:30:30 +00001436 tbr='reviewer@example.com',
Edward Lemur1b52d872019-05-09 21:12:12 +00001437 labels={'Code-Review': 2},
1438 change_id='123456789',
1439 original_title='Initial upload')
tandriia60502f2016-06-20 02:01:53 -07001440
1441 def test_gerrit_upload_squash_first_is_default(self):
tandriia60502f2016-06-20 02:01:53 -07001442 self._run_gerrit_upload_test(
1443 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001444 'desc ✔\nBUG=\n\nChange-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001445 [],
Edward Lemur1b52d872019-05-09 21:12:12 +00001446 expected_upstream_ref='origin/master',
1447 change_id='123456789',
1448 original_title='Initial upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001449
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001450 def test_gerrit_upload_squash_first(self):
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001451 self._run_gerrit_upload_test(
1452 ['--squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001453 'desc ✔\nBUG=\n\nChange-Id: 123456789',
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001454 [],
luqui@chromium.org609f3952015-05-04 22:47:04 +00001455 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001456 expected_upstream_ref='origin/master',
1457 change_id='123456789',
1458 original_title='Initial upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001459
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001460 def test_gerrit_upload_squash_first_with_labels(self):
1461 self._run_gerrit_upload_test(
1462 ['--squash', '--cq-dry-run', '--enable-auto-submit'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001463 'desc ✔\nBUG=\n\nChange-Id: 123456789',
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001464 [],
1465 squash=True,
1466 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001467 labels={'Commit-Queue': 1, 'Auto-Submit': 1},
1468 change_id='123456789',
1469 original_title='Initial upload')
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001470
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001471 def test_gerrit_upload_squash_first_against_rev(self):
1472 custom_cl_base = 'custom_cl_base_rev_or_branch'
1473 self._run_gerrit_upload_test(
1474 ['--squash', custom_cl_base],
Edward Lemur0db01f02019-11-12 22:01:51 +00001475 'desc ✔\nBUG=\n\nChange-Id: 123456789',
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001476 [],
1477 squash=True,
1478 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001479 custom_cl_base=custom_cl_base,
1480 change_id='123456789',
1481 original_title='Initial upload')
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001482 self.assertIn(
1483 'If you proceed with upload, more than 1 CL may be created by Gerrit',
1484 sys.stdout.getvalue())
1485
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001486 def test_gerrit_upload_squash_reupload(self):
Edward Lemur0db01f02019-11-12 22:01:51 +00001487 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001488 self._run_gerrit_upload_test(
1489 ['--squash'],
1490 description,
1491 [],
1492 squash=True,
1493 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001494 issue=123456,
1495 change_id='123456789',
1496 original_title='User input')
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001497
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001498 def test_gerrit_upload_squash_reupload_to_abandoned(self):
1499 self.mock(git_cl, 'DieWithError',
1500 lambda msg, change=None: self._mocked_call('DieWithError', msg))
Edward Lemur0db01f02019-11-12 22:01:51 +00001501 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001502 with self.assertRaises(SystemExitMock):
1503 self._run_gerrit_upload_test(
1504 ['--squash'],
1505 description,
1506 [],
1507 squash=True,
1508 expected_upstream_ref='origin/master',
1509 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001510 fetched_status='ABANDONED',
1511 change_id='123456789')
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001512
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001513 def test_gerrit_upload_squash_reupload_to_not_owned(self):
1514 self.mock(git_cl.gerrit_util, 'GetAccountDetails',
1515 lambda *_, **__: {'email': 'yet-another@example.com'})
Edward Lemur0db01f02019-11-12 22:01:51 +00001516 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001517 self._run_gerrit_upload_test(
1518 ['--squash'],
1519 description,
1520 [],
1521 squash=True,
1522 expected_upstream_ref='origin/master',
1523 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001524 other_cl_owner='other@example.com',
1525 change_id='123456789',
1526 original_title='User input')
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001527 self.assertIn(
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001528 'WARNING: Change 123456 is owned by other@example.com, but you '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001529 'authenticate to Gerrit as yet-another@example.com.\n'
1530 'Uploading may fail due to lack of permissions',
1531 git_cl.sys.stdout.getvalue())
1532
rmistry@google.com2dd99862015-06-22 12:22:18 +00001533 def test_upload_branch_deps(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00001534 self.mock(git_cl.sys, 'stdout', StringIO())
rmistry@google.com2dd99862015-06-22 12:22:18 +00001535 def mock_run_git(*args, **_kwargs):
1536 if args[0] == ['for-each-ref',
1537 '--format=%(refname:short) %(upstream:short)',
1538 'refs/heads']:
1539 # Create a local branch dependency tree that looks like this:
1540 # test1 -> test2 -> test3 -> test4 -> test5
1541 # -> test3.1
1542 # test6 -> test0
1543 branch_deps = [
1544 'test2 test1', # test1 -> test2
1545 'test3 test2', # test2 -> test3
1546 'test3.1 test2', # test2 -> test3.1
1547 'test4 test3', # test3 -> test4
1548 'test5 test4', # test4 -> test5
1549 'test6 test0', # test0 -> test6
1550 'test7', # test7
1551 ]
1552 return '\n'.join(branch_deps)
1553 self.mock(git_cl, 'RunGit', mock_run_git)
1554
1555 class RecordCalls:
1556 times_called = 0
1557 record_calls = RecordCalls()
1558 def mock_CMDupload(*args, **_kwargs):
1559 record_calls.times_called += 1
1560 return 0
1561 self.mock(git_cl, 'CMDupload', mock_CMDupload)
1562
1563 self.calls = [
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001564 (('ask_for_data', 'This command will checkout all dependent branches '
1565 'and run "git cl upload". Press Enter to continue, '
1566 'or Ctrl+C to abort'), ''),
1567 ]
rmistry@google.com2dd99862015-06-22 12:22:18 +00001568
1569 class MockChangelist():
1570 def __init__(self):
1571 pass
1572 def GetBranch(self):
1573 return 'test1'
1574 def GetIssue(self):
1575 return '123'
1576 def GetPatchset(self):
1577 return '1001'
tandrii@chromium.org4c72b082016-03-31 22:26:35 +00001578 def IsGerrit(self):
1579 return False
rmistry@google.com2dd99862015-06-22 12:22:18 +00001580
1581 ret = git_cl.upload_branch_deps(MockChangelist(), [])
1582 # CMDupload should have been called 5 times because of 5 dependent branches.
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00001583 self.assertEqual(5, record_calls.times_called)
1584 self.assertEqual(0, ret)
rmistry@google.com2dd99862015-06-22 12:22:18 +00001585
tandrii@chromium.org65874e12016-03-04 12:03:02 +00001586 def test_gerrit_change_id(self):
1587 self.calls = [
1588 ((['git', 'write-tree'], ),
1589 'hashtree'),
1590 ((['git', 'rev-parse', 'HEAD~0'], ),
1591 'branch-parent'),
1592 ((['git', 'var', 'GIT_AUTHOR_IDENT'], ),
1593 'A B <a@b.org> 1456848326 +0100'),
1594 ((['git', 'var', 'GIT_COMMITTER_IDENT'], ),
1595 'C D <c@d.org> 1456858326 +0100'),
1596 ((['git', 'hash-object', '-t', 'commit', '--stdin'], ),
1597 'hashchange'),
1598 ]
1599 change_id = git_cl.GenerateGerritChangeId('line1\nline2\n')
1600 self.assertEqual(change_id, 'Ihashchange')
1601
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001602 def test_desecription_append_footer(self):
1603 for init_desc, footer_line, expected_desc in [
1604 # Use unique desc first lines for easy test failure identification.
1605 ('foo', 'R=one', 'foo\n\nR=one'),
1606 ('foo\n\nR=one', 'BUG=', 'foo\n\nR=one\nBUG='),
1607 ('foo\n\nR=one', 'Change-Id: Ixx', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1608 ('foo\n\nChange-Id: Ixx', 'R=one', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1609 ('foo\n\nR=one\n\nChange-Id: Ixx', 'TBR=two',
1610 'foo\n\nR=one\nTBR=two\n\nChange-Id: Ixx'),
1611 ('foo\n\nR=one\n\nChange-Id: Ixx', 'Foo-Bar: baz',
1612 'foo\n\nR=one\n\nChange-Id: Ixx\nFoo-Bar: baz'),
1613 ('foo\n\nChange-Id: Ixx', 'Foo-Bak: baz',
1614 'foo\n\nChange-Id: Ixx\nFoo-Bak: baz'),
1615 ('foo', 'Change-Id: Ixx', 'foo\n\nChange-Id: Ixx'),
1616 ]:
1617 desc = git_cl.ChangeDescription(init_desc)
1618 desc.append_footer(footer_line)
1619 self.assertEqual(desc.description, expected_desc)
1620
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001621 def test_update_reviewers(self):
1622 data = [
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001623 ('foo', [], [],
1624 'foo'),
1625 ('foo\nR=xx', [], [],
1626 'foo\nR=xx'),
1627 ('foo\nTBR=xx', [], [],
1628 'foo\nTBR=xx'),
1629 ('foo', ['a@c'], [],
1630 'foo\n\nR=a@c'),
1631 ('foo\nR=xx', ['a@c'], [],
1632 'foo\n\nR=a@c, xx'),
1633 ('foo\nTBR=xx', ['a@c'], [],
1634 'foo\n\nR=a@c\nTBR=xx'),
1635 ('foo\nTBR=xx\nR=yy', ['a@c'], [],
1636 'foo\n\nR=a@c, yy\nTBR=xx'),
1637 ('foo\nBUG=', ['a@c'], [],
1638 'foo\nBUG=\nR=a@c'),
1639 ('foo\nR=xx\nTBR=yy\nR=bar', ['a@c'], [],
1640 'foo\n\nR=a@c, bar, xx\nTBR=yy'),
1641 ('foo', ['a@c', 'b@c'], [],
1642 'foo\n\nR=a@c, b@c'),
1643 ('foo\nBar\n\nR=\nBUG=', ['c@c'], [],
1644 'foo\nBar\n\nR=c@c\nBUG='),
1645 ('foo\nBar\n\nR=\nBUG=\nR=', ['c@c'], [],
1646 'foo\nBar\n\nR=c@c\nBUG='),
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001647 # Same as the line before, but full of whitespaces.
1648 (
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001649 'foo\nBar\n\n R = \n BUG = \n R = ', ['c@c'], [],
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001650 'foo\nBar\n\nR=c@c\n BUG =',
1651 ),
1652 # Whitespaces aren't interpreted as new lines.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001653 ('foo BUG=allo R=joe ', ['c@c'], [],
1654 'foo BUG=allo R=joe\n\nR=c@c'),
1655 # Redundant TBRs get promoted to Rs
1656 ('foo\n\nR=a@c\nTBR=t@c', ['b@c', 'a@c'], ['a@c', 't@c'],
1657 'foo\n\nR=a@c, b@c\nTBR=t@c'),
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001658 ]
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001659 expected = [i[-1] for i in data]
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001660 actual = []
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001661 for orig, reviewers, tbrs, _expected in data:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001662 obj = git_cl.ChangeDescription(orig)
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001663 obj.update_reviewers(reviewers, tbrs)
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001664 actual.append(obj.description)
1665 self.assertEqual(expected, actual)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001666
Nodir Turakulov23b82142017-11-16 11:04:25 -08001667 def test_get_hash_tags(self):
1668 cases = [
1669 ('', []),
1670 ('a', []),
1671 ('[a]', ['a']),
1672 ('[aa]', ['aa']),
1673 ('[a ]', ['a']),
1674 ('[a- ]', ['a']),
1675 ('[a- b]', ['a-b']),
1676 ('[a--b]', ['a-b']),
1677 ('[a', []),
1678 ('[a]x', ['a']),
1679 ('[aa]x', ['aa']),
1680 ('[a b]', ['a-b']),
1681 ('[a b]', ['a-b']),
1682 ('[a__b]', ['a-b']),
1683 ('[a] x', ['a']),
1684 ('[a][b]', ['a', 'b']),
1685 ('[a] [b]', ['a', 'b']),
1686 ('[a][b]x', ['a', 'b']),
1687 ('[a][b] x', ['a', 'b']),
1688 ('[a]\n[b]', ['a']),
1689 ('[a\nb]', []),
1690 ('[a][', ['a']),
1691 ('Revert "[a] feature"', ['a']),
1692 ('Reland "[a] feature"', ['a']),
1693 ('Revert: [a] feature', ['a']),
1694 ('Reland: [a] feature', ['a']),
1695 ('Revert "Reland: [a] feature"', ['a']),
1696 ('Foo: feature', ['foo']),
1697 ('Foo Bar: feature', ['foo-bar']),
Anthony Polito02b5af32019-12-02 19:49:47 +00001698 ('Change Foo::Bar', []),
1699 ('Foo: Change Foo::Bar', ['foo']),
Nodir Turakulov23b82142017-11-16 11:04:25 -08001700 ('Revert "Foo bar: feature"', ['foo-bar']),
1701 ('Reland "Foo bar: feature"', ['foo-bar']),
1702 ]
1703 for desc, expected in cases:
1704 change_desc = git_cl.ChangeDescription(desc)
1705 actual = change_desc.get_hash_tags()
1706 self.assertEqual(
1707 actual,
1708 expected,
1709 'GetHashTags(%r) == %r, expected %r' % (desc, actual, expected))
1710
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001711 self.assertEqual(None, git_cl.GetTargetRef('origin', None, 'master'))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001712 self.assertEqual(None, git_cl.GetTargetRef(None,
1713 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001714 'master'))
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001715
wittman@chromium.org455dc922015-01-26 20:15:50 +00001716 # Check default target refs for branches.
1717 self.assertEqual('refs/heads/master',
1718 git_cl.GetTargetRef('origin', 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001719 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001720 self.assertEqual('refs/heads/master',
1721 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkgr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001722 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001723 self.assertEqual('refs/heads/master',
1724 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkcr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001725 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001726 self.assertEqual('refs/branch-heads/123',
1727 git_cl.GetTargetRef('origin',
1728 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001729 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001730 self.assertEqual('refs/diff/test',
1731 git_cl.GetTargetRef('origin',
1732 'refs/remotes/origin/refs/diff/test',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001733 None))
rmistry@google.comc68112d2015-03-03 12:48:06 +00001734 self.assertEqual('refs/heads/chrome/m42',
1735 git_cl.GetTargetRef('origin',
1736 'refs/remotes/origin/chrome/m42',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001737 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001738
1739 # Check target refs for user-specified target branch.
1740 for branch in ('branch-heads/123', 'remotes/branch-heads/123',
1741 'refs/remotes/branch-heads/123'):
1742 self.assertEqual('refs/branch-heads/123',
1743 git_cl.GetTargetRef('origin',
1744 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001745 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001746 for branch in ('origin/master', 'remotes/origin/master',
1747 'refs/remotes/origin/master'):
1748 self.assertEqual('refs/heads/master',
1749 git_cl.GetTargetRef('origin',
1750 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001751 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001752 for branch in ('master', 'heads/master', 'refs/heads/master'):
1753 self.assertEqual('refs/heads/master',
1754 git_cl.GetTargetRef('origin',
1755 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001756 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001757
wychen@chromium.orga872e752015-04-28 23:42:18 +00001758 def test_patch_when_dirty(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001759 # Patch when local tree is dirty.
wychen@chromium.orga872e752015-04-28 23:42:18 +00001760 self.mock(git_common, 'is_dirty_git_tree', lambda x: True)
1761 self.assertNotEqual(git_cl.main(['patch', '123456']), 0)
1762
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001763 @staticmethod
1764 def _get_gerrit_codereview_server_calls(branch, value=None,
1765 git_short_host='host',
Aaron Gable697a91b2018-01-19 15:20:15 -08001766 detect_branch=True,
1767 detect_server=True):
Edward Lemur125d60a2019-09-13 18:25:41 +00001768 """Returns calls executed by Changelist.GetCodereviewServer.
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001769
1770 If value is given, branch.<BRANCH>.gerritcodereview is already set.
1771 """
1772 calls = []
1773 if detect_branch:
1774 calls.append(((['git', 'symbolic-ref', 'HEAD'],), branch))
Aaron Gable697a91b2018-01-19 15:20:15 -08001775 if detect_server:
1776 calls.append(((['git', 'config', 'branch.' + branch + '.gerritserver'],),
1777 CERR1 if value is None else value))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001778 if value is None:
1779 calls += [
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001780 ((['git', 'config', 'branch.' + branch + '.merge'],),
1781 'refs/heads' + branch),
1782 ((['git', 'config', 'branch.' + branch + '.remote'],),
1783 'origin'),
1784 ((['git', 'config', 'remote.origin.url'],),
1785 'https://%s.googlesource.com/my/repo' % git_short_host),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001786 ]
1787 return calls
1788
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001789 def _patch_common(self, force_codereview=False,
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001790 new_branch=False, git_short_host='host',
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001791 detect_gerrit_server=False,
1792 actual_codereview=None,
1793 codereview_in_url=False):
Edward Lemur79d4f992019-11-11 23:49:02 +00001794 self.mock(git_cl.sys, 'stdout', StringIO())
wychen@chromium.orga872e752015-04-28 23:42:18 +00001795 self.mock(git_cl, 'IsGitVersionAtLeast', lambda *args: True)
1796
tandriidf09a462016-08-18 16:23:55 -07001797 if new_branch:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001798 self.calls = [((['git', 'new-branch', 'master'],), '')]
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001799
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001800 if codereview_in_url and actual_codereview == 'rietveld':
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001801 self.calls += [
1802 ((['git', 'rev-parse', '--show-cdup'],), ''),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001803 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001804 ]
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001805
1806 if not force_codereview and not codereview_in_url:
1807 # These calls detect codereview to use.
1808 self.calls += [
1809 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001810 ]
1811 if detect_gerrit_server:
1812 self.calls += self._get_gerrit_codereview_server_calls(
1813 'master', git_short_host=git_short_host,
1814 detect_branch=not new_branch and force_codereview)
1815 actual_codereview = 'gerrit'
1816
1817 if actual_codereview == 'gerrit':
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001818 self.calls += [
1819 (('GetChangeDetail', git_short_host + '-review.googlesource.com',
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001820 'my%2Frepo~123456', ['ALL_REVISIONS', 'CURRENT_COMMIT']),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001821 {
1822 'current_revision': '7777777777',
1823 'revisions': {
1824 '1111111111': {
1825 '_number': 1,
1826 'fetch': {'http': {
1827 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1828 'ref': 'refs/changes/56/123456/1',
1829 }},
1830 },
1831 '7777777777': {
1832 '_number': 7,
1833 'fetch': {'http': {
1834 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1835 'ref': 'refs/changes/56/123456/7',
1836 }},
1837 },
1838 },
1839 }),
1840 ]
wychen@chromium.orga872e752015-04-28 23:42:18 +00001841
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001842 def test_patch_gerrit_default(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001843 self._patch_common(git_short_host='chromium', detect_gerrit_server=True)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001844 self.calls += [
1845 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1846 'refs/changes/56/123456/7'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001847 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001848 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
Aaron Gable697a91b2018-01-19 15:20:15 -08001849 ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001850 ((['git', 'config', 'branch.master.gerritserver',
1851 'https://chromium-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001852 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001853 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1854 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1855 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001856 ]
1857 self.assertEqual(git_cl.main(['patch', '123456']), 0)
1858
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001859 def test_patch_gerrit_new_branch(self):
1860 self._patch_common(
1861 git_short_host='chromium', detect_gerrit_server=True, new_branch=True)
1862 self.calls += [
1863 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1864 'refs/changes/56/123456/7'],), ''),
1865 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
1866 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
1867 ''),
1868 ((['git', 'config', 'branch.master.gerritserver',
1869 'https://chromium-review.googlesource.com'],), ''),
1870 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
1871 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1872 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1873 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
1874 ]
1875 self.assertEqual(git_cl.main(['patch', '-b', 'master', '123456']), 0)
1876
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001877 def test_patch_gerrit_force(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001878 self._patch_common(
1879 force_codereview=True, git_short_host='host', detect_gerrit_server=True)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001880 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001881 ((['git', 'fetch', 'https://host.googlesource.com/my/repo',
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001882 'refs/changes/56/123456/7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001883 ((['git', 'reset', '--hard', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001884 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001885 ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001886 ((['git', 'config', 'branch.master.gerritserver',
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001887 'https://host-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001888 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001889 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1890 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1891 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001892 ]
Aaron Gable62619a32017-06-16 08:22:09 -07001893 self.assertEqual(git_cl.main(['patch', '--gerrit', '123456', '--force']), 0)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001894
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001895 def test_patch_gerrit_guess_by_url(self):
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001896 self.calls += self._get_gerrit_codereview_server_calls(
1897 'master', git_short_host='else', detect_server=False)
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001898 self._patch_common(
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001899 actual_codereview='gerrit', git_short_host='else',
1900 codereview_in_url=True, detect_gerrit_server=False)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001901 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001902 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001903 'refs/changes/56/123456/1'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001904 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001905 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001906 ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001907 ((['git', 'config', 'branch.master.gerritserver',
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001908 'https://else-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001909 ((['git', 'config', 'branch.master.gerritpatchset', '1'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001910 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1911 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1912 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001913 ]
1914 self.assertEqual(git_cl.main(
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001915 ['patch', 'https://else-review.googlesource.com/#/c/123456/1']), 0)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001916
Aaron Gable697a91b2018-01-19 15:20:15 -08001917 def test_patch_gerrit_guess_by_url_with_repo(self):
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001918 self.calls += self._get_gerrit_codereview_server_calls(
1919 'master', git_short_host='else', detect_server=False)
Aaron Gable697a91b2018-01-19 15:20:15 -08001920 self._patch_common(
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001921 actual_codereview='gerrit', git_short_host='else',
1922 codereview_in_url=True, detect_gerrit_server=False)
Aaron Gable697a91b2018-01-19 15:20:15 -08001923 self.calls += [
1924 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
1925 'refs/changes/56/123456/1'],), ''),
1926 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
1927 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
1928 ''),
1929 ((['git', 'config', 'branch.master.gerritserver',
1930 'https://else-review.googlesource.com'],), ''),
1931 ((['git', 'config', 'branch.master.gerritpatchset', '1'],), ''),
1932 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1933 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1934 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
1935 ]
1936 self.assertEqual(git_cl.main(
1937 ['patch', 'https://else-review.googlesource.com/c/my/repo/+/123456/1']),
1938 0)
1939
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001940 def test_patch_gerrit_conflict(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001941 self._patch_common(detect_gerrit_server=True, git_short_host='chromium')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001942 self.calls += [
1943 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001944 'refs/changes/56/123456/7'],), ''),
tandrii5d48c322016-08-18 16:19:37 -07001945 ((['git', 'cherry-pick', 'FETCH_HEAD'],), CERR1),
1946 ((['DieWithError', 'Command "git cherry-pick FETCH_HEAD" failed.\n'],),
1947 SystemExitMock()),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001948 ]
1949 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001950 git_cl.main(['patch', '123456'])
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001951
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001952 def test_patch_gerrit_not_exists(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001953
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001954 def notExists(_issue, *_, **kwargs):
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001955 raise git_cl.gerrit_util.GerritError(404, '')
1956 self.mock(git_cl.gerrit_util, 'GetChangeDetail', notExists)
1957
tandriic2405f52016-10-10 08:13:15 -07001958 self.calls = [
1959 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001960 ((['git', 'config', 'branch.master.gerritserver'],), CERR1),
1961 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
1962 ((['git', 'config', 'branch.master.remote'],), 'origin'),
1963 ((['git', 'config', 'remote.origin.url'],),
1964 'https://chromium.googlesource.com/my/repo'),
1965 ((['DieWithError',
1966 'change 123456 at https://chromium-review.googlesource.com does not '
1967 'exist or you have no access to it'],), SystemExitMock()),
tandriic2405f52016-10-10 08:13:15 -07001968 ]
1969 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001970 self.assertEqual(1, git_cl.main(['patch', '123456']))
tandriic2405f52016-10-10 08:13:15 -07001971
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001972 def _checkout_calls(self):
1973 return [
1974 ((['git', 'config', '--local', '--get-regexp',
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001975 'branch\\..*\\.gerritissue'], ),
1976 ('branch.ger-branch.gerritissue 123456\n'
1977 'branch.gbranch654.gerritissue 654321\n')),
1978 ]
1979
1980 def test_checkout_gerrit(self):
1981 """Tests git cl checkout <issue>."""
1982 self.calls = self._checkout_calls()
1983 self.calls += [((['git', 'checkout', 'ger-branch'], ), '')]
1984 self.assertEqual(0, git_cl.main(['checkout', '123456']))
1985
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001986 def test_checkout_not_found(self):
1987 """Tests git cl checkout <issue>."""
Edward Lemur79d4f992019-11-11 23:49:02 +00001988 self.mock(git_cl.sys, 'stdout', StringIO())
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001989 self.calls = self._checkout_calls()
1990 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1991
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001992 def test_checkout_no_branch_issues(self):
1993 """Tests git cl checkout <issue>."""
Edward Lemur79d4f992019-11-11 23:49:02 +00001994 self.mock(git_cl.sys, 'stdout', StringIO())
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001995 self.calls = [
1996 ((['git', 'config', '--local', '--get-regexp',
tandrii5d48c322016-08-18 16:19:37 -07001997 'branch\\..*\\.gerritissue'], ), CERR1),
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001998 ]
1999 self.assertEqual(1, git_cl.main(['checkout', '99999']))
2000
tandrii@chromium.org28253532016-04-14 13:46:56 +00002001 def _test_gerrit_ensure_authenticated_common(self, auth,
2002 skip_auth_check=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002003 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
2004 CookiesAuthenticatorMockFactory(hosts_with_creds=auth))
2005 self.mock(git_cl, 'DieWithError',
Christopher Lamf732cd52017-01-24 12:40:11 +11002006 lambda msg, change=None: self._mocked_call(['DieWithError', msg]))
tandrii@chromium.org28253532016-04-14 13:46:56 +00002007 self.calls = self._gerrit_ensure_auth_calls(skip_auth_check=skip_auth_check)
Edward Lemurf38bc172019-09-03 21:02:13 +00002008 cl = git_cl.Changelist()
tandrii@chromium.org28253532016-04-14 13:46:56 +00002009 cl.branch = 'master'
2010 cl.branchref = 'refs/heads/master'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002011 return cl
2012
2013 def test_gerrit_ensure_authenticated_missing(self):
2014 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002015 'chromium.googlesource.com': ('git-is.ok', '', 'but gerrit is missing'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002016 })
2017 self.calls.append(
2018 ((['DieWithError',
2019 'Credentials for the following hosts are required:\n'
2020 ' chromium-review.googlesource.com\n'
2021 'These are read from ~/.gitcookies (or legacy ~/.netrc)\n'
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01002022 'You can (re)generate your credentials by visiting '
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002023 'https://chromium-review.googlesource.com/new-password'],), ''),)
2024 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2025
2026 def test_gerrit_ensure_authenticated_conflict(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00002027 self.mock(git_cl.sys, 'stdout', StringIO())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002028 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002029 'chromium.googlesource.com':
2030 ('git-one.example.com', None, 'secret1'),
2031 'chromium-review.googlesource.com':
2032 ('git-other.example.com', None, 'secret2'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002033 })
2034 self.calls.append(
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002035 (('ask_for_data', 'If you know what you are doing '
2036 'press Enter to continue, or Ctrl+C to abort'), ''))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002037 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2038
2039 def test_gerrit_ensure_authenticated_ok(self):
2040 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002041 'chromium.googlesource.com':
2042 ('git-same.example.com', None, 'secret'),
2043 'chromium-review.googlesource.com':
2044 ('git-same.example.com', None, 'secret'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002045 })
2046 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2047
tandrii@chromium.org28253532016-04-14 13:46:56 +00002048 def test_gerrit_ensure_authenticated_skipped(self):
2049 cl = self._test_gerrit_ensure_authenticated_common(
2050 auth={}, skip_auth_check=True)
2051 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2052
Eric Boren2fb63102018-10-05 13:05:03 +00002053 def test_gerrit_ensure_authenticated_bearer_token(self):
2054 cl = self._test_gerrit_ensure_authenticated_common(auth={
2055 'chromium.googlesource.com':
2056 ('', None, 'secret'),
2057 'chromium-review.googlesource.com':
2058 ('', None, 'secret'),
2059 })
2060 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2061 header = gerrit_util.CookiesAuthenticator().get_auth_header(
2062 'chromium.googlesource.com')
2063 self.assertTrue('Bearer' in header)
2064
Daniel Chengcf6269b2019-05-18 01:02:12 +00002065 def test_gerrit_ensure_authenticated_non_https(self):
2066 self.calls = [
2067 ((['git', 'config', '--bool',
2068 'gerrit.skip-ensure-authenticated'],), CERR1),
2069 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
2070 ((['git', 'config', 'branch.master.remote'],), 'origin'),
2071 ((['git', 'config', 'remote.origin.url'],), 'custom-scheme://repo'),
2072 ]
2073 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
2074 CookiesAuthenticatorMockFactory(hosts_with_creds={}))
Edward Lemurf38bc172019-09-03 21:02:13 +00002075 cl = git_cl.Changelist()
Daniel Chengcf6269b2019-05-18 01:02:12 +00002076 cl.branch = 'master'
2077 cl.branchref = 'refs/heads/master'
2078 cl.lookedup_issue = True
2079 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2080
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002081 def _cmd_set_commit_gerrit_common(self, vote, notify=None):
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002082 self.mock(git_cl.gerrit_util, 'SetReview',
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002083 lambda h, i, labels, notify=None:
2084 self._mocked_call(['SetReview', h, i, labels, notify]))
2085
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002086 self.calls = [
2087 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002088 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002089 ((['git', 'config', 'branch.feature.gerritserver'],),
2090 'https://chromium-review.googlesource.com'),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002091 ((['git', 'config', 'branch.feature.merge'],), 'refs/heads/master'),
2092 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2093 ((['git', 'config', 'remote.origin.url'],),
2094 'https://chromium.googlesource.com/infra/infra.git'),
2095 ((['SetReview', 'chromium-review.googlesource.com',
2096 'infra%2Finfra~123',
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002097 {'Commit-Queue': vote}, notify],), ''),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002098 ]
tandriid9e5ce52016-07-13 02:32:59 -07002099
2100 def test_cmd_set_commit_gerrit_clear(self):
2101 self._cmd_set_commit_gerrit_common(0)
2102 self.assertEqual(0, git_cl.main(['set-commit', '-c']))
2103
2104 def test_cmd_set_commit_gerrit_dry(self):
Aaron Gable75e78722017-06-09 10:40:16 -07002105 self._cmd_set_commit_gerrit_common(1, notify=False)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002106 self.assertEqual(0, git_cl.main(['set-commit', '-d']))
2107
tandriid9e5ce52016-07-13 02:32:59 -07002108 def test_cmd_set_commit_gerrit(self):
2109 self._cmd_set_commit_gerrit_common(2)
2110 self.assertEqual(0, git_cl.main(['set-commit']))
2111
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002112 def test_description_display(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00002113 out = StringIO()
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002114 self.mock(git_cl.sys, 'stdout', out)
2115
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002116 self.mock(git_cl, 'Changelist', ChangelistMock)
2117 ChangelistMock.desc = 'foo\n'
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002118
2119 self.assertEqual(0, git_cl.main(['description', '-d']))
2120 self.assertEqual('foo\n', out.getvalue())
2121
iannucci3c972b92016-08-17 13:24:10 -07002122 def test_StatusFieldOverrideIssueMissingArgs(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00002123 out = StringIO()
iannucci3c972b92016-08-17 13:24:10 -07002124 self.mock(git_cl.sys, 'stderr', out)
2125
2126 try:
2127 self.assertEqual(git_cl.main(['status', '--issue', '1']), 0)
2128 except SystemExit as ex:
2129 self.assertEqual(ex.code, 2)
Edward Lemurf38bc172019-09-03 21:02:13 +00002130 self.assertRegexpMatches(out.getvalue(), r'--field must be specified')
iannucci3c972b92016-08-17 13:24:10 -07002131
Edward Lemur79d4f992019-11-11 23:49:02 +00002132 out = StringIO()
iannucci3c972b92016-08-17 13:24:10 -07002133 self.mock(git_cl.sys, 'stderr', out)
2134
2135 try:
Andrii Shyshkalovfeec80e2018-10-16 01:00:47 +00002136 self.assertEqual(git_cl.main(['status', '--issue', '1', '--gerrit']), 0)
iannucci3c972b92016-08-17 13:24:10 -07002137 except SystemExit as ex:
2138 self.assertEqual(ex.code, 2)
iannuccie53c9352016-08-17 14:40:40 -07002139 self.assertRegexpMatches(out.getvalue(), r'--field must be specified')
iannucci3c972b92016-08-17 13:24:10 -07002140
2141 def test_StatusFieldOverrideIssue(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00002142 out = StringIO()
iannucci3c972b92016-08-17 13:24:10 -07002143 self.mock(git_cl.sys, 'stdout', out)
2144
2145 def assertIssue(cl_self, *_args):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002146 self.assertEqual(cl_self.issue, 1)
iannucci3c972b92016-08-17 13:24:10 -07002147 return 'foobar'
2148
2149 self.mock(git_cl.Changelist, 'GetDescription', assertIssue)
iannuccie53c9352016-08-17 14:40:40 -07002150 self.assertEqual(
Andrii Shyshkalovfeec80e2018-10-16 01:00:47 +00002151 git_cl.main(['status', '--issue', '1', '--gerrit', '--field', 'desc']),
iannuccie53c9352016-08-17 14:40:40 -07002152 0)
iannucci3c972b92016-08-17 13:24:10 -07002153 self.assertEqual(out.getvalue(), 'foobar\n')
2154
iannuccie53c9352016-08-17 14:40:40 -07002155 def test_SetCloseOverrideIssue(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002156
iannuccie53c9352016-08-17 14:40:40 -07002157 def assertIssue(cl_self, *_args):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002158 self.assertEqual(cl_self.issue, 1)
iannuccie53c9352016-08-17 14:40:40 -07002159 return 'foobar'
2160
2161 self.mock(git_cl.Changelist, 'GetDescription', assertIssue)
2162 self.mock(git_cl.Changelist, 'CloseIssue', lambda *_: None)
iannuccie53c9352016-08-17 14:40:40 -07002163 self.assertEqual(
Andrii Shyshkalovfeec80e2018-10-16 01:00:47 +00002164 git_cl.main(['set-close', '--issue', '1', '--gerrit']), 0)
iannuccie53c9352016-08-17 14:40:40 -07002165
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002166 def test_description(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00002167 out = StringIO()
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002168 self.mock(git_cl.sys, 'stdout', out)
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01002169 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002170 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2171 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2172 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2173 ((['git', 'config', 'remote.origin.url'],),
2174 'https://chromium.googlesource.com/my/repo'),
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002175 (('GetChangeDetail', 'chromium-review.googlesource.com',
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002176 'my%2Frepo~123123', ['CURRENT_REVISION', 'CURRENT_COMMIT']),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01002177 {
2178 'current_revision': 'sha1',
2179 'revisions': {'sha1': {
2180 'commit': {'message': 'foobar'},
2181 }},
2182 }),
2183 ]
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002184 self.assertEqual(0, git_cl.main([
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002185 'description',
2186 'https://chromium-review.googlesource.com/c/my/repo/+/123123',
2187 '-d']))
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002188 self.assertEqual('foobar\n', out.getvalue())
2189
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002190 def test_description_set_raw(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00002191 out = StringIO()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002192 self.mock(git_cl.sys, 'stdout', out)
2193
2194 self.mock(git_cl, 'Changelist', ChangelistMock)
Edward Lemur79d4f992019-11-11 23:49:02 +00002195 self.mock(git_cl.sys, 'stdin', StringIO('hihi'))
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002196
2197 self.assertEqual(0, git_cl.main(['description', '-n', 'hihi']))
2198 self.assertEqual('hihi', ChangelistMock.desc)
2199
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002200 def test_description_appends_bug_line(self):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002201 current_desc = 'Some.\n\nChange-Id: xxx'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002202
2203 def RunEditor(desc, _, **kwargs):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002204 self.assertEqual(
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002205 '# Enter a description of the change.\n'
2206 '# This will be displayed on the codereview site.\n'
2207 '# The first line will also be used as the subject of the review.\n'
2208 '#--------------------This line is 72 characters long'
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002209 '--------------------\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -07002210 'Some.\n\nChange-Id: xxx\nBug: ',
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002211 desc)
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002212 # Simulate user changing something.
Aaron Gable3a16ed12017-03-23 10:51:55 -07002213 return 'Some.\n\nChange-Id: xxx\nBug: 123'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002214
dsansomee2d6fd92016-09-08 00:10:47 -07002215 def UpdateDescriptionRemote(_, desc, force=False):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002216 self.assertEqual(desc, 'Some.\n\nChange-Id: xxx\nBug: 123')
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002217
Edward Lemur79d4f992019-11-11 23:49:02 +00002218 self.mock(git_cl.sys, 'stdout', StringIO())
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002219 self.mock(git_cl.Changelist, 'GetDescription',
2220 lambda *args: current_desc)
Edward Lemur125d60a2019-09-13 18:25:41 +00002221 self.mock(git_cl.Changelist, 'UpdateDescriptionRemote',
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002222 UpdateDescriptionRemote)
2223 self.mock(git_cl.gclient_utils, 'RunEditor', RunEditor)
2224
2225 self.calls = [
2226 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002227 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii5d48c322016-08-18 16:19:37 -07002228 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2229 ((['git', 'config', 'rietveld.bug-prefix'],), CERR1),
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002230 ((['git', 'config', 'core.editor'],), 'vi'),
2231 ]
2232 self.assertEqual(0, git_cl.main(['description', '--gerrit']))
2233
Dan Beamd8b04ca2019-10-10 21:23:26 +00002234 def test_description_does_not_append_bug_line_if_fixed_is_present(self):
2235 current_desc = 'Some.\n\nFixed: 123\nChange-Id: xxx'
2236
2237 def RunEditor(desc, _, **kwargs):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002238 self.assertEqual(
Dan Beamd8b04ca2019-10-10 21:23:26 +00002239 '# Enter a description of the change.\n'
2240 '# This will be displayed on the codereview site.\n'
2241 '# The first line will also be used as the subject of the review.\n'
2242 '#--------------------This line is 72 characters long'
2243 '--------------------\n'
2244 'Some.\n\nFixed: 123\nChange-Id: xxx',
2245 desc)
2246 return desc
2247
Edward Lemur79d4f992019-11-11 23:49:02 +00002248 self.mock(git_cl.sys, 'stdout', StringIO())
Dan Beamd8b04ca2019-10-10 21:23:26 +00002249 self.mock(git_cl.Changelist, 'GetDescription',
2250 lambda *args: current_desc)
2251 self.mock(git_cl.gclient_utils, 'RunEditor', RunEditor)
2252
2253 self.calls = [
2254 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2255 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
2256 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2257 ((['git', 'config', 'rietveld.bug-prefix'],), CERR1),
2258 ((['git', 'config', 'core.editor'],), 'vi'),
2259 ]
2260 self.assertEqual(0, git_cl.main(['description', '--gerrit']))
2261
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002262 def test_description_set_stdin(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00002263 out = StringIO()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002264 self.mock(git_cl.sys, 'stdout', out)
2265
2266 self.mock(git_cl, 'Changelist', ChangelistMock)
Edward Lemur79d4f992019-11-11 23:49:02 +00002267 self.mock(git_cl.sys, 'stdin', StringIO('hi \r\n\t there\n\nman'))
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002268
2269 self.assertEqual(0, git_cl.main(['description', '-n', '-']))
2270 self.assertEqual('hi\n\t there\n\nman', ChangelistMock.desc)
2271
kmarshall3bff56b2016-06-06 18:31:47 -07002272 def test_archive(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00002273 self.mock(git_cl.sys, 'stdout', StringIO())
tandrii1c67da62016-06-10 07:35:53 -07002274
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002275 self.calls = [
2276 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
Edward Lemurf38bc172019-09-03 21:02:13 +00002277 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002278 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002279 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2280 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],), ''),
Edward Lemurf38bc172019-09-03 21:02:13 +00002281 ((['git', 'branch', '-D', 'foo'],), '')
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002282 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002283
kmarshall3bff56b2016-06-06 18:31:47 -07002284 self.mock(git_cl, 'get_cl_statuses',
2285 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002286 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2287 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2288 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
kmarshall3bff56b2016-06-06 18:31:47 -07002289
2290 self.assertEqual(0, git_cl.main(['archive', '-f']))
2291
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002292 def test_archive_tag_collision(self):
2293 self.mock(git_cl.sys, 'stdout', StringIO())
2294
2295 self.calls = [
2296 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2297 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2298 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],),
2299 'refs/tags/git-cl-archived-456-foo'),
2300 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2301 ((['git', 'tag', 'git-cl-archived-456-foo-2', 'foo'],), ''),
2302 ((['git', 'branch', '-D', 'foo'],), '')
2303 ]
2304
2305 self.mock(git_cl, 'get_cl_statuses',
2306 lambda branches, fine_grained, max_processes:
2307 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2308 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2309 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
2310
2311 self.assertEqual(0, git_cl.main(['archive', '-f']))
2312
kmarshall3bff56b2016-06-06 18:31:47 -07002313 def test_archive_current_branch_fails(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00002314 self.mock(git_cl.sys, 'stdout', StringIO())
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002315 self.calls = [
2316 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2317 'refs/heads/master'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002318 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002319 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2320 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002321
kmarshall9249e012016-08-23 12:02:16 -07002322 self.mock(git_cl, 'get_cl_statuses',
2323 lambda branches, fine_grained, max_processes:
2324 [(MockChangelistWithBranchAndIssue('master', 1), 'closed')])
2325
2326 self.assertEqual(1, git_cl.main(['archive', '-f']))
2327
2328 def test_archive_dry_run(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00002329 self.mock(git_cl.sys, 'stdout', StringIO())
kmarshall9249e012016-08-23 12:02:16 -07002330
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002331 self.calls = [
2332 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2333 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002334 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002335 ((['git', 'symbolic-ref', 'HEAD'],), 'master')
2336 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002337
2338 self.mock(git_cl, 'get_cl_statuses',
2339 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002340 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2341 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2342 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
kmarshall3bff56b2016-06-06 18:31:47 -07002343
kmarshall9249e012016-08-23 12:02:16 -07002344 self.assertEqual(0, git_cl.main(['archive', '-f', '--dry-run']))
2345
2346 def test_archive_no_tags(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00002347 self.mock(git_cl.sys, 'stdout', StringIO())
kmarshall9249e012016-08-23 12:02:16 -07002348
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002349 self.calls = [
2350 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2351 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002352 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002353 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2354 ((['git', 'branch', '-D', 'foo'],), '')
2355 ]
kmarshall9249e012016-08-23 12:02:16 -07002356
2357 self.mock(git_cl, 'get_cl_statuses',
2358 lambda branches, fine_grained, max_processes:
2359 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2360 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2361 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
2362
2363 self.assertEqual(0, git_cl.main(['archive', '-f', '--notags']))
kmarshall3bff56b2016-06-06 18:31:47 -07002364
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002365 def test_archive_tag_cleanup_on_branch_deletion_error(self):
2366 self.mock(git_cl.sys, 'stdout', StringIO())
2367
2368 self.calls = [
2369 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2370 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2371 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
2372 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2373 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],),
2374 'refs/tags/git-cl-archived-456-foo'),
2375 ((['git', 'branch', '-D', 'foo'],), CERR1),
2376 ((['git', 'tag', '-d', 'git-cl-archived-456-foo'],),
2377 'refs/tags/git-cl-archived-456-foo'),
2378 ]
2379
2380 self.mock(git_cl, 'get_cl_statuses',
2381 lambda branches, fine_grained, max_processes:
2382 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2383 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2384 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
2385
2386 self.assertEqual(0, git_cl.main(['archive', '-f']))
2387
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002388 def test_cmd_issue_erase_existing(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00002389 out = StringIO()
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002390 self.mock(git_cl.sys, 'stdout', out)
2391 self.calls = [
2392 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002393 # Let this command raise exception (retcode=1) - it should be ignored.
2394 ((['git', 'config', '--unset', 'branch.feature.last-upload-hash'],),
tandrii5d48c322016-08-18 16:19:37 -07002395 CERR1),
2396 ((['git', 'config', '--unset', 'branch.feature.gerritissue'],), ''),
2397 ((['git', 'config', '--unset', 'branch.feature.gerritpatchset'],), ''),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002398 ((['git', 'config', '--unset', 'branch.feature.gerritserver'],), ''),
2399 ((['git', 'config', '--unset', 'branch.feature.gerritsquashhash'],),
2400 ''),
Aaron Gableca01e2c2017-07-19 11:16:02 -07002401 ((['git', 'log', '-1', '--format=%B'],), 'This is a description'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002402 ]
2403 self.assertEqual(0, git_cl.main(['issue', '0']))
2404
Aaron Gable400e9892017-07-12 15:31:21 -07002405 def test_cmd_issue_erase_existing_with_change_id(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00002406 out = StringIO()
Aaron Gable400e9892017-07-12 15:31:21 -07002407 self.mock(git_cl.sys, 'stdout', out)
2408 self.mock(git_cl.Changelist, 'GetDescription',
2409 lambda _: 'This is a description\n\nChange-Id: Ideadbeef')
2410 self.calls = [
2411 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
Aaron Gable400e9892017-07-12 15:31:21 -07002412 # Let this command raise exception (retcode=1) - it should be ignored.
2413 ((['git', 'config', '--unset', 'branch.feature.last-upload-hash'],),
2414 CERR1),
2415 ((['git', 'config', '--unset', 'branch.feature.gerritissue'],), ''),
2416 ((['git', 'config', '--unset', 'branch.feature.gerritpatchset'],), ''),
2417 ((['git', 'config', '--unset', 'branch.feature.gerritserver'],), ''),
2418 ((['git', 'config', '--unset', 'branch.feature.gerritsquashhash'],),
2419 ''),
Aaron Gableca01e2c2017-07-19 11:16:02 -07002420 ((['git', 'log', '-1', '--format=%B'],),
2421 'This is a description\n\nChange-Id: Ideadbeef'),
2422 ((['git', 'commit', '--amend', '-m', 'This is a description\n'],), ''),
Aaron Gable400e9892017-07-12 15:31:21 -07002423 ]
2424 self.assertEqual(0, git_cl.main(['issue', '0']))
2425
phajdan.jre328cf92016-08-22 04:12:17 -07002426 def test_cmd_issue_json(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00002427 out = StringIO()
phajdan.jre328cf92016-08-22 04:12:17 -07002428 self.mock(git_cl.sys, 'stdout', out)
2429 self.calls = [
2430 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002431 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
2432 ((['git', 'config', 'branch.feature.gerritserver'],),
2433 'https://chromium-review.googlesource.com'),
phajdan.jre328cf92016-08-22 04:12:17 -07002434 (('write_json', 'output.json',
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002435 {'issue': 123,
2436 'issue_url': 'https://chromium-review.googlesource.com/123'}),
phajdan.jre328cf92016-08-22 04:12:17 -07002437 ''),
2438 ]
2439 self.assertEqual(0, git_cl.main(['issue', '--json', 'output.json']))
2440
tandrii16e0b4e2016-06-07 10:34:28 -07002441 def _common_GerritCommitMsgHookCheck(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00002442 self.mock(git_cl.sys, 'stdout', StringIO())
tandrii16e0b4e2016-06-07 10:34:28 -07002443 self.mock(git_cl.os.path, 'abspath',
2444 lambda path: self._mocked_call(['abspath', path]))
2445 self.mock(git_cl.os.path, 'exists',
2446 lambda path: self._mocked_call(['exists', path]))
2447 self.mock(git_cl.gclient_utils, 'FileRead',
2448 lambda path: self._mocked_call(['FileRead', path]))
2449 self.mock(git_cl.gclient_utils, 'rm_file_or_tree',
2450 lambda path: self._mocked_call(['rm_file_or_tree', path]))
2451 self.calls = [
2452 ((['git', 'rev-parse', '--show-cdup'],), '../'),
2453 ((['abspath', '../'],), '/abs/git_repo_root'),
2454 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002455 return git_cl.Changelist(issue=123)
tandrii16e0b4e2016-06-07 10:34:28 -07002456
2457 def test_GerritCommitMsgHookCheck_custom_hook(self):
2458 cl = self._common_GerritCommitMsgHookCheck()
2459 self.calls += [
2460 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), True),
2461 ((['FileRead', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2462 '#!/bin/sh\necho "custom hook"')
2463 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002464 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002465
2466 def test_GerritCommitMsgHookCheck_not_exists(self):
2467 cl = self._common_GerritCommitMsgHookCheck()
2468 self.calls += [
2469 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), False),
2470 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002471 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002472
2473 def test_GerritCommitMsgHookCheck(self):
2474 cl = self._common_GerritCommitMsgHookCheck()
2475 self.calls += [
2476 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), True),
2477 ((['FileRead', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2478 '...\n# From Gerrit Code Review\n...\nadd_ChangeId()\n'),
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002479 (('ask_for_data', 'Do you want to remove it now? [Yes/No]: '), 'Yes'),
tandrii16e0b4e2016-06-07 10:34:28 -07002480 ((['rm_file_or_tree', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2481 ''),
2482 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002483 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002484
tandriic4344b52016-08-29 06:04:54 -07002485 def test_GerritCmdLand(self):
2486 self.calls += [
2487 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2488 ((['git', 'config', 'branch.feature.gerritsquashhash'],),
2489 'deadbeaf'),
2490 ((['git', 'diff', 'deadbeaf'],), ''), # No diff.
2491 ((['git', 'config', 'branch.feature.gerritserver'],),
2492 'chromium-review.googlesource.com'),
2493 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002494 cl = git_cl.Changelist(issue=123)
Edward Lemur125d60a2019-09-13 18:25:41 +00002495 cl._GetChangeDetail = lambda *args, **kwargs: {
tandriic4344b52016-08-29 06:04:54 -07002496 'labels': {},
2497 'current_revision': 'deadbeaf',
2498 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002499 cl._GetChangeCommit = lambda: {
agable32978d92016-11-01 12:55:02 -07002500 'commit': 'deadbeef',
Aaron Gable02cdbb42016-12-13 16:24:25 -08002501 'web_links': [{'name': 'gitiles',
agable32978d92016-11-01 12:55:02 -07002502 'url': 'https://git.googlesource.com/test/+/deadbeef'}],
2503 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002504 cl.SubmitIssue = lambda wait_for_merge: None
Edward Lemur79d4f992019-11-11 23:49:02 +00002505 out = StringIO()
tandrii8da412c2016-09-07 16:01:07 -07002506 self.mock(sys, 'stdout', out)
Olivier Robin75ee7252018-04-13 10:02:56 +02002507 self.assertEqual(0, cl.CMDLand(force=True,
2508 bypass_hooks=True,
2509 verbose=True,
2510 parallel=False))
tandrii8da412c2016-09-07 16:01:07 -07002511 self.assertRegexpMatches(out.getvalue(), 'Issue.*123 has been submitted')
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002512 self.assertRegexpMatches(out.getvalue(), 'Landed as: .*deadbeef')
tandriic4344b52016-08-29 06:04:54 -07002513
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002514 def _mock_gerrit_changes_for_detail_cache(self):
Edward Lemur125d60a2019-09-13 18:25:41 +00002515 self.mock(git_cl.Changelist, '_GetGerritHost', lambda _: 'host')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002516
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002517 def test_gerrit_change_detail_cache_simple(self):
2518 self._mock_gerrit_changes_for_detail_cache()
2519 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002520 (('GetChangeDetail', 'host', 'my%2Frepo~1', []), 'a'),
2521 (('GetChangeDetail', 'host', 'ab%2Frepo~2', []), 'b'),
2522 (('GetChangeDetail', 'host', 'ab%2Frepo~2', []), 'b2'),
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002523 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002524 cl1 = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002525 cl1._cached_remote_url = (
2526 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemurf38bc172019-09-03 21:02:13 +00002527 cl2 = git_cl.Changelist(issue=2)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002528 cl2._cached_remote_url = (
2529 True, 'https://chromium.googlesource.com/ab/repo')
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002530 self.assertEqual(cl1._GetChangeDetail(), 'a') # Miss.
2531 self.assertEqual(cl1._GetChangeDetail(), 'a')
2532 self.assertEqual(cl2._GetChangeDetail(), 'b') # Miss.
2533 self.assertEqual(cl2._GetChangeDetail(no_cache=True), 'b2') # Miss.
2534 self.assertEqual(cl1._GetChangeDetail(), 'a')
2535 self.assertEqual(cl2._GetChangeDetail(), 'b2')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002536
2537 def test_gerrit_change_detail_cache_options(self):
2538 self._mock_gerrit_changes_for_detail_cache()
2539 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002540 (('GetChangeDetail', 'host', 'repo~1', ['C', 'A', 'B']), 'cab'),
2541 (('GetChangeDetail', 'host', 'repo~1', ['A', 'D']), 'ad'),
2542 (('GetChangeDetail', 'host', 'repo~1', ['A']), 'a'), # no_cache=True
2543 # no longer in cache.
2544 (('GetChangeDetail', 'host', 'repo~1', ['B']), 'b'),
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002545 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002546 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002547 cl._cached_remote_url = (True, 'https://chromium.googlesource.com/repo/')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002548 self.assertEqual(cl._GetChangeDetail(options=['C', 'A', 'B']), 'cab')
2549 self.assertEqual(cl._GetChangeDetail(options=['A', 'B', 'C']), 'cab')
2550 self.assertEqual(cl._GetChangeDetail(options=['B', 'A']), 'cab')
2551 self.assertEqual(cl._GetChangeDetail(options=['C']), 'cab')
2552 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2553 self.assertEqual(cl._GetChangeDetail(), 'cab')
2554
2555 self.assertEqual(cl._GetChangeDetail(options=['A', 'D']), 'ad')
2556 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2557 self.assertEqual(cl._GetChangeDetail(options=['D']), 'ad')
2558 self.assertEqual(cl._GetChangeDetail(), 'cab')
2559
2560 # Finally, no_cache should invalidate all caches for given change.
2561 self.assertEqual(cl._GetChangeDetail(options=['A'], no_cache=True), 'a')
2562 self.assertEqual(cl._GetChangeDetail(options=['B']), 'b')
2563
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002564 def test_gerrit_description_caching(self):
2565 def gen_detail(rev, desc):
2566 return {
2567 'current_revision': rev,
2568 'revisions': {rev: {'commit': {'message': desc}}}
2569 }
2570 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002571 (('GetChangeDetail', 'host', 'my%2Frepo~1',
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002572 ['CURRENT_REVISION', 'CURRENT_COMMIT']),
2573 gen_detail('rev1', 'desc1')),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002574 (('GetChangeDetail', 'host', 'my%2Frepo~1',
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002575 ['CURRENT_REVISION', 'CURRENT_COMMIT']),
2576 gen_detail('rev2', 'desc2')),
2577 ]
2578
2579 self._mock_gerrit_changes_for_detail_cache()
Edward Lemurf38bc172019-09-03 21:02:13 +00002580 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002581 cl._cached_remote_url = (
2582 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002583 self.assertEqual(cl.GetDescription(), 'desc1')
2584 self.assertEqual(cl.GetDescription(), 'desc1') # cache hit.
2585 self.assertEqual(cl.GetDescription(force=True), 'desc2')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002586
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002587 def test_print_current_creds(self):
2588 class CookiesAuthenticatorMock(object):
2589 def __init__(self):
2590 self.gitcookies = {
2591 'host.googlesource.com': ('user', 'pass'),
2592 'host-review.googlesource.com': ('user', 'pass'),
2593 }
2594 self.netrc = self
2595 self.netrc.hosts = {
2596 'github.com': ('user2', None, 'pass2'),
2597 'host2.googlesource.com': ('user3', None, 'pass'),
2598 }
2599 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
2600 CookiesAuthenticatorMock)
Edward Lemur79d4f992019-11-11 23:49:02 +00002601 self.mock(sys, 'stdout', StringIO())
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002602 git_cl._GitCookiesChecker().print_current_creds(include_netrc=True)
2603 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2604 ' Host\t User\t Which file',
2605 '============================\t=====\t===========',
2606 'host-review.googlesource.com\t user\t.gitcookies',
2607 ' host.googlesource.com\t user\t.gitcookies',
2608 ' host2.googlesource.com\tuser3\t .netrc',
2609 ])
Edward Lemur79d4f992019-11-11 23:49:02 +00002610 sys.stdout.seek(0)
2611 sys.stdout.truncate(0)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002612 git_cl._GitCookiesChecker().print_current_creds(include_netrc=False)
2613 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2614 ' Host\tUser\t Which file',
2615 '============================\t====\t===========',
2616 'host-review.googlesource.com\tuser\t.gitcookies',
2617 ' host.googlesource.com\tuser\t.gitcookies',
2618 ])
2619
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002620 def _common_creds_check_mocks(self):
2621 def exists_mock(path):
2622 dirname = os.path.dirname(path)
2623 if dirname == os.path.expanduser('~'):
2624 dirname = '~'
2625 base = os.path.basename(path)
2626 if base in ('.netrc', '.gitcookies'):
2627 return self._mocked_call('os.path.exists', '%s/%s' % (dirname, base))
2628 # git cl also checks for existence other files not relevant to this test.
2629 return None
2630 self.mock(os.path, 'exists', exists_mock)
Edward Lemur79d4f992019-11-11 23:49:02 +00002631 self.mock(sys, 'stdout', StringIO())
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002632
2633 def test_creds_check_gitcookies_not_configured(self):
2634 self._common_creds_check_mocks()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002635 self.mock(git_cl._GitCookiesChecker, 'get_hosts_with_creds',
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01002636 lambda _, include_netrc=False: [])
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002637 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08002638 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002639 ((['git', 'config', '--global', 'http.cookiefile'],), CERR1),
2640 (('os.path.exists', '~/.netrc'), True),
2641 (('ask_for_data', 'Press Enter to setup .gitcookies, '
2642 'or Ctrl+C to abort'), ''),
2643 ((['git', 'config', '--global', 'http.cookiefile',
2644 os.path.expanduser('~/.gitcookies')], ), ''),
2645 ]
2646 self.assertEqual(0, git_cl.main(['creds-check']))
2647 self.assertRegexpMatches(
2648 sys.stdout.getvalue(),
2649 '^You seem to be using outdated .netrc for git credentials:')
2650 self.assertRegexpMatches(
2651 sys.stdout.getvalue(),
2652 '\nConfigured git to use .gitcookies from')
2653
2654 def test_creds_check_gitcookies_configured_custom_broken(self):
2655 self._common_creds_check_mocks()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002656 self.mock(git_cl._GitCookiesChecker, 'get_hosts_with_creds',
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01002657 lambda _, include_netrc=False: [])
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002658 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08002659 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002660 ((['git', 'config', '--global', 'http.cookiefile'],),
2661 '/custom/.gitcookies'),
2662 (('os.path.exists', '/custom/.gitcookies'), False),
2663 (('ask_for_data', 'Reconfigure git to use default .gitcookies? '
2664 'Press Enter to reconfigure, or Ctrl+C to abort'), ''),
2665 ((['git', 'config', '--global', 'http.cookiefile',
2666 os.path.expanduser('~/.gitcookies')], ), ''),
2667 ]
2668 self.assertEqual(0, git_cl.main(['creds-check']))
2669 self.assertRegexpMatches(
2670 sys.stdout.getvalue(),
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002671 'WARNING: You have configured custom path to .gitcookies: ')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002672 self.assertRegexpMatches(
2673 sys.stdout.getvalue(),
2674 'However, your configured .gitcookies file is missing.')
2675
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002676 def test_git_cl_comment_add_gerrit(self):
2677 self.mock(git_cl.gerrit_util, 'SetReview',
Aaron Gable636b13f2017-07-14 10:42:48 -07002678 lambda host, change, msg, ready:
2679 self._mocked_call('SetReview', host, change, msg, ready))
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002680 self.calls = [
2681 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
2682 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
2683 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
2684 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
2685 'origin/master'),
2686 ((['git', 'config', 'remote.origin.url'],),
2687 'https://chromium.googlesource.com/infra/infra'),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002688 (('SetReview', 'chromium-review.googlesource.com', 'infra%2Finfra~10',
2689 'msg', None),
Aaron Gable636b13f2017-07-14 10:42:48 -07002690 None),
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002691 ]
2692 self.assertEqual(0, git_cl.main(['comment', '--gerrit', '-i', '10',
2693 '-a', 'msg']))
2694
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002695 def test_git_cl_comments_fetch_gerrit(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00002696 self.mock(sys, 'stdout', StringIO())
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002697 self.calls = [
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002698 ((['git', 'config', 'branch.foo.gerritserver'],), ''),
2699 ((['git', 'config', 'branch.foo.merge'],), ''),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002700 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
2701 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
2702 'origin/master'),
2703 ((['git', 'config', 'remote.origin.url'],),
2704 'https://chromium.googlesource.com/infra/infra'),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002705 (('GetChangeDetail', 'chromium-review.googlesource.com',
2706 'infra%2Finfra~1',
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002707 ['MESSAGES', 'DETAILED_ACCOUNTS', 'CURRENT_REVISION',
2708 'CURRENT_COMMIT']), {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002709 'owner': {'email': 'owner@example.com'},
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002710 'current_revision': 'ba5eba11',
2711 'revisions': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002712 'deadbeaf': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002713 '_number': 1,
2714 },
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002715 'ba5eba11': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002716 '_number': 2,
2717 },
2718 },
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002719 'messages': [
2720 {
2721 u'_revision_number': 1,
2722 u'author': {
2723 u'_account_id': 1111084,
2724 u'email': u'commit-bot@chromium.org',
2725 u'name': u'Commit Bot'
2726 },
2727 u'date': u'2017-03-15 20:08:45.000000000',
2728 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
Dirk Prankef6a58802017-10-17 12:49:42 -07002729 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002730 u'tag': u'autogenerated:cq:dry-run'
2731 },
2732 {
2733 u'_revision_number': 2,
2734 u'author': {
2735 u'_account_id': 11151243,
2736 u'email': u'owner@example.com',
2737 u'name': u'owner'
2738 },
2739 u'date': u'2017-03-16 20:00:41.000000000',
2740 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2741 u'message': u'PTAL',
2742 },
2743 {
2744 u'_revision_number': 2,
2745 u'author': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002746 u'_account_id': 148512,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002747 u'email': u'reviewer@example.com',
2748 u'name': u'reviewer'
2749 },
2750 u'date': u'2017-03-17 05:19:37.500000000',
2751 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2752 u'message': u'Patch Set 2: Code-Review+1',
2753 },
2754 ]
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002755 }),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002756 (('GetChangeComments', 'chromium-review.googlesource.com',
2757 'infra%2Finfra~1'), {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002758 '/COMMIT_MSG': [
2759 {
2760 'author': {'email': u'reviewer@example.com'},
2761 'updated': u'2017-03-17 05:19:37.500000000',
2762 'patch_set': 2,
2763 'side': 'REVISION',
2764 'message': 'Please include a bug link',
2765 },
2766 ],
2767 'codereview.settings': [
2768 {
2769 'author': {'email': u'owner@example.com'},
2770 'updated': u'2017-03-16 20:00:41.000000000',
2771 'patch_set': 2,
2772 'side': 'PARENT',
2773 'line': 42,
2774 'message': 'I removed this because it is bad',
2775 },
2776 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002777 }),
2778 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
2779 'infra%2Finfra~1'), {}),
2780 ((['git', 'config', 'branch.foo.gerritpatchset', '2'],), ''),
Leszek Swirski45b20c42018-09-17 17:05:26 +00002781 ] * 2 + [
2782 (('write_json', 'output.json', [
2783 {
2784 u'date': u'2017-03-16 20:00:41.000000',
2785 u'message': (
2786 u'PTAL\n' +
2787 u'\n' +
2788 u'codereview.settings\n' +
2789 u' Base, Line 42: https://chromium-review.googlesource.com/' +
2790 u'c/1/2/codereview.settings#b42\n' +
2791 u' I removed this because it is bad\n'),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002792 u'autogenerated': False,
Leszek Swirski45b20c42018-09-17 17:05:26 +00002793 u'approval': False,
2794 u'disapproval': False,
2795 u'sender': u'owner@example.com'
2796 }, {
2797 u'date': u'2017-03-17 05:19:37.500000',
2798 u'message': (
2799 u'Patch Set 2: Code-Review+1\n' +
2800 u'\n' +
2801 u'/COMMIT_MSG\n' +
2802 u' PS2, File comment: https://chromium-review.googlesource' +
2803 u'.com/c/1/2//COMMIT_MSG#\n' +
2804 u' Please include a bug link\n'),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002805 u'autogenerated': False,
Leszek Swirski45b20c42018-09-17 17:05:26 +00002806 u'approval': False,
2807 u'disapproval': False,
2808 u'sender': u'reviewer@example.com'
2809 }
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002810 ]), '')
Leszek Swirski45b20c42018-09-17 17:05:26 +00002811 ]
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002812 expected_comments_summary = [
2813 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002814 message=(
2815 u'PTAL\n' +
2816 u'\n' +
2817 u'codereview.settings\n' +
2818 u' Base, Line 42: https://chromium-review.googlesource.com/' +
2819 u'c/1/2/codereview.settings#b42\n' +
2820 u' I removed this because it is bad\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002821 date=datetime.datetime(2017, 3, 16, 20, 0, 41, 0),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002822 autogenerated=False,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002823 disapproval=False, approval=False, sender=u'owner@example.com'),
2824 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002825 message=(
2826 u'Patch Set 2: Code-Review+1\n' +
2827 u'\n' +
2828 u'/COMMIT_MSG\n' +
2829 u' PS2, File comment: https://chromium-review.googlesource.com/' +
2830 u'c/1/2//COMMIT_MSG#\n' +
2831 u' Please include a bug link\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002832 date=datetime.datetime(2017, 3, 17, 5, 19, 37, 500000),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002833 autogenerated=False,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002834 disapproval=False, approval=False, sender=u'reviewer@example.com'),
2835 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002836 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00002837 issue=1, branchref='refs/heads/foo')
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002838 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002839 self.mock(git_cl.Changelist, 'GetBranch', lambda _: 'foo')
2840 self.assertEqual(
2841 0, git_cl.main(['comments', '-i', '1', '-j', 'output.json']))
2842
2843 def test_git_cl_comments_robot_comments(self):
2844 # git cl comments also fetches robot comments (which are considered a type
2845 # of autogenerated comment), and unlike other types of comments, only robot
2846 # comments from the latest patchset are shown.
Edward Lemur79d4f992019-11-11 23:49:02 +00002847 self.mock(sys, 'stdout', StringIO())
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002848 self.calls = [
2849 ((['git', 'config', 'branch.foo.gerritserver'],), ''),
2850 ((['git', 'config', 'branch.foo.merge'],), ''),
2851 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
2852 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
2853 'origin/master'),
2854 ((['git', 'config', 'remote.origin.url'],),
2855 'https://chromium.googlesource.com/infra/infra'),
2856 (('GetChangeDetail', 'chromium-review.googlesource.com',
2857 'infra%2Finfra~1',
2858 ['MESSAGES', 'DETAILED_ACCOUNTS', 'CURRENT_REVISION',
2859 'CURRENT_COMMIT']), {
2860 'owner': {'email': 'owner@example.com'},
2861 'current_revision': 'ba5eba11',
2862 'revisions': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002863 'deadbeaf': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002864 '_number': 1,
2865 },
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002866 'ba5eba11': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002867 '_number': 2,
2868 },
2869 },
2870 'messages': [
2871 {
2872 u'_revision_number': 1,
2873 u'author': {
2874 u'_account_id': 1111084,
2875 u'email': u'commit-bot@chromium.org',
2876 u'name': u'Commit Bot'
2877 },
2878 u'date': u'2017-03-15 20:08:45.000000000',
2879 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
2880 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
2881 u'tag': u'autogenerated:cq:dry-run'
2882 },
2883 {
2884 u'_revision_number': 1,
2885 u'author': {
2886 u'_account_id': 123,
2887 u'email': u'tricium@serviceaccount.com',
2888 u'name': u'Tricium'
2889 },
2890 u'date': u'2017-03-16 20:00:41.000000000',
2891 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2892 u'message': u'(1 comment)',
2893 u'tag': u'autogenerated:tricium',
2894 },
2895 {
2896 u'_revision_number': 1,
2897 u'author': {
2898 u'_account_id': 123,
2899 u'email': u'tricium@serviceaccount.com',
2900 u'name': u'Tricium'
2901 },
2902 u'date': u'2017-03-16 20:00:41.000000000',
2903 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2904 u'message': u'(1 comment)',
2905 u'tag': u'autogenerated:tricium',
2906 },
2907 {
2908 u'_revision_number': 2,
2909 u'author': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002910 u'_account_id': 123,
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002911 u'email': u'tricium@serviceaccount.com',
2912 u'name': u'reviewer'
2913 },
2914 u'date': u'2017-03-17 05:30:37.000000000',
2915 u'tag': u'autogenerated:tricium',
2916 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2917 u'message': u'(1 comment)',
2918 },
2919 ]
2920 }),
2921 (('GetChangeComments', 'chromium-review.googlesource.com',
2922 'infra%2Finfra~1'), {}),
2923 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
2924 'infra%2Finfra~1'), {
2925 'codereview.settings': [
2926 {
2927 u'author': {u'email': u'tricium@serviceaccount.com'},
2928 u'updated': u'2017-03-17 05:30:37.000000000',
2929 u'robot_run_id': u'5565031076855808',
2930 u'robot_id': u'Linter/Category',
2931 u'tag': u'autogenerated:tricium',
2932 u'patch_set': 2,
2933 u'side': u'REVISION',
2934 u'message': u'Linter warning message text',
2935 u'line': 32,
2936 },
2937 ],
2938 }),
2939 ((['git', 'config', 'branch.foo.gerritpatchset', '2'],), ''),
2940 ]
2941 expected_comments_summary = [
2942 git_cl._CommentSummary(date=datetime.datetime(2017, 3, 17, 5, 30, 37),
2943 message=(
2944 u'(1 comment)\n\ncodereview.settings\n'
2945 u' PS2, Line 32: https://chromium-review.googlesource.com/'
2946 u'c/1/2/codereview.settings#32\n'
2947 u' Linter warning message text\n'),
2948 sender=u'tricium@serviceaccount.com',
2949 autogenerated=True, approval=False, disapproval=False)
2950 ]
2951 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00002952 issue=1, branchref='refs/heads/foo')
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002953 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002954
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002955 def test_get_remote_url_with_mirror(self):
2956 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002957
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002958 def selective_os_path_isdir_mock(path):
2959 if path == '/cache/this-dir-exists':
2960 return self._mocked_call('os.path.isdir', path)
2961 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002962
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002963 self.mock(os.path, 'isdir', selective_os_path_isdir_mock)
2964
2965 url = 'https://chromium.googlesource.com/my/repo'
2966 self.calls = [
2967 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2968 ((['git', 'config', 'branch.master.merge'],), 'master'),
2969 ((['git', 'config', 'branch.master.remote'],), 'origin'),
2970 ((['git', 'config', 'remote.origin.url'],),
2971 '/cache/this-dir-exists'),
2972 (('os.path.isdir', '/cache/this-dir-exists'),
2973 True),
2974 # Runs in /cache/this-dir-exists.
2975 ((['git', 'config', 'remote.origin.url'],),
2976 url),
2977 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002978 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002979 self.assertEqual(cl.GetRemoteUrl(), url)
2980 self.assertEqual(cl.GetRemoteUrl(), url) # Must be cached.
2981
Edward Lemur298f2cf2019-02-22 21:40:39 +00002982 def test_get_remote_url_non_existing_mirror(self):
2983 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002984
Edward Lemur298f2cf2019-02-22 21:40:39 +00002985 def selective_os_path_isdir_mock(path):
2986 if path == '/cache/this-dir-doesnt-exist':
2987 return self._mocked_call('os.path.isdir', path)
2988 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002989
Edward Lemur298f2cf2019-02-22 21:40:39 +00002990 self.mock(os.path, 'isdir', selective_os_path_isdir_mock)
2991 self.mock(logging, 'error',
2992 lambda fmt, *a: self._mocked_call('logging.error', fmt % a))
2993
2994 self.calls = [
2995 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2996 ((['git', 'config', 'branch.master.merge'],), 'master'),
2997 ((['git', 'config', 'branch.master.remote'],), 'origin'),
2998 ((['git', 'config', 'remote.origin.url'],),
2999 '/cache/this-dir-doesnt-exist'),
3000 (('os.path.isdir', '/cache/this-dir-doesnt-exist'),
3001 False),
3002 (('logging.error',
Daniel Bratell4a60db42019-09-16 17:02:52 +00003003 'Remote "origin" for branch "master" points to'
3004 ' "/cache/this-dir-doesnt-exist", but it doesn\'t exist.'), None),
Edward Lemur298f2cf2019-02-22 21:40:39 +00003005 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00003006 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00003007 self.assertIsNone(cl.GetRemoteUrl())
3008
3009 def test_get_remote_url_misconfigured_mirror(self):
3010 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003011
Edward Lemur298f2cf2019-02-22 21:40:39 +00003012 def selective_os_path_isdir_mock(path):
3013 if path == '/cache/this-dir-exists':
3014 return self._mocked_call('os.path.isdir', path)
3015 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003016
Edward Lemur298f2cf2019-02-22 21:40:39 +00003017 self.mock(os.path, 'isdir', selective_os_path_isdir_mock)
3018 self.mock(logging, 'error',
3019 lambda *a: self._mocked_call('logging.error', *a))
3020
3021 self.calls = [
3022 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3023 ((['git', 'config', 'branch.master.merge'],), 'master'),
3024 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3025 ((['git', 'config', 'remote.origin.url'],),
3026 '/cache/this-dir-exists'),
3027 (('os.path.isdir', '/cache/this-dir-exists'), True),
3028 # Runs in /cache/this-dir-exists.
3029 ((['git', 'config', 'remote.origin.url'],), ''),
3030 (('logging.error',
3031 'Remote "%(remote)s" for branch "%(branch)s" points to '
3032 '"%(cache_path)s", but it is misconfigured.\n'
3033 '"%(cache_path)s" must be a git repo and must have a remote named '
3034 '"%(remote)s" pointing to the git host.', {
3035 'remote': 'origin',
3036 'cache_path': '/cache/this-dir-exists',
3037 'branch': 'master'}
3038 ), None),
3039 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00003040 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00003041 self.assertIsNone(cl.GetRemoteUrl())
3042
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003043 def test_gerrit_change_identifier_with_project(self):
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00003044 self.calls = [
3045 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3046 ((['git', 'config', 'branch.master.merge'],), 'master'),
3047 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3048 ((['git', 'config', 'remote.origin.url'],),
3049 'https://chromium.googlesource.com/a/my/repo.git/'),
3050 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00003051 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003052 self.assertEqual(cl._GerritChangeIdentifier(), 'my%2Frepo~123456')
3053
3054 def test_gerrit_change_identifier_without_project(self):
3055 self.calls = [
3056 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3057 ((['git', 'config', 'branch.master.merge'],), 'master'),
3058 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3059 ((['git', 'config', 'remote.origin.url'],), CERR1),
3060 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00003061 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003062 self.assertEqual(cl._GerritChangeIdentifier(), '123456')
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00003063
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003064
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003065class CMDTestCaseBase(unittest.TestCase):
3066 _STATUSES = [
3067 'STATUS_UNSPECIFIED', 'SCHEDULED', 'STARTED', 'SUCCESS', 'FAILURE',
3068 'INFRA_FAILURE', 'CANCELED',
3069 ]
3070 _CHANGE_DETAIL = {
3071 'project': 'depot_tools',
3072 'status': 'OPEN',
3073 'owner': {'email': 'owner@e.mail'},
3074 'current_revision': 'beeeeeef',
3075 'revisions': {
3076 'deadbeaf': {'_number': 6},
3077 'beeeeeef': {
3078 '_number': 7,
3079 'fetch': {'http': {
3080 'url': 'https://chromium.googlesource.com/depot_tools',
3081 'ref': 'refs/changes/56/123456/7'
3082 }},
3083 },
3084 },
3085 }
3086 _DEFAULT_RESPONSE = {
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003087 'builds': [{
3088 'id': str(100 + idx),
3089 'builder': {
3090 'project': 'chromium',
3091 'bucket': 'try',
3092 'builder': 'bot_' + status.lower(),
3093 },
3094 'createTime': '2019-10-09T08:00:0%d.854286Z' % (idx % 10),
3095 'tags': [],
3096 'status': status,
3097 } for idx, status in enumerate(_STATUSES)]
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003098 }
3099
Edward Lemur4c707a22019-09-24 21:13:43 +00003100 def setUp(self):
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003101 super(CMDTestCaseBase, self).setUp()
Edward Lemur79d4f992019-11-11 23:49:02 +00003102 mock.patch('git_cl.sys.stdout', StringIO()).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003103 mock.patch('git_cl.uuid.uuid4', return_value='uuid4').start()
3104 mock.patch('git_cl.Changelist.GetIssue', return_value=123456).start()
Edward Lemur4c707a22019-09-24 21:13:43 +00003105 mock.patch('git_cl.Changelist.GetCodereviewServer',
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003106 return_value='https://chromium-review.googlesource.com').start()
3107 mock.patch('git_cl.Changelist.GetMostRecentPatchset',
3108 return_value=7).start()
Edward Lemur5b929a42019-10-21 17:57:39 +00003109 mock.patch('git_cl.auth.Authenticator',
Edward Lemurb4a587d2019-10-09 23:56:38 +00003110 return_value=AuthenticatorMock()).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003111 mock.patch('git_cl.Changelist._GetChangeDetail',
3112 return_value=self._CHANGE_DETAIL).start()
3113 mock.patch('git_cl._call_buildbucket',
3114 return_value = self._DEFAULT_RESPONSE).start()
3115 mock.patch('git_common.is_dirty_git_tree', return_value=False).start()
Edward Lemur4c707a22019-09-24 21:13:43 +00003116 self.addCleanup(mock.patch.stopall)
3117
Edward Lemur4c707a22019-09-24 21:13:43 +00003118
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003119class CMDTryResultsTestCase(CMDTestCaseBase):
3120 _DEFAULT_REQUEST = {
3121 'predicate': {
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003122 "gerritChanges": [{
3123 "project": "depot_tools",
3124 "host": "chromium-review.googlesource.com",
3125 "patchset": 7,
3126 "change": 123456,
3127 }],
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003128 },
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003129 'fields': ('builds.*.id,builds.*.builder,builds.*.status' +
3130 ',builds.*.createTime,builds.*.tags'),
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003131 }
3132
3133 def testNoJobs(self):
3134 git_cl._call_buildbucket.return_value = {}
3135
3136 self.assertEqual(0, git_cl.main(['try-results']))
3137 self.assertEqual('No tryjobs scheduled.\n', sys.stdout.getvalue())
3138 git_cl._call_buildbucket.assert_called_once_with(
3139 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3140 self._DEFAULT_REQUEST)
3141
3142 def testPrintToStdout(self):
3143 self.assertEqual(0, git_cl.main(['try-results']))
3144 self.assertEqual([
3145 'Successes:',
3146 ' bot_success https://ci.chromium.org/b/103',
3147 'Infra Failures:',
3148 ' bot_infra_failure https://ci.chromium.org/b/105',
3149 'Failures:',
3150 ' bot_failure https://ci.chromium.org/b/104',
3151 'Canceled:',
3152 ' bot_canceled ',
3153 'Started:',
3154 ' bot_started https://ci.chromium.org/b/102',
3155 'Scheduled:',
3156 ' bot_scheduled id=101',
3157 'Other:',
3158 ' bot_status_unspecified id=100',
3159 'Total: 7 tryjobs',
3160 ], sys.stdout.getvalue().splitlines())
3161 git_cl._call_buildbucket.assert_called_once_with(
3162 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3163 self._DEFAULT_REQUEST)
3164
3165 def testPrintToStdoutWithMasters(self):
3166 self.assertEqual(0, git_cl.main(['try-results', '--print-master']))
3167 self.assertEqual([
3168 'Successes:',
3169 ' try bot_success https://ci.chromium.org/b/103',
3170 'Infra Failures:',
3171 ' try bot_infra_failure https://ci.chromium.org/b/105',
3172 'Failures:',
3173 ' try bot_failure https://ci.chromium.org/b/104',
3174 'Canceled:',
3175 ' try bot_canceled ',
3176 'Started:',
3177 ' try bot_started https://ci.chromium.org/b/102',
3178 'Scheduled:',
3179 ' try bot_scheduled id=101',
3180 'Other:',
3181 ' try bot_status_unspecified id=100',
3182 'Total: 7 tryjobs',
3183 ], sys.stdout.getvalue().splitlines())
3184 git_cl._call_buildbucket.assert_called_once_with(
3185 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3186 self._DEFAULT_REQUEST)
3187
3188 @mock.patch('git_cl.write_json')
3189 def testWriteToJson(self, mockJsonDump):
3190 self.assertEqual(0, git_cl.main(['try-results', '--json', 'file.json']))
3191 git_cl._call_buildbucket.assert_called_once_with(
3192 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3193 self._DEFAULT_REQUEST)
3194 mockJsonDump.assert_called_once_with(
3195 'file.json', self._DEFAULT_RESPONSE['builds'])
3196
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003197 def test_filter_failed_for_one_simple(self):
3198 self.assertEqual({}, git_cl._filter_failed_for_retry([]))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003199 self.assertEqual({
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003200 'chromium/try': {
3201 'bot_failure': [],
3202 'bot_infra_failure': []
3203 },
3204 }, git_cl._filter_failed_for_retry(self._DEFAULT_RESPONSE['builds']))
3205
3206 def test_filter_failed_for_retry_many_builds(self):
3207
3208 def _build(name, created_sec, status, experimental=False):
3209 assert 0 <= created_sec < 100, created_sec
3210 b = {
3211 'id': 112112,
3212 'builder': {
3213 'project': 'chromium',
3214 'bucket': 'try',
3215 'builder': name,
3216 },
3217 'createTime': '2019-10-09T08:00:%02d.854286Z' % created_sec,
3218 'status': status,
3219 'tags': [],
3220 }
3221 if experimental:
3222 b['tags'].append({'key': 'cq_experimental', 'value': 'true'})
3223 return b
3224
3225 builds = [
3226 _build('flaky-last-green', 1, 'FAILURE'),
3227 _build('flaky-last-green', 2, 'SUCCESS'),
3228 _build('flaky', 1, 'SUCCESS'),
3229 _build('flaky', 2, 'FAILURE'),
3230 _build('running', 1, 'FAILED'),
3231 _build('running', 2, 'SCHEDULED'),
3232 _build('yep-still-running', 1, 'STARTED'),
3233 _build('yep-still-running', 2, 'FAILURE'),
3234 _build('cq-experimental', 1, 'SUCCESS', experimental=True),
3235 _build('cq-experimental', 2, 'FAILURE', experimental=True),
3236
3237 # Simulate experimental in CQ builder, which developer decided
3238 # to retry manually which resulted in 2nd build non-experimental.
3239 _build('sometimes-experimental', 1, 'FAILURE', experimental=True),
3240 _build('sometimes-experimental', 2, 'FAILURE', experimental=False),
3241 ]
3242 builds.sort(key=lambda b: b['status']) # ~deterministic shuffle.
3243 self.assertEqual({
3244 'chromium/try': {
3245 'flaky': [],
3246 'sometimes-experimental': []
3247 },
3248 }, git_cl._filter_failed_for_retry(builds))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003249
3250
3251class CMDTryTestCase(CMDTestCaseBase):
3252
3253 @mock.patch('git_cl.Changelist.SetCQState')
3254 @mock.patch('git_cl._get_bucket_map', return_value={})
3255 def testSetCQDryRunByDefault(self, _mockGetBucketMap, mockSetCQState):
3256 mockSetCQState.return_value = 0
Edward Lemur4c707a22019-09-24 21:13:43 +00003257 self.assertEqual(0, git_cl.main(['try']))
3258 git_cl.Changelist.SetCQState.assert_called_with(git_cl._CQState.DRY_RUN)
3259 self.assertEqual(
3260 sys.stdout.getvalue(),
3261 'Scheduling CQ dry run on: '
3262 'https://chromium-review.googlesource.com/123456\n')
3263
Edward Lemur4c707a22019-09-24 21:13:43 +00003264 @mock.patch('git_cl._call_buildbucket')
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003265 def testScheduleOnBuildbucket(self, mockCallBuildbucket):
Edward Lemur4c707a22019-09-24 21:13:43 +00003266 mockCallBuildbucket.return_value = {}
Edward Lemur4c707a22019-09-24 21:13:43 +00003267
3268 self.assertEqual(0, git_cl.main([
3269 'try', '-B', 'luci.chromium.try', '-b', 'win',
3270 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
3271 self.assertIn(
3272 'Scheduling jobs on:\nBucket: luci.chromium.try',
3273 git_cl.sys.stdout.getvalue())
3274
3275 expected_request = {
3276 "requests": [{
3277 "scheduleBuild": {
3278 "requestId": "uuid4",
3279 "builder": {
3280 "project": "chromium",
3281 "builder": "win",
3282 "bucket": "try",
3283 },
3284 "gerritChanges": [{
3285 "project": "depot_tools",
3286 "host": "chromium-review.googlesource.com",
3287 "patchset": 7,
3288 "change": 123456,
3289 }],
3290 "properties": {
3291 "category": "git_cl_try",
3292 "json": [{"a": 1}, None],
3293 "key": "val",
3294 },
3295 "tags": [
3296 {"value": "win", "key": "builder"},
3297 {"value": "git_cl_try", "key": "user_agent"},
3298 ],
3299 },
3300 }],
3301 }
3302 mockCallBuildbucket.assert_called_with(
3303 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3304
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003305 def testScheduleOnBuildbucket_WrongBucket(self):
Edward Lemur4c707a22019-09-24 21:13:43 +00003306 self.assertEqual(0, git_cl.main([
3307 'try', '-B', 'not-a-bucket', '-b', 'win',
3308 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
3309 self.assertIn(
3310 'WARNING Could not parse bucket "not-a-bucket". Skipping.',
3311 git_cl.sys.stdout.getvalue())
3312
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003313 @mock.patch('git_cl._call_buildbucket')
3314 @mock.patch('git_cl.fetch_try_jobs')
3315 def testScheduleOnBuildbucketRetryFailed(
3316 self, mockFetchTryJobs, mockCallBuildbucket):
3317
3318 git_cl.fetch_try_jobs.side_effect = lambda *_, **kw: {
3319 7: [],
3320 6: [{
3321 'id': 112112,
3322 'builder': {
3323 'project': 'chromium',
3324 'bucket': 'try',
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003325 'builder': 'linux',},
3326 'createTime': '2019-10-09T08:00:01.854286Z',
3327 'tags': [],
3328 'status': 'FAILURE',}],}[kw['patchset']]
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003329 mockCallBuildbucket.return_value = {}
3330
3331 self.assertEqual(0, git_cl.main(['try', '--retry-failed']))
3332 self.assertIn(
3333 'Scheduling jobs on:\nBucket: chromium/try',
3334 git_cl.sys.stdout.getvalue())
3335
3336 expected_request = {
3337 "requests": [{
3338 "scheduleBuild": {
3339 "requestId": "uuid4",
3340 "builder": {
3341 "project": "chromium",
3342 "bucket": "try",
3343 "builder": "linux",
3344 },
3345 "gerritChanges": [{
3346 "project": "depot_tools",
3347 "host": "chromium-review.googlesource.com",
3348 "patchset": 7,
3349 "change": 123456,
3350 }],
3351 "properties": {
3352 "category": "git_cl_try",
3353 },
3354 "tags": [
3355 {"value": "linux", "key": "builder"},
3356 {"value": "git_cl_try", "key": "user_agent"},
3357 {"value": "1", "key": "retry_failed"},
3358 ],
3359 },
3360 }],
3361 }
3362 mockCallBuildbucket.assert_called_with(
3363 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3364
Edward Lemur4c707a22019-09-24 21:13:43 +00003365 def test_parse_bucket(self):
3366 test_cases = [
3367 {
3368 'bucket': 'chromium/try',
3369 'result': ('chromium', 'try'),
3370 },
3371 {
3372 'bucket': 'luci.chromium.try',
3373 'result': ('chromium', 'try'),
3374 'has_warning': True,
3375 },
3376 {
3377 'bucket': 'skia.primary',
3378 'result': ('skia', 'skia.primary'),
3379 'has_warning': True,
3380 },
3381 {
3382 'bucket': 'not-a-bucket',
3383 'result': (None, None),
3384 },
3385 ]
3386
3387 for test_case in test_cases:
3388 git_cl.sys.stdout.truncate(0)
3389 self.assertEqual(
3390 test_case['result'], git_cl._parse_bucket(test_case['bucket']))
3391 if test_case.get('has_warning'):
Edward Lemur6215c792019-10-03 21:59:05 +00003392 expected_warning = 'WARNING Please use %s/%s to specify the bucket' % (
3393 test_case['result'])
3394 self.assertIn(expected_warning, git_cl.sys.stdout.getvalue())
Edward Lemur4c707a22019-09-24 21:13:43 +00003395
3396
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003397class CMDUploadTestCase(CMDTestCaseBase):
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003398 def setUp(self):
3399 super(CMDUploadTestCase, self).setUp()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003400 mock.patch('git_cl.fetch_try_jobs').start()
3401 mock.patch('git_cl._trigger_try_jobs', return_value={}).start()
3402 mock.patch('git_cl.Changelist.CMDUpload', return_value=0).start()
Anthony Polito46689b02019-11-15 20:56:41 +00003403 mock.patch('git_cl.Settings.GetIsGerrit', return_value=True).start()
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003404 self.addCleanup(mock.patch.stopall)
3405
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003406 def testUploadRetryFailed(self):
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003407 # This test mocks out the actual upload part, and just asserts that after
3408 # upload, if --retry-failed is added, then the tool will fetch try jobs
3409 # from the previous patchset and trigger the right builders on the latest
3410 # patchset.
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003411 git_cl.fetch_try_jobs.side_effect = [
3412 # Latest patchset: No builds.
3413 [],
3414 # Patchset before latest: Some builds.
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003415 [{
3416 'id': str(100 + idx),
3417 'builder': {
3418 'project': 'chromium',
3419 'bucket': 'try',
3420 'builder': 'bot_' + status.lower(),
3421 },
3422 'createTime': '2019-10-09T08:00:0%d.854286Z' % (idx % 10),
3423 'tags': [],
3424 'status': status,
3425 } for idx, status in enumerate(self._STATUSES)],
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +00003426 ]
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003427
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003428 self.assertEqual(0, git_cl.main(['upload', '--retry-failed']))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003429 self.assertEqual([
Edward Lemur5b929a42019-10-21 17:57:39 +00003430 mock.call(mock.ANY, 'cr-buildbucket.appspot.com', patchset=7),
3431 mock.call(mock.ANY, 'cr-buildbucket.appspot.com', patchset=6),
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003432 ], git_cl.fetch_try_jobs.mock_calls)
3433 expected_buckets = {
3434 'chromium/try': {'bot_failure': [], 'bot_infra_failure': []},
3435 }
3436 git_cl._trigger_try_jobs.assert_called_once_with(
Edward Lemur5b929a42019-10-21 17:57:39 +00003437 mock.ANY, expected_buckets, mock.ANY, 8)
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003438
Brian Sheedy59b06a82019-10-14 17:03:29 +00003439
3440class CMDFormatTestCase(TestCase):
3441
3442 def setUp(self):
3443 super(CMDFormatTestCase, self).setUp()
3444 self._top_dir = tempfile.mkdtemp()
3445
3446 def tearDown(self):
3447 shutil.rmtree(self._top_dir)
3448 super(CMDFormatTestCase, self).tearDown()
3449
3450 def _make_yapfignore(self, contents):
Jamie Madill177710b2020-01-10 19:16:47 +00003451 with open(os.path.join(self._top_dir, '.yapfignore'), 'w') as yapfignore:
3452 yapfignore.write('\n'.join(contents))
Brian Sheedy59b06a82019-10-14 17:03:29 +00003453
Brian Sheedyb4307d52019-12-02 19:18:17 +00003454 def _check_yapf_filtering(self, files, expected):
3455 self.assertEqual(expected, git_cl._FilterYapfIgnoredFiles(
3456 files, git_cl._GetYapfIgnorePatterns(self._top_dir)))
Brian Sheedy59b06a82019-10-14 17:03:29 +00003457
Brian Sheedyb4307d52019-12-02 19:18:17 +00003458 def testYapfignoreExplicit(self):
3459 self._make_yapfignore(['foo/bar.py', 'foo/bar/baz.py'])
3460 files = [
3461 'bar.py',
3462 'foo/bar.py',
3463 'foo/baz.py',
3464 'foo/bar/baz.py',
3465 'foo/bar/foobar.py',
3466 ]
3467 expected = [
3468 'bar.py',
3469 'foo/baz.py',
3470 'foo/bar/foobar.py',
3471 ]
3472 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003473
Brian Sheedyb4307d52019-12-02 19:18:17 +00003474 def testYapfignoreSingleWildcards(self):
3475 self._make_yapfignore(['*bar.py', 'foo*', 'baz*.py'])
3476 files = [
3477 'bar.py', # Matched by *bar.py.
3478 'bar.txt',
3479 'foobar.py', # Matched by *bar.py, foo*.
3480 'foobar.txt', # Matched by foo*.
3481 'bazbar.py', # Matched by *bar.py, baz*.py.
3482 'bazbar.txt',
3483 'foo/baz.txt', # Matched by foo*.
3484 'bar/bar.py', # Matched by *bar.py.
3485 'baz/foo.py', # Matched by baz*.py, foo*.
3486 'baz/foo.txt',
3487 ]
3488 expected = [
3489 'bar.txt',
3490 'bazbar.txt',
3491 'baz/foo.txt',
3492 ]
3493 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003494
Brian Sheedyb4307d52019-12-02 19:18:17 +00003495 def testYapfignoreMultiplewildcards(self):
3496 self._make_yapfignore(['*bar*', '*foo*baz.txt'])
3497 files = [
3498 'bar.py', # Matched by *bar*.
3499 'bar.txt', # Matched by *bar*.
3500 'abar.py', # Matched by *bar*.
3501 'foobaz.txt', # Matched by *foo*baz.txt.
3502 'foobaz.py',
3503 'afoobaz.txt', # Matched by *foo*baz.txt.
3504 ]
3505 expected = [
3506 'foobaz.py',
3507 ]
3508 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003509
3510 def testYapfignoreComments(self):
3511 self._make_yapfignore(['test.py', '#test2.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003512 files = [
3513 'test.py',
3514 'test2.py',
3515 ]
3516 expected = [
3517 'test2.py',
3518 ]
3519 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003520
3521 def testYapfignoreBlankLines(self):
3522 self._make_yapfignore(['test.py', '', '', 'test2.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003523 files = [
3524 'test.py',
3525 'test2.py',
3526 'test3.py',
3527 ]
3528 expected = [
3529 'test3.py',
3530 ]
3531 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003532
3533 def testYapfignoreWhitespace(self):
3534 self._make_yapfignore([' test.py '])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003535 files = [
3536 'test.py',
3537 'test2.py',
3538 ]
3539 expected = [
3540 'test2.py',
3541 ]
3542 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003543
Brian Sheedyb4307d52019-12-02 19:18:17 +00003544 def testYapfignoreNoFiles(self):
Brian Sheedy59b06a82019-10-14 17:03:29 +00003545 self._make_yapfignore(['test.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003546 self._check_yapf_filtering([], [])
3547
3548 def testYapfignoreMissingYapfignore(self):
3549 files = [
3550 'test.py',
3551 ]
3552 expected = [
3553 'test.py',
3554 ]
3555 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003556
3557
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003558if __name__ == '__main__':
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +01003559 logging.basicConfig(
3560 level=logging.DEBUG if '-v' in sys.argv else logging.ERROR)
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003561 unittest.main()