blob: 901d96b0428d22b332e2e2ac318245984114ca38 [file] [log] [blame]
Edward Lemur0db01f02019-11-12 22:01:51 +00001#!/usr/bin/env vpython3
2# coding=utf-8
maruel@chromium.orgeb5edbc2012-01-16 17:03:28 +00003# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@chromium.orgddd59412011-11-30 14:20:38 +00004# Use of this source code is governed by a BSD-style license that can be
5# found in the LICENSE file.
6
7"""Unit tests for git_cl.py."""
8
Edward Lemur85153282020-02-14 22:06:29 +00009from __future__ import print_function
Edward Lemur0db01f02019-11-12 22:01:51 +000010from __future__ import unicode_literals
11
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +010012import datetime
tandriide281ae2016-10-12 06:02:30 -070013import json
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +010014import logging
maruel@chromium.orgddd59412011-11-30 14:20:38 +000015import os
Edward Lemur85153282020-02-14 22:06:29 +000016import pprint
Brian Sheedy59b06a82019-10-14 17:03:29 +000017import shutil
maruel@chromium.orgddd59412011-11-30 14:20:38 +000018import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070019import tempfile
maruel@chromium.orgddd59412011-11-30 14:20:38 +000020import unittest
21
Edward Lemura8145022020-01-06 18:47:54 +000022if sys.version_info.major == 2:
23 from StringIO import StringIO
24 import mock
25else:
26 from io import StringIO
27 from unittest import mock
28
maruel@chromium.orgddd59412011-11-30 14:20:38 +000029sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
30
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000031import metrics
32# We have to disable monitoring before importing git_cl.
33metrics.DISABLE_METRICS_COLLECTION = True
34
Jamie Madill5e96ad12020-01-13 16:08:35 +000035import clang_format
Eric Boren2fb63102018-10-05 13:05:03 +000036import gerrit_util
maruel@chromium.orgddd59412011-11-30 14:20:38 +000037import git_cl
iannucci@chromium.org9e849272014-04-04 00:31:55 +000038import git_common
tandrii@chromium.org57d86542016-03-04 16:11:32 +000039import git_footers
Edward Lemur85153282020-02-14 22:06:29 +000040import git_new_branch
41import scm
maruel@chromium.orgddd59412011-11-30 14:20:38 +000042import subprocess2
maruel@chromium.orgddd59412011-11-30 14:20:38 +000043
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000044
Edward Lemur0db01f02019-11-12 22:01:51 +000045def callError(code=1, cmd='', cwd='', stdout=b'', stderr=b''):
tandrii5d48c322016-08-18 16:19:37 -070046 return subprocess2.CalledProcessError(code, cmd, cwd, stdout, stderr)
47
48
Edward Lemur4c707a22019-09-24 21:13:43 +000049def _constantFn(return_value):
50 def f(*args, **kwargs):
51 return return_value
52 return f
53
54
tandrii5d48c322016-08-18 16:19:37 -070055CERR1 = callError(1)
56
57
Edward Lemur0db01f02019-11-12 22:01:51 +000058def MakeNamedTemporaryFileMock(test, expected_content):
Aaron Gable9a03ae02017-11-03 11:31:07 -070059 class NamedTemporaryFileMock(object):
60 def __init__(self, *args, **kwargs):
61 self.name = '/tmp/named'
Edward Lemur0db01f02019-11-12 22:01:51 +000062 self.expected_content = expected_content.encode('utf-8', 'replace')
Aaron Gable9a03ae02017-11-03 11:31:07 -070063
64 def __enter__(self):
65 return self
66
67 def __exit__(self, _type, _value, _tb):
68 pass
69
70 def write(self, content):
71 if self.expected_content:
Edward Lemur0db01f02019-11-12 22:01:51 +000072 test.assertEqual(self.expected_content, content)
Aaron Gable9a03ae02017-11-03 11:31:07 -070073
74 def close(self):
75 pass
76
77 return NamedTemporaryFileMock
78
79
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000080class ChangelistMock(object):
81 # A class variable so we can access it when we don't have access to the
82 # instance that's being set.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000083 desc = ''
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000084 def __init__(self, **kwargs):
85 pass
86 def GetIssue(self):
87 return 1
Edward Lemur6c6827c2020-02-06 21:15:18 +000088 def FetchDescription(self):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000089 return ChangelistMock.desc
dsansomee2d6fd92016-09-08 00:10:47 -070090 def UpdateDescription(self, desc, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000091 ChangelistMock.desc = desc
92
tandrii5d48c322016-08-18 16:19:37 -070093
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000094class PresubmitMock(object):
95 def __init__(self, *args, **kwargs):
96 self.reviewers = []
Daniel Cheng7227d212017-11-17 08:12:37 -080097 self.more_cc = ['chromium-reviews+test-more-cc@chromium.org']
98
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000099 @staticmethod
100 def should_continue():
101 return True
102
103
Edward Lemur85153282020-02-14 22:06:29 +0000104class GitMocks(object):
105 def __init__(self, config=None, branchref=None):
106 self.branchref = branchref or 'refs/heads/master'
107 self.config = config or {}
108
109 def GetBranchRef(self, _root):
110 return self.branchref
111
112 def NewBranch(self, branchref):
113 self.branchref = branchref
114
115 def GetConfig(self, _root, key, default=None):
116 return self.config.get(key, default)
117
118 def SetConfig(self, _root, key, value=None):
119 if value:
120 self.config[key] = value
121 return
122 if key not in self.config:
123 raise CERR1
124 del self.config[key]
125
126
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000127class WatchlistsMock(object):
128 def __init__(self, _):
129 pass
130 @staticmethod
131 def GetWatchersForPaths(_):
132 return ['joe@example.com']
133
134
Edward Lemur4c707a22019-09-24 21:13:43 +0000135class CodereviewSettingsFileMock(object):
136 def __init__(self):
137 pass
138 # pylint: disable=no-self-use
139 def read(self):
140 return ('CODE_REVIEW_SERVER: gerrit.chromium.org\n' +
141 'GERRIT_HOST: True\n')
142
143
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000144class AuthenticatorMock(object):
145 def __init__(self, *_args):
146 pass
147 def has_cached_credentials(self):
148 return True
tandrii221ab252016-10-06 08:12:04 -0700149 def authorize(self, http):
150 return http
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000151
152
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100153def CookiesAuthenticatorMockFactory(hosts_with_creds=None, same_auth=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000154 """Use to mock Gerrit/Git credentials from ~/.netrc or ~/.gitcookies.
155
156 Usage:
157 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100158 CookiesAuthenticatorMockFactory({'host': ('user', _, 'pass')})
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000159
160 OR
161 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100162 CookiesAuthenticatorMockFactory(
163 same_auth=('user', '', 'pass'))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000164 """
165 class CookiesAuthenticatorMock(git_cl.gerrit_util.CookiesAuthenticator):
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800166 def __init__(self): # pylint: disable=super-init-not-called
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000167 # Intentionally not calling super() because it reads actual cookie files.
168 pass
169 @classmethod
170 def get_gitcookies_path(cls):
171 return '~/.gitcookies'
172 @classmethod
173 def get_netrc_path(cls):
174 return '~/.netrc'
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100175 def _get_auth_for_host(self, host):
176 if same_auth:
177 return same_auth
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000178 return (hosts_with_creds or {}).get(host)
179 return CookiesAuthenticatorMock
180
Aaron Gable9a03ae02017-11-03 11:31:07 -0700181
kmarshall9249e012016-08-23 12:02:16 -0700182class MockChangelistWithBranchAndIssue():
183 def __init__(self, branch, issue):
184 self.branch = branch
185 self.issue = issue
186 def GetBranch(self):
187 return self.branch
188 def GetIssue(self):
189 return self.issue
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000190
tandriic2405f52016-10-10 08:13:15 -0700191
192class SystemExitMock(Exception):
193 pass
194
195
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000196class TestGitClBasic(unittest.TestCase):
Edward Lemur6c6827c2020-02-06 21:15:18 +0000197 def test_fetch_description(self):
Edward Lemurf38bc172019-09-03 21:02:13 +0000198 cl = git_cl.Changelist(issue=1, codereview_host='host')
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100199 cl.description = 'x'
200 cl.has_description = True
Edward Lemur6c6827c2020-02-06 21:15:18 +0000201 self.assertEqual(cl.FetchDescription(), 'x')
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700202
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +0000203 def test_set_preserve_tryjobs(self):
204 d = git_cl.ChangeDescription('Simple.')
205 d.set_preserve_tryjobs()
206 self.assertEqual(d.description.splitlines(), [
207 'Simple.',
208 '',
209 'Cq-Do-Not-Cancel-Tryjobs: true',
210 ])
211 before = d.description
212 d.set_preserve_tryjobs()
213 self.assertEqual(before, d.description)
214
215 d = git_cl.ChangeDescription('\n'.join([
216 'One is enough',
217 '',
218 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
219 'Change-Id: Ideadbeef',
220 ]))
221 d.set_preserve_tryjobs()
222 self.assertEqual(d.description.splitlines(), [
223 'One is enough',
224 '',
225 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
226 'Change-Id: Ideadbeef',
227 'Cq-Do-Not-Cancel-Tryjobs: true',
228 ])
229
tandriif9aefb72016-07-01 09:06:51 -0700230 def test_get_bug_line_values(self):
231 f = lambda p, bugs: list(git_cl._get_bug_line_values(p, bugs))
232 self.assertEqual(f('', ''), [])
233 self.assertEqual(f('', '123,v8:456'), ['123', 'v8:456'])
234 self.assertEqual(f('v8', '456'), ['v8:456'])
235 self.assertEqual(f('v8', 'chromium:123,456'), ['v8:456', 'chromium:123'])
236 # Not nice, but not worth carying.
237 self.assertEqual(f('v8', 'chromium:123,456,v8:123'),
238 ['v8:456', 'chromium:123', 'v8:123'])
239
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100240 def _test_git_number(self, parent_msg, dest_ref, child_msg,
241 parent_hash='parenthash'):
242 desc = git_cl.ChangeDescription(child_msg)
243 desc.update_with_git_number_footers(parent_hash, parent_msg, dest_ref)
244 return desc.description
245
246 def assertEqualByLine(self, actual, expected):
247 self.assertEqual(actual.splitlines(), expected.splitlines())
248
249 def test_git_number_bad_parent(self):
250 with self.assertRaises(ValueError):
251 self._test_git_number('Parent', 'refs/heads/master', 'Child')
252
253 def test_git_number_bad_parent_footer(self):
254 with self.assertRaises(AssertionError):
255 self._test_git_number(
256 'Parent\n'
257 '\n'
258 'Cr-Commit-Position: wrong',
259 'refs/heads/master', 'Child')
260
261 def test_git_number_bad_lineage_ignored(self):
262 actual = self._test_git_number(
263 'Parent\n'
264 '\n'
265 'Cr-Commit-Position: refs/heads/master@{#1}\n'
266 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}',
267 'refs/heads/master', 'Child')
268 self.assertEqualByLine(
269 actual,
270 'Child\n'
271 '\n'
272 'Cr-Commit-Position: refs/heads/master@{#2}\n'
273 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}')
274
275 def test_git_number_same_branch(self):
276 actual = self._test_git_number(
277 'Parent\n'
278 '\n'
279 'Cr-Commit-Position: refs/heads/master@{#12}',
280 dest_ref='refs/heads/master',
281 child_msg='Child')
282 self.assertEqualByLine(
283 actual,
284 'Child\n'
285 '\n'
286 'Cr-Commit-Position: refs/heads/master@{#13}')
287
Andrii Shyshkalovde37c012017-07-06 21:06:50 +0200288 def test_git_number_same_branch_mixed_footers(self):
289 actual = self._test_git_number(
290 'Parent\n'
291 '\n'
292 'Cr-Commit-Position: refs/heads/master@{#12}',
293 dest_ref='refs/heads/master',
294 child_msg='Child\n'
295 '\n'
296 'Broken-by: design\n'
297 'BUG=123')
298 self.assertEqualByLine(
299 actual,
300 'Child\n'
301 '\n'
302 'Broken-by: design\n'
303 'BUG=123\n'
304 'Cr-Commit-Position: refs/heads/master@{#13}')
305
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100306 def test_git_number_same_branch_with_originals(self):
307 actual = self._test_git_number(
308 'Parent\n'
309 '\n'
310 'Cr-Commit-Position: refs/heads/master@{#12}',
311 dest_ref='refs/heads/master',
312 child_msg='Child\n'
313 '\n'
314 'Some users are smart and insert their own footers\n'
315 '\n'
316 'Cr-Whatever: value\n'
317 'Cr-Commit-Position: refs/copy/paste@{#22}')
318 self.assertEqualByLine(
319 actual,
320 'Child\n'
321 '\n'
322 'Some users are smart and insert their own footers\n'
323 '\n'
324 'Cr-Original-Whatever: value\n'
325 'Cr-Original-Commit-Position: refs/copy/paste@{#22}\n'
326 'Cr-Commit-Position: refs/heads/master@{#13}')
327
328 def test_git_number_new_branch(self):
329 actual = self._test_git_number(
330 'Parent\n'
331 '\n'
332 'Cr-Commit-Position: refs/heads/master@{#12}',
333 dest_ref='refs/heads/branch',
334 child_msg='Child')
335 self.assertEqualByLine(
336 actual,
337 'Child\n'
338 '\n'
339 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
340 'Cr-Branched-From: parenthash-refs/heads/master@{#12}')
341
342 def test_git_number_lineage(self):
343 actual = self._test_git_number(
344 'Parent\n'
345 '\n'
346 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
347 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
348 dest_ref='refs/heads/branch',
349 child_msg='Child')
350 self.assertEqualByLine(
351 actual,
352 'Child\n'
353 '\n'
354 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
355 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
356
357 def test_git_number_moooooooore_lineage(self):
358 actual = self._test_git_number(
359 'Parent\n'
360 '\n'
361 'Cr-Commit-Position: refs/heads/branch@{#5}\n'
362 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
363 dest_ref='refs/heads/mooore',
364 child_msg='Child')
365 self.assertEqualByLine(
366 actual,
367 'Child\n'
368 '\n'
369 'Cr-Commit-Position: refs/heads/mooore@{#1}\n'
370 'Cr-Branched-From: parenthash-refs/heads/branch@{#5}\n'
371 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
372
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100373 def test_git_number_ever_moooooooore_lineage(self):
Robert Iannucci456b0d62018-03-13 19:15:50 -0700374 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100375 actual = self._test_git_number(
376 'CQ commit on fresh new branch + numbering.\n'
377 '\n'
378 'NOTRY=True\n'
379 'NOPRESUBMIT=True\n'
380 'BUG=\n'
381 '\n'
382 'Review-Url: https://codereview.chromium.org/2577703003\n'
383 'Cr-Commit-Position: refs/heads/gnumb-test/br@{#1}\n'
384 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
385 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}',
386 dest_ref='refs/heads/gnumb-test/cl',
387 child_msg='git cl on fresh new branch + numbering.\n'
388 '\n'
389 'Review-Url: https://codereview.chromium.org/2575043003 .\n')
390 self.assertEqualByLine(
391 actual,
392 'git cl on fresh new branch + numbering.\n'
393 '\n'
394 'Review-Url: https://codereview.chromium.org/2575043003 .\n'
395 'Cr-Commit-Position: refs/heads/gnumb-test/cl@{#1}\n'
396 'Cr-Branched-From: parenthash-refs/heads/gnumb-test/br@{#1}\n'
397 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
398 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}')
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100399
400 def test_git_number_cherry_pick(self):
401 actual = self._test_git_number(
402 'Parent\n'
403 '\n'
404 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
405 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
406 dest_ref='refs/heads/branch',
407 child_msg='Child, which is cherry-pick from master\n'
408 '\n'
409 'Cr-Commit-Position: refs/heads/master@{#100}\n'
410 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)')
411 self.assertEqualByLine(
412 actual,
413 'Child, which is cherry-pick from master\n'
414 '\n'
415 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)\n'
416 '\n'
417 'Cr-Original-Commit-Position: refs/heads/master@{#100}\n'
418 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
419 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
420
Edward Lemurda4b6c62020-02-13 00:28:40 +0000421 @mock.patch('gerrit_util.GetAccountDetails')
422 def test_valid_accounts(self, mockGetAccountDetails):
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000423 mock_per_account = {
424 'u1': None, # 404, doesn't exist.
425 'u2': {
426 '_account_id': 123124,
427 'avatars': [],
428 'email': 'u2@example.com',
429 'name': 'User Number 2',
430 'status': 'OOO',
431 },
432 'u3': git_cl.gerrit_util.GerritError(500, 'retries didn\'t help :('),
433 }
434 def GetAccountDetailsMock(_, account):
435 # Poor-man's mock library's side_effect.
436 v = mock_per_account.pop(account)
437 if isinstance(v, Exception):
438 raise v
439 return v
440
Edward Lemurda4b6c62020-02-13 00:28:40 +0000441 mockGetAccountDetails.side_effect = GetAccountDetailsMock
442 actual = git_cl.gerrit_util.ValidAccounts(
443 'host', ['u1', 'u2', 'u3'], max_threads=1)
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000444 self.assertEqual(actual, {
445 'u2': {
446 '_account_id': 123124,
447 'avatars': [],
448 'email': 'u2@example.com',
449 'name': 'User Number 2',
450 'status': 'OOO',
451 },
452 })
453
454
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200455class TestParseIssueURL(unittest.TestCase):
456 def _validate(self, parsed, issue=None, patchset=None, hostname=None,
Edward Lemurf38bc172019-09-03 21:02:13 +0000457 fail=False):
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200458 self.assertIsNotNone(parsed)
459 if fail:
460 self.assertFalse(parsed.valid)
461 return
462 self.assertTrue(parsed.valid)
463 self.assertEqual(parsed.issue, issue)
464 self.assertEqual(parsed.patchset, patchset)
465 self.assertEqual(parsed.hostname, hostname)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200466
Edward Lemur678a6842019-10-03 22:25:05 +0000467 def test_ParseIssueNumberArgument(self):
468 def test(arg, *args, **kwargs):
469 self._validate(git_cl.ParseIssueNumberArgument(arg), *args, **kwargs)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200470
Edward Lemur678a6842019-10-03 22:25:05 +0000471 test('123', 123)
472 test('', fail=True)
473 test('abc', fail=True)
474 test('123/1', fail=True)
475 test('123a', fail=True)
476 test('ssh://chrome-review.source.com/#/c/123/4/', fail=True)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200477
Edward Lemur678a6842019-10-03 22:25:05 +0000478 test('https://codereview.source.com/123',
479 123, None, 'codereview.source.com')
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200480 test('http://chrome-review.source.com/c/123',
481 123, None, 'chrome-review.source.com')
482 test('https://chrome-review.source.com/c/123/',
483 123, None, 'chrome-review.source.com')
484 test('https://chrome-review.source.com/c/123/4',
485 123, 4, 'chrome-review.source.com')
486 test('https://chrome-review.source.com/#/c/123/4',
487 123, 4, 'chrome-review.source.com')
488 test('https://chrome-review.source.com/c/123/4',
489 123, 4, 'chrome-review.source.com')
490 test('https://chrome-review.source.com/123',
491 123, None, 'chrome-review.source.com')
492 test('https://chrome-review.source.com/123/4',
493 123, 4, 'chrome-review.source.com')
494
Edward Lemur678a6842019-10-03 22:25:05 +0000495 test('https://chrome-review.source.com/bad/123/4', fail=True)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200496 test('https://chrome-review.source.com/c/123/1/whatisthis', fail=True)
497 test('https://chrome-review.source.com/c/abc/', fail=True)
498 test('ssh://chrome-review.source.com/c/123/1/', fail=True)
499
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200500
501
Edward Lemurda4b6c62020-02-13 00:28:40 +0000502class GitCookiesCheckerTest(unittest.TestCase):
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100503 def setUp(self):
504 super(GitCookiesCheckerTest, self).setUp()
505 self.c = git_cl._GitCookiesChecker()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100506 self.c._all_hosts = []
Edward Lemurda4b6c62020-02-13 00:28:40 +0000507 mock.patch('sys.stdout', StringIO()).start()
508 self.addCleanup(mock.patch.stopall)
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100509
510 def mock_hosts_creds(self, subhost_identity_pairs):
511 def ensure_googlesource(h):
512 if not h.endswith(self.c._GOOGLESOURCE):
513 assert not h.endswith('.')
514 return h + '.' + self.c._GOOGLESOURCE
515 return h
516 self.c._all_hosts = [(ensure_googlesource(h), i, '.gitcookies')
517 for h, i in subhost_identity_pairs]
518
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200519 def test_identity_parsing(self):
520 self.assertEqual(self.c._parse_identity('ldap.google.com'),
521 ('ldap', 'google.com'))
522 self.assertEqual(self.c._parse_identity('git-ldap.example.com'),
523 ('ldap', 'example.com'))
524 # Specical case because we know there are no subdomains in chromium.org.
525 self.assertEqual(self.c._parse_identity('git-note.period.chromium.org'),
526 ('note.period', 'chromium.org'))
Lei Zhangd3f769a2017-12-15 15:16:14 -0800527 # Pathological: ".period." can be either username OR domain, more likely
528 # domain.
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200529 self.assertEqual(self.c._parse_identity('git-note.period.example.com'),
530 ('note', 'period.example.com'))
531
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100532 def test_analysis_nothing(self):
533 self.c._all_hosts = []
534 self.assertFalse(self.c.has_generic_host())
535 self.assertEqual(set(), self.c.get_conflicting_hosts())
536 self.assertEqual(set(), self.c.get_duplicated_hosts())
537 self.assertEqual(set(), self.c.get_partially_configured_hosts())
538 self.assertEqual(set(), self.c.get_hosts_with_wrong_identities())
539
540 def test_analysis(self):
541 self.mock_hosts_creds([
542 ('.googlesource.com', 'git-example.chromium.org'),
543
544 ('chromium', 'git-example.google.com'),
545 ('chromium-review', 'git-example.google.com'),
546 ('chrome-internal', 'git-example.chromium.org'),
547 ('chrome-internal-review', 'git-example.chromium.org'),
548 ('conflict', 'git-example.google.com'),
549 ('conflict-review', 'git-example.chromium.org'),
550 ('dup', 'git-example.google.com'),
551 ('dup', 'git-example.google.com'),
552 ('dup-review', 'git-example.google.com'),
553 ('partial', 'git-example.google.com'),
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200554 ('gpartial-review', 'git-example.google.com'),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100555 ])
556 self.assertTrue(self.c.has_generic_host())
557 self.assertEqual(set(['conflict.googlesource.com']),
558 self.c.get_conflicting_hosts())
559 self.assertEqual(set(['dup.googlesource.com']),
560 self.c.get_duplicated_hosts())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200561 self.assertEqual(set(['partial.googlesource.com',
562 'gpartial-review.googlesource.com']),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100563 self.c.get_partially_configured_hosts())
564 self.assertEqual(set(['chromium.googlesource.com',
565 'chrome-internal.googlesource.com']),
566 self.c.get_hosts_with_wrong_identities())
567
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100568 def test_report_no_problems(self):
569 self.test_analysis_nothing()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100570 self.assertFalse(self.c.find_and_report_problems())
571 self.assertEqual(sys.stdout.getvalue(), '')
572
Edward Lemurda4b6c62020-02-13 00:28:40 +0000573 @mock.patch(
574 'git_cl.gerrit_util.CookiesAuthenticator.get_gitcookies_path',
575 return_value='~/.gitcookies')
576 def test_report(self, *_mocks):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100577 self.test_analysis()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100578 self.assertTrue(self.c.find_and_report_problems())
579 with open(os.path.join(os.path.dirname(__file__),
580 'git_cl_creds_check_report.txt')) as f:
581 expected = f.read()
582 def by_line(text):
583 return [l.rstrip() for l in text.rstrip().splitlines()]
Robert Iannucci456b0d62018-03-13 19:15:50 -0700584 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalov4812e612017-03-27 17:22:57 +0200585 self.assertEqual(by_line(sys.stdout.getvalue().strip()), by_line(expected))
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100586
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -0800587
Edward Lemurda4b6c62020-02-13 00:28:40 +0000588class TestGitCl(unittest.TestCase):
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000589 def setUp(self):
590 super(TestGitCl, self).setUp()
591 self.calls = []
tandrii9d206752016-06-20 11:32:47 -0700592 self._calls_done = []
Edward Lemurda4b6c62020-02-13 00:28:40 +0000593 mock.patch('sys.stdout', StringIO()).start()
594 mock.patch(
595 'git_cl.time_time',
596 lambda: self._mocked_call('time.time')).start()
597 mock.patch(
598 'git_cl.metrics.collector.add_repeated',
599 lambda *a: self._mocked_call('add_repeated', *a)).start()
600 mock.patch('subprocess2.call', self._mocked_call).start()
601 mock.patch('subprocess2.check_call', self._mocked_call).start()
602 mock.patch('subprocess2.check_output', self._mocked_call).start()
603 mock.patch(
604 'subprocess2.communicate',
605 lambda *a, **_k: ([self._mocked_call(*a), ''], 0)).start()
606 mock.patch(
607 'git_cl.gclient_utils.CheckCallAndFilter',
608 self._mocked_call).start()
609 mock.patch('git_common.is_dirty_git_tree', lambda x: False).start()
610 mock.patch(
611 'git_common.get_or_create_merge_base',
612 lambda *a: self._mocked_call('get_or_create_merge_base', *a)).start()
613 mock.patch('git_cl.BranchExists', return_value=True).start()
614 mock.patch('git_cl.FindCodereviewSettingsFile', return_value='').start()
615 mock.patch(
616 'git_cl.SaveDescriptionBackup',
617 lambda _: self._mocked_call('SaveDescriptionBackup')).start()
618 mock.patch(
619 'git_cl.ask_for_data',
620 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
621 mock.patch(
622 'git_cl.write_json',
623 lambda *a: self._mocked_call('write_json', *a)).start()
624 mock.patch(
625 'git_cl.presubmit_support.DoPresubmitChecks', PresubmitMock).start()
626 mock.patch('git_cl.watchlists.Watchlists', WatchlistsMock).start()
627 mock.patch('git_cl.auth.Authenticator', AuthenticatorMock).start()
628 mock.patch(
629 'git_cl.gerrit_util.GetChangeDetail',
630 lambda *a: self._mocked_call('GetChangeDetail', *a)).start()
631 mock.patch(
632 'git_cl.gerrit_util.GetChangeComments',
633 lambda *a: self._mocked_call('GetChangeComments', *a)).start()
634 mock.patch(
635 'git_cl.gerrit_util.GetChangeRobotComments',
636 lambda *a: self._mocked_call('GetChangeRobotComments', *a)).start()
637 mock.patch(
638 'git_cl.gerrit_util.AddReviewers',
639 lambda *a: self._mocked_call('AddReviewers', *a)).start()
640 mock.patch(
641 'git_cl.gerrit_util.SetReview',
642 lambda h, i, msg=None, labels=None, notify=None, ready=None: (
643 self._mocked_call(
644 'SetReview', h, i, msg, labels, notify, ready))).start()
645 mock.patch(
646 'git_cl.gerrit_util.LuciContextAuthenticator.is_luci',
647 return_value=False).start()
648 mock.patch(
649 'git_cl.gerrit_util.GceAuthenticator.is_gce',
650 return_value=False).start()
651 mock.patch(
652 'git_cl.gerrit_util.ValidAccounts',
653 lambda *a: self._mocked_call('ValidAccounts', *a)).start()
654 mock.patch(
655 'git_cl.DieWithError',
656 lambda msg, change=None: self._mocked_call('DieWithError', msg)).start()
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000657 mock.patch('git_cl.Settings.GetRoot', return_value='').start()
Edward Lemur85153282020-02-14 22:06:29 +0000658 self.mockGit = GitMocks()
659 mock.patch('scm.GIT.GetBranchRef', self.mockGit.GetBranchRef).start()
660 mock.patch('scm.GIT.GetConfig', self.mockGit.GetConfig).start()
661 mock.patch('scm.GIT.SetConfig', self.mockGit.SetConfig).start()
662 mock.patch('git_new_branch.main', self.mockGit.NewBranch).start()
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000663 mock.patch(
Edward Lemur85153282020-02-14 22:06:29 +0000664 'scm.GIT.FetchUpstreamTuple',
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000665 return_value=('origin', 'refs/heads/master')).start()
Edward Lemur85153282020-02-14 22:06:29 +0000666 mock.patch(
667 'scm.GIT.CaptureStatus', return_value=[('M', 'foo.txt')]).start()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000668 # It's important to reset settings to not have inter-tests interference.
669 git_cl.settings = None
Edward Lemurda4b6c62020-02-13 00:28:40 +0000670 self.addCleanup(mock.patch.stopall)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000671
672 def tearDown(self):
wychen@chromium.org445c8962015-04-28 23:30:05 +0000673 try:
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +0000674 self.assertEqual([], self.calls)
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100675 except AssertionError:
Edward Lemur85153282020-02-14 22:06:29 +0000676 calls = ''.join(' %s\n' % str(call) for call in self.calls[:5])
677 if len(self.calls) > 5:
678 calls += ' ...\n'
679 self.fail(
680 '\n'
681 'There are un-consumed calls after this test has finished:\n' +
682 calls)
wychen@chromium.org445c8962015-04-28 23:30:05 +0000683 finally:
684 super(TestGitCl, self).tearDown()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000685
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000686 def _mocked_call(self, *args, **_kwargs):
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000687 self.assertTrue(
688 self.calls,
tandrii9d206752016-06-20 11:32:47 -0700689 '@%d Expected: <Missing> Actual: %r' % (len(self._calls_done), args))
wychen@chromium.orga872e752015-04-28 23:42:18 +0000690 top = self.calls.pop(0)
wychen@chromium.orga872e752015-04-28 23:42:18 +0000691 expected_args, result = top
692
maruel@chromium.orge52678e2013-04-26 18:34:44 +0000693 # Also logs otherwise it could get caught in a try/finally and be hard to
694 # diagnose.
695 if expected_args != args:
tandrii9d206752016-06-20 11:32:47 -0700696 N = 5
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000697 prior_calls = '\n '.join(
tandrii9d206752016-06-20 11:32:47 -0700698 '@%d: %r' % (len(self._calls_done) - N + i, c[0])
699 for i, c in enumerate(self._calls_done[-N:]))
700 following_calls = '\n '.join(
701 '@%d: %r' % (len(self._calls_done) + i + 1, c[0])
702 for i, c in enumerate(self.calls[:N]))
703 extended_msg = (
704 'A few prior calls:\n %s\n\n'
705 'This (expected):\n @%d: %r\n'
706 'This (actual):\n @%d: %r\n\n'
707 'A few following expected calls:\n %s' %
708 (prior_calls, len(self._calls_done), expected_args,
709 len(self._calls_done), args, following_calls))
710 git_cl.logging.error(extended_msg)
711
tandrii99a72f22016-08-17 14:33:24 -0700712 self.fail('@%d\n'
713 ' Expected: %r\n'
714 ' Actual: %r' % (
tandrii9d206752016-06-20 11:32:47 -0700715 len(self._calls_done), expected_args, args))
716
717 self._calls_done.append(top)
tandrii5d48c322016-08-18 16:19:37 -0700718 if isinstance(result, Exception):
719 raise result
Edward Lemur0db01f02019-11-12 22:01:51 +0000720 # stdout from git commands is supposed to be a bytestream. Convert it here
721 # instead of converting all test output in this file to bytes.
722 if args[0][0] == 'git' and not isinstance(result, bytes):
723 result = result.encode('utf-8')
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000724 return result
725
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100726 def test_ask_for_explicit_yes_true(self):
727 self.calls = [
728 (('ask_for_data', 'prompt [Yes/No]: '), 'blah'),
729 (('ask_for_data', 'Please, type yes or no: '), 'ye'),
730 ]
731 self.assertTrue(git_cl.ask_for_explicit_yes('prompt'))
732
tandrii48df5812016-10-17 03:55:37 -0700733 def test_LoadCodereviewSettingsFromFile_gerrit(self):
Edward Lemur79d4f992019-11-11 23:49:02 +0000734 codereview_file = StringIO('GERRIT_HOST: true')
tandrii48df5812016-10-17 03:55:37 -0700735 self.calls = [
736 ((['git', 'config', '--unset-all', 'rietveld.cc'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700737 ((['git', 'config', '--unset-all', 'rietveld.tree-status-url'],), CERR1),
738 ((['git', 'config', '--unset-all', 'rietveld.viewvc-url'],), CERR1),
739 ((['git', 'config', '--unset-all', 'rietveld.bug-prefix'],), CERR1),
740 ((['git', 'config', '--unset-all', 'rietveld.cpplint-regex'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700741 ((['git', 'config', '--unset-all', 'rietveld.cpplint-ignore-regex'],),
742 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700743 ((['git', 'config', '--unset-all', 'rietveld.run-post-upload-hook'],),
744 CERR1),
Jamie Madilldc4d19e2019-10-24 21:50:02 +0000745 ((['git', 'config', '--unset-all', 'rietveld.format-full-by-default'],),
746 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700747 ((['git', 'config', 'gerrit.host', 'true'],), ''),
748 ]
749 self.assertIsNone(git_cl.LoadCodereviewSettingsFromFile(codereview_file))
750
maruel@chromium.orga3353652011-11-30 14:26:57 +0000751 @classmethod
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000752 def _is_gerrit_calls(cls, gerrit=False):
753 return [((['git', 'config', 'rietveld.autoupdate'],), ''),
754 ((['git', 'config', 'gerrit.host'],), 'True' if gerrit else '')]
755
756 @classmethod
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +0000757 def _git_post_upload_calls(cls):
758 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000759 ((['git', 'rev-parse', 'HEAD'],), 'hash'),
rmistry@google.com5626a922015-02-26 14:03:30 +0000760 ((['git', 'config', 'rietveld.run-post-upload-hook'],), ''),
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000761 ]
762
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000763 @staticmethod
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000764 def _git_sanity_checks(diff_base, working_branch, get_remote_branch=True):
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000765 fake_ancestor = 'fake_ancestor'
766 fake_cl = 'fake_cl_for_patch'
767 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000768 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000769 'rev-parse', '--verify', diff_base],), fake_ancestor),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000770 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000771 'merge-base', fake_ancestor, 'HEAD'],), fake_ancestor),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000772 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000773 'rev-list', '^' + fake_ancestor, 'HEAD'],), fake_cl),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000774 # Mock a config miss (error code 1)
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000775 ((['git',
tandrii5d48c322016-08-18 16:19:37 -0700776 'config', 'gitcl.remotebranch'],), CERR1),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000777 ] + ([
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000778 # Call to GetRemoteBranch()
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000779 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000780 'config', 'branch.%s.merge' % working_branch],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000781 'refs/heads/master'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000782 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000783 'config', 'branch.%s.remote' % working_branch],), 'origin'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000784 ] if get_remote_branch else []) + [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000785 ((['git', 'rev-list', '^' + fake_ancestor,
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000786 'refs/remotes/origin/master'],), ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000787 ]
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000788
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000789 @classmethod
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000790 def _gerrit_ensure_auth_calls(
Edward Lemurf38bc172019-09-03 21:02:13 +0000791 cls, issue=None, skip_auth_check=False, short_hostname='chromium',
792 custom_cl_base=None):
shinyak@chromium.org00dbccd2016-04-15 07:24:43 +0000793 cmd = ['git', 'config', '--bool', 'gerrit.skip-ensure-authenticated']
tandrii@chromium.org28253532016-04-14 13:46:56 +0000794 if skip_auth_check:
795 return [((cmd, ), 'true')]
796
tandrii5d48c322016-08-18 16:19:37 -0700797 calls = [((cmd, ), CERR1)]
Edward Lemurf38bc172019-09-03 21:02:13 +0000798
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000799 calls.extend([
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000800 ((['git', 'config', 'remote.origin.url'],),
Edward Lemur85153282020-02-14 22:06:29 +0000801 'https://%s.googlesource.com/my/repo' % short_hostname)
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000802 ])
Edward Lemurf38bc172019-09-03 21:02:13 +0000803
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000804 return calls
805
806 @classmethod
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100807 def _gerrit_base_calls(cls, issue=None, fetched_description=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200808 fetched_status=None, other_cl_owner=None,
Anthony Polito8b955342019-09-24 19:01:36 +0000809 custom_cl_base=None, short_hostname='chromium',
810 change_id=None):
Aaron Gable13101a62018-02-09 13:20:41 -0800811 calls = cls._is_gerrit_calls(True)
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000812
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200813 if custom_cl_base:
814 ancestor_revision = custom_cl_base
815 else:
816 # Determine ancestor_revision to be merge base.
817 ancestor_revision = 'fake_ancestor_sha'
818 calls += [
Edward Lemurda4b6c62020-02-13 00:28:40 +0000819 (('get_or_create_merge_base', 'master', 'refs/remotes/origin/master'),
820 ancestor_revision),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200821 ]
822
823 # Calls to verify branch point is ancestor
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000824 calls += cls._gerrit_ensure_auth_calls(
Edward Lemurf38bc172019-09-03 21:02:13 +0000825 issue=issue, short_hostname=short_hostname,
826 custom_cl_base=custom_cl_base)
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100827
828 if issue:
829 calls += [
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000830 (('GetChangeDetail', '%s-review.googlesource.com' % short_hostname,
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +0000831 'my%2Frepo~123456',
Andrii Shyshkalovc4a73562018-09-25 18:40:17 +0000832 ['DETAILED_ACCOUNTS', 'CURRENT_REVISION', 'CURRENT_COMMIT', 'LABELS']
833 ),
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100834 {
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100835 'owner': {'email': (other_cl_owner or 'owner@example.com')},
Anthony Polito8b955342019-09-24 19:01:36 +0000836 'change_id': (change_id or '123456789'),
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100837 'current_revision': 'sha1_of_current_revision',
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000838 'revisions': {'sha1_of_current_revision': {
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100839 'commit': {'message': fetched_description},
840 }},
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100841 'status': fetched_status or 'NEW',
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100842 }),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100843 ]
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100844 if fetched_status == 'ABANDONED':
845 calls += [
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000846 (('DieWithError', 'Change https://%s-review.googlesource.com/'
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100847 '123456 has been abandoned, new uploads are not '
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000848 'allowed' % short_hostname), SystemExitMock()),
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100849 ]
850 return calls
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100851 if other_cl_owner:
852 calls += [
853 (('ask_for_data', 'Press Enter to upload, or Ctrl+C to abort'), ''),
854 ]
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100855
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200856 calls += cls._git_sanity_checks(ancestor_revision, 'master',
857 get_remote_branch=False)
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100858 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200859 ((['git', 'rev-parse', 'HEAD'],), '12345'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100860 ]
861
862 if not issue:
863 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200864 ((['git', 'log', '--pretty=format:%s%n%n%b',
865 ancestor_revision + '...'],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000866 'foo'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100867 ]
868
869 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200870 ((['git', 'config', 'user.email'],), 'me@example.com'),
Edward Lemur2c48f242019-06-04 16:14:09 +0000871 (('time.time',), 1000,),
872 (('time.time',), 3000,),
873 (('add_repeated', 'sub_commands', {
874 'execution_time': 2000,
875 'command': 'presubmit',
876 'exit_code': 0
877 }), None,),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200878 ((['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] +
879 ([custom_cl_base] if custom_cl_base else
880 [ancestor_revision, 'HEAD']),),
881 '+dat'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100882 ]
883 return calls
ukai@chromium.orge8077812012-02-03 03:41:46 +0000884
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +0000885 @classmethod
886 def _gerrit_upload_calls(cls, description, reviewers, squash,
tandriia60502f2016-06-20 02:01:53 -0700887 squash_mode='default',
tandrii@chromium.org10625002016-03-04 20:03:47 +0000888 expected_upstream_ref='origin/refs/heads/master',
Aaron Gablefd238082017-06-07 13:42:34 -0700889 title=None, notify=False,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +0100890 post_amend_description=None, issue=None, cc=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000891 custom_cl_base=None, tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +0000892 short_hostname='chromium',
Edward Lemur1b52d872019-05-09 21:12:12 +0000893 labels=None, change_id=None, original_title=None,
Anthony Polito8b955342019-09-24 19:01:36 +0000894 final_description=None, gitcookies_exists=True,
Josipe827b0f2020-01-30 00:07:20 +0000895 force=False, edit_description=None):
tandrii@chromium.org10625002016-03-04 20:03:47 +0000896 if post_amend_description is None:
897 post_amend_description = description
bradnelsond975b302016-10-23 12:20:23 -0700898 cc = cc or []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200899 # Determined in `_gerrit_base_calls`.
900 determined_ancestor_revision = custom_cl_base or 'fake_ancestor_sha'
901
902 calls = []
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000903
tandriia60502f2016-06-20 02:01:53 -0700904 if squash_mode == 'default':
905 calls.extend([
906 ((['git', 'config', '--bool', 'gerrit.override-squash-uploads'],), ''),
907 ((['git', 'config', '--bool', 'gerrit.squash-uploads'],), ''),
908 ])
909 elif squash_mode in ('override_squash', 'override_nosquash'):
910 calls.extend([
911 ((['git', 'config', '--bool', 'gerrit.override-squash-uploads'],),
912 'true' if squash_mode == 'override_squash' else 'false'),
913 ])
914 else:
915 assert squash_mode in ('squash', 'nosquash')
916
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000917 # If issue is given, then description is fetched from Gerrit instead.
918 if issue is None:
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000919 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200920 ((['git', 'log', '--pretty=format:%s\n\n%b',
921 ((custom_cl_base + '..') if custom_cl_base else
922 'fake_ancestor_sha..HEAD')],),
923 description),
924 ]
Aaron Gableb56ad332017-01-06 15:24:31 -0800925 if squash:
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000926 title = 'Initial_upload'
Aaron Gableb56ad332017-01-06 15:24:31 -0800927 else:
928 if not title:
929 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200930 ((['git', 'show', '-s', '--format=%s', 'HEAD'],), ''),
931 (('ask_for_data', 'Title for patchset []: '), 'User input'),
Aaron Gableb56ad332017-01-06 15:24:31 -0800932 ]
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000933 title = 'User_input'
tandrii@chromium.org57d86542016-03-04 16:11:32 +0000934 if not git_footers.get_footer_change_id(description) and not squash:
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000935 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200936 (('DownloadGerritHook', False), ''),
937 # Amending of commit message to get the Change-Id.
938 ((['git', 'log', '--pretty=format:%s\n\n%b',
939 determined_ancestor_revision + '..HEAD'],),
940 description),
941 ((['git', 'commit', '--amend', '-m', description],), ''),
942 ((['git', 'log', '--pretty=format:%s\n\n%b',
943 determined_ancestor_revision + '..HEAD'],),
944 post_amend_description)
945 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000946 if squash:
Anthony Polito8b955342019-09-24 19:01:36 +0000947 if force or not issue:
948 if issue:
949 calls += [
950 ((['git', 'config', 'rietveld.bug-prefix'],), ''),
951 ]
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000952 # Prompting to edit description on first upload.
953 calls += [
Jonas Termansend0f79112019-03-22 15:28:26 +0000954 ((['git', 'config', 'rietveld.bug-prefix'],), ''),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000955 ]
Anthony Polito8b955342019-09-24 19:01:36 +0000956 if not force:
957 calls += [
958 ((['git', 'config', 'core.editor'],), ''),
959 ((['RunEditor'],), description),
960 ]
Josipe827b0f2020-01-30 00:07:20 +0000961 # user wants to edit description
962 if edit_description:
963 calls += [
964 ((['git', 'config', 'rietveld.bug-prefix'],), ''),
965 ((['git', 'config', 'core.editor'],), ''),
966 ((['RunEditor'],), edit_description),
967 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000968 ref_to_push = 'abcdef0123456789'
969 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200970 ]
971
972 if custom_cl_base is None:
973 calls += [
Edward Lemurda4b6c62020-02-13 00:28:40 +0000974 (('get_or_create_merge_base', 'master', 'refs/remotes/origin/master'),
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000975 'origin/master'),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200976 ]
977 parent = 'origin/master'
978 else:
979 calls += [
980 ((['git', 'merge-base', '--is-ancestor', custom_cl_base,
981 'refs/remotes/origin/master'],),
982 callError(1)), # Means not ancenstor.
983 (('ask_for_data',
984 'Do you take responsibility for cleaning up potential mess '
985 'resulting from proceeding with upload? Press Enter to upload, '
986 'or Ctrl+C to abort'), ''),
987 ]
988 parent = custom_cl_base
989
990 calls += [
991 ((['git', 'rev-parse', 'HEAD:'],), # `HEAD:` means HEAD's tree hash.
992 '0123456789abcdef'),
993 ((['git', 'commit-tree', '0123456789abcdef', '-p', parent,
Aaron Gable9a03ae02017-11-03 11:31:07 -0700994 '-F', '/tmp/named'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200995 ref_to_push),
996 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000997 else:
998 ref_to_push = 'HEAD'
999
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001000 calls += [
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +00001001 (('SaveDescriptionBackup',), None),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001002 ((['git', 'rev-list',
1003 (custom_cl_base if custom_cl_base else expected_upstream_ref) + '..' +
1004 ref_to_push],),
1005 '1hashPerLine\n'),
1006 ]
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001007
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001008 metrics_arguments = []
1009
Aaron Gableafd52772017-06-27 16:40:10 -07001010 if notify:
Aaron Gable844cf292017-06-28 11:32:59 -07001011 ref_suffix = '%ready,notify=ALL'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001012 metrics_arguments += ['ready', 'notify=ALL']
Aaron Gable844cf292017-06-28 11:32:59 -07001013 else:
Jamie Madill276da0b2018-04-27 14:41:20 -04001014 if not issue and squash:
Aaron Gable844cf292017-06-28 11:32:59 -07001015 ref_suffix = '%wip'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001016 metrics_arguments.append('wip')
Aaron Gable844cf292017-06-28 11:32:59 -07001017 else:
1018 ref_suffix = '%notify=NONE'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001019 metrics_arguments.append('notify=NONE')
Aaron Gable9b713dd2016-12-14 16:04:21 -08001020
Aaron Gable70f4e242017-06-26 10:45:59 -07001021 if title:
Aaron Gableafd52772017-06-27 16:40:10 -07001022 ref_suffix += ',m=' + title
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001023 metrics_arguments.append('m')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001024
Edward Lemur4508b422019-10-03 21:56:35 +00001025 if issue is None:
1026 calls += [
1027 ((['git', 'config', 'rietveld.cc'],), ''),
1028 ]
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001029 if short_hostname == 'chromium':
1030 # All reviwers and ccs get into ref_suffix.
1031 for r in sorted(reviewers):
1032 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001033 metrics_arguments.append('r')
Edward Lemur4508b422019-10-03 21:56:35 +00001034 if issue is None:
1035 cc += ['chromium-reviews+test-more-cc@chromium.org', 'joe@example.com']
1036 for c in sorted(cc):
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001037 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001038 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001039 reviewers, cc = [], []
1040 else:
1041 # TODO(crbug/877717): remove this case.
1042 calls += [
1043 (('ValidAccounts', '%s-review.googlesource.com' % short_hostname,
1044 sorted(reviewers) + ['joe@example.com',
1045 'chromium-reviews+test-more-cc@chromium.org'] + cc),
1046 {
1047 e: {'email': e}
1048 for e in (reviewers + ['joe@example.com'] + cc)
1049 })
1050 ]
1051 for r in sorted(reviewers):
1052 if r != 'bad-account-or-email':
1053 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001054 metrics_arguments.append('r')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001055 reviewers.remove(r)
Edward Lemur4508b422019-10-03 21:56:35 +00001056 if issue is None:
1057 cc += ['joe@example.com']
1058 for c in sorted(cc):
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001059 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001060 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001061 if c in cc:
1062 cc.remove(c)
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00001063
Edward Lemur687ca902018-12-05 02:30:30 +00001064 for k, v in sorted((labels or {}).items()):
1065 ref_suffix += ',l=%s+%d' % (k, v)
1066 metrics_arguments.append('l=%s+%d' % (k, v))
1067
1068 if tbr:
1069 calls += [
1070 (('GetCodeReviewTbrScore',
1071 '%s-review.googlesource.com' % short_hostname,
1072 'my/repo'),
1073 2,),
1074 ]
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001075
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001076 calls += [
1077 (('time.time',), 1000,),
1078 ((['git', 'push',
1079 'https://%s.googlesource.com/my/repo' % short_hostname,
1080 ref_to_push + ':refs/for/refs/heads/master' + ref_suffix],),
1081 (('remote:\n'
1082 'remote: Processing changes: (\)\n'
1083 'remote: Processing changes: (|)\n'
1084 'remote: Processing changes: (/)\n'
1085 'remote: Processing changes: (-)\n'
1086 'remote: Processing changes: new: 1 (/)\n'
1087 'remote: Processing changes: new: 1, done\n'
1088 'remote:\n'
1089 'remote: New Changes:\n'
1090 'remote: https://%s-review.googlesource.com/#/c/my/repo/+/123456'
1091 ' XXX\n'
1092 'remote:\n'
1093 'To https://%s.googlesource.com/my/repo\n'
1094 ' * [new branch] hhhh -> refs/for/refs/heads/master\n'
1095 ) % (short_hostname, short_hostname)),),
1096 (('time.time',), 2000,),
1097 (('add_repeated',
1098 'sub_commands',
1099 {
1100 'execution_time': 1000,
1101 'command': 'git push',
1102 'exit_code': 0,
1103 'arguments': sorted(metrics_arguments),
1104 }),
1105 None,),
1106 ]
1107
Edward Lemur1b52d872019-05-09 21:12:12 +00001108 final_description = final_description or post_amend_description.strip()
1109 original_title = original_title or title or '<untitled>'
1110 # Trace-related calls
1111 calls += [
1112 # Write a description with context for the current trace.
1113 ((['FileWrite', 'TRACES_DIR/20170316T200041.000000-README',
Edward Lemur75391d42019-05-14 23:35:56 +00001114 'Thu Mar 16 20:00:41 2017\n'
1115 '%(short_hostname)s-review.googlesource.com\n'
1116 '%(change_id)s\n'
1117 '%(title)s\n'
1118 '%(description)s\n'
1119 '1000\n'
1120 '0\n'
1121 '%(trace_name)s' % {
Edward Lemur1b52d872019-05-09 21:12:12 +00001122 'short_hostname': short_hostname,
1123 'change_id': change_id,
1124 'description': final_description,
1125 'title': original_title,
Edward Lemur75391d42019-05-14 23:35:56 +00001126 'trace_name': 'TRACES_DIR/20170316T200041.000000',
Edward Lemur1b52d872019-05-09 21:12:12 +00001127 }],),
1128 None,
1129 ),
1130 # Read traces and shorten git hashes.
1131 ((['os.path.isfile', 'TEMP_DIR/trace-packet'],),
1132 True,
1133 ),
1134 ((['FileRead', 'TEMP_DIR/trace-packet'],),
1135 ('git-hash: 0123456789012345678901234567890123456789\n'
1136 'git-hash: abcdeabcdeabcdeabcdeabcdeabcdeabcdeabcde\n'),
1137 ),
1138 ((['FileWrite', 'TEMP_DIR/trace-packet',
1139 'git-hash: 012345\n'
1140 'git-hash: abcdea\n'],),
1141 None,
1142 ),
1143 # Make zip file for the git traces.
1144 ((['make_archive', 'TRACES_DIR/20170316T200041.000000-traces', 'zip',
1145 'TEMP_DIR'],),
1146 None,
1147 ),
1148 # Collect git config and gitcookies.
1149 ((['git', 'config', '-l'],),
1150 'git-config-output',
1151 ),
1152 ((['FileWrite', 'TEMP_DIR/git-config', 'git-config-output'],),
1153 None,
1154 ),
1155 ((['os.path.isfile', '~/.gitcookies'],),
1156 gitcookies_exists,
1157 ),
1158 ]
1159 if gitcookies_exists:
1160 calls += [
1161 ((['FileRead', '~/.gitcookies'],),
1162 'gitcookies 1/SECRET',
1163 ),
1164 ((['FileWrite', 'TEMP_DIR/gitcookies', 'gitcookies REDACTED'],),
1165 None,
1166 ),
1167 ]
1168 calls += [
1169 # Make zip file for the git config and gitcookies.
1170 ((['make_archive', 'TRACES_DIR/20170316T200041.000000-git-info', 'zip',
1171 'TEMP_DIR'],),
1172 None,
1173 ),
1174 ]
1175
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001176 # TODO(crbug/877717): this should never be used.
1177 if squash and short_hostname != 'chromium':
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001178 calls += [
1179 (('AddReviewers',
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001180 'chromium-review.googlesource.com', 'my%2Frepo~123456',
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001181 sorted(reviewers),
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00001182 cc + ['chromium-reviews+test-more-cc@chromium.org'],
1183 notify),
1184 ''),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001185 ]
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +00001186 calls += cls._git_post_upload_calls()
ukai@chromium.orge8077812012-02-03 03:41:46 +00001187 return calls
1188
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001189 def _run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001190 self,
1191 upload_args,
1192 description,
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001193 reviewers=None,
tandriia60502f2016-06-20 02:01:53 -07001194 squash=True,
1195 squash_mode=None,
tandrii@chromium.org10625002016-03-04 20:03:47 +00001196 expected_upstream_ref='origin/refs/heads/master',
Aaron Gable9b713dd2016-12-14 16:04:21 -08001197 title=None,
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001198 notify=False,
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001199 post_amend_description=None,
bradnelsond975b302016-10-23 12:20:23 -07001200 issue=None,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +01001201 cc=None,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001202 fetched_status=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001203 other_cl_owner=None,
Aaron Gablefd238082017-06-07 13:42:34 -07001204 custom_cl_base=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001205 tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001206 short_hostname='chromium',
Edward Lemur1b52d872019-05-09 21:12:12 +00001207 labels=None,
1208 change_id=None,
1209 original_title=None,
1210 final_description=None,
Anthony Polito8b955342019-09-24 19:01:36 +00001211 gitcookies_exists=True,
1212 force=False,
Josipe827b0f2020-01-30 00:07:20 +00001213 edit_description=None,
Anthony Polito8b955342019-09-24 19:01:36 +00001214 fetched_description=None):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001215 """Generic gerrit upload test framework."""
tandriia60502f2016-06-20 02:01:53 -07001216 if squash_mode is None:
1217 if '--no-squash' in upload_args:
1218 squash_mode = 'nosquash'
1219 elif '--squash' in upload_args:
1220 squash_mode = 'squash'
1221 else:
1222 squash_mode = 'default'
1223
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001224 reviewers = reviewers or []
bradnelsond975b302016-10-23 12:20:23 -07001225 cc = cc or []
Edward Lemurda4b6c62020-02-13 00:28:40 +00001226 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001227 CookiesAuthenticatorMockFactory(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001228 same_auth=('git-owner.example.com', '', 'pass'))).start()
1229 mock.patch('git_cl.Changelist._GerritCommitMsgHookCheck',
1230 lambda _, offer_removal: None).start()
1231 mock.patch('git_cl.gclient_utils.RunEditor',
1232 lambda *_, **__: self._mocked_call(['RunEditor'])).start()
1233 mock.patch('git_cl.DownloadGerritHook', lambda force: self._mocked_call(
1234 'DownloadGerritHook', force)).start()
1235 mock.patch('git_cl.gclient_utils.FileRead',
1236 lambda path: self._mocked_call(['FileRead', path])).start()
1237 mock.patch('git_cl.gclient_utils.FileWrite',
Edward Lemur1b52d872019-05-09 21:12:12 +00001238 lambda path, contents: self._mocked_call(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001239 ['FileWrite', path, contents])).start()
1240 mock.patch('git_cl.datetime_now',
1241 lambda: datetime.datetime(2017, 3, 16, 20, 0, 41, 0)).start()
1242 mock.patch('git_cl.tempfile.mkdtemp', lambda: 'TEMP_DIR').start()
1243 mock.patch('git_cl.TRACES_DIR', 'TRACES_DIR').start()
1244 mock.patch('git_cl.TRACES_README_FORMAT',
Edward Lemur75391d42019-05-14 23:35:56 +00001245 '%(now)s\n'
1246 '%(gerrit_host)s\n'
1247 '%(change_id)s\n'
1248 '%(title)s\n'
1249 '%(description)s\n'
1250 '%(execution_time)s\n'
1251 '%(exit_code)s\n'
Edward Lemurda4b6c62020-02-13 00:28:40 +00001252 '%(trace_name)s').start()
1253 mock.patch('git_cl.shutil.make_archive',
1254 lambda *args: self._mocked_call(['make_archive'] +
1255 list(args))).start()
1256 mock.patch('os.path.isfile',
1257 lambda path: self._mocked_call(['os.path.isfile', path])).start()
tandriia60502f2016-06-20 02:01:53 -07001258
Edward Lemur85153282020-02-14 22:06:29 +00001259 self.mockGit.config['branch.master.gerritissue'] = (
1260 str(issue) if issue else None)
1261 self.mockGit.config['remote.origin.url'] = (
1262 'https://%s.googlesource.com/my/repo' % short_hostname)
1263
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001264 self.calls = self._gerrit_base_calls(
1265 issue=issue,
Anthony Polito8b955342019-09-24 19:01:36 +00001266 fetched_description=fetched_description or description,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001267 fetched_status=fetched_status,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001268 other_cl_owner=other_cl_owner,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001269 custom_cl_base=custom_cl_base,
Anthony Polito8b955342019-09-24 19:01:36 +00001270 short_hostname=short_hostname,
1271 change_id=change_id)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001272 if fetched_status != 'ABANDONED':
Edward Lemurda4b6c62020-02-13 00:28:40 +00001273 mock.patch(
1274 'tempfile.NamedTemporaryFile',
1275 MakeNamedTemporaryFileMock(
1276 self, expected_content=description)).start()
1277 mock.patch('os.remove', return_value=True).start()
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001278 self.calls += self._gerrit_upload_calls(
1279 description, reviewers, squash,
1280 squash_mode=squash_mode,
1281 expected_upstream_ref=expected_upstream_ref,
Aaron Gablefd238082017-06-07 13:42:34 -07001282 title=title, notify=notify,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001283 post_amend_description=post_amend_description,
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001284 issue=issue, cc=cc,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001285 custom_cl_base=custom_cl_base, tbr=tbr,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001286 short_hostname=short_hostname,
Edward Lemur1b52d872019-05-09 21:12:12 +00001287 labels=labels,
1288 change_id=change_id,
1289 original_title=original_title,
1290 final_description=final_description,
Anthony Polito8b955342019-09-24 19:01:36 +00001291 gitcookies_exists=gitcookies_exists,
Josipe827b0f2020-01-30 00:07:20 +00001292 force=force,
1293 edit_description=edit_description)
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001294 # Uncomment when debugging.
Raul Tambre80ee78e2019-05-06 22:41:05 +00001295 # print('\n'.join(map(lambda x: '%2i: %s' % x, enumerate(self.calls))))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001296 git_cl.main(['upload'] + upload_args)
Edward Lemur85153282020-02-14 22:06:29 +00001297 if squash:
1298 self.assertEqual(
1299 '123456', scm.GIT.GetBranchConfig(None, 'master', 'gerritissue'))
1300 self.assertEqual(
1301 'https://chromium-review.googlesource.com',
1302 scm.GIT.GetBranchConfig(None, 'master', 'gerritserver'))
1303 self.assertEqual(
1304 'abcdef0123456789',
1305 scm.GIT.GetBranchConfig(None, 'master', 'gerritsquashhash'))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001306
Edward Lemur1b52d872019-05-09 21:12:12 +00001307 def test_gerrit_upload_traces_no_gitcookies(self):
1308 self._run_gerrit_upload_test(
1309 ['--no-squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001310 'desc ✔\n\nBUG=\n',
Edward Lemur1b52d872019-05-09 21:12:12 +00001311 [],
1312 squash=False,
Edward Lemur0db01f02019-11-12 22:01:51 +00001313 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001314 change_id='Ixxx',
1315 gitcookies_exists=False)
1316
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001317 def test_gerrit_upload_without_change_id(self):
tandriia60502f2016-06-20 02:01:53 -07001318 self._run_gerrit_upload_test(
1319 ['--no-squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001320 'desc ✔\n\nBUG=\n',
tandriia60502f2016-06-20 02:01:53 -07001321 [],
1322 squash=False,
Edward Lemur0db01f02019-11-12 22:01:51 +00001323 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001324 change_id='Ixxx')
tandriia60502f2016-06-20 02:01:53 -07001325
1326 def test_gerrit_upload_without_change_id_override_nosquash(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001327 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001328 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001329 'desc ✔\n\nBUG=\n',
tandrii@chromium.org10625002016-03-04 20:03:47 +00001330 [],
tandriia60502f2016-06-20 02:01:53 -07001331 squash=False,
1332 squash_mode='override_nosquash',
Edward Lemur0db01f02019-11-12 22:01:51 +00001333 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001334 change_id='Ixxx')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001335
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001336 def test_gerrit_no_reviewer(self):
1337 self._run_gerrit_upload_test(
1338 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001339 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
tandriia60502f2016-06-20 02:01:53 -07001340 [],
1341 squash=False,
Edward Lemur1b52d872019-05-09 21:12:12 +00001342 squash_mode='override_nosquash',
1343 change_id='I123456789')
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001344
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001345 def test_gerrit_no_reviewer_non_chromium_host(self):
1346 # TODO(crbug/877717): remove this test case.
1347 self._run_gerrit_upload_test(
1348 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001349 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001350 [],
1351 squash=False,
1352 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001353 short_hostname='other',
1354 change_id='I123456789')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001355
Nick Carter8692b182017-11-06 16:30:38 -08001356 def test_gerrit_patchset_title_special_chars(self):
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001357 self._run_gerrit_upload_test(
Nick Carter8692b182017-11-06 16:30:38 -08001358 ['-f', '-t', 'We\'ll escape ^_ ^ special chars...@{u}'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001359 'desc ✔\n\nBUG=\n\nChange-Id: I123456789',
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001360 squash=False,
1361 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001362 title='We%27ll_escape_%5E%5F_%5E_special_chars%2E%2E%2E%40%7Bu%7D',
1363 change_id='I123456789',
1364 original_title='We\'ll escape ^_ ^ special chars...@{u}')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001365
ukai@chromium.orge8077812012-02-03 03:41:46 +00001366 def test_gerrit_reviewers_cmd_line(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001367 self._run_gerrit_upload_test(
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001368 ['-r', 'foo@example.com', '--send-mail'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001369 'desc ✔\n\nBUG=\n\nChange-Id: I123456789',
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001370 ['foo@example.com'],
tandriia60502f2016-06-20 02:01:53 -07001371 squash=False,
1372 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001373 notify=True,
1374 change_id='I123456789',
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001375 final_description=(
Edward Lemur0db01f02019-11-12 22:01:51 +00001376 'desc ✔\n\nBUG=\nR=foo@example.com\n\nChange-Id: I123456789'))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001377
Anthony Polito8b955342019-09-24 19:01:36 +00001378 def test_gerrit_upload_force_sets_bug(self):
1379 self._run_gerrit_upload_test(
1380 ['-b', '10000', '-f'],
1381 u'desc=\n\nBug: 10000\nChange-Id: Ixxx',
1382 [],
1383 force=True,
1384 expected_upstream_ref='origin/master',
1385 fetched_description='desc=\n\nChange-Id: Ixxx',
1386 original_title='Initial upload',
1387 change_id='Ixxx')
1388
1389 def test_gerrit_upload_force_sets_bug_if_wrong_changeid(self):
1390 self._run_gerrit_upload_test(
1391 ['-b', '10000', '-f', '-m', 'Title'],
1392 u'desc=\n\nChange-Id: Ixxxx\n\nChange-Id: Izzzz\nBug: 10000',
1393 [],
1394 force=True,
1395 issue='123456',
1396 expected_upstream_ref='origin/master',
1397 fetched_description='desc=\n\nChange-Id: Ixxxx',
1398 original_title='Title',
1399 title='Title',
1400 change_id='Izzzz')
1401
Dan Beamd8b04ca2019-10-10 21:23:26 +00001402 def test_gerrit_upload_force_sets_fixed(self):
1403 self._run_gerrit_upload_test(
1404 ['-x', '10000', '-f'],
1405 u'desc=\n\nFixed: 10000\nChange-Id: Ixxx',
1406 [],
1407 force=True,
1408 expected_upstream_ref='origin/master',
1409 fetched_description='desc=\n\nChange-Id: Ixxx',
1410 original_title='Initial upload',
1411 change_id='Ixxx')
1412
ukai@chromium.orge8077812012-02-03 03:41:46 +00001413 def test_gerrit_reviewer_multiple(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00001414 mock.patch('git_cl.gerrit_util.GetCodeReviewTbrScore',
1415 lambda *a: self._mocked_call('GetCodeReviewTbrScore', *a)).start()
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001416 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001417 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001418 'desc ✔\nTBR=reviewer@example.com\nBUG=\nR=another@example.com\n'
bradnelsond975b302016-10-23 12:20:23 -07001419 'CC=more@example.com,people@example.com\n\n'
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001420 'Change-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001421 ['reviewer@example.com', 'another@example.com'],
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001422 expected_upstream_ref='origin/master',
Aaron Gablefd238082017-06-07 13:42:34 -07001423 cc=['more@example.com', 'people@example.com'],
Edward Lemur687ca902018-12-05 02:30:30 +00001424 tbr='reviewer@example.com',
Edward Lemur1b52d872019-05-09 21:12:12 +00001425 labels={'Code-Review': 2},
1426 change_id='123456789',
1427 original_title='Initial upload')
tandriia60502f2016-06-20 02:01:53 -07001428
1429 def test_gerrit_upload_squash_first_is_default(self):
tandriia60502f2016-06-20 02:01:53 -07001430 self._run_gerrit_upload_test(
1431 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001432 'desc ✔\nBUG=\n\nChange-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001433 [],
Edward Lemur1b52d872019-05-09 21:12:12 +00001434 expected_upstream_ref='origin/master',
1435 change_id='123456789',
1436 original_title='Initial upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001437
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001438 def test_gerrit_upload_squash_first(self):
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001439 self._run_gerrit_upload_test(
1440 ['--squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001441 'desc ✔\nBUG=\n\nChange-Id: 123456789',
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001442 [],
luqui@chromium.org609f3952015-05-04 22:47:04 +00001443 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001444 expected_upstream_ref='origin/master',
1445 change_id='123456789',
1446 original_title='Initial upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001447
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001448 def test_gerrit_upload_squash_first_with_labels(self):
1449 self._run_gerrit_upload_test(
1450 ['--squash', '--cq-dry-run', '--enable-auto-submit'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001451 'desc ✔\nBUG=\n\nChange-Id: 123456789',
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001452 [],
1453 squash=True,
1454 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001455 labels={'Commit-Queue': 1, 'Auto-Submit': 1},
1456 change_id='123456789',
1457 original_title='Initial upload')
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001458
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001459 def test_gerrit_upload_squash_first_against_rev(self):
1460 custom_cl_base = 'custom_cl_base_rev_or_branch'
1461 self._run_gerrit_upload_test(
1462 ['--squash', custom_cl_base],
Edward Lemur0db01f02019-11-12 22:01:51 +00001463 'desc ✔\nBUG=\n\nChange-Id: 123456789',
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001464 [],
1465 squash=True,
1466 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001467 custom_cl_base=custom_cl_base,
1468 change_id='123456789',
1469 original_title='Initial upload')
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001470 self.assertIn(
1471 'If you proceed with upload, more than 1 CL may be created by Gerrit',
1472 sys.stdout.getvalue())
1473
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001474 def test_gerrit_upload_squash_reupload(self):
Edward Lemur0db01f02019-11-12 22:01:51 +00001475 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001476 self._run_gerrit_upload_test(
1477 ['--squash'],
1478 description,
1479 [],
1480 squash=True,
1481 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001482 issue=123456,
1483 change_id='123456789',
1484 original_title='User input')
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001485
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001486 def test_gerrit_upload_squash_reupload_to_abandoned(self):
Edward Lemur0db01f02019-11-12 22:01:51 +00001487 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001488 with self.assertRaises(SystemExitMock):
1489 self._run_gerrit_upload_test(
1490 ['--squash'],
1491 description,
1492 [],
1493 squash=True,
1494 expected_upstream_ref='origin/master',
1495 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001496 fetched_status='ABANDONED',
1497 change_id='123456789')
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001498
Edward Lemurda4b6c62020-02-13 00:28:40 +00001499 @mock.patch(
1500 'gerrit_util.GetAccountDetails',
1501 return_value={'email': 'yet-another@example.com'})
1502 def test_gerrit_upload_squash_reupload_to_not_owned(self, _mock):
Edward Lemur0db01f02019-11-12 22:01:51 +00001503 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001504 self._run_gerrit_upload_test(
1505 ['--squash'],
1506 description,
1507 [],
1508 squash=True,
1509 expected_upstream_ref='origin/master',
1510 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001511 other_cl_owner='other@example.com',
1512 change_id='123456789',
1513 original_title='User input')
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001514 self.assertIn(
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001515 'WARNING: Change 123456 is owned by other@example.com, but you '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001516 'authenticate to Gerrit as yet-another@example.com.\n'
1517 'Uploading may fail due to lack of permissions',
Edward Lemurda4b6c62020-02-13 00:28:40 +00001518 sys.stdout.getvalue())
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001519
Josipe827b0f2020-01-30 00:07:20 +00001520 def test_upload_change_description_editor(self):
1521 fetched_description = 'foo\n\nChange-Id: 123456789'
1522 description = 'bar\n\nChange-Id: 123456789'
1523 self._run_gerrit_upload_test(
1524 ['--squash', '--edit-description'],
1525 description,
1526 [],
1527 fetched_description=fetched_description,
1528 squash=True,
1529 expected_upstream_ref='origin/master',
1530 issue=123456,
1531 change_id='123456789',
1532 original_title='User input',
1533 edit_description=description)
1534
Edward Lemurda4b6c62020-02-13 00:28:40 +00001535 @mock.patch('git_cl.RunGit')
1536 @mock.patch('git_cl.CMDupload')
1537 @mock.patch('git_cl.ask_for_data')
1538 def test_upload_branch_deps(self, *_mocks):
rmistry@google.com2dd99862015-06-22 12:22:18 +00001539 def mock_run_git(*args, **_kwargs):
1540 if args[0] == ['for-each-ref',
1541 '--format=%(refname:short) %(upstream:short)',
1542 'refs/heads']:
1543 # Create a local branch dependency tree that looks like this:
1544 # test1 -> test2 -> test3 -> test4 -> test5
1545 # -> test3.1
1546 # test6 -> test0
1547 branch_deps = [
1548 'test2 test1', # test1 -> test2
1549 'test3 test2', # test2 -> test3
1550 'test3.1 test2', # test2 -> test3.1
1551 'test4 test3', # test3 -> test4
1552 'test5 test4', # test4 -> test5
1553 'test6 test0', # test0 -> test6
1554 'test7', # test7
1555 ]
1556 return '\n'.join(branch_deps)
Edward Lemurda4b6c62020-02-13 00:28:40 +00001557 git_cl.RunGit.side_effect = mock_run_git
1558 git_cl.CMDupload.return_value = 0
rmistry@google.com2dd99862015-06-22 12:22:18 +00001559
1560 class MockChangelist():
1561 def __init__(self):
1562 pass
1563 def GetBranch(self):
1564 return 'test1'
1565 def GetIssue(self):
1566 return '123'
1567 def GetPatchset(self):
1568 return '1001'
tandrii@chromium.org4c72b082016-03-31 22:26:35 +00001569 def IsGerrit(self):
1570 return False
rmistry@google.com2dd99862015-06-22 12:22:18 +00001571
1572 ret = git_cl.upload_branch_deps(MockChangelist(), [])
1573 # CMDupload should have been called 5 times because of 5 dependent branches.
Edward Lemurda4b6c62020-02-13 00:28:40 +00001574 self.assertEqual(5, len(git_cl.CMDupload.mock_calls))
1575 git_cl.ask_for_data.assert_called_once_with(
1576 'This command will checkout all dependent branches '
1577 'and run "git cl upload". Press Enter to continue, '
1578 'or Ctrl+C to abort')
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00001579 self.assertEqual(0, ret)
rmistry@google.com2dd99862015-06-22 12:22:18 +00001580
tandrii@chromium.org65874e12016-03-04 12:03:02 +00001581 def test_gerrit_change_id(self):
1582 self.calls = [
1583 ((['git', 'write-tree'], ),
1584 'hashtree'),
1585 ((['git', 'rev-parse', 'HEAD~0'], ),
1586 'branch-parent'),
1587 ((['git', 'var', 'GIT_AUTHOR_IDENT'], ),
1588 'A B <a@b.org> 1456848326 +0100'),
1589 ((['git', 'var', 'GIT_COMMITTER_IDENT'], ),
1590 'C D <c@d.org> 1456858326 +0100'),
1591 ((['git', 'hash-object', '-t', 'commit', '--stdin'], ),
1592 'hashchange'),
1593 ]
1594 change_id = git_cl.GenerateGerritChangeId('line1\nline2\n')
1595 self.assertEqual(change_id, 'Ihashchange')
1596
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001597 def test_desecription_append_footer(self):
1598 for init_desc, footer_line, expected_desc in [
1599 # Use unique desc first lines for easy test failure identification.
1600 ('foo', 'R=one', 'foo\n\nR=one'),
1601 ('foo\n\nR=one', 'BUG=', 'foo\n\nR=one\nBUG='),
1602 ('foo\n\nR=one', 'Change-Id: Ixx', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1603 ('foo\n\nChange-Id: Ixx', 'R=one', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1604 ('foo\n\nR=one\n\nChange-Id: Ixx', 'TBR=two',
1605 'foo\n\nR=one\nTBR=two\n\nChange-Id: Ixx'),
1606 ('foo\n\nR=one\n\nChange-Id: Ixx', 'Foo-Bar: baz',
1607 'foo\n\nR=one\n\nChange-Id: Ixx\nFoo-Bar: baz'),
1608 ('foo\n\nChange-Id: Ixx', 'Foo-Bak: baz',
1609 'foo\n\nChange-Id: Ixx\nFoo-Bak: baz'),
1610 ('foo', 'Change-Id: Ixx', 'foo\n\nChange-Id: Ixx'),
1611 ]:
1612 desc = git_cl.ChangeDescription(init_desc)
1613 desc.append_footer(footer_line)
1614 self.assertEqual(desc.description, expected_desc)
1615
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001616 def test_update_reviewers(self):
1617 data = [
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001618 ('foo', [], [],
1619 'foo'),
1620 ('foo\nR=xx', [], [],
1621 'foo\nR=xx'),
1622 ('foo\nTBR=xx', [], [],
1623 'foo\nTBR=xx'),
1624 ('foo', ['a@c'], [],
1625 'foo\n\nR=a@c'),
1626 ('foo\nR=xx', ['a@c'], [],
1627 'foo\n\nR=a@c, xx'),
1628 ('foo\nTBR=xx', ['a@c'], [],
1629 'foo\n\nR=a@c\nTBR=xx'),
1630 ('foo\nTBR=xx\nR=yy', ['a@c'], [],
1631 'foo\n\nR=a@c, yy\nTBR=xx'),
1632 ('foo\nBUG=', ['a@c'], [],
1633 'foo\nBUG=\nR=a@c'),
1634 ('foo\nR=xx\nTBR=yy\nR=bar', ['a@c'], [],
1635 'foo\n\nR=a@c, bar, xx\nTBR=yy'),
1636 ('foo', ['a@c', 'b@c'], [],
1637 'foo\n\nR=a@c, b@c'),
1638 ('foo\nBar\n\nR=\nBUG=', ['c@c'], [],
1639 'foo\nBar\n\nR=c@c\nBUG='),
1640 ('foo\nBar\n\nR=\nBUG=\nR=', ['c@c'], [],
1641 'foo\nBar\n\nR=c@c\nBUG='),
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001642 # Same as the line before, but full of whitespaces.
1643 (
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001644 'foo\nBar\n\n R = \n BUG = \n R = ', ['c@c'], [],
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001645 'foo\nBar\n\nR=c@c\n BUG =',
1646 ),
1647 # Whitespaces aren't interpreted as new lines.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001648 ('foo BUG=allo R=joe ', ['c@c'], [],
1649 'foo BUG=allo R=joe\n\nR=c@c'),
1650 # Redundant TBRs get promoted to Rs
1651 ('foo\n\nR=a@c\nTBR=t@c', ['b@c', 'a@c'], ['a@c', 't@c'],
1652 'foo\n\nR=a@c, b@c\nTBR=t@c'),
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001653 ]
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001654 expected = [i[-1] for i in data]
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001655 actual = []
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001656 for orig, reviewers, tbrs, _expected in data:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001657 obj = git_cl.ChangeDescription(orig)
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001658 obj.update_reviewers(reviewers, tbrs)
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001659 actual.append(obj.description)
1660 self.assertEqual(expected, actual)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001661
Nodir Turakulov23b82142017-11-16 11:04:25 -08001662 def test_get_hash_tags(self):
1663 cases = [
1664 ('', []),
1665 ('a', []),
1666 ('[a]', ['a']),
1667 ('[aa]', ['aa']),
1668 ('[a ]', ['a']),
1669 ('[a- ]', ['a']),
1670 ('[a- b]', ['a-b']),
1671 ('[a--b]', ['a-b']),
1672 ('[a', []),
1673 ('[a]x', ['a']),
1674 ('[aa]x', ['aa']),
1675 ('[a b]', ['a-b']),
1676 ('[a b]', ['a-b']),
1677 ('[a__b]', ['a-b']),
1678 ('[a] x', ['a']),
1679 ('[a][b]', ['a', 'b']),
1680 ('[a] [b]', ['a', 'b']),
1681 ('[a][b]x', ['a', 'b']),
1682 ('[a][b] x', ['a', 'b']),
1683 ('[a]\n[b]', ['a']),
1684 ('[a\nb]', []),
1685 ('[a][', ['a']),
1686 ('Revert "[a] feature"', ['a']),
1687 ('Reland "[a] feature"', ['a']),
1688 ('Revert: [a] feature', ['a']),
1689 ('Reland: [a] feature', ['a']),
1690 ('Revert "Reland: [a] feature"', ['a']),
1691 ('Foo: feature', ['foo']),
1692 ('Foo Bar: feature', ['foo-bar']),
Anthony Polito02b5af32019-12-02 19:49:47 +00001693 ('Change Foo::Bar', []),
1694 ('Foo: Change Foo::Bar', ['foo']),
Nodir Turakulov23b82142017-11-16 11:04:25 -08001695 ('Revert "Foo bar: feature"', ['foo-bar']),
1696 ('Reland "Foo bar: feature"', ['foo-bar']),
1697 ]
1698 for desc, expected in cases:
1699 change_desc = git_cl.ChangeDescription(desc)
1700 actual = change_desc.get_hash_tags()
1701 self.assertEqual(
1702 actual,
1703 expected,
1704 'GetHashTags(%r) == %r, expected %r' % (desc, actual, expected))
1705
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001706 self.assertEqual(None, git_cl.GetTargetRef('origin', None, 'master'))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001707 self.assertEqual(None, git_cl.GetTargetRef(None,
1708 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001709 'master'))
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001710
wittman@chromium.org455dc922015-01-26 20:15:50 +00001711 # Check default target refs for branches.
1712 self.assertEqual('refs/heads/master',
1713 git_cl.GetTargetRef('origin', 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001714 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001715 self.assertEqual('refs/heads/master',
1716 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkgr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001717 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001718 self.assertEqual('refs/heads/master',
1719 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkcr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001720 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001721 self.assertEqual('refs/branch-heads/123',
1722 git_cl.GetTargetRef('origin',
1723 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001724 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001725 self.assertEqual('refs/diff/test',
1726 git_cl.GetTargetRef('origin',
1727 'refs/remotes/origin/refs/diff/test',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001728 None))
rmistry@google.comc68112d2015-03-03 12:48:06 +00001729 self.assertEqual('refs/heads/chrome/m42',
1730 git_cl.GetTargetRef('origin',
1731 'refs/remotes/origin/chrome/m42',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001732 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001733
1734 # Check target refs for user-specified target branch.
1735 for branch in ('branch-heads/123', 'remotes/branch-heads/123',
1736 'refs/remotes/branch-heads/123'):
1737 self.assertEqual('refs/branch-heads/123',
1738 git_cl.GetTargetRef('origin',
1739 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001740 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001741 for branch in ('origin/master', 'remotes/origin/master',
1742 'refs/remotes/origin/master'):
1743 self.assertEqual('refs/heads/master',
1744 git_cl.GetTargetRef('origin',
1745 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001746 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001747 for branch in ('master', 'heads/master', 'refs/heads/master'):
1748 self.assertEqual('refs/heads/master',
1749 git_cl.GetTargetRef('origin',
1750 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001751 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001752
Edward Lemurda4b6c62020-02-13 00:28:40 +00001753 @mock.patch('git_common.is_dirty_git_tree', return_value=True)
1754 def test_patch_when_dirty(self, *_mocks):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001755 # Patch when local tree is dirty.
wychen@chromium.orga872e752015-04-28 23:42:18 +00001756 self.assertNotEqual(git_cl.main(['patch', '123456']), 0)
1757
Edward Lemur85153282020-02-14 22:06:29 +00001758 def assertIssueAndPatchset(
1759 self, branch='master', issue='123456', patchset='7',
1760 git_short_host='chromium'):
1761 self.assertEqual(
1762 issue, scm.GIT.GetBranchConfig(None, branch, 'gerritissue'))
1763 self.assertEqual(
1764 patchset, scm.GIT.GetBranchConfig(None, branch, 'gerritpatchset'))
1765 self.assertEqual(
1766 'https://%s-review.googlesource.com' % git_short_host,
1767 scm.GIT.GetBranchConfig(None, branch, 'gerritserver'))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001768
Edward Lemur85153282020-02-14 22:06:29 +00001769 def _patch_common(self, git_short_host='chromium'):
Edward Lemurda4b6c62020-02-13 00:28:40 +00001770 mock.patch('git_cl.IsGitVersionAtLeast', return_value=True).start()
wychen@chromium.orga872e752015-04-28 23:42:18 +00001771
Edward Lemur85153282020-02-14 22:06:29 +00001772 self.calls += [
1773 ((['git', 'config', 'remote.origin.url'],),
1774 'https://%s.googlesource.com/my/repo' % git_short_host),
1775 (('GetChangeDetail', git_short_host + '-review.googlesource.com',
1776 'my%2Frepo~123456', ['ALL_REVISIONS', 'CURRENT_COMMIT']),
1777 {
1778 'current_revision': '7777777777',
1779 'revisions': {
1780 '1111111111': {
1781 '_number': 1,
1782 'fetch': {'http': {
1783 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1784 'ref': 'refs/changes/56/123456/1',
1785 }},
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001786 },
Edward Lemur85153282020-02-14 22:06:29 +00001787 '7777777777': {
1788 '_number': 7,
1789 'fetch': {'http': {
1790 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1791 'ref': 'refs/changes/56/123456/7',
1792 }},
1793 },
1794 },
1795 }),
1796 ]
wychen@chromium.orga872e752015-04-28 23:42:18 +00001797
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001798 def test_patch_gerrit_default(self):
Edward Lemur85153282020-02-14 22:06:29 +00001799 self._patch_common()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001800 self.calls += [
1801 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1802 'refs/changes/56/123456/7'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001803 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001804 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001805 ]
1806 self.assertEqual(git_cl.main(['patch', '123456']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001807 self.assertIssueAndPatchset()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001808
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001809 def test_patch_gerrit_new_branch(self):
Edward Lemur85153282020-02-14 22:06:29 +00001810 self._patch_common()
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001811 self.calls += [
1812 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1813 'refs/changes/56/123456/7'],), ''),
1814 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001815 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001816 ]
Edward Lemur85153282020-02-14 22:06:29 +00001817 self.assertEqual(git_cl.main(['patch', '-b', 'feature', '123456']), 0)
1818 self.assertIssueAndPatchset(branch='feature')
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001819
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001820 def test_patch_gerrit_force(self):
Edward Lemur85153282020-02-14 22:06:29 +00001821 self._patch_common('host')
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001822 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001823 ((['git', 'fetch', 'https://host.googlesource.com/my/repo',
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001824 'refs/changes/56/123456/7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001825 ((['git', 'reset', '--hard', 'FETCH_HEAD'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001826 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001827 ]
Edward Lemur52969c92020-02-06 18:15:28 +00001828 self.assertEqual(git_cl.main(['patch', '123456', '--force']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001829 self.assertIssueAndPatchset(git_short_host='host')
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001830
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001831 def test_patch_gerrit_guess_by_url(self):
Edward Lemur85153282020-02-14 22:06:29 +00001832 self._patch_common('else')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001833 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001834 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001835 'refs/changes/56/123456/1'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001836 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001837 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001838 ]
1839 self.assertEqual(git_cl.main(
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001840 ['patch', 'https://else-review.googlesource.com/#/c/123456/1']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001841 self.assertIssueAndPatchset(patchset='1', git_short_host='else')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001842
Aaron Gable697a91b2018-01-19 15:20:15 -08001843 def test_patch_gerrit_guess_by_url_with_repo(self):
Edward Lemur85153282020-02-14 22:06:29 +00001844 self._patch_common('else')
Aaron Gable697a91b2018-01-19 15:20:15 -08001845 self.calls += [
1846 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
1847 'refs/changes/56/123456/1'],), ''),
1848 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
Aaron Gable697a91b2018-01-19 15:20:15 -08001849 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
Aaron Gable697a91b2018-01-19 15:20:15 -08001850 ]
1851 self.assertEqual(git_cl.main(
1852 ['patch', 'https://else-review.googlesource.com/c/my/repo/+/123456/1']),
1853 0)
Edward Lemur85153282020-02-14 22:06:29 +00001854 self.assertIssueAndPatchset(patchset='1', git_short_host='else')
Aaron Gable697a91b2018-01-19 15:20:15 -08001855
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001856 def test_patch_gerrit_conflict(self):
Edward Lemur85153282020-02-14 22:06:29 +00001857 self._patch_common()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001858 self.calls += [
1859 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001860 'refs/changes/56/123456/7'],), ''),
tandrii5d48c322016-08-18 16:19:37 -07001861 ((['git', 'cherry-pick', 'FETCH_HEAD'],), CERR1),
Edward Lemurda4b6c62020-02-13 00:28:40 +00001862 (('DieWithError', 'Command "git cherry-pick FETCH_HEAD" failed.\n'),
tandrii5d48c322016-08-18 16:19:37 -07001863 SystemExitMock()),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001864 ]
1865 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001866 git_cl.main(['patch', '123456'])
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001867
Edward Lemurda4b6c62020-02-13 00:28:40 +00001868 @mock.patch(
1869 'git_cl.gerrit_util.GetChangeDetail',
1870 side_effect=gerrit_util.GerritError(404, ''))
1871 def test_patch_gerrit_not_exists(self, *_mocks):
tandriic2405f52016-10-10 08:13:15 -07001872 self.calls = [
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001873 ((['git', 'config', 'remote.origin.url'],),
1874 'https://chromium.googlesource.com/my/repo'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00001875 (('DieWithError',
1876 'change 123456 at https://chromium-review.googlesource.com does not '
1877 'exist or you have no access to it'), SystemExitMock()),
tandriic2405f52016-10-10 08:13:15 -07001878 ]
1879 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001880 self.assertEqual(1, git_cl.main(['patch', '123456']))
tandriic2405f52016-10-10 08:13:15 -07001881
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001882 def _checkout_calls(self):
1883 return [
1884 ((['git', 'config', '--local', '--get-regexp',
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001885 'branch\\..*\\.gerritissue'], ),
1886 ('branch.ger-branch.gerritissue 123456\n'
1887 'branch.gbranch654.gerritissue 654321\n')),
1888 ]
1889
1890 def test_checkout_gerrit(self):
1891 """Tests git cl checkout <issue>."""
1892 self.calls = self._checkout_calls()
1893 self.calls += [((['git', 'checkout', 'ger-branch'], ), '')]
1894 self.assertEqual(0, git_cl.main(['checkout', '123456']))
1895
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001896 def test_checkout_not_found(self):
1897 """Tests git cl checkout <issue>."""
1898 self.calls = self._checkout_calls()
1899 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1900
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001901 def test_checkout_no_branch_issues(self):
1902 """Tests git cl checkout <issue>."""
1903 self.calls = [
1904 ((['git', 'config', '--local', '--get-regexp',
tandrii5d48c322016-08-18 16:19:37 -07001905 'branch\\..*\\.gerritissue'], ), CERR1),
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001906 ]
1907 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1908
tandrii@chromium.org28253532016-04-14 13:46:56 +00001909 def _test_gerrit_ensure_authenticated_common(self, auth,
1910 skip_auth_check=False):
Edward Lemurda4b6c62020-02-13 00:28:40 +00001911 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
1912 CookiesAuthenticatorMockFactory(hosts_with_creds=auth)).start()
tandrii@chromium.org28253532016-04-14 13:46:56 +00001913 self.calls = self._gerrit_ensure_auth_calls(skip_auth_check=skip_auth_check)
Edward Lemurf38bc172019-09-03 21:02:13 +00001914 cl = git_cl.Changelist()
tandrii@chromium.org28253532016-04-14 13:46:56 +00001915 cl.branch = 'master'
1916 cl.branchref = 'refs/heads/master'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001917 return cl
1918
1919 def test_gerrit_ensure_authenticated_missing(self):
1920 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001921 'chromium.googlesource.com': ('git-is.ok', '', 'but gerrit is missing'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001922 })
1923 self.calls.append(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001924 (('DieWithError',
1925 'Credentials for the following hosts are required:\n'
1926 ' chromium-review.googlesource.com\n'
1927 'These are read from ~/.gitcookies (or legacy ~/.netrc)\n'
1928 'You can (re)generate your credentials by visiting '
1929 'https://chromium-review.googlesource.com/new-password'), ''),)
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001930 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1931
1932 def test_gerrit_ensure_authenticated_conflict(self):
1933 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001934 'chromium.googlesource.com':
1935 ('git-one.example.com', None, 'secret1'),
1936 'chromium-review.googlesource.com':
1937 ('git-other.example.com', None, 'secret2'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001938 })
1939 self.calls.append(
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001940 (('ask_for_data', 'If you know what you are doing '
1941 'press Enter to continue, or Ctrl+C to abort'), ''))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001942 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1943
1944 def test_gerrit_ensure_authenticated_ok(self):
1945 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001946 'chromium.googlesource.com':
1947 ('git-same.example.com', None, 'secret'),
1948 'chromium-review.googlesource.com':
1949 ('git-same.example.com', None, 'secret'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001950 })
1951 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1952
tandrii@chromium.org28253532016-04-14 13:46:56 +00001953 def test_gerrit_ensure_authenticated_skipped(self):
1954 cl = self._test_gerrit_ensure_authenticated_common(
1955 auth={}, skip_auth_check=True)
1956 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1957
Eric Boren2fb63102018-10-05 13:05:03 +00001958 def test_gerrit_ensure_authenticated_bearer_token(self):
1959 cl = self._test_gerrit_ensure_authenticated_common(auth={
1960 'chromium.googlesource.com':
1961 ('', None, 'secret'),
1962 'chromium-review.googlesource.com':
1963 ('', None, 'secret'),
1964 })
1965 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1966 header = gerrit_util.CookiesAuthenticator().get_auth_header(
1967 'chromium.googlesource.com')
1968 self.assertTrue('Bearer' in header)
1969
Daniel Chengcf6269b2019-05-18 01:02:12 +00001970 def test_gerrit_ensure_authenticated_non_https(self):
1971 self.calls = [
1972 ((['git', 'config', '--bool',
1973 'gerrit.skip-ensure-authenticated'],), CERR1),
Daniel Chengcf6269b2019-05-18 01:02:12 +00001974 ((['git', 'config', 'remote.origin.url'],), 'custom-scheme://repo'),
Josip906bfde2020-01-31 22:38:49 +00001975 (('logging.warning',
1976 'Ignoring branch %(branch)s with non-https remote '
1977 '%(remote)s', {
1978 'branch': 'master',
1979 'remote': 'custom-scheme://repo'}
1980 ), None),
Daniel Chengcf6269b2019-05-18 01:02:12 +00001981 ]
Edward Lemurda4b6c62020-02-13 00:28:40 +00001982 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
1983 CookiesAuthenticatorMockFactory(hosts_with_creds={})).start()
1984 mock.patch('logging.warning',
1985 lambda *a: self._mocked_call('logging.warning', *a)).start()
Edward Lemurf38bc172019-09-03 21:02:13 +00001986 cl = git_cl.Changelist()
Daniel Chengcf6269b2019-05-18 01:02:12 +00001987 cl.branch = 'master'
1988 cl.branchref = 'refs/heads/master'
1989 cl.lookedup_issue = True
1990 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1991
Florian Mayerae510e82020-01-30 21:04:48 +00001992 def test_gerrit_ensure_authenticated_non_url(self):
1993 self.calls = [
1994 ((['git', 'config', '--bool', 'gerrit.skip-ensure-authenticated'], ),
1995 CERR1),
Florian Mayerae510e82020-01-30 21:04:48 +00001996 ((['git', 'config', 'remote.origin.url'], ),
1997 'git@somehost.example:foo/bar.git'),
Josip906bfde2020-01-31 22:38:49 +00001998 (('logging.error',
1999 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
2000 'but it doesn\'t exist.', {
2001 'remote': 'origin',
2002 'branch': 'master',
2003 'url': 'git@somehost.example:foo/bar.git'}
2004 ), None),
Florian Mayerae510e82020-01-30 21:04:48 +00002005 ]
Edward Lemurda4b6c62020-02-13 00:28:40 +00002006 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
2007 CookiesAuthenticatorMockFactory(hosts_with_creds={})).start()
2008 mock.patch('logging.error',
2009 lambda *a: self._mocked_call('logging.error', *a)).start()
Florian Mayerae510e82020-01-30 21:04:48 +00002010 cl = git_cl.Changelist()
2011 cl.branch = 'master'
2012 cl.branchref = 'refs/heads/master'
2013 cl.lookedup_issue = True
2014 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2015
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002016 def _cmd_set_commit_gerrit_common(self, vote, notify=None):
Edward Lemur85153282020-02-14 22:06:29 +00002017 self.mockGit.config['branch.master.gerritissue'] = '123'
2018 self.mockGit.config['branch.master.gerritserver'] = (
2019 'https://chromium-review.googlesource.com')
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002020 self.calls = [
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002021 ((['git', 'config', 'remote.origin.url'],),
2022 'https://chromium.googlesource.com/infra/infra.git'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002023 (('SetReview', 'chromium-review.googlesource.com',
2024 'infra%2Finfra~123', None,
2025 {'Commit-Queue': vote}, notify, None), ''),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002026 ]
tandriid9e5ce52016-07-13 02:32:59 -07002027
2028 def test_cmd_set_commit_gerrit_clear(self):
2029 self._cmd_set_commit_gerrit_common(0)
2030 self.assertEqual(0, git_cl.main(['set-commit', '-c']))
2031
2032 def test_cmd_set_commit_gerrit_dry(self):
Aaron Gable75e78722017-06-09 10:40:16 -07002033 self._cmd_set_commit_gerrit_common(1, notify=False)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002034 self.assertEqual(0, git_cl.main(['set-commit', '-d']))
2035
tandriid9e5ce52016-07-13 02:32:59 -07002036 def test_cmd_set_commit_gerrit(self):
2037 self._cmd_set_commit_gerrit_common(2)
2038 self.assertEqual(0, git_cl.main(['set-commit']))
2039
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002040 def test_description_display(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002041 mock.patch('git_cl.Changelist', ChangelistMock).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002042 ChangelistMock.desc = 'foo\n'
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002043
2044 self.assertEqual(0, git_cl.main(['description', '-d']))
Edward Lemurda4b6c62020-02-13 00:28:40 +00002045 self.assertEqual('foo\n', sys.stdout.getvalue())
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002046
Edward Lemurda4b6c62020-02-13 00:28:40 +00002047 @mock.patch('sys.stderr', StringIO())
iannucci3c972b92016-08-17 13:24:10 -07002048 def test_StatusFieldOverrideIssueMissingArgs(self):
iannucci3c972b92016-08-17 13:24:10 -07002049 try:
2050 self.assertEqual(git_cl.main(['status', '--issue', '1']), 0)
2051 except SystemExit as ex:
2052 self.assertEqual(ex.code, 2)
Edward Lemur6c6827c2020-02-06 21:15:18 +00002053 self.assertIn(
Edward Lemurda4b6c62020-02-13 00:28:40 +00002054 '--field must be given when --issue is set.', sys.stderr.getvalue())
iannucci3c972b92016-08-17 13:24:10 -07002055
2056 def test_StatusFieldOverrideIssue(self):
iannucci3c972b92016-08-17 13:24:10 -07002057 def assertIssue(cl_self, *_args):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002058 self.assertEqual(cl_self.issue, 1)
iannucci3c972b92016-08-17 13:24:10 -07002059 return 'foobar'
2060
Edward Lemurda4b6c62020-02-13 00:28:40 +00002061 mock.patch('git_cl.Changelist.FetchDescription', assertIssue).start()
iannuccie53c9352016-08-17 14:40:40 -07002062 self.assertEqual(
Edward Lemur52969c92020-02-06 18:15:28 +00002063 git_cl.main(['status', '--issue', '1', '--field', 'desc']),
iannuccie53c9352016-08-17 14:40:40 -07002064 0)
Edward Lemurda4b6c62020-02-13 00:28:40 +00002065 self.assertEqual(sys.stdout.getvalue(), 'foobar\n')
iannucci3c972b92016-08-17 13:24:10 -07002066
iannuccie53c9352016-08-17 14:40:40 -07002067 def test_SetCloseOverrideIssue(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002068
iannuccie53c9352016-08-17 14:40:40 -07002069 def assertIssue(cl_self, *_args):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002070 self.assertEqual(cl_self.issue, 1)
iannuccie53c9352016-08-17 14:40:40 -07002071 return 'foobar'
2072
Edward Lemurda4b6c62020-02-13 00:28:40 +00002073 mock.patch('git_cl.Changelist.FetchDescription', assertIssue).start()
2074 mock.patch('git_cl.Changelist.CloseIssue', lambda *_: None).start()
iannuccie53c9352016-08-17 14:40:40 -07002075 self.assertEqual(
Edward Lemur52969c92020-02-06 18:15:28 +00002076 git_cl.main(['set-close', '--issue', '1']), 0)
iannuccie53c9352016-08-17 14:40:40 -07002077
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002078 def test_description(self):
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01002079 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002080 ((['git', 'config', 'remote.origin.url'],),
2081 'https://chromium.googlesource.com/my/repo'),
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002082 (('GetChangeDetail', 'chromium-review.googlesource.com',
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002083 'my%2Frepo~123123', ['CURRENT_REVISION', 'CURRENT_COMMIT']),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01002084 {
2085 'current_revision': 'sha1',
2086 'revisions': {'sha1': {
2087 'commit': {'message': 'foobar'},
2088 }},
2089 }),
2090 ]
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002091 self.assertEqual(0, git_cl.main([
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002092 'description',
2093 'https://chromium-review.googlesource.com/c/my/repo/+/123123',
2094 '-d']))
Edward Lemurda4b6c62020-02-13 00:28:40 +00002095 self.assertEqual('foobar\n', sys.stdout.getvalue())
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002096
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002097 def test_description_set_raw(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002098 mock.patch('git_cl.Changelist', ChangelistMock).start()
2099 mock.patch('git_cl.sys.stdin', StringIO('hihi')).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002100
2101 self.assertEqual(0, git_cl.main(['description', '-n', 'hihi']))
2102 self.assertEqual('hihi', ChangelistMock.desc)
2103
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002104 def test_description_appends_bug_line(self):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002105 current_desc = 'Some.\n\nChange-Id: xxx'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002106
2107 def RunEditor(desc, _, **kwargs):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002108 self.assertEqual(
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002109 '# Enter a description of the change.\n'
2110 '# This will be displayed on the codereview site.\n'
2111 '# The first line will also be used as the subject of the review.\n'
2112 '#--------------------This line is 72 characters long'
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002113 '--------------------\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -07002114 'Some.\n\nChange-Id: xxx\nBug: ',
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002115 desc)
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002116 # Simulate user changing something.
Aaron Gable3a16ed12017-03-23 10:51:55 -07002117 return 'Some.\n\nChange-Id: xxx\nBug: 123'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002118
Edward Lemur6c6827c2020-02-06 21:15:18 +00002119 def UpdateDescription(_, desc, force=False):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002120 self.assertEqual(desc, 'Some.\n\nChange-Id: xxx\nBug: 123')
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002121
Edward Lemurda4b6c62020-02-13 00:28:40 +00002122 mock.patch('git_cl.Changelist.FetchDescription',
2123 lambda *args: current_desc).start()
2124 mock.patch('git_cl.Changelist.UpdateDescription',
2125 UpdateDescription).start()
2126 mock.patch('git_cl.gclient_utils.RunEditor', RunEditor).start()
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002127
Edward Lemur85153282020-02-14 22:06:29 +00002128 self.mockGit.config['branch.master.gerritissue'] = '123'
2129
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002130 self.calls = [
tandrii5d48c322016-08-18 16:19:37 -07002131 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2132 ((['git', 'config', 'rietveld.bug-prefix'],), CERR1),
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002133 ((['git', 'config', 'core.editor'],), 'vi'),
2134 ]
Edward Lemur52969c92020-02-06 18:15:28 +00002135 self.assertEqual(0, git_cl.main(['description']))
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002136
Dan Beamd8b04ca2019-10-10 21:23:26 +00002137 def test_description_does_not_append_bug_line_if_fixed_is_present(self):
2138 current_desc = 'Some.\n\nFixed: 123\nChange-Id: xxx'
2139
2140 def RunEditor(desc, _, **kwargs):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002141 self.assertEqual(
Dan Beamd8b04ca2019-10-10 21:23:26 +00002142 '# Enter a description of the change.\n'
2143 '# This will be displayed on the codereview site.\n'
2144 '# The first line will also be used as the subject of the review.\n'
2145 '#--------------------This line is 72 characters long'
2146 '--------------------\n'
2147 'Some.\n\nFixed: 123\nChange-Id: xxx',
2148 desc)
2149 return desc
2150
Edward Lemurda4b6c62020-02-13 00:28:40 +00002151 mock.patch('git_cl.Changelist.FetchDescription',
2152 lambda *args: current_desc).start()
2153 mock.patch('git_cl.gclient_utils.RunEditor', RunEditor).start()
Dan Beamd8b04ca2019-10-10 21:23:26 +00002154
Edward Lemur85153282020-02-14 22:06:29 +00002155 self.mockGit.config['branch.master.gerritissue'] = '123'
2156
Dan Beamd8b04ca2019-10-10 21:23:26 +00002157 self.calls = [
Dan Beamd8b04ca2019-10-10 21:23:26 +00002158 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2159 ((['git', 'config', 'rietveld.bug-prefix'],), CERR1),
2160 ((['git', 'config', 'core.editor'],), 'vi'),
2161 ]
Edward Lemur52969c92020-02-06 18:15:28 +00002162 self.assertEqual(0, git_cl.main(['description']))
Dan Beamd8b04ca2019-10-10 21:23:26 +00002163
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002164 def test_description_set_stdin(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002165 mock.patch('git_cl.Changelist', ChangelistMock).start()
2166 mock.patch('git_cl.sys.stdin', StringIO('hi \r\n\t there\n\nman')).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002167
2168 self.assertEqual(0, git_cl.main(['description', '-n', '-']))
2169 self.assertEqual('hi\n\t there\n\nman', ChangelistMock.desc)
2170
kmarshall3bff56b2016-06-06 18:31:47 -07002171 def test_archive(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002172 self.calls = [
2173 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
Edward Lemurf38bc172019-09-03 21:02:13 +00002174 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002175 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002176 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],), ''),
Edward Lemurf38bc172019-09-03 21:02:13 +00002177 ((['git', 'branch', '-D', 'foo'],), '')
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002178 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002179
Edward Lemurda4b6c62020-02-13 00:28:40 +00002180 mock.patch('git_cl.get_cl_statuses',
kmarshall3bff56b2016-06-06 18:31:47 -07002181 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002182 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2183 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002184 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall3bff56b2016-06-06 18:31:47 -07002185
2186 self.assertEqual(0, git_cl.main(['archive', '-f']))
2187
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002188 def test_archive_tag_collision(self):
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002189 self.calls = [
2190 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2191 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2192 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],),
2193 'refs/tags/git-cl-archived-456-foo'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002194 ((['git', 'tag', 'git-cl-archived-456-foo-2', 'foo'],), ''),
2195 ((['git', 'branch', '-D', 'foo'],), '')
2196 ]
2197
Edward Lemurda4b6c62020-02-13 00:28:40 +00002198 mock.patch('git_cl.get_cl_statuses',
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002199 lambda branches, fine_grained, max_processes:
2200 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2201 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002202 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002203
2204 self.assertEqual(0, git_cl.main(['archive', '-f']))
2205
kmarshall3bff56b2016-06-06 18:31:47 -07002206 def test_archive_current_branch_fails(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002207 self.calls = [
2208 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2209 'refs/heads/master'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002210 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002211 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002212
Edward Lemurda4b6c62020-02-13 00:28:40 +00002213 mock.patch('git_cl.get_cl_statuses',
kmarshall9249e012016-08-23 12:02:16 -07002214 lambda branches, fine_grained, max_processes:
Edward Lemurda4b6c62020-02-13 00:28:40 +00002215 [(MockChangelistWithBranchAndIssue('master', 1),
2216 'closed')]).start()
kmarshall9249e012016-08-23 12:02:16 -07002217
2218 self.assertEqual(1, git_cl.main(['archive', '-f']))
2219
2220 def test_archive_dry_run(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002221 self.calls = [
2222 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2223 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002224 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002225 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002226
Edward Lemurda4b6c62020-02-13 00:28:40 +00002227 mock.patch('git_cl.get_cl_statuses',
kmarshall3bff56b2016-06-06 18:31:47 -07002228 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002229 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2230 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002231 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall3bff56b2016-06-06 18:31:47 -07002232
kmarshall9249e012016-08-23 12:02:16 -07002233 self.assertEqual(0, git_cl.main(['archive', '-f', '--dry-run']))
2234
2235 def test_archive_no_tags(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002236 self.calls = [
2237 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2238 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002239 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002240 ((['git', 'branch', '-D', 'foo'],), '')
2241 ]
kmarshall9249e012016-08-23 12:02:16 -07002242
Edward Lemurda4b6c62020-02-13 00:28:40 +00002243 mock.patch('git_cl.get_cl_statuses',
kmarshall9249e012016-08-23 12:02:16 -07002244 lambda branches, fine_grained, max_processes:
2245 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2246 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002247 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall9249e012016-08-23 12:02:16 -07002248
2249 self.assertEqual(0, git_cl.main(['archive', '-f', '--notags']))
kmarshall3bff56b2016-06-06 18:31:47 -07002250
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002251 def test_archive_tag_cleanup_on_branch_deletion_error(self):
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002252 self.calls = [
2253 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2254 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2255 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002256 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],),
2257 'refs/tags/git-cl-archived-456-foo'),
2258 ((['git', 'branch', '-D', 'foo'],), CERR1),
2259 ((['git', 'tag', '-d', 'git-cl-archived-456-foo'],),
2260 'refs/tags/git-cl-archived-456-foo'),
2261 ]
2262
Edward Lemurda4b6c62020-02-13 00:28:40 +00002263 mock.patch('git_cl.get_cl_statuses',
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002264 lambda branches, fine_grained, max_processes:
2265 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2266 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002267 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002268
2269 self.assertEqual(0, git_cl.main(['archive', '-f']))
2270
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002271 def test_cmd_issue_erase_existing(self):
Edward Lemur85153282020-02-14 22:06:29 +00002272 self.mockGit.config['branch.master.gerritissue'] = '123'
2273 self.mockGit.config['branch.master.gerritserver'] = (
2274 'https://chromium-review.googlesource.com')
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002275 self.calls = [
Aaron Gableca01e2c2017-07-19 11:16:02 -07002276 ((['git', 'log', '-1', '--format=%B'],), 'This is a description'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002277 ]
2278 self.assertEqual(0, git_cl.main(['issue', '0']))
Edward Lemur85153282020-02-14 22:06:29 +00002279 self.assertNotIn('branch.master.gerritissue', self.mockGit.config)
2280 self.assertNotIn('branch.master.gerritserver', self.mockGit.config)
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002281
Aaron Gable400e9892017-07-12 15:31:21 -07002282 def test_cmd_issue_erase_existing_with_change_id(self):
Edward Lemur85153282020-02-14 22:06:29 +00002283 self.mockGit.config['branch.master.gerritissue'] = '123'
2284 self.mockGit.config['branch.master.gerritserver'] = (
2285 'https://chromium-review.googlesource.com')
Edward Lemurda4b6c62020-02-13 00:28:40 +00002286 mock.patch('git_cl.Changelist.FetchDescription',
2287 lambda _: 'This is a description\n\nChange-Id: Ideadbeef').start()
Aaron Gable400e9892017-07-12 15:31:21 -07002288 self.calls = [
Aaron Gableca01e2c2017-07-19 11:16:02 -07002289 ((['git', 'log', '-1', '--format=%B'],),
2290 'This is a description\n\nChange-Id: Ideadbeef'),
2291 ((['git', 'commit', '--amend', '-m', 'This is a description\n'],), ''),
Aaron Gable400e9892017-07-12 15:31:21 -07002292 ]
2293 self.assertEqual(0, git_cl.main(['issue', '0']))
Edward Lemur85153282020-02-14 22:06:29 +00002294 self.assertNotIn('branch.master.gerritissue', self.mockGit.config)
2295 self.assertNotIn('branch.master.gerritserver', self.mockGit.config)
Aaron Gable400e9892017-07-12 15:31:21 -07002296
phajdan.jre328cf92016-08-22 04:12:17 -07002297 def test_cmd_issue_json(self):
Edward Lemur85153282020-02-14 22:06:29 +00002298 self.mockGit.config['branch.master.gerritissue'] = '123'
2299 self.mockGit.config['branch.master.gerritserver'] = (
2300 'https://chromium-review.googlesource.com')
phajdan.jre328cf92016-08-22 04:12:17 -07002301 self.calls = [
phajdan.jre328cf92016-08-22 04:12:17 -07002302 (('write_json', 'output.json',
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002303 {'issue': 123,
2304 'issue_url': 'https://chromium-review.googlesource.com/123'}),
phajdan.jre328cf92016-08-22 04:12:17 -07002305 ''),
2306 ]
2307 self.assertEqual(0, git_cl.main(['issue', '--json', 'output.json']))
2308
tandrii16e0b4e2016-06-07 10:34:28 -07002309 def _common_GerritCommitMsgHookCheck(self):
Edward Lemur15a9b8c2020-02-13 00:52:30 +00002310 mock.patch(
2311 'git_cl.os.path.abspath',
2312 lambda path: self._mocked_call(['abspath', path])).start()
2313 mock.patch(
2314 'git_cl.os.path.exists',
2315 lambda path: self._mocked_call(['exists', path])).start()
2316 mock.patch(
2317 'git_cl.gclient_utils.FileRead',
2318 lambda path: self._mocked_call(['FileRead', path])).start()
2319 mock.patch(
2320 'git_cl.gclient_utils.rm_file_or_tree',
2321 lambda path: self._mocked_call(['rm_file_or_tree', path])).start()
Edward Lemurf38bc172019-09-03 21:02:13 +00002322 return git_cl.Changelist(issue=123)
tandrii16e0b4e2016-06-07 10:34:28 -07002323
2324 def test_GerritCommitMsgHookCheck_custom_hook(self):
2325 cl = self._common_GerritCommitMsgHookCheck()
2326 self.calls += [
Edward Lemur15a9b8c2020-02-13 00:52:30 +00002327 ((['exists', '.git/hooks/commit-msg'],), True),
2328 ((['FileRead', '.git/hooks/commit-msg'],),
tandrii16e0b4e2016-06-07 10:34:28 -07002329 '#!/bin/sh\necho "custom hook"')
2330 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002331 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002332
2333 def test_GerritCommitMsgHookCheck_not_exists(self):
2334 cl = self._common_GerritCommitMsgHookCheck()
2335 self.calls += [
Edward Lemur15a9b8c2020-02-13 00:52:30 +00002336 ((['exists', '.git/hooks/commit-msg'],), False),
tandrii16e0b4e2016-06-07 10:34:28 -07002337 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002338 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002339
2340 def test_GerritCommitMsgHookCheck(self):
2341 cl = self._common_GerritCommitMsgHookCheck()
2342 self.calls += [
Edward Lemur15a9b8c2020-02-13 00:52:30 +00002343 ((['exists', '.git/hooks/commit-msg'],), True),
2344 ((['FileRead', '.git/hooks/commit-msg'],),
tandrii16e0b4e2016-06-07 10:34:28 -07002345 '...\n# From Gerrit Code Review\n...\nadd_ChangeId()\n'),
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002346 (('ask_for_data', 'Do you want to remove it now? [Yes/No]: '), 'Yes'),
Edward Lemur15a9b8c2020-02-13 00:52:30 +00002347 ((['rm_file_or_tree', '.git/hooks/commit-msg'],),
tandrii16e0b4e2016-06-07 10:34:28 -07002348 ''),
2349 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002350 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002351
tandriic4344b52016-08-29 06:04:54 -07002352 def test_GerritCmdLand(self):
Edward Lemur85153282020-02-14 22:06:29 +00002353 self.mockGit.config['branch.master.gerritsquashhash'] = 'deadbeaf'
2354 self.mockGit.config['branch.master.gerritserver'] = (
2355 'chromium-review.googlesource.com')
tandriic4344b52016-08-29 06:04:54 -07002356 self.calls += [
tandriic4344b52016-08-29 06:04:54 -07002357 ((['git', 'diff', 'deadbeaf'],), ''), # No diff.
tandriic4344b52016-08-29 06:04:54 -07002358 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002359 cl = git_cl.Changelist(issue=123)
Edward Lemur125d60a2019-09-13 18:25:41 +00002360 cl._GetChangeDetail = lambda *args, **kwargs: {
tandriic4344b52016-08-29 06:04:54 -07002361 'labels': {},
2362 'current_revision': 'deadbeaf',
2363 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002364 cl._GetChangeCommit = lambda: {
agable32978d92016-11-01 12:55:02 -07002365 'commit': 'deadbeef',
Aaron Gable02cdbb42016-12-13 16:24:25 -08002366 'web_links': [{'name': 'gitiles',
agable32978d92016-11-01 12:55:02 -07002367 'url': 'https://git.googlesource.com/test/+/deadbeef'}],
2368 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002369 cl.SubmitIssue = lambda wait_for_merge: None
Olivier Robin75ee7252018-04-13 10:02:56 +02002370 self.assertEqual(0, cl.CMDLand(force=True,
2371 bypass_hooks=True,
2372 verbose=True,
2373 parallel=False))
Edward Lemur73c76702020-02-06 23:57:18 +00002374 self.assertIn(
2375 'Issue chromium-review.googlesource.com/123 has been submitted',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002376 sys.stdout.getvalue())
Edward Lemur73c76702020-02-06 23:57:18 +00002377 self.assertIn(
2378 'Landed as: https://git.googlesource.com/test/+/deadbeef',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002379 sys.stdout.getvalue())
tandriic4344b52016-08-29 06:04:54 -07002380
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002381 def _mock_gerrit_changes_for_detail_cache(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002382 mock.patch('git_cl.Changelist._GetGerritHost', lambda _: 'host').start()
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002383
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002384 def test_gerrit_change_detail_cache_simple(self):
2385 self._mock_gerrit_changes_for_detail_cache()
2386 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002387 (('GetChangeDetail', 'host', 'my%2Frepo~1', []), 'a'),
2388 (('GetChangeDetail', 'host', 'ab%2Frepo~2', []), 'b'),
2389 (('GetChangeDetail', 'host', 'ab%2Frepo~2', []), 'b2'),
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002390 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002391 cl1 = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002392 cl1._cached_remote_url = (
2393 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemurf38bc172019-09-03 21:02:13 +00002394 cl2 = git_cl.Changelist(issue=2)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002395 cl2._cached_remote_url = (
2396 True, 'https://chromium.googlesource.com/ab/repo')
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002397 self.assertEqual(cl1._GetChangeDetail(), 'a') # Miss.
2398 self.assertEqual(cl1._GetChangeDetail(), 'a')
2399 self.assertEqual(cl2._GetChangeDetail(), 'b') # Miss.
2400 self.assertEqual(cl2._GetChangeDetail(no_cache=True), 'b2') # Miss.
2401 self.assertEqual(cl1._GetChangeDetail(), 'a')
2402 self.assertEqual(cl2._GetChangeDetail(), 'b2')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002403
2404 def test_gerrit_change_detail_cache_options(self):
2405 self._mock_gerrit_changes_for_detail_cache()
2406 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002407 (('GetChangeDetail', 'host', 'repo~1', ['C', 'A', 'B']), 'cab'),
2408 (('GetChangeDetail', 'host', 'repo~1', ['A', 'D']), 'ad'),
2409 (('GetChangeDetail', 'host', 'repo~1', ['A']), 'a'), # no_cache=True
2410 # no longer in cache.
2411 (('GetChangeDetail', 'host', 'repo~1', ['B']), 'b'),
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002412 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002413 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002414 cl._cached_remote_url = (True, 'https://chromium.googlesource.com/repo/')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002415 self.assertEqual(cl._GetChangeDetail(options=['C', 'A', 'B']), 'cab')
2416 self.assertEqual(cl._GetChangeDetail(options=['A', 'B', 'C']), 'cab')
2417 self.assertEqual(cl._GetChangeDetail(options=['B', 'A']), 'cab')
2418 self.assertEqual(cl._GetChangeDetail(options=['C']), 'cab')
2419 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2420 self.assertEqual(cl._GetChangeDetail(), 'cab')
2421
2422 self.assertEqual(cl._GetChangeDetail(options=['A', 'D']), 'ad')
2423 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2424 self.assertEqual(cl._GetChangeDetail(options=['D']), 'ad')
2425 self.assertEqual(cl._GetChangeDetail(), 'cab')
2426
2427 # Finally, no_cache should invalidate all caches for given change.
2428 self.assertEqual(cl._GetChangeDetail(options=['A'], no_cache=True), 'a')
2429 self.assertEqual(cl._GetChangeDetail(options=['B']), 'b')
2430
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002431 def test_gerrit_description_caching(self):
2432 def gen_detail(rev, desc):
2433 return {
2434 'current_revision': rev,
2435 'revisions': {rev: {'commit': {'message': desc}}}
2436 }
2437 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002438 (('GetChangeDetail', 'host', 'my%2Frepo~1',
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002439 ['CURRENT_REVISION', 'CURRENT_COMMIT']),
2440 gen_detail('rev1', 'desc1')),
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002441 ]
2442
2443 self._mock_gerrit_changes_for_detail_cache()
Edward Lemurf38bc172019-09-03 21:02:13 +00002444 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002445 cl._cached_remote_url = (
2446 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemur6c6827c2020-02-06 21:15:18 +00002447 self.assertEqual(cl.FetchDescription(), 'desc1')
2448 self.assertEqual(cl.FetchDescription(), 'desc1') # cache hit.
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002449
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002450 def test_print_current_creds(self):
2451 class CookiesAuthenticatorMock(object):
2452 def __init__(self):
2453 self.gitcookies = {
2454 'host.googlesource.com': ('user', 'pass'),
2455 'host-review.googlesource.com': ('user', 'pass'),
2456 }
2457 self.netrc = self
2458 self.netrc.hosts = {
2459 'github.com': ('user2', None, 'pass2'),
2460 'host2.googlesource.com': ('user3', None, 'pass'),
2461 }
Edward Lemurda4b6c62020-02-13 00:28:40 +00002462 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
2463 CookiesAuthenticatorMock).start()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002464 git_cl._GitCookiesChecker().print_current_creds(include_netrc=True)
2465 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2466 ' Host\t User\t Which file',
2467 '============================\t=====\t===========',
2468 'host-review.googlesource.com\t user\t.gitcookies',
2469 ' host.googlesource.com\t user\t.gitcookies',
2470 ' host2.googlesource.com\tuser3\t .netrc',
2471 ])
Edward Lemur79d4f992019-11-11 23:49:02 +00002472 sys.stdout.seek(0)
2473 sys.stdout.truncate(0)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002474 git_cl._GitCookiesChecker().print_current_creds(include_netrc=False)
2475 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2476 ' Host\tUser\t Which file',
2477 '============================\t====\t===========',
2478 'host-review.googlesource.com\tuser\t.gitcookies',
2479 ' host.googlesource.com\tuser\t.gitcookies',
2480 ])
2481
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002482 def _common_creds_check_mocks(self):
2483 def exists_mock(path):
2484 dirname = os.path.dirname(path)
2485 if dirname == os.path.expanduser('~'):
2486 dirname = '~'
2487 base = os.path.basename(path)
2488 if base in ('.netrc', '.gitcookies'):
2489 return self._mocked_call('os.path.exists', '%s/%s' % (dirname, base))
2490 # git cl also checks for existence other files not relevant to this test.
2491 return None
Edward Lemurda4b6c62020-02-13 00:28:40 +00002492 mock.patch('os.path.exists', exists_mock).start()
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002493
2494 def test_creds_check_gitcookies_not_configured(self):
2495 self._common_creds_check_mocks()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002496 mock.patch('git_cl._GitCookiesChecker.get_hosts_with_creds',
2497 lambda _, include_netrc=False: []).start()
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002498 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08002499 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002500 ((['git', 'config', '--global', 'http.cookiefile'],), CERR1),
2501 (('os.path.exists', '~/.netrc'), True),
2502 (('ask_for_data', 'Press Enter to setup .gitcookies, '
2503 'or Ctrl+C to abort'), ''),
2504 ((['git', 'config', '--global', 'http.cookiefile',
2505 os.path.expanduser('~/.gitcookies')], ), ''),
2506 ]
2507 self.assertEqual(0, git_cl.main(['creds-check']))
Edward Lemur73c76702020-02-06 23:57:18 +00002508 self.assertTrue(
2509 sys.stdout.getvalue().startswith(
2510 'You seem to be using outdated .netrc for git credentials:'))
2511 self.assertIn(
2512 '\nConfigured git to use .gitcookies from',
2513 sys.stdout.getvalue())
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002514
2515 def test_creds_check_gitcookies_configured_custom_broken(self):
2516 self._common_creds_check_mocks()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002517 mock.patch('git_cl._GitCookiesChecker.get_hosts_with_creds',
2518 lambda _, include_netrc=False: []).start()
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002519 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08002520 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002521 ((['git', 'config', '--global', 'http.cookiefile'],),
2522 '/custom/.gitcookies'),
2523 (('os.path.exists', '/custom/.gitcookies'), False),
2524 (('ask_for_data', 'Reconfigure git to use default .gitcookies? '
2525 'Press Enter to reconfigure, or Ctrl+C to abort'), ''),
2526 ((['git', 'config', '--global', 'http.cookiefile',
2527 os.path.expanduser('~/.gitcookies')], ), ''),
2528 ]
2529 self.assertEqual(0, git_cl.main(['creds-check']))
Edward Lemur73c76702020-02-06 23:57:18 +00002530 self.assertIn(
2531 'WARNING: You have configured custom path to .gitcookies: ',
2532 sys.stdout.getvalue())
2533 self.assertIn(
2534 'However, your configured .gitcookies file is missing.',
2535 sys.stdout.getvalue())
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002536
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002537 def test_git_cl_comment_add_gerrit(self):
Edward Lemur85153282020-02-14 22:06:29 +00002538 self.mockGit.branchref = None
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002539 self.calls = [
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002540 ((['git', 'config', 'remote.origin.url'],),
2541 'https://chromium.googlesource.com/infra/infra'),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002542 (('SetReview', 'chromium-review.googlesource.com', 'infra%2Finfra~10',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002543 'msg', None, None, None),
Aaron Gable636b13f2017-07-14 10:42:48 -07002544 None),
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002545 ]
Edward Lemur52969c92020-02-06 18:15:28 +00002546 self.assertEqual(0, git_cl.main(['comment', '-i', '10', '-a', 'msg']))
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002547
Edward Lemurda4b6c62020-02-13 00:28:40 +00002548 @mock.patch('git_cl.Changelist.GetBranch', return_value='foo')
2549 def test_git_cl_comments_fetch_gerrit(self, *_mocks):
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002550 self.calls = [
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002551 ((['git', 'config', 'remote.origin.url'],),
2552 'https://chromium.googlesource.com/infra/infra'),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002553 (('GetChangeDetail', 'chromium-review.googlesource.com',
2554 'infra%2Finfra~1',
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002555 ['MESSAGES', 'DETAILED_ACCOUNTS', 'CURRENT_REVISION',
2556 'CURRENT_COMMIT']), {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002557 'owner': {'email': 'owner@example.com'},
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002558 'current_revision': 'ba5eba11',
2559 'revisions': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002560 'deadbeaf': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002561 '_number': 1,
2562 },
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002563 'ba5eba11': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002564 '_number': 2,
2565 },
2566 },
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002567 'messages': [
2568 {
2569 u'_revision_number': 1,
2570 u'author': {
2571 u'_account_id': 1111084,
2572 u'email': u'commit-bot@chromium.org',
2573 u'name': u'Commit Bot'
2574 },
2575 u'date': u'2017-03-15 20:08:45.000000000',
2576 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
Dirk Prankef6a58802017-10-17 12:49:42 -07002577 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002578 u'tag': u'autogenerated:cq:dry-run'
2579 },
2580 {
2581 u'_revision_number': 2,
2582 u'author': {
2583 u'_account_id': 11151243,
2584 u'email': u'owner@example.com',
2585 u'name': u'owner'
2586 },
2587 u'date': u'2017-03-16 20:00:41.000000000',
2588 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2589 u'message': u'PTAL',
2590 },
2591 {
2592 u'_revision_number': 2,
2593 u'author': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002594 u'_account_id': 148512,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002595 u'email': u'reviewer@example.com',
2596 u'name': u'reviewer'
2597 },
2598 u'date': u'2017-03-17 05:19:37.500000000',
2599 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2600 u'message': u'Patch Set 2: Code-Review+1',
2601 },
2602 ]
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002603 }),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002604 (('GetChangeComments', 'chromium-review.googlesource.com',
2605 'infra%2Finfra~1'), {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002606 '/COMMIT_MSG': [
2607 {
2608 'author': {'email': u'reviewer@example.com'},
2609 'updated': u'2017-03-17 05:19:37.500000000',
2610 'patch_set': 2,
2611 'side': 'REVISION',
2612 'message': 'Please include a bug link',
2613 },
2614 ],
2615 'codereview.settings': [
2616 {
2617 'author': {'email': u'owner@example.com'},
2618 'updated': u'2017-03-16 20:00:41.000000000',
2619 'patch_set': 2,
2620 'side': 'PARENT',
2621 'line': 42,
2622 'message': 'I removed this because it is bad',
2623 },
2624 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002625 }),
2626 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
2627 'infra%2Finfra~1'), {}),
Leszek Swirski45b20c42018-09-17 17:05:26 +00002628 ] * 2 + [
2629 (('write_json', 'output.json', [
2630 {
2631 u'date': u'2017-03-16 20:00:41.000000',
2632 u'message': (
2633 u'PTAL\n' +
2634 u'\n' +
2635 u'codereview.settings\n' +
2636 u' Base, Line 42: https://chromium-review.googlesource.com/' +
2637 u'c/1/2/codereview.settings#b42\n' +
2638 u' I removed this because it is bad\n'),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002639 u'autogenerated': False,
Leszek Swirski45b20c42018-09-17 17:05:26 +00002640 u'approval': False,
2641 u'disapproval': False,
2642 u'sender': u'owner@example.com'
2643 }, {
2644 u'date': u'2017-03-17 05:19:37.500000',
2645 u'message': (
2646 u'Patch Set 2: Code-Review+1\n' +
2647 u'\n' +
2648 u'/COMMIT_MSG\n' +
2649 u' PS2, File comment: https://chromium-review.googlesource' +
2650 u'.com/c/1/2//COMMIT_MSG#\n' +
2651 u' Please include a bug link\n'),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002652 u'autogenerated': False,
Leszek Swirski45b20c42018-09-17 17:05:26 +00002653 u'approval': False,
2654 u'disapproval': False,
2655 u'sender': u'reviewer@example.com'
2656 }
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002657 ]), '')
Leszek Swirski45b20c42018-09-17 17:05:26 +00002658 ]
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002659 expected_comments_summary = [
2660 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002661 message=(
2662 u'PTAL\n' +
2663 u'\n' +
2664 u'codereview.settings\n' +
2665 u' Base, Line 42: https://chromium-review.googlesource.com/' +
2666 u'c/1/2/codereview.settings#b42\n' +
2667 u' I removed this because it is bad\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002668 date=datetime.datetime(2017, 3, 16, 20, 0, 41, 0),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002669 autogenerated=False,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002670 disapproval=False, approval=False, sender=u'owner@example.com'),
2671 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002672 message=(
2673 u'Patch Set 2: Code-Review+1\n' +
2674 u'\n' +
2675 u'/COMMIT_MSG\n' +
2676 u' PS2, File comment: https://chromium-review.googlesource.com/' +
2677 u'c/1/2//COMMIT_MSG#\n' +
2678 u' Please include a bug link\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002679 date=datetime.datetime(2017, 3, 17, 5, 19, 37, 500000),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002680 autogenerated=False,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002681 disapproval=False, approval=False, sender=u'reviewer@example.com'),
2682 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002683 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00002684 issue=1, branchref='refs/heads/foo')
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002685 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002686 self.assertEqual(
2687 0, git_cl.main(['comments', '-i', '1', '-j', 'output.json']))
2688
2689 def test_git_cl_comments_robot_comments(self):
2690 # git cl comments also fetches robot comments (which are considered a type
2691 # of autogenerated comment), and unlike other types of comments, only robot
2692 # comments from the latest patchset are shown.
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002693 self.calls = [
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002694 ((['git', 'config', 'remote.origin.url'],),
2695 'https://chromium.googlesource.com/infra/infra'),
2696 (('GetChangeDetail', 'chromium-review.googlesource.com',
2697 'infra%2Finfra~1',
2698 ['MESSAGES', 'DETAILED_ACCOUNTS', 'CURRENT_REVISION',
2699 'CURRENT_COMMIT']), {
2700 'owner': {'email': 'owner@example.com'},
2701 'current_revision': 'ba5eba11',
2702 'revisions': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002703 'deadbeaf': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002704 '_number': 1,
2705 },
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002706 'ba5eba11': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002707 '_number': 2,
2708 },
2709 },
2710 'messages': [
2711 {
2712 u'_revision_number': 1,
2713 u'author': {
2714 u'_account_id': 1111084,
2715 u'email': u'commit-bot@chromium.org',
2716 u'name': u'Commit Bot'
2717 },
2718 u'date': u'2017-03-15 20:08:45.000000000',
2719 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
2720 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
2721 u'tag': u'autogenerated:cq:dry-run'
2722 },
2723 {
2724 u'_revision_number': 1,
2725 u'author': {
2726 u'_account_id': 123,
2727 u'email': u'tricium@serviceaccount.com',
2728 u'name': u'Tricium'
2729 },
2730 u'date': u'2017-03-16 20:00:41.000000000',
2731 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2732 u'message': u'(1 comment)',
2733 u'tag': u'autogenerated:tricium',
2734 },
2735 {
2736 u'_revision_number': 1,
2737 u'author': {
2738 u'_account_id': 123,
2739 u'email': u'tricium@serviceaccount.com',
2740 u'name': u'Tricium'
2741 },
2742 u'date': u'2017-03-16 20:00:41.000000000',
2743 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2744 u'message': u'(1 comment)',
2745 u'tag': u'autogenerated:tricium',
2746 },
2747 {
2748 u'_revision_number': 2,
2749 u'author': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002750 u'_account_id': 123,
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002751 u'email': u'tricium@serviceaccount.com',
2752 u'name': u'reviewer'
2753 },
2754 u'date': u'2017-03-17 05:30:37.000000000',
2755 u'tag': u'autogenerated:tricium',
2756 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2757 u'message': u'(1 comment)',
2758 },
2759 ]
2760 }),
2761 (('GetChangeComments', 'chromium-review.googlesource.com',
2762 'infra%2Finfra~1'), {}),
2763 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
2764 'infra%2Finfra~1'), {
2765 'codereview.settings': [
2766 {
2767 u'author': {u'email': u'tricium@serviceaccount.com'},
2768 u'updated': u'2017-03-17 05:30:37.000000000',
2769 u'robot_run_id': u'5565031076855808',
2770 u'robot_id': u'Linter/Category',
2771 u'tag': u'autogenerated:tricium',
2772 u'patch_set': 2,
2773 u'side': u'REVISION',
2774 u'message': u'Linter warning message text',
2775 u'line': 32,
2776 },
2777 ],
2778 }),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002779 ]
2780 expected_comments_summary = [
2781 git_cl._CommentSummary(date=datetime.datetime(2017, 3, 17, 5, 30, 37),
2782 message=(
2783 u'(1 comment)\n\ncodereview.settings\n'
2784 u' PS2, Line 32: https://chromium-review.googlesource.com/'
2785 u'c/1/2/codereview.settings#32\n'
2786 u' Linter warning message text\n'),
2787 sender=u'tricium@serviceaccount.com',
2788 autogenerated=True, approval=False, disapproval=False)
2789 ]
2790 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00002791 issue=1, branchref='refs/heads/foo')
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002792 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002793
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002794 def test_get_remote_url_with_mirror(self):
2795 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002796
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002797 def selective_os_path_isdir_mock(path):
2798 if path == '/cache/this-dir-exists':
2799 return self._mocked_call('os.path.isdir', path)
2800 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002801
Edward Lemurda4b6c62020-02-13 00:28:40 +00002802 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002803
2804 url = 'https://chromium.googlesource.com/my/repo'
2805 self.calls = [
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002806 ((['git', 'config', 'remote.origin.url'],),
2807 '/cache/this-dir-exists'),
2808 (('os.path.isdir', '/cache/this-dir-exists'),
2809 True),
2810 # Runs in /cache/this-dir-exists.
2811 ((['git', 'config', 'remote.origin.url'],),
2812 url),
2813 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002814 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002815 self.assertEqual(cl.GetRemoteUrl(), url)
2816 self.assertEqual(cl.GetRemoteUrl(), url) # Must be cached.
2817
Edward Lemur298f2cf2019-02-22 21:40:39 +00002818 def test_get_remote_url_non_existing_mirror(self):
2819 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002820
Edward Lemur298f2cf2019-02-22 21:40:39 +00002821 def selective_os_path_isdir_mock(path):
2822 if path == '/cache/this-dir-doesnt-exist':
2823 return self._mocked_call('os.path.isdir', path)
2824 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002825
Edward Lemurda4b6c62020-02-13 00:28:40 +00002826 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
2827 mock.patch('logging.error',
2828 lambda *a: self._mocked_call('logging.error', *a)).start()
Edward Lemur298f2cf2019-02-22 21:40:39 +00002829
2830 self.calls = [
Edward Lemur298f2cf2019-02-22 21:40:39 +00002831 ((['git', 'config', 'remote.origin.url'],),
2832 '/cache/this-dir-doesnt-exist'),
2833 (('os.path.isdir', '/cache/this-dir-doesnt-exist'),
2834 False),
2835 (('logging.error',
Josip906bfde2020-01-31 22:38:49 +00002836 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
2837 'but it doesn\'t exist.', {
2838 'remote': 'origin',
2839 'branch': 'master',
2840 'url': '/cache/this-dir-doesnt-exist'}
2841 ), None),
Edward Lemur298f2cf2019-02-22 21:40:39 +00002842 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002843 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00002844 self.assertIsNone(cl.GetRemoteUrl())
2845
2846 def test_get_remote_url_misconfigured_mirror(self):
2847 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002848
Edward Lemur298f2cf2019-02-22 21:40:39 +00002849 def selective_os_path_isdir_mock(path):
2850 if path == '/cache/this-dir-exists':
2851 return self._mocked_call('os.path.isdir', path)
2852 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002853
Edward Lemurda4b6c62020-02-13 00:28:40 +00002854 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
2855 mock.patch('logging.error',
2856 lambda *a: self._mocked_call('logging.error', *a)).start()
Edward Lemur298f2cf2019-02-22 21:40:39 +00002857
2858 self.calls = [
Edward Lemur298f2cf2019-02-22 21:40:39 +00002859 ((['git', 'config', 'remote.origin.url'],),
2860 '/cache/this-dir-exists'),
2861 (('os.path.isdir', '/cache/this-dir-exists'), True),
2862 # Runs in /cache/this-dir-exists.
2863 ((['git', 'config', 'remote.origin.url'],), ''),
2864 (('logging.error',
2865 'Remote "%(remote)s" for branch "%(branch)s" points to '
2866 '"%(cache_path)s", but it is misconfigured.\n'
2867 '"%(cache_path)s" must be a git repo and must have a remote named '
2868 '"%(remote)s" pointing to the git host.', {
2869 'remote': 'origin',
2870 'cache_path': '/cache/this-dir-exists',
2871 'branch': 'master'}
2872 ), None),
2873 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002874 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00002875 self.assertIsNone(cl.GetRemoteUrl())
2876
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002877 def test_gerrit_change_identifier_with_project(self):
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00002878 self.calls = [
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00002879 ((['git', 'config', 'remote.origin.url'],),
2880 'https://chromium.googlesource.com/a/my/repo.git/'),
2881 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002882 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002883 self.assertEqual(cl._GerritChangeIdentifier(), 'my%2Frepo~123456')
2884
2885 def test_gerrit_change_identifier_without_project(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002886 mock.patch('logging.error',
2887 lambda *a: self._mocked_call('logging.error', *a)).start()
Josip906bfde2020-01-31 22:38:49 +00002888
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002889 self.calls = [
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002890 ((['git', 'config', 'remote.origin.url'],), CERR1),
Josip906bfde2020-01-31 22:38:49 +00002891 (('logging.error',
2892 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
2893 'but it doesn\'t exist.', {
2894 'remote': 'origin',
2895 'branch': 'master',
2896 'url': ''}
2897 ), None),
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002898 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002899 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002900 self.assertEqual(cl._GerritChangeIdentifier(), '123456')
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00002901
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002902
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002903class CMDTestCaseBase(unittest.TestCase):
2904 _STATUSES = [
2905 'STATUS_UNSPECIFIED', 'SCHEDULED', 'STARTED', 'SUCCESS', 'FAILURE',
2906 'INFRA_FAILURE', 'CANCELED',
2907 ]
2908 _CHANGE_DETAIL = {
2909 'project': 'depot_tools',
2910 'status': 'OPEN',
2911 'owner': {'email': 'owner@e.mail'},
2912 'current_revision': 'beeeeeef',
2913 'revisions': {
2914 'deadbeaf': {'_number': 6},
2915 'beeeeeef': {
2916 '_number': 7,
2917 'fetch': {'http': {
2918 'url': 'https://chromium.googlesource.com/depot_tools',
2919 'ref': 'refs/changes/56/123456/7'
2920 }},
2921 },
2922 },
2923 }
2924 _DEFAULT_RESPONSE = {
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00002925 'builds': [{
2926 'id': str(100 + idx),
2927 'builder': {
2928 'project': 'chromium',
2929 'bucket': 'try',
2930 'builder': 'bot_' + status.lower(),
2931 },
2932 'createTime': '2019-10-09T08:00:0%d.854286Z' % (idx % 10),
2933 'tags': [],
2934 'status': status,
2935 } for idx, status in enumerate(_STATUSES)]
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002936 }
2937
Edward Lemur4c707a22019-09-24 21:13:43 +00002938 def setUp(self):
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002939 super(CMDTestCaseBase, self).setUp()
Edward Lemur79d4f992019-11-11 23:49:02 +00002940 mock.patch('git_cl.sys.stdout', StringIO()).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002941 mock.patch('git_cl.uuid.uuid4', return_value='uuid4').start()
2942 mock.patch('git_cl.Changelist.GetIssue', return_value=123456).start()
Edward Lemur4c707a22019-09-24 21:13:43 +00002943 mock.patch('git_cl.Changelist.GetCodereviewServer',
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002944 return_value='https://chromium-review.googlesource.com').start()
2945 mock.patch('git_cl.Changelist.GetMostRecentPatchset',
2946 return_value=7).start()
Edward Lemur5b929a42019-10-21 17:57:39 +00002947 mock.patch('git_cl.auth.Authenticator',
Edward Lemurb4a587d2019-10-09 23:56:38 +00002948 return_value=AuthenticatorMock()).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002949 mock.patch('git_cl.Changelist._GetChangeDetail',
2950 return_value=self._CHANGE_DETAIL).start()
2951 mock.patch('git_cl._call_buildbucket',
2952 return_value = self._DEFAULT_RESPONSE).start()
2953 mock.patch('git_common.is_dirty_git_tree', return_value=False).start()
Edward Lemur4c707a22019-09-24 21:13:43 +00002954 self.addCleanup(mock.patch.stopall)
2955
Edward Lemur4c707a22019-09-24 21:13:43 +00002956
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002957class CMDTryResultsTestCase(CMDTestCaseBase):
2958 _DEFAULT_REQUEST = {
2959 'predicate': {
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00002960 "gerritChanges": [{
2961 "project": "depot_tools",
2962 "host": "chromium-review.googlesource.com",
2963 "patchset": 7,
2964 "change": 123456,
2965 }],
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002966 },
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00002967 'fields': ('builds.*.id,builds.*.builder,builds.*.status' +
2968 ',builds.*.createTime,builds.*.tags'),
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002969 }
2970
2971 def testNoJobs(self):
2972 git_cl._call_buildbucket.return_value = {}
2973
2974 self.assertEqual(0, git_cl.main(['try-results']))
2975 self.assertEqual('No tryjobs scheduled.\n', sys.stdout.getvalue())
2976 git_cl._call_buildbucket.assert_called_once_with(
2977 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
2978 self._DEFAULT_REQUEST)
2979
2980 def testPrintToStdout(self):
2981 self.assertEqual(0, git_cl.main(['try-results']))
2982 self.assertEqual([
2983 'Successes:',
2984 ' bot_success https://ci.chromium.org/b/103',
2985 'Infra Failures:',
2986 ' bot_infra_failure https://ci.chromium.org/b/105',
2987 'Failures:',
2988 ' bot_failure https://ci.chromium.org/b/104',
2989 'Canceled:',
2990 ' bot_canceled ',
2991 'Started:',
2992 ' bot_started https://ci.chromium.org/b/102',
2993 'Scheduled:',
2994 ' bot_scheduled id=101',
2995 'Other:',
2996 ' bot_status_unspecified id=100',
2997 'Total: 7 tryjobs',
2998 ], sys.stdout.getvalue().splitlines())
2999 git_cl._call_buildbucket.assert_called_once_with(
3000 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3001 self._DEFAULT_REQUEST)
3002
3003 def testPrintToStdoutWithMasters(self):
3004 self.assertEqual(0, git_cl.main(['try-results', '--print-master']))
3005 self.assertEqual([
3006 'Successes:',
3007 ' try bot_success https://ci.chromium.org/b/103',
3008 'Infra Failures:',
3009 ' try bot_infra_failure https://ci.chromium.org/b/105',
3010 'Failures:',
3011 ' try bot_failure https://ci.chromium.org/b/104',
3012 'Canceled:',
3013 ' try bot_canceled ',
3014 'Started:',
3015 ' try bot_started https://ci.chromium.org/b/102',
3016 'Scheduled:',
3017 ' try bot_scheduled id=101',
3018 'Other:',
3019 ' try bot_status_unspecified id=100',
3020 'Total: 7 tryjobs',
3021 ], sys.stdout.getvalue().splitlines())
3022 git_cl._call_buildbucket.assert_called_once_with(
3023 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3024 self._DEFAULT_REQUEST)
3025
3026 @mock.patch('git_cl.write_json')
3027 def testWriteToJson(self, mockJsonDump):
3028 self.assertEqual(0, git_cl.main(['try-results', '--json', 'file.json']))
3029 git_cl._call_buildbucket.assert_called_once_with(
3030 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3031 self._DEFAULT_REQUEST)
3032 mockJsonDump.assert_called_once_with(
3033 'file.json', self._DEFAULT_RESPONSE['builds'])
3034
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003035 def test_filter_failed_for_one_simple(self):
3036 self.assertEqual({}, git_cl._filter_failed_for_retry([]))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003037 self.assertEqual({
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003038 'chromium/try': {
3039 'bot_failure': [],
3040 'bot_infra_failure': []
3041 },
3042 }, git_cl._filter_failed_for_retry(self._DEFAULT_RESPONSE['builds']))
3043
3044 def test_filter_failed_for_retry_many_builds(self):
3045
3046 def _build(name, created_sec, status, experimental=False):
3047 assert 0 <= created_sec < 100, created_sec
3048 b = {
3049 'id': 112112,
3050 'builder': {
3051 'project': 'chromium',
3052 'bucket': 'try',
3053 'builder': name,
3054 },
3055 'createTime': '2019-10-09T08:00:%02d.854286Z' % created_sec,
3056 'status': status,
3057 'tags': [],
3058 }
3059 if experimental:
3060 b['tags'].append({'key': 'cq_experimental', 'value': 'true'})
3061 return b
3062
3063 builds = [
3064 _build('flaky-last-green', 1, 'FAILURE'),
3065 _build('flaky-last-green', 2, 'SUCCESS'),
3066 _build('flaky', 1, 'SUCCESS'),
3067 _build('flaky', 2, 'FAILURE'),
3068 _build('running', 1, 'FAILED'),
3069 _build('running', 2, 'SCHEDULED'),
3070 _build('yep-still-running', 1, 'STARTED'),
3071 _build('yep-still-running', 2, 'FAILURE'),
3072 _build('cq-experimental', 1, 'SUCCESS', experimental=True),
3073 _build('cq-experimental', 2, 'FAILURE', experimental=True),
3074
3075 # Simulate experimental in CQ builder, which developer decided
3076 # to retry manually which resulted in 2nd build non-experimental.
3077 _build('sometimes-experimental', 1, 'FAILURE', experimental=True),
3078 _build('sometimes-experimental', 2, 'FAILURE', experimental=False),
3079 ]
3080 builds.sort(key=lambda b: b['status']) # ~deterministic shuffle.
3081 self.assertEqual({
3082 'chromium/try': {
3083 'flaky': [],
3084 'sometimes-experimental': []
3085 },
3086 }, git_cl._filter_failed_for_retry(builds))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003087
3088
3089class CMDTryTestCase(CMDTestCaseBase):
3090
3091 @mock.patch('git_cl.Changelist.SetCQState')
3092 @mock.patch('git_cl._get_bucket_map', return_value={})
3093 def testSetCQDryRunByDefault(self, _mockGetBucketMap, mockSetCQState):
3094 mockSetCQState.return_value = 0
Edward Lemur4c707a22019-09-24 21:13:43 +00003095 self.assertEqual(0, git_cl.main(['try']))
3096 git_cl.Changelist.SetCQState.assert_called_with(git_cl._CQState.DRY_RUN)
3097 self.assertEqual(
3098 sys.stdout.getvalue(),
3099 'Scheduling CQ dry run on: '
3100 'https://chromium-review.googlesource.com/123456\n')
3101
Edward Lemur4c707a22019-09-24 21:13:43 +00003102 @mock.patch('git_cl._call_buildbucket')
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003103 def testScheduleOnBuildbucket(self, mockCallBuildbucket):
Edward Lemur4c707a22019-09-24 21:13:43 +00003104 mockCallBuildbucket.return_value = {}
Edward Lemur4c707a22019-09-24 21:13:43 +00003105
3106 self.assertEqual(0, git_cl.main([
3107 'try', '-B', 'luci.chromium.try', '-b', 'win',
3108 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
3109 self.assertIn(
3110 'Scheduling jobs on:\nBucket: luci.chromium.try',
3111 git_cl.sys.stdout.getvalue())
3112
3113 expected_request = {
3114 "requests": [{
3115 "scheduleBuild": {
3116 "requestId": "uuid4",
3117 "builder": {
3118 "project": "chromium",
3119 "builder": "win",
3120 "bucket": "try",
3121 },
3122 "gerritChanges": [{
3123 "project": "depot_tools",
3124 "host": "chromium-review.googlesource.com",
3125 "patchset": 7,
3126 "change": 123456,
3127 }],
3128 "properties": {
3129 "category": "git_cl_try",
3130 "json": [{"a": 1}, None],
3131 "key": "val",
3132 },
3133 "tags": [
3134 {"value": "win", "key": "builder"},
3135 {"value": "git_cl_try", "key": "user_agent"},
3136 ],
3137 },
3138 }],
3139 }
3140 mockCallBuildbucket.assert_called_with(
3141 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3142
Anthony Polito1a5fe232020-01-24 23:17:52 +00003143 @mock.patch('git_cl._call_buildbucket')
3144 def testScheduleOnBuildbucketWithRevision(self, mockCallBuildbucket):
3145 mockCallBuildbucket.return_value = {}
3146
3147 self.assertEqual(0, git_cl.main([
3148 'try', '-B', 'luci.chromium.try', '-b', 'win', '-b', 'linux',
3149 '-p', 'key=val', '-p', 'json=[{"a":1}, null]',
3150 '-r', 'beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef']))
3151 self.assertIn(
3152 'Scheduling jobs on:\nBucket: luci.chromium.try',
3153 git_cl.sys.stdout.getvalue())
3154
3155 expected_request = {
3156 "requests": [{
3157 "scheduleBuild": {
3158 "requestId": "uuid4",
3159 "builder": {
3160 "project": "chromium",
3161 "builder": "linux",
3162 "bucket": "try",
3163 },
3164 "gerritChanges": [{
3165 "project": "depot_tools",
3166 "host": "chromium-review.googlesource.com",
3167 "patchset": 7,
3168 "change": 123456,
3169 }],
3170 "properties": {
3171 "category": "git_cl_try",
3172 "json": [{"a": 1}, None],
3173 "key": "val",
3174 },
3175 "tags": [
3176 {"value": "linux", "key": "builder"},
3177 {"value": "git_cl_try", "key": "user_agent"},
3178 ],
3179 "gitilesCommit": {
3180 "host": "chromium-review.googlesource.com",
3181 "project": "depot_tools",
3182 "id": "beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef",
3183 }
3184 },
3185 },
3186 {
3187 "scheduleBuild": {
3188 "requestId": "uuid4",
3189 "builder": {
3190 "project": "chromium",
3191 "builder": "win",
3192 "bucket": "try",
3193 },
3194 "gerritChanges": [{
3195 "project": "depot_tools",
3196 "host": "chromium-review.googlesource.com",
3197 "patchset": 7,
3198 "change": 123456,
3199 }],
3200 "properties": {
3201 "category": "git_cl_try",
3202 "json": [{"a": 1}, None],
3203 "key": "val",
3204 },
3205 "tags": [
3206 {"value": "win", "key": "builder"},
3207 {"value": "git_cl_try", "key": "user_agent"},
3208 ],
3209 "gitilesCommit": {
3210 "host": "chromium-review.googlesource.com",
3211 "project": "depot_tools",
3212 "id": "beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef",
3213 }
3214 },
3215 }],
3216 }
3217 mockCallBuildbucket.assert_called_with(
3218 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3219
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003220 def testScheduleOnBuildbucket_WrongBucket(self):
Edward Lemur4c707a22019-09-24 21:13:43 +00003221 self.assertEqual(0, git_cl.main([
3222 'try', '-B', 'not-a-bucket', '-b', 'win',
3223 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
3224 self.assertIn(
3225 'WARNING Could not parse bucket "not-a-bucket". Skipping.',
3226 git_cl.sys.stdout.getvalue())
3227
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003228 @mock.patch('git_cl._call_buildbucket')
3229 @mock.patch('git_cl.fetch_try_jobs')
3230 def testScheduleOnBuildbucketRetryFailed(
3231 self, mockFetchTryJobs, mockCallBuildbucket):
3232
3233 git_cl.fetch_try_jobs.side_effect = lambda *_, **kw: {
3234 7: [],
3235 6: [{
3236 'id': 112112,
3237 'builder': {
3238 'project': 'chromium',
3239 'bucket': 'try',
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003240 'builder': 'linux',},
3241 'createTime': '2019-10-09T08:00:01.854286Z',
3242 'tags': [],
3243 'status': 'FAILURE',}],}[kw['patchset']]
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003244 mockCallBuildbucket.return_value = {}
3245
3246 self.assertEqual(0, git_cl.main(['try', '--retry-failed']))
3247 self.assertIn(
3248 'Scheduling jobs on:\nBucket: chromium/try',
3249 git_cl.sys.stdout.getvalue())
3250
3251 expected_request = {
3252 "requests": [{
3253 "scheduleBuild": {
3254 "requestId": "uuid4",
3255 "builder": {
3256 "project": "chromium",
3257 "bucket": "try",
3258 "builder": "linux",
3259 },
3260 "gerritChanges": [{
3261 "project": "depot_tools",
3262 "host": "chromium-review.googlesource.com",
3263 "patchset": 7,
3264 "change": 123456,
3265 }],
3266 "properties": {
3267 "category": "git_cl_try",
3268 },
3269 "tags": [
3270 {"value": "linux", "key": "builder"},
3271 {"value": "git_cl_try", "key": "user_agent"},
3272 {"value": "1", "key": "retry_failed"},
3273 ],
3274 },
3275 }],
3276 }
3277 mockCallBuildbucket.assert_called_with(
3278 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3279
Edward Lemur4c707a22019-09-24 21:13:43 +00003280 def test_parse_bucket(self):
3281 test_cases = [
3282 {
3283 'bucket': 'chromium/try',
3284 'result': ('chromium', 'try'),
3285 },
3286 {
3287 'bucket': 'luci.chromium.try',
3288 'result': ('chromium', 'try'),
3289 'has_warning': True,
3290 },
3291 {
3292 'bucket': 'skia.primary',
3293 'result': ('skia', 'skia.primary'),
3294 'has_warning': True,
3295 },
3296 {
3297 'bucket': 'not-a-bucket',
3298 'result': (None, None),
3299 },
3300 ]
3301
3302 for test_case in test_cases:
3303 git_cl.sys.stdout.truncate(0)
3304 self.assertEqual(
3305 test_case['result'], git_cl._parse_bucket(test_case['bucket']))
3306 if test_case.get('has_warning'):
Edward Lemur6215c792019-10-03 21:59:05 +00003307 expected_warning = 'WARNING Please use %s/%s to specify the bucket' % (
3308 test_case['result'])
3309 self.assertIn(expected_warning, git_cl.sys.stdout.getvalue())
Edward Lemur4c707a22019-09-24 21:13:43 +00003310
3311
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003312class CMDUploadTestCase(CMDTestCaseBase):
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003313 def setUp(self):
3314 super(CMDUploadTestCase, self).setUp()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003315 mock.patch('git_cl.fetch_try_jobs').start()
3316 mock.patch('git_cl._trigger_try_jobs', return_value={}).start()
3317 mock.patch('git_cl.Changelist.CMDUpload', return_value=0).start()
Anthony Polito46689b02019-11-15 20:56:41 +00003318 mock.patch('git_cl.Settings.GetIsGerrit', return_value=True).start()
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003319 self.addCleanup(mock.patch.stopall)
3320
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003321 def testUploadRetryFailed(self):
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003322 # This test mocks out the actual upload part, and just asserts that after
3323 # upload, if --retry-failed is added, then the tool will fetch try jobs
3324 # from the previous patchset and trigger the right builders on the latest
3325 # patchset.
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003326 git_cl.fetch_try_jobs.side_effect = [
3327 # Latest patchset: No builds.
3328 [],
3329 # Patchset before latest: Some builds.
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003330 [{
3331 'id': str(100 + idx),
3332 'builder': {
3333 'project': 'chromium',
3334 'bucket': 'try',
3335 'builder': 'bot_' + status.lower(),
3336 },
3337 'createTime': '2019-10-09T08:00:0%d.854286Z' % (idx % 10),
3338 'tags': [],
3339 'status': status,
3340 } for idx, status in enumerate(self._STATUSES)],
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +00003341 ]
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003342
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003343 self.assertEqual(0, git_cl.main(['upload', '--retry-failed']))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003344 self.assertEqual([
Edward Lemur5b929a42019-10-21 17:57:39 +00003345 mock.call(mock.ANY, 'cr-buildbucket.appspot.com', patchset=7),
3346 mock.call(mock.ANY, 'cr-buildbucket.appspot.com', patchset=6),
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003347 ], git_cl.fetch_try_jobs.mock_calls)
3348 expected_buckets = {
3349 'chromium/try': {'bot_failure': [], 'bot_infra_failure': []},
3350 }
3351 git_cl._trigger_try_jobs.assert_called_once_with(
Edward Lemur5b929a42019-10-21 17:57:39 +00003352 mock.ANY, expected_buckets, mock.ANY, 8)
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003353
Brian Sheedy59b06a82019-10-14 17:03:29 +00003354
Edward Lemurda4b6c62020-02-13 00:28:40 +00003355class CMDFormatTestCase(unittest.TestCase):
Brian Sheedy59b06a82019-10-14 17:03:29 +00003356
3357 def setUp(self):
3358 super(CMDFormatTestCase, self).setUp()
Jamie Madill5e96ad12020-01-13 16:08:35 +00003359 mock.patch('git_cl.RunCommand').start()
3360 mock.patch('clang_format.FindClangFormatToolInChromiumTree').start()
3361 mock.patch('clang_format.FindClangFormatScriptInChromiumTree').start()
3362 mock.patch('git_cl.settings').start()
Brian Sheedy59b06a82019-10-14 17:03:29 +00003363 self._top_dir = tempfile.mkdtemp()
Jamie Madill5e96ad12020-01-13 16:08:35 +00003364 self.addCleanup(mock.patch.stopall)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003365
3366 def tearDown(self):
3367 shutil.rmtree(self._top_dir)
3368 super(CMDFormatTestCase, self).tearDown()
3369
Jamie Madill5e96ad12020-01-13 16:08:35 +00003370 def _make_temp_file(self, fname, contents):
3371 with open(os.path.join(self._top_dir, fname), 'w') as tf:
3372 tf.write('\n'.join(contents))
3373
Brian Sheedy59b06a82019-10-14 17:03:29 +00003374 def _make_yapfignore(self, contents):
Jamie Madill5e96ad12020-01-13 16:08:35 +00003375 self._make_temp_file('.yapfignore', contents)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003376
Brian Sheedyb4307d52019-12-02 19:18:17 +00003377 def _check_yapf_filtering(self, files, expected):
3378 self.assertEqual(expected, git_cl._FilterYapfIgnoredFiles(
3379 files, git_cl._GetYapfIgnorePatterns(self._top_dir)))
Brian Sheedy59b06a82019-10-14 17:03:29 +00003380
Jamie Madill5e96ad12020-01-13 16:08:35 +00003381 def testClangFormatDiffFull(self):
3382 self._make_temp_file('test.cc', ['// test'])
3383 git_cl.settings.GetFormatFullByDefault.return_value = False
3384 diff_file = [os.path.join(self._top_dir, 'test.cc')]
3385 mock_opts = mock.Mock(full=True, dry_run=True, diff=False)
3386
3387 # Diff
3388 git_cl.RunCommand.return_value = ' // test'
3389 return_value = git_cl._RunClangFormatDiff(mock_opts, diff_file,
3390 self._top_dir, 'HEAD')
3391 self.assertEqual(2, return_value)
3392
3393 # No diff
3394 git_cl.RunCommand.return_value = '// test'
3395 return_value = git_cl._RunClangFormatDiff(mock_opts, diff_file,
3396 self._top_dir, 'HEAD')
3397 self.assertEqual(0, return_value)
3398
3399 def testClangFormatDiff(self):
3400 git_cl.settings.GetFormatFullByDefault.return_value = False
3401 mock_opts = mock.Mock(full=False, dry_run=True, diff=False)
3402
3403 # Diff
3404 git_cl.RunCommand.return_value = 'error'
3405 return_value = git_cl._RunClangFormatDiff(mock_opts, ['.'], self._top_dir,
3406 'HEAD')
3407 self.assertEqual(2, return_value)
3408
3409 # No diff
3410 git_cl.RunCommand.return_value = ''
3411 return_value = git_cl._RunClangFormatDiff(mock_opts, ['.'], self._top_dir,
3412 'HEAD')
3413 self.assertEqual(0, return_value)
3414
Brian Sheedyb4307d52019-12-02 19:18:17 +00003415 def testYapfignoreExplicit(self):
3416 self._make_yapfignore(['foo/bar.py', 'foo/bar/baz.py'])
3417 files = [
3418 'bar.py',
3419 'foo/bar.py',
3420 'foo/baz.py',
3421 'foo/bar/baz.py',
3422 'foo/bar/foobar.py',
3423 ]
3424 expected = [
3425 'bar.py',
3426 'foo/baz.py',
3427 'foo/bar/foobar.py',
3428 ]
3429 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003430
Brian Sheedyb4307d52019-12-02 19:18:17 +00003431 def testYapfignoreSingleWildcards(self):
3432 self._make_yapfignore(['*bar.py', 'foo*', 'baz*.py'])
3433 files = [
3434 'bar.py', # Matched by *bar.py.
3435 'bar.txt',
3436 'foobar.py', # Matched by *bar.py, foo*.
3437 'foobar.txt', # Matched by foo*.
3438 'bazbar.py', # Matched by *bar.py, baz*.py.
3439 'bazbar.txt',
3440 'foo/baz.txt', # Matched by foo*.
3441 'bar/bar.py', # Matched by *bar.py.
3442 'baz/foo.py', # Matched by baz*.py, foo*.
3443 'baz/foo.txt',
3444 ]
3445 expected = [
3446 'bar.txt',
3447 'bazbar.txt',
3448 'baz/foo.txt',
3449 ]
3450 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003451
Brian Sheedyb4307d52019-12-02 19:18:17 +00003452 def testYapfignoreMultiplewildcards(self):
3453 self._make_yapfignore(['*bar*', '*foo*baz.txt'])
3454 files = [
3455 'bar.py', # Matched by *bar*.
3456 'bar.txt', # Matched by *bar*.
3457 'abar.py', # Matched by *bar*.
3458 'foobaz.txt', # Matched by *foo*baz.txt.
3459 'foobaz.py',
3460 'afoobaz.txt', # Matched by *foo*baz.txt.
3461 ]
3462 expected = [
3463 'foobaz.py',
3464 ]
3465 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003466
3467 def testYapfignoreComments(self):
3468 self._make_yapfignore(['test.py', '#test2.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003469 files = [
3470 'test.py',
3471 'test2.py',
3472 ]
3473 expected = [
3474 'test2.py',
3475 ]
3476 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003477
3478 def testYapfignoreBlankLines(self):
3479 self._make_yapfignore(['test.py', '', '', 'test2.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003480 files = [
3481 'test.py',
3482 'test2.py',
3483 'test3.py',
3484 ]
3485 expected = [
3486 'test3.py',
3487 ]
3488 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003489
3490 def testYapfignoreWhitespace(self):
3491 self._make_yapfignore([' test.py '])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003492 files = [
3493 'test.py',
3494 'test2.py',
3495 ]
3496 expected = [
3497 'test2.py',
3498 ]
3499 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003500
Brian Sheedyb4307d52019-12-02 19:18:17 +00003501 def testYapfignoreNoFiles(self):
Brian Sheedy59b06a82019-10-14 17:03:29 +00003502 self._make_yapfignore(['test.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003503 self._check_yapf_filtering([], [])
3504
3505 def testYapfignoreMissingYapfignore(self):
3506 files = [
3507 'test.py',
3508 ]
3509 expected = [
3510 'test.py',
3511 ]
3512 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003513
3514
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003515if __name__ == '__main__':
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +01003516 logging.basicConfig(
3517 level=logging.DEBUG if '-v' in sys.argv else logging.ERROR)
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003518 unittest.main()