blob: 555cc9037fbb00e641bf4359ec83c1ccb2fc3f52 [file] [log] [blame]
Edward Lemur0db01f02019-11-12 22:01:51 +00001#!/usr/bin/env vpython3
2# coding=utf-8
maruel@chromium.orgeb5edbc2012-01-16 17:03:28 +00003# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@chromium.orgddd59412011-11-30 14:20:38 +00004# Use of this source code is governed by a BSD-style license that can be
5# found in the LICENSE file.
6
7"""Unit tests for git_cl.py."""
8
Edward Lemur85153282020-02-14 22:06:29 +00009from __future__ import print_function
Edward Lemur0db01f02019-11-12 22:01:51 +000010from __future__ import unicode_literals
11
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +010012import datetime
tandriide281ae2016-10-12 06:02:30 -070013import json
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +010014import logging
maruel@chromium.orgddd59412011-11-30 14:20:38 +000015import os
Edward Lemur85153282020-02-14 22:06:29 +000016import pprint
Brian Sheedy59b06a82019-10-14 17:03:29 +000017import shutil
maruel@chromium.orgddd59412011-11-30 14:20:38 +000018import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070019import tempfile
maruel@chromium.orgddd59412011-11-30 14:20:38 +000020import unittest
21
Edward Lemura8145022020-01-06 18:47:54 +000022if sys.version_info.major == 2:
23 from StringIO import StringIO
24 import mock
25else:
26 from io import StringIO
27 from unittest import mock
28
maruel@chromium.orgddd59412011-11-30 14:20:38 +000029sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
30
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000031import metrics
32# We have to disable monitoring before importing git_cl.
33metrics.DISABLE_METRICS_COLLECTION = True
34
Jamie Madill5e96ad12020-01-13 16:08:35 +000035import clang_format
Eric Boren2fb63102018-10-05 13:05:03 +000036import gerrit_util
maruel@chromium.orgddd59412011-11-30 14:20:38 +000037import git_cl
iannucci@chromium.org9e849272014-04-04 00:31:55 +000038import git_common
tandrii@chromium.org57d86542016-03-04 16:11:32 +000039import git_footers
Edward Lemur85153282020-02-14 22:06:29 +000040import git_new_branch
41import scm
maruel@chromium.orgddd59412011-11-30 14:20:38 +000042import subprocess2
maruel@chromium.orgddd59412011-11-30 14:20:38 +000043
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000044
Edward Lemur0db01f02019-11-12 22:01:51 +000045def callError(code=1, cmd='', cwd='', stdout=b'', stderr=b''):
tandrii5d48c322016-08-18 16:19:37 -070046 return subprocess2.CalledProcessError(code, cmd, cwd, stdout, stderr)
47
48
Edward Lemur4c707a22019-09-24 21:13:43 +000049def _constantFn(return_value):
50 def f(*args, **kwargs):
51 return return_value
52 return f
53
54
tandrii5d48c322016-08-18 16:19:37 -070055CERR1 = callError(1)
56
57
Edward Lemur0db01f02019-11-12 22:01:51 +000058def MakeNamedTemporaryFileMock(test, expected_content):
Aaron Gable9a03ae02017-11-03 11:31:07 -070059 class NamedTemporaryFileMock(object):
60 def __init__(self, *args, **kwargs):
61 self.name = '/tmp/named'
Edward Lemur0db01f02019-11-12 22:01:51 +000062 self.expected_content = expected_content.encode('utf-8', 'replace')
Aaron Gable9a03ae02017-11-03 11:31:07 -070063
64 def __enter__(self):
65 return self
66
67 def __exit__(self, _type, _value, _tb):
68 pass
69
70 def write(self, content):
71 if self.expected_content:
Edward Lemur0db01f02019-11-12 22:01:51 +000072 test.assertEqual(self.expected_content, content)
Aaron Gable9a03ae02017-11-03 11:31:07 -070073
74 def close(self):
75 pass
76
77 return NamedTemporaryFileMock
78
79
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000080class ChangelistMock(object):
81 # A class variable so we can access it when we don't have access to the
82 # instance that's being set.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000083 desc = ''
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000084 def __init__(self, **kwargs):
85 pass
86 def GetIssue(self):
87 return 1
Edward Lemur6c6827c2020-02-06 21:15:18 +000088 def FetchDescription(self):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000089 return ChangelistMock.desc
dsansomee2d6fd92016-09-08 00:10:47 -070090 def UpdateDescription(self, desc, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000091 ChangelistMock.desc = desc
92
tandrii5d48c322016-08-18 16:19:37 -070093
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000094class PresubmitMock(object):
95 def __init__(self, *args, **kwargs):
96 self.reviewers = []
Daniel Cheng7227d212017-11-17 08:12:37 -080097 self.more_cc = ['chromium-reviews+test-more-cc@chromium.org']
98
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000099 @staticmethod
100 def should_continue():
101 return True
102
103
Edward Lemur85153282020-02-14 22:06:29 +0000104class GitMocks(object):
105 def __init__(self, config=None, branchref=None):
106 self.branchref = branchref or 'refs/heads/master'
107 self.config = config or {}
108
109 def GetBranchRef(self, _root):
110 return self.branchref
111
112 def NewBranch(self, branchref):
113 self.branchref = branchref
114
Edward Lemur26964072020-02-19 19:18:51 +0000115 def GetConfig(self, root, key, default=None):
116 if root != '':
117 key = '%s:%s' % (root, key)
Edward Lemur85153282020-02-14 22:06:29 +0000118 return self.config.get(key, default)
119
Edward Lemur26964072020-02-19 19:18:51 +0000120 def SetConfig(self, root, key, value=None):
121 if root != '':
122 key = '%s:%s' % (root, key)
Edward Lemur85153282020-02-14 22:06:29 +0000123 if value:
124 self.config[key] = value
125 return
126 if key not in self.config:
127 raise CERR1
128 del self.config[key]
129
130
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000131class WatchlistsMock(object):
132 def __init__(self, _):
133 pass
134 @staticmethod
135 def GetWatchersForPaths(_):
136 return ['joe@example.com']
137
138
Edward Lemur4c707a22019-09-24 21:13:43 +0000139class CodereviewSettingsFileMock(object):
140 def __init__(self):
141 pass
142 # pylint: disable=no-self-use
143 def read(self):
144 return ('CODE_REVIEW_SERVER: gerrit.chromium.org\n' +
145 'GERRIT_HOST: True\n')
146
147
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000148class AuthenticatorMock(object):
149 def __init__(self, *_args):
150 pass
151 def has_cached_credentials(self):
152 return True
tandrii221ab252016-10-06 08:12:04 -0700153 def authorize(self, http):
154 return http
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000155
156
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100157def CookiesAuthenticatorMockFactory(hosts_with_creds=None, same_auth=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000158 """Use to mock Gerrit/Git credentials from ~/.netrc or ~/.gitcookies.
159
160 Usage:
161 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100162 CookiesAuthenticatorMockFactory({'host': ('user', _, 'pass')})
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000163
164 OR
165 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100166 CookiesAuthenticatorMockFactory(
167 same_auth=('user', '', 'pass'))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000168 """
169 class CookiesAuthenticatorMock(git_cl.gerrit_util.CookiesAuthenticator):
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800170 def __init__(self): # pylint: disable=super-init-not-called
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000171 # Intentionally not calling super() because it reads actual cookie files.
172 pass
173 @classmethod
174 def get_gitcookies_path(cls):
175 return '~/.gitcookies'
176 @classmethod
177 def get_netrc_path(cls):
178 return '~/.netrc'
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100179 def _get_auth_for_host(self, host):
180 if same_auth:
181 return same_auth
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000182 return (hosts_with_creds or {}).get(host)
183 return CookiesAuthenticatorMock
184
Aaron Gable9a03ae02017-11-03 11:31:07 -0700185
kmarshall9249e012016-08-23 12:02:16 -0700186class MockChangelistWithBranchAndIssue():
187 def __init__(self, branch, issue):
188 self.branch = branch
189 self.issue = issue
190 def GetBranch(self):
191 return self.branch
192 def GetIssue(self):
193 return self.issue
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000194
tandriic2405f52016-10-10 08:13:15 -0700195
196class SystemExitMock(Exception):
197 pass
198
199
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000200class TestGitClBasic(unittest.TestCase):
Edward Lemur6c6827c2020-02-06 21:15:18 +0000201 def test_fetch_description(self):
Edward Lemurf38bc172019-09-03 21:02:13 +0000202 cl = git_cl.Changelist(issue=1, codereview_host='host')
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100203 cl.description = 'x'
204 cl.has_description = True
Edward Lemur6c6827c2020-02-06 21:15:18 +0000205 self.assertEqual(cl.FetchDescription(), 'x')
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700206
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +0000207 def test_set_preserve_tryjobs(self):
208 d = git_cl.ChangeDescription('Simple.')
209 d.set_preserve_tryjobs()
210 self.assertEqual(d.description.splitlines(), [
211 'Simple.',
212 '',
213 'Cq-Do-Not-Cancel-Tryjobs: true',
214 ])
215 before = d.description
216 d.set_preserve_tryjobs()
217 self.assertEqual(before, d.description)
218
219 d = git_cl.ChangeDescription('\n'.join([
220 'One is enough',
221 '',
222 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
223 'Change-Id: Ideadbeef',
224 ]))
225 d.set_preserve_tryjobs()
226 self.assertEqual(d.description.splitlines(), [
227 'One is enough',
228 '',
229 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
230 'Change-Id: Ideadbeef',
231 'Cq-Do-Not-Cancel-Tryjobs: true',
232 ])
233
tandriif9aefb72016-07-01 09:06:51 -0700234 def test_get_bug_line_values(self):
235 f = lambda p, bugs: list(git_cl._get_bug_line_values(p, bugs))
236 self.assertEqual(f('', ''), [])
237 self.assertEqual(f('', '123,v8:456'), ['123', 'v8:456'])
238 self.assertEqual(f('v8', '456'), ['v8:456'])
239 self.assertEqual(f('v8', 'chromium:123,456'), ['v8:456', 'chromium:123'])
240 # Not nice, but not worth carying.
241 self.assertEqual(f('v8', 'chromium:123,456,v8:123'),
242 ['v8:456', 'chromium:123', 'v8:123'])
243
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100244 def _test_git_number(self, parent_msg, dest_ref, child_msg,
245 parent_hash='parenthash'):
246 desc = git_cl.ChangeDescription(child_msg)
247 desc.update_with_git_number_footers(parent_hash, parent_msg, dest_ref)
248 return desc.description
249
250 def assertEqualByLine(self, actual, expected):
251 self.assertEqual(actual.splitlines(), expected.splitlines())
252
253 def test_git_number_bad_parent(self):
254 with self.assertRaises(ValueError):
255 self._test_git_number('Parent', 'refs/heads/master', 'Child')
256
257 def test_git_number_bad_parent_footer(self):
258 with self.assertRaises(AssertionError):
259 self._test_git_number(
260 'Parent\n'
261 '\n'
262 'Cr-Commit-Position: wrong',
263 'refs/heads/master', 'Child')
264
265 def test_git_number_bad_lineage_ignored(self):
266 actual = self._test_git_number(
267 'Parent\n'
268 '\n'
269 'Cr-Commit-Position: refs/heads/master@{#1}\n'
270 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}',
271 'refs/heads/master', 'Child')
272 self.assertEqualByLine(
273 actual,
274 'Child\n'
275 '\n'
276 'Cr-Commit-Position: refs/heads/master@{#2}\n'
277 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}')
278
279 def test_git_number_same_branch(self):
280 actual = self._test_git_number(
281 'Parent\n'
282 '\n'
283 'Cr-Commit-Position: refs/heads/master@{#12}',
284 dest_ref='refs/heads/master',
285 child_msg='Child')
286 self.assertEqualByLine(
287 actual,
288 'Child\n'
289 '\n'
290 'Cr-Commit-Position: refs/heads/master@{#13}')
291
Andrii Shyshkalovde37c012017-07-06 21:06:50 +0200292 def test_git_number_same_branch_mixed_footers(self):
293 actual = self._test_git_number(
294 'Parent\n'
295 '\n'
296 'Cr-Commit-Position: refs/heads/master@{#12}',
297 dest_ref='refs/heads/master',
298 child_msg='Child\n'
299 '\n'
300 'Broken-by: design\n'
301 'BUG=123')
302 self.assertEqualByLine(
303 actual,
304 'Child\n'
305 '\n'
306 'Broken-by: design\n'
307 'BUG=123\n'
308 'Cr-Commit-Position: refs/heads/master@{#13}')
309
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100310 def test_git_number_same_branch_with_originals(self):
311 actual = self._test_git_number(
312 'Parent\n'
313 '\n'
314 'Cr-Commit-Position: refs/heads/master@{#12}',
315 dest_ref='refs/heads/master',
316 child_msg='Child\n'
317 '\n'
318 'Some users are smart and insert their own footers\n'
319 '\n'
320 'Cr-Whatever: value\n'
321 'Cr-Commit-Position: refs/copy/paste@{#22}')
322 self.assertEqualByLine(
323 actual,
324 'Child\n'
325 '\n'
326 'Some users are smart and insert their own footers\n'
327 '\n'
328 'Cr-Original-Whatever: value\n'
329 'Cr-Original-Commit-Position: refs/copy/paste@{#22}\n'
330 'Cr-Commit-Position: refs/heads/master@{#13}')
331
332 def test_git_number_new_branch(self):
333 actual = self._test_git_number(
334 'Parent\n'
335 '\n'
336 'Cr-Commit-Position: refs/heads/master@{#12}',
337 dest_ref='refs/heads/branch',
338 child_msg='Child')
339 self.assertEqualByLine(
340 actual,
341 'Child\n'
342 '\n'
343 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
344 'Cr-Branched-From: parenthash-refs/heads/master@{#12}')
345
346 def test_git_number_lineage(self):
347 actual = self._test_git_number(
348 'Parent\n'
349 '\n'
350 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
351 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
352 dest_ref='refs/heads/branch',
353 child_msg='Child')
354 self.assertEqualByLine(
355 actual,
356 'Child\n'
357 '\n'
358 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
359 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
360
361 def test_git_number_moooooooore_lineage(self):
362 actual = self._test_git_number(
363 'Parent\n'
364 '\n'
365 'Cr-Commit-Position: refs/heads/branch@{#5}\n'
366 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
367 dest_ref='refs/heads/mooore',
368 child_msg='Child')
369 self.assertEqualByLine(
370 actual,
371 'Child\n'
372 '\n'
373 'Cr-Commit-Position: refs/heads/mooore@{#1}\n'
374 'Cr-Branched-From: parenthash-refs/heads/branch@{#5}\n'
375 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
376
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100377 def test_git_number_ever_moooooooore_lineage(self):
Robert Iannucci456b0d62018-03-13 19:15:50 -0700378 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100379 actual = self._test_git_number(
380 'CQ commit on fresh new branch + numbering.\n'
381 '\n'
382 'NOTRY=True\n'
383 'NOPRESUBMIT=True\n'
384 'BUG=\n'
385 '\n'
386 'Review-Url: https://codereview.chromium.org/2577703003\n'
387 'Cr-Commit-Position: refs/heads/gnumb-test/br@{#1}\n'
388 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
389 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}',
390 dest_ref='refs/heads/gnumb-test/cl',
391 child_msg='git cl on fresh new branch + numbering.\n'
392 '\n'
393 'Review-Url: https://codereview.chromium.org/2575043003 .\n')
394 self.assertEqualByLine(
395 actual,
396 'git cl on fresh new branch + numbering.\n'
397 '\n'
398 'Review-Url: https://codereview.chromium.org/2575043003 .\n'
399 'Cr-Commit-Position: refs/heads/gnumb-test/cl@{#1}\n'
400 'Cr-Branched-From: parenthash-refs/heads/gnumb-test/br@{#1}\n'
401 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
402 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}')
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100403
404 def test_git_number_cherry_pick(self):
405 actual = self._test_git_number(
406 'Parent\n'
407 '\n'
408 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
409 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
410 dest_ref='refs/heads/branch',
411 child_msg='Child, which is cherry-pick from master\n'
412 '\n'
413 'Cr-Commit-Position: refs/heads/master@{#100}\n'
414 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)')
415 self.assertEqualByLine(
416 actual,
417 'Child, which is cherry-pick from master\n'
418 '\n'
419 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)\n'
420 '\n'
421 'Cr-Original-Commit-Position: refs/heads/master@{#100}\n'
422 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
423 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
424
Edward Lemurda4b6c62020-02-13 00:28:40 +0000425 @mock.patch('gerrit_util.GetAccountDetails')
426 def test_valid_accounts(self, mockGetAccountDetails):
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000427 mock_per_account = {
428 'u1': None, # 404, doesn't exist.
429 'u2': {
430 '_account_id': 123124,
431 'avatars': [],
432 'email': 'u2@example.com',
433 'name': 'User Number 2',
434 'status': 'OOO',
435 },
436 'u3': git_cl.gerrit_util.GerritError(500, 'retries didn\'t help :('),
437 }
438 def GetAccountDetailsMock(_, account):
439 # Poor-man's mock library's side_effect.
440 v = mock_per_account.pop(account)
441 if isinstance(v, Exception):
442 raise v
443 return v
444
Edward Lemurda4b6c62020-02-13 00:28:40 +0000445 mockGetAccountDetails.side_effect = GetAccountDetailsMock
446 actual = git_cl.gerrit_util.ValidAccounts(
447 'host', ['u1', 'u2', 'u3'], max_threads=1)
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000448 self.assertEqual(actual, {
449 'u2': {
450 '_account_id': 123124,
451 'avatars': [],
452 'email': 'u2@example.com',
453 'name': 'User Number 2',
454 'status': 'OOO',
455 },
456 })
457
458
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200459class TestParseIssueURL(unittest.TestCase):
460 def _validate(self, parsed, issue=None, patchset=None, hostname=None,
Edward Lemurf38bc172019-09-03 21:02:13 +0000461 fail=False):
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200462 self.assertIsNotNone(parsed)
463 if fail:
464 self.assertFalse(parsed.valid)
465 return
466 self.assertTrue(parsed.valid)
467 self.assertEqual(parsed.issue, issue)
468 self.assertEqual(parsed.patchset, patchset)
469 self.assertEqual(parsed.hostname, hostname)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200470
Edward Lemur678a6842019-10-03 22:25:05 +0000471 def test_ParseIssueNumberArgument(self):
472 def test(arg, *args, **kwargs):
473 self._validate(git_cl.ParseIssueNumberArgument(arg), *args, **kwargs)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200474
Edward Lemur678a6842019-10-03 22:25:05 +0000475 test('123', 123)
476 test('', fail=True)
477 test('abc', fail=True)
478 test('123/1', fail=True)
479 test('123a', fail=True)
480 test('ssh://chrome-review.source.com/#/c/123/4/', fail=True)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200481
Edward Lemur678a6842019-10-03 22:25:05 +0000482 test('https://codereview.source.com/123',
483 123, None, 'codereview.source.com')
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200484 test('http://chrome-review.source.com/c/123',
485 123, None, 'chrome-review.source.com')
486 test('https://chrome-review.source.com/c/123/',
487 123, None, 'chrome-review.source.com')
488 test('https://chrome-review.source.com/c/123/4',
489 123, 4, 'chrome-review.source.com')
490 test('https://chrome-review.source.com/#/c/123/4',
491 123, 4, 'chrome-review.source.com')
492 test('https://chrome-review.source.com/c/123/4',
493 123, 4, 'chrome-review.source.com')
494 test('https://chrome-review.source.com/123',
495 123, None, 'chrome-review.source.com')
496 test('https://chrome-review.source.com/123/4',
497 123, 4, 'chrome-review.source.com')
498
Edward Lemur678a6842019-10-03 22:25:05 +0000499 test('https://chrome-review.source.com/bad/123/4', fail=True)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200500 test('https://chrome-review.source.com/c/123/1/whatisthis', fail=True)
501 test('https://chrome-review.source.com/c/abc/', fail=True)
502 test('ssh://chrome-review.source.com/c/123/1/', fail=True)
503
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200504
505
Edward Lemurda4b6c62020-02-13 00:28:40 +0000506class GitCookiesCheckerTest(unittest.TestCase):
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100507 def setUp(self):
508 super(GitCookiesCheckerTest, self).setUp()
509 self.c = git_cl._GitCookiesChecker()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100510 self.c._all_hosts = []
Edward Lemurda4b6c62020-02-13 00:28:40 +0000511 mock.patch('sys.stdout', StringIO()).start()
512 self.addCleanup(mock.patch.stopall)
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100513
514 def mock_hosts_creds(self, subhost_identity_pairs):
515 def ensure_googlesource(h):
516 if not h.endswith(self.c._GOOGLESOURCE):
517 assert not h.endswith('.')
518 return h + '.' + self.c._GOOGLESOURCE
519 return h
520 self.c._all_hosts = [(ensure_googlesource(h), i, '.gitcookies')
521 for h, i in subhost_identity_pairs]
522
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200523 def test_identity_parsing(self):
524 self.assertEqual(self.c._parse_identity('ldap.google.com'),
525 ('ldap', 'google.com'))
526 self.assertEqual(self.c._parse_identity('git-ldap.example.com'),
527 ('ldap', 'example.com'))
528 # Specical case because we know there are no subdomains in chromium.org.
529 self.assertEqual(self.c._parse_identity('git-note.period.chromium.org'),
530 ('note.period', 'chromium.org'))
Lei Zhangd3f769a2017-12-15 15:16:14 -0800531 # Pathological: ".period." can be either username OR domain, more likely
532 # domain.
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200533 self.assertEqual(self.c._parse_identity('git-note.period.example.com'),
534 ('note', 'period.example.com'))
535
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100536 def test_analysis_nothing(self):
537 self.c._all_hosts = []
538 self.assertFalse(self.c.has_generic_host())
539 self.assertEqual(set(), self.c.get_conflicting_hosts())
540 self.assertEqual(set(), self.c.get_duplicated_hosts())
541 self.assertEqual(set(), self.c.get_partially_configured_hosts())
542 self.assertEqual(set(), self.c.get_hosts_with_wrong_identities())
543
544 def test_analysis(self):
545 self.mock_hosts_creds([
546 ('.googlesource.com', 'git-example.chromium.org'),
547
548 ('chromium', 'git-example.google.com'),
549 ('chromium-review', 'git-example.google.com'),
550 ('chrome-internal', 'git-example.chromium.org'),
551 ('chrome-internal-review', 'git-example.chromium.org'),
552 ('conflict', 'git-example.google.com'),
553 ('conflict-review', 'git-example.chromium.org'),
554 ('dup', 'git-example.google.com'),
555 ('dup', 'git-example.google.com'),
556 ('dup-review', 'git-example.google.com'),
557 ('partial', 'git-example.google.com'),
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200558 ('gpartial-review', 'git-example.google.com'),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100559 ])
560 self.assertTrue(self.c.has_generic_host())
561 self.assertEqual(set(['conflict.googlesource.com']),
562 self.c.get_conflicting_hosts())
563 self.assertEqual(set(['dup.googlesource.com']),
564 self.c.get_duplicated_hosts())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200565 self.assertEqual(set(['partial.googlesource.com',
566 'gpartial-review.googlesource.com']),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100567 self.c.get_partially_configured_hosts())
568 self.assertEqual(set(['chromium.googlesource.com',
569 'chrome-internal.googlesource.com']),
570 self.c.get_hosts_with_wrong_identities())
571
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100572 def test_report_no_problems(self):
573 self.test_analysis_nothing()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100574 self.assertFalse(self.c.find_and_report_problems())
575 self.assertEqual(sys.stdout.getvalue(), '')
576
Edward Lemurda4b6c62020-02-13 00:28:40 +0000577 @mock.patch(
578 'git_cl.gerrit_util.CookiesAuthenticator.get_gitcookies_path',
579 return_value='~/.gitcookies')
580 def test_report(self, *_mocks):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100581 self.test_analysis()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100582 self.assertTrue(self.c.find_and_report_problems())
583 with open(os.path.join(os.path.dirname(__file__),
584 'git_cl_creds_check_report.txt')) as f:
585 expected = f.read()
586 def by_line(text):
587 return [l.rstrip() for l in text.rstrip().splitlines()]
Robert Iannucci456b0d62018-03-13 19:15:50 -0700588 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalov4812e612017-03-27 17:22:57 +0200589 self.assertEqual(by_line(sys.stdout.getvalue().strip()), by_line(expected))
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100590
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -0800591
Edward Lemurda4b6c62020-02-13 00:28:40 +0000592class TestGitCl(unittest.TestCase):
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000593 def setUp(self):
594 super(TestGitCl, self).setUp()
595 self.calls = []
tandrii9d206752016-06-20 11:32:47 -0700596 self._calls_done = []
Edward Lemurda4b6c62020-02-13 00:28:40 +0000597 mock.patch('sys.stdout', StringIO()).start()
598 mock.patch(
599 'git_cl.time_time',
600 lambda: self._mocked_call('time.time')).start()
601 mock.patch(
602 'git_cl.metrics.collector.add_repeated',
603 lambda *a: self._mocked_call('add_repeated', *a)).start()
604 mock.patch('subprocess2.call', self._mocked_call).start()
605 mock.patch('subprocess2.check_call', self._mocked_call).start()
606 mock.patch('subprocess2.check_output', self._mocked_call).start()
607 mock.patch(
608 'subprocess2.communicate',
609 lambda *a, **_k: ([self._mocked_call(*a), ''], 0)).start()
610 mock.patch(
611 'git_cl.gclient_utils.CheckCallAndFilter',
612 self._mocked_call).start()
613 mock.patch('git_common.is_dirty_git_tree', lambda x: False).start()
614 mock.patch(
615 'git_common.get_or_create_merge_base',
616 lambda *a: self._mocked_call('get_or_create_merge_base', *a)).start()
617 mock.patch('git_cl.BranchExists', return_value=True).start()
618 mock.patch('git_cl.FindCodereviewSettingsFile', return_value='').start()
619 mock.patch(
620 'git_cl.SaveDescriptionBackup',
621 lambda _: self._mocked_call('SaveDescriptionBackup')).start()
622 mock.patch(
623 'git_cl.ask_for_data',
624 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
625 mock.patch(
626 'git_cl.write_json',
627 lambda *a: self._mocked_call('write_json', *a)).start()
628 mock.patch(
629 'git_cl.presubmit_support.DoPresubmitChecks', PresubmitMock).start()
630 mock.patch('git_cl.watchlists.Watchlists', WatchlistsMock).start()
631 mock.patch('git_cl.auth.Authenticator', AuthenticatorMock).start()
Edward Lesmes7677e5c2020-02-19 20:39:03 +0000632 mock.patch('gerrit_util.GetChangeDetail').start()
Edward Lemurda4b6c62020-02-13 00:28:40 +0000633 mock.patch(
634 'git_cl.gerrit_util.GetChangeComments',
635 lambda *a: self._mocked_call('GetChangeComments', *a)).start()
636 mock.patch(
637 'git_cl.gerrit_util.GetChangeRobotComments',
638 lambda *a: self._mocked_call('GetChangeRobotComments', *a)).start()
639 mock.patch(
640 'git_cl.gerrit_util.AddReviewers',
641 lambda *a: self._mocked_call('AddReviewers', *a)).start()
642 mock.patch(
643 'git_cl.gerrit_util.SetReview',
644 lambda h, i, msg=None, labels=None, notify=None, ready=None: (
645 self._mocked_call(
646 'SetReview', h, i, msg, labels, notify, ready))).start()
647 mock.patch(
648 'git_cl.gerrit_util.LuciContextAuthenticator.is_luci',
649 return_value=False).start()
650 mock.patch(
651 'git_cl.gerrit_util.GceAuthenticator.is_gce',
652 return_value=False).start()
653 mock.patch(
654 'git_cl.gerrit_util.ValidAccounts',
655 lambda *a: self._mocked_call('ValidAccounts', *a)).start()
656 mock.patch(
657 'git_cl.DieWithError',
658 lambda msg, change=None: self._mocked_call('DieWithError', msg)).start()
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000659 mock.patch('git_cl.Settings.GetRoot', return_value='').start()
Edward Lemur85153282020-02-14 22:06:29 +0000660 self.mockGit = GitMocks()
661 mock.patch('scm.GIT.GetBranchRef', self.mockGit.GetBranchRef).start()
662 mock.patch('scm.GIT.GetConfig', self.mockGit.GetConfig).start()
663 mock.patch('scm.GIT.SetConfig', self.mockGit.SetConfig).start()
664 mock.patch('git_new_branch.main', self.mockGit.NewBranch).start()
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000665 mock.patch(
Edward Lemur85153282020-02-14 22:06:29 +0000666 'scm.GIT.FetchUpstreamTuple',
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000667 return_value=('origin', 'refs/heads/master')).start()
Edward Lemur85153282020-02-14 22:06:29 +0000668 mock.patch(
669 'scm.GIT.CaptureStatus', return_value=[('M', 'foo.txt')]).start()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000670 # It's important to reset settings to not have inter-tests interference.
671 git_cl.settings = None
Edward Lemurda4b6c62020-02-13 00:28:40 +0000672 self.addCleanup(mock.patch.stopall)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000673
674 def tearDown(self):
wychen@chromium.org445c8962015-04-28 23:30:05 +0000675 try:
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +0000676 self.assertEqual([], self.calls)
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100677 except AssertionError:
Edward Lemur85153282020-02-14 22:06:29 +0000678 calls = ''.join(' %s\n' % str(call) for call in self.calls[:5])
679 if len(self.calls) > 5:
680 calls += ' ...\n'
681 self.fail(
682 '\n'
683 'There are un-consumed calls after this test has finished:\n' +
684 calls)
wychen@chromium.org445c8962015-04-28 23:30:05 +0000685 finally:
686 super(TestGitCl, self).tearDown()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000687
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000688 def _mocked_call(self, *args, **_kwargs):
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000689 self.assertTrue(
690 self.calls,
tandrii9d206752016-06-20 11:32:47 -0700691 '@%d Expected: <Missing> Actual: %r' % (len(self._calls_done), args))
wychen@chromium.orga872e752015-04-28 23:42:18 +0000692 top = self.calls.pop(0)
wychen@chromium.orga872e752015-04-28 23:42:18 +0000693 expected_args, result = top
694
maruel@chromium.orge52678e2013-04-26 18:34:44 +0000695 # Also logs otherwise it could get caught in a try/finally and be hard to
696 # diagnose.
697 if expected_args != args:
tandrii9d206752016-06-20 11:32:47 -0700698 N = 5
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000699 prior_calls = '\n '.join(
tandrii9d206752016-06-20 11:32:47 -0700700 '@%d: %r' % (len(self._calls_done) - N + i, c[0])
701 for i, c in enumerate(self._calls_done[-N:]))
702 following_calls = '\n '.join(
703 '@%d: %r' % (len(self._calls_done) + i + 1, c[0])
704 for i, c in enumerate(self.calls[:N]))
705 extended_msg = (
706 'A few prior calls:\n %s\n\n'
707 'This (expected):\n @%d: %r\n'
708 'This (actual):\n @%d: %r\n\n'
709 'A few following expected calls:\n %s' %
710 (prior_calls, len(self._calls_done), expected_args,
711 len(self._calls_done), args, following_calls))
tandrii9d206752016-06-20 11:32:47 -0700712
tandrii99a72f22016-08-17 14:33:24 -0700713 self.fail('@%d\n'
714 ' Expected: %r\n'
Edward Lemur26964072020-02-19 19:18:51 +0000715 ' Actual: %r\n'
716 '\n'
717 '%s' % (
718 len(self._calls_done), expected_args, args, extended_msg))
tandrii9d206752016-06-20 11:32:47 -0700719
720 self._calls_done.append(top)
tandrii5d48c322016-08-18 16:19:37 -0700721 if isinstance(result, Exception):
722 raise result
Edward Lemur0db01f02019-11-12 22:01:51 +0000723 # stdout from git commands is supposed to be a bytestream. Convert it here
724 # instead of converting all test output in this file to bytes.
725 if args[0][0] == 'git' and not isinstance(result, bytes):
726 result = result.encode('utf-8')
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000727 return result
728
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100729 def test_ask_for_explicit_yes_true(self):
730 self.calls = [
731 (('ask_for_data', 'prompt [Yes/No]: '), 'blah'),
732 (('ask_for_data', 'Please, type yes or no: '), 'ye'),
733 ]
734 self.assertTrue(git_cl.ask_for_explicit_yes('prompt'))
735
tandrii48df5812016-10-17 03:55:37 -0700736 def test_LoadCodereviewSettingsFromFile_gerrit(self):
Edward Lemur79d4f992019-11-11 23:49:02 +0000737 codereview_file = StringIO('GERRIT_HOST: true')
tandrii48df5812016-10-17 03:55:37 -0700738 self.calls = [
739 ((['git', 'config', '--unset-all', 'rietveld.cc'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700740 ((['git', 'config', '--unset-all', 'rietveld.tree-status-url'],), CERR1),
741 ((['git', 'config', '--unset-all', 'rietveld.viewvc-url'],), CERR1),
742 ((['git', 'config', '--unset-all', 'rietveld.bug-prefix'],), CERR1),
743 ((['git', 'config', '--unset-all', 'rietveld.cpplint-regex'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700744 ((['git', 'config', '--unset-all', 'rietveld.cpplint-ignore-regex'],),
745 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700746 ((['git', 'config', '--unset-all', 'rietveld.run-post-upload-hook'],),
747 CERR1),
Jamie Madilldc4d19e2019-10-24 21:50:02 +0000748 ((['git', 'config', '--unset-all', 'rietveld.format-full-by-default'],),
749 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700750 ((['git', 'config', 'gerrit.host', 'true'],), ''),
751 ]
752 self.assertIsNone(git_cl.LoadCodereviewSettingsFromFile(codereview_file))
753
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000754 @staticmethod
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000755 def _git_sanity_checks(diff_base, working_branch, get_remote_branch=True):
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000756 fake_ancestor = 'fake_ancestor'
757 fake_cl = 'fake_cl_for_patch'
758 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000759 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000760 'rev-parse', '--verify', diff_base],), fake_ancestor),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000761 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000762 'merge-base', fake_ancestor, 'HEAD'],), fake_ancestor),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000763 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000764 'rev-list', '^' + fake_ancestor, 'HEAD'],), fake_cl),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000765 # Mock a config miss (error code 1)
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000766 ((['git',
tandrii5d48c322016-08-18 16:19:37 -0700767 'config', 'gitcl.remotebranch'],), CERR1),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000768 ] + ([
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000769 # Call to GetRemoteBranch()
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000770 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000771 'config', 'branch.%s.merge' % working_branch],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000772 'refs/heads/master'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000773 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000774 'config', 'branch.%s.remote' % working_branch],), 'origin'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000775 ] if get_remote_branch else []) + [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000776 ((['git', 'rev-list', '^' + fake_ancestor,
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000777 'refs/remotes/origin/master'],), ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000778 ]
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000779
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000780 @classmethod
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100781 def _gerrit_base_calls(cls, issue=None, fetched_description=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200782 fetched_status=None, other_cl_owner=None,
Anthony Polito8b955342019-09-24 19:01:36 +0000783 custom_cl_base=None, short_hostname='chromium',
784 change_id=None):
Edward Lemur26964072020-02-19 19:18:51 +0000785 calls = []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200786 if custom_cl_base:
787 ancestor_revision = custom_cl_base
788 else:
789 # Determine ancestor_revision to be merge base.
790 ancestor_revision = 'fake_ancestor_sha'
791 calls += [
Edward Lemurda4b6c62020-02-13 00:28:40 +0000792 (('get_or_create_merge_base', 'master', 'refs/remotes/origin/master'),
793 ancestor_revision),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200794 ]
795
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100796 if issue:
Edward Lesmes7677e5c2020-02-19 20:39:03 +0000797 gerrit_util.GetChangeDetail.return_value = {
798 'owner': {'email': (other_cl_owner or 'owner@example.com')},
799 'change_id': (change_id or '123456789'),
800 'current_revision': 'sha1_of_current_revision',
801 'revisions': {'sha1_of_current_revision': {
802 'commit': {'message': fetched_description},
803 }},
804 'status': fetched_status or 'NEW',
805 }
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100806 if fetched_status == 'ABANDONED':
807 calls += [
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000808 (('DieWithError', 'Change https://%s-review.googlesource.com/'
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100809 '123456 has been abandoned, new uploads are not '
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000810 'allowed' % short_hostname), SystemExitMock()),
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100811 ]
812 return calls
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100813 if other_cl_owner:
814 calls += [
815 (('ask_for_data', 'Press Enter to upload, or Ctrl+C to abort'), ''),
816 ]
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100817
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200818 calls += cls._git_sanity_checks(ancestor_revision, 'master',
819 get_remote_branch=False)
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100820 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200821 ((['git', 'rev-parse', 'HEAD'],), '12345'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100822 ]
823
824 if not issue:
825 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200826 ((['git', 'log', '--pretty=format:%s%n%n%b',
827 ancestor_revision + '...'],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000828 'foo'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100829 ]
830
831 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200832 ((['git', 'config', 'user.email'],), 'me@example.com'),
Edward Lemur2c48f242019-06-04 16:14:09 +0000833 (('time.time',), 1000,),
834 (('time.time',), 3000,),
835 (('add_repeated', 'sub_commands', {
836 'execution_time': 2000,
837 'command': 'presubmit',
838 'exit_code': 0
839 }), None,),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200840 ((['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] +
841 ([custom_cl_base] if custom_cl_base else
842 [ancestor_revision, 'HEAD']),),
843 '+dat'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100844 ]
845 return calls
ukai@chromium.orge8077812012-02-03 03:41:46 +0000846
Edward Lemur26964072020-02-19 19:18:51 +0000847 def _gerrit_upload_calls(self, description, reviewers, squash,
tandriia60502f2016-06-20 02:01:53 -0700848 squash_mode='default',
tandrii@chromium.org10625002016-03-04 20:03:47 +0000849 expected_upstream_ref='origin/refs/heads/master',
Aaron Gablefd238082017-06-07 13:42:34 -0700850 title=None, notify=False,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +0100851 post_amend_description=None, issue=None, cc=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000852 custom_cl_base=None, tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +0000853 short_hostname='chromium',
Edward Lemur1b52d872019-05-09 21:12:12 +0000854 labels=None, change_id=None, original_title=None,
Anthony Polito8b955342019-09-24 19:01:36 +0000855 final_description=None, gitcookies_exists=True,
Josipe827b0f2020-01-30 00:07:20 +0000856 force=False, edit_description=None):
tandrii@chromium.org10625002016-03-04 20:03:47 +0000857 if post_amend_description is None:
858 post_amend_description = description
bradnelsond975b302016-10-23 12:20:23 -0700859 cc = cc or []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200860 # Determined in `_gerrit_base_calls`.
861 determined_ancestor_revision = custom_cl_base or 'fake_ancestor_sha'
862
863 calls = []
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000864
Edward Lemur26964072020-02-19 19:18:51 +0000865 if squash_mode in ('override_squash', 'override_nosquash'):
866 self.mockGit.config['gerrit.override-squash-uploads'] = (
867 'true' if squash_mode == 'override_squash' else 'false')
tandriia60502f2016-06-20 02:01:53 -0700868
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000869 # If issue is given, then description is fetched from Gerrit instead.
870 if issue is None:
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000871 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200872 ((['git', 'log', '--pretty=format:%s\n\n%b',
873 ((custom_cl_base + '..') if custom_cl_base else
874 'fake_ancestor_sha..HEAD')],),
875 description),
876 ]
Aaron Gableb56ad332017-01-06 15:24:31 -0800877 if squash:
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000878 title = 'Initial_upload'
Aaron Gableb56ad332017-01-06 15:24:31 -0800879 else:
880 if not title:
881 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200882 ((['git', 'show', '-s', '--format=%s', 'HEAD'],), ''),
883 (('ask_for_data', 'Title for patchset []: '), 'User input'),
Aaron Gableb56ad332017-01-06 15:24:31 -0800884 ]
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000885 title = 'User_input'
tandrii@chromium.org57d86542016-03-04 16:11:32 +0000886 if not git_footers.get_footer_change_id(description) and not squash:
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000887 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200888 (('DownloadGerritHook', False), ''),
889 # Amending of commit message to get the Change-Id.
890 ((['git', 'log', '--pretty=format:%s\n\n%b',
891 determined_ancestor_revision + '..HEAD'],),
892 description),
893 ((['git', 'commit', '--amend', '-m', description],), ''),
894 ((['git', 'log', '--pretty=format:%s\n\n%b',
895 determined_ancestor_revision + '..HEAD'],),
896 post_amend_description)
897 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000898 if squash:
Anthony Polito8b955342019-09-24 19:01:36 +0000899 if force or not issue:
Anthony Polito8b955342019-09-24 19:01:36 +0000900 if not force:
901 calls += [
Anthony Polito8b955342019-09-24 19:01:36 +0000902 ((['RunEditor'],), description),
903 ]
Josipe827b0f2020-01-30 00:07:20 +0000904 # user wants to edit description
905 if edit_description:
906 calls += [
Josipe827b0f2020-01-30 00:07:20 +0000907 ((['RunEditor'],), edit_description),
908 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000909 ref_to_push = 'abcdef0123456789'
910 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200911 ]
912
913 if custom_cl_base is None:
914 calls += [
Edward Lemurda4b6c62020-02-13 00:28:40 +0000915 (('get_or_create_merge_base', 'master', 'refs/remotes/origin/master'),
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000916 'origin/master'),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200917 ]
918 parent = 'origin/master'
919 else:
920 calls += [
921 ((['git', 'merge-base', '--is-ancestor', custom_cl_base,
922 'refs/remotes/origin/master'],),
923 callError(1)), # Means not ancenstor.
924 (('ask_for_data',
925 'Do you take responsibility for cleaning up potential mess '
926 'resulting from proceeding with upload? Press Enter to upload, '
927 'or Ctrl+C to abort'), ''),
928 ]
929 parent = custom_cl_base
930
931 calls += [
932 ((['git', 'rev-parse', 'HEAD:'],), # `HEAD:` means HEAD's tree hash.
933 '0123456789abcdef'),
934 ((['git', 'commit-tree', '0123456789abcdef', '-p', parent,
Aaron Gable9a03ae02017-11-03 11:31:07 -0700935 '-F', '/tmp/named'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200936 ref_to_push),
937 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000938 else:
939 ref_to_push = 'HEAD'
940
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000941 calls += [
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000942 (('SaveDescriptionBackup',), None),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200943 ((['git', 'rev-list',
944 (custom_cl_base if custom_cl_base else expected_upstream_ref) + '..' +
945 ref_to_push],),
946 '1hashPerLine\n'),
947 ]
tandrii@chromium.org8da45402016-05-24 23:11:03 +0000948
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000949 metrics_arguments = []
950
Aaron Gableafd52772017-06-27 16:40:10 -0700951 if notify:
Aaron Gable844cf292017-06-28 11:32:59 -0700952 ref_suffix = '%ready,notify=ALL'
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000953 metrics_arguments += ['ready', 'notify=ALL']
Aaron Gable844cf292017-06-28 11:32:59 -0700954 else:
Jamie Madill276da0b2018-04-27 14:41:20 -0400955 if not issue and squash:
Aaron Gable844cf292017-06-28 11:32:59 -0700956 ref_suffix = '%wip'
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000957 metrics_arguments.append('wip')
Aaron Gable844cf292017-06-28 11:32:59 -0700958 else:
959 ref_suffix = '%notify=NONE'
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000960 metrics_arguments.append('notify=NONE')
Aaron Gable9b713dd2016-12-14 16:04:21 -0800961
Aaron Gable70f4e242017-06-26 10:45:59 -0700962 if title:
Aaron Gableafd52772017-06-27 16:40:10 -0700963 ref_suffix += ',m=' + title
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000964 metrics_arguments.append('m')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000965
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000966 if short_hostname == 'chromium':
967 # All reviwers and ccs get into ref_suffix.
968 for r in sorted(reviewers):
969 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000970 metrics_arguments.append('r')
Edward Lemur4508b422019-10-03 21:56:35 +0000971 if issue is None:
972 cc += ['chromium-reviews+test-more-cc@chromium.org', 'joe@example.com']
973 for c in sorted(cc):
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000974 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000975 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000976 reviewers, cc = [], []
977 else:
978 # TODO(crbug/877717): remove this case.
979 calls += [
980 (('ValidAccounts', '%s-review.googlesource.com' % short_hostname,
981 sorted(reviewers) + ['joe@example.com',
982 'chromium-reviews+test-more-cc@chromium.org'] + cc),
983 {
984 e: {'email': e}
985 for e in (reviewers + ['joe@example.com'] + cc)
986 })
987 ]
988 for r in sorted(reviewers):
989 if r != 'bad-account-or-email':
990 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000991 metrics_arguments.append('r')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000992 reviewers.remove(r)
Edward Lemur4508b422019-10-03 21:56:35 +0000993 if issue is None:
994 cc += ['joe@example.com']
995 for c in sorted(cc):
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000996 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000997 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000998 if c in cc:
999 cc.remove(c)
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00001000
Edward Lemur687ca902018-12-05 02:30:30 +00001001 for k, v in sorted((labels or {}).items()):
1002 ref_suffix += ',l=%s+%d' % (k, v)
1003 metrics_arguments.append('l=%s+%d' % (k, v))
1004
1005 if tbr:
1006 calls += [
1007 (('GetCodeReviewTbrScore',
1008 '%s-review.googlesource.com' % short_hostname,
1009 'my/repo'),
1010 2,),
1011 ]
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001012
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001013 calls += [
1014 (('time.time',), 1000,),
1015 ((['git', 'push',
1016 'https://%s.googlesource.com/my/repo' % short_hostname,
1017 ref_to_push + ':refs/for/refs/heads/master' + ref_suffix],),
1018 (('remote:\n'
1019 'remote: Processing changes: (\)\n'
1020 'remote: Processing changes: (|)\n'
1021 'remote: Processing changes: (/)\n'
1022 'remote: Processing changes: (-)\n'
1023 'remote: Processing changes: new: 1 (/)\n'
1024 'remote: Processing changes: new: 1, done\n'
1025 'remote:\n'
1026 'remote: New Changes:\n'
1027 'remote: https://%s-review.googlesource.com/#/c/my/repo/+/123456'
1028 ' XXX\n'
1029 'remote:\n'
1030 'To https://%s.googlesource.com/my/repo\n'
1031 ' * [new branch] hhhh -> refs/for/refs/heads/master\n'
1032 ) % (short_hostname, short_hostname)),),
1033 (('time.time',), 2000,),
1034 (('add_repeated',
1035 'sub_commands',
1036 {
1037 'execution_time': 1000,
1038 'command': 'git push',
1039 'exit_code': 0,
1040 'arguments': sorted(metrics_arguments),
1041 }),
1042 None,),
1043 ]
1044
Edward Lemur1b52d872019-05-09 21:12:12 +00001045 final_description = final_description or post_amend_description.strip()
1046 original_title = original_title or title or '<untitled>'
1047 # Trace-related calls
1048 calls += [
1049 # Write a description with context for the current trace.
1050 ((['FileWrite', 'TRACES_DIR/20170316T200041.000000-README',
Edward Lemur75391d42019-05-14 23:35:56 +00001051 'Thu Mar 16 20:00:41 2017\n'
1052 '%(short_hostname)s-review.googlesource.com\n'
1053 '%(change_id)s\n'
1054 '%(title)s\n'
1055 '%(description)s\n'
1056 '1000\n'
1057 '0\n'
1058 '%(trace_name)s' % {
Edward Lemur1b52d872019-05-09 21:12:12 +00001059 'short_hostname': short_hostname,
1060 'change_id': change_id,
1061 'description': final_description,
1062 'title': original_title,
Edward Lemur75391d42019-05-14 23:35:56 +00001063 'trace_name': 'TRACES_DIR/20170316T200041.000000',
Edward Lemur1b52d872019-05-09 21:12:12 +00001064 }],),
1065 None,
1066 ),
1067 # Read traces and shorten git hashes.
1068 ((['os.path.isfile', 'TEMP_DIR/trace-packet'],),
1069 True,
1070 ),
1071 ((['FileRead', 'TEMP_DIR/trace-packet'],),
1072 ('git-hash: 0123456789012345678901234567890123456789\n'
1073 'git-hash: abcdeabcdeabcdeabcdeabcdeabcdeabcdeabcde\n'),
1074 ),
1075 ((['FileWrite', 'TEMP_DIR/trace-packet',
1076 'git-hash: 012345\n'
1077 'git-hash: abcdea\n'],),
1078 None,
1079 ),
1080 # Make zip file for the git traces.
1081 ((['make_archive', 'TRACES_DIR/20170316T200041.000000-traces', 'zip',
1082 'TEMP_DIR'],),
1083 None,
1084 ),
1085 # Collect git config and gitcookies.
1086 ((['git', 'config', '-l'],),
1087 'git-config-output',
1088 ),
1089 ((['FileWrite', 'TEMP_DIR/git-config', 'git-config-output'],),
1090 None,
1091 ),
1092 ((['os.path.isfile', '~/.gitcookies'],),
1093 gitcookies_exists,
1094 ),
1095 ]
1096 if gitcookies_exists:
1097 calls += [
1098 ((['FileRead', '~/.gitcookies'],),
1099 'gitcookies 1/SECRET',
1100 ),
1101 ((['FileWrite', 'TEMP_DIR/gitcookies', 'gitcookies REDACTED'],),
1102 None,
1103 ),
1104 ]
1105 calls += [
1106 # Make zip file for the git config and gitcookies.
1107 ((['make_archive', 'TRACES_DIR/20170316T200041.000000-git-info', 'zip',
1108 'TEMP_DIR'],),
1109 None,
1110 ),
1111 ]
1112
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001113 # TODO(crbug/877717): this should never be used.
1114 if squash and short_hostname != 'chromium':
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001115 calls += [
1116 (('AddReviewers',
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001117 'chromium-review.googlesource.com', 'my%2Frepo~123456',
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001118 sorted(reviewers),
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00001119 cc + ['chromium-reviews+test-more-cc@chromium.org'],
1120 notify),
1121 ''),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001122 ]
Edward Lemur26964072020-02-19 19:18:51 +00001123 calls += [
1124 ((['git', 'rev-parse', 'HEAD'],), 'hash'),
1125 ]
ukai@chromium.orge8077812012-02-03 03:41:46 +00001126 return calls
1127
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001128 def _run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001129 self,
1130 upload_args,
1131 description,
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001132 reviewers=None,
tandriia60502f2016-06-20 02:01:53 -07001133 squash=True,
1134 squash_mode=None,
tandrii@chromium.org10625002016-03-04 20:03:47 +00001135 expected_upstream_ref='origin/refs/heads/master',
Aaron Gable9b713dd2016-12-14 16:04:21 -08001136 title=None,
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001137 notify=False,
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001138 post_amend_description=None,
bradnelsond975b302016-10-23 12:20:23 -07001139 issue=None,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +01001140 cc=None,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001141 fetched_status=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001142 other_cl_owner=None,
Aaron Gablefd238082017-06-07 13:42:34 -07001143 custom_cl_base=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001144 tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001145 short_hostname='chromium',
Edward Lemur1b52d872019-05-09 21:12:12 +00001146 labels=None,
1147 change_id=None,
1148 original_title=None,
1149 final_description=None,
Anthony Polito8b955342019-09-24 19:01:36 +00001150 gitcookies_exists=True,
1151 force=False,
Josipe827b0f2020-01-30 00:07:20 +00001152 edit_description=None,
Anthony Polito8b955342019-09-24 19:01:36 +00001153 fetched_description=None):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001154 """Generic gerrit upload test framework."""
tandriia60502f2016-06-20 02:01:53 -07001155 if squash_mode is None:
1156 if '--no-squash' in upload_args:
1157 squash_mode = 'nosquash'
1158 elif '--squash' in upload_args:
1159 squash_mode = 'squash'
1160 else:
1161 squash_mode = 'default'
1162
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001163 reviewers = reviewers or []
bradnelsond975b302016-10-23 12:20:23 -07001164 cc = cc or []
Edward Lemurda4b6c62020-02-13 00:28:40 +00001165 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001166 CookiesAuthenticatorMockFactory(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001167 same_auth=('git-owner.example.com', '', 'pass'))).start()
1168 mock.patch('git_cl.Changelist._GerritCommitMsgHookCheck',
1169 lambda _, offer_removal: None).start()
1170 mock.patch('git_cl.gclient_utils.RunEditor',
1171 lambda *_, **__: self._mocked_call(['RunEditor'])).start()
1172 mock.patch('git_cl.DownloadGerritHook', lambda force: self._mocked_call(
1173 'DownloadGerritHook', force)).start()
1174 mock.patch('git_cl.gclient_utils.FileRead',
1175 lambda path: self._mocked_call(['FileRead', path])).start()
1176 mock.patch('git_cl.gclient_utils.FileWrite',
Edward Lemur1b52d872019-05-09 21:12:12 +00001177 lambda path, contents: self._mocked_call(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001178 ['FileWrite', path, contents])).start()
1179 mock.patch('git_cl.datetime_now',
1180 lambda: datetime.datetime(2017, 3, 16, 20, 0, 41, 0)).start()
1181 mock.patch('git_cl.tempfile.mkdtemp', lambda: 'TEMP_DIR').start()
1182 mock.patch('git_cl.TRACES_DIR', 'TRACES_DIR').start()
1183 mock.patch('git_cl.TRACES_README_FORMAT',
Edward Lemur75391d42019-05-14 23:35:56 +00001184 '%(now)s\n'
1185 '%(gerrit_host)s\n'
1186 '%(change_id)s\n'
1187 '%(title)s\n'
1188 '%(description)s\n'
1189 '%(execution_time)s\n'
1190 '%(exit_code)s\n'
Edward Lemurda4b6c62020-02-13 00:28:40 +00001191 '%(trace_name)s').start()
1192 mock.patch('git_cl.shutil.make_archive',
1193 lambda *args: self._mocked_call(['make_archive'] +
1194 list(args))).start()
1195 mock.patch('os.path.isfile',
1196 lambda path: self._mocked_call(['os.path.isfile', path])).start()
tandriia60502f2016-06-20 02:01:53 -07001197
Edward Lemur26964072020-02-19 19:18:51 +00001198 self.mockGit.config['gerrit.host'] = 'true'
Edward Lemur85153282020-02-14 22:06:29 +00001199 self.mockGit.config['branch.master.gerritissue'] = (
1200 str(issue) if issue else None)
1201 self.mockGit.config['remote.origin.url'] = (
1202 'https://%s.googlesource.com/my/repo' % short_hostname)
1203
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001204 self.calls = self._gerrit_base_calls(
1205 issue=issue,
Anthony Polito8b955342019-09-24 19:01:36 +00001206 fetched_description=fetched_description or description,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001207 fetched_status=fetched_status,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001208 other_cl_owner=other_cl_owner,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001209 custom_cl_base=custom_cl_base,
Anthony Polito8b955342019-09-24 19:01:36 +00001210 short_hostname=short_hostname,
1211 change_id=change_id)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001212 if fetched_status != 'ABANDONED':
Edward Lemurda4b6c62020-02-13 00:28:40 +00001213 mock.patch(
1214 'tempfile.NamedTemporaryFile',
1215 MakeNamedTemporaryFileMock(
1216 self, expected_content=description)).start()
1217 mock.patch('os.remove', return_value=True).start()
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001218 self.calls += self._gerrit_upload_calls(
1219 description, reviewers, squash,
1220 squash_mode=squash_mode,
1221 expected_upstream_ref=expected_upstream_ref,
Aaron Gablefd238082017-06-07 13:42:34 -07001222 title=title, notify=notify,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001223 post_amend_description=post_amend_description,
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001224 issue=issue, cc=cc,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001225 custom_cl_base=custom_cl_base, tbr=tbr,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001226 short_hostname=short_hostname,
Edward Lemur1b52d872019-05-09 21:12:12 +00001227 labels=labels,
1228 change_id=change_id,
1229 original_title=original_title,
1230 final_description=final_description,
Anthony Polito8b955342019-09-24 19:01:36 +00001231 gitcookies_exists=gitcookies_exists,
Josipe827b0f2020-01-30 00:07:20 +00001232 force=force,
1233 edit_description=edit_description)
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001234 # Uncomment when debugging.
Raul Tambre80ee78e2019-05-06 22:41:05 +00001235 # print('\n'.join(map(lambda x: '%2i: %s' % x, enumerate(self.calls))))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001236 git_cl.main(['upload'] + upload_args)
Edward Lemur85153282020-02-14 22:06:29 +00001237 if squash:
Edward Lemur26964072020-02-19 19:18:51 +00001238 self.assertIssueAndPatchset(patchset=None)
Edward Lemur85153282020-02-14 22:06:29 +00001239 self.assertEqual(
1240 'abcdef0123456789',
Edward Lemur26964072020-02-19 19:18:51 +00001241 scm.GIT.GetBranchConfig('', 'master', 'gerritsquashhash'))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001242
Edward Lemur1b52d872019-05-09 21:12:12 +00001243 def test_gerrit_upload_traces_no_gitcookies(self):
1244 self._run_gerrit_upload_test(
1245 ['--no-squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001246 'desc ✔\n\nBUG=\n',
Edward Lemur1b52d872019-05-09 21:12:12 +00001247 [],
1248 squash=False,
Edward Lemur0db01f02019-11-12 22:01:51 +00001249 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001250 change_id='Ixxx',
1251 gitcookies_exists=False)
1252
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001253 def test_gerrit_upload_without_change_id(self):
tandriia60502f2016-06-20 02:01:53 -07001254 self._run_gerrit_upload_test(
1255 ['--no-squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001256 'desc ✔\n\nBUG=\n',
tandriia60502f2016-06-20 02:01:53 -07001257 [],
1258 squash=False,
Edward Lemur0db01f02019-11-12 22:01:51 +00001259 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001260 change_id='Ixxx')
tandriia60502f2016-06-20 02:01:53 -07001261
1262 def test_gerrit_upload_without_change_id_override_nosquash(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001263 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001264 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001265 'desc ✔\n\nBUG=\n',
tandrii@chromium.org10625002016-03-04 20:03:47 +00001266 [],
tandriia60502f2016-06-20 02:01:53 -07001267 squash=False,
1268 squash_mode='override_nosquash',
Edward Lemur0db01f02019-11-12 22:01:51 +00001269 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001270 change_id='Ixxx')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001271
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001272 def test_gerrit_no_reviewer(self):
1273 self._run_gerrit_upload_test(
1274 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001275 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
tandriia60502f2016-06-20 02:01:53 -07001276 [],
1277 squash=False,
Edward Lemur1b52d872019-05-09 21:12:12 +00001278 squash_mode='override_nosquash',
1279 change_id='I123456789')
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001280
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001281 def test_gerrit_no_reviewer_non_chromium_host(self):
1282 # TODO(crbug/877717): remove this test case.
1283 self._run_gerrit_upload_test(
1284 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001285 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001286 [],
1287 squash=False,
1288 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001289 short_hostname='other',
1290 change_id='I123456789')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001291
Nick Carter8692b182017-11-06 16:30:38 -08001292 def test_gerrit_patchset_title_special_chars(self):
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001293 self._run_gerrit_upload_test(
Nick Carter8692b182017-11-06 16:30:38 -08001294 ['-f', '-t', 'We\'ll escape ^_ ^ special chars...@{u}'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001295 'desc ✔\n\nBUG=\n\nChange-Id: I123456789',
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001296 squash=False,
1297 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001298 title='We%27ll_escape_%5E%5F_%5E_special_chars%2E%2E%2E%40%7Bu%7D',
1299 change_id='I123456789',
1300 original_title='We\'ll escape ^_ ^ special chars...@{u}')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001301
ukai@chromium.orge8077812012-02-03 03:41:46 +00001302 def test_gerrit_reviewers_cmd_line(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001303 self._run_gerrit_upload_test(
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001304 ['-r', 'foo@example.com', '--send-mail'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001305 'desc ✔\n\nBUG=\n\nChange-Id: I123456789',
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001306 ['foo@example.com'],
tandriia60502f2016-06-20 02:01:53 -07001307 squash=False,
1308 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001309 notify=True,
1310 change_id='I123456789',
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001311 final_description=(
Edward Lemur0db01f02019-11-12 22:01:51 +00001312 'desc ✔\n\nBUG=\nR=foo@example.com\n\nChange-Id: I123456789'))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001313
Anthony Polito8b955342019-09-24 19:01:36 +00001314 def test_gerrit_upload_force_sets_bug(self):
1315 self._run_gerrit_upload_test(
1316 ['-b', '10000', '-f'],
1317 u'desc=\n\nBug: 10000\nChange-Id: Ixxx',
1318 [],
1319 force=True,
1320 expected_upstream_ref='origin/master',
1321 fetched_description='desc=\n\nChange-Id: Ixxx',
1322 original_title='Initial upload',
1323 change_id='Ixxx')
1324
1325 def test_gerrit_upload_force_sets_bug_if_wrong_changeid(self):
1326 self._run_gerrit_upload_test(
1327 ['-b', '10000', '-f', '-m', 'Title'],
1328 u'desc=\n\nChange-Id: Ixxxx\n\nChange-Id: Izzzz\nBug: 10000',
1329 [],
1330 force=True,
1331 issue='123456',
1332 expected_upstream_ref='origin/master',
1333 fetched_description='desc=\n\nChange-Id: Ixxxx',
1334 original_title='Title',
1335 title='Title',
1336 change_id='Izzzz')
1337
Dan Beamd8b04ca2019-10-10 21:23:26 +00001338 def test_gerrit_upload_force_sets_fixed(self):
1339 self._run_gerrit_upload_test(
1340 ['-x', '10000', '-f'],
1341 u'desc=\n\nFixed: 10000\nChange-Id: Ixxx',
1342 [],
1343 force=True,
1344 expected_upstream_ref='origin/master',
1345 fetched_description='desc=\n\nChange-Id: Ixxx',
1346 original_title='Initial upload',
1347 change_id='Ixxx')
1348
ukai@chromium.orge8077812012-02-03 03:41:46 +00001349 def test_gerrit_reviewer_multiple(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00001350 mock.patch('git_cl.gerrit_util.GetCodeReviewTbrScore',
1351 lambda *a: self._mocked_call('GetCodeReviewTbrScore', *a)).start()
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001352 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001353 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001354 'desc ✔\nTBR=reviewer@example.com\nBUG=\nR=another@example.com\n'
bradnelsond975b302016-10-23 12:20:23 -07001355 'CC=more@example.com,people@example.com\n\n'
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001356 'Change-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001357 ['reviewer@example.com', 'another@example.com'],
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001358 expected_upstream_ref='origin/master',
Aaron Gablefd238082017-06-07 13:42:34 -07001359 cc=['more@example.com', 'people@example.com'],
Edward Lemur687ca902018-12-05 02:30:30 +00001360 tbr='reviewer@example.com',
Edward Lemur1b52d872019-05-09 21:12:12 +00001361 labels={'Code-Review': 2},
1362 change_id='123456789',
1363 original_title='Initial upload')
tandriia60502f2016-06-20 02:01:53 -07001364
1365 def test_gerrit_upload_squash_first_is_default(self):
tandriia60502f2016-06-20 02:01:53 -07001366 self._run_gerrit_upload_test(
1367 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001368 'desc ✔\nBUG=\n\nChange-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001369 [],
Edward Lemur1b52d872019-05-09 21:12:12 +00001370 expected_upstream_ref='origin/master',
1371 change_id='123456789',
1372 original_title='Initial upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001373
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001374 def test_gerrit_upload_squash_first(self):
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001375 self._run_gerrit_upload_test(
1376 ['--squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001377 'desc ✔\nBUG=\n\nChange-Id: 123456789',
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001378 [],
luqui@chromium.org609f3952015-05-04 22:47:04 +00001379 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001380 expected_upstream_ref='origin/master',
1381 change_id='123456789',
1382 original_title='Initial upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001383
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001384 def test_gerrit_upload_squash_first_with_labels(self):
1385 self._run_gerrit_upload_test(
1386 ['--squash', '--cq-dry-run', '--enable-auto-submit'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001387 'desc ✔\nBUG=\n\nChange-Id: 123456789',
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001388 [],
1389 squash=True,
1390 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001391 labels={'Commit-Queue': 1, 'Auto-Submit': 1},
1392 change_id='123456789',
1393 original_title='Initial upload')
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001394
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001395 def test_gerrit_upload_squash_first_against_rev(self):
1396 custom_cl_base = 'custom_cl_base_rev_or_branch'
1397 self._run_gerrit_upload_test(
1398 ['--squash', custom_cl_base],
Edward Lemur0db01f02019-11-12 22:01:51 +00001399 'desc ✔\nBUG=\n\nChange-Id: 123456789',
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001400 [],
1401 squash=True,
1402 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001403 custom_cl_base=custom_cl_base,
1404 change_id='123456789',
1405 original_title='Initial upload')
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001406 self.assertIn(
1407 'If you proceed with upload, more than 1 CL may be created by Gerrit',
1408 sys.stdout.getvalue())
1409
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001410 def test_gerrit_upload_squash_reupload(self):
Edward Lemur0db01f02019-11-12 22:01:51 +00001411 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001412 self._run_gerrit_upload_test(
1413 ['--squash'],
1414 description,
1415 [],
1416 squash=True,
1417 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001418 issue=123456,
1419 change_id='123456789',
1420 original_title='User input')
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001421
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001422 def test_gerrit_upload_squash_reupload_to_abandoned(self):
Edward Lemur0db01f02019-11-12 22:01:51 +00001423 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001424 with self.assertRaises(SystemExitMock):
1425 self._run_gerrit_upload_test(
1426 ['--squash'],
1427 description,
1428 [],
1429 squash=True,
1430 expected_upstream_ref='origin/master',
1431 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001432 fetched_status='ABANDONED',
1433 change_id='123456789')
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001434
Edward Lemurda4b6c62020-02-13 00:28:40 +00001435 @mock.patch(
1436 'gerrit_util.GetAccountDetails',
1437 return_value={'email': 'yet-another@example.com'})
1438 def test_gerrit_upload_squash_reupload_to_not_owned(self, _mock):
Edward Lemur0db01f02019-11-12 22:01:51 +00001439 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001440 self._run_gerrit_upload_test(
1441 ['--squash'],
1442 description,
1443 [],
1444 squash=True,
1445 expected_upstream_ref='origin/master',
1446 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001447 other_cl_owner='other@example.com',
1448 change_id='123456789',
1449 original_title='User input')
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001450 self.assertIn(
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001451 'WARNING: Change 123456 is owned by other@example.com, but you '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001452 'authenticate to Gerrit as yet-another@example.com.\n'
1453 'Uploading may fail due to lack of permissions',
Edward Lemurda4b6c62020-02-13 00:28:40 +00001454 sys.stdout.getvalue())
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001455
Josipe827b0f2020-01-30 00:07:20 +00001456 def test_upload_change_description_editor(self):
1457 fetched_description = 'foo\n\nChange-Id: 123456789'
1458 description = 'bar\n\nChange-Id: 123456789'
1459 self._run_gerrit_upload_test(
1460 ['--squash', '--edit-description'],
1461 description,
1462 [],
1463 fetched_description=fetched_description,
1464 squash=True,
1465 expected_upstream_ref='origin/master',
1466 issue=123456,
1467 change_id='123456789',
1468 original_title='User input',
1469 edit_description=description)
1470
Edward Lemurda4b6c62020-02-13 00:28:40 +00001471 @mock.patch('git_cl.RunGit')
1472 @mock.patch('git_cl.CMDupload')
1473 @mock.patch('git_cl.ask_for_data')
1474 def test_upload_branch_deps(self, *_mocks):
rmistry@google.com2dd99862015-06-22 12:22:18 +00001475 def mock_run_git(*args, **_kwargs):
1476 if args[0] == ['for-each-ref',
1477 '--format=%(refname:short) %(upstream:short)',
1478 'refs/heads']:
1479 # Create a local branch dependency tree that looks like this:
1480 # test1 -> test2 -> test3 -> test4 -> test5
1481 # -> test3.1
1482 # test6 -> test0
1483 branch_deps = [
1484 'test2 test1', # test1 -> test2
1485 'test3 test2', # test2 -> test3
1486 'test3.1 test2', # test2 -> test3.1
1487 'test4 test3', # test3 -> test4
1488 'test5 test4', # test4 -> test5
1489 'test6 test0', # test0 -> test6
1490 'test7', # test7
1491 ]
1492 return '\n'.join(branch_deps)
Edward Lemurda4b6c62020-02-13 00:28:40 +00001493 git_cl.RunGit.side_effect = mock_run_git
1494 git_cl.CMDupload.return_value = 0
rmistry@google.com2dd99862015-06-22 12:22:18 +00001495
1496 class MockChangelist():
1497 def __init__(self):
1498 pass
1499 def GetBranch(self):
1500 return 'test1'
1501 def GetIssue(self):
1502 return '123'
1503 def GetPatchset(self):
1504 return '1001'
tandrii@chromium.org4c72b082016-03-31 22:26:35 +00001505 def IsGerrit(self):
1506 return False
rmistry@google.com2dd99862015-06-22 12:22:18 +00001507
1508 ret = git_cl.upload_branch_deps(MockChangelist(), [])
1509 # CMDupload should have been called 5 times because of 5 dependent branches.
Edward Lemurda4b6c62020-02-13 00:28:40 +00001510 self.assertEqual(5, len(git_cl.CMDupload.mock_calls))
1511 git_cl.ask_for_data.assert_called_once_with(
1512 'This command will checkout all dependent branches '
1513 'and run "git cl upload". Press Enter to continue, '
1514 'or Ctrl+C to abort')
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00001515 self.assertEqual(0, ret)
rmistry@google.com2dd99862015-06-22 12:22:18 +00001516
tandrii@chromium.org65874e12016-03-04 12:03:02 +00001517 def test_gerrit_change_id(self):
1518 self.calls = [
1519 ((['git', 'write-tree'], ),
1520 'hashtree'),
1521 ((['git', 'rev-parse', 'HEAD~0'], ),
1522 'branch-parent'),
1523 ((['git', 'var', 'GIT_AUTHOR_IDENT'], ),
1524 'A B <a@b.org> 1456848326 +0100'),
1525 ((['git', 'var', 'GIT_COMMITTER_IDENT'], ),
1526 'C D <c@d.org> 1456858326 +0100'),
1527 ((['git', 'hash-object', '-t', 'commit', '--stdin'], ),
1528 'hashchange'),
1529 ]
1530 change_id = git_cl.GenerateGerritChangeId('line1\nline2\n')
1531 self.assertEqual(change_id, 'Ihashchange')
1532
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001533 def test_desecription_append_footer(self):
1534 for init_desc, footer_line, expected_desc in [
1535 # Use unique desc first lines for easy test failure identification.
1536 ('foo', 'R=one', 'foo\n\nR=one'),
1537 ('foo\n\nR=one', 'BUG=', 'foo\n\nR=one\nBUG='),
1538 ('foo\n\nR=one', 'Change-Id: Ixx', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1539 ('foo\n\nChange-Id: Ixx', 'R=one', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1540 ('foo\n\nR=one\n\nChange-Id: Ixx', 'TBR=two',
1541 'foo\n\nR=one\nTBR=two\n\nChange-Id: Ixx'),
1542 ('foo\n\nR=one\n\nChange-Id: Ixx', 'Foo-Bar: baz',
1543 'foo\n\nR=one\n\nChange-Id: Ixx\nFoo-Bar: baz'),
1544 ('foo\n\nChange-Id: Ixx', 'Foo-Bak: baz',
1545 'foo\n\nChange-Id: Ixx\nFoo-Bak: baz'),
1546 ('foo', 'Change-Id: Ixx', 'foo\n\nChange-Id: Ixx'),
1547 ]:
1548 desc = git_cl.ChangeDescription(init_desc)
1549 desc.append_footer(footer_line)
1550 self.assertEqual(desc.description, expected_desc)
1551
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001552 def test_update_reviewers(self):
1553 data = [
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001554 ('foo', [], [],
1555 'foo'),
1556 ('foo\nR=xx', [], [],
1557 'foo\nR=xx'),
1558 ('foo\nTBR=xx', [], [],
1559 'foo\nTBR=xx'),
1560 ('foo', ['a@c'], [],
1561 'foo\n\nR=a@c'),
1562 ('foo\nR=xx', ['a@c'], [],
1563 'foo\n\nR=a@c, xx'),
1564 ('foo\nTBR=xx', ['a@c'], [],
1565 'foo\n\nR=a@c\nTBR=xx'),
1566 ('foo\nTBR=xx\nR=yy', ['a@c'], [],
1567 'foo\n\nR=a@c, yy\nTBR=xx'),
1568 ('foo\nBUG=', ['a@c'], [],
1569 'foo\nBUG=\nR=a@c'),
1570 ('foo\nR=xx\nTBR=yy\nR=bar', ['a@c'], [],
1571 'foo\n\nR=a@c, bar, xx\nTBR=yy'),
1572 ('foo', ['a@c', 'b@c'], [],
1573 'foo\n\nR=a@c, b@c'),
1574 ('foo\nBar\n\nR=\nBUG=', ['c@c'], [],
1575 'foo\nBar\n\nR=c@c\nBUG='),
1576 ('foo\nBar\n\nR=\nBUG=\nR=', ['c@c'], [],
1577 'foo\nBar\n\nR=c@c\nBUG='),
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001578 # Same as the line before, but full of whitespaces.
1579 (
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001580 'foo\nBar\n\n R = \n BUG = \n R = ', ['c@c'], [],
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001581 'foo\nBar\n\nR=c@c\n BUG =',
1582 ),
1583 # Whitespaces aren't interpreted as new lines.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001584 ('foo BUG=allo R=joe ', ['c@c'], [],
1585 'foo BUG=allo R=joe\n\nR=c@c'),
1586 # Redundant TBRs get promoted to Rs
1587 ('foo\n\nR=a@c\nTBR=t@c', ['b@c', 'a@c'], ['a@c', 't@c'],
1588 'foo\n\nR=a@c, b@c\nTBR=t@c'),
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001589 ]
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001590 expected = [i[-1] for i in data]
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001591 actual = []
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001592 for orig, reviewers, tbrs, _expected in data:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001593 obj = git_cl.ChangeDescription(orig)
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001594 obj.update_reviewers(reviewers, tbrs)
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001595 actual.append(obj.description)
1596 self.assertEqual(expected, actual)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001597
Nodir Turakulov23b82142017-11-16 11:04:25 -08001598 def test_get_hash_tags(self):
1599 cases = [
1600 ('', []),
1601 ('a', []),
1602 ('[a]', ['a']),
1603 ('[aa]', ['aa']),
1604 ('[a ]', ['a']),
1605 ('[a- ]', ['a']),
1606 ('[a- b]', ['a-b']),
1607 ('[a--b]', ['a-b']),
1608 ('[a', []),
1609 ('[a]x', ['a']),
1610 ('[aa]x', ['aa']),
1611 ('[a b]', ['a-b']),
1612 ('[a b]', ['a-b']),
1613 ('[a__b]', ['a-b']),
1614 ('[a] x', ['a']),
1615 ('[a][b]', ['a', 'b']),
1616 ('[a] [b]', ['a', 'b']),
1617 ('[a][b]x', ['a', 'b']),
1618 ('[a][b] x', ['a', 'b']),
1619 ('[a]\n[b]', ['a']),
1620 ('[a\nb]', []),
1621 ('[a][', ['a']),
1622 ('Revert "[a] feature"', ['a']),
1623 ('Reland "[a] feature"', ['a']),
1624 ('Revert: [a] feature', ['a']),
1625 ('Reland: [a] feature', ['a']),
1626 ('Revert "Reland: [a] feature"', ['a']),
1627 ('Foo: feature', ['foo']),
1628 ('Foo Bar: feature', ['foo-bar']),
Anthony Polito02b5af32019-12-02 19:49:47 +00001629 ('Change Foo::Bar', []),
1630 ('Foo: Change Foo::Bar', ['foo']),
Nodir Turakulov23b82142017-11-16 11:04:25 -08001631 ('Revert "Foo bar: feature"', ['foo-bar']),
1632 ('Reland "Foo bar: feature"', ['foo-bar']),
1633 ]
1634 for desc, expected in cases:
1635 change_desc = git_cl.ChangeDescription(desc)
1636 actual = change_desc.get_hash_tags()
1637 self.assertEqual(
1638 actual,
1639 expected,
1640 'GetHashTags(%r) == %r, expected %r' % (desc, actual, expected))
1641
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001642 self.assertEqual(None, git_cl.GetTargetRef('origin', None, 'master'))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001643 self.assertEqual(None, git_cl.GetTargetRef(None,
1644 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001645 'master'))
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001646
wittman@chromium.org455dc922015-01-26 20:15:50 +00001647 # Check default target refs for branches.
1648 self.assertEqual('refs/heads/master',
1649 git_cl.GetTargetRef('origin', 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001650 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001651 self.assertEqual('refs/heads/master',
1652 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkgr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001653 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001654 self.assertEqual('refs/heads/master',
1655 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkcr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001656 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001657 self.assertEqual('refs/branch-heads/123',
1658 git_cl.GetTargetRef('origin',
1659 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001660 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001661 self.assertEqual('refs/diff/test',
1662 git_cl.GetTargetRef('origin',
1663 'refs/remotes/origin/refs/diff/test',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001664 None))
rmistry@google.comc68112d2015-03-03 12:48:06 +00001665 self.assertEqual('refs/heads/chrome/m42',
1666 git_cl.GetTargetRef('origin',
1667 'refs/remotes/origin/chrome/m42',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001668 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001669
1670 # Check target refs for user-specified target branch.
1671 for branch in ('branch-heads/123', 'remotes/branch-heads/123',
1672 'refs/remotes/branch-heads/123'):
1673 self.assertEqual('refs/branch-heads/123',
1674 git_cl.GetTargetRef('origin',
1675 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001676 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001677 for branch in ('origin/master', 'remotes/origin/master',
1678 'refs/remotes/origin/master'):
1679 self.assertEqual('refs/heads/master',
1680 git_cl.GetTargetRef('origin',
1681 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001682 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001683 for branch in ('master', 'heads/master', 'refs/heads/master'):
1684 self.assertEqual('refs/heads/master',
1685 git_cl.GetTargetRef('origin',
1686 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001687 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001688
Edward Lemurda4b6c62020-02-13 00:28:40 +00001689 @mock.patch('git_common.is_dirty_git_tree', return_value=True)
1690 def test_patch_when_dirty(self, *_mocks):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001691 # Patch when local tree is dirty.
wychen@chromium.orga872e752015-04-28 23:42:18 +00001692 self.assertNotEqual(git_cl.main(['patch', '123456']), 0)
1693
Edward Lemur85153282020-02-14 22:06:29 +00001694 def assertIssueAndPatchset(
1695 self, branch='master', issue='123456', patchset='7',
1696 git_short_host='chromium'):
1697 self.assertEqual(
Edward Lemur26964072020-02-19 19:18:51 +00001698 issue, scm.GIT.GetBranchConfig('', branch, 'gerritissue'))
Edward Lemur85153282020-02-14 22:06:29 +00001699 self.assertEqual(
Edward Lemur26964072020-02-19 19:18:51 +00001700 patchset, scm.GIT.GetBranchConfig('', branch, 'gerritpatchset'))
Edward Lemur85153282020-02-14 22:06:29 +00001701 self.assertEqual(
1702 'https://%s-review.googlesource.com' % git_short_host,
Edward Lemur26964072020-02-19 19:18:51 +00001703 scm.GIT.GetBranchConfig('', branch, 'gerritserver'))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001704
Edward Lemur85153282020-02-14 22:06:29 +00001705 def _patch_common(self, git_short_host='chromium'):
Edward Lemurda4b6c62020-02-13 00:28:40 +00001706 mock.patch('git_cl.IsGitVersionAtLeast', return_value=True).start()
Edward Lemur26964072020-02-19 19:18:51 +00001707 self.mockGit.config['remote.origin.url'] = (
1708 'https://%s.googlesource.com/my/repo' % git_short_host)
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001709 gerrit_util.GetChangeDetail.return_value = {
1710 'current_revision': '7777777777',
1711 'revisions': {
1712 '1111111111': {
1713 '_number': 1,
1714 'fetch': {'http': {
1715 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1716 'ref': 'refs/changes/56/123456/1',
1717 }},
1718 },
1719 '7777777777': {
1720 '_number': 7,
1721 'fetch': {'http': {
1722 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1723 'ref': 'refs/changes/56/123456/7',
1724 }},
1725 },
1726 },
1727 }
wychen@chromium.orga872e752015-04-28 23:42:18 +00001728
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001729 def test_patch_gerrit_default(self):
Edward Lemur85153282020-02-14 22:06:29 +00001730 self._patch_common()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001731 self.calls += [
1732 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1733 'refs/changes/56/123456/7'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001734 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001735 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001736 ]
1737 self.assertEqual(git_cl.main(['patch', '123456']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001738 self.assertIssueAndPatchset()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001739
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001740 def test_patch_gerrit_new_branch(self):
Edward Lemur85153282020-02-14 22:06:29 +00001741 self._patch_common()
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001742 self.calls += [
1743 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1744 'refs/changes/56/123456/7'],), ''),
1745 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001746 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001747 ]
Edward Lemur85153282020-02-14 22:06:29 +00001748 self.assertEqual(git_cl.main(['patch', '-b', 'feature', '123456']), 0)
1749 self.assertIssueAndPatchset(branch='feature')
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001750
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001751 def test_patch_gerrit_force(self):
Edward Lemur85153282020-02-14 22:06:29 +00001752 self._patch_common('host')
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001753 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001754 ((['git', 'fetch', 'https://host.googlesource.com/my/repo',
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001755 'refs/changes/56/123456/7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001756 ((['git', 'reset', '--hard', 'FETCH_HEAD'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001757 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001758 ]
Edward Lemur52969c92020-02-06 18:15:28 +00001759 self.assertEqual(git_cl.main(['patch', '123456', '--force']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001760 self.assertIssueAndPatchset(git_short_host='host')
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001761
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001762 def test_patch_gerrit_guess_by_url(self):
Edward Lemur85153282020-02-14 22:06:29 +00001763 self._patch_common('else')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001764 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001765 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001766 'refs/changes/56/123456/1'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001767 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001768 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001769 ]
1770 self.assertEqual(git_cl.main(
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001771 ['patch', 'https://else-review.googlesource.com/#/c/123456/1']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001772 self.assertIssueAndPatchset(patchset='1', git_short_host='else')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001773
Aaron Gable697a91b2018-01-19 15:20:15 -08001774 def test_patch_gerrit_guess_by_url_with_repo(self):
Edward Lemur85153282020-02-14 22:06:29 +00001775 self._patch_common('else')
Aaron Gable697a91b2018-01-19 15:20:15 -08001776 self.calls += [
1777 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
1778 'refs/changes/56/123456/1'],), ''),
1779 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
Aaron Gable697a91b2018-01-19 15:20:15 -08001780 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
Aaron Gable697a91b2018-01-19 15:20:15 -08001781 ]
1782 self.assertEqual(git_cl.main(
1783 ['patch', 'https://else-review.googlesource.com/c/my/repo/+/123456/1']),
1784 0)
Edward Lemur85153282020-02-14 22:06:29 +00001785 self.assertIssueAndPatchset(patchset='1', git_short_host='else')
Aaron Gable697a91b2018-01-19 15:20:15 -08001786
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001787 def test_patch_gerrit_conflict(self):
Edward Lemur85153282020-02-14 22:06:29 +00001788 self._patch_common()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001789 self.calls += [
1790 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001791 'refs/changes/56/123456/7'],), ''),
tandrii5d48c322016-08-18 16:19:37 -07001792 ((['git', 'cherry-pick', 'FETCH_HEAD'],), CERR1),
Edward Lemurda4b6c62020-02-13 00:28:40 +00001793 (('DieWithError', 'Command "git cherry-pick FETCH_HEAD" failed.\n'),
tandrii5d48c322016-08-18 16:19:37 -07001794 SystemExitMock()),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001795 ]
1796 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001797 git_cl.main(['patch', '123456'])
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001798
Edward Lemurda4b6c62020-02-13 00:28:40 +00001799 @mock.patch(
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001800 'gerrit_util.GetChangeDetail',
Edward Lemurda4b6c62020-02-13 00:28:40 +00001801 side_effect=gerrit_util.GerritError(404, ''))
1802 def test_patch_gerrit_not_exists(self, *_mocks):
Edward Lemur26964072020-02-19 19:18:51 +00001803 self.mockGit.config['remote.origin.url'] = (
1804 'https://chromium.googlesource.com/my/repo')
tandriic2405f52016-10-10 08:13:15 -07001805 self.calls = [
Edward Lemurda4b6c62020-02-13 00:28:40 +00001806 (('DieWithError',
1807 'change 123456 at https://chromium-review.googlesource.com does not '
1808 'exist or you have no access to it'), SystemExitMock()),
tandriic2405f52016-10-10 08:13:15 -07001809 ]
1810 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001811 self.assertEqual(1, git_cl.main(['patch', '123456']))
tandriic2405f52016-10-10 08:13:15 -07001812
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001813 def _checkout_calls(self):
1814 return [
1815 ((['git', 'config', '--local', '--get-regexp',
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001816 'branch\\..*\\.gerritissue'], ),
1817 ('branch.ger-branch.gerritissue 123456\n'
1818 'branch.gbranch654.gerritissue 654321\n')),
1819 ]
1820
1821 def test_checkout_gerrit(self):
1822 """Tests git cl checkout <issue>."""
1823 self.calls = self._checkout_calls()
1824 self.calls += [((['git', 'checkout', 'ger-branch'], ), '')]
1825 self.assertEqual(0, git_cl.main(['checkout', '123456']))
1826
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001827 def test_checkout_not_found(self):
1828 """Tests git cl checkout <issue>."""
1829 self.calls = self._checkout_calls()
1830 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1831
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001832 def test_checkout_no_branch_issues(self):
1833 """Tests git cl checkout <issue>."""
1834 self.calls = [
1835 ((['git', 'config', '--local', '--get-regexp',
tandrii5d48c322016-08-18 16:19:37 -07001836 'branch\\..*\\.gerritissue'], ), CERR1),
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001837 ]
1838 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1839
Edward Lemur26964072020-02-19 19:18:51 +00001840 def _test_gerrit_ensure_authenticated_common(self, auth):
Edward Lemurda4b6c62020-02-13 00:28:40 +00001841 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
1842 CookiesAuthenticatorMockFactory(hosts_with_creds=auth)).start()
Edward Lemur26964072020-02-19 19:18:51 +00001843 self.mockGit.config['remote.origin.url'] = (
1844 'https://chromium.googlesource.com/my/repo')
Edward Lemurf38bc172019-09-03 21:02:13 +00001845 cl = git_cl.Changelist()
tandrii@chromium.org28253532016-04-14 13:46:56 +00001846 cl.branch = 'master'
1847 cl.branchref = 'refs/heads/master'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001848 return cl
1849
1850 def test_gerrit_ensure_authenticated_missing(self):
1851 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001852 'chromium.googlesource.com': ('git-is.ok', '', 'but gerrit is missing'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001853 })
1854 self.calls.append(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001855 (('DieWithError',
1856 'Credentials for the following hosts are required:\n'
1857 ' chromium-review.googlesource.com\n'
1858 'These are read from ~/.gitcookies (or legacy ~/.netrc)\n'
1859 'You can (re)generate your credentials by visiting '
1860 'https://chromium-review.googlesource.com/new-password'), ''),)
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001861 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1862
1863 def test_gerrit_ensure_authenticated_conflict(self):
1864 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001865 'chromium.googlesource.com':
1866 ('git-one.example.com', None, 'secret1'),
1867 'chromium-review.googlesource.com':
1868 ('git-other.example.com', None, 'secret2'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001869 })
1870 self.calls.append(
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001871 (('ask_for_data', 'If you know what you are doing '
1872 'press Enter to continue, or Ctrl+C to abort'), ''))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001873 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1874
1875 def test_gerrit_ensure_authenticated_ok(self):
1876 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001877 'chromium.googlesource.com':
1878 ('git-same.example.com', None, 'secret'),
1879 'chromium-review.googlesource.com':
1880 ('git-same.example.com', None, 'secret'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001881 })
1882 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1883
tandrii@chromium.org28253532016-04-14 13:46:56 +00001884 def test_gerrit_ensure_authenticated_skipped(self):
Edward Lemur26964072020-02-19 19:18:51 +00001885 self.mockGit.config['gerrit.skip-ensure-authenticated'] = 'true'
1886 cl = self._test_gerrit_ensure_authenticated_common(auth={})
tandrii@chromium.org28253532016-04-14 13:46:56 +00001887 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1888
Eric Boren2fb63102018-10-05 13:05:03 +00001889 def test_gerrit_ensure_authenticated_bearer_token(self):
1890 cl = self._test_gerrit_ensure_authenticated_common(auth={
1891 'chromium.googlesource.com':
1892 ('', None, 'secret'),
1893 'chromium-review.googlesource.com':
1894 ('', None, 'secret'),
1895 })
1896 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1897 header = gerrit_util.CookiesAuthenticator().get_auth_header(
1898 'chromium.googlesource.com')
1899 self.assertTrue('Bearer' in header)
1900
Daniel Chengcf6269b2019-05-18 01:02:12 +00001901 def test_gerrit_ensure_authenticated_non_https(self):
Edward Lemur26964072020-02-19 19:18:51 +00001902 self.mockGit.config['remote.origin.url'] = 'custom-scheme://repo'
Daniel Chengcf6269b2019-05-18 01:02:12 +00001903 self.calls = [
Josip906bfde2020-01-31 22:38:49 +00001904 (('logging.warning',
1905 'Ignoring branch %(branch)s with non-https remote '
1906 '%(remote)s', {
1907 'branch': 'master',
1908 'remote': 'custom-scheme://repo'}
1909 ), None),
Daniel Chengcf6269b2019-05-18 01:02:12 +00001910 ]
Edward Lemurda4b6c62020-02-13 00:28:40 +00001911 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
1912 CookiesAuthenticatorMockFactory(hosts_with_creds={})).start()
1913 mock.patch('logging.warning',
1914 lambda *a: self._mocked_call('logging.warning', *a)).start()
Edward Lemurf38bc172019-09-03 21:02:13 +00001915 cl = git_cl.Changelist()
Daniel Chengcf6269b2019-05-18 01:02:12 +00001916 cl.branch = 'master'
1917 cl.branchref = 'refs/heads/master'
1918 cl.lookedup_issue = True
1919 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1920
Florian Mayerae510e82020-01-30 21:04:48 +00001921 def test_gerrit_ensure_authenticated_non_url(self):
Edward Lemur26964072020-02-19 19:18:51 +00001922 self.mockGit.config['remote.origin.url'] = (
1923 'git@somehost.example:foo/bar.git')
Florian Mayerae510e82020-01-30 21:04:48 +00001924 self.calls = [
Josip906bfde2020-01-31 22:38:49 +00001925 (('logging.error',
1926 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
1927 'but it doesn\'t exist.', {
1928 'remote': 'origin',
1929 'branch': 'master',
1930 'url': 'git@somehost.example:foo/bar.git'}
1931 ), None),
Florian Mayerae510e82020-01-30 21:04:48 +00001932 ]
Edward Lemurda4b6c62020-02-13 00:28:40 +00001933 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
1934 CookiesAuthenticatorMockFactory(hosts_with_creds={})).start()
1935 mock.patch('logging.error',
1936 lambda *a: self._mocked_call('logging.error', *a)).start()
Florian Mayerae510e82020-01-30 21:04:48 +00001937 cl = git_cl.Changelist()
1938 cl.branch = 'master'
1939 cl.branchref = 'refs/heads/master'
1940 cl.lookedup_issue = True
1941 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1942
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01001943 def _cmd_set_commit_gerrit_common(self, vote, notify=None):
Edward Lemur85153282020-02-14 22:06:29 +00001944 self.mockGit.config['branch.master.gerritissue'] = '123'
1945 self.mockGit.config['branch.master.gerritserver'] = (
1946 'https://chromium-review.googlesource.com')
Edward Lemur26964072020-02-19 19:18:51 +00001947 self.mockGit.config['remote.origin.url'] = (
1948 'https://chromium.googlesource.com/infra/infra')
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001949 self.calls = [
Edward Lemurda4b6c62020-02-13 00:28:40 +00001950 (('SetReview', 'chromium-review.googlesource.com',
1951 'infra%2Finfra~123', None,
1952 {'Commit-Queue': vote}, notify, None), ''),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001953 ]
tandriid9e5ce52016-07-13 02:32:59 -07001954
1955 def test_cmd_set_commit_gerrit_clear(self):
1956 self._cmd_set_commit_gerrit_common(0)
1957 self.assertEqual(0, git_cl.main(['set-commit', '-c']))
1958
1959 def test_cmd_set_commit_gerrit_dry(self):
Aaron Gable75e78722017-06-09 10:40:16 -07001960 self._cmd_set_commit_gerrit_common(1, notify=False)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001961 self.assertEqual(0, git_cl.main(['set-commit', '-d']))
1962
tandriid9e5ce52016-07-13 02:32:59 -07001963 def test_cmd_set_commit_gerrit(self):
1964 self._cmd_set_commit_gerrit_common(2)
1965 self.assertEqual(0, git_cl.main(['set-commit']))
1966
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001967 def test_description_display(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00001968 mock.patch('git_cl.Changelist', ChangelistMock).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00001969 ChangelistMock.desc = 'foo\n'
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001970
1971 self.assertEqual(0, git_cl.main(['description', '-d']))
Edward Lemurda4b6c62020-02-13 00:28:40 +00001972 self.assertEqual('foo\n', sys.stdout.getvalue())
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001973
Edward Lemurda4b6c62020-02-13 00:28:40 +00001974 @mock.patch('sys.stderr', StringIO())
iannucci3c972b92016-08-17 13:24:10 -07001975 def test_StatusFieldOverrideIssueMissingArgs(self):
iannucci3c972b92016-08-17 13:24:10 -07001976 try:
1977 self.assertEqual(git_cl.main(['status', '--issue', '1']), 0)
1978 except SystemExit as ex:
1979 self.assertEqual(ex.code, 2)
Edward Lemur6c6827c2020-02-06 21:15:18 +00001980 self.assertIn(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001981 '--field must be given when --issue is set.', sys.stderr.getvalue())
iannucci3c972b92016-08-17 13:24:10 -07001982
1983 def test_StatusFieldOverrideIssue(self):
iannucci3c972b92016-08-17 13:24:10 -07001984 def assertIssue(cl_self, *_args):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00001985 self.assertEqual(cl_self.issue, 1)
iannucci3c972b92016-08-17 13:24:10 -07001986 return 'foobar'
1987
Edward Lemurda4b6c62020-02-13 00:28:40 +00001988 mock.patch('git_cl.Changelist.FetchDescription', assertIssue).start()
iannuccie53c9352016-08-17 14:40:40 -07001989 self.assertEqual(
Edward Lemur52969c92020-02-06 18:15:28 +00001990 git_cl.main(['status', '--issue', '1', '--field', 'desc']),
iannuccie53c9352016-08-17 14:40:40 -07001991 0)
Edward Lemurda4b6c62020-02-13 00:28:40 +00001992 self.assertEqual(sys.stdout.getvalue(), 'foobar\n')
iannucci3c972b92016-08-17 13:24:10 -07001993
iannuccie53c9352016-08-17 14:40:40 -07001994 def test_SetCloseOverrideIssue(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001995
iannuccie53c9352016-08-17 14:40:40 -07001996 def assertIssue(cl_self, *_args):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00001997 self.assertEqual(cl_self.issue, 1)
iannuccie53c9352016-08-17 14:40:40 -07001998 return 'foobar'
1999
Edward Lemurda4b6c62020-02-13 00:28:40 +00002000 mock.patch('git_cl.Changelist.FetchDescription', assertIssue).start()
2001 mock.patch('git_cl.Changelist.CloseIssue', lambda *_: None).start()
iannuccie53c9352016-08-17 14:40:40 -07002002 self.assertEqual(
Edward Lemur52969c92020-02-06 18:15:28 +00002003 git_cl.main(['set-close', '--issue', '1']), 0)
iannuccie53c9352016-08-17 14:40:40 -07002004
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002005 def test_description(self):
Edward Lemur26964072020-02-19 19:18:51 +00002006 self.mockGit.config['remote.origin.url'] = (
2007 'https://chromium.googlesource.com/my/repo')
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002008 gerrit_util.GetChangeDetail.return_value = {
2009 'current_revision': 'sha1',
2010 'revisions': {'sha1': {
2011 'commit': {'message': 'foobar'},
2012 }},
2013 }
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002014 self.assertEqual(0, git_cl.main([
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002015 'description',
2016 'https://chromium-review.googlesource.com/c/my/repo/+/123123',
2017 '-d']))
Edward Lemurda4b6c62020-02-13 00:28:40 +00002018 self.assertEqual('foobar\n', sys.stdout.getvalue())
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002019
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002020 def test_description_set_raw(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002021 mock.patch('git_cl.Changelist', ChangelistMock).start()
2022 mock.patch('git_cl.sys.stdin', StringIO('hihi')).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002023
2024 self.assertEqual(0, git_cl.main(['description', '-n', 'hihi']))
2025 self.assertEqual('hihi', ChangelistMock.desc)
2026
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002027 def test_description_appends_bug_line(self):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002028 current_desc = 'Some.\n\nChange-Id: xxx'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002029
2030 def RunEditor(desc, _, **kwargs):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002031 self.assertEqual(
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002032 '# Enter a description of the change.\n'
2033 '# This will be displayed on the codereview site.\n'
2034 '# The first line will also be used as the subject of the review.\n'
2035 '#--------------------This line is 72 characters long'
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002036 '--------------------\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -07002037 'Some.\n\nChange-Id: xxx\nBug: ',
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002038 desc)
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002039 # Simulate user changing something.
Aaron Gable3a16ed12017-03-23 10:51:55 -07002040 return 'Some.\n\nChange-Id: xxx\nBug: 123'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002041
Edward Lemur6c6827c2020-02-06 21:15:18 +00002042 def UpdateDescription(_, desc, force=False):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002043 self.assertEqual(desc, 'Some.\n\nChange-Id: xxx\nBug: 123')
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002044
Edward Lemurda4b6c62020-02-13 00:28:40 +00002045 mock.patch('git_cl.Changelist.FetchDescription',
2046 lambda *args: current_desc).start()
2047 mock.patch('git_cl.Changelist.UpdateDescription',
2048 UpdateDescription).start()
2049 mock.patch('git_cl.gclient_utils.RunEditor', RunEditor).start()
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002050
Edward Lemur85153282020-02-14 22:06:29 +00002051 self.mockGit.config['branch.master.gerritissue'] = '123'
Edward Lemur52969c92020-02-06 18:15:28 +00002052 self.assertEqual(0, git_cl.main(['description']))
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002053
Dan Beamd8b04ca2019-10-10 21:23:26 +00002054 def test_description_does_not_append_bug_line_if_fixed_is_present(self):
2055 current_desc = 'Some.\n\nFixed: 123\nChange-Id: xxx'
2056
2057 def RunEditor(desc, _, **kwargs):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002058 self.assertEqual(
Dan Beamd8b04ca2019-10-10 21:23:26 +00002059 '# Enter a description of the change.\n'
2060 '# This will be displayed on the codereview site.\n'
2061 '# The first line will also be used as the subject of the review.\n'
2062 '#--------------------This line is 72 characters long'
2063 '--------------------\n'
2064 'Some.\n\nFixed: 123\nChange-Id: xxx',
2065 desc)
2066 return desc
2067
Edward Lemurda4b6c62020-02-13 00:28:40 +00002068 mock.patch('git_cl.Changelist.FetchDescription',
2069 lambda *args: current_desc).start()
2070 mock.patch('git_cl.gclient_utils.RunEditor', RunEditor).start()
Dan Beamd8b04ca2019-10-10 21:23:26 +00002071
Edward Lemur85153282020-02-14 22:06:29 +00002072 self.mockGit.config['branch.master.gerritissue'] = '123'
Edward Lemur52969c92020-02-06 18:15:28 +00002073 self.assertEqual(0, git_cl.main(['description']))
Dan Beamd8b04ca2019-10-10 21:23:26 +00002074
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002075 def test_description_set_stdin(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002076 mock.patch('git_cl.Changelist', ChangelistMock).start()
2077 mock.patch('git_cl.sys.stdin', StringIO('hi \r\n\t there\n\nman')).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002078
2079 self.assertEqual(0, git_cl.main(['description', '-n', '-']))
2080 self.assertEqual('hi\n\t there\n\nman', ChangelistMock.desc)
2081
kmarshall3bff56b2016-06-06 18:31:47 -07002082 def test_archive(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002083 self.calls = [
2084 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
Edward Lemurf38bc172019-09-03 21:02:13 +00002085 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002086 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002087 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],), ''),
Edward Lemurf38bc172019-09-03 21:02:13 +00002088 ((['git', 'branch', '-D', 'foo'],), '')
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002089 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002090
Edward Lemurda4b6c62020-02-13 00:28:40 +00002091 mock.patch('git_cl.get_cl_statuses',
kmarshall3bff56b2016-06-06 18:31:47 -07002092 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002093 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2094 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002095 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall3bff56b2016-06-06 18:31:47 -07002096
2097 self.assertEqual(0, git_cl.main(['archive', '-f']))
2098
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002099 def test_archive_tag_collision(self):
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002100 self.calls = [
2101 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2102 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2103 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],),
2104 'refs/tags/git-cl-archived-456-foo'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002105 ((['git', 'tag', 'git-cl-archived-456-foo-2', 'foo'],), ''),
2106 ((['git', 'branch', '-D', 'foo'],), '')
2107 ]
2108
Edward Lemurda4b6c62020-02-13 00:28:40 +00002109 mock.patch('git_cl.get_cl_statuses',
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002110 lambda branches, fine_grained, max_processes:
2111 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2112 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002113 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002114
2115 self.assertEqual(0, git_cl.main(['archive', '-f']))
2116
kmarshall3bff56b2016-06-06 18:31:47 -07002117 def test_archive_current_branch_fails(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002118 self.calls = [
2119 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2120 'refs/heads/master'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002121 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002122 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002123
Edward Lemurda4b6c62020-02-13 00:28:40 +00002124 mock.patch('git_cl.get_cl_statuses',
kmarshall9249e012016-08-23 12:02:16 -07002125 lambda branches, fine_grained, max_processes:
Edward Lemurda4b6c62020-02-13 00:28:40 +00002126 [(MockChangelistWithBranchAndIssue('master', 1),
2127 'closed')]).start()
kmarshall9249e012016-08-23 12:02:16 -07002128
2129 self.assertEqual(1, git_cl.main(['archive', '-f']))
2130
2131 def test_archive_dry_run(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002132 self.calls = [
2133 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2134 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002135 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002136 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002137
Edward Lemurda4b6c62020-02-13 00:28:40 +00002138 mock.patch('git_cl.get_cl_statuses',
kmarshall3bff56b2016-06-06 18:31:47 -07002139 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002140 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2141 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002142 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall3bff56b2016-06-06 18:31:47 -07002143
kmarshall9249e012016-08-23 12:02:16 -07002144 self.assertEqual(0, git_cl.main(['archive', '-f', '--dry-run']))
2145
2146 def test_archive_no_tags(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002147 self.calls = [
2148 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2149 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002150 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002151 ((['git', 'branch', '-D', 'foo'],), '')
2152 ]
kmarshall9249e012016-08-23 12:02:16 -07002153
Edward Lemurda4b6c62020-02-13 00:28:40 +00002154 mock.patch('git_cl.get_cl_statuses',
kmarshall9249e012016-08-23 12:02:16 -07002155 lambda branches, fine_grained, max_processes:
2156 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2157 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002158 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall9249e012016-08-23 12:02:16 -07002159
2160 self.assertEqual(0, git_cl.main(['archive', '-f', '--notags']))
kmarshall3bff56b2016-06-06 18:31:47 -07002161
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002162 def test_archive_tag_cleanup_on_branch_deletion_error(self):
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002163 self.calls = [
2164 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2165 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2166 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002167 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],),
2168 'refs/tags/git-cl-archived-456-foo'),
2169 ((['git', 'branch', '-D', 'foo'],), CERR1),
2170 ((['git', 'tag', '-d', 'git-cl-archived-456-foo'],),
2171 'refs/tags/git-cl-archived-456-foo'),
2172 ]
2173
Edward Lemurda4b6c62020-02-13 00:28:40 +00002174 mock.patch('git_cl.get_cl_statuses',
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002175 lambda branches, fine_grained, max_processes:
2176 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2177 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002178 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002179
2180 self.assertEqual(0, git_cl.main(['archive', '-f']))
2181
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002182 def test_cmd_issue_erase_existing(self):
Edward Lemur85153282020-02-14 22:06:29 +00002183 self.mockGit.config['branch.master.gerritissue'] = '123'
2184 self.mockGit.config['branch.master.gerritserver'] = (
2185 'https://chromium-review.googlesource.com')
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002186 self.calls = [
Aaron Gableca01e2c2017-07-19 11:16:02 -07002187 ((['git', 'log', '-1', '--format=%B'],), 'This is a description'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002188 ]
2189 self.assertEqual(0, git_cl.main(['issue', '0']))
Edward Lemur85153282020-02-14 22:06:29 +00002190 self.assertNotIn('branch.master.gerritissue', self.mockGit.config)
2191 self.assertNotIn('branch.master.gerritserver', self.mockGit.config)
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002192
Aaron Gable400e9892017-07-12 15:31:21 -07002193 def test_cmd_issue_erase_existing_with_change_id(self):
Edward Lemur85153282020-02-14 22:06:29 +00002194 self.mockGit.config['branch.master.gerritissue'] = '123'
2195 self.mockGit.config['branch.master.gerritserver'] = (
2196 'https://chromium-review.googlesource.com')
Edward Lemurda4b6c62020-02-13 00:28:40 +00002197 mock.patch('git_cl.Changelist.FetchDescription',
2198 lambda _: 'This is a description\n\nChange-Id: Ideadbeef').start()
Aaron Gable400e9892017-07-12 15:31:21 -07002199 self.calls = [
Aaron Gableca01e2c2017-07-19 11:16:02 -07002200 ((['git', 'log', '-1', '--format=%B'],),
2201 'This is a description\n\nChange-Id: Ideadbeef'),
2202 ((['git', 'commit', '--amend', '-m', 'This is a description\n'],), ''),
Aaron Gable400e9892017-07-12 15:31:21 -07002203 ]
2204 self.assertEqual(0, git_cl.main(['issue', '0']))
Edward Lemur85153282020-02-14 22:06:29 +00002205 self.assertNotIn('branch.master.gerritissue', self.mockGit.config)
2206 self.assertNotIn('branch.master.gerritserver', self.mockGit.config)
Aaron Gable400e9892017-07-12 15:31:21 -07002207
phajdan.jre328cf92016-08-22 04:12:17 -07002208 def test_cmd_issue_json(self):
Edward Lemur85153282020-02-14 22:06:29 +00002209 self.mockGit.config['branch.master.gerritissue'] = '123'
2210 self.mockGit.config['branch.master.gerritserver'] = (
2211 'https://chromium-review.googlesource.com')
phajdan.jre328cf92016-08-22 04:12:17 -07002212 self.calls = [
phajdan.jre328cf92016-08-22 04:12:17 -07002213 (('write_json', 'output.json',
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002214 {'issue': 123,
2215 'issue_url': 'https://chromium-review.googlesource.com/123'}),
phajdan.jre328cf92016-08-22 04:12:17 -07002216 ''),
2217 ]
2218 self.assertEqual(0, git_cl.main(['issue', '--json', 'output.json']))
2219
tandrii16e0b4e2016-06-07 10:34:28 -07002220 def _common_GerritCommitMsgHookCheck(self):
Edward Lemur15a9b8c2020-02-13 00:52:30 +00002221 mock.patch(
2222 'git_cl.os.path.abspath',
2223 lambda path: self._mocked_call(['abspath', path])).start()
2224 mock.patch(
2225 'git_cl.os.path.exists',
2226 lambda path: self._mocked_call(['exists', path])).start()
2227 mock.patch(
2228 'git_cl.gclient_utils.FileRead',
2229 lambda path: self._mocked_call(['FileRead', path])).start()
2230 mock.patch(
2231 'git_cl.gclient_utils.rm_file_or_tree',
2232 lambda path: self._mocked_call(['rm_file_or_tree', path])).start()
Edward Lemurf38bc172019-09-03 21:02:13 +00002233 return git_cl.Changelist(issue=123)
tandrii16e0b4e2016-06-07 10:34:28 -07002234
2235 def test_GerritCommitMsgHookCheck_custom_hook(self):
2236 cl = self._common_GerritCommitMsgHookCheck()
2237 self.calls += [
Edward Lemur15a9b8c2020-02-13 00:52:30 +00002238 ((['exists', '.git/hooks/commit-msg'],), True),
2239 ((['FileRead', '.git/hooks/commit-msg'],),
tandrii16e0b4e2016-06-07 10:34:28 -07002240 '#!/bin/sh\necho "custom hook"')
2241 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002242 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002243
2244 def test_GerritCommitMsgHookCheck_not_exists(self):
2245 cl = self._common_GerritCommitMsgHookCheck()
2246 self.calls += [
Edward Lemur15a9b8c2020-02-13 00:52:30 +00002247 ((['exists', '.git/hooks/commit-msg'],), False),
tandrii16e0b4e2016-06-07 10:34:28 -07002248 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002249 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002250
2251 def test_GerritCommitMsgHookCheck(self):
2252 cl = self._common_GerritCommitMsgHookCheck()
2253 self.calls += [
Edward Lemur15a9b8c2020-02-13 00:52:30 +00002254 ((['exists', '.git/hooks/commit-msg'],), True),
2255 ((['FileRead', '.git/hooks/commit-msg'],),
tandrii16e0b4e2016-06-07 10:34:28 -07002256 '...\n# From Gerrit Code Review\n...\nadd_ChangeId()\n'),
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002257 (('ask_for_data', 'Do you want to remove it now? [Yes/No]: '), 'Yes'),
Edward Lemur15a9b8c2020-02-13 00:52:30 +00002258 ((['rm_file_or_tree', '.git/hooks/commit-msg'],),
tandrii16e0b4e2016-06-07 10:34:28 -07002259 ''),
2260 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002261 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002262
tandriic4344b52016-08-29 06:04:54 -07002263 def test_GerritCmdLand(self):
Edward Lemur85153282020-02-14 22:06:29 +00002264 self.mockGit.config['branch.master.gerritsquashhash'] = 'deadbeaf'
2265 self.mockGit.config['branch.master.gerritserver'] = (
2266 'chromium-review.googlesource.com')
tandriic4344b52016-08-29 06:04:54 -07002267 self.calls += [
tandriic4344b52016-08-29 06:04:54 -07002268 ((['git', 'diff', 'deadbeaf'],), ''), # No diff.
tandriic4344b52016-08-29 06:04:54 -07002269 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002270 cl = git_cl.Changelist(issue=123)
Edward Lemur125d60a2019-09-13 18:25:41 +00002271 cl._GetChangeDetail = lambda *args, **kwargs: {
tandriic4344b52016-08-29 06:04:54 -07002272 'labels': {},
2273 'current_revision': 'deadbeaf',
2274 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002275 cl._GetChangeCommit = lambda: {
agable32978d92016-11-01 12:55:02 -07002276 'commit': 'deadbeef',
Aaron Gable02cdbb42016-12-13 16:24:25 -08002277 'web_links': [{'name': 'gitiles',
agable32978d92016-11-01 12:55:02 -07002278 'url': 'https://git.googlesource.com/test/+/deadbeef'}],
2279 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002280 cl.SubmitIssue = lambda wait_for_merge: None
Olivier Robin75ee7252018-04-13 10:02:56 +02002281 self.assertEqual(0, cl.CMDLand(force=True,
2282 bypass_hooks=True,
2283 verbose=True,
2284 parallel=False))
Edward Lemur73c76702020-02-06 23:57:18 +00002285 self.assertIn(
2286 'Issue chromium-review.googlesource.com/123 has been submitted',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002287 sys.stdout.getvalue())
Edward Lemur73c76702020-02-06 23:57:18 +00002288 self.assertIn(
2289 'Landed as: https://git.googlesource.com/test/+/deadbeef',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002290 sys.stdout.getvalue())
tandriic4344b52016-08-29 06:04:54 -07002291
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002292 def _mock_gerrit_changes_for_detail_cache(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002293 mock.patch('git_cl.Changelist._GetGerritHost', lambda _: 'host').start()
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002294
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002295 def test_gerrit_change_detail_cache_simple(self):
2296 self._mock_gerrit_changes_for_detail_cache()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002297 gerrit_util.GetChangeDetail.side_effect = ['a', 'b']
Edward Lemurf38bc172019-09-03 21:02:13 +00002298 cl1 = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002299 cl1._cached_remote_url = (
2300 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemurf38bc172019-09-03 21:02:13 +00002301 cl2 = git_cl.Changelist(issue=2)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002302 cl2._cached_remote_url = (
2303 True, 'https://chromium.googlesource.com/ab/repo')
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002304 self.assertEqual(cl1._GetChangeDetail(), 'a') # Miss.
2305 self.assertEqual(cl1._GetChangeDetail(), 'a')
2306 self.assertEqual(cl2._GetChangeDetail(), 'b') # Miss.
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002307
2308 def test_gerrit_change_detail_cache_options(self):
2309 self._mock_gerrit_changes_for_detail_cache()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002310 gerrit_util.GetChangeDetail.side_effect = ['cab', 'ad']
Edward Lemurf38bc172019-09-03 21:02:13 +00002311 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002312 cl._cached_remote_url = (True, 'https://chromium.googlesource.com/repo/')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002313 self.assertEqual(cl._GetChangeDetail(options=['C', 'A', 'B']), 'cab')
2314 self.assertEqual(cl._GetChangeDetail(options=['A', 'B', 'C']), 'cab')
2315 self.assertEqual(cl._GetChangeDetail(options=['B', 'A']), 'cab')
2316 self.assertEqual(cl._GetChangeDetail(options=['C']), 'cab')
2317 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2318 self.assertEqual(cl._GetChangeDetail(), 'cab')
2319
2320 self.assertEqual(cl._GetChangeDetail(options=['A', 'D']), 'ad')
2321 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2322 self.assertEqual(cl._GetChangeDetail(options=['D']), 'ad')
2323 self.assertEqual(cl._GetChangeDetail(), 'cab')
2324
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002325 def test_gerrit_description_caching(self):
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002326 gerrit_util.GetChangeDetail.return_value = {
2327 'current_revision': 'rev1',
2328 'revisions': {
2329 'rev1': {'commit': {'message': 'desc1'}},
2330 },
2331 }
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002332
2333 self._mock_gerrit_changes_for_detail_cache()
Edward Lemurf38bc172019-09-03 21:02:13 +00002334 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002335 cl._cached_remote_url = (
2336 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemur6c6827c2020-02-06 21:15:18 +00002337 self.assertEqual(cl.FetchDescription(), 'desc1')
2338 self.assertEqual(cl.FetchDescription(), 'desc1') # cache hit.
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002339
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002340 def test_print_current_creds(self):
2341 class CookiesAuthenticatorMock(object):
2342 def __init__(self):
2343 self.gitcookies = {
2344 'host.googlesource.com': ('user', 'pass'),
2345 'host-review.googlesource.com': ('user', 'pass'),
2346 }
2347 self.netrc = self
2348 self.netrc.hosts = {
2349 'github.com': ('user2', None, 'pass2'),
2350 'host2.googlesource.com': ('user3', None, 'pass'),
2351 }
Edward Lemurda4b6c62020-02-13 00:28:40 +00002352 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
2353 CookiesAuthenticatorMock).start()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002354 git_cl._GitCookiesChecker().print_current_creds(include_netrc=True)
2355 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2356 ' Host\t User\t Which file',
2357 '============================\t=====\t===========',
2358 'host-review.googlesource.com\t user\t.gitcookies',
2359 ' host.googlesource.com\t user\t.gitcookies',
2360 ' host2.googlesource.com\tuser3\t .netrc',
2361 ])
Edward Lemur79d4f992019-11-11 23:49:02 +00002362 sys.stdout.seek(0)
2363 sys.stdout.truncate(0)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002364 git_cl._GitCookiesChecker().print_current_creds(include_netrc=False)
2365 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2366 ' Host\tUser\t Which file',
2367 '============================\t====\t===========',
2368 'host-review.googlesource.com\tuser\t.gitcookies',
2369 ' host.googlesource.com\tuser\t.gitcookies',
2370 ])
2371
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002372 def _common_creds_check_mocks(self):
2373 def exists_mock(path):
2374 dirname = os.path.dirname(path)
2375 if dirname == os.path.expanduser('~'):
2376 dirname = '~'
2377 base = os.path.basename(path)
2378 if base in ('.netrc', '.gitcookies'):
2379 return self._mocked_call('os.path.exists', '%s/%s' % (dirname, base))
2380 # git cl also checks for existence other files not relevant to this test.
2381 return None
Edward Lemurda4b6c62020-02-13 00:28:40 +00002382 mock.patch('os.path.exists', exists_mock).start()
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002383
2384 def test_creds_check_gitcookies_not_configured(self):
2385 self._common_creds_check_mocks()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002386 mock.patch('git_cl._GitCookiesChecker.get_hosts_with_creds',
2387 lambda _, include_netrc=False: []).start()
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002388 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08002389 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002390 ((['git', 'config', '--global', 'http.cookiefile'],), CERR1),
2391 (('os.path.exists', '~/.netrc'), True),
2392 (('ask_for_data', 'Press Enter to setup .gitcookies, '
2393 'or Ctrl+C to abort'), ''),
2394 ((['git', 'config', '--global', 'http.cookiefile',
2395 os.path.expanduser('~/.gitcookies')], ), ''),
2396 ]
2397 self.assertEqual(0, git_cl.main(['creds-check']))
Edward Lemur73c76702020-02-06 23:57:18 +00002398 self.assertTrue(
2399 sys.stdout.getvalue().startswith(
2400 'You seem to be using outdated .netrc for git credentials:'))
2401 self.assertIn(
2402 '\nConfigured git to use .gitcookies from',
2403 sys.stdout.getvalue())
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002404
2405 def test_creds_check_gitcookies_configured_custom_broken(self):
2406 self._common_creds_check_mocks()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002407 mock.patch('git_cl._GitCookiesChecker.get_hosts_with_creds',
2408 lambda _, include_netrc=False: []).start()
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002409 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08002410 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002411 ((['git', 'config', '--global', 'http.cookiefile'],),
2412 '/custom/.gitcookies'),
2413 (('os.path.exists', '/custom/.gitcookies'), False),
2414 (('ask_for_data', 'Reconfigure git to use default .gitcookies? '
2415 'Press Enter to reconfigure, or Ctrl+C to abort'), ''),
2416 ((['git', 'config', '--global', 'http.cookiefile',
2417 os.path.expanduser('~/.gitcookies')], ), ''),
2418 ]
2419 self.assertEqual(0, git_cl.main(['creds-check']))
Edward Lemur73c76702020-02-06 23:57:18 +00002420 self.assertIn(
2421 'WARNING: You have configured custom path to .gitcookies: ',
2422 sys.stdout.getvalue())
2423 self.assertIn(
2424 'However, your configured .gitcookies file is missing.',
2425 sys.stdout.getvalue())
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002426
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002427 def test_git_cl_comment_add_gerrit(self):
Edward Lemur85153282020-02-14 22:06:29 +00002428 self.mockGit.branchref = None
Edward Lemur26964072020-02-19 19:18:51 +00002429 self.mockGit.config['remote.origin.url'] = (
2430 'https://chromium.googlesource.com/infra/infra')
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002431 self.calls = [
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002432 (('SetReview', 'chromium-review.googlesource.com', 'infra%2Finfra~10',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002433 'msg', None, None, None),
Aaron Gable636b13f2017-07-14 10:42:48 -07002434 None),
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002435 ]
Edward Lemur52969c92020-02-06 18:15:28 +00002436 self.assertEqual(0, git_cl.main(['comment', '-i', '10', '-a', 'msg']))
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002437
Edward Lemurda4b6c62020-02-13 00:28:40 +00002438 @mock.patch('git_cl.Changelist.GetBranch', return_value='foo')
2439 def test_git_cl_comments_fetch_gerrit(self, *_mocks):
Edward Lemur26964072020-02-19 19:18:51 +00002440 self.mockGit.config['remote.origin.url'] = (
2441 'https://chromium.googlesource.com/infra/infra')
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002442 gerrit_util.GetChangeDetail.return_value = {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002443 'owner': {'email': 'owner@example.com'},
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002444 'current_revision': 'ba5eba11',
2445 'revisions': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002446 'deadbeaf': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002447 '_number': 1,
2448 },
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002449 'ba5eba11': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002450 '_number': 2,
2451 },
2452 },
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002453 'messages': [
2454 {
2455 u'_revision_number': 1,
2456 u'author': {
2457 u'_account_id': 1111084,
2458 u'email': u'commit-bot@chromium.org',
2459 u'name': u'Commit Bot'
2460 },
2461 u'date': u'2017-03-15 20:08:45.000000000',
2462 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
Dirk Prankef6a58802017-10-17 12:49:42 -07002463 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002464 u'tag': u'autogenerated:cq:dry-run'
2465 },
2466 {
2467 u'_revision_number': 2,
2468 u'author': {
2469 u'_account_id': 11151243,
2470 u'email': u'owner@example.com',
2471 u'name': u'owner'
2472 },
2473 u'date': u'2017-03-16 20:00:41.000000000',
2474 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2475 u'message': u'PTAL',
2476 },
2477 {
2478 u'_revision_number': 2,
2479 u'author': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002480 u'_account_id': 148512,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002481 u'email': u'reviewer@example.com',
2482 u'name': u'reviewer'
2483 },
2484 u'date': u'2017-03-17 05:19:37.500000000',
2485 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2486 u'message': u'Patch Set 2: Code-Review+1',
2487 },
2488 ]
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002489 }
2490 self.calls = [
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002491 (('GetChangeComments', 'chromium-review.googlesource.com',
2492 'infra%2Finfra~1'), {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002493 '/COMMIT_MSG': [
2494 {
2495 'author': {'email': u'reviewer@example.com'},
2496 'updated': u'2017-03-17 05:19:37.500000000',
2497 'patch_set': 2,
2498 'side': 'REVISION',
2499 'message': 'Please include a bug link',
2500 },
2501 ],
2502 'codereview.settings': [
2503 {
2504 'author': {'email': u'owner@example.com'},
2505 'updated': u'2017-03-16 20:00:41.000000000',
2506 'patch_set': 2,
2507 'side': 'PARENT',
2508 'line': 42,
2509 'message': 'I removed this because it is bad',
2510 },
2511 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002512 }),
2513 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
2514 'infra%2Finfra~1'), {}),
Leszek Swirski45b20c42018-09-17 17:05:26 +00002515 ] * 2 + [
2516 (('write_json', 'output.json', [
2517 {
2518 u'date': u'2017-03-16 20:00:41.000000',
2519 u'message': (
2520 u'PTAL\n' +
2521 u'\n' +
2522 u'codereview.settings\n' +
2523 u' Base, Line 42: https://chromium-review.googlesource.com/' +
2524 u'c/1/2/codereview.settings#b42\n' +
2525 u' I removed this because it is bad\n'),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002526 u'autogenerated': False,
Leszek Swirski45b20c42018-09-17 17:05:26 +00002527 u'approval': False,
2528 u'disapproval': False,
2529 u'sender': u'owner@example.com'
2530 }, {
2531 u'date': u'2017-03-17 05:19:37.500000',
2532 u'message': (
2533 u'Patch Set 2: Code-Review+1\n' +
2534 u'\n' +
2535 u'/COMMIT_MSG\n' +
2536 u' PS2, File comment: https://chromium-review.googlesource' +
2537 u'.com/c/1/2//COMMIT_MSG#\n' +
2538 u' Please include a bug link\n'),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002539 u'autogenerated': False,
Leszek Swirski45b20c42018-09-17 17:05:26 +00002540 u'approval': False,
2541 u'disapproval': False,
2542 u'sender': u'reviewer@example.com'
2543 }
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002544 ]), '')
Leszek Swirski45b20c42018-09-17 17:05:26 +00002545 ]
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002546 expected_comments_summary = [
2547 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002548 message=(
2549 u'PTAL\n' +
2550 u'\n' +
2551 u'codereview.settings\n' +
2552 u' Base, Line 42: https://chromium-review.googlesource.com/' +
2553 u'c/1/2/codereview.settings#b42\n' +
2554 u' I removed this because it is bad\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002555 date=datetime.datetime(2017, 3, 16, 20, 0, 41, 0),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002556 autogenerated=False,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002557 disapproval=False, approval=False, sender=u'owner@example.com'),
2558 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002559 message=(
2560 u'Patch Set 2: Code-Review+1\n' +
2561 u'\n' +
2562 u'/COMMIT_MSG\n' +
2563 u' PS2, File comment: https://chromium-review.googlesource.com/' +
2564 u'c/1/2//COMMIT_MSG#\n' +
2565 u' Please include a bug link\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002566 date=datetime.datetime(2017, 3, 17, 5, 19, 37, 500000),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002567 autogenerated=False,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002568 disapproval=False, approval=False, sender=u'reviewer@example.com'),
2569 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002570 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00002571 issue=1, branchref='refs/heads/foo')
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002572 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002573 self.assertEqual(
2574 0, git_cl.main(['comments', '-i', '1', '-j', 'output.json']))
2575
2576 def test_git_cl_comments_robot_comments(self):
2577 # git cl comments also fetches robot comments (which are considered a type
2578 # of autogenerated comment), and unlike other types of comments, only robot
2579 # comments from the latest patchset are shown.
Edward Lemur26964072020-02-19 19:18:51 +00002580 self.mockGit.config['remote.origin.url'] = (
2581 'https://chromium.googlesource.com/infra/infra')
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002582 gerrit_util.GetChangeDetail.return_value = {
2583 'owner': {'email': 'owner@example.com'},
2584 'current_revision': 'ba5eba11',
2585 'revisions': {
2586 'deadbeaf': {
2587 '_number': 1,
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002588 },
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002589 'ba5eba11': {
2590 '_number': 2,
2591 },
2592 },
2593 'messages': [
2594 {
2595 u'_revision_number': 1,
2596 u'author': {
2597 u'_account_id': 1111084,
2598 u'email': u'commit-bot@chromium.org',
2599 u'name': u'Commit Bot'
2600 },
2601 u'date': u'2017-03-15 20:08:45.000000000',
2602 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
2603 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
2604 u'tag': u'autogenerated:cq:dry-run'
2605 },
2606 {
2607 u'_revision_number': 1,
2608 u'author': {
2609 u'_account_id': 123,
2610 u'email': u'tricium@serviceaccount.com',
2611 u'name': u'Tricium'
2612 },
2613 u'date': u'2017-03-16 20:00:41.000000000',
2614 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2615 u'message': u'(1 comment)',
2616 u'tag': u'autogenerated:tricium',
2617 },
2618 {
2619 u'_revision_number': 1,
2620 u'author': {
2621 u'_account_id': 123,
2622 u'email': u'tricium@serviceaccount.com',
2623 u'name': u'Tricium'
2624 },
2625 u'date': u'2017-03-16 20:00:41.000000000',
2626 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2627 u'message': u'(1 comment)',
2628 u'tag': u'autogenerated:tricium',
2629 },
2630 {
2631 u'_revision_number': 2,
2632 u'author': {
2633 u'_account_id': 123,
2634 u'email': u'tricium@serviceaccount.com',
2635 u'name': u'reviewer'
2636 },
2637 u'date': u'2017-03-17 05:30:37.000000000',
2638 u'tag': u'autogenerated:tricium',
2639 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2640 u'message': u'(1 comment)',
2641 },
2642 ]
2643 }
2644 self.calls = [
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002645 (('GetChangeComments', 'chromium-review.googlesource.com',
2646 'infra%2Finfra~1'), {}),
2647 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
2648 'infra%2Finfra~1'), {
2649 'codereview.settings': [
2650 {
2651 u'author': {u'email': u'tricium@serviceaccount.com'},
2652 u'updated': u'2017-03-17 05:30:37.000000000',
2653 u'robot_run_id': u'5565031076855808',
2654 u'robot_id': u'Linter/Category',
2655 u'tag': u'autogenerated:tricium',
2656 u'patch_set': 2,
2657 u'side': u'REVISION',
2658 u'message': u'Linter warning message text',
2659 u'line': 32,
2660 },
2661 ],
2662 }),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002663 ]
2664 expected_comments_summary = [
2665 git_cl._CommentSummary(date=datetime.datetime(2017, 3, 17, 5, 30, 37),
2666 message=(
2667 u'(1 comment)\n\ncodereview.settings\n'
2668 u' PS2, Line 32: https://chromium-review.googlesource.com/'
2669 u'c/1/2/codereview.settings#32\n'
2670 u' Linter warning message text\n'),
2671 sender=u'tricium@serviceaccount.com',
2672 autogenerated=True, approval=False, disapproval=False)
2673 ]
2674 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00002675 issue=1, branchref='refs/heads/foo')
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002676 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002677
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002678 def test_get_remote_url_with_mirror(self):
2679 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002680
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002681 def selective_os_path_isdir_mock(path):
2682 if path == '/cache/this-dir-exists':
2683 return self._mocked_call('os.path.isdir', path)
2684 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002685
Edward Lemurda4b6c62020-02-13 00:28:40 +00002686 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002687
2688 url = 'https://chromium.googlesource.com/my/repo'
Edward Lemur26964072020-02-19 19:18:51 +00002689 self.mockGit.config['remote.origin.url'] = (
2690 '/cache/this-dir-exists')
2691 self.mockGit.config['/cache/this-dir-exists:remote.origin.url'] = (
2692 url)
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002693 self.calls = [
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002694 (('os.path.isdir', '/cache/this-dir-exists'),
2695 True),
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002696 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002697 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002698 self.assertEqual(cl.GetRemoteUrl(), url)
2699 self.assertEqual(cl.GetRemoteUrl(), url) # Must be cached.
2700
Edward Lemur298f2cf2019-02-22 21:40:39 +00002701 def test_get_remote_url_non_existing_mirror(self):
2702 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002703
Edward Lemur298f2cf2019-02-22 21:40:39 +00002704 def selective_os_path_isdir_mock(path):
2705 if path == '/cache/this-dir-doesnt-exist':
2706 return self._mocked_call('os.path.isdir', path)
2707 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002708
Edward Lemurda4b6c62020-02-13 00:28:40 +00002709 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
2710 mock.patch('logging.error',
2711 lambda *a: self._mocked_call('logging.error', *a)).start()
Edward Lemur298f2cf2019-02-22 21:40:39 +00002712
Edward Lemur26964072020-02-19 19:18:51 +00002713 self.mockGit.config['remote.origin.url'] = (
2714 '/cache/this-dir-doesnt-exist')
Edward Lemur298f2cf2019-02-22 21:40:39 +00002715 self.calls = [
Edward Lemur298f2cf2019-02-22 21:40:39 +00002716 (('os.path.isdir', '/cache/this-dir-doesnt-exist'),
2717 False),
2718 (('logging.error',
Josip906bfde2020-01-31 22:38:49 +00002719 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
2720 'but it doesn\'t exist.', {
2721 'remote': 'origin',
2722 'branch': 'master',
2723 'url': '/cache/this-dir-doesnt-exist'}
2724 ), None),
Edward Lemur298f2cf2019-02-22 21:40:39 +00002725 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002726 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00002727 self.assertIsNone(cl.GetRemoteUrl())
2728
2729 def test_get_remote_url_misconfigured_mirror(self):
2730 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002731
Edward Lemur298f2cf2019-02-22 21:40:39 +00002732 def selective_os_path_isdir_mock(path):
2733 if path == '/cache/this-dir-exists':
2734 return self._mocked_call('os.path.isdir', path)
2735 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002736
Edward Lemurda4b6c62020-02-13 00:28:40 +00002737 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
2738 mock.patch('logging.error',
2739 lambda *a: self._mocked_call('logging.error', *a)).start()
Edward Lemur298f2cf2019-02-22 21:40:39 +00002740
Edward Lemur26964072020-02-19 19:18:51 +00002741 self.mockGit.config['remote.origin.url'] = (
2742 '/cache/this-dir-exists')
Edward Lemur298f2cf2019-02-22 21:40:39 +00002743 self.calls = [
Edward Lemur298f2cf2019-02-22 21:40:39 +00002744 (('os.path.isdir', '/cache/this-dir-exists'), True),
Edward Lemur298f2cf2019-02-22 21:40:39 +00002745 (('logging.error',
2746 'Remote "%(remote)s" for branch "%(branch)s" points to '
2747 '"%(cache_path)s", but it is misconfigured.\n'
2748 '"%(cache_path)s" must be a git repo and must have a remote named '
2749 '"%(remote)s" pointing to the git host.', {
2750 'remote': 'origin',
2751 'cache_path': '/cache/this-dir-exists',
2752 'branch': 'master'}
2753 ), None),
2754 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002755 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00002756 self.assertIsNone(cl.GetRemoteUrl())
2757
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002758 def test_gerrit_change_identifier_with_project(self):
Edward Lemur26964072020-02-19 19:18:51 +00002759 self.mockGit.config['remote.origin.url'] = (
2760 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemurf38bc172019-09-03 21:02:13 +00002761 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002762 self.assertEqual(cl._GerritChangeIdentifier(), 'my%2Frepo~123456')
2763
2764 def test_gerrit_change_identifier_without_project(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002765 mock.patch('logging.error',
2766 lambda *a: self._mocked_call('logging.error', *a)).start()
Josip906bfde2020-01-31 22:38:49 +00002767
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002768 self.calls = [
Josip906bfde2020-01-31 22:38:49 +00002769 (('logging.error',
2770 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
2771 'but it doesn\'t exist.', {
2772 'remote': 'origin',
2773 'branch': 'master',
2774 'url': ''}
2775 ), None),
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002776 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002777 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002778 self.assertEqual(cl._GerritChangeIdentifier(), '123456')
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00002779
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002780
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002781class CMDTestCaseBase(unittest.TestCase):
2782 _STATUSES = [
2783 'STATUS_UNSPECIFIED', 'SCHEDULED', 'STARTED', 'SUCCESS', 'FAILURE',
2784 'INFRA_FAILURE', 'CANCELED',
2785 ]
2786 _CHANGE_DETAIL = {
2787 'project': 'depot_tools',
2788 'status': 'OPEN',
2789 'owner': {'email': 'owner@e.mail'},
2790 'current_revision': 'beeeeeef',
2791 'revisions': {
2792 'deadbeaf': {'_number': 6},
2793 'beeeeeef': {
2794 '_number': 7,
2795 'fetch': {'http': {
2796 'url': 'https://chromium.googlesource.com/depot_tools',
2797 'ref': 'refs/changes/56/123456/7'
2798 }},
2799 },
2800 },
2801 }
2802 _DEFAULT_RESPONSE = {
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00002803 'builds': [{
2804 'id': str(100 + idx),
2805 'builder': {
2806 'project': 'chromium',
2807 'bucket': 'try',
2808 'builder': 'bot_' + status.lower(),
2809 },
2810 'createTime': '2019-10-09T08:00:0%d.854286Z' % (idx % 10),
2811 'tags': [],
2812 'status': status,
2813 } for idx, status in enumerate(_STATUSES)]
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002814 }
2815
Edward Lemur4c707a22019-09-24 21:13:43 +00002816 def setUp(self):
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002817 super(CMDTestCaseBase, self).setUp()
Edward Lemur79d4f992019-11-11 23:49:02 +00002818 mock.patch('git_cl.sys.stdout', StringIO()).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002819 mock.patch('git_cl.uuid.uuid4', return_value='uuid4').start()
2820 mock.patch('git_cl.Changelist.GetIssue', return_value=123456).start()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002821 mock.patch(
2822 'git_cl.Changelist.GetCodereviewServer',
2823 return_value='https://chromium-review.googlesource.com').start()
2824 mock.patch(
2825 'git_cl.Changelist._GetGerritHost',
2826 return_value='chromium-review.googlesource.com').start()
2827 mock.patch(
2828 'git_cl.Changelist.GetMostRecentPatchset',
2829 return_value=7).start()
2830 mock.patch(
2831 'git_cl.Changelist.GetRemoteUrl',
2832 return_value='https://chromium.googlesource.com/depot_tools').start()
2833 mock.patch(
2834 'auth.Authenticator',
2835 return_value=AuthenticatorMock()).start()
2836 mock.patch(
2837 'gerrit_util.GetChangeDetail',
2838 return_value=self._CHANGE_DETAIL).start()
2839 mock.patch(
2840 'git_cl._call_buildbucket',
2841 return_value = self._DEFAULT_RESPONSE).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002842 mock.patch('git_common.is_dirty_git_tree', return_value=False).start()
Edward Lemur4c707a22019-09-24 21:13:43 +00002843 self.addCleanup(mock.patch.stopall)
2844
Edward Lemur4c707a22019-09-24 21:13:43 +00002845
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002846class CMDTryResultsTestCase(CMDTestCaseBase):
2847 _DEFAULT_REQUEST = {
2848 'predicate': {
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00002849 "gerritChanges": [{
2850 "project": "depot_tools",
2851 "host": "chromium-review.googlesource.com",
2852 "patchset": 7,
2853 "change": 123456,
2854 }],
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002855 },
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00002856 'fields': ('builds.*.id,builds.*.builder,builds.*.status' +
2857 ',builds.*.createTime,builds.*.tags'),
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002858 }
2859
2860 def testNoJobs(self):
2861 git_cl._call_buildbucket.return_value = {}
2862
2863 self.assertEqual(0, git_cl.main(['try-results']))
2864 self.assertEqual('No tryjobs scheduled.\n', sys.stdout.getvalue())
2865 git_cl._call_buildbucket.assert_called_once_with(
2866 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
2867 self._DEFAULT_REQUEST)
2868
2869 def testPrintToStdout(self):
2870 self.assertEqual(0, git_cl.main(['try-results']))
2871 self.assertEqual([
2872 'Successes:',
2873 ' bot_success https://ci.chromium.org/b/103',
2874 'Infra Failures:',
2875 ' bot_infra_failure https://ci.chromium.org/b/105',
2876 'Failures:',
2877 ' bot_failure https://ci.chromium.org/b/104',
2878 'Canceled:',
2879 ' bot_canceled ',
2880 'Started:',
2881 ' bot_started https://ci.chromium.org/b/102',
2882 'Scheduled:',
2883 ' bot_scheduled id=101',
2884 'Other:',
2885 ' bot_status_unspecified id=100',
2886 'Total: 7 tryjobs',
2887 ], sys.stdout.getvalue().splitlines())
2888 git_cl._call_buildbucket.assert_called_once_with(
2889 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
2890 self._DEFAULT_REQUEST)
2891
2892 def testPrintToStdoutWithMasters(self):
2893 self.assertEqual(0, git_cl.main(['try-results', '--print-master']))
2894 self.assertEqual([
2895 'Successes:',
2896 ' try bot_success https://ci.chromium.org/b/103',
2897 'Infra Failures:',
2898 ' try bot_infra_failure https://ci.chromium.org/b/105',
2899 'Failures:',
2900 ' try bot_failure https://ci.chromium.org/b/104',
2901 'Canceled:',
2902 ' try bot_canceled ',
2903 'Started:',
2904 ' try bot_started https://ci.chromium.org/b/102',
2905 'Scheduled:',
2906 ' try bot_scheduled id=101',
2907 'Other:',
2908 ' try bot_status_unspecified id=100',
2909 'Total: 7 tryjobs',
2910 ], sys.stdout.getvalue().splitlines())
2911 git_cl._call_buildbucket.assert_called_once_with(
2912 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
2913 self._DEFAULT_REQUEST)
2914
2915 @mock.patch('git_cl.write_json')
2916 def testWriteToJson(self, mockJsonDump):
2917 self.assertEqual(0, git_cl.main(['try-results', '--json', 'file.json']))
2918 git_cl._call_buildbucket.assert_called_once_with(
2919 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
2920 self._DEFAULT_REQUEST)
2921 mockJsonDump.assert_called_once_with(
2922 'file.json', self._DEFAULT_RESPONSE['builds'])
2923
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00002924 def test_filter_failed_for_one_simple(self):
2925 self.assertEqual({}, git_cl._filter_failed_for_retry([]))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002926 self.assertEqual({
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00002927 'chromium/try': {
2928 'bot_failure': [],
2929 'bot_infra_failure': []
2930 },
2931 }, git_cl._filter_failed_for_retry(self._DEFAULT_RESPONSE['builds']))
2932
2933 def test_filter_failed_for_retry_many_builds(self):
2934
2935 def _build(name, created_sec, status, experimental=False):
2936 assert 0 <= created_sec < 100, created_sec
2937 b = {
2938 'id': 112112,
2939 'builder': {
2940 'project': 'chromium',
2941 'bucket': 'try',
2942 'builder': name,
2943 },
2944 'createTime': '2019-10-09T08:00:%02d.854286Z' % created_sec,
2945 'status': status,
2946 'tags': [],
2947 }
2948 if experimental:
2949 b['tags'].append({'key': 'cq_experimental', 'value': 'true'})
2950 return b
2951
2952 builds = [
2953 _build('flaky-last-green', 1, 'FAILURE'),
2954 _build('flaky-last-green', 2, 'SUCCESS'),
2955 _build('flaky', 1, 'SUCCESS'),
2956 _build('flaky', 2, 'FAILURE'),
2957 _build('running', 1, 'FAILED'),
2958 _build('running', 2, 'SCHEDULED'),
2959 _build('yep-still-running', 1, 'STARTED'),
2960 _build('yep-still-running', 2, 'FAILURE'),
2961 _build('cq-experimental', 1, 'SUCCESS', experimental=True),
2962 _build('cq-experimental', 2, 'FAILURE', experimental=True),
2963
2964 # Simulate experimental in CQ builder, which developer decided
2965 # to retry manually which resulted in 2nd build non-experimental.
2966 _build('sometimes-experimental', 1, 'FAILURE', experimental=True),
2967 _build('sometimes-experimental', 2, 'FAILURE', experimental=False),
2968 ]
2969 builds.sort(key=lambda b: b['status']) # ~deterministic shuffle.
2970 self.assertEqual({
2971 'chromium/try': {
2972 'flaky': [],
2973 'sometimes-experimental': []
2974 },
2975 }, git_cl._filter_failed_for_retry(builds))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002976
2977
2978class CMDTryTestCase(CMDTestCaseBase):
2979
2980 @mock.patch('git_cl.Changelist.SetCQState')
2981 @mock.patch('git_cl._get_bucket_map', return_value={})
2982 def testSetCQDryRunByDefault(self, _mockGetBucketMap, mockSetCQState):
2983 mockSetCQState.return_value = 0
Edward Lemur4c707a22019-09-24 21:13:43 +00002984 self.assertEqual(0, git_cl.main(['try']))
2985 git_cl.Changelist.SetCQState.assert_called_with(git_cl._CQState.DRY_RUN)
2986 self.assertEqual(
2987 sys.stdout.getvalue(),
2988 'Scheduling CQ dry run on: '
2989 'https://chromium-review.googlesource.com/123456\n')
2990
Edward Lemur4c707a22019-09-24 21:13:43 +00002991 @mock.patch('git_cl._call_buildbucket')
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002992 def testScheduleOnBuildbucket(self, mockCallBuildbucket):
Edward Lemur4c707a22019-09-24 21:13:43 +00002993 mockCallBuildbucket.return_value = {}
Edward Lemur4c707a22019-09-24 21:13:43 +00002994
2995 self.assertEqual(0, git_cl.main([
2996 'try', '-B', 'luci.chromium.try', '-b', 'win',
2997 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
2998 self.assertIn(
2999 'Scheduling jobs on:\nBucket: luci.chromium.try',
3000 git_cl.sys.stdout.getvalue())
3001
3002 expected_request = {
3003 "requests": [{
3004 "scheduleBuild": {
3005 "requestId": "uuid4",
3006 "builder": {
3007 "project": "chromium",
3008 "builder": "win",
3009 "bucket": "try",
3010 },
3011 "gerritChanges": [{
3012 "project": "depot_tools",
3013 "host": "chromium-review.googlesource.com",
3014 "patchset": 7,
3015 "change": 123456,
3016 }],
3017 "properties": {
3018 "category": "git_cl_try",
3019 "json": [{"a": 1}, None],
3020 "key": "val",
3021 },
3022 "tags": [
3023 {"value": "win", "key": "builder"},
3024 {"value": "git_cl_try", "key": "user_agent"},
3025 ],
3026 },
3027 }],
3028 }
3029 mockCallBuildbucket.assert_called_with(
3030 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3031
Anthony Polito1a5fe232020-01-24 23:17:52 +00003032 @mock.patch('git_cl._call_buildbucket')
3033 def testScheduleOnBuildbucketWithRevision(self, mockCallBuildbucket):
3034 mockCallBuildbucket.return_value = {}
3035
3036 self.assertEqual(0, git_cl.main([
3037 'try', '-B', 'luci.chromium.try', '-b', 'win', '-b', 'linux',
3038 '-p', 'key=val', '-p', 'json=[{"a":1}, null]',
3039 '-r', 'beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef']))
3040 self.assertIn(
3041 'Scheduling jobs on:\nBucket: luci.chromium.try',
3042 git_cl.sys.stdout.getvalue())
3043
3044 expected_request = {
3045 "requests": [{
3046 "scheduleBuild": {
3047 "requestId": "uuid4",
3048 "builder": {
3049 "project": "chromium",
3050 "builder": "linux",
3051 "bucket": "try",
3052 },
3053 "gerritChanges": [{
3054 "project": "depot_tools",
3055 "host": "chromium-review.googlesource.com",
3056 "patchset": 7,
3057 "change": 123456,
3058 }],
3059 "properties": {
3060 "category": "git_cl_try",
3061 "json": [{"a": 1}, None],
3062 "key": "val",
3063 },
3064 "tags": [
3065 {"value": "linux", "key": "builder"},
3066 {"value": "git_cl_try", "key": "user_agent"},
3067 ],
3068 "gitilesCommit": {
3069 "host": "chromium-review.googlesource.com",
3070 "project": "depot_tools",
3071 "id": "beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef",
3072 }
3073 },
3074 },
3075 {
3076 "scheduleBuild": {
3077 "requestId": "uuid4",
3078 "builder": {
3079 "project": "chromium",
3080 "builder": "win",
3081 "bucket": "try",
3082 },
3083 "gerritChanges": [{
3084 "project": "depot_tools",
3085 "host": "chromium-review.googlesource.com",
3086 "patchset": 7,
3087 "change": 123456,
3088 }],
3089 "properties": {
3090 "category": "git_cl_try",
3091 "json": [{"a": 1}, None],
3092 "key": "val",
3093 },
3094 "tags": [
3095 {"value": "win", "key": "builder"},
3096 {"value": "git_cl_try", "key": "user_agent"},
3097 ],
3098 "gitilesCommit": {
3099 "host": "chromium-review.googlesource.com",
3100 "project": "depot_tools",
3101 "id": "beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef",
3102 }
3103 },
3104 }],
3105 }
3106 mockCallBuildbucket.assert_called_with(
3107 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3108
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003109 def testScheduleOnBuildbucket_WrongBucket(self):
Edward Lemur4c707a22019-09-24 21:13:43 +00003110 self.assertEqual(0, git_cl.main([
3111 'try', '-B', 'not-a-bucket', '-b', 'win',
3112 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
3113 self.assertIn(
3114 'WARNING Could not parse bucket "not-a-bucket". Skipping.',
3115 git_cl.sys.stdout.getvalue())
3116
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003117 @mock.patch('git_cl._call_buildbucket')
3118 @mock.patch('git_cl.fetch_try_jobs')
3119 def testScheduleOnBuildbucketRetryFailed(
3120 self, mockFetchTryJobs, mockCallBuildbucket):
3121
3122 git_cl.fetch_try_jobs.side_effect = lambda *_, **kw: {
3123 7: [],
3124 6: [{
3125 'id': 112112,
3126 'builder': {
3127 'project': 'chromium',
3128 'bucket': 'try',
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003129 'builder': 'linux',},
3130 'createTime': '2019-10-09T08:00:01.854286Z',
3131 'tags': [],
3132 'status': 'FAILURE',}],}[kw['patchset']]
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003133 mockCallBuildbucket.return_value = {}
3134
3135 self.assertEqual(0, git_cl.main(['try', '--retry-failed']))
3136 self.assertIn(
3137 'Scheduling jobs on:\nBucket: chromium/try',
3138 git_cl.sys.stdout.getvalue())
3139
3140 expected_request = {
3141 "requests": [{
3142 "scheduleBuild": {
3143 "requestId": "uuid4",
3144 "builder": {
3145 "project": "chromium",
3146 "bucket": "try",
3147 "builder": "linux",
3148 },
3149 "gerritChanges": [{
3150 "project": "depot_tools",
3151 "host": "chromium-review.googlesource.com",
3152 "patchset": 7,
3153 "change": 123456,
3154 }],
3155 "properties": {
3156 "category": "git_cl_try",
3157 },
3158 "tags": [
3159 {"value": "linux", "key": "builder"},
3160 {"value": "git_cl_try", "key": "user_agent"},
3161 {"value": "1", "key": "retry_failed"},
3162 ],
3163 },
3164 }],
3165 }
3166 mockCallBuildbucket.assert_called_with(
3167 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3168
Edward Lemur4c707a22019-09-24 21:13:43 +00003169 def test_parse_bucket(self):
3170 test_cases = [
3171 {
3172 'bucket': 'chromium/try',
3173 'result': ('chromium', 'try'),
3174 },
3175 {
3176 'bucket': 'luci.chromium.try',
3177 'result': ('chromium', 'try'),
3178 'has_warning': True,
3179 },
3180 {
3181 'bucket': 'skia.primary',
3182 'result': ('skia', 'skia.primary'),
3183 'has_warning': True,
3184 },
3185 {
3186 'bucket': 'not-a-bucket',
3187 'result': (None, None),
3188 },
3189 ]
3190
3191 for test_case in test_cases:
3192 git_cl.sys.stdout.truncate(0)
3193 self.assertEqual(
3194 test_case['result'], git_cl._parse_bucket(test_case['bucket']))
3195 if test_case.get('has_warning'):
Edward Lemur6215c792019-10-03 21:59:05 +00003196 expected_warning = 'WARNING Please use %s/%s to specify the bucket' % (
3197 test_case['result'])
3198 self.assertIn(expected_warning, git_cl.sys.stdout.getvalue())
Edward Lemur4c707a22019-09-24 21:13:43 +00003199
3200
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003201class CMDUploadTestCase(CMDTestCaseBase):
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003202 def setUp(self):
3203 super(CMDUploadTestCase, self).setUp()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003204 mock.patch('git_cl.fetch_try_jobs').start()
3205 mock.patch('git_cl._trigger_try_jobs', return_value={}).start()
3206 mock.patch('git_cl.Changelist.CMDUpload', return_value=0).start()
Anthony Polito46689b02019-11-15 20:56:41 +00003207 mock.patch('git_cl.Settings.GetIsGerrit', return_value=True).start()
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003208 self.addCleanup(mock.patch.stopall)
3209
Edward Lesmes7677e5c2020-02-19 20:39:03 +00003210 def testWarmUpChangeDetailCache(self):
3211 self.assertEqual(0, git_cl.main(['upload']))
3212 gerrit_util.GetChangeDetail.assert_called_once_with(
3213 'chromium-review.googlesource.com', 'depot_tools~123456',
3214 frozenset([
3215 'LABELS', 'CURRENT_REVISION', 'DETAILED_ACCOUNTS',
3216 'CURRENT_COMMIT']))
3217
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003218 def testUploadRetryFailed(self):
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003219 # This test mocks out the actual upload part, and just asserts that after
3220 # upload, if --retry-failed is added, then the tool will fetch try jobs
3221 # from the previous patchset and trigger the right builders on the latest
3222 # patchset.
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003223 git_cl.fetch_try_jobs.side_effect = [
3224 # Latest patchset: No builds.
3225 [],
3226 # Patchset before latest: Some builds.
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003227 [{
3228 'id': str(100 + idx),
3229 'builder': {
3230 'project': 'chromium',
3231 'bucket': 'try',
3232 'builder': 'bot_' + status.lower(),
3233 },
3234 'createTime': '2019-10-09T08:00:0%d.854286Z' % (idx % 10),
3235 'tags': [],
3236 'status': status,
3237 } for idx, status in enumerate(self._STATUSES)],
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +00003238 ]
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003239
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003240 self.assertEqual(0, git_cl.main(['upload', '--retry-failed']))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003241 self.assertEqual([
Edward Lemur5b929a42019-10-21 17:57:39 +00003242 mock.call(mock.ANY, 'cr-buildbucket.appspot.com', patchset=7),
3243 mock.call(mock.ANY, 'cr-buildbucket.appspot.com', patchset=6),
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003244 ], git_cl.fetch_try_jobs.mock_calls)
3245 expected_buckets = {
3246 'chromium/try': {'bot_failure': [], 'bot_infra_failure': []},
3247 }
3248 git_cl._trigger_try_jobs.assert_called_once_with(
Edward Lemur5b929a42019-10-21 17:57:39 +00003249 mock.ANY, expected_buckets, mock.ANY, 8)
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003250
Brian Sheedy59b06a82019-10-14 17:03:29 +00003251
Edward Lemurda4b6c62020-02-13 00:28:40 +00003252class CMDFormatTestCase(unittest.TestCase):
Brian Sheedy59b06a82019-10-14 17:03:29 +00003253
3254 def setUp(self):
3255 super(CMDFormatTestCase, self).setUp()
Jamie Madill5e96ad12020-01-13 16:08:35 +00003256 mock.patch('git_cl.RunCommand').start()
3257 mock.patch('clang_format.FindClangFormatToolInChromiumTree').start()
3258 mock.patch('clang_format.FindClangFormatScriptInChromiumTree').start()
3259 mock.patch('git_cl.settings').start()
Brian Sheedy59b06a82019-10-14 17:03:29 +00003260 self._top_dir = tempfile.mkdtemp()
Jamie Madill5e96ad12020-01-13 16:08:35 +00003261 self.addCleanup(mock.patch.stopall)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003262
3263 def tearDown(self):
3264 shutil.rmtree(self._top_dir)
3265 super(CMDFormatTestCase, self).tearDown()
3266
Jamie Madill5e96ad12020-01-13 16:08:35 +00003267 def _make_temp_file(self, fname, contents):
3268 with open(os.path.join(self._top_dir, fname), 'w') as tf:
3269 tf.write('\n'.join(contents))
3270
Brian Sheedy59b06a82019-10-14 17:03:29 +00003271 def _make_yapfignore(self, contents):
Jamie Madill5e96ad12020-01-13 16:08:35 +00003272 self._make_temp_file('.yapfignore', contents)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003273
Brian Sheedyb4307d52019-12-02 19:18:17 +00003274 def _check_yapf_filtering(self, files, expected):
3275 self.assertEqual(expected, git_cl._FilterYapfIgnoredFiles(
3276 files, git_cl._GetYapfIgnorePatterns(self._top_dir)))
Brian Sheedy59b06a82019-10-14 17:03:29 +00003277
Jamie Madill5e96ad12020-01-13 16:08:35 +00003278 def testClangFormatDiffFull(self):
3279 self._make_temp_file('test.cc', ['// test'])
3280 git_cl.settings.GetFormatFullByDefault.return_value = False
3281 diff_file = [os.path.join(self._top_dir, 'test.cc')]
3282 mock_opts = mock.Mock(full=True, dry_run=True, diff=False)
3283
3284 # Diff
3285 git_cl.RunCommand.return_value = ' // test'
3286 return_value = git_cl._RunClangFormatDiff(mock_opts, diff_file,
3287 self._top_dir, 'HEAD')
3288 self.assertEqual(2, return_value)
3289
3290 # No diff
3291 git_cl.RunCommand.return_value = '// test'
3292 return_value = git_cl._RunClangFormatDiff(mock_opts, diff_file,
3293 self._top_dir, 'HEAD')
3294 self.assertEqual(0, return_value)
3295
3296 def testClangFormatDiff(self):
3297 git_cl.settings.GetFormatFullByDefault.return_value = False
3298 mock_opts = mock.Mock(full=False, dry_run=True, diff=False)
3299
3300 # Diff
3301 git_cl.RunCommand.return_value = 'error'
3302 return_value = git_cl._RunClangFormatDiff(mock_opts, ['.'], self._top_dir,
3303 'HEAD')
3304 self.assertEqual(2, return_value)
3305
3306 # No diff
3307 git_cl.RunCommand.return_value = ''
3308 return_value = git_cl._RunClangFormatDiff(mock_opts, ['.'], self._top_dir,
3309 'HEAD')
3310 self.assertEqual(0, return_value)
3311
Brian Sheedyb4307d52019-12-02 19:18:17 +00003312 def testYapfignoreExplicit(self):
3313 self._make_yapfignore(['foo/bar.py', 'foo/bar/baz.py'])
3314 files = [
3315 'bar.py',
3316 'foo/bar.py',
3317 'foo/baz.py',
3318 'foo/bar/baz.py',
3319 'foo/bar/foobar.py',
3320 ]
3321 expected = [
3322 'bar.py',
3323 'foo/baz.py',
3324 'foo/bar/foobar.py',
3325 ]
3326 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003327
Brian Sheedyb4307d52019-12-02 19:18:17 +00003328 def testYapfignoreSingleWildcards(self):
3329 self._make_yapfignore(['*bar.py', 'foo*', 'baz*.py'])
3330 files = [
3331 'bar.py', # Matched by *bar.py.
3332 'bar.txt',
3333 'foobar.py', # Matched by *bar.py, foo*.
3334 'foobar.txt', # Matched by foo*.
3335 'bazbar.py', # Matched by *bar.py, baz*.py.
3336 'bazbar.txt',
3337 'foo/baz.txt', # Matched by foo*.
3338 'bar/bar.py', # Matched by *bar.py.
3339 'baz/foo.py', # Matched by baz*.py, foo*.
3340 'baz/foo.txt',
3341 ]
3342 expected = [
3343 'bar.txt',
3344 'bazbar.txt',
3345 'baz/foo.txt',
3346 ]
3347 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003348
Brian Sheedyb4307d52019-12-02 19:18:17 +00003349 def testYapfignoreMultiplewildcards(self):
3350 self._make_yapfignore(['*bar*', '*foo*baz.txt'])
3351 files = [
3352 'bar.py', # Matched by *bar*.
3353 'bar.txt', # Matched by *bar*.
3354 'abar.py', # Matched by *bar*.
3355 'foobaz.txt', # Matched by *foo*baz.txt.
3356 'foobaz.py',
3357 'afoobaz.txt', # Matched by *foo*baz.txt.
3358 ]
3359 expected = [
3360 'foobaz.py',
3361 ]
3362 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003363
3364 def testYapfignoreComments(self):
3365 self._make_yapfignore(['test.py', '#test2.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003366 files = [
3367 'test.py',
3368 'test2.py',
3369 ]
3370 expected = [
3371 'test2.py',
3372 ]
3373 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003374
3375 def testYapfignoreBlankLines(self):
3376 self._make_yapfignore(['test.py', '', '', 'test2.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003377 files = [
3378 'test.py',
3379 'test2.py',
3380 'test3.py',
3381 ]
3382 expected = [
3383 'test3.py',
3384 ]
3385 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003386
3387 def testYapfignoreWhitespace(self):
3388 self._make_yapfignore([' test.py '])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003389 files = [
3390 'test.py',
3391 'test2.py',
3392 ]
3393 expected = [
3394 'test2.py',
3395 ]
3396 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003397
Brian Sheedyb4307d52019-12-02 19:18:17 +00003398 def testYapfignoreNoFiles(self):
Brian Sheedy59b06a82019-10-14 17:03:29 +00003399 self._make_yapfignore(['test.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003400 self._check_yapf_filtering([], [])
3401
3402 def testYapfignoreMissingYapfignore(self):
3403 files = [
3404 'test.py',
3405 ]
3406 expected = [
3407 'test.py',
3408 ]
3409 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003410
3411
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003412if __name__ == '__main__':
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +01003413 logging.basicConfig(
3414 level=logging.DEBUG if '-v' in sys.argv else logging.ERROR)
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003415 unittest.main()