blob: 2fa71c0fa949be59b8722a5a5a2501f92909e4c0 [file] [log] [blame]
maruel@chromium.org725f1c32011-04-01 20:24:54 +00001#!/usr/bin/env python
maruel@chromium.org3bbf2942012-01-10 16:52:06 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Enables directory-specific presubmit checks to run at upload and/or commit.
7"""
8
Raul Tambre80ee78e2019-05-06 22:41:05 +00009from __future__ import print_function
10
stip@chromium.orgf7d31f52014-01-03 20:14:46 +000011__version__ = '1.8.0'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000012
13# TODO(joi) Add caching where appropriate/needed. The API is designed to allow
14# caching (between all different invocations of presubmit scripts for a given
15# change). We should add it as our presubmit scripts start feeling slow.
16
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +090017import ast # Exposed through the API.
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +000018import contextlib
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +000019import cpplint
dcheng091b7db2016-06-16 01:27:51 -070020import fnmatch # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000021import glob
asvitkine@chromium.org15169952011-09-27 14:30:53 +000022import inspect
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +000023import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000024import json # Exposed through the API.
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +000025import logging
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000026import multiprocessing
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000027import optparse
28import os # Somewhat exposed through the API.
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000029import random
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000030import re # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040031import signal
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000032import sys # Parts exposed through API.
33import tempfile # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040034import threading
jam@chromium.org2a891dc2009-08-20 20:33:37 +000035import time
Edward Lemurd2a5a4c2019-10-23 22:55:26 +000036import types
Edward Lemurde9e3ca2019-10-24 21:13:31 +000037import traceback
maruel@chromium.org1487d532009-06-06 00:22:57 +000038import unittest # Exposed through the API.
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000039from warnings import warn
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000040
41# Local imports.
maruel@chromium.org35625c72011-03-23 17:34:02 +000042import fix_encoding
Yoshisato Yanagisawa04600b42019-03-15 03:03:41 +000043import gclient_paths # Exposed through the API
44import gclient_utils
Aaron Gableb584c4f2017-04-26 16:28:08 -070045import git_footers
tandrii@chromium.org015ebae2016-04-25 19:37:22 +000046import gerrit_util
dpranke@chromium.org2a009622011-03-01 02:43:31 +000047import owners
Jochen Eisinger76f5fc62017-04-07 16:27:46 +020048import owners_finder
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000049import presubmit_canned_checks
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +000050import scm
maruel@chromium.org84f4fe32011-04-06 13:26:45 +000051import subprocess2 as subprocess # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000052
Edward Lemur16af3562019-10-17 22:11:33 +000053if sys.version_info.major == 2:
54 # TODO(1009814): Expose urllib2 only through urllib_request and urllib_error
55 import urllib2 # Exposed through the API.
56 import urlparse
57 import urllib2 as urllib_request
58 import urllib2 as urllib_error
59else:
60 import urllib.parse as urlparse
61 import urllib.request as urllib_request
62 import urllib.error as urllib_error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000063
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000064# Ask for feedback only once in program lifetime.
65_ASKED_FOR_FEEDBACK = False
66
67
maruel@chromium.org899e1c12011-04-07 17:03:18 +000068class PresubmitFailure(Exception):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000069 pass
70
71
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000072class CommandData(object):
Edward Lemur940c2822019-08-23 00:34:25 +000073 def __init__(self, name, cmd, kwargs, message, python3=False):
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000074 self.name = name
75 self.cmd = cmd
Edward Lesmes8e282792018-04-03 18:50:29 -040076 self.stdin = kwargs.get('stdin', None)
Edward Lemur2d6b67c2019-08-23 22:25:41 +000077 self.kwargs = kwargs.copy()
Edward Lesmes8e282792018-04-03 18:50:29 -040078 self.kwargs['stdout'] = subprocess.PIPE
79 self.kwargs['stderr'] = subprocess.STDOUT
80 self.kwargs['stdin'] = subprocess.PIPE
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000081 self.message = message
82 self.info = None
Edward Lemur940c2822019-08-23 00:34:25 +000083 self.python3 = python3
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000084
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000085
Edward Lesmes8e282792018-04-03 18:50:29 -040086# Adapted from
87# https://github.com/google/gtest-parallel/blob/master/gtest_parallel.py#L37
88#
89# An object that catches SIGINT sent to the Python process and notices
90# if processes passed to wait() die by SIGINT (we need to look for
91# both of those cases, because pressing Ctrl+C can result in either
92# the main process or one of the subprocesses getting the signal).
93#
94# Before a SIGINT is seen, wait(p) will simply call p.wait() and
95# return the result. Once a SIGINT has been seen (in the main process
96# or a subprocess, including the one the current call is waiting for),
Edward Lemur9a5bb612019-09-26 02:01:52 +000097# wait(p) will call p.terminate().
Edward Lesmes8e282792018-04-03 18:50:29 -040098class SigintHandler(object):
Edward Lesmes8e282792018-04-03 18:50:29 -040099 sigint_returncodes = {-signal.SIGINT, # Unix
100 -1073741510, # Windows
101 }
102 def __init__(self):
103 self.__lock = threading.Lock()
104 self.__processes = set()
105 self.__got_sigint = False
Edward Lemur9a5bb612019-09-26 02:01:52 +0000106 self.__previous_signal = signal.signal(signal.SIGINT, self.interrupt)
Edward Lesmes8e282792018-04-03 18:50:29 -0400107
108 def __on_sigint(self):
109 self.__got_sigint = True
110 while self.__processes:
111 try:
112 self.__processes.pop().terminate()
113 except OSError:
114 pass
115
Edward Lemur9a5bb612019-09-26 02:01:52 +0000116 def interrupt(self, signal_num, frame):
Edward Lesmes8e282792018-04-03 18:50:29 -0400117 with self.__lock:
118 self.__on_sigint()
Edward Lemur9a5bb612019-09-26 02:01:52 +0000119 self.__previous_signal(signal_num, frame)
Edward Lesmes8e282792018-04-03 18:50:29 -0400120
121 def got_sigint(self):
122 with self.__lock:
123 return self.__got_sigint
124
125 def wait(self, p, stdin):
126 with self.__lock:
127 if self.__got_sigint:
128 p.terminate()
129 self.__processes.add(p)
130 stdout, stderr = p.communicate(stdin)
131 code = p.returncode
132 with self.__lock:
133 self.__processes.discard(p)
134 if code in self.sigint_returncodes:
135 self.__on_sigint()
Edward Lesmes8e282792018-04-03 18:50:29 -0400136 return stdout, stderr
137
138sigint_handler = SigintHandler()
139
140
141class ThreadPool(object):
142 def __init__(self, pool_size=None):
143 self._pool_size = pool_size or multiprocessing.cpu_count()
144 self._messages = []
145 self._messages_lock = threading.Lock()
146 self._tests = []
147 self._tests_lock = threading.Lock()
148 self._nonparallel_tests = []
149
150 def CallCommand(self, test):
151 """Runs an external program.
152
153 This function converts invocation of .py files and invocations of "python"
154 to vpython invocations.
155 """
Edward Lemur940c2822019-08-23 00:34:25 +0000156 vpython = 'vpython'
157 if test.python3:
158 vpython += '3'
159 if sys.platform == 'win32':
160 vpython += '.bat'
Edward Lesmes8e282792018-04-03 18:50:29 -0400161
162 cmd = test.cmd
163 if cmd[0] == 'python':
164 cmd = list(cmd)
165 cmd[0] = vpython
166 elif cmd[0].endswith('.py'):
167 cmd = [vpython] + cmd
168
169 try:
170 start = time.time()
171 p = subprocess.Popen(cmd, **test.kwargs)
172 stdout, _ = sigint_handler.wait(p, test.stdin)
173 duration = time.time() - start
174 except OSError as e:
175 duration = time.time() - start
176 return test.message(
177 '%s exec failure (%4.2fs)\n %s' % (test.name, duration, e))
Edward Lemurde9e3ca2019-10-24 21:13:31 +0000178 except Exception as e:
179 duration = time.time() - start
180 return test.message(
181 '%s exec failure (%4.2fs)\n%s' % (
182 test.name, duration, traceback.format_exc()))
183
Edward Lesmes8e282792018-04-03 18:50:29 -0400184 if p.returncode != 0:
185 return test.message(
186 '%s (%4.2fs) failed\n%s' % (test.name, duration, stdout))
187 if test.info:
188 return test.info('%s (%4.2fs)' % (test.name, duration))
189
190 def AddTests(self, tests, parallel=True):
191 if parallel:
192 self._tests.extend(tests)
193 else:
194 self._nonparallel_tests.extend(tests)
195
196 def RunAsync(self):
197 self._messages = []
198
199 def _WorkerFn():
200 while True:
201 test = None
202 with self._tests_lock:
203 if not self._tests:
204 break
205 test = self._tests.pop()
206 result = self.CallCommand(test)
207 if result:
208 with self._messages_lock:
209 self._messages.append(result)
210
211 def _StartDaemon():
212 t = threading.Thread(target=_WorkerFn)
213 t.daemon = True
214 t.start()
215 return t
216
217 while self._nonparallel_tests:
218 test = self._nonparallel_tests.pop()
219 result = self.CallCommand(test)
220 if result:
221 self._messages.append(result)
222
223 if self._tests:
224 threads = [_StartDaemon() for _ in range(self._pool_size)]
225 for worker in threads:
226 worker.join()
227
228 return self._messages
229
230
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000231def normpath(path):
232 '''Version of os.path.normpath that also changes backward slashes to
233 forward slashes when not running on Windows.
234 '''
235 # This is safe to always do because the Windows version of os.path.normpath
236 # will replace forward slashes with backward slashes.
237 path = path.replace(os.sep, '/')
238 return os.path.normpath(path)
239
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000240
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000241def _RightHandSideLinesImpl(affected_files):
242 """Implements RightHandSideLines for InputApi and GclChange."""
243 for af in affected_files:
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000244 lines = af.ChangedContents()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000245 for line in lines:
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000246 yield (af, line[0], line[1])
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000247
248
dpranke@chromium.org5ac21012011-03-16 02:58:25 +0000249class PresubmitOutput(object):
250 def __init__(self, input_stream=None, output_stream=None):
251 self.input_stream = input_stream
252 self.output_stream = output_stream
253 self.reviewers = []
Daniel Cheng7227d212017-11-17 08:12:37 -0800254 self.more_cc = []
dpranke@chromium.org5ac21012011-03-16 02:58:25 +0000255 self.written_output = []
256 self.error_count = 0
257
258 def prompt_yes_no(self, prompt_string):
259 self.write(prompt_string)
260 if self.input_stream:
261 response = self.input_stream.readline().strip().lower()
262 if response not in ('y', 'yes'):
263 self.fail()
264 else:
265 self.fail()
266
267 def fail(self):
268 self.error_count += 1
269
270 def should_continue(self):
271 return not self.error_count
272
273 def write(self, s):
274 self.written_output.append(s)
275 if self.output_stream:
276 self.output_stream.write(s)
277
278 def getvalue(self):
279 return ''.join(self.written_output)
280
281
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000282# Top level object so multiprocessing can pickle
283# Public access through OutputApi object.
284class _PresubmitResult(object):
285 """Base class for result objects."""
286 fatal = False
287 should_prompt = False
288
289 def __init__(self, message, items=None, long_text=''):
290 """
291 message: A short one-line message to indicate errors.
292 items: A list of short strings to indicate where errors occurred.
293 long_text: multi-line text output, e.g. from another tool
294 """
295 self._message = message
296 self._items = items or []
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000297 self._long_text = long_text.rstrip()
298
299 def handle(self, output):
300 output.write(self._message)
301 output.write('\n')
302 for index, item in enumerate(self._items):
303 output.write(' ')
304 # Write separately in case it's unicode.
305 output.write(str(item))
306 if index < len(self._items) - 1:
307 output.write(' \\')
308 output.write('\n')
309 if self._long_text:
310 output.write('\n***************\n')
311 # Write separately in case it's unicode.
312 output.write(self._long_text)
313 output.write('\n***************\n')
314 if self.fatal:
315 output.fail()
316
Debrian Figueroadd2737e2019-06-21 23:50:13 +0000317 def json_format(self):
318 return {
319 'message': self._message,
Debrian Figueroa6095d402019-06-28 18:47:18 +0000320 'items': [str(item) for item in self._items],
Debrian Figueroadd2737e2019-06-21 23:50:13 +0000321 'long_text': self._long_text,
322 'fatal': self.fatal
323 }
324
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000325
326# Top level object so multiprocessing can pickle
327# Public access through OutputApi object.
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000328class _PresubmitError(_PresubmitResult):
329 """A hard presubmit error."""
330 fatal = True
331
332
333# Top level object so multiprocessing can pickle
334# Public access through OutputApi object.
335class _PresubmitPromptWarning(_PresubmitResult):
336 """An warning that prompts the user if they want to continue."""
337 should_prompt = True
338
339
340# Top level object so multiprocessing can pickle
341# Public access through OutputApi object.
342class _PresubmitNotifyResult(_PresubmitResult):
343 """Just print something to the screen -- but it's not even a warning."""
344 pass
345
346
347# Top level object so multiprocessing can pickle
348# Public access through OutputApi object.
349class _MailTextResult(_PresubmitResult):
350 """A warning that should be included in the review request email."""
351 def __init__(self, *args, **kwargs):
352 super(_MailTextResult, self).__init__()
353 raise NotImplementedError()
354
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000355class GerritAccessor(object):
356 """Limited Gerrit functionality for canned presubmit checks to work.
357
358 To avoid excessive Gerrit calls, caches the results.
359 """
360
361 def __init__(self, host):
362 self.host = host
363 self.cache = {}
364
365 def _FetchChangeDetail(self, issue):
366 # Separate function to be easily mocked in tests.
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100367 try:
368 return gerrit_util.GetChangeDetail(
369 self.host, str(issue),
Aaron Gable6f5a8d92017-04-18 14:49:05 -0700370 ['ALL_REVISIONS', 'DETAILED_LABELS', 'ALL_COMMITS'])
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100371 except gerrit_util.GerritError as e:
372 if e.http_status == 404:
373 raise Exception('Either Gerrit issue %s doesn\'t exist, or '
374 'no credentials to fetch issue details' % issue)
375 raise
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000376
377 def GetChangeInfo(self, issue):
378 """Returns labels and all revisions (patchsets) for this issue.
379
380 The result is a dictionary according to Gerrit REST Api.
381 https://gerrit-review.googlesource.com/Documentation/rest-api.html
382
383 However, API isn't very clear what's inside, so see tests for example.
384 """
385 assert issue
386 cache_key = int(issue)
387 if cache_key not in self.cache:
388 self.cache[cache_key] = self._FetchChangeDetail(issue)
389 return self.cache[cache_key]
390
391 def GetChangeDescription(self, issue, patchset=None):
392 """If patchset is none, fetches current patchset."""
393 info = self.GetChangeInfo(issue)
394 # info is a reference to cache. We'll modify it here adding description to
395 # it to the right patchset, if it is not yet there.
396
397 # Find revision info for the patchset we want.
398 if patchset is not None:
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +0000399 for rev, rev_info in info['revisions'].items():
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000400 if str(rev_info['_number']) == str(patchset):
401 break
402 else:
403 raise Exception('patchset %s doesn\'t exist in issue %s' % (
404 patchset, issue))
405 else:
406 rev = info['current_revision']
407 rev_info = info['revisions'][rev]
408
Andrii Shyshkalov9c3a4642017-01-24 17:41:22 +0100409 return rev_info['commit']['message']
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000410
Mun Yong Jang603d01e2017-12-19 16:38:30 -0800411 def GetDestRef(self, issue):
412 ref = self.GetChangeInfo(issue)['branch']
413 if not ref.startswith('refs/'):
414 # NOTE: it is possible to create 'refs/x' branch,
415 # aka 'refs/heads/refs/x'. However, this is ill-advised.
416 ref = 'refs/heads/%s' % ref
417 return ref
418
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000419 def GetChangeOwner(self, issue):
420 return self.GetChangeInfo(issue)['owner']['email']
421
422 def GetChangeReviewers(self, issue, approving_only=True):
Aaron Gable8b478f02017-07-31 15:33:19 -0700423 changeinfo = self.GetChangeInfo(issue)
424 if approving_only:
425 labelinfo = changeinfo.get('labels', {}).get('Code-Review', {})
426 values = labelinfo.get('values', {}).keys()
427 try:
428 max_value = max(int(v) for v in values)
429 reviewers = [r for r in labelinfo.get('all', [])
430 if r.get('value', 0) == max_value]
431 except ValueError: # values is the empty list
432 reviewers = []
433 else:
434 reviewers = changeinfo.get('reviewers', {}).get('REVIEWER', [])
435 return [r.get('email') for r in reviewers]
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000436
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000437
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000438class OutputApi(object):
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000439 """An instance of OutputApi gets passed to presubmit scripts so that they
440 can output various types of results.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000441 """
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000442 PresubmitResult = _PresubmitResult
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000443 PresubmitError = _PresubmitError
444 PresubmitPromptWarning = _PresubmitPromptWarning
445 PresubmitNotifyResult = _PresubmitNotifyResult
446 MailTextResult = _MailTextResult
447
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000448 def __init__(self, is_committing):
449 self.is_committing = is_committing
Daniel Cheng7227d212017-11-17 08:12:37 -0800450 self.more_cc = []
451
452 def AppendCC(self, cc):
453 """Appends a user to cc for this change."""
454 self.more_cc.append(cc)
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000455
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000456 def PresubmitPromptOrNotify(self, *args, **kwargs):
457 """Warn the user when uploading, but only notify if committing."""
458 if self.is_committing:
459 return self.PresubmitNotifyResult(*args, **kwargs)
460 return self.PresubmitPromptWarning(*args, **kwargs)
461
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000462
463class InputApi(object):
464 """An instance of this object is passed to presubmit scripts so they can
465 know stuff about the change they're looking at.
466 """
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000467 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800468 # pylint: disable=no-self-use
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000469
maruel@chromium.org3410d912009-06-09 20:56:16 +0000470 # File extensions that are considered source files from a style guide
471 # perspective. Don't modify this list from a presubmit script!
maruel@chromium.orgc33455a2011-06-24 19:14:18 +0000472 #
473 # Files without an extension aren't included in the list. If you want to
474 # filter them as source files, add r"(^|.*?[\\\/])[^.]+$" to the white list.
475 # Note that ALL CAPS files are black listed in DEFAULT_BLACK_LIST below.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000476 DEFAULT_WHITE_LIST = (
477 # C++ and friends
maruel@chromium.orgfe1211a2011-05-28 18:54:17 +0000478 r".+\.c$", r".+\.cc$", r".+\.cpp$", r".+\.h$", r".+\.m$", r".+\.mm$",
479 r".+\.inl$", r".+\.asm$", r".+\.hxx$", r".+\.hpp$", r".+\.s$", r".+\.S$",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000480 # Scripts
maruel@chromium.orgfe1211a2011-05-28 18:54:17 +0000481 r".+\.js$", r".+\.py$", r".+\.sh$", r".+\.rb$", r".+\.pl$", r".+\.pm$",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000482 # Other
Sergey Ulanov166bc4c2018-04-30 17:03:38 -0700483 r".+\.java$", r".+\.mk$", r".+\.am$", r".+\.css$", r".+\.mojom$",
484 r".+\.fidl$"
maruel@chromium.org3410d912009-06-09 20:56:16 +0000485 )
486
487 # Path regexp that should be excluded from being considered containing source
488 # files. Don't modify this list from a presubmit script!
489 DEFAULT_BLACK_LIST = (
gavinp@chromium.org656326d2012-08-13 00:43:57 +0000490 r"testing_support[\\\/]google_appengine[\\\/].*",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000491 r".*\bexperimental[\\\/].*",
Kent Tamura179dd1e2018-04-26 15:07:41 +0900492 # Exclude third_party/.* but NOT third_party/{WebKit,blink}
493 # (crbug.com/539768 and crbug.com/836555).
494 r".*\bthird_party[\\\/](?!(WebKit|blink)[\\\/]).*",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000495 # Output directories (just in case)
496 r".*\bDebug[\\\/].*",
497 r".*\bRelease[\\\/].*",
498 r".*\bxcodebuild[\\\/].*",
thakis@chromium.orgc1c96352013-10-09 19:50:27 +0000499 r".*\bout[\\\/].*",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000500 # All caps files like README and LICENCE.
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000501 r".*\b[A-Z0-9_]{2,}$",
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000502 # SCM (can happen in dual SCM configuration). (Slightly over aggressive)
maruel@chromium.org5d0dc432011-01-03 02:40:37 +0000503 r"(|.*[\\\/])\.git[\\\/].*",
504 r"(|.*[\\\/])\.svn[\\\/].*",
maruel@chromium.org7ccb4bb2011-11-07 20:26:20 +0000505 # There is no point in processing a patch file.
506 r".+\.diff$",
507 r".+\.patch$",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000508 )
509
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000510 def __init__(self, change, presubmit_path, is_committing,
Edward Lesmes8e282792018-04-03 18:50:29 -0400511 verbose, gerrit_obj, dry_run=None, thread_pool=None, parallel=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000512 """Builds an InputApi object.
513
514 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000515 change: A presubmit.Change object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000516 presubmit_path: The path to the presubmit script being processed.
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000517 is_committing: True if the change is about to be committed.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000518 gerrit_obj: provides basic Gerrit codereview functionality.
519 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -0400520 parallel: if true, all tests reported via input_api.RunTests for all
521 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000522 """
maruel@chromium.org9711bba2009-05-22 23:51:39 +0000523 # Version number of the presubmit_support script.
524 self.version = [int(x) for x in __version__.split('.')]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000525 self.change = change
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000526 self.is_committing = is_committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000527 self.gerrit = gerrit_obj
tandrii@chromium.org57bafac2016-04-28 05:09:03 +0000528 self.dry_run = dry_run
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000529
Edward Lesmes8e282792018-04-03 18:50:29 -0400530 self.parallel = parallel
531 self.thread_pool = thread_pool or ThreadPool()
532
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000533 # We expose various modules and functions as attributes of the input_api
534 # so that presubmit scripts don't have to import them.
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +0900535 self.ast = ast
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000536 self.basename = os.path.basename
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000537 self.cpplint = cpplint
dcheng091b7db2016-06-16 01:27:51 -0700538 self.fnmatch = fnmatch
Yoshisato Yanagisawa04600b42019-03-15 03:03:41 +0000539 self.gclient_paths = gclient_paths
Yoshisato Yanagisawa57dd17b2019-03-22 09:10:29 +0000540 # TODO(yyanagisawa): stop exposing this when python3 become default.
541 # Since python3's tempfile has TemporaryDirectory, we do not need this.
542 self.temporary_directory = gclient_utils.temporary_directory
dpranke@chromium.org17cc2442012-10-17 21:12:09 +0000543 self.glob = glob.glob
maruel@chromium.orgfb11c7b2010-03-18 18:22:14 +0000544 self.json = json
maruel@chromium.org6fba34d2011-06-02 13:45:12 +0000545 self.logging = logging.getLogger('PRESUBMIT')
maruel@chromium.org2b5ce562011-03-31 16:15:44 +0000546 self.os_listdir = os.listdir
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000547 self.os_path = os.path
pgervais@chromium.orgbd0cace2014-10-02 23:23:46 +0000548 self.os_stat = os.stat
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +0000549 self.os_walk = os.walk
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000550 self.re = re
551 self.subprocess = subprocess
552 self.tempfile = tempfile
dpranke@chromium.org0d1bdea2011-03-24 22:54:38 +0000553 self.time = time
maruel@chromium.org1487d532009-06-06 00:22:57 +0000554 self.unittest = unittest
Edward Lemurd2a5a4c2019-10-23 22:55:26 +0000555 self.urllib2 = urllib2
Edward Lemur16af3562019-10-17 22:11:33 +0000556 self.urllib_request = urllib_request
557 self.urllib_error = urllib_error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000558
Robert Iannucci50258932018-03-19 10:30:59 -0700559 self.is_windows = sys.platform == 'win32'
560
561 # Set python_executable to 'python'. This is interpreted in CallCommand to
562 # convert to vpython in order to allow scripts in other repos (e.g. src.git)
563 # to automatically pick up that repo's .vpython file, instead of inheriting
564 # the one in depot_tools.
565 self.python_executable = 'python'
maruel@chromium.orgc0b22972009-06-25 16:19:14 +0000566 self.environ = os.environ
567
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000568 # InputApi.platform is the platform you're currently running on.
569 self.platform = sys.platform
570
iannucci@chromium.org0af3bb32015-06-12 20:44:35 +0000571 self.cpu_count = multiprocessing.cpu_count()
572
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000573 # The local path of the currently-being-processed presubmit script.
maruel@chromium.org3d235242009-05-15 12:40:48 +0000574 self._current_presubmit_path = os.path.dirname(presubmit_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000575
576 # We carry the canned checks so presubmit scripts can easily use them.
577 self.canned_checks = presubmit_canned_checks
578
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100579 # Temporary files we must manually remove at the end of a run.
580 self._named_temporary_files = []
Jochen Eisinger72606f82017-04-04 10:44:18 +0200581
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000582 # TODO(dpranke): figure out a list of all approved owners for a repo
583 # in order to be able to handle wildcard OWNERS files?
584 self.owners_db = owners.Database(change.RepositoryRoot(),
Edward Lemurd2a5a4c2019-10-23 22:55:26 +0000585 fopen=file, os_path=self.os_path)
Jochen Eisinger76f5fc62017-04-07 16:27:46 +0200586 self.owners_finder = owners_finder.OwnersFinder
maruel@chromium.org899e1c12011-04-07 17:03:18 +0000587 self.verbose = verbose
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000588 self.Command = CommandData
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000589
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000590 # Replace <hash_map> and <hash_set> as headers that need to be included
danakj@chromium.org18278522013-06-11 22:42:32 +0000591 # with "base/containers/hash_tables.h" instead.
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000592 # Access to a protected member _XX of a client class
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800593 # pylint: disable=protected-access
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000594 self.cpplint._re_pattern_templates = [
danakj@chromium.org18278522013-06-11 22:42:32 +0000595 (a, b, 'base/containers/hash_tables.h')
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000596 if header in ('<hash_map>', '<hash_set>') else (a, b, header)
597 for (a, b, header) in cpplint._re_pattern_templates
598 ]
599
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000600 def PresubmitLocalPath(self):
601 """Returns the local path of the presubmit script currently being run.
602
603 This is useful if you don't want to hard-code absolute paths in the
604 presubmit script. For example, It can be used to find another file
605 relative to the PRESUBMIT.py script, so the whole tree can be branched and
606 the presubmit script still works, without editing its content.
607 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000608 return self._current_presubmit_path
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000609
agable0b65e732016-11-22 09:25:46 -0800610 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000611 """Same as input_api.change.AffectedFiles() except only lists files
612 (and optionally directories) in the same directory as the current presubmit
613 script, or subdirectories thereof.
614 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000615 dir_with_slash = normpath("%s/" % self.PresubmitLocalPath())
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000616 if len(dir_with_slash) == 1:
617 dir_with_slash = ''
sail@chromium.org5538e022011-05-12 17:53:16 +0000618
Edward Lemurd2a5a4c2019-10-23 22:55:26 +0000619 return filter(
maruel@chromium.org4661e0c2009-06-04 00:45:26 +0000620 lambda x: normpath(x.AbsoluteLocalPath()).startswith(dir_with_slash),
Edward Lemurd2a5a4c2019-10-23 22:55:26 +0000621 self.change.AffectedFiles(include_deletes, file_filter))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000622
agable0b65e732016-11-22 09:25:46 -0800623 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000624 """Returns local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800625 paths = [af.LocalPath() for af in self.AffectedFiles()]
pgervais@chromium.org2f64f782014-04-25 00:12:33 +0000626 logging.debug("LocalPaths: %s", paths)
627 return paths
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000628
agable0b65e732016-11-22 09:25:46 -0800629 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000630 """Returns absolute local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800631 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000632
John Budorick16162372018-04-18 10:39:53 -0700633 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
agable0b65e732016-11-22 09:25:46 -0800634 """Same as input_api.change.AffectedTestableFiles() except only lists files
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000635 in the same directory as the current presubmit script, or subdirectories
636 thereof.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000637 """
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000638 if include_deletes is not None:
agable0b65e732016-11-22 09:25:46 -0800639 warn("AffectedTestableFiles(include_deletes=%s)"
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000640 " is deprecated and ignored" % str(include_deletes),
641 category=DeprecationWarning,
642 stacklevel=2)
Edward Lemurd2a5a4c2019-10-23 22:55:26 +0000643 return filter(lambda x: x.IsTestableFile(),
644 self.AffectedFiles(include_deletes=False, **kwargs))
agable0b65e732016-11-22 09:25:46 -0800645
646 def AffectedTextFiles(self, include_deletes=None):
647 """An alias to AffectedTestableFiles for backwards compatibility."""
648 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000649
maruel@chromium.org3410d912009-06-09 20:56:16 +0000650 def FilterSourceFile(self, affected_file, white_list=None, black_list=None):
651 """Filters out files that aren't considered "source file".
652
653 If white_list or black_list is None, InputApi.DEFAULT_WHITE_LIST
654 and InputApi.DEFAULT_BLACK_LIST is used respectively.
655
656 The lists will be compiled as regular expression and
657 AffectedFile.LocalPath() needs to pass both list.
658
659 Note: Copy-paste this function to suit your needs or use a lambda function.
660 """
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000661 def Find(affected_file, items):
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000662 local_path = affected_file.LocalPath()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000663 for item in items:
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000664 if self.re.match(item, local_path):
maruel@chromium.org3410d912009-06-09 20:56:16 +0000665 return True
666 return False
667 return (Find(affected_file, white_list or self.DEFAULT_WHITE_LIST) and
668 not Find(affected_file, black_list or self.DEFAULT_BLACK_LIST))
669
670 def AffectedSourceFiles(self, source_file):
agable0b65e732016-11-22 09:25:46 -0800671 """Filter the list of AffectedTestableFiles by the function source_file.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000672
673 If source_file is None, InputApi.FilterSourceFile() is used.
674 """
675 if not source_file:
676 source_file = self.FilterSourceFile
Edward Lemurd2a5a4c2019-10-23 22:55:26 +0000677 return filter(source_file, self.AffectedTestableFiles())
maruel@chromium.org3410d912009-06-09 20:56:16 +0000678
679 def RightHandSideLines(self, source_file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000680 """An iterator over all text lines in "new" version of changed files.
681
682 Only lists lines from new or modified text files in the change that are
683 contained by the directory of the currently executing presubmit script.
684
685 This is useful for doing line-by-line regex checks, like checking for
686 trailing whitespace.
687
688 Yields:
689 a 3 tuple:
690 the AffectedFile instance of the current file;
691 integer line number (1-based); and
692 the contents of the line as a string.
maruel@chromium.org1487d532009-06-06 00:22:57 +0000693
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000694 Note: The carriage return (LF or CR) is stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000695 """
maruel@chromium.org3410d912009-06-09 20:56:16 +0000696 files = self.AffectedSourceFiles(source_file_filter)
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000697 return _RightHandSideLinesImpl(files)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000698
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000699 def ReadFile(self, file_item, mode='r'):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000700 """Reads an arbitrary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000701
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000702 Deny reading anything outside the repository.
703 """
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000704 if isinstance(file_item, AffectedFile):
705 file_item = file_item.AbsoluteLocalPath()
706 if not file_item.startswith(self.change.RepositoryRoot()):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000707 raise IOError('Access outside the repository root is denied.')
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +0000708 return gclient_utils.FileRead(file_item, mode)
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000709
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100710 def CreateTemporaryFile(self, **kwargs):
711 """Returns a named temporary file that must be removed with a call to
712 RemoveTemporaryFiles().
713
714 All keyword arguments are forwarded to tempfile.NamedTemporaryFile(),
715 except for |delete|, which is always set to False.
716
717 Presubmit checks that need to create a temporary file and pass it for
718 reading should use this function instead of NamedTemporaryFile(), as
719 Windows fails to open a file that is already open for writing.
720
721 with input_api.CreateTemporaryFile() as f:
722 f.write('xyz')
723 f.close()
724 input_api.subprocess.check_output(['script-that', '--reads-from',
725 f.name])
726
727
728 Note that callers of CreateTemporaryFile() should not worry about removing
729 any temporary file; this is done transparently by the presubmit handling
730 code.
731 """
732 if 'delete' in kwargs:
733 # Prevent users from passing |delete|; we take care of file deletion
734 # ourselves and this prevents unintuitive error messages when we pass
735 # delete=False and 'delete' is also in kwargs.
736 raise TypeError('CreateTemporaryFile() does not take a "delete" '
737 'argument, file deletion is handled automatically by '
738 'the same presubmit_support code that creates InputApi '
739 'objects.')
740 temp_file = self.tempfile.NamedTemporaryFile(delete=False, **kwargs)
741 self._named_temporary_files.append(temp_file.name)
742 return temp_file
743
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000744 @property
745 def tbr(self):
746 """Returns if a change is TBR'ed."""
Jeremy Romandce22502017-06-20 15:37:29 -0400747 return 'TBR' in self.change.tags or self.change.TBRsFromDescription()
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000748
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000749 def RunTests(self, tests_mix, parallel=True):
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000750 tests = []
751 msgs = []
752 for t in tests_mix:
Edward Lesmes8e282792018-04-03 18:50:29 -0400753 if isinstance(t, OutputApi.PresubmitResult) and t:
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000754 msgs.append(t)
755 else:
756 assert issubclass(t.message, _PresubmitResult)
757 tests.append(t)
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000758 if self.verbose:
759 t.info = _PresubmitNotifyResult
Edward Lemur1037c742018-05-01 18:56:04 -0400760 if not t.kwargs.get('cwd'):
761 t.kwargs['cwd'] = self.PresubmitLocalPath()
Edward Lesmes8e282792018-04-03 18:50:29 -0400762 self.thread_pool.AddTests(tests, parallel)
Edward Lemur21000eb2019-05-24 23:25:58 +0000763 # When self.parallel is True (i.e. --parallel is passed as an option)
764 # RunTests doesn't actually run tests. It adds them to a ThreadPool that
765 # will run all tests once all PRESUBMIT files are processed.
766 # Otherwise, it will run them and return the results.
767 if not self.parallel:
Edward Lesmes8e282792018-04-03 18:50:29 -0400768 msgs.extend(self.thread_pool.RunAsync())
769 return msgs
scottmg86099d72016-09-01 09:16:51 -0700770
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000771
nick@chromium.orgff526192013-06-10 19:30:26 +0000772class _DiffCache(object):
773 """Caches diffs retrieved from a particular SCM."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000774 def __init__(self, upstream=None):
775 """Stores the upstream revision against which all diffs will be computed."""
776 self._upstream = upstream
nick@chromium.orgff526192013-06-10 19:30:26 +0000777
778 def GetDiff(self, path, local_root):
779 """Get the diff for a particular path."""
780 raise NotImplementedError()
781
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700782 def GetOldContents(self, path, local_root):
783 """Get the old version for a particular path."""
784 raise NotImplementedError()
785
nick@chromium.orgff526192013-06-10 19:30:26 +0000786
nick@chromium.orgff526192013-06-10 19:30:26 +0000787class _GitDiffCache(_DiffCache):
788 """DiffCache implementation for git; gets all file diffs at once."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000789 def __init__(self, upstream):
790 super(_GitDiffCache, self).__init__(upstream=upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000791 self._diffs_by_file = None
792
793 def GetDiff(self, path, local_root):
794 if not self._diffs_by_file:
795 # Compute a single diff for all files and parse the output; should
796 # with git this is much faster than computing one diff for each file.
797 diffs = {}
798
799 # Don't specify any filenames below, because there are command line length
800 # limits on some platforms and GenerateDiff would fail.
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000801 unified_diff = scm.GIT.GenerateDiff(local_root, files=[], full_move=True,
802 branch=self._upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000803
804 # This regex matches the path twice, separated by a space. Note that
805 # filename itself may contain spaces.
806 file_marker = re.compile('^diff --git (?P<filename>.*) (?P=filename)$')
807 current_diff = []
808 keep_line_endings = True
809 for x in unified_diff.splitlines(keep_line_endings):
810 match = file_marker.match(x)
811 if match:
812 # Marks the start of a new per-file section.
813 diffs[match.group('filename')] = current_diff = [x]
814 elif x.startswith('diff --git'):
815 raise PresubmitFailure('Unexpected diff line: %s' % x)
816 else:
817 current_diff.append(x)
818
819 self._diffs_by_file = dict(
820 (normpath(path), ''.join(diff)) for path, diff in diffs.items())
821
822 if path not in self._diffs_by_file:
823 raise PresubmitFailure(
824 'Unified diff did not contain entry for file %s' % path)
825
826 return self._diffs_by_file[path]
827
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700828 def GetOldContents(self, path, local_root):
829 return scm.GIT.GetOldContents(local_root, path, branch=self._upstream)
830
nick@chromium.orgff526192013-06-10 19:30:26 +0000831
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000832class AffectedFile(object):
833 """Representation of a file in a change."""
nick@chromium.orgff526192013-06-10 19:30:26 +0000834
835 DIFF_CACHE = _DiffCache
836
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000837 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800838 # pylint: disable=no-self-use
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000839 def __init__(self, path, action, repository_root, diff_cache):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000840 self._path = path
841 self._action = action
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000842 self._local_root = repository_root
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000843 self._is_directory = None
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000844 self._cached_changed_contents = None
845 self._cached_new_contents = None
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000846 self._diff_cache = diff_cache
tobiasjs2836bcf2016-08-16 04:08:16 -0700847 logging.debug('%s(%s)', self.__class__.__name__, self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000848
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000849 def LocalPath(self):
850 """Returns the path of this file on the local disk relative to client root.
Andrew Grieve92b8b992017-11-02 09:42:24 -0400851
852 This should be used for error messages but not for accessing files,
853 because presubmit checks are run with CWD=PresubmitLocalPath() (which is
854 often != client root).
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000855 """
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000856 return normpath(self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000857
858 def AbsoluteLocalPath(self):
859 """Returns the absolute path of this file on the local disk.
860 """
chase@chromium.org8e416c82009-10-06 04:30:44 +0000861 return os.path.abspath(os.path.join(self._local_root, self.LocalPath()))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000862
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000863 def Action(self):
864 """Returns the action on this opened file, e.g. A, M, D, etc."""
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000865 return self._action
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000866
agable0b65e732016-11-22 09:25:46 -0800867 def IsTestableFile(self):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000868 """Returns True if the file is a text file and not a binary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000869
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000870 Deleted files are not text file."""
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000871 raise NotImplementedError() # Implement when needed
872
agable0b65e732016-11-22 09:25:46 -0800873 def IsTextFile(self):
874 """An alias to IsTestableFile for backwards compatibility."""
875 return self.IsTestableFile()
876
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700877 def OldContents(self):
878 """Returns an iterator over the lines in the old version of file.
879
Daniel Cheng2da34fe2017-03-21 20:42:12 -0700880 The old version is the file before any modifications in the user's
881 workspace, i.e. the "left hand side".
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700882
883 Contents will be empty if the file is a directory or does not exist.
884 Note: The carriage returns (LF or CR) are stripped off.
885 """
886 return self._diff_cache.GetOldContents(self.LocalPath(),
887 self._local_root).splitlines()
888
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000889 def NewContents(self):
890 """Returns an iterator over the lines in the new version of file.
891
892 The new version is the file in the user's workspace, i.e. the "right hand
893 side".
894
895 Contents will be empty if the file is a directory or does not exist.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000896 Note: The carriage returns (LF or CR) are stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000897 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000898 if self._cached_new_contents is None:
899 self._cached_new_contents = []
agable0b65e732016-11-22 09:25:46 -0800900 try:
901 self._cached_new_contents = gclient_utils.FileRead(
902 self.AbsoluteLocalPath(), 'rU').splitlines()
903 except IOError:
904 pass # File not found? That's fine; maybe it was deleted.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000905 return self._cached_new_contents[:]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000906
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000907 def ChangedContents(self):
908 """Returns a list of tuples (line number, line text) of all new lines.
909
910 This relies on the scm diff output describing each changed code section
911 with a line of the form
912
913 ^@@ <old line num>,<old size> <new line num>,<new size> @@$
914 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000915 if self._cached_changed_contents is not None:
916 return self._cached_changed_contents[:]
917 self._cached_changed_contents = []
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000918 line_num = 0
919
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000920 for line in self.GenerateScmDiff().splitlines():
921 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
922 if m:
923 line_num = int(m.groups(1)[0])
924 continue
925 if line.startswith('+') and not line.startswith('++'):
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000926 self._cached_changed_contents.append((line_num, line[1:]))
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000927 if not line.startswith('-'):
928 line_num += 1
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000929 return self._cached_changed_contents[:]
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000930
maruel@chromium.org5de13972009-06-10 18:16:06 +0000931 def __str__(self):
932 return self.LocalPath()
933
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000934 def GenerateScmDiff(self):
nick@chromium.orgff526192013-06-10 19:30:26 +0000935 return self._diff_cache.GetDiff(self.LocalPath(), self._local_root)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000936
maruel@chromium.org58407af2011-04-12 23:15:57 +0000937
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000938class GitAffectedFile(AffectedFile):
939 """Representation of a file in a change out of a git checkout."""
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000940 # Method 'NNN' is abstract in class 'NNN' but is not overridden
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800941 # pylint: disable=abstract-method
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000942
nick@chromium.orgff526192013-06-10 19:30:26 +0000943 DIFF_CACHE = _GitDiffCache
944
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000945 def __init__(self, *args, **kwargs):
946 AffectedFile.__init__(self, *args, **kwargs)
947 self._server_path = None
agable0b65e732016-11-22 09:25:46 -0800948 self._is_testable_file = None
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000949
agable0b65e732016-11-22 09:25:46 -0800950 def IsTestableFile(self):
951 if self._is_testable_file is None:
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000952 if self.Action() == 'D':
agable0b65e732016-11-22 09:25:46 -0800953 # A deleted file is not testable.
954 self._is_testable_file = False
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000955 else:
agable0b65e732016-11-22 09:25:46 -0800956 self._is_testable_file = os.path.isfile(self.AbsoluteLocalPath())
957 return self._is_testable_file
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000958
maruel@chromium.orgc1938752011-04-12 23:11:13 +0000959
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000960class Change(object):
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000961 """Describe a change.
962
963 Used directly by the presubmit scripts to query the current change being
964 tested.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000965
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000966 Instance members:
nick@chromium.orgff526192013-06-10 19:30:26 +0000967 tags: Dictionary of KEY=VALUE pairs found in the change description.
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000968 self.KEY: equivalent to tags['KEY']
969 """
970
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000971 _AFFECTED_FILES = AffectedFile
972
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000973 # Matches key/value (or "tag") lines in changelist descriptions.
maruel@chromium.org428342a2011-11-10 15:46:33 +0000974 TAG_LINE_RE = re.compile(
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +0000975 '^[ \t]*(?P<key>[A-Z][A-Z_0-9]*)[ \t]*=[ \t]*(?P<value>.*?)[ \t]*$')
maruel@chromium.orgc1938752011-04-12 23:11:13 +0000976 scm = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000977
maruel@chromium.org58407af2011-04-12 23:15:57 +0000978 def __init__(
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000979 self, name, description, local_root, files, issue, patchset, author,
980 upstream=None):
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000981 if files is None:
982 files = []
983 self._name = name
chase@chromium.org8e416c82009-10-06 04:30:44 +0000984 # Convert root into an absolute path.
985 self._local_root = os.path.abspath(local_root)
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000986 self._upstream = upstream
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000987 self.issue = issue
988 self.patchset = patchset
maruel@chromium.org58407af2011-04-12 23:15:57 +0000989 self.author_email = author
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000990
isherman@chromium.orgb5cded62014-03-25 17:47:57 +0000991 self._full_description = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000992 self.tags = {}
isherman@chromium.orgb5cded62014-03-25 17:47:57 +0000993 self._description_without_tags = ''
994 self.SetDescriptionText(description)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000995
maruel@chromium.orge085d812011-10-10 19:49:15 +0000996 assert all(
997 (isinstance(f, (list, tuple)) and len(f) == 2) for f in files), files
998
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000999 diff_cache = self._AFFECTED_FILES.DIFF_CACHE(self._upstream)
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001000 self._affected_files = [
nick@chromium.orgff526192013-06-10 19:30:26 +00001001 self._AFFECTED_FILES(path, action.strip(), self._local_root, diff_cache)
1002 for action, path in files
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +00001003 ]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001004
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001005 def Name(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001006 """Returns the change name."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001007 return self._name
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001008
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001009 def DescriptionText(self):
1010 """Returns the user-entered changelist description, minus tags.
1011
1012 Any line in the user-provided description starting with e.g. "FOO="
1013 (whitespace permitted before and around) is considered a tag line. Such
1014 lines are stripped out of the description this function returns.
1015 """
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001016 return self._description_without_tags
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001017
1018 def FullDescriptionText(self):
1019 """Returns the complete changelist description including tags."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001020 return self._full_description
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001021
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001022 def SetDescriptionText(self, description):
1023 """Sets the full description text (including tags) to |description|.
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001024
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001025 Also updates the list of tags."""
1026 self._full_description = description
1027
1028 # From the description text, build up a dictionary of key/value pairs
1029 # plus the description minus all key/value or "tag" lines.
1030 description_without_tags = []
1031 self.tags = {}
1032 for line in self._full_description.splitlines():
1033 m = self.TAG_LINE_RE.match(line)
1034 if m:
1035 self.tags[m.group('key')] = m.group('value')
1036 else:
1037 description_without_tags.append(line)
1038
1039 # Change back to text and remove whitespace at end.
1040 self._description_without_tags = (
1041 '\n'.join(description_without_tags).rstrip())
1042
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001043 def RepositoryRoot(self):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001044 """Returns the repository (checkout) root directory for this change,
1045 as an absolute path.
1046 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001047 return self._local_root
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001048
1049 def __getattr__(self, attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001050 """Return tags directly as attributes on the object."""
1051 if not re.match(r"^[A-Z_]*$", attr):
1052 raise AttributeError(self, attr)
maruel@chromium.orge1a524f2009-05-27 14:43:46 +00001053 return self.tags.get(attr)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001054
Aaron Gablefc03e672017-05-15 14:09:42 -07001055 def BugsFromDescription(self):
1056 """Returns all bugs referenced in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -07001057 tags = [b.strip() for b in self.tags.get('BUG', '').split(',') if b.strip()]
Caleb Rouleauc0546b92019-02-22 06:12:57 +00001058 footers = []
Dan Beam62954042019-10-03 21:20:33 +00001059 parsed = git_footers.parse_footers(self._full_description)
1060 unsplit_footers = parsed.get('Bug', []) + parsed.get('Fixed', [])
Caleb Rouleauc0546b92019-02-22 06:12:57 +00001061 for unsplit_footer in unsplit_footers:
1062 footers += [b.strip() for b in unsplit_footer.split(',')]
Aaron Gable12ef5012017-05-15 14:29:00 -07001063 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -07001064
1065 def ReviewersFromDescription(self):
1066 """Returns all reviewers listed in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -07001067 # We don't support a "R:" git-footer for reviewers; that is in metadata.
1068 tags = [r.strip() for r in self.tags.get('R', '').split(',') if r.strip()]
1069 return sorted(set(tags))
Aaron Gablefc03e672017-05-15 14:09:42 -07001070
1071 def TBRsFromDescription(self):
1072 """Returns all TBR reviewers listed in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -07001073 tags = [r.strip() for r in self.tags.get('TBR', '').split(',') if r.strip()]
1074 # TODO(agable): Remove support for 'Tbr:' when TBRs are programmatically
1075 # determined by self-CR+1s.
1076 footers = git_footers.parse_footers(self._full_description).get('Tbr', [])
1077 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -07001078
1079 # TODO(agable): Delete these once we're sure they're unused.
1080 @property
1081 def BUG(self):
1082 return ','.join(self.BugsFromDescription())
1083 @property
1084 def R(self):
1085 return ','.join(self.ReviewersFromDescription())
1086 @property
1087 def TBR(self):
1088 return ','.join(self.TBRsFromDescription())
1089
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001090 def AllFiles(self, root=None):
1091 """List all files under source control in the repo."""
1092 raise NotImplementedError()
1093
agable0b65e732016-11-22 09:25:46 -08001094 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001095 """Returns a list of AffectedFile instances for all files in the change.
1096
1097 Args:
1098 include_deletes: If false, deleted files will be filtered out.
sail@chromium.org5538e022011-05-12 17:53:16 +00001099 file_filter: An additional filter to apply.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001100
1101 Returns:
1102 [AffectedFile(path, action), AffectedFile(path, action)]
1103 """
Edward Lemurd2a5a4c2019-10-23 22:55:26 +00001104 affected = filter(file_filter, self._affected_files)
sail@chromium.org5538e022011-05-12 17:53:16 +00001105
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001106 if include_deletes:
1107 return affected
Edward Lemurd2a5a4c2019-10-23 22:55:26 +00001108 return filter(lambda x: x.Action() != 'D', affected)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001109
John Budorick16162372018-04-18 10:39:53 -07001110 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +00001111 """Return a list of the existing text files in a change."""
1112 if include_deletes is not None:
agable0b65e732016-11-22 09:25:46 -08001113 warn("AffectedTeestableFiles(include_deletes=%s)"
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001114 " is deprecated and ignored" % str(include_deletes),
1115 category=DeprecationWarning,
1116 stacklevel=2)
Edward Lemurd2a5a4c2019-10-23 22:55:26 +00001117 return filter(lambda x: x.IsTestableFile(),
1118 self.AffectedFiles(include_deletes=False, **kwargs))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001119
agable0b65e732016-11-22 09:25:46 -08001120 def AffectedTextFiles(self, include_deletes=None):
1121 """An alias to AffectedTestableFiles for backwards compatibility."""
1122 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001123
agable0b65e732016-11-22 09:25:46 -08001124 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001125 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -08001126 return [af.LocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001127
agable0b65e732016-11-22 09:25:46 -08001128 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001129 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -08001130 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001131
1132 def RightHandSideLines(self):
1133 """An iterator over all text lines in "new" version of changed files.
1134
1135 Lists lines from new or modified text files in the change.
1136
1137 This is useful for doing line-by-line regex checks, like checking for
1138 trailing whitespace.
1139
1140 Yields:
1141 a 3 tuple:
1142 the AffectedFile instance of the current file;
1143 integer line number (1-based); and
1144 the contents of the line as a string.
1145 """
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001146 return _RightHandSideLinesImpl(
1147 x for x in self.AffectedFiles(include_deletes=False)
agable0b65e732016-11-22 09:25:46 -08001148 if x.IsTestableFile())
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001149
Jochen Eisingerd0573ec2017-04-13 10:55:06 +02001150 def OriginalOwnersFiles(self):
1151 """A map from path names of affected OWNERS files to their old content."""
1152 def owners_file_filter(f):
1153 return 'OWNERS' in os.path.split(f.LocalPath())[1]
1154 files = self.AffectedFiles(file_filter=owners_file_filter)
1155 return dict([(f.LocalPath(), f.OldContents()) for f in files])
1156
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001157
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001158class GitChange(Change):
1159 _AFFECTED_FILES = GitAffectedFile
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001160 scm = 'git'
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +00001161
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001162 def AllFiles(self, root=None):
1163 """List all files under source control in the repo."""
1164 root = root or self.RepositoryRoot()
1165 return subprocess.check_output(
Aaron Gable7817f022017-12-12 09:43:17 -08001166 ['git', '-c', 'core.quotePath=false', 'ls-files', '--', '.'],
1167 cwd=root).splitlines()
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001168
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001169
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001170def ListRelevantPresubmitFiles(files, root):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001171 """Finds all presubmit files that apply to a given set of source files.
1172
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001173 If inherit-review-settings-ok is present right under root, looks for
1174 PRESUBMIT.py in directories enclosing root.
1175
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001176 Args:
1177 files: An iterable container containing file paths.
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001178 root: Path where to stop searching.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001179
1180 Return:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001181 List of absolute paths of the existing PRESUBMIT.py scripts.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001182 """
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001183 files = [normpath(os.path.join(root, f)) for f in files]
1184
1185 # List all the individual directories containing files.
1186 directories = set([os.path.dirname(f) for f in files])
1187
1188 # Ignore root if inherit-review-settings-ok is present.
1189 if os.path.isfile(os.path.join(root, 'inherit-review-settings-ok')):
1190 root = None
1191
1192 # Collect all unique directories that may contain PRESUBMIT.py.
1193 candidates = set()
1194 for directory in directories:
1195 while True:
1196 if directory in candidates:
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001197 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001198 candidates.add(directory)
1199 if directory == root:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001200 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001201 parent_dir = os.path.dirname(directory)
1202 if parent_dir == directory:
1203 # We hit the system root directory.
1204 break
1205 directory = parent_dir
1206
1207 # Look for PRESUBMIT.py in all candidate directories.
1208 results = []
1209 for directory in sorted(list(candidates)):
tobiasjsff061c02016-08-17 03:23:57 -07001210 try:
1211 for f in os.listdir(directory):
1212 p = os.path.join(directory, f)
1213 if os.path.isfile(p) and re.match(
1214 r'PRESUBMIT.*\.py$', f) and not f.startswith('PRESUBMIT_test'):
1215 results.append(p)
1216 except OSError:
1217 pass
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001218
tobiasjs2836bcf2016-08-16 04:08:16 -07001219 logging.debug('Presubmit files: %s', ','.join(results))
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001220 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001221
1222
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001223class GetTryMastersExecuter(object):
1224 @staticmethod
1225 def ExecPresubmitScript(script_text, presubmit_path, project, change):
1226 """Executes GetPreferredTryMasters() from a single presubmit script.
1227
1228 Args:
1229 script_text: The text of the presubmit script.
1230 presubmit_path: Project script to run.
1231 project: Project name to pass to presubmit script for bot selection.
1232
1233 Return:
1234 A map of try masters to map of builders to set of tests.
1235 """
1236 context = {}
1237 try:
Raul Tambre09e64b42019-05-14 01:57:22 +00001238 exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True),
1239 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001240 except Exception as e:
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001241 raise PresubmitFailure('"%s" had an exception.\n%s'
1242 % (presubmit_path, e))
1243
1244 function_name = 'GetPreferredTryMasters'
1245 if function_name not in context:
1246 return {}
1247 get_preferred_try_masters = context[function_name]
1248 if not len(inspect.getargspec(get_preferred_try_masters)[0]) == 2:
1249 raise PresubmitFailure(
1250 'Expected function "GetPreferredTryMasters" to take two arguments.')
1251 return get_preferred_try_masters(project, change)
1252
1253
rmistry@google.com5626a922015-02-26 14:03:30 +00001254class GetPostUploadExecuter(object):
1255 @staticmethod
1256 def ExecPresubmitScript(script_text, presubmit_path, cl, change):
1257 """Executes PostUploadHook() from a single presubmit script.
1258
1259 Args:
1260 script_text: The text of the presubmit script.
1261 presubmit_path: Project script to run.
1262 cl: The Changelist object.
1263 change: The Change object.
1264
1265 Return:
1266 A list of results objects.
1267 """
1268 context = {}
1269 try:
Raul Tambre09e64b42019-05-14 01:57:22 +00001270 exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True),
1271 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001272 except Exception as e:
rmistry@google.com5626a922015-02-26 14:03:30 +00001273 raise PresubmitFailure('"%s" had an exception.\n%s'
1274 % (presubmit_path, e))
1275
1276 function_name = 'PostUploadHook'
1277 if function_name not in context:
1278 return {}
1279 post_upload_hook = context[function_name]
1280 if not len(inspect.getargspec(post_upload_hook)[0]) == 3:
1281 raise PresubmitFailure(
1282 'Expected function "PostUploadHook" to take three arguments.')
1283 return post_upload_hook(cl, change, OutputApi(False))
1284
1285
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001286def _MergeMasters(masters1, masters2):
1287 """Merges two master maps. Merges also the tests of each builder."""
1288 result = {}
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001289 for (master, builders) in itertools.chain(masters1.items(),
1290 masters2.items()):
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001291 new_builders = result.setdefault(master, {})
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001292 for (builder, tests) in builders.items():
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001293 new_builders.setdefault(builder, set([])).update(tests)
1294 return result
1295
1296
1297def DoGetTryMasters(change,
1298 changed_files,
1299 repository_root,
1300 default_presubmit,
1301 project,
1302 verbose,
1303 output_stream):
1304 """Get the list of try masters from the presubmit scripts.
1305
1306 Args:
1307 changed_files: List of modified files.
1308 repository_root: The repository root.
1309 default_presubmit: A default presubmit script to execute in any case.
1310 project: Optional name of a project used in selecting trybots.
1311 verbose: Prints debug info.
1312 output_stream: A stream to write debug output to.
1313
1314 Return:
1315 Map of try masters to map of builders to set of tests.
1316 """
1317 presubmit_files = ListRelevantPresubmitFiles(changed_files, repository_root)
1318 if not presubmit_files and verbose:
1319 output_stream.write("Warning, no PRESUBMIT.py found.\n")
1320 results = {}
1321 executer = GetTryMastersExecuter()
1322
1323 if default_presubmit:
1324 if verbose:
1325 output_stream.write("Running default presubmit script.\n")
1326 fake_path = os.path.join(repository_root, 'PRESUBMIT.py')
1327 results = _MergeMasters(results, executer.ExecPresubmitScript(
1328 default_presubmit, fake_path, project, change))
1329 for filename in presubmit_files:
1330 filename = os.path.abspath(filename)
1331 if verbose:
1332 output_stream.write("Running %s\n" % filename)
1333 # Accept CRLF presubmit script.
1334 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1335 results = _MergeMasters(results, executer.ExecPresubmitScript(
1336 presubmit_script, filename, project, change))
1337
1338 # Make sets to lists again for later JSON serialization.
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001339 for builders in results.values():
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001340 for builder in builders:
1341 builders[builder] = list(builders[builder])
1342
1343 if results and verbose:
1344 output_stream.write('%s\n' % str(results))
1345 return results
1346
1347
rmistry@google.com5626a922015-02-26 14:03:30 +00001348def DoPostUploadExecuter(change,
1349 cl,
1350 repository_root,
1351 verbose,
1352 output_stream):
1353 """Execute the post upload hook.
1354
1355 Args:
1356 change: The Change object.
1357 cl: The Changelist object.
1358 repository_root: The repository root.
1359 verbose: Prints debug info.
1360 output_stream: A stream to write debug output to.
1361 """
1362 presubmit_files = ListRelevantPresubmitFiles(
1363 change.LocalPaths(), repository_root)
1364 if not presubmit_files and verbose:
1365 output_stream.write("Warning, no PRESUBMIT.py found.\n")
1366 results = []
1367 executer = GetPostUploadExecuter()
1368 # The root presubmit file should be executed after the ones in subdirectories.
1369 # i.e. the specific post upload hooks should run before the general ones.
1370 # Thus, reverse the order provided by ListRelevantPresubmitFiles.
1371 presubmit_files.reverse()
1372
1373 for filename in presubmit_files:
1374 filename = os.path.abspath(filename)
1375 if verbose:
1376 output_stream.write("Running %s\n" % filename)
1377 # Accept CRLF presubmit script.
1378 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1379 results.extend(executer.ExecPresubmitScript(
1380 presubmit_script, filename, cl, change))
1381 output_stream.write('\n')
1382 if results:
1383 output_stream.write('** Post Upload Hook Messages **\n')
1384 for result in results:
1385 result.handle(output_stream)
1386 output_stream.write('\n')
1387
1388 return results
1389
1390
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001391class PresubmitExecuter(object):
Aaron Gable668c1d82018-04-03 10:19:16 -07001392 def __init__(self, change, committing, verbose,
Edward Lesmes8e282792018-04-03 18:50:29 -04001393 gerrit_obj, dry_run=None, thread_pool=None, parallel=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001394 """
1395 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001396 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001397 committing: True if 'git cl land' is running, False if 'git cl upload' is.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001398 gerrit_obj: provides basic Gerrit codereview functionality.
1399 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001400 parallel: if true, all tests reported via input_api.RunTests for all
1401 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001402 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001403 self.change = change
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001404 self.committing = committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001405 self.gerrit = gerrit_obj
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001406 self.verbose = verbose
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001407 self.dry_run = dry_run
Daniel Cheng7227d212017-11-17 08:12:37 -08001408 self.more_cc = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001409 self.thread_pool = thread_pool
1410 self.parallel = parallel
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001411
1412 def ExecPresubmitScript(self, script_text, presubmit_path):
1413 """Executes a single presubmit script.
1414
1415 Args:
1416 script_text: The text of the presubmit script.
1417 presubmit_path: The path to the presubmit file (this will be reported via
1418 input_api.PresubmitLocalPath()).
1419
1420 Return:
1421 A list of result objects, empty if no problems.
1422 """
thakis@chromium.orgc6ef53a2014-11-04 00:13:54 +00001423
chase@chromium.org8e416c82009-10-06 04:30:44 +00001424 # Change to the presubmit file's directory to support local imports.
1425 main_path = os.getcwd()
1426 os.chdir(os.path.dirname(presubmit_path))
1427
1428 # Load the presubmit script into context.
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001429 input_api = InputApi(self.change, presubmit_path, self.committing,
Aaron Gable668c1d82018-04-03 10:19:16 -07001430 self.verbose, gerrit_obj=self.gerrit,
Edward Lesmes8e282792018-04-03 18:50:29 -04001431 dry_run=self.dry_run, thread_pool=self.thread_pool,
1432 parallel=self.parallel)
Daniel Cheng7227d212017-11-17 08:12:37 -08001433 output_api = OutputApi(self.committing)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001434 context = {}
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001435 try:
Raul Tambre09e64b42019-05-14 01:57:22 +00001436 exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True),
1437 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001438 except Exception as e:
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001439 raise PresubmitFailure('"%s" had an exception.\n%s' % (presubmit_path, e))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001440
1441 # These function names must change if we make substantial changes to
1442 # the presubmit API that are not backwards compatible.
1443 if self.committing:
1444 function_name = 'CheckChangeOnCommit'
1445 else:
1446 function_name = 'CheckChangeOnUpload'
1447 if function_name in context:
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +01001448 try:
Daniel Cheng7227d212017-11-17 08:12:37 -08001449 context['__args'] = (input_api, output_api)
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +01001450 logging.debug('Running %s in %s', function_name, presubmit_path)
1451 result = eval(function_name + '(*__args)', context)
1452 logging.debug('Running %s done.', function_name)
Daniel Chengd36fce42017-11-21 21:52:52 -08001453 self.more_cc.extend(output_api.more_cc)
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +01001454 finally:
Edward Lemurd2a5a4c2019-10-23 22:55:26 +00001455 map(os.remove, input_api._named_temporary_files)
1456 if not (isinstance(result, types.TupleType) or
1457 isinstance(result, types.ListType)):
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001458 raise PresubmitFailure(
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001459 'Presubmit functions must return a tuple or list')
1460 for item in result:
1461 if not isinstance(item, OutputApi.PresubmitResult):
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001462 raise PresubmitFailure(
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001463 'All presubmit results must be of types derived from '
1464 'output_api.PresubmitResult')
1465 else:
1466 result = () # no error since the script doesn't care about current event.
1467
chase@chromium.org8e416c82009-10-06 04:30:44 +00001468 # Return the process to the original working directory.
1469 os.chdir(main_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001470 return result
1471
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001472def DoPresubmitChecks(change,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001473 committing,
1474 verbose,
1475 output_stream,
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001476 input_stream,
maruel@chromium.orgb0dfd352009-06-10 14:12:54 +00001477 default_presubmit,
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001478 may_prompt,
Aaron Gable668c1d82018-04-03 10:19:16 -07001479 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04001480 dry_run=None,
Debrian Figueroadd2737e2019-06-21 23:50:13 +00001481 parallel=False,
1482 json_output=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001483 """Runs all presubmit checks that apply to the files in the change.
1484
1485 This finds all PRESUBMIT.py files in directories enclosing the files in the
1486 change (up to the repository root) and calls the relevant entrypoint function
1487 depending on whether the change is being committed or uploaded.
1488
1489 Prints errors, warnings and notifications. Prompts the user for warnings
1490 when needed.
1491
1492 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001493 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001494 committing: True if 'git cl land' is running, False if 'git cl upload' is.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001495 verbose: Prints debug info.
1496 output_stream: A stream to write output from presubmit tests to.
1497 input_stream: A stream to read input from the user.
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001498 default_presubmit: A default presubmit script to execute in any case.
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001499 may_prompt: Enable (y/n) questions on warning or error. If False,
1500 any questions are answered with yes by default.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001501 gerrit_obj: provides basic Gerrit codereview functionality.
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001502 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001503 parallel: if true, all tests specified by input_api.RunTests in all
1504 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001505
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001506 Warning:
1507 If may_prompt is true, output_stream SHOULD be sys.stdout and input_stream
1508 SHOULD be sys.stdin.
1509
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001510 Return:
dpranke@chromium.org5ac21012011-03-16 02:58:25 +00001511 A PresubmitOutput object. Use output.should_continue() to figure out
1512 if there were errors or warnings and the caller should abort.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001513 """
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001514 old_environ = os.environ
1515 try:
1516 # Make sure python subprocesses won't generate .pyc files.
Edward Lesmes401b25c2019-10-23 03:34:12 +00001517 # We convert to str, since on Windows on Python 2 only strings are allowed
1518 # as environment variables, but literals are unicode since we're importing
1519 # unicode_literals from __future__.
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001520 os.environ = os.environ.copy()
Edward Lesmes401b25c2019-10-23 03:34:12 +00001521 os.environ[str('PYTHONDONTWRITEBYTECODE')] = str('1')
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001522
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001523 output = PresubmitOutput(input_stream, output_stream)
Debrian Figueroadd2737e2019-06-21 23:50:13 +00001524
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001525 if committing:
1526 output.write("Running presubmit commit checks ...\n")
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001527 else:
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001528 output.write("Running presubmit upload checks ...\n")
1529 start_time = time.time()
1530 presubmit_files = ListRelevantPresubmitFiles(
agable0b65e732016-11-22 09:25:46 -08001531 change.AbsoluteLocalPaths(), change.RepositoryRoot())
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001532 if not presubmit_files and verbose:
maruel@chromium.orgfae707b2011-09-15 18:57:58 +00001533 output.write("Warning, no PRESUBMIT.py found.\n")
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001534 results = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001535 thread_pool = ThreadPool()
Edward Lemur7e3c67f2018-07-20 20:52:49 +00001536 executer = PresubmitExecuter(change, committing, verbose, gerrit_obj,
1537 dry_run, thread_pool, parallel)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001538 if default_presubmit:
1539 if verbose:
1540 output.write("Running default presubmit script.\n")
1541 fake_path = os.path.join(change.RepositoryRoot(), 'PRESUBMIT.py')
1542 results += executer.ExecPresubmitScript(default_presubmit, fake_path)
1543 for filename in presubmit_files:
1544 filename = os.path.abspath(filename)
1545 if verbose:
1546 output.write("Running %s\n" % filename)
1547 # Accept CRLF presubmit script.
1548 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1549 results += executer.ExecPresubmitScript(presubmit_script, filename)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001550
Edward Lesmes8e282792018-04-03 18:50:29 -04001551 results += thread_pool.RunAsync()
1552
Daniel Cheng7227d212017-11-17 08:12:37 -08001553 output.more_cc.extend(executer.more_cc)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001554 errors = []
1555 notifications = []
1556 warnings = []
1557 for result in results:
1558 if result.fatal:
1559 errors.append(result)
1560 elif result.should_prompt:
1561 warnings.append(result)
1562 else:
1563 notifications.append(result)
pam@chromium.orged9a0832009-09-09 22:48:55 +00001564
Debrian Figueroadd2737e2019-06-21 23:50:13 +00001565 if json_output:
1566 # Write the presubmit results to json output
1567 presubmit_results = {
1568 'errors': [
1569 error.json_format() for error in errors
1570 ],
1571 'notifications': [
1572 notification.json_format() for notification in notifications
1573 ],
1574 'warnings': [
1575 warning.json_format() for warning in warnings
1576 ]
1577 }
1578
Edward Lemurd2a5a4c2019-10-23 22:55:26 +00001579 gclient_utils.FileWrite(json_output, json.dumps(presubmit_results))
Debrian Figueroadd2737e2019-06-21 23:50:13 +00001580
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001581 output.write('\n')
1582 for name, items in (('Messages', notifications),
1583 ('Warnings', warnings),
1584 ('ERRORS', errors)):
1585 if items:
1586 output.write('** Presubmit %s **\n' % name)
1587 for item in items:
1588 item.handle(output)
1589 output.write('\n')
pam@chromium.orged9a0832009-09-09 22:48:55 +00001590
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001591 total_time = time.time() - start_time
1592 if total_time > 1.0:
1593 output.write("Presubmit checks took %.1fs to calculate.\n\n" % total_time)
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001594
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001595 if errors:
1596 output.fail()
1597 elif warnings:
1598 output.write('There were presubmit warnings. ')
1599 if may_prompt:
1600 output.prompt_yes_no('Are you sure you wish to continue? (y/N): ')
1601 else:
1602 output.write('Presubmit checks passed.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001603
1604 global _ASKED_FOR_FEEDBACK
1605 # Ask for feedback one time out of 5.
1606 if (len(results) and random.randint(0, 4) == 0 and not _ASKED_FOR_FEEDBACK):
maruel@chromium.org1ce8e662014-01-14 15:23:00 +00001607 output.write(
1608 'Was the presubmit check useful? If not, run "git cl presubmit -v"\n'
1609 'to figure out which PRESUBMIT.py was run, then run git blame\n'
1610 'on the file to figure out who to ask for help.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001611 _ASKED_FOR_FEEDBACK = True
1612 return output
1613 finally:
1614 os.environ = old_environ
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001615
1616
1617def ScanSubDirs(mask, recursive):
1618 if not recursive:
pgervais@chromium.orge57b09d2014-05-07 00:58:13 +00001619 return [x for x in glob.glob(mask) if x not in ('.svn', '.git')]
Lei Zhang9611c4c2017-04-04 01:41:56 -07001620
1621 results = []
1622 for root, dirs, files in os.walk('.'):
1623 if '.svn' in dirs:
1624 dirs.remove('.svn')
1625 if '.git' in dirs:
1626 dirs.remove('.git')
1627 for name in files:
1628 if fnmatch.fnmatch(name, mask):
1629 results.append(os.path.join(root, name))
1630 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001631
1632
1633def ParseFiles(args, recursive):
tobiasjs2836bcf2016-08-16 04:08:16 -07001634 logging.debug('Searching for %s', args)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001635 files = []
1636 for arg in args:
maruel@chromium.orge3608df2009-11-10 20:22:57 +00001637 files.extend([('M', f) for f in ScanSubDirs(arg, recursive)])
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001638 return files
1639
1640
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001641def load_files(options, args):
1642 """Tries to determine the SCM."""
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001643 files = []
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001644 if args:
1645 files = ParseFiles(args, options.recursive)
agable0b65e732016-11-22 09:25:46 -08001646 change_scm = scm.determine_scm(options.root)
1647 if change_scm == 'git':
maruel@chromium.org9b31f162012-01-26 19:02:31 +00001648 change_class = GitChange
agable@chromium.org2da1ade2014-04-30 17:40:45 +00001649 upstream = options.upstream or None
maruel@chromium.org9b31f162012-01-26 19:02:31 +00001650 if not files:
agable@chromium.org2da1ade2014-04-30 17:40:45 +00001651 files = scm.GIT.CaptureStatus([], options.root, upstream)
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001652 else:
tobiasjs2836bcf2016-08-16 04:08:16 -07001653 logging.info('Doesn\'t seem under source control. Got %d files', len(args))
maruel@chromium.org9b31f162012-01-26 19:02:31 +00001654 if not files:
1655 return None, None
1656 change_class = Change
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001657 return change_class, files
1658
1659
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001660@contextlib.contextmanager
1661def canned_check_filter(method_names):
1662 filtered = {}
1663 try:
1664 for method_name in method_names:
1665 if not hasattr(presubmit_canned_checks, method_name):
Aaron Gableecee74c2018-04-02 15:13:08 -07001666 logging.warn('Skipping unknown "canned" check %s' % method_name)
1667 continue
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001668 filtered[method_name] = getattr(presubmit_canned_checks, method_name)
1669 setattr(presubmit_canned_checks, method_name, lambda *_a, **_kw: [])
1670 yield
1671 finally:
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001672 for name, method in filtered.items():
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001673 setattr(presubmit_canned_checks, name, method)
1674
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001675
sbc@chromium.org013731e2015-02-26 18:28:43 +00001676def main(argv=None):
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001677 parser = optparse.OptionParser(usage="%prog [options] <files...>",
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001678 version="%prog " + str(__version__))
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001679 parser.add_option("-c", "--commit", action="store_true", default=False,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001680 help="Use commit instead of upload checks")
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001681 parser.add_option("-u", "--upload", action="store_false", dest='commit',
1682 help="Use upload instead of commit checks")
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001683 parser.add_option("-r", "--recursive", action="store_true",
1684 help="Act recursively")
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001685 parser.add_option("-v", "--verbose", action="count", default=0,
1686 help="Use 2 times for more debug info")
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001687 parser.add_option("--name", default='no name')
maruel@chromium.org58407af2011-04-12 23:15:57 +00001688 parser.add_option("--author")
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001689 parser.add_option("--description", default='')
1690 parser.add_option("--issue", type='int', default=0)
1691 parser.add_option("--patchset", type='int', default=0)
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001692 parser.add_option("--root", default=os.getcwd(),
1693 help="Search for PRESUBMIT.py up to this directory. "
1694 "If inherit-review-settings-ok is present in this "
1695 "directory, parent directories up to the root file "
1696 "system directories will also be searched.")
agable@chromium.org2da1ade2014-04-30 17:40:45 +00001697 parser.add_option("--upstream",
1698 help="Git only: the base ref or upstream branch against "
1699 "which the diff should be computed.")
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001700 parser.add_option("--default_presubmit")
1701 parser.add_option("--may_prompt", action='store_true', default=False)
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001702 parser.add_option("--skip_canned", action='append', default=[],
1703 help="A list of checks to skip which appear in "
1704 "presubmit_canned_checks. Can be provided multiple times "
1705 "to skip multiple canned checks.")
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001706 parser.add_option("--dry_run", action='store_true',
1707 help=optparse.SUPPRESS_HELP)
tandrii@chromium.org015ebae2016-04-25 19:37:22 +00001708 parser.add_option("--gerrit_url", help=optparse.SUPPRESS_HELP)
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001709 parser.add_option("--gerrit_fetch", action='store_true',
1710 help=optparse.SUPPRESS_HELP)
Edward Lesmes8e282792018-04-03 18:50:29 -04001711 parser.add_option('--parallel', action='store_true',
1712 help='Run all tests specified by input_api.RunTests in all '
1713 'PRESUBMIT files in parallel.')
Debrian Figueroadd2737e2019-06-21 23:50:13 +00001714 parser.add_option('--json_output',
1715 help='Write presubmit errors to json output.')
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001716
maruel@chromium.org82e5f282011-03-17 14:08:55 +00001717 options, args = parser.parse_args(argv)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001718
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001719 if options.verbose >= 2:
maruel@chromium.org7444c502011-02-09 14:02:11 +00001720 logging.basicConfig(level=logging.DEBUG)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001721 elif options.verbose:
1722 logging.basicConfig(level=logging.INFO)
1723 else:
1724 logging.basicConfig(level=logging.ERROR)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001725
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001726 change_class, files = load_files(options, args)
1727 if not change_class:
1728 parser.error('For unversioned directory, <files> is not optional.')
tobiasjs2836bcf2016-08-16 04:08:16 -07001729 logging.info('Found %d file(s).', len(files))
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001730
Aaron Gable668c1d82018-04-03 10:19:16 -07001731 gerrit_obj = None
tandrii@chromium.org015ebae2016-04-25 19:37:22 +00001732 if options.gerrit_url and options.gerrit_fetch:
tandrii@chromium.org83b1b232016-04-29 16:33:19 +00001733 assert options.issue and options.patchset
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001734 gerrit_obj = GerritAccessor(urlparse.urlparse(options.gerrit_url).netloc)
1735 options.author = gerrit_obj.GetChangeOwner(options.issue)
1736 options.description = gerrit_obj.GetChangeDescription(options.issue,
1737 options.patchset)
tandrii@chromium.org015ebae2016-04-25 19:37:22 +00001738 logging.info('Got author: "%s"', options.author)
1739 logging.info('Got description: """\n%s\n"""', options.description)
1740
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001741 try:
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001742 with canned_check_filter(options.skip_canned):
1743 results = DoPresubmitChecks(
1744 change_class(options.name,
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001745 options.description,
1746 options.root,
1747 files,
1748 options.issue,
1749 options.patchset,
1750 options.author,
1751 upstream=options.upstream),
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001752 options.commit,
1753 options.verbose,
1754 sys.stdout,
1755 sys.stdin,
1756 options.default_presubmit,
1757 options.may_prompt,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001758 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04001759 options.dry_run,
Debrian Figueroadd2737e2019-06-21 23:50:13 +00001760 options.parallel,
1761 options.json_output)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001762 return not results.should_continue()
Raul Tambre7c938462019-05-24 16:35:35 +00001763 except PresubmitFailure as e:
Raul Tambre80ee78e2019-05-06 22:41:05 +00001764 print(e, file=sys.stderr)
1765 print('Maybe your depot_tools is out of date?', file=sys.stderr)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001766 return 2
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001767
1768
1769if __name__ == '__main__':
maruel@chromium.org35625c72011-03-23 17:34:02 +00001770 fix_encoding.fix_encoding()
sbc@chromium.org013731e2015-02-26 18:28:43 +00001771 try:
1772 sys.exit(main())
1773 except KeyboardInterrupt:
1774 sys.stderr.write('interrupted\n')
sergiybf8a3b382016-07-05 11:21:30 -07001775 sys.exit(2)