blob: bb907f2ccb203e8152f61f134c33e2b43f285a16 [file] [log] [blame]
maruel@chromium.orgddd59412011-11-30 14:20:38 +00001#!/usr/bin/env python
maruel@chromium.orgeb5edbc2012-01-16 17:03:28 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Unit tests for git_cl.py."""
7
8import os
maruel@chromium.orga3353652011-11-30 14:26:57 +00009import StringIO
ukai@chromium.org78c4b982012-02-14 02:20:26 +000010import stat
maruel@chromium.orgddd59412011-11-30 14:20:38 +000011import sys
12import unittest
13
14sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
15
16from testing_support.auto_stub import TestCase
17
18import git_cl
19import subprocess2
20
21
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000022class PresubmitMock(object):
23 def __init__(self, *args, **kwargs):
24 self.reviewers = []
25 @staticmethod
26 def should_continue():
27 return True
28
29
30class RietveldMock(object):
31 def __init__(self, *args, **kwargs):
32 pass
maruel@chromium.org78936cb2013-04-11 00:17:52 +000033
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000034 @staticmethod
35 def get_description(issue):
36 return 'Issue: %d' % issue
37
maruel@chromium.org78936cb2013-04-11 00:17:52 +000038 @staticmethod
39 def get_issue_properties(_issue, _messages):
40 return {
41 'reviewers': ['joe@chromium.org', 'john@chromium.org'],
42 'messages': [
43 {
44 'approval': True,
45 'sender': 'john@chromium.org',
46 },
47 ],
48 }
49
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000050
51class WatchlistsMock(object):
52 def __init__(self, _):
53 pass
54 @staticmethod
55 def GetWatchersForPaths(_):
56 return ['joe@example.com']
57
58
ukai@chromium.org78c4b982012-02-14 02:20:26 +000059class CodereviewSettingsFileMock(object):
60 def __init__(self):
61 pass
62 # pylint: disable=R0201
63 def read(self):
64 return ("CODE_REVIEW_SERVER: gerrit.chromium.org\n" +
65 "GERRIT_HOST: gerrit.chromium.org\n" +
66 "GERRIT_PORT: 29418\n")
67
68
maruel@chromium.orgddd59412011-11-30 14:20:38 +000069class TestGitCl(TestCase):
70 def setUp(self):
71 super(TestGitCl, self).setUp()
72 self.calls = []
73 self._calls_done = 0
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000074 self.mock(subprocess2, 'call', self._mocked_call)
75 self.mock(subprocess2, 'check_call', self._mocked_call)
76 self.mock(subprocess2, 'check_output', self._mocked_call)
77 self.mock(subprocess2, 'communicate', self._mocked_call)
78 self.mock(subprocess2, 'Popen', self._mocked_call)
maruel@chromium.orgddd59412011-11-30 14:20:38 +000079 self.mock(git_cl, 'FindCodereviewSettingsFile', lambda: '')
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000080 self.mock(git_cl, 'ask_for_data', self._mocked_call)
81 self.mock(git_cl.breakpad, 'post', self._mocked_call)
82 self.mock(git_cl.breakpad, 'SendStack', self._mocked_call)
maruel@chromium.orgddd59412011-11-30 14:20:38 +000083 self.mock(git_cl.presubmit_support, 'DoPresubmitChecks', PresubmitMock)
maruel@chromium.orgddd59412011-11-30 14:20:38 +000084 self.mock(git_cl.rietveld, 'Rietveld', RietveldMock)
maruel@chromium.org4bac4b52012-11-27 20:33:52 +000085 self.mock(git_cl.rietveld, 'CachingRietveld', RietveldMock)
maruel@chromium.orgddd59412011-11-30 14:20:38 +000086 self.mock(git_cl.upload, 'RealMain', self.fail)
maruel@chromium.orgddd59412011-11-30 14:20:38 +000087 self.mock(git_cl.watchlists, 'Watchlists', WatchlistsMock)
88 # It's important to reset settings to not have inter-tests interference.
89 git_cl.settings = None
90
91 def tearDown(self):
92 if not self.has_failed():
93 self.assertEquals([], self.calls)
94 super(TestGitCl, self).tearDown()
95
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000096 def _mocked_call(self, *args, **kwargs):
97 self.assertTrue(
98 self.calls,
99 '@%d Expected: <Missing> Actual: %r' % (self._calls_done, args))
100 expected_args, result = self.calls.pop(0)
maruel@chromium.orge52678e2013-04-26 18:34:44 +0000101 # Also logs otherwise it could get caught in a try/finally and be hard to
102 # diagnose.
103 if expected_args != args:
104 msg = '@%d Expected: %r Actual: %r' % (
105 self._calls_done, expected_args, args)
106 git_cl.logging.error(msg)
107 self.fail(msg)
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000108 self._calls_done += 1
109 return result
110
maruel@chromium.orga3353652011-11-30 14:26:57 +0000111 @classmethod
iannucci@chromium.org79540052012-10-19 23:15:26 +0000112 def _upload_calls(cls, similarity, find_copies):
113 return (cls._git_base_calls(similarity, find_copies) +
114 cls._git_upload_calls())
maruel@chromium.orga3353652011-11-30 14:26:57 +0000115
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000116 @classmethod
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000117 def _upload_no_rev_calls(cls, similarity, find_copies):
118 return (cls._git_base_calls(similarity, find_copies) +
119 cls._git_upload_no_rev_calls())
120
121 @classmethod
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000122 def _git_base_calls(cls, similarity, find_copies):
iannucci@chromium.org53937ba2012-10-02 18:20:43 +0000123 if similarity is None:
124 similarity = '50'
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000125 similarity_call = ((['git', '--no-pager', 'config', '--int', '--get',
iannucci@chromium.org53937ba2012-10-02 18:20:43 +0000126 'branch.master.git-cl-similarity'],), '')
127 else:
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000128 similarity_call = ((['git', '--no-pager', 'config', '--int',
iannucci@chromium.org53937ba2012-10-02 18:20:43 +0000129 'branch.master.git-cl-similarity', similarity],), '')
iannucci@chromium.org79540052012-10-19 23:15:26 +0000130
131 if find_copies is None:
132 find_copies = True
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000133 find_copies_call = ((['git', '--no-pager', 'config', '--int', '--get',
iannucci@chromium.org79540052012-10-19 23:15:26 +0000134 'branch.master.git-find-copies'],), '')
135 else:
136 val = str(int(find_copies))
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000137 find_copies_call = ((['git', '--no-pager', 'config', '--int',
iannucci@chromium.org79540052012-10-19 23:15:26 +0000138 'branch.master.git-find-copies', val],), '')
139
140 if find_copies:
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000141 stat_call = ((['git', '--no-pager', 'diff', '--no-ext-diff', '--stat',
iannucci@chromium.org79540052012-10-19 23:15:26 +0000142 '--find-copies-harder', '-l100000', '-C'+similarity,
sbc@chromium.org5e07e062013-02-28 23:55:44 +0000143 'fake_ancestor_sha', 'HEAD'],), '+dat')
iannucci@chromium.org79540052012-10-19 23:15:26 +0000144 else:
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000145 stat_call = ((['git', '--no-pager', 'diff', '--no-ext-diff', '--stat',
sbc@chromium.org5e07e062013-02-28 23:55:44 +0000146 '-M'+similarity, 'fake_ancestor_sha', 'HEAD'],), '+dat')
iannucci@chromium.org79540052012-10-19 23:15:26 +0000147
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000148 return [
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000149 ((['git', '--no-pager', 'config', 'rietveld.server'],),
150 'codereview.example.com'),
151 ((['git', '--no-pager', 'symbolic-ref', 'HEAD'],), 'master'),
iannucci@chromium.org53937ba2012-10-02 18:20:43 +0000152 similarity_call,
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000153 ((['git', '--no-pager', 'symbolic-ref', 'HEAD'],), 'master'),
iannucci@chromium.org79540052012-10-19 23:15:26 +0000154 find_copies_call,
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000155 ((['git', '--no-pager', 'update-index', '--refresh', '-q'],), ''),
156 ((['git', '--no-pager', 'diff-index', '--name-status', 'HEAD'],), ''),
157 ((['git', '--no-pager', 'symbolic-ref', 'HEAD'],), 'master'),
158 ((['git', '--no-pager', 'config', 'branch.master.merge'],), 'master'),
159 ((['git', '--no-pager', 'config', 'branch.master.remote'],), 'origin'),
160 ((['git', '--no-pager', 'merge-base', 'master', 'HEAD'],),
161 'fake_ancestor_sha'),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000162 ] + cls._git_sanity_checks('fake_ancestor_sha', 'master') + [
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000163 ((['git', '--no-pager', 'rev-parse', '--show-cdup'],), ''),
164 ((['git', '--no-pager', 'rev-parse', 'HEAD'],), '12345'),
165 ((['git', '--no-pager', 'diff', '--name-status', '-r',
166 'fake_ancestor_sha...', '.'],),
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000167 'M\t.gitignore\n'),
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000168 ((['git', '--no-pager', 'config', 'branch.master.rietveldissue'],), ''),
169 ((['git', '--no-pager', 'config', 'branch.master.rietveldpatchset'],),
170 ''),
171 ((['git', '--no-pager', 'log', '--pretty=format:%s%n%n%b',
172 'fake_ancestor_sha...'],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000173 'foo'),
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000174 ((['git', '--no-pager', 'config', 'user.email'],), 'me@example.com'),
iannucci@chromium.org79540052012-10-19 23:15:26 +0000175 stat_call,
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000176 ((['git', '--no-pager', 'config', 'gerrit.host'],), ''),
177 ((['git', '--no-pager', 'log', '--pretty=format:%s\n\n%b',
178 'fake_ancestor_sha..HEAD'],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000179 'desc\n'),
maruel@chromium.orga3353652011-11-30 14:26:57 +0000180 ]
181
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000182 @classmethod
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000183 def _git_upload_no_rev_calls(cls):
184 return [
185 ((['git', '--no-pager', 'config', 'core.editor'],), ''),
186 ]
187
188 @classmethod
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000189 def _git_upload_calls(cls):
maruel@chromium.orga3353652011-11-30 14:26:57 +0000190 return [
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000191 ((['git', '--no-pager', 'config', 'core.editor'],), ''),
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000192 ((['git', '--no-pager', 'config', 'rietveld.cc'],), ''),
193 ((['git', '--no-pager', 'config', 'branch.master.base-url'],), ''),
194 ((['git', '--no-pager',
195 'config', '--local', '--get-regexp', '^svn-remote\\.'],),
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000196 (('', None), 0)),
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000197 ((['git', '--no-pager', 'rev-parse', '--show-cdup'],), ''),
198 ((['git', '--no-pager', 'svn', 'info'],), ''),
199 ((['git', '--no-pager',
200 'config', 'branch.master.rietveldissue', '1'],), ''),
201 ((['git', '--no-pager', 'config', 'branch.master.rietveldserver',
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000202 'https://codereview.example.com'],), ''),
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000203 ((['git', '--no-pager',
204 'config', 'branch.master.rietveldpatchset', '2'],), ''),
205 ((['git', '--no-pager', 'rev-parse', 'HEAD'],), 'hash'),
206 ((['git', '--no-pager', 'symbolic-ref', 'HEAD'],), 'hash'),
207 ((['git', '--no-pager',
208 'config', 'branch.hash.last-upload-hash', 'hash'],), ''),
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000209 ]
210
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000211 @staticmethod
212 def _git_sanity_checks(diff_base, working_branch):
213 fake_ancestor = 'fake_ancestor'
214 fake_cl = 'fake_cl_for_patch'
215 return [
216 # Calls to verify branch point is ancestor
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000217 ((['git', '--no-pager',
218 'rev-parse', '--verify', diff_base],), fake_ancestor),
219 ((['git', '--no-pager',
220 'merge-base', fake_ancestor, 'HEAD'],), fake_ancestor),
221 ((['git', '--no-pager',
222 'rev-list', '^' + fake_ancestor, 'HEAD'],), fake_cl),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000223 # Mock a config miss (error code 1)
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000224 ((['git', '--no-pager',
225 'config', 'gitcl.remotebranch'],), (('', None), 1)),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000226 # Call to GetRemoteBranch()
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000227 ((['git', '--no-pager',
228 'config', 'branch.%s.merge' % working_branch],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000229 'refs/heads/master'),
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000230 ((['git', '--no-pager',
231 'config', 'branch.%s.remote' % working_branch],), 'origin'),
232 ((['git', '--no-pager', 'rev-list', '^' + fake_ancestor,
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000233 'refs/remotes/origin/master'],), ''),
234 ]
235
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000236 @classmethod
237 def _dcommit_calls_1(cls):
238 return [
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000239 ((['git', '--no-pager',
240 'config', '--local', '--get-regexp', '^svn-remote\\.'],),
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000241 ((('svn-remote.svn.url svn://svn.chromium.org/chrome\n'
242 'svn-remote.svn.fetch trunk/src:refs/remotes/origin/master'),
243 None),
244 0)),
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000245 ((['git', '--no-pager',
246 'config', 'rietveld.server'],), 'codereview.example.com'),
247 ((['git', '--no-pager', 'symbolic-ref', 'HEAD'],), 'refs/heads/working'),
248 ((['git', '--no-pager', 'config', '--int', '--get',
iannucci@chromium.org53937ba2012-10-02 18:20:43 +0000249 'branch.working.git-cl-similarity'],), ''),
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000250 ((['git', '--no-pager', 'symbolic-ref', 'HEAD'],), 'refs/heads/working'),
251 ((['git', '--no-pager', 'config', '--int', '--get',
iannucci@chromium.org79540052012-10-19 23:15:26 +0000252 'branch.working.git-find-copies'],), ''),
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000253 ((['git', '--no-pager', 'symbolic-ref', 'HEAD'],), 'refs/heads/working'),
254 ((['git', '--no-pager',
255 'config', 'branch.working.merge'],), 'refs/heads/master'),
256 ((['git', '--no-pager', 'config', 'branch.working.remote'],), 'origin'),
257 ((['git', '--no-pager', 'rev-list', '--merges',
szager@chromium.orge84b7542012-06-15 21:26:58 +0000258 '--grep=^SVN changes up to revision [0-9]*$',
szager@chromium.org9bb85e22012-06-13 20:28:23 +0000259 'refs/remotes/origin/master^!'],), ''),
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000260 ((['git', '--no-pager', 'update-index', '--refresh', '-q'],), ''),
261 ((['git', '--no-pager', 'diff-index', '--name-status', 'HEAD'],), ''),
262 ((['git', '--no-pager', 'rev-list', '^refs/heads/working',
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000263 'refs/remotes/origin/master'],),
264 ''),
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000265 ((['git', '--no-pager',
266 'log', '--grep=^git-svn-id:', '-1', '--pretty=format:%H'],),
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000267 '3fc18b62c4966193eb435baabe2d18a3810ec82e'),
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000268 ((['git', '--no-pager',
269 'rev-list', '^3fc18b62c4966193eb435baabe2d18a3810ec82e',
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000270 'refs/remotes/origin/master'],), ''),
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000271 ((['git', '--no-pager',
272 'merge-base', 'refs/remotes/origin/master', 'HEAD'],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000273 'fake_ancestor_sha'),
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000274 ]
275
276 @classmethod
277 def _dcommit_calls_normal(cls):
278 return [
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000279 ((['git', '--no-pager', 'rev-parse', '--show-cdup'],), ''),
280 ((['git', '--no-pager', 'rev-parse', 'HEAD'],),
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000281 '00ff397798ea57439712ed7e04ab96e13969ef40'),
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000282 ((['git', '--no-pager',
283 'diff', '--name-status', '-r', 'fake_ancestor_sha...',
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000284 '.'],),
285 'M\tPRESUBMIT.py'),
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000286 ((['git', '--no-pager',
287 'config', 'branch.working.rietveldissue'],), '12345'),
288 ((['git', '--no-pager',
289 'config', 'branch.working.rietveldpatchset'],), '31137'),
290 ((['git', '--no-pager', 'config', 'branch.working.rietveldserver'],),
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000291 'codereview.example.com'),
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000292 ((['git', '--no-pager', 'config', 'user.email'],), 'author@example.com'),
293 ((['git', '--no-pager', 'config', 'rietveld.tree-status-url'],), ''),
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000294 ]
295
296 @classmethod
297 def _dcommit_calls_bypassed(cls):
298 return [
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000299 ((['git', '--no-pager',
300 'config', 'branch.working.rietveldissue'],), '12345'),
301 ((['git', '--no-pager', 'config', 'branch.working.rietveldserver'],),
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000302 'codereview.example.com'),
303 (('GitClHooksBypassedCommit',
304 'Issue https://codereview.example.com/12345 bypassed hook when '
305 'committing'), None),
306 ]
307
308 @classmethod
309 def _dcommit_calls_3(cls):
310 return [
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000311 ((['git', '--no-pager',
312 'diff', '--no-ext-diff', '--stat', '--find-copies-harder',
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000313 '-l100000', '-C50', 'fake_ancestor_sha',
iannucci@chromium.org53937ba2012-10-02 18:20:43 +0000314 'refs/heads/working'],),
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000315 (' PRESUBMIT.py | 2 +-\n'
316 ' 1 files changed, 1 insertions(+), 1 deletions(-)\n')),
317 (('About to commit; enter to confirm.',), None),
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000318 ((['git', '--no-pager', 'show-ref', '--quiet', '--verify',
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000319 'refs/heads/git-cl-commit'],),
320 (('', None), 0)),
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000321 ((['git', '--no-pager', 'branch', '-D', 'git-cl-commit'],), ''),
322 ((['git', '--no-pager', 'show-ref', '--quiet', '--verify',
szager@chromium.org9bb85e22012-06-13 20:28:23 +0000323 'refs/heads/git-cl-cherry-pick'],), ''),
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000324 ((['git', '--no-pager', 'rev-parse', '--show-cdup'],), '\n'),
325 ((['git', '--no-pager', 'checkout', '-q', '-b', 'git-cl-commit'],), ''),
326 ((['git', '--no-pager', 'reset', '--soft', 'fake_ancestor_sha'],), ''),
327 ((['git', '--no-pager', 'commit', '-m',
maruel@chromium.orge52678e2013-04-26 18:34:44 +0000328 'Issue: 12345\n\nR=john@chromium.org\n\n'
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000329 'Review URL: https://codereview.example.com/12345'],),
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000330 ''),
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000331 ((['git', '--no-pager',
332 'svn', 'dcommit', '-C50', '--no-rebase', '--rmdir'],),
iannucci@chromium.org53937ba2012-10-02 18:20:43 +0000333 (('', None), 0)),
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000334 ((['git', '--no-pager', 'checkout', '-q', 'working'],), ''),
335 ((['git', '--no-pager', 'branch', '-D', 'git-cl-commit'],), ''),
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000336 ]
337
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000338 @staticmethod
iannucci@chromium.org79540052012-10-19 23:15:26 +0000339 def _cmd_line(description, args, similarity, find_copies):
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000340 """Returns the upload command line passed to upload.RealMain()."""
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000341 return [
342 'upload', '--assume_yes', '--server',
maruel@chromium.orgeb5edbc2012-01-16 17:03:28 +0000343 'https://codereview.example.com',
maruel@chromium.org71e12a92012-02-14 02:34:15 +0000344 '--message', description
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000345 ] + args + [
346 '--cc', 'joe@example.com',
iannucci@chromium.org79540052012-10-19 23:15:26 +0000347 '--git_similarity', similarity or '50'
348 ] + (['--git_no_find_copies'] if find_copies == False else []) + [
sbc@chromium.org5e07e062013-02-28 23:55:44 +0000349 'fake_ancestor_sha', 'HEAD'
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000350 ]
351
352 def _run_reviewer_test(
353 self,
354 upload_args,
355 expected_description,
356 returned_description,
357 final_description,
358 reviewers):
359 """Generic reviewer test framework."""
iannucci@chromium.org53937ba2012-10-02 18:20:43 +0000360 try:
361 similarity = upload_args[upload_args.index('--similarity')+1]
362 except ValueError:
363 similarity = None
iannucci@chromium.org79540052012-10-19 23:15:26 +0000364
365 if '--find-copies' in upload_args:
366 find_copies = True
367 elif '--no-find-copies' in upload_args:
368 find_copies = False
369 else:
370 find_copies = None
371
372 self.calls = self._upload_calls(similarity, find_copies)
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000373 def RunEditor(desc, _, **kwargs):
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000374 self.assertEquals(
375 '# Enter a description of the change.\n'
janx@chromium.org104b2db2013-04-18 12:58:40 +0000376 '# This will be displayed on the codereview site.\n'
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000377 '# The first line will also be used as the subject of the review.\n' +
378 expected_description,
379 desc)
380 return returned_description
381 self.mock(git_cl.gclient_utils, 'RunEditor', RunEditor)
382 def check_upload(args):
iannucci@chromium.org79540052012-10-19 23:15:26 +0000383 cmd_line = self._cmd_line(final_description, reviewers, similarity,
384 find_copies)
iannucci@chromium.org53937ba2012-10-02 18:20:43 +0000385 self.assertEquals(cmd_line, args)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000386 return 1, 2
387 self.mock(git_cl.upload, 'RealMain', check_upload)
388 git_cl.main(['upload'] + upload_args)
389
390 def test_no_reviewer(self):
391 self._run_reviewer_test(
392 [],
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000393 'desc\n\nBUG=',
394 '# Blah blah comment.\ndesc\n\nBUG=',
395 'desc\n\nBUG=',
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000396 [])
397
iannucci@chromium.org53937ba2012-10-02 18:20:43 +0000398 def test_keep_similarity(self):
399 self._run_reviewer_test(
400 ['--similarity', '70'],
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000401 'desc\n\nBUG=',
402 '# Blah blah comment.\ndesc\n\nBUG=',
403 'desc\n\nBUG=',
iannucci@chromium.org53937ba2012-10-02 18:20:43 +0000404 [])
405
iannucci@chromium.org79540052012-10-19 23:15:26 +0000406 def test_keep_find_copies(self):
407 self._run_reviewer_test(
408 ['--no-find-copies'],
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000409 'desc\n\nBUG=',
iannucci@chromium.org79540052012-10-19 23:15:26 +0000410 '# Blah blah comment.\ndesc\n\nBUG=\n',
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000411 'desc\n\nBUG=',
iannucci@chromium.org79540052012-10-19 23:15:26 +0000412 [])
413
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000414 def test_reviewers_cmd_line(self):
415 # Reviewer is passed as-is
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000416 description = 'desc\n\nR=foo@example.com\nBUG='
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000417 self._run_reviewer_test(
418 ['-r' 'foo@example.com'],
419 description,
420 '\n%s\n' % description,
421 description,
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000422 ['--reviewers=foo@example.com'])
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000423
424 def test_reviewer_tbr_overriden(self):
425 # Reviewer is overriden with TBR
426 # Also verifies the regexp work without a trailing LF
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000427 description = 'Foo Bar\n\nTBR=reviewer@example.com'
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000428 self._run_reviewer_test(
429 ['-r' 'foo@example.com'],
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000430 'desc\n\nR=foo@example.com\nBUG=',
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000431 description.strip('\n'),
432 description,
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000433 ['--reviewers=reviewer@example.com'])
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000434
435 def test_reviewer_multiple(self):
436 # Handles multiple R= or TBR= lines.
437 description = (
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000438 'Foo Bar\nTBR=reviewer@example.com\nBUG=\nR=another@example.com')
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000439 self._run_reviewer_test(
440 [],
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000441 'desc\n\nBUG=',
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000442 description,
443 description,
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000444 ['--reviewers=another@example.com,reviewer@example.com'])
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000445
maruel@chromium.orga3353652011-11-30 14:26:57 +0000446 def test_reviewer_send_mail(self):
447 # --send-mail can be used without -r if R= is used
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000448 description = 'Foo Bar\nR=reviewer@example.com'
maruel@chromium.orga3353652011-11-30 14:26:57 +0000449 self._run_reviewer_test(
450 ['--send-mail'],
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000451 'desc\n\nBUG=',
maruel@chromium.orga3353652011-11-30 14:26:57 +0000452 description.strip('\n'),
453 description,
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000454 ['--reviewers=reviewer@example.com', '--send_mail'])
maruel@chromium.orga3353652011-11-30 14:26:57 +0000455
456 def test_reviewer_send_mail_no_rev(self):
457 # Fails without a reviewer.
458 class FileMock(object):
459 buf = StringIO.StringIO()
460 def write(self, content):
461 self.buf.write(content)
462
463 mock = FileMock()
464 try:
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000465 self.calls = self._upload_no_rev_calls(None, None)
466 def RunEditor(desc, _, **kwargs):
maruel@chromium.orga3353652011-11-30 14:26:57 +0000467 return desc
468 self.mock(git_cl.gclient_utils, 'RunEditor', RunEditor)
469 self.mock(sys, 'stderr', mock)
470 git_cl.main(['upload', '--send-mail'])
471 self.fail()
472 except SystemExit:
473 self.assertEquals(
474 'Must specify reviewers to send email.\n', mock.buf.getvalue())
475
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000476 def test_dcommit(self):
477 self.calls = (
478 self._dcommit_calls_1() +
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000479 self._git_sanity_checks('fake_ancestor_sha', 'working') +
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000480 self._dcommit_calls_normal() +
481 self._dcommit_calls_3())
482 git_cl.main(['dcommit'])
483
484 def test_dcommit_bypass_hooks(self):
485 self.calls = (
486 self._dcommit_calls_1() +
487 self._dcommit_calls_bypassed() +
488 self._dcommit_calls_3())
489 git_cl.main(['dcommit', '--bypass-hooks'])
490
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000491
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000492 @classmethod
493 def _gerrit_base_calls(cls):
ukai@chromium.orge8077812012-02-03 03:41:46 +0000494 return [
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000495 ((['git', '--no-pager',
496 'config', 'rietveld.server'],), 'codereview.example.com'),
497 ((['git', '--no-pager', 'symbolic-ref', 'HEAD'],), 'master'),
498 ((['git', '--no-pager', 'config', '--int', '--get',
iannucci@chromium.org53937ba2012-10-02 18:20:43 +0000499 'branch.master.git-cl-similarity'],), ''),
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000500 ((['git', '--no-pager', 'symbolic-ref', 'HEAD'],), 'master'),
501 ((['git', '--no-pager', 'config', '--int', '--get',
iannucci@chromium.org79540052012-10-19 23:15:26 +0000502 'branch.master.git-find-copies'],), ''),
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000503 ((['git', '--no-pager', 'update-index', '--refresh', '-q'],), ''),
504 ((['git', '--no-pager', 'diff-index', '--name-status', 'HEAD'],), ''),
505 ((['git', '--no-pager', 'symbolic-ref', 'HEAD'],), 'master'),
506 ((['git', '--no-pager', 'config', 'branch.master.merge'],), 'master'),
507 ((['git', '--no-pager', 'config', 'branch.master.remote'],), 'origin'),
508 ((['git', '--no-pager',
509 'merge-base', 'master', 'HEAD'],), 'fake_ancestor_sha'),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000510 ] + cls._git_sanity_checks('fake_ancestor_sha', 'master') + [
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000511 ((['git', '--no-pager', 'rev-parse', '--show-cdup'],), ''),
512 ((['git', '--no-pager', 'rev-parse', 'HEAD'],), '12345'),
513 ((['git', '--no-pager',
514 'diff', '--name-status', '-r', 'fake_ancestor_sha...', '.'],),
ukai@chromium.orge8077812012-02-03 03:41:46 +0000515 'M\t.gitignore\n'),
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000516 ((['git', '--no-pager', 'config', 'branch.master.rietveldissue'],), ''),
517 ((['git', '--no-pager',
518 'config', 'branch.master.rietveldpatchset'],), ''),
519 ((['git', '--no-pager',
520 'log', '--pretty=format:%s%n%n%b', 'fake_ancestor_sha...'],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000521 'foo'),
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000522 ((['git', '--no-pager', 'config', 'user.email'],), 'me@example.com'),
523 ((['git', '--no-pager',
524 'diff', '--no-ext-diff', '--stat', '--find-copies-harder',
sbc@chromium.org5e07e062013-02-28 23:55:44 +0000525 '-l100000', '-C50', 'fake_ancestor_sha', 'HEAD'],),
ukai@chromium.orge8077812012-02-03 03:41:46 +0000526 '+dat'),
527 ]
528
529 @staticmethod
530 def _gerrit_upload_calls(description, reviewers):
531 calls = [
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000532 ((['git', '--no-pager', 'config', 'gerrit.host'],),
533 'gerrit.example.com'),
534 ((['git', '--no-pager', 'log', '--pretty=format:%s\n\n%b',
sbc@chromium.org5e07e062013-02-28 23:55:44 +0000535 'fake_ancestor_sha..HEAD'],),
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000536 description)
537 ]
538 if git_cl.CHANGE_ID not in description:
539 calls += [
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000540 ((['git', '--no-pager', 'log', '--pretty=format:%s\n\n%b',
sbc@chromium.org5e07e062013-02-28 23:55:44 +0000541 'fake_ancestor_sha..HEAD'],),
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000542 description),
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000543 ((['git', '--no-pager', 'commit', '--amend', '-m', description],),
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000544 ''),
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000545 ((['git', '--no-pager', 'log', '--pretty=format:%s\n\n%b',
sbc@chromium.org5e07e062013-02-28 23:55:44 +0000546 'fake_ancestor_sha..HEAD'],),
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000547 description)
548 ]
549 calls += [
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000550 ((['git', '--no-pager', 'config', 'rietveld.cc'],), '')
ukai@chromium.orge8077812012-02-03 03:41:46 +0000551 ]
ukai@chromium.org19bbfa22012-02-03 16:18:11 +0000552 receive_pack = '--receive-pack=git receive-pack '
ukai@chromium.orge8077812012-02-03 03:41:46 +0000553 receive_pack += '--cc=joe@example.com' # from watch list
554 if reviewers:
555 receive_pack += ' '
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000556 receive_pack += ' '.join(
557 '--reviewer=' + email for email in sorted(reviewers))
ukai@chromium.org19bbfa22012-02-03 16:18:11 +0000558 receive_pack += ''
ukai@chromium.orge8077812012-02-03 03:41:46 +0000559 calls += [
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000560 ((['git', '--no-pager',
561 'push', receive_pack, 'origin', 'HEAD:refs/for/master'],),
ukai@chromium.orge8077812012-02-03 03:41:46 +0000562 '')
563 ]
564 return calls
565
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000566 def _run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +0000567 self,
568 upload_args,
569 description,
570 reviewers):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000571 """Generic gerrit upload test framework."""
ukai@chromium.orge8077812012-02-03 03:41:46 +0000572 self.calls = self._gerrit_base_calls()
573 self.calls += self._gerrit_upload_calls(description, reviewers)
574 git_cl.main(['upload'] + upload_args)
575
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000576 def test_gerrit_upload_without_change_id(self):
577 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +0000578 [],
jamesr@chromium.org35d1a842012-07-27 00:20:43 +0000579 'desc\n\nBUG=\n',
ukai@chromium.orge8077812012-02-03 03:41:46 +0000580 [])
581
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000582 def test_gerrit_no_reviewer(self):
583 self._run_gerrit_upload_test(
584 [],
585 'desc\n\nBUG=\nChange-Id:123456789\n',
586 [])
587
ukai@chromium.orge8077812012-02-03 03:41:46 +0000588 def test_gerrit_reviewers_cmd_line(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000589 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +0000590 ['-r', 'foo@example.com'],
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000591 'desc\n\nBUG=\nChange-Id:123456789',
ukai@chromium.orge8077812012-02-03 03:41:46 +0000592 ['foo@example.com'])
593
594 def test_gerrit_reviewer_multiple(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000595 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +0000596 [],
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000597 'desc\nTBR=reviewer@example.com\nBUG=\nR=another@example.com\n'
598 'Change-Id:123456789\n',
ukai@chromium.orge8077812012-02-03 03:41:46 +0000599 ['reviewer@example.com', 'another@example.com'])
600
601
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000602 def test_config_gerrit_download_hook(self):
603 self.mock(git_cl, 'FindCodereviewSettingsFile', CodereviewSettingsFileMock)
604 def ParseCodereviewSettingsContent(content):
605 keyvals = {}
606 keyvals['CODE_REVIEW_SERVER'] = 'gerrit.chromium.org'
607 keyvals['GERRIT_HOST'] = 'gerrit.chromium.org'
608 keyvals['GERRIT_PORT'] = '29418'
609 return keyvals
610 self.mock(git_cl.gclient_utils, 'ParseCodereviewSettingsContent',
611 ParseCodereviewSettingsContent)
612 self.mock(git_cl.os, 'access', self._mocked_call)
613 self.mock(git_cl.os, 'chmod', self._mocked_call)
ukai@chromium.org91655502012-05-25 01:46:07 +0000614 src_dir = os.path.join(os.path.sep, 'usr', 'local', 'src')
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000615 def AbsPath(path):
ukai@chromium.org91655502012-05-25 01:46:07 +0000616 if not path.startswith(os.path.sep):
617 return os.path.join(src_dir, path)
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000618 return path
619 self.mock(git_cl.os.path, 'abspath', AbsPath)
ukai@chromium.org91655502012-05-25 01:46:07 +0000620 commit_msg_path = os.path.join(src_dir, '.git', 'hooks', 'commit-msg')
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000621 def Exists(path):
ukai@chromium.org91655502012-05-25 01:46:07 +0000622 if path == commit_msg_path:
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000623 return False
624 # others paths, such as /usr/share/locale/....
625 return True
626 self.mock(git_cl.os.path, 'exists', Exists)
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +0000627 self.mock(git_cl, 'urlretrieve', self._mocked_call)
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000628 self.calls = [
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000629 ((['git', '--no-pager', 'config', 'rietveld.server',
630 'gerrit.chromium.org'],), ''),
631 ((['git', '--no-pager', 'config', '--unset-all', 'rietveld.cc'],), ''),
632 ((['git', '--no-pager', 'config', '--unset-all',
633 'rietveld.tree-status-url'],), ''),
634 ((['git', '--no-pager', 'config', '--unset-all',
635 'rietveld.viewvc-url'],), ''),
636 ((['git', '--no-pager', 'config', 'gerrit.host',
637 'gerrit.chromium.org'],), ''),
638 ((['git', '--no-pager', 'config', 'gerrit.port', '29418'],), ''),
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000639 # DownloadHooks(False)
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000640 ((['git', '--no-pager', 'config', 'gerrit.host'],),
641 'gerrit.chromium.org'),
642 ((['git', '--no-pager', 'config', 'rietveld.server'],),
643 'gerrit.chromium.org'),
644 ((['git', '--no-pager', 'rev-parse', '--show-cdup'],), ''),
ukai@chromium.org91655502012-05-25 01:46:07 +0000645 ((commit_msg_path, os.X_OK,), False),
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000646 (('https://gerrit.chromium.org/tools/hooks/commit-msg',
ukai@chromium.org91655502012-05-25 01:46:07 +0000647 commit_msg_path,), ''),
648 ((commit_msg_path, stat.S_IRUSR | stat.S_IWUSR | stat.S_IXUSR,), ''),
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000649 # GetCodereviewSettingsInteractively
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000650 ((['git', '--no-pager', 'config', 'rietveld.server'],),
651 'gerrit.chromium.org'),
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000652 (('Rietveld server (host[:port]) [https://gerrit.chromium.org]:',),
653 ''),
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000654 ((['git', '--no-pager', 'config', 'rietveld.cc'],), ''),
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000655 (('CC list:',), ''),
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000656 ((['git', '--no-pager', 'config', 'rietveld.tree-status-url'],), ''),
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000657 (('Tree status URL:',), ''),
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000658 ((['git', '--no-pager', 'config', 'rietveld.viewvc-url'],), ''),
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000659 (('ViewVC URL:',), ''),
660 # DownloadHooks(True)
ukai@chromium.org91655502012-05-25 01:46:07 +0000661 ((commit_msg_path, os.X_OK,), True),
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000662 ]
663 git_cl.main(['config'])
664
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000665 def test_update_reviewers(self):
666 data = [
667 ('foo', [], 'foo'),
668 ('foo', ['a@c'], 'foo\n\nR=a@c'),
669 ('foo\nBUG=', ['a@c'], 'foo\nBUG=\nR=a@c'),
670 ('foo\nR=xx\nTBR=yy\nR=bar', ['a@c'], 'foo\nTBR=a@c'),
671 ('foo', ['a@c', 'b@c'], 'foo\n\nR=a@c, b@c'),
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +0000672 ('foo\nBar\n\nR=\nBUG=', ['c@c'], 'foo\nBar\n\nR=c@c\nBUG='),
673 ('foo\nBar\n\nR=\nBUG=\nR=', ['c@c'], 'foo\nBar\n\nR=c@c\nBUG='),
674 # Same as the line before, but full of whitespaces.
675 (
676 'foo\nBar\n\n R = \n BUG = \n R = ', ['c@c'],
677 'foo\nBar\n\nR=c@c\n BUG =',
678 ),
679 # Whitespaces aren't interpreted as new lines.
680 ('foo BUG=allo R=joe ', ['c@c'], 'foo BUG=allo R=joe\n\nR=c@c'),
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000681 ]
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +0000682 expected = [i[2] for i in data]
683 actual = []
684 for orig, reviewers, _expected in data:
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000685 obj = git_cl.ChangeDescription(orig)
686 obj.update_reviewers(reviewers)
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +0000687 actual.append(obj.description)
688 self.assertEqual(expected, actual)
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000689
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000690
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000691if __name__ == '__main__':
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000692 git_cl.logging.basicConfig(
693 level=git_cl.logging.DEBUG if '-v' in sys.argv else git_cl.logging.ERROR)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000694 unittest.main()