blob: a88c5e3a2a7be6910601109769b8f8a1950c462e [file] [log] [blame]
Edward Lemur0db01f02019-11-12 22:01:51 +00001#!/usr/bin/env vpython3
2# coding=utf-8
maruel@chromium.orgeb5edbc2012-01-16 17:03:28 +00003# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@chromium.orgddd59412011-11-30 14:20:38 +00004# Use of this source code is governed by a BSD-style license that can be
5# found in the LICENSE file.
6
7"""Unit tests for git_cl.py."""
8
Edward Lemur85153282020-02-14 22:06:29 +00009from __future__ import print_function
Edward Lemur0db01f02019-11-12 22:01:51 +000010from __future__ import unicode_literals
11
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +010012import datetime
tandriide281ae2016-10-12 06:02:30 -070013import json
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +010014import logging
Edward Lemur61bf4172020-02-24 23:22:37 +000015import multiprocessing
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000016import optparse
maruel@chromium.orgddd59412011-11-30 14:20:38 +000017import os
Edward Lemur85153282020-02-14 22:06:29 +000018import pprint
Brian Sheedy59b06a82019-10-14 17:03:29 +000019import shutil
maruel@chromium.orgddd59412011-11-30 14:20:38 +000020import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070021import tempfile
maruel@chromium.orgddd59412011-11-30 14:20:38 +000022import unittest
23
Edward Lemura8145022020-01-06 18:47:54 +000024if sys.version_info.major == 2:
25 from StringIO import StringIO
26 import mock
27else:
28 from io import StringIO
29 from unittest import mock
30
maruel@chromium.orgddd59412011-11-30 14:20:38 +000031sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
32
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000033import metrics
Edward Lesmes9c349062021-05-06 20:02:39 +000034import metrics_utils
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000035# We have to disable monitoring before importing git_cl.
Edward Lesmes9c349062021-05-06 20:02:39 +000036metrics_utils.COLLECT_METRICS = False
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000037
Jamie Madill5e96ad12020-01-13 16:08:35 +000038import clang_format
Edward Lemur227d5102020-02-25 23:45:35 +000039import contextlib
Edward Lemur1773f372020-02-22 00:27:14 +000040import gclient_utils
Eric Boren2fb63102018-10-05 13:05:03 +000041import gerrit_util
maruel@chromium.orgddd59412011-11-30 14:20:38 +000042import git_cl
iannucci@chromium.org9e849272014-04-04 00:31:55 +000043import git_common
tandrii@chromium.org57d86542016-03-04 16:11:32 +000044import git_footers
Edward Lemur85153282020-02-14 22:06:29 +000045import git_new_branch
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +000046import owners_client
Edward Lemur85153282020-02-14 22:06:29 +000047import scm
maruel@chromium.orgddd59412011-11-30 14:20:38 +000048import subprocess2
maruel@chromium.orgddd59412011-11-30 14:20:38 +000049
Josip Sokcevic464e9ff2020-03-18 23:48:55 +000050NETRC_FILENAME = '_netrc' if sys.platform == 'win32' else '.netrc'
51
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000052
Edward Lemur0db01f02019-11-12 22:01:51 +000053def callError(code=1, cmd='', cwd='', stdout=b'', stderr=b''):
tandrii5d48c322016-08-18 16:19:37 -070054 return subprocess2.CalledProcessError(code, cmd, cwd, stdout, stderr)
55
tandrii5d48c322016-08-18 16:19:37 -070056CERR1 = callError(1)
57
58
Edward Lemur1773f372020-02-22 00:27:14 +000059class TemporaryFileMock(object):
60 def __init__(self):
61 self.suffix = 0
Aaron Gable9a03ae02017-11-03 11:31:07 -070062
Edward Lemur1773f372020-02-22 00:27:14 +000063 @contextlib.contextmanager
64 def __call__(self):
65 self.suffix += 1
66 yield '/tmp/fake-temp' + str(self.suffix)
Aaron Gable9a03ae02017-11-03 11:31:07 -070067
68
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000069class ChangelistMock(object):
70 # A class variable so we can access it when we don't have access to the
71 # instance that's being set.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000072 desc = ''
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000073
Dirk Pranke6f0df682021-06-25 00:42:33 +000074 def __init__(self, gerrit_change=None, use_python3=False, **kwargs):
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000075 self._gerrit_change = gerrit_change
Dirk Pranke6f0df682021-06-25 00:42:33 +000076 self._use_python3 = use_python3
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000077
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000078 def GetIssue(self):
79 return 1
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000080
Edward Lemur6c6827c2020-02-06 21:15:18 +000081 def FetchDescription(self):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000082 return ChangelistMock.desc
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000083
dsansomee2d6fd92016-09-08 00:10:47 -070084 def UpdateDescription(self, desc, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000085 ChangelistMock.desc = desc
86
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000087 def GetGerritChange(self, patchset=None, **kwargs):
88 del patchset
89 return self._gerrit_change
90
Josip Sokcevic9011a5b2021-02-12 18:59:44 +000091 def GetRemoteBranch(self):
92 return ('origin', 'refs/remotes/origin/main')
93
Dirk Pranke6f0df682021-06-25 00:42:33 +000094 def GetUsePython3(self):
95 return self._use_python3
tandrii5d48c322016-08-18 16:19:37 -070096
Edward Lemur85153282020-02-14 22:06:29 +000097class GitMocks(object):
98 def __init__(self, config=None, branchref=None):
Josip Sokcevic7e133ff2021-07-13 17:44:53 +000099 self.branchref = branchref or 'refs/heads/main'
Edward Lemur85153282020-02-14 22:06:29 +0000100 self.config = config or {}
101
102 def GetBranchRef(self, _root):
103 return self.branchref
104
105 def NewBranch(self, branchref):
106 self.branchref = branchref
107
Edward Lemur26964072020-02-19 19:18:51 +0000108 def GetConfig(self, root, key, default=None):
109 if root != '':
110 key = '%s:%s' % (root, key)
Edward Lemur85153282020-02-14 22:06:29 +0000111 return self.config.get(key, default)
112
Edward Lemur26964072020-02-19 19:18:51 +0000113 def SetConfig(self, root, key, value=None):
114 if root != '':
115 key = '%s:%s' % (root, key)
Edward Lemur85153282020-02-14 22:06:29 +0000116 if value:
117 self.config[key] = value
118 return
119 if key not in self.config:
120 raise CERR1
121 del self.config[key]
122
123
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000124class WatchlistsMock(object):
125 def __init__(self, _):
126 pass
127 @staticmethod
128 def GetWatchersForPaths(_):
129 return ['joe@example.com']
130
131
Edward Lemur4c707a22019-09-24 21:13:43 +0000132class CodereviewSettingsFileMock(object):
133 def __init__(self):
134 pass
135 # pylint: disable=no-self-use
136 def read(self):
137 return ('CODE_REVIEW_SERVER: gerrit.chromium.org\n' +
138 'GERRIT_HOST: True\n')
139
140
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000141class AuthenticatorMock(object):
142 def __init__(self, *_args):
143 pass
144 def has_cached_credentials(self):
145 return True
tandrii221ab252016-10-06 08:12:04 -0700146 def authorize(self, http):
147 return http
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000148
149
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100150def CookiesAuthenticatorMockFactory(hosts_with_creds=None, same_auth=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000151 """Use to mock Gerrit/Git credentials from ~/.netrc or ~/.gitcookies.
152
153 Usage:
154 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100155 CookiesAuthenticatorMockFactory({'host': ('user', _, 'pass')})
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000156
157 OR
158 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100159 CookiesAuthenticatorMockFactory(
160 same_auth=('user', '', 'pass'))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000161 """
162 class CookiesAuthenticatorMock(git_cl.gerrit_util.CookiesAuthenticator):
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800163 def __init__(self): # pylint: disable=super-init-not-called
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000164 # Intentionally not calling super() because it reads actual cookie files.
165 pass
166 @classmethod
167 def get_gitcookies_path(cls):
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000168 return os.path.join('~', '.gitcookies')
169
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000170 @classmethod
171 def get_netrc_path(cls):
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000172 return os.path.join('~', NETRC_FILENAME)
173
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100174 def _get_auth_for_host(self, host):
175 if same_auth:
176 return same_auth
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000177 return (hosts_with_creds or {}).get(host)
178 return CookiesAuthenticatorMock
179
Aaron Gable9a03ae02017-11-03 11:31:07 -0700180
kmarshall9249e012016-08-23 12:02:16 -0700181class MockChangelistWithBranchAndIssue():
182 def __init__(self, branch, issue):
183 self.branch = branch
184 self.issue = issue
185 def GetBranch(self):
186 return self.branch
187 def GetIssue(self):
188 return self.issue
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000189
tandriic2405f52016-10-10 08:13:15 -0700190
191class SystemExitMock(Exception):
192 pass
193
194
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000195class TestGitClBasic(unittest.TestCase):
Josip Sokcevic953278a2020-02-28 19:46:36 +0000196 def setUp(self):
197 mock.patch('sys.exit', side_effect=SystemExitMock).start()
198 mock.patch('sys.stdout', StringIO()).start()
199 mock.patch('sys.stderr', StringIO()).start()
200 self.addCleanup(mock.patch.stopall)
201
202 def test_die_with_error(self):
203 with self.assertRaises(SystemExitMock):
204 git_cl.DieWithError('foo', git_cl.ChangeDescription('lorem ipsum'))
205 self.assertEqual(sys.stderr.getvalue(), 'foo\n')
206 self.assertTrue('saving CL description' in sys.stdout.getvalue())
207 self.assertTrue('Content of CL description' in sys.stdout.getvalue())
208 self.assertTrue('lorem ipsum' in sys.stdout.getvalue())
209 sys.exit.assert_called_once_with(1)
210
211 def test_die_with_error_no_desc(self):
212 with self.assertRaises(SystemExitMock):
213 git_cl.DieWithError('foo')
214 self.assertEqual(sys.stderr.getvalue(), 'foo\n')
215 self.assertEqual(sys.stdout.getvalue(), '')
216 sys.exit.assert_called_once_with(1)
217
Edward Lemur6c6827c2020-02-06 21:15:18 +0000218 def test_fetch_description(self):
Edward Lemurf38bc172019-09-03 21:02:13 +0000219 cl = git_cl.Changelist(issue=1, codereview_host='host')
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100220 cl.description = 'x'
Edward Lemur6c6827c2020-02-06 21:15:18 +0000221 self.assertEqual(cl.FetchDescription(), 'x')
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700222
Edward Lemur61bf4172020-02-24 23:22:37 +0000223 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
224 @mock.patch('git_cl.Changelist.GetStatus', lambda cl: cl.status)
225 def test_get_cl_statuses(self, *_mocks):
226 statuses = [
227 'closed', 'commit', 'dry-run', 'lgtm', 'reply', 'unsent', 'waiting']
228 changes = []
229 for status in statuses:
230 cl = git_cl.Changelist()
231 cl.status = status
232 changes.append(cl)
233
234 actual = set(git_cl.get_cl_statuses(changes, True))
235 self.assertEqual(set(zip(changes, statuses)), actual)
236
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000237 def test_upload_to_non_default_branch_no_retry(self):
238 m = mock.patch('git_cl.Changelist._CMDUploadChange',
239 side_effect=[git_cl.GitPushError(), None]).start()
240 mock.patch('git_cl.Changelist.GetRemoteBranch',
241 return_value=('foo', 'bar')).start()
Edward Lesmeseeca9c62020-11-20 00:00:17 +0000242 mock.patch('git_cl.Changelist.GetGerritProject',
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000243 return_value='foo').start()
244 mock.patch('git_cl.gerrit_util.GetProjectHead',
245 return_value='refs/heads/main').start()
246
247 cl = git_cl.Changelist()
248 options = optparse.Values()
Josip Sokcevicb631a882021-01-06 18:18:10 +0000249 options.target_branch = 'refs/heads/bar'
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000250 with self.assertRaises(SystemExitMock):
251 cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
252
253 # ensure upload is called once
254 self.assertEqual(len(m.mock_calls), 1)
255 sys.exit.assert_called_once_with(1)
256 # option not set as retry didn't happen
257 self.assertFalse(hasattr(options, 'force'))
258 self.assertFalse(hasattr(options, 'edit_description'))
259
260 def test_upload_to_old_default_still_active(self):
261 m = mock.patch('git_cl.Changelist._CMDUploadChange',
262 side_effect=[git_cl.GitPushError(), None]).start()
263 mock.patch('git_cl.Changelist.GetRemoteBranch',
264 return_value=('foo', git_cl.DEFAULT_OLD_BRANCH)).start()
Edward Lesmeseeca9c62020-11-20 00:00:17 +0000265 mock.patch('git_cl.Changelist.GetGerritProject',
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000266 return_value='foo').start()
267 mock.patch('git_cl.gerrit_util.GetProjectHead',
Josip Sokcevic7e133ff2021-07-13 17:44:53 +0000268 return_value='refs/heads/main').start()
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000269
270 cl = git_cl.Changelist()
271 options = optparse.Values()
Josip Sokcevic7e133ff2021-07-13 17:44:53 +0000272 options.target_branch = 'refs/heads/main'
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000273 with self.assertRaises(SystemExitMock):
274 cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
275
276 # ensure upload is called once
277 self.assertEqual(len(m.mock_calls), 1)
278 sys.exit.assert_called_once_with(1)
279 # option not set as retry didn't happen
280 self.assertFalse(hasattr(options, 'force'))
281 self.assertFalse(hasattr(options, 'edit_description'))
282
Gavin Mak68e6cf32021-01-25 18:24:08 +0000283 def test_upload_with_message_file_no_editor(self):
284 m = mock.patch('git_cl.ChangeDescription.prompt',
285 return_value=None).start()
286 mock.patch('git_cl.Changelist.GetRemoteBranch',
287 return_value=('foo', git_cl.DEFAULT_NEW_BRANCH)).start()
288 mock.patch('git_cl.GetTargetRef',
289 return_value='refs/heads/main').start()
290 mock.patch('git_cl.Changelist._GerritCommitMsgHookCheck',
291 lambda _, offer_removal: None).start()
292 mock.patch('git_cl.Changelist.GetIssue', return_value=None).start()
293 mock.patch('git_cl.Changelist.GetBranch',
294 side_effect=SystemExitMock).start()
295 mock.patch('git_cl.GenerateGerritChangeId', return_value=None).start()
296 mock.patch('git_cl.RunGit').start()
297
298 cl = git_cl.Changelist()
299 options = optparse.Values()
Josip Sokcevic7e133ff2021-07-13 17:44:53 +0000300 options.target_branch = 'refs/heads/main'
Gavin Mak68e6cf32021-01-25 18:24:08 +0000301 options.squash = True
302 options.edit_description = False
303 options.force = False
304 options.preserve_tryjobs = False
305 options.message_file = "message.txt"
306
307 with self.assertRaises(SystemExitMock):
308 cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
309 self.assertEqual(len(m.mock_calls), 0)
310
311 options.message_file = None
312 with self.assertRaises(SystemExitMock):
313 cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
314 self.assertEqual(len(m.mock_calls), 1)
315
Edward Lemur61bf4172020-02-24 23:22:37 +0000316 def test_get_cl_statuses_no_changes(self):
317 self.assertEqual([], list(git_cl.get_cl_statuses([], True)))
318
319 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
320 @mock.patch('multiprocessing.pool.ThreadPool')
321 def test_get_cl_statuses_timeout(self, *_mocks):
322 changes = [git_cl.Changelist() for _ in range(2)]
323 pool = multiprocessing.pool.ThreadPool()
324 it = pool.imap_unordered.return_value.__iter__ = mock.Mock()
325 it.return_value.next.side_effect = [
326 (changes[0], 'lgtm'),
327 multiprocessing.TimeoutError,
328 ]
329
330 actual = list(git_cl.get_cl_statuses(changes, True))
331 self.assertEqual([(changes[0], 'lgtm'), (changes[1], 'error')], actual)
332
333 @mock.patch('git_cl.Changelist.GetIssueURL')
334 def test_get_cl_statuses_not_finegrained(self, _mock):
335 changes = [git_cl.Changelist() for _ in range(2)]
336 urls = ['some-url', None]
337 git_cl.Changelist.GetIssueURL.side_effect = urls
338
339 actual = set(git_cl.get_cl_statuses(changes, False))
340 self.assertEqual(
341 set([(changes[0], 'waiting'), (changes[1], 'error')]), actual)
342
Andrii Shyshkalov1ee78cd2020-03-12 01:31:53 +0000343 def test_get_issue_url(self):
344 cl = git_cl.Changelist(issue=123)
345 cl._gerrit_server = 'https://example.com'
346 self.assertEqual(cl.GetIssueURL(), 'https://example.com/123')
347 self.assertEqual(cl.GetIssueURL(short=True), 'https://example.com/123')
348
349 cl = git_cl.Changelist(issue=123)
350 cl._gerrit_server = 'https://chromium-review.googlesource.com'
351 self.assertEqual(cl.GetIssueURL(),
352 'https://chromium-review.googlesource.com/123')
353 self.assertEqual(cl.GetIssueURL(short=True), 'https://crrev.com/c/123')
354
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +0000355 def test_set_preserve_tryjobs(self):
356 d = git_cl.ChangeDescription('Simple.')
357 d.set_preserve_tryjobs()
358 self.assertEqual(d.description.splitlines(), [
359 'Simple.',
360 '',
361 'Cq-Do-Not-Cancel-Tryjobs: true',
362 ])
363 before = d.description
364 d.set_preserve_tryjobs()
365 self.assertEqual(before, d.description)
366
367 d = git_cl.ChangeDescription('\n'.join([
368 'One is enough',
369 '',
370 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
371 'Change-Id: Ideadbeef',
372 ]))
373 d.set_preserve_tryjobs()
374 self.assertEqual(d.description.splitlines(), [
375 'One is enough',
376 '',
377 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
378 'Change-Id: Ideadbeef',
379 'Cq-Do-Not-Cancel-Tryjobs: true',
380 ])
381
tandriif9aefb72016-07-01 09:06:51 -0700382 def test_get_bug_line_values(self):
383 f = lambda p, bugs: list(git_cl._get_bug_line_values(p, bugs))
384 self.assertEqual(f('', ''), [])
385 self.assertEqual(f('', '123,v8:456'), ['123', 'v8:456'])
Lei Zhang8a0efc12020-08-05 19:58:45 +0000386 # Prefix that ends with colon.
387 self.assertEqual(f('v8:', '456'), ['v8:456'])
388 self.assertEqual(f('v8:', 'chromium:123,456'), ['v8:456', 'chromium:123'])
389 # Prefix that ends without colon.
tandriif9aefb72016-07-01 09:06:51 -0700390 self.assertEqual(f('v8', '456'), ['v8:456'])
391 self.assertEqual(f('v8', 'chromium:123,456'), ['v8:456', 'chromium:123'])
392 # Not nice, but not worth carying.
Lei Zhang8a0efc12020-08-05 19:58:45 +0000393 self.assertEqual(f('v8:', 'chromium:123,456,v8:123'),
394 ['v8:456', 'chromium:123', 'v8:123'])
tandriif9aefb72016-07-01 09:06:51 -0700395 self.assertEqual(f('v8', 'chromium:123,456,v8:123'),
396 ['v8:456', 'chromium:123', 'v8:123'])
397
Edward Lemurda4b6c62020-02-13 00:28:40 +0000398 @mock.patch('gerrit_util.GetAccountDetails')
399 def test_valid_accounts(self, mockGetAccountDetails):
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000400 mock_per_account = {
401 'u1': None, # 404, doesn't exist.
402 'u2': {
403 '_account_id': 123124,
404 'avatars': [],
405 'email': 'u2@example.com',
406 'name': 'User Number 2',
407 'status': 'OOO',
408 },
409 'u3': git_cl.gerrit_util.GerritError(500, 'retries didn\'t help :('),
410 }
411 def GetAccountDetailsMock(_, account):
412 # Poor-man's mock library's side_effect.
413 v = mock_per_account.pop(account)
414 if isinstance(v, Exception):
415 raise v
416 return v
417
Edward Lemurda4b6c62020-02-13 00:28:40 +0000418 mockGetAccountDetails.side_effect = GetAccountDetailsMock
419 actual = git_cl.gerrit_util.ValidAccounts(
420 'host', ['u1', 'u2', 'u3'], max_threads=1)
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000421 self.assertEqual(actual, {
422 'u2': {
423 '_account_id': 123124,
424 'avatars': [],
425 'email': 'u2@example.com',
426 'name': 'User Number 2',
427 'status': 'OOO',
428 },
429 })
430
431
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200432class TestParseIssueURL(unittest.TestCase):
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000433 def _test(self, arg, issue=None, patchset=None, hostname=None, fail=False):
434 parsed = git_cl.ParseIssueNumberArgument(arg)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200435 self.assertIsNotNone(parsed)
436 if fail:
437 self.assertFalse(parsed.valid)
438 return
439 self.assertTrue(parsed.valid)
440 self.assertEqual(parsed.issue, issue)
441 self.assertEqual(parsed.patchset, patchset)
442 self.assertEqual(parsed.hostname, hostname)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200443
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000444 def test_basic(self):
445 self._test('123', 123)
446 self._test('', fail=True)
447 self._test('abc', fail=True)
448 self._test('123/1', fail=True)
449 self._test('123a', fail=True)
450 self._test('ssh://chrome-review.source.com/#/c/123/4/', fail=True)
451 self._test('ssh://chrome-review.source.com/c/123/1/', fail=True)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200452
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000453 def test_gerrit_url(self):
454 self._test('https://codereview.source.com/123', 123, None,
455 'codereview.source.com')
456 self._test('http://chrome-review.source.com/c/123', 123, None,
457 'chrome-review.source.com')
458 self._test('https://chrome-review.source.com/c/123/', 123, None,
459 'chrome-review.source.com')
460 self._test('https://chrome-review.source.com/c/123/4', 123, 4,
461 'chrome-review.source.com')
462 self._test('https://chrome-review.source.com/#/c/123/4', 123, 4,
463 'chrome-review.source.com')
464 self._test('https://chrome-review.source.com/c/123/4', 123, 4,
465 'chrome-review.source.com')
466 self._test('https://chrome-review.source.com/123', 123, None,
467 'chrome-review.source.com')
468 self._test('https://chrome-review.source.com/123/4', 123, 4,
469 'chrome-review.source.com')
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200470
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000471 self._test('https://chrome-review.source.com/bad/123/4', fail=True)
472 self._test('https://chrome-review.source.com/c/123/1/whatisthis', fail=True)
473 self._test('https://chrome-review.source.com/c/abc/', fail=True)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200474
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000475 def test_short_urls(self):
476 self._test('https://crrev.com/c/2151934', 2151934, None,
477 'chromium-review.googlesource.com')
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200478
479
Edward Lemurda4b6c62020-02-13 00:28:40 +0000480class GitCookiesCheckerTest(unittest.TestCase):
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100481 def setUp(self):
482 super(GitCookiesCheckerTest, self).setUp()
483 self.c = git_cl._GitCookiesChecker()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100484 self.c._all_hosts = []
Edward Lemurda4b6c62020-02-13 00:28:40 +0000485 mock.patch('sys.stdout', StringIO()).start()
486 self.addCleanup(mock.patch.stopall)
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100487
488 def mock_hosts_creds(self, subhost_identity_pairs):
489 def ensure_googlesource(h):
490 if not h.endswith(self.c._GOOGLESOURCE):
491 assert not h.endswith('.')
492 return h + '.' + self.c._GOOGLESOURCE
493 return h
494 self.c._all_hosts = [(ensure_googlesource(h), i, '.gitcookies')
495 for h, i in subhost_identity_pairs]
496
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200497 def test_identity_parsing(self):
498 self.assertEqual(self.c._parse_identity('ldap.google.com'),
499 ('ldap', 'google.com'))
500 self.assertEqual(self.c._parse_identity('git-ldap.example.com'),
501 ('ldap', 'example.com'))
502 # Specical case because we know there are no subdomains in chromium.org.
503 self.assertEqual(self.c._parse_identity('git-note.period.chromium.org'),
504 ('note.period', 'chromium.org'))
Lei Zhangd3f769a2017-12-15 15:16:14 -0800505 # Pathological: ".period." can be either username OR domain, more likely
506 # domain.
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200507 self.assertEqual(self.c._parse_identity('git-note.period.example.com'),
508 ('note', 'period.example.com'))
509
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100510 def test_analysis_nothing(self):
511 self.c._all_hosts = []
512 self.assertFalse(self.c.has_generic_host())
513 self.assertEqual(set(), self.c.get_conflicting_hosts())
514 self.assertEqual(set(), self.c.get_duplicated_hosts())
515 self.assertEqual(set(), self.c.get_partially_configured_hosts())
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100516
517 def test_analysis(self):
518 self.mock_hosts_creds([
519 ('.googlesource.com', 'git-example.chromium.org'),
520
521 ('chromium', 'git-example.google.com'),
522 ('chromium-review', 'git-example.google.com'),
523 ('chrome-internal', 'git-example.chromium.org'),
524 ('chrome-internal-review', 'git-example.chromium.org'),
525 ('conflict', 'git-example.google.com'),
526 ('conflict-review', 'git-example.chromium.org'),
527 ('dup', 'git-example.google.com'),
528 ('dup', 'git-example.google.com'),
529 ('dup-review', 'git-example.google.com'),
530 ('partial', 'git-example.google.com'),
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200531 ('gpartial-review', 'git-example.google.com'),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100532 ])
533 self.assertTrue(self.c.has_generic_host())
534 self.assertEqual(set(['conflict.googlesource.com']),
535 self.c.get_conflicting_hosts())
536 self.assertEqual(set(['dup.googlesource.com']),
537 self.c.get_duplicated_hosts())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200538 self.assertEqual(set(['partial.googlesource.com',
539 'gpartial-review.googlesource.com']),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100540 self.c.get_partially_configured_hosts())
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100541
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100542 def test_report_no_problems(self):
543 self.test_analysis_nothing()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100544 self.assertFalse(self.c.find_and_report_problems())
545 self.assertEqual(sys.stdout.getvalue(), '')
546
Edward Lemurda4b6c62020-02-13 00:28:40 +0000547 @mock.patch(
548 'git_cl.gerrit_util.CookiesAuthenticator.get_gitcookies_path',
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000549 return_value=os.path.join('~', '.gitcookies'))
Edward Lemurda4b6c62020-02-13 00:28:40 +0000550 def test_report(self, *_mocks):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100551 self.test_analysis()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100552 self.assertTrue(self.c.find_and_report_problems())
553 with open(os.path.join(os.path.dirname(__file__),
554 'git_cl_creds_check_report.txt')) as f:
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000555 expected = f.read() % {
556 'sep': os.sep,
557 }
558
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100559 def by_line(text):
560 return [l.rstrip() for l in text.rstrip().splitlines()]
Robert Iannucci456b0d62018-03-13 19:15:50 -0700561 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalov4812e612017-03-27 17:22:57 +0200562 self.assertEqual(by_line(sys.stdout.getvalue().strip()), by_line(expected))
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100563
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -0800564
Edward Lemurda4b6c62020-02-13 00:28:40 +0000565class TestGitCl(unittest.TestCase):
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000566 def setUp(self):
567 super(TestGitCl, self).setUp()
568 self.calls = []
tandrii9d206752016-06-20 11:32:47 -0700569 self._calls_done = []
Edward Lesmes0dd54822020-03-26 18:24:25 +0000570 self.failed = False
Edward Lemurda4b6c62020-02-13 00:28:40 +0000571 mock.patch('sys.stdout', StringIO()).start()
572 mock.patch(
573 'git_cl.time_time',
574 lambda: self._mocked_call('time.time')).start()
575 mock.patch(
576 'git_cl.metrics.collector.add_repeated',
577 lambda *a: self._mocked_call('add_repeated', *a)).start()
578 mock.patch('subprocess2.call', self._mocked_call).start()
579 mock.patch('subprocess2.check_call', self._mocked_call).start()
580 mock.patch('subprocess2.check_output', self._mocked_call).start()
581 mock.patch(
582 'subprocess2.communicate',
583 lambda *a, **_k: ([self._mocked_call(*a), ''], 0)).start()
584 mock.patch(
585 'git_cl.gclient_utils.CheckCallAndFilter',
586 self._mocked_call).start()
587 mock.patch('git_common.is_dirty_git_tree', lambda x: False).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +0000588 mock.patch('git_cl.FindCodereviewSettingsFile', return_value='').start()
589 mock.patch(
590 'git_cl.SaveDescriptionBackup',
591 lambda _: self._mocked_call('SaveDescriptionBackup')).start()
592 mock.patch(
Edward Lemurda4b6c62020-02-13 00:28:40 +0000593 'git_cl.write_json',
594 lambda *a: self._mocked_call('write_json', *a)).start()
595 mock.patch(
Edward Lemur227d5102020-02-25 23:45:35 +0000596 'git_cl.Changelist.RunHook',
597 return_value={'more_cc': ['test-more-cc@chromium.org']}).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +0000598 mock.patch('git_cl.watchlists.Watchlists', WatchlistsMock).start()
599 mock.patch('git_cl.auth.Authenticator', AuthenticatorMock).start()
Edward Lesmes7677e5c2020-02-19 20:39:03 +0000600 mock.patch('gerrit_util.GetChangeDetail').start()
Edward Lemurda4b6c62020-02-13 00:28:40 +0000601 mock.patch(
602 'git_cl.gerrit_util.GetChangeComments',
603 lambda *a: self._mocked_call('GetChangeComments', *a)).start()
604 mock.patch(
605 'git_cl.gerrit_util.GetChangeRobotComments',
606 lambda *a: self._mocked_call('GetChangeRobotComments', *a)).start()
607 mock.patch(
608 'git_cl.gerrit_util.AddReviewers',
609 lambda *a: self._mocked_call('AddReviewers', *a)).start()
610 mock.patch(
611 'git_cl.gerrit_util.SetReview',
612 lambda h, i, msg=None, labels=None, notify=None, ready=None: (
613 self._mocked_call(
614 'SetReview', h, i, msg, labels, notify, ready))).start()
615 mock.patch(
616 'git_cl.gerrit_util.LuciContextAuthenticator.is_luci',
617 return_value=False).start()
618 mock.patch(
619 'git_cl.gerrit_util.GceAuthenticator.is_gce',
620 return_value=False).start()
621 mock.patch(
622 'git_cl.gerrit_util.ValidAccounts',
623 lambda *a: self._mocked_call('ValidAccounts', *a)).start()
Edward Lemurd55c5072020-02-20 01:09:07 +0000624 mock.patch('sys.exit', side_effect=SystemExitMock).start()
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000625 mock.patch('git_cl.Settings.GetRoot', return_value='').start()
Edward Lemur85153282020-02-14 22:06:29 +0000626 self.mockGit = GitMocks()
627 mock.patch('scm.GIT.GetBranchRef', self.mockGit.GetBranchRef).start()
628 mock.patch('scm.GIT.GetConfig', self.mockGit.GetConfig).start()
Edward Lesmes50da7702020-03-30 19:23:43 +0000629 mock.patch('scm.GIT.ResolveCommit', return_value='hash').start()
630 mock.patch('scm.GIT.IsValidRevision', return_value=True).start()
Edward Lemur85153282020-02-14 22:06:29 +0000631 mock.patch('scm.GIT.SetConfig', self.mockGit.SetConfig).start()
Edward Lemur84101642020-02-21 21:40:34 +0000632 mock.patch(
633 'git_new_branch.create_new_branch', self.mockGit.NewBranch).start()
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000634 mock.patch(
Edward Lemur85153282020-02-14 22:06:29 +0000635 'scm.GIT.FetchUpstreamTuple',
Josip Sokcevic7e133ff2021-07-13 17:44:53 +0000636 return_value=('origin', 'refs/heads/main')).start()
Edward Lemur85153282020-02-14 22:06:29 +0000637 mock.patch(
638 'scm.GIT.CaptureStatus', return_value=[('M', 'foo.txt')]).start()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000639 # It's important to reset settings to not have inter-tests interference.
640 git_cl.settings = None
Edward Lemurda4b6c62020-02-13 00:28:40 +0000641 self.addCleanup(mock.patch.stopall)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000642
643 def tearDown(self):
wychen@chromium.org445c8962015-04-28 23:30:05 +0000644 try:
Edward Lesmes0dd54822020-03-26 18:24:25 +0000645 if not self.failed:
646 self.assertEqual([], self.calls)
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100647 except AssertionError:
Edward Lemur85153282020-02-14 22:06:29 +0000648 calls = ''.join(' %s\n' % str(call) for call in self.calls[:5])
649 if len(self.calls) > 5:
650 calls += ' ...\n'
651 self.fail(
652 '\n'
653 'There are un-consumed calls after this test has finished:\n' +
654 calls)
wychen@chromium.org445c8962015-04-28 23:30:05 +0000655 finally:
656 super(TestGitCl, self).tearDown()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000657
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000658 def _mocked_call(self, *args, **_kwargs):
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000659 self.assertTrue(
660 self.calls,
tandrii9d206752016-06-20 11:32:47 -0700661 '@%d Expected: <Missing> Actual: %r' % (len(self._calls_done), args))
wychen@chromium.orga872e752015-04-28 23:42:18 +0000662 top = self.calls.pop(0)
wychen@chromium.orga872e752015-04-28 23:42:18 +0000663 expected_args, result = top
664
maruel@chromium.orge52678e2013-04-26 18:34:44 +0000665 # Also logs otherwise it could get caught in a try/finally and be hard to
666 # diagnose.
667 if expected_args != args:
tandrii9d206752016-06-20 11:32:47 -0700668 N = 5
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000669 prior_calls = '\n '.join(
tandrii9d206752016-06-20 11:32:47 -0700670 '@%d: %r' % (len(self._calls_done) - N + i, c[0])
671 for i, c in enumerate(self._calls_done[-N:]))
672 following_calls = '\n '.join(
673 '@%d: %r' % (len(self._calls_done) + i + 1, c[0])
674 for i, c in enumerate(self.calls[:N]))
675 extended_msg = (
676 'A few prior calls:\n %s\n\n'
677 'This (expected):\n @%d: %r\n'
678 'This (actual):\n @%d: %r\n\n'
679 'A few following expected calls:\n %s' %
680 (prior_calls, len(self._calls_done), expected_args,
681 len(self._calls_done), args, following_calls))
tandrii9d206752016-06-20 11:32:47 -0700682
Edward Lesmes0dd54822020-03-26 18:24:25 +0000683 self.failed = True
tandrii99a72f22016-08-17 14:33:24 -0700684 self.fail('@%d\n'
685 ' Expected: %r\n'
Edward Lemur26964072020-02-19 19:18:51 +0000686 ' Actual: %r\n'
687 '\n'
688 '%s' % (
689 len(self._calls_done), expected_args, args, extended_msg))
tandrii9d206752016-06-20 11:32:47 -0700690
691 self._calls_done.append(top)
tandrii5d48c322016-08-18 16:19:37 -0700692 if isinstance(result, Exception):
693 raise result
Edward Lemur0db01f02019-11-12 22:01:51 +0000694 # stdout from git commands is supposed to be a bytestream. Convert it here
695 # instead of converting all test output in this file to bytes.
696 if args[0][0] == 'git' and not isinstance(result, bytes):
697 result = result.encode('utf-8')
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000698 return result
699
Edward Lemur1a83da12020-03-04 21:18:36 +0000700 @mock.patch('sys.stdin', StringIO('blah\nye\n'))
701 @mock.patch('sys.stdout', StringIO())
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100702 def test_ask_for_explicit_yes_true(self):
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100703 self.assertTrue(git_cl.ask_for_explicit_yes('prompt'))
Edward Lemur1a83da12020-03-04 21:18:36 +0000704 self.assertEqual(
705 'prompt [Yes/No]: Please, type yes or no: ',
706 sys.stdout.getvalue())
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100707
tandrii48df5812016-10-17 03:55:37 -0700708 def test_LoadCodereviewSettingsFromFile_gerrit(self):
Edward Lemur79d4f992019-11-11 23:49:02 +0000709 codereview_file = StringIO('GERRIT_HOST: true')
tandrii48df5812016-10-17 03:55:37 -0700710 self.calls = [
711 ((['git', 'config', '--unset-all', 'rietveld.cc'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700712 ((['git', 'config', '--unset-all', 'rietveld.tree-status-url'],), CERR1),
713 ((['git', 'config', '--unset-all', 'rietveld.viewvc-url'],), CERR1),
714 ((['git', 'config', '--unset-all', 'rietveld.bug-prefix'],), CERR1),
715 ((['git', 'config', '--unset-all', 'rietveld.cpplint-regex'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700716 ((['git', 'config', '--unset-all', 'rietveld.cpplint-ignore-regex'],),
717 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700718 ((['git', 'config', '--unset-all', 'rietveld.run-post-upload-hook'],),
719 CERR1),
Jamie Madilldc4d19e2019-10-24 21:50:02 +0000720 ((['git', 'config', '--unset-all', 'rietveld.format-full-by-default'],),
721 CERR1),
Dirk Pranke6f0df682021-06-25 00:42:33 +0000722 ((['git', 'config', '--unset-all', 'rietveld.use-python3'],),
723 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700724 ((['git', 'config', 'gerrit.host', 'true'],), ''),
725 ]
726 self.assertIsNone(git_cl.LoadCodereviewSettingsFromFile(codereview_file))
727
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000728 @classmethod
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100729 def _gerrit_base_calls(cls, issue=None, fetched_description=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200730 fetched_status=None, other_cl_owner=None,
Anthony Polito8b955342019-09-24 19:01:36 +0000731 custom_cl_base=None, short_hostname='chromium',
Josip Sokcevic7e133ff2021-07-13 17:44:53 +0000732 change_id=None, default_branch='main'):
Edward Lemur26964072020-02-19 19:18:51 +0000733 calls = []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200734 if custom_cl_base:
735 ancestor_revision = custom_cl_base
736 else:
737 # Determine ancestor_revision to be merge base.
Edward Lesmes8c43c3f2021-01-20 00:20:26 +0000738 ancestor_revision = 'origin/' + default_branch
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200739
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100740 if issue:
Edward Lesmes7677e5c2020-02-19 20:39:03 +0000741 gerrit_util.GetChangeDetail.return_value = {
742 'owner': {'email': (other_cl_owner or 'owner@example.com')},
743 'change_id': (change_id or '123456789'),
744 'current_revision': 'sha1_of_current_revision',
745 'revisions': {'sha1_of_current_revision': {
746 'commit': {'message': fetched_description},
747 }},
748 'status': fetched_status or 'NEW',
749 }
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100750 if fetched_status == 'ABANDONED':
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100751 return calls
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100752 if other_cl_owner:
753 calls += [
754 (('ask_for_data', 'Press Enter to upload, or Ctrl+C to abort'), ''),
755 ]
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100756
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100757 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200758 ((['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] +
759 ([custom_cl_base] if custom_cl_base else
760 [ancestor_revision, 'HEAD']),),
761 '+dat'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100762 ]
Edward Lemur2c62b332020-03-12 22:12:33 +0000763
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100764 return calls
ukai@chromium.orge8077812012-02-03 03:41:46 +0000765
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +0000766 def _gerrit_upload_calls(self,
767 description,
768 reviewers,
769 squash,
tandriia60502f2016-06-20 02:01:53 -0700770 squash_mode='default',
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +0000771 title=None,
772 notify=False,
773 post_amend_description=None,
774 issue=None,
775 cc=None,
776 custom_cl_base=None,
777 tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +0000778 short_hostname='chromium',
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +0000779 labels=None,
780 change_id=None,
781 final_description=None,
782 gitcookies_exists=True,
783 force=False,
784 edit_description=None,
Josip Sokcevic7e133ff2021-07-13 17:44:53 +0000785 default_branch='main',
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +0000786 push_opts=None):
tandrii@chromium.org10625002016-03-04 20:03:47 +0000787 if post_amend_description is None:
788 post_amend_description = description
bradnelsond975b302016-10-23 12:20:23 -0700789 cc = cc or []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200790
791 calls = []
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000792
Edward Lesmes4de54132020-05-05 19:41:33 +0000793 if squash_mode in ('override_squash', 'override_nosquash'):
794 self.mockGit.config['gerrit.override-squash-uploads'] = (
795 'true' if squash_mode == 'override_squash' else 'false')
796
tandrii@chromium.org57d86542016-03-04 16:11:32 +0000797 if not git_footers.get_footer_change_id(description) and not squash:
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000798 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200799 (('DownloadGerritHook', False), ''),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200800 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000801 if squash:
Edward Lemur5a644f82020-03-18 16:44:57 +0000802 if not issue and not force:
Edward Lemur5fb22242020-03-12 22:05:13 +0000803 calls += [
804 ((['RunEditor'],), description),
805 ]
Josipe827b0f2020-01-30 00:07:20 +0000806 # user wants to edit description
807 if edit_description:
808 calls += [
Josipe827b0f2020-01-30 00:07:20 +0000809 ((['RunEditor'],), edit_description),
810 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000811 ref_to_push = 'abcdef0123456789'
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200812
813 if custom_cl_base is None:
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000814 parent = 'origin/' + default_branch
Edward Lesmes8c43c3f2021-01-20 00:20:26 +0000815 git_common.get_or_create_merge_base.return_value = parent
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200816 else:
817 calls += [
818 ((['git', 'merge-base', '--is-ancestor', custom_cl_base,
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000819 'refs/remotes/origin/' + default_branch],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200820 callError(1)), # Means not ancenstor.
821 (('ask_for_data',
822 'Do you take responsibility for cleaning up potential mess '
823 'resulting from proceeding with upload? Press Enter to upload, '
824 'or Ctrl+C to abort'), ''),
825 ]
826 parent = custom_cl_base
827
828 calls += [
829 ((['git', 'rev-parse', 'HEAD:'],), # `HEAD:` means HEAD's tree hash.
830 '0123456789abcdef'),
Edward Lemur1773f372020-02-22 00:27:14 +0000831 ((['FileWrite', '/tmp/fake-temp1', description],), None),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200832 ((['git', 'commit-tree', '0123456789abcdef', '-p', parent,
Edward Lemur1773f372020-02-22 00:27:14 +0000833 '-F', '/tmp/fake-temp1'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200834 ref_to_push),
835 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000836 else:
837 ref_to_push = 'HEAD'
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000838 parent = 'origin/refs/heads/' + default_branch
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000839
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000840 calls += [
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000841 (('SaveDescriptionBackup',), None),
Edward Lemur5a644f82020-03-18 16:44:57 +0000842 ((['git', 'rev-list', parent + '..' + ref_to_push],),'1hashPerLine\n'),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200843 ]
tandrii@chromium.org8da45402016-05-24 23:11:03 +0000844
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +0000845 metrics_arguments = []
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000846
Aaron Gableafd52772017-06-27 16:40:10 -0700847 if notify:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +0000848 ref_suffix = '%ready,notify=ALL'
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000849 metrics_arguments += ['ready', 'notify=ALL']
Aaron Gable844cf292017-06-28 11:32:59 -0700850 else:
Jamie Madill276da0b2018-04-27 14:41:20 -0400851 if not issue and squash:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +0000852 ref_suffix = '%wip'
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000853 metrics_arguments.append('wip')
Aaron Gable844cf292017-06-28 11:32:59 -0700854 else:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +0000855 ref_suffix = '%notify=NONE'
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000856 metrics_arguments.append('notify=NONE')
Aaron Gable9b713dd2016-12-14 16:04:21 -0800857
Edward Lemur5a644f82020-03-18 16:44:57 +0000858 # If issue is given, then description is fetched from Gerrit instead.
859 if issue is None:
860 if squash:
861 title = 'Initial upload'
862 else:
863 if not title:
864 calls += [
865 ((['git', 'show', '-s', '--format=%s', 'HEAD'],), ''),
866 (('ask_for_data', 'Title for patchset []: '), 'User input'),
867 ]
868 title = 'User input'
Aaron Gable70f4e242017-06-26 10:45:59 -0700869 if title:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +0000870 ref_suffix += ',m=' + gerrit_util.PercentEncodeForGitRef(title)
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000871 metrics_arguments.append('m')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000872
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000873 if short_hostname == 'chromium':
Quinten Yearsley925cedb2020-04-13 17:49:39 +0000874 # All reviewers and ccs get into ref_suffix.
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000875 for r in sorted(reviewers):
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +0000876 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000877 metrics_arguments.append('r')
Edward Lemur4508b422019-10-03 21:56:35 +0000878 if issue is None:
Edward Lemur227d5102020-02-25 23:45:35 +0000879 cc += ['test-more-cc@chromium.org', 'joe@example.com']
Edward Lemur4508b422019-10-03 21:56:35 +0000880 for c in sorted(cc):
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +0000881 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000882 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000883 reviewers, cc = [], []
884 else:
885 # TODO(crbug/877717): remove this case.
886 calls += [
887 (('ValidAccounts', '%s-review.googlesource.com' % short_hostname,
888 sorted(reviewers) + ['joe@example.com',
Edward Lemur227d5102020-02-25 23:45:35 +0000889 'test-more-cc@chromium.org'] + cc),
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000890 {
891 e: {'email': e}
892 for e in (reviewers + ['joe@example.com'] + cc)
893 })
894 ]
895 for r in sorted(reviewers):
896 if r != 'bad-account-or-email':
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +0000897 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000898 metrics_arguments.append('r')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000899 reviewers.remove(r)
Edward Lemur4508b422019-10-03 21:56:35 +0000900 if issue is None:
901 cc += ['joe@example.com']
902 for c in sorted(cc):
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +0000903 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000904 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000905 if c in cc:
906 cc.remove(c)
Andrii Shyshkalov76988a82018-10-15 03:12:25 +0000907
Edward Lemur687ca902018-12-05 02:30:30 +0000908 for k, v in sorted((labels or {}).items()):
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +0000909 ref_suffix += ',l=%s+%d' % (k, v)
Edward Lemur687ca902018-12-05 02:30:30 +0000910 metrics_arguments.append('l=%s+%d' % (k, v))
911
912 if tbr:
913 calls += [
914 (('GetCodeReviewTbrScore',
915 '%s-review.googlesource.com' % short_hostname,
916 'my/repo'),
917 2,),
918 ]
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +0000919
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000920 calls += [
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +0000921 (
922 ('time.time', ),
923 1000,
924 ),
925 (
926 ([
927 'git', 'push',
928 'https://%s.googlesource.com/my/repo' % short_hostname,
929 ref_to_push + ':refs/for/refs/heads/' + default_branch +
930 ref_suffix
931 ] + (push_opts if push_opts else []), ),
932 (('remote:\n'
933 'remote: Processing changes: (\)\n'
934 'remote: Processing changes: (|)\n'
935 'remote: Processing changes: (/)\n'
936 'remote: Processing changes: (-)\n'
937 'remote: Processing changes: new: 1 (/)\n'
938 'remote: Processing changes: new: 1, done\n'
939 'remote:\n'
940 'remote: New Changes:\n'
941 'remote: '
942 'https://%s-review.googlesource.com/#/c/my/repo/+/123456'
943 ' XXX\n'
944 'remote:\n'
945 'To https://%s.googlesource.com/my/repo\n'
946 ' * [new branch] hhhh -> refs/for/refs/heads/%s\n') %
947 (short_hostname, short_hostname, default_branch)),
948 ),
949 (
950 ('time.time', ),
951 2000,
952 ),
953 (
954 ('add_repeated', 'sub_commands', {
955 'execution_time': 1000,
956 'command': 'git push',
957 'exit_code': 0,
958 'arguments': sorted(metrics_arguments),
959 }),
960 None,
961 ),
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000962 ]
963
Edward Lemur1b52d872019-05-09 21:12:12 +0000964 final_description = final_description or post_amend_description.strip()
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000965
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000966 trace_name = os.path.join('TRACES_DIR', '20170316T200041.000000')
967
Edward Lemur1b52d872019-05-09 21:12:12 +0000968 # Trace-related calls
969 calls += [
970 # Write a description with context for the current trace.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000971 (
972 ([
973 'FileWrite', trace_name + '-README',
974 '%(date)s\n'
975 '%(short_hostname)s-review.googlesource.com\n'
976 '%(change_id)s\n'
977 '%(title)s\n'
978 '%(description)s\n'
979 '1000\n'
980 '0\n'
981 '%(trace_name)s' % {
Josip Sokcevic5e18b602020-04-23 21:47:00 +0000982 'date': '2017-03-16T20:00:41.000000',
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000983 'short_hostname': short_hostname,
984 'change_id': change_id,
985 'description': final_description,
986 'title': title or '<untitled>',
987 'trace_name': trace_name,
988 }
989 ], ),
990 None,
Edward Lemur1b52d872019-05-09 21:12:12 +0000991 ),
992 # Read traces and shorten git hashes.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000993 (
994 (['os.path.isfile',
995 os.path.join('TEMP_DIR', 'trace-packet')], ),
996 True,
Edward Lemur1b52d872019-05-09 21:12:12 +0000997 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000998 (
999 (['FileRead', os.path.join('TEMP_DIR', 'trace-packet')], ),
1000 ('git-hash: 0123456789012345678901234567890123456789\n'
1001 'git-hash: abcdeabcdeabcdeabcdeabcdeabcdeabcdeabcde\n'),
Edward Lemur1b52d872019-05-09 21:12:12 +00001002 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001003 (
1004 ([
1005 'FileWrite',
1006 os.path.join('TEMP_DIR', 'trace-packet'), 'git-hash: 012345\n'
1007 'git-hash: abcdea\n'
1008 ], ),
1009 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001010 ),
1011 # Make zip file for the git traces.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001012 (
1013 (['make_archive', trace_name + '-traces', 'zip', 'TEMP_DIR'], ),
1014 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001015 ),
1016 # Collect git config and gitcookies.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001017 (
1018 (['git', 'config', '-l'], ),
1019 'git-config-output',
Edward Lemur1b52d872019-05-09 21:12:12 +00001020 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001021 (
1022 ([
1023 'FileWrite',
1024 os.path.join('TEMP_DIR', 'git-config'), 'git-config-output'
1025 ], ),
1026 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001027 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001028 (
1029 (['os.path.isfile',
1030 os.path.join('~', '.gitcookies')], ),
1031 gitcookies_exists,
Edward Lemur1b52d872019-05-09 21:12:12 +00001032 ),
1033 ]
1034 if gitcookies_exists:
1035 calls += [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001036 (
1037 (['FileRead', os.path.join('~', '.gitcookies')], ),
1038 'gitcookies 1/SECRET',
Edward Lemur1b52d872019-05-09 21:12:12 +00001039 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001040 (
1041 ([
1042 'FileWrite',
1043 os.path.join('TEMP_DIR', 'gitcookies'), 'gitcookies REDACTED'
1044 ], ),
1045 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001046 ),
1047 ]
1048 calls += [
1049 # Make zip file for the git config and gitcookies.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001050 (
1051 (['make_archive', trace_name + '-git-info', 'zip', 'TEMP_DIR'], ),
1052 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001053 ),
1054 ]
1055
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001056 # TODO(crbug/877717): this should never be used.
1057 if squash and short_hostname != 'chromium':
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001058 calls += [
1059 (('AddReviewers',
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001060 'chromium-review.googlesource.com', 'my%2Frepo~123456',
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001061 sorted(reviewers),
Edward Lemur227d5102020-02-25 23:45:35 +00001062 cc + ['test-more-cc@chromium.org'],
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00001063 notify),
1064 ''),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001065 ]
ukai@chromium.orge8077812012-02-03 03:41:46 +00001066 return calls
1067
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00001068 def _run_gerrit_upload_test(self,
1069 upload_args,
1070 description,
1071 reviewers=None,
1072 squash=True,
1073 squash_mode=None,
1074 title=None,
1075 notify=False,
1076 post_amend_description=None,
1077 issue=None,
1078 cc=None,
1079 fetched_status=None,
1080 other_cl_owner=None,
1081 custom_cl_base=None,
1082 tbr=None,
1083 short_hostname='chromium',
1084 labels=None,
1085 change_id=None,
1086 final_description=None,
1087 gitcookies_exists=True,
1088 force=False,
1089 log_description=None,
1090 edit_description=None,
1091 fetched_description=None,
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00001092 default_branch='main',
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00001093 push_opts=None):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001094 """Generic gerrit upload test framework."""
tandriia60502f2016-06-20 02:01:53 -07001095 if squash_mode is None:
1096 if '--no-squash' in upload_args:
1097 squash_mode = 'nosquash'
1098 elif '--squash' in upload_args:
1099 squash_mode = 'squash'
1100 else:
1101 squash_mode = 'default'
1102
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001103 reviewers = reviewers or []
bradnelsond975b302016-10-23 12:20:23 -07001104 cc = cc or []
Edward Lemurda4b6c62020-02-13 00:28:40 +00001105 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001106 CookiesAuthenticatorMockFactory(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001107 same_auth=('git-owner.example.com', '', 'pass'))).start()
1108 mock.patch('git_cl.Changelist._GerritCommitMsgHookCheck',
1109 lambda _, offer_removal: None).start()
1110 mock.patch('git_cl.gclient_utils.RunEditor',
1111 lambda *_, **__: self._mocked_call(['RunEditor'])).start()
1112 mock.patch('git_cl.DownloadGerritHook', lambda force: self._mocked_call(
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001113 'DownloadGerritHook', force)).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00001114 mock.patch('git_cl.gclient_utils.FileRead',
1115 lambda path: self._mocked_call(['FileRead', path])).start()
1116 mock.patch('git_cl.gclient_utils.FileWrite',
Edward Lemur1b52d872019-05-09 21:12:12 +00001117 lambda path, contents: self._mocked_call(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001118 ['FileWrite', path, contents])).start()
1119 mock.patch('git_cl.datetime_now',
1120 lambda: datetime.datetime(2017, 3, 16, 20, 0, 41, 0)).start()
1121 mock.patch('git_cl.tempfile.mkdtemp', lambda: 'TEMP_DIR').start()
1122 mock.patch('git_cl.TRACES_DIR', 'TRACES_DIR').start()
1123 mock.patch('git_cl.TRACES_README_FORMAT',
Edward Lemur75391d42019-05-14 23:35:56 +00001124 '%(now)s\n'
1125 '%(gerrit_host)s\n'
1126 '%(change_id)s\n'
1127 '%(title)s\n'
1128 '%(description)s\n'
1129 '%(execution_time)s\n'
1130 '%(exit_code)s\n'
Edward Lemurda4b6c62020-02-13 00:28:40 +00001131 '%(trace_name)s').start()
1132 mock.patch('git_cl.shutil.make_archive',
1133 lambda *args: self._mocked_call(['make_archive'] +
1134 list(args))).start()
1135 mock.patch('os.path.isfile',
1136 lambda path: self._mocked_call(['os.path.isfile', path])).start()
Edward Lemur9aa1a962020-02-25 00:58:38 +00001137 mock.patch(
Edward Lesmes0dd54822020-03-26 18:24:25 +00001138 'git_cl._create_description_from_log',
1139 return_value=log_description or description).start()
Edward Lemura12175c2020-03-09 16:58:26 +00001140 mock.patch(
1141 'git_cl.Changelist._AddChangeIdToCommitMessage',
1142 return_value=post_amend_description or description).start()
Edward Lemur1a83da12020-03-04 21:18:36 +00001143 mock.patch(
Edward Lemur5a644f82020-03-18 16:44:57 +00001144 'git_cl.GenerateGerritChangeId', return_value=change_id).start()
1145 mock.patch(
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001146 'git_common.get_or_create_merge_base',
1147 return_value='origin/' + default_branch).start()
1148 mock.patch(
Edward Lesmesae3586b2020-03-23 21:21:14 +00001149 'gclient_utils.AskForData',
Edward Lemur1a83da12020-03-04 21:18:36 +00001150 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
tandriia60502f2016-06-20 02:01:53 -07001151
Edward Lemur26964072020-02-19 19:18:51 +00001152 self.mockGit.config['gerrit.host'] = 'true'
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00001153 self.mockGit.config['branch.main.gerritissue'] = (
Edward Lemur85153282020-02-14 22:06:29 +00001154 str(issue) if issue else None)
1155 self.mockGit.config['remote.origin.url'] = (
1156 'https://%s.googlesource.com/my/repo' % short_hostname)
Edward Lemur9aa1a962020-02-25 00:58:38 +00001157 self.mockGit.config['user.email'] = 'me@example.com'
Edward Lemur85153282020-02-14 22:06:29 +00001158
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001159 self.calls = self._gerrit_base_calls(
1160 issue=issue,
Anthony Polito8b955342019-09-24 19:01:36 +00001161 fetched_description=fetched_description or description,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001162 fetched_status=fetched_status,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001163 other_cl_owner=other_cl_owner,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001164 custom_cl_base=custom_cl_base,
Anthony Polito8b955342019-09-24 19:01:36 +00001165 short_hostname=short_hostname,
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001166 change_id=change_id,
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001167 default_branch=default_branch)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001168 if fetched_status != 'ABANDONED':
Edward Lemurda4b6c62020-02-13 00:28:40 +00001169 mock.patch(
Edward Lemur1773f372020-02-22 00:27:14 +00001170 'gclient_utils.temporary_file', TemporaryFileMock()).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00001171 mock.patch('os.remove', return_value=True).start()
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001172 self.calls += self._gerrit_upload_calls(
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00001173 description,
1174 reviewers,
1175 squash,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001176 squash_mode=squash_mode,
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00001177 title=title,
1178 notify=notify,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001179 post_amend_description=post_amend_description,
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00001180 issue=issue,
1181 cc=cc,
1182 custom_cl_base=custom_cl_base,
1183 tbr=tbr,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001184 short_hostname=short_hostname,
Edward Lemur1b52d872019-05-09 21:12:12 +00001185 labels=labels,
1186 change_id=change_id,
Edward Lemur1b52d872019-05-09 21:12:12 +00001187 final_description=final_description,
Anthony Polito8b955342019-09-24 19:01:36 +00001188 gitcookies_exists=gitcookies_exists,
Josipe827b0f2020-01-30 00:07:20 +00001189 force=force,
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001190 edit_description=edit_description,
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00001191 default_branch=default_branch,
1192 push_opts=push_opts)
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001193 # Uncomment when debugging.
Raul Tambre80ee78e2019-05-06 22:41:05 +00001194 # print('\n'.join(map(lambda x: '%2i: %s' % x, enumerate(self.calls))))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001195 git_cl.main(['upload'] + upload_args)
Edward Lemur85153282020-02-14 22:06:29 +00001196 if squash:
Edward Lemur26964072020-02-19 19:18:51 +00001197 self.assertIssueAndPatchset(patchset=None)
Edward Lemur85153282020-02-14 22:06:29 +00001198 self.assertEqual(
1199 'abcdef0123456789',
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00001200 scm.GIT.GetBranchConfig('', 'main', 'gerritsquashhash'))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001201
Edward Lemur1b52d872019-05-09 21:12:12 +00001202 def test_gerrit_upload_traces_no_gitcookies(self):
1203 self._run_gerrit_upload_test(
1204 ['--no-squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001205 'desc ✔\n\nBUG=\n',
Edward Lemur1b52d872019-05-09 21:12:12 +00001206 [],
1207 squash=False,
Edward Lemur0db01f02019-11-12 22:01:51 +00001208 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001209 change_id='Ixxx',
1210 gitcookies_exists=False)
1211
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001212 def test_gerrit_upload_without_change_id(self):
tandriia60502f2016-06-20 02:01:53 -07001213 self._run_gerrit_upload_test(
Edward Lemur5a644f82020-03-18 16:44:57 +00001214 [],
1215 'desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
1216 [],
1217 change_id='Ixxx')
1218
1219 def test_gerrit_upload_without_change_id_nosquash(self):
1220 self._run_gerrit_upload_test(
tandriia60502f2016-06-20 02:01:53 -07001221 ['--no-squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001222 'desc ✔\n\nBUG=\n',
tandriia60502f2016-06-20 02:01:53 -07001223 [],
1224 squash=False,
Edward Lemur0db01f02019-11-12 22:01:51 +00001225 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001226 change_id='Ixxx')
tandriia60502f2016-06-20 02:01:53 -07001227
Edward Lesmes4de54132020-05-05 19:41:33 +00001228 def test_gerrit_upload_without_change_id_override_nosquash(self):
1229 self._run_gerrit_upload_test(
1230 [],
1231 'desc ✔\n\nBUG=\n',
1232 [],
1233 squash=False,
1234 squash_mode='override_nosquash',
1235 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
1236 change_id='Ixxx')
1237
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001238 def test_gerrit_no_reviewer(self):
1239 self._run_gerrit_upload_test(
Edward Lesmes4de54132020-05-05 19:41:33 +00001240 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001241 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
tandriia60502f2016-06-20 02:01:53 -07001242 [],
1243 squash=False,
Edward Lesmes4de54132020-05-05 19:41:33 +00001244 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001245 change_id='I123456789')
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001246
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00001247 def test_gerrit_push_opts(self):
1248 self._run_gerrit_upload_test(['-o', 'wip'],
1249 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
1250 [],
1251 squash=False,
1252 squash_mode='override_nosquash',
1253 change_id='I123456789',
1254 push_opts=['-o', 'wip'])
1255
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001256 def test_gerrit_no_reviewer_non_chromium_host(self):
1257 # TODO(crbug/877717): remove this test case.
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00001258 self._run_gerrit_upload_test([],
1259 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
1260 [],
1261 squash=False,
1262 squash_mode='override_nosquash',
1263 short_hostname='other',
1264 change_id='I123456789')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001265
Edward Lesmes0dd54822020-03-26 18:24:25 +00001266 def test_gerrit_patchset_title_special_chars_nosquash(self):
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001267 self._run_gerrit_upload_test(
Edward Lesmes4de54132020-05-05 19:41:33 +00001268 ['-f', '-t', 'We\'ll escape ^_ ^ special chars...@{u}'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001269 'desc ✔\n\nBUG=\n\nChange-Id: I123456789',
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001270 squash=False,
Edward Lesmes4de54132020-05-05 19:41:33 +00001271 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001272 change_id='I123456789',
Edward Lemur5a644f82020-03-18 16:44:57 +00001273 title='We\'ll escape ^_ ^ special chars...@{u}')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001274
ukai@chromium.orge8077812012-02-03 03:41:46 +00001275 def test_gerrit_reviewers_cmd_line(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001276 self._run_gerrit_upload_test(
Edward Lesmes4de54132020-05-05 19:41:33 +00001277 ['-r', 'foo@example.com', '--send-mail'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001278 'desc ✔\n\nBUG=\n\nChange-Id: I123456789',
Edward Lemur5a644f82020-03-18 16:44:57 +00001279 reviewers=['foo@example.com'],
tandriia60502f2016-06-20 02:01:53 -07001280 squash=False,
Edward Lesmes4de54132020-05-05 19:41:33 +00001281 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001282 notify=True,
1283 change_id='I123456789',
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001284 final_description=(
Edward Lemur0db01f02019-11-12 22:01:51 +00001285 'desc ✔\n\nBUG=\nR=foo@example.com\n\nChange-Id: I123456789'))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001286
Anthony Polito8b955342019-09-24 19:01:36 +00001287 def test_gerrit_upload_force_sets_bug(self):
1288 self._run_gerrit_upload_test(
1289 ['-b', '10000', '-f'],
1290 u'desc=\n\nBug: 10000\nChange-Id: Ixxx',
1291 [],
1292 force=True,
Anthony Polito8b955342019-09-24 19:01:36 +00001293 fetched_description='desc=\n\nChange-Id: Ixxx',
Anthony Polito8b955342019-09-24 19:01:36 +00001294 change_id='Ixxx')
1295
Edward Lemur5fb22242020-03-12 22:05:13 +00001296 def test_gerrit_upload_corrects_wrong_change_id(self):
Anthony Polito8b955342019-09-24 19:01:36 +00001297 self._run_gerrit_upload_test(
Edward Lemur5fb22242020-03-12 22:05:13 +00001298 ['-b', '10000', '-m', 'Title', '--edit-description'],
1299 u'desc=\n\nBug: 10000\nChange-Id: Ixxxx',
Anthony Polito8b955342019-09-24 19:01:36 +00001300 [],
Anthony Polito8b955342019-09-24 19:01:36 +00001301 issue='123456',
Edward Lemur5fb22242020-03-12 22:05:13 +00001302 edit_description='desc=\n\nBug: 10000\nChange-Id: Izzzz',
Anthony Polito8b955342019-09-24 19:01:36 +00001303 fetched_description='desc=\n\nChange-Id: Ixxxx',
Anthony Polito8b955342019-09-24 19:01:36 +00001304 title='Title',
Edward Lemur5fb22242020-03-12 22:05:13 +00001305 change_id='Ixxxx')
Anthony Polito8b955342019-09-24 19:01:36 +00001306
Dan Beamd8b04ca2019-10-10 21:23:26 +00001307 def test_gerrit_upload_force_sets_fixed(self):
1308 self._run_gerrit_upload_test(
1309 ['-x', '10000', '-f'],
1310 u'desc=\n\nFixed: 10000\nChange-Id: Ixxx',
1311 [],
1312 force=True,
Dan Beamd8b04ca2019-10-10 21:23:26 +00001313 fetched_description='desc=\n\nChange-Id: Ixxx',
Dan Beamd8b04ca2019-10-10 21:23:26 +00001314 change_id='Ixxx')
1315
ukai@chromium.orge8077812012-02-03 03:41:46 +00001316 def test_gerrit_reviewer_multiple(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00001317 mock.patch('git_cl.gerrit_util.GetCodeReviewTbrScore',
1318 lambda *a: self._mocked_call('GetCodeReviewTbrScore', *a)).start()
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001319 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001320 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001321 'desc ✔\nTBR=reviewer@example.com\nBUG=\nR=another@example.com\n'
bradnelsond975b302016-10-23 12:20:23 -07001322 'CC=more@example.com,people@example.com\n\n'
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001323 'Change-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001324 ['reviewer@example.com', 'another@example.com'],
Aaron Gablefd238082017-06-07 13:42:34 -07001325 cc=['more@example.com', 'people@example.com'],
Edward Lemur687ca902018-12-05 02:30:30 +00001326 tbr='reviewer@example.com',
Edward Lemur1b52d872019-05-09 21:12:12 +00001327 labels={'Code-Review': 2},
Edward Lemur5a644f82020-03-18 16:44:57 +00001328 change_id='123456789')
tandriia60502f2016-06-20 02:01:53 -07001329
1330 def test_gerrit_upload_squash_first_is_default(self):
tandriia60502f2016-06-20 02:01:53 -07001331 self._run_gerrit_upload_test(
1332 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001333 'desc ✔\nBUG=\n\nChange-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001334 [],
Edward Lemur5a644f82020-03-18 16:44:57 +00001335 change_id='123456789')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001336
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001337 def test_gerrit_upload_squash_first(self):
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001338 self._run_gerrit_upload_test(
1339 ['--squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001340 'desc ✔\nBUG=\n\nChange-Id: 123456789',
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001341 [],
luqui@chromium.org609f3952015-05-04 22:47:04 +00001342 squash=True,
Edward Lemur5a644f82020-03-18 16:44:57 +00001343 change_id='123456789')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001344
Edward Lesmes0dd54822020-03-26 18:24:25 +00001345 def test_gerrit_upload_squash_first_title(self):
1346 self._run_gerrit_upload_test(
1347 ['-f', '-t', 'title'],
1348 'title\n\ndesc\n\nChange-Id: 123456789',
1349 [],
1350 force=True,
1351 squash=True,
1352 log_description='desc',
1353 change_id='123456789')
1354
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001355 def test_gerrit_upload_squash_first_with_labels(self):
1356 self._run_gerrit_upload_test(
1357 ['--squash', '--cq-dry-run', '--enable-auto-submit'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001358 'desc ✔\nBUG=\n\nChange-Id: 123456789',
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001359 [],
1360 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001361 labels={'Commit-Queue': 1, 'Auto-Submit': 1},
Edward Lemur5a644f82020-03-18 16:44:57 +00001362 change_id='123456789')
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001363
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001364 def test_gerrit_upload_squash_first_against_rev(self):
1365 custom_cl_base = 'custom_cl_base_rev_or_branch'
1366 self._run_gerrit_upload_test(
1367 ['--squash', custom_cl_base],
Edward Lemur0db01f02019-11-12 22:01:51 +00001368 'desc ✔\nBUG=\n\nChange-Id: 123456789',
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001369 [],
1370 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001371 custom_cl_base=custom_cl_base,
Edward Lemur5a644f82020-03-18 16:44:57 +00001372 change_id='123456789')
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001373 self.assertIn(
1374 'If you proceed with upload, more than 1 CL may be created by Gerrit',
1375 sys.stdout.getvalue())
1376
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001377 def test_gerrit_upload_squash_reupload(self):
Edward Lemur0db01f02019-11-12 22:01:51 +00001378 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001379 self._run_gerrit_upload_test(
1380 ['--squash'],
1381 description,
1382 [],
1383 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001384 issue=123456,
Edward Lemur5a644f82020-03-18 16:44:57 +00001385 change_id='123456789')
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001386
Edward Lemurd55c5072020-02-20 01:09:07 +00001387 @mock.patch('sys.stderr', StringIO())
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001388 def test_gerrit_upload_squash_reupload_to_abandoned(self):
Edward Lemur0db01f02019-11-12 22:01:51 +00001389 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001390 with self.assertRaises(SystemExitMock):
1391 self._run_gerrit_upload_test(
1392 ['--squash'],
1393 description,
1394 [],
1395 squash=True,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001396 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001397 fetched_status='ABANDONED',
1398 change_id='123456789')
Edward Lemurd55c5072020-02-20 01:09:07 +00001399 self.assertEqual(
1400 'Change https://chromium-review.googlesource.com/123456 has been '
1401 'abandoned, new uploads are not allowed\n',
1402 sys.stderr.getvalue())
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001403
Edward Lemurda4b6c62020-02-13 00:28:40 +00001404 @mock.patch(
1405 'gerrit_util.GetAccountDetails',
1406 return_value={'email': 'yet-another@example.com'})
1407 def test_gerrit_upload_squash_reupload_to_not_owned(self, _mock):
Edward Lemur0db01f02019-11-12 22:01:51 +00001408 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001409 self._run_gerrit_upload_test(
1410 ['--squash'],
1411 description,
1412 [],
1413 squash=True,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001414 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001415 other_cl_owner='other@example.com',
Edward Lemur5a644f82020-03-18 16:44:57 +00001416 change_id='123456789')
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001417 self.assertIn(
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001418 'WARNING: Change 123456 is owned by other@example.com, but you '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001419 'authenticate to Gerrit as yet-another@example.com.\n'
1420 'Uploading may fail due to lack of permissions',
Edward Lemurda4b6c62020-02-13 00:28:40 +00001421 sys.stdout.getvalue())
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001422
Josipe827b0f2020-01-30 00:07:20 +00001423 def test_upload_change_description_editor(self):
1424 fetched_description = 'foo\n\nChange-Id: 123456789'
1425 description = 'bar\n\nChange-Id: 123456789'
1426 self._run_gerrit_upload_test(
1427 ['--squash', '--edit-description'],
1428 description,
1429 [],
1430 fetched_description=fetched_description,
1431 squash=True,
Josipe827b0f2020-01-30 00:07:20 +00001432 issue=123456,
1433 change_id='123456789',
Josipe827b0f2020-01-30 00:07:20 +00001434 edit_description=description)
1435
Edward Lemurda4b6c62020-02-13 00:28:40 +00001436 @mock.patch('git_cl.RunGit')
1437 @mock.patch('git_cl.CMDupload')
Edward Lemur1a83da12020-03-04 21:18:36 +00001438 @mock.patch('sys.stdin', StringIO('\n'))
1439 @mock.patch('sys.stdout', StringIO())
Edward Lemurda4b6c62020-02-13 00:28:40 +00001440 def test_upload_branch_deps(self, *_mocks):
rmistry@google.com2dd99862015-06-22 12:22:18 +00001441 def mock_run_git(*args, **_kwargs):
1442 if args[0] == ['for-each-ref',
1443 '--format=%(refname:short) %(upstream:short)',
1444 'refs/heads']:
1445 # Create a local branch dependency tree that looks like this:
1446 # test1 -> test2 -> test3 -> test4 -> test5
1447 # -> test3.1
1448 # test6 -> test0
1449 branch_deps = [
1450 'test2 test1', # test1 -> test2
1451 'test3 test2', # test2 -> test3
1452 'test3.1 test2', # test2 -> test3.1
1453 'test4 test3', # test3 -> test4
1454 'test5 test4', # test4 -> test5
1455 'test6 test0', # test0 -> test6
1456 'test7', # test7
1457 ]
1458 return '\n'.join(branch_deps)
Edward Lemurda4b6c62020-02-13 00:28:40 +00001459 git_cl.RunGit.side_effect = mock_run_git
1460 git_cl.CMDupload.return_value = 0
rmistry@google.com2dd99862015-06-22 12:22:18 +00001461
1462 class MockChangelist():
1463 def __init__(self):
1464 pass
1465 def GetBranch(self):
1466 return 'test1'
1467 def GetIssue(self):
1468 return '123'
1469 def GetPatchset(self):
1470 return '1001'
tandrii@chromium.org4c72b082016-03-31 22:26:35 +00001471 def IsGerrit(self):
1472 return False
rmistry@google.com2dd99862015-06-22 12:22:18 +00001473
1474 ret = git_cl.upload_branch_deps(MockChangelist(), [])
1475 # CMDupload should have been called 5 times because of 5 dependent branches.
Edward Lemurda4b6c62020-02-13 00:28:40 +00001476 self.assertEqual(5, len(git_cl.CMDupload.mock_calls))
Edward Lemur1a83da12020-03-04 21:18:36 +00001477 self.assertIn(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001478 'This command will checkout all dependent branches '
1479 'and run "git cl upload". Press Enter to continue, '
Edward Lemur1a83da12020-03-04 21:18:36 +00001480 'or Ctrl+C to abort',
1481 sys.stdout.getvalue())
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00001482 self.assertEqual(0, ret)
rmistry@google.com2dd99862015-06-22 12:22:18 +00001483
tandrii@chromium.org65874e12016-03-04 12:03:02 +00001484 def test_gerrit_change_id(self):
1485 self.calls = [
1486 ((['git', 'write-tree'], ),
1487 'hashtree'),
1488 ((['git', 'rev-parse', 'HEAD~0'], ),
1489 'branch-parent'),
1490 ((['git', 'var', 'GIT_AUTHOR_IDENT'], ),
1491 'A B <a@b.org> 1456848326 +0100'),
1492 ((['git', 'var', 'GIT_COMMITTER_IDENT'], ),
1493 'C D <c@d.org> 1456858326 +0100'),
1494 ((['git', 'hash-object', '-t', 'commit', '--stdin'], ),
1495 'hashchange'),
1496 ]
1497 change_id = git_cl.GenerateGerritChangeId('line1\nline2\n')
1498 self.assertEqual(change_id, 'Ihashchange')
1499
Edward Lesmes8170c292021-03-19 20:04:43 +00001500 @mock.patch('gerrit_util.IsCodeOwnersEnabledOnHost')
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001501 @mock.patch('git_cl.Settings.GetBugPrefix')
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001502 @mock.patch('git_cl.Changelist.FetchDescription')
1503 @mock.patch('git_cl.Changelist.GetBranch')
Edward Lesmes1eaaab52021-03-02 23:52:54 +00001504 @mock.patch('git_cl.Changelist.GetCommonAncestorWithUpstream')
Edward Lesmese1576912021-02-16 21:53:34 +00001505 @mock.patch('git_cl.Changelist.GetGerritHost')
1506 @mock.patch('git_cl.Changelist.GetGerritProject')
1507 @mock.patch('git_cl.Changelist.GetRemoteBranch')
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001508 @mock.patch('owners_client.OwnersClient.BatchListOwners')
1509 def getDescriptionForUploadTest(
Edward Lesmese1576912021-02-16 21:53:34 +00001510 self, mockBatchListOwners=None, mockGetRemoteBranch=None,
Edward Lesmes1eaaab52021-03-02 23:52:54 +00001511 mockGetGerritProject=None, mockGetGerritHost=None,
1512 mockGetCommonAncestorWithUpstream=None, mockGetBranch=None,
Edward Lesmese1576912021-02-16 21:53:34 +00001513 mockFetchDescription=None, mockGetBugPrefix=None,
Edward Lesmes8170c292021-03-19 20:04:43 +00001514 mockIsCodeOwnersEnabledOnHost=None,
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001515 initial_description='desc', bug=None, fixed=None, branch='branch',
1516 reviewers=None, tbrs=None, add_owners_to=None,
1517 expected_description='desc'):
1518 reviewers = reviewers or []
1519 tbrs = tbrs or []
1520 owners_by_path = {
1521 'a': ['a@example.com'],
1522 'b': ['b@example.com'],
1523 'c': ['c@example.com'],
1524 }
Edward Lesmes8170c292021-03-19 20:04:43 +00001525 mockIsCodeOwnersEnabledOnHost.return_value = True
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001526 mockGetBranch.return_value = branch
1527 mockGetBugPrefix.return_value = 'prefix'
Edward Lesmes1eaaab52021-03-02 23:52:54 +00001528 mockGetCommonAncestorWithUpstream.return_value = 'upstream'
Edward Lesmese1576912021-02-16 21:53:34 +00001529 mockGetRemoteBranch.return_value = ('origin', 'refs/remotes/origin/main')
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001530 mockFetchDescription.return_value = 'desc'
1531 mockBatchListOwners.side_effect = lambda ps: {
1532 p: owners_by_path.get(p)
1533 for p in ps
1534 }
1535
1536 cl = git_cl.Changelist(issue=1234)
Josip Sokcevic340edc32021-07-08 17:01:46 +00001537 actual = cl._GetDescriptionForUpload(options=mock.Mock(
1538 bug=bug,
1539 fixed=fixed,
1540 reviewers=reviewers,
1541 tbrs=tbrs,
1542 add_owners_to=add_owners_to,
1543 message=initial_description),
1544 git_diff_args=None,
1545 files=list(owners_by_path))
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001546 self.assertEqual(expected_description, actual.description)
1547
1548 def testGetDescriptionForUpload(self):
1549 self.getDescriptionForUploadTest()
1550
1551 def testGetDescriptionForUpload_Bug(self):
1552 self.getDescriptionForUploadTest(
1553 bug='1234',
1554 expected_description='\n'.join([
1555 'desc',
1556 '',
1557 'Bug: prefix:1234',
1558 ]))
1559
1560 def testGetDescriptionForUpload_Fixed(self):
1561 self.getDescriptionForUploadTest(
1562 fixed='1234',
1563 expected_description='\n'.join([
1564 'desc',
1565 '',
1566 'Fixed: prefix:1234',
1567 ]))
1568
Josip Sokcevic340edc32021-07-08 17:01:46 +00001569 @mock.patch('git_cl.Changelist.GetIssue')
1570 def testGetDescriptionForUpload_BugFromBranch(self, mockGetIssue):
1571 mockGetIssue.return_value = None
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001572 self.getDescriptionForUploadTest(
1573 branch='bug-1234',
1574 expected_description='\n'.join([
1575 'desc',
1576 '',
1577 'Bug: prefix:1234',
1578 ]))
1579
Josip Sokcevic340edc32021-07-08 17:01:46 +00001580 @mock.patch('git_cl.Changelist.GetIssue')
1581 def testGetDescriptionForUpload_FixedFromBranch(self, mockGetIssue):
1582 mockGetIssue.return_value = None
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001583 self.getDescriptionForUploadTest(
1584 branch='fix-1234',
1585 expected_description='\n'.join([
1586 'desc',
1587 '',
1588 'Fixed: prefix:1234',
1589 ]))
1590
Josip Sokcevic340edc32021-07-08 17:01:46 +00001591 def testGetDescriptionForUpload_SkipBugFromBranchIfAlreadyUploaded(self):
1592 self.getDescriptionForUploadTest(
1593 branch='bug-1234',
1594 expected_description='desc',
1595 )
1596
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001597 def testGetDescriptionForUpload_AddOwnersToR(self):
1598 self.getDescriptionForUploadTest(
1599 reviewers=['a@example.com'],
1600 tbrs=['b@example.com'],
1601 add_owners_to='R',
1602 expected_description='\n'.join([
1603 'desc',
1604 '',
1605 'R=a@example.com, c@example.com',
1606 'TBR=b@example.com',
1607 ]))
1608
1609 def testGetDescriptionForUpload_AddOwnersToTBR(self):
1610 self.getDescriptionForUploadTest(
1611 reviewers=['a@example.com'],
1612 tbrs=['b@example.com'],
1613 add_owners_to='TBR',
1614 expected_description='\n'.join([
1615 'desc',
1616 '',
1617 'R=a@example.com',
1618 'TBR=b@example.com, c@example.com',
1619 ]))
1620
1621 def testGetDescriptionForUpload_AddOwnersToNoOwnersNeeded(self):
1622 self.getDescriptionForUploadTest(
1623 reviewers=['a@example.com', 'c@example.com'],
1624 tbrs=['b@example.com'],
1625 add_owners_to='TBR',
1626 expected_description='\n'.join([
1627 'desc',
1628 '',
1629 'R=a@example.com, c@example.com',
1630 'TBR=b@example.com',
1631 ]))
1632
1633 def testGetDescriptionForUpload_Reviewers(self):
1634 self.getDescriptionForUploadTest(
1635 reviewers=['a@example.com', 'b@example.com'],
1636 expected_description='\n'.join([
1637 'desc',
1638 '',
1639 'R=a@example.com, b@example.com',
1640 ]))
1641
1642 def testGetDescriptionForUpload_TBRs(self):
1643 self.getDescriptionForUploadTest(
1644 tbrs=['a@example.com', 'b@example.com'],
1645 expected_description='\n'.join([
1646 'desc',
1647 '',
1648 'TBR=a@example.com, b@example.com',
1649 ]))
1650
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001651 def test_desecription_append_footer(self):
1652 for init_desc, footer_line, expected_desc in [
1653 # Use unique desc first lines for easy test failure identification.
1654 ('foo', 'R=one', 'foo\n\nR=one'),
1655 ('foo\n\nR=one', 'BUG=', 'foo\n\nR=one\nBUG='),
1656 ('foo\n\nR=one', 'Change-Id: Ixx', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1657 ('foo\n\nChange-Id: Ixx', 'R=one', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1658 ('foo\n\nR=one\n\nChange-Id: Ixx', 'TBR=two',
1659 'foo\n\nR=one\nTBR=two\n\nChange-Id: Ixx'),
1660 ('foo\n\nR=one\n\nChange-Id: Ixx', 'Foo-Bar: baz',
1661 'foo\n\nR=one\n\nChange-Id: Ixx\nFoo-Bar: baz'),
1662 ('foo\n\nChange-Id: Ixx', 'Foo-Bak: baz',
1663 'foo\n\nChange-Id: Ixx\nFoo-Bak: baz'),
1664 ('foo', 'Change-Id: Ixx', 'foo\n\nChange-Id: Ixx'),
1665 ]:
1666 desc = git_cl.ChangeDescription(init_desc)
1667 desc.append_footer(footer_line)
1668 self.assertEqual(desc.description, expected_desc)
1669
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001670 def test_update_reviewers(self):
1671 data = [
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001672 ('foo', [], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001673 'foo'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001674 ('foo\nR=xx', [], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001675 'foo\nR=xx'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001676 ('foo\nTBR=xx', [], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001677 'foo\nTBR=xx'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001678 ('foo', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001679 'foo\n\nR=a@c'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001680 ('foo\nR=xx', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001681 'foo\n\nR=a@c, xx'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001682 ('foo\nTBR=xx', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001683 'foo\n\nR=a@c\nTBR=xx'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001684 ('foo\nTBR=xx\nR=yy', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001685 'foo\n\nR=a@c, yy\nTBR=xx'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001686 ('foo\nBUG=', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001687 'foo\nBUG=\nR=a@c'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001688 ('foo\nR=xx\nTBR=yy\nR=bar', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001689 'foo\n\nR=a@c, bar, xx\nTBR=yy'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001690 ('foo', ['a@c', 'b@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001691 'foo\n\nR=a@c, b@c'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001692 ('foo\nBar\n\nR=\nBUG=', ['c@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001693 'foo\nBar\n\nR=c@c\nBUG='),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001694 ('foo\nBar\n\nR=\nBUG=\nR=', ['c@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001695 'foo\nBar\n\nR=c@c\nBUG='),
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001696 # Same as the line before, but full of whitespaces.
1697 (
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001698 'foo\nBar\n\n R = \n BUG = \n R = ', ['c@c'], [],
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001699 'foo\nBar\n\nR=c@c\n BUG =',
1700 ),
1701 # Whitespaces aren't interpreted as new lines.
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001702 ('foo BUG=allo R=joe ', ['c@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001703 'foo BUG=allo R=joe\n\nR=c@c'),
1704 # Redundant TBRs get promoted to Rs
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001705 ('foo\n\nR=a@c\nTBR=t@c', ['b@c', 'a@c'], ['a@c', 't@c'],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001706 'foo\n\nR=a@c, b@c\nTBR=t@c'),
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001707 ]
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001708 expected = [i[-1] for i in data]
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001709 actual = []
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001710 for orig, reviewers, tbrs, _expected in data:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001711 obj = git_cl.ChangeDescription(orig)
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001712 obj.update_reviewers(reviewers, tbrs)
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001713 actual.append(obj.description)
1714 self.assertEqual(expected, actual)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001715
Nodir Turakulov23b82142017-11-16 11:04:25 -08001716 def test_get_hash_tags(self):
1717 cases = [
1718 ('', []),
1719 ('a', []),
1720 ('[a]', ['a']),
1721 ('[aa]', ['aa']),
1722 ('[a ]', ['a']),
1723 ('[a- ]', ['a']),
1724 ('[a- b]', ['a-b']),
1725 ('[a--b]', ['a-b']),
1726 ('[a', []),
1727 ('[a]x', ['a']),
1728 ('[aa]x', ['aa']),
1729 ('[a b]', ['a-b']),
1730 ('[a b]', ['a-b']),
1731 ('[a__b]', ['a-b']),
1732 ('[a] x', ['a']),
1733 ('[a][b]', ['a', 'b']),
1734 ('[a] [b]', ['a', 'b']),
1735 ('[a][b]x', ['a', 'b']),
1736 ('[a][b] x', ['a', 'b']),
1737 ('[a]\n[b]', ['a']),
1738 ('[a\nb]', []),
1739 ('[a][', ['a']),
1740 ('Revert "[a] feature"', ['a']),
1741 ('Reland "[a] feature"', ['a']),
1742 ('Revert: [a] feature', ['a']),
1743 ('Reland: [a] feature', ['a']),
1744 ('Revert "Reland: [a] feature"', ['a']),
1745 ('Foo: feature', ['foo']),
1746 ('Foo Bar: feature', ['foo-bar']),
Anthony Polito02b5af32019-12-02 19:49:47 +00001747 ('Change Foo::Bar', []),
1748 ('Foo: Change Foo::Bar', ['foo']),
Nodir Turakulov23b82142017-11-16 11:04:25 -08001749 ('Revert "Foo bar: feature"', ['foo-bar']),
1750 ('Reland "Foo bar: feature"', ['foo-bar']),
1751 ]
1752 for desc, expected in cases:
1753 change_desc = git_cl.ChangeDescription(desc)
1754 actual = change_desc.get_hash_tags()
1755 self.assertEqual(
1756 actual,
1757 expected,
1758 'GetHashTags(%r) == %r, expected %r' % (desc, actual, expected))
1759
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00001760 self.assertEqual(None, git_cl.GetTargetRef('origin', None, 'main'))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001761 self.assertEqual(None, git_cl.GetTargetRef(None,
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00001762 'refs/remotes/origin/main',
1763 'main'))
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001764
wittman@chromium.org455dc922015-01-26 20:15:50 +00001765 # Check default target refs for branches.
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00001766 self.assertEqual('refs/heads/main',
1767 git_cl.GetTargetRef('origin', 'refs/remotes/origin/main',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001768 None))
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00001769 self.assertEqual('refs/heads/main',
wittman@chromium.org455dc922015-01-26 20:15:50 +00001770 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkgr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001771 None))
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00001772 self.assertEqual('refs/heads/main',
wittman@chromium.org455dc922015-01-26 20:15:50 +00001773 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkcr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001774 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001775 self.assertEqual('refs/branch-heads/123',
1776 git_cl.GetTargetRef('origin',
1777 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001778 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001779 self.assertEqual('refs/diff/test',
1780 git_cl.GetTargetRef('origin',
1781 'refs/remotes/origin/refs/diff/test',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001782 None))
rmistry@google.comc68112d2015-03-03 12:48:06 +00001783 self.assertEqual('refs/heads/chrome/m42',
1784 git_cl.GetTargetRef('origin',
1785 'refs/remotes/origin/chrome/m42',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001786 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001787
1788 # Check target refs for user-specified target branch.
1789 for branch in ('branch-heads/123', 'remotes/branch-heads/123',
1790 'refs/remotes/branch-heads/123'):
1791 self.assertEqual('refs/branch-heads/123',
1792 git_cl.GetTargetRef('origin',
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00001793 'refs/remotes/origin/main',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001794 branch))
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00001795 for branch in ('origin/main', 'remotes/origin/main',
1796 'refs/remotes/origin/main'):
1797 self.assertEqual('refs/heads/main',
wittman@chromium.org455dc922015-01-26 20:15:50 +00001798 git_cl.GetTargetRef('origin',
1799 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001800 branch))
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00001801 for branch in ('main', 'heads/main', 'refs/heads/main'):
1802 self.assertEqual('refs/heads/main',
wittman@chromium.org455dc922015-01-26 20:15:50 +00001803 git_cl.GetTargetRef('origin',
1804 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001805 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001806
Edward Lemurda4b6c62020-02-13 00:28:40 +00001807 @mock.patch('git_common.is_dirty_git_tree', return_value=True)
1808 def test_patch_when_dirty(self, *_mocks):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001809 # Patch when local tree is dirty.
wychen@chromium.orga872e752015-04-28 23:42:18 +00001810 self.assertNotEqual(git_cl.main(['patch', '123456']), 0)
1811
Edward Lemur85153282020-02-14 22:06:29 +00001812 def assertIssueAndPatchset(
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00001813 self, branch='main', issue='123456', patchset='7',
Edward Lemur85153282020-02-14 22:06:29 +00001814 git_short_host='chromium'):
1815 self.assertEqual(
Edward Lemur26964072020-02-19 19:18:51 +00001816 issue, scm.GIT.GetBranchConfig('', branch, 'gerritissue'))
Edward Lemur85153282020-02-14 22:06:29 +00001817 self.assertEqual(
Edward Lemur26964072020-02-19 19:18:51 +00001818 patchset, scm.GIT.GetBranchConfig('', branch, 'gerritpatchset'))
Edward Lemur85153282020-02-14 22:06:29 +00001819 self.assertEqual(
1820 'https://%s-review.googlesource.com' % git_short_host,
Edward Lemur26964072020-02-19 19:18:51 +00001821 scm.GIT.GetBranchConfig('', branch, 'gerritserver'))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001822
Edward Lemur85153282020-02-14 22:06:29 +00001823 def _patch_common(self, git_short_host='chromium'):
Edward Lesmes50da7702020-03-30 19:23:43 +00001824 mock.patch('scm.GIT.ResolveCommit', return_value='deadbeef').start()
Edward Lemur26964072020-02-19 19:18:51 +00001825 self.mockGit.config['remote.origin.url'] = (
1826 'https://%s.googlesource.com/my/repo' % git_short_host)
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001827 gerrit_util.GetChangeDetail.return_value = {
1828 'current_revision': '7777777777',
1829 'revisions': {
1830 '1111111111': {
1831 '_number': 1,
1832 'fetch': {'http': {
1833 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1834 'ref': 'refs/changes/56/123456/1',
1835 }},
1836 },
1837 '7777777777': {
1838 '_number': 7,
1839 'fetch': {'http': {
1840 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1841 'ref': 'refs/changes/56/123456/7',
1842 }},
1843 },
1844 },
1845 }
wychen@chromium.orga872e752015-04-28 23:42:18 +00001846
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001847 def test_patch_gerrit_default(self):
Edward Lemur85153282020-02-14 22:06:29 +00001848 self._patch_common()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001849 self.calls += [
1850 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1851 'refs/changes/56/123456/7'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001852 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001853 ]
1854 self.assertEqual(git_cl.main(['patch', '123456']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001855 self.assertIssueAndPatchset()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001856
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001857 def test_patch_gerrit_new_branch(self):
Edward Lemur85153282020-02-14 22:06:29 +00001858 self._patch_common()
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001859 self.calls += [
1860 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1861 'refs/changes/56/123456/7'],), ''),
1862 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001863 ]
Edward Lemur85153282020-02-14 22:06:29 +00001864 self.assertEqual(git_cl.main(['patch', '-b', 'feature', '123456']), 0)
1865 self.assertIssueAndPatchset(branch='feature')
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001866
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001867 def test_patch_gerrit_force(self):
Edward Lemur85153282020-02-14 22:06:29 +00001868 self._patch_common('host')
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001869 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001870 ((['git', 'fetch', 'https://host.googlesource.com/my/repo',
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001871 'refs/changes/56/123456/7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001872 ((['git', 'reset', '--hard', 'FETCH_HEAD'],), ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001873 ]
Edward Lemur52969c92020-02-06 18:15:28 +00001874 self.assertEqual(git_cl.main(['patch', '123456', '--force']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001875 self.assertIssueAndPatchset(git_short_host='host')
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001876
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001877 def test_patch_gerrit_guess_by_url(self):
Edward Lemur85153282020-02-14 22:06:29 +00001878 self._patch_common('else')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001879 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001880 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001881 'refs/changes/56/123456/1'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001882 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001883 ]
1884 self.assertEqual(git_cl.main(
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001885 ['patch', 'https://else-review.googlesource.com/#/c/123456/1']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001886 self.assertIssueAndPatchset(patchset='1', git_short_host='else')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001887
Aaron Gable697a91b2018-01-19 15:20:15 -08001888 def test_patch_gerrit_guess_by_url_with_repo(self):
Edward Lemur85153282020-02-14 22:06:29 +00001889 self._patch_common('else')
Aaron Gable697a91b2018-01-19 15:20:15 -08001890 self.calls += [
1891 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
1892 'refs/changes/56/123456/1'],), ''),
1893 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
Aaron Gable697a91b2018-01-19 15:20:15 -08001894 ]
1895 self.assertEqual(git_cl.main(
1896 ['patch', 'https://else-review.googlesource.com/c/my/repo/+/123456/1']),
1897 0)
Edward Lemur85153282020-02-14 22:06:29 +00001898 self.assertIssueAndPatchset(patchset='1', git_short_host='else')
Aaron Gable697a91b2018-01-19 15:20:15 -08001899
Edward Lemurd55c5072020-02-20 01:09:07 +00001900 @mock.patch('sys.stderr', StringIO())
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001901 def test_patch_gerrit_conflict(self):
Edward Lemur85153282020-02-14 22:06:29 +00001902 self._patch_common()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001903 self.calls += [
1904 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001905 'refs/changes/56/123456/7'],), ''),
tandrii5d48c322016-08-18 16:19:37 -07001906 ((['git', 'cherry-pick', 'FETCH_HEAD'],), CERR1),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001907 ]
1908 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001909 git_cl.main(['patch', '123456'])
Edward Lemurd55c5072020-02-20 01:09:07 +00001910 self.assertEqual(
1911 'Command "git cherry-pick FETCH_HEAD" failed.\n\n',
1912 sys.stderr.getvalue())
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001913
Edward Lemurda4b6c62020-02-13 00:28:40 +00001914 @mock.patch(
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001915 'gerrit_util.GetChangeDetail',
Edward Lemurda4b6c62020-02-13 00:28:40 +00001916 side_effect=gerrit_util.GerritError(404, ''))
Edward Lemurd55c5072020-02-20 01:09:07 +00001917 @mock.patch('sys.stderr', StringIO())
Edward Lemurda4b6c62020-02-13 00:28:40 +00001918 def test_patch_gerrit_not_exists(self, *_mocks):
Edward Lemur26964072020-02-19 19:18:51 +00001919 self.mockGit.config['remote.origin.url'] = (
1920 'https://chromium.googlesource.com/my/repo')
tandriic2405f52016-10-10 08:13:15 -07001921 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001922 self.assertEqual(1, git_cl.main(['patch', '123456']))
Edward Lemurd55c5072020-02-20 01:09:07 +00001923 self.assertEqual(
1924 'change 123456 at https://chromium-review.googlesource.com does not '
1925 'exist or you have no access to it\n',
1926 sys.stderr.getvalue())
tandriic2405f52016-10-10 08:13:15 -07001927
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001928 def _checkout_calls(self):
1929 return [
1930 ((['git', 'config', '--local', '--get-regexp',
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001931 'branch\\..*\\.gerritissue'], ),
1932 ('branch.ger-branch.gerritissue 123456\n'
1933 'branch.gbranch654.gerritissue 654321\n')),
1934 ]
1935
1936 def test_checkout_gerrit(self):
1937 """Tests git cl checkout <issue>."""
1938 self.calls = self._checkout_calls()
1939 self.calls += [((['git', 'checkout', 'ger-branch'], ), '')]
1940 self.assertEqual(0, git_cl.main(['checkout', '123456']))
1941
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001942 def test_checkout_not_found(self):
1943 """Tests git cl checkout <issue>."""
1944 self.calls = self._checkout_calls()
1945 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1946
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001947 def test_checkout_no_branch_issues(self):
1948 """Tests git cl checkout <issue>."""
1949 self.calls = [
1950 ((['git', 'config', '--local', '--get-regexp',
tandrii5d48c322016-08-18 16:19:37 -07001951 'branch\\..*\\.gerritissue'], ), CERR1),
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001952 ]
1953 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1954
Edward Lemur26964072020-02-19 19:18:51 +00001955 def _test_gerrit_ensure_authenticated_common(self, auth):
Edward Lemur1a83da12020-03-04 21:18:36 +00001956 mock.patch(
Edward Lesmesae3586b2020-03-23 21:21:14 +00001957 'gclient_utils.AskForData',
Edward Lemur1a83da12020-03-04 21:18:36 +00001958 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00001959 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
1960 CookiesAuthenticatorMockFactory(hosts_with_creds=auth)).start()
Edward Lemur26964072020-02-19 19:18:51 +00001961 self.mockGit.config['remote.origin.url'] = (
1962 'https://chromium.googlesource.com/my/repo')
Edward Lemurf38bc172019-09-03 21:02:13 +00001963 cl = git_cl.Changelist()
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00001964 cl.branch = 'main'
1965 cl.branchref = 'refs/heads/main'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001966 return cl
1967
Edward Lemurd55c5072020-02-20 01:09:07 +00001968 @mock.patch('sys.stderr', StringIO())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001969 def test_gerrit_ensure_authenticated_missing(self):
1970 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001971 'chromium.googlesource.com': ('git-is.ok', '', 'but gerrit is missing'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001972 })
Edward Lemurd55c5072020-02-20 01:09:07 +00001973 with self.assertRaises(SystemExitMock):
1974 cl.EnsureAuthenticated(force=False)
1975 self.assertEqual(
1976 'Credentials for the following hosts are required:\n'
1977 ' chromium-review.googlesource.com\n'
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001978 'These are read from ~%(sep)s.gitcookies '
1979 '(or legacy ~%(sep)s%(netrc)s)\n'
Edward Lemurd55c5072020-02-20 01:09:07 +00001980 'You can (re)generate your credentials by visiting '
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001981 'https://chromium-review.googlesource.com/new-password\n' % {
1982 'sep': os.sep,
1983 'netrc': NETRC_FILENAME,
1984 }, sys.stderr.getvalue())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001985
1986 def test_gerrit_ensure_authenticated_conflict(self):
1987 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001988 'chromium.googlesource.com':
1989 ('git-one.example.com', None, 'secret1'),
1990 'chromium-review.googlesource.com':
1991 ('git-other.example.com', None, 'secret2'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001992 })
1993 self.calls.append(
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001994 (('ask_for_data', 'If you know what you are doing '
1995 'press Enter to continue, or Ctrl+C to abort'), ''))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001996 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1997
1998 def test_gerrit_ensure_authenticated_ok(self):
1999 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002000 'chromium.googlesource.com':
2001 ('git-same.example.com', None, 'secret'),
2002 'chromium-review.googlesource.com':
2003 ('git-same.example.com', None, 'secret'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002004 })
2005 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2006
tandrii@chromium.org28253532016-04-14 13:46:56 +00002007 def test_gerrit_ensure_authenticated_skipped(self):
Edward Lemur26964072020-02-19 19:18:51 +00002008 self.mockGit.config['gerrit.skip-ensure-authenticated'] = 'true'
2009 cl = self._test_gerrit_ensure_authenticated_common(auth={})
tandrii@chromium.org28253532016-04-14 13:46:56 +00002010 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2011
Eric Boren2fb63102018-10-05 13:05:03 +00002012 def test_gerrit_ensure_authenticated_bearer_token(self):
2013 cl = self._test_gerrit_ensure_authenticated_common(auth={
2014 'chromium.googlesource.com':
2015 ('', None, 'secret'),
2016 'chromium-review.googlesource.com':
2017 ('', None, 'secret'),
2018 })
2019 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2020 header = gerrit_util.CookiesAuthenticator().get_auth_header(
2021 'chromium.googlesource.com')
2022 self.assertTrue('Bearer' in header)
2023
Daniel Chengcf6269b2019-05-18 01:02:12 +00002024 def test_gerrit_ensure_authenticated_non_https(self):
Edward Lemur26964072020-02-19 19:18:51 +00002025 self.mockGit.config['remote.origin.url'] = 'custom-scheme://repo'
Daniel Chengcf6269b2019-05-18 01:02:12 +00002026 self.calls = [
Josip906bfde2020-01-31 22:38:49 +00002027 (('logging.warning',
2028 'Ignoring branch %(branch)s with non-https remote '
2029 '%(remote)s', {
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00002030 'branch': 'main',
Josip906bfde2020-01-31 22:38:49 +00002031 'remote': 'custom-scheme://repo'}
2032 ), None),
Daniel Chengcf6269b2019-05-18 01:02:12 +00002033 ]
Edward Lemurda4b6c62020-02-13 00:28:40 +00002034 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
2035 CookiesAuthenticatorMockFactory(hosts_with_creds={})).start()
2036 mock.patch('logging.warning',
2037 lambda *a: self._mocked_call('logging.warning', *a)).start()
Edward Lemurf38bc172019-09-03 21:02:13 +00002038 cl = git_cl.Changelist()
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00002039 cl.branch = 'main'
2040 cl.branchref = 'refs/heads/main'
Daniel Chengcf6269b2019-05-18 01:02:12 +00002041 cl.lookedup_issue = True
2042 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2043
Florian Mayerae510e82020-01-30 21:04:48 +00002044 def test_gerrit_ensure_authenticated_non_url(self):
Edward Lemur26964072020-02-19 19:18:51 +00002045 self.mockGit.config['remote.origin.url'] = (
2046 'git@somehost.example:foo/bar.git')
Florian Mayerae510e82020-01-30 21:04:48 +00002047 self.calls = [
Josip906bfde2020-01-31 22:38:49 +00002048 (('logging.error',
2049 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
2050 'but it doesn\'t exist.', {
2051 'remote': 'origin',
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00002052 'branch': 'main',
Josip906bfde2020-01-31 22:38:49 +00002053 'url': 'git@somehost.example:foo/bar.git'}
2054 ), None),
Florian Mayerae510e82020-01-30 21:04:48 +00002055 ]
Edward Lemurda4b6c62020-02-13 00:28:40 +00002056 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
2057 CookiesAuthenticatorMockFactory(hosts_with_creds={})).start()
2058 mock.patch('logging.error',
2059 lambda *a: self._mocked_call('logging.error', *a)).start()
Florian Mayerae510e82020-01-30 21:04:48 +00002060 cl = git_cl.Changelist()
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00002061 cl.branch = 'main'
2062 cl.branchref = 'refs/heads/main'
Florian Mayerae510e82020-01-30 21:04:48 +00002063 cl.lookedup_issue = True
2064 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2065
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002066 def _cmd_set_commit_gerrit_common(self, vote, notify=None):
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00002067 self.mockGit.config['branch.main.gerritissue'] = '123'
2068 self.mockGit.config['branch.main.gerritserver'] = (
Edward Lemur85153282020-02-14 22:06:29 +00002069 'https://chromium-review.googlesource.com')
Edward Lemur26964072020-02-19 19:18:51 +00002070 self.mockGit.config['remote.origin.url'] = (
2071 'https://chromium.googlesource.com/infra/infra')
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002072 self.calls = [
Edward Lemurda4b6c62020-02-13 00:28:40 +00002073 (('SetReview', 'chromium-review.googlesource.com',
2074 'infra%2Finfra~123', None,
2075 {'Commit-Queue': vote}, notify, None), ''),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002076 ]
tandriid9e5ce52016-07-13 02:32:59 -07002077
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00002078 def _cmd_set_quick_run_gerrit(self):
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00002079 self.mockGit.config['branch.main.gerritissue'] = '123'
2080 self.mockGit.config['branch.main.gerritserver'] = (
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00002081 'https://chromium-review.googlesource.com')
2082 self.mockGit.config['remote.origin.url'] = (
2083 'https://chromium.googlesource.com/infra/infra')
2084 self.calls = [
2085 (('SetReview', 'chromium-review.googlesource.com',
2086 'infra%2Finfra~123', None,
2087 {'Commit-Queue': 1, 'Quick-Run': 1}, None, None), ''),
2088 ]
2089
tandriid9e5ce52016-07-13 02:32:59 -07002090 def test_cmd_set_commit_gerrit_clear(self):
2091 self._cmd_set_commit_gerrit_common(0)
2092 self.assertEqual(0, git_cl.main(['set-commit', '-c']))
2093
2094 def test_cmd_set_commit_gerrit_dry(self):
Aaron Gable75e78722017-06-09 10:40:16 -07002095 self._cmd_set_commit_gerrit_common(1, notify=False)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002096 self.assertEqual(0, git_cl.main(['set-commit', '-d']))
2097
tandriid9e5ce52016-07-13 02:32:59 -07002098 def test_cmd_set_commit_gerrit(self):
2099 self._cmd_set_commit_gerrit_common(2)
2100 self.assertEqual(0, git_cl.main(['set-commit']))
2101
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00002102 def test_cmd_set_quick_run_gerrit(self):
2103 self._cmd_set_quick_run_gerrit()
2104 self.assertEqual(0, git_cl.main(['set-commit', '-q']))
2105
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002106 def test_description_display(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002107 mock.patch('git_cl.Changelist', ChangelistMock).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002108 ChangelistMock.desc = 'foo\n'
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002109
2110 self.assertEqual(0, git_cl.main(['description', '-d']))
Edward Lemurda4b6c62020-02-13 00:28:40 +00002111 self.assertEqual('foo\n', sys.stdout.getvalue())
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002112
Edward Lemurda4b6c62020-02-13 00:28:40 +00002113 @mock.patch('sys.stderr', StringIO())
iannucci3c972b92016-08-17 13:24:10 -07002114 def test_StatusFieldOverrideIssueMissingArgs(self):
iannucci3c972b92016-08-17 13:24:10 -07002115 try:
2116 self.assertEqual(git_cl.main(['status', '--issue', '1']), 0)
Edward Lemurd55c5072020-02-20 01:09:07 +00002117 except SystemExitMock:
Edward Lemur6c6827c2020-02-06 21:15:18 +00002118 self.assertIn(
Edward Lemurda4b6c62020-02-13 00:28:40 +00002119 '--field must be given when --issue is set.', sys.stderr.getvalue())
iannucci3c972b92016-08-17 13:24:10 -07002120
2121 def test_StatusFieldOverrideIssue(self):
iannucci3c972b92016-08-17 13:24:10 -07002122 def assertIssue(cl_self, *_args):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002123 self.assertEqual(cl_self.issue, 1)
iannucci3c972b92016-08-17 13:24:10 -07002124 return 'foobar'
2125
Edward Lemurda4b6c62020-02-13 00:28:40 +00002126 mock.patch('git_cl.Changelist.FetchDescription', assertIssue).start()
iannuccie53c9352016-08-17 14:40:40 -07002127 self.assertEqual(
Edward Lemur52969c92020-02-06 18:15:28 +00002128 git_cl.main(['status', '--issue', '1', '--field', 'desc']),
iannuccie53c9352016-08-17 14:40:40 -07002129 0)
Edward Lemurda4b6c62020-02-13 00:28:40 +00002130 self.assertEqual(sys.stdout.getvalue(), 'foobar\n')
iannucci3c972b92016-08-17 13:24:10 -07002131
iannuccie53c9352016-08-17 14:40:40 -07002132 def test_SetCloseOverrideIssue(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002133
iannuccie53c9352016-08-17 14:40:40 -07002134 def assertIssue(cl_self, *_args):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002135 self.assertEqual(cl_self.issue, 1)
iannuccie53c9352016-08-17 14:40:40 -07002136 return 'foobar'
2137
Edward Lemurda4b6c62020-02-13 00:28:40 +00002138 mock.patch('git_cl.Changelist.FetchDescription', assertIssue).start()
2139 mock.patch('git_cl.Changelist.CloseIssue', lambda *_: None).start()
iannuccie53c9352016-08-17 14:40:40 -07002140 self.assertEqual(
Edward Lemur52969c92020-02-06 18:15:28 +00002141 git_cl.main(['set-close', '--issue', '1']), 0)
iannuccie53c9352016-08-17 14:40:40 -07002142
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002143 def test_description(self):
Edward Lemur26964072020-02-19 19:18:51 +00002144 self.mockGit.config['remote.origin.url'] = (
2145 'https://chromium.googlesource.com/my/repo')
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002146 gerrit_util.GetChangeDetail.return_value = {
2147 'current_revision': 'sha1',
2148 'revisions': {'sha1': {
2149 'commit': {'message': 'foobar'},
2150 }},
2151 }
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002152 self.assertEqual(0, git_cl.main([
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002153 'description',
2154 'https://chromium-review.googlesource.com/c/my/repo/+/123123',
2155 '-d']))
Edward Lemurda4b6c62020-02-13 00:28:40 +00002156 self.assertEqual('foobar\n', sys.stdout.getvalue())
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002157
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002158 def test_description_set_raw(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002159 mock.patch('git_cl.Changelist', ChangelistMock).start()
2160 mock.patch('git_cl.sys.stdin', StringIO('hihi')).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002161
2162 self.assertEqual(0, git_cl.main(['description', '-n', 'hihi']))
2163 self.assertEqual('hihi', ChangelistMock.desc)
2164
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002165 def test_description_appends_bug_line(self):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002166 current_desc = 'Some.\n\nChange-Id: xxx'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002167
2168 def RunEditor(desc, _, **kwargs):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002169 self.assertEqual(
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002170 '# Enter a description of the change.\n'
2171 '# This will be displayed on the codereview site.\n'
2172 '# The first line will also be used as the subject of the review.\n'
2173 '#--------------------This line is 72 characters long'
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002174 '--------------------\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -07002175 'Some.\n\nChange-Id: xxx\nBug: ',
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002176 desc)
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002177 # Simulate user changing something.
Aaron Gable3a16ed12017-03-23 10:51:55 -07002178 return 'Some.\n\nChange-Id: xxx\nBug: 123'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002179
Edward Lemur6c6827c2020-02-06 21:15:18 +00002180 def UpdateDescription(_, desc, force=False):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002181 self.assertEqual(desc, 'Some.\n\nChange-Id: xxx\nBug: 123')
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002182
Edward Lemurda4b6c62020-02-13 00:28:40 +00002183 mock.patch('git_cl.Changelist.FetchDescription',
2184 lambda *args: current_desc).start()
2185 mock.patch('git_cl.Changelist.UpdateDescription',
2186 UpdateDescription).start()
2187 mock.patch('git_cl.gclient_utils.RunEditor', RunEditor).start()
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002188
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00002189 self.mockGit.config['branch.main.gerritissue'] = '123'
Edward Lemur52969c92020-02-06 18:15:28 +00002190 self.assertEqual(0, git_cl.main(['description']))
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002191
Dan Beamd8b04ca2019-10-10 21:23:26 +00002192 def test_description_does_not_append_bug_line_if_fixed_is_present(self):
2193 current_desc = 'Some.\n\nFixed: 123\nChange-Id: xxx'
2194
2195 def RunEditor(desc, _, **kwargs):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002196 self.assertEqual(
Dan Beamd8b04ca2019-10-10 21:23:26 +00002197 '# Enter a description of the change.\n'
2198 '# This will be displayed on the codereview site.\n'
2199 '# The first line will also be used as the subject of the review.\n'
2200 '#--------------------This line is 72 characters long'
2201 '--------------------\n'
2202 'Some.\n\nFixed: 123\nChange-Id: xxx',
2203 desc)
2204 return desc
2205
Edward Lemurda4b6c62020-02-13 00:28:40 +00002206 mock.patch('git_cl.Changelist.FetchDescription',
2207 lambda *args: current_desc).start()
2208 mock.patch('git_cl.gclient_utils.RunEditor', RunEditor).start()
Dan Beamd8b04ca2019-10-10 21:23:26 +00002209
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00002210 self.mockGit.config['branch.main.gerritissue'] = '123'
Edward Lemur52969c92020-02-06 18:15:28 +00002211 self.assertEqual(0, git_cl.main(['description']))
Dan Beamd8b04ca2019-10-10 21:23:26 +00002212
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002213 def test_description_set_stdin(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002214 mock.patch('git_cl.Changelist', ChangelistMock).start()
2215 mock.patch('git_cl.sys.stdin', StringIO('hi \r\n\t there\n\nman')).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002216
2217 self.assertEqual(0, git_cl.main(['description', '-n', '-']))
2218 self.assertEqual('hi\n\t there\n\nman', ChangelistMock.desc)
2219
kmarshall3bff56b2016-06-06 18:31:47 -07002220 def test_archive(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002221 self.calls = [
2222 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00002223 'refs/heads/main\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002224 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002225 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],), ''),
Edward Lemurf38bc172019-09-03 21:02:13 +00002226 ((['git', 'branch', '-D', 'foo'],), '')
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002227 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002228
Edward Lemurda4b6c62020-02-13 00:28:40 +00002229 mock.patch('git_cl.get_cl_statuses',
kmarshall3bff56b2016-06-06 18:31:47 -07002230 lambda branches, fine_grained, max_processes:
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00002231 [(MockChangelistWithBranchAndIssue('main', 1), 'open'),
kmarshall9249e012016-08-23 12:02:16 -07002232 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002233 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall3bff56b2016-06-06 18:31:47 -07002234
2235 self.assertEqual(0, git_cl.main(['archive', '-f']))
2236
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002237 def test_archive_tag_collision(self):
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002238 self.calls = [
2239 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00002240 'refs/heads/main\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002241 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],),
2242 'refs/tags/git-cl-archived-456-foo'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002243 ((['git', 'tag', 'git-cl-archived-456-foo-2', 'foo'],), ''),
2244 ((['git', 'branch', '-D', 'foo'],), '')
2245 ]
2246
Edward Lemurda4b6c62020-02-13 00:28:40 +00002247 mock.patch('git_cl.get_cl_statuses',
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002248 lambda branches, fine_grained, max_processes:
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00002249 [(MockChangelistWithBranchAndIssue('main', 1), 'open'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002250 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002251 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002252
2253 self.assertEqual(0, git_cl.main(['archive', '-f']))
2254
kmarshall3bff56b2016-06-06 18:31:47 -07002255 def test_archive_current_branch_fails(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002256 self.calls = [
2257 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00002258 'refs/heads/main'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002259 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002260 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002261
Edward Lemurda4b6c62020-02-13 00:28:40 +00002262 mock.patch('git_cl.get_cl_statuses',
kmarshall9249e012016-08-23 12:02:16 -07002263 lambda branches, fine_grained, max_processes:
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00002264 [(MockChangelistWithBranchAndIssue('main', 1),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002265 'closed')]).start()
kmarshall9249e012016-08-23 12:02:16 -07002266
2267 self.assertEqual(1, git_cl.main(['archive', '-f']))
2268
2269 def test_archive_dry_run(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002270 self.calls = [
2271 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00002272 'refs/heads/main\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002273 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002274 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002275
Edward Lemurda4b6c62020-02-13 00:28:40 +00002276 mock.patch('git_cl.get_cl_statuses',
kmarshall3bff56b2016-06-06 18:31:47 -07002277 lambda branches, fine_grained, max_processes:
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00002278 [(MockChangelistWithBranchAndIssue('main', 1), 'open'),
kmarshall9249e012016-08-23 12:02:16 -07002279 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002280 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall3bff56b2016-06-06 18:31:47 -07002281
kmarshall9249e012016-08-23 12:02:16 -07002282 self.assertEqual(0, git_cl.main(['archive', '-f', '--dry-run']))
2283
2284 def test_archive_no_tags(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002285 self.calls = [
2286 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00002287 'refs/heads/main\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002288 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002289 ((['git', 'branch', '-D', 'foo'],), '')
2290 ]
kmarshall9249e012016-08-23 12:02:16 -07002291
Edward Lemurda4b6c62020-02-13 00:28:40 +00002292 mock.patch('git_cl.get_cl_statuses',
kmarshall9249e012016-08-23 12:02:16 -07002293 lambda branches, fine_grained, max_processes:
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00002294 [(MockChangelistWithBranchAndIssue('main', 1), 'open'),
kmarshall9249e012016-08-23 12:02:16 -07002295 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002296 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall9249e012016-08-23 12:02:16 -07002297
2298 self.assertEqual(0, git_cl.main(['archive', '-f', '--notags']))
kmarshall3bff56b2016-06-06 18:31:47 -07002299
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002300 def test_archive_tag_cleanup_on_branch_deletion_error(self):
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002301 self.calls = [
2302 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00002303 'refs/heads/main\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002304 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002305 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],),
2306 'refs/tags/git-cl-archived-456-foo'),
2307 ((['git', 'branch', '-D', 'foo'],), CERR1),
2308 ((['git', 'tag', '-d', 'git-cl-archived-456-foo'],),
2309 'refs/tags/git-cl-archived-456-foo'),
2310 ]
2311
Edward Lemurda4b6c62020-02-13 00:28:40 +00002312 mock.patch('git_cl.get_cl_statuses',
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002313 lambda branches, fine_grained, max_processes:
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00002314 [(MockChangelistWithBranchAndIssue('main', 1), 'open'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002315 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002316 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002317
2318 self.assertEqual(0, git_cl.main(['archive', '-f']))
2319
Tibor Goldschwendt7c5efb22020-03-25 01:23:54 +00002320 def test_archive_with_format(self):
2321 self.calls = [
2322 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'], ),
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00002323 'refs/heads/main\nrefs/heads/foo\nrefs/heads/bar'),
Tibor Goldschwendt7c5efb22020-03-25 01:23:54 +00002324 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'], ), ''),
2325 ((['git', 'tag', 'archived/12-foo', 'foo'], ), ''),
2326 ((['git', 'branch', '-D', 'foo'], ), ''),
2327 ]
2328
2329 mock.patch('git_cl.get_cl_statuses',
2330 lambda branches, fine_grained, max_processes:
2331 [(MockChangelistWithBranchAndIssue('foo', 12), 'closed')]).start()
2332
2333 self.assertEqual(
2334 0, git_cl.main(['archive', '-f', '-p', 'archived/{issue}-{branch}']))
2335
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002336 def test_cmd_issue_erase_existing(self):
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00002337 self.mockGit.config['branch.main.gerritissue'] = '123'
2338 self.mockGit.config['branch.main.gerritserver'] = (
Edward Lemur85153282020-02-14 22:06:29 +00002339 'https://chromium-review.googlesource.com')
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002340 self.calls = [
Aaron Gableca01e2c2017-07-19 11:16:02 -07002341 ((['git', 'log', '-1', '--format=%B'],), 'This is a description'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002342 ]
2343 self.assertEqual(0, git_cl.main(['issue', '0']))
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00002344 self.assertNotIn('branch.main.gerritissue', self.mockGit.config)
2345 self.assertNotIn('branch.main.gerritserver', self.mockGit.config)
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002346
Aaron Gable400e9892017-07-12 15:31:21 -07002347 def test_cmd_issue_erase_existing_with_change_id(self):
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00002348 self.mockGit.config['branch.main.gerritissue'] = '123'
2349 self.mockGit.config['branch.main.gerritserver'] = (
Edward Lemur85153282020-02-14 22:06:29 +00002350 'https://chromium-review.googlesource.com')
Edward Lemurda4b6c62020-02-13 00:28:40 +00002351 mock.patch('git_cl.Changelist.FetchDescription',
2352 lambda _: 'This is a description\n\nChange-Id: Ideadbeef').start()
Aaron Gable400e9892017-07-12 15:31:21 -07002353 self.calls = [
Aaron Gableca01e2c2017-07-19 11:16:02 -07002354 ((['git', 'log', '-1', '--format=%B'],),
2355 'This is a description\n\nChange-Id: Ideadbeef'),
2356 ((['git', 'commit', '--amend', '-m', 'This is a description\n'],), ''),
Aaron Gable400e9892017-07-12 15:31:21 -07002357 ]
2358 self.assertEqual(0, git_cl.main(['issue', '0']))
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00002359 self.assertNotIn('branch.main.gerritissue', self.mockGit.config)
2360 self.assertNotIn('branch.main.gerritserver', self.mockGit.config)
Aaron Gable400e9892017-07-12 15:31:21 -07002361
phajdan.jre328cf92016-08-22 04:12:17 -07002362 def test_cmd_issue_json(self):
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00002363 self.mockGit.config['branch.main.gerritissue'] = '123'
2364 self.mockGit.config['branch.main.gerritserver'] = (
Edward Lemur85153282020-02-14 22:06:29 +00002365 'https://chromium-review.googlesource.com')
Nodir Turakulov27379632021-03-17 18:53:29 +00002366 self.mockGit.config['remote.origin.url'] = (
2367 'https://chromium.googlesource.com/chromium/src'
2368 )
2369 self.calls = [(
2370 (
2371 'write_json',
2372 'output.json',
2373 {
2374 'issue': 123,
2375 'issue_url': 'https://chromium-review.googlesource.com/123',
2376 'gerrit_host': 'chromium-review.googlesource.com',
2377 'gerrit_project': 'chromium/src',
2378 },
2379 ),
2380 '',
2381 )]
phajdan.jre328cf92016-08-22 04:12:17 -07002382 self.assertEqual(0, git_cl.main(['issue', '--json', 'output.json']))
2383
tandrii16e0b4e2016-06-07 10:34:28 -07002384 def _common_GerritCommitMsgHookCheck(self):
Edward Lemur15a9b8c2020-02-13 00:52:30 +00002385 mock.patch(
2386 'git_cl.os.path.abspath',
2387 lambda path: self._mocked_call(['abspath', path])).start()
2388 mock.patch(
2389 'git_cl.os.path.exists',
2390 lambda path: self._mocked_call(['exists', path])).start()
2391 mock.patch(
2392 'git_cl.gclient_utils.FileRead',
2393 lambda path: self._mocked_call(['FileRead', path])).start()
2394 mock.patch(
2395 'git_cl.gclient_utils.rm_file_or_tree',
2396 lambda path: self._mocked_call(['rm_file_or_tree', path])).start()
Edward Lemur1a83da12020-03-04 21:18:36 +00002397 mock.patch(
Edward Lesmesae3586b2020-03-23 21:21:14 +00002398 'gclient_utils.AskForData',
Edward Lemur1a83da12020-03-04 21:18:36 +00002399 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
Edward Lemurf38bc172019-09-03 21:02:13 +00002400 return git_cl.Changelist(issue=123)
tandrii16e0b4e2016-06-07 10:34:28 -07002401
2402 def test_GerritCommitMsgHookCheck_custom_hook(self):
2403 cl = self._common_GerritCommitMsgHookCheck()
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002404 self.calls += [((['exists',
2405 os.path.join('.git', 'hooks', 'commit-msg')], ), True),
2406 ((['FileRead',
2407 os.path.join('.git', 'hooks', 'commit-msg')], ),
2408 '#!/bin/sh\necho "custom hook"')]
Edward Lemur125d60a2019-09-13 18:25:41 +00002409 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002410
2411 def test_GerritCommitMsgHookCheck_not_exists(self):
2412 cl = self._common_GerritCommitMsgHookCheck()
2413 self.calls += [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002414 ((['exists', os.path.join('.git', 'hooks', 'commit-msg')], ), False),
tandrii16e0b4e2016-06-07 10:34:28 -07002415 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002416 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002417
2418 def test_GerritCommitMsgHookCheck(self):
2419 cl = self._common_GerritCommitMsgHookCheck()
2420 self.calls += [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002421 ((['exists', os.path.join('.git', 'hooks', 'commit-msg')], ), True),
2422 ((['FileRead', os.path.join('.git', 'hooks', 'commit-msg')], ),
tandrii16e0b4e2016-06-07 10:34:28 -07002423 '...\n# From Gerrit Code Review\n...\nadd_ChangeId()\n'),
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002424 (('ask_for_data', 'Do you want to remove it now? [Yes/No]: '), 'Yes'),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002425 ((['rm_file_or_tree',
2426 os.path.join('.git', 'hooks', 'commit-msg')], ), ''),
tandrii16e0b4e2016-06-07 10:34:28 -07002427 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002428 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002429
tandriic4344b52016-08-29 06:04:54 -07002430 def test_GerritCmdLand(self):
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00002431 self.mockGit.config['branch.main.gerritsquashhash'] = 'deadbeaf'
2432 self.mockGit.config['branch.main.gerritserver'] = (
Edward Lemur85153282020-02-14 22:06:29 +00002433 'chromium-review.googlesource.com')
tandriic4344b52016-08-29 06:04:54 -07002434 self.calls += [
tandriic4344b52016-08-29 06:04:54 -07002435 ((['git', 'diff', 'deadbeaf'],), ''), # No diff.
tandriic4344b52016-08-29 06:04:54 -07002436 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002437 cl = git_cl.Changelist(issue=123)
Edward Lemur125d60a2019-09-13 18:25:41 +00002438 cl._GetChangeDetail = lambda *args, **kwargs: {
tandriic4344b52016-08-29 06:04:54 -07002439 'labels': {},
2440 'current_revision': 'deadbeaf',
2441 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002442 cl._GetChangeCommit = lambda: {
agable32978d92016-11-01 12:55:02 -07002443 'commit': 'deadbeef',
Aaron Gable02cdbb42016-12-13 16:24:25 -08002444 'web_links': [{'name': 'gitiles',
agable32978d92016-11-01 12:55:02 -07002445 'url': 'https://git.googlesource.com/test/+/deadbeef'}],
2446 }
Xinan Lin1bd4ffa2021-07-28 00:54:22 +00002447 cl.SubmitIssue = lambda: None
Olivier Robin75ee7252018-04-13 10:02:56 +02002448 self.assertEqual(0, cl.CMDLand(force=True,
2449 bypass_hooks=True,
2450 verbose=True,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00002451 parallel=False,
2452 resultdb=False,
2453 realm=None))
Edward Lemur73c76702020-02-06 23:57:18 +00002454 self.assertIn(
2455 'Issue chromium-review.googlesource.com/123 has been submitted',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002456 sys.stdout.getvalue())
Edward Lemur73c76702020-02-06 23:57:18 +00002457 self.assertIn(
2458 'Landed as: https://git.googlesource.com/test/+/deadbeef',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002459 sys.stdout.getvalue())
tandriic4344b52016-08-29 06:04:54 -07002460
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002461 def _mock_gerrit_changes_for_detail_cache(self):
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002462 mock.patch('git_cl.Changelist.GetGerritHost', lambda _: 'host').start()
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002463
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002464 def test_gerrit_change_detail_cache_simple(self):
2465 self._mock_gerrit_changes_for_detail_cache()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002466 gerrit_util.GetChangeDetail.side_effect = ['a', 'b']
Edward Lemurf38bc172019-09-03 21:02:13 +00002467 cl1 = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002468 cl1._cached_remote_url = (
2469 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemurf38bc172019-09-03 21:02:13 +00002470 cl2 = git_cl.Changelist(issue=2)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002471 cl2._cached_remote_url = (
2472 True, 'https://chromium.googlesource.com/ab/repo')
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002473 self.assertEqual(cl1._GetChangeDetail(), 'a') # Miss.
2474 self.assertEqual(cl1._GetChangeDetail(), 'a')
2475 self.assertEqual(cl2._GetChangeDetail(), 'b') # Miss.
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002476
2477 def test_gerrit_change_detail_cache_options(self):
2478 self._mock_gerrit_changes_for_detail_cache()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002479 gerrit_util.GetChangeDetail.side_effect = ['cab', 'ad']
Edward Lemurf38bc172019-09-03 21:02:13 +00002480 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002481 cl._cached_remote_url = (True, 'https://chromium.googlesource.com/repo/')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002482 self.assertEqual(cl._GetChangeDetail(options=['C', 'A', 'B']), 'cab')
2483 self.assertEqual(cl._GetChangeDetail(options=['A', 'B', 'C']), 'cab')
2484 self.assertEqual(cl._GetChangeDetail(options=['B', 'A']), 'cab')
2485 self.assertEqual(cl._GetChangeDetail(options=['C']), 'cab')
2486 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2487 self.assertEqual(cl._GetChangeDetail(), 'cab')
2488
2489 self.assertEqual(cl._GetChangeDetail(options=['A', 'D']), 'ad')
2490 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2491 self.assertEqual(cl._GetChangeDetail(options=['D']), 'ad')
2492 self.assertEqual(cl._GetChangeDetail(), 'cab')
2493
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002494 def test_gerrit_description_caching(self):
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002495 gerrit_util.GetChangeDetail.return_value = {
2496 'current_revision': 'rev1',
2497 'revisions': {
2498 'rev1': {'commit': {'message': 'desc1'}},
2499 },
2500 }
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002501
2502 self._mock_gerrit_changes_for_detail_cache()
Edward Lemurf38bc172019-09-03 21:02:13 +00002503 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002504 cl._cached_remote_url = (
2505 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemur6c6827c2020-02-06 21:15:18 +00002506 self.assertEqual(cl.FetchDescription(), 'desc1')
2507 self.assertEqual(cl.FetchDescription(), 'desc1') # cache hit.
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002508
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002509 def test_print_current_creds(self):
2510 class CookiesAuthenticatorMock(object):
2511 def __init__(self):
2512 self.gitcookies = {
2513 'host.googlesource.com': ('user', 'pass'),
2514 'host-review.googlesource.com': ('user', 'pass'),
2515 }
2516 self.netrc = self
2517 self.netrc.hosts = {
2518 'github.com': ('user2', None, 'pass2'),
2519 'host2.googlesource.com': ('user3', None, 'pass'),
2520 }
Edward Lemurda4b6c62020-02-13 00:28:40 +00002521 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
2522 CookiesAuthenticatorMock).start()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002523 git_cl._GitCookiesChecker().print_current_creds(include_netrc=True)
2524 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2525 ' Host\t User\t Which file',
2526 '============================\t=====\t===========',
2527 'host-review.googlesource.com\t user\t.gitcookies',
2528 ' host.googlesource.com\t user\t.gitcookies',
2529 ' host2.googlesource.com\tuser3\t .netrc',
2530 ])
Edward Lemur79d4f992019-11-11 23:49:02 +00002531 sys.stdout.seek(0)
2532 sys.stdout.truncate(0)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002533 git_cl._GitCookiesChecker().print_current_creds(include_netrc=False)
2534 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2535 ' Host\tUser\t Which file',
2536 '============================\t====\t===========',
2537 'host-review.googlesource.com\tuser\t.gitcookies',
2538 ' host.googlesource.com\tuser\t.gitcookies',
2539 ])
2540
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002541 def _common_creds_check_mocks(self):
2542 def exists_mock(path):
2543 dirname = os.path.dirname(path)
2544 if dirname == os.path.expanduser('~'):
2545 dirname = '~'
2546 base = os.path.basename(path)
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002547 if base in (NETRC_FILENAME, '.gitcookies'):
2548 return self._mocked_call('os.path.exists', os.path.join(dirname, base))
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002549 # git cl also checks for existence other files not relevant to this test.
2550 return None
Edward Lemur1a83da12020-03-04 21:18:36 +00002551 mock.patch(
Edward Lesmesae3586b2020-03-23 21:21:14 +00002552 'gclient_utils.AskForData',
Edward Lemur1a83da12020-03-04 21:18:36 +00002553 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002554 mock.patch('os.path.exists', exists_mock).start()
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002555
2556 def test_creds_check_gitcookies_not_configured(self):
2557 self._common_creds_check_mocks()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002558 mock.patch('git_cl._GitCookiesChecker.get_hosts_with_creds',
2559 lambda _, include_netrc=False: []).start()
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002560 self.calls = [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002561 ((['git', 'config', '--path', 'http.cookiefile'], ), CERR1),
2562 ((['git', 'config', '--global', 'http.cookiefile'], ), CERR1),
2563 (('os.path.exists', os.path.join('~', NETRC_FILENAME)), True),
2564 (('ask_for_data', 'Press Enter to setup .gitcookies, '
2565 'or Ctrl+C to abort'), ''),
2566 (([
2567 'git', 'config', '--global', 'http.cookiefile',
2568 os.path.expanduser(os.path.join('~', '.gitcookies'))
2569 ], ), ''),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002570 ]
2571 self.assertEqual(0, git_cl.main(['creds-check']))
Edward Lemur73c76702020-02-06 23:57:18 +00002572 self.assertTrue(
2573 sys.stdout.getvalue().startswith(
2574 'You seem to be using outdated .netrc for git credentials:'))
2575 self.assertIn(
2576 '\nConfigured git to use .gitcookies from',
2577 sys.stdout.getvalue())
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002578
2579 def test_creds_check_gitcookies_configured_custom_broken(self):
2580 self._common_creds_check_mocks()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002581 mock.patch('git_cl._GitCookiesChecker.get_hosts_with_creds',
2582 lambda _, include_netrc=False: []).start()
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002583 custom_cookie_path = ('C:\\.gitcookies'
2584 if sys.platform == 'win32' else '/custom/.gitcookies')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002585 self.calls = [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002586 ((['git', 'config', '--path', 'http.cookiefile'], ), CERR1),
2587 ((['git', 'config', '--global', 'http.cookiefile'], ),
2588 custom_cookie_path),
2589 (('os.path.exists', custom_cookie_path), False),
2590 (('ask_for_data', 'Reconfigure git to use default .gitcookies? '
2591 'Press Enter to reconfigure, or Ctrl+C to abort'), ''),
2592 (([
2593 'git', 'config', '--global', 'http.cookiefile',
2594 os.path.expanduser(os.path.join('~', '.gitcookies'))
2595 ], ), ''),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002596 ]
2597 self.assertEqual(0, git_cl.main(['creds-check']))
Edward Lemur73c76702020-02-06 23:57:18 +00002598 self.assertIn(
2599 'WARNING: You have configured custom path to .gitcookies: ',
2600 sys.stdout.getvalue())
2601 self.assertIn(
2602 'However, your configured .gitcookies file is missing.',
2603 sys.stdout.getvalue())
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002604
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002605 def test_git_cl_comment_add_gerrit(self):
Edward Lemur85153282020-02-14 22:06:29 +00002606 self.mockGit.branchref = None
Edward Lemur26964072020-02-19 19:18:51 +00002607 self.mockGit.config['remote.origin.url'] = (
2608 'https://chromium.googlesource.com/infra/infra')
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002609 self.calls = [
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002610 (('SetReview', 'chromium-review.googlesource.com', 'infra%2Finfra~10',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002611 'msg', None, None, None),
Aaron Gable636b13f2017-07-14 10:42:48 -07002612 None),
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002613 ]
Edward Lemur52969c92020-02-06 18:15:28 +00002614 self.assertEqual(0, git_cl.main(['comment', '-i', '10', '-a', 'msg']))
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002615
Edward Lemurda4b6c62020-02-13 00:28:40 +00002616 @mock.patch('git_cl.Changelist.GetBranch', return_value='foo')
2617 def test_git_cl_comments_fetch_gerrit(self, *_mocks):
Edward Lemur26964072020-02-19 19:18:51 +00002618 self.mockGit.config['remote.origin.url'] = (
2619 'https://chromium.googlesource.com/infra/infra')
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002620 gerrit_util.GetChangeDetail.return_value = {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002621 'owner': {'email': 'owner@example.com'},
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002622 'current_revision': 'ba5eba11',
2623 'revisions': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002624 'deadbeaf': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002625 '_number': 1,
2626 },
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002627 'ba5eba11': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002628 '_number': 2,
2629 },
2630 },
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002631 'messages': [
2632 {
2633 u'_revision_number': 1,
2634 u'author': {
2635 u'_account_id': 1111084,
Andrii Shyshkalov8aa9d622020-03-10 19:15:35 +00002636 u'email': u'could-be-anything@example.com',
2637 u'name': u'LUCI CQ'
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002638 },
2639 u'date': u'2017-03-15 20:08:45.000000000',
2640 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
Dirk Prankef6a58802017-10-17 12:49:42 -07002641 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
Andrii Shyshkalov899785a2021-07-09 12:45:37 +00002642 u'tag': u'autogenerated:cv:dry-run'
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002643 },
2644 {
2645 u'_revision_number': 2,
2646 u'author': {
2647 u'_account_id': 11151243,
2648 u'email': u'owner@example.com',
2649 u'name': u'owner'
2650 },
2651 u'date': u'2017-03-16 20:00:41.000000000',
2652 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2653 u'message': u'PTAL',
2654 },
2655 {
2656 u'_revision_number': 2,
2657 u'author': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002658 u'_account_id': 148512,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002659 u'email': u'reviewer@example.com',
2660 u'name': u'reviewer'
2661 },
2662 u'date': u'2017-03-17 05:19:37.500000000',
2663 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2664 u'message': u'Patch Set 2: Code-Review+1',
2665 },
Josip Sokcevic266129c2021-11-09 00:22:00 +00002666 {
2667 u'_revision_number': 2,
2668 u'author': {
2669 u'_account_id': 42,
2670 u'name': u'reviewer'
2671 },
2672 u'date': u'2017-03-17 05:19:37.900000000',
2673 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d0000',
2674 u'message': u'A bot with no email set',
2675 },
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002676 ]
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002677 }
2678 self.calls = [
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002679 (('GetChangeComments', 'chromium-review.googlesource.com',
2680 'infra%2Finfra~1'), {
2681 '/COMMIT_MSG': [
2682 {
2683 'author': {
2684 'email': u'reviewer@example.com'
2685 },
2686 'updated': u'2017-03-17 05:19:37.500000000',
2687 'patch_set': 2,
2688 'side': 'REVISION',
2689 'message': 'Please include a bug link',
2690 },
2691 ],
2692 'codereview.settings': [
2693 {
2694 'author': {
2695 'email': u'owner@example.com'
2696 },
2697 'updated': u'2017-03-16 20:00:41.000000000',
2698 'patch_set': 2,
2699 'side': 'PARENT',
2700 'line': 42,
2701 'message': 'I removed this because it is bad',
2702 },
2703 ]
2704 }),
2705 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
2706 'infra%2Finfra~1'), {}),
2707 ] * 2 + [(('write_json', 'output.json', [{
2708 u'date':
2709 u'2017-03-16 20:00:41.000000',
2710 u'message': (u'PTAL\n' + u'\n' + u'codereview.settings\n' +
2711 u' Base, Line 42: https://crrev.com/c/1/2/'
2712 u'codereview.settings#b42\n' +
2713 u' I removed this because it is bad\n'),
2714 u'autogenerated':
2715 False,
2716 u'approval':
2717 False,
2718 u'disapproval':
2719 False,
2720 u'sender':
2721 u'owner@example.com'
2722 }, {
2723 u'date':
2724 u'2017-03-17 05:19:37.500000',
2725 u'message':
2726 (u'Patch Set 2: Code-Review+1\n' + u'\n' + u'/COMMIT_MSG\n' +
2727 u' PS2, File comment: https://crrev.com/c/1/2//COMMIT_MSG#\n' +
2728 u' Please include a bug link\n'),
2729 u'autogenerated':
2730 False,
2731 u'approval':
2732 False,
2733 u'disapproval':
2734 False,
2735 u'sender':
2736 u'reviewer@example.com'
2737 }]), '')]
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002738 expected_comments_summary = [
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002739 git_cl._CommentSummary(
2740 message=(u'PTAL\n' + u'\n' + u'codereview.settings\n' +
2741 u' Base, Line 42: https://crrev.com/c/1/2/' +
2742 u'codereview.settings#b42\n' +
2743 u' I removed this because it is bad\n'),
2744 date=datetime.datetime(2017, 3, 16, 20, 0, 41, 0),
2745 autogenerated=False,
2746 disapproval=False,
2747 approval=False,
2748 sender=u'owner@example.com'),
2749 git_cl._CommentSummary(message=(
2750 u'Patch Set 2: Code-Review+1\n' + u'\n' + u'/COMMIT_MSG\n' +
2751 u' PS2, File comment: https://crrev.com/c/1/2//COMMIT_MSG#\n' +
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002752 u' Please include a bug link\n'),
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002753 date=datetime.datetime(2017, 3, 17, 5, 19, 37,
2754 500000),
2755 autogenerated=False,
2756 disapproval=False,
2757 approval=False,
2758 sender=u'reviewer@example.com'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002759 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002760 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00002761 issue=1, branchref='refs/heads/foo')
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002762 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002763 self.assertEqual(
2764 0, git_cl.main(['comments', '-i', '1', '-j', 'output.json']))
2765
2766 def test_git_cl_comments_robot_comments(self):
2767 # git cl comments also fetches robot comments (which are considered a type
2768 # of autogenerated comment), and unlike other types of comments, only robot
2769 # comments from the latest patchset are shown.
Edward Lemur26964072020-02-19 19:18:51 +00002770 self.mockGit.config['remote.origin.url'] = (
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002771 'https://x.googlesource.com/infra/infra')
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002772 gerrit_util.GetChangeDetail.return_value = {
2773 'owner': {'email': 'owner@example.com'},
2774 'current_revision': 'ba5eba11',
2775 'revisions': {
2776 'deadbeaf': {
2777 '_number': 1,
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002778 },
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002779 'ba5eba11': {
2780 '_number': 2,
2781 },
2782 },
2783 'messages': [
2784 {
2785 u'_revision_number': 1,
2786 u'author': {
2787 u'_account_id': 1111084,
2788 u'email': u'commit-bot@chromium.org',
2789 u'name': u'Commit Bot'
2790 },
2791 u'date': u'2017-03-15 20:08:45.000000000',
2792 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
2793 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
2794 u'tag': u'autogenerated:cq:dry-run'
2795 },
2796 {
2797 u'_revision_number': 1,
2798 u'author': {
2799 u'_account_id': 123,
2800 u'email': u'tricium@serviceaccount.com',
2801 u'name': u'Tricium'
2802 },
2803 u'date': u'2017-03-16 20:00:41.000000000',
2804 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2805 u'message': u'(1 comment)',
2806 u'tag': u'autogenerated:tricium',
2807 },
2808 {
2809 u'_revision_number': 1,
2810 u'author': {
2811 u'_account_id': 123,
2812 u'email': u'tricium@serviceaccount.com',
2813 u'name': u'Tricium'
2814 },
2815 u'date': u'2017-03-16 20:00:41.000000000',
2816 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2817 u'message': u'(1 comment)',
2818 u'tag': u'autogenerated:tricium',
2819 },
2820 {
2821 u'_revision_number': 2,
2822 u'author': {
2823 u'_account_id': 123,
2824 u'email': u'tricium@serviceaccount.com',
2825 u'name': u'reviewer'
2826 },
2827 u'date': u'2017-03-17 05:30:37.000000000',
2828 u'tag': u'autogenerated:tricium',
2829 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2830 u'message': u'(1 comment)',
2831 },
2832 ]
2833 }
2834 self.calls = [
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002835 (('GetChangeComments', 'x-review.googlesource.com', 'infra%2Finfra~1'),
2836 {}),
2837 (('GetChangeRobotComments', 'x-review.googlesource.com',
2838 'infra%2Finfra~1'), {
2839 'codereview.settings': [
2840 {
2841 u'author': {
2842 u'email': u'tricium@serviceaccount.com'
2843 },
2844 u'updated': u'2017-03-17 05:30:37.000000000',
2845 u'robot_run_id': u'5565031076855808',
2846 u'robot_id': u'Linter/Category',
2847 u'tag': u'autogenerated:tricium',
2848 u'patch_set': 2,
2849 u'side': u'REVISION',
2850 u'message': u'Linter warning message text',
2851 u'line': 32,
2852 },
2853 ],
2854 }),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002855 ]
2856 expected_comments_summary = [
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002857 git_cl._CommentSummary(
2858 date=datetime.datetime(2017, 3, 17, 5, 30, 37),
2859 message=(u'(1 comment)\n\ncodereview.settings\n'
2860 u' PS2, Line 32: https://x-review.googlesource.com/c/1/2/'
2861 u'codereview.settings#32\n'
2862 u' Linter warning message text\n'),
2863 sender=u'tricium@serviceaccount.com',
2864 autogenerated=True,
2865 approval=False,
2866 disapproval=False)
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002867 ]
2868 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00002869 issue=1, branchref='refs/heads/foo')
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002870 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002871
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002872 def test_get_remote_url_with_mirror(self):
2873 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002874
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002875 def selective_os_path_isdir_mock(path):
2876 if path == '/cache/this-dir-exists':
2877 return self._mocked_call('os.path.isdir', path)
2878 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002879
Edward Lemurda4b6c62020-02-13 00:28:40 +00002880 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002881
2882 url = 'https://chromium.googlesource.com/my/repo'
Edward Lemur26964072020-02-19 19:18:51 +00002883 self.mockGit.config['remote.origin.url'] = (
2884 '/cache/this-dir-exists')
2885 self.mockGit.config['/cache/this-dir-exists:remote.origin.url'] = (
2886 url)
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002887 self.calls = [
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002888 (('os.path.isdir', '/cache/this-dir-exists'),
2889 True),
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002890 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002891 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002892 self.assertEqual(cl.GetRemoteUrl(), url)
2893 self.assertEqual(cl.GetRemoteUrl(), url) # Must be cached.
2894
Edward Lemur298f2cf2019-02-22 21:40:39 +00002895 def test_get_remote_url_non_existing_mirror(self):
2896 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002897
Edward Lemur298f2cf2019-02-22 21:40:39 +00002898 def selective_os_path_isdir_mock(path):
2899 if path == '/cache/this-dir-doesnt-exist':
2900 return self._mocked_call('os.path.isdir', path)
2901 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002902
Edward Lemurda4b6c62020-02-13 00:28:40 +00002903 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
2904 mock.patch('logging.error',
2905 lambda *a: self._mocked_call('logging.error', *a)).start()
Edward Lemur298f2cf2019-02-22 21:40:39 +00002906
Edward Lemur26964072020-02-19 19:18:51 +00002907 self.mockGit.config['remote.origin.url'] = (
2908 '/cache/this-dir-doesnt-exist')
Edward Lemur298f2cf2019-02-22 21:40:39 +00002909 self.calls = [
Edward Lemur298f2cf2019-02-22 21:40:39 +00002910 (('os.path.isdir', '/cache/this-dir-doesnt-exist'),
2911 False),
2912 (('logging.error',
Josip906bfde2020-01-31 22:38:49 +00002913 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
2914 'but it doesn\'t exist.', {
2915 'remote': 'origin',
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00002916 'branch': 'main',
Josip906bfde2020-01-31 22:38:49 +00002917 'url': '/cache/this-dir-doesnt-exist'}
2918 ), None),
Edward Lemur298f2cf2019-02-22 21:40:39 +00002919 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002920 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00002921 self.assertIsNone(cl.GetRemoteUrl())
2922
2923 def test_get_remote_url_misconfigured_mirror(self):
2924 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002925
Edward Lemur298f2cf2019-02-22 21:40:39 +00002926 def selective_os_path_isdir_mock(path):
2927 if path == '/cache/this-dir-exists':
2928 return self._mocked_call('os.path.isdir', path)
2929 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002930
Edward Lemurda4b6c62020-02-13 00:28:40 +00002931 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
2932 mock.patch('logging.error',
2933 lambda *a: self._mocked_call('logging.error', *a)).start()
Edward Lemur298f2cf2019-02-22 21:40:39 +00002934
Edward Lemur26964072020-02-19 19:18:51 +00002935 self.mockGit.config['remote.origin.url'] = (
2936 '/cache/this-dir-exists')
Edward Lemur298f2cf2019-02-22 21:40:39 +00002937 self.calls = [
Edward Lemur298f2cf2019-02-22 21:40:39 +00002938 (('os.path.isdir', '/cache/this-dir-exists'), True),
Edward Lemur298f2cf2019-02-22 21:40:39 +00002939 (('logging.error',
2940 'Remote "%(remote)s" for branch "%(branch)s" points to '
2941 '"%(cache_path)s", but it is misconfigured.\n'
2942 '"%(cache_path)s" must be a git repo and must have a remote named '
2943 '"%(remote)s" pointing to the git host.', {
2944 'remote': 'origin',
2945 'cache_path': '/cache/this-dir-exists',
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00002946 'branch': 'main'}
Edward Lemur298f2cf2019-02-22 21:40:39 +00002947 ), None),
2948 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002949 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00002950 self.assertIsNone(cl.GetRemoteUrl())
2951
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002952 def test_gerrit_change_identifier_with_project(self):
Edward Lemur26964072020-02-19 19:18:51 +00002953 self.mockGit.config['remote.origin.url'] = (
2954 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemurf38bc172019-09-03 21:02:13 +00002955 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002956 self.assertEqual(cl._GerritChangeIdentifier(), 'my%2Frepo~123456')
2957
2958 def test_gerrit_change_identifier_without_project(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002959 mock.patch('logging.error',
2960 lambda *a: self._mocked_call('logging.error', *a)).start()
Josip906bfde2020-01-31 22:38:49 +00002961
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002962 self.calls = [
Josip906bfde2020-01-31 22:38:49 +00002963 (('logging.error',
2964 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
2965 'but it doesn\'t exist.', {
2966 'remote': 'origin',
Josip Sokcevic7e133ff2021-07-13 17:44:53 +00002967 'branch': 'main',
Josip906bfde2020-01-31 22:38:49 +00002968 'url': ''}
2969 ), None),
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002970 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002971 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002972 self.assertEqual(cl._GerritChangeIdentifier(), '123456')
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00002973
Josip Sokcevicc39ab992020-09-24 20:09:15 +00002974 def test_gerrit_new_default(self):
2975 self._run_gerrit_upload_test(
2976 [],
2977 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
2978 [],
2979 squash=False,
2980 squash_mode='override_nosquash',
2981 change_id='I123456789',
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00002982 default_branch='main')
Josip Sokcevicc39ab992020-09-24 20:09:15 +00002983
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002984
Edward Lemur9aa1a962020-02-25 00:58:38 +00002985class ChangelistTest(unittest.TestCase):
mlcui3da91712021-05-05 10:00:30 +00002986 LAST_COMMIT_SUBJECT = 'Fixes goat teleporter destination to be Australia'
2987
2988 def _mock_run_git(commands):
2989 if commands == ['show', '-s', '--format=%s', 'HEAD']:
2990 return ChangelistTest.LAST_COMMIT_SUBJECT
2991
Edward Lemur227d5102020-02-25 23:45:35 +00002992 def setUp(self):
2993 super(ChangelistTest, self).setUp()
2994 mock.patch('gclient_utils.FileRead').start()
2995 mock.patch('gclient_utils.FileWrite').start()
2996 mock.patch('gclient_utils.temporary_file', TemporaryFileMock()).start()
2997 mock.patch(
2998 'git_cl.Changelist.GetCodereviewServer',
2999 return_value='https://chromium-review.googlesource.com').start()
3000 mock.patch('git_cl.Changelist.GetAuthor', return_value='author').start()
3001 mock.patch('git_cl.Changelist.GetIssue', return_value=123456).start()
3002 mock.patch('git_cl.Changelist.GetPatchset', return_value=7).start()
Dirk Pranke6f0df682021-06-25 00:42:33 +00003003 mock.patch('git_cl.Changelist.GetUsePython3', return_value=False).start()
Edward Lesmeseb1bd622021-03-01 19:54:07 +00003004 mock.patch(
3005 'git_cl.Changelist.GetRemoteBranch',
3006 return_value=('origin', 'refs/remotes/origin/main')).start()
Edward Lemur227d5102020-02-25 23:45:35 +00003007 mock.patch('git_cl.PRESUBMIT_SUPPORT', 'PRESUBMIT_SUPPORT').start()
3008 mock.patch('git_cl.Settings.GetRoot', return_value='root').start()
3009 mock.patch('git_cl.time_time').start()
3010 mock.patch('metrics.collector').start()
3011 mock.patch('subprocess2.Popen').start()
Edward Lesmeseb1bd622021-03-01 19:54:07 +00003012 mock.patch(
3013 'git_cl.Changelist.GetGerritProject', return_value='project').start()
Edward Lemur227d5102020-02-25 23:45:35 +00003014 self.addCleanup(mock.patch.stopall)
3015 self.temp_count = 0
3016
Edward Lemur227d5102020-02-25 23:45:35 +00003017 def testRunHook(self):
3018 expected_results = {
Dirk Pranke61bf6e82021-04-23 00:50:21 +00003019 'more_cc': ['cc@example.com', 'more@example.com'],
3020 'errors': [],
3021 'notifications': [],
3022 'warnings': [],
Edward Lemur227d5102020-02-25 23:45:35 +00003023 }
3024 gclient_utils.FileRead.return_value = json.dumps(expected_results)
Dirk Pranke61bf6e82021-04-23 00:50:21 +00003025 git_cl.time_time.side_effect = [100, 200, 300, 400]
Edward Lemur227d5102020-02-25 23:45:35 +00003026 mockProcess = mock.Mock()
3027 mockProcess.wait.return_value = 0
3028 subprocess2.Popen.return_value = mockProcess
3029
3030 cl = git_cl.Changelist()
3031 results = cl.RunHook(
3032 committing=True,
3033 may_prompt=True,
3034 verbose=2,
3035 parallel=True,
3036 upstream='upstream',
3037 description='description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003038 all_files=True,
3039 resultdb=False)
Edward Lemur227d5102020-02-25 23:45:35 +00003040
3041 self.assertEqual(expected_results, results)
Dirk Pranke61bf6e82021-04-23 00:50:21 +00003042 subprocess2.Popen.assert_any_call([
Edward Lemur227d5102020-02-25 23:45:35 +00003043 'vpython', 'PRESUBMIT_SUPPORT',
Edward Lemur227d5102020-02-25 23:45:35 +00003044 '--root', 'root',
3045 '--upstream', 'upstream',
3046 '--verbose', '--verbose',
Edward Lemur99df04e2020-03-05 19:39:43 +00003047 '--gerrit_url', 'https://chromium-review.googlesource.com',
Edward Lesmeseb1bd622021-03-01 19:54:07 +00003048 '--gerrit_project', 'project',
3049 '--gerrit_branch', 'refs/heads/main',
3050 '--author', 'author',
Edward Lemur227d5102020-02-25 23:45:35 +00003051 '--issue', '123456',
3052 '--patchset', '7',
Edward Lemur75526302020-02-27 22:31:05 +00003053 '--commit',
Edward Lemur227d5102020-02-25 23:45:35 +00003054 '--may_prompt',
3055 '--parallel',
3056 '--all_files',
3057 '--json_output', '/tmp/fake-temp2',
3058 '--description_file', '/tmp/fake-temp1',
3059 ])
Dirk Pranke61bf6e82021-04-23 00:50:21 +00003060 subprocess2.Popen.assert_any_call([
3061 'vpython3', 'PRESUBMIT_SUPPORT',
3062 '--root', 'root',
3063 '--upstream', 'upstream',
3064 '--verbose', '--verbose',
3065 '--gerrit_url', 'https://chromium-review.googlesource.com',
3066 '--gerrit_project', 'project',
3067 '--gerrit_branch', 'refs/heads/main',
3068 '--author', 'author',
3069 '--issue', '123456',
3070 '--patchset', '7',
3071 '--commit',
3072 '--may_prompt',
3073 '--parallel',
3074 '--all_files',
3075 '--json_output', '/tmp/fake-temp4',
3076 '--description_file', '/tmp/fake-temp3',
3077 ])
3078 gclient_utils.FileWrite.assert_any_call(
Edward Lemur1a83da12020-03-04 21:18:36 +00003079 '/tmp/fake-temp1', 'description')
Edward Lemur227d5102020-02-25 23:45:35 +00003080 metrics.collector.add_repeated('sub_commands', {
3081 'command': 'presubmit',
3082 'execution_time': 100,
3083 'exit_code': 0,
3084 })
3085
Edward Lemur99df04e2020-03-05 19:39:43 +00003086 def testRunHook_FewerOptions(self):
3087 expected_results = {
Dirk Pranke61bf6e82021-04-23 00:50:21 +00003088 'more_cc': ['cc@example.com', 'more@example.com'],
3089 'errors': [],
3090 'notifications': [],
3091 'warnings': [],
Edward Lemur99df04e2020-03-05 19:39:43 +00003092 }
3093 gclient_utils.FileRead.return_value = json.dumps(expected_results)
Dirk Pranke61bf6e82021-04-23 00:50:21 +00003094 git_cl.time_time.side_effect = [100, 200, 300, 400]
Edward Lemur99df04e2020-03-05 19:39:43 +00003095 mockProcess = mock.Mock()
3096 mockProcess.wait.return_value = 0
3097 subprocess2.Popen.return_value = mockProcess
3098
3099 git_cl.Changelist.GetAuthor.return_value = None
3100 git_cl.Changelist.GetIssue.return_value = None
3101 git_cl.Changelist.GetPatchset.return_value = None
Edward Lemur99df04e2020-03-05 19:39:43 +00003102
3103 cl = git_cl.Changelist()
3104 results = cl.RunHook(
3105 committing=False,
3106 may_prompt=False,
3107 verbose=0,
3108 parallel=False,
3109 upstream='upstream',
3110 description='description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003111 all_files=False,
3112 resultdb=False)
Edward Lemur99df04e2020-03-05 19:39:43 +00003113
3114 self.assertEqual(expected_results, results)
Dirk Pranke61bf6e82021-04-23 00:50:21 +00003115 subprocess2.Popen.assert_any_call([
Edward Lemur99df04e2020-03-05 19:39:43 +00003116 'vpython', 'PRESUBMIT_SUPPORT',
3117 '--root', 'root',
3118 '--upstream', 'upstream',
Edward Lesmeseb1bd622021-03-01 19:54:07 +00003119 '--gerrit_url', 'https://chromium-review.googlesource.com',
3120 '--gerrit_project', 'project',
3121 '--gerrit_branch', 'refs/heads/main',
Edward Lemur99df04e2020-03-05 19:39:43 +00003122 '--upload',
3123 '--json_output', '/tmp/fake-temp2',
3124 '--description_file', '/tmp/fake-temp1',
3125 ])
Dirk Pranke61bf6e82021-04-23 00:50:21 +00003126 gclient_utils.FileWrite.assert_any_call(
Edward Lemur99df04e2020-03-05 19:39:43 +00003127 '/tmp/fake-temp1', 'description')
3128 metrics.collector.add_repeated('sub_commands', {
3129 'command': 'presubmit',
3130 'execution_time': 100,
3131 'exit_code': 0,
3132 })
3133
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003134 def testRunHook_FewerOptionsResultDB(self):
3135 expected_results = {
Dirk Pranke61bf6e82021-04-23 00:50:21 +00003136 'more_cc': ['cc@example.com', 'more@example.com'],
3137 'errors': [],
3138 'notifications': [],
3139 'warnings': [],
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003140 }
3141 gclient_utils.FileRead.return_value = json.dumps(expected_results)
Dirk Pranke61bf6e82021-04-23 00:50:21 +00003142 git_cl.time_time.side_effect = [100, 200, 300, 400]
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003143 mockProcess = mock.Mock()
3144 mockProcess.wait.return_value = 0
3145 subprocess2.Popen.return_value = mockProcess
3146
3147 git_cl.Changelist.GetAuthor.return_value = None
3148 git_cl.Changelist.GetIssue.return_value = None
3149 git_cl.Changelist.GetPatchset.return_value = None
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003150
3151 cl = git_cl.Changelist()
3152 results = cl.RunHook(
3153 committing=False,
3154 may_prompt=False,
3155 verbose=0,
3156 parallel=False,
3157 upstream='upstream',
3158 description='description',
3159 all_files=False,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003160 resultdb=True,
3161 realm='chromium:public')
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003162
3163 self.assertEqual(expected_results, results)
Dirk Pranke61bf6e82021-04-23 00:50:21 +00003164 subprocess2.Popen.assert_any_call([
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003165 'rdb', 'stream', '-new', '-realm', 'chromium:public', '--',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003166 'vpython', 'PRESUBMIT_SUPPORT',
3167 '--root', 'root',
3168 '--upstream', 'upstream',
Edward Lesmeseb1bd622021-03-01 19:54:07 +00003169 '--gerrit_url', 'https://chromium-review.googlesource.com',
3170 '--gerrit_project', 'project',
3171 '--gerrit_branch', 'refs/heads/main',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003172 '--upload',
3173 '--json_output', '/tmp/fake-temp2',
3174 '--description_file', '/tmp/fake-temp1',
3175 ])
3176
Edward Lemur227d5102020-02-25 23:45:35 +00003177 @mock.patch('sys.exit', side_effect=SystemExitMock)
3178 def testRunHook_Failure(self, _mock):
3179 git_cl.time_time.side_effect = [100, 200]
3180 mockProcess = mock.Mock()
3181 mockProcess.wait.return_value = 2
3182 subprocess2.Popen.return_value = mockProcess
3183
3184 cl = git_cl.Changelist()
3185 with self.assertRaises(SystemExitMock):
3186 cl.RunHook(
3187 committing=True,
3188 may_prompt=True,
3189 verbose=2,
3190 parallel=True,
3191 upstream='upstream',
3192 description='description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003193 all_files=True,
3194 resultdb=False)
Edward Lemur227d5102020-02-25 23:45:35 +00003195
3196 sys.exit.assert_called_once_with(2)
3197
Edward Lemur75526302020-02-27 22:31:05 +00003198 def testRunPostUploadHook(self):
3199 cl = git_cl.Changelist()
3200 cl.RunPostUploadHook(2, 'upstream', 'description')
3201
3202 subprocess2.Popen.assert_called_once_with([
3203 'vpython', 'PRESUBMIT_SUPPORT',
Edward Lemur75526302020-02-27 22:31:05 +00003204 '--root', 'root',
3205 '--upstream', 'upstream',
3206 '--verbose', '--verbose',
Edward Lemur99df04e2020-03-05 19:39:43 +00003207 '--gerrit_url', 'https://chromium-review.googlesource.com',
Edward Lesmeseb1bd622021-03-01 19:54:07 +00003208 '--gerrit_project', 'project',
3209 '--gerrit_branch', 'refs/heads/main',
3210 '--author', 'author',
Edward Lemur75526302020-02-27 22:31:05 +00003211 '--issue', '123456',
3212 '--patchset', '7',
Edward Lemur75526302020-02-27 22:31:05 +00003213 '--post_upload',
3214 '--description_file', '/tmp/fake-temp1',
3215 ])
3216 gclient_utils.FileWrite.assert_called_once_with(
Edward Lemur1a83da12020-03-04 21:18:36 +00003217 '/tmp/fake-temp1', 'description')
Edward Lemur75526302020-02-27 22:31:05 +00003218
mlcui3da91712021-05-05 10:00:30 +00003219 @mock.patch('git_cl.RunGit', _mock_run_git)
3220 def testDefaultTitleEmptyMessage(self):
3221 cl = git_cl.Changelist()
3222 cl.issue = 100
3223 options = optparse.Values({
3224 'squash': True,
3225 'title': None,
3226 'message': None,
3227 'force': None,
3228 'skip_title': None
3229 })
3230
3231 mock.patch('gclient_utils.AskForData', lambda _: user_title).start()
3232 for user_title in ['', 'y', 'Y']:
3233 self.assertEqual(cl._GetTitleForUpload(options), self.LAST_COMMIT_SUBJECT)
3234
3235 for user_title in ['not empty', 'yes', 'YES']:
3236 self.assertEqual(cl._GetTitleForUpload(options), user_title)
3237
Edward Lemur9aa1a962020-02-25 00:58:38 +00003238
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003239class CMDTestCaseBase(unittest.TestCase):
3240 _STATUSES = [
3241 'STATUS_UNSPECIFIED', 'SCHEDULED', 'STARTED', 'SUCCESS', 'FAILURE',
3242 'INFRA_FAILURE', 'CANCELED',
3243 ]
3244 _CHANGE_DETAIL = {
3245 'project': 'depot_tools',
3246 'status': 'OPEN',
3247 'owner': {'email': 'owner@e.mail'},
3248 'current_revision': 'beeeeeef',
3249 'revisions': {
Gavin Make61ccc52020-11-13 00:12:57 +00003250 'deadbeaf': {
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00003251 '_number': 6,
Gavin Make61ccc52020-11-13 00:12:57 +00003252 'kind': 'REWORK',
3253 },
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003254 'beeeeeef': {
3255 '_number': 7,
Gavin Make61ccc52020-11-13 00:12:57 +00003256 'kind': 'NO_CODE_CHANGE',
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003257 'fetch': {'http': {
3258 'url': 'https://chromium.googlesource.com/depot_tools',
3259 'ref': 'refs/changes/56/123456/7'
3260 }},
3261 },
3262 },
3263 }
3264 _DEFAULT_RESPONSE = {
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003265 'builds': [{
3266 'id': str(100 + idx),
3267 'builder': {
3268 'project': 'chromium',
3269 'bucket': 'try',
3270 'builder': 'bot_' + status.lower(),
3271 },
3272 'createTime': '2019-10-09T08:00:0%d.854286Z' % (idx % 10),
3273 'tags': [],
3274 'status': status,
3275 } for idx, status in enumerate(_STATUSES)]
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003276 }
3277
Edward Lemur4c707a22019-09-24 21:13:43 +00003278 def setUp(self):
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003279 super(CMDTestCaseBase, self).setUp()
Edward Lemur79d4f992019-11-11 23:49:02 +00003280 mock.patch('git_cl.sys.stdout', StringIO()).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003281 mock.patch('git_cl.uuid.uuid4', return_value='uuid4').start()
3282 mock.patch('git_cl.Changelist.GetIssue', return_value=123456).start()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00003283 mock.patch(
3284 'git_cl.Changelist.GetCodereviewServer',
3285 return_value='https://chromium-review.googlesource.com').start()
3286 mock.patch(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00003287 'git_cl.Changelist.GetGerritHost',
Edward Lesmes7677e5c2020-02-19 20:39:03 +00003288 return_value='chromium-review.googlesource.com').start()
3289 mock.patch(
3290 'git_cl.Changelist.GetMostRecentPatchset',
3291 return_value=7).start()
3292 mock.patch(
Gavin Make61ccc52020-11-13 00:12:57 +00003293 'git_cl.Changelist.GetMostRecentDryRunPatchset',
3294 return_value=6).start()
3295 mock.patch(
Edward Lesmes7677e5c2020-02-19 20:39:03 +00003296 'git_cl.Changelist.GetRemoteUrl',
3297 return_value='https://chromium.googlesource.com/depot_tools').start()
3298 mock.patch(
3299 'auth.Authenticator',
3300 return_value=AuthenticatorMock()).start()
3301 mock.patch(
3302 'gerrit_util.GetChangeDetail',
3303 return_value=self._CHANGE_DETAIL).start()
3304 mock.patch(
3305 'git_cl._call_buildbucket',
3306 return_value = self._DEFAULT_RESPONSE).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003307 mock.patch('git_common.is_dirty_git_tree', return_value=False).start()
Edward Lemur4c707a22019-09-24 21:13:43 +00003308 self.addCleanup(mock.patch.stopall)
3309
Edward Lemur4c707a22019-09-24 21:13:43 +00003310
Edward Lemur9468eba2020-02-27 19:07:22 +00003311class CMDPresubmitTestCase(CMDTestCaseBase):
3312 def setUp(self):
3313 super(CMDPresubmitTestCase, self).setUp()
3314 mock.patch(
3315 'git_cl.Changelist.GetCommonAncestorWithUpstream',
3316 return_value='upstream').start()
3317 mock.patch(
3318 'git_cl.Changelist.FetchDescription',
3319 return_value='fetch description').start()
3320 mock.patch(
Edward Lemura12175c2020-03-09 16:58:26 +00003321 'git_cl._create_description_from_log',
Edward Lemur9468eba2020-02-27 19:07:22 +00003322 return_value='get description').start()
3323 mock.patch('git_cl.Changelist.RunHook').start()
3324
3325 def testDefaultCase(self):
3326 self.assertEqual(0, git_cl.main(['presubmit']))
3327 git_cl.Changelist.RunHook.assert_called_once_with(
3328 committing=True,
3329 may_prompt=False,
3330 verbose=0,
3331 parallel=None,
3332 upstream='upstream',
3333 description='fetch description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003334 all_files=None,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003335 resultdb=None,
3336 realm=None)
Edward Lemur9468eba2020-02-27 19:07:22 +00003337
3338 def testNoIssue(self):
3339 git_cl.Changelist.GetIssue.return_value = None
3340 self.assertEqual(0, git_cl.main(['presubmit']))
3341 git_cl.Changelist.RunHook.assert_called_once_with(
3342 committing=True,
3343 may_prompt=False,
3344 verbose=0,
3345 parallel=None,
3346 upstream='upstream',
3347 description='get description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003348 all_files=None,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003349 resultdb=None,
3350 realm=None)
Edward Lemur9468eba2020-02-27 19:07:22 +00003351
3352 def testCustomBranch(self):
3353 self.assertEqual(0, git_cl.main(['presubmit', 'custom_branch']))
3354 git_cl.Changelist.RunHook.assert_called_once_with(
3355 committing=True,
3356 may_prompt=False,
3357 verbose=0,
3358 parallel=None,
3359 upstream='custom_branch',
3360 description='fetch description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003361 all_files=None,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003362 resultdb=None,
3363 realm=None)
Edward Lemur9468eba2020-02-27 19:07:22 +00003364
3365 def testOptions(self):
3366 self.assertEqual(
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003367 0, git_cl.main(['presubmit', '-v', '-v', '--all', '--parallel', '-u',
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003368 '--resultdb', '--realm', 'chromium:public']))
Edward Lemur9468eba2020-02-27 19:07:22 +00003369 git_cl.Changelist.RunHook.assert_called_once_with(
3370 committing=False,
3371 may_prompt=False,
3372 verbose=2,
3373 parallel=True,
3374 upstream='upstream',
3375 description='fetch description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003376 all_files=True,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003377 resultdb=True,
3378 realm='chromium:public')
Edward Lemur9468eba2020-02-27 19:07:22 +00003379
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003380class CMDTryResultsTestCase(CMDTestCaseBase):
3381 _DEFAULT_REQUEST = {
3382 'predicate': {
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003383 "gerritChanges": [{
3384 "project": "depot_tools",
3385 "host": "chromium-review.googlesource.com",
Gavin Make61ccc52020-11-13 00:12:57 +00003386 "patchset": 6,
3387 "change": 123456,
3388 }],
3389 },
3390 'fields': ('builds.*.id,builds.*.builder,builds.*.status' +
3391 ',builds.*.createTime,builds.*.tags'),
3392 }
3393
3394 _TRIVIAL_REQUEST = {
3395 'predicate': {
3396 "gerritChanges": [{
3397 "project": "depot_tools",
3398 "host": "chromium-review.googlesource.com",
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003399 "patchset": 7,
3400 "change": 123456,
3401 }],
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003402 },
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003403 'fields': ('builds.*.id,builds.*.builder,builds.*.status' +
3404 ',builds.*.createTime,builds.*.tags'),
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003405 }
3406
3407 def testNoJobs(self):
3408 git_cl._call_buildbucket.return_value = {}
3409
3410 self.assertEqual(0, git_cl.main(['try-results']))
3411 self.assertEqual('No tryjobs scheduled.\n', sys.stdout.getvalue())
3412 git_cl._call_buildbucket.assert_called_once_with(
3413 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3414 self._DEFAULT_REQUEST)
3415
Gavin Make61ccc52020-11-13 00:12:57 +00003416 def testTrivialCommits(self):
3417 self.assertEqual(0, git_cl.main(['try-results']))
3418 git_cl._call_buildbucket.assert_called_with(
3419 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3420 self._DEFAULT_REQUEST)
3421
3422 git_cl._call_buildbucket.return_value = {}
3423 self.assertEqual(0, git_cl.main(['try-results', '--patchset', '7']))
3424 git_cl._call_buildbucket.assert_called_with(
3425 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3426 self._TRIVIAL_REQUEST)
3427 self.assertEqual([
3428 'Successes:',
3429 ' bot_success https://ci.chromium.org/b/103',
3430 'Infra Failures:',
3431 ' bot_infra_failure https://ci.chromium.org/b/105',
3432 'Failures:',
3433 ' bot_failure https://ci.chromium.org/b/104',
3434 'Canceled:',
3435 ' bot_canceled ',
3436 'Started:',
3437 ' bot_started https://ci.chromium.org/b/102',
3438 'Scheduled:',
3439 ' bot_scheduled id=101',
3440 'Other:',
3441 ' bot_status_unspecified id=100',
3442 'Total: 7 tryjobs',
3443 'No tryjobs scheduled.',
3444 ], sys.stdout.getvalue().splitlines())
3445
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003446 def testPrintToStdout(self):
3447 self.assertEqual(0, git_cl.main(['try-results']))
3448 self.assertEqual([
3449 'Successes:',
3450 ' bot_success https://ci.chromium.org/b/103',
3451 'Infra Failures:',
3452 ' bot_infra_failure https://ci.chromium.org/b/105',
3453 'Failures:',
3454 ' bot_failure https://ci.chromium.org/b/104',
3455 'Canceled:',
3456 ' bot_canceled ',
3457 'Started:',
3458 ' bot_started https://ci.chromium.org/b/102',
3459 'Scheduled:',
3460 ' bot_scheduled id=101',
3461 'Other:',
3462 ' bot_status_unspecified id=100',
3463 'Total: 7 tryjobs',
3464 ], sys.stdout.getvalue().splitlines())
3465 git_cl._call_buildbucket.assert_called_once_with(
3466 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3467 self._DEFAULT_REQUEST)
3468
3469 def testPrintToStdoutWithMasters(self):
3470 self.assertEqual(0, git_cl.main(['try-results', '--print-master']))
3471 self.assertEqual([
3472 'Successes:',
3473 ' try bot_success https://ci.chromium.org/b/103',
3474 'Infra Failures:',
3475 ' try bot_infra_failure https://ci.chromium.org/b/105',
3476 'Failures:',
3477 ' try bot_failure https://ci.chromium.org/b/104',
3478 'Canceled:',
3479 ' try bot_canceled ',
3480 'Started:',
3481 ' try bot_started https://ci.chromium.org/b/102',
3482 'Scheduled:',
3483 ' try bot_scheduled id=101',
3484 'Other:',
3485 ' try bot_status_unspecified id=100',
3486 'Total: 7 tryjobs',
3487 ], sys.stdout.getvalue().splitlines())
3488 git_cl._call_buildbucket.assert_called_once_with(
3489 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3490 self._DEFAULT_REQUEST)
3491
3492 @mock.patch('git_cl.write_json')
3493 def testWriteToJson(self, mockJsonDump):
3494 self.assertEqual(0, git_cl.main(['try-results', '--json', 'file.json']))
3495 git_cl._call_buildbucket.assert_called_once_with(
3496 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3497 self._DEFAULT_REQUEST)
3498 mockJsonDump.assert_called_once_with(
3499 'file.json', self._DEFAULT_RESPONSE['builds'])
3500
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003501 def test_filter_failed_for_one_simple(self):
Edward Lemur45768512020-03-02 19:03:14 +00003502 self.assertEqual([], git_cl._filter_failed_for_retry([]))
3503 self.assertEqual(
3504 [
3505 ('chromium', 'try', 'bot_failure'),
3506 ('chromium', 'try', 'bot_infra_failure'),
3507 ],
3508 git_cl._filter_failed_for_retry(self._DEFAULT_RESPONSE['builds']))
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003509
3510 def test_filter_failed_for_retry_many_builds(self):
3511
3512 def _build(name, created_sec, status, experimental=False):
3513 assert 0 <= created_sec < 100, created_sec
3514 b = {
3515 'id': 112112,
3516 'builder': {
3517 'project': 'chromium',
3518 'bucket': 'try',
3519 'builder': name,
3520 },
3521 'createTime': '2019-10-09T08:00:%02d.854286Z' % created_sec,
3522 'status': status,
3523 'tags': [],
3524 }
3525 if experimental:
3526 b['tags'].append({'key': 'cq_experimental', 'value': 'true'})
3527 return b
3528
3529 builds = [
3530 _build('flaky-last-green', 1, 'FAILURE'),
3531 _build('flaky-last-green', 2, 'SUCCESS'),
3532 _build('flaky', 1, 'SUCCESS'),
3533 _build('flaky', 2, 'FAILURE'),
3534 _build('running', 1, 'FAILED'),
3535 _build('running', 2, 'SCHEDULED'),
3536 _build('yep-still-running', 1, 'STARTED'),
3537 _build('yep-still-running', 2, 'FAILURE'),
3538 _build('cq-experimental', 1, 'SUCCESS', experimental=True),
3539 _build('cq-experimental', 2, 'FAILURE', experimental=True),
3540
3541 # Simulate experimental in CQ builder, which developer decided
3542 # to retry manually which resulted in 2nd build non-experimental.
3543 _build('sometimes-experimental', 1, 'FAILURE', experimental=True),
3544 _build('sometimes-experimental', 2, 'FAILURE', experimental=False),
3545 ]
3546 builds.sort(key=lambda b: b['status']) # ~deterministic shuffle.
Edward Lemur45768512020-03-02 19:03:14 +00003547 self.assertEqual(
3548 [
3549 ('chromium', 'try', 'flaky'),
3550 ('chromium', 'try', 'sometimes-experimental'),
3551 ],
3552 git_cl._filter_failed_for_retry(builds))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003553
3554
3555class CMDTryTestCase(CMDTestCaseBase):
3556
3557 @mock.patch('git_cl.Changelist.SetCQState')
Edward Lemur45768512020-03-02 19:03:14 +00003558 def testSetCQDryRunByDefault(self, mockSetCQState):
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003559 mockSetCQState.return_value = 0
Edward Lemur4c707a22019-09-24 21:13:43 +00003560 self.assertEqual(0, git_cl.main(['try']))
3561 git_cl.Changelist.SetCQState.assert_called_with(git_cl._CQState.DRY_RUN)
3562 self.assertEqual(
3563 sys.stdout.getvalue(),
3564 'Scheduling CQ dry run on: '
3565 'https://chromium-review.googlesource.com/123456\n')
3566
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00003567 @mock.patch('git_cl.Changelist.SetCQState')
3568 def testSetCQQuickRunByDefault(self, mockSetCQState):
3569 mockSetCQState.return_value = 0
3570 self.assertEqual(0, git_cl.main(['try', '-q']))
3571 git_cl.Changelist.SetCQState.assert_called_with(git_cl._CQState.QUICK_RUN)
3572 self.assertEqual(
3573 sys.stdout.getvalue(),
3574 'Scheduling CQ quick run on: '
3575 'https://chromium-review.googlesource.com/123456\n')
3576
Edward Lemur4c707a22019-09-24 21:13:43 +00003577 @mock.patch('git_cl._call_buildbucket')
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003578 def testScheduleOnBuildbucket(self, mockCallBuildbucket):
Edward Lemur4c707a22019-09-24 21:13:43 +00003579 mockCallBuildbucket.return_value = {}
Edward Lemur4c707a22019-09-24 21:13:43 +00003580
3581 self.assertEqual(0, git_cl.main([
3582 'try', '-B', 'luci.chromium.try', '-b', 'win',
3583 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
3584 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003585 'Scheduling jobs on:\n'
3586 ' chromium/try: win',
Edward Lemur4c707a22019-09-24 21:13:43 +00003587 git_cl.sys.stdout.getvalue())
3588
3589 expected_request = {
3590 "requests": [{
3591 "scheduleBuild": {
3592 "requestId": "uuid4",
3593 "builder": {
3594 "project": "chromium",
3595 "builder": "win",
3596 "bucket": "try",
3597 },
3598 "gerritChanges": [{
3599 "project": "depot_tools",
3600 "host": "chromium-review.googlesource.com",
3601 "patchset": 7,
3602 "change": 123456,
3603 }],
3604 "properties": {
3605 "category": "git_cl_try",
3606 "json": [{"a": 1}, None],
3607 "key": "val",
3608 },
3609 "tags": [
3610 {"value": "win", "key": "builder"},
3611 {"value": "git_cl_try", "key": "user_agent"},
3612 ],
3613 },
3614 }],
3615 }
3616 mockCallBuildbucket.assert_called_with(
3617 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3618
Anthony Polito1a5fe232020-01-24 23:17:52 +00003619 @mock.patch('git_cl._call_buildbucket')
3620 def testScheduleOnBuildbucketWithRevision(self, mockCallBuildbucket):
3621 mockCallBuildbucket.return_value = {}
Josip Sokcevic9011a5b2021-02-12 18:59:44 +00003622 mock.patch('git_cl.Changelist.GetRemoteBranch',
3623 return_value=('origin', 'refs/remotes/origin/main')).start()
Anthony Polito1a5fe232020-01-24 23:17:52 +00003624
3625 self.assertEqual(0, git_cl.main([
3626 'try', '-B', 'luci.chromium.try', '-b', 'win', '-b', 'linux',
3627 '-p', 'key=val', '-p', 'json=[{"a":1}, null]',
3628 '-r', 'beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef']))
3629 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003630 'Scheduling jobs on:\n'
3631 ' chromium/try: linux\n'
3632 ' chromium/try: win',
Anthony Polito1a5fe232020-01-24 23:17:52 +00003633 git_cl.sys.stdout.getvalue())
3634
3635 expected_request = {
3636 "requests": [{
3637 "scheduleBuild": {
3638 "requestId": "uuid4",
3639 "builder": {
3640 "project": "chromium",
3641 "builder": "linux",
3642 "bucket": "try",
3643 },
3644 "gerritChanges": [{
3645 "project": "depot_tools",
3646 "host": "chromium-review.googlesource.com",
3647 "patchset": 7,
3648 "change": 123456,
3649 }],
3650 "properties": {
3651 "category": "git_cl_try",
3652 "json": [{"a": 1}, None],
3653 "key": "val",
3654 },
3655 "tags": [
3656 {"value": "linux", "key": "builder"},
3657 {"value": "git_cl_try", "key": "user_agent"},
3658 ],
3659 "gitilesCommit": {
3660 "host": "chromium-review.googlesource.com",
3661 "project": "depot_tools",
3662 "id": "beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef",
Josip Sokcevic9011a5b2021-02-12 18:59:44 +00003663 "ref": "refs/heads/main",
Anthony Polito1a5fe232020-01-24 23:17:52 +00003664 }
3665 },
3666 },
3667 {
3668 "scheduleBuild": {
3669 "requestId": "uuid4",
3670 "builder": {
3671 "project": "chromium",
3672 "builder": "win",
3673 "bucket": "try",
3674 },
3675 "gerritChanges": [{
3676 "project": "depot_tools",
3677 "host": "chromium-review.googlesource.com",
3678 "patchset": 7,
3679 "change": 123456,
3680 }],
3681 "properties": {
3682 "category": "git_cl_try",
3683 "json": [{"a": 1}, None],
3684 "key": "val",
3685 },
3686 "tags": [
3687 {"value": "win", "key": "builder"},
3688 {"value": "git_cl_try", "key": "user_agent"},
3689 ],
3690 "gitilesCommit": {
3691 "host": "chromium-review.googlesource.com",
3692 "project": "depot_tools",
3693 "id": "beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef",
Josip Sokcevic9011a5b2021-02-12 18:59:44 +00003694 "ref": "refs/heads/main",
Anthony Polito1a5fe232020-01-24 23:17:52 +00003695 }
3696 },
3697 }],
3698 }
3699 mockCallBuildbucket.assert_called_with(
3700 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3701
Edward Lemur45768512020-03-02 19:03:14 +00003702 @mock.patch('sys.stderr', StringIO())
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003703 def testScheduleOnBuildbucket_WrongBucket(self):
Edward Lemur45768512020-03-02 19:03:14 +00003704 with self.assertRaises(SystemExit):
3705 git_cl.main([
3706 'try', '-B', 'not-a-bucket', '-b', 'win',
3707 '-p', 'key=val', '-p', 'json=[{"a":1}, null]'])
Edward Lemur4c707a22019-09-24 21:13:43 +00003708 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003709 'Invalid bucket: not-a-bucket.',
3710 sys.stderr.getvalue())
Edward Lemur4c707a22019-09-24 21:13:43 +00003711
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003712 @mock.patch('git_cl._call_buildbucket')
Quinten Yearsley777660f2020-03-04 23:37:06 +00003713 @mock.patch('git_cl._fetch_tryjobs')
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003714 def testScheduleOnBuildbucketRetryFailed(
3715 self, mockFetchTryJobs, mockCallBuildbucket):
Quinten Yearsley777660f2020-03-04 23:37:06 +00003716 git_cl._fetch_tryjobs.side_effect = lambda *_, **kw: {
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003717 7: [],
3718 6: [{
3719 'id': 112112,
3720 'builder': {
3721 'project': 'chromium',
3722 'bucket': 'try',
Quinten Yearsley777660f2020-03-04 23:37:06 +00003723 'builder': 'linux', },
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003724 'createTime': '2019-10-09T08:00:01.854286Z',
3725 'tags': [],
Quinten Yearsley777660f2020-03-04 23:37:06 +00003726 'status': 'FAILURE', }], }[kw['patchset']]
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003727 mockCallBuildbucket.return_value = {}
3728
3729 self.assertEqual(0, git_cl.main(['try', '--retry-failed']))
3730 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003731 'Scheduling jobs on:\n'
3732 ' chromium/try: linux',
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003733 git_cl.sys.stdout.getvalue())
3734
3735 expected_request = {
3736 "requests": [{
3737 "scheduleBuild": {
3738 "requestId": "uuid4",
3739 "builder": {
3740 "project": "chromium",
3741 "bucket": "try",
3742 "builder": "linux",
3743 },
3744 "gerritChanges": [{
3745 "project": "depot_tools",
3746 "host": "chromium-review.googlesource.com",
3747 "patchset": 7,
3748 "change": 123456,
3749 }],
3750 "properties": {
3751 "category": "git_cl_try",
3752 },
3753 "tags": [
3754 {"value": "linux", "key": "builder"},
3755 {"value": "git_cl_try", "key": "user_agent"},
3756 {"value": "1", "key": "retry_failed"},
3757 ],
3758 },
3759 }],
3760 }
3761 mockCallBuildbucket.assert_called_with(
3762 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3763
Edward Lemur4c707a22019-09-24 21:13:43 +00003764 def test_parse_bucket(self):
3765 test_cases = [
3766 {
3767 'bucket': 'chromium/try',
3768 'result': ('chromium', 'try'),
3769 },
3770 {
3771 'bucket': 'luci.chromium.try',
3772 'result': ('chromium', 'try'),
3773 'has_warning': True,
3774 },
3775 {
3776 'bucket': 'skia.primary',
3777 'result': ('skia', 'skia.primary'),
3778 'has_warning': True,
3779 },
3780 {
3781 'bucket': 'not-a-bucket',
3782 'result': (None, None),
3783 },
3784 ]
3785
3786 for test_case in test_cases:
3787 git_cl.sys.stdout.truncate(0)
3788 self.assertEqual(
3789 test_case['result'], git_cl._parse_bucket(test_case['bucket']))
3790 if test_case.get('has_warning'):
Edward Lemur6215c792019-10-03 21:59:05 +00003791 expected_warning = 'WARNING Please use %s/%s to specify the bucket' % (
3792 test_case['result'])
3793 self.assertIn(expected_warning, git_cl.sys.stdout.getvalue())
Edward Lemur4c707a22019-09-24 21:13:43 +00003794
3795
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003796class CMDUploadTestCase(CMDTestCaseBase):
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +00003797
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003798 def setUp(self):
3799 super(CMDUploadTestCase, self).setUp()
Quinten Yearsley777660f2020-03-04 23:37:06 +00003800 mock.patch('git_cl._fetch_tryjobs').start()
3801 mock.patch('git_cl._trigger_tryjobs', return_value={}).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003802 mock.patch('git_cl.Changelist.CMDUpload', return_value=0).start()
Edward Lesmes0dd54822020-03-26 18:24:25 +00003803 mock.patch('git_cl.Settings.GetRoot', return_value='').start()
3804 mock.patch(
3805 'git_cl.Settings.GetSquashGerritUploads',
3806 return_value=True).start()
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003807 self.addCleanup(mock.patch.stopall)
3808
Edward Lesmes7677e5c2020-02-19 20:39:03 +00003809 def testWarmUpChangeDetailCache(self):
3810 self.assertEqual(0, git_cl.main(['upload']))
3811 gerrit_util.GetChangeDetail.assert_called_once_with(
3812 'chromium-review.googlesource.com', 'depot_tools~123456',
3813 frozenset([
3814 'LABELS', 'CURRENT_REVISION', 'DETAILED_ACCOUNTS',
3815 'CURRENT_COMMIT']))
3816
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003817 def testUploadRetryFailed(self):
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003818 # This test mocks out the actual upload part, and just asserts that after
3819 # upload, if --retry-failed is added, then the tool will fetch try jobs
3820 # from the previous patchset and trigger the right builders on the latest
3821 # patchset.
Quinten Yearsley777660f2020-03-04 23:37:06 +00003822 git_cl._fetch_tryjobs.side_effect = [
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003823 # Latest patchset: No builds.
3824 [],
3825 # Patchset before latest: Some builds.
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003826 [{
3827 'id': str(100 + idx),
3828 'builder': {
3829 'project': 'chromium',
3830 'bucket': 'try',
3831 'builder': 'bot_' + status.lower(),
3832 },
3833 'createTime': '2019-10-09T08:00:0%d.854286Z' % (idx % 10),
3834 'tags': [],
3835 'status': status,
3836 } for idx, status in enumerate(self._STATUSES)],
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +00003837 ]
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003838
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003839 self.assertEqual(0, git_cl.main(['upload', '--retry-failed']))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003840 self.assertEqual([
Edward Lemur5b929a42019-10-21 17:57:39 +00003841 mock.call(mock.ANY, 'cr-buildbucket.appspot.com', patchset=7),
3842 mock.call(mock.ANY, 'cr-buildbucket.appspot.com', patchset=6),
Quinten Yearsley777660f2020-03-04 23:37:06 +00003843 ], git_cl._fetch_tryjobs.mock_calls)
Edward Lemur45768512020-03-02 19:03:14 +00003844 expected_buckets = [
3845 ('chromium', 'try', 'bot_failure'),
3846 ('chromium', 'try', 'bot_infra_failure'),
3847 ]
Quinten Yearsley777660f2020-03-04 23:37:06 +00003848 git_cl._trigger_tryjobs.assert_called_once_with(mock.ANY, expected_buckets,
3849 mock.ANY, 8)
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003850
Brian Sheedy59b06a82019-10-14 17:03:29 +00003851
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +00003852class MakeRequestsHelperTestCase(unittest.TestCase):
3853
3854 def exampleGerritChange(self):
3855 return {
3856 'host': 'chromium-review.googlesource.com',
3857 'project': 'depot_tools',
3858 'change': 1,
3859 'patchset': 2,
3860 }
3861
3862 def testMakeRequestsHelperNoOptions(self):
3863 # Basic test for the helper function _make_tryjob_schedule_requests;
3864 # it shouldn't throw AttributeError even when options doesn't have any
3865 # of the expected values; it will use default option values.
3866 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3867 jobs = [('chromium', 'try', 'my-builder')]
3868 options = optparse.Values()
3869 requests = git_cl._make_tryjob_schedule_requests(
3870 changelist, jobs, options, patchset=None)
3871
3872 # requestId is non-deterministic. Just assert that it's there and has
3873 # a particular length.
3874 self.assertEqual(len(requests[0]['scheduleBuild'].pop('requestId')), 36)
3875 self.assertEqual(requests, [{
3876 'scheduleBuild': {
3877 'builder': {
3878 'bucket': 'try',
3879 'builder': 'my-builder',
3880 'project': 'chromium'
3881 },
3882 'gerritChanges': [self.exampleGerritChange()],
3883 'properties': {
3884 'category': 'git_cl_try'
3885 },
3886 'tags': [{
3887 'key': 'builder',
3888 'value': 'my-builder'
3889 }, {
3890 'key': 'user_agent',
3891 'value': 'git_cl_try'
3892 }]
3893 }
3894 }])
3895
3896 def testMakeRequestsHelperPresubmitSetsDryRunProperty(self):
3897 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3898 jobs = [('chromium', 'try', 'presubmit')]
3899 options = optparse.Values()
3900 requests = git_cl._make_tryjob_schedule_requests(
3901 changelist, jobs, options, patchset=None)
3902 self.assertEqual(requests[0]['scheduleBuild']['properties'], {
3903 'category': 'git_cl_try',
3904 'dry_run': 'true'
3905 })
3906
3907 def testMakeRequestsHelperRevisionSet(self):
3908 # Gitiles commit is specified when revision is in options.
3909 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3910 jobs = [('chromium', 'try', 'my-builder')]
3911 options = optparse.Values({'revision': 'ba5eba11'})
3912 requests = git_cl._make_tryjob_schedule_requests(
3913 changelist, jobs, options, patchset=None)
3914 self.assertEqual(
3915 requests[0]['scheduleBuild']['gitilesCommit'], {
3916 'host': 'chromium-review.googlesource.com',
3917 'id': 'ba5eba11',
Josip Sokcevic9011a5b2021-02-12 18:59:44 +00003918 'project': 'depot_tools',
3919 'ref': 'refs/heads/main',
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +00003920 })
3921
3922 def testMakeRequestsHelperRetryFailedSet(self):
3923 # An extra tag is added when retry_failed is in options.
3924 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3925 jobs = [('chromium', 'try', 'my-builder')]
3926 options = optparse.Values({'retry_failed': 'true'})
3927 requests = git_cl._make_tryjob_schedule_requests(
3928 changelist, jobs, options, patchset=None)
3929 self.assertEqual(
3930 requests[0]['scheduleBuild']['tags'], [
3931 {
3932 'key': 'builder',
3933 'value': 'my-builder'
3934 },
3935 {
3936 'key': 'user_agent',
3937 'value': 'git_cl_try'
3938 },
3939 {
3940 'key': 'retry_failed',
3941 'value': '1'
3942 }
3943 ])
3944
3945 def testMakeRequestsHelperCategorySet(self):
Quinten Yearsley925cedb2020-04-13 17:49:39 +00003946 # The category property can be overridden with options.
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +00003947 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3948 jobs = [('chromium', 'try', 'my-builder')]
3949 options = optparse.Values({'category': 'my-special-category'})
3950 requests = git_cl._make_tryjob_schedule_requests(
3951 changelist, jobs, options, patchset=None)
3952 self.assertEqual(requests[0]['scheduleBuild']['properties'],
3953 {'category': 'my-special-category'})
3954
3955
Edward Lemurda4b6c62020-02-13 00:28:40 +00003956class CMDFormatTestCase(unittest.TestCase):
Brian Sheedy59b06a82019-10-14 17:03:29 +00003957
3958 def setUp(self):
3959 super(CMDFormatTestCase, self).setUp()
Jamie Madill5e96ad12020-01-13 16:08:35 +00003960 mock.patch('git_cl.RunCommand').start()
3961 mock.patch('clang_format.FindClangFormatToolInChromiumTree').start()
3962 mock.patch('clang_format.FindClangFormatScriptInChromiumTree').start()
3963 mock.patch('git_cl.settings').start()
Brian Sheedy59b06a82019-10-14 17:03:29 +00003964 self._top_dir = tempfile.mkdtemp()
Jamie Madill5e96ad12020-01-13 16:08:35 +00003965 self.addCleanup(mock.patch.stopall)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003966
3967 def tearDown(self):
3968 shutil.rmtree(self._top_dir)
3969 super(CMDFormatTestCase, self).tearDown()
3970
Jamie Madill5e96ad12020-01-13 16:08:35 +00003971 def _make_temp_file(self, fname, contents):
Anthony Politoc64e3902021-04-30 21:55:25 +00003972 gclient_utils.FileWrite(os.path.join(self._top_dir, fname),
3973 ('\n'.join(contents)))
Jamie Madill5e96ad12020-01-13 16:08:35 +00003974
Brian Sheedy59b06a82019-10-14 17:03:29 +00003975 def _make_yapfignore(self, contents):
Jamie Madill5e96ad12020-01-13 16:08:35 +00003976 self._make_temp_file('.yapfignore', contents)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003977
Brian Sheedyb4307d52019-12-02 19:18:17 +00003978 def _check_yapf_filtering(self, files, expected):
3979 self.assertEqual(expected, git_cl._FilterYapfIgnoredFiles(
3980 files, git_cl._GetYapfIgnorePatterns(self._top_dir)))
Brian Sheedy59b06a82019-10-14 17:03:29 +00003981
Edward Lemur1a83da12020-03-04 21:18:36 +00003982 def _run_command_mock(self, return_value):
3983 def f(*args, **kwargs):
3984 if 'stdin' in kwargs:
3985 self.assertIsInstance(kwargs['stdin'], bytes)
3986 return return_value
3987 return f
3988
Jamie Madill5e96ad12020-01-13 16:08:35 +00003989 def testClangFormatDiffFull(self):
3990 self._make_temp_file('test.cc', ['// test'])
3991 git_cl.settings.GetFormatFullByDefault.return_value = False
3992 diff_file = [os.path.join(self._top_dir, 'test.cc')]
3993 mock_opts = mock.Mock(full=True, dry_run=True, diff=False)
3994
3995 # Diff
Edward Lemur1a83da12020-03-04 21:18:36 +00003996 git_cl.RunCommand.side_effect = self._run_command_mock(' // test')
Jamie Madill5e96ad12020-01-13 16:08:35 +00003997 return_value = git_cl._RunClangFormatDiff(mock_opts, diff_file,
3998 self._top_dir, 'HEAD')
3999 self.assertEqual(2, return_value)
4000
4001 # No diff
Edward Lemur1a83da12020-03-04 21:18:36 +00004002 git_cl.RunCommand.side_effect = self._run_command_mock('// test')
Jamie Madill5e96ad12020-01-13 16:08:35 +00004003 return_value = git_cl._RunClangFormatDiff(mock_opts, diff_file,
4004 self._top_dir, 'HEAD')
4005 self.assertEqual(0, return_value)
4006
4007 def testClangFormatDiff(self):
4008 git_cl.settings.GetFormatFullByDefault.return_value = False
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00004009 # A valid file is required, so use this test.
4010 clang_format.FindClangFormatToolInChromiumTree.return_value = __file__
Jamie Madill5e96ad12020-01-13 16:08:35 +00004011 mock_opts = mock.Mock(full=False, dry_run=True, diff=False)
4012
4013 # Diff
Edward Lemur1a83da12020-03-04 21:18:36 +00004014 git_cl.RunCommand.side_effect = self._run_command_mock('error')
4015 return_value = git_cl._RunClangFormatDiff(
4016 mock_opts, ['.'], self._top_dir, 'HEAD')
Jamie Madill5e96ad12020-01-13 16:08:35 +00004017 self.assertEqual(2, return_value)
4018
4019 # No diff
Edward Lemur1a83da12020-03-04 21:18:36 +00004020 git_cl.RunCommand.side_effect = self._run_command_mock('')
Jamie Madill5e96ad12020-01-13 16:08:35 +00004021 return_value = git_cl._RunClangFormatDiff(mock_opts, ['.'], self._top_dir,
4022 'HEAD')
4023 self.assertEqual(0, return_value)
4024
Brian Sheedyb4307d52019-12-02 19:18:17 +00004025 def testYapfignoreExplicit(self):
4026 self._make_yapfignore(['foo/bar.py', 'foo/bar/baz.py'])
4027 files = [
4028 'bar.py',
4029 'foo/bar.py',
4030 'foo/baz.py',
4031 'foo/bar/baz.py',
4032 'foo/bar/foobar.py',
4033 ]
4034 expected = [
4035 'bar.py',
4036 'foo/baz.py',
4037 'foo/bar/foobar.py',
4038 ]
4039 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00004040
Brian Sheedyb4307d52019-12-02 19:18:17 +00004041 def testYapfignoreSingleWildcards(self):
4042 self._make_yapfignore(['*bar.py', 'foo*', 'baz*.py'])
4043 files = [
4044 'bar.py', # Matched by *bar.py.
4045 'bar.txt',
4046 'foobar.py', # Matched by *bar.py, foo*.
4047 'foobar.txt', # Matched by foo*.
4048 'bazbar.py', # Matched by *bar.py, baz*.py.
4049 'bazbar.txt',
4050 'foo/baz.txt', # Matched by foo*.
4051 'bar/bar.py', # Matched by *bar.py.
4052 'baz/foo.py', # Matched by baz*.py, foo*.
4053 'baz/foo.txt',
4054 ]
4055 expected = [
4056 'bar.txt',
4057 'bazbar.txt',
4058 'baz/foo.txt',
4059 ]
4060 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00004061
Brian Sheedyb4307d52019-12-02 19:18:17 +00004062 def testYapfignoreMultiplewildcards(self):
4063 self._make_yapfignore(['*bar*', '*foo*baz.txt'])
4064 files = [
4065 'bar.py', # Matched by *bar*.
4066 'bar.txt', # Matched by *bar*.
4067 'abar.py', # Matched by *bar*.
4068 'foobaz.txt', # Matched by *foo*baz.txt.
4069 'foobaz.py',
4070 'afoobaz.txt', # Matched by *foo*baz.txt.
4071 ]
4072 expected = [
4073 'foobaz.py',
4074 ]
4075 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00004076
4077 def testYapfignoreComments(self):
4078 self._make_yapfignore(['test.py', '#test2.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00004079 files = [
4080 'test.py',
4081 'test2.py',
4082 ]
4083 expected = [
4084 'test2.py',
4085 ]
4086 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00004087
Anthony Politoc64e3902021-04-30 21:55:25 +00004088 def testYapfHandleUtf8(self):
4089 self._make_yapfignore(['test.py', 'test_🌐.py'])
4090 files = [
4091 'test.py',
4092 'test_🌐.py',
4093 'test2.py',
4094 ]
4095 expected = [
4096 'test2.py',
4097 ]
4098 self._check_yapf_filtering(files, expected)
4099
Brian Sheedy59b06a82019-10-14 17:03:29 +00004100 def testYapfignoreBlankLines(self):
4101 self._make_yapfignore(['test.py', '', '', 'test2.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00004102 files = [
4103 'test.py',
4104 'test2.py',
4105 'test3.py',
4106 ]
4107 expected = [
4108 'test3.py',
4109 ]
4110 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00004111
4112 def testYapfignoreWhitespace(self):
4113 self._make_yapfignore([' test.py '])
Brian Sheedyb4307d52019-12-02 19:18:17 +00004114 files = [
4115 'test.py',
4116 'test2.py',
4117 ]
4118 expected = [
4119 'test2.py',
4120 ]
4121 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00004122
Brian Sheedyb4307d52019-12-02 19:18:17 +00004123 def testYapfignoreNoFiles(self):
Brian Sheedy59b06a82019-10-14 17:03:29 +00004124 self._make_yapfignore(['test.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00004125 self._check_yapf_filtering([], [])
4126
4127 def testYapfignoreMissingYapfignore(self):
4128 files = [
4129 'test.py',
4130 ]
4131 expected = [
4132 'test.py',
4133 ]
4134 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00004135
4136
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00004137class CMDStatusTestCase(CMDTestCaseBase):
4138 # Return branch names a,..,f with comitterdates in increasing order, i.e.
4139 # 'f' is the most-recently changed branch.
4140 def _mock_run_git(commands):
4141 if commands == [
4142 'for-each-ref', '--format=%(refname) %(committerdate:unix)',
4143 'refs/heads'
4144 ]:
4145 branches_and_committerdates = [
4146 'refs/heads/a 1',
4147 'refs/heads/b 2',
4148 'refs/heads/c 3',
4149 'refs/heads/d 4',
4150 'refs/heads/e 5',
4151 'refs/heads/f 6',
4152 ]
4153 return '\n'.join(branches_and_committerdates)
4154
4155 # Mock the status in such a way that the issue number gives us an
4156 # indication of the commit date (simplifies manual debugging).
4157 def _mock_get_cl_statuses(branches, fine_grained, max_processes):
4158 for c in branches:
4159 c.issue = (100 + int(c.GetCommitDate()))
4160 yield (c, 'open')
4161
4162 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
4163 @mock.patch('git_cl.Changelist.FetchDescription', lambda cl, pretty: 'x')
4164 @mock.patch('git_cl.Changelist.GetIssue', lambda cl: cl.issue)
4165 @mock.patch('git_cl.RunGit', _mock_run_git)
4166 @mock.patch('git_cl.get_cl_statuses', _mock_get_cl_statuses)
4167 @mock.patch('git_cl.Settings.GetRoot', return_value='')
Sigurd Schneider1bfda8e2021-06-30 14:46:25 +00004168 @mock.patch('git_cl.Settings.IsStatusCommitOrderByDate', return_value=False)
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00004169 @mock.patch('scm.GIT.GetBranch', return_value='a')
4170 def testStatus(self, *_mocks):
4171 self.assertEqual(0, git_cl.main(['status', '--no-branch-color']))
4172 self.maxDiff = None
4173 self.assertEqual(
4174 sys.stdout.getvalue(), 'Branches associated with reviews:\n'
4175 ' * a : https://crrev.com/c/101 (open)\n'
4176 ' b : https://crrev.com/c/102 (open)\n'
4177 ' c : https://crrev.com/c/103 (open)\n'
4178 ' d : https://crrev.com/c/104 (open)\n'
4179 ' e : https://crrev.com/c/105 (open)\n'
4180 ' f : https://crrev.com/c/106 (open)\n\n'
4181 'Current branch: a\n'
4182 'Issue number: 101 (https://chromium-review.googlesource.com/101)\n'
4183 'Issue description:\n'
4184 'x\n')
4185
4186 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
4187 @mock.patch('git_cl.Changelist.FetchDescription', lambda cl, pretty: 'x')
4188 @mock.patch('git_cl.Changelist.GetIssue', lambda cl: cl.issue)
4189 @mock.patch('git_cl.RunGit', _mock_run_git)
4190 @mock.patch('git_cl.get_cl_statuses', _mock_get_cl_statuses)
4191 @mock.patch('git_cl.Settings.GetRoot', return_value='')
Sigurd Schneider1bfda8e2021-06-30 14:46:25 +00004192 @mock.patch('git_cl.Settings.IsStatusCommitOrderByDate', return_value=False)
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00004193 @mock.patch('scm.GIT.GetBranch', return_value='a')
4194 def testStatusByDate(self, *_mocks):
4195 self.assertEqual(
4196 0, git_cl.main(['status', '--no-branch-color', '--date-order']))
4197 self.maxDiff = None
4198 self.assertEqual(
4199 sys.stdout.getvalue(), 'Branches associated with reviews:\n'
4200 ' f : https://crrev.com/c/106 (open)\n'
4201 ' e : https://crrev.com/c/105 (open)\n'
4202 ' d : https://crrev.com/c/104 (open)\n'
4203 ' c : https://crrev.com/c/103 (open)\n'
4204 ' b : https://crrev.com/c/102 (open)\n'
4205 ' * a : https://crrev.com/c/101 (open)\n\n'
4206 'Current branch: a\n'
4207 'Issue number: 101 (https://chromium-review.googlesource.com/101)\n'
4208 'Issue description:\n'
4209 'x\n')
4210
Sigurd Schneider1bfda8e2021-06-30 14:46:25 +00004211 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
4212 @mock.patch('git_cl.Changelist.FetchDescription', lambda cl, pretty: 'x')
4213 @mock.patch('git_cl.Changelist.GetIssue', lambda cl: cl.issue)
4214 @mock.patch('git_cl.RunGit', _mock_run_git)
4215 @mock.patch('git_cl.get_cl_statuses', _mock_get_cl_statuses)
4216 @mock.patch('git_cl.Settings.GetRoot', return_value='')
4217 @mock.patch('git_cl.Settings.IsStatusCommitOrderByDate', return_value=True)
4218 @mock.patch('scm.GIT.GetBranch', return_value='a')
4219 def testStatusByDate(self, *_mocks):
4220 self.assertEqual(
4221 0, git_cl.main(['status', '--no-branch-color']))
4222 self.maxDiff = None
4223 self.assertEqual(
4224 sys.stdout.getvalue(), 'Branches associated with reviews:\n'
4225 ' f : https://crrev.com/c/106 (open)\n'
4226 ' e : https://crrev.com/c/105 (open)\n'
4227 ' d : https://crrev.com/c/104 (open)\n'
4228 ' c : https://crrev.com/c/103 (open)\n'
4229 ' b : https://crrev.com/c/102 (open)\n'
4230 ' * a : https://crrev.com/c/101 (open)\n\n'
4231 'Current branch: a\n'
4232 'Issue number: 101 (https://chromium-review.googlesource.com/101)\n'
4233 'Issue description:\n'
4234 'x\n')
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00004235
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004236class CMDOwnersTestCase(CMDTestCaseBase):
4237 def setUp(self):
4238 super(CMDOwnersTestCase, self).setUp()
Edward Lesmes82b992a2021-01-11 23:24:55 +00004239 self.owners_by_path = {
4240 'foo': ['a@example.com'],
4241 'bar': ['b@example.com', 'c@example.com'],
4242 }
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004243 mock.patch('git_cl.Settings.GetRoot', return_value='root').start()
4244 mock.patch('git_cl.Changelist.GetAuthor', return_value='author').start()
4245 mock.patch(
Edward Lesmes82b992a2021-01-11 23:24:55 +00004246 'git_cl.Changelist.GetAffectedFiles',
4247 return_value=list(self.owners_by_path)).start()
4248 mock.patch(
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004249 'git_cl.Changelist.GetCommonAncestorWithUpstream',
4250 return_value='upstream').start()
Edward Lesmes82b992a2021-01-11 23:24:55 +00004251 mock.patch(
Edward Lesmese1576912021-02-16 21:53:34 +00004252 'git_cl.Changelist.GetGerritHost',
4253 return_value='host').start()
4254 mock.patch(
4255 'git_cl.Changelist.GetGerritProject',
4256 return_value='project').start()
4257 mock.patch(
4258 'git_cl.Changelist.GetRemoteBranch',
4259 return_value=('origin', 'refs/remotes/origin/main')).start()
4260 mock.patch(
4261 'owners_client.OwnersClient.BatchListOwners',
Edward Lesmes82b992a2021-01-11 23:24:55 +00004262 return_value=self.owners_by_path).start()
Edward Lesmes8170c292021-03-19 20:04:43 +00004263 mock.patch(
4264 'gerrit_util.IsCodeOwnersEnabledOnHost', return_value=True).start()
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004265 self.addCleanup(mock.patch.stopall)
4266
4267 def testShowAllNoArgs(self):
4268 self.assertEqual(0, git_cl.main(['owners', '--show-all']))
4269 self.assertEqual(
4270 'No files specified for --show-all. Nothing to do.\n',
4271 git_cl.sys.stdout.getvalue())
4272
4273 def testShowAll(self):
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004274 self.assertEqual(
4275 0,
4276 git_cl.main(['owners', '--show-all', 'foo', 'bar', 'baz']))
Edward Lesmese1576912021-02-16 21:53:34 +00004277 owners_client.OwnersClient.BatchListOwners.assert_called_once_with(
Edward Lesmes82b992a2021-01-11 23:24:55 +00004278 ['foo', 'bar', 'baz'])
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004279 self.assertEqual(
4280 '\n'.join([
4281 'Owners for foo:',
4282 ' - a@example.com',
4283 'Owners for bar:',
4284 ' - b@example.com',
4285 ' - c@example.com',
4286 'Owners for baz:',
4287 ' - No owners found',
4288 '',
4289 ]),
4290 sys.stdout.getvalue())
4291
Edward Lesmes82b992a2021-01-11 23:24:55 +00004292 def testBatch(self):
4293 self.assertEqual(0, git_cl.main(['owners', '--batch']))
4294 self.assertIn('a@example.com', sys.stdout.getvalue())
4295 self.assertIn('b@example.com', sys.stdout.getvalue())
4296
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004297
maruel@chromium.orgddd59412011-11-30 14:20:38 +00004298if __name__ == '__main__':
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +01004299 logging.basicConfig(
4300 level=logging.DEBUG if '-v' in sys.argv else logging.ERROR)
maruel@chromium.orgddd59412011-11-30 14:20:38 +00004301 unittest.main()