blob: 7741591bd0884d8bc1b726732cc89cb76fd1cea6 [file] [log] [blame]
Edward Lemur0db01f02019-11-12 22:01:51 +00001#!/usr/bin/env vpython3
2# coding=utf-8
maruel@chromium.orgeb5edbc2012-01-16 17:03:28 +00003# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@chromium.orgddd59412011-11-30 14:20:38 +00004# Use of this source code is governed by a BSD-style license that can be
5# found in the LICENSE file.
6
7"""Unit tests for git_cl.py."""
8
Edward Lemur85153282020-02-14 22:06:29 +00009from __future__ import print_function
Edward Lemur0db01f02019-11-12 22:01:51 +000010from __future__ import unicode_literals
11
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +010012import datetime
tandriide281ae2016-10-12 06:02:30 -070013import json
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +010014import logging
Edward Lemur61bf4172020-02-24 23:22:37 +000015import multiprocessing
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000016import optparse
maruel@chromium.orgddd59412011-11-30 14:20:38 +000017import os
Edward Lemur85153282020-02-14 22:06:29 +000018import pprint
Brian Sheedy59b06a82019-10-14 17:03:29 +000019import shutil
maruel@chromium.orgddd59412011-11-30 14:20:38 +000020import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070021import tempfile
maruel@chromium.orgddd59412011-11-30 14:20:38 +000022import unittest
23
Edward Lemura8145022020-01-06 18:47:54 +000024if sys.version_info.major == 2:
25 from StringIO import StringIO
26 import mock
27else:
28 from io import StringIO
29 from unittest import mock
30
maruel@chromium.orgddd59412011-11-30 14:20:38 +000031sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
32
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000033import metrics
Edward Lesmes9c349062021-05-06 20:02:39 +000034import metrics_utils
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000035# We have to disable monitoring before importing git_cl.
Edward Lesmes9c349062021-05-06 20:02:39 +000036metrics_utils.COLLECT_METRICS = False
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000037
Jamie Madill5e96ad12020-01-13 16:08:35 +000038import clang_format
Edward Lemur227d5102020-02-25 23:45:35 +000039import contextlib
Edward Lemur1773f372020-02-22 00:27:14 +000040import gclient_utils
Eric Boren2fb63102018-10-05 13:05:03 +000041import gerrit_util
maruel@chromium.orgddd59412011-11-30 14:20:38 +000042import git_cl
iannucci@chromium.org9e849272014-04-04 00:31:55 +000043import git_common
tandrii@chromium.org57d86542016-03-04 16:11:32 +000044import git_footers
Edward Lemur85153282020-02-14 22:06:29 +000045import git_new_branch
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +000046import owners_client
Edward Lemur85153282020-02-14 22:06:29 +000047import scm
maruel@chromium.orgddd59412011-11-30 14:20:38 +000048import subprocess2
maruel@chromium.orgddd59412011-11-30 14:20:38 +000049
Josip Sokcevic464e9ff2020-03-18 23:48:55 +000050NETRC_FILENAME = '_netrc' if sys.platform == 'win32' else '.netrc'
51
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000052
Edward Lemur0db01f02019-11-12 22:01:51 +000053def callError(code=1, cmd='', cwd='', stdout=b'', stderr=b''):
tandrii5d48c322016-08-18 16:19:37 -070054 return subprocess2.CalledProcessError(code, cmd, cwd, stdout, stderr)
55
tandrii5d48c322016-08-18 16:19:37 -070056CERR1 = callError(1)
57
58
Edward Lemur1773f372020-02-22 00:27:14 +000059class TemporaryFileMock(object):
60 def __init__(self):
61 self.suffix = 0
Aaron Gable9a03ae02017-11-03 11:31:07 -070062
Edward Lemur1773f372020-02-22 00:27:14 +000063 @contextlib.contextmanager
64 def __call__(self):
65 self.suffix += 1
66 yield '/tmp/fake-temp' + str(self.suffix)
Aaron Gable9a03ae02017-11-03 11:31:07 -070067
68
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000069class ChangelistMock(object):
70 # A class variable so we can access it when we don't have access to the
71 # instance that's being set.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000072 desc = ''
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000073
Dirk Pranke6f0df682021-06-25 00:42:33 +000074 def __init__(self, gerrit_change=None, use_python3=False, **kwargs):
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000075 self._gerrit_change = gerrit_change
Dirk Pranke6f0df682021-06-25 00:42:33 +000076 self._use_python3 = use_python3
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000077
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000078 def GetIssue(self):
79 return 1
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000080
Edward Lemur6c6827c2020-02-06 21:15:18 +000081 def FetchDescription(self):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000082 return ChangelistMock.desc
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000083
dsansomee2d6fd92016-09-08 00:10:47 -070084 def UpdateDescription(self, desc, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000085 ChangelistMock.desc = desc
86
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +000087 def GetGerritChange(self, patchset=None, **kwargs):
88 del patchset
89 return self._gerrit_change
90
Josip Sokcevic9011a5b2021-02-12 18:59:44 +000091 def GetRemoteBranch(self):
92 return ('origin', 'refs/remotes/origin/main')
93
Dirk Pranke6f0df682021-06-25 00:42:33 +000094 def GetUsePython3(self):
95 return self._use_python3
tandrii5d48c322016-08-18 16:19:37 -070096
Edward Lemur85153282020-02-14 22:06:29 +000097class GitMocks(object):
98 def __init__(self, config=None, branchref=None):
99 self.branchref = branchref or 'refs/heads/master'
100 self.config = config or {}
101
102 def GetBranchRef(self, _root):
103 return self.branchref
104
105 def NewBranch(self, branchref):
106 self.branchref = branchref
107
Edward Lemur26964072020-02-19 19:18:51 +0000108 def GetConfig(self, root, key, default=None):
109 if root != '':
110 key = '%s:%s' % (root, key)
Edward Lemur85153282020-02-14 22:06:29 +0000111 return self.config.get(key, default)
112
Edward Lemur26964072020-02-19 19:18:51 +0000113 def SetConfig(self, root, key, value=None):
114 if root != '':
115 key = '%s:%s' % (root, key)
Edward Lemur85153282020-02-14 22:06:29 +0000116 if value:
117 self.config[key] = value
118 return
119 if key not in self.config:
120 raise CERR1
121 del self.config[key]
122
123
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000124class WatchlistsMock(object):
125 def __init__(self, _):
126 pass
127 @staticmethod
128 def GetWatchersForPaths(_):
129 return ['joe@example.com']
130
131
Edward Lemur4c707a22019-09-24 21:13:43 +0000132class CodereviewSettingsFileMock(object):
133 def __init__(self):
134 pass
135 # pylint: disable=no-self-use
136 def read(self):
137 return ('CODE_REVIEW_SERVER: gerrit.chromium.org\n' +
138 'GERRIT_HOST: True\n')
139
140
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000141class AuthenticatorMock(object):
142 def __init__(self, *_args):
143 pass
144 def has_cached_credentials(self):
145 return True
tandrii221ab252016-10-06 08:12:04 -0700146 def authorize(self, http):
147 return http
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000148
149
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100150def CookiesAuthenticatorMockFactory(hosts_with_creds=None, same_auth=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000151 """Use to mock Gerrit/Git credentials from ~/.netrc or ~/.gitcookies.
152
153 Usage:
154 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100155 CookiesAuthenticatorMockFactory({'host': ('user', _, 'pass')})
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000156
157 OR
158 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100159 CookiesAuthenticatorMockFactory(
160 same_auth=('user', '', 'pass'))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000161 """
162 class CookiesAuthenticatorMock(git_cl.gerrit_util.CookiesAuthenticator):
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800163 def __init__(self): # pylint: disable=super-init-not-called
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000164 # Intentionally not calling super() because it reads actual cookie files.
165 pass
166 @classmethod
167 def get_gitcookies_path(cls):
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000168 return os.path.join('~', '.gitcookies')
169
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000170 @classmethod
171 def get_netrc_path(cls):
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000172 return os.path.join('~', NETRC_FILENAME)
173
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100174 def _get_auth_for_host(self, host):
175 if same_auth:
176 return same_auth
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000177 return (hosts_with_creds or {}).get(host)
178 return CookiesAuthenticatorMock
179
Aaron Gable9a03ae02017-11-03 11:31:07 -0700180
kmarshall9249e012016-08-23 12:02:16 -0700181class MockChangelistWithBranchAndIssue():
182 def __init__(self, branch, issue):
183 self.branch = branch
184 self.issue = issue
185 def GetBranch(self):
186 return self.branch
187 def GetIssue(self):
188 return self.issue
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000189
tandriic2405f52016-10-10 08:13:15 -0700190
191class SystemExitMock(Exception):
192 pass
193
194
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000195class TestGitClBasic(unittest.TestCase):
Josip Sokcevic953278a2020-02-28 19:46:36 +0000196 def setUp(self):
197 mock.patch('sys.exit', side_effect=SystemExitMock).start()
198 mock.patch('sys.stdout', StringIO()).start()
199 mock.patch('sys.stderr', StringIO()).start()
200 self.addCleanup(mock.patch.stopall)
201
202 def test_die_with_error(self):
203 with self.assertRaises(SystemExitMock):
204 git_cl.DieWithError('foo', git_cl.ChangeDescription('lorem ipsum'))
205 self.assertEqual(sys.stderr.getvalue(), 'foo\n')
206 self.assertTrue('saving CL description' in sys.stdout.getvalue())
207 self.assertTrue('Content of CL description' in sys.stdout.getvalue())
208 self.assertTrue('lorem ipsum' in sys.stdout.getvalue())
209 sys.exit.assert_called_once_with(1)
210
211 def test_die_with_error_no_desc(self):
212 with self.assertRaises(SystemExitMock):
213 git_cl.DieWithError('foo')
214 self.assertEqual(sys.stderr.getvalue(), 'foo\n')
215 self.assertEqual(sys.stdout.getvalue(), '')
216 sys.exit.assert_called_once_with(1)
217
Edward Lemur6c6827c2020-02-06 21:15:18 +0000218 def test_fetch_description(self):
Edward Lemurf38bc172019-09-03 21:02:13 +0000219 cl = git_cl.Changelist(issue=1, codereview_host='host')
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100220 cl.description = 'x'
Edward Lemur6c6827c2020-02-06 21:15:18 +0000221 self.assertEqual(cl.FetchDescription(), 'x')
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700222
Edward Lemur61bf4172020-02-24 23:22:37 +0000223 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
224 @mock.patch('git_cl.Changelist.GetStatus', lambda cl: cl.status)
225 def test_get_cl_statuses(self, *_mocks):
226 statuses = [
227 'closed', 'commit', 'dry-run', 'lgtm', 'reply', 'unsent', 'waiting']
228 changes = []
229 for status in statuses:
230 cl = git_cl.Changelist()
231 cl.status = status
232 changes.append(cl)
233
234 actual = set(git_cl.get_cl_statuses(changes, True))
235 self.assertEqual(set(zip(changes, statuses)), actual)
236
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000237 def test_upload_to_non_default_branch_no_retry(self):
238 m = mock.patch('git_cl.Changelist._CMDUploadChange',
239 side_effect=[git_cl.GitPushError(), None]).start()
240 mock.patch('git_cl.Changelist.GetRemoteBranch',
241 return_value=('foo', 'bar')).start()
Edward Lesmeseeca9c62020-11-20 00:00:17 +0000242 mock.patch('git_cl.Changelist.GetGerritProject',
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000243 return_value='foo').start()
244 mock.patch('git_cl.gerrit_util.GetProjectHead',
245 return_value='refs/heads/main').start()
246
247 cl = git_cl.Changelist()
248 options = optparse.Values()
Josip Sokcevicb631a882021-01-06 18:18:10 +0000249 options.target_branch = 'refs/heads/bar'
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000250 with self.assertRaises(SystemExitMock):
251 cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
252
253 # ensure upload is called once
254 self.assertEqual(len(m.mock_calls), 1)
255 sys.exit.assert_called_once_with(1)
256 # option not set as retry didn't happen
257 self.assertFalse(hasattr(options, 'force'))
258 self.assertFalse(hasattr(options, 'edit_description'))
259
260 def test_upload_to_old_default_still_active(self):
261 m = mock.patch('git_cl.Changelist._CMDUploadChange',
262 side_effect=[git_cl.GitPushError(), None]).start()
263 mock.patch('git_cl.Changelist.GetRemoteBranch',
264 return_value=('foo', git_cl.DEFAULT_OLD_BRANCH)).start()
Edward Lesmeseeca9c62020-11-20 00:00:17 +0000265 mock.patch('git_cl.Changelist.GetGerritProject',
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000266 return_value='foo').start()
267 mock.patch('git_cl.gerrit_util.GetProjectHead',
Josip Sokcevicb631a882021-01-06 18:18:10 +0000268 return_value='refs/heads/master').start()
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000269
270 cl = git_cl.Changelist()
271 options = optparse.Values()
Josip Sokcevicb631a882021-01-06 18:18:10 +0000272 options.target_branch = 'refs/heads/master'
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000273 with self.assertRaises(SystemExitMock):
274 cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
275
276 # ensure upload is called once
277 self.assertEqual(len(m.mock_calls), 1)
278 sys.exit.assert_called_once_with(1)
279 # option not set as retry didn't happen
280 self.assertFalse(hasattr(options, 'force'))
281 self.assertFalse(hasattr(options, 'edit_description'))
282
283 def test_upload_to_old_default_retry_on_failure(self):
284 m = mock.patch('git_cl.Changelist._CMDUploadChange',
285 side_effect=[git_cl.GitPushError(), None]).start()
286 mock.patch('git_cl.Changelist.GetRemoteBranch',
287 return_value=('foo', git_cl.DEFAULT_OLD_BRANCH)).start()
Edward Lesmeseeca9c62020-11-20 00:00:17 +0000288 mock.patch('git_cl.Changelist.GetGerritProject',
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000289 return_value='foo').start()
290 mock.patch('git_cl.gerrit_util.GetProjectHead',
291 return_value='refs/heads/main').start()
292 mock.patch('git_cl.RunGit').start()
293
294 cl = git_cl.Changelist()
295 options = optparse.Values()
Josip Sokcevicb631a882021-01-06 18:18:10 +0000296 options.target_branch = 'refs/heads/master'
297 cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
298 # ensure upload is called twice
299 self.assertEqual(len(m.mock_calls), 2)
300 # option overrides on retry
301 self.assertEqual(options.force, True)
302 self.assertEqual(options.edit_description, False)
303
Gavin Mak68e6cf32021-01-25 18:24:08 +0000304 def test_upload_with_message_file_no_editor(self):
305 m = mock.patch('git_cl.ChangeDescription.prompt',
306 return_value=None).start()
307 mock.patch('git_cl.Changelist.GetRemoteBranch',
308 return_value=('foo', git_cl.DEFAULT_NEW_BRANCH)).start()
309 mock.patch('git_cl.GetTargetRef',
310 return_value='refs/heads/main').start()
311 mock.patch('git_cl.Changelist._GerritCommitMsgHookCheck',
312 lambda _, offer_removal: None).start()
313 mock.patch('git_cl.Changelist.GetIssue', return_value=None).start()
314 mock.patch('git_cl.Changelist.GetBranch',
315 side_effect=SystemExitMock).start()
316 mock.patch('git_cl.GenerateGerritChangeId', return_value=None).start()
317 mock.patch('git_cl.RunGit').start()
318
319 cl = git_cl.Changelist()
320 options = optparse.Values()
321 options.target_branch = 'refs/heads/master'
322 options.squash = True
323 options.edit_description = False
324 options.force = False
325 options.preserve_tryjobs = False
326 options.message_file = "message.txt"
327
328 with self.assertRaises(SystemExitMock):
329 cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
330 self.assertEqual(len(m.mock_calls), 0)
331
332 options.message_file = None
333 with self.assertRaises(SystemExitMock):
334 cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
335 self.assertEqual(len(m.mock_calls), 1)
336
Josip Sokcevicb631a882021-01-06 18:18:10 +0000337 def test_upload_to_old_default_retry_on_rollback(self):
338 """Test when default branch migration had to be rolled back to old name"""
339 m = mock.patch('git_cl.Changelist._CMDUploadChange',
340 side_effect=[git_cl.GitPushError(), None]).start()
341 mock.patch('git_cl.Changelist.GetRemoteBranch',
342 return_value=('foo', git_cl.DEFAULT_NEW_BRANCH)).start()
343 mock.patch('git_cl.Changelist.GetGerritProject',
344 return_value='foo').start()
345 mock.patch('git_cl.gerrit_util.GetProjectHead',
346 return_value='refs/heads/master').start()
347 # GetTargetRef returns new default branch since it has stale remote
348 # information.
349 mock.patch('git_cl.GetTargetRef',
350 return_value='refs/heads/main').start()
351 mock.patch('git_cl.RunGit').start()
352
353 cl = git_cl.Changelist()
354 options = optparse.Values()
355 options.target_branch = 'refs/heads/master'
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000356 cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
357 # ensure upload is called twice
358 self.assertEqual(len(m.mock_calls), 2)
359 # option overrides on retry
360 self.assertEqual(options.force, True)
361 self.assertEqual(options.edit_description, False)
362
Edward Lemur61bf4172020-02-24 23:22:37 +0000363 def test_get_cl_statuses_no_changes(self):
364 self.assertEqual([], list(git_cl.get_cl_statuses([], True)))
365
366 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
367 @mock.patch('multiprocessing.pool.ThreadPool')
368 def test_get_cl_statuses_timeout(self, *_mocks):
369 changes = [git_cl.Changelist() for _ in range(2)]
370 pool = multiprocessing.pool.ThreadPool()
371 it = pool.imap_unordered.return_value.__iter__ = mock.Mock()
372 it.return_value.next.side_effect = [
373 (changes[0], 'lgtm'),
374 multiprocessing.TimeoutError,
375 ]
376
377 actual = list(git_cl.get_cl_statuses(changes, True))
378 self.assertEqual([(changes[0], 'lgtm'), (changes[1], 'error')], actual)
379
380 @mock.patch('git_cl.Changelist.GetIssueURL')
381 def test_get_cl_statuses_not_finegrained(self, _mock):
382 changes = [git_cl.Changelist() for _ in range(2)]
383 urls = ['some-url', None]
384 git_cl.Changelist.GetIssueURL.side_effect = urls
385
386 actual = set(git_cl.get_cl_statuses(changes, False))
387 self.assertEqual(
388 set([(changes[0], 'waiting'), (changes[1], 'error')]), actual)
389
Andrii Shyshkalov1ee78cd2020-03-12 01:31:53 +0000390 def test_get_issue_url(self):
391 cl = git_cl.Changelist(issue=123)
392 cl._gerrit_server = 'https://example.com'
393 self.assertEqual(cl.GetIssueURL(), 'https://example.com/123')
394 self.assertEqual(cl.GetIssueURL(short=True), 'https://example.com/123')
395
396 cl = git_cl.Changelist(issue=123)
397 cl._gerrit_server = 'https://chromium-review.googlesource.com'
398 self.assertEqual(cl.GetIssueURL(),
399 'https://chromium-review.googlesource.com/123')
400 self.assertEqual(cl.GetIssueURL(short=True), 'https://crrev.com/c/123')
401
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +0000402 def test_set_preserve_tryjobs(self):
403 d = git_cl.ChangeDescription('Simple.')
404 d.set_preserve_tryjobs()
405 self.assertEqual(d.description.splitlines(), [
406 'Simple.',
407 '',
408 'Cq-Do-Not-Cancel-Tryjobs: true',
409 ])
410 before = d.description
411 d.set_preserve_tryjobs()
412 self.assertEqual(before, d.description)
413
414 d = git_cl.ChangeDescription('\n'.join([
415 'One is enough',
416 '',
417 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
418 'Change-Id: Ideadbeef',
419 ]))
420 d.set_preserve_tryjobs()
421 self.assertEqual(d.description.splitlines(), [
422 'One is enough',
423 '',
424 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
425 'Change-Id: Ideadbeef',
426 'Cq-Do-Not-Cancel-Tryjobs: true',
427 ])
428
tandriif9aefb72016-07-01 09:06:51 -0700429 def test_get_bug_line_values(self):
430 f = lambda p, bugs: list(git_cl._get_bug_line_values(p, bugs))
431 self.assertEqual(f('', ''), [])
432 self.assertEqual(f('', '123,v8:456'), ['123', 'v8:456'])
Lei Zhang8a0efc12020-08-05 19:58:45 +0000433 # Prefix that ends with colon.
434 self.assertEqual(f('v8:', '456'), ['v8:456'])
435 self.assertEqual(f('v8:', 'chromium:123,456'), ['v8:456', 'chromium:123'])
436 # Prefix that ends without colon.
tandriif9aefb72016-07-01 09:06:51 -0700437 self.assertEqual(f('v8', '456'), ['v8:456'])
438 self.assertEqual(f('v8', 'chromium:123,456'), ['v8:456', 'chromium:123'])
439 # Not nice, but not worth carying.
Lei Zhang8a0efc12020-08-05 19:58:45 +0000440 self.assertEqual(f('v8:', 'chromium:123,456,v8:123'),
441 ['v8:456', 'chromium:123', 'v8:123'])
tandriif9aefb72016-07-01 09:06:51 -0700442 self.assertEqual(f('v8', 'chromium:123,456,v8:123'),
443 ['v8:456', 'chromium:123', 'v8:123'])
444
Edward Lemurda4b6c62020-02-13 00:28:40 +0000445 @mock.patch('gerrit_util.GetAccountDetails')
446 def test_valid_accounts(self, mockGetAccountDetails):
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000447 mock_per_account = {
448 'u1': None, # 404, doesn't exist.
449 'u2': {
450 '_account_id': 123124,
451 'avatars': [],
452 'email': 'u2@example.com',
453 'name': 'User Number 2',
454 'status': 'OOO',
455 },
456 'u3': git_cl.gerrit_util.GerritError(500, 'retries didn\'t help :('),
457 }
458 def GetAccountDetailsMock(_, account):
459 # Poor-man's mock library's side_effect.
460 v = mock_per_account.pop(account)
461 if isinstance(v, Exception):
462 raise v
463 return v
464
Edward Lemurda4b6c62020-02-13 00:28:40 +0000465 mockGetAccountDetails.side_effect = GetAccountDetailsMock
466 actual = git_cl.gerrit_util.ValidAccounts(
467 'host', ['u1', 'u2', 'u3'], max_threads=1)
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000468 self.assertEqual(actual, {
469 'u2': {
470 '_account_id': 123124,
471 'avatars': [],
472 'email': 'u2@example.com',
473 'name': 'User Number 2',
474 'status': 'OOO',
475 },
476 })
477
478
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200479class TestParseIssueURL(unittest.TestCase):
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000480 def _test(self, arg, issue=None, patchset=None, hostname=None, fail=False):
481 parsed = git_cl.ParseIssueNumberArgument(arg)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200482 self.assertIsNotNone(parsed)
483 if fail:
484 self.assertFalse(parsed.valid)
485 return
486 self.assertTrue(parsed.valid)
487 self.assertEqual(parsed.issue, issue)
488 self.assertEqual(parsed.patchset, patchset)
489 self.assertEqual(parsed.hostname, hostname)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200490
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000491 def test_basic(self):
492 self._test('123', 123)
493 self._test('', fail=True)
494 self._test('abc', fail=True)
495 self._test('123/1', fail=True)
496 self._test('123a', fail=True)
497 self._test('ssh://chrome-review.source.com/#/c/123/4/', fail=True)
498 self._test('ssh://chrome-review.source.com/c/123/1/', fail=True)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200499
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000500 def test_gerrit_url(self):
501 self._test('https://codereview.source.com/123', 123, None,
502 'codereview.source.com')
503 self._test('http://chrome-review.source.com/c/123', 123, None,
504 'chrome-review.source.com')
505 self._test('https://chrome-review.source.com/c/123/', 123, None,
506 'chrome-review.source.com')
507 self._test('https://chrome-review.source.com/c/123/4', 123, 4,
508 'chrome-review.source.com')
509 self._test('https://chrome-review.source.com/#/c/123/4', 123, 4,
510 'chrome-review.source.com')
511 self._test('https://chrome-review.source.com/c/123/4', 123, 4,
512 'chrome-review.source.com')
513 self._test('https://chrome-review.source.com/123', 123, None,
514 'chrome-review.source.com')
515 self._test('https://chrome-review.source.com/123/4', 123, 4,
516 'chrome-review.source.com')
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200517
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000518 self._test('https://chrome-review.source.com/bad/123/4', fail=True)
519 self._test('https://chrome-review.source.com/c/123/1/whatisthis', fail=True)
520 self._test('https://chrome-review.source.com/c/abc/', fail=True)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200521
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000522 def test_short_urls(self):
523 self._test('https://crrev.com/c/2151934', 2151934, None,
524 'chromium-review.googlesource.com')
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200525
526
Edward Lemurda4b6c62020-02-13 00:28:40 +0000527class GitCookiesCheckerTest(unittest.TestCase):
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100528 def setUp(self):
529 super(GitCookiesCheckerTest, self).setUp()
530 self.c = git_cl._GitCookiesChecker()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100531 self.c._all_hosts = []
Edward Lemurda4b6c62020-02-13 00:28:40 +0000532 mock.patch('sys.stdout', StringIO()).start()
533 self.addCleanup(mock.patch.stopall)
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100534
535 def mock_hosts_creds(self, subhost_identity_pairs):
536 def ensure_googlesource(h):
537 if not h.endswith(self.c._GOOGLESOURCE):
538 assert not h.endswith('.')
539 return h + '.' + self.c._GOOGLESOURCE
540 return h
541 self.c._all_hosts = [(ensure_googlesource(h), i, '.gitcookies')
542 for h, i in subhost_identity_pairs]
543
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200544 def test_identity_parsing(self):
545 self.assertEqual(self.c._parse_identity('ldap.google.com'),
546 ('ldap', 'google.com'))
547 self.assertEqual(self.c._parse_identity('git-ldap.example.com'),
548 ('ldap', 'example.com'))
549 # Specical case because we know there are no subdomains in chromium.org.
550 self.assertEqual(self.c._parse_identity('git-note.period.chromium.org'),
551 ('note.period', 'chromium.org'))
Lei Zhangd3f769a2017-12-15 15:16:14 -0800552 # Pathological: ".period." can be either username OR domain, more likely
553 # domain.
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200554 self.assertEqual(self.c._parse_identity('git-note.period.example.com'),
555 ('note', 'period.example.com'))
556
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100557 def test_analysis_nothing(self):
558 self.c._all_hosts = []
559 self.assertFalse(self.c.has_generic_host())
560 self.assertEqual(set(), self.c.get_conflicting_hosts())
561 self.assertEqual(set(), self.c.get_duplicated_hosts())
562 self.assertEqual(set(), self.c.get_partially_configured_hosts())
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100563
564 def test_analysis(self):
565 self.mock_hosts_creds([
566 ('.googlesource.com', 'git-example.chromium.org'),
567
568 ('chromium', 'git-example.google.com'),
569 ('chromium-review', 'git-example.google.com'),
570 ('chrome-internal', 'git-example.chromium.org'),
571 ('chrome-internal-review', 'git-example.chromium.org'),
572 ('conflict', 'git-example.google.com'),
573 ('conflict-review', 'git-example.chromium.org'),
574 ('dup', 'git-example.google.com'),
575 ('dup', 'git-example.google.com'),
576 ('dup-review', 'git-example.google.com'),
577 ('partial', 'git-example.google.com'),
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200578 ('gpartial-review', 'git-example.google.com'),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100579 ])
580 self.assertTrue(self.c.has_generic_host())
581 self.assertEqual(set(['conflict.googlesource.com']),
582 self.c.get_conflicting_hosts())
583 self.assertEqual(set(['dup.googlesource.com']),
584 self.c.get_duplicated_hosts())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200585 self.assertEqual(set(['partial.googlesource.com',
586 'gpartial-review.googlesource.com']),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100587 self.c.get_partially_configured_hosts())
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100588
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100589 def test_report_no_problems(self):
590 self.test_analysis_nothing()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100591 self.assertFalse(self.c.find_and_report_problems())
592 self.assertEqual(sys.stdout.getvalue(), '')
593
Edward Lemurda4b6c62020-02-13 00:28:40 +0000594 @mock.patch(
595 'git_cl.gerrit_util.CookiesAuthenticator.get_gitcookies_path',
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000596 return_value=os.path.join('~', '.gitcookies'))
Edward Lemurda4b6c62020-02-13 00:28:40 +0000597 def test_report(self, *_mocks):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100598 self.test_analysis()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100599 self.assertTrue(self.c.find_and_report_problems())
600 with open(os.path.join(os.path.dirname(__file__),
601 'git_cl_creds_check_report.txt')) as f:
Josip Sokcevic464e9ff2020-03-18 23:48:55 +0000602 expected = f.read() % {
603 'sep': os.sep,
604 }
605
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100606 def by_line(text):
607 return [l.rstrip() for l in text.rstrip().splitlines()]
Robert Iannucci456b0d62018-03-13 19:15:50 -0700608 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalov4812e612017-03-27 17:22:57 +0200609 self.assertEqual(by_line(sys.stdout.getvalue().strip()), by_line(expected))
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100610
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -0800611
Edward Lemurda4b6c62020-02-13 00:28:40 +0000612class TestGitCl(unittest.TestCase):
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000613 def setUp(self):
614 super(TestGitCl, self).setUp()
615 self.calls = []
tandrii9d206752016-06-20 11:32:47 -0700616 self._calls_done = []
Edward Lesmes0dd54822020-03-26 18:24:25 +0000617 self.failed = False
Edward Lemurda4b6c62020-02-13 00:28:40 +0000618 mock.patch('sys.stdout', StringIO()).start()
619 mock.patch(
620 'git_cl.time_time',
621 lambda: self._mocked_call('time.time')).start()
622 mock.patch(
623 'git_cl.metrics.collector.add_repeated',
624 lambda *a: self._mocked_call('add_repeated', *a)).start()
625 mock.patch('subprocess2.call', self._mocked_call).start()
626 mock.patch('subprocess2.check_call', self._mocked_call).start()
627 mock.patch('subprocess2.check_output', self._mocked_call).start()
628 mock.patch(
629 'subprocess2.communicate',
630 lambda *a, **_k: ([self._mocked_call(*a), ''], 0)).start()
631 mock.patch(
632 'git_cl.gclient_utils.CheckCallAndFilter',
633 self._mocked_call).start()
634 mock.patch('git_common.is_dirty_git_tree', lambda x: False).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +0000635 mock.patch('git_cl.FindCodereviewSettingsFile', return_value='').start()
636 mock.patch(
637 'git_cl.SaveDescriptionBackup',
638 lambda _: self._mocked_call('SaveDescriptionBackup')).start()
639 mock.patch(
Edward Lemurda4b6c62020-02-13 00:28:40 +0000640 'git_cl.write_json',
641 lambda *a: self._mocked_call('write_json', *a)).start()
642 mock.patch(
Edward Lemur227d5102020-02-25 23:45:35 +0000643 'git_cl.Changelist.RunHook',
644 return_value={'more_cc': ['test-more-cc@chromium.org']}).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +0000645 mock.patch('git_cl.watchlists.Watchlists', WatchlistsMock).start()
646 mock.patch('git_cl.auth.Authenticator', AuthenticatorMock).start()
Edward Lesmes7677e5c2020-02-19 20:39:03 +0000647 mock.patch('gerrit_util.GetChangeDetail').start()
Edward Lemurda4b6c62020-02-13 00:28:40 +0000648 mock.patch(
649 'git_cl.gerrit_util.GetChangeComments',
650 lambda *a: self._mocked_call('GetChangeComments', *a)).start()
651 mock.patch(
652 'git_cl.gerrit_util.GetChangeRobotComments',
653 lambda *a: self._mocked_call('GetChangeRobotComments', *a)).start()
654 mock.patch(
655 'git_cl.gerrit_util.AddReviewers',
656 lambda *a: self._mocked_call('AddReviewers', *a)).start()
657 mock.patch(
658 'git_cl.gerrit_util.SetReview',
659 lambda h, i, msg=None, labels=None, notify=None, ready=None: (
660 self._mocked_call(
661 'SetReview', h, i, msg, labels, notify, ready))).start()
662 mock.patch(
663 'git_cl.gerrit_util.LuciContextAuthenticator.is_luci',
664 return_value=False).start()
665 mock.patch(
666 'git_cl.gerrit_util.GceAuthenticator.is_gce',
667 return_value=False).start()
668 mock.patch(
669 'git_cl.gerrit_util.ValidAccounts',
670 lambda *a: self._mocked_call('ValidAccounts', *a)).start()
Edward Lemurd55c5072020-02-20 01:09:07 +0000671 mock.patch('sys.exit', side_effect=SystemExitMock).start()
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000672 mock.patch('git_cl.Settings.GetRoot', return_value='').start()
Edward Lemur85153282020-02-14 22:06:29 +0000673 self.mockGit = GitMocks()
674 mock.patch('scm.GIT.GetBranchRef', self.mockGit.GetBranchRef).start()
675 mock.patch('scm.GIT.GetConfig', self.mockGit.GetConfig).start()
Edward Lesmes50da7702020-03-30 19:23:43 +0000676 mock.patch('scm.GIT.ResolveCommit', return_value='hash').start()
677 mock.patch('scm.GIT.IsValidRevision', return_value=True).start()
Edward Lemur85153282020-02-14 22:06:29 +0000678 mock.patch('scm.GIT.SetConfig', self.mockGit.SetConfig).start()
Edward Lemur84101642020-02-21 21:40:34 +0000679 mock.patch(
680 'git_new_branch.create_new_branch', self.mockGit.NewBranch).start()
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000681 mock.patch(
Edward Lemur85153282020-02-14 22:06:29 +0000682 'scm.GIT.FetchUpstreamTuple',
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000683 return_value=('origin', 'refs/heads/master')).start()
Edward Lemur85153282020-02-14 22:06:29 +0000684 mock.patch(
685 'scm.GIT.CaptureStatus', return_value=[('M', 'foo.txt')]).start()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000686 # It's important to reset settings to not have inter-tests interference.
687 git_cl.settings = None
Edward Lemurda4b6c62020-02-13 00:28:40 +0000688 self.addCleanup(mock.patch.stopall)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000689
690 def tearDown(self):
wychen@chromium.org445c8962015-04-28 23:30:05 +0000691 try:
Edward Lesmes0dd54822020-03-26 18:24:25 +0000692 if not self.failed:
693 self.assertEqual([], self.calls)
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100694 except AssertionError:
Edward Lemur85153282020-02-14 22:06:29 +0000695 calls = ''.join(' %s\n' % str(call) for call in self.calls[:5])
696 if len(self.calls) > 5:
697 calls += ' ...\n'
698 self.fail(
699 '\n'
700 'There are un-consumed calls after this test has finished:\n' +
701 calls)
wychen@chromium.org445c8962015-04-28 23:30:05 +0000702 finally:
703 super(TestGitCl, self).tearDown()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000704
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000705 def _mocked_call(self, *args, **_kwargs):
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000706 self.assertTrue(
707 self.calls,
tandrii9d206752016-06-20 11:32:47 -0700708 '@%d Expected: <Missing> Actual: %r' % (len(self._calls_done), args))
wychen@chromium.orga872e752015-04-28 23:42:18 +0000709 top = self.calls.pop(0)
wychen@chromium.orga872e752015-04-28 23:42:18 +0000710 expected_args, result = top
711
maruel@chromium.orge52678e2013-04-26 18:34:44 +0000712 # Also logs otherwise it could get caught in a try/finally and be hard to
713 # diagnose.
714 if expected_args != args:
tandrii9d206752016-06-20 11:32:47 -0700715 N = 5
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000716 prior_calls = '\n '.join(
tandrii9d206752016-06-20 11:32:47 -0700717 '@%d: %r' % (len(self._calls_done) - N + i, c[0])
718 for i, c in enumerate(self._calls_done[-N:]))
719 following_calls = '\n '.join(
720 '@%d: %r' % (len(self._calls_done) + i + 1, c[0])
721 for i, c in enumerate(self.calls[:N]))
722 extended_msg = (
723 'A few prior calls:\n %s\n\n'
724 'This (expected):\n @%d: %r\n'
725 'This (actual):\n @%d: %r\n\n'
726 'A few following expected calls:\n %s' %
727 (prior_calls, len(self._calls_done), expected_args,
728 len(self._calls_done), args, following_calls))
tandrii9d206752016-06-20 11:32:47 -0700729
Edward Lesmes0dd54822020-03-26 18:24:25 +0000730 self.failed = True
tandrii99a72f22016-08-17 14:33:24 -0700731 self.fail('@%d\n'
732 ' Expected: %r\n'
Edward Lemur26964072020-02-19 19:18:51 +0000733 ' Actual: %r\n'
734 '\n'
735 '%s' % (
736 len(self._calls_done), expected_args, args, extended_msg))
tandrii9d206752016-06-20 11:32:47 -0700737
738 self._calls_done.append(top)
tandrii5d48c322016-08-18 16:19:37 -0700739 if isinstance(result, Exception):
740 raise result
Edward Lemur0db01f02019-11-12 22:01:51 +0000741 # stdout from git commands is supposed to be a bytestream. Convert it here
742 # instead of converting all test output in this file to bytes.
743 if args[0][0] == 'git' and not isinstance(result, bytes):
744 result = result.encode('utf-8')
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000745 return result
746
Edward Lemur1a83da12020-03-04 21:18:36 +0000747 @mock.patch('sys.stdin', StringIO('blah\nye\n'))
748 @mock.patch('sys.stdout', StringIO())
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100749 def test_ask_for_explicit_yes_true(self):
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100750 self.assertTrue(git_cl.ask_for_explicit_yes('prompt'))
Edward Lemur1a83da12020-03-04 21:18:36 +0000751 self.assertEqual(
752 'prompt [Yes/No]: Please, type yes or no: ',
753 sys.stdout.getvalue())
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100754
tandrii48df5812016-10-17 03:55:37 -0700755 def test_LoadCodereviewSettingsFromFile_gerrit(self):
Edward Lemur79d4f992019-11-11 23:49:02 +0000756 codereview_file = StringIO('GERRIT_HOST: true')
tandrii48df5812016-10-17 03:55:37 -0700757 self.calls = [
758 ((['git', 'config', '--unset-all', 'rietveld.cc'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700759 ((['git', 'config', '--unset-all', 'rietveld.tree-status-url'],), CERR1),
760 ((['git', 'config', '--unset-all', 'rietveld.viewvc-url'],), CERR1),
761 ((['git', 'config', '--unset-all', 'rietveld.bug-prefix'],), CERR1),
762 ((['git', 'config', '--unset-all', 'rietveld.cpplint-regex'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700763 ((['git', 'config', '--unset-all', 'rietveld.cpplint-ignore-regex'],),
764 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700765 ((['git', 'config', '--unset-all', 'rietveld.run-post-upload-hook'],),
766 CERR1),
Jamie Madilldc4d19e2019-10-24 21:50:02 +0000767 ((['git', 'config', '--unset-all', 'rietveld.format-full-by-default'],),
768 CERR1),
Dirk Pranke6f0df682021-06-25 00:42:33 +0000769 ((['git', 'config', '--unset-all', 'rietveld.use-python3'],),
770 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700771 ((['git', 'config', 'gerrit.host', 'true'],), ''),
772 ]
773 self.assertIsNone(git_cl.LoadCodereviewSettingsFromFile(codereview_file))
774
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000775 @classmethod
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100776 def _gerrit_base_calls(cls, issue=None, fetched_description=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200777 fetched_status=None, other_cl_owner=None,
Anthony Polito8b955342019-09-24 19:01:36 +0000778 custom_cl_base=None, short_hostname='chromium',
Edward Lesmes8c43c3f2021-01-20 00:20:26 +0000779 change_id=None, default_branch='master'):
Edward Lemur26964072020-02-19 19:18:51 +0000780 calls = []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200781 if custom_cl_base:
782 ancestor_revision = custom_cl_base
783 else:
784 # Determine ancestor_revision to be merge base.
Edward Lesmes8c43c3f2021-01-20 00:20:26 +0000785 ancestor_revision = 'origin/' + default_branch
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200786
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100787 if issue:
Edward Lesmes7677e5c2020-02-19 20:39:03 +0000788 gerrit_util.GetChangeDetail.return_value = {
789 'owner': {'email': (other_cl_owner or 'owner@example.com')},
790 'change_id': (change_id or '123456789'),
791 'current_revision': 'sha1_of_current_revision',
792 'revisions': {'sha1_of_current_revision': {
793 'commit': {'message': fetched_description},
794 }},
795 'status': fetched_status or 'NEW',
796 }
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100797 if fetched_status == 'ABANDONED':
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100798 return calls
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100799 if other_cl_owner:
800 calls += [
801 (('ask_for_data', 'Press Enter to upload, or Ctrl+C to abort'), ''),
802 ]
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100803
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100804 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200805 ((['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] +
806 ([custom_cl_base] if custom_cl_base else
807 [ancestor_revision, 'HEAD']),),
808 '+dat'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100809 ]
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000810 calls += [
811 ((['git', 'show-branch', 'refs/remotes/origin/main'], ),
Edward Lesmes8c43c3f2021-01-20 00:20:26 +0000812 '1' if default_branch == 'main' else callError(1)),
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000813 ]
Edward Lemur2c62b332020-03-12 22:12:33 +0000814
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100815 return calls
ukai@chromium.orge8077812012-02-03 03:41:46 +0000816
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +0000817 def _gerrit_upload_calls(self,
818 description,
819 reviewers,
820 squash,
tandriia60502f2016-06-20 02:01:53 -0700821 squash_mode='default',
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +0000822 title=None,
823 notify=False,
824 post_amend_description=None,
825 issue=None,
826 cc=None,
827 custom_cl_base=None,
828 tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +0000829 short_hostname='chromium',
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +0000830 labels=None,
831 change_id=None,
832 final_description=None,
833 gitcookies_exists=True,
834 force=False,
835 edit_description=None,
836 default_branch='master',
837 push_opts=None):
tandrii@chromium.org10625002016-03-04 20:03:47 +0000838 if post_amend_description is None:
839 post_amend_description = description
bradnelsond975b302016-10-23 12:20:23 -0700840 cc = cc or []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200841
842 calls = []
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000843
Edward Lesmes4de54132020-05-05 19:41:33 +0000844 if squash_mode in ('override_squash', 'override_nosquash'):
845 self.mockGit.config['gerrit.override-squash-uploads'] = (
846 'true' if squash_mode == 'override_squash' else 'false')
847
tandrii@chromium.org57d86542016-03-04 16:11:32 +0000848 if not git_footers.get_footer_change_id(description) and not squash:
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000849 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200850 (('DownloadGerritHook', False), ''),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200851 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000852 if squash:
Edward Lemur5a644f82020-03-18 16:44:57 +0000853 if not issue and not force:
Edward Lemur5fb22242020-03-12 22:05:13 +0000854 calls += [
855 ((['RunEditor'],), description),
856 ]
Josipe827b0f2020-01-30 00:07:20 +0000857 # user wants to edit description
858 if edit_description:
859 calls += [
Josipe827b0f2020-01-30 00:07:20 +0000860 ((['RunEditor'],), edit_description),
861 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000862 ref_to_push = 'abcdef0123456789'
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200863
864 if custom_cl_base is None:
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000865 parent = 'origin/' + default_branch
Edward Lesmes8c43c3f2021-01-20 00:20:26 +0000866 git_common.get_or_create_merge_base.return_value = parent
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200867 else:
868 calls += [
869 ((['git', 'merge-base', '--is-ancestor', custom_cl_base,
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000870 'refs/remotes/origin/' + default_branch],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200871 callError(1)), # Means not ancenstor.
872 (('ask_for_data',
873 'Do you take responsibility for cleaning up potential mess '
874 'resulting from proceeding with upload? Press Enter to upload, '
875 'or Ctrl+C to abort'), ''),
876 ]
877 parent = custom_cl_base
878
879 calls += [
880 ((['git', 'rev-parse', 'HEAD:'],), # `HEAD:` means HEAD's tree hash.
881 '0123456789abcdef'),
Edward Lemur1773f372020-02-22 00:27:14 +0000882 ((['FileWrite', '/tmp/fake-temp1', description],), None),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200883 ((['git', 'commit-tree', '0123456789abcdef', '-p', parent,
Edward Lemur1773f372020-02-22 00:27:14 +0000884 '-F', '/tmp/fake-temp1'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200885 ref_to_push),
886 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000887 else:
888 ref_to_push = 'HEAD'
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000889 parent = 'origin/refs/heads/' + default_branch
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000890
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000891 calls += [
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000892 (('SaveDescriptionBackup',), None),
Edward Lemur5a644f82020-03-18 16:44:57 +0000893 ((['git', 'rev-list', parent + '..' + ref_to_push],),'1hashPerLine\n'),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200894 ]
tandrii@chromium.org8da45402016-05-24 23:11:03 +0000895
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +0000896 metrics_arguments = []
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000897
Aaron Gableafd52772017-06-27 16:40:10 -0700898 if notify:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +0000899 ref_suffix = '%ready,notify=ALL'
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000900 metrics_arguments += ['ready', 'notify=ALL']
Aaron Gable844cf292017-06-28 11:32:59 -0700901 else:
Jamie Madill276da0b2018-04-27 14:41:20 -0400902 if not issue and squash:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +0000903 ref_suffix = '%wip'
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000904 metrics_arguments.append('wip')
Aaron Gable844cf292017-06-28 11:32:59 -0700905 else:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +0000906 ref_suffix = '%notify=NONE'
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000907 metrics_arguments.append('notify=NONE')
Aaron Gable9b713dd2016-12-14 16:04:21 -0800908
Edward Lemur5a644f82020-03-18 16:44:57 +0000909 # If issue is given, then description is fetched from Gerrit instead.
910 if issue is None:
911 if squash:
912 title = 'Initial upload'
913 else:
914 if not title:
915 calls += [
916 ((['git', 'show', '-s', '--format=%s', 'HEAD'],), ''),
917 (('ask_for_data', 'Title for patchset []: '), 'User input'),
918 ]
919 title = 'User input'
Aaron Gable70f4e242017-06-26 10:45:59 -0700920 if title:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +0000921 ref_suffix += ',m=' + gerrit_util.PercentEncodeForGitRef(title)
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000922 metrics_arguments.append('m')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000923
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000924 if short_hostname == 'chromium':
Quinten Yearsley925cedb2020-04-13 17:49:39 +0000925 # All reviewers and ccs get into ref_suffix.
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000926 for r in sorted(reviewers):
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +0000927 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000928 metrics_arguments.append('r')
Edward Lemur4508b422019-10-03 21:56:35 +0000929 if issue is None:
Edward Lemur227d5102020-02-25 23:45:35 +0000930 cc += ['test-more-cc@chromium.org', 'joe@example.com']
Edward Lemur4508b422019-10-03 21:56:35 +0000931 for c in sorted(cc):
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +0000932 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000933 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000934 reviewers, cc = [], []
935 else:
936 # TODO(crbug/877717): remove this case.
937 calls += [
938 (('ValidAccounts', '%s-review.googlesource.com' % short_hostname,
939 sorted(reviewers) + ['joe@example.com',
Edward Lemur227d5102020-02-25 23:45:35 +0000940 'test-more-cc@chromium.org'] + cc),
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000941 {
942 e: {'email': e}
943 for e in (reviewers + ['joe@example.com'] + cc)
944 })
945 ]
946 for r in sorted(reviewers):
947 if r != 'bad-account-or-email':
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +0000948 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000949 metrics_arguments.append('r')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000950 reviewers.remove(r)
Edward Lemur4508b422019-10-03 21:56:35 +0000951 if issue is None:
952 cc += ['joe@example.com']
953 for c in sorted(cc):
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +0000954 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000955 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000956 if c in cc:
957 cc.remove(c)
Andrii Shyshkalov76988a82018-10-15 03:12:25 +0000958
Edward Lemur687ca902018-12-05 02:30:30 +0000959 for k, v in sorted((labels or {}).items()):
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +0000960 ref_suffix += ',l=%s+%d' % (k, v)
Edward Lemur687ca902018-12-05 02:30:30 +0000961 metrics_arguments.append('l=%s+%d' % (k, v))
962
963 if tbr:
964 calls += [
965 (('GetCodeReviewTbrScore',
966 '%s-review.googlesource.com' % short_hostname,
967 'my/repo'),
968 2,),
969 ]
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +0000970
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000971 calls += [
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +0000972 (
973 ('time.time', ),
974 1000,
975 ),
976 (
977 ([
978 'git', 'push',
979 'https://%s.googlesource.com/my/repo' % short_hostname,
980 ref_to_push + ':refs/for/refs/heads/' + default_branch +
981 ref_suffix
982 ] + (push_opts if push_opts else []), ),
983 (('remote:\n'
984 'remote: Processing changes: (\)\n'
985 'remote: Processing changes: (|)\n'
986 'remote: Processing changes: (/)\n'
987 'remote: Processing changes: (-)\n'
988 'remote: Processing changes: new: 1 (/)\n'
989 'remote: Processing changes: new: 1, done\n'
990 'remote:\n'
991 'remote: New Changes:\n'
992 'remote: '
993 'https://%s-review.googlesource.com/#/c/my/repo/+/123456'
994 ' XXX\n'
995 'remote:\n'
996 'To https://%s.googlesource.com/my/repo\n'
997 ' * [new branch] hhhh -> refs/for/refs/heads/%s\n') %
998 (short_hostname, short_hostname, default_branch)),
999 ),
1000 (
1001 ('time.time', ),
1002 2000,
1003 ),
1004 (
1005 ('add_repeated', 'sub_commands', {
1006 'execution_time': 1000,
1007 'command': 'git push',
1008 'exit_code': 0,
1009 'arguments': sorted(metrics_arguments),
1010 }),
1011 None,
1012 ),
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001013 ]
1014
Edward Lemur1b52d872019-05-09 21:12:12 +00001015 final_description = final_description or post_amend_description.strip()
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001016
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001017 trace_name = os.path.join('TRACES_DIR', '20170316T200041.000000')
1018
Edward Lemur1b52d872019-05-09 21:12:12 +00001019 # Trace-related calls
1020 calls += [
1021 # Write a description with context for the current trace.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001022 (
1023 ([
1024 'FileWrite', trace_name + '-README',
1025 '%(date)s\n'
1026 '%(short_hostname)s-review.googlesource.com\n'
1027 '%(change_id)s\n'
1028 '%(title)s\n'
1029 '%(description)s\n'
1030 '1000\n'
1031 '0\n'
1032 '%(trace_name)s' % {
Josip Sokcevic5e18b602020-04-23 21:47:00 +00001033 'date': '2017-03-16T20:00:41.000000',
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001034 'short_hostname': short_hostname,
1035 'change_id': change_id,
1036 'description': final_description,
1037 'title': title or '<untitled>',
1038 'trace_name': trace_name,
1039 }
1040 ], ),
1041 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001042 ),
1043 # Read traces and shorten git hashes.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001044 (
1045 (['os.path.isfile',
1046 os.path.join('TEMP_DIR', 'trace-packet')], ),
1047 True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001048 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001049 (
1050 (['FileRead', os.path.join('TEMP_DIR', 'trace-packet')], ),
1051 ('git-hash: 0123456789012345678901234567890123456789\n'
1052 'git-hash: abcdeabcdeabcdeabcdeabcdeabcdeabcdeabcde\n'),
Edward Lemur1b52d872019-05-09 21:12:12 +00001053 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001054 (
1055 ([
1056 'FileWrite',
1057 os.path.join('TEMP_DIR', 'trace-packet'), 'git-hash: 012345\n'
1058 'git-hash: abcdea\n'
1059 ], ),
1060 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001061 ),
1062 # Make zip file for the git traces.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001063 (
1064 (['make_archive', trace_name + '-traces', 'zip', 'TEMP_DIR'], ),
1065 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001066 ),
1067 # Collect git config and gitcookies.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001068 (
1069 (['git', 'config', '-l'], ),
1070 'git-config-output',
Edward Lemur1b52d872019-05-09 21:12:12 +00001071 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001072 (
1073 ([
1074 'FileWrite',
1075 os.path.join('TEMP_DIR', 'git-config'), 'git-config-output'
1076 ], ),
1077 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001078 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001079 (
1080 (['os.path.isfile',
1081 os.path.join('~', '.gitcookies')], ),
1082 gitcookies_exists,
Edward Lemur1b52d872019-05-09 21:12:12 +00001083 ),
1084 ]
1085 if gitcookies_exists:
1086 calls += [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001087 (
1088 (['FileRead', os.path.join('~', '.gitcookies')], ),
1089 'gitcookies 1/SECRET',
Edward Lemur1b52d872019-05-09 21:12:12 +00001090 ),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001091 (
1092 ([
1093 'FileWrite',
1094 os.path.join('TEMP_DIR', 'gitcookies'), 'gitcookies REDACTED'
1095 ], ),
1096 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001097 ),
1098 ]
1099 calls += [
1100 # Make zip file for the git config and gitcookies.
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00001101 (
1102 (['make_archive', trace_name + '-git-info', 'zip', 'TEMP_DIR'], ),
1103 None,
Edward Lemur1b52d872019-05-09 21:12:12 +00001104 ),
1105 ]
1106
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001107 # TODO(crbug/877717): this should never be used.
1108 if squash and short_hostname != 'chromium':
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001109 calls += [
1110 (('AddReviewers',
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001111 'chromium-review.googlesource.com', 'my%2Frepo~123456',
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001112 sorted(reviewers),
Edward Lemur227d5102020-02-25 23:45:35 +00001113 cc + ['test-more-cc@chromium.org'],
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00001114 notify),
1115 ''),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001116 ]
ukai@chromium.orge8077812012-02-03 03:41:46 +00001117 return calls
1118
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00001119 def _run_gerrit_upload_test(self,
1120 upload_args,
1121 description,
1122 reviewers=None,
1123 squash=True,
1124 squash_mode=None,
1125 title=None,
1126 notify=False,
1127 post_amend_description=None,
1128 issue=None,
1129 cc=None,
1130 fetched_status=None,
1131 other_cl_owner=None,
1132 custom_cl_base=None,
1133 tbr=None,
1134 short_hostname='chromium',
1135 labels=None,
1136 change_id=None,
1137 final_description=None,
1138 gitcookies_exists=True,
1139 force=False,
1140 log_description=None,
1141 edit_description=None,
1142 fetched_description=None,
1143 default_branch='master',
1144 push_opts=None):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001145 """Generic gerrit upload test framework."""
tandriia60502f2016-06-20 02:01:53 -07001146 if squash_mode is None:
1147 if '--no-squash' in upload_args:
1148 squash_mode = 'nosquash'
1149 elif '--squash' in upload_args:
1150 squash_mode = 'squash'
1151 else:
1152 squash_mode = 'default'
1153
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001154 reviewers = reviewers or []
bradnelsond975b302016-10-23 12:20:23 -07001155 cc = cc or []
Edward Lemurda4b6c62020-02-13 00:28:40 +00001156 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001157 CookiesAuthenticatorMockFactory(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001158 same_auth=('git-owner.example.com', '', 'pass'))).start()
1159 mock.patch('git_cl.Changelist._GerritCommitMsgHookCheck',
1160 lambda _, offer_removal: None).start()
1161 mock.patch('git_cl.gclient_utils.RunEditor',
1162 lambda *_, **__: self._mocked_call(['RunEditor'])).start()
1163 mock.patch('git_cl.DownloadGerritHook', lambda force: self._mocked_call(
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001164 'DownloadGerritHook', force)).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00001165 mock.patch('git_cl.gclient_utils.FileRead',
1166 lambda path: self._mocked_call(['FileRead', path])).start()
1167 mock.patch('git_cl.gclient_utils.FileWrite',
Edward Lemur1b52d872019-05-09 21:12:12 +00001168 lambda path, contents: self._mocked_call(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001169 ['FileWrite', path, contents])).start()
1170 mock.patch('git_cl.datetime_now',
1171 lambda: datetime.datetime(2017, 3, 16, 20, 0, 41, 0)).start()
1172 mock.patch('git_cl.tempfile.mkdtemp', lambda: 'TEMP_DIR').start()
1173 mock.patch('git_cl.TRACES_DIR', 'TRACES_DIR').start()
1174 mock.patch('git_cl.TRACES_README_FORMAT',
Edward Lemur75391d42019-05-14 23:35:56 +00001175 '%(now)s\n'
1176 '%(gerrit_host)s\n'
1177 '%(change_id)s\n'
1178 '%(title)s\n'
1179 '%(description)s\n'
1180 '%(execution_time)s\n'
1181 '%(exit_code)s\n'
Edward Lemurda4b6c62020-02-13 00:28:40 +00001182 '%(trace_name)s').start()
1183 mock.patch('git_cl.shutil.make_archive',
1184 lambda *args: self._mocked_call(['make_archive'] +
1185 list(args))).start()
1186 mock.patch('os.path.isfile',
1187 lambda path: self._mocked_call(['os.path.isfile', path])).start()
Edward Lemur9aa1a962020-02-25 00:58:38 +00001188 mock.patch(
Edward Lesmes0dd54822020-03-26 18:24:25 +00001189 'git_cl._create_description_from_log',
1190 return_value=log_description or description).start()
Edward Lemura12175c2020-03-09 16:58:26 +00001191 mock.patch(
1192 'git_cl.Changelist._AddChangeIdToCommitMessage',
1193 return_value=post_amend_description or description).start()
Edward Lemur1a83da12020-03-04 21:18:36 +00001194 mock.patch(
Edward Lemur5a644f82020-03-18 16:44:57 +00001195 'git_cl.GenerateGerritChangeId', return_value=change_id).start()
1196 mock.patch(
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001197 'git_common.get_or_create_merge_base',
1198 return_value='origin/' + default_branch).start()
1199 mock.patch(
Edward Lesmesae3586b2020-03-23 21:21:14 +00001200 'gclient_utils.AskForData',
Edward Lemur1a83da12020-03-04 21:18:36 +00001201 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
tandriia60502f2016-06-20 02:01:53 -07001202
Edward Lemur26964072020-02-19 19:18:51 +00001203 self.mockGit.config['gerrit.host'] = 'true'
Edward Lemur85153282020-02-14 22:06:29 +00001204 self.mockGit.config['branch.master.gerritissue'] = (
1205 str(issue) if issue else None)
1206 self.mockGit.config['remote.origin.url'] = (
1207 'https://%s.googlesource.com/my/repo' % short_hostname)
Edward Lemur9aa1a962020-02-25 00:58:38 +00001208 self.mockGit.config['user.email'] = 'me@example.com'
Edward Lemur85153282020-02-14 22:06:29 +00001209
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001210 self.calls = self._gerrit_base_calls(
1211 issue=issue,
Anthony Polito8b955342019-09-24 19:01:36 +00001212 fetched_description=fetched_description or description,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001213 fetched_status=fetched_status,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001214 other_cl_owner=other_cl_owner,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001215 custom_cl_base=custom_cl_base,
Anthony Polito8b955342019-09-24 19:01:36 +00001216 short_hostname=short_hostname,
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001217 change_id=change_id,
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001218 default_branch=default_branch)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001219 if fetched_status != 'ABANDONED':
Edward Lemurda4b6c62020-02-13 00:28:40 +00001220 mock.patch(
Edward Lemur1773f372020-02-22 00:27:14 +00001221 'gclient_utils.temporary_file', TemporaryFileMock()).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00001222 mock.patch('os.remove', return_value=True).start()
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001223 self.calls += self._gerrit_upload_calls(
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00001224 description,
1225 reviewers,
1226 squash,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001227 squash_mode=squash_mode,
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00001228 title=title,
1229 notify=notify,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001230 post_amend_description=post_amend_description,
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00001231 issue=issue,
1232 cc=cc,
1233 custom_cl_base=custom_cl_base,
1234 tbr=tbr,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001235 short_hostname=short_hostname,
Edward Lemur1b52d872019-05-09 21:12:12 +00001236 labels=labels,
1237 change_id=change_id,
Edward Lemur1b52d872019-05-09 21:12:12 +00001238 final_description=final_description,
Anthony Polito8b955342019-09-24 19:01:36 +00001239 gitcookies_exists=gitcookies_exists,
Josipe827b0f2020-01-30 00:07:20 +00001240 force=force,
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001241 edit_description=edit_description,
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00001242 default_branch=default_branch,
1243 push_opts=push_opts)
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001244 # Uncomment when debugging.
Raul Tambre80ee78e2019-05-06 22:41:05 +00001245 # print('\n'.join(map(lambda x: '%2i: %s' % x, enumerate(self.calls))))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001246 git_cl.main(['upload'] + upload_args)
Edward Lemur85153282020-02-14 22:06:29 +00001247 if squash:
Edward Lemur26964072020-02-19 19:18:51 +00001248 self.assertIssueAndPatchset(patchset=None)
Edward Lemur85153282020-02-14 22:06:29 +00001249 self.assertEqual(
1250 'abcdef0123456789',
Edward Lemur26964072020-02-19 19:18:51 +00001251 scm.GIT.GetBranchConfig('', 'master', 'gerritsquashhash'))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001252
Edward Lemur1b52d872019-05-09 21:12:12 +00001253 def test_gerrit_upload_traces_no_gitcookies(self):
1254 self._run_gerrit_upload_test(
1255 ['--no-squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001256 'desc ✔\n\nBUG=\n',
Edward Lemur1b52d872019-05-09 21:12:12 +00001257 [],
1258 squash=False,
Edward Lemur0db01f02019-11-12 22:01:51 +00001259 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001260 change_id='Ixxx',
1261 gitcookies_exists=False)
1262
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001263 def test_gerrit_upload_without_change_id(self):
tandriia60502f2016-06-20 02:01:53 -07001264 self._run_gerrit_upload_test(
Edward Lemur5a644f82020-03-18 16:44:57 +00001265 [],
1266 'desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
1267 [],
1268 change_id='Ixxx')
1269
1270 def test_gerrit_upload_without_change_id_nosquash(self):
1271 self._run_gerrit_upload_test(
tandriia60502f2016-06-20 02:01:53 -07001272 ['--no-squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001273 'desc ✔\n\nBUG=\n',
tandriia60502f2016-06-20 02:01:53 -07001274 [],
1275 squash=False,
Edward Lemur0db01f02019-11-12 22:01:51 +00001276 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001277 change_id='Ixxx')
tandriia60502f2016-06-20 02:01:53 -07001278
Edward Lesmes4de54132020-05-05 19:41:33 +00001279 def test_gerrit_upload_without_change_id_override_nosquash(self):
1280 self._run_gerrit_upload_test(
1281 [],
1282 'desc ✔\n\nBUG=\n',
1283 [],
1284 squash=False,
1285 squash_mode='override_nosquash',
1286 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
1287 change_id='Ixxx')
1288
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001289 def test_gerrit_no_reviewer(self):
1290 self._run_gerrit_upload_test(
Edward Lesmes4de54132020-05-05 19:41:33 +00001291 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001292 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
tandriia60502f2016-06-20 02:01:53 -07001293 [],
1294 squash=False,
Edward Lesmes4de54132020-05-05 19:41:33 +00001295 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001296 change_id='I123456789')
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001297
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00001298 def test_gerrit_push_opts(self):
1299 self._run_gerrit_upload_test(['-o', 'wip'],
1300 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
1301 [],
1302 squash=False,
1303 squash_mode='override_nosquash',
1304 change_id='I123456789',
1305 push_opts=['-o', 'wip'])
1306
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001307 def test_gerrit_no_reviewer_non_chromium_host(self):
1308 # TODO(crbug/877717): remove this test case.
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00001309 self._run_gerrit_upload_test([],
1310 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
1311 [],
1312 squash=False,
1313 squash_mode='override_nosquash',
1314 short_hostname='other',
1315 change_id='I123456789')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001316
Edward Lesmes0dd54822020-03-26 18:24:25 +00001317 def test_gerrit_patchset_title_special_chars_nosquash(self):
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001318 self._run_gerrit_upload_test(
Edward Lesmes4de54132020-05-05 19:41:33 +00001319 ['-f', '-t', 'We\'ll escape ^_ ^ special chars...@{u}'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001320 'desc ✔\n\nBUG=\n\nChange-Id: I123456789',
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001321 squash=False,
Edward Lesmes4de54132020-05-05 19:41:33 +00001322 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001323 change_id='I123456789',
Edward Lemur5a644f82020-03-18 16:44:57 +00001324 title='We\'ll escape ^_ ^ special chars...@{u}')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001325
ukai@chromium.orge8077812012-02-03 03:41:46 +00001326 def test_gerrit_reviewers_cmd_line(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001327 self._run_gerrit_upload_test(
Edward Lesmes4de54132020-05-05 19:41:33 +00001328 ['-r', 'foo@example.com', '--send-mail'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001329 'desc ✔\n\nBUG=\n\nChange-Id: I123456789',
Edward Lemur5a644f82020-03-18 16:44:57 +00001330 reviewers=['foo@example.com'],
tandriia60502f2016-06-20 02:01:53 -07001331 squash=False,
Edward Lesmes4de54132020-05-05 19:41:33 +00001332 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001333 notify=True,
1334 change_id='I123456789',
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001335 final_description=(
Edward Lemur0db01f02019-11-12 22:01:51 +00001336 'desc ✔\n\nBUG=\nR=foo@example.com\n\nChange-Id: I123456789'))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001337
Anthony Polito8b955342019-09-24 19:01:36 +00001338 def test_gerrit_upload_force_sets_bug(self):
1339 self._run_gerrit_upload_test(
1340 ['-b', '10000', '-f'],
1341 u'desc=\n\nBug: 10000\nChange-Id: Ixxx',
1342 [],
1343 force=True,
Anthony Polito8b955342019-09-24 19:01:36 +00001344 fetched_description='desc=\n\nChange-Id: Ixxx',
Anthony Polito8b955342019-09-24 19:01:36 +00001345 change_id='Ixxx')
1346
Edward Lemur5fb22242020-03-12 22:05:13 +00001347 def test_gerrit_upload_corrects_wrong_change_id(self):
Anthony Polito8b955342019-09-24 19:01:36 +00001348 self._run_gerrit_upload_test(
Edward Lemur5fb22242020-03-12 22:05:13 +00001349 ['-b', '10000', '-m', 'Title', '--edit-description'],
1350 u'desc=\n\nBug: 10000\nChange-Id: Ixxxx',
Anthony Polito8b955342019-09-24 19:01:36 +00001351 [],
Anthony Polito8b955342019-09-24 19:01:36 +00001352 issue='123456',
Edward Lemur5fb22242020-03-12 22:05:13 +00001353 edit_description='desc=\n\nBug: 10000\nChange-Id: Izzzz',
Anthony Polito8b955342019-09-24 19:01:36 +00001354 fetched_description='desc=\n\nChange-Id: Ixxxx',
Anthony Polito8b955342019-09-24 19:01:36 +00001355 title='Title',
Edward Lemur5fb22242020-03-12 22:05:13 +00001356 change_id='Ixxxx')
Anthony Polito8b955342019-09-24 19:01:36 +00001357
Dan Beamd8b04ca2019-10-10 21:23:26 +00001358 def test_gerrit_upload_force_sets_fixed(self):
1359 self._run_gerrit_upload_test(
1360 ['-x', '10000', '-f'],
1361 u'desc=\n\nFixed: 10000\nChange-Id: Ixxx',
1362 [],
1363 force=True,
Dan Beamd8b04ca2019-10-10 21:23:26 +00001364 fetched_description='desc=\n\nChange-Id: Ixxx',
Dan Beamd8b04ca2019-10-10 21:23:26 +00001365 change_id='Ixxx')
1366
ukai@chromium.orge8077812012-02-03 03:41:46 +00001367 def test_gerrit_reviewer_multiple(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00001368 mock.patch('git_cl.gerrit_util.GetCodeReviewTbrScore',
1369 lambda *a: self._mocked_call('GetCodeReviewTbrScore', *a)).start()
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001370 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001371 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001372 'desc ✔\nTBR=reviewer@example.com\nBUG=\nR=another@example.com\n'
bradnelsond975b302016-10-23 12:20:23 -07001373 'CC=more@example.com,people@example.com\n\n'
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001374 'Change-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001375 ['reviewer@example.com', 'another@example.com'],
Aaron Gablefd238082017-06-07 13:42:34 -07001376 cc=['more@example.com', 'people@example.com'],
Edward Lemur687ca902018-12-05 02:30:30 +00001377 tbr='reviewer@example.com',
Edward Lemur1b52d872019-05-09 21:12:12 +00001378 labels={'Code-Review': 2},
Edward Lemur5a644f82020-03-18 16:44:57 +00001379 change_id='123456789')
tandriia60502f2016-06-20 02:01:53 -07001380
1381 def test_gerrit_upload_squash_first_is_default(self):
tandriia60502f2016-06-20 02:01:53 -07001382 self._run_gerrit_upload_test(
1383 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001384 'desc ✔\nBUG=\n\nChange-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001385 [],
Edward Lemur5a644f82020-03-18 16:44:57 +00001386 change_id='123456789')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001387
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001388 def test_gerrit_upload_squash_first(self):
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001389 self._run_gerrit_upload_test(
1390 ['--squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001391 'desc ✔\nBUG=\n\nChange-Id: 123456789',
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001392 [],
luqui@chromium.org609f3952015-05-04 22:47:04 +00001393 squash=True,
Edward Lemur5a644f82020-03-18 16:44:57 +00001394 change_id='123456789')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001395
Edward Lesmes0dd54822020-03-26 18:24:25 +00001396 def test_gerrit_upload_squash_first_title(self):
1397 self._run_gerrit_upload_test(
1398 ['-f', '-t', 'title'],
1399 'title\n\ndesc\n\nChange-Id: 123456789',
1400 [],
1401 force=True,
1402 squash=True,
1403 log_description='desc',
1404 change_id='123456789')
1405
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001406 def test_gerrit_upload_squash_first_with_labels(self):
1407 self._run_gerrit_upload_test(
1408 ['--squash', '--cq-dry-run', '--enable-auto-submit'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001409 'desc ✔\nBUG=\n\nChange-Id: 123456789',
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001410 [],
1411 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001412 labels={'Commit-Queue': 1, 'Auto-Submit': 1},
Edward Lemur5a644f82020-03-18 16:44:57 +00001413 change_id='123456789')
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001414
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001415 def test_gerrit_upload_squash_first_against_rev(self):
1416 custom_cl_base = 'custom_cl_base_rev_or_branch'
1417 self._run_gerrit_upload_test(
1418 ['--squash', custom_cl_base],
Edward Lemur0db01f02019-11-12 22:01:51 +00001419 'desc ✔\nBUG=\n\nChange-Id: 123456789',
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001420 [],
1421 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001422 custom_cl_base=custom_cl_base,
Edward Lemur5a644f82020-03-18 16:44:57 +00001423 change_id='123456789')
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001424 self.assertIn(
1425 'If you proceed with upload, more than 1 CL may be created by Gerrit',
1426 sys.stdout.getvalue())
1427
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001428 def test_gerrit_upload_squash_reupload(self):
Edward Lemur0db01f02019-11-12 22:01:51 +00001429 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001430 self._run_gerrit_upload_test(
1431 ['--squash'],
1432 description,
1433 [],
1434 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001435 issue=123456,
Edward Lemur5a644f82020-03-18 16:44:57 +00001436 change_id='123456789')
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001437
Edward Lemurd55c5072020-02-20 01:09:07 +00001438 @mock.patch('sys.stderr', StringIO())
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001439 def test_gerrit_upload_squash_reupload_to_abandoned(self):
Edward Lemur0db01f02019-11-12 22:01:51 +00001440 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001441 with self.assertRaises(SystemExitMock):
1442 self._run_gerrit_upload_test(
1443 ['--squash'],
1444 description,
1445 [],
1446 squash=True,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001447 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001448 fetched_status='ABANDONED',
1449 change_id='123456789')
Edward Lemurd55c5072020-02-20 01:09:07 +00001450 self.assertEqual(
1451 'Change https://chromium-review.googlesource.com/123456 has been '
1452 'abandoned, new uploads are not allowed\n',
1453 sys.stderr.getvalue())
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001454
Edward Lemurda4b6c62020-02-13 00:28:40 +00001455 @mock.patch(
1456 'gerrit_util.GetAccountDetails',
1457 return_value={'email': 'yet-another@example.com'})
1458 def test_gerrit_upload_squash_reupload_to_not_owned(self, _mock):
Edward Lemur0db01f02019-11-12 22:01:51 +00001459 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001460 self._run_gerrit_upload_test(
1461 ['--squash'],
1462 description,
1463 [],
1464 squash=True,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001465 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001466 other_cl_owner='other@example.com',
Edward Lemur5a644f82020-03-18 16:44:57 +00001467 change_id='123456789')
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001468 self.assertIn(
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001469 'WARNING: Change 123456 is owned by other@example.com, but you '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001470 'authenticate to Gerrit as yet-another@example.com.\n'
1471 'Uploading may fail due to lack of permissions',
Edward Lemurda4b6c62020-02-13 00:28:40 +00001472 sys.stdout.getvalue())
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001473
Josipe827b0f2020-01-30 00:07:20 +00001474 def test_upload_change_description_editor(self):
1475 fetched_description = 'foo\n\nChange-Id: 123456789'
1476 description = 'bar\n\nChange-Id: 123456789'
1477 self._run_gerrit_upload_test(
1478 ['--squash', '--edit-description'],
1479 description,
1480 [],
1481 fetched_description=fetched_description,
1482 squash=True,
Josipe827b0f2020-01-30 00:07:20 +00001483 issue=123456,
1484 change_id='123456789',
Josipe827b0f2020-01-30 00:07:20 +00001485 edit_description=description)
1486
Edward Lemurda4b6c62020-02-13 00:28:40 +00001487 @mock.patch('git_cl.RunGit')
1488 @mock.patch('git_cl.CMDupload')
Edward Lemur1a83da12020-03-04 21:18:36 +00001489 @mock.patch('sys.stdin', StringIO('\n'))
1490 @mock.patch('sys.stdout', StringIO())
Edward Lemurda4b6c62020-02-13 00:28:40 +00001491 def test_upload_branch_deps(self, *_mocks):
rmistry@google.com2dd99862015-06-22 12:22:18 +00001492 def mock_run_git(*args, **_kwargs):
1493 if args[0] == ['for-each-ref',
1494 '--format=%(refname:short) %(upstream:short)',
1495 'refs/heads']:
1496 # Create a local branch dependency tree that looks like this:
1497 # test1 -> test2 -> test3 -> test4 -> test5
1498 # -> test3.1
1499 # test6 -> test0
1500 branch_deps = [
1501 'test2 test1', # test1 -> test2
1502 'test3 test2', # test2 -> test3
1503 'test3.1 test2', # test2 -> test3.1
1504 'test4 test3', # test3 -> test4
1505 'test5 test4', # test4 -> test5
1506 'test6 test0', # test0 -> test6
1507 'test7', # test7
1508 ]
1509 return '\n'.join(branch_deps)
Edward Lemurda4b6c62020-02-13 00:28:40 +00001510 git_cl.RunGit.side_effect = mock_run_git
1511 git_cl.CMDupload.return_value = 0
rmistry@google.com2dd99862015-06-22 12:22:18 +00001512
1513 class MockChangelist():
1514 def __init__(self):
1515 pass
1516 def GetBranch(self):
1517 return 'test1'
1518 def GetIssue(self):
1519 return '123'
1520 def GetPatchset(self):
1521 return '1001'
tandrii@chromium.org4c72b082016-03-31 22:26:35 +00001522 def IsGerrit(self):
1523 return False
rmistry@google.com2dd99862015-06-22 12:22:18 +00001524
1525 ret = git_cl.upload_branch_deps(MockChangelist(), [])
1526 # CMDupload should have been called 5 times because of 5 dependent branches.
Edward Lemurda4b6c62020-02-13 00:28:40 +00001527 self.assertEqual(5, len(git_cl.CMDupload.mock_calls))
Edward Lemur1a83da12020-03-04 21:18:36 +00001528 self.assertIn(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001529 'This command will checkout all dependent branches '
1530 'and run "git cl upload". Press Enter to continue, '
Edward Lemur1a83da12020-03-04 21:18:36 +00001531 'or Ctrl+C to abort',
1532 sys.stdout.getvalue())
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00001533 self.assertEqual(0, ret)
rmistry@google.com2dd99862015-06-22 12:22:18 +00001534
tandrii@chromium.org65874e12016-03-04 12:03:02 +00001535 def test_gerrit_change_id(self):
1536 self.calls = [
1537 ((['git', 'write-tree'], ),
1538 'hashtree'),
1539 ((['git', 'rev-parse', 'HEAD~0'], ),
1540 'branch-parent'),
1541 ((['git', 'var', 'GIT_AUTHOR_IDENT'], ),
1542 'A B <a@b.org> 1456848326 +0100'),
1543 ((['git', 'var', 'GIT_COMMITTER_IDENT'], ),
1544 'C D <c@d.org> 1456858326 +0100'),
1545 ((['git', 'hash-object', '-t', 'commit', '--stdin'], ),
1546 'hashchange'),
1547 ]
1548 change_id = git_cl.GenerateGerritChangeId('line1\nline2\n')
1549 self.assertEqual(change_id, 'Ihashchange')
1550
Edward Lesmes8170c292021-03-19 20:04:43 +00001551 @mock.patch('gerrit_util.IsCodeOwnersEnabledOnHost')
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001552 @mock.patch('git_cl.Settings.GetBugPrefix')
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001553 @mock.patch('git_cl.Changelist.FetchDescription')
1554 @mock.patch('git_cl.Changelist.GetBranch')
Edward Lesmes1eaaab52021-03-02 23:52:54 +00001555 @mock.patch('git_cl.Changelist.GetCommonAncestorWithUpstream')
Edward Lesmese1576912021-02-16 21:53:34 +00001556 @mock.patch('git_cl.Changelist.GetGerritHost')
1557 @mock.patch('git_cl.Changelist.GetGerritProject')
1558 @mock.patch('git_cl.Changelist.GetRemoteBranch')
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001559 @mock.patch('owners_client.OwnersClient.BatchListOwners')
1560 def getDescriptionForUploadTest(
Edward Lesmese1576912021-02-16 21:53:34 +00001561 self, mockBatchListOwners=None, mockGetRemoteBranch=None,
Edward Lesmes1eaaab52021-03-02 23:52:54 +00001562 mockGetGerritProject=None, mockGetGerritHost=None,
1563 mockGetCommonAncestorWithUpstream=None, mockGetBranch=None,
Edward Lesmese1576912021-02-16 21:53:34 +00001564 mockFetchDescription=None, mockGetBugPrefix=None,
Edward Lesmes8170c292021-03-19 20:04:43 +00001565 mockIsCodeOwnersEnabledOnHost=None,
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001566 initial_description='desc', bug=None, fixed=None, branch='branch',
1567 reviewers=None, tbrs=None, add_owners_to=None,
1568 expected_description='desc'):
1569 reviewers = reviewers or []
1570 tbrs = tbrs or []
1571 owners_by_path = {
1572 'a': ['a@example.com'],
1573 'b': ['b@example.com'],
1574 'c': ['c@example.com'],
1575 }
Edward Lesmes8170c292021-03-19 20:04:43 +00001576 mockIsCodeOwnersEnabledOnHost.return_value = True
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001577 mockGetBranch.return_value = branch
1578 mockGetBugPrefix.return_value = 'prefix'
Edward Lesmes1eaaab52021-03-02 23:52:54 +00001579 mockGetCommonAncestorWithUpstream.return_value = 'upstream'
Edward Lesmese1576912021-02-16 21:53:34 +00001580 mockGetRemoteBranch.return_value = ('origin', 'refs/remotes/origin/main')
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001581 mockFetchDescription.return_value = 'desc'
1582 mockBatchListOwners.side_effect = lambda ps: {
1583 p: owners_by_path.get(p)
1584 for p in ps
1585 }
1586
1587 cl = git_cl.Changelist(issue=1234)
1588 actual = cl._GetDescriptionForUpload(
1589 options=mock.Mock(
1590 bug=bug,
1591 fixed=fixed,
1592 reviewers=reviewers,
1593 tbrs=tbrs,
1594 add_owners_to=add_owners_to),
1595 git_diff_args=None,
1596 files=list(owners_by_path))
1597 self.assertEqual(expected_description, actual.description)
1598
1599 def testGetDescriptionForUpload(self):
1600 self.getDescriptionForUploadTest()
1601
1602 def testGetDescriptionForUpload_Bug(self):
1603 self.getDescriptionForUploadTest(
1604 bug='1234',
1605 expected_description='\n'.join([
1606 'desc',
1607 '',
1608 'Bug: prefix:1234',
1609 ]))
1610
1611 def testGetDescriptionForUpload_Fixed(self):
1612 self.getDescriptionForUploadTest(
1613 fixed='1234',
1614 expected_description='\n'.join([
1615 'desc',
1616 '',
1617 'Fixed: prefix:1234',
1618 ]))
1619
1620
1621 def testGetDescriptionForUpload_BugFromBranch(self):
1622 self.getDescriptionForUploadTest(
1623 branch='bug-1234',
1624 expected_description='\n'.join([
1625 'desc',
1626 '',
1627 'Bug: prefix:1234',
1628 ]))
1629
1630 def testGetDescriptionForUpload_FixedFromBranch(self):
1631 self.getDescriptionForUploadTest(
1632 branch='fix-1234',
1633 expected_description='\n'.join([
1634 'desc',
1635 '',
1636 'Fixed: prefix:1234',
1637 ]))
1638
1639 def testGetDescriptionForUpload_AddOwnersToR(self):
1640 self.getDescriptionForUploadTest(
1641 reviewers=['a@example.com'],
1642 tbrs=['b@example.com'],
1643 add_owners_to='R',
1644 expected_description='\n'.join([
1645 'desc',
1646 '',
1647 'R=a@example.com, c@example.com',
1648 'TBR=b@example.com',
1649 ]))
1650
1651 def testGetDescriptionForUpload_AddOwnersToTBR(self):
1652 self.getDescriptionForUploadTest(
1653 reviewers=['a@example.com'],
1654 tbrs=['b@example.com'],
1655 add_owners_to='TBR',
1656 expected_description='\n'.join([
1657 'desc',
1658 '',
1659 'R=a@example.com',
1660 'TBR=b@example.com, c@example.com',
1661 ]))
1662
1663 def testGetDescriptionForUpload_AddOwnersToNoOwnersNeeded(self):
1664 self.getDescriptionForUploadTest(
1665 reviewers=['a@example.com', 'c@example.com'],
1666 tbrs=['b@example.com'],
1667 add_owners_to='TBR',
1668 expected_description='\n'.join([
1669 'desc',
1670 '',
1671 'R=a@example.com, c@example.com',
1672 'TBR=b@example.com',
1673 ]))
1674
1675 def testGetDescriptionForUpload_Reviewers(self):
1676 self.getDescriptionForUploadTest(
1677 reviewers=['a@example.com', 'b@example.com'],
1678 expected_description='\n'.join([
1679 'desc',
1680 '',
1681 'R=a@example.com, b@example.com',
1682 ]))
1683
1684 def testGetDescriptionForUpload_TBRs(self):
1685 self.getDescriptionForUploadTest(
1686 tbrs=['a@example.com', 'b@example.com'],
1687 expected_description='\n'.join([
1688 'desc',
1689 '',
1690 'TBR=a@example.com, b@example.com',
1691 ]))
1692
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001693 def test_desecription_append_footer(self):
1694 for init_desc, footer_line, expected_desc in [
1695 # Use unique desc first lines for easy test failure identification.
1696 ('foo', 'R=one', 'foo\n\nR=one'),
1697 ('foo\n\nR=one', 'BUG=', 'foo\n\nR=one\nBUG='),
1698 ('foo\n\nR=one', 'Change-Id: Ixx', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1699 ('foo\n\nChange-Id: Ixx', 'R=one', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1700 ('foo\n\nR=one\n\nChange-Id: Ixx', 'TBR=two',
1701 'foo\n\nR=one\nTBR=two\n\nChange-Id: Ixx'),
1702 ('foo\n\nR=one\n\nChange-Id: Ixx', 'Foo-Bar: baz',
1703 'foo\n\nR=one\n\nChange-Id: Ixx\nFoo-Bar: baz'),
1704 ('foo\n\nChange-Id: Ixx', 'Foo-Bak: baz',
1705 'foo\n\nChange-Id: Ixx\nFoo-Bak: baz'),
1706 ('foo', 'Change-Id: Ixx', 'foo\n\nChange-Id: Ixx'),
1707 ]:
1708 desc = git_cl.ChangeDescription(init_desc)
1709 desc.append_footer(footer_line)
1710 self.assertEqual(desc.description, expected_desc)
1711
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001712 def test_update_reviewers(self):
1713 data = [
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001714 ('foo', [], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001715 'foo'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001716 ('foo\nR=xx', [], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001717 'foo\nR=xx'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001718 ('foo\nTBR=xx', [], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001719 'foo\nTBR=xx'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001720 ('foo', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001721 'foo\n\nR=a@c'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001722 ('foo\nR=xx', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001723 'foo\n\nR=a@c, xx'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001724 ('foo\nTBR=xx', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001725 'foo\n\nR=a@c\nTBR=xx'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001726 ('foo\nTBR=xx\nR=yy', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001727 'foo\n\nR=a@c, yy\nTBR=xx'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001728 ('foo\nBUG=', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001729 'foo\nBUG=\nR=a@c'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001730 ('foo\nR=xx\nTBR=yy\nR=bar', ['a@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001731 'foo\n\nR=a@c, bar, xx\nTBR=yy'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001732 ('foo', ['a@c', 'b@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001733 'foo\n\nR=a@c, b@c'),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001734 ('foo\nBar\n\nR=\nBUG=', ['c@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001735 'foo\nBar\n\nR=c@c\nBUG='),
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001736 ('foo\nBar\n\nR=\nBUG=\nR=', ['c@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001737 'foo\nBar\n\nR=c@c\nBUG='),
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001738 # Same as the line before, but full of whitespaces.
1739 (
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001740 'foo\nBar\n\n R = \n BUG = \n R = ', ['c@c'], [],
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001741 'foo\nBar\n\nR=c@c\n BUG =',
1742 ),
1743 # Whitespaces aren't interpreted as new lines.
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001744 ('foo BUG=allo R=joe ', ['c@c'], [],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001745 'foo BUG=allo R=joe\n\nR=c@c'),
1746 # Redundant TBRs get promoted to Rs
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001747 ('foo\n\nR=a@c\nTBR=t@c', ['b@c', 'a@c'], ['a@c', 't@c'],
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001748 'foo\n\nR=a@c, b@c\nTBR=t@c'),
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001749 ]
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001750 expected = [i[-1] for i in data]
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001751 actual = []
Stephen Martinis1c3c9392021-01-07 02:42:33 +00001752 for orig, reviewers, tbrs, _expected in data:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001753 obj = git_cl.ChangeDescription(orig)
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001754 obj.update_reviewers(reviewers, tbrs)
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001755 actual.append(obj.description)
1756 self.assertEqual(expected, actual)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001757
Nodir Turakulov23b82142017-11-16 11:04:25 -08001758 def test_get_hash_tags(self):
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001759 self.calls = [
1760 ((['git', 'show-branch', 'refs/remotes/origin/main'], ),
1761 callError(1)),
1762 ] * 9
Nodir Turakulov23b82142017-11-16 11:04:25 -08001763 cases = [
1764 ('', []),
1765 ('a', []),
1766 ('[a]', ['a']),
1767 ('[aa]', ['aa']),
1768 ('[a ]', ['a']),
1769 ('[a- ]', ['a']),
1770 ('[a- b]', ['a-b']),
1771 ('[a--b]', ['a-b']),
1772 ('[a', []),
1773 ('[a]x', ['a']),
1774 ('[aa]x', ['aa']),
1775 ('[a b]', ['a-b']),
1776 ('[a b]', ['a-b']),
1777 ('[a__b]', ['a-b']),
1778 ('[a] x', ['a']),
1779 ('[a][b]', ['a', 'b']),
1780 ('[a] [b]', ['a', 'b']),
1781 ('[a][b]x', ['a', 'b']),
1782 ('[a][b] x', ['a', 'b']),
1783 ('[a]\n[b]', ['a']),
1784 ('[a\nb]', []),
1785 ('[a][', ['a']),
1786 ('Revert "[a] feature"', ['a']),
1787 ('Reland "[a] feature"', ['a']),
1788 ('Revert: [a] feature', ['a']),
1789 ('Reland: [a] feature', ['a']),
1790 ('Revert "Reland: [a] feature"', ['a']),
1791 ('Foo: feature', ['foo']),
1792 ('Foo Bar: feature', ['foo-bar']),
Anthony Polito02b5af32019-12-02 19:49:47 +00001793 ('Change Foo::Bar', []),
1794 ('Foo: Change Foo::Bar', ['foo']),
Nodir Turakulov23b82142017-11-16 11:04:25 -08001795 ('Revert "Foo bar: feature"', ['foo-bar']),
1796 ('Reland "Foo bar: feature"', ['foo-bar']),
1797 ]
1798 for desc, expected in cases:
1799 change_desc = git_cl.ChangeDescription(desc)
1800 actual = change_desc.get_hash_tags()
1801 self.assertEqual(
1802 actual,
1803 expected,
1804 'GetHashTags(%r) == %r, expected %r' % (desc, actual, expected))
1805
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001806 self.assertEqual(None, git_cl.GetTargetRef('origin', None, 'master'))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001807 self.assertEqual(None, git_cl.GetTargetRef(None,
1808 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001809 'master'))
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001810
wittman@chromium.org455dc922015-01-26 20:15:50 +00001811 # Check default target refs for branches.
1812 self.assertEqual('refs/heads/master',
1813 git_cl.GetTargetRef('origin', 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001814 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001815 self.assertEqual('refs/heads/master',
1816 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkgr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001817 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001818 self.assertEqual('refs/heads/master',
1819 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkcr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001820 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001821 self.assertEqual('refs/branch-heads/123',
1822 git_cl.GetTargetRef('origin',
1823 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001824 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001825 self.assertEqual('refs/diff/test',
1826 git_cl.GetTargetRef('origin',
1827 'refs/remotes/origin/refs/diff/test',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001828 None))
rmistry@google.comc68112d2015-03-03 12:48:06 +00001829 self.assertEqual('refs/heads/chrome/m42',
1830 git_cl.GetTargetRef('origin',
1831 'refs/remotes/origin/chrome/m42',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001832 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001833
1834 # Check target refs for user-specified target branch.
1835 for branch in ('branch-heads/123', 'remotes/branch-heads/123',
1836 'refs/remotes/branch-heads/123'):
1837 self.assertEqual('refs/branch-heads/123',
1838 git_cl.GetTargetRef('origin',
1839 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001840 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001841 for branch in ('origin/master', 'remotes/origin/master',
1842 'refs/remotes/origin/master'):
1843 self.assertEqual('refs/heads/master',
1844 git_cl.GetTargetRef('origin',
1845 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001846 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001847 for branch in ('master', 'heads/master', 'refs/heads/master'):
1848 self.assertEqual('refs/heads/master',
1849 git_cl.GetTargetRef('origin',
1850 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001851 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001852
Edward Lemurda4b6c62020-02-13 00:28:40 +00001853 @mock.patch('git_common.is_dirty_git_tree', return_value=True)
1854 def test_patch_when_dirty(self, *_mocks):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001855 # Patch when local tree is dirty.
wychen@chromium.orga872e752015-04-28 23:42:18 +00001856 self.assertNotEqual(git_cl.main(['patch', '123456']), 0)
1857
Edward Lemur85153282020-02-14 22:06:29 +00001858 def assertIssueAndPatchset(
1859 self, branch='master', issue='123456', patchset='7',
1860 git_short_host='chromium'):
1861 self.assertEqual(
Edward Lemur26964072020-02-19 19:18:51 +00001862 issue, scm.GIT.GetBranchConfig('', branch, 'gerritissue'))
Edward Lemur85153282020-02-14 22:06:29 +00001863 self.assertEqual(
Edward Lemur26964072020-02-19 19:18:51 +00001864 patchset, scm.GIT.GetBranchConfig('', branch, 'gerritpatchset'))
Edward Lemur85153282020-02-14 22:06:29 +00001865 self.assertEqual(
1866 'https://%s-review.googlesource.com' % git_short_host,
Edward Lemur26964072020-02-19 19:18:51 +00001867 scm.GIT.GetBranchConfig('', branch, 'gerritserver'))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001868
Edward Lemur85153282020-02-14 22:06:29 +00001869 def _patch_common(self, git_short_host='chromium'):
Edward Lesmes50da7702020-03-30 19:23:43 +00001870 mock.patch('scm.GIT.ResolveCommit', return_value='deadbeef').start()
Edward Lemur26964072020-02-19 19:18:51 +00001871 self.mockGit.config['remote.origin.url'] = (
1872 'https://%s.googlesource.com/my/repo' % git_short_host)
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001873 gerrit_util.GetChangeDetail.return_value = {
1874 'current_revision': '7777777777',
1875 'revisions': {
1876 '1111111111': {
1877 '_number': 1,
1878 'fetch': {'http': {
1879 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1880 'ref': 'refs/changes/56/123456/1',
1881 }},
1882 },
1883 '7777777777': {
1884 '_number': 7,
1885 'fetch': {'http': {
1886 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1887 'ref': 'refs/changes/56/123456/7',
1888 }},
1889 },
1890 },
1891 }
wychen@chromium.orga872e752015-04-28 23:42:18 +00001892
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001893 def test_patch_gerrit_default(self):
Edward Lemur85153282020-02-14 22:06:29 +00001894 self._patch_common()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001895 self.calls += [
1896 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1897 'refs/changes/56/123456/7'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001898 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001899 ]
1900 self.assertEqual(git_cl.main(['patch', '123456']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001901 self.assertIssueAndPatchset()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001902
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001903 def test_patch_gerrit_new_branch(self):
Edward Lemur85153282020-02-14 22:06:29 +00001904 self._patch_common()
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001905 self.calls += [
1906 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1907 'refs/changes/56/123456/7'],), ''),
1908 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001909 ]
Edward Lemur85153282020-02-14 22:06:29 +00001910 self.assertEqual(git_cl.main(['patch', '-b', 'feature', '123456']), 0)
1911 self.assertIssueAndPatchset(branch='feature')
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001912
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001913 def test_patch_gerrit_force(self):
Edward Lemur85153282020-02-14 22:06:29 +00001914 self._patch_common('host')
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001915 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001916 ((['git', 'fetch', 'https://host.googlesource.com/my/repo',
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001917 'refs/changes/56/123456/7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001918 ((['git', 'reset', '--hard', 'FETCH_HEAD'],), ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001919 ]
Edward Lemur52969c92020-02-06 18:15:28 +00001920 self.assertEqual(git_cl.main(['patch', '123456', '--force']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001921 self.assertIssueAndPatchset(git_short_host='host')
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001922
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001923 def test_patch_gerrit_guess_by_url(self):
Edward Lemur85153282020-02-14 22:06:29 +00001924 self._patch_common('else')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001925 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001926 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001927 'refs/changes/56/123456/1'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001928 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001929 ]
1930 self.assertEqual(git_cl.main(
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001931 ['patch', 'https://else-review.googlesource.com/#/c/123456/1']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001932 self.assertIssueAndPatchset(patchset='1', git_short_host='else')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001933
Aaron Gable697a91b2018-01-19 15:20:15 -08001934 def test_patch_gerrit_guess_by_url_with_repo(self):
Edward Lemur85153282020-02-14 22:06:29 +00001935 self._patch_common('else')
Aaron Gable697a91b2018-01-19 15:20:15 -08001936 self.calls += [
1937 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
1938 'refs/changes/56/123456/1'],), ''),
1939 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
Aaron Gable697a91b2018-01-19 15:20:15 -08001940 ]
1941 self.assertEqual(git_cl.main(
1942 ['patch', 'https://else-review.googlesource.com/c/my/repo/+/123456/1']),
1943 0)
Edward Lemur85153282020-02-14 22:06:29 +00001944 self.assertIssueAndPatchset(patchset='1', git_short_host='else')
Aaron Gable697a91b2018-01-19 15:20:15 -08001945
Edward Lemurd55c5072020-02-20 01:09:07 +00001946 @mock.patch('sys.stderr', StringIO())
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001947 def test_patch_gerrit_conflict(self):
Edward Lemur85153282020-02-14 22:06:29 +00001948 self._patch_common()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001949 self.calls += [
1950 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001951 'refs/changes/56/123456/7'],), ''),
tandrii5d48c322016-08-18 16:19:37 -07001952 ((['git', 'cherry-pick', 'FETCH_HEAD'],), CERR1),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001953 ]
1954 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001955 git_cl.main(['patch', '123456'])
Edward Lemurd55c5072020-02-20 01:09:07 +00001956 self.assertEqual(
1957 'Command "git cherry-pick FETCH_HEAD" failed.\n\n',
1958 sys.stderr.getvalue())
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001959
Edward Lemurda4b6c62020-02-13 00:28:40 +00001960 @mock.patch(
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001961 'gerrit_util.GetChangeDetail',
Edward Lemurda4b6c62020-02-13 00:28:40 +00001962 side_effect=gerrit_util.GerritError(404, ''))
Edward Lemurd55c5072020-02-20 01:09:07 +00001963 @mock.patch('sys.stderr', StringIO())
Edward Lemurda4b6c62020-02-13 00:28:40 +00001964 def test_patch_gerrit_not_exists(self, *_mocks):
Edward Lemur26964072020-02-19 19:18:51 +00001965 self.mockGit.config['remote.origin.url'] = (
1966 'https://chromium.googlesource.com/my/repo')
tandriic2405f52016-10-10 08:13:15 -07001967 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001968 self.assertEqual(1, git_cl.main(['patch', '123456']))
Edward Lemurd55c5072020-02-20 01:09:07 +00001969 self.assertEqual(
1970 'change 123456 at https://chromium-review.googlesource.com does not '
1971 'exist or you have no access to it\n',
1972 sys.stderr.getvalue())
tandriic2405f52016-10-10 08:13:15 -07001973
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001974 def _checkout_calls(self):
1975 return [
1976 ((['git', 'config', '--local', '--get-regexp',
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001977 'branch\\..*\\.gerritissue'], ),
1978 ('branch.ger-branch.gerritissue 123456\n'
1979 'branch.gbranch654.gerritissue 654321\n')),
1980 ]
1981
1982 def test_checkout_gerrit(self):
1983 """Tests git cl checkout <issue>."""
1984 self.calls = self._checkout_calls()
1985 self.calls += [((['git', 'checkout', 'ger-branch'], ), '')]
1986 self.assertEqual(0, git_cl.main(['checkout', '123456']))
1987
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001988 def test_checkout_not_found(self):
1989 """Tests git cl checkout <issue>."""
1990 self.calls = self._checkout_calls()
1991 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1992
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001993 def test_checkout_no_branch_issues(self):
1994 """Tests git cl checkout <issue>."""
1995 self.calls = [
1996 ((['git', 'config', '--local', '--get-regexp',
tandrii5d48c322016-08-18 16:19:37 -07001997 'branch\\..*\\.gerritissue'], ), CERR1),
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001998 ]
1999 self.assertEqual(1, git_cl.main(['checkout', '99999']))
2000
Edward Lemur26964072020-02-19 19:18:51 +00002001 def _test_gerrit_ensure_authenticated_common(self, auth):
Edward Lemur1a83da12020-03-04 21:18:36 +00002002 mock.patch(
Edward Lesmesae3586b2020-03-23 21:21:14 +00002003 'gclient_utils.AskForData',
Edward Lemur1a83da12020-03-04 21:18:36 +00002004 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002005 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
2006 CookiesAuthenticatorMockFactory(hosts_with_creds=auth)).start()
Edward Lemur26964072020-02-19 19:18:51 +00002007 self.mockGit.config['remote.origin.url'] = (
2008 'https://chromium.googlesource.com/my/repo')
Edward Lemurf38bc172019-09-03 21:02:13 +00002009 cl = git_cl.Changelist()
tandrii@chromium.org28253532016-04-14 13:46:56 +00002010 cl.branch = 'master'
2011 cl.branchref = 'refs/heads/master'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002012 return cl
2013
Edward Lemurd55c5072020-02-20 01:09:07 +00002014 @mock.patch('sys.stderr', StringIO())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002015 def test_gerrit_ensure_authenticated_missing(self):
2016 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002017 'chromium.googlesource.com': ('git-is.ok', '', 'but gerrit is missing'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002018 })
Edward Lemurd55c5072020-02-20 01:09:07 +00002019 with self.assertRaises(SystemExitMock):
2020 cl.EnsureAuthenticated(force=False)
2021 self.assertEqual(
2022 'Credentials for the following hosts are required:\n'
2023 ' chromium-review.googlesource.com\n'
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002024 'These are read from ~%(sep)s.gitcookies '
2025 '(or legacy ~%(sep)s%(netrc)s)\n'
Edward Lemurd55c5072020-02-20 01:09:07 +00002026 'You can (re)generate your credentials by visiting '
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002027 'https://chromium-review.googlesource.com/new-password\n' % {
2028 'sep': os.sep,
2029 'netrc': NETRC_FILENAME,
2030 }, sys.stderr.getvalue())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002031
2032 def test_gerrit_ensure_authenticated_conflict(self):
2033 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002034 'chromium.googlesource.com':
2035 ('git-one.example.com', None, 'secret1'),
2036 'chromium-review.googlesource.com':
2037 ('git-other.example.com', None, 'secret2'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002038 })
2039 self.calls.append(
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002040 (('ask_for_data', 'If you know what you are doing '
2041 'press Enter to continue, or Ctrl+C to abort'), ''))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002042 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2043
2044 def test_gerrit_ensure_authenticated_ok(self):
2045 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002046 'chromium.googlesource.com':
2047 ('git-same.example.com', None, 'secret'),
2048 'chromium-review.googlesource.com':
2049 ('git-same.example.com', None, 'secret'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002050 })
2051 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2052
tandrii@chromium.org28253532016-04-14 13:46:56 +00002053 def test_gerrit_ensure_authenticated_skipped(self):
Edward Lemur26964072020-02-19 19:18:51 +00002054 self.mockGit.config['gerrit.skip-ensure-authenticated'] = 'true'
2055 cl = self._test_gerrit_ensure_authenticated_common(auth={})
tandrii@chromium.org28253532016-04-14 13:46:56 +00002056 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2057
Eric Boren2fb63102018-10-05 13:05:03 +00002058 def test_gerrit_ensure_authenticated_bearer_token(self):
2059 cl = self._test_gerrit_ensure_authenticated_common(auth={
2060 'chromium.googlesource.com':
2061 ('', None, 'secret'),
2062 'chromium-review.googlesource.com':
2063 ('', None, 'secret'),
2064 })
2065 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2066 header = gerrit_util.CookiesAuthenticator().get_auth_header(
2067 'chromium.googlesource.com')
2068 self.assertTrue('Bearer' in header)
2069
Daniel Chengcf6269b2019-05-18 01:02:12 +00002070 def test_gerrit_ensure_authenticated_non_https(self):
Edward Lemur26964072020-02-19 19:18:51 +00002071 self.mockGit.config['remote.origin.url'] = 'custom-scheme://repo'
Daniel Chengcf6269b2019-05-18 01:02:12 +00002072 self.calls = [
Josip906bfde2020-01-31 22:38:49 +00002073 (('logging.warning',
2074 'Ignoring branch %(branch)s with non-https remote '
2075 '%(remote)s', {
2076 'branch': 'master',
2077 'remote': 'custom-scheme://repo'}
2078 ), None),
Daniel Chengcf6269b2019-05-18 01:02:12 +00002079 ]
Edward Lemurda4b6c62020-02-13 00:28:40 +00002080 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
2081 CookiesAuthenticatorMockFactory(hosts_with_creds={})).start()
2082 mock.patch('logging.warning',
2083 lambda *a: self._mocked_call('logging.warning', *a)).start()
Edward Lemurf38bc172019-09-03 21:02:13 +00002084 cl = git_cl.Changelist()
Daniel Chengcf6269b2019-05-18 01:02:12 +00002085 cl.branch = 'master'
2086 cl.branchref = 'refs/heads/master'
2087 cl.lookedup_issue = True
2088 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2089
Florian Mayerae510e82020-01-30 21:04:48 +00002090 def test_gerrit_ensure_authenticated_non_url(self):
Edward Lemur26964072020-02-19 19:18:51 +00002091 self.mockGit.config['remote.origin.url'] = (
2092 'git@somehost.example:foo/bar.git')
Florian Mayerae510e82020-01-30 21:04:48 +00002093 self.calls = [
Josip906bfde2020-01-31 22:38:49 +00002094 (('logging.error',
2095 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
2096 'but it doesn\'t exist.', {
2097 'remote': 'origin',
2098 'branch': 'master',
2099 'url': 'git@somehost.example:foo/bar.git'}
2100 ), None),
Florian Mayerae510e82020-01-30 21:04:48 +00002101 ]
Edward Lemurda4b6c62020-02-13 00:28:40 +00002102 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
2103 CookiesAuthenticatorMockFactory(hosts_with_creds={})).start()
2104 mock.patch('logging.error',
2105 lambda *a: self._mocked_call('logging.error', *a)).start()
Florian Mayerae510e82020-01-30 21:04:48 +00002106 cl = git_cl.Changelist()
2107 cl.branch = 'master'
2108 cl.branchref = 'refs/heads/master'
2109 cl.lookedup_issue = True
2110 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2111
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002112 def _cmd_set_commit_gerrit_common(self, vote, notify=None):
Edward Lemur85153282020-02-14 22:06:29 +00002113 self.mockGit.config['branch.master.gerritissue'] = '123'
2114 self.mockGit.config['branch.master.gerritserver'] = (
2115 'https://chromium-review.googlesource.com')
Edward Lemur26964072020-02-19 19:18:51 +00002116 self.mockGit.config['remote.origin.url'] = (
2117 'https://chromium.googlesource.com/infra/infra')
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002118 self.calls = [
Edward Lemurda4b6c62020-02-13 00:28:40 +00002119 (('SetReview', 'chromium-review.googlesource.com',
2120 'infra%2Finfra~123', None,
2121 {'Commit-Queue': vote}, notify, None), ''),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002122 ]
tandriid9e5ce52016-07-13 02:32:59 -07002123
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00002124 def _cmd_set_quick_run_gerrit(self):
2125 self.mockGit.config['branch.master.gerritissue'] = '123'
2126 self.mockGit.config['branch.master.gerritserver'] = (
2127 'https://chromium-review.googlesource.com')
2128 self.mockGit.config['remote.origin.url'] = (
2129 'https://chromium.googlesource.com/infra/infra')
2130 self.calls = [
2131 (('SetReview', 'chromium-review.googlesource.com',
2132 'infra%2Finfra~123', None,
2133 {'Commit-Queue': 1, 'Quick-Run': 1}, None, None), ''),
2134 ]
2135
tandriid9e5ce52016-07-13 02:32:59 -07002136 def test_cmd_set_commit_gerrit_clear(self):
2137 self._cmd_set_commit_gerrit_common(0)
2138 self.assertEqual(0, git_cl.main(['set-commit', '-c']))
2139
2140 def test_cmd_set_commit_gerrit_dry(self):
Aaron Gable75e78722017-06-09 10:40:16 -07002141 self._cmd_set_commit_gerrit_common(1, notify=False)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002142 self.assertEqual(0, git_cl.main(['set-commit', '-d']))
2143
tandriid9e5ce52016-07-13 02:32:59 -07002144 def test_cmd_set_commit_gerrit(self):
2145 self._cmd_set_commit_gerrit_common(2)
2146 self.assertEqual(0, git_cl.main(['set-commit']))
2147
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00002148 def test_cmd_set_quick_run_gerrit(self):
2149 self._cmd_set_quick_run_gerrit()
2150 self.assertEqual(0, git_cl.main(['set-commit', '-q']))
2151
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002152 def test_description_display(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002153 mock.patch('git_cl.Changelist', ChangelistMock).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002154 ChangelistMock.desc = 'foo\n'
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002155
2156 self.assertEqual(0, git_cl.main(['description', '-d']))
Edward Lemurda4b6c62020-02-13 00:28:40 +00002157 self.assertEqual('foo\n', sys.stdout.getvalue())
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002158
Edward Lemurda4b6c62020-02-13 00:28:40 +00002159 @mock.patch('sys.stderr', StringIO())
iannucci3c972b92016-08-17 13:24:10 -07002160 def test_StatusFieldOverrideIssueMissingArgs(self):
iannucci3c972b92016-08-17 13:24:10 -07002161 try:
2162 self.assertEqual(git_cl.main(['status', '--issue', '1']), 0)
Edward Lemurd55c5072020-02-20 01:09:07 +00002163 except SystemExitMock:
Edward Lemur6c6827c2020-02-06 21:15:18 +00002164 self.assertIn(
Edward Lemurda4b6c62020-02-13 00:28:40 +00002165 '--field must be given when --issue is set.', sys.stderr.getvalue())
iannucci3c972b92016-08-17 13:24:10 -07002166
2167 def test_StatusFieldOverrideIssue(self):
iannucci3c972b92016-08-17 13:24:10 -07002168 def assertIssue(cl_self, *_args):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002169 self.assertEqual(cl_self.issue, 1)
iannucci3c972b92016-08-17 13:24:10 -07002170 return 'foobar'
2171
Edward Lemurda4b6c62020-02-13 00:28:40 +00002172 mock.patch('git_cl.Changelist.FetchDescription', assertIssue).start()
iannuccie53c9352016-08-17 14:40:40 -07002173 self.assertEqual(
Edward Lemur52969c92020-02-06 18:15:28 +00002174 git_cl.main(['status', '--issue', '1', '--field', 'desc']),
iannuccie53c9352016-08-17 14:40:40 -07002175 0)
Edward Lemurda4b6c62020-02-13 00:28:40 +00002176 self.assertEqual(sys.stdout.getvalue(), 'foobar\n')
iannucci3c972b92016-08-17 13:24:10 -07002177
iannuccie53c9352016-08-17 14:40:40 -07002178 def test_SetCloseOverrideIssue(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002179
iannuccie53c9352016-08-17 14:40:40 -07002180 def assertIssue(cl_self, *_args):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002181 self.assertEqual(cl_self.issue, 1)
iannuccie53c9352016-08-17 14:40:40 -07002182 return 'foobar'
2183
Edward Lemurda4b6c62020-02-13 00:28:40 +00002184 mock.patch('git_cl.Changelist.FetchDescription', assertIssue).start()
2185 mock.patch('git_cl.Changelist.CloseIssue', lambda *_: None).start()
iannuccie53c9352016-08-17 14:40:40 -07002186 self.assertEqual(
Edward Lemur52969c92020-02-06 18:15:28 +00002187 git_cl.main(['set-close', '--issue', '1']), 0)
iannuccie53c9352016-08-17 14:40:40 -07002188
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002189 def test_description(self):
Edward Lemur26964072020-02-19 19:18:51 +00002190 self.mockGit.config['remote.origin.url'] = (
2191 'https://chromium.googlesource.com/my/repo')
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002192 gerrit_util.GetChangeDetail.return_value = {
2193 'current_revision': 'sha1',
2194 'revisions': {'sha1': {
2195 'commit': {'message': 'foobar'},
2196 }},
2197 }
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002198 self.assertEqual(0, git_cl.main([
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002199 'description',
2200 'https://chromium-review.googlesource.com/c/my/repo/+/123123',
2201 '-d']))
Edward Lemurda4b6c62020-02-13 00:28:40 +00002202 self.assertEqual('foobar\n', sys.stdout.getvalue())
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002203
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002204 def test_description_set_raw(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002205 mock.patch('git_cl.Changelist', ChangelistMock).start()
2206 mock.patch('git_cl.sys.stdin', StringIO('hihi')).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002207
2208 self.assertEqual(0, git_cl.main(['description', '-n', 'hihi']))
2209 self.assertEqual('hihi', ChangelistMock.desc)
2210
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002211 def test_description_appends_bug_line(self):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002212 current_desc = 'Some.\n\nChange-Id: xxx'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002213
2214 def RunEditor(desc, _, **kwargs):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002215 self.assertEqual(
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002216 '# Enter a description of the change.\n'
2217 '# This will be displayed on the codereview site.\n'
2218 '# The first line will also be used as the subject of the review.\n'
2219 '#--------------------This line is 72 characters long'
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002220 '--------------------\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -07002221 'Some.\n\nChange-Id: xxx\nBug: ',
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002222 desc)
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002223 # Simulate user changing something.
Aaron Gable3a16ed12017-03-23 10:51:55 -07002224 return 'Some.\n\nChange-Id: xxx\nBug: 123'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002225
Edward Lemur6c6827c2020-02-06 21:15:18 +00002226 def UpdateDescription(_, desc, force=False):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002227 self.assertEqual(desc, 'Some.\n\nChange-Id: xxx\nBug: 123')
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002228
Edward Lemurda4b6c62020-02-13 00:28:40 +00002229 mock.patch('git_cl.Changelist.FetchDescription',
2230 lambda *args: current_desc).start()
2231 mock.patch('git_cl.Changelist.UpdateDescription',
2232 UpdateDescription).start()
2233 mock.patch('git_cl.gclient_utils.RunEditor', RunEditor).start()
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002234
Edward Lemur85153282020-02-14 22:06:29 +00002235 self.mockGit.config['branch.master.gerritissue'] = '123'
Edward Lemur52969c92020-02-06 18:15:28 +00002236 self.assertEqual(0, git_cl.main(['description']))
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002237
Dan Beamd8b04ca2019-10-10 21:23:26 +00002238 def test_description_does_not_append_bug_line_if_fixed_is_present(self):
2239 current_desc = 'Some.\n\nFixed: 123\nChange-Id: xxx'
2240
2241 def RunEditor(desc, _, **kwargs):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002242 self.assertEqual(
Dan Beamd8b04ca2019-10-10 21:23:26 +00002243 '# Enter a description of the change.\n'
2244 '# This will be displayed on the codereview site.\n'
2245 '# The first line will also be used as the subject of the review.\n'
2246 '#--------------------This line is 72 characters long'
2247 '--------------------\n'
2248 'Some.\n\nFixed: 123\nChange-Id: xxx',
2249 desc)
2250 return desc
2251
Edward Lemurda4b6c62020-02-13 00:28:40 +00002252 mock.patch('git_cl.Changelist.FetchDescription',
2253 lambda *args: current_desc).start()
2254 mock.patch('git_cl.gclient_utils.RunEditor', RunEditor).start()
Dan Beamd8b04ca2019-10-10 21:23:26 +00002255
Edward Lemur85153282020-02-14 22:06:29 +00002256 self.mockGit.config['branch.master.gerritissue'] = '123'
Edward Lemur52969c92020-02-06 18:15:28 +00002257 self.assertEqual(0, git_cl.main(['description']))
Dan Beamd8b04ca2019-10-10 21:23:26 +00002258
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002259 def test_description_set_stdin(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002260 mock.patch('git_cl.Changelist', ChangelistMock).start()
2261 mock.patch('git_cl.sys.stdin', StringIO('hi \r\n\t there\n\nman')).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002262
2263 self.assertEqual(0, git_cl.main(['description', '-n', '-']))
2264 self.assertEqual('hi\n\t there\n\nman', ChangelistMock.desc)
2265
kmarshall3bff56b2016-06-06 18:31:47 -07002266 def test_archive(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002267 self.calls = [
2268 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
Edward Lemurf38bc172019-09-03 21:02:13 +00002269 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002270 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002271 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],), ''),
Edward Lemurf38bc172019-09-03 21:02:13 +00002272 ((['git', 'branch', '-D', 'foo'],), '')
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002273 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002274
Edward Lemurda4b6c62020-02-13 00:28:40 +00002275 mock.patch('git_cl.get_cl_statuses',
kmarshall3bff56b2016-06-06 18:31:47 -07002276 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002277 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2278 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002279 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall3bff56b2016-06-06 18:31:47 -07002280
2281 self.assertEqual(0, git_cl.main(['archive', '-f']))
2282
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002283 def test_archive_tag_collision(self):
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002284 self.calls = [
2285 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2286 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2287 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],),
2288 'refs/tags/git-cl-archived-456-foo'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002289 ((['git', 'tag', 'git-cl-archived-456-foo-2', 'foo'],), ''),
2290 ((['git', 'branch', '-D', 'foo'],), '')
2291 ]
2292
Edward Lemurda4b6c62020-02-13 00:28:40 +00002293 mock.patch('git_cl.get_cl_statuses',
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002294 lambda branches, fine_grained, max_processes:
2295 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2296 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002297 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002298
2299 self.assertEqual(0, git_cl.main(['archive', '-f']))
2300
kmarshall3bff56b2016-06-06 18:31:47 -07002301 def test_archive_current_branch_fails(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002302 self.calls = [
2303 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2304 'refs/heads/master'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002305 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002306 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002307
Edward Lemurda4b6c62020-02-13 00:28:40 +00002308 mock.patch('git_cl.get_cl_statuses',
kmarshall9249e012016-08-23 12:02:16 -07002309 lambda branches, fine_grained, max_processes:
Edward Lemurda4b6c62020-02-13 00:28:40 +00002310 [(MockChangelistWithBranchAndIssue('master', 1),
2311 'closed')]).start()
kmarshall9249e012016-08-23 12:02:16 -07002312
2313 self.assertEqual(1, git_cl.main(['archive', '-f']))
2314
2315 def test_archive_dry_run(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002316 self.calls = [
2317 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2318 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002319 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002320 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002321
Edward Lemurda4b6c62020-02-13 00:28:40 +00002322 mock.patch('git_cl.get_cl_statuses',
kmarshall3bff56b2016-06-06 18:31:47 -07002323 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002324 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2325 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002326 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall3bff56b2016-06-06 18:31:47 -07002327
kmarshall9249e012016-08-23 12:02:16 -07002328 self.assertEqual(0, git_cl.main(['archive', '-f', '--dry-run']))
2329
2330 def test_archive_no_tags(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002331 self.calls = [
2332 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2333 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002334 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002335 ((['git', 'branch', '-D', 'foo'],), '')
2336 ]
kmarshall9249e012016-08-23 12:02:16 -07002337
Edward Lemurda4b6c62020-02-13 00:28:40 +00002338 mock.patch('git_cl.get_cl_statuses',
kmarshall9249e012016-08-23 12:02:16 -07002339 lambda branches, fine_grained, max_processes:
2340 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2341 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002342 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall9249e012016-08-23 12:02:16 -07002343
2344 self.assertEqual(0, git_cl.main(['archive', '-f', '--notags']))
kmarshall3bff56b2016-06-06 18:31:47 -07002345
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002346 def test_archive_tag_cleanup_on_branch_deletion_error(self):
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002347 self.calls = [
2348 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2349 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2350 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002351 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],),
2352 'refs/tags/git-cl-archived-456-foo'),
2353 ((['git', 'branch', '-D', 'foo'],), CERR1),
2354 ((['git', 'tag', '-d', 'git-cl-archived-456-foo'],),
2355 'refs/tags/git-cl-archived-456-foo'),
2356 ]
2357
Edward Lemurda4b6c62020-02-13 00:28:40 +00002358 mock.patch('git_cl.get_cl_statuses',
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002359 lambda branches, fine_grained, max_processes:
2360 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2361 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002362 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002363
2364 self.assertEqual(0, git_cl.main(['archive', '-f']))
2365
Tibor Goldschwendt7c5efb22020-03-25 01:23:54 +00002366 def test_archive_with_format(self):
2367 self.calls = [
2368 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'], ),
2369 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2370 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'], ), ''),
2371 ((['git', 'tag', 'archived/12-foo', 'foo'], ), ''),
2372 ((['git', 'branch', '-D', 'foo'], ), ''),
2373 ]
2374
2375 mock.patch('git_cl.get_cl_statuses',
2376 lambda branches, fine_grained, max_processes:
2377 [(MockChangelistWithBranchAndIssue('foo', 12), 'closed')]).start()
2378
2379 self.assertEqual(
2380 0, git_cl.main(['archive', '-f', '-p', 'archived/{issue}-{branch}']))
2381
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002382 def test_cmd_issue_erase_existing(self):
Edward Lemur85153282020-02-14 22:06:29 +00002383 self.mockGit.config['branch.master.gerritissue'] = '123'
2384 self.mockGit.config['branch.master.gerritserver'] = (
2385 'https://chromium-review.googlesource.com')
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002386 self.calls = [
Aaron Gableca01e2c2017-07-19 11:16:02 -07002387 ((['git', 'log', '-1', '--format=%B'],), 'This is a description'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002388 ]
2389 self.assertEqual(0, git_cl.main(['issue', '0']))
Edward Lemur85153282020-02-14 22:06:29 +00002390 self.assertNotIn('branch.master.gerritissue', self.mockGit.config)
2391 self.assertNotIn('branch.master.gerritserver', self.mockGit.config)
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002392
Aaron Gable400e9892017-07-12 15:31:21 -07002393 def test_cmd_issue_erase_existing_with_change_id(self):
Edward Lemur85153282020-02-14 22:06:29 +00002394 self.mockGit.config['branch.master.gerritissue'] = '123'
2395 self.mockGit.config['branch.master.gerritserver'] = (
2396 'https://chromium-review.googlesource.com')
Edward Lemurda4b6c62020-02-13 00:28:40 +00002397 mock.patch('git_cl.Changelist.FetchDescription',
2398 lambda _: 'This is a description\n\nChange-Id: Ideadbeef').start()
Aaron Gable400e9892017-07-12 15:31:21 -07002399 self.calls = [
Aaron Gableca01e2c2017-07-19 11:16:02 -07002400 ((['git', 'log', '-1', '--format=%B'],),
2401 'This is a description\n\nChange-Id: Ideadbeef'),
2402 ((['git', 'commit', '--amend', '-m', 'This is a description\n'],), ''),
Aaron Gable400e9892017-07-12 15:31:21 -07002403 ]
2404 self.assertEqual(0, git_cl.main(['issue', '0']))
Edward Lemur85153282020-02-14 22:06:29 +00002405 self.assertNotIn('branch.master.gerritissue', self.mockGit.config)
2406 self.assertNotIn('branch.master.gerritserver', self.mockGit.config)
Aaron Gable400e9892017-07-12 15:31:21 -07002407
phajdan.jre328cf92016-08-22 04:12:17 -07002408 def test_cmd_issue_json(self):
Edward Lemur85153282020-02-14 22:06:29 +00002409 self.mockGit.config['branch.master.gerritissue'] = '123'
2410 self.mockGit.config['branch.master.gerritserver'] = (
2411 'https://chromium-review.googlesource.com')
Nodir Turakulov27379632021-03-17 18:53:29 +00002412 self.mockGit.config['remote.origin.url'] = (
2413 'https://chromium.googlesource.com/chromium/src'
2414 )
2415 self.calls = [(
2416 (
2417 'write_json',
2418 'output.json',
2419 {
2420 'issue': 123,
2421 'issue_url': 'https://chromium-review.googlesource.com/123',
2422 'gerrit_host': 'chromium-review.googlesource.com',
2423 'gerrit_project': 'chromium/src',
2424 },
2425 ),
2426 '',
2427 )]
phajdan.jre328cf92016-08-22 04:12:17 -07002428 self.assertEqual(0, git_cl.main(['issue', '--json', 'output.json']))
2429
tandrii16e0b4e2016-06-07 10:34:28 -07002430 def _common_GerritCommitMsgHookCheck(self):
Edward Lemur15a9b8c2020-02-13 00:52:30 +00002431 mock.patch(
2432 'git_cl.os.path.abspath',
2433 lambda path: self._mocked_call(['abspath', path])).start()
2434 mock.patch(
2435 'git_cl.os.path.exists',
2436 lambda path: self._mocked_call(['exists', path])).start()
2437 mock.patch(
2438 'git_cl.gclient_utils.FileRead',
2439 lambda path: self._mocked_call(['FileRead', path])).start()
2440 mock.patch(
2441 'git_cl.gclient_utils.rm_file_or_tree',
2442 lambda path: self._mocked_call(['rm_file_or_tree', path])).start()
Edward Lemur1a83da12020-03-04 21:18:36 +00002443 mock.patch(
Edward Lesmesae3586b2020-03-23 21:21:14 +00002444 'gclient_utils.AskForData',
Edward Lemur1a83da12020-03-04 21:18:36 +00002445 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
Edward Lemurf38bc172019-09-03 21:02:13 +00002446 return git_cl.Changelist(issue=123)
tandrii16e0b4e2016-06-07 10:34:28 -07002447
2448 def test_GerritCommitMsgHookCheck_custom_hook(self):
2449 cl = self._common_GerritCommitMsgHookCheck()
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002450 self.calls += [((['exists',
2451 os.path.join('.git', 'hooks', 'commit-msg')], ), True),
2452 ((['FileRead',
2453 os.path.join('.git', 'hooks', 'commit-msg')], ),
2454 '#!/bin/sh\necho "custom hook"')]
Edward Lemur125d60a2019-09-13 18:25:41 +00002455 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002456
2457 def test_GerritCommitMsgHookCheck_not_exists(self):
2458 cl = self._common_GerritCommitMsgHookCheck()
2459 self.calls += [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002460 ((['exists', os.path.join('.git', 'hooks', 'commit-msg')], ), False),
tandrii16e0b4e2016-06-07 10:34:28 -07002461 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002462 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002463
2464 def test_GerritCommitMsgHookCheck(self):
2465 cl = self._common_GerritCommitMsgHookCheck()
2466 self.calls += [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002467 ((['exists', os.path.join('.git', 'hooks', 'commit-msg')], ), True),
2468 ((['FileRead', os.path.join('.git', 'hooks', 'commit-msg')], ),
tandrii16e0b4e2016-06-07 10:34:28 -07002469 '...\n# From Gerrit Code Review\n...\nadd_ChangeId()\n'),
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002470 (('ask_for_data', 'Do you want to remove it now? [Yes/No]: '), 'Yes'),
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002471 ((['rm_file_or_tree',
2472 os.path.join('.git', 'hooks', 'commit-msg')], ), ''),
tandrii16e0b4e2016-06-07 10:34:28 -07002473 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002474 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002475
tandriic4344b52016-08-29 06:04:54 -07002476 def test_GerritCmdLand(self):
Edward Lemur85153282020-02-14 22:06:29 +00002477 self.mockGit.config['branch.master.gerritsquashhash'] = 'deadbeaf'
2478 self.mockGit.config['branch.master.gerritserver'] = (
2479 'chromium-review.googlesource.com')
tandriic4344b52016-08-29 06:04:54 -07002480 self.calls += [
tandriic4344b52016-08-29 06:04:54 -07002481 ((['git', 'diff', 'deadbeaf'],), ''), # No diff.
tandriic4344b52016-08-29 06:04:54 -07002482 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002483 cl = git_cl.Changelist(issue=123)
Edward Lemur125d60a2019-09-13 18:25:41 +00002484 cl._GetChangeDetail = lambda *args, **kwargs: {
tandriic4344b52016-08-29 06:04:54 -07002485 'labels': {},
2486 'current_revision': 'deadbeaf',
2487 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002488 cl._GetChangeCommit = lambda: {
agable32978d92016-11-01 12:55:02 -07002489 'commit': 'deadbeef',
Aaron Gable02cdbb42016-12-13 16:24:25 -08002490 'web_links': [{'name': 'gitiles',
agable32978d92016-11-01 12:55:02 -07002491 'url': 'https://git.googlesource.com/test/+/deadbeef'}],
2492 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002493 cl.SubmitIssue = lambda wait_for_merge: None
Olivier Robin75ee7252018-04-13 10:02:56 +02002494 self.assertEqual(0, cl.CMDLand(force=True,
2495 bypass_hooks=True,
2496 verbose=True,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00002497 parallel=False,
2498 resultdb=False,
2499 realm=None))
Edward Lemur73c76702020-02-06 23:57:18 +00002500 self.assertIn(
2501 'Issue chromium-review.googlesource.com/123 has been submitted',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002502 sys.stdout.getvalue())
Edward Lemur73c76702020-02-06 23:57:18 +00002503 self.assertIn(
2504 'Landed as: https://git.googlesource.com/test/+/deadbeef',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002505 sys.stdout.getvalue())
tandriic4344b52016-08-29 06:04:54 -07002506
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002507 def _mock_gerrit_changes_for_detail_cache(self):
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002508 mock.patch('git_cl.Changelist.GetGerritHost', lambda _: 'host').start()
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002509
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002510 def test_gerrit_change_detail_cache_simple(self):
2511 self._mock_gerrit_changes_for_detail_cache()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002512 gerrit_util.GetChangeDetail.side_effect = ['a', 'b']
Edward Lemurf38bc172019-09-03 21:02:13 +00002513 cl1 = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002514 cl1._cached_remote_url = (
2515 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemurf38bc172019-09-03 21:02:13 +00002516 cl2 = git_cl.Changelist(issue=2)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002517 cl2._cached_remote_url = (
2518 True, 'https://chromium.googlesource.com/ab/repo')
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002519 self.assertEqual(cl1._GetChangeDetail(), 'a') # Miss.
2520 self.assertEqual(cl1._GetChangeDetail(), 'a')
2521 self.assertEqual(cl2._GetChangeDetail(), 'b') # Miss.
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002522
2523 def test_gerrit_change_detail_cache_options(self):
2524 self._mock_gerrit_changes_for_detail_cache()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002525 gerrit_util.GetChangeDetail.side_effect = ['cab', 'ad']
Edward Lemurf38bc172019-09-03 21:02:13 +00002526 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002527 cl._cached_remote_url = (True, 'https://chromium.googlesource.com/repo/')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002528 self.assertEqual(cl._GetChangeDetail(options=['C', 'A', 'B']), 'cab')
2529 self.assertEqual(cl._GetChangeDetail(options=['A', 'B', 'C']), 'cab')
2530 self.assertEqual(cl._GetChangeDetail(options=['B', 'A']), 'cab')
2531 self.assertEqual(cl._GetChangeDetail(options=['C']), 'cab')
2532 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2533 self.assertEqual(cl._GetChangeDetail(), 'cab')
2534
2535 self.assertEqual(cl._GetChangeDetail(options=['A', 'D']), 'ad')
2536 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2537 self.assertEqual(cl._GetChangeDetail(options=['D']), 'ad')
2538 self.assertEqual(cl._GetChangeDetail(), 'cab')
2539
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002540 def test_gerrit_description_caching(self):
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002541 gerrit_util.GetChangeDetail.return_value = {
2542 'current_revision': 'rev1',
2543 'revisions': {
2544 'rev1': {'commit': {'message': 'desc1'}},
2545 },
2546 }
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002547
2548 self._mock_gerrit_changes_for_detail_cache()
Edward Lemurf38bc172019-09-03 21:02:13 +00002549 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002550 cl._cached_remote_url = (
2551 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemur6c6827c2020-02-06 21:15:18 +00002552 self.assertEqual(cl.FetchDescription(), 'desc1')
2553 self.assertEqual(cl.FetchDescription(), 'desc1') # cache hit.
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002554
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002555 def test_print_current_creds(self):
2556 class CookiesAuthenticatorMock(object):
2557 def __init__(self):
2558 self.gitcookies = {
2559 'host.googlesource.com': ('user', 'pass'),
2560 'host-review.googlesource.com': ('user', 'pass'),
2561 }
2562 self.netrc = self
2563 self.netrc.hosts = {
2564 'github.com': ('user2', None, 'pass2'),
2565 'host2.googlesource.com': ('user3', None, 'pass'),
2566 }
Edward Lemurda4b6c62020-02-13 00:28:40 +00002567 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
2568 CookiesAuthenticatorMock).start()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002569 git_cl._GitCookiesChecker().print_current_creds(include_netrc=True)
2570 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2571 ' Host\t User\t Which file',
2572 '============================\t=====\t===========',
2573 'host-review.googlesource.com\t user\t.gitcookies',
2574 ' host.googlesource.com\t user\t.gitcookies',
2575 ' host2.googlesource.com\tuser3\t .netrc',
2576 ])
Edward Lemur79d4f992019-11-11 23:49:02 +00002577 sys.stdout.seek(0)
2578 sys.stdout.truncate(0)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002579 git_cl._GitCookiesChecker().print_current_creds(include_netrc=False)
2580 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2581 ' Host\tUser\t Which file',
2582 '============================\t====\t===========',
2583 'host-review.googlesource.com\tuser\t.gitcookies',
2584 ' host.googlesource.com\tuser\t.gitcookies',
2585 ])
2586
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002587 def _common_creds_check_mocks(self):
2588 def exists_mock(path):
2589 dirname = os.path.dirname(path)
2590 if dirname == os.path.expanduser('~'):
2591 dirname = '~'
2592 base = os.path.basename(path)
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002593 if base in (NETRC_FILENAME, '.gitcookies'):
2594 return self._mocked_call('os.path.exists', os.path.join(dirname, base))
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002595 # git cl also checks for existence other files not relevant to this test.
2596 return None
Edward Lemur1a83da12020-03-04 21:18:36 +00002597 mock.patch(
Edward Lesmesae3586b2020-03-23 21:21:14 +00002598 'gclient_utils.AskForData',
Edward Lemur1a83da12020-03-04 21:18:36 +00002599 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002600 mock.patch('os.path.exists', exists_mock).start()
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002601
2602 def test_creds_check_gitcookies_not_configured(self):
2603 self._common_creds_check_mocks()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002604 mock.patch('git_cl._GitCookiesChecker.get_hosts_with_creds',
2605 lambda _, include_netrc=False: []).start()
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002606 self.calls = [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002607 ((['git', 'config', '--path', 'http.cookiefile'], ), CERR1),
2608 ((['git', 'config', '--global', 'http.cookiefile'], ), CERR1),
2609 (('os.path.exists', os.path.join('~', NETRC_FILENAME)), True),
2610 (('ask_for_data', 'Press Enter to setup .gitcookies, '
2611 'or Ctrl+C to abort'), ''),
2612 (([
2613 'git', 'config', '--global', 'http.cookiefile',
2614 os.path.expanduser(os.path.join('~', '.gitcookies'))
2615 ], ), ''),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002616 ]
2617 self.assertEqual(0, git_cl.main(['creds-check']))
Edward Lemur73c76702020-02-06 23:57:18 +00002618 self.assertTrue(
2619 sys.stdout.getvalue().startswith(
2620 'You seem to be using outdated .netrc for git credentials:'))
2621 self.assertIn(
2622 '\nConfigured git to use .gitcookies from',
2623 sys.stdout.getvalue())
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002624
2625 def test_creds_check_gitcookies_configured_custom_broken(self):
2626 self._common_creds_check_mocks()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002627 mock.patch('git_cl._GitCookiesChecker.get_hosts_with_creds',
2628 lambda _, include_netrc=False: []).start()
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002629 custom_cookie_path = ('C:\\.gitcookies'
2630 if sys.platform == 'win32' else '/custom/.gitcookies')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002631 self.calls = [
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00002632 ((['git', 'config', '--path', 'http.cookiefile'], ), CERR1),
2633 ((['git', 'config', '--global', 'http.cookiefile'], ),
2634 custom_cookie_path),
2635 (('os.path.exists', custom_cookie_path), False),
2636 (('ask_for_data', 'Reconfigure git to use default .gitcookies? '
2637 'Press Enter to reconfigure, or Ctrl+C to abort'), ''),
2638 (([
2639 'git', 'config', '--global', 'http.cookiefile',
2640 os.path.expanduser(os.path.join('~', '.gitcookies'))
2641 ], ), ''),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002642 ]
2643 self.assertEqual(0, git_cl.main(['creds-check']))
Edward Lemur73c76702020-02-06 23:57:18 +00002644 self.assertIn(
2645 'WARNING: You have configured custom path to .gitcookies: ',
2646 sys.stdout.getvalue())
2647 self.assertIn(
2648 'However, your configured .gitcookies file is missing.',
2649 sys.stdout.getvalue())
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002650
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002651 def test_git_cl_comment_add_gerrit(self):
Edward Lemur85153282020-02-14 22:06:29 +00002652 self.mockGit.branchref = None
Edward Lemur26964072020-02-19 19:18:51 +00002653 self.mockGit.config['remote.origin.url'] = (
2654 'https://chromium.googlesource.com/infra/infra')
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002655 self.calls = [
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002656 (('SetReview', 'chromium-review.googlesource.com', 'infra%2Finfra~10',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002657 'msg', None, None, None),
Aaron Gable636b13f2017-07-14 10:42:48 -07002658 None),
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002659 ]
Edward Lemur52969c92020-02-06 18:15:28 +00002660 self.assertEqual(0, git_cl.main(['comment', '-i', '10', '-a', 'msg']))
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002661
Edward Lemurda4b6c62020-02-13 00:28:40 +00002662 @mock.patch('git_cl.Changelist.GetBranch', return_value='foo')
2663 def test_git_cl_comments_fetch_gerrit(self, *_mocks):
Edward Lemur26964072020-02-19 19:18:51 +00002664 self.mockGit.config['remote.origin.url'] = (
2665 'https://chromium.googlesource.com/infra/infra')
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002666 gerrit_util.GetChangeDetail.return_value = {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002667 'owner': {'email': 'owner@example.com'},
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002668 'current_revision': 'ba5eba11',
2669 'revisions': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002670 'deadbeaf': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002671 '_number': 1,
2672 },
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002673 'ba5eba11': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002674 '_number': 2,
2675 },
2676 },
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002677 'messages': [
2678 {
2679 u'_revision_number': 1,
2680 u'author': {
2681 u'_account_id': 1111084,
Andrii Shyshkalov8aa9d622020-03-10 19:15:35 +00002682 u'email': u'could-be-anything@example.com',
2683 u'name': u'LUCI CQ'
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002684 },
2685 u'date': u'2017-03-15 20:08:45.000000000',
2686 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
Dirk Prankef6a58802017-10-17 12:49:42 -07002687 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002688 u'tag': u'autogenerated:cq:dry-run'
2689 },
2690 {
2691 u'_revision_number': 2,
2692 u'author': {
2693 u'_account_id': 11151243,
2694 u'email': u'owner@example.com',
2695 u'name': u'owner'
2696 },
2697 u'date': u'2017-03-16 20:00:41.000000000',
2698 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2699 u'message': u'PTAL',
2700 },
2701 {
2702 u'_revision_number': 2,
2703 u'author': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002704 u'_account_id': 148512,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002705 u'email': u'reviewer@example.com',
2706 u'name': u'reviewer'
2707 },
2708 u'date': u'2017-03-17 05:19:37.500000000',
2709 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2710 u'message': u'Patch Set 2: Code-Review+1',
2711 },
2712 ]
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002713 }
2714 self.calls = [
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002715 (('GetChangeComments', 'chromium-review.googlesource.com',
2716 'infra%2Finfra~1'), {
2717 '/COMMIT_MSG': [
2718 {
2719 'author': {
2720 'email': u'reviewer@example.com'
2721 },
2722 'updated': u'2017-03-17 05:19:37.500000000',
2723 'patch_set': 2,
2724 'side': 'REVISION',
2725 'message': 'Please include a bug link',
2726 },
2727 ],
2728 'codereview.settings': [
2729 {
2730 'author': {
2731 'email': u'owner@example.com'
2732 },
2733 'updated': u'2017-03-16 20:00:41.000000000',
2734 'patch_set': 2,
2735 'side': 'PARENT',
2736 'line': 42,
2737 'message': 'I removed this because it is bad',
2738 },
2739 ]
2740 }),
2741 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
2742 'infra%2Finfra~1'), {}),
2743 ] * 2 + [(('write_json', 'output.json', [{
2744 u'date':
2745 u'2017-03-16 20:00:41.000000',
2746 u'message': (u'PTAL\n' + u'\n' + u'codereview.settings\n' +
2747 u' Base, Line 42: https://crrev.com/c/1/2/'
2748 u'codereview.settings#b42\n' +
2749 u' I removed this because it is bad\n'),
2750 u'autogenerated':
2751 False,
2752 u'approval':
2753 False,
2754 u'disapproval':
2755 False,
2756 u'sender':
2757 u'owner@example.com'
2758 }, {
2759 u'date':
2760 u'2017-03-17 05:19:37.500000',
2761 u'message':
2762 (u'Patch Set 2: Code-Review+1\n' + u'\n' + u'/COMMIT_MSG\n' +
2763 u' PS2, File comment: https://crrev.com/c/1/2//COMMIT_MSG#\n' +
2764 u' Please include a bug link\n'),
2765 u'autogenerated':
2766 False,
2767 u'approval':
2768 False,
2769 u'disapproval':
2770 False,
2771 u'sender':
2772 u'reviewer@example.com'
2773 }]), '')]
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002774 expected_comments_summary = [
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002775 git_cl._CommentSummary(
2776 message=(u'PTAL\n' + u'\n' + u'codereview.settings\n' +
2777 u' Base, Line 42: https://crrev.com/c/1/2/' +
2778 u'codereview.settings#b42\n' +
2779 u' I removed this because it is bad\n'),
2780 date=datetime.datetime(2017, 3, 16, 20, 0, 41, 0),
2781 autogenerated=False,
2782 disapproval=False,
2783 approval=False,
2784 sender=u'owner@example.com'),
2785 git_cl._CommentSummary(message=(
2786 u'Patch Set 2: Code-Review+1\n' + u'\n' + u'/COMMIT_MSG\n' +
2787 u' PS2, File comment: https://crrev.com/c/1/2//COMMIT_MSG#\n' +
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002788 u' Please include a bug link\n'),
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002789 date=datetime.datetime(2017, 3, 17, 5, 19, 37,
2790 500000),
2791 autogenerated=False,
2792 disapproval=False,
2793 approval=False,
2794 sender=u'reviewer@example.com'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002795 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002796 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00002797 issue=1, branchref='refs/heads/foo')
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002798 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002799 self.assertEqual(
2800 0, git_cl.main(['comments', '-i', '1', '-j', 'output.json']))
2801
2802 def test_git_cl_comments_robot_comments(self):
2803 # git cl comments also fetches robot comments (which are considered a type
2804 # of autogenerated comment), and unlike other types of comments, only robot
2805 # comments from the latest patchset are shown.
Edward Lemur26964072020-02-19 19:18:51 +00002806 self.mockGit.config['remote.origin.url'] = (
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002807 'https://x.googlesource.com/infra/infra')
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002808 gerrit_util.GetChangeDetail.return_value = {
2809 'owner': {'email': 'owner@example.com'},
2810 'current_revision': 'ba5eba11',
2811 'revisions': {
2812 'deadbeaf': {
2813 '_number': 1,
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002814 },
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002815 'ba5eba11': {
2816 '_number': 2,
2817 },
2818 },
2819 'messages': [
2820 {
2821 u'_revision_number': 1,
2822 u'author': {
2823 u'_account_id': 1111084,
2824 u'email': u'commit-bot@chromium.org',
2825 u'name': u'Commit Bot'
2826 },
2827 u'date': u'2017-03-15 20:08:45.000000000',
2828 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
2829 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
2830 u'tag': u'autogenerated:cq:dry-run'
2831 },
2832 {
2833 u'_revision_number': 1,
2834 u'author': {
2835 u'_account_id': 123,
2836 u'email': u'tricium@serviceaccount.com',
2837 u'name': u'Tricium'
2838 },
2839 u'date': u'2017-03-16 20:00:41.000000000',
2840 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2841 u'message': u'(1 comment)',
2842 u'tag': u'autogenerated:tricium',
2843 },
2844 {
2845 u'_revision_number': 1,
2846 u'author': {
2847 u'_account_id': 123,
2848 u'email': u'tricium@serviceaccount.com',
2849 u'name': u'Tricium'
2850 },
2851 u'date': u'2017-03-16 20:00:41.000000000',
2852 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2853 u'message': u'(1 comment)',
2854 u'tag': u'autogenerated:tricium',
2855 },
2856 {
2857 u'_revision_number': 2,
2858 u'author': {
2859 u'_account_id': 123,
2860 u'email': u'tricium@serviceaccount.com',
2861 u'name': u'reviewer'
2862 },
2863 u'date': u'2017-03-17 05:30:37.000000000',
2864 u'tag': u'autogenerated:tricium',
2865 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2866 u'message': u'(1 comment)',
2867 },
2868 ]
2869 }
2870 self.calls = [
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002871 (('GetChangeComments', 'x-review.googlesource.com', 'infra%2Finfra~1'),
2872 {}),
2873 (('GetChangeRobotComments', 'x-review.googlesource.com',
2874 'infra%2Finfra~1'), {
2875 'codereview.settings': [
2876 {
2877 u'author': {
2878 u'email': u'tricium@serviceaccount.com'
2879 },
2880 u'updated': u'2017-03-17 05:30:37.000000000',
2881 u'robot_run_id': u'5565031076855808',
2882 u'robot_id': u'Linter/Category',
2883 u'tag': u'autogenerated:tricium',
2884 u'patch_set': 2,
2885 u'side': u'REVISION',
2886 u'message': u'Linter warning message text',
2887 u'line': 32,
2888 },
2889 ],
2890 }),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002891 ]
2892 expected_comments_summary = [
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002893 git_cl._CommentSummary(
2894 date=datetime.datetime(2017, 3, 17, 5, 30, 37),
2895 message=(u'(1 comment)\n\ncodereview.settings\n'
2896 u' PS2, Line 32: https://x-review.googlesource.com/c/1/2/'
2897 u'codereview.settings#32\n'
2898 u' Linter warning message text\n'),
2899 sender=u'tricium@serviceaccount.com',
2900 autogenerated=True,
2901 approval=False,
2902 disapproval=False)
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002903 ]
2904 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00002905 issue=1, branchref='refs/heads/foo')
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002906 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002907
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002908 def test_get_remote_url_with_mirror(self):
2909 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002910
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002911 def selective_os_path_isdir_mock(path):
2912 if path == '/cache/this-dir-exists':
2913 return self._mocked_call('os.path.isdir', path)
2914 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002915
Edward Lemurda4b6c62020-02-13 00:28:40 +00002916 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002917
2918 url = 'https://chromium.googlesource.com/my/repo'
Edward Lemur26964072020-02-19 19:18:51 +00002919 self.mockGit.config['remote.origin.url'] = (
2920 '/cache/this-dir-exists')
2921 self.mockGit.config['/cache/this-dir-exists:remote.origin.url'] = (
2922 url)
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002923 self.calls = [
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002924 (('os.path.isdir', '/cache/this-dir-exists'),
2925 True),
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002926 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002927 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002928 self.assertEqual(cl.GetRemoteUrl(), url)
2929 self.assertEqual(cl.GetRemoteUrl(), url) # Must be cached.
2930
Edward Lemur298f2cf2019-02-22 21:40:39 +00002931 def test_get_remote_url_non_existing_mirror(self):
2932 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002933
Edward Lemur298f2cf2019-02-22 21:40:39 +00002934 def selective_os_path_isdir_mock(path):
2935 if path == '/cache/this-dir-doesnt-exist':
2936 return self._mocked_call('os.path.isdir', path)
2937 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002938
Edward Lemurda4b6c62020-02-13 00:28:40 +00002939 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
2940 mock.patch('logging.error',
2941 lambda *a: self._mocked_call('logging.error', *a)).start()
Edward Lemur298f2cf2019-02-22 21:40:39 +00002942
Edward Lemur26964072020-02-19 19:18:51 +00002943 self.mockGit.config['remote.origin.url'] = (
2944 '/cache/this-dir-doesnt-exist')
Edward Lemur298f2cf2019-02-22 21:40:39 +00002945 self.calls = [
Edward Lemur298f2cf2019-02-22 21:40:39 +00002946 (('os.path.isdir', '/cache/this-dir-doesnt-exist'),
2947 False),
2948 (('logging.error',
Josip906bfde2020-01-31 22:38:49 +00002949 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
2950 'but it doesn\'t exist.', {
2951 'remote': 'origin',
2952 'branch': 'master',
2953 'url': '/cache/this-dir-doesnt-exist'}
2954 ), None),
Edward Lemur298f2cf2019-02-22 21:40:39 +00002955 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002956 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00002957 self.assertIsNone(cl.GetRemoteUrl())
2958
2959 def test_get_remote_url_misconfigured_mirror(self):
2960 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002961
Edward Lemur298f2cf2019-02-22 21:40:39 +00002962 def selective_os_path_isdir_mock(path):
2963 if path == '/cache/this-dir-exists':
2964 return self._mocked_call('os.path.isdir', path)
2965 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002966
Edward Lemurda4b6c62020-02-13 00:28:40 +00002967 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
2968 mock.patch('logging.error',
2969 lambda *a: self._mocked_call('logging.error', *a)).start()
Edward Lemur298f2cf2019-02-22 21:40:39 +00002970
Edward Lemur26964072020-02-19 19:18:51 +00002971 self.mockGit.config['remote.origin.url'] = (
2972 '/cache/this-dir-exists')
Edward Lemur298f2cf2019-02-22 21:40:39 +00002973 self.calls = [
Edward Lemur298f2cf2019-02-22 21:40:39 +00002974 (('os.path.isdir', '/cache/this-dir-exists'), True),
Edward Lemur298f2cf2019-02-22 21:40:39 +00002975 (('logging.error',
2976 'Remote "%(remote)s" for branch "%(branch)s" points to '
2977 '"%(cache_path)s", but it is misconfigured.\n'
2978 '"%(cache_path)s" must be a git repo and must have a remote named '
2979 '"%(remote)s" pointing to the git host.', {
2980 'remote': 'origin',
2981 'cache_path': '/cache/this-dir-exists',
2982 'branch': 'master'}
2983 ), None),
2984 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002985 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00002986 self.assertIsNone(cl.GetRemoteUrl())
2987
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002988 def test_gerrit_change_identifier_with_project(self):
Edward Lemur26964072020-02-19 19:18:51 +00002989 self.mockGit.config['remote.origin.url'] = (
2990 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemurf38bc172019-09-03 21:02:13 +00002991 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002992 self.assertEqual(cl._GerritChangeIdentifier(), 'my%2Frepo~123456')
2993
2994 def test_gerrit_change_identifier_without_project(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002995 mock.patch('logging.error',
2996 lambda *a: self._mocked_call('logging.error', *a)).start()
Josip906bfde2020-01-31 22:38:49 +00002997
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002998 self.calls = [
Josip906bfde2020-01-31 22:38:49 +00002999 (('logging.error',
3000 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
3001 'but it doesn\'t exist.', {
3002 'remote': 'origin',
3003 'branch': 'master',
3004 'url': ''}
3005 ), None),
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003006 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00003007 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003008 self.assertEqual(cl._GerritChangeIdentifier(), '123456')
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00003009
Josip Sokcevicc39ab992020-09-24 20:09:15 +00003010 def test_gerrit_new_default(self):
3011 self._run_gerrit_upload_test(
3012 [],
3013 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
3014 [],
3015 squash=False,
3016 squash_mode='override_nosquash',
3017 change_id='I123456789',
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00003018 default_branch='main')
Josip Sokcevicc39ab992020-09-24 20:09:15 +00003019
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003020
Edward Lemur9aa1a962020-02-25 00:58:38 +00003021class ChangelistTest(unittest.TestCase):
mlcui3da91712021-05-05 10:00:30 +00003022 LAST_COMMIT_SUBJECT = 'Fixes goat teleporter destination to be Australia'
3023
3024 def _mock_run_git(commands):
3025 if commands == ['show', '-s', '--format=%s', 'HEAD']:
3026 return ChangelistTest.LAST_COMMIT_SUBJECT
3027
Edward Lemur227d5102020-02-25 23:45:35 +00003028 def setUp(self):
3029 super(ChangelistTest, self).setUp()
3030 mock.patch('gclient_utils.FileRead').start()
3031 mock.patch('gclient_utils.FileWrite').start()
3032 mock.patch('gclient_utils.temporary_file', TemporaryFileMock()).start()
3033 mock.patch(
3034 'git_cl.Changelist.GetCodereviewServer',
3035 return_value='https://chromium-review.googlesource.com').start()
3036 mock.patch('git_cl.Changelist.GetAuthor', return_value='author').start()
3037 mock.patch('git_cl.Changelist.GetIssue', return_value=123456).start()
3038 mock.patch('git_cl.Changelist.GetPatchset', return_value=7).start()
Dirk Pranke6f0df682021-06-25 00:42:33 +00003039 mock.patch('git_cl.Changelist.GetUsePython3', return_value=False).start()
Edward Lesmeseb1bd622021-03-01 19:54:07 +00003040 mock.patch(
3041 'git_cl.Changelist.GetRemoteBranch',
3042 return_value=('origin', 'refs/remotes/origin/main')).start()
Edward Lemur227d5102020-02-25 23:45:35 +00003043 mock.patch('git_cl.PRESUBMIT_SUPPORT', 'PRESUBMIT_SUPPORT').start()
3044 mock.patch('git_cl.Settings.GetRoot', return_value='root').start()
3045 mock.patch('git_cl.time_time').start()
3046 mock.patch('metrics.collector').start()
3047 mock.patch('subprocess2.Popen').start()
Edward Lesmeseb1bd622021-03-01 19:54:07 +00003048 mock.patch(
3049 'git_cl.Changelist.GetGerritProject', return_value='project').start()
Edward Lemur227d5102020-02-25 23:45:35 +00003050 self.addCleanup(mock.patch.stopall)
3051 self.temp_count = 0
3052
Edward Lemur227d5102020-02-25 23:45:35 +00003053 def testRunHook(self):
3054 expected_results = {
Dirk Pranke61bf6e82021-04-23 00:50:21 +00003055 'more_cc': ['cc@example.com', 'more@example.com'],
3056 'errors': [],
3057 'notifications': [],
3058 'warnings': [],
Edward Lemur227d5102020-02-25 23:45:35 +00003059 }
3060 gclient_utils.FileRead.return_value = json.dumps(expected_results)
Dirk Pranke61bf6e82021-04-23 00:50:21 +00003061 git_cl.time_time.side_effect = [100, 200, 300, 400]
Edward Lemur227d5102020-02-25 23:45:35 +00003062 mockProcess = mock.Mock()
3063 mockProcess.wait.return_value = 0
3064 subprocess2.Popen.return_value = mockProcess
3065
3066 cl = git_cl.Changelist()
3067 results = cl.RunHook(
3068 committing=True,
3069 may_prompt=True,
3070 verbose=2,
3071 parallel=True,
3072 upstream='upstream',
3073 description='description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003074 all_files=True,
3075 resultdb=False)
Edward Lemur227d5102020-02-25 23:45:35 +00003076
3077 self.assertEqual(expected_results, results)
Dirk Pranke61bf6e82021-04-23 00:50:21 +00003078 subprocess2.Popen.assert_any_call([
Edward Lemur227d5102020-02-25 23:45:35 +00003079 'vpython', 'PRESUBMIT_SUPPORT',
Edward Lemur227d5102020-02-25 23:45:35 +00003080 '--root', 'root',
3081 '--upstream', 'upstream',
3082 '--verbose', '--verbose',
Edward Lemur99df04e2020-03-05 19:39:43 +00003083 '--gerrit_url', 'https://chromium-review.googlesource.com',
Edward Lesmeseb1bd622021-03-01 19:54:07 +00003084 '--gerrit_project', 'project',
3085 '--gerrit_branch', 'refs/heads/main',
3086 '--author', 'author',
Edward Lemur227d5102020-02-25 23:45:35 +00003087 '--issue', '123456',
3088 '--patchset', '7',
Edward Lemur75526302020-02-27 22:31:05 +00003089 '--commit',
Edward Lemur227d5102020-02-25 23:45:35 +00003090 '--may_prompt',
3091 '--parallel',
3092 '--all_files',
3093 '--json_output', '/tmp/fake-temp2',
3094 '--description_file', '/tmp/fake-temp1',
3095 ])
Dirk Pranke61bf6e82021-04-23 00:50:21 +00003096 subprocess2.Popen.assert_any_call([
3097 'vpython3', 'PRESUBMIT_SUPPORT',
3098 '--root', 'root',
3099 '--upstream', 'upstream',
3100 '--verbose', '--verbose',
3101 '--gerrit_url', 'https://chromium-review.googlesource.com',
3102 '--gerrit_project', 'project',
3103 '--gerrit_branch', 'refs/heads/main',
3104 '--author', 'author',
3105 '--issue', '123456',
3106 '--patchset', '7',
3107 '--commit',
3108 '--may_prompt',
3109 '--parallel',
3110 '--all_files',
3111 '--json_output', '/tmp/fake-temp4',
3112 '--description_file', '/tmp/fake-temp3',
3113 ])
3114 gclient_utils.FileWrite.assert_any_call(
Edward Lemur1a83da12020-03-04 21:18:36 +00003115 '/tmp/fake-temp1', 'description')
Edward Lemur227d5102020-02-25 23:45:35 +00003116 metrics.collector.add_repeated('sub_commands', {
3117 'command': 'presubmit',
3118 'execution_time': 100,
3119 'exit_code': 0,
3120 })
3121
Edward Lemur99df04e2020-03-05 19:39:43 +00003122 def testRunHook_FewerOptions(self):
3123 expected_results = {
Dirk Pranke61bf6e82021-04-23 00:50:21 +00003124 'more_cc': ['cc@example.com', 'more@example.com'],
3125 'errors': [],
3126 'notifications': [],
3127 'warnings': [],
Edward Lemur99df04e2020-03-05 19:39:43 +00003128 }
3129 gclient_utils.FileRead.return_value = json.dumps(expected_results)
Dirk Pranke61bf6e82021-04-23 00:50:21 +00003130 git_cl.time_time.side_effect = [100, 200, 300, 400]
Edward Lemur99df04e2020-03-05 19:39:43 +00003131 mockProcess = mock.Mock()
3132 mockProcess.wait.return_value = 0
3133 subprocess2.Popen.return_value = mockProcess
3134
3135 git_cl.Changelist.GetAuthor.return_value = None
3136 git_cl.Changelist.GetIssue.return_value = None
3137 git_cl.Changelist.GetPatchset.return_value = None
Edward Lemur99df04e2020-03-05 19:39:43 +00003138
3139 cl = git_cl.Changelist()
3140 results = cl.RunHook(
3141 committing=False,
3142 may_prompt=False,
3143 verbose=0,
3144 parallel=False,
3145 upstream='upstream',
3146 description='description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003147 all_files=False,
3148 resultdb=False)
Edward Lemur99df04e2020-03-05 19:39:43 +00003149
3150 self.assertEqual(expected_results, results)
Dirk Pranke61bf6e82021-04-23 00:50:21 +00003151 subprocess2.Popen.assert_any_call([
Edward Lemur99df04e2020-03-05 19:39:43 +00003152 'vpython', 'PRESUBMIT_SUPPORT',
3153 '--root', 'root',
3154 '--upstream', 'upstream',
Edward Lesmeseb1bd622021-03-01 19:54:07 +00003155 '--gerrit_url', 'https://chromium-review.googlesource.com',
3156 '--gerrit_project', 'project',
3157 '--gerrit_branch', 'refs/heads/main',
Edward Lemur99df04e2020-03-05 19:39:43 +00003158 '--upload',
3159 '--json_output', '/tmp/fake-temp2',
3160 '--description_file', '/tmp/fake-temp1',
3161 ])
Dirk Pranke61bf6e82021-04-23 00:50:21 +00003162 gclient_utils.FileWrite.assert_any_call(
Edward Lemur99df04e2020-03-05 19:39:43 +00003163 '/tmp/fake-temp1', 'description')
3164 metrics.collector.add_repeated('sub_commands', {
3165 'command': 'presubmit',
3166 'execution_time': 100,
3167 'exit_code': 0,
3168 })
3169
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003170 def testRunHook_FewerOptionsResultDB(self):
3171 expected_results = {
Dirk Pranke61bf6e82021-04-23 00:50:21 +00003172 'more_cc': ['cc@example.com', 'more@example.com'],
3173 'errors': [],
3174 'notifications': [],
3175 'warnings': [],
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003176 }
3177 gclient_utils.FileRead.return_value = json.dumps(expected_results)
Dirk Pranke61bf6e82021-04-23 00:50:21 +00003178 git_cl.time_time.side_effect = [100, 200, 300, 400]
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003179 mockProcess = mock.Mock()
3180 mockProcess.wait.return_value = 0
3181 subprocess2.Popen.return_value = mockProcess
3182
3183 git_cl.Changelist.GetAuthor.return_value = None
3184 git_cl.Changelist.GetIssue.return_value = None
3185 git_cl.Changelist.GetPatchset.return_value = None
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003186
3187 cl = git_cl.Changelist()
3188 results = cl.RunHook(
3189 committing=False,
3190 may_prompt=False,
3191 verbose=0,
3192 parallel=False,
3193 upstream='upstream',
3194 description='description',
3195 all_files=False,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003196 resultdb=True,
3197 realm='chromium:public')
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003198
3199 self.assertEqual(expected_results, results)
Dirk Pranke61bf6e82021-04-23 00:50:21 +00003200 subprocess2.Popen.assert_any_call([
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003201 'rdb', 'stream', '-new', '-realm', 'chromium:public', '--',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003202 'vpython', 'PRESUBMIT_SUPPORT',
3203 '--root', 'root',
3204 '--upstream', 'upstream',
Edward Lesmeseb1bd622021-03-01 19:54:07 +00003205 '--gerrit_url', 'https://chromium-review.googlesource.com',
3206 '--gerrit_project', 'project',
3207 '--gerrit_branch', 'refs/heads/main',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003208 '--upload',
3209 '--json_output', '/tmp/fake-temp2',
3210 '--description_file', '/tmp/fake-temp1',
3211 ])
3212
Edward Lemur227d5102020-02-25 23:45:35 +00003213 @mock.patch('sys.exit', side_effect=SystemExitMock)
3214 def testRunHook_Failure(self, _mock):
3215 git_cl.time_time.side_effect = [100, 200]
3216 mockProcess = mock.Mock()
3217 mockProcess.wait.return_value = 2
3218 subprocess2.Popen.return_value = mockProcess
3219
3220 cl = git_cl.Changelist()
3221 with self.assertRaises(SystemExitMock):
3222 cl.RunHook(
3223 committing=True,
3224 may_prompt=True,
3225 verbose=2,
3226 parallel=True,
3227 upstream='upstream',
3228 description='description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003229 all_files=True,
3230 resultdb=False)
Edward Lemur227d5102020-02-25 23:45:35 +00003231
3232 sys.exit.assert_called_once_with(2)
3233
Edward Lemur75526302020-02-27 22:31:05 +00003234 def testRunPostUploadHook(self):
3235 cl = git_cl.Changelist()
3236 cl.RunPostUploadHook(2, 'upstream', 'description')
3237
3238 subprocess2.Popen.assert_called_once_with([
3239 'vpython', 'PRESUBMIT_SUPPORT',
Edward Lemur75526302020-02-27 22:31:05 +00003240 '--root', 'root',
3241 '--upstream', 'upstream',
3242 '--verbose', '--verbose',
Edward Lemur99df04e2020-03-05 19:39:43 +00003243 '--gerrit_url', 'https://chromium-review.googlesource.com',
Edward Lesmeseb1bd622021-03-01 19:54:07 +00003244 '--gerrit_project', 'project',
3245 '--gerrit_branch', 'refs/heads/main',
3246 '--author', 'author',
Edward Lemur75526302020-02-27 22:31:05 +00003247 '--issue', '123456',
3248 '--patchset', '7',
Edward Lemur75526302020-02-27 22:31:05 +00003249 '--post_upload',
3250 '--description_file', '/tmp/fake-temp1',
3251 ])
3252 gclient_utils.FileWrite.assert_called_once_with(
Edward Lemur1a83da12020-03-04 21:18:36 +00003253 '/tmp/fake-temp1', 'description')
Edward Lemur75526302020-02-27 22:31:05 +00003254
mlcui3da91712021-05-05 10:00:30 +00003255 @mock.patch('git_cl.RunGit', _mock_run_git)
3256 def testDefaultTitleEmptyMessage(self):
3257 cl = git_cl.Changelist()
3258 cl.issue = 100
3259 options = optparse.Values({
3260 'squash': True,
3261 'title': None,
3262 'message': None,
3263 'force': None,
3264 'skip_title': None
3265 })
3266
3267 mock.patch('gclient_utils.AskForData', lambda _: user_title).start()
3268 for user_title in ['', 'y', 'Y']:
3269 self.assertEqual(cl._GetTitleForUpload(options), self.LAST_COMMIT_SUBJECT)
3270
3271 for user_title in ['not empty', 'yes', 'YES']:
3272 self.assertEqual(cl._GetTitleForUpload(options), user_title)
3273
Edward Lemur9aa1a962020-02-25 00:58:38 +00003274
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003275class CMDTestCaseBase(unittest.TestCase):
3276 _STATUSES = [
3277 'STATUS_UNSPECIFIED', 'SCHEDULED', 'STARTED', 'SUCCESS', 'FAILURE',
3278 'INFRA_FAILURE', 'CANCELED',
3279 ]
3280 _CHANGE_DETAIL = {
3281 'project': 'depot_tools',
3282 'status': 'OPEN',
3283 'owner': {'email': 'owner@e.mail'},
3284 'current_revision': 'beeeeeef',
3285 'revisions': {
Gavin Make61ccc52020-11-13 00:12:57 +00003286 'deadbeaf': {
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00003287 '_number': 6,
Gavin Make61ccc52020-11-13 00:12:57 +00003288 'kind': 'REWORK',
3289 },
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003290 'beeeeeef': {
3291 '_number': 7,
Gavin Make61ccc52020-11-13 00:12:57 +00003292 'kind': 'NO_CODE_CHANGE',
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003293 'fetch': {'http': {
3294 'url': 'https://chromium.googlesource.com/depot_tools',
3295 'ref': 'refs/changes/56/123456/7'
3296 }},
3297 },
3298 },
3299 }
3300 _DEFAULT_RESPONSE = {
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003301 'builds': [{
3302 'id': str(100 + idx),
3303 'builder': {
3304 'project': 'chromium',
3305 'bucket': 'try',
3306 'builder': 'bot_' + status.lower(),
3307 },
3308 'createTime': '2019-10-09T08:00:0%d.854286Z' % (idx % 10),
3309 'tags': [],
3310 'status': status,
3311 } for idx, status in enumerate(_STATUSES)]
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003312 }
3313
Edward Lemur4c707a22019-09-24 21:13:43 +00003314 def setUp(self):
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003315 super(CMDTestCaseBase, self).setUp()
Edward Lemur79d4f992019-11-11 23:49:02 +00003316 mock.patch('git_cl.sys.stdout', StringIO()).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003317 mock.patch('git_cl.uuid.uuid4', return_value='uuid4').start()
3318 mock.patch('git_cl.Changelist.GetIssue', return_value=123456).start()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00003319 mock.patch(
3320 'git_cl.Changelist.GetCodereviewServer',
3321 return_value='https://chromium-review.googlesource.com').start()
3322 mock.patch(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00003323 'git_cl.Changelist.GetGerritHost',
Edward Lesmes7677e5c2020-02-19 20:39:03 +00003324 return_value='chromium-review.googlesource.com').start()
3325 mock.patch(
3326 'git_cl.Changelist.GetMostRecentPatchset',
3327 return_value=7).start()
3328 mock.patch(
Gavin Make61ccc52020-11-13 00:12:57 +00003329 'git_cl.Changelist.GetMostRecentDryRunPatchset',
3330 return_value=6).start()
3331 mock.patch(
Edward Lesmes7677e5c2020-02-19 20:39:03 +00003332 'git_cl.Changelist.GetRemoteUrl',
3333 return_value='https://chromium.googlesource.com/depot_tools').start()
3334 mock.patch(
3335 'auth.Authenticator',
3336 return_value=AuthenticatorMock()).start()
3337 mock.patch(
3338 'gerrit_util.GetChangeDetail',
3339 return_value=self._CHANGE_DETAIL).start()
3340 mock.patch(
3341 'git_cl._call_buildbucket',
3342 return_value = self._DEFAULT_RESPONSE).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003343 mock.patch('git_common.is_dirty_git_tree', return_value=False).start()
Edward Lemur4c707a22019-09-24 21:13:43 +00003344 self.addCleanup(mock.patch.stopall)
3345
Edward Lemur4c707a22019-09-24 21:13:43 +00003346
Edward Lemur9468eba2020-02-27 19:07:22 +00003347class CMDPresubmitTestCase(CMDTestCaseBase):
3348 def setUp(self):
3349 super(CMDPresubmitTestCase, self).setUp()
3350 mock.patch(
3351 'git_cl.Changelist.GetCommonAncestorWithUpstream',
3352 return_value='upstream').start()
3353 mock.patch(
3354 'git_cl.Changelist.FetchDescription',
3355 return_value='fetch description').start()
3356 mock.patch(
Edward Lemura12175c2020-03-09 16:58:26 +00003357 'git_cl._create_description_from_log',
Edward Lemur9468eba2020-02-27 19:07:22 +00003358 return_value='get description').start()
3359 mock.patch('git_cl.Changelist.RunHook').start()
3360
3361 def testDefaultCase(self):
3362 self.assertEqual(0, git_cl.main(['presubmit']))
3363 git_cl.Changelist.RunHook.assert_called_once_with(
3364 committing=True,
3365 may_prompt=False,
3366 verbose=0,
3367 parallel=None,
3368 upstream='upstream',
3369 description='fetch description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003370 all_files=None,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003371 resultdb=None,
3372 realm=None)
Edward Lemur9468eba2020-02-27 19:07:22 +00003373
3374 def testNoIssue(self):
3375 git_cl.Changelist.GetIssue.return_value = None
3376 self.assertEqual(0, git_cl.main(['presubmit']))
3377 git_cl.Changelist.RunHook.assert_called_once_with(
3378 committing=True,
3379 may_prompt=False,
3380 verbose=0,
3381 parallel=None,
3382 upstream='upstream',
3383 description='get description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003384 all_files=None,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003385 resultdb=None,
3386 realm=None)
Edward Lemur9468eba2020-02-27 19:07:22 +00003387
3388 def testCustomBranch(self):
3389 self.assertEqual(0, git_cl.main(['presubmit', 'custom_branch']))
3390 git_cl.Changelist.RunHook.assert_called_once_with(
3391 committing=True,
3392 may_prompt=False,
3393 verbose=0,
3394 parallel=None,
3395 upstream='custom_branch',
3396 description='fetch description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003397 all_files=None,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003398 resultdb=None,
3399 realm=None)
Edward Lemur9468eba2020-02-27 19:07:22 +00003400
3401 def testOptions(self):
3402 self.assertEqual(
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003403 0, git_cl.main(['presubmit', '-v', '-v', '--all', '--parallel', '-u',
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003404 '--resultdb', '--realm', 'chromium:public']))
Edward Lemur9468eba2020-02-27 19:07:22 +00003405 git_cl.Changelist.RunHook.assert_called_once_with(
3406 committing=False,
3407 may_prompt=False,
3408 verbose=2,
3409 parallel=True,
3410 upstream='upstream',
3411 description='fetch description',
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003412 all_files=True,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003413 resultdb=True,
3414 realm='chromium:public')
Edward Lemur9468eba2020-02-27 19:07:22 +00003415
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003416class CMDTryResultsTestCase(CMDTestCaseBase):
3417 _DEFAULT_REQUEST = {
3418 'predicate': {
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003419 "gerritChanges": [{
3420 "project": "depot_tools",
3421 "host": "chromium-review.googlesource.com",
Gavin Make61ccc52020-11-13 00:12:57 +00003422 "patchset": 6,
3423 "change": 123456,
3424 }],
3425 },
3426 'fields': ('builds.*.id,builds.*.builder,builds.*.status' +
3427 ',builds.*.createTime,builds.*.tags'),
3428 }
3429
3430 _TRIVIAL_REQUEST = {
3431 'predicate': {
3432 "gerritChanges": [{
3433 "project": "depot_tools",
3434 "host": "chromium-review.googlesource.com",
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003435 "patchset": 7,
3436 "change": 123456,
3437 }],
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003438 },
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003439 'fields': ('builds.*.id,builds.*.builder,builds.*.status' +
3440 ',builds.*.createTime,builds.*.tags'),
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003441 }
3442
3443 def testNoJobs(self):
3444 git_cl._call_buildbucket.return_value = {}
3445
3446 self.assertEqual(0, git_cl.main(['try-results']))
3447 self.assertEqual('No tryjobs scheduled.\n', sys.stdout.getvalue())
3448 git_cl._call_buildbucket.assert_called_once_with(
3449 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3450 self._DEFAULT_REQUEST)
3451
Gavin Make61ccc52020-11-13 00:12:57 +00003452 def testTrivialCommits(self):
3453 self.assertEqual(0, git_cl.main(['try-results']))
3454 git_cl._call_buildbucket.assert_called_with(
3455 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3456 self._DEFAULT_REQUEST)
3457
3458 git_cl._call_buildbucket.return_value = {}
3459 self.assertEqual(0, git_cl.main(['try-results', '--patchset', '7']))
3460 git_cl._call_buildbucket.assert_called_with(
3461 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3462 self._TRIVIAL_REQUEST)
3463 self.assertEqual([
3464 'Successes:',
3465 ' bot_success https://ci.chromium.org/b/103',
3466 'Infra Failures:',
3467 ' bot_infra_failure https://ci.chromium.org/b/105',
3468 'Failures:',
3469 ' bot_failure https://ci.chromium.org/b/104',
3470 'Canceled:',
3471 ' bot_canceled ',
3472 'Started:',
3473 ' bot_started https://ci.chromium.org/b/102',
3474 'Scheduled:',
3475 ' bot_scheduled id=101',
3476 'Other:',
3477 ' bot_status_unspecified id=100',
3478 'Total: 7 tryjobs',
3479 'No tryjobs scheduled.',
3480 ], sys.stdout.getvalue().splitlines())
3481
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003482 def testPrintToStdout(self):
3483 self.assertEqual(0, git_cl.main(['try-results']))
3484 self.assertEqual([
3485 'Successes:',
3486 ' bot_success https://ci.chromium.org/b/103',
3487 'Infra Failures:',
3488 ' bot_infra_failure https://ci.chromium.org/b/105',
3489 'Failures:',
3490 ' bot_failure https://ci.chromium.org/b/104',
3491 'Canceled:',
3492 ' bot_canceled ',
3493 'Started:',
3494 ' bot_started https://ci.chromium.org/b/102',
3495 'Scheduled:',
3496 ' bot_scheduled id=101',
3497 'Other:',
3498 ' bot_status_unspecified id=100',
3499 'Total: 7 tryjobs',
3500 ], sys.stdout.getvalue().splitlines())
3501 git_cl._call_buildbucket.assert_called_once_with(
3502 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3503 self._DEFAULT_REQUEST)
3504
3505 def testPrintToStdoutWithMasters(self):
3506 self.assertEqual(0, git_cl.main(['try-results', '--print-master']))
3507 self.assertEqual([
3508 'Successes:',
3509 ' try bot_success https://ci.chromium.org/b/103',
3510 'Infra Failures:',
3511 ' try bot_infra_failure https://ci.chromium.org/b/105',
3512 'Failures:',
3513 ' try bot_failure https://ci.chromium.org/b/104',
3514 'Canceled:',
3515 ' try bot_canceled ',
3516 'Started:',
3517 ' try bot_started https://ci.chromium.org/b/102',
3518 'Scheduled:',
3519 ' try bot_scheduled id=101',
3520 'Other:',
3521 ' try bot_status_unspecified id=100',
3522 'Total: 7 tryjobs',
3523 ], sys.stdout.getvalue().splitlines())
3524 git_cl._call_buildbucket.assert_called_once_with(
3525 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3526 self._DEFAULT_REQUEST)
3527
3528 @mock.patch('git_cl.write_json')
3529 def testWriteToJson(self, mockJsonDump):
3530 self.assertEqual(0, git_cl.main(['try-results', '--json', 'file.json']))
3531 git_cl._call_buildbucket.assert_called_once_with(
3532 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3533 self._DEFAULT_REQUEST)
3534 mockJsonDump.assert_called_once_with(
3535 'file.json', self._DEFAULT_RESPONSE['builds'])
3536
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003537 def test_filter_failed_for_one_simple(self):
Edward Lemur45768512020-03-02 19:03:14 +00003538 self.assertEqual([], git_cl._filter_failed_for_retry([]))
3539 self.assertEqual(
3540 [
3541 ('chromium', 'try', 'bot_failure'),
3542 ('chromium', 'try', 'bot_infra_failure'),
3543 ],
3544 git_cl._filter_failed_for_retry(self._DEFAULT_RESPONSE['builds']))
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003545
3546 def test_filter_failed_for_retry_many_builds(self):
3547
3548 def _build(name, created_sec, status, experimental=False):
3549 assert 0 <= created_sec < 100, created_sec
3550 b = {
3551 'id': 112112,
3552 'builder': {
3553 'project': 'chromium',
3554 'bucket': 'try',
3555 'builder': name,
3556 },
3557 'createTime': '2019-10-09T08:00:%02d.854286Z' % created_sec,
3558 'status': status,
3559 'tags': [],
3560 }
3561 if experimental:
3562 b['tags'].append({'key': 'cq_experimental', 'value': 'true'})
3563 return b
3564
3565 builds = [
3566 _build('flaky-last-green', 1, 'FAILURE'),
3567 _build('flaky-last-green', 2, 'SUCCESS'),
3568 _build('flaky', 1, 'SUCCESS'),
3569 _build('flaky', 2, 'FAILURE'),
3570 _build('running', 1, 'FAILED'),
3571 _build('running', 2, 'SCHEDULED'),
3572 _build('yep-still-running', 1, 'STARTED'),
3573 _build('yep-still-running', 2, 'FAILURE'),
3574 _build('cq-experimental', 1, 'SUCCESS', experimental=True),
3575 _build('cq-experimental', 2, 'FAILURE', experimental=True),
3576
3577 # Simulate experimental in CQ builder, which developer decided
3578 # to retry manually which resulted in 2nd build non-experimental.
3579 _build('sometimes-experimental', 1, 'FAILURE', experimental=True),
3580 _build('sometimes-experimental', 2, 'FAILURE', experimental=False),
3581 ]
3582 builds.sort(key=lambda b: b['status']) # ~deterministic shuffle.
Edward Lemur45768512020-03-02 19:03:14 +00003583 self.assertEqual(
3584 [
3585 ('chromium', 'try', 'flaky'),
3586 ('chromium', 'try', 'sometimes-experimental'),
3587 ],
3588 git_cl._filter_failed_for_retry(builds))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003589
3590
3591class CMDTryTestCase(CMDTestCaseBase):
3592
3593 @mock.patch('git_cl.Changelist.SetCQState')
Edward Lemur45768512020-03-02 19:03:14 +00003594 def testSetCQDryRunByDefault(self, mockSetCQState):
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003595 mockSetCQState.return_value = 0
Edward Lemur4c707a22019-09-24 21:13:43 +00003596 self.assertEqual(0, git_cl.main(['try']))
3597 git_cl.Changelist.SetCQState.assert_called_with(git_cl._CQState.DRY_RUN)
3598 self.assertEqual(
3599 sys.stdout.getvalue(),
3600 'Scheduling CQ dry run on: '
3601 'https://chromium-review.googlesource.com/123456\n')
3602
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00003603 @mock.patch('git_cl.Changelist.SetCQState')
3604 def testSetCQQuickRunByDefault(self, mockSetCQState):
3605 mockSetCQState.return_value = 0
3606 self.assertEqual(0, git_cl.main(['try', '-q']))
3607 git_cl.Changelist.SetCQState.assert_called_with(git_cl._CQState.QUICK_RUN)
3608 self.assertEqual(
3609 sys.stdout.getvalue(),
3610 'Scheduling CQ quick run on: '
3611 'https://chromium-review.googlesource.com/123456\n')
3612
Edward Lemur4c707a22019-09-24 21:13:43 +00003613 @mock.patch('git_cl._call_buildbucket')
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003614 def testScheduleOnBuildbucket(self, mockCallBuildbucket):
Edward Lemur4c707a22019-09-24 21:13:43 +00003615 mockCallBuildbucket.return_value = {}
Edward Lemur4c707a22019-09-24 21:13:43 +00003616
3617 self.assertEqual(0, git_cl.main([
3618 'try', '-B', 'luci.chromium.try', '-b', 'win',
3619 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
3620 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003621 'Scheduling jobs on:\n'
3622 ' chromium/try: win',
Edward Lemur4c707a22019-09-24 21:13:43 +00003623 git_cl.sys.stdout.getvalue())
3624
3625 expected_request = {
3626 "requests": [{
3627 "scheduleBuild": {
3628 "requestId": "uuid4",
3629 "builder": {
3630 "project": "chromium",
3631 "builder": "win",
3632 "bucket": "try",
3633 },
3634 "gerritChanges": [{
3635 "project": "depot_tools",
3636 "host": "chromium-review.googlesource.com",
3637 "patchset": 7,
3638 "change": 123456,
3639 }],
3640 "properties": {
3641 "category": "git_cl_try",
3642 "json": [{"a": 1}, None],
3643 "key": "val",
3644 },
3645 "tags": [
3646 {"value": "win", "key": "builder"},
3647 {"value": "git_cl_try", "key": "user_agent"},
3648 ],
3649 },
3650 }],
3651 }
3652 mockCallBuildbucket.assert_called_with(
3653 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3654
Anthony Polito1a5fe232020-01-24 23:17:52 +00003655 @mock.patch('git_cl._call_buildbucket')
3656 def testScheduleOnBuildbucketWithRevision(self, mockCallBuildbucket):
3657 mockCallBuildbucket.return_value = {}
Josip Sokcevic9011a5b2021-02-12 18:59:44 +00003658 mock.patch('git_cl.Changelist.GetRemoteBranch',
3659 return_value=('origin', 'refs/remotes/origin/main')).start()
Anthony Polito1a5fe232020-01-24 23:17:52 +00003660
3661 self.assertEqual(0, git_cl.main([
3662 'try', '-B', 'luci.chromium.try', '-b', 'win', '-b', 'linux',
3663 '-p', 'key=val', '-p', 'json=[{"a":1}, null]',
3664 '-r', 'beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef']))
3665 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003666 'Scheduling jobs on:\n'
3667 ' chromium/try: linux\n'
3668 ' chromium/try: win',
Anthony Polito1a5fe232020-01-24 23:17:52 +00003669 git_cl.sys.stdout.getvalue())
3670
3671 expected_request = {
3672 "requests": [{
3673 "scheduleBuild": {
3674 "requestId": "uuid4",
3675 "builder": {
3676 "project": "chromium",
3677 "builder": "linux",
3678 "bucket": "try",
3679 },
3680 "gerritChanges": [{
3681 "project": "depot_tools",
3682 "host": "chromium-review.googlesource.com",
3683 "patchset": 7,
3684 "change": 123456,
3685 }],
3686 "properties": {
3687 "category": "git_cl_try",
3688 "json": [{"a": 1}, None],
3689 "key": "val",
3690 },
3691 "tags": [
3692 {"value": "linux", "key": "builder"},
3693 {"value": "git_cl_try", "key": "user_agent"},
3694 ],
3695 "gitilesCommit": {
3696 "host": "chromium-review.googlesource.com",
3697 "project": "depot_tools",
3698 "id": "beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef",
Josip Sokcevic9011a5b2021-02-12 18:59:44 +00003699 "ref": "refs/heads/main",
Anthony Polito1a5fe232020-01-24 23:17:52 +00003700 }
3701 },
3702 },
3703 {
3704 "scheduleBuild": {
3705 "requestId": "uuid4",
3706 "builder": {
3707 "project": "chromium",
3708 "builder": "win",
3709 "bucket": "try",
3710 },
3711 "gerritChanges": [{
3712 "project": "depot_tools",
3713 "host": "chromium-review.googlesource.com",
3714 "patchset": 7,
3715 "change": 123456,
3716 }],
3717 "properties": {
3718 "category": "git_cl_try",
3719 "json": [{"a": 1}, None],
3720 "key": "val",
3721 },
3722 "tags": [
3723 {"value": "win", "key": "builder"},
3724 {"value": "git_cl_try", "key": "user_agent"},
3725 ],
3726 "gitilesCommit": {
3727 "host": "chromium-review.googlesource.com",
3728 "project": "depot_tools",
3729 "id": "beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef",
Josip Sokcevic9011a5b2021-02-12 18:59:44 +00003730 "ref": "refs/heads/main",
Anthony Polito1a5fe232020-01-24 23:17:52 +00003731 }
3732 },
3733 }],
3734 }
3735 mockCallBuildbucket.assert_called_with(
3736 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3737
Edward Lemur45768512020-03-02 19:03:14 +00003738 @mock.patch('sys.stderr', StringIO())
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003739 def testScheduleOnBuildbucket_WrongBucket(self):
Edward Lemur45768512020-03-02 19:03:14 +00003740 with self.assertRaises(SystemExit):
3741 git_cl.main([
3742 'try', '-B', 'not-a-bucket', '-b', 'win',
3743 '-p', 'key=val', '-p', 'json=[{"a":1}, null]'])
Edward Lemur4c707a22019-09-24 21:13:43 +00003744 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003745 'Invalid bucket: not-a-bucket.',
3746 sys.stderr.getvalue())
Edward Lemur4c707a22019-09-24 21:13:43 +00003747
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003748 @mock.patch('git_cl._call_buildbucket')
Quinten Yearsley777660f2020-03-04 23:37:06 +00003749 @mock.patch('git_cl._fetch_tryjobs')
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003750 def testScheduleOnBuildbucketRetryFailed(
3751 self, mockFetchTryJobs, mockCallBuildbucket):
Quinten Yearsley777660f2020-03-04 23:37:06 +00003752 git_cl._fetch_tryjobs.side_effect = lambda *_, **kw: {
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003753 7: [],
3754 6: [{
3755 'id': 112112,
3756 'builder': {
3757 'project': 'chromium',
3758 'bucket': 'try',
Quinten Yearsley777660f2020-03-04 23:37:06 +00003759 'builder': 'linux', },
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003760 'createTime': '2019-10-09T08:00:01.854286Z',
3761 'tags': [],
Quinten Yearsley777660f2020-03-04 23:37:06 +00003762 'status': 'FAILURE', }], }[kw['patchset']]
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003763 mockCallBuildbucket.return_value = {}
3764
3765 self.assertEqual(0, git_cl.main(['try', '--retry-failed']))
3766 self.assertIn(
Edward Lemur45768512020-03-02 19:03:14 +00003767 'Scheduling jobs on:\n'
3768 ' chromium/try: linux',
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003769 git_cl.sys.stdout.getvalue())
3770
3771 expected_request = {
3772 "requests": [{
3773 "scheduleBuild": {
3774 "requestId": "uuid4",
3775 "builder": {
3776 "project": "chromium",
3777 "bucket": "try",
3778 "builder": "linux",
3779 },
3780 "gerritChanges": [{
3781 "project": "depot_tools",
3782 "host": "chromium-review.googlesource.com",
3783 "patchset": 7,
3784 "change": 123456,
3785 }],
3786 "properties": {
3787 "category": "git_cl_try",
3788 },
3789 "tags": [
3790 {"value": "linux", "key": "builder"},
3791 {"value": "git_cl_try", "key": "user_agent"},
3792 {"value": "1", "key": "retry_failed"},
3793 ],
3794 },
3795 }],
3796 }
3797 mockCallBuildbucket.assert_called_with(
3798 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3799
Edward Lemur4c707a22019-09-24 21:13:43 +00003800 def test_parse_bucket(self):
3801 test_cases = [
3802 {
3803 'bucket': 'chromium/try',
3804 'result': ('chromium', 'try'),
3805 },
3806 {
3807 'bucket': 'luci.chromium.try',
3808 'result': ('chromium', 'try'),
3809 'has_warning': True,
3810 },
3811 {
3812 'bucket': 'skia.primary',
3813 'result': ('skia', 'skia.primary'),
3814 'has_warning': True,
3815 },
3816 {
3817 'bucket': 'not-a-bucket',
3818 'result': (None, None),
3819 },
3820 ]
3821
3822 for test_case in test_cases:
3823 git_cl.sys.stdout.truncate(0)
3824 self.assertEqual(
3825 test_case['result'], git_cl._parse_bucket(test_case['bucket']))
3826 if test_case.get('has_warning'):
Edward Lemur6215c792019-10-03 21:59:05 +00003827 expected_warning = 'WARNING Please use %s/%s to specify the bucket' % (
3828 test_case['result'])
3829 self.assertIn(expected_warning, git_cl.sys.stdout.getvalue())
Edward Lemur4c707a22019-09-24 21:13:43 +00003830
3831
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003832class CMDUploadTestCase(CMDTestCaseBase):
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +00003833
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003834 def setUp(self):
3835 super(CMDUploadTestCase, self).setUp()
Quinten Yearsley777660f2020-03-04 23:37:06 +00003836 mock.patch('git_cl._fetch_tryjobs').start()
3837 mock.patch('git_cl._trigger_tryjobs', return_value={}).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003838 mock.patch('git_cl.Changelist.CMDUpload', return_value=0).start()
Edward Lesmes0dd54822020-03-26 18:24:25 +00003839 mock.patch('git_cl.Settings.GetRoot', return_value='').start()
3840 mock.patch(
3841 'git_cl.Settings.GetSquashGerritUploads',
3842 return_value=True).start()
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003843 self.addCleanup(mock.patch.stopall)
3844
Edward Lesmes7677e5c2020-02-19 20:39:03 +00003845 def testWarmUpChangeDetailCache(self):
3846 self.assertEqual(0, git_cl.main(['upload']))
3847 gerrit_util.GetChangeDetail.assert_called_once_with(
3848 'chromium-review.googlesource.com', 'depot_tools~123456',
3849 frozenset([
3850 'LABELS', 'CURRENT_REVISION', 'DETAILED_ACCOUNTS',
3851 'CURRENT_COMMIT']))
3852
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003853 def testUploadRetryFailed(self):
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003854 # This test mocks out the actual upload part, and just asserts that after
3855 # upload, if --retry-failed is added, then the tool will fetch try jobs
3856 # from the previous patchset and trigger the right builders on the latest
3857 # patchset.
Quinten Yearsley777660f2020-03-04 23:37:06 +00003858 git_cl._fetch_tryjobs.side_effect = [
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003859 # Latest patchset: No builds.
3860 [],
3861 # Patchset before latest: Some builds.
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003862 [{
3863 'id': str(100 + idx),
3864 'builder': {
3865 'project': 'chromium',
3866 'bucket': 'try',
3867 'builder': 'bot_' + status.lower(),
3868 },
3869 'createTime': '2019-10-09T08:00:0%d.854286Z' % (idx % 10),
3870 'tags': [],
3871 'status': status,
3872 } for idx, status in enumerate(self._STATUSES)],
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +00003873 ]
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003874
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003875 self.assertEqual(0, git_cl.main(['upload', '--retry-failed']))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003876 self.assertEqual([
Edward Lemur5b929a42019-10-21 17:57:39 +00003877 mock.call(mock.ANY, 'cr-buildbucket.appspot.com', patchset=7),
3878 mock.call(mock.ANY, 'cr-buildbucket.appspot.com', patchset=6),
Quinten Yearsley777660f2020-03-04 23:37:06 +00003879 ], git_cl._fetch_tryjobs.mock_calls)
Edward Lemur45768512020-03-02 19:03:14 +00003880 expected_buckets = [
3881 ('chromium', 'try', 'bot_failure'),
3882 ('chromium', 'try', 'bot_infra_failure'),
3883 ]
Quinten Yearsley777660f2020-03-04 23:37:06 +00003884 git_cl._trigger_tryjobs.assert_called_once_with(mock.ANY, expected_buckets,
3885 mock.ANY, 8)
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003886
Brian Sheedy59b06a82019-10-14 17:03:29 +00003887
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +00003888class MakeRequestsHelperTestCase(unittest.TestCase):
3889
3890 def exampleGerritChange(self):
3891 return {
3892 'host': 'chromium-review.googlesource.com',
3893 'project': 'depot_tools',
3894 'change': 1,
3895 'patchset': 2,
3896 }
3897
3898 def testMakeRequestsHelperNoOptions(self):
3899 # Basic test for the helper function _make_tryjob_schedule_requests;
3900 # it shouldn't throw AttributeError even when options doesn't have any
3901 # of the expected values; it will use default option values.
3902 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3903 jobs = [('chromium', 'try', 'my-builder')]
3904 options = optparse.Values()
3905 requests = git_cl._make_tryjob_schedule_requests(
3906 changelist, jobs, options, patchset=None)
3907
3908 # requestId is non-deterministic. Just assert that it's there and has
3909 # a particular length.
3910 self.assertEqual(len(requests[0]['scheduleBuild'].pop('requestId')), 36)
3911 self.assertEqual(requests, [{
3912 'scheduleBuild': {
3913 'builder': {
3914 'bucket': 'try',
3915 'builder': 'my-builder',
3916 'project': 'chromium'
3917 },
3918 'gerritChanges': [self.exampleGerritChange()],
3919 'properties': {
3920 'category': 'git_cl_try'
3921 },
3922 'tags': [{
3923 'key': 'builder',
3924 'value': 'my-builder'
3925 }, {
3926 'key': 'user_agent',
3927 'value': 'git_cl_try'
3928 }]
3929 }
3930 }])
3931
3932 def testMakeRequestsHelperPresubmitSetsDryRunProperty(self):
3933 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3934 jobs = [('chromium', 'try', 'presubmit')]
3935 options = optparse.Values()
3936 requests = git_cl._make_tryjob_schedule_requests(
3937 changelist, jobs, options, patchset=None)
3938 self.assertEqual(requests[0]['scheduleBuild']['properties'], {
3939 'category': 'git_cl_try',
3940 'dry_run': 'true'
3941 })
3942
3943 def testMakeRequestsHelperRevisionSet(self):
3944 # Gitiles commit is specified when revision is in options.
3945 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3946 jobs = [('chromium', 'try', 'my-builder')]
3947 options = optparse.Values({'revision': 'ba5eba11'})
3948 requests = git_cl._make_tryjob_schedule_requests(
3949 changelist, jobs, options, patchset=None)
3950 self.assertEqual(
3951 requests[0]['scheduleBuild']['gitilesCommit'], {
3952 'host': 'chromium-review.googlesource.com',
3953 'id': 'ba5eba11',
Josip Sokcevic9011a5b2021-02-12 18:59:44 +00003954 'project': 'depot_tools',
3955 'ref': 'refs/heads/main',
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +00003956 })
3957
3958 def testMakeRequestsHelperRetryFailedSet(self):
3959 # An extra tag is added when retry_failed is in options.
3960 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3961 jobs = [('chromium', 'try', 'my-builder')]
3962 options = optparse.Values({'retry_failed': 'true'})
3963 requests = git_cl._make_tryjob_schedule_requests(
3964 changelist, jobs, options, patchset=None)
3965 self.assertEqual(
3966 requests[0]['scheduleBuild']['tags'], [
3967 {
3968 'key': 'builder',
3969 'value': 'my-builder'
3970 },
3971 {
3972 'key': 'user_agent',
3973 'value': 'git_cl_try'
3974 },
3975 {
3976 'key': 'retry_failed',
3977 'value': '1'
3978 }
3979 ])
3980
3981 def testMakeRequestsHelperCategorySet(self):
Quinten Yearsley925cedb2020-04-13 17:49:39 +00003982 # The category property can be overridden with options.
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +00003983 changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
3984 jobs = [('chromium', 'try', 'my-builder')]
3985 options = optparse.Values({'category': 'my-special-category'})
3986 requests = git_cl._make_tryjob_schedule_requests(
3987 changelist, jobs, options, patchset=None)
3988 self.assertEqual(requests[0]['scheduleBuild']['properties'],
3989 {'category': 'my-special-category'})
3990
3991
Edward Lemurda4b6c62020-02-13 00:28:40 +00003992class CMDFormatTestCase(unittest.TestCase):
Brian Sheedy59b06a82019-10-14 17:03:29 +00003993
3994 def setUp(self):
3995 super(CMDFormatTestCase, self).setUp()
Jamie Madill5e96ad12020-01-13 16:08:35 +00003996 mock.patch('git_cl.RunCommand').start()
3997 mock.patch('clang_format.FindClangFormatToolInChromiumTree').start()
3998 mock.patch('clang_format.FindClangFormatScriptInChromiumTree').start()
3999 mock.patch('git_cl.settings').start()
Brian Sheedy59b06a82019-10-14 17:03:29 +00004000 self._top_dir = tempfile.mkdtemp()
Jamie Madill5e96ad12020-01-13 16:08:35 +00004001 self.addCleanup(mock.patch.stopall)
Brian Sheedy59b06a82019-10-14 17:03:29 +00004002
4003 def tearDown(self):
4004 shutil.rmtree(self._top_dir)
4005 super(CMDFormatTestCase, self).tearDown()
4006
Jamie Madill5e96ad12020-01-13 16:08:35 +00004007 def _make_temp_file(self, fname, contents):
Anthony Politoc64e3902021-04-30 21:55:25 +00004008 gclient_utils.FileWrite(os.path.join(self._top_dir, fname),
4009 ('\n'.join(contents)))
Jamie Madill5e96ad12020-01-13 16:08:35 +00004010
Brian Sheedy59b06a82019-10-14 17:03:29 +00004011 def _make_yapfignore(self, contents):
Jamie Madill5e96ad12020-01-13 16:08:35 +00004012 self._make_temp_file('.yapfignore', contents)
Brian Sheedy59b06a82019-10-14 17:03:29 +00004013
Brian Sheedyb4307d52019-12-02 19:18:17 +00004014 def _check_yapf_filtering(self, files, expected):
4015 self.assertEqual(expected, git_cl._FilterYapfIgnoredFiles(
4016 files, git_cl._GetYapfIgnorePatterns(self._top_dir)))
Brian Sheedy59b06a82019-10-14 17:03:29 +00004017
Edward Lemur1a83da12020-03-04 21:18:36 +00004018 def _run_command_mock(self, return_value):
4019 def f(*args, **kwargs):
4020 if 'stdin' in kwargs:
4021 self.assertIsInstance(kwargs['stdin'], bytes)
4022 return return_value
4023 return f
4024
Jamie Madill5e96ad12020-01-13 16:08:35 +00004025 def testClangFormatDiffFull(self):
4026 self._make_temp_file('test.cc', ['// test'])
4027 git_cl.settings.GetFormatFullByDefault.return_value = False
4028 diff_file = [os.path.join(self._top_dir, 'test.cc')]
4029 mock_opts = mock.Mock(full=True, dry_run=True, diff=False)
4030
4031 # Diff
Edward Lemur1a83da12020-03-04 21:18:36 +00004032 git_cl.RunCommand.side_effect = self._run_command_mock(' // test')
Jamie Madill5e96ad12020-01-13 16:08:35 +00004033 return_value = git_cl._RunClangFormatDiff(mock_opts, diff_file,
4034 self._top_dir, 'HEAD')
4035 self.assertEqual(2, return_value)
4036
4037 # No diff
Edward Lemur1a83da12020-03-04 21:18:36 +00004038 git_cl.RunCommand.side_effect = self._run_command_mock('// test')
Jamie Madill5e96ad12020-01-13 16:08:35 +00004039 return_value = git_cl._RunClangFormatDiff(mock_opts, diff_file,
4040 self._top_dir, 'HEAD')
4041 self.assertEqual(0, return_value)
4042
4043 def testClangFormatDiff(self):
4044 git_cl.settings.GetFormatFullByDefault.return_value = False
Josip Sokcevic464e9ff2020-03-18 23:48:55 +00004045 # A valid file is required, so use this test.
4046 clang_format.FindClangFormatToolInChromiumTree.return_value = __file__
Jamie Madill5e96ad12020-01-13 16:08:35 +00004047 mock_opts = mock.Mock(full=False, dry_run=True, diff=False)
4048
4049 # Diff
Edward Lemur1a83da12020-03-04 21:18:36 +00004050 git_cl.RunCommand.side_effect = self._run_command_mock('error')
4051 return_value = git_cl._RunClangFormatDiff(
4052 mock_opts, ['.'], self._top_dir, 'HEAD')
Jamie Madill5e96ad12020-01-13 16:08:35 +00004053 self.assertEqual(2, return_value)
4054
4055 # No diff
Edward Lemur1a83da12020-03-04 21:18:36 +00004056 git_cl.RunCommand.side_effect = self._run_command_mock('')
Jamie Madill5e96ad12020-01-13 16:08:35 +00004057 return_value = git_cl._RunClangFormatDiff(mock_opts, ['.'], self._top_dir,
4058 'HEAD')
4059 self.assertEqual(0, return_value)
4060
Brian Sheedyb4307d52019-12-02 19:18:17 +00004061 def testYapfignoreExplicit(self):
4062 self._make_yapfignore(['foo/bar.py', 'foo/bar/baz.py'])
4063 files = [
4064 'bar.py',
4065 'foo/bar.py',
4066 'foo/baz.py',
4067 'foo/bar/baz.py',
4068 'foo/bar/foobar.py',
4069 ]
4070 expected = [
4071 'bar.py',
4072 'foo/baz.py',
4073 'foo/bar/foobar.py',
4074 ]
4075 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00004076
Brian Sheedyb4307d52019-12-02 19:18:17 +00004077 def testYapfignoreSingleWildcards(self):
4078 self._make_yapfignore(['*bar.py', 'foo*', 'baz*.py'])
4079 files = [
4080 'bar.py', # Matched by *bar.py.
4081 'bar.txt',
4082 'foobar.py', # Matched by *bar.py, foo*.
4083 'foobar.txt', # Matched by foo*.
4084 'bazbar.py', # Matched by *bar.py, baz*.py.
4085 'bazbar.txt',
4086 'foo/baz.txt', # Matched by foo*.
4087 'bar/bar.py', # Matched by *bar.py.
4088 'baz/foo.py', # Matched by baz*.py, foo*.
4089 'baz/foo.txt',
4090 ]
4091 expected = [
4092 'bar.txt',
4093 'bazbar.txt',
4094 'baz/foo.txt',
4095 ]
4096 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00004097
Brian Sheedyb4307d52019-12-02 19:18:17 +00004098 def testYapfignoreMultiplewildcards(self):
4099 self._make_yapfignore(['*bar*', '*foo*baz.txt'])
4100 files = [
4101 'bar.py', # Matched by *bar*.
4102 'bar.txt', # Matched by *bar*.
4103 'abar.py', # Matched by *bar*.
4104 'foobaz.txt', # Matched by *foo*baz.txt.
4105 'foobaz.py',
4106 'afoobaz.txt', # Matched by *foo*baz.txt.
4107 ]
4108 expected = [
4109 'foobaz.py',
4110 ]
4111 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00004112
4113 def testYapfignoreComments(self):
4114 self._make_yapfignore(['test.py', '#test2.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00004115 files = [
4116 'test.py',
4117 'test2.py',
4118 ]
4119 expected = [
4120 'test2.py',
4121 ]
4122 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00004123
Anthony Politoc64e3902021-04-30 21:55:25 +00004124 def testYapfHandleUtf8(self):
4125 self._make_yapfignore(['test.py', 'test_🌐.py'])
4126 files = [
4127 'test.py',
4128 'test_🌐.py',
4129 'test2.py',
4130 ]
4131 expected = [
4132 'test2.py',
4133 ]
4134 self._check_yapf_filtering(files, expected)
4135
Brian Sheedy59b06a82019-10-14 17:03:29 +00004136 def testYapfignoreBlankLines(self):
4137 self._make_yapfignore(['test.py', '', '', 'test2.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00004138 files = [
4139 'test.py',
4140 'test2.py',
4141 'test3.py',
4142 ]
4143 expected = [
4144 'test3.py',
4145 ]
4146 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00004147
4148 def testYapfignoreWhitespace(self):
4149 self._make_yapfignore([' test.py '])
Brian Sheedyb4307d52019-12-02 19:18:17 +00004150 files = [
4151 'test.py',
4152 'test2.py',
4153 ]
4154 expected = [
4155 'test2.py',
4156 ]
4157 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00004158
Brian Sheedyb4307d52019-12-02 19:18:17 +00004159 def testYapfignoreNoFiles(self):
Brian Sheedy59b06a82019-10-14 17:03:29 +00004160 self._make_yapfignore(['test.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00004161 self._check_yapf_filtering([], [])
4162
4163 def testYapfignoreMissingYapfignore(self):
4164 files = [
4165 'test.py',
4166 ]
4167 expected = [
4168 'test.py',
4169 ]
4170 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00004171
4172
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00004173class CMDStatusTestCase(CMDTestCaseBase):
4174 # Return branch names a,..,f with comitterdates in increasing order, i.e.
4175 # 'f' is the most-recently changed branch.
4176 def _mock_run_git(commands):
4177 if commands == [
4178 'for-each-ref', '--format=%(refname) %(committerdate:unix)',
4179 'refs/heads'
4180 ]:
4181 branches_and_committerdates = [
4182 'refs/heads/a 1',
4183 'refs/heads/b 2',
4184 'refs/heads/c 3',
4185 'refs/heads/d 4',
4186 'refs/heads/e 5',
4187 'refs/heads/f 6',
4188 ]
4189 return '\n'.join(branches_and_committerdates)
4190
4191 # Mock the status in such a way that the issue number gives us an
4192 # indication of the commit date (simplifies manual debugging).
4193 def _mock_get_cl_statuses(branches, fine_grained, max_processes):
4194 for c in branches:
4195 c.issue = (100 + int(c.GetCommitDate()))
4196 yield (c, 'open')
4197
4198 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
4199 @mock.patch('git_cl.Changelist.FetchDescription', lambda cl, pretty: 'x')
4200 @mock.patch('git_cl.Changelist.GetIssue', lambda cl: cl.issue)
4201 @mock.patch('git_cl.RunGit', _mock_run_git)
4202 @mock.patch('git_cl.get_cl_statuses', _mock_get_cl_statuses)
4203 @mock.patch('git_cl.Settings.GetRoot', return_value='')
Sigurd Schneider1bfda8e2021-06-30 14:46:25 +00004204 @mock.patch('git_cl.Settings.IsStatusCommitOrderByDate', return_value=False)
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00004205 @mock.patch('scm.GIT.GetBranch', return_value='a')
4206 def testStatus(self, *_mocks):
4207 self.assertEqual(0, git_cl.main(['status', '--no-branch-color']))
4208 self.maxDiff = None
4209 self.assertEqual(
4210 sys.stdout.getvalue(), 'Branches associated with reviews:\n'
4211 ' * a : https://crrev.com/c/101 (open)\n'
4212 ' b : https://crrev.com/c/102 (open)\n'
4213 ' c : https://crrev.com/c/103 (open)\n'
4214 ' d : https://crrev.com/c/104 (open)\n'
4215 ' e : https://crrev.com/c/105 (open)\n'
4216 ' f : https://crrev.com/c/106 (open)\n\n'
4217 'Current branch: a\n'
4218 'Issue number: 101 (https://chromium-review.googlesource.com/101)\n'
4219 'Issue description:\n'
4220 'x\n')
4221
4222 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
4223 @mock.patch('git_cl.Changelist.FetchDescription', lambda cl, pretty: 'x')
4224 @mock.patch('git_cl.Changelist.GetIssue', lambda cl: cl.issue)
4225 @mock.patch('git_cl.RunGit', _mock_run_git)
4226 @mock.patch('git_cl.get_cl_statuses', _mock_get_cl_statuses)
4227 @mock.patch('git_cl.Settings.GetRoot', return_value='')
Sigurd Schneider1bfda8e2021-06-30 14:46:25 +00004228 @mock.patch('git_cl.Settings.IsStatusCommitOrderByDate', return_value=False)
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00004229 @mock.patch('scm.GIT.GetBranch', return_value='a')
4230 def testStatusByDate(self, *_mocks):
4231 self.assertEqual(
4232 0, git_cl.main(['status', '--no-branch-color', '--date-order']))
4233 self.maxDiff = None
4234 self.assertEqual(
4235 sys.stdout.getvalue(), 'Branches associated with reviews:\n'
4236 ' f : https://crrev.com/c/106 (open)\n'
4237 ' e : https://crrev.com/c/105 (open)\n'
4238 ' d : https://crrev.com/c/104 (open)\n'
4239 ' c : https://crrev.com/c/103 (open)\n'
4240 ' b : https://crrev.com/c/102 (open)\n'
4241 ' * a : https://crrev.com/c/101 (open)\n\n'
4242 'Current branch: a\n'
4243 'Issue number: 101 (https://chromium-review.googlesource.com/101)\n'
4244 'Issue description:\n'
4245 'x\n')
4246
Sigurd Schneider1bfda8e2021-06-30 14:46:25 +00004247 @mock.patch('git_cl.Changelist.EnsureAuthenticated')
4248 @mock.patch('git_cl.Changelist.FetchDescription', lambda cl, pretty: 'x')
4249 @mock.patch('git_cl.Changelist.GetIssue', lambda cl: cl.issue)
4250 @mock.patch('git_cl.RunGit', _mock_run_git)
4251 @mock.patch('git_cl.get_cl_statuses', _mock_get_cl_statuses)
4252 @mock.patch('git_cl.Settings.GetRoot', return_value='')
4253 @mock.patch('git_cl.Settings.IsStatusCommitOrderByDate', return_value=True)
4254 @mock.patch('scm.GIT.GetBranch', return_value='a')
4255 def testStatusByDate(self, *_mocks):
4256 self.assertEqual(
4257 0, git_cl.main(['status', '--no-branch-color']))
4258 self.maxDiff = None
4259 self.assertEqual(
4260 sys.stdout.getvalue(), 'Branches associated with reviews:\n'
4261 ' f : https://crrev.com/c/106 (open)\n'
4262 ' e : https://crrev.com/c/105 (open)\n'
4263 ' d : https://crrev.com/c/104 (open)\n'
4264 ' c : https://crrev.com/c/103 (open)\n'
4265 ' b : https://crrev.com/c/102 (open)\n'
4266 ' * a : https://crrev.com/c/101 (open)\n\n'
4267 'Current branch: a\n'
4268 'Issue number: 101 (https://chromium-review.googlesource.com/101)\n'
4269 'Issue description:\n'
4270 'x\n')
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00004271
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004272class CMDOwnersTestCase(CMDTestCaseBase):
4273 def setUp(self):
4274 super(CMDOwnersTestCase, self).setUp()
Edward Lesmes82b992a2021-01-11 23:24:55 +00004275 self.owners_by_path = {
4276 'foo': ['a@example.com'],
4277 'bar': ['b@example.com', 'c@example.com'],
4278 }
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004279 mock.patch('git_cl.Settings.GetRoot', return_value='root').start()
4280 mock.patch('git_cl.Changelist.GetAuthor', return_value='author').start()
4281 mock.patch(
Edward Lesmes82b992a2021-01-11 23:24:55 +00004282 'git_cl.Changelist.GetAffectedFiles',
4283 return_value=list(self.owners_by_path)).start()
4284 mock.patch(
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004285 'git_cl.Changelist.GetCommonAncestorWithUpstream',
4286 return_value='upstream').start()
Edward Lesmes82b992a2021-01-11 23:24:55 +00004287 mock.patch(
Edward Lesmese1576912021-02-16 21:53:34 +00004288 'git_cl.Changelist.GetGerritHost',
4289 return_value='host').start()
4290 mock.patch(
4291 'git_cl.Changelist.GetGerritProject',
4292 return_value='project').start()
4293 mock.patch(
4294 'git_cl.Changelist.GetRemoteBranch',
4295 return_value=('origin', 'refs/remotes/origin/main')).start()
4296 mock.patch(
4297 'owners_client.OwnersClient.BatchListOwners',
Edward Lesmes82b992a2021-01-11 23:24:55 +00004298 return_value=self.owners_by_path).start()
Edward Lesmes8170c292021-03-19 20:04:43 +00004299 mock.patch(
4300 'gerrit_util.IsCodeOwnersEnabledOnHost', return_value=True).start()
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004301 self.addCleanup(mock.patch.stopall)
4302
4303 def testShowAllNoArgs(self):
4304 self.assertEqual(0, git_cl.main(['owners', '--show-all']))
4305 self.assertEqual(
4306 'No files specified for --show-all. Nothing to do.\n',
4307 git_cl.sys.stdout.getvalue())
4308
4309 def testShowAll(self):
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004310 self.assertEqual(
4311 0,
4312 git_cl.main(['owners', '--show-all', 'foo', 'bar', 'baz']))
Edward Lesmese1576912021-02-16 21:53:34 +00004313 owners_client.OwnersClient.BatchListOwners.assert_called_once_with(
Edward Lesmes82b992a2021-01-11 23:24:55 +00004314 ['foo', 'bar', 'baz'])
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004315 self.assertEqual(
4316 '\n'.join([
4317 'Owners for foo:',
4318 ' - a@example.com',
4319 'Owners for bar:',
4320 ' - b@example.com',
4321 ' - c@example.com',
4322 'Owners for baz:',
4323 ' - No owners found',
4324 '',
4325 ]),
4326 sys.stdout.getvalue())
4327
Edward Lesmes82b992a2021-01-11 23:24:55 +00004328 def testBatch(self):
4329 self.assertEqual(0, git_cl.main(['owners', '--batch']))
4330 self.assertIn('a@example.com', sys.stdout.getvalue())
4331 self.assertIn('b@example.com', sys.stdout.getvalue())
4332
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004333
maruel@chromium.orgddd59412011-11-30 14:20:38 +00004334if __name__ == '__main__':
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +01004335 logging.basicConfig(
4336 level=logging.DEBUG if '-v' in sys.argv else logging.ERROR)
maruel@chromium.orgddd59412011-11-30 14:20:38 +00004337 unittest.main()