Delete nag_max and nag_timer
It's impossible to sync by default on Windows and has been since this was
added: https://www.google.com/search?q=chromium-dev+nag_max
Most recently: https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/CEpATyu9udc
So, remove it. If someone needs it they can figure out a more targeted
implementation.
Keep --no-nag-max for backwards compat so that bot scripts won't fail out.
I'll remove it from bot scripts after this has baked a while, and then
come back and remove the option.
R=iannucci@chromium.org
Review URL: https://chromiumcodereview.appspot.com/24950002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@225730 0039d316-1c4b-4281-b951-d872f2087c98
diff --git a/tests/gclient_scm_test.py b/tests/gclient_scm_test.py
index fa16be6..65b4ba7 100755
--- a/tests/gclient_scm_test.py
+++ b/tests/gclient_scm_test.py
@@ -109,8 +109,6 @@
'cleanup',
'diff',
'name',
- 'nag_max',
- 'nag_timer',
'pack',
'relpath',
'revert',
@@ -516,8 +514,6 @@
gclient_scm.gclient_utils.CheckCallAndFilterAndHeader(
['svn', 'checkout', '--depth', 'empty', self.url, self.base_path],
always=True,
- nag_max=30,
- nag_timer=30,
cwd=self.root_dir)
gclient_scm.scm.SVN.RunAndGetFileList(
options.verbose,
@@ -555,7 +551,7 @@
files_list = self.mox.CreateMockAnything()
gclient_scm.gclient_utils.CheckCallAndFilterAndHeader(
['svn', 'export', join(self.url, 'DEPS'), join(self.base_path, 'DEPS')],
- nag_timer=30, nag_max=30, always=True, cwd=self.root_dir)
+ always=True, cwd=self.root_dir)
self.mox.ReplayAll()
scm = self._scm_wrapper(url=self.url, root_dir=self.root_dir,
@@ -588,8 +584,6 @@
gclient_scm.gclient_utils.CheckCallAndFilterAndHeader(
['svn', 'checkout', '--depth', 'empty', self.url, self.base_path],
always=True,
- nag_max=30,
- nag_timer=30,
cwd=self.root_dir)
gclient_scm.scm.SVN.RunAndGetFileList(
options.verbose,
@@ -827,8 +821,6 @@
'cleanup',
'diff',
'name',
- 'nag_max',
- 'nag_timer',
'pack',
'UpdateSubmoduleConfig',
'relpath',