Implement owners check in presubmit for Gerrit.
R=machenbach@chromium.org,phajdan.jr@chromium.org
BUG=605563
Review-Url: https://codereview.chromium.org/1927773002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300320 0039d316-1c4b-4281-b951-d872f2087c98
diff --git a/git_cl.py b/git_cl.py
index 9bf60ea..bf94913 100755
--- a/git_cl.py
+++ b/git_cl.py
@@ -1317,7 +1317,8 @@
return presubmit_support.DoPresubmitChecks(change, committing,
verbose=verbose, output_stream=sys.stdout, input_stream=sys.stdin,
default_presubmit=None, may_prompt=may_prompt,
- rietveld_obj=self._codereview_impl.GetRieveldObjForPresubmit())
+ rietveld_obj=self._codereview_impl.GetRieveldObjForPresubmit(),
+ gerrit_obj=self._codereview_impl.GetGerritObjForPresubmit())
except presubmit_support.PresubmitFailure, e:
DieWithError(
('%s\nMaybe your depot_tools is out of date?\n'
@@ -1501,6 +1502,10 @@
# For non-Rietveld codereviews, this probably should return a dummy object.
raise NotImplementedError()
+ def GetGerritObjForPresubmit(self):
+ # None is valid return value, otherwise presubmit_support.GerritAccessor.
+ return None
+
def UpdateDescriptionRemote(self, description):
"""Update the description on codereview site."""
raise NotImplementedError()
@@ -2107,6 +2112,9 @@
raise NotImplementedError()
return ThisIsNotRietveldIssue()
+ def GetGerritObjForPresubmit(self):
+ return presubmit_support.GerritAccessor(self._GetGerritHost())
+
def GetStatus(self):
"""Apply a rough heuristic to give a simple summary of an issue's review
or CQ status, assuming adherence to a common workflow.