Reland of git cl try: don't skip presubmit builders, but set dry_run property.
With a fix: actually set dry_run for presubmit, and don't set it for other builders.
R=machenbach@chromium.org,sergiyb@chromium.org
BUG=601128,594127,591030
Review-Url: https://codereview.chromium.org/1926663002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300295 0039d316-1c4b-4281-b951-d872f2087c98
diff --git a/git_cl.py b/git_cl.py
index 0acb9cd..fd2dcea 100755
--- a/git_cl.py
+++ b/git_cl.py
@@ -337,6 +337,8 @@
'rietveld': rietveld_url,
},
}
+ if 'presubmit' in builder.lower():
+ parameters['properties']['dry_run'] = 'true'
if tests:
parameters['properties']['testfilter'] = tests
if properties:
@@ -4316,8 +4318,7 @@
for master, builders in cq_masters.iteritems():
for builder in builders:
# Skip presubmit builders, because these will fail without LGTM.
- if 'presubmit' not in builder.lower():
- masters.setdefault(master, {})[builder] = ['defaulttests']
+ masters.setdefault(master, {})[builder] = ['defaulttests']
if masters:
return masters