commit c5f0cbb8654b3c38dea5714e117c71bd7ab6136f
author Aravind Vasudevan <aravindvasudev@google.com> Mon Jan 24 23:56:57 2022 +0000
committer LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Jan 24 23:56:57 2022 +0000
tree 403ecd23e165c344cba78a9e389984d31bc9092f
parent d94f9a6d20c8607724b344adf214bedbda9d2d03

Use pylint 2.7 for depot_tools

This includes a few fixes for specific errors, and disables several new
warnings introduced in this version, in order to allow for an incremental migration.

Bug:1262286
Change-Id: I4b8f8fc521386419a3121bbb07edc8ac83170a94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3413679
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>

git_footers.py

diff --git a/git_footers.py b/git_footers.py
index 766a958..a096b6f 100755
--- a/git_footers.py
+++ b/git_footers.py
@@ -71,7 +71,8 @@
   for line in reversed(message_lines):
     if line == '' or line.isspace():
       break
-    elif parse_footer(line):
+
+    if parse_footer(line):
       footer_lines.extend(maybe_footer_lines)
       maybe_footer_lines = []
       footer_lines.append(line)
@@ -182,8 +183,8 @@
   assert len(values) <= 1, 'Multiple %s footers' % key
   if values:
     return values[0]
-  else:
-    return None
+
+  return None
 
 
 def get_position(footers):