commit c40b2406de90e245daf8897bc25c5eaf0211b9fb
author Edward Lesmes <ehmaldonado@google.com> Tue Jan 12 20:03:11 2021 +0000
committer LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Jan 12 20:03:11 2021 +0000
tree 253fb6893b62d7dfb62c81560dd08b1f462eb464
parent f6b414c57847249036ae4e6ea15d8ffe37e14cbe

owners: Move constants inside OwnersClient.

When used as part of presubmit's input_api, we only
expose OwnersClient and not global constants, so
move constants inside OwnersClient.

Change-Id: I8983c5edadafeebff62838d9cd4a19fdce908159
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2621744
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>

owners_client.py

diff --git a/owners_client.py b/owners_client.py
index fc75692..d40d799 100644
--- a/owners_client.py
+++ b/owners_client.py
@@ -13,11 +13,6 @@
 import scm
 
 
-APPROVED = 'APPROVED'
-PENDING = 'PENDING'
-INSUFFICIENT_REVIEWERS = 'INSUFFICIENT_REVIEWERS'
-
-
 def _owner_combinations(owners, num_owners):
   """Iterate owners combinations by decrasing score.
 
@@ -54,6 +49,10 @@
   All code should use this class to interact with OWNERS files instead of the
   owners database in owners.py
   """
+  APPROVED = 'APPROVED'
+  PENDING = 'PENDING'
+  INSUFFICIENT_REVIEWERS = 'INSUFFICIENT_REVIEWERS'
+
   def ListOwners(self, path):
     """List all owners for a file.
 
@@ -85,11 +84,11 @@
     for path, owners in owners_by_path.items():
       owners = set(owners)
       if owners.intersection(approvers):
-        status[path] = APPROVED
+        status[path] = self.APPROVED
       elif owners.intersection(reviewers):
-        status[path] = PENDING
+        status[path] = self.PENDING
       else:
-        status[path] = INSUFFICIENT_REVIEWERS
+        status[path] = self.INSUFFICIENT_REVIEWERS
     return status
 
   def SuggestOwners(self, paths):