commit b8164180d2c339940c99db74344c865e67ca064d
author Aravind Vasudevan <aravindvasudev@google.com> Fri Aug 25 21:49:12 2023 +0000
committer LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Aug 25 21:49:12 2023 +0000
tree a57ef7ccfb8fd8c154007a28b7ec7ec75f88783b
parent bb14391a5092f01557cf1fedfa3f7fe3afdbd1fb

Warn when fsmonitor is enabled and git submodules are used

Change-Id: I181bf180f762282d5b4bc614d12a91125f56e063
Bug: 1475405
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4814429
Auto-Submit: Aravind Vasudevan <aravindvasudev@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>

git_cl.py

diff --git a/git_cl.py b/git_cl.py
index b0f7efb..0b2d34f 100755
--- a/git_cl.py
+++ b/git_cl.py
@@ -4738,6 +4738,11 @@
                    if opt.help != optparse.SUPPRESS_HELP))
     return
 
+  # TODO(crbug.com/1475405): Warn users if the project uses submodules and
+  # they have fsmonitor enabled.
+  if os.path.isfile('.gitmodules'):
+    git_common.warn_submodule()
+
   if git_common.is_dirty_git_tree('upload'):
     return 1