commit b2cc4a94daa946aeb94c2bb9e5d34f56adfa71b2
author Quinten Yearsley <qyearsley@google.com> Thu Dec 15 13:53:26 2016 -0800
committer Commit Bot <commit-bot@chromium.org> Fri Dec 16 00:31:40 2016 +0000
tree 6cf81ba6a23c70d02651f76d58566e2475e5e7fc
parent 442fb64cab695a5fabec8ba32b1b733acd5b8ef8

depot_tools: Replace pylint error numbers with symbolic names.

This affects a bunch of files, but only changes comments,
and shouldn't make any difference to behavior.

The purpose is to slightly improve readability of pylint
disable comments.

Change-Id: Ic6cd0f8de792b31d91c6125f6da2616450b30f11
Reviewed-on: https://chromium-review.googlesource.com/420412
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>

tests/gclient_scm_test.py

diff --git a/tests/gclient_scm_test.py b/tests/gclient_scm_test.py
index 7acd59c..8c62491 100755
--- a/tests/gclient_scm_test.py
+++ b/tests/gclient_scm_test.py
@@ -42,14 +42,10 @@
       lines[i] = m.group(1)
   return ''.join(lines)
 
-# Access to a protected member XXX of a client class
-# pylint: disable=W0212
-
 
 class GCBaseTestCase(object):
   def assertRaisesError(self, msg, fn, *args, **kwargs):
     """Like unittest's assertRaises() but checks for Gclient.Error."""
-    # pylint: disable=E1101
     try:
       fn(*args, **kwargs)
     except gclient_scm.gclient_utils.Error, e:
@@ -192,7 +188,7 @@
   def checkstdout(self, expected):
     value = sys.stdout.getvalue()
     sys.stdout.close()
-    # pylint: disable=E1101
+    # pylint: disable=no-member
     self.assertEquals(expected, strip_timestamps(value))
 
   @staticmethod
@@ -572,7 +568,7 @@
   def checkstdout(self, expected):
     value = sys.stdout.getvalue()
     sys.stdout.close()
-    # pylint: disable=E1101
+    # pylint: disable=no-member
     self.assertEquals(expected, strip_timestamps(value))
 
   def setUp(self):
@@ -590,7 +586,7 @@
     BaseTestCase.tearDown(self)
 
   def testGetUsableRevGit(self):
-    # pylint: disable=E1101
+    # pylint: disable=no-member
     options = self.Options(verbose=True)
 
     self.mox.StubOutWithMock(gclient_scm.scm.GIT, 'IsValidRevision', True)
@@ -631,7 +627,7 @@
     gclient_scm.os.path.exists(os.path.join(self.base_path, '.git')
                                ).AndReturn(False)
     self.mox.StubOutWithMock(gclient_scm.GitWrapper, '_Clone', True)
-    # pylint: disable=E1120
+    # pylint: disable=no-value-for-parameter
     gclient_scm.GitWrapper._Clone('refs/remotes/origin/master', self.url,
                                   options)
     self.mox.StubOutWithMock(gclient_scm.subprocess2, 'check_output', True)
@@ -662,7 +658,7 @@
     gclient_scm.os.path.exists(os.path.join(self.base_path, '.git')
                                ).AndReturn(False)
     self.mox.StubOutWithMock(gclient_scm.GitWrapper, '_Clone', True)
-    # pylint: disable=E1120
+    # pylint: disable=no-value-for-parameter
     gclient_scm.GitWrapper._Clone(
         'refs/remotes/origin/master', self.url, options
     ).AndRaise(gclient_scm.subprocess2.CalledProcessError(None, None, None,
@@ -693,13 +689,13 @@
   def checkInStdout(self, expected):
     value = sys.stdout.getvalue()
     sys.stdout.close()
-    # pylint: disable=E1101
+    # pylint: disable=no-member
     self.assertIn(expected, value)
 
   def checkNotInStdout(self, expected):
     value = sys.stdout.getvalue()
     sys.stdout.close()
-    # pylint: disable=E1101
+    # pylint: disable=no-member
     self.assertNotIn(expected, value)
 
   def getCurrentBranch(self):