Disable the remaining pylint warnings locally and enable pylint warnings in PRESUBMIT.
This causes some code clutter.
TEST=Increased pylint warning level
BUG=none
Review URL: http://codereview.chromium.org/4321006
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@64913 0039d316-1c4b-4281-b951-d872f2087c98
diff --git a/gclient_utils.py b/gclient_utils.py
index ecc59cc..d0fbb1e 100644
--- a/gclient_utils.py
+++ b/gclient_utils.py
@@ -316,6 +316,8 @@
fileobj.delay = delay
return fileobj
+ # Attribute 'XXX' defined outside __init__
+ # pylint: disable=W0201
new_fileobj = SoftClone(fileobj)
if not hasattr(new_fileobj, 'lock'):
new_fileobj.lock = threading.Lock()
@@ -350,6 +352,8 @@
# Already patched.
return fileobj
+ # Attribute 'XXX' defined outside __init__
+ # pylint: disable=W0201
new_fileobj = SoftClone(fileobj)
if not hasattr(new_fileobj, 'lock'):
new_fileobj.lock = threading.Lock()
@@ -698,6 +702,8 @@
"""Runs in its own thread."""
logging.debug('running(%s)' % self.item.name)
work_queue = self.kwargs['work_queue']
+ # It's necessary to catch all exceptions.
+ # pylint: disable=W0703
try:
self.item.run(*self.args, **self.kwargs)
except Exception: