Revert "Generate patchset name from commit subject"
This reverts commit 947f2ee80883852e73fbe6fb2b624f354cebd800.
Reason for revert: unnecessarily sets the title for the first upload,
which isn't done for Rietveld.
Original change's description:
> Generate patchset name from commit subject
>
> BUG=672332
>
> Change-Id: If9c662f11b217a52cac7c9c47ad9f3d978148c2e
> Reviewed-on: https://chromium-review.googlesource.com/419330
> Commit-Queue: Aaron Gable <agable@chromium.org>
> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
>
TBR=agable@chromium.org,tandrii@chromium.org,chromium-reviews@chromium.org
BUG=672332
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Change-Id: I9dcec1b02c8f16ceca8338acef4a1fc174aef35c
Reviewed-on: https://chromium-review.googlesource.com/419517
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
diff --git a/git_cl.py b/git_cl.py
index be339c0..46af2bc 100755
--- a/git_cl.py
+++ b/git_cl.py
@@ -2934,20 +2934,16 @@
print('Adding self-LGTM (Code-Review +1) because of TBRs')
refspec_opts.append('l=Code-Review+1')
- title = options.title
- if not title:
- default = RunGit(['show', '-s', '--format=%s', 'HEAD']).strip()
- title = ask_for_data('Title for patchset [%s]: ' % default) or default
- if title:
- if not re.match(r'^[\w ]+$', title):
- title = re.sub(r'[^\w ]', '', title)
+ if options.title:
+ if not re.match(r'^[\w ]+$', options.title):
+ options.title = re.sub(r'[^\w ]', '', options.title)
print('WARNING: Patchset title may only contain alphanumeric chars '
- 'and spaces. Cleaned up title:\n%s' % title)
+ 'and spaces. Cleaned up title:\n%s' % options.title)
if not options.force:
ask_for_data('Press enter to continue, Ctrl+C to abort')
# Per doc, spaces must be converted to underscores, and Gerrit will do the
# reverse on its side.
- refspec_opts.append('m=' + title.replace(' ', '_'))
+ refspec_opts.append('m=' + options.title.replace(' ', '_'))
if options.send_mail:
if not change_desc.get_reviewers():