commit 93efa03156ee7b800898e5a0fedf01b0319425cf
author jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> Sat Mar 12 07:40:41 2011 +0000
committer jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> Sat Mar 12 07:40:41 2011 +0000
tree 6766246457816293e1484967f52798158fb432a4
parent 37248c0bbab0b4900abcc1c2e6f2867bd609d2b1

Revert 77913 - Regression: Editor Linux Fix for gcl.

Editor doesn't come up due to Shell=True

BUG=none
TEST=linux and win works
Review URL: http://codereview.chromium.org/6679023

TBR=mhm@chromium.org
Review URL: http://codereview.chromium.org/6684022

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77928 0039d316-1c4b-4281-b951-d872f2087c98

git_cl/git_cl.py

diff --git a/git_cl/git_cl.py b/git_cl/git_cl.py
index 083db60..8677adb 100644
--- a/git_cl/git_cl.py
+++ b/git_cl/git_cl.py
@@ -710,8 +710,9 @@
   fileobj.write(starting_text)
   fileobj.close()
 
+  result = None
   try:
-    subprocess.check_call(['env', editor, filename])
+    subprocess.check_call(['env', editor, filename], shell=True)
     fileobj = open(filename)
     result = fileobj.read()
     fileobj.close()