Allow git cl also in repos with read-only git-svn.
If you have read-only git-svn git cl would still try
to use svn commands, which would then fail. This
changes git cl to only use git-svn if the remote
svn repository use the svn:// protocol. It matches
how chromium works and it allowed me to upload a patch.
BUG=391430
R=iannucci
Review URL: https://codereview.chromium.org/344013005
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@281500 0039d316-1c4b-4281-b951-d872f2087c98
diff --git a/tests/git_cl_test.py b/tests/git_cl_test.py
index f7f57b4..3af5d30 100755
--- a/tests/git_cl_test.py
+++ b/tests/git_cl_test.py
@@ -207,8 +207,8 @@
] + cc_call + private_call + [
((['git', 'config', 'branch.master.base-url'],), ''),
((['git',
- 'config', '--local', '--get-regexp', '^svn-remote\\.'],),
- (('', None), 0)),
+ 'config', '--local', '--get-regexp', '^svn-remote\\..*\\.url'],),
+ (('svn-remote.mybranch.url svn://svn.chromium.org/chrome', None), 0)),
((['git', 'rev-parse', '--show-cdup'],), ''),
((['git', 'svn', 'info'],), ''),
((['git', 'config', 'rietveld.project'],), ''),
@@ -253,7 +253,7 @@
def _dcommit_calls_1(cls):
return [
((['git',
- 'config', '--local', '--get-regexp', '^svn-remote\\.'],),
+ 'config', '--local', '--get-regexp', '^svn-remote\\..*\\.url'],),
((('svn-remote.svn.url svn://svn.chromium.org/chrome\n'
'svn-remote.svn.fetch trunk/src:refs/remotes/origin/master'),
None),
@@ -775,7 +775,8 @@
''),
((['git', 'config', 'rietveld.private',],),
''),
- ((['git', 'config', '--local', '--get-regexp', '^svn-remote\\.'],),
+ ((['git', 'config', '--local', '--get-regexp',
+ '^svn-remote\\..*\\.url',],),
''),
((['git', 'config', 'rietveld.project',],),
''),