Revert of Implement owners check in presubmit for Gerrit. (patchset #5 id:80001 of https://codereview.chromium.org/1927773002/ )
Reason for revert:
now it doesn't work for gerrit. Damn it.
Original issue's description:
> Implement owners check in presubmit for Gerrit.
>
> R=machenbach@chromium.org,phajdan.jr@chromium.org
> BUG=605563
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300350
TBR=machenbach@chromium.org,phajdan.jr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=605563
Review-Url: https://codereview.chromium.org/1935563002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300352 0039d316-1c4b-4281-b951-d872f2087c98
diff --git a/git_cl.py b/git_cl.py
index bf94913..9bf60ea 100755
--- a/git_cl.py
+++ b/git_cl.py
@@ -1317,8 +1317,7 @@
return presubmit_support.DoPresubmitChecks(change, committing,
verbose=verbose, output_stream=sys.stdout, input_stream=sys.stdin,
default_presubmit=None, may_prompt=may_prompt,
- rietveld_obj=self._codereview_impl.GetRieveldObjForPresubmit(),
- gerrit_obj=self._codereview_impl.GetGerritObjForPresubmit())
+ rietveld_obj=self._codereview_impl.GetRieveldObjForPresubmit())
except presubmit_support.PresubmitFailure, e:
DieWithError(
('%s\nMaybe your depot_tools is out of date?\n'
@@ -1502,10 +1501,6 @@
# For non-Rietveld codereviews, this probably should return a dummy object.
raise NotImplementedError()
- def GetGerritObjForPresubmit(self):
- # None is valid return value, otherwise presubmit_support.GerritAccessor.
- return None
-
def UpdateDescriptionRemote(self, description):
"""Update the description on codereview site."""
raise NotImplementedError()
@@ -2112,9 +2107,6 @@
raise NotImplementedError()
return ThisIsNotRietveldIssue()
- def GetGerritObjForPresubmit(self):
- return presubmit_support.GerritAccessor(self._GetGerritHost())
-
def GetStatus(self):
"""Apply a rough heuristic to give a simple summary of an issue's review
or CQ status, assuming adherence to a common workflow.