commit 772efaf8bcd3ecadfabd961661a743f0ac14f8a4
author agable@chromium.org <agable@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> Tue Apr 01 02:35:44 2014 +0000
committer agable@chromium.org <agable@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> Tue Apr 01 02:35:44 2014 +0000
tree 5fa06fbbbeed6849051408a2a74c6fab10139918
parent 512d97d4124ce2af8e7bde6700628e188f73eb38

Use CheckCallAndFilterAndHeader for git commands.

This causes git commands to be completely silent (they don't even print
______ running 'git foo bar') if the git command itself is completely silent.
This mirrors the behavior of SVN commands. This is useful for commands like
'gclient diff', which should print no output at all if there is no diff.

R=szager@chromium.org, vadimsh@chromium.org

Review URL: https://codereview.chromium.org/218993009

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@260758 0039d316-1c4b-4281-b951-d872f2087c98

gclient_scm.py

diff --git a/gclient_scm.py b/gclient_scm.py
index fd098e2..0b10982 100644
--- a/gclient_scm.py
+++ b/gclient_scm.py
@@ -962,10 +962,8 @@
       env.setdefault('SSH_ASKPASS', 'true')
     else:
       kwargs.setdefault('print_stdout', True)
-    stdout = kwargs.get('stdout', sys.stdout)
-    stdout.write('\n________ running \'git %s\' in \'%s\'\n' % (
-                 ' '.join(args), kwargs['cwd']))
-    return gclient_utils.CheckCallAndFilter(['git'] + args, **kwargs)
+    cmd = ['git'] + args
+    return gclient_utils.CheckCallAndFilterAndHeader(cmd, **kwargs)
 
 
 class SVNWrapper(SCMWrapper):