commit 6fb14d906bf480a2e6aafe682fcf5a800c3ff39c
author maruel@chromium.org <maruel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> Tue Sep 27 00:12:49 2011 +0000
committer maruel@chromium.org <maruel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> Tue Sep 27 00:12:49 2011 +0000
tree 303e23139aedb5f5c7d873ebfb8a4e0627b1a250
parent 7af6c4dc8092362d609338fec88141b3ef8fda51

Revert r102783 "Support for |change| argument to |GetPreferredTrySlaves()|."

Cause an infinite recursion in some context.

TBR=asvitkine@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/8036046

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@102836 0039d316-1c4b-4281-b951-d872f2087c98

git_cl.py

diff --git a/git_cl.py b/git_cl.py
index 9946999..cb33488 100755
--- a/git_cl.py
+++ b/git_cl.py
@@ -488,7 +488,8 @@
       self.SetPatchset(0)
     self.has_issue = False
 
-  def GetChange(self, upstream_branch, author):
+  def RunHook(self, committing, upstream_branch, may_prompt, verbose, author):
+    """Calls sys.exit() if the hook fails; returns a HookResults otherwise."""
     root = RunCommand(['git', 'rev-parse', '--show-cdup']).strip() or '.'
     absroot = os.path.abspath(root)
 
@@ -510,7 +511,7 @@
 
     if not author:
       author = RunGit(['config', 'user.email']).strip() or None
-    return presubmit_support.GitChange(
+    change = presubmit_support.GitChange(
         name,
         description,
         absroot,
@@ -519,10 +520,6 @@
         patchset,
         author)
 
-  def RunHook(self, committing, upstream_branch, may_prompt, verbose, author):
-    """Calls sys.exit() if the hook fails; returns a HookResults otherwise."""
-    change = self.GetChange(upstream_branch, author)
-
     # Apply watchlists on upload.
     if not committing:
       watchlist = watchlists.Watchlists(change.RepositoryRoot())