commit 6b98cdcbc133ec6902e84da64617560b33f9febc
author Joanna Wang <jojwang@chromium.org> Thu Feb 16 00:37:20 2023 +0000
committer LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Feb 16 00:37:20 2023 +0000
tree 0fd07e698f4961eb5afc8c3c0eea336eefa59181
parent 78db5133598c97f18693b52e9472dd41137674a9

Check for detached HEAD state.

Bug: 1416683
Change-Id: I538715d05170662001ac7193a86dbd2e7f50e3f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4258505
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Auto-Submit: Joanna Wang <jojwang@chromium.org>

git_cl.py

diff --git a/git_cl.py b/git_cl.py
index 29c0326..bc6046b 100755
--- a/git_cl.py
+++ b/git_cl.py
@@ -4908,6 +4908,10 @@
       since their last upload and a boolean of whether the user wants to
       cherry-pick and upload the current branch instead of uploading all cls.
   """
+  cl = Changelist()
+  if cl.GetBranch() is None:
+    DieWithError('Can\'t upload from detached HEAD state. Get on a branch!')
+
   branch_ref = None
   cls = []
   must_upload_upstream = False