commit 650f853ced2d5f740eb6e4a80edbf0d09351d10e
author Josip Sokcevic <sokcevic@google.com> Fri Oct 15 18:35:31 2021 +0000
committer LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Oct 15 18:35:31 2021 +0000
tree b3cc2f8aa860e3360c62ce9fa9736873c8583848
parent 3e50cf453e79d262fed2b9ff59b8c82cb86c3e3f

Disable print for git for-each-ref in git_cache

The command is used for verification purposes when git index is fetched
from GS. The output is verbose for chromium/src and not useful at all.

R=gavinmak@google.com

Bug: 1255228
Change-Id: Ie95963a23ef397e9fd6ce7bcf959ec9964d21ba7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3227145
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>

git_cache.py

diff --git a/git_cache.py b/git_cache.py
index 786546c..1240f2f 100755
--- a/git_cache.py
+++ b/git_cache.py
@@ -231,11 +231,12 @@
         name='rename [%s] => [%s]' % (src, dst),
         printerr=self.print)
 
-  def RunGit(self, cmd, **kwargs):
+  def RunGit(self, cmd, print_stdout=True, **kwargs):
     """Run git in a subprocess."""
     cwd = kwargs.setdefault('cwd', self.mirror_path)
     kwargs.setdefault('print_stdout', False)
-    kwargs.setdefault('filter_fn', self.print)
+    if print_stdout:
+      kwargs.setdefault('filter_fn', self.print)
     env = kwargs.get('env') or kwargs.setdefault('env', os.environ.copy())
     env.setdefault('GIT_ASKPASS', 'true')
     env.setdefault('SSH_ASKPASS', 'true')
@@ -320,7 +321,7 @@
       # Set HEAD to main.
       self.RunGit(['symbolic-ref', 'HEAD', 'refs/heads/main'], cwd=tempdir)
       # A quick validation that all references are valid.
-      self.RunGit(['for-each-ref'], cwd=tempdir)
+      self.RunGit(['for-each-ref'], print_stdout=False, cwd=tempdir)
     except Exception as e:
       self.print('Encountered error: %s' % str(e), file=sys.stderr)
       gclient_utils.rmtree(tempdir)