Use exit code 130 for keyboard interrupts
Interrupting is reported with exit_code 1 in metrics and makes it harder
to determine if a user canceled git cl.
Change-Id: I99f35378dcf02cffa39a05317651fcd2c6a0b520
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4684512
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Gavin Mak <gavinmak@google.com>
diff --git a/metrics_utils.py b/metrics_utils.py
index e7ba2be..4af7eb3 100644
--- a/metrics_utils.py
+++ b/metrics_utils.py
@@ -219,8 +219,11 @@
"""Returns the exit code that would result of raising the exception."""
if exception is None:
return 0
- if isinstance(exception[1], SystemExit):
- return exception[1].code
+ e = exception[1]
+ if isinstance(e, KeyboardInterrupt):
+ return 130
+ if isinstance(e, SystemExit):
+ return e.code
return 1