Require certifi package and python3 in my_activity
my_activity.py talks to third party (e.g. review.coreboot.org). Without
certifi package, making https connection may result in
CERTIFICATE_VERIFY_FAILED.
Adding certifi package to .vpython (py2) doesn't work, so this change
drops py2 support for my_activity.py.
R=gavinmak@google.com
Fixed: 1255921
Change-Id: I515b14c81d37a52d482d08085d8029c791911ae8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3206906
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 7aba7c6..c4c166c 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -91,14 +91,15 @@
test_to_run_list = [r'.*test\.py$']
if input_api.platform.startswith(('cygwin', 'win32')):
print('Warning: skipping most unit tests on Windows')
- tests_to_skip_list = [
+ tests_to_skip_list.extend([
r'.*auth_test\.py$',
r'.*git_common_test\.py$',
r'.*git_hyper_blame_test\.py$',
r'.*git_map_test\.py$',
r'.*ninjalog_uploader_test\.py$',
r'.*recipes_test\.py$',
- ]
+ ])
+ tests_to_skip_list.append(r'.*my_activity_test\.py')
# TODO(maruel): Make sure at least one file is modified first.
# TODO(maruel): If only tests are modified, only run them.
@@ -111,6 +112,13 @@
files_to_skip=tests_to_skip_list,
run_on_python3=False))
+ tests.extend(input_api.canned_checks.GetUnitTestsInDirectory(
+ input_api,
+ output_api,
+ 'tests',
+ files_to_check=[r'.*my_activity_test\.py'],
+ run_on_python3=True))
+
# Validate CIPD manifests.
root = input_api.os_path.normpath(
input_api.os_path.abspath(input_api.PresubmitLocalPath()))