commit 3c74bc9df5c5fed285f268272d0ac88ad35e33bc
author maruel@chromium.org <maruel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> Thu Sep 15 19:17:21 2011 +0000
committer maruel@chromium.org <maruel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> Thu Sep 15 19:17:21 2011 +0000
tree d4932fddc7a466572529d70b6610ed3801695bba
parent fae707be998a04450417780fd4dd31516d5922ea

Fix member lookup to be more stable.

Add regression test.

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7891061

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@101351 0039d316-1c4b-4281-b951-d872f2087c98

gclient.py

diff --git a/gclient.py b/gclient.py
index f568662..c038738 100644
--- a/gclient.py
+++ b/gclient.py
@@ -585,11 +585,15 @@
   def __str__(self):
     out = []
     for i in ('name', 'url', 'parsed_url', 'safesync_url', 'custom_deps',
-              'custom_vars', 'deps_hooks', '_file_list', 'should_process',
+              'custom_vars', 'deps_hooks', 'file_list', 'should_process',
               'processed', 'hooks_ran', 'deps_parsed', 'requirements'):
-      # 'deps_file'
-      if self.__dict__[i]:
-        out.append('%s: %s' % (i, self.__dict__[i]))
+      # First try the native property if it exists.
+      if hasattr(self, '_' + i):
+        value = getattr(self, '_' + i, False)
+      else:
+        value = getattr(self, i, False)
+      if value:
+        out.append('%s: %s' % (i, value))
 
     for d in self.dependencies:
       out.extend(['  ' + x for x in str(d).splitlines()])