commit 38436920198bdb1586c84e557bd003a62ec84601
author mhm@chromium.org <mhm@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> Sat Mar 12 03:18:13 2011 +0000
committer mhm@chromium.org <mhm@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> Sat Mar 12 03:18:13 2011 +0000
tree bd20d2c0543ab4b75e235f872904089408054bef
parent 3d4d7edc3da7895ebe7f2c7da5a1714c2da50c2b

Regression: Editor Linux Fix for gcl.

Editor doesn't come up due to Shell=True

BUG=none
TEST=linux and win works
Review URL: http://codereview.chromium.org/6679023

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77913 0039d316-1c4b-4281-b951-d872f2087c98

git_cl/git_cl.py

diff --git a/git_cl/git_cl.py b/git_cl/git_cl.py
index 80329cb..e1e73b6 100644
--- a/git_cl/git_cl.py
+++ b/git_cl/git_cl.py
@@ -710,9 +710,8 @@
   fileobj.write(starting_text)
   fileobj.close()
 
-  result = None
   try:
-    subprocess.check_call(['env', editor, filename], shell=True)
+    subprocess.check_call(['env', editor, filename])
     fileobj = open(filename)
     result = fileobj.read()
     fileobj.close()