Revert of Add CC_LIST and --cc to Gerrit issues via API to be similar to CCs in Rietveld (patchset #4 id:60001 of https://codereview.chromium.org/2378703002/ )
Reason for revert:
Actually, it doesn't break uploads, add cc-ed emails post-upload fails with exception and confuses users, and I couldn't find workaround.
Original issue's description:
> Add CC_LIST and --cc to Gerrit issues via API to be similar to CCs in Rietveld
>
> BUG=chromium:649660
>
> Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/3574740929abd37c45db1d2f8a2c3799bdfe77c5
TBR=rmistry@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:649660
Review-Url: https://codereview.chromium.org/2375393002
diff --git a/git_cl.py b/git_cl.py
index bbb8edf..133713b 100755
--- a/git_cl.py
+++ b/git_cl.py
@@ -2618,6 +2618,13 @@
else:
refspec_opts.append('notify=NONE')
+ cc = self.GetCCList().split(',')
+ if options.cc:
+ cc.extend(options.cc)
+ cc = filter(None, cc)
+ if cc:
+ refspec_opts.extend('cc=' + email.strip() for email in cc)
+
reviewers = change_desc.get_reviewers()
if reviewers:
refspec_opts.extend('r=' + email.strip() for email in reviewers)
@@ -2655,16 +2662,6 @@
'Change-Id: %s') % (len(change_numbers), change_id))
self.SetIssue(change_numbers[0])
self._GitSetBranchConfigValue('gerritsquashhash', ref_to_push)
-
- # Add cc's from the CC_LIST and --cc flag (if any).
- cc = self.GetCCList().split(',')
- if options.cc:
- cc.extend(options.cc)
- cc = filter(None, cc)
- if cc:
- gerrit_util.AddReviewers(
- self._GetGerritHost(), self.GetIssue(), cc, is_reviewer=False)
-
return 0
def _AddChangeIdToCommitMessage(self, options, args):