commit 2a471073e87fae58baee203054b1fae3fbcd3ebf
author maruel@chromium.org <maruel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> Tue May 10 17:29:23 2011 +0000
committer maruel@chromium.org <maruel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> Tue May 10 17:29:23 2011 +0000
tree 4cd2a296b46eb6eb036bd7fcaf45a0ca277fb1e1
parent b1ce775c2969228596ac9b1a57532ea373e8e26b

Make gcl and git-cl don't throw when a vim user does :cg

That's just noise for the maintainer.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6985002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@84803 0039d316-1c4b-4281-b951-d872f2087c98

git_cl.py

diff --git a/git_cl.py b/git_cl.py
index 9e1124c..5cf2580 100755
--- a/git_cl.py
+++ b/git_cl.py
@@ -842,7 +842,10 @@
       # Msysgit requires the usage of 'env' to be present.
       cmd = 'env ' + cmd
     # shell=True to allow the shell to handle all forms of quotes in $EDITOR.
-    subprocess.check_call(cmd, shell=True)
+    try:
+      subprocess.check_call(cmd, shell=True)
+    except subprocess.CalledProcessError, e:
+      DieWithError('Editor returned %d' % e.returncode)
     fileobj = open(filename)
     text = fileobj.read()
     fileobj.close()