Fix bug with parsing capitalized git shas
Fix identification of shas that contain capitalized
hexadecimal characters. Addresses comments from
http://crrev.com/18262002/
R=maruel@chromium.org
Review URL: https://chromiumcodereview.appspot.com/18292005
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@210429 0039d316-1c4b-4281-b951-d872f2087c98
diff --git a/scm.py b/scm.py
index 8810c2a..5e72464 100644
--- a/scm.py
+++ b/scm.py
@@ -454,12 +454,12 @@
if re.match(r'^[0-9a-fA-F]{40}$', rev):
lookup_rev = rev[:-1]
try:
- sha = GIT.Capture(['rev-parse', lookup_rev], cwd=cwd)
+ sha = GIT.Capture(['rev-parse', lookup_rev], cwd=cwd).lower()
if lookup_rev != rev:
# Make sure we get the original 40 chars back.
- return rev == sha
+ return rev.lower() == sha
if sha_only:
- return sha.startswith(rev)
+ return sha.startswith(rev.lower())
return True
except subprocess2.CalledProcessError:
return False