commit 1344a3c9989dfe11d7dbe2a994d50a211ac23301
author Xinan Lin <linxinan@google.com> Tue May 02 21:55:43 2023 +0000
committer LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue May 02 21:55:43 2023 +0000
tree a1c3cb99f20982956c303296784a5a157ede9ae9
parent 13878e1f729d01c7215590e0d8b5beb5851fe126

Add global 300s global timeout for Gerrit API calls

This will not impact the calls which have explicit timeout.
For the rest, either PUT or POST or DELETE methods, 5 min should
suffice.

Fixed: 1441863
TEST=NA

Change-Id: I235bc60344b6981eb3d96930ca8b6463129a2be2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4495994
Commit-Queue: Xinan Lin <linxinan@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>

gerrit_util.py

diff --git a/gerrit_util.py b/gerrit_util.py
index a8b04ad..eb30807 100644
--- a/gerrit_util.py
+++ b/gerrit_util.py
@@ -380,7 +380,7 @@
                    reqtype='GET',
                    headers=None,
                    body=None,
-                   timeout=None):
+                   timeout=300):
   """Opens an HTTPS connection to a Gerrit service, and sends a request."""
   headers = headers or {}
   bare_host = host.partition(':')[0]