commit 0bcd1d343059104a979ceb68abe139cd48bc7a06
author maruel@chromium.org <maruel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> Tue Apr 26 15:55:49 2011 +0000
committer maruel@chromium.org <maruel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> Tue Apr 26 15:55:49 2011 +0000
tree f6b088edc252c649fc9032ff315666a27662d795
parent 6f323bbad2e5f1f2a1febf8225f558e6e23b9c75

Make subprocess2.check_call() compliant with subprocess.check_call().

Rename check_call to check_call_out. It's a quite specific need when stderr is
needed or when the user doesn't want the default arguments of check_output.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6882127

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@83023 0039d316-1c4b-4281-b951-d872f2087c98

checkout.py

diff --git a/checkout.py b/checkout.py
index ab449b4..38c269a 100644
--- a/checkout.py
+++ b/checkout.py
@@ -191,7 +191,8 @@
     """Runs svn and throws an exception if the command failed."""
     kwargs.setdefault('cwd', self.project_path)
     kwargs.setdefault('stdout', self.VOID)
-    return subprocess2.check_call(self._add_svn_flags(args, False), **kwargs)
+    return subprocess2.check_call_out(
+        self._add_svn_flags(args, False), **kwargs)
 
   def _check_output_svn(self, args, **kwargs):
     """Runs svn and throws an exception if the command failed.
@@ -429,7 +430,7 @@
   def _check_call_git(self, args, **kwargs):
     kwargs.setdefault('cwd', self.project_path)
     kwargs.setdefault('stdout', self.VOID)
-    return subprocess2.check_call(['git'] + args, **kwargs)
+    return subprocess2.check_call_out(['git'] + args, **kwargs)
 
   def _call_git(self, args, **kwargs):
     """Like check_call but doesn't throw on failure."""