commit a3fcc000cb7bd5b12816512834e6484c68658576
author dan <dan@noemail.net> Thu Aug 15 13:53:22 2019 +0000
committer dan <dan@noemail.net> Thu Aug 15 13:53:22 2019 +0000
tree 4120e7f003a337ceab43adeaf2800683143224af
parent d4da4936cdfaf5647d9daf0b861b2e63969a810d

Ensure that SQLite does not attempt to process incompatible window functions in a single scan. Fix for [256741a1].

FossilOrigin-Name: 4f5b2d938194fab7627486e2ced633def2c90d9d3328e3700612feb9dbfa3d9a

src/resolve.c

diff --git a/src/resolve.c b/src/resolve.c
index d88abc4..3160038 100644
--- a/src/resolve.c
+++ b/src/resolve.c
@@ -908,16 +908,7 @@
           sqlite3WalkExprList(pWalker, pWin->pPartition);
           sqlite3WalkExprList(pWalker, pWin->pOrderBy);
           sqlite3WalkExpr(pWalker, pWin->pFilter);
-          if( 0==pSel->pWin 
-           || 0==sqlite3WindowCompare(pParse, pSel->pWin, pWin, 0)
-          ){
-            pWin->pNextWin = pSel->pWin;
-            if( pSel->pWin ){
-              pSel->pWin->ppThis = &pWin->pNextWin;
-            }
-            pSel->pWin = pWin;
-            pWin->ppThis = &pSel->pWin;
-          }
+          sqlite3WindowLink(pSel, pWin);
           pNC->ncFlags |= NC_HasWin;
         }else
 #endif /* SQLITE_OMIT_WINDOWFUNC */