commit 89b6de0357a499209c13cf66a3cc406f26f67e6f
author drh <drh@noemail.net> Wed Dec 12 20:11:23 2018 +0000
committer drh <drh@noemail.net> Wed Dec 12 20:11:23 2018 +0000
tree 23e55dc342d8c4cf216b348a0bc7df30009ab5a8
parent 03c5c213289baed1f809d3e58dee1e2abfb72f2b

Remove an ALWAYS() from a branch that is not always taken.  The test case
found by OSSFuzz has been added to TH3.

FossilOrigin-Name: 5c7dab85535ac42c021977dbd4a39cef5a72e3d9dccff1c5ca5570a1780516cd

src/expr.c

diff --git a/src/expr.c b/src/expr.c
index dc6f033..b4d1014 100644
--- a/src/expr.c
+++ b/src/expr.c
@@ -4778,7 +4778,7 @@
     }
   }
   if( (pA->flags & EP_Distinct)!=(pB->flags & EP_Distinct) ) return 2;
-  if( ALWAYS((combinedFlags & EP_TokenOnly)==0) ){
+  if( (combinedFlags & EP_TokenOnly)==0 ){
     if( combinedFlags & EP_xIsSelect ) return 2;
     if( (combinedFlags & EP_FixedCol)==0
      && sqlite3ExprCompare(pParse, pA->pLeft, pB->pLeft, iTab) ) return 2;